12020-09-25T00:00:02  *** patryk has quit IRC
  22020-09-25T00:00:35  *** DeanGuss has quit IRC
  32020-09-25T00:06:17  *** DeanGuss has joined #bitcoin-core-dev
  42020-09-25T00:11:47  *** Cory has quit IRC
  52020-09-25T00:18:32  *** Cory has joined #bitcoin-core-dev
  62020-09-25T00:21:40  *** zerstoerer has joined #bitcoin-core-dev
  72020-09-25T00:24:00  *** syperf has joined #bitcoin-core-dev
  82020-09-25T00:31:48  *** AaronvanW has quit IRC
  92020-09-25T00:36:36  *** syperf has quit IRC
 102020-09-25T01:07:45  *** Emcy has quit IRC
 112020-09-25T01:07:57  *** Emcy_ has joined #bitcoin-core-dev
 122020-09-25T01:09:21  *** AaronvanW has joined #bitcoin-core-dev
 132020-09-25T01:14:46  *** AaronvanW has quit IRC
 142020-09-25T01:16:50  *** AaronvanW has joined #bitcoin-core-dev
 152020-09-25T01:21:15  *** instagibbs has quit IRC
 162020-09-25T01:22:01  *** instagibbs has joined #bitcoin-core-dev
 172020-09-25T01:26:00  *** promag_ has joined #bitcoin-core-dev
 182020-09-25T01:26:00  *** promag has quit IRC
 192020-09-25T01:38:22  <roconnor> I managed to rebuild my desktop with gcc 8.  elichai2 let me know how it goes with clang.  I'm worried a lot of packages won't build.
 202020-09-25T01:39:16  <roconnor> luke-jr: real_or_random showed me a link to https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/builtins.c;h=eb662112b32e5ad377d2a865d9977c64dc12cc93;hb=eb662112b32e5ad377d2a865d9977c64dc12cc93#l539 earlier which looked horrifying because it looks like the bug might have affected it.
 212020-09-25T01:39:45  <roconnor> and it is used in string_length, which is used in c_strlen, which is something that is possibly related to the bug itself.
 222020-09-25T01:40:09  <roconnor> that all said, sipa seems to have noticed that memcmp being compared with 0 doesn't seem to tickle this bug.
 232020-09-25T01:40:23  <roconnor> which explains to me how it is possible that not every single piece of software is broken.
 242020-09-25T01:40:37  <roconnor> I expect memcmp is very often compared with 0.
 252020-09-25T01:41:05  <sipa> having read the code: that's exactly it
 262020-09-25T01:41:25  <roconnor> oh you understand the gcc code and the bug?
 272020-09-25T01:42:27  *** EagleTM has joined #bitcoin-core-dev
 282020-09-25T01:42:47  <sipa> not the bug
 292020-09-25T01:43:25  *** Eagle[TM] has quit IRC
 302020-09-25T01:43:42  <sipa> but there is a flag passed to expand_builtin_memcmp for the case where the sign of the return value of memcmp doesn't matter (for == and != cases)
 312020-09-25T01:43:45  <luke-jr> roconnor: why wouldn't anything build? O.o
 322020-09-25T01:43:46  <sipa> which has a separate code path
 332020-09-25T01:44:39  <luke-jr> sipa: is the fix then "fixing" things that aren't broken?
 342020-09-25T01:46:29  <sipa> luke-jr: no?
 352020-09-25T01:47:49  <roconnor> luke-jr: you mean with clang?  I sort of expect a handful of packages to use gcc specfic features.
 362020-09-25T01:47:52  <roconnor> But what do I know.
 372020-09-25T01:56:03  <roconnor> I'll give building everything with clang a try and see how it goes.
 382020-09-25T01:57:10  *** Zhonghua has joined #bitcoin-core-dev
 392020-09-25T01:59:08  *** MrPaz has quit IRC
 402020-09-25T01:59:40  <luke-jr> oh, I meant GCC 8
 412020-09-25T02:00:15  *** kexkey has joined #bitcoin-core-dev
 422020-09-25T02:02:01  *** S3RK has joined #bitcoin-core-dev
 432020-09-25T02:02:52  <roconnor> luke-jr: appstreamer-qt added a -Wno-error=deprecated-copy flag which doesn't exist on GCC 8.
 442020-09-25T02:03:05  <roconnor> luke-jr: and nix3.0pre seems to have gone all in on C++20 features.
 452020-09-25T02:03:41  <luke-jr> surprised Nix lets you change the compiler just like that in the first place :o
 462020-09-25T02:03:54  <roconnor> what do you mean?
 472020-09-25T02:04:03  <luke-jr> well, Guix was refusing to let me use my existing system compiler to bootstrap
 482020-09-25T02:04:24  <sipa> does the linux kernel use any memcmp?
 492020-09-25T02:04:31  <roconnor> also llvm 9.0.1 seems to have a test case that fails when built with gcc 8.  that ones seems weird.
 502020-09-25T02:04:34  <luke-jr> sipa: yes, even __builtin_memcmp :/
 512020-09-25T02:04:50  <luke-jr> sipa: I'm afraid to build with my hacked GCC 9.3
 522020-09-25T02:05:13  <luke-jr> (in case it depends on the builtin for cases where there's no libc)
 532020-09-25T02:07:42  *** AaronvanW has quit IRC
 542020-09-25T02:08:17  <roconnor> luke-jr: https://gist.github.com/roconnor/2b8e22e829ed80088ed6690cc3c7f3a8 is my nix overlay that is sufficent to purge gcc 9 from my system.
 552020-09-25T02:09:33  <fanquake> MarcoFalke: FYI the bot seems to have run out of disk: https://github.com/bitcoin/bitcoin/pull/19868#issuecomment-698680164
 562020-09-25T02:09:37  <roconnor> But I think I want to try again with a bug patched version of gcc 10.
 572020-09-25T02:13:42  <roconnor> luke-jr: in an ideal world the overly would just be gcc = self.gcc8.  But unfortunately it isn't quite as easy as it should be.  I need to switch gfortan which openblas uses, and this weird gccFun thing seems to be requires to build nix itself with gcc 8, etc.
 582020-09-25T02:37:32  *** lizhonghua_ has joined #bitcoin-core-dev
 592020-09-25T02:39:17  *** justanotheruser has quit IRC
 602020-09-25T02:41:06  *** davterra has joined #bitcoin-core-dev
 612020-09-25T02:49:20  *** lizhonghua_ has quit IRC
 622020-09-25T02:56:19  *** lizhonghua__ has joined #bitcoin-core-dev
 632020-09-25T03:00:02  *** zerstoerer has quit IRC
 642020-09-25T03:05:46  *** S3RK has quit IRC
 652020-09-25T03:06:53  *** Zhonghua has quit IRC
 662020-09-25T03:15:24  *** justanotheruser has joined #bitcoin-core-dev
 672020-09-25T03:17:40  *** GankMove has joined #bitcoin-core-dev
 682020-09-25T03:20:14  *** Highway62 has joined #bitcoin-core-dev
 692020-09-25T03:20:19  *** Highway61 has quit IRC
 702020-09-25T03:20:19  *** Highway62 is now known as Highway61
 712020-09-25T03:22:34  *** bpalmer1 has joined #bitcoin-core-dev
 722020-09-25T03:22:59  *** GankMove- has joined #bitcoin-core-dev
 732020-09-25T03:23:42  *** GankMove has quit IRC
 742020-09-25T03:23:43  *** GankMove- has quit IRC
 752020-09-25T03:26:53  *** niftynei has quit IRC
 762020-09-25T03:27:09  *** niftynei has joined #bitcoin-core-dev
 772020-09-25T03:34:57  *** justan0theruser has joined #bitcoin-core-dev
 782020-09-25T03:36:42  *** justanotheruser has quit IRC
 792020-09-25T03:52:13  *** tralfaz has joined #bitcoin-core-dev
 802020-09-25T03:53:01  *** davterra has quit IRC
 812020-09-25T03:53:08  *** tralfaz is now known as davterra
 822020-09-25T04:03:58  *** lizhonghua_ has joined #bitcoin-core-dev
 832020-09-25T04:04:28  *** AaronvanW has joined #bitcoin-core-dev
 842020-09-25T04:06:12  *** lizhonghua__ has quit IRC
 852020-09-25T04:13:16  *** promag has joined #bitcoin-core-dev
 862020-09-25T04:13:16  *** promag_ has quit IRC
 872020-09-25T04:16:22  *** S3RK has joined #bitcoin-core-dev
 882020-09-25T04:22:09  *** promag has quit IRC
 892020-09-25T04:22:22  *** promag has joined #bitcoin-core-dev
 902020-09-25T04:22:43  *** S3RK has quit IRC
 912020-09-25T04:26:37  *** promag_ has joined #bitcoin-core-dev
 922020-09-25T04:27:09  *** promag_ has quit IRC
 932020-09-25T04:28:17  *** promag_ has joined #bitcoin-core-dev
 942020-09-25T04:28:58  *** promag has quit IRC
 952020-09-25T04:36:45  *** AaronvanW has quit IRC
 962020-09-25T04:37:28  *** jonatack has quit IRC
 972020-09-25T04:50:20  *** S3RK has joined #bitcoin-core-dev
 982020-09-25T04:57:31  *** S3RK_ has joined #bitcoin-core-dev
 992020-09-25T05:00:25  *** S3RK has quit IRC
1002020-09-25T05:04:16  *** S3RK_ has quit IRC
1012020-09-25T05:04:29  *** S3RK has joined #bitcoin-core-dev
1022020-09-25T05:11:55  *** proofofkeags has quit IRC
1032020-09-25T05:15:08  *** andreacab has joined #bitcoin-core-dev
1042020-09-25T05:17:27  *** bpalmer1 has quit IRC
1052020-09-25T05:18:10  *** andreacab has quit IRC
1062020-09-25T05:18:36  *** andreacab has joined #bitcoin-core-dev
1072020-09-25T05:25:13  *** andreacab has quit IRC
1082020-09-25T05:32:47  *** schmichael1 has joined #bitcoin-core-dev
1092020-09-25T05:39:40  *** S3RK has quit IRC
1102020-09-25T05:40:07  *** S3RK has joined #bitcoin-core-dev
1112020-09-25T05:49:38  *** Victorsueca has joined #bitcoin-core-dev
1122020-09-25T05:53:29  *** S3RK has quit IRC
1132020-09-25T05:53:57  *** S3RK has joined #bitcoin-core-dev
1142020-09-25T05:55:16  *** andreacab has joined #bitcoin-core-dev
1152020-09-25T05:55:26  *** S3RK has joined #bitcoin-core-dev
1162020-09-25T05:55:33  *** justan0theruser has quit IRC
1172020-09-25T06:00:01  *** schmichael1 has quit IRC
1182020-09-25T06:01:00  *** braydonf has quit IRC
1192020-09-25T06:01:26  *** braydonf has joined #bitcoin-core-dev
1202020-09-25T06:16:48  *** Victorsueca has quit IRC
1212020-09-25T06:20:35  *** tool8 has joined #bitcoin-core-dev
1222020-09-25T06:23:44  *** Victorsueca has joined #bitcoin-core-dev
1232020-09-25T06:28:47  *** Victorsueca has quit IRC
1242020-09-25T06:34:30  *** AaronvanW has joined #bitcoin-core-dev
1252020-09-25T06:40:47  *** lizhonghua_ has quit IRC
1262020-09-25T06:43:01  *** Zhonghua has joined #bitcoin-core-dev
1272020-09-25T06:44:10  *** andreacab has quit IRC
1282020-09-25T06:44:16  *** andreacab has joined #bitcoin-core-dev
1292020-09-25T07:03:13  *** Zhonghua has quit IRC
1302020-09-25T07:03:30  *** Zhonghua has joined #bitcoin-core-dev
1312020-09-25T07:04:56  *** balbirs has quit IRC
1322020-09-25T07:05:41  *** balbirs has joined #bitcoin-core-dev
1332020-09-25T07:07:52  *** AaronvanW has quit IRC
1342020-09-25T07:10:03  *** yanmaani has quit IRC
1352020-09-25T07:12:44  *** lizhonghua_ has joined #bitcoin-core-dev
1362020-09-25T07:13:01  *** Zhonghua has quit IRC
1372020-09-25T07:13:41  *** andreacab has quit IRC
1382020-09-25T07:14:07  *** andreacab has joined #bitcoin-core-dev
1392020-09-25T07:18:07  *** lizhonghua_ has quit IRC
1402020-09-25T07:18:35  *** andreacab has quit IRC
1412020-09-25T07:19:29  *** kristapsk has quit IRC
1422020-09-25T07:20:03  *** marcoagner has joined #bitcoin-core-dev
1432020-09-25T07:20:50  *** Zhonghua has joined #bitcoin-core-dev
1442020-09-25T07:23:16  *** S3RK has quit IRC
1452020-09-25T07:23:45  *** S3RK has joined #bitcoin-core-dev
1462020-09-25T07:24:46  *** tralfaz has joined #bitcoin-core-dev
1472020-09-25T07:25:14  *** S3RK has joined #bitcoin-core-dev
1482020-09-25T07:26:05  *** yanmaani has joined #bitcoin-core-dev
1492020-09-25T07:26:51  *** davterra has quit IRC
1502020-09-25T07:29:01  *** bitcoin-git has joined #bitcoin-core-dev
1512020-09-25T07:29:01  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20012: rpc: Remove duplicate name and argNames from CRPCCommand (master...2009-rpcCheckMapping) https://github.com/bitcoin/bitcoin/pull/20012
1522020-09-25T07:29:01  *** bitcoin-git has left #bitcoin-core-dev
1532020-09-25T07:33:33  *** andreacab has joined #bitcoin-core-dev
1542020-09-25T07:35:02  *** Zhonghua has quit IRC
1552020-09-25T07:36:40  *** lizhonghua_ has joined #bitcoin-core-dev
1562020-09-25T07:46:57  *** S3RK has quit IRC
1572020-09-25T07:47:06  *** S3RK has joined #bitcoin-core-dev
1582020-09-25T07:48:25  *** marcoagner has quit IRC
1592020-09-25T07:51:12  *** kljasdfvv has quit IRC
1602020-09-25T07:52:56  *** kljasdfvv has joined #bitcoin-core-dev
1612020-09-25T07:53:26  *** andreacab has quit IRC
1622020-09-25T07:53:49  *** andreacab has joined #bitcoin-core-dev
1632020-09-25T07:56:32  *** promag_ has quit IRC
1642020-09-25T07:56:47  *** promag has joined #bitcoin-core-dev
1652020-09-25T07:57:54  *** andreacab has quit IRC
1662020-09-25T07:58:20  *** andreacab has joined #bitcoin-core-dev
1672020-09-25T07:59:55  *** andreacab has quit IRC
1682020-09-25T08:00:03  *** andreacab has joined #bitcoin-core-dev
1692020-09-25T08:06:14  *** Highway61 has quit IRC
1702020-09-25T08:18:57  *** bitcoin-git has joined #bitcoin-core-dev
1712020-09-25T08:18:57  <bitcoin-git> [bitcoin] kallewoof opened pull request #20013: rpc: normalize parameter names (master...202009-rpc-normalize) https://github.com/bitcoin/bitcoin/pull/20013
1722020-09-25T08:18:58  *** bitcoin-git has left #bitcoin-core-dev
1732020-09-25T08:20:21  *** andreacab has quit IRC
1742020-09-25T08:20:47  *** andreacab has joined #bitcoin-core-dev
1752020-09-25T08:25:43  *** andreacab has quit IRC
1762020-09-25T08:26:07  *** lizhonghua__ has joined #bitcoin-core-dev
1772020-09-25T08:26:22  *** lizhonghua_ has quit IRC
1782020-09-25T08:26:25  *** bitcoin-git has joined #bitcoin-core-dev
1792020-09-25T08:26:26  <bitcoin-git> [bitcoin] kallewoof closed pull request #19957: rpc: alias helper (master...202009-rpc-alias) https://github.com/bitcoin/bitcoin/pull/19957
1802020-09-25T08:26:26  *** bitcoin-git has left #bitcoin-core-dev
1812020-09-25T08:33:31  *** andreacab has joined #bitcoin-core-dev
1822020-09-25T08:35:07  *** lizhonghua__ has quit IRC
1832020-09-25T08:39:34  *** Zhonghua has joined #bitcoin-core-dev
1842020-09-25T08:41:01  *** andreacab has quit IRC
1852020-09-25T08:42:10  *** mrostecki has joined #bitcoin-core-dev
1862020-09-25T08:48:05  *** ghost43 has quit IRC
1872020-09-25T08:48:25  *** ghost43 has joined #bitcoin-core-dev
1882020-09-25T08:52:30  *** AaronvanW has joined #bitcoin-core-dev
1892020-09-25T08:54:05  *** andreacab has joined #bitcoin-core-dev
1902020-09-25T08:54:23  *** S3RK has quit IRC
1912020-09-25T08:54:54  *** S3RK has joined #bitcoin-core-dev
1922020-09-25T08:55:41  *** andreacab has quit IRC
1932020-09-25T08:56:49  *** GankMove has joined #bitcoin-core-dev
1942020-09-25T08:56:54  *** GankMove- has joined #bitcoin-core-dev
1952020-09-25T08:59:37  *** Zhonghua has quit IRC
1962020-09-25T09:00:02  *** tool8 has quit IRC
1972020-09-25T09:00:17  *** andreacab has joined #bitcoin-core-dev
1982020-09-25T09:00:31  *** Zhonghua has joined #bitcoin-core-dev
1992020-09-25T09:04:06  *** mrostecki has joined #bitcoin-core-dev
2002020-09-25T09:04:40  *** kexkey has quit IRC
2012020-09-25T09:04:42  *** vasild has quit IRC
2022020-09-25T09:06:09  *** S3RK has quit IRC
2032020-09-25T09:06:36  *** S3RK has joined #bitcoin-core-dev
2042020-09-25T09:09:57  *** vasild has joined #bitcoin-core-dev
2052020-09-25T09:11:29  *** AaronvanW has quit IRC
2062020-09-25T09:11:47  *** AaronvanW has joined #bitcoin-core-dev
2072020-09-25T09:13:37  *** Zhonghua has quit IRC
2082020-09-25T09:18:08  *** lizhonghua_ has joined #bitcoin-core-dev
2092020-09-25T09:19:45  *** S3RK has quit IRC
2102020-09-25T09:20:13  *** S3RK has joined #bitcoin-core-dev
2112020-09-25T09:22:03  *** vladan1 has joined #bitcoin-core-dev
2122020-09-25T09:23:32  *** lizhonghua_ has quit IRC
2132020-09-25T09:23:51  *** Zhonghua has joined #bitcoin-core-dev
2142020-09-25T09:25:47  *** andreacab has quit IRC
2152020-09-25T09:26:14  *** andreacab has joined #bitcoin-core-dev
2162020-09-25T09:30:16  *** promag has quit IRC
2172020-09-25T09:30:32  *** andreacab has quit IRC
2182020-09-25T09:30:48  *** promag has joined #bitcoin-core-dev
2192020-09-25T09:32:01  *** andreacab has joined #bitcoin-core-dev
2202020-09-25T09:39:32  *** kristapsk has joined #bitcoin-core-dev
2212020-09-25T09:51:24  *** promag has quit IRC
2222020-09-25T09:51:42  *** promag has joined #bitcoin-core-dev
2232020-09-25T09:54:05  *** GankMove has quit IRC
2242020-09-25T09:54:28  *** GankMove has joined #bitcoin-core-dev
2252020-09-25T09:54:30  *** jonatack has joined #bitcoin-core-dev
2262020-09-25T09:54:33  *** GankMove- has joined #bitcoin-core-dev
2272020-09-25T09:54:44  *** GankMove has quit IRC
2282020-09-25T09:58:44  *** GankMove- has quit IRC
2292020-09-25T10:01:54  *** S3RK has quit IRC
2302020-09-25T10:02:04  *** S3RK has joined #bitcoin-core-dev
2312020-09-25T10:10:03  *** vasild has quit IRC
2322020-09-25T10:12:08  *** vasild has joined #bitcoin-core-dev
2332020-09-25T10:18:19  *** Imelda77Turcotte has joined #bitcoin-core-dev
2342020-09-25T10:18:45  *** jonatack has quit IRC
2352020-09-25T10:19:40  *** jonatack has joined #bitcoin-core-dev
2362020-09-25T10:28:55  *** andreacab has quit IRC
2372020-09-25T10:29:21  *** andreacab has joined #bitcoin-core-dev
2382020-09-25T10:29:50  *** andreaca_ has joined #bitcoin-core-dev
2392020-09-25T10:30:11  *** Imelda77Turcotte has quit IRC
2402020-09-25T10:32:31  *** S3RK has quit IRC
2412020-09-25T10:34:17  *** andreacab has quit IRC
2422020-09-25T10:34:55  *** andreaca_ has quit IRC
2432020-09-25T10:34:56  *** S3RK has joined #bitcoin-core-dev
2442020-09-25T10:35:26  *** S3RK has joined #bitcoin-core-dev
2452020-09-25T10:36:54  *** sr_gi has quit IRC
2462020-09-25T10:37:21  *** sr_gi has joined #bitcoin-core-dev
2472020-09-25T11:01:00  *** alko89 has quit IRC
2482020-09-25T11:01:16  *** alko89 has joined #bitcoin-core-dev
2492020-09-25T11:07:50  *** andreacab has joined #bitcoin-core-dev
2502020-09-25T11:08:59  *** adiabat has quit IRC
2512020-09-25T11:11:47  <hebasto> jonasschnelli: fanquake: begging review for https://github.com/bitcoin-core/gui/pull/46
2522020-09-25T11:13:13  *** S3RK has quit IRC
2532020-09-25T11:13:28  *** andreacab has quit IRC
2542020-09-25T11:16:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2552020-09-25T11:27:44  *** filchef has joined #bitcoin-core-dev
2562020-09-25T11:31:17  *** promag has quit IRC
2572020-09-25T11:32:18  *** promag has joined #bitcoin-core-dev
2582020-09-25T11:40:51  *** Zhonghua has quit IRC
2592020-09-25T11:41:16  *** Zhonghua has joined #bitcoin-core-dev
2602020-09-25T11:47:28  *** promag has quit IRC
2612020-09-25T11:47:45  *** promag has joined #bitcoin-core-dev
2622020-09-25T11:51:55  *** tralfaz has quit IRC
2632020-09-25T11:52:19  *** tralfaz has joined #bitcoin-core-dev
2642020-09-25T11:55:10  *** filchef has quit IRC
2652020-09-25T12:00:01  *** vladan1 has quit IRC
2662020-09-25T12:08:21  <elichai2> roconnor: what distribution do you use? I'm with archlinux and I don't know how to even start with "rebuilding" almost everything is prebuilt, and the kernel itself is prebuilt+signed (for the whole EFI security stuff)
2672020-09-25T12:08:39  <elichai2> roconnor: god that link looks terrifying
2682020-09-25T12:09:51  *** Guyver2 has joined #bitcoin-core-dev
2692020-09-25T12:10:29  *** EagleTM has quit IRC
2702020-09-25T12:10:30  *** promag has quit IRC
2712020-09-25T12:11:30  *** promag has joined #bitcoin-core-dev
2722020-09-25T12:20:01  *** bitcoin-git has joined #bitcoin-core-dev
2732020-09-25T12:20:02  <bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1b313cacc99a...78f912c9010f
2742020-09-25T12:20:03  <bitcoin-git> bitcoin/master 784f757 gzhao408: [refactor] clarify tests by referencing p2p objects directly
2752020-09-25T12:20:04  <bitcoin-git> bitcoin/master 7a0de46 gzhao408: [doc] sample code for test framework p2p objects
2762020-09-25T12:20:04  <bitcoin-git> bitcoin/master 549d30f gzhao408: scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx
2772020-09-25T12:20:06  *** bitcoin-git has left #bitcoin-core-dev
2782020-09-25T12:20:25  *** bitcoin-git has joined #bitcoin-core-dev
2792020-09-25T12:20:25  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #19804: test/refactor: reference p2p objects explicitly and remove confusing Test_Node.p2p property (master...test-p2p-property) https://github.com/bitcoin/bitcoin/pull/19804
2802020-09-25T12:20:26  *** bitcoin-git has left #bitcoin-core-dev
2812020-09-25T12:21:05  *** The20YearIRCloud has joined #bitcoin-core-dev
2822020-09-25T12:25:27  *** The20YearIRCloud has quit IRC
2832020-09-25T12:27:45  *** bitcoin-git has joined #bitcoin-core-dev
2842020-09-25T12:27:45  <bitcoin-git> [bitcoin] hebasto opened pull request #20014: doc: Mention signet in -help output (master...200925-signet) https://github.com/bitcoin/bitcoin/pull/20014
2852020-09-25T12:27:46  *** bitcoin-git has left #bitcoin-core-dev
2862020-09-25T12:35:43  *** S3RK has joined #bitcoin-core-dev
2872020-09-25T12:40:27  *** S3RK has quit IRC
2882020-09-25T12:43:15  *** promag has quit IRC
2892020-09-25T12:43:28  *** promag has joined #bitcoin-core-dev
2902020-09-25T12:45:16  *** Highway61 has joined #bitcoin-core-dev
2912020-09-25T12:47:17  *** bitcoin-git has joined #bitcoin-core-dev
2922020-09-25T12:47:18  <bitcoin-git> [bitcoin] gr0kchain opened pull request #20015: doc: Added default signet config for linearize script (master...master) https://github.com/bitcoin/bitcoin/pull/20015
2932020-09-25T12:47:18  *** bitcoin-git has left #bitcoin-core-dev
2942020-09-25T12:52:17  *** promag has quit IRC
2952020-09-25T12:53:04  *** promag has joined #bitcoin-core-dev
2962020-09-25T12:56:07  *** rc_423 has joined #bitcoin-core-dev
2972020-09-25T12:56:23  *** Waithamai has joined #bitcoin-core-dev
2982020-09-25T12:56:37  *** Waithamai is now known as Guest83434
2992020-09-25T13:13:52  *** promag has quit IRC
3002020-09-25T13:14:10  *** promag has joined #bitcoin-core-dev
3012020-09-25T13:16:36  <luke-jr> elichai2: he uses Nix
3022020-09-25T13:22:45  *** aqua42 has quit IRC
3032020-09-25T13:23:06  *** aqua42 has joined #bitcoin-core-dev
3042020-09-25T13:25:59  *** ExEric3 has quit IRC
3052020-09-25T13:26:47  *** ExEric3 has joined #bitcoin-core-dev
3062020-09-25T13:28:48  <roconnor> elichai2: what looks terrifying?
3072020-09-25T13:31:21  *** justanotheruser has joined #bitcoin-core-dev
3082020-09-25T13:35:14  *** promag has quit IRC
3092020-09-25T13:39:34  <elichai2> https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/builtins.c;h=eb662112b32e5ad377d2a865d9977c64dc12cc93;hb=eb662112b32e5ad377d2a865d9977c64dc12cc93#l539
3102020-09-25T13:44:24  <roconnor> well, turns out it is effectively comparing the memcpy result with 0, so it sould be unaffected by the bug I guess.
3112020-09-25T14:06:34  *** jonatack has quit IRC
3122020-09-25T14:12:40  *** tralfaz is now known as davterra
3132020-09-25T14:19:24  *** S3RK has joined #bitcoin-core-dev
3142020-09-25T14:24:18  *** S3RK has quit IRC
3152020-09-25T14:30:46  *** promag has joined #bitcoin-core-dev
3162020-09-25T14:39:13  *** andreacab has joined #bitcoin-core-dev
3172020-09-25T14:41:55  *** kexkey has joined #bitcoin-core-dev
3182020-09-25T14:42:55  *** Chris_Stewart_5 has quit IRC
3192020-09-25T14:43:49  *** andreacab has quit IRC
3202020-09-25T14:47:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3212020-09-25T14:55:21  *** Mercury_Vapor has quit IRC
3222020-09-25T14:55:44  *** Mercury_Vapor has joined #bitcoin-core-dev
3232020-09-25T14:57:52  *** mrostecki has quit IRC
3242020-09-25T14:58:09  *** mrostecki has joined #bitcoin-core-dev
3252020-09-25T15:00:02  *** Guest83434 has quit IRC
3262020-09-25T15:11:53  *** bitcoin-git has joined #bitcoin-core-dev
3272020-09-25T15:11:53  <bitcoin-git> [bitcoin] ajtowns opened pull request #20016: uint256: 1 is a constant (master...202009-uint256_1) https://github.com/bitcoin/bitcoin/pull/20016
3282020-09-25T15:11:54  *** bitcoin-git has left #bitcoin-core-dev
3292020-09-25T15:21:30  *** Talkless has joined #bitcoin-core-dev
3302020-09-25T15:22:11  *** MacYET2 has joined #bitcoin-core-dev
3312020-09-25T15:35:16  *** Chris_Stewart_5 has quit IRC
3322020-09-25T15:39:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3332020-09-25T15:49:21  *** Highway61 has quit IRC
3342020-09-25T15:49:50  *** Highway61 has joined #bitcoin-core-dev
3352020-09-25T15:53:10  *** ghost43 has quit IRC
3362020-09-25T15:53:25  *** ghost43_ has joined #bitcoin-core-dev
3372020-09-25T15:57:03  *** mrostecki has quit IRC
3382020-09-25T15:57:34  *** alko89 has quit IRC
3392020-09-25T16:01:30  *** Talkless has quit IRC
3402020-09-25T16:01:42  *** gloriazhao has joined #bitcoin-core-dev
3412020-09-25T16:07:56  *** promag has quit IRC
3422020-09-25T16:09:00  *** promag has joined #bitcoin-core-dev
3432020-09-25T16:29:22  *** face_ has quit IRC
3442020-09-25T16:37:13  *** mrostecki has joined #bitcoin-core-dev
3452020-09-25T16:48:52  *** Chris_Stewart_5 has quit IRC
3462020-09-25T16:50:46  *** jonatack has joined #bitcoin-core-dev
3472020-09-25T16:54:36  *** achow101 has quit IRC
3482020-09-25T16:54:40  *** S3RK has joined #bitcoin-core-dev
3492020-09-25T16:56:09  *** alko89 has joined #bitcoin-core-dev
3502020-09-25T16:56:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3512020-09-25T16:56:33  *** achow101 has joined #bitcoin-core-dev
3522020-09-25T16:58:29  *** achow101 has quit IRC
3532020-09-25T16:59:16  *** S3RK has quit IRC
3542020-09-25T17:00:01  *** achow101 has joined #bitcoin-core-dev
3552020-09-25T17:12:41  *** proofofkeags has joined #bitcoin-core-dev
3562020-09-25T17:18:24  *** promag has quit IRC
3572020-09-25T17:18:40  *** promag has joined #bitcoin-core-dev
3582020-09-25T17:34:03  *** andreacab has joined #bitcoin-core-dev
3592020-09-25T17:35:25  *** achow101 has quit IRC
3602020-09-25T17:35:57  *** achow101 has joined #bitcoin-core-dev
3612020-09-25T17:37:19  *** Chris_Stewart_5 has quit IRC
3622020-09-25T17:37:38  *** promag has quit IRC
3632020-09-25T17:38:22  *** promag has joined #bitcoin-core-dev
3642020-09-25T17:38:52  *** promag has joined #bitcoin-core-dev
3652020-09-25T17:42:17  *** andreacab has quit IRC
3662020-09-25T17:42:43  *** andreacab has joined #bitcoin-core-dev
3672020-09-25T17:47:29  *** andreacab has quit IRC
3682020-09-25T17:48:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3692020-09-25T17:53:39  *** achow101 has quit IRC
3702020-09-25T17:53:50  *** achow101 has joined #bitcoin-core-dev
3712020-09-25T18:00:02  *** MacYET2 has quit IRC
3722020-09-25T18:21:56  *** andreacab has joined #bitcoin-core-dev
3732020-09-25T18:21:58  *** grafa has joined #bitcoin-core-dev
3742020-09-25T18:22:13  *** jonatack has quit IRC
3752020-09-25T18:26:45  *** andreacab has quit IRC
3762020-09-25T18:32:21  *** davterra has quit IRC
3772020-09-25T18:42:44  *** GankMove has joined #bitcoin-core-dev
3782020-09-25T18:45:00  *** davterra has joined #bitcoin-core-dev
3792020-09-25T18:55:07  *** bitcoin-git has joined #bitcoin-core-dev
3802020-09-25T18:55:07  <bitcoin-git> [bitcoin] promag opened pull request #20017: rpc: Add RPCContext (master...2020-09-rpcontext) https://github.com/bitcoin/bitcoin/pull/20017
3812020-09-25T18:55:07  *** bitcoin-git has left #bitcoin-core-dev
3822020-09-25T18:55:43  *** mrostecki has quit IRC
3832020-09-25T18:56:47  *** andreacab has joined #bitcoin-core-dev
3842020-09-25T19:00:20  <achow101> anyone around for the wallet meeting have something to discuss?
3852020-09-25T19:01:12  <fjahr> Sort of but no topics and on the go
3862020-09-25T19:01:47  *** jonatack has joined #bitcoin-core-dev
3872020-09-25T19:01:53  <achow101> all i've got is that i'd like to shill for #19077
3882020-09-25T19:01:55  <gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
3892020-09-25T19:02:00  <achow101> i'll trade for reviews on that
3902020-09-25T19:02:09  <jonatack> hi
3912020-09-25T19:02:12  *** andreacab has quit IRC
3922020-09-25T19:02:34  <fjahr> Yeah, already working on that :)
3932020-09-25T19:02:58  *** ghost43_ has quit IRC
3942020-09-25T19:03:18  *** ghost43 has joined #bitcoin-core-dev
3952020-09-25T19:05:31  <jonatack> Sorry, I missed the start. What would be the biggest wallet prios to try for before Oct 15 FF.
3962020-09-25T19:05:46  <jonatack> #16546?
3972020-09-25T19:05:49  <gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
3982020-09-25T19:06:00  <jonatack> Sqlite3?
3992020-09-25T19:06:31  <achow101> sqlite is one I'd like
4002020-09-25T19:07:00  <achow101> I think external signer support should wait one release to let descriptor wallets get a release first
4012020-09-25T19:07:37  <achow101> #18836 too, but that could also be considered a bug fix
4022020-09-25T19:07:40  <gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
4032020-09-25T19:08:21  <jonatack> ty achow101. WDYT, can we try for fjahr and sipa's coinstats work (unsure if this counts as wallet)?
4042020-09-25T19:09:18  *** promag has quit IRC
4052020-09-25T19:09:19  <achow101> jonatack: not wallet, but I can take a look
4062020-09-25T19:09:34  <luke-jr> achow101: have you looked any into the PSBT side of the GCC bug?
4072020-09-25T19:09:44  <achow101> luke-jr: nope
4082020-09-25T19:09:48  <achow101> should I
4092020-09-25T19:09:52  <luke-jr> not sure
4102020-09-25T19:10:02  <luke-jr> it's only within deserialisation
4112020-09-25T19:10:08  <sipa> luke-jr: my current thinking is that it is not affected
4122020-09-25T19:10:17  *** promag has joined #bitcoin-core-dev
4132020-09-25T19:10:20  <luke-jr> sipa: well, the fixed GCC is definitely producing different code
4142020-09-25T19:10:34  <sipa> the code may have changed as a result of the bug fix, but that doesn't mean that in this case the old code was wrong
4152020-09-25T19:10:40  <sipa> i'll look in more detail today
4162020-09-25T19:10:56  <achow101> i would guess that std::map uses std::lexicographic_compare and that might be why it shows up
4172020-09-25T19:11:11  <luke-jr> hmm
4182020-09-25T19:11:15  <achow101> for std::vector<unsigned char> as the key
4192020-09-25T19:12:41  <achow101> but that would only effect how things are stored by std::map internally, so I think that would be fine?
4202020-09-25T19:13:06  <sipa> it could in theory mean things can't be found or so
4212020-09-25T19:13:46  <sipa> actually, the keys never have a 0 byte in them, right?
4222020-09-25T19:13:57  <achow101> they can
4232020-09-25T19:14:02  <sipa> and those that do aren't from constants
4242020-09-25T19:14:24  <sipa> e.g. a prefix + hash could have a 0 byte in the hash, but the hash is not a constant
4252020-09-25T19:14:37  <achow101> there's a 0 type but i don't know if they would end up in the memcmp
4262020-09-25T19:14:45  <achow101> I would expect no
4272020-09-25T19:15:18  <luke-jr> could it ever have any security implications though?
4282020-09-25T19:16:31  <sipa> achow101: the problem is that in some cases the memcmp "stops" at the first zero byte
4292020-09-25T19:16:51  <sipa> so the null key in PSBT which is just a zero byte and nothing else would be unaffected
4302020-09-25T19:17:04  <achow101> right
4312020-09-25T19:38:44  *** Talkless has joined #bitcoin-core-dev
4322020-09-25T19:42:42  *** bitcoin-git has joined #bitcoin-core-dev
4332020-09-25T19:42:43  <bitcoin-git> [bitcoin] dhruv opened pull request #20018: p2p: ProcessAddrFetch(-seednode) is unnecessary if -connect is specified (master...seednode-not-needed-with-connect) https://github.com/bitcoin/bitcoin/pull/20018
4342020-09-25T19:42:44  *** bitcoin-git has left #bitcoin-core-dev
4352020-09-25T19:51:54  *** Chris_Stewart_5 has quit IRC
4362020-09-25T19:52:41  *** bitcoin-git has joined #bitcoin-core-dev
4372020-09-25T19:52:41  <bitcoin-git> [bitcoin] dongcarl opened pull request #20019: depends: Properly pass $PATH to configure and pin (master...2020-09-resolve-PATH-prepending-madness) https://github.com/bitcoin/bitcoin/pull/20019
4382020-09-25T19:52:44  *** bitcoin-git has left #bitcoin-core-dev
4392020-09-25T19:55:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4402020-09-25T20:01:51  *** jonatack has quit IRC
4412020-09-25T20:10:15  *** jonatack has joined #bitcoin-core-dev
4422020-09-25T20:30:01  *** S3RK has joined #bitcoin-core-dev
4432020-09-25T20:34:20  *** S3RK has quit IRC
4442020-09-25T20:34:51  *** filchef has joined #bitcoin-core-dev
4452020-09-25T20:37:24  *** promag has quit IRC
4462020-09-25T20:37:40  *** promag has joined #bitcoin-core-dev
4472020-09-25T20:39:29  *** Talkless has quit IRC
4482020-09-25T20:47:55  *** Guyver2 has quit IRC
4492020-09-25T20:47:55  *** promag has quit IRC
4502020-09-25T20:48:52  *** promag has joined #bitcoin-core-dev
4512020-09-25T20:52:59  *** Chris_Stewart_5 has quit IRC
4522020-09-25T20:55:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4532020-09-25T20:59:08  *** andreacab has joined #bitcoin-core-dev
4542020-09-25T21:00:01  *** grafa has quit IRC
4552020-09-25T21:01:28  *** promag_ has joined #bitcoin-core-dev
4562020-09-25T21:01:29  *** promag has quit IRC
4572020-09-25T21:06:59  *** andreacab has quit IRC
4582020-09-25T21:28:00  *** promag_ has quit IRC
4592020-09-25T21:56:44  *** aj1 has joined #bitcoin-core-dev
4602020-09-25T21:58:58  *** luke has joined #bitcoin-core-dev
4612020-09-25T22:05:36  *** promag has joined #bitcoin-core-dev
4622020-09-25T22:08:02  *** promag has quit IRC
4632020-09-25T22:10:43  *** vasild has quit IRC
4642020-09-25T22:12:01  *** vasild has joined #bitcoin-core-dev
4652020-09-25T22:16:12  *** luke has quit IRC
4662020-09-25T23:14:35  *** promag has joined #bitcoin-core-dev
4672020-09-25T23:50:00  *** proofofkeags has quit IRC