12020-10-03T00:00:01  *** srimech1 has quit IRC
  22020-10-03T00:00:47  *** DeanGuss has quit IRC
  32020-10-03T00:01:13  *** DeanGuss has joined #bitcoin-core-dev
  42020-10-03T00:01:35  *** promag has quit IRC
  52020-10-03T00:02:08  *** promag has joined #bitcoin-core-dev
  62020-10-03T00:03:29  *** AaronvanW has quit IRC
  72020-10-03T00:05:56  *** question has joined #bitcoin-core-dev
  82020-10-03T00:22:03  *** aaronj1335 has joined #bitcoin-core-dev
  92020-10-03T00:34:56  *** AaronvanW has joined #bitcoin-core-dev
 102020-10-03T00:39:18  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 112020-10-03T00:39:25  *** AaronvanW has quit IRC
 122020-10-03T00:42:48  *** question has quit IRC
 132020-10-03T00:55:09  *** Eagle[TM] has joined #bitcoin-core-dev
 142020-10-03T00:56:53  *** EagleTM has quit IRC
 152020-10-03T01:02:50  *** mrostecki has quit IRC
 162020-10-03T01:03:15  *** mrostecki has joined #bitcoin-core-dev
 172020-10-03T01:17:27  *** mrostecki has quit IRC
 182020-10-03T01:32:19  *** EagleTM has joined #bitcoin-core-dev
 192020-10-03T01:34:48  *** Eagle[TM] has quit IRC
 202020-10-03T01:36:05  *** Danilo57 has joined #bitcoin-core-dev
 212020-10-03T01:38:09  *** Danilo57 has quit IRC
 222020-10-03T01:59:27  *** aaronj1335 has quit IRC
 232020-10-03T01:59:56  *** justanotheruser has quit IRC
 242020-10-03T02:26:25  *** da39a3ee5e6b4b0d has quit IRC
 252020-10-03T02:26:44  *** justanotheruser has joined #bitcoin-core-dev
 262020-10-03T02:29:17  *** AaronvanW has joined #bitcoin-core-dev
 272020-10-03T02:29:33  *** andreacab has joined #bitcoin-core-dev
 282020-10-03T02:32:33  *** Guest71674 has joined #bitcoin-core-dev
 292020-10-03T02:33:21  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 302020-10-03T02:33:55  *** andreacab has quit IRC
 312020-10-03T02:42:00  *** twistedline has joined #bitcoin-core-dev
 322020-10-03T02:42:11  *** landakram has joined #bitcoin-core-dev
 332020-10-03T02:48:43  *** yanmaani has quit IRC
 342020-10-03T03:00:01  *** Guest71674 has quit IRC
 352020-10-03T03:02:37  *** AaronvanW has quit IRC
 362020-10-03T03:13:52  *** bitcoin-git has joined #bitcoin-core-dev
 372020-10-03T03:13:52  <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/171cd05ae341...54fc96ffa70a
 382020-10-03T03:13:53  <bitcoin-git> bitcoin/master f471a3b Nima Yazdanmehr: scripted diff: Improve invalid vout value rpc error message
 392020-10-03T03:13:53  <bitcoin-git> bitcoin/master 54fc96f fanquake: Merge #19956: rpc: Improve invalid vout value rpc error message
 402020-10-03T03:13:56  *** bitcoin-git has left #bitcoin-core-dev
 412020-10-03T03:14:12  *** bitcoin-git has joined #bitcoin-core-dev
 422020-10-03T03:14:12  <bitcoin-git> [bitcoin] fanquake merged pull request #19956: rpc: Improve invalid vout value rpc error message (master...rpc-invalid-vout-message) https://github.com/bitcoin/bitcoin/pull/19956
 432020-10-03T03:14:12  *** bitcoin-git has left #bitcoin-core-dev
 442020-10-03T03:14:47  *** jonatack has quit IRC
 452020-10-03T03:22:22  *** leafstorm has joined #bitcoin-core-dev
 462020-10-03T03:32:39  *** yanmaani has joined #bitcoin-core-dev
 472020-10-03T03:46:19  *** landakram has quit IRC
 482020-10-03T04:12:15  *** AaronvanW has joined #bitcoin-core-dev
 492020-10-03T04:44:41  *** AaronvanW has quit IRC
 502020-10-03T04:47:32  *** da39a3ee5e6b4b0d has quit IRC
 512020-10-03T04:48:14  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 522020-10-03T04:55:27  *** da39a3ee5e6b4b0d has quit IRC
 532020-10-03T05:16:57  *** notmandatory has quit IRC
 542020-10-03T05:17:15  *** notmandatory has joined #bitcoin-core-dev
 552020-10-03T05:53:58  *** mol_ has joined #bitcoin-core-dev
 562020-10-03T05:56:59  *** mol has quit IRC
 572020-10-03T06:00:02  *** leafstorm has quit IRC
 582020-10-03T06:04:32  *** jb55 has quit IRC
 592020-10-03T06:05:06  *** jb55 has joined #bitcoin-core-dev
 602020-10-03T06:17:38  *** Talkless has joined #bitcoin-core-dev
 612020-10-03T06:20:09  *** r4d1x1 has joined #bitcoin-core-dev
 622020-10-03T06:25:36  *** Talkless has quit IRC
 632020-10-03T06:31:03  *** andreacab has joined #bitcoin-core-dev
 642020-10-03T06:35:25  *** andreacab has quit IRC
 652020-10-03T06:42:00  *** AaronvanW has joined #bitcoin-core-dev
 662020-10-03T07:11:50  *** S3RK has joined #bitcoin-core-dev
 672020-10-03T07:15:35  *** AaronvanW has quit IRC
 682020-10-03T07:16:08  *** andreacab has joined #bitcoin-core-dev
 692020-10-03T07:48:54  <wumpus> amiti: sure but i think it's important to allow for flexibility, we don't really know all uses people have for the software, this is even more the case for open source software ... as long as it doesn't result in a direct bug / crash i don't see why it should be prevented
 702020-10-03T07:50:24  <wumpus> amiti: in this case there isn't any harm caused if someone does `-connect -dnsseed=1`, at most it wastes some bandwidth
 712020-10-03T07:54:16  <wumpus> software like bitcoind is primarily a tool, it's in the end not really up to the maintainers how people use it, there's some actually dangerous combinations that are possible: e.g. we strongly recommend that people don't bind RPC on anything but localhost, but if you really want to they can, and i guess there might be some legit scenarios where someone wants to do it
 722020-10-03T07:56:06  <wumpus> and yes, people might 'accidentally misunderstand how CLI flags work', but that's more of a risk for real footguns
 732020-10-03T07:57:13  <wumpus> dhruvm: i somewhat wonder what specifically made you concerned about this combination in the first place
 742020-10-03T08:02:17  <wumpus> also: maybe your node doesn't care about the addresses itself, but your node still takes part in address gossiping, so AddrMan functionality shouldn't be fully disabled, that'd be a logically separate choice
 752020-10-03T08:02:53  <wumpus> in any case a default is sufficient here, doing anything else would *add* complexity
 762020-10-03T08:08:00  *** jeremyrubin has quit IRC
 772020-10-03T08:10:09  <wumpus> the higher level question would be 'should AddrMan be entirely disabled in some cases', we had some related discussion wrt. that for BIP155 for making it possible for nodes to signal that they don't take part in address gossip
 782020-10-03T08:19:05  *** andreacab has quit IRC
 792020-10-03T08:22:25  *** jonatack has joined #bitcoin-core-dev
 802020-10-03T08:26:22  *** kristapsk has quit IRC
 812020-10-03T08:39:59  *** digi_james has quit IRC
 822020-10-03T08:40:09  *** digi_james has joined #bitcoin-core-dev
 832020-10-03T08:41:15  *** michagogo has quit IRC
 842020-10-03T08:41:53  *** drbrule has quit IRC
 852020-10-03T08:42:14  *** michagogo has joined #bitcoin-core-dev
 862020-10-03T08:43:20  *** drbrule has joined #bitcoin-core-dev
 872020-10-03T08:48:48  *** S3RK has quit IRC
 882020-10-03T08:49:24  *** S3RK has joined #bitcoin-core-dev
 892020-10-03T08:53:45  *** S3RK has quit IRC
 902020-10-03T09:00:02  *** r4d1x1 has quit IRC
 912020-10-03T09:04:23  *** kexkey has quit IRC
 922020-10-03T09:04:52  *** bitcoin-git has joined #bitcoin-core-dev
 932020-10-03T09:04:52  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20065: fuzz: Configure check for main function (master...2010-fuzzMainConfig) https://github.com/bitcoin/bitcoin/pull/20065
 942020-10-03T09:04:53  *** bitcoin-git has left #bitcoin-core-dev
 952020-10-03T09:06:46  *** AaronvanW has joined #bitcoin-core-dev
 962020-10-03T09:18:27  *** frogar has quit IRC
 972020-10-03T09:21:02  *** martind1 has joined #bitcoin-core-dev
 982020-10-03T09:22:31  *** shesek has quit IRC
 992020-10-03T09:29:28  *** yancy has joined #bitcoin-core-dev
1002020-10-03T09:52:52  *** andreacab has joined #bitcoin-core-dev
1012020-10-03T09:57:16  *** andreacab has quit IRC
1022020-10-03T09:57:42  *** andreacab has joined #bitcoin-core-dev
1032020-10-03T10:02:19  *** andreacab has quit IRC
1042020-10-03T10:10:03  *** vasild has quit IRC
1052020-10-03T10:12:14  *** vasild has joined #bitcoin-core-dev
1062020-10-03T10:18:29  *** Katelynn2Hauck has joined #bitcoin-core-dev
1072020-10-03T10:25:58  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1082020-10-03T10:32:52  *** b10c has quit IRC
1092020-10-03T10:33:13  *** b10c has joined #bitcoin-core-dev
1102020-10-03T10:53:53  *** da39a3ee5e6b4b0d has quit IRC
1112020-10-03T10:59:16  *** molz_ has joined #bitcoin-core-dev
1122020-10-03T11:02:01  *** bitcoin-git has joined #bitcoin-core-dev
1132020-10-03T11:02:01  <bitcoin-git> [bitcoin] theStack opened pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
1142020-10-03T11:02:02  *** bitcoin-git has left #bitcoin-core-dev
1152020-10-03T11:02:14  *** mol_ has quit IRC
1162020-10-03T11:05:05  *** Katelynn2Hauck has quit IRC
1172020-10-03T11:34:07  <hebasto> could any one explain this https://travis-ci.org/github/bitcoin/bitcoin/jobs/732481553 ?
1182020-10-03T11:42:42  *** worc3131 has quit IRC
1192020-10-03T11:42:43  *** AaronvanW has quit IRC
1202020-10-03T11:44:51  <aj> hebasto: #19956 had "scripted diff" in the commit message instead of "scripted-diff"
1212020-10-03T11:44:53  <gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
1222020-10-03T11:45:31  <wumpus> hebasto: none of your commits looks remotely like a scripted diff at least
1232020-10-03T11:46:08  <hebasto> that is it, looks very strange
1242020-10-03T11:46:44  <hebasto> aj: oh, thanks!
1252020-10-03T11:47:21  <wumpus> that error message really needs to have the commit id in it to be useful
1262020-10-03T11:47:30  <wumpus> test/lint/commit-script-check.sh line 40
1272020-10-03T11:48:04  <wumpus> but that seems to be it ^^
1282020-10-03T11:50:56  <hebasto> wumpus: what script is used for merging? is it its responsibility to check such variants?
1292020-10-03T11:51:48  *** bitcoin-git has joined #bitcoin-core-dev
1302020-10-03T11:51:48  <bitcoin-git> [bitcoin] laanwj opened pull request #20069: test: Mention commit id in scripted diff error (master...2020_10_scriptdiff_lint_errormsg) https://github.com/bitcoin/bitcoin/pull/20069
1312020-10-03T11:51:49  *** bitcoin-git has left #bitcoin-core-dev
1322020-10-03T11:53:37  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1332020-10-03T11:57:00  <hebasto> interesting that #19956 has no Travis CI check
1342020-10-03T11:57:02  <gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
1352020-10-03T11:57:26  *** martind1 has quit IRC
1362020-10-03T11:58:10  *** FredC has joined #bitcoin-core-dev
1372020-10-03T12:00:02  *** FredC has quit IRC
1382020-10-03T12:22:10  *** mrafiee has joined #bitcoin-core-dev
1392020-10-03T12:41:52  *** jonatack has quit IRC
1402020-10-03T12:56:32  *** jonatack has joined #bitcoin-core-dev
1412020-10-03T13:02:30  *** alko89 has quit IRC
1422020-10-03T13:25:15  *** alko89 has joined #bitcoin-core-dev
1432020-10-03T13:27:52  <wumpus> hebasto: no, the script for merging doesn't check this, it's up to the maintainer merging it to do such checks or not
1442020-10-03T13:28:34  <wumpus> how deep is this linting script checking anyway? I'm a bit surprised it checks previous PRs, I don't think it should
1452020-10-03T13:35:14  <aj> wumpus: it's $TRAVIS_COMMIT_RANGE which is meant to be only the PR commits, but is all the commits from both the PR and that were merged since the PR's branch point, i think -- https://github.com/travis-ci/travis-ci/issues/4596  also #19654
1462020-10-03T13:35:16  <gribble> https://github.com/bitcoin/bitcoin/issues/19654 | lint: Dont use TRAVIS_COMMIT_RANGE in commit message linter by fjahr · Pull Request #19654 · bitcoin/bitcoin · GitHub
1472020-10-03T13:46:38  *** da39a3ee5e6b4b0d has quit IRC
1482020-10-03T13:53:37  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1492020-10-03T14:09:39  *** da39a3ee5e6b4b0d has quit IRC
1502020-10-03T14:37:13  *** davec has quit IRC
1512020-10-03T14:37:49  *** davec has joined #bitcoin-core-dev
1522020-10-03T14:57:34  *** jeremyrubin has joined #bitcoin-core-dev
1532020-10-03T15:00:02  *** mrafiee has quit IRC
1542020-10-03T15:09:14  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1552020-10-03T15:14:47  *** justanotheruser has quit IRC
1562020-10-03T15:22:15  *** justanotheruser has joined #bitcoin-core-dev
1572020-10-03T15:22:20  *** shoman94 has joined #bitcoin-core-dev
1582020-10-03T15:43:10  *** jkczyz has quit IRC
1592020-10-03T15:43:10  *** moneyball has quit IRC
1602020-10-03T15:43:20  *** moneyball has joined #bitcoin-core-dev
1612020-10-03T15:43:23  *** jkczyz has joined #bitcoin-core-dev
1622020-10-03T15:43:48  *** endogenic has quit IRC
1632020-10-03T15:44:26  *** pierre_rochard has quit IRC
1642020-10-03T15:45:04  *** NicolasDorier has quit IRC
1652020-10-03T15:45:44  *** Jackielove4u has quit IRC
1662020-10-03T15:45:52  *** bosma has quit IRC
1672020-10-03T15:46:02  *** pierre_rochard has joined #bitcoin-core-dev
1682020-10-03T15:47:11  *** endogenic has joined #bitcoin-core-dev
1692020-10-03T15:48:40  *** Jackielove4u has joined #bitcoin-core-dev
1702020-10-03T15:49:03  *** bosma has joined #bitcoin-core-dev
1712020-10-03T15:52:18  *** NicolasDorier has joined #bitcoin-core-dev
1722020-10-03T16:01:08  *** da39a3ee5e6b4b0d has quit IRC
1732020-10-03T16:04:13  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1742020-10-03T16:05:12  *** sr_gi has quit IRC
1752020-10-03T16:12:03  *** shesek has joined #bitcoin-core-dev
1762020-10-03T16:12:03  *** shesek has joined #bitcoin-core-dev
1772020-10-03T16:12:09  <fjahr> Yeah, it's the same issue. $TRAVIS_COMMIT_RANGE is very unintuitive.
1782020-10-03T16:16:40  *** da39a3ee5e6b4b0d has quit IRC
1792020-10-03T16:16:48  *** bitcoin-git has joined #bitcoin-core-dev
1802020-10-03T16:16:49  <bitcoin-git> [bitcoin] fjahr opened pull request #20071: ci: Don't use TRAVIS_COMMIT_RANGE for commit-script-check (master...commit_range) https://github.com/bitcoin/bitcoin/pull/20071
1812020-10-03T16:16:50  *** bitcoin-git has left #bitcoin-core-dev
1822020-10-03T16:31:26  *** AaronvanW has joined #bitcoin-core-dev
1832020-10-03T16:54:31  *** mol_ has joined #bitcoin-core-dev
1842020-10-03T16:57:25  *** molz_ has quit IRC
1852020-10-03T17:04:45  *** cltrbreak_MAD2 is now known as ctrlbreak
1862020-10-03T17:09:52  *** andreacab has joined #bitcoin-core-dev
1872020-10-03T17:20:13  *** andreacab has quit IRC
1882020-10-03T17:20:39  *** andreacab has joined #bitcoin-core-dev
1892020-10-03T17:25:39  *** andreacab has quit IRC
1902020-10-03T17:32:30  *** bitcoin-git has joined #bitcoin-core-dev
1912020-10-03T17:32:30  <bitcoin-git> [bitcoin] fjahr opened pull request #20072: ci: Build Arm64 on Travis without functional tests (master...travis_arm) https://github.com/bitcoin/bitcoin/pull/20072
1922020-10-03T17:32:31  *** bitcoin-git has left #bitcoin-core-dev
1932020-10-03T17:32:36  *** Talkless has joined #bitcoin-core-dev
1942020-10-03T17:39:25  <fjahr> I think until #20071 is merged or the offending commit is rolled back, all new PRs will fail on Travis.
1952020-10-03T17:39:26  <gribble> https://github.com/bitcoin/bitcoin/issues/20071 | ci: Dont use TRAVIS_COMMIT_RANGE for commit-script-check by fjahr · Pull Request #20071 · bitcoin/bitcoin · GitHub
1962020-10-03T17:40:59  <fjahr> f471a3be00c2b6433b8c258b716982c0539da13f is the offender that would need to be removed
1972020-10-03T17:42:35  *** bitcoin-git has joined #bitcoin-core-dev
1982020-10-03T17:42:35  <bitcoin-git> [bitcoin] hebasto opened pull request #20073: [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail (master...201003-travis) https://github.com/bitcoin/bitcoin/pull/20073
1992020-10-03T17:42:36  *** bitcoin-git has left #bitcoin-core-dev
2002020-10-03T17:42:46  <fjahr> or as aj said #19956
2012020-10-03T17:42:48  <gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
2022020-10-03T17:46:13  <sipa> fjahr: i haven't followed this; what is the problem with f471a3be ?
2032020-10-03T17:48:18  <fjahr> it has "scripted diff" instead of "scripted-diff" as a prefix, which makes the linter fail. But it was merged and since the linter uses TRAVIS_COMMIT_RANGE it checks all the pushed commits of a new PR. So when a new PR is opened all commits are checked, including the offending one in master.
2042020-10-03T17:50:32  <sipa> oh
2052020-10-03T17:51:32  <sipa> and the appveyor build is failing on #20071, for the ubrelated msys2 problem, sigh!
2062020-10-03T17:51:33  <gribble> https://github.com/bitcoin/bitcoin/issues/20071 | ci: Dont use TRAVIS_COMMIT_RANGE for commit-script-check by fjahr · Pull Request #20071 · bitcoin/bitcoin · GitHub
2072020-10-03T17:51:51  <hebasto> travis environment seems inconsistent; both #20072 and #20073 are built on the same base, but TRAVIS_COMMIT_RANGE seems have different base commit for them
2082020-10-03T17:51:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20072 | ci: Build Arm64 on Travis without functional tests by fjahr · Pull Request #20072 · bitcoin/bitcoin · GitHub
2092020-10-03T17:51:53  <gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
2102020-10-03T17:52:22  <fjahr> is this a ci deadlock?
2112020-10-03T17:52:54  <hebasto> what is "ci deadlock"?
2122020-10-03T17:53:18  <fjahr> a joke :)
2132020-10-03T17:53:29  <hebasto> :D
2142020-10-03T17:53:32  <fjahr> both ci fixes fail on another ci
2152020-10-03T17:53:48  <hebasto> let's get rid of TRAVIS_COMMIT_RANGE completely
2162020-10-03T17:53:56  <fjahr> I agree
2172020-10-03T17:54:54  <sipa> it seems TRAVIS_COMMIT_RANGE just isn't the right thing for sanity checks on PRs
2182020-10-03T17:54:57  <sipa> so agree
2192020-10-03T17:56:06  <fjahr> I am removing it from the whitespace linter which seems to be the only place left
2202020-10-03T17:56:30  <sipa> cool
2212020-10-03T17:56:55  <hebasto> it's a pity we cannot find out the actual value of TRAVIS_COMMIT_RANGE on failed builds
2222020-10-03T17:57:35  <sipa> it's just $MASTER...$MERGED_PR_HEAD, no?
2232020-10-03T17:58:03  <hebasto> in that case it should work, but it doesn't
2242020-10-03T17:58:28  <hebasto> compare 20072 and 20073
2252020-10-03T17:58:44  <fjahr> no, it is all the pushed commits, so for example when you rebase it is including all the rebase commits
2262020-10-03T17:59:20  <fjahr> I tried to explain it a bit better in https://github.com/bitcoin/bitcoin/pull/19654
2272020-10-03T17:59:22  <hebasto> fjahr: that is not the case for the recent 20072 and 20073
2282020-10-03T18:00:02  *** shoman94 has quit IRC
2292020-10-03T18:00:13  <hebasto> your 20072 has the same base commit as my 20073
2302020-10-03T18:00:35  <fjahr> I am not sure about the initial pushes when a PR is first opened. But since I saw my new or fail I assumed it goes back far, maybe even all commits.
2312020-10-03T18:01:06  <fjahr> that they are the same would make sense for new commits
2322020-10-03T18:01:32  <sipa> 54fc96ffa70ad3a53d32709101b7a2ce064d822e...f006f1679d0833f8d9c693553196a68a69e4f65f on #20073
2332020-10-03T18:01:33  <gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
2342020-10-03T18:02:04  <hebasto> sipa: that is correct value
2352020-10-03T18:02:30  <hebasto> fjahr: 20072 has only one push, right?
2362020-10-03T18:02:37  <sipa> which is just master and the head of 20073
2372020-10-03T18:03:10  <sipa> try pushing a version of 20073, rebase on an older version of master?
2382020-10-03T18:05:00  <fjahr> a true, so maybe initial push is from master if your pr branch is up to date on master and if it's not up to date it is all commits from the last commit in the branch
2392020-10-03T18:05:13  <fjahr> *is from master HEAD
2402020-10-03T18:05:32  <sipa> note the ... syntax
2412020-10-03T18:05:36  <sipa> which does not mean "
2422020-10-03T18:05:44  <sipa> what you may expect
2432020-10-03T18:06:05  <sipa> it's all commits that are in A's history but not in B's, or the other way around (for A...B)
2442020-10-03T18:06:38  <sipa> if A and B have different snapshots of master in it, the difference between the two will be included in the range
2452020-10-03T18:06:51  <hebasto> sipa: experimental #20073 rebased on older base
2462020-10-03T18:06:52  <gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
2472020-10-03T18:09:29  <sipa> yup
2482020-10-03T18:09:39  <sipa> so A is master, B is the head of your PR
2492020-10-03T18:09:41  <hebasto> failed with value 54fc96ffa70ad3a53d32709101b7a2ce064d822e...202ea04949ea9b742fa3368bb9104bb3a2099d3d
2502020-10-03T18:10:10  <sipa> which means that any commits in master that your PR has not been rebased on, are included
2512020-10-03T18:10:49  <hebasto> the latest TRAVIS_COMMIT_RANGE value is wrong; the base commit is 597488d37c9c358837616516d88f861f5c25f827
2522020-10-03T18:12:01  <sipa> i don't think it's wrong - it's doing what it's designed to, but that's not what we need
2532020-10-03T18:12:06  <hebasto> I'm wrong; the first is master commit
2542020-10-03T18:12:20  <hebasto> as it is `...` syntax
2552020-10-03T18:12:28  <sipa> fjahr: concept ack 20071
2562020-10-03T18:12:36  <fjahr> sipa: ty
2572020-10-03T18:14:53  <hebasto> sipa: I don't see how the commit range `54fc96ffa70ad3a53d32709101b7a2ce064d822e...202ea04949ea9b742fa3368bb9104bb3a2099d3d` includes the offender f471a3be00c2b6433b8c258b716982c0539da13f
2582020-10-03T18:14:54  <sipa> you're going to update it to also use that mechanism for the whitespace linter?
2592020-10-03T18:16:03  <hebasto> sipa: as the common commit is 597488d37c9c358837616516d88f861f5c25f827, which is later than offender
2602020-10-03T18:16:15  <sipa> hebasto: the concept of X...Y is that if you have a git history of the form r-c1-c2-c3-X and r-c1-c4-Y, then X...Y is the set of commits (c2, c3, c4, X, Y)
2612020-10-03T18:16:27  <sipa> it is not a "range"
2622020-10-03T18:16:31  <sipa> it's a set difference
2632020-10-03T18:16:38  <hebasto> I understand this notion
2642020-10-03T18:16:40  *** harrigan has quit IRC
2652020-10-03T18:16:53  <hebasto> that why I'm asking
2662020-10-03T18:17:54  <sipa> hebasto: 54fc96ffa70ad3a53d32709101b7a2ce064d822e has the offender f471a3be00c2b6433b8c258b716982c0539da13f in its history; 202ea04949ea9b742fa3368bb9104bb3a2099d3d does not
2672020-10-03T18:18:14  <fjahr> sipa: I will unless 20071 already gets merged. But will finish the whitespace one soon.
2682020-10-03T18:18:48  *** harrigan has joined #bitcoin-core-dev
2692020-10-03T18:20:24  <sipa> hebasto: which also means the merge-base 597488d37c9c358837616516d88f861f5c25f827 does not have the offender in its history
2702020-10-03T18:20:31  <sipa> so i think you're just overlooking something
2712020-10-03T18:22:27  *** harrigan has quit IRC
2722020-10-03T18:23:02  <hebasto> sipa: correct
2732020-10-03T18:26:10  <sipa> fjahr: i believe your code in 20071 is unnecessary; "$MERGE_BASE..HEAD" should be identical to "$(git merge-base HEAD $MERGE_BASE)..HEAD", unless there is a subtle difference between master and $MERGE_BASE ?
2742020-10-03T18:26:29  <hebasto> sipa: that means TRAVIS_COMMIT_RANGE for a new pr which is built on top of current HEAD (that merges the offender) should not include the offender, right?
2752020-10-03T18:26:36  <sipa> hebasto: correct
2762020-10-03T18:26:56  <sipa> that's my understanding, but i'm not entirely sure that re-pushes don't have extra behavior
2772020-10-03T18:27:52  *** harrigan has joined #bitcoin-core-dev
2782020-10-03T18:27:54  <hebasto> sipa: thanks
2792020-10-03T18:28:45  <sipa> fjahr: the merge-base with master may result in weird effects if it's a PR for a release branch rather than master
2802020-10-03T18:31:12  <fjahr> sipa: I am not sure if I understand. Did you mean it should be identical to "$(git merge-base HEAD)..HEAD"?
2812020-10-03T18:31:31  <fjahr> Otherwise I am confused because you still have $MERGE_BASE in there
2822020-10-03T18:32:29  <sipa> fjahr: i'm saying that you should use "$MERGE_BASE..HEAD" and not "$(git merge-base HEAD $MERGE_BASE)..HEAD" as you're doing now
2832020-10-03T18:32:33  <sipa> sorry
2842020-10-03T18:32:39  <sipa> fjahr: i'm saying that you should use "$MERGE_BASE..HEAD" and not "$(git merge-base HEAD master)..HEAD" as you're doing now
2852020-10-03T18:33:41  <sipa> what you're doing now is equivalent (as far as I understand) to "master..HEAD", which would be wrong for non-master PRs
2862020-10-03T18:34:53  <fjahr> in both commits or the second one I added?
2872020-10-03T18:35:35  *** Guyver2 has joined #bitcoin-core-dev
2882020-10-03T18:35:40  <sipa> in all of them
2892020-10-03T18:35:48  <sipa> do you understand what i mean?
2902020-10-03T18:36:08  <fjahr> So there is already a variable $MERGE_BASE? I did not know that
2912020-10-03T18:36:27  <sipa> you're using it!
2922020-10-03T18:36:31  <sipa> COMMIT_RANGE="$MERGE_BASE..HEAD"
2932020-10-03T18:36:37  <sipa> oh
2942020-10-03T18:36:43  <sipa> i'm misreading, i see
2952020-10-03T18:36:46  <sipa> ignore me
2962020-10-03T18:36:55  <fjahr> :)
2972020-10-03T18:38:11  <sipa> try COMMIT_RANGE="$TRAVIS_BRANCH..HEAD" ?
2982020-10-03T18:38:36  <sipa> TRAVIS_BRANCH:
2992020-10-03T18:38:36  <sipa> for push builds, or builds not triggered by a pull request, this is the name of the branch. for builds triggered by a pull request this is the name of the branch targeted by the pull request.
3002020-10-03T18:38:40  <sipa> for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG).
3012020-10-03T18:45:47  <fjahr> I thought it might be good to not be dependent on travis variables. But you think it will be more robust?
3022020-10-03T18:46:03  *** jrawsthorne has quit IRC
3032020-10-03T18:47:17  *** jrawsthorne has joined #bitcoin-core-dev
3042020-10-03T18:49:01  <fjahr> Ah, you mean only in 06_script.sh, not the other places...
3052020-10-03T18:49:20  <sipa> fjahr: i think your current code will cause non-master PRs to recheck the entire history back to where the release branch forked off
3062020-10-03T18:51:22  <fjahr> ah, I see, I think that is right
3072020-10-03T18:56:56  *** Jamalaka has joined #bitcoin-core-dev
3082020-10-03T19:01:52  *** bitcoin-git has joined #bitcoin-core-dev
3092020-10-03T19:01:53  <bitcoin-git> [bitcoin] robot-dreams opened pull request #20074: test: p2p_blockfilters tests for BIP157 config args (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/20074
3102020-10-03T19:02:02  *** bitcoin-git has left #bitcoin-core-dev
3112020-10-03T19:04:49  *** go11111111111 has joined #bitcoin-core-dev
3122020-10-03T19:05:39  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
3132020-10-03T19:07:07  *** go1111111 has quit IRC
3142020-10-03T19:09:58  *** andreacab has joined #bitcoin-core-dev
3152020-10-03T19:10:26  *** da39a3ee5e6b4b0d has quit IRC
3162020-10-03T19:12:17  *** andreacab has quit IRC
3172020-10-03T19:12:29  *** andreacab has joined #bitcoin-core-dev
3182020-10-03T19:19:46  *** andreacab has quit IRC
3192020-10-03T19:20:13  *** andreacab has joined #bitcoin-core-dev
3202020-10-03T19:24:52  *** andreacab has quit IRC
3212020-10-03T20:11:46  *** Talkless has quit IRC
3222020-10-03T20:17:24  *** harrigan has quit IRC
3232020-10-03T20:18:14  *** harrigan has joined #bitcoin-core-dev
3242020-10-03T20:22:53  *** Guyver2 has quit IRC
3252020-10-03T21:00:01  *** Jamalaka has quit IRC
3262020-10-03T21:10:52  *** harrigan has quit IRC
3272020-10-03T21:11:15  *** Tennis has joined #bitcoin-core-dev
3282020-10-03T21:12:40  *** wullon587 has joined #bitcoin-core-dev
3292020-10-03T21:13:55  *** harrigan has joined #bitcoin-core-dev
3302020-10-03T21:21:40  *** filchef has joined #bitcoin-core-dev
3312020-10-03T21:42:09  *** bitcoin-git has joined #bitcoin-core-dev
3322020-10-03T21:42:09  <bitcoin-git> [bitcoin] sipa opened pull request #20075: [DO NOT MERGE] Version of #20071 rebased on buggy commit, with extra logging (master...pr20071) https://github.com/bitcoin/bitcoin/pull/20075
3332020-10-03T21:42:11  *** bitcoin-git has left #bitcoin-core-dev
3342020-10-03T21:50:32  *** mrostecki has joined #bitcoin-core-dev
3352020-10-03T21:54:02  *** kers has joined #bitcoin-core-dev
3362020-10-03T21:57:41  *** bitcoin-git has joined #bitcoin-core-dev
3372020-10-03T21:57:41  <bitcoin-git> [bitcoin] sipa closed pull request #20075: [DO NOT MERGE] Version of #20071 rebased on buggy commit, with extra logging (master...pr20071) https://github.com/bitcoin/bitcoin/pull/20075
3382020-10-03T21:57:42  *** bitcoin-git has left #bitcoin-core-dev
3392020-10-03T22:01:47  <dhruvm> wumpus: Referring to your message from 08:57, what made me curious about these cli flag combinations is that I am new to the codebase and trying to estaablish a mental model for how the p2p layer works. For me this has involved going through the code, asking people I have access to questions about why things are a certain way.
3402020-10-03T22:03:30  <dhruvm> When I saw that getaddr calls are still made in -connect mode I found myself confused as a new developer, and thought this may be confusing to future new devs as well. So the primary motivation was keeping things easy to understand.
3412020-10-03T22:09:19  <sipa> dhruvm: good thinking
3422020-10-03T22:10:03  *** vasild has quit IRC
3432020-10-03T22:12:15  *** vasild has joined #bitcoin-core-dev
3442020-10-03T22:17:53  *** harrigan has quit IRC
3452020-10-03T22:22:15  *** harrigan has joined #bitcoin-core-dev
3462020-10-03T22:53:33  *** promag_ has joined #bitcoin-core-dev
3472020-10-03T23:03:33  *** promag_ has quit IRC
3482020-10-03T23:12:23  *** promag_ has joined #bitcoin-core-dev
3492020-10-03T23:17:54  *** promag_ has quit IRC
3502020-10-03T23:30:32  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
3512020-10-03T23:34:18  *** bitdex has joined #bitcoin-core-dev
3522020-10-03T23:34:56  *** da39a3ee5e6b4b0d has quit IRC
3532020-10-03T23:40:55  *** troygiorshev has joined #bitcoin-core-dev
3542020-10-03T23:42:35  *** troygiorshev has joined #bitcoin-core-dev
3552020-10-03T23:50:06  *** brianhoffman_ has joined #bitcoin-core-dev
3562020-10-03T23:52:35  *** brianhoffman has quit IRC
3572020-10-03T23:52:35  *** brianhoffman_ is now known as brianhoffman
3582020-10-03T23:55:23  *** bitdex has quit IRC