12020-10-07T00:00:01  *** yar1 has quit IRC
  22020-10-07T00:00:26  *** Dean_Guss has quit IRC
  32020-10-07T00:05:42  *** DeanGuss has joined #bitcoin-core-dev
  42020-10-07T00:12:51  *** TeaBear has quit IRC
  52020-10-07T00:17:18  *** justanotheruser has quit IRC
  62020-10-07T00:21:33  *** kpyke has joined #bitcoin-core-dev
  72020-10-07T00:21:55  *** AaronvanW has quit IRC
  82020-10-07T00:36:00  *** S3RK has joined #bitcoin-core-dev
  92020-10-07T00:37:43  *** DeanGuss has quit IRC
 102020-10-07T00:47:18  *** varioust has joined #bitcoin-core-dev
 112020-10-07T00:50:47  *** S3RK has quit IRC
 122020-10-07T00:52:47  *** justanotheruser has joined #bitcoin-core-dev
 132020-10-07T01:01:17  *** AaronvanW has joined #bitcoin-core-dev
 142020-10-07T01:06:10  *** AaronvanW has quit IRC
 152020-10-07T01:07:47  *** Mercury_Vapor has quit IRC
 162020-10-07T01:13:44  *** varioust has quit IRC
 172020-10-07T01:31:24  *** troygiorshev has joined #bitcoin-core-dev
 182020-10-07T01:45:28  *** AaronvanW has joined #bitcoin-core-dev
 192020-10-07T01:52:00  *** tralfaz has joined #bitcoin-core-dev
 202020-10-07T01:54:43  *** davterra has quit IRC
 212020-10-07T01:56:34  *** tralfaz is now known as davterra
 222020-10-07T02:18:53  *** AaronvanW has quit IRC
 232020-10-07T02:22:32  *** varioust has joined #bitcoin-core-dev
 242020-10-07T02:28:02  *** DeanGuss has joined #bitcoin-core-dev
 252020-10-07T02:52:25  *** varioust has quit IRC
 262020-10-07T02:59:07  *** bitcoin-git has joined #bitcoin-core-dev
 272020-10-07T02:59:09  <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d8cd7b137fb0...db88db47278d
 282020-10-07T02:59:09  <bitcoin-git> bitcoin/master 8f1290c gzhao408: [rpc/node] check for high fee before ATMP in clients
 292020-10-07T02:59:10  <bitcoin-git> bitcoin/master 932564b gzhao408: scripted-diff: update max-fee-exceeded error message to include RPC
 302020-10-07T02:59:11  <bitcoin-git> bitcoin/master b048b27 John Newbery: [validation] Remove absurdfee from accepttomempool
 312020-10-07T02:59:13  *** bitcoin-git has left #bitcoin-core-dev
 322020-10-07T02:59:57  *** bitcoin-git has joined #bitcoin-core-dev
 332020-10-07T02:59:57  <bitcoin-git> [bitcoin] fanquake merged pull request #19339: validation: re-delegate absurd fee checking from mempool to clients (master...mempool-remove-absurdfee) https://github.com/bitcoin/bitcoin/pull/19339
 342020-10-07T02:59:59  *** bitcoin-git has left #bitcoin-core-dev
 352020-10-07T03:00:02  *** kpyke has quit IRC
 362020-10-07T03:44:50  *** S3RK has joined #bitcoin-core-dev
 372020-10-07T03:57:28  *** tralfaz has joined #bitcoin-core-dev
 382020-10-07T03:59:43  *** davterra has quit IRC
 392020-10-07T04:08:49  *** tralfaz is now known as davterra
 402020-10-07T04:16:17  *** AaronvanW has joined #bitcoin-core-dev
 412020-10-07T04:18:28  *** cltrbreak_MAD2 has joined #bitcoin-core-dev
 422020-10-07T04:21:33  *** ctrlbreak_MAD has quit IRC
 432020-10-07T04:28:00  *** Frost has joined #bitcoin-core-dev
 442020-10-07T04:49:06  *** AaronvanW has quit IRC
 452020-10-07T04:57:07  *** da39a3ee5e6b4b0d has quit IRC
 462020-10-07T04:58:49  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 472020-10-07T05:17:32  *** Frost has quit IRC
 482020-10-07T05:33:54  *** alorente has joined #bitcoin-core-dev
 492020-10-07T05:36:19  *** S3RK has quit IRC
 502020-10-07T05:47:56  *** justanotheruser has quit IRC
 512020-10-07T06:00:01  *** alorente has quit IRC
 522020-10-07T06:10:53  *** S3RK has joined #bitcoin-core-dev
 532020-10-07T06:14:17  *** afk11 has quit IRC
 542020-10-07T06:14:17  *** sipa has quit IRC
 552020-10-07T06:14:17  *** braydonf has quit IRC
 562020-10-07T06:14:18  *** ghost43 has quit IRC
 572020-10-07T06:14:18  *** yanmaani has quit IRC
 582020-10-07T06:14:18  *** vasild has quit IRC
 592020-10-07T06:14:18  *** DeanGuss has quit IRC
 602020-10-07T06:14:18  *** ares_ has quit IRC
 612020-10-07T06:14:18  *** sdaftuar has quit IRC
 622020-10-07T06:14:18  *** morcos has quit IRC
 632020-10-07T06:14:18  *** k3tan has quit IRC
 642020-10-07T06:14:19  *** jb55 has quit IRC
 652020-10-07T06:14:38  *** vasild has joined #bitcoin-core-dev
 662020-10-07T06:14:39  *** DeanGuss has joined #bitcoin-core-dev
 672020-10-07T06:14:48  *** sdaftuar has joined #bitcoin-core-dev
 682020-10-07T06:14:49  *** jb55 has joined #bitcoin-core-dev
 692020-10-07T06:15:02  *** k3tan has joined #bitcoin-core-dev
 702020-10-07T06:15:03  *** braydonf has joined #bitcoin-core-dev
 712020-10-07T06:15:04  *** afk11 has joined #bitcoin-core-dev
 722020-10-07T06:15:34  *** morcos has joined #bitcoin-core-dev
 732020-10-07T06:17:18  *** yanmaani has joined #bitcoin-core-dev
 742020-10-07T06:18:35  *** ghost43 has joined #bitcoin-core-dev
 752020-10-07T06:19:29  *** sipa has joined #bitcoin-core-dev
 762020-10-07T06:19:32  *** ares_ has joined #bitcoin-core-dev
 772020-10-07T06:22:00  *** Andy2011Zoe has joined #bitcoin-core-dev
 782020-10-07T06:24:49  *** S3RK has quit IRC
 792020-10-07T06:26:46  *** EagleTM has joined #bitcoin-core-dev
 802020-10-07T06:33:33  *** S3RK has joined #bitcoin-core-dev
 812020-10-07T06:41:54  *** S3RK has quit IRC
 822020-10-07T06:45:52  *** AaronvanW has joined #bitcoin-core-dev
 832020-10-07T07:04:22  *** sdaftuar has quit IRC
 842020-10-07T07:04:42  *** sdaftuar has joined #bitcoin-core-dev
 852020-10-07T07:06:44  *** cornfeedhobo has quit IRC
 862020-10-07T07:13:03  *** spinza has quit IRC
 872020-10-07T07:14:27  *** Guyver2 has joined #bitcoin-core-dev
 882020-10-07T07:15:21  *** spinza has joined #bitcoin-core-dev
 892020-10-07T07:15:38  *** PaulTroo_ has joined #bitcoin-core-dev
 902020-10-07T07:18:16  *** AaronvanW has quit IRC
 912020-10-07T07:18:48  *** S3RK has joined #bitcoin-core-dev
 922020-10-07T07:19:53  *** mol_ has joined #bitcoin-core-dev
 932020-10-07T07:23:10  *** mol has quit IRC
 942020-10-07T07:27:14  *** PaulTroo_ has quit IRC
 952020-10-07T07:33:52  *** bitcoin-git has joined #bitcoin-core-dev
 962020-10-07T07:33:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/db88db47278d...283a73d7eaea
 972020-10-07T07:33:52  <bitcoin-git> bitcoin/master d103484 Hennadii Stepanov: util: Do not use gArgs global in ArgsManager member functions
 982020-10-07T07:33:53  <bitcoin-git> bitcoin/master 283a73d MarcoFalke: Merge #20092: util: Do not use gArgs global in ArgsManager member function...
 992020-10-07T07:33:54  *** bitcoin-git has left #bitcoin-core-dev
1002020-10-07T07:34:11  *** bitcoin-git has joined #bitcoin-core-dev
1012020-10-07T07:34:11  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20092: util: Do not use gArgs global in ArgsManager member functions (master...201006-gargs) https://github.com/bitcoin/bitcoin/pull/20092
1022020-10-07T07:34:12  *** bitcoin-git has left #bitcoin-core-dev
1032020-10-07T07:38:25  *** BGL has quit IRC
1042020-10-07T07:41:40  *** promag has joined #bitcoin-core-dev
1052020-10-07T07:42:08  <wumpus> aj: would it make sense to maintain that project board as part of the bitcoin/bitcoin repo? or do you prefer hosting it on your own repo
1062020-10-07T07:42:58  <wumpus> (fwiw: I just closed the ancient "P2P refactor" project)
1072020-10-07T07:43:23  *** promag has quit IRC
1082020-10-07T07:45:03  *** afk11 has quit IRC
1092020-10-07T07:45:39  *** promag has joined #bitcoin-core-dev
1102020-10-07T07:46:15  <wumpus> great job in any case it's good to have an overview
1112020-10-07T07:46:30  *** Guyver2 has quit IRC
1122020-10-07T07:46:56  *** afk11 has joined #bitcoin-core-dev
1132020-10-07T07:47:27  *** Guyver2 has joined #bitcoin-core-dev
1142020-10-07T07:53:46  *** promag_ has joined #bitcoin-core-dev
1152020-10-07T07:53:46  *** promag has quit IRC
1162020-10-07T08:13:14  *** cornfeedhobo has joined #bitcoin-core-dev
1172020-10-07T08:27:21  *** tralfaz has joined #bitcoin-core-dev
1182020-10-07T08:27:35  *** davterra has quit IRC
1192020-10-07T08:30:49  *** AaronvanW has joined #bitcoin-core-dev
1202020-10-07T08:35:54  *** belcher_ has joined #bitcoin-core-dev
1212020-10-07T08:37:53  *** AaronvanW has quit IRC
1222020-10-07T08:38:11  *** AaronvanW has joined #bitcoin-core-dev
1232020-10-07T08:39:38  *** belcher has quit IRC
1242020-10-07T08:55:29  *** CubicEarth has quit IRC
1252020-10-07T08:56:07  *** jonatack has quit IRC
1262020-10-07T09:00:01  *** Andy2011Zoe has quit IRC
1272020-10-07T09:04:39  *** kexkey has quit IRC
1282020-10-07T09:09:21  *** CubicEarth has joined #bitcoin-core-dev
1292020-10-07T09:13:16  *** afk11 has quit IRC
1302020-10-07T09:13:43  *** afk11 has joined #bitcoin-core-dev
1312020-10-07T09:22:14  *** ToBeFree has joined #bitcoin-core-dev
1322020-10-07T09:22:36  *** ToBeFree is now known as Guest19382
1332020-10-07T09:27:27  *** promag_ has quit IRC
1342020-10-07T09:29:03  *** AaronvanW has quit IRC
1352020-10-07T09:31:24  *** jonatack has joined #bitcoin-core-dev
1362020-10-07T09:33:14  *** promag has joined #bitcoin-core-dev
1372020-10-07T09:36:58  *** andreacab has joined #bitcoin-core-dev
1382020-10-07T09:42:22  *** EagleTM has quit IRC
1392020-10-07T09:42:25  *** CubicEarth has quit IRC
1402020-10-07T09:44:34  *** promag has quit IRC
1412020-10-07T09:45:18  *** da39a3ee5e6b4b0d has quit IRC
1422020-10-07T09:45:57  *** andreacab has quit IRC
1432020-10-07T09:46:23  *** andreacab has joined #bitcoin-core-dev
1442020-10-07T09:46:23  *** sr_gi has quit IRC
1452020-10-07T09:47:01  *** sr_gi has joined #bitcoin-core-dev
1462020-10-07T09:50:27  *** andreacab has quit IRC
1472020-10-07T09:52:02  *** BGL has joined #bitcoin-core-dev
1482020-10-07T10:03:37  *** belcher_ has quit IRC
1492020-10-07T10:06:07  *** belcher_ has joined #bitcoin-core-dev
1502020-10-07T10:09:25  *** belcher_ is now known as belcher
1512020-10-07T10:10:41  *** S3RK has quit IRC
1522020-10-07T10:10:43  *** vasild has quit IRC
1532020-10-07T10:10:57  *** S3RK has joined #bitcoin-core-dev
1542020-10-07T10:12:06  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1552020-10-07T10:12:42  *** vasild has joined #bitcoin-core-dev
1562020-10-07T10:14:01  *** S3RK has quit IRC
1572020-10-07T10:18:35  *** Ardella31Botsfor has joined #bitcoin-core-dev
1582020-10-07T10:22:33  *** CubicEarth has joined #bitcoin-core-dev
1592020-10-07T10:23:27  *** Ardella31Botsfor has quit IRC
1602020-10-07T10:26:06  *** andreacab has joined #bitcoin-core-dev
1612020-10-07T10:28:19  *** promag has joined #bitcoin-core-dev
1622020-10-07T10:36:49  *** da39a3ee5e6b4b0d has quit IRC
1632020-10-07T10:37:56  *** S3RK has joined #bitcoin-core-dev
1642020-10-07T10:41:25  *** andreacab has quit IRC
1652020-10-07T10:43:18  *** promag has quit IRC
1662020-10-07T10:45:16  *** promag has joined #bitcoin-core-dev
1672020-10-07T10:48:07  *** andreacab has joined #bitcoin-core-dev
1682020-10-07T10:49:37  *** promag has quit IRC
1692020-10-07T10:51:06  *** AaronvanW has joined #bitcoin-core-dev
1702020-10-07T10:52:02  *** rc_423 has quit IRC
1712020-10-07T10:53:37  *** rc_423 has joined #bitcoin-core-dev
1722020-10-07T11:15:03  *** andreacab has quit IRC
1732020-10-07T11:15:33  *** andreacab has joined #bitcoin-core-dev
1742020-10-07T11:19:11  *** shesek has joined #bitcoin-core-dev
1752020-10-07T11:19:11  *** shesek has joined #bitcoin-core-dev
1762020-10-07T11:19:56  *** andreacab has quit IRC
1772020-10-07T11:21:50  *** AaronvanW has quit IRC
1782020-10-07T11:29:36  *** S3RK has quit IRC
1792020-10-07T11:30:23  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1802020-10-07T11:30:34  *** S3RK has joined #bitcoin-core-dev
1812020-10-07T11:36:18  *** EagleTM has joined #bitcoin-core-dev
1822020-10-07T11:40:47  *** S3RK has quit IRC
1832020-10-07T11:44:58  *** jonatack has quit IRC
1842020-10-07T11:53:10  *** andreacab has joined #bitcoin-core-dev
1852020-10-07T11:58:30  *** tryphe_ is now known as tryphe
1862020-10-07T12:00:02  *** Guest19382 has quit IRC
1872020-10-07T12:07:15  *** andreacab has quit IRC
1882020-10-07T12:11:21  *** Mercury_Vapor has joined #bitcoin-core-dev
1892020-10-07T12:20:17  *** ferringb has joined #bitcoin-core-dev
1902020-10-07T12:21:39  *** bitcoin-git has joined #bitcoin-core-dev
1912020-10-07T12:21:39  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20097: fuzz: Version handshake (master...2010-fuzzHandshake) https://github.com/bitcoin/bitcoin/pull/20097
1922020-10-07T12:21:39  *** bitcoin-git has left #bitcoin-core-dev
1932020-10-07T12:33:54  *** crtn32002[m] has quit IRC
1942020-10-07T12:34:00  *** icota[m]1 has quit IRC
1952020-10-07T12:34:06  *** tianshi[m] has quit IRC
1962020-10-07T12:34:14  *** RaphalBentgeac[m has quit IRC
1972020-10-07T12:34:16  *** kyoo[m] has quit IRC
1982020-10-07T12:34:17  *** Pasta[m] has quit IRC
1992020-10-07T12:34:17  *** snowkeld[m] has quit IRC
2002020-10-07T12:34:17  *** sethrogers23[m] has quit IRC
2012020-10-07T12:37:49  *** Guyver2 has quit IRC
2022020-10-07T12:41:29  *** tianshi[m] has joined #bitcoin-core-dev
2032020-10-07T12:42:18  *** EagleTM has quit IRC
2042020-10-07T12:51:11  *** andreacab has joined #bitcoin-core-dev
2052020-10-07T12:55:05  <vasild> hebasto: I dont think there would be any benefit of sending the sendaddrv2 message before verack (right now in #19954 we send it after verack)
2062020-10-07T12:55:08  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
2072020-10-07T12:56:29  <vasild> there would be benefit if we send it before the version message (:-O) because then in the version message we could encode the addrMe and addrYou in the new format thus they can be e.g. torv3 addresses
2082020-10-07T12:59:56  *** S3RK has joined #bitcoin-core-dev
2092020-10-07T13:00:40  <hebasto> am I wrong considering the window between version and verack as the main venue for adding new feature negotiation now / in the future?
2102020-10-07T13:00:52  *** icota[m] has joined #bitcoin-core-dev
2112020-10-07T13:00:53  *** rcrtn32002[m] has joined #bitcoin-core-dev
2122020-10-07T13:00:53  *** TheFuzzStone[m] has joined #bitcoin-core-dev
2132020-10-07T13:00:53  *** sethrogers23[m] has joined #bitcoin-core-dev
2142020-10-07T13:00:53  *** kyoo[m] has joined #bitcoin-core-dev
2152020-10-07T13:00:53  *** snowkeld[m] has joined #bitcoin-core-dev
2162020-10-07T13:01:00  *** RaphalBentgeac[m has joined #bitcoin-core-dev
2172020-10-07T13:01:00  *** Pasta[m] has joined #bitcoin-core-dev
2182020-10-07T13:01:14  <vasild> Also, if we push now a new message before verack, even though #19723 is merged, about 70% of the peers will misbehave us because they dont run the latest version
2192020-10-07T13:01:16  <gribble> https://github.com/bitcoin/bitcoin/issues/19723 | Ignore unknown messages before VERACK by sdaftuar · Pull Request #19723 · bitcoin/bitcoin · GitHub
2202020-10-07T13:01:28  <hebasto> correct
2212020-10-07T13:01:51  <vasild> I think "now" is too early :)
2222020-10-07T13:03:00  <vasild> but for sendaddrv2 in particular it does not make a difference whether it is before or after verack
2232020-10-07T13:03:52  *** tryphe_ has joined #bitcoin-core-dev
2242020-10-07T13:04:00  *** sethrogers23[m] has quit IRC
2252020-10-07T13:04:00  *** TheFuzzStone[m] has quit IRC
2262020-10-07T13:04:00  *** da39a3ee5e6b4b0d has quit IRC
2272020-10-07T13:04:00  *** gribble has quit IRC
2282020-10-07T13:04:00  *** tryphe has quit IRC
2292020-10-07T13:04:00  *** alko89 has quit IRC
2302020-10-07T13:04:00  *** dergoegge has quit IRC
2312020-10-07T13:04:00  *** hsmiths has quit IRC
2322020-10-07T13:04:00  *** mariorz has quit IRC
2332020-10-07T13:04:00  *** noganoo has quit IRC
2342020-10-07T13:04:00  *** kallewoof has quit IRC
2352020-10-07T13:04:14  *** tryphe_ is now known as tryphe
2362020-10-07T13:04:16  *** alko89 has joined #bitcoin-core-dev
2372020-10-07T13:04:58  *** S3RK has quit IRC
2382020-10-07T13:05:25  *** sethrogers23[m] has joined #bitcoin-core-dev
2392020-10-07T13:06:10  *** bsm117532 has quit IRC
2402020-10-07T13:06:18  *** TheFuzzStone[m] has joined #bitcoin-core-dev
2412020-10-07T13:08:52  *** bsm117532 has joined #bitcoin-core-dev
2422020-10-07T13:09:22  *** dergoegge has joined #bitcoin-core-dev
2432020-10-07T13:09:23  *** hsmiths has joined #bitcoin-core-dev
2442020-10-07T13:09:23  *** mariorz has joined #bitcoin-core-dev
2452020-10-07T13:09:23  *** noganoo has joined #bitcoin-core-dev
2462020-10-07T13:09:23  *** kallewoof has joined #bitcoin-core-dev
2472020-10-07T13:10:11  *** gribble has joined #bitcoin-core-dev
2482020-10-07T13:13:15  *** varioust has joined #bitcoin-core-dev
2492020-10-07T13:18:53  *** AaronvanW has joined #bitcoin-core-dev
2502020-10-07T13:32:13  *** filchef has joined #bitcoin-core-dev
2512020-10-07T13:33:43  *** tralfaz is now known as davterra
2522020-10-07T13:36:14  *** andreacab has quit IRC
2532020-10-07T13:37:04  *** andreacab has joined #bitcoin-core-dev
2542020-10-07T13:38:53  *** jonatack has joined #bitcoin-core-dev
2552020-10-07T13:45:25  *** andreacab has quit IRC
2562020-10-07T13:52:20  *** AaronvanW has quit IRC
2572020-10-07T13:52:35  *** worc3131 has quit IRC
2582020-10-07T13:53:28  *** ferringb has quit IRC
2592020-10-07T13:53:52  *** worc3131 has joined #bitcoin-core-dev
2602020-10-07T14:04:16  *** shesek has quit IRC
2612020-10-07T14:11:16  <hebasto> debian has gcc 10.2 now; is it patched already?
2622020-10-07T14:14:53  *** icota[m] has quit IRC
2632020-10-07T14:19:31  <luke-jr> "Correct handling of constant representations containing embedded nuls."
2642020-10-07T14:19:35  <luke-jr> check changelog for that
2652020-10-07T14:20:59  <luke-jr> hmm, changelog looks useless
2662020-10-07T14:22:20  <luke-jr> hebasto: no, it looks like it's not fixed in 10.2.0
2672020-10-07T14:23:02  <luke-jr> if inline_expand_builtin_.*cmp finds inline_expand_builtin_string_cmp, it's broken; if inline_expand_builtin_bytecmp, it's fixed
2682020-10-07T14:23:09  <luke-jr> (unless Debian patched it some other way)
2692020-10-07T14:26:41  <hebasto> luke-jr: thanks
2702020-10-07T14:28:24  *** Guyver2 has joined #bitcoin-core-dev
2712020-10-07T14:32:12  *** AaronvanW has joined #bitcoin-core-dev
2722020-10-07T14:32:17  *** justanotheruser has joined #bitcoin-core-dev
2732020-10-07T14:36:03  *** jfredett has joined #bitcoin-core-dev
2742020-10-07T14:47:44  *** EagleTM has joined #bitcoin-core-dev
2752020-10-07T14:53:27  *** andreacab has joined #bitcoin-core-dev
2762020-10-07T15:00:01  *** jfredett has quit IRC
2772020-10-07T15:00:40  *** andreacab has quit IRC
2782020-10-07T15:01:08  *** andreacab has joined #bitcoin-core-dev
2792020-10-07T15:08:03  *** andreacab has quit IRC
2802020-10-07T15:12:36  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
2812020-10-07T15:20:17  *** hggdh1 has joined #bitcoin-core-dev
2822020-10-07T15:36:03  *** andreacab has joined #bitcoin-core-dev
2832020-10-07T15:43:13  *** andreacab has quit IRC
2842020-10-07T15:44:33  *** Talkless has joined #bitcoin-core-dev
2852020-10-07T15:58:19  *** AaronvanW has quit IRC
2862020-10-07T15:59:17  *** da39a3ee5e6b4b0d has quit IRC
2872020-10-07T16:09:52  *** DeanGuss has quit IRC
2882020-10-07T16:10:14  *** DeanGuss has joined #bitcoin-core-dev
2892020-10-07T16:31:11  *** filchef has quit IRC
2902020-10-07T16:31:18  *** AaronvanW has joined #bitcoin-core-dev
2912020-10-07T16:35:45  *** AaronvanW has quit IRC
2922020-10-07T16:43:04  <achow101> ryanofsky: would you like to have a dicussion about wallet.dat vs wallet.sqlite?
2932020-10-07T16:45:47  <luke-jr> IMO the latter is better, since users shouldn't be messing with wallet internal files, and backupwallet lets the user specify any extension anyway
2942020-10-07T16:46:42  <achow101> luke-jr: but there's a lot of tooling and documentation that refer to the wallet.dat file
2952020-10-07T16:47:10  <luke-jr> achow101: and users can still call their backups wallet.dat
2962020-10-07T16:47:15  <achow101> also, I'm concerned that a downgrade would result in a new wallet.dat being created which would not be good
2972020-10-07T16:47:21  <achow101> I should probably test that..
2982020-10-07T16:47:32  <luke-jr> hmm
2992020-10-07T16:47:48  <achow101> luke-jr: right, but if they have a script backing up "wallet.dat", then it wouldn't work anymore
3002020-10-07T16:48:32  <luke-jr> achow101: yes it would
3012020-10-07T16:48:45  <luke-jr> you could *never* copy the original wallet.dat directly
3022020-10-07T16:48:49  <luke-jr> only via backupwallet RPC
3032020-10-07T16:48:54  <luke-jr> which lets them specify any filename
3042020-10-07T16:49:02  <achow101> ???
3052020-10-07T16:49:09  <achow101> you just go into the datadir and copy the file
3062020-10-07T16:49:23  <luke-jr> no, that's not a supported method to backup and can result in corrupt backups
3072020-10-07T16:49:32  <achow101> sure, but that doesn't mean people don't do it
3082020-10-07T16:49:39  <luke-jr> sounds like a reason to break it
3092020-10-07T16:50:34  <luke-jr> better to get an error on upgrade, than find out later your backups were corrupt
3102020-10-07T16:50:43  <luke-jr> otoh, sqlite might not have the same corruption issue.. so..
3112020-10-07T16:50:51  <achow101> likewise there may be a restore script that operates on wallet.dat files
3122020-10-07T16:51:34  <achow101> also, backupwallet allowing you to specify an extension may interact poorly with this
3132020-10-07T16:52:23  <luke-jr> true, we don't have a sane recover-from-backup
3142020-10-07T16:52:48  <achow101> actually it probably doesn't since we do look for the file magic to deterine type, not the filename
3152020-10-07T16:53:55  <sipa> luke-jr: backing uo wallet.dat by copying after a clean shutdown is soemthing i'd consider supported
3162020-10-07T16:54:18  *** pergaminho has joined #bitcoin-core-dev
3172020-10-07T16:55:07  *** lightlike has joined #bitcoin-core-dev
3182020-10-07T16:57:19  *** andreacab has joined #bitcoin-core-dev
3192020-10-07T17:00:31  <achow101> it's also a lot more common for people to suggest copying the wallet.dat file for backups rather than using the backupwallet rpc
3202020-10-07T17:00:55  <achow101> it's probably easier for people to understand file copying than it is for them to understand rpcs
3212020-10-07T17:00:56  *** dhruvm has joined #bitcoin-core-dev
3222020-10-07T17:01:52  *** andreacab has quit IRC
3232020-10-07T17:06:54  *** AaronvanW has joined #bitcoin-core-dev
3242020-10-07T17:10:27  <phantomcircuit> luke-jr, unfortunately lots of people just copy the wallet.dat directly cause terrible tutorials
3252020-10-07T17:17:44  *** ares_ has quit IRC
3262020-10-07T17:17:53  *** ares_ has joined #bitcoin-core-dev
3272020-10-07T17:18:58  <luke-jr> again, those are reasons to break such bad scripts/advice ;)
3282020-10-07T17:19:31  <luke-jr> backward compatibility, and guides to restoring wallets, are the reasons I see to leave .dat
3292020-10-07T17:20:52  *** ares_ has quit IRC
3302020-10-07T17:22:58  *** ares_ has joined #bitcoin-core-dev
3312020-10-07T17:31:56  *** Klox04809 has quit IRC
3322020-10-07T17:32:39  *** Klox04809 has joined #bitcoin-core-dev
3332020-10-07T17:39:05  *** Klox04809 has quit IRC
3342020-10-07T17:40:13  *** AaronvanW has quit IRC
3352020-10-07T17:43:19  *** Klox04809 has joined #bitcoin-core-dev
3362020-10-07T17:45:36  *** promag has joined #bitcoin-core-dev
3372020-10-07T17:48:07  *** worc3131 has quit IRC
3382020-10-07T17:51:37  *** AaronvanW has joined #bitcoin-core-dev
3392020-10-07T17:54:14  *** andreacab has joined #bitcoin-core-dev
3402020-10-07T17:58:58  *** worc3131 has joined #bitcoin-core-dev
3412020-10-07T17:59:23  *** andreacab has quit IRC
3422020-10-07T18:00:01  *** hggdh1 has quit IRC
3432020-10-07T18:12:18  *** lightlike has quit IRC
3442020-10-07T18:13:47  *** worc3131 has quit IRC
3452020-10-07T18:14:53  *** worc3131 has joined #bitcoin-core-dev
3462020-10-07T18:15:37  *** promag has quit IRC
3472020-10-07T18:15:47  *** S3RK has joined #bitcoin-core-dev
3482020-10-07T18:20:21  *** KuluBot has joined #bitcoin-core-dev
3492020-10-07T18:21:40  *** S3RK has quit IRC
3502020-10-07T18:58:33  *** Talkless has quit IRC
3512020-10-07T18:59:25  *** varioust has quit IRC
3522020-10-07T18:59:46  *** pinheadmz has quit IRC
3532020-10-07T19:19:03  *** pinheadmz has joined #bitcoin-core-dev
3542020-10-07T19:27:01  <achow101> it seems like at least 0.19 and 0.20 expect a wallet.dat file in an existing dir for a wallet, so renaming to wallet.sqlite wouldn't silently fail on a downgrade
3552020-10-07T19:33:29  *** mol_ has quit IRC
3562020-10-07T19:48:11  <sipa> achow101: what happens if you have an sqlite wallet.dat and run an old version? will it try to do salvage/recover somehow?
3572020-10-07T19:48:15  <sipa> or suggest to
3582020-10-07T19:48:28  <achow101> sipa: no, it errors saying it isn' a bdb file
3592020-10-07T19:48:40  <achow101> it checks the file magic before attempting to do anything to it
3602020-10-07T19:48:45  <sipa> ok
3612020-10-07T19:55:33  *** andreacab has joined #bitcoin-core-dev
3622020-10-07T19:59:47  *** andreacab has quit IRC
3632020-10-07T20:00:54  *** davterra has quit IRC
3642020-10-07T20:01:24  *** davterra has joined #bitcoin-core-dev
3652020-10-07T20:12:08  <achow101> hmm, actually it seems like we do actually attempt to salvage them, but bdb should be doing nothing because its the wrong magic
3662020-10-07T20:12:09  *** sr_gi has quit IRC
3672020-10-07T20:12:41  *** sr_gi has joined #bitcoin-core-dev
3682020-10-07T20:18:41  *** Guyver2 has quit IRC
3692020-10-07T20:22:27  <achow101> mmm, but wait, there's more, if the wallet is specified as a config option, 0.20 will make the wallet.dat file if it doesn't exist
3702020-10-07T20:23:31  *** k3tan has quit IRC
3712020-10-07T20:24:10  *** k3tan has joined #bitcoin-core-dev
3722020-10-07T20:28:24  *** brianhoffman_ has joined #bitcoin-core-dev
3732020-10-07T20:30:57  *** pinheadm_ has joined #bitcoin-core-dev
3742020-10-07T20:31:02  *** brianhoffman has quit IRC
3752020-10-07T20:31:20  *** brianhoffman_ is now known as brianhoffman
3762020-10-07T20:31:31  *** TallTim has quit IRC
3772020-10-07T20:31:46  *** pinheadmz has quit IRC
3782020-10-07T20:31:52  *** andreacab has joined #bitcoin-core-dev
3792020-10-07T20:32:02  *** andreacab has quit IRC
3802020-10-07T20:32:37  *** andreacab has joined #bitcoin-core-dev
3812020-10-07T20:33:25  *** a5m0 has quit IRC
3822020-10-07T20:34:43  *** a5m0 has joined #bitcoin-core-dev
3832020-10-07T20:35:57  *** mol has joined #bitcoin-core-dev
3842020-10-07T20:36:47  *** andreacab has quit IRC
3852020-10-07T20:44:31  *** andreacab has joined #bitcoin-core-dev
3862020-10-07T20:48:55  *** TallTim has joined #bitcoin-core-dev
3872020-10-07T20:49:07  *** andreacab has quit IRC
3882020-10-07T21:00:02  *** KuluBot has quit IRC
3892020-10-07T21:06:36  *** promag has joined #bitcoin-core-dev
3902020-10-07T21:11:10  *** promag has quit IRC
3912020-10-07T21:14:04  *** jb55 has quit IRC
3922020-10-07T21:14:30  *** jb55 has joined #bitcoin-core-dev
3932020-10-07T21:15:01  *** cornfeedhobo has quit IRC
3942020-10-07T21:18:00  *** pergaminho has quit IRC
3952020-10-07T21:20:54  *** kristapsk has joined #bitcoin-core-dev
3962020-10-07T21:21:28  *** Barras2 has joined #bitcoin-core-dev
3972020-10-07T21:23:33  *** cornfeedhobo has joined #bitcoin-core-dev
3982020-10-07T21:24:25  *** andreacab has joined #bitcoin-core-dev
3992020-10-07T21:29:56  *** andreacab has quit IRC
4002020-10-07T21:30:02  *** andreacab has joined #bitcoin-core-dev
4012020-10-07T21:32:56  *** andreacab has quit IRC
4022020-10-07T21:33:57  *** andreacab has joined #bitcoin-core-dev
4032020-10-07T21:38:53  *** andreacab has quit IRC
4042020-10-07T21:42:47  *** worc3131 has quit IRC
4052020-10-07T21:43:36  *** worc3131 has joined #bitcoin-core-dev
4062020-10-07T22:04:02  *** jrawsthorne has quit IRC
4072020-10-07T22:04:13  *** jrawsthorne has joined #bitcoin-core-dev
4082020-10-07T22:06:25  *** ariard has quit IRC
4092020-10-07T22:07:17  *** ariard has joined #bitcoin-core-dev
4102020-10-07T22:08:50  <sanket1729> How do I get my tests written in script_tests.cpp into script_test.json.gen?
4112020-10-07T22:09:29  <sanket1729> script_test.json looks auto-generated.
4122020-10-07T22:10:13  <sipa> // Uncomment if you want to output updated JSON tests.
4132020-10-07T22:10:18  <sipa> // #define UPDATE_JSON_TESTS
4142020-10-07T22:10:43  *** vasild has quit IRC
4152020-10-07T22:11:08  <sanket1729> Thanks.
4162020-10-07T22:12:17  *** andreacab has joined #bitcoin-core-dev
4172020-10-07T22:12:17  *** vasild has joined #bitcoin-core-dev
4182020-10-07T22:17:09  *** andreacab has quit IRC
4192020-10-07T22:19:23  *** S3RK has joined #bitcoin-core-dev
4202020-10-07T22:20:24  *** go121212 has joined #bitcoin-core-dev
4212020-10-07T22:23:08  *** go11111111111 has quit IRC
4222020-10-07T22:23:49  *** S3RK has quit IRC
4232020-10-07T22:57:56  <gwillen> I am concerned that #20051 is a sign of things to come, I think the "no loaded wallet" error message needs to clearly spell out the fact that default wallet creation was deprecated and you should call createwallet
4242020-10-07T22:57:57  <gribble> https://github.com/bitcoin/bitcoin/issues/20051 | wallet method is disabled because no wallet is loaded · Issue #20051 · bitcoin/bitcoin · GitHub
4252020-10-07T22:58:22  <gwillen> (by 'things to come' I just mean 'once this gets released, a ton of people are going to be confused by the breakage)
4262020-10-07T22:58:42  <achow101> The error message could be written better
4272020-10-07T22:59:08  <gwillen> I don't know how long RPC error messages are allowed to get, in terms of explanations or pointers to documentation
4282020-10-07T23:01:50  <sipa> at least this long: "Using bumpfee with wallets that have private keys disabled is deprecated. Use psbtbumpfee instead or restart bitcoind with -deprecatedrpc=bumpfee. This functionality will be removed in 0.22"
4292020-10-07T23:03:20  <gwillen> this is possibly too long: "Wallet RPCs are disabled because no wallet is loaded. (NOTE: Bitcoin Core no longer creates a default wallet automatically. Load a wallet using `loadwallet`, or by running bitcoind with `-wallet`; or create a wallet with `createwallet`.)"
4302020-10-07T23:03:57  <gwillen> but that would spell out the general options. (Alternatively, replace the last bit with a link to documentation, if there's a stable link that would work.)
4312020-10-07T23:04:41  <gwillen> alternatively, is there any precedent for having "help foo" entries where foo is not an RPC? If so, we could refer people to "help default_wallet_deprecation" or so.
4322020-10-07T23:07:18  *** shesek has joined #bitcoin-core-dev
4332020-10-07T23:09:12  <achow101> I think it's fine to just say what people can do
4342020-10-07T23:09:21  <achow101> Maybe link to release notes if necessary
4352020-10-07T23:13:50  *** pinheadm_ has quit IRC
4362020-10-07T23:15:15  *** pinheadmz has joined #bitcoin-core-dev
4372020-10-07T23:23:23  *** ares_ has quit IRC
4382020-10-07T23:25:29  *** ares_ has joined #bitcoin-core-dev
4392020-10-07T23:43:55  *** pinheadmz has quit IRC
4402020-10-07T23:44:47  *** pinheadmz has joined #bitcoin-core-dev
4412020-10-07T23:48:54  *** pinheadmz has quit IRC
4422020-10-07T23:50:23  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
4432020-10-07T23:55:56  *** pinheadmz has joined #bitcoin-core-dev
4442020-10-07T23:57:39  *** pinheadmz has quit IRC