12020-10-08T00:00:25  *** DeanGuss has quit IRC
  22020-10-08T00:02:02  *** kristapsk has quit IRC
  32020-10-08T00:02:35  *** Barras2 has quit IRC
  42020-10-08T00:02:49  *** kristapsk has joined #bitcoin-core-dev
  52020-10-08T00:05:50  *** DeanGuss has joined #bitcoin-core-dev
  62020-10-08T00:06:11  *** pinheadmz has joined #bitcoin-core-dev
  72020-10-08T00:14:38  *** pinheadmz has quit IRC
  82020-10-08T00:21:16  *** lugosi1 has joined #bitcoin-core-dev
  92020-10-08T00:29:20  *** pinheadmz has joined #bitcoin-core-dev
 102020-10-08T00:30:11  *** bitcoin-git has joined #bitcoin-core-dev
 112020-10-08T00:30:11  <bitcoin-git> [bitcoin] sanket1729 opened pull request #20100: split policy/error consensus codes for CLEANSTACK, MINAMALIF (master...minimal_if) https://github.com/bitcoin/bitcoin/pull/20100
 122020-10-08T00:30:12  *** bitcoin-git has left #bitcoin-core-dev
 132020-10-08T00:48:15  *** davec has quit IRC
 142020-10-08T00:48:37  *** S3RK has joined #bitcoin-core-dev
 152020-10-08T00:53:44  *** davec has joined #bitcoin-core-dev
 162020-10-08T01:00:49  *** AaronvanW has quit IRC
 172020-10-08T01:04:33  *** S3RK has quit IRC
 182020-10-08T01:05:07  *** pinheadmz has quit IRC
 192020-10-08T01:17:28  *** tralfaz has joined #bitcoin-core-dev
 202020-10-08T01:20:23  *** davterra has quit IRC
 212020-10-08T01:20:40  *** tralfaz is now known as davterra
 222020-10-08T01:21:56  *** mol_ has joined #bitcoin-core-dev
 232020-10-08T01:25:25  *** mol has quit IRC
 242020-10-08T01:27:43  *** Eagle[TM] has joined #bitcoin-core-dev
 252020-10-08T01:28:49  *** EagleTM has quit IRC
 262020-10-08T01:35:53  *** AaronvanW has joined #bitcoin-core-dev
 272020-10-08T01:38:24  *** dr-orlovsky has quit IRC
 282020-10-08T01:39:12  *** bitcoin-git has joined #bitcoin-core-dev
 292020-10-08T01:39:12  <bitcoin-git> [bitcoin] achow101 opened pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
 302020-10-08T01:39:13  *** bitcoin-git has left #bitcoin-core-dev
 312020-10-08T01:39:21  <achow101> gwillen: ^
 322020-10-08T01:40:25  *** AaronvanW has quit IRC
 332020-10-08T01:43:10  *** pinheadmz has joined #bitcoin-core-dev
 342020-10-08T02:05:14  *** kristapsk has quit IRC
 352020-10-08T02:06:51  *** kristapsk has joined #bitcoin-core-dev
 362020-10-08T02:11:23  *** AaronvanW has joined #bitcoin-core-dev
 372020-10-08T02:13:50  *** andreacab has joined #bitcoin-core-dev
 382020-10-08T02:18:27  *** andreacab has quit IRC
 392020-10-08T02:35:38  *** rc_423 has quit IRC
 402020-10-08T02:36:21  *** rc_423 has joined #bitcoin-core-dev
 412020-10-08T02:44:32  *** AaronvanW has quit IRC
 422020-10-08T02:47:28  *** pinheadmz has quit IRC
 432020-10-08T02:49:19  *** pinheadmz has joined #bitcoin-core-dev
 442020-10-08T03:00:02  *** lugosi1 has quit IRC
 452020-10-08T03:12:46  *** tralfaz has joined #bitcoin-core-dev
 462020-10-08T03:12:54  *** davterra has quit IRC
 472020-10-08T03:13:02  *** tralfaz is now known as davterra
 482020-10-08T03:25:55  *** justanotheruser has quit IRC
 492020-10-08T03:26:27  *** pinheadmz has quit IRC
 502020-10-08T03:41:39  *** proofofkeags has quit IRC
 512020-10-08T03:42:30  *** justanotheruser has joined #bitcoin-core-dev
 522020-10-08T03:43:21  *** pinheadmz has joined #bitcoin-core-dev
 532020-10-08T03:55:02  *** xPaw1 has joined #bitcoin-core-dev
 542020-10-08T03:55:33  *** da39a3ee5e6b4b0d has quit IRC
 552020-10-08T04:06:03  *** S3RK has joined #bitcoin-core-dev
 562020-10-08T04:20:12  *** rjected_ has quit IRC
 572020-10-08T04:23:07  *** justanotheruser has quit IRC
 582020-10-08T04:30:51  *** dermoth has quit IRC
 592020-10-08T04:31:14  *** dermoth has joined #bitcoin-core-dev
 602020-10-08T04:34:04  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
 612020-10-08T04:41:11  *** AaronvanW has joined #bitcoin-core-dev
 622020-10-08T04:43:31  *** S3RK has quit IRC
 632020-10-08T04:50:29  *** S3RK has joined #bitcoin-core-dev
 642020-10-08T04:54:48  *** brianhoffman_ has joined #bitcoin-core-dev
 652020-10-08T04:56:10  *** brianhoffman has quit IRC
 662020-10-08T04:56:11  *** brianhoffman_ is now known as brianhoffman
 672020-10-08T04:57:25  *** molz_ has joined #bitcoin-core-dev
 682020-10-08T05:00:41  *** mol_ has quit IRC
 692020-10-08T05:10:06  *** mol has joined #bitcoin-core-dev
 702020-10-08T05:12:44  *** molz_ has quit IRC
 712020-10-08T05:14:29  *** AaronvanW has quit IRC
 722020-10-08T05:14:38  *** mol has quit IRC
 732020-10-08T05:15:24  *** GankMove has joined #bitcoin-core-dev
 742020-10-08T05:52:46  *** S3RK has quit IRC
 752020-10-08T06:00:02  *** xPaw1 has quit IRC
 762020-10-08T06:07:35  *** tralfaz has joined #bitcoin-core-dev
 772020-10-08T06:09:43  *** davterra has quit IRC
 782020-10-08T06:15:29  *** andreacab has joined #bitcoin-core-dev
 792020-10-08T06:19:47  *** andreacab has quit IRC
 802020-10-08T06:21:23  *** leoburd has joined #bitcoin-core-dev
 812020-10-08T06:35:29  *** kyoo[m] has quit IRC
 822020-10-08T06:35:33  *** snowkeld[m] has quit IRC
 832020-10-08T06:35:35  *** RaphalBentgeac[m has quit IRC
 842020-10-08T06:35:44  *** Pasta[m] has quit IRC
 852020-10-08T06:35:53  *** rcrtn32002[m] has quit IRC
 862020-10-08T06:35:55  *** sethrogers23[m] has quit IRC
 872020-10-08T06:35:55  *** TheFuzzStone[m] has quit IRC
 882020-10-08T06:35:56  *** tianshi[m] has quit IRC
 892020-10-08T06:40:56  *** Guyver2 has joined #bitcoin-core-dev
 902020-10-08T06:42:31  *** icota[m] has joined #bitcoin-core-dev
 912020-10-08T06:45:51  *** andreacab has joined #bitcoin-core-dev
 922020-10-08T07:00:11  *** sethrogers23[m] has joined #bitcoin-core-dev
 932020-10-08T07:00:11  *** TheFuzzStone[m] has joined #bitcoin-core-dev
 942020-10-08T07:00:12  *** rcrtn32002[m] has joined #bitcoin-core-dev
 952020-10-08T07:00:12  *** snowkeld[m] has joined #bitcoin-core-dev
 962020-10-08T07:00:12  *** kyoo[m] has joined #bitcoin-core-dev
 972020-10-08T07:00:13  *** icota[m] has left #bitcoin-core-dev
 982020-10-08T07:00:17  *** tianshi[m] has joined #bitcoin-core-dev
 992020-10-08T07:00:17  *** RaphalBentgeac[m has joined #bitcoin-core-dev
1002020-10-08T07:00:18  *** Pasta[m] has joined #bitcoin-core-dev
1012020-10-08T07:11:53  *** AaronvanW has joined #bitcoin-core-dev
1022020-10-08T07:30:20  *** S3RK has joined #bitcoin-core-dev
1032020-10-08T07:31:47  *** andreacab has quit IRC
1042020-10-08T07:31:54  *** andreacab has joined #bitcoin-core-dev
1052020-10-08T07:32:17  *** DeanGuss has quit IRC
1062020-10-08T07:32:40  *** DeanGuss has joined #bitcoin-core-dev
1072020-10-08T07:33:00  *** RaphalBentgeac[m has quit IRC
1082020-10-08T07:33:01  *** sethrogers23[m] has quit IRC
1092020-10-08T07:33:01  *** leoburd has quit IRC
1102020-10-08T07:33:01  *** jonatack has quit IRC
1112020-10-08T07:33:01  *** dergoegge has quit IRC
1122020-10-08T07:33:01  *** hsmiths has quit IRC
1132020-10-08T07:33:01  *** mariorz has quit IRC
1142020-10-08T07:33:01  *** noganoo has quit IRC
1152020-10-08T07:33:01  *** kallewoof has quit IRC
1162020-10-08T07:34:44  *** emzy_ has joined #bitcoin-core-dev
1172020-10-08T07:37:04  *** RaphalBentgeac[m has joined #bitcoin-core-dev
1182020-10-08T07:37:35  *** sethrogers23[m] has joined #bitcoin-core-dev
1192020-10-08T07:38:32  *** dergoegge has joined #bitcoin-core-dev
1202020-10-08T07:38:32  *** hsmiths has joined #bitcoin-core-dev
1212020-10-08T07:38:32  *** mariorz has joined #bitcoin-core-dev
1222020-10-08T07:38:32  *** noganoo has joined #bitcoin-core-dev
1232020-10-08T07:38:32  *** kallewoof has joined #bitcoin-core-dev
1242020-10-08T07:44:24  *** AaronvanW has quit IRC
1252020-10-08T07:44:58  *** andreacab has quit IRC
1262020-10-08T07:45:24  *** andreacab has joined #bitcoin-core-dev
1272020-10-08T07:46:55  *** mol has joined #bitcoin-core-dev
1282020-10-08T07:50:19  *** andreacab has quit IRC
1292020-10-08T07:54:10  *** andreacab has joined #bitcoin-core-dev
1302020-10-08T07:55:52  *** andreacab has quit IRC
1312020-10-08T07:58:03  *** andreacab has joined #bitcoin-core-dev
1322020-10-08T08:05:35  *** Pavlenex has joined #bitcoin-core-dev
1332020-10-08T08:09:25  *** jonatack has joined #bitcoin-core-dev
1342020-10-08T08:10:20  *** promag has joined #bitcoin-core-dev
1352020-10-08T08:10:31  *** Pavlenex has quit IRC
1362020-10-08T08:25:14  *** Harekiet1 has joined #bitcoin-core-dev
1372020-10-08T08:29:05  *** Pavlenex has joined #bitcoin-core-dev
1382020-10-08T08:31:26  *** AaronvanW has joined #bitcoin-core-dev
1392020-10-08T08:33:43  *** da39a3ee5e6b4b0d has quit IRC
1402020-10-08T08:34:22  *** promag has quit IRC
1412020-10-08T08:34:54  *** mrostecki has joined #bitcoin-core-dev
1422020-10-08T08:35:01  <wumpus> the release notes should not be considered documentation, and it's good if the program is self-contained, I'd greatly prefer linking to some actual documentation instead-like the help text of options or other RPC calls
1432020-10-08T08:35:06  *** rc_423 has quit IRC
1442020-10-08T08:35:14  *** da39a3ee5e6b4b0d has joined #bitcoin-core-dev
1452020-10-08T08:35:28  *** Pavlenex has joined #bitcoin-core-dev
1462020-10-08T08:35:57  *** promag has joined #bitcoin-core-dev
1472020-10-08T08:36:02  *** rc_423 has joined #bitcoin-core-dev
1482020-10-08T08:37:20  *** S3RK has quit IRC
1492020-10-08T08:37:43  *** promag has quit IRC
1502020-10-08T08:40:25  *** da39a3ee5e6b4b0d has quit IRC
1512020-10-08T08:45:14  *** S3RK has joined #bitcoin-core-dev
1522020-10-08T08:52:25  *** Pavlenex has quit IRC
1532020-10-08T08:54:22  *** opsec_x12 has quit IRC
1542020-10-08T08:54:49  *** opsec_x12 has joined #bitcoin-core-dev
1552020-10-08T09:00:02  *** Harekiet1 has quit IRC
1562020-10-08T09:03:03  *** Pavlenex has joined #bitcoin-core-dev
1572020-10-08T09:15:15  *** belcher has quit IRC
1582020-10-08T09:15:38  *** AaronvanW has quit IRC
1592020-10-08T09:16:35  *** AaronvanW has joined #bitcoin-core-dev
1602020-10-08T09:20:17  *** AaronvanW has quit IRC
1612020-10-08T09:20:35  *** AaronvanW has joined #bitcoin-core-dev
1622020-10-08T09:22:12  *** sirkitree has joined #bitcoin-core-dev
1632020-10-08T09:24:27  *** belcher has joined #bitcoin-core-dev
1642020-10-08T09:27:42  *** belcher_ has joined #bitcoin-core-dev
1652020-10-08T09:28:18  *** belcher has quit IRC
1662020-10-08T09:40:22  *** Pavlenex has quit IRC
1672020-10-08T09:40:32  *** bitcoin-git has joined #bitcoin-core-dev
1682020-10-08T09:40:33  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/283a73d7eaea...9dd4de2832e2
1692020-10-08T09:40:33  <bitcoin-git> bitcoin/master ec3916f Pieter Wuille: Use mockable time everywhere in net_processing
1702020-10-08T09:40:34  <bitcoin-git> bitcoin/master b6834e3 Pieter Wuille: Avoid 'timing mishap' warnings when mocking
1712020-10-08T09:40:34  <bitcoin-git> bitcoin/master 9dd4de2 MarcoFalke: Merge #20027: Use mockable time everywhere in net_processing
1722020-10-08T09:40:36  *** bitcoin-git has left #bitcoin-core-dev
1732020-10-08T09:40:52  *** bitcoin-git has joined #bitcoin-core-dev
1742020-10-08T09:40:52  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
1752020-10-08T09:40:53  *** bitcoin-git has left #bitcoin-core-dev
1762020-10-08T09:45:50  *** andreacab has quit IRC
1772020-10-08T09:46:18  *** andreacab has joined #bitcoin-core-dev
1782020-10-08T09:46:56  *** Pavlenex has joined #bitcoin-core-dev
1792020-10-08T09:49:30  *** Pavlenex has quit IRC
1802020-10-08T09:50:58  *** andreacab has quit IRC
1812020-10-08T09:51:02  *** andreaca_ has joined #bitcoin-core-dev
1822020-10-08T09:55:55  *** jonatack has quit IRC
1832020-10-08T10:00:16  *** dermoth has quit IRC
1842020-10-08T10:06:25  *** belcher has joined #bitcoin-core-dev
1852020-10-08T10:09:08  *** belcher_ has quit IRC
1862020-10-08T10:10:23  *** vasild has quit IRC
1872020-10-08T10:12:17  *** dermoth has joined #bitcoin-core-dev
1882020-10-08T10:12:18  *** vasild has joined #bitcoin-core-dev
1892020-10-08T10:13:48  *** bitcoin-git has joined #bitcoin-core-dev
1902020-10-08T10:13:48  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
1912020-10-08T10:13:49  *** bitcoin-git has left #bitcoin-core-dev
1922020-10-08T10:16:33  *** vincenzopalazzo has joined #bitcoin-core-dev
1932020-10-08T10:18:25  *** Elenor20Ziemann has joined #bitcoin-core-dev
1942020-10-08T10:21:04  *** andreaca_ has quit IRC
1952020-10-08T10:21:30  *** andreacab has joined #bitcoin-core-dev
1962020-10-08T10:23:02  *** andreaca_ has joined #bitcoin-core-dev
1972020-10-08T10:25:27  *** andreacab has quit IRC
1982020-10-08T10:33:55  *** andreaca_ has quit IRC
1992020-10-08T10:34:47  *** andreacab has joined #bitcoin-core-dev
2002020-10-08T10:35:17  *** kallewoof has quit IRC
2012020-10-08T10:35:24  *** kallewoof has joined #bitcoin-core-dev
2022020-10-08T10:36:00  *** emzy_ has quit IRC
2032020-10-08T10:36:00  *** Pavlenex has joined #bitcoin-core-dev
2042020-10-08T10:36:48  *** kallewoof has quit IRC
2052020-10-08T10:36:50  *** kallewoof_ has joined #bitcoin-core-dev
2062020-10-08T10:37:31  *** worc3131 has quit IRC
2072020-10-08T10:38:15  *** Pavlenex has quit IRC
2082020-10-08T10:39:23  *** andreacab has quit IRC
2092020-10-08T10:40:43  *** sdaftuar has quit IRC
2102020-10-08T10:42:40  *** S3RK has quit IRC
2112020-10-08T10:42:55  *** S3RK has joined #bitcoin-core-dev
2122020-10-08T10:44:18  *** sdaftuar has joined #bitcoin-core-dev
2132020-10-08T10:49:45  <wumpus> but no, there is no precedent for help options that are not RPC, and I'm not sure that's a good idea to introduce, it feels to me a kind of cluttery to use RPC help for that, it does reveal our lack of a more general user documentation. As a workaround isn't there some existing RPC where is would be appropriate?
2142020-10-08T10:49:51  <wumpus> to be honest I think that error message is OK
2152020-10-08T10:50:17  <wumpus> it's long but it actually tells something useful
2162020-10-08T10:55:11  *** mrostecki has quit IRC
2172020-10-08T10:58:20  *** mrostecki has joined #bitcoin-core-dev
2182020-10-08T11:14:39  *** andreacab has joined #bitcoin-core-dev
2192020-10-08T11:17:08  *** andreacab has quit IRC
2202020-10-08T11:17:14  *** andreacab has joined #bitcoin-core-dev
2212020-10-08T11:19:22  *** bitcoin-git has joined #bitcoin-core-dev
2222020-10-08T11:19:22  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dd4de2832e2...b337bd7bc087
2232020-10-08T11:19:22  *** andreacab has quit IRC
2242020-10-08T11:19:23  <bitcoin-git> bitcoin/master fae7a1c MarcoFalke: fuzz: Configure check for main function
2252020-10-08T11:19:23  <bitcoin-git> bitcoin/master b337bd7 MarcoFalke: Merge #20065: fuzz: Configure check for main function
2262020-10-08T11:19:25  *** bitcoin-git has left #bitcoin-core-dev
2272020-10-08T11:19:42  *** bitcoin-git has joined #bitcoin-core-dev
2282020-10-08T11:19:42  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20065: fuzz: Configure check for main function (master...2010-fuzzMainConfig) https://github.com/bitcoin/bitcoin/pull/20065
2292020-10-08T11:19:44  *** bitcoin-git has left #bitcoin-core-dev
2302020-10-08T11:20:02  *** bitcoin-git has joined #bitcoin-core-dev
2312020-10-08T11:20:02  <bitcoin-git> [bitcoin] jnewbery opened pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
2322020-10-08T11:20:03  *** bitcoin-git has left #bitcoin-core-dev
2332020-10-08T11:20:15  *** andreacab has joined #bitcoin-core-dev
2342020-10-08T11:20:50  *** andreacab has joined #bitcoin-core-dev
2352020-10-08T11:21:26  *** promag has joined #bitcoin-core-dev
2362020-10-08T11:25:43  *** S3RK has quit IRC
2372020-10-08T11:26:08  *** promag has quit IRC
2382020-10-08T11:26:55  *** andreacab has quit IRC
2392020-10-08T11:31:12  *** roconnor has joined #bitcoin-core-dev
2402020-10-08T11:35:31  *** jeremyrubin has quit IRC
2412020-10-08T11:43:48  *** mrostecki has quit IRC
2422020-10-08T11:44:09  *** mrostecki has joined #bitcoin-core-dev
2432020-10-08T11:54:06  *** S3RK has joined #bitcoin-core-dev
2442020-10-08T11:55:20  *** andreacab has joined #bitcoin-core-dev
2452020-10-08T11:58:44  *** S3RK has quit IRC
2462020-10-08T12:00:02  *** sirkitree has quit IRC
2472020-10-08T12:00:29  *** andreacab has quit IRC
2482020-10-08T12:21:35  *** dr-orlovsky has joined #bitcoin-core-dev
2492020-10-08T12:22:02  *** Lthere has joined #bitcoin-core-dev
2502020-10-08T12:23:21  *** mrostecki has quit IRC
2512020-10-08T12:25:28  <hebasto> for those who could be interested in Qt code -- https://github.com/users/hebasto/projects/1
2522020-10-08T12:26:05  *** sdaftuar has quit IRC
2532020-10-08T12:26:28  *** sdaftuar has joined #bitcoin-core-dev
2542020-10-08T12:27:56  *** andreacab has joined #bitcoin-core-dev
2552020-10-08T12:32:47  *** andreacab has quit IRC
2562020-10-08T12:41:21  *** promag has joined #bitcoin-core-dev
2572020-10-08T12:45:49  *** promag has quit IRC
2582020-10-08T12:50:28  *** Elenor20Ziemann has quit IRC
2592020-10-08T12:54:06  *** bitcoin-git has joined #bitcoin-core-dev
2602020-10-08T12:54:06  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
2612020-10-08T12:54:06  *** sr_gi has quit IRC
2622020-10-08T12:54:07  *** bitcoin-git has left #bitcoin-core-dev
2632020-10-08T12:54:45  *** sr_gi has joined #bitcoin-core-dev
2642020-10-08T12:57:02  *** tralfaz is now known as davterra
2652020-10-08T13:00:12  *** kallewoof_ has left #bitcoin-core-dev
2662020-10-08T13:00:56  *** kallewoof has joined #bitcoin-core-dev
2672020-10-08T13:02:40  <sdaftuar> rt
2682020-10-08T13:03:35  * sdaftuar notes that could have been worse
2692020-10-08T13:08:58  *** bitcoin-git has joined #bitcoin-core-dev
2702020-10-08T13:08:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b337bd7bc087...392c6f4fb253
2712020-10-08T13:08:59  <bitcoin-git> bitcoin/master 907f142 Andrew Chow: rpc: change no wallet loaded message to be clearer
2722020-10-08T13:09:00  <bitcoin-git> bitcoin/master 392c6f4 MarcoFalke: Merge #20101: rpc: change no wallet loaded message to be clearer
2732020-10-08T13:09:02  *** bitcoin-git has left #bitcoin-core-dev
2742020-10-08T13:09:18  *** bitcoin-git has joined #bitcoin-core-dev
2752020-10-08T13:09:18  <bitcoin-git> [bitcoin] MarcoFalke merged pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
2762020-10-08T13:09:24  *** bitcoin-git has left #bitcoin-core-dev
2772020-10-08T13:12:18  *** bitcoin-git has joined #bitcoin-core-dev
2782020-10-08T13:12:18  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #20107: doc: Collect release-notes snippets (master...2010-docRelSnip) https://github.com/bitcoin/bitcoin/pull/20107
2792020-10-08T13:12:20  *** bitcoin-git has left #bitcoin-core-dev
2802020-10-08T13:22:23  *** yanmaani has quit IRC
2812020-10-08T13:35:27  *** yanmaani has joined #bitcoin-core-dev
2822020-10-08T13:43:24  *** mrostecki has joined #bitcoin-core-dev
2832020-10-08T13:45:34  *** andreacab has joined #bitcoin-core-dev
2842020-10-08T13:46:15  *** andreaca_ has joined #bitcoin-core-dev
2852020-10-08T13:47:49  *** roconnor has quit IRC
2862020-10-08T13:50:08  *** andreacab has quit IRC
2872020-10-08T13:54:18  *** kexkey has joined #bitcoin-core-dev
2882020-10-08T13:55:46  *** andreaca_ has quit IRC
2892020-10-08T13:56:12  *** andreacab has joined #bitcoin-core-dev
2902020-10-08T14:00:27  *** andreacab has quit IRC
2912020-10-08T14:09:23  *** mrostecki has quit IRC
2922020-10-08T14:11:27  *** dr-orlovsky has quit IRC
2932020-10-08T14:12:44  *** dr-orlovsky has joined #bitcoin-core-dev
2942020-10-08T14:30:00  *** S3RK has joined #bitcoin-core-dev
2952020-10-08T14:32:36  *** proofofkeags has joined #bitcoin-core-dev
2962020-10-08T14:34:05  *** S3RK has quit IRC
2972020-10-08T14:44:43  *** k3tan has quit IRC
2982020-10-08T14:45:04  *** justanotheruser has joined #bitcoin-core-dev
2992020-10-08T14:46:12  *** k3tan has joined #bitcoin-core-dev
3002020-10-08T15:00:02  *** Lthere has quit IRC
3012020-10-08T15:22:00  *** zacts has joined #bitcoin-core-dev
3022020-10-08T15:22:24  *** zacts is now known as Guest4550
3032020-10-08T15:35:45  *** proofofkeags has quit IRC
3042020-10-08T15:36:48  <dongcarl> vasild, sipa: I might be misremembering, but I recall having a discussion about the versionspace of serializers/unserializers and how we should separate them for different types?
3052020-10-08T15:38:00  <dongcarl> Oh I see that's still being worked on in #19503
3062020-10-08T15:38:04  <gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
3072020-10-08T15:41:34  *** jeremyrubin has joined #bitcoin-core-dev
3082020-10-08T15:44:09  <vasild> yeah
3092020-10-08T15:50:07  *** ghost43 has quit IRC
3102020-10-08T15:50:26  *** ghost43 has joined #bitcoin-core-dev
3112020-10-08T15:52:25  *** jonatack has joined #bitcoin-core-dev
3122020-10-08T15:53:49  <sipa> dongcarl: yeah, but i didn't want to hold up torv3 stuff with that
3132020-10-08T15:53:59  <sipa> so i hacen't pushed for it further
3142020-10-08T15:54:20  <dongcarl> Makes sense!
3152020-10-08T15:57:16  *** palazzovincenzo has joined #bitcoin-core-dev
3162020-10-08T16:00:00  *** vincenzopalazzo has quit IRC
3172020-10-08T16:00:06  *** andreacab has joined #bitcoin-core-dev
3182020-10-08T16:03:50  *** proofofkeags has joined #bitcoin-core-dev
3192020-10-08T16:06:00  *** proofofkeags has quit IRC
3202020-10-08T16:09:13  *** vincenzopalazzo has joined #bitcoin-core-dev
3212020-10-08T16:13:21  *** andreacab has quit IRC
3222020-10-08T16:13:49  *** andreacab has joined #bitcoin-core-dev
3232020-10-08T16:18:18  *** andreacab has quit IRC
3242020-10-08T16:18:47  *** Guest4550 has quit IRC
3252020-10-08T16:26:17  *** Talkless has joined #bitcoin-core-dev
3262020-10-08T16:33:52  *** icota[m] has joined #bitcoin-core-dev
3272020-10-08T16:37:35  *** Ga1aCt1Cz00_ has joined #bitcoin-core-dev
3282020-10-08T16:41:41  *** Ga1aCt1Cz00 has quit IRC
3292020-10-08T16:58:04  *** hari1 has joined #bitcoin-core-dev
3302020-10-08T17:07:08  <wumpus> #19503 and TorV3 would be an interesting combination, but yes I don't think they should hold up each other
3312020-10-08T17:07:11  <gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
3322020-10-08T17:33:49  *** filchef has joined #bitcoin-core-dev
3332020-10-08T17:49:42  *** andreacab has joined #bitcoin-core-dev
3342020-10-08T18:00:02  *** hari1 has quit IRC
3352020-10-08T18:22:09  *** variable has joined #bitcoin-core-dev
3362020-10-08T18:22:11  *** variable is now known as Guest36719
3372020-10-08T18:33:30  *** andreacab has quit IRC
3382020-10-08T18:33:57  *** andreacab has joined #bitcoin-core-dev
3392020-10-08T18:38:18  *** andreacab has quit IRC
3402020-10-08T18:42:53  *** bitcoin-git has joined #bitcoin-core-dev
3412020-10-08T18:42:54  <bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/392c6f4fb253...d9de00b3e067
3422020-10-08T18:42:54  <bitcoin-git> bitcoin/master 1afcd41 John Newbery: [net] Remove CombinerAll
3432020-10-08T18:42:55  <bitcoin-git> bitcoin/master d9de00b Wladimir J. van der Laan: Merge #20105: [net] Remove CombinerAll
3442020-10-08T18:42:57  *** bitcoin-git has left #bitcoin-core-dev
3452020-10-08T18:43:13  *** bitcoin-git has joined #bitcoin-core-dev
3462020-10-08T18:43:13  <bitcoin-git> [bitcoin] laanwj merged pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
3472020-10-08T18:43:14  *** bitcoin-git has left #bitcoin-core-dev
3482020-10-08T18:45:30  *** vincenzopalazzo has quit IRC
3492020-10-08T18:57:38  *** S3RK has joined #bitcoin-core-dev
3502020-10-08T18:58:44  *** jonasschnelli has quit IRC
3512020-10-08T18:58:45  *** jonasschnelli has joined #bitcoin-core-dev
3522020-10-08T19:01:35  <aj> meeting?
3532020-10-08T19:01:37  <jnewbery> e
3542020-10-08T19:02:11  <sipa> hi
3552020-10-08T19:02:14  <jonasschnelli> hi
3562020-10-08T19:02:24  *** S3RK has quit IRC
3572020-10-08T19:02:29  *** andreacab has joined #bitcoin-core-dev
3582020-10-08T19:02:35  <wumpus> #startmeeting
3592020-10-08T19:02:35  <lightningbot> Meeting started Thu Oct  8 19:02:35 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
3602020-10-08T19:02:35  <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
3612020-10-08T19:02:37  <jnewbery> hi
3622020-10-08T19:02:40  <hebasto> hi
3632020-10-08T19:02:52  <aj> hiiii
3642020-10-08T19:02:55  <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
3652020-10-08T19:02:57  <wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
3662020-10-08T19:03:04  <meshcollider> hi
3672020-10-08T19:03:13  <jonatack> ciao
3682020-10-08T19:03:27  <luke-jr> hi
3692020-10-08T19:04:15  <wumpus> FWIW: the 0.21 feature freeze is in a week, it probably makes more sense to discuss what is tagged for the 0.21 milestone as high priority for review at this point
3702020-10-08T19:04:25  <wumpus> this is https://github.com/bitcoin/bitcoin/milestone/45
3712020-10-08T19:06:05  <sipa> that's a long list
3722020-10-08T19:06:12  <wumpus> it looks like no other topics have been proposed for this week
3732020-10-08T19:06:15  <jonasschnelli> How is the merge back of the GUI repository handled? MarcoFalke?
3742020-10-08T19:06:19  <wumpus> yes, it's also likely outdated
3752020-10-08T19:06:22  <jonasschnelli> (Regarding freeze)
3762020-10-08T19:06:37  <wumpus> which makes it good to go over it I suppose
3772020-10-08T19:06:55  <vasild> hi
3782020-10-08T19:07:30  <wumpus> and at least two of the issues are simply 'follow release process'
3792020-10-08T19:07:38  <sipa> i think #19954 is pretty much done
3802020-10-08T19:07:41  <gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
3812020-10-08T19:07:56  <wumpus> yes
3822020-10-08T19:08:08  <hebasto> #18077 and #18710 could be moved to 0.22
3832020-10-08T19:08:10  <gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
3842020-10-08T19:08:13  <gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
3852020-10-08T19:08:28  <wumpus> hebasto: ok, thanks
3862020-10-08T19:08:38  <aj> #19543 doesn't have an associated PR yet?
3872020-10-08T19:08:40  <gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
3882020-10-08T19:08:42  <nehan> 5
3892020-10-08T19:09:00  <nehan> (typo)
3902020-10-08T19:09:04  <jonatack> i've been focusing on #19953 the past day or so as it seems to be the highest priority along with tor v3
3912020-10-08T19:09:07  <gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
3922020-10-08T19:09:39  <jonatack> aj: i planned to do #19543 after FF as it's a bugfix
3932020-10-08T19:09:40  <gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
3942020-10-08T19:09:51  <hebasto> two drafts also could be moved?
3952020-10-08T19:09:53  <sipa> all todos are done for taproot, including the json tests in the qa-assets repo
3962020-10-08T19:09:59  <wumpus> jonatack: so that one needs 0.21 milestone?
3972020-10-08T19:10:16  <wumpus> aj: seems like it, but also seems not urgent for 0.21?
3982020-10-08T19:11:04  <wumpus> aj: oh "This needs to happen before the next major release. Otherwise, it will be a breaking change."
3992020-10-08T19:11:05  *** vasild has quit IRC
4002020-10-08T19:11:06  *** vasild_ has joined #bitcoin-core-dev
4012020-10-08T19:11:09  <aj> wumpus: yeah
4022020-10-08T19:11:12  <wumpus> ping MarcoFalke
4032020-10-08T19:11:12  *** vasild_ is now known as vasild
4042020-10-08T19:11:28  <sipa> wumpus: i'd very much like to get taproot in 0.21, as the alternative (i expect) is that we'll want it early in 0.22 anyway, which will just complicate backports
4052020-10-08T19:11:51  <sipa> (the code, not activation obviously)
4062020-10-08T19:12:03  <wumpus> hebasto: done
4072020-10-08T19:12:14  <wumpus> sipa: agree!
4082020-10-08T19:12:48  <jonatack> +1
4092020-10-08T19:13:59  <meshcollider> I feel like we should really push for #19077 if possible just to have it in the same version as descriptor wallets like we discussed
4102020-10-08T19:14:02  <gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
4112020-10-08T19:14:09  <meshcollider> But it's a big PR
4122020-10-08T19:14:28  <sipa> i haven't paid attention to the PR itself, but it seems it's been making lots of progress lately, including review
4132020-10-08T19:14:45  <meshcollider> Yeah it's had a decent amount of review already so it's not infeasible
4142020-10-08T19:15:05  <sipa> i know wumpus had reservations about having it in 0.21
4152020-10-08T19:15:24  <wumpus> looks like we're starting to run into issues building bdb 4.8 on some platforms at least: #19411
4162020-10-08T19:15:26  <gribble> https://github.com/bitcoin/bitcoin/issues/19411 | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 · Issue #19411 · bitcoin/bitcoin · GitHub
4172020-10-08T19:16:01  <wumpus> sipa: yes, it seems fairly risky to introduce a new wallet database format (which is used by default) in something last minute
4182020-10-08T19:16:03  <sipa> --with-incompatible-bdb lalala
4192020-10-08T19:16:23  <achow101> wumpus: it's only used by descriptor wallets which we already have marked as "experimental"
4202020-10-08T19:16:35  <wumpus> achow101: they're not created by default for new users?
4212020-10-08T19:16:39  <achow101> no
4222020-10-08T19:16:41  <wumpus> in that case I"m oay with it
4232020-10-08T19:17:02  <sipa> ah, descriptor wallets are not default for new wallets?
4242020-10-08T19:17:07  <achow101> not yet
4252020-10-08T19:17:25  <sipa> that's perhaps the best of both worlds... get descriptor wallets and sqlite in 0.21, but neither is default
4262020-10-08T19:17:37  <wumpus> if it's opt-in I see no problem
4272020-10-08T19:18:27  <achow101> if descriptor wallets were the default, a lot of tests would be failing :p
4282020-10-08T19:20:46  <wumpus> wrt #20005 I'm not convinced we should do anything for it, the particular issue doesn't affect anything in our project and clearly in the longer run it's better left solved upstream
4292020-10-08T19:20:47  <gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
4302020-10-08T19:21:36  *** Talkless has quit IRC
4312020-10-08T19:21:54  <sipa> agree
4322020-10-08T19:22:11  <sipa> it's good to continue discussing the options, but i don't think there is urgency
4332020-10-08T19:22:22  <wumpus> sure, but removing the milestone then
4342020-10-08T19:22:22  <sipa> we're not using gcc 9 or gcc 10 for releases either, i believe?
4352020-10-08T19:23:17  <wumpus> no, 8 at most
4362020-10-08T19:23:41  <hebasto> 7.4 for linux x86_64
4372020-10-08T19:25:24  <wumpus> yes, correct
4382020-10-08T19:25:35  *** Pavlenex has joined #bitcoin-core-dev
4392020-10-08T19:25:42  <wumpus> otherwise there's agreement what is on the milestone right now?
4402020-10-08T19:26:48  <sipa> not everything will make it, but sure
4412020-10-08T19:27:11  <sipa> i'm also hoping for 19988
4422020-10-08T19:27:23  <sipa> given the amount of review it's had the past days
4432020-10-08T19:27:58  <jnewbery> I think 19988 is ready. It has three or four recent ACKs now
4442020-10-08T19:28:22  <meshcollider> #19988
4452020-10-08T19:28:25  <gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
4462020-10-08T19:29:03  <sipa> 50% test code :)
4472020-10-08T19:29:20  <wumpus> added to milestone anyway
4482020-10-08T19:29:25  <sipa> thanks!
4492020-10-08T19:30:44  <sipa> unrelated: i've noticed that sometimes clicking "show resolved" on github expands everything, and sometimes not
4502020-10-08T19:30:57  <sipa> does anyone else have this, or know how it's caused?
4512020-10-08T19:30:58  <achow101> #16463 could be removed from the milestone I guess
4522020-10-08T19:31:01  <gribble> https://github.com/bitcoin/bitcoin/issues/16463 | [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101 · Pull Request #16463 · bitcoin/bitcoin · GitHub
4532020-10-08T19:31:31  <wumpus> ok done
4542020-10-08T19:32:41  <wumpus> any other topics for today?
4552020-10-08T19:33:03  <jnewbery> I have a question about c++17
4562020-10-08T19:33:42  <aj> wumpus: you pinged about moving https://github.com/users/ajtowns/projects/1 under bitcoin/ ; happy to, might be nice to move the automation into drahtbot at the same time
4572020-10-08T19:34:04  <jnewbery> we're planning to move to c++17 (remove c++11 compat) in v0.21: https://github.com/bitcoin/bitcoin/issues/16684
4582020-10-08T19:34:18  <wumpus> no, in 0.22 right?
4592020-10-08T19:34:33  <wumpus> 0.21 introduces c++17 compilation by default
4602020-10-08T19:34:36  <jnewbery> oops sorry, yes v0.22
4612020-10-08T19:34:47  <wumpus> 0.22 is c++17 only
4622020-10-08T19:34:49  <wumpus> okay
4632020-10-08T19:35:04  *** andreacab has quit IRC
4642020-10-08T19:35:04  <jnewbery> so after v0.21 branch we're theoretically free to use c++17 features throughout the codebase
4652020-10-08T19:35:05  *** Eagle[TM] has quit IRC
4662020-10-08T19:35:11  <wumpus> yes
4672020-10-08T19:35:29  *** andreacab has joined #bitcoin-core-dev
4682020-10-08T19:35:29  <jnewbery> My question was whether it makes sense to try to keep c++11 compatability for consensus code for longer
4692020-10-08T19:35:40  <wumpus> for new code definitely, as for c++11, please don't file PRs to convert all old code at once
4702020-10-08T19:35:49  <wumpus> for the sake of doing so
4712020-10-08T19:36:09  <wumpus> there's no *need* for any compatibility with c++11 anymore
4722020-10-08T19:36:12  <jnewbery> ie use c++17 features in net processing/wallet/etc, but try to keep consensus code on c++11 for longer
4732020-10-08T19:36:59  <jnewbery> given that apparently compilers have bugs it might make sense to be more conservative with upgrading to the latest features in consensus
4742020-10-08T19:37:06  <wumpus> I think that will make things really complicated, even defining what is 'consensus code' is pretty hard right now
4752020-10-08T19:37:12  <jnewbery> but it's just a half-baked thought
4762020-10-08T19:37:41  <jnewbery> wumpus: right. It'd be nice if that separation were clearer
4772020-10-08T19:37:46  <wumpus> or do you only mean 'what is part of libconsensus'
4782020-10-08T19:38:01  <wumpus> dongcarl's libbitcoinkernel is a nice idea but it's only an idea right now
4792020-10-08T19:38:21  *** Pavlenex1 has joined #bitcoin-core-dev
4802020-10-08T19:38:50  <aj> libbitcoinkernel? no hits on google
4812020-10-08T19:38:51  <wumpus> yes, it'd be nice but definitely not around the corner, I don't think it's in any shape to make C++ version depend on it
4822020-10-08T19:39:12  <wumpus> agree with regard to bugs though
4832020-10-08T19:39:16  <sipa> almost all of C++17 is in GCC 7, and all of it is in GCC 8
4842020-10-08T19:39:18  <wumpus> everything is broken let' go shopping
4852020-10-08T19:39:50  <sipa> so i'd agree as far as being conservative w.r.t. C++ features in consensus-critical code, but i don't think that's necessarily a new idea
4862020-10-08T19:39:56  <sipa> we always want to be conservative there
4872020-10-08T19:40:15  <sipa> i don't think we need a "this subset of the code must remain c++11 compatible" rule
4882020-10-08T19:40:17  *** andreacab has quit IRC
4892020-10-08T19:40:29  <sipa> whether enforced or not
4902020-10-08T19:40:44  <wumpus> I really thin kwe should make one decision for the entire codebase
4912020-10-08T19:40:53  <sipa> agree
4922020-10-08T19:41:07  <wumpus> if the recent discovery means that new versions of C++ are unsafe, that means, let's just give up on C++17 for now
4932020-10-08T19:41:17  <sipa> i don't think so
4942020-10-08T19:41:24  <wumpus> I don't particularly want the P2P code to be unsafe either
4952020-10-08T19:41:27  *** Pavlenex has quit IRC
4962020-10-08T19:41:27  *** Pavlenex1 is now known as Pavlenex
4972020-10-08T19:41:31  <sipa> it's a bug in a C89 feature FFS
4982020-10-08T19:41:34  <jnewbery> sipa: does it make sense to codify what you mean by 'conservative w.r.t c++ features in consensus-critical code'?
4992020-10-08T19:42:00  <wumpus> we don't have suffiient separateion of consensus-critical code from anything
5002020-10-08T19:42:03  <wumpus> we need to have that, sure
5012020-10-08T19:42:32  <wumpus> but it's more than you'd expect if you include util and compat and other indirect dependencies
5022020-10-08T19:42:58  <sipa> jnewbery: yeah, i'm trying to think what that would mean
5032020-10-08T19:43:01  <sipa> it's just a thought
5042020-10-08T19:43:26  <wumpus> honestly I think this is completely seperate from the c++17 question
5052020-10-08T19:43:32  <sipa> yes, agree
5062020-10-08T19:43:36  <wumpus> yes, it would be good to isolate the consensus code
5072020-10-08T19:43:54  <wumpus> then again this was a project since, 2012 or so...
5082020-10-08T19:44:19  *** EagleTM has joined #bitcoin-core-dev
5092020-10-08T19:44:25  <wumpus> also: leveldb is part of consensus
5102020-10-08T19:44:29  <sipa> i think the question for C++17 or not just depends on whether we expect build environments that people will want to use for 0.22 support it sufficiently or not
5112020-10-08T19:45:00  <wumpus> it's not like you can build the consensus code separately anyway
5122020-10-08T19:45:16  <sipa> indeed
5132020-10-08T19:45:38  <sipa> we *could* say that libconsensus needs to remain C++11 buildable - but i don't think there is much of a reason for that
5142020-10-08T19:46:05  <wumpus> I don't think so either
5152020-10-08T19:46:33  <wumpus> c++17 is already three years old anyway and most c++ compilers implemented it, or features from it, before that
5162020-10-08T19:46:46  <wumpus> it's not that we're super fast in adopting new c++ standards
5172020-10-08T19:46:48  <sipa> so let's discuss this after 0.21 branch off, whether we think requiring a C++17 build environment will be a problem by the time 0.22 gets released
5182020-10-08T19:47:07  <sipa> indeed
5192020-10-08T19:47:08  <jnewbery> sipa: +1
5202020-10-08T19:47:32  <jonatack> to summarize, if I may: before feature freeze in one week, please review 19953 (BIPs 340-342), 19954 (tor v3), 19988 (tx relay logic), and 19077 (sqlite wallet)
5212020-10-08T19:47:40  <wumpus> seems deviating from our plan here on last minute does need a very good reason though
5222020-10-08T19:47:52  <jnewbery> I am interested in how we judge 'conservative w.r.t c++ features', but not necessarily now
5232020-10-08T19:48:33  <sipa> wumpus: yeah
5242020-10-08T19:48:34  <wumpus> I think we need to be conservative in making changes to the consensus code, not so much specifically regarding c++ features
5252020-10-08T19:48:39  <aj> jnewbery: i think that was just a subset of "conservative in general"
5262020-10-08T19:48:54  <wumpus> right
5272020-10-08T19:49:15  <wumpus> which was also my first reply, don't change code for c++17 for the sake of using c++17
5282020-10-08T19:49:21  <sipa> and perhaps avoid features that reviewers may not be very familiar with - which is correlated but not the same as recently-introduced language features
5292020-10-08T19:49:49  <wumpus> any other topics?
5302020-10-08T19:50:51  <sipa> jonatack: +1
5312020-10-08T19:51:43  *** Pavlenex1 has joined #bitcoin-core-dev
5322020-10-08T19:52:11  <wumpus> honestly I'd feel a lot better if we had focused on isolating the consensus-critical code a long time ago, seems like something people like to talk about but it never really panned out yet
5332020-10-08T19:52:30  <sipa> wumpus: it's... hard
5342020-10-08T19:52:47  *** Pavlenex has quit IRC
5352020-10-08T19:52:47  *** Pavlenex1 is now known as Pavlenex
5362020-10-08T19:52:52  <wumpus> sipa: yes :/
5372020-10-08T19:52:56  <wumpus> jonatack: agree!
5382020-10-08T19:54:09  <jnewbery> wumpus: we're moving in that direction ... slowly. #20049 and #20050 are next
5392020-10-08T19:54:09  <wumpus> sipa: it's hard but maybe one of the things remaining that's really worth doing
5402020-10-08T19:54:10  <gribble> https://github.com/bitcoin/bitcoin/issues/20049 | De-globalizing ChainstateManager · Issue #20049 · bitcoin/bitcoin · GitHub
5412020-10-08T19:54:12  <gribble> https://github.com/bitcoin/bitcoin/issues/20050 | validation: Prune (in)direct g_chainman usage related to ::LookupBlockIndex (bundle 1) by dongcarl · Pull Request #20050 · bitcoin/bitcoin · GitHub
5422020-10-08T19:54:50  <wumpus> jnewbery: I guess the main problem is that isolating the consensus code means changes to the consensus code which is a risk in itself so hard to do
5432020-10-08T19:55:44  <wumpus> jnewbery: but good to know!
5442020-10-08T19:55:48  <aj> wumpus: also that we want to switch between non-consensus and consensus code efficiently in lots of places
5452020-10-08T19:56:34  <sipa> yes, and given previous attempts at refactoring out consensus code ended us more than once is a worse half-baked state, it's harder to get reviewer enthousiasm for such changes
5462020-10-08T19:56:50  <wumpus> aj: yes defining an interface that makes sens in itself but doesn't make things a lot slower is another thing
5472020-10-08T19:57:03  <dongcarl> Definitely non-zero risks, which is why the focus should be on doing it incrementally, and testing it continuously :-)
5482020-10-08T19:57:20  *** EagleTM has quit IRC
5492020-10-08T19:57:36  <wumpus> definitely more interestedi n it than discussions about the icon color though :-)
5502020-10-08T19:57:45  <dongcarl> Hehe
5512020-10-08T19:57:47  <sipa> haha
5522020-10-08T19:57:50  <jonatack> hehe
5532020-10-08T19:57:54  <sipa> it is as BIP42 predicted
5542020-10-08T19:58:09  <sipa> "Prominent among them is the discussion on what to call 1 billion Bitcoin, which symbol color to use for it, and when wallet clients should switch to it by default. "
5552020-10-08T19:58:33  <wumpus> heh!
5562020-10-08T19:59:20  <wumpus> #endmeeting
5572020-10-08T19:59:20  <lightningbot> Meeting ended Thu Oct  8 19:59:20 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
5582020-10-08T19:59:20  <lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.html
5592020-10-08T19:59:20  <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.txt
5602020-10-08T19:59:20  <lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.log.html
5612020-10-08T19:59:37  <achow101> time to add "prophet" to sipa's resume
5622020-10-08T20:02:13  <sipa> aj: fwiw, 19988 now has "time going backwards" unit tests
5632020-10-08T20:16:42  *** Guyver2 has quit IRC
5642020-10-08T20:22:19  *** filchef has quit IRC
5652020-10-08T20:39:37  <vasild> CAddress::unser: time=1601829922, services=134218813, addr=62.107.200.30:8333
5662020-10-08T20:39:56  <vasild> CAddress::unser: time=1600339981, services=134217741, addr=akinbo7tlegsnsxn.onion:8333
5672020-10-08T20:40:31  <vasild> jonatack: wumpus: so...
5682020-10-08T20:41:05  <vasild> in the network there are some peers with services=unusually high value
5692020-10-08T20:42:08  <sipa> that's 0x0800000d
5702020-10-08T20:42:14  <vasild> they get in via p2p gossip into addrman without causing problems
5712020-10-08T20:42:16  <vasild> sipa: right
5722020-10-08T20:43:18  <vasild> using addrv1
5732020-10-08T20:44:03  <vasild> then addrman saves it on disk just fine in V3_BIP155 format using READWRITE(COMPACTSIZE(services_tmp))
5742020-10-08T20:44:44  <vasild> however, on read back from disk it bricks because ReadCompactSize() contains this at the end:
5752020-10-08T20:44:53  <vasild>     if (nSizeRet > (uint64_t)MAX_SIZE)
5762020-10-08T20:44:54  <vasild>         throw std::ios_base::failure("ReadCompactSize(): size too large");
5772020-10-08T20:45:18  <vasild> and MAX_SIZE is quite low value 0x02000000
5782020-10-08T20:45:47  <vasild> I wondered before wtf is that limit but decided it is harmless
5792020-10-08T20:46:15  <sipa> vasild: ehhhh
5802020-10-08T20:46:28  <sipa> this means we need to bypass that limit when deserializing addrv2
5812020-10-08T20:46:46  <vasild> so WriteCompactSize() can write >0x02000000 but ReadCompactSize() cannot read it back :-X
5822020-10-08T20:46:48  *** balbirs has quit IRC
5832020-10-08T20:47:32  *** balbirs has joined #bitcoin-core-dev
5842020-10-08T20:47:46  <sipa> vasild: it's a protection for the case where CompactSize format is used to actually encode a size
5852020-10-08T20:47:50  <sipa> and not just a number
5862020-10-08T20:48:19  <sipa> add a bool to ReadCompactSize to determine whether the limit is enforced or not?
5872020-10-08T20:49:17  <sipa> i guess we overlooked that in bip152, where it's also not used as a size, but restricted to pretty small numbers
5882020-10-08T20:49:35  <sipa> let me know if you need help with serialization framework stuff
5892020-10-08T20:50:25  <pinheadmz> where can i find the current version of bitcoin core in the source code? wihtout using git
5902020-10-08T20:50:52  <sipa> clientversion.h
5912020-10-08T20:51:01  <pinheadmz> (sorry meant for pr-reviews-club) thanks sipa
5922020-10-08T20:51:10  <vasild> hmm
5932020-10-08T20:51:54  <sipa> ah, it's in config/bitcoin-config.h now
5942020-10-08T20:52:04  <sipa> which may be generated by somwthing else still
5952020-10-08T20:52:22  <sipa> version numbers are aoways a mess, due to attempts to aboid having it in dozens of places
5962020-10-08T20:52:46  <pinheadmz> yeah thats why i expected there to be one source of truth that gets copioed arond
5972020-10-08T20:53:09  <sipa> it's in configure.ac i think
5982020-10-08T20:53:19  <sipa> top of the file
5992020-10-08T20:53:33  <pinheadmz> aha yes, this is what im looking for gracias
6002020-10-08T20:53:36  <vasild> sipa: how would we pass a bool parameter to ReadCompactSize() from               READWRITE(COMPACTSIZE(services_tmp));
6012020-10-08T20:54:21  <sipa> vasild: you can add template parameters to the compactsize wrapper
6022020-10-08T20:54:22  <vasild> inroduce READWRITE(COMPACTSIZE_UNBOUNDED(services_tmp))
6032020-10-08T20:54:23  <vasild> ?
6042020-10-08T20:54:29  <sipa> i can do that also
6052020-10-08T20:54:38  <sipa> though i'll be busy the next hour or so
6062020-10-08T20:55:11  <vasild> I am too sleepy, going to bed now, glad I nailed this down
6072020-10-08T20:55:19  <vasild> (the problem, not the solution)
6082020-10-08T20:56:17  * vasild bb in 9-10h
6092020-10-08T20:56:19  <jonatack> vasild: nice! sleepy here too, but it looks like that would explain what we are seeing. back on it tomorrow -- goodnight!
6102020-10-08T20:56:38  <vasild> jonatack: yeah, your disk is not corrupted! :-)
6112020-10-08T20:56:52  <sipa> vasild: what timezone are you in?
6122020-10-08T20:57:05  <vasild> UTC+2, it is 22:57 here
6132020-10-08T20:57:09  <jonatack> i suspect it's 2300
6142020-10-08T20:57:25  <vasild> sipa: you?
6152020-10-08T20:58:05  <sipa> vasild: UTC-7
6162020-10-08T20:58:32  <vasild> almost on the other side of the world :)
6172020-10-08T20:58:33  <sipa> lots of october 8th left for me
6182020-10-08T20:58:34  <jonatack> oh not in nyc then
6192020-10-08T20:58:38  <sipa> jonatack: not yet
6202020-10-08T21:00:01  *** Guest36719 has quit IRC
6212020-10-08T21:00:02  * vasild zZzZ
6222020-10-08T21:14:27  *** justanotheruser has quit IRC
6232020-10-08T21:16:57  *** EagleTM has joined #bitcoin-core-dev
6242020-10-08T21:20:11  *** EagleTM has quit IRC
6252020-10-08T21:20:35  *** EagleTM has joined #bitcoin-core-dev
6262020-10-08T21:22:28  *** dorena has joined #bitcoin-core-dev
6272020-10-08T21:22:55  *** proofofkeags has joined #bitcoin-core-dev
6282020-10-08T21:23:00  *** proofofkeags_ has joined #bitcoin-core-dev
6292020-10-08T21:23:36  *** Pavlenex has quit IRC
6302020-10-08T21:25:59  *** EagleTM has quit IRC
6312020-10-08T21:26:08  *** bitcoin-git has joined #bitcoin-core-dev
6322020-10-08T21:26:08  <bitcoin-git> [bitcoin] glozow opened pull request #20109: Release notes and followups from 19339 (master...docs-absurdfee) https://github.com/bitcoin/bitcoin/pull/20109
6332020-10-08T21:26:09  *** bitcoin-git has left #bitcoin-core-dev
6342020-10-08T21:26:24  *** EagleTM has joined #bitcoin-core-dev
6352020-10-08T21:27:01  *** rh0nj has quit IRC
6362020-10-08T21:28:07  *** rh0nj has joined #bitcoin-core-dev
6372020-10-08T21:44:30  *** justanotheruser has joined #bitcoin-core-dev
6382020-10-08T21:45:47  *** EagleTM has quit IRC
6392020-10-08T21:46:10  *** EagleTM has joined #bitcoin-core-dev
6402020-10-08T21:49:12  *** EagleTM has quit IRC
6412020-10-08T21:49:38  *** EagleTM has joined #bitcoin-core-dev
6422020-10-08T21:50:29  *** worc3131 has joined #bitcoin-core-dev
6432020-10-08T21:58:47  *** EagleTM has quit IRC
6442020-10-08T21:59:12  *** EagleTM has joined #bitcoin-core-dev
6452020-10-08T22:06:35  *** worc3131 has quit IRC
6462020-10-08T22:11:03  *** vasild has quit IRC
6472020-10-08T22:11:15  *** EagleTM has quit IRC
6482020-10-08T22:11:28  *** vasild has joined #bitcoin-core-dev
6492020-10-08T22:11:39  *** EagleTM has joined #bitcoin-core-dev
6502020-10-08T22:14:56  *** EagleTM has quit IRC
6512020-10-08T22:15:20  *** EagleTM has joined #bitcoin-core-dev
6522020-10-08T22:22:50  *** EagleTM has quit IRC
6532020-10-08T22:23:13  *** EagleTM has joined #bitcoin-core-dev
6542020-10-08T22:26:15  *** EagleTM has quit IRC
6552020-10-08T22:26:38  *** EagleTM has joined #bitcoin-core-dev
6562020-10-08T22:30:39  *** rc_423 has quit IRC
6572020-10-08T22:31:04  *** rc_423 has joined #bitcoin-core-dev
6582020-10-08T22:34:17  *** EagleTM has quit IRC
6592020-10-08T22:34:40  *** EagleTM has joined #bitcoin-core-dev
6602020-10-08T22:59:09  *** S3RK has joined #bitcoin-core-dev
6612020-10-08T23:03:25  *** S3RK has quit IRC
6622020-10-08T23:04:33  *** EagleTM has quit IRC
6632020-10-08T23:04:55  *** EagleTM has joined #bitcoin-core-dev
6642020-10-08T23:09:27  *** provoostenator has quit IRC
6652020-10-08T23:10:59  *** provoostenator has joined #bitcoin-core-dev
6662020-10-08T23:24:03  *** davterra has quit IRC
6672020-10-08T23:24:14  *** EagleTM has quit IRC
6682020-10-08T23:52:25  *** mol_ has joined #bitcoin-core-dev
6692020-10-08T23:55:04  *** mol has quit IRC