19:00:27 #startmeeting 19:00:27 Meeting started Thu Feb 8 19:00:27 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 19:00:27 Useful Commands: #action #agreed #help #info #idea #link #topic. 19:00:46 hi 19:00:50 hi 19:00:51 #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 19:01:04 hi 19:01:05 hi 19:01:16 hi 19:01:21 PSA: rc3 was tagged earlier today, if you haven't started your gitian build yet, please do so :) 19:01:28 topic suggestion, next high priority stuff 19:01:40 yes 19:01:44 provoostenator, you filed an issue for timestamps right? 19:01:46 #topic high priority for review 19:02:39 we still have plenty of things in https://github.com/bitcoin/bitcoin/projects/8, but it hasn't been updated for a few weeks because we've effectively used the 0.16 milestone for that, so now that 0.16 has branched it's up for discussion to add/remove things 19:02:40 hi. 19:03:07 for instance #11383 19:03:10 https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub 19:03:38 https://github.com/bitcoin/bitcoin/pull/12172 could use some tested acks, even if it's a small bug 19:04:19 jtimon: you have a comment by MarcoFalke to remove a commit IIRC 19:04:21 #10740 needs rebase so it can be removed for now (and I think it makes sense to wait for after 11383 is in) 19:04:24 https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 19:04:40 but yes, #12172 should stay 19:04:43 https://github.com/bitcoin/bitcoin/issues/12172 | Bugfix: RPC: savemempool: Dont save until LoadMempool() is finished by jtimon · Pull Request #12172 · bitcoin/bitcoin · GitHub 19:04:43 wumpus: yes, does anyone agree? I agree with removing it. just waiting for feedback 19:04:45 Hello. 19:05:12 jtimon: well he's the tests maintainer so I tend to agree with him regarding tests things, by default 19:05:24 It would be nice to get #10583 and #10579 in 19:05:27 https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub 19:05:31 https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub 19:05:44 jtimon: I haven't looked closely though 19:05:47 fyi MarcoFalke, ryanofsky and bluematt are away from keyboard 19:05:48 ok, I'll remove it, no problem, it will still need some tested acks then 19:05:48 jtimon: I'll check it too 19:06:20 promag: thanks! 19:06:29 achow101: +1 a few more ACKs please - those PRs have been rebased too many times 19:06:41 10740 removed 19:06:42 will takea look achow101 19:06:57 jtimon: but yes I'll take a look soon 19:07:06 awesome 19:07:12 topic suggestion: PR purge before ramping up for 0.17 19:07:31 purge as in closing? 19:07:43 #11882 19:07:45 https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub 19:08:02 well, I looked at my open PR list yesterday and noticed quite a few that I should probably just close. I suspect I'm not alone... 19:08:25 that could be a next topic, the current topic is high priority :) 19:08:26 now seems like a good time to go through their own and close things that are stale 19:08:36 bjut yes I agree 19:09:05 Also #11913 19:09:09 https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub 19:09:18 ok, sorry 19:09:33 cfields: perhaps the upcoming Core dev tech days is a good opportunity to go through and clear out old PRs? 19:09:37 achow101: I've added 10583, you already have the coin selection one I think two high prio per person is a good limit 19:09:40 yeah, there have been no interest in https://github.com/bitcoin/bitcoin/pull/9608 for a while so I'm more inclined to close it than to rebase it at this point unless someone changes my mind 19:10:42 hi 19:11:18 could i have some comments on #10785 ? 19:11:20 jnewbery, PR triage/close session sounds like a good idea 19:11:22 https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub 19:11:31 wumpus: ok 19:11:32 #topic PR purge 19:12:26 close old PRs? 19:12:28 if PRs should be closed you can always let me know, you don't really need to wait until a meeting 19:12:35 jnewbery: agreed, as a rally. But I was really just hinting that everyone should clean up their stale pulls to get the count down. 19:12:57 jnewbery: but yes, a kinda "i'm not sure if anyone cares about this or not" session in NYC would be great 19:13:24 [13bitcoin] 15sipa closed pull request #10434: [WIP] 3072-bit MuHash based hash_serialized (06master...06muhash) 02https://github.com/bitcoin/bitcoin/pull/10434 19:13:33 as I've said again and again, it's impossible for me to keep track of all PRs, so if there is something with a PR, just notify me 19:13:36 [13bitcoin] 15achow101 closed pull request #9504: [RPC] dumpmasterprivkey command (06master...06dumpmasterprivkey) 02https://github.com/bitcoin/bitcoin/pull/9504 19:13:44 It feels like in-person is the most efficient way to do a bulk purge. Probably most efficient if a set of us make lists beforehand for what we think can be closed 19:14:43 yes 19:14:56 [13bitcoin] 15promag closed pull request #11563: Improve CheckBlockIndex performance (06master...062017-10-improve-checkblockindex) 02https://github.com/bitcoin/bitcoin/pull/11563 19:15:00 sgtm 19:15:33 19:15:39 any other topics? 19:15:41 [13bitcoin] 15jtimon closed pull request #9608: Net: Divide ProcessMessage in smaller functions (06master...062017-01-split-processmessages) 02https://github.com/bitcoin/bitcoin/pull/9608 19:16:13 [13bitcoin] 15instagibbs closed pull request #10360: [WIP] [Wallet] Target effective value during transaction creation (06master...06feedo) 02https://github.com/bitcoin/bitcoin/pull/10360 19:16:29 maybe that should've been the last topic :p 19:16:30 so ocongratulations everyone on rc3! we were reallly fast with the fixes this time 19:17:08 hopefully this will be the last rc 19:17:23 hopefully, yes 19:18:00 cfields: at least the closes end up in the meeting log now 19:18:02 wumpus: Is rc3 available for download? 19:18:20 Randolf: no, it's just tagged earlier today 19:18:35 Okay. Thanks. 19:18:51 but if you have no problems with rc2, it should be ok, rc3 mostly fixed some edge cases 19:19:05 (to do with initialization and shutdown) 19:19:15 wumpus: heh 19:19:22 I was planning to try rc2 this weekend. If rc3 comes out first though, then rc3 is where I'll start. 19:20:28 I think it'll be possible to upload binaries for rc3 tomorrow 19:20:55 have we gotten anywhere with the MPC RSA signing thing? 19:20:59 That will be great. 19:21:25 already lots of rc3 gitian sigs 19:21:37 achow101: oh, right 19:21:48 gmaxwell: ping ^^. Any update? 19:23:16 I'm gonna guess that gmaxwell is not here right now 19:23:23 I guess so too 19:23:34 busy with ___root 19:23:42 I'm also not hearing any other proposals for topics, so this will be a short meeting I suppose 19:23:57 instagibbs: ...or fork (if he has kids). ;) 19:24:04 * wumpus just merged the rc3 signatures on bitcoin-core/gitian.sigs 19:24:34 wumpus: Moving away from Boost libraries? 19:24:40 Randolf: he doesn't have kids. I'm pretty sure he hates children 19:24:41 wumpus: ...as a topic? 19:24:55 wumpus: mine just finished building. We can do binaries today if we get the osx sig :) 19:24:58 Randolf: is there anything specific to discuss about that? it's been going on, slowly, for a long time 19:25:08 Randolf: review cfields's PRs! 19:25:26 wumpus: Well, it seems to me a good idea because Boost libraries have been a problem with getting numerous things compiled on NetBSD. I guess I'm just wondering how things are going on that front. 19:25:32 More general. 19:25:35 craig satoshi 19:25:36 Randolf: it will be years 19:25:40 holy shit roger is stupid 19:25:46 arubi: not here 19:25:46 Randolf: https://github.com/bitcoin/bitcoin/projects/3 19:25:48 oh man sorry, wrong channel 19:25:50 sipa: Oh, so there must be a lot of things tied to it then. 19:25:59 yea, missed the ctrl :) 19:26:31 cfields: Thanks. Wow, there's quite a lot to do there, and I wonder if that's everything that needs to be done. 19:26:39 there's no hurry in any case 19:26:41 Randolf: short version: I think we'll be able to get rid of a few parts of boost for 0.17, but things like the unit tests will keep it hanging around for a while 19:26:44 Sure, because it's working. 19:27:06 cfields: That seems reasonable. 19:27:08 boost::filesystem can only be replaced in c++17 or so 19:27:10 anyway, we can discuss after the meeting 19:27:21 Okay. 19:27:23 will be a while until we can start using that 19:27:24 wumpus: right 19:28:03 or at least, mandating it, it could theoretically be an option, but meh. I'd recommend you just solve whatever build problems you have with boost and put it behind you for now 19:28:19 yes, let's close the meeting 19:28:21 #endmeeting