19:01:18 <wumpus> #startmeeting
19:01:18 <lightningbot> Meeting started Thu Aug 30 19:01:18 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:01:18 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:01:27 <jonasschnelli> \o
19:01:32 <jonasschnelli> \o
19:01:34 <promag> howdy
19:01:36 <jonasschnelli> o/
19:01:55 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
19:02:00 <kanzure> hi.
19:02:04 <achow101> hi
19:02:06 <meshcollider> hi
19:03:02 <wumpus> so re: 0.17.0 it seems we still have a few issues
19:03:12 <wumpus> https://github.com/bitcoin/bitcoin/milestone/33
19:03:17 <gmaxwell> Hi.
19:03:28 <kanzure> topic: i am collecting topics for coredevtech tokyo; please submit topic suggestions to me, things that you would like to speak about, or things that you would prefer others to speak about, could be anything from source code things to BIPs to mailing list stuff, or complaints about twitter.
19:03:29 <wumpus> looks like the most serious one is a possible incompatibility when going back to 0.16.2
19:03:45 <wumpus> #14048
19:03:46 <gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub
19:04:09 <instagibbs> hi
19:04:24 <achow101> wasn't there a change to how txindex is handled now?
19:04:28 <gmaxwell> I no longer think #14109 is blocking, it appears to be a measurement artifact. pages in the cache in read only mmaps show up in res.
19:04:29 <gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub
19:04:29 <wumpus> there's also possible working memory use increase during IBD ( #14109)
19:04:30 <gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub
19:04:32 <achow101> so that's probably what is causing the problem
19:04:36 <wumpus> gmaxwell: good to know!
19:04:37 <jonasschnelli> Also #14104 is eventually something we want to take a look (or at least mention in the RN)
19:04:39 <gribble> https://github.com/bitcoin/bitcoin/issues/14104 | 0.17.2rc issue (standardness change for bare multisig) · Issue #14104 · bitcoin/bitcoin · GitHub
19:05:43 <wumpus> ok tagging that with 0.17.0
19:05:51 <jonasschnelli> sipas script template remove (#13194) caused a tiny isStandard different for bare multisig
19:05:53 <gribble> https://github.com/bitcoin/bitcoin/issues/13194 | Remove template matching and pseudo opcodes by sipa · Pull Request #13194 · bitcoin/bitcoin · GitHub
19:05:58 <wumpus> hadn't seen that one but it looks like it is expected?
19:06:14 <wumpus> ah
19:06:16 <jonasschnelli> Invalid pubkeys with the right size was standard until 0.17
19:06:41 <jonasschnelli> Now, it checks the first byte (compress, uncompressed, etc.). Before it just had to be 33 or 65 bytes.
19:06:49 <gmaxwell> jonasschnelli: what does invalid here mean? the initial byte isn't ne of the right flags?
19:06:50 <gmaxwell> okay.
19:07:08 <wumpus> I'd say the new way is better then?
19:07:10 <gmaxwell> (just making sure we weren't doing the on-the-curve check, since thats slow)
19:07:17 <jonasschnelli> It looks like people have stuffed 33 bytes into a bare multisig for some unknown reason
19:07:42 <jonasschnelli> (probably to make some data public available ala OP_RETURN)
19:07:47 <wumpus> well you can't avoid people stuffing other things in them, but making sure they look like valid keys makes some sense
19:08:10 <gmaxwell> The new way is a reasonable behavior. it will inhibit some kind of non-op-return store-data-in-the-utxo set behavior.
19:08:10 <jonasschnelli> heh. Yes. I think we should just mention that in the release notes
19:08:35 <wumpus> right
19:08:38 <gmaxwell> yes, should be release noted.
19:09:40 <wumpus> posted it in #12391
19:09:41 <gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub
19:10:15 <jonasschnelli> For #14048, I think its acceptable to require to create the txindex again when downgrade from 17 to 16...
19:10:16 <gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub
19:10:33 <gmaxwell> jonasschnelli: I agree, but it needs to be release noted.
19:10:33 <wumpus> oh this is because of the txindex update? of course, gah
19:10:45 <wumpus> what is the PR that changed the txindex?
19:11:05 <jonasschnelli> #13033
19:11:07 <gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub
19:11:08 <jonasschnelli> (i think)
19:11:47 <promag> also related #13243
19:11:49 <gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub
19:12:46 <willyko_> yaas finally got my gitian build to work
19:13:16 <wumpus> ok added
19:14:09 <wumpus> for the rest there is some documentation confusion which I *try* to clear up in #14100
19:14:11 <gribble> https://github.com/bitcoin/bitcoin/issues/14100 | doc: Change documentation for =0 for non-boolean options by laanwj · Pull Request #14100 · bitcoin/bitcoin · GitHub
19:14:44 <wumpus> at least if I do understand it correctly
19:15:51 <jonasschnelli> Added a new minor issue for 0.17 #14114
19:15:52 <gribble> https://github.com/bitcoin/bitcoin/issues/14114 | scantxoutset help about descriptors refers to TODO document · Issue #14114 · bitcoin/bitcoin · GitHubAsset 1Asset 1
19:17:11 <wumpus> oops
19:17:42 <gmaxwell> pieter opened a PR to fill in the docs.
19:17:57 <gmaxwell> #14096
19:17:59 <gribble> https://github.com/bitcoin/bitcoin/issues/14096 | Add reference documentation for descriptors language by sipa · Pull Request #14096 · bitcoin/bitcoin · GitHub
19:18:17 <wumpus> yes, that is already tagged 0.17.0
19:18:38 <gmaxwell> so it fixes 14114
19:18:44 <wumpus> right
19:19:22 <jonasschnelli> Oh. Wasn't aware
19:20:08 <wumpus> one topic I'd like to discuss is where to move tinyformat in the source tree, if we're going to do that at all, I hate it when there's two competing PRs open for something
19:20:11 * jonasschnelli is lost in PRs
19:20:24 <wumpus> #topic tinyformat move
19:20:34 <wumpus> e.g.: #13846, #13845, or keep as is
19:20:36 <gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHub
19:20:38 <gribble> https://github.com/bitcoin/bitcoin/issues/13845 | Include tinyformat as a subtree by Empact · Pull Request #13845 · bitcoin/bitcoin · GitHubAsset 1Asset 1
19:21:07 <wumpus> I'm ok with all three options but not with leaving those PRs open forever
19:22:01 <jonasschnelli> The subtree looked to me after an overkill,... I would prefer #13846 (no strong opinion)
19:22:03 <gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHubAsset 1Asset 1
19:22:57 <wumpus> I guess MarcoFalke is not here?
19:23:07 <wumpus> I think he has the strongest opinion about it
19:23:27 <gmaxwell> would we really do a subtree for a single file?
19:23:32 <wumpus> no.
19:24:00 <wumpus> I think this is pretty much unnecessary, and certainly the subtree one contains lots of changes
19:24:25 <gmaxwell> seems like change for the sake of change to me.
19:24:54 <wumpus> too much of that
19:25:05 <achow101> I'm in favor of keeping it as is
19:26:08 <wumpus> ok, other proposed topics?
19:26:18 <wumpus> I guess we haven't had high prio for review yet
19:26:23 <wumpus> #topic high priority for review
19:26:55 <wumpus> https://github.com/bitcoin/bitcoin/projects/8
19:27:00 <jonasschnelli> I'd like to add #14046
19:27:02 <wumpus> we made quite a lot of progress there this week
19:27:03 <gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub
19:27:12 <wumpus> only three left
19:27:41 <wumpus> added
19:28:43 <achow101> can I get #14019 for hi prio?
19:28:45 <gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub
19:29:01 <wumpus> achow101: you already have one
19:29:09 <achow101> replace it with that one
19:29:13 <wumpus> ok
19:29:48 <wumpus> done
19:30:04 <ken2812221_> wumpus: I want to replace #13866 with #13878
19:30:06 <gribble> https://github.com/bitcoin/bitcoin/issues/13866 | utils: Use _wfopen and _wfreopen on Windows by ken2812221 · Pull Request #13866 · bitcoin/bitcoin · GitHubAsset 1Asset 1
19:30:08 <gribble> https://github.com/bitcoin/bitcoin/issues/13878 | utils: Add fstream wrapper to allow to pass unicode filename on Windows by ken2812221 · Pull Request #13878 · bitcoin/bitcoin · GitHubAsset 1Asset 1
19:30:26 <wumpus> ken2812221_: you really need to find someone that can review windows stuff :)
19:31:11 <wumpus> anyhow - replaced
19:31:18 <ken2812221_> I am not sure that who knows about Windows thing.
19:31:48 <wumpus> maybe sipsorcery (who contributed the MSVC build)
19:32:51 <wumpus> which reminds me of #14089
19:32:53 <gribble> https://github.com/bitcoin/bitcoin/issues/14089 | CryptGenRandom is deprecated by fingera · Pull Request #14089 · bitcoin/bitcoin · GitHub
19:32:58 <wumpus> I'd, personally, prefer to close that one
19:33:22 <wumpus> or what luke-jr says, add it as extra random source, that can't hurt
19:34:10 <jonasschnelli> deprecated PRNG may have less backdoors. :)
19:34:44 <wumpus> right, good to be very careful here
19:35:25 <ken2812221_> anyway, I don't have a strong opinion.
19:35:27 <gmaxwell> when we finally do move off of openssl as an input, we'll add additional randomness inputs, making that stuff slightly less critical.
19:35:38 <gmaxwell> ken2812221_: what caused you to be aware of the deprecation?
19:36:39 <wumpus> he only concept-ACKed it
19:36:41 <ken2812221_> Well, that is not my PR.
19:37:21 <wumpus> NicolasDorier NACKed it (with rationale)
19:37:58 <wumpus> he's another person that knows things about windows btw, you could maybe ping him in your other PRs ken2812221_  :)
19:38:21 <ken2812221_> Thank you, wumpus
19:38:26 <gmaxwell> ken2812221_: oh sorry, its fingera's PR. my mistake.
19:40:05 <wumpus> ok, any other topics?
19:41:12 <wumpus> ken2812221_: would be nice to get your PRs in for 0.18 and fix the windows unicode issues once and for all
19:42:08 <ken2812221_> I'm not sure if this fix all problems, it needs more and more tests.
19:42:25 <ken2812221_> But we have 6+ months to test it.
19:42:58 <wumpus> yes, better to merge it soon in that regard
19:44:53 <wumpus> so if no other topics I'm going to close the meeting
19:45:34 <wumpus> #endmeeting