19:00:21 <wumpus> #startmeeting
19:00:21 <lightningbot> Meeting started Thu Jan  9 19:00:21 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:21 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
19:00:25 <kanzure> hi
19:00:26 <wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr
19:00:28 <wumpus> jeremyrubin lightlike emilengler jonatack hebasto
19:00:37 <hebasto> hi
19:00:49 <achow101> hi
19:01:00 <jamesob> hi
19:01:07 <jb55> ih
19:01:08 <wumpus> no pre-proposed topics for today in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a
19:01:15 <wumpus> any last minute proposals?
19:01:15 <instagibbs> hi
19:01:16 <emilengler> hi
19:01:16 <aj> hi
19:01:47 <wumpus> #topic High priority for review
19:01:53 <promag> hi
19:02:07 <wumpus> https://github.com/bitcoin/bitcoin/projects/8   9 blockers, 5 chasing concept for now
19:02:13 <ariard> hi
19:02:28 <wumpus> anything to add/remove or ready for merge?
19:02:32 <promag> can #17878 be in hp?
19:02:34 <gribble> https://github.com/bitcoin/bitcoin/issues/17878 | wip: zmq: Support -zmqpubwallettx by promag · Pull Request #17878 · bitcoin/bitcoin · GitHub
19:02:52 <promag> "Chasing Concept ACK"
19:02:55 <wumpus> I don't think a wip PR should be in high priority or review
19:03:00 <wumpus> ohh yes that's okay
19:03:14 <promag> ok, ty
19:03:45 <nehan_> hi
19:03:51 <jb55> looks like #13339 is finally ready though?
19:03:54 <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
19:04:15 <promag> going to address latest ryanofsky review
19:04:23 <jb55> testing it locally now
19:04:26 <wumpus> that's good to know
19:04:37 <jonatack> hi
19:04:43 <promag> prolly a release note saying that win is not supported
19:05:25 <wumpus> that definitely took a long and difficult review cycle for on first glance, easy functionality
19:06:06 <wumpus> #topic 0.19.1 release
19:06:35 <emilengler> 3 PRs need backports rn
19:06:36 <wumpus> I think it'd be a good idea to do a 0.19.1 release soon, there have been quite a few bug fixes
19:06:40 <promag> yeah, could be in 0.19.1
19:06:57 <jb55> that would be great
19:07:03 <hebasto> nice
19:07:21 <wumpus> emilengler: yes, there are still a few things tagged for backport to 0.19 that could make it in
19:07:41 <achow101> Can #17156 be added for backport 10 0.19.1?
19:07:42 <promag> I have 2 bug fixes #16923 #17457 but not sure they will get enough review
19:07:45 <gribble> https://github.com/bitcoin/bitcoin/issues/17156 | psbt: check that various indexes and amounts are within bounds by achow101 · Pull Request #17156 · bitcoin/bitcoin · GitHub
19:07:46 <gribble> https://github.com/bitcoin/bitcoin/issues/16923 | wallet: Fix duplicates fileid exception on start by promag · Pull Request #16923 · bitcoin/bitcoin · GitHub
19:07:47 <wumpus> especialy the macosx disk usage
19:07:48 <gribble> https://github.com/bitcoin/bitcoin/issues/17457 | gui: Fix manual coin control with multiple wallets loaded by promag · Pull Request #17457 · bitcoin/bitcoin · GitHub
19:09:12 <wumpus> well, my idea is to do the 0.19.1 release soon-ish, so things that require long review cycle and aren't super urgent could wait for 0.19.2 I think
19:09:40 <wumpus> would be nice though
19:09:48 <promag> when then?
19:10:12 <wumpus> when the remaining tagged PRs are merged
19:10:36 <wumpus> and backported ofc
19:10:51 <wumpus> dunno about #15706 though
19:10:53 <gribble> https://github.com/bitcoin/bitcoin/issues/15706 | build: Check QT library version by lucayepa · Pull Request #15706 · bitcoin/bitcoin · GitHub
19:11:04 <promag> then please tag #13339
19:11:07 <gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
19:11:15 <wumpus> that's not a bugfix
19:11:27 <promag> ah!
19:11:41 <hebasto> #15706 needs more eyes
19:11:43 <gribble> https://github.com/bitcoin/bitcoin/issues/15706 | build: Check QT library version by lucayepa · Pull Request #15706 · bitcoin/bitcoin · GitHub
19:11:44 <promag> so 0.20 I guess
19:12:00 <wumpus> promag: yes I'd hope so
19:12:16 <wumpus> if it wouldn't make 0.20 either it'd be absurd
19:13:39 <wumpus> hebasto: it's hard to get review for m4 build system stuff, could hope cfields_ takes a look at it :)
19:14:21 <wumpus> any other topics?
19:15:16 <wumpus> #endmeeting