12015-10-05T00:15:17  *** CodeShark is now known as CodeShark_
  22015-10-05T00:15:33  *** CodeShark has joined #bitcoin-core-dev
  32015-10-05T00:33:11  *** dcousens has joined #bitcoin-core-dev
  42015-10-05T01:20:51  *** CodeShark has quit IRC
  52015-10-05T01:21:02  *** CodeShark_ is now known as CodeShark
  62015-10-05T01:21:24  *** belcher_ has quit IRC
  72015-10-05T01:34:23  *** droark has joined #bitcoin-core-dev
  82015-10-05T02:51:27  *** Guest22695 is now known as pigeons
  92015-10-05T03:14:44  *** CodeShark is now known as CodeShark_
 102015-10-05T03:14:57  *** CodeShark has joined #bitcoin-core-dev
 112015-10-05T03:35:12  *** tripleslash_e is now known as tripleslash
 122015-10-05T03:44:59  *** challisto has quit IRC
 132015-10-05T04:05:38  *** challisto has joined #bitcoin-core-dev
 142015-10-05T05:59:11  *** aj_ is now known as aj
 152015-10-05T06:20:20  <gmaxwell> Luke-Jr: we know why that miner was problematic, they disabled script validation.
 162015-10-05T06:20:31  <Luke-Jr> gmaxwell: was that confirmed?
 172015-10-05T06:20:40  <Luke-Jr> afaik it was just speculated..
 182015-10-05T06:22:43  <gmaxwell> I confirmed it.
 192015-10-05T06:22:59  <Luke-Jr> interesting.
 202015-10-05T07:07:53  *** trippysalmon has quit IRC
 212015-10-05T07:13:16  *** jl2012 has quit IRC
 222015-10-05T07:13:23  *** jl2012 has joined #bitcoin-core-dev
 232015-10-05T07:14:55  *** paveljanik has quit IRC
 242015-10-05T07:27:27  *** n0n0__ has joined #bitcoin-core-dev
 252015-10-05T07:39:25  *** ParadoxSpiral has joined #bitcoin-core-dev
 262015-10-05T07:49:31  <phantomcircuit> gmaxwell, do you think it's likely that we will require anything in the coinbase scriptSig area beyond the block height for a soft fork ever again?
 272015-10-05T07:49:39  <phantomcircuit> (yes i know predicting the future and what not)
 282015-10-05T07:50:16  <gmaxwell> phantomcircuit: I would think it somewhat likely.
 292015-10-05T07:51:37  <phantomcircuit> gmaxwell, was afraid you'd say that
 302015-10-05T07:51:43  * phantomcircuit grubles and goes back to things
 312015-10-05T08:26:24  *** randy-waterhouse has joined #bitcoin-core-dev
 322015-10-05T08:41:50  *** adam3us has joined #bitcoin-core-dev
 332015-10-05T08:42:00  *** adam3us1 has quit IRC
 342015-10-05T08:42:19  <CodeShark> why is qa/pull-tester/rpc-tests.py always getting modified when I build?
 352015-10-05T08:43:32  <CodeShark> oh, the permissions seem to have changed
 362015-10-05T08:43:43  <CodeShark> old mode 100644
 372015-10-05T08:43:43  <CodeShark> new mode 100755
 382015-10-05T08:45:48  <CodeShark> the fix: git config core.filemode false
 392015-10-05T08:51:16  *** dcousens has quit IRC
 402015-10-05T08:51:34  *** CodeShark_ has quit IRC
 412015-10-05T08:53:23  *** rubensayshi has joined #bitcoin-core-dev
 422015-10-05T09:02:08  <btcdrak> ping jgarzik: "CodeShark: the fix: git config core.filemode false"
 432015-10-05T09:02:31  <btcdrak> though I'm not sure anyone should be direct pushing to the repository, the point on pull requests is to catch mistakes
 442015-10-05T09:02:44  *** BashCo has joined #bitcoin-core-dev
 452015-10-05T09:09:02  <CodeShark> looks like this is the offender: https://github.com/bitcoin/bitcoin/commit/5467820be5404fa736436a1202079e764a4308b4
 462015-10-05T09:26:00  <CodeShark> is there any reason the file in the repo should have mode 644 and have configure change it to 755?
 472015-10-05T09:29:01  <btcdrak> CodeShark: it makes sense if you want a shell script for example, to be scripts to be executable by default.
 482015-10-05T09:29:12  <CodeShark> yes, but this is a python script
 492015-10-05T09:29:17  <CodeShark> do we ever need to run it directly?
 502015-10-05T09:29:28  <CodeShark> or do we always invoke it with python file.py?
 512015-10-05T09:43:42  <wumpus> uhm, configure shouldn't be changing the permissions of a file in the repository
 522015-10-05T09:43:45  <randy-waterhouse> more properly executable scripts should not be included in the EXTRA_DIST variable but using _SCRIPTS
 532015-10-05T09:43:53  <randy-waterhouse> wumpus right
 542015-10-05T09:44:33  <randy-waterhouse> then they will be clearly treated as executable binaries by whatever platform they land upon ... and handled accordingly
 552015-10-05T09:44:36  <wumpus> either it's packaged in the github repo with +x permissions, or it's not and called with python2, both are valid, but this isn't
 562015-10-05T09:44:44  <randy-waterhouse> agree
 572015-10-05T09:46:57  <wumpus> ok, so the file is 755 in the repo now, just the chmod XXX needs to be removed from configure.ac
 582015-10-05T09:47:17  <wumpus> both of them
 592015-10-05T09:48:27  <wumpus> although chmodding *generated* files in configure scfipt is fine, but not those that are in the repository
 602015-10-05T09:51:19  *** n0n0__ has quit IRC
 612015-10-05T10:00:24  <GitHub165> [bitcoin] laanwj opened pull request #6759: build: Remove unncecessary chmods after #6616 (master...2015_10_remove_unncecessary_chmods) https://github.com/bitcoin/bitcoin/pull/6759
 622015-10-05T10:01:20  <CodeShark> can I get some more ACKs? https://github.com/bitcoin/bitcoin/pull/6747
 632015-10-05T10:01:40  <CodeShark> if you ACK it I'll review your PR
 642015-10-05T10:01:41  <CodeShark> :)
 652015-10-05T10:10:34  *** Guest11115 has quit IRC
 662015-10-05T10:41:43  *** BashCo has quit IRC
 672015-10-05T10:42:30  <jonasschnelli> CodeShark: Yeah. PR review deals...
 682015-10-05T10:42:37  <CodeShark> ;)
 692015-10-05T10:43:53  <CodeShark> gotta prioritize somehow :)
 702015-10-05T10:44:22  <CodeShark> hell if any of us are going to go through all of them (well, maybe sipa will)
 712015-10-05T10:44:23  <CodeShark> :p
 722015-10-05T10:45:48  *** BashCo has joined #bitcoin-core-dev
 732015-10-05T10:48:37  <jgarzik> I go through every one, once every couple of months, in additional to daily spot reviews based on incoming github email notifications.
 742015-10-05T10:48:56  <jgarzik> don't necessarily comment if things are going well, or nothing new to add
 752015-10-05T10:52:53  <CodeShark> ok, jgarzik will, too ;)
 762015-10-05T11:13:34  *** n0n0__ has joined #bitcoin-core-dev
 772015-10-05T11:25:56  <CodeShark> can we please stop paying attention to that clown who claims he coined the idea of not validating stuff?
 782015-10-05T11:26:55  <CodeShark> I created an SPV client in a few seconds the other day...by disabling all transaction checks
 792015-10-05T11:27:04  <CodeShark> perhaps I should start claiming I coined SPV
 802015-10-05T11:29:22  <jgarzik> CodeShark, IMO hard fork vs soft fork is on topic
 812015-10-05T11:29:34  <CodeShark> perhaps discussed by serious individuals
 822015-10-05T11:29:35  <jgarzik> (though off topic for this channel)
 832015-10-05T11:29:46  <CodeShark> this person deserves no attention from any of us - he's a dick
 842015-10-05T11:29:47  * wumpus stopped paying attention to that particular clown quite some time ago, and suggest keeping it out of this channel
 852015-10-05T11:29:53  <jgarzik> +1
 862015-10-05T11:30:06  <wumpus> he's not welcome here and neither is talk baout him
 872015-10-05T11:30:19  <CodeShark> sorry, wumpus - I'll stop
 882015-10-05T11:30:28  <jgarzik> Meta - IMO behavior should be unwelcome, not people
 892015-10-05T11:35:34  <GitHub167> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ab3de8ba1a6...2844b9e90e58
 902015-10-05T11:35:34  <GitHub167> bitcoin/master ea70997 Wladimir J. van der Laan: build: Remove unnecessary chmods after #6616...
 912015-10-05T11:35:35  <GitHub167> bitcoin/master 2844b9e Wladimir J. van der Laan: Merge pull request #6759...
 922015-10-05T11:35:43  <GitHub94> [bitcoin] laanwj closed pull request #6759: build: Remove unncecessary chmods after #6616 (master...2015_10_remove_unncecessary_chmods) https://github.com/bitcoin/bitcoin/pull/6759
 932015-10-05T11:39:01  <GitHub13> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/5f34a2510f6414a27ac3179ee461c944c8acd395
 942015-10-05T11:39:01  <GitHub13> bitcoin/master 5f34a25 ptschip: Changed rpc-tests.sh to rpc-tests.py in README.md...
 952015-10-05T11:39:21  <GitHub143> [bitcoin] laanwj closed pull request #6752: Changed rpc-tests.sh to rpc-tests.py in README.md (master...readme) https://github.com/bitcoin/bitcoin/pull/6752
 962015-10-05T11:41:27  <GitHub57> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5f34a2510f64...e10a4ab904ab
 972015-10-05T11:41:27  <GitHub57> bitcoin/master 9ee5ac8 Pavel Janík: Rewrite help texts for features enabled by default.
 982015-10-05T11:41:28  <GitHub57> bitcoin/master e10a4ab Wladimir J. van der Laan: Merge pull request #6748...
 992015-10-05T11:43:32  <GitHub178> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e10a4ab904ab...a75c67364d34
1002015-10-05T11:43:32  <GitHub178> bitcoin/master bb24835 Wladimir J. van der Laan: build: disable -Wself-assign...
1012015-10-05T11:43:33  <GitHub178> bitcoin/master a75c673 Wladimir J. van der Laan: Merge pull request #6744...
1022015-10-05T11:43:39  <GitHub182> [bitcoin] laanwj closed pull request #6744: build: disable -Wself-assign (master...2015_10_clang_self_assignment_warning) https://github.com/bitcoin/bitcoin/pull/6744
1032015-10-05T11:44:34  <wumpus> GODDAMNIT, I did merge the UTF BOM in 5f34a25, these things are harder to get rid of than viruses
1042015-10-05T11:48:23  <wumpus> the mind boggles, what use are byte order marks, it's not like UTF-8 has different endiannesses
1052015-10-05T11:57:27  <btcdrak> we really need a basic CS checker as part of the CI process
1062015-10-05T11:59:01  <btcdrak> https://scrutinizer-ci.com is free for OSS projects. It integrates with Github like travis
1072015-10-05T11:59:13  <btcdrak> and does CS checks afaik
1082015-10-05T12:07:02  *** BashCo has quit IRC
1092015-10-05T12:07:38  *** BashCo has joined #bitcoin-core-dev
1102015-10-05T12:07:47  *** BashCo has quit IRC
1112015-10-05T12:31:11  <GitHub76> [bitcoin] randy-waterhouse opened pull request #6760: Changed qa/pull-tester/run-bitcoind-for-test.sh.in to non-executable mode. (master...master) https://github.com/bitcoin/bitcoin/pull/6760
1122015-10-05T12:33:53  <jgarzik> CS = coding style?   clang works as CS checker.  Using that is The Plan - reformat the source code according to the already-chosen clang style at some flag day.  Then checks from that point can be automated.
1132015-10-05T12:47:17  *** GAit has joined #bitcoin-core-dev
1142015-10-05T12:53:06  <CodeShark> speaking of which, how are we on the C++11/C++14 stuff?
1152015-10-05T12:53:59  <CodeShark> I guess backports make that very hard now
1162015-10-05T13:03:26  <jonasschnelli> github merge script does use git@github.com: instead of https://github.com, wouldn't the later be our preferred way. I assume git@github.com uses plaintext communication. Sure. commits are signed, but still https might be the preferred way?
1172015-10-05T13:06:02  <jgarzik> jonasschnelli, git@github is ssh
1182015-10-05T13:06:14  <jgarzik> jonasschnelli, git:// is plaintext
1192015-10-05T13:06:33  <jonasschnelli> jgarzik: Ah. Right.. Thanks. I missed the @. nm
1202015-10-05T13:07:26  *** pigeons has quit IRC
1212015-10-05T13:08:33  *** pigeons has joined #bitcoin-core-dev
1222015-10-05T13:08:57  *** pigeons is now known as Guest22631
1232015-10-05T13:22:53  <btcdrak> jgarzik: yes, a codestyle checker - it doesnt need to be on nazi mode, just catch things like whitespace, UTF8 BOM, and basic style. Having it as part of the pull request CI (which includes Travis) makes it much easier for contributors to get it right first and makes less work for reviewers).
1242015-10-05T13:25:05  *** mtrythall has joined #bitcoin-core-dev
1252015-10-05T13:26:52  <CodeShark> jonasschnelli: which one's your pride and joy right now? I'll have a look
1262015-10-05T13:27:13  <CodeShark> PR that is
1272015-10-05T13:27:46  *** mtrythall has left #bitcoin-core-dev
1282015-10-05T13:28:47  <jonasschnelli> CodeShark: I keep my +1 credit because non of my PR are merge-or-review-ready state. I still like to get the bip32 patch into 0.12. Will come back to your offer soon. :)
1292015-10-05T13:28:58  <jonasschnelli> *are in
1302015-10-05T13:30:28  *** adam3us1 has joined #bitcoin-core-dev
1312015-10-05T13:30:29  *** adam3us has quit IRC
1322015-10-05T13:36:00  *** BashCo has joined #bitcoin-core-dev
1332015-10-05T13:40:10  *** BashCo has quit IRC
1342015-10-05T13:42:31  <jgarzik> btcdrak, having a "fail unless clang-CS compliant" or "auto format tree to clang-CS style" policy fixes a lot of those issues automatically
1352015-10-05T14:00:24  <jonasschnelli> clang auto-format was rejected because clang-format wasn't deterministic enough (event with same version of clang-format) IIRC
1362015-10-05T14:07:14  *** droark has quit IRC
1372015-10-05T14:11:23  <jonasschnelli> s/event/even
1382015-10-05T14:41:12  *** BashCo has joined #bitcoin-core-dev
1392015-10-05T14:53:33  *** CodeShark has quit IRC
1402015-10-05T15:15:48  *** jl2012_ has joined #bitcoin-core-dev
1412015-10-05T15:15:51  *** jl2012 has quit IRC
1422015-10-05T15:16:59  *** Guest22631 is now known as pigeons
1432015-10-05T15:35:41  *** paveljanik has joined #bitcoin-core-dev
1442015-10-05T15:37:04  *** stonecoldpat1 is now known as stonecoldpat
1452015-10-05T15:43:35  *** fkhan has quit IRC
1462015-10-05T15:49:21  *** BashCo has quit IRC
1472015-10-05T15:56:20  *** fkhan has joined #bitcoin-core-dev
1482015-10-05T16:22:59  *** paveljanik has quit IRC
1492015-10-05T16:25:15  *** paveljanik has joined #bitcoin-core-dev
1502015-10-05T16:25:38  *** paveljanik has quit IRC
1512015-10-05T16:31:29  *** paveljanik has joined #bitcoin-core-dev
1522015-10-05T16:32:25  *** adam3us1 has quit IRC
1532015-10-05T16:33:26  *** adam3us has joined #bitcoin-core-dev
1542015-10-05T17:07:56  *** BashCo has joined #bitcoin-core-dev
1552015-10-05T17:38:39  *** BashCo has quit IRC
1562015-10-05T17:43:28  *** BashCo has joined #bitcoin-core-dev
1572015-10-05T17:59:41  *** belcher has joined #bitcoin-core-dev
1582015-10-05T18:08:29  *** d_t has joined #bitcoin-core-dev
1592015-10-05T18:10:06  <GitHub152> [bitcoin] paveljanik opened pull request #6761: [Trivial] Remove UTF-8 BOM [skip ci] (master...remove_bom) https://github.com/bitcoin/bitcoin/pull/6761
1602015-10-05T18:11:09  *** rubensayshi has quit IRC
1612015-10-05T18:18:58  <GitHub72> [bitcoin] paveljanik opened pull request #6762: tests-config.sh is superseded by tests_config.py [skip ci] (master...qatest_gitignore) https://github.com/bitcoin/bitcoin/pull/6762
1622015-10-05T18:32:41  *** ParadoxSpiral_ has joined #bitcoin-core-dev
1632015-10-05T18:35:47  *** ParadoxSpiral has quit IRC
1642015-10-05T18:57:07  <GitHub85> [bitcoin] laanwj closed pull request #6761: [Trivial] Remove UTF-8 BOM [skip ci] (master...remove_bom) https://github.com/bitcoin/bitcoin/pull/6761
1652015-10-05T19:23:12  <GitHub107> [bitcoin] paveljanik opened pull request #6763: [Trivial] The Bitcoin Core project is releasing Bitcoin Core, not Bitcoin. (master...trivial_Bitcoin_vs_BitcoinCore_fix) https://github.com/bitcoin/bitcoin/pull/6763
1662015-10-05T19:23:36  *** mm_1 has joined #bitcoin-core-dev
1672015-10-05T19:59:25  *** rusty has joined #bitcoin-core-dev
1682015-10-05T20:05:41  *** BashCo has joined #bitcoin-core-dev
1692015-10-05T20:07:30  *** paveljanik has quit IRC
1702015-10-05T20:31:15  *** sipa has joined #bitcoin-core-dev
1712015-10-05T21:23:59  *** rusty has quit IRC
1722015-10-05T22:02:46  *** randy-waterhouse has quit IRC
1732015-10-05T22:03:17  *** PaulCape_ has quit IRC
1742015-10-05T22:03:46  *** PaulCapestany has joined #bitcoin-core-dev
1752015-10-05T22:26:10  *** n0n0__ has quit IRC
1762015-10-05T22:28:39  *** ChanServ sets mode: +o sipa
1772015-10-05T23:01:57  *** rusty has joined #bitcoin-core-dev
1782015-10-05T23:07:47  *** rusty has quit IRC
1792015-10-05T23:28:18  *** rusty has joined #bitcoin-core-dev
1802015-10-05T23:45:34  *** BashCo has quit IRC
1812015-10-05T23:51:29  *** PRab has joined #bitcoin-core-dev
1822015-10-05T23:54:01  *** d_t has quit IRC