12015-10-07T00:12:24  *** alpalp has joined #bitcoin-core-dev
  22015-10-07T00:36:56  *** d_t has quit IRC
  32015-10-07T00:57:21  *** BashCo has joined #bitcoin-core-dev
  42015-10-07T01:01:59  *** BashCo has quit IRC
  52015-10-07T01:10:43  *** CodeShark has joined #bitcoin-core-dev
  62015-10-07T01:33:18  *** belcher has quit IRC
  72015-10-07T01:43:46  *** maaku has quit IRC
  82015-10-07T01:46:15  *** maaku has joined #bitcoin-core-dev
  92015-10-07T01:46:39  *** maaku is now known as Guest309
 102015-10-07T01:47:37  *** Guest309 is now known as maaku
 112015-10-07T02:42:43  *** maaku has quit IRC
 122015-10-07T02:54:22  *** maaku has joined #bitcoin-core-dev
 132015-10-07T02:54:45  *** maaku is now known as Guest41021
 142015-10-07T03:32:14  *** tripleslash_e has joined #bitcoin-core-dev
 152015-10-07T03:32:41  *** tripleslash has quit IRC
 162015-10-07T03:35:22  *** tripleslash_e is now known as tripleslash
 172015-10-07T04:06:49  *** goregrind has quit IRC
 182015-10-07T04:08:40  *** goregrind has joined #bitcoin-core-dev
 192015-10-07T04:09:57  *** adam3us1 has joined #bitcoin-core-dev
 202015-10-07T04:10:18  *** adam3us has quit IRC
 212015-10-07T04:13:03  *** Squidicc has joined #bitcoin-core-dev
 222015-10-07T04:16:11  *** Squidicuz has quit IRC
 232015-10-07T04:20:59  *** d_t has joined #bitcoin-core-dev
 242015-10-07T04:23:17  *** BlueMatt has quit IRC
 252015-10-07T04:56:15  *** paveljanik has joined #bitcoin-core-dev
 262015-10-07T05:06:58  *** Arnavion has joined #bitcoin-core-dev
 272015-10-07T05:07:15  *** AtashiCon has joined #bitcoin-core-dev
 282015-10-07T05:27:07  *** AtashiCon has quit IRC
 292015-10-07T05:27:23  *** AtashiCon has joined #bitcoin-core-dev
 302015-10-07T05:27:47  *** Arnavion has quit IRC
 312015-10-07T05:28:04  *** Arnavion has joined #bitcoin-core-dev
 322015-10-07T06:55:21  *** d_t has quit IRC
 332015-10-07T07:22:11  *** paveljanik has quit IRC
 342015-10-07T07:40:17  *** ParadoxSpiral has joined #bitcoin-core-dev
 352015-10-07T07:54:01  *** randy-waterhouse has joined #bitcoin-core-dev
 362015-10-07T08:00:07  *** kyuupichan has joined #bitcoin-core-dev
 372015-10-07T08:00:19  *** kyuupichan has left #bitcoin-core-dev
 382015-10-07T08:02:19  *** paveljanik has joined #bitcoin-core-dev
 392015-10-07T08:07:00  *** paveljanik has quit IRC
 402015-10-07T08:07:15  *** paveljanik has joined #bitcoin-core-dev
 412015-10-07T08:07:15  *** n0n0__ has joined #bitcoin-core-dev
 422015-10-07T08:21:21  *** Guest41021 is now known as maaku
 432015-10-07T08:25:18  *** maaku has quit IRC
 442015-10-07T08:29:53  *** maaku has joined #bitcoin-core-dev
 452015-10-07T08:30:16  *** maaku is now known as Guest45905
 462015-10-07T08:36:37  *** Guest45905 is now known as maaku
 472015-10-07T08:59:08  <GitHub94> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4fac576c619f...49dd5c629df0
 482015-10-07T08:59:08  <GitHub94> bitcoin/master b196b68 Gregory Maxwell: Test LowS in standardness, removes nuisance malleability vector....
 492015-10-07T08:59:09  <GitHub94> bitcoin/master 49dd5c6 Wladimir J. van der Laan: Merge pull request #6769...
 502015-10-07T08:59:15  <GitHub89> [bitcoin] laanwj closed pull request #6769: Test LowS in standardness, removes nuisance malleability vector. (master...no_nuisance_malleability) https://github.com/bitcoin/bitcoin/pull/6769
 512015-10-07T09:13:46  <GitHub107> [bitcoin] laanwj pushed 1 new commit to 0.10: https://github.com/bitcoin/bitcoin/commit/b1d76af0ea35dc349f96251496fdfafe3ffab759
 522015-10-07T09:13:47  <GitHub107> bitcoin/0.10 b1d76af Gregory Maxwell: Test LowS in standardness, removes nuisance malleability vector....
 532015-10-07T09:19:31  <GitHub13> [bitcoin] laanwj force-pushed 0.10 from b1d76af to 1cea6b0: https://github.com/bitcoin/bitcoin/commits/0.10
 542015-10-07T09:19:31  <GitHub13> bitcoin/0.10 1cea6b0 Gregory Maxwell: Test LowS in standardness, removes nuisance malleability vector....
 552015-10-07T09:23:46  <wumpus> needed force-push: forgot the sign the commit
 562015-10-07T09:25:07  <CodeShark> no harm :)
 572015-10-07T09:32:34  <GitHub136> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/71cc9d9fe829efd9c9b012c4cd1ece1d988b4869
 582015-10-07T09:32:34  <GitHub136> bitcoin/0.11 71cc9d9 Gregory Maxwell: Test LowS in standardness, removes nuisance malleability vector....
 592015-10-07T09:50:07  *** dcousens has joined #bitcoin-core-dev
 602015-10-07T09:51:33  <dcousens> gmaxwell: another day, another fund-losing bug in JS land
 612015-10-07T09:52:08  <dcousens> This one affects all devices on Android 4.3 or below
 622015-10-07T09:52:17  <dcousens> Not even sure how many wallets are affected
 632015-10-07T09:52:22  <dcousens> But, I know at least 3
 642015-10-07T09:53:19  <CodeShark> oh?
 652015-10-07T09:54:38  <dcousens> CodeShark: 4.3 web views overflow when assigning 32 bit integers to UInt8 byte arrays
 662015-10-07T09:54:48  <dcousens> Not consistently either
 672015-10-07T09:54:56  <dcousens> But,  we have solid repro
 682015-10-07T09:55:32  <dcousens> CodeShark: https://github.com/feross/buffer/pull/81
 692015-10-07T09:56:16  <CodeShark> this sounds more serious than just potentially fund-losing
 702015-10-07T09:56:46  <dcousens> CodeShark: question is,  where do you even post it?
 712015-10-07T09:57:04  <dcousens> I'm thinking about writing it up for bitcoinjs-lib,  bitcore etc
 722015-10-07T09:57:08  <CodeShark> contact the wallet authors?
 732015-10-07T09:58:17  <dcousens> CodeShark: hard to tell who uses JS under the hood
 742015-10-07T09:58:26  <dcousens> I know CoPay does, and it doesn't use XWalk
 752015-10-07T09:58:54  <dcousens> I know BlockTrail does (already contacted, their doing a migration now, Ruben helped discover this when users reported mismatched key derivations)
 762015-10-07T09:59:34  <dcousens> Basically every webwallet [when run on android 4.3 w/o a new version of Chrome]
 772015-10-07T09:59:50  <dcousens> (Assuming* they use typed arrays)
 782015-10-07T10:00:46  <CodeShark> all browser controls in android in all apps use this same web view control?
 792015-10-07T10:02:01  <dcousens> CodeShark: https://developer.android.com/reference/android/webkit/WebView.html
 802015-10-07T10:02:37  <dcousens> Typically the SDK has 1 WebView implementation, and depending on certain factors, it may or may not be the same one as the phones default browser
 812015-10-07T10:04:04  <CodeShark> and the correct behavior should be? crashing? truncation?
 822015-10-07T10:04:18  <dcousens> CodeShark: %256
 832015-10-07T10:04:22  <dcousens> mod 256
 842015-10-07T10:04:30  <CodeShark> so the least significant byte
 852015-10-07T10:04:56  <dcousens> aye
 862015-10-07T10:05:02  <dcousens> that is the *defined* behaviour
 872015-10-07T10:05:46  <CodeShark> doesn't sound good - are the android folks working on a patch?
 882015-10-07T10:06:52  <dcousens> CodeShark: haven't been in contact with them yet,  but I'm not sure what the dynamics/communication pathways are there yet.
 892015-10-07T10:21:47  <dcousens> CodeShark: any ideas on who you would contact for that?
 902015-10-07T10:22:10  <CodeShark> I wish I had some suggestions - unfortunately I don't know how to help
 912015-10-07T10:22:21  <dcousens> like,  if they could update those web views
 922015-10-07T10:22:27  <dcousens> Wouldn't they juts update the entire android anyway?
 932015-10-07T10:23:26  *** Squidicc has quit IRC
 942015-10-07T10:23:47  <dcousens> I get the feeling the best bet is to just put out the notices to the major JS libs and maybe ping in a few more wallet devs
 952015-10-07T10:23:49  <CodeShark> that's what one would think...but I'm guessing there could be compatibility issues or lack of device support that might prevent people from updating the entire android. admittedly, I'm no android expert
 962015-10-07T10:24:21  <CodeShark> my android development experience consists of a handful of toy apps :p
 972015-10-07T10:24:35  <wumpus> yes, lack of device support for updates is very common, unfortunately
 982015-10-07T10:26:06  <dcousens> I'm just glad I deployed the bitcoin apps I work on with XWalk (compatibility, 20mb+ to your app size, but guarantees a consistent (and new) web view across all versions)
 992015-10-07T10:29:15  <wumpus> so that's why all those apps are so large nowadays :-) I have a very old, severly resource-challenged smartphone and every time there's application updates available, I need to remove at least one application to make room.
1002015-10-07T10:29:51  <wumpus> at some point it's going to be unusable and I'm not actually sure I'm going to get a smartphone again
1012015-10-07T10:31:15  <CodeShark> is there still another option? pay phones? :)
1022015-10-07T10:31:31  <CodeShark> remember those things?
1032015-10-07T10:31:32  <dcousens> CodeShark: rpi with a GSM module? haha
1042015-10-07T10:32:36  *** paveljanik has quit IRC
1052015-10-07T10:32:39  <wumpus> well there's still cheap 'dumbphones' available that can only call and text. At least when I checked a year ago or so. For old people, like me :-)
1062015-10-07T10:34:19  <dcousens> wumpus: but are they actually 'dumb'? :P
1072015-10-07T10:36:06  <wumpus> good point. So that leaves... someone have an old Nokia 3310 laying around... ? :P
1082015-10-07T10:37:10  <CodeShark> I think I still have a Motorola StarTak somewhere
1092015-10-07T10:37:12  <CodeShark> lol
1102015-10-07T10:37:38  <CodeShark> s/StarTak/StarTAC
1112015-10-07T10:37:50  <CodeShark> from like the mid 1990's
1122015-10-07T10:37:51  <wumpus> heh
1132015-10-07T10:39:02  <CodeShark> I remember when I got my first cell phone - a car phone - the transciever took up like half the trunk :p
1142015-10-07T10:39:35  <dcousens> wumpus: whats the concern anyway, NSA paranoia? :P
1152015-10-07T10:39:39  <wumpus> I had a similar one, maybe even the same
1162015-10-07T10:39:45  <wumpus> CodeShark: awesome
1172015-10-07T10:41:58  <wumpus> dcousens: not so much the NSA, but exploiting vulnerabilities isn't exactly only NSA territory, especially in old software given the lack of vendor support for keeping software up to date and secure
1182015-10-07T10:44:30  <wumpus> the ecosystem is a mess. Would be great to have a phone that's more like a normal PC. I think that's what Nokia tried with N900, shame it didn't go very far.
1192015-10-07T10:44:47  <CodeShark> built-in obsolescence is a feature of all modern appliances :)
1202015-10-07T10:45:21  <wumpus> but not that fast
1212015-10-07T10:45:51  <wumpus> anyhow, this has veered very far off topic, sorry for that
1222015-10-07T10:46:22  <CodeShark> now to tie it back to some PR...
1232015-10-07T11:27:24  *** paveljanik has joined #bitcoin-core-dev
1242015-10-07T11:27:24  *** paveljanik has joined #bitcoin-core-dev
1252015-10-07T11:42:56  *** fkhan has quit IRC
1262015-10-07T12:08:15  *** Squidicuz has joined #bitcoin-core-dev
1272015-10-07T12:10:27  *** fkhan has joined #bitcoin-core-dev
1282015-10-07T12:38:14  *** moli has joined #bitcoin-core-dev
1292015-10-07T13:00:29  <GitHub95> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/49dd5c629df0...d479311dba25
1302015-10-07T13:00:29  <GitHub95> bitcoin/master 1534d9a EthanHeilman: Creates unittests for addrman, makes addrman testable....
1312015-10-07T13:00:30  <GitHub95> bitcoin/master d479311 Wladimir J. van der Laan: Merge pull request #6720...
1322015-10-07T13:00:33  <GitHub68> [bitcoin] laanwj closed pull request #6720: Creates unittests for addrman, makes addrman more testable. (master...unittest) https://github.com/bitcoin/bitcoin/pull/6720
1332015-10-07T13:08:21  *** pigeons has quit IRC
1342015-10-07T13:08:40  *** pigeons has joined #bitcoin-core-dev
1352015-10-07T13:09:03  *** pigeons is now known as Guest74766
1362015-10-07T13:14:35  *** adam3us1 has quit IRC
1372015-10-07T13:23:41  *** adam3us has joined #bitcoin-core-dev
1382015-10-07T13:31:48  *** Justitia has quit IRC
1392015-10-07T14:06:30  *** d_t has joined #bitcoin-core-dev
1402015-10-07T14:22:39  <GitHub192> [bitcoin] CodeShark opened pull request #6774: ISM to softforks unit (master...ISM_to_softforks_unit) https://github.com/bitcoin/bitcoin/pull/6774
1412015-10-07T14:28:06  *** BashCo has joined #bitcoin-core-dev
1422015-10-07T14:49:56  *** jl2012_ has quit IRC
1432015-10-07T14:49:58  *** maaku has quit IRC
1442015-10-07T14:50:25  *** jl2012 has joined #bitcoin-core-dev
1452015-10-07T14:50:37  *** dgenr8 has quit IRC
1462015-10-07T14:51:06  *** maaku__ has quit IRC
1472015-10-07T14:51:10  *** maaku has joined #bitcoin-core-dev
1482015-10-07T14:51:18  *** dgenr8 has joined #bitcoin-core-dev
1492015-10-07T14:51:33  *** maaku is now known as Guest4879
1502015-10-07T14:52:05  *** maaku__ has joined #bitcoin-core-dev
1512015-10-07T14:57:26  *** molly has joined #bitcoin-core-dev
1522015-10-07T15:00:19  *** moli has quit IRC
1532015-10-07T15:22:26  *** CodeShark has quit IRC
1542015-10-07T15:30:50  *** BashCo has quit IRC
1552015-10-07T15:36:14  *** BashCo has joined #bitcoin-core-dev
1562015-10-07T16:00:12  *** treehug88 has joined #bitcoin-core-dev
1572015-10-07T16:08:55  *** adam3us has quit IRC
1582015-10-07T16:22:52  *** adam3us has joined #bitcoin-core-dev
1592015-10-07T16:24:35  *** adam3us has quit IRC
1602015-10-07T16:36:07  *** maaku__ is now known as maaku
1612015-10-07T17:15:24  <stonecoldpat> hi, is there any reason payment protocol files (i.e. paymentserver.cpp) is inside the /qt folder?
1622015-10-07T17:15:46  <morcos> BlueMatt: you around?
1632015-10-07T17:15:58  <morcos> there is definitely some mempool stressing going on now
1642015-10-07T17:16:10  <stonecoldpat> (apart from the fact it is used by qt, the logic doesnt need to be there from what i can tell)
1652015-10-07T17:16:30  <morcos> i started a new node running 6722 (with 50MB mempool) and within a few mins it was rejecting txs
1662015-10-07T17:16:47  <morcos> I think it would be great to add some more debugging output to 6722
1672015-10-07T17:17:03  <sipa> stonecoldpat: it relies on qt's ssl inplementatiin, unfortunately
1682015-10-07T17:17:15  <sipa> s/inplementatiin/interface/
1692015-10-07T17:18:34  <paveljanik> morcos, yup, https://bitcoinfees.github.io/#30m
1702015-10-07T17:19:46  <morcos> interestingly this "attack" does not depend only on chains of transactions.  i've had a node up running my new low limits since yesterday and its up to 178M of mempool usage itself
1712015-10-07T17:25:02  *** d_t has quit IRC
1722015-10-07T17:25:47  <stonecoldpat> sipa: ah i see, thats quite annoying! thanks though :)
1732015-10-07T17:33:02  <paveljanik> example tx: 895e6500146b67dc668eb73ce490cdf6c49ad2a5682a599b8f12fa97952f2400
1742015-10-07T17:39:36  <Luke-Jr> hmm
1752015-10-07T17:39:55  <Luke-Jr> so to bring BIP70 to bitcoind probably means replacing that with libcurl or smth
1762015-10-07T17:40:06  <Luke-Jr> or maybe it could just use QtNetwork as an optional dep
1772015-10-07T17:42:52  <paveljanik> 100inputs, 1 output, fee 15000
1782015-10-07T17:43:21  <wumpus> Luke-Jr: evhttp would work just as well - but I don't think moving it to bitcoind would make a lot of sense, at least the fetching part. Parsing/processing of payment messages might.
1792015-10-07T17:43:32  <stonecoldpat> Luke-Jr: I dont know if it has QtNetwork (if its related to the Q classes), for example QByteArray is used for the payment data structure, but that isn't accessible without core
1802015-10-07T17:44:00  <stonecoldpat> s/core/qt
1812015-10-07T17:44:14  <stonecoldpat> wumpus: thats what i was hoping to do, verify payment messages using bitcoind
1822015-10-07T17:44:18  <wumpus> then again, I think it'd be better to make a BIP70 handling library that is completely independent of bitcoind
1832015-10-07T17:45:04  <Luke-Jr> wumpus: probably
1842015-10-07T17:45:12  <Luke-Jr> BIP70 adoption is not going fast enough IMO
1852015-10-07T17:45:15  <wumpus> that would have been better, it could be done pretty much independent of any specific wallet / frontend implementation
1862015-10-07T17:45:28  <wumpus> and also include functionality to make payment protocol messages
1872015-10-07T17:48:11  <wumpus> an example could interface to bitcoind and handle BIP70 either as client as server - as long as it is clear that it is a layer on top
1882015-10-07T17:49:36  <kanzure> what is the measure of bip70 adoption?
1892015-10-07T17:49:38  <stonecoldpat> wumpus: ah you mean like another module, but it interacts with bitcoind to do the signing? (so builds payment message, and then calls rpc of bicoind to create and sign transaction?)
1902015-10-07T17:49:52  <stonecoldpat> at the moment, its supported by bitpay and coinbase, so 100k+ merchants should be using it
1912015-10-07T17:50:10  <wumpus> stonecoldpat: yes
1922015-10-07T17:50:38  <randy-waterhouse> "should be"
1932015-10-07T17:51:53  <Luke-Jr> it's very hard for non-merchants to use, though
1942015-10-07T17:51:57  <kanzure> sounds like coinbase/bitpay might have internal metrics around adoption, but other than that we don't know? just curious what Luke-Jr is estimating from because would be useful.
1952015-10-07T17:52:41  <Luke-Jr> kanzure: also, most wallets besides Core don't support sending to it
1962015-10-07T17:53:32  <sipa> afaik, nearly no wallets support creating payment requesrts...
1972015-10-07T17:53:36  *** sipa sets mode: -o sipa
1982015-10-07T17:54:16  <stonecoldpat> Luke-Jr: I wouldn't say thats entirely true, core, bitcoinj, breadwallet, hive, electrum support sending payments to a payment request, but as sipa said there is no wallet that supports creating a request
1992015-10-07T17:54:24  <kanzure> wallet/implementation adoption is much easier to measure than user usage. so i'll give you that.
2002015-10-07T17:54:36  <Luke-Jr> stonecoldpat: oh? didn't know Electrum did for example
2012015-10-07T17:55:14  <stonecoldpat> Luke-Jr: they seem to have code in their github for it (ive never used electrum)
2022015-10-07T17:56:47  <stonecoldpat> Luke-Jr: actually, for electrum it may only be for creating a payment request, sorry for that.
2032015-10-07T17:58:59  <stonecoldpat> wumpus: if it would help, I can look into making a module for bip70 that interfaces with bitcoind
2042015-10-07T17:59:34  <Luke-Jr> stonecoldpat: as wumpus said, an external library would probably be best ;)
2052015-10-07T17:59:50  <wumpus> stonecoldpat: well I would write it generally, as a library; then one of the examples could be interfacing with bitcoind
2062015-10-07T18:02:28  <wumpus> stonecoldpat: I think binding it to bitcoind specifically reduces the usefulness, people may want to use other wallets, or even without a wallet (just a database of addresses, of which one is dealt out for every now payment)
2072015-10-07T18:07:28  <stonecoldpat> wumpus: ah okay, yes that makes sense. i'll have a look into getting a library made then. This is actually better than what I planned to do, now i don't have to worry about messing with core code which should be easier. :)
2082015-10-07T18:09:55  <wumpus> stonecoldpat: :)
2092015-10-07T18:27:35  *** bitdevsnyc has joined #bitcoin-core-dev
2102015-10-07T18:32:53  *** ParadoxSpiral_ has joined #bitcoin-core-dev
2112015-10-07T18:35:46  *** ParadoxSpiral has quit IRC
2122015-10-07T18:42:27  *** alpalp has quit IRC
2132015-10-07T18:48:34  *** Guest74766 is now known as pigeons
2142015-10-07T18:52:34  *** BlueMatt has joined #bitcoin-core-dev
2152015-10-07T19:25:57  *** moli has joined #bitcoin-core-dev
2162015-10-07T19:27:39  *** molly has quit IRC
2172015-10-07T19:46:44  *** harding_ has joined #bitcoin-core-dev
2182015-10-07T19:47:11  *** harding has quit IRC
2192015-10-07T19:49:22  *** molly has joined #bitcoin-core-dev
2202015-10-07T19:49:45  *** belcher has joined #bitcoin-core-dev
2212015-10-07T19:52:26  *** moli has quit IRC
2222015-10-07T21:22:39  *** treehug88 has quit IRC
2232015-10-07T21:41:07  <GitHub83> [bitcoin] sipa opened pull request #6776: Support -checkmempool=N, which runs checks once every N transactions (master...fraccheck) https://github.com/bitcoin/bitcoin/pull/6776
2242015-10-07T21:46:53  *** ParadoxSpiral_ has quit IRC
2252015-10-07T22:00:57  *** randy-waterhouse has quit IRC
2262015-10-07T22:11:15  *** bitdevsn_ has joined #bitcoin-core-dev
2272015-10-07T22:15:02  *** bitdevsnyc has quit IRC
2282015-10-07T22:24:29  *** BashCo has quit IRC
2292015-10-07T22:26:11  *** bitdevsnyc has joined #bitcoin-core-dev
2302015-10-07T22:28:49  *** bitdevsn_ has quit IRC
2312015-10-07T22:32:31  *** BashCo has joined #bitcoin-core-dev
2322015-10-07T22:34:09  *** adam3us has joined #bitcoin-core-dev
2332015-10-07T23:24:15  <dcousens> wumpus: short of something more formal, https://github.com/feross/buffer/pull/81#issuecomment-146362284 should be OK for now
2342015-10-07T23:24:51  *** BashCo has quit IRC
2352015-10-07T23:24:52  <dcousens> If you know any JS wallet devs that aren't in that post,  feel free to PM me and I'll tag (or tag them yourself)
2362015-10-07T23:43:23  *** moli has joined #bitcoin-core-dev
2372015-10-07T23:46:19  *** molly has quit IRC
2382015-10-07T23:57:50  *** goregrin1 has joined #bitcoin-core-dev