12015-10-18T00:04:53  *** d_t has joined #bitcoin-core-dev
  22015-10-18T00:09:08  *** CodeShark has quit IRC
  32015-10-18T00:15:40  *** midnightmagic has joined #bitcoin-core-dev
  42015-10-18T00:23:37  *** midnightmagic has quit IRC
  52015-10-18T00:24:39  *** midnightmagic has joined #bitcoin-core-dev
  62015-10-18T00:27:37  *** Thireus has quit IRC
  72015-10-18T01:54:18  *** Ylbam has quit IRC
  82015-10-18T02:05:33  *** belcher has quit IRC
  92015-10-18T02:43:21  *** alpalp has quit IRC
 102015-10-18T02:45:15  *** alpalp has joined #bitcoin-core-dev
 112015-10-18T02:49:01  *** d_t has quit IRC
 122015-10-18T02:59:20  *** fkhan has quit IRC
 132015-10-18T03:11:42  *** d_t has joined #bitcoin-core-dev
 142015-10-18T03:12:15  *** fkhan has joined #bitcoin-core-dev
 152015-10-18T04:54:51  *** PRab_ has joined #bitcoin-core-dev
 162015-10-18T04:55:42  *** gribble has quit IRC
 172015-10-18T04:57:54  *** helo_ has joined #bitcoin-core-dev
 182015-10-18T04:58:07  *** gmaxwell_ has joined #bitcoin-core-dev
 192015-10-18T04:58:21  *** gavinand1esen has joined #bitcoin-core-dev
 202015-10-18T04:58:22  *** luke-jr_ has joined #bitcoin-core-dev
 212015-10-18T04:58:24  *** aj__ has joined #bitcoin-core-dev
 222015-10-18T04:58:31  *** gmaxwell_ is now known as Guest81501
 232015-10-18T04:59:53  *** Guest81501 has quit IRC
 242015-10-18T04:59:54  *** Guest81501 has joined #bitcoin-core-dev
 252015-10-18T05:01:06  *** cfields_ has joined #bitcoin-core-dev
 262015-10-18T05:01:32  *** phantomcircuit_ has joined #bitcoin-core-dev
 272015-10-18T05:02:52  *** PRab has quit IRC
 282015-10-18T05:02:53  *** aj has quit IRC
 292015-10-18T05:02:55  *** Luke-Jr has quit IRC
 302015-10-18T05:02:56  *** jonasschnelli has quit IRC
 312015-10-18T05:02:56  *** baldur has quit IRC
 322015-10-18T05:02:57  *** phantomcircuit has quit IRC
 332015-10-18T05:02:57  *** GAit has quit IRC
 342015-10-18T05:02:58  *** BlueMatt has quit IRC
 352015-10-18T05:03:00  *** helo has quit IRC
 362015-10-18T05:03:01  *** berndj has quit IRC
 372015-10-18T05:03:03  *** gmaxwell has quit IRC
 382015-10-18T05:03:03  *** cfields has quit IRC
 392015-10-18T05:03:05  *** gavinandresen has quit IRC
 402015-10-18T05:03:15  *** GAit has joined #bitcoin-core-dev
 412015-10-18T05:03:39  *** GAit is now known as Guest13178
 422015-10-18T05:03:40  *** phantomcircuit_ is now known as phantomcircuit
 432015-10-18T05:03:41  *** berndj has joined #bitcoin-core-dev
 442015-10-18T05:04:04  *** BlueMatt has joined #bitcoin-core-dev
 452015-10-18T05:09:03  *** gribble has joined #bitcoin-core-dev
 462015-10-18T05:09:51  *** baldur has joined #bitcoin-core-dev
 472015-10-18T05:10:46  *** ProfMac has quit IRC
 482015-10-18T05:12:15  *** luke-jr_ is now known as Luke-Jr
 492015-10-18T05:22:19  *** d_t has quit IRC
 502015-10-18T05:50:41  *** JoeLiu has joined #bitcoin-core-dev
 512015-10-18T05:56:11  *** jonasschnelli has joined #bitcoin-core-dev
 522015-10-18T06:40:15  *** d_t has joined #bitcoin-core-dev
 532015-10-18T06:58:33  *** Guest81501 is now known as gmaxwell
 542015-10-18T07:09:24  *** Ylbam has joined #bitcoin-core-dev
 552015-10-18T07:26:34  *** maaku has quit IRC
 562015-10-18T07:28:16  *** maaku has joined #bitcoin-core-dev
 572015-10-18T07:28:40  *** maaku is now known as Guest88932
 582015-10-18T07:31:35  *** Guest88932 is now known as maaku
 592015-10-18T07:36:55  <JoeLiu>  Is there any book for Bitcoin developping?
 602015-10-18T07:36:56  *** d_t has quit IRC
 612015-10-18T07:53:45  *** CodeShark has joined #bitcoin-core-dev
 622015-10-18T07:54:52  <Luke-Jr> JoeLiu: bitcoin.org has some useful documentation
 632015-10-18T08:04:23  *** dcousens has joined #bitcoin-core-dev
 642015-10-18T08:04:34  <dcousens> gmaxwell: you around?
 652015-10-18T08:04:52  <dcousens> Just had my node drop, was curious why
 662015-10-18T08:04:53  <dcousens> bitcoind
 672015-10-18T08:04:53  <dcousens> Killed
 682015-10-18T08:04:59  <dcousens> Nothing more on the console
 692015-10-18T08:05:43  <dcousens> last few messages on the debug.log are 2015-10-16 18:14:46 socket sending timeout: 37784s
 702015-10-18T08:06:28  <phantomcircuit> dcousens, run dmesg
 712015-10-18T08:06:32  <phantomcircuit> im guessing out of memory
 722015-10-18T08:06:42  <dcousens> ta, ya OOM.
 732015-10-18T08:07:00  <dcousens> Though shouldn't have bitcoind thrown an error std::bad_alloc etc?
 742015-10-18T08:08:18  <dcousens> is there any way I can stop this from happening?
 752015-10-18T08:08:22  <dcousens> I had a higher minrelaytxfee
 762015-10-18T08:11:08  <phantomcircuit> dcousens, how much memory do you have?
 772015-10-18T08:11:42  <dcousens> phantomcircuit: on this node? 2GB
 782015-10-18T08:12:05  <phantomcircuit> drop the maxconnections limit is probably what you have to do
 792015-10-18T08:12:07  <phantomcircuit> unfortunately
 802015-10-18T08:12:18  <dcousens> would just setting an even higher relay fee work maybe?
 812015-10-18T08:12:43  <dcousens> also,  whats the easiest way to track this data over time?
 822015-10-18T08:12:57  <dcousens> (like, say, process v mempool MB size)
 832015-10-18T08:14:30  <phantomcircuit> dcousens, you can call getmempoolinfo and dump that to a file somewhere
 842015-10-18T08:16:15  <Luke-Jr> 2 GB is plenty. Probably your relay policy is too broad and is storing spam.
 852015-10-18T08:36:15  *** aj__ is now known as aj
 862015-10-18T09:19:59  <dcousens>  Luke-Jr: default policy, so probably
 872015-10-18T09:20:08  <dcousens> 0.12 couldn't come sooner :)
 882015-10-18T09:21:05  <Luke-Jr> software versions are not for policies.
 892015-10-18T09:21:14  <Luke-Jr> you're supposed to configure that yourself
 902015-10-18T09:24:10  <dcousens> Luke-Jr: if I were to configure this node for what it is being paid to do,  it'd be a leech solely
 912015-10-18T09:24:34  <dcousens> I don't have time to allocate to configuring policy, so, the defaults matter
 922015-10-18T09:24:58  <dcousens> Maybe if policy was as simple as dropping in some pre-written CPP files that there were a library of somewhere
 932015-10-18T09:25:15  <dcousens> But, I'm not aware (nor is it advertised) of that
 942015-10-18T09:26:11  <dcousens> (by leech solely, I mean, it'd only download blocks, no relay whatsoever)
 952015-10-18T09:28:52  <Luke-Jr> then you get to deal with the unlimited resource consumption. we don't have time to help you.
 962015-10-18T09:30:18  <Luke-Jr> deciding and configuring policy is part of the job of running a node, *especially* if you're being paid to do it..
 972015-10-18T09:31:51  <dcousens> Luke-Jr: lol, conceptually I agree with you, but pragmatically things tend to be different
 982015-10-18T09:32:16  <Luke-Jr> instead you get paid to do it, and then go insist others do your job on their unpaid (at least by you) time..
 992015-10-18T09:33:37  <dcousens> Luke-Jr: I wasn't insisting anything?
1002015-10-18T09:33:53  <Luke-Jr> [09:20:08] <dcousens> 0.12 couldn't come sooner ☺ [09:24:34] <dcousens> I don't have time to allocate to configuring policy, so, the defaults matter
1012015-10-18T09:33:57  <Luke-Jr> sure sounds like it
1022015-10-18T09:34:11  <dcousens> I understand the implications of OSS,  its all I do all day
1032015-10-18T09:34:17  <Luke-Jr> pragmatically, you're the one left without a working node, and having to explain to whoever is paying you why you're not doing the job
1042015-10-18T09:34:27  <dcousens> Doesn't mean I can't express interest in some of the changes that will be deployed as defaults in 0.12
1052015-10-18T09:35:02  <Luke-Jr> dcousens: we adopted a "don't change default policy" principle a bit ago. maybe we should have stuck to it stronger..
1062015-10-18T09:36:46  * Luke-Jr goes to bed.
1072015-10-18T09:37:24  <dcousens> Luke-Jr: night,  sorry you took my comments the wrong way.  phantomcircuit thanks for the help
1082015-10-18T09:55:45  *** JoeLiu has quit IRC
1092015-10-18T10:03:30  <GitHub28> [bitcoin] dcousens opened pull request #6846: bitcoind: alias -h for --help (master...aliash) https://github.com/bitcoin/bitcoin/pull/6846
1102015-10-18T10:06:57  *** randy-waterhouse has joined #bitcoin-core-dev
1112015-10-18T10:45:07  *** Thireus has joined #bitcoin-core-dev
1122015-10-18T11:16:26  *** dcousens has quit IRC
1132015-10-18T11:25:20  *** belcher has joined #bitcoin-core-dev
1142015-10-18T15:03:49  *** Guest13178 is now known as GAit
1152015-10-18T15:44:11  *** randy-waterhouse has quit IRC
1162015-10-18T15:47:01  *** Thireus has quit IRC
1172015-10-18T15:49:06  *** BananaLotus has quit IRC
1182015-10-18T15:50:26  *** guruvan has quit IRC
1192015-10-18T15:50:42  *** BananaLotus has joined #bitcoin-core-dev
1202015-10-18T15:54:44  *** BananaLotus has joined #bitcoin-core-dev
1212015-10-18T15:55:39  *** guruvan has joined #bitcoin-core-dev
1222015-10-18T16:18:16  *** d_t has joined #bitcoin-core-dev
1232015-10-18T16:18:56  *** d_t has joined #bitcoin-core-dev
1242015-10-18T16:29:12  <GitHub58> [bitcoin] rnicoll opened pull request #6848: Add DERSIG transaction test cases (master...bip66-tests) https://github.com/bitcoin/bitcoin/pull/6848
1252015-10-18T16:48:46  *** Thireus has joined #bitcoin-core-dev
1262015-10-18T16:56:19  *** Thireus has quit IRC
1272015-10-18T16:57:11  *** rrrandom has joined #bitcoin-core-dev
1282015-10-18T16:57:15  *** d_t has quit IRC
1292015-10-18T16:58:54  *** belcher has quit IRC
1302015-10-18T17:00:31  *** rrrandom has quit IRC
1312015-10-18T17:01:03  *** Thireus has joined #bitcoin-core-dev
1322015-10-18T17:01:47  *** belcher has joined #bitcoin-core-dev
1332015-10-18T17:11:31  *** d_t has joined #bitcoin-core-dev
1342015-10-18T17:25:20  *** Thireus has quit IRC
1352015-10-18T18:26:39  <GitHub31> [bitcoin] afk11 opened pull request #6849: Mention PHP bindings to libbitcoinconsensus (master...bitcoinconsensus-php-bindings) https://github.com/bitcoin/bitcoin/pull/6849
1362015-10-18T19:20:26  *** ParadoxSpiral has joined #bitcoin-core-dev
1372015-10-18T19:26:26  *** ParadoxSpiral has quit IRC
1382015-10-18T19:26:58  *** JoeLiu has joined #bitcoin-core-dev
1392015-10-18T19:28:31  *** ParadoxSpiral has joined #bitcoin-core-dev
1402015-10-18T19:32:29  <GitHub197> [bitcoin] bittylicious opened pull request #6850: Improve AddToWallet performance when rescanning (master...master) https://github.com/bitcoin/bitcoin/pull/6850
1412015-10-18T19:34:50  <gmaxwell> Luke-Jr: ^
1422015-10-18T20:00:27  *** paveljanik has joined #bitcoin-core-dev
1432015-10-18T20:11:13  *** belcher has quit IRC
1442015-10-18T20:11:28  *** belcher has joined #bitcoin-core-dev
1452015-10-18T20:17:13  <gmaxwell> Luke-Jr: So I'd rather remove smart times completely than have rescans take 9.5 hours longer in that case. :P so you should help him figure out how to get the behavior right.
1462015-10-18T20:17:41  <gmaxwell> we never would have merged smart times knowing that it added hours to the rescan of a 200k key wallet.
1472015-10-18T20:18:38  <Luke-Jr> :/
1482015-10-18T20:19:12  <Luke-Jr> this is the first complaint of that nature, whereas we used to have regular complaints about tranasction times before smart-times got released..
1492015-10-18T20:19:27  <gmaxwell> Luke-Jr: we have had regular complaints about rescan taking forever for a long time.
1502015-10-18T20:19:34  <Luke-Jr> O.o
1512015-10-18T20:19:36  <gmaxwell> Just didn't know smarttimes were part of it until now.
1522015-10-18T20:19:47  <gmaxwell> heck, even I've complained about it. :)
1532015-10-18T20:19:49  <Luke-Jr> it's rare enough I assumed he meant reindex
1542015-10-18T20:20:06  <gmaxwell> Luke-Jr: no, rescale! as in zapwallettx (which he mentioned specifically)
1552015-10-18T20:20:12  <gmaxwell> er rescan.
1562015-10-18T20:20:32  <Luke-Jr> I mean, rescan and zapwallettx are not daily tasks
1572015-10-18T20:20:35  <Luke-Jr> reindex is getting to be :/
1582015-10-18T20:21:04  <gmaxwell> Luke-Jr: people are zaping frequently because of the malleation attacks.
1592015-10-18T20:21:18  <gmaxwell> still, this also means reindex would be slow, as we run the same code there.
1602015-10-18T20:23:39  <Luke-Jr> if it's really 9.5 hours longer, then any significant optimisation is likely to require changing the database non-trivially, which is dangerous. I consider slow better than dangerous, since we plan to go away from bdb someday anyway. So if bad times in day-to-day use is preferable to slow rescan, reverting it may be our best option. :|
1612015-10-18T20:25:11  <Luke-Jr> I'll take a look and see if I'm wrong about the risk, but that's what 9.5 hours suggests to me.
1622015-10-18T20:35:32  <Luke-Jr> ok, we can probably get a lot of improvement by caching the ordered tx list rather than sorting it every add
1632015-10-18T20:35:40  <Luke-Jr> >_<
1642015-10-18T20:38:16  <Luke-Jr> any simple way to benchmark?
1652015-10-18T20:40:15  *** paveljanik has quit IRC
1662015-10-18T20:45:01  *** ParadoxSpiral has quit IRC
1672015-10-18T21:05:31  *** Thireus has joined #bitcoin-core-dev
1682015-10-18T21:08:29  <Luke-Jr> gmaxwell: this would be easier if I could remove accounting first; thoughts?
1692015-10-18T21:08:31  <Luke-Jr> wumpus: ^
1702015-10-18T21:12:28  *** Thireus1 has joined #bitcoin-core-dev
1712015-10-18T21:14:40  *** Thireus has quit IRC
1722015-10-18T21:20:03  *** moli has joined #bitcoin-core-dev
1732015-10-18T21:22:59  *** molly has quit IRC
1742015-10-18T21:35:45  *** JoeLiu has quit IRC
1752015-10-18T22:31:30  *** CodeShark has quit IRC
1762015-10-18T23:45:26  <gmaxwell> Luke-Jr: why do you need the sorted list?
1772015-10-18T23:45:37  <gmaxwell> Luke-Jr: can you not cache a min or max?