1 2015-11-07T00:01:25 *** danielsocials has joined #bitcoin-core-dev
2 2015-11-07T00:48:11 *** danielsocials has quit IRC
3 2015-11-07T00:49:55 *** danielsocials has joined #bitcoin-core-dev
4 2015-11-07T01:10:20 *** danielsocials has quit IRC
5 2015-11-07T01:14:01 *** danielsocials has joined #bitcoin-core-dev
6 2015-11-07T01:24:24 *** Ylbam has quit IRC
7 2015-11-07T01:28:39 <phantomcircuit> gmaxwell, well yes i was wondering if you had a % ?
8 2015-11-07T01:28:55 <phantomcircuit> (of course this changes with the hardware, but a ballpark)
9 2015-11-07T01:31:23 <gmaxwell> phantomcircuit: no clue, actually depends on other stuff going on. it wastes memory/tlb bandwidth.
10 2015-11-07T01:31:40 <gmaxwell> e.g. it's free if the next thing you're going to do is immediate run in a tight loop already in cache. :)
11 2015-11-07T01:32:11 <gmaxwell> obvious thing to try would be to drop the zeroizing from the code and benchmark, but I've not done that (well not recently at least).
12 2015-11-07T01:32:53 <gmaxwell> I don't think this has yet ever saved our bacon, but I've dealt with vulnerabilities elsewhere that would be made unexploitable due to zeroizing network buffers.
13 2015-11-07T01:33:24 <sipa> i'm generally in favor of saving bacon
14 2015-11-07T01:35:52 <gmaxwell> Bitcoin Core used to have a number of other adhoc additional security measures which have been dropped.
15 2015-11-07T01:36:14 <gmaxwell> E.g. there eas stack randomization via recursion for each thread.
16 2015-11-07T01:37:48 <sipa> which was actually optimized out by modern compilers...
17 2015-11-07T01:38:55 <gmaxwell> the zeroize on free could end up optimized out too (though I doubt it is currently!)
18 2015-11-07T01:40:02 *** baldur has quit IRC
19 2015-11-07T01:40:24 *** baldur has joined #bitcoin-core-dev
20 2015-11-07T01:45:05 *** guest234234 has joined #bitcoin-core-dev
21 2015-11-07T01:45:17 <phantomcircuit> it would be nice if compilers supported "dont optimize this block"
22 2015-11-07T01:46:41 <sipa> phantomcircuit: not optimizing doesn't mean they suddenly have to respect stronger semantics
23 2015-11-07T01:47:36 <gmaxwell> phantomcircuit: C(++) is _not_ a fancy macro assembler.
24 2015-11-07T01:49:18 <gmaxwell> The language only promises to obey certian observable semantics of a particular abstract machine. The language cannot be directly mapped to your instruction set without _some_ transformation, (though not much if you're targeting a PDP-11 :) ) ... so there will always be some difference between what the code explicitly says and what the machine does.
25 2015-11-07T01:51:02 <sipa> PDP-11... didn't the y use braindead byte ordering?
26 2015-11-07T01:52:02 <sipa> Ah, wikipedia calls it "Middle-endian". Boring.
27 2015-11-07T01:58:31 *** danielsocials has quit IRC
28 2015-11-07T02:00:48 *** sipa has quit IRC
29 2015-11-07T02:10:11 *** Guest23423 has joined #bitcoin-core-dev
30 2015-11-07T02:12:27 *** guest234234 has quit IRC
31 2015-11-07T02:23:17 *** Guest23423 has quit IRC
32 2015-11-07T02:26:58 *** belcher has quit IRC
33 2015-11-07T03:00:56 <Luke-Jr> [01:51:02] <sipa> PDP-11⦠didn't the y use braindead byte ordering? <-- what are those symbols supposed to be?
34 2015-11-07T03:02:06 <Luke-Jr> oh, it's a unicode DELETE :x
35 2015-11-07T03:03:40 <jgarzik> speaking of unicode, thanks for the JSON issues wumpus
36 2015-11-07T03:23:36 *** jtimon has joined #bitcoin-core-dev
37 2015-11-07T04:04:37 *** challisto has joined #bitcoin-core-dev
38 2015-11-07T04:25:06 <GitHub189> [bitcoin] pstratem opened pull request #6966: Cache CWalletDB pointer in CWallet to improve performance (master...wallet_speedup) https://github.com/bitcoin/bitcoin/pull/6966
39 2015-11-07T04:31:46 *** jtimon has quit IRC
40 2015-11-07T04:36:10 *** grubles has quit IRC
41 2015-11-07T04:47:26 *** CodeShark_ has quit IRC
42 2015-11-07T05:00:43 *** gribble has quit IRC
43 2015-11-07T05:15:39 *** gribble has joined #bitcoin-core-dev
44 2015-11-07T07:12:45 <btcdrak> gmaxwell: sipa: petertodd: what do you think of this patch for the sequence numbers PR https://github.com/NicolasDorier/bitcoin/commit/5f24b6603407c78ae112ae82fd293ac24fbefb52
45 2015-11-07T07:27:47 *** ParadoxSpiral has joined #bitcoin-core-dev
46 2015-11-07T07:41:58 *** PaulCapestany has quit IRC
47 2015-11-07T07:49:12 *** Ylbam has joined #bitcoin-core-dev
48 2015-11-07T07:50:51 *** guest234234 has joined #bitcoin-core-dev
49 2015-11-07T08:12:44 *** PaulCapestany has joined #bitcoin-core-dev
50 2015-11-07T08:21:05 *** Thireus has quit IRC
51 2015-11-07T08:39:34 *** PaulCapestany has quit IRC
52 2015-11-07T08:42:08 *** PaulCapestany has joined #bitcoin-core-dev
53 2015-11-07T08:50:19 *** sipa has joined #bitcoin-core-dev
54 2015-11-07T09:21:05 *** fanquake has joined #bitcoin-core-dev
55 2015-11-07T09:44:11 *** Thireus has joined #bitcoin-core-dev
56 2015-11-07T09:53:27 *** CodeShark_ has joined #bitcoin-core-dev
57 2015-11-07T10:10:21 <btcdrak> correction, this commit instead https://github.com/bitcoin/bitcoin/commit/6a9495392f0f89ed9ce46ff2bc3460ce443f407a
58 2015-11-07T11:02:29 *** CodeShark_ has quit IRC
59 2015-11-07T11:02:39 *** guest234234 has quit IRC
60 2015-11-07T11:02:46 *** CodeShark_ has joined #bitcoin-core-dev
61 2015-11-07T12:46:27 *** jtimon has joined #bitcoin-core-dev
62 2015-11-07T13:13:36 *** guest234234 has joined #bitcoin-core-dev
63 2015-11-07T14:35:39 *** ParadoxSpiral_ has joined #bitcoin-core-dev
64 2015-11-07T14:35:46 *** ParadoxSpiral has quit IRC
65 2015-11-07T14:43:16 *** guest234234 has quit IRC
66 2015-11-07T14:43:22 *** Guest23423 has joined #bitcoin-core-dev
67 2015-11-07T14:59:27 *** Guest23423 has quit IRC
68 2015-11-07T15:20:26 *** zooko has joined #bitcoin-core-dev
69 2015-11-07T15:36:52 <jgarzik> cfields, FYI - we should be running "make $N_CPUS distcheck" in travis for bitcoin
70 2015-11-07T15:37:12 <jgarzik> secp256k1 already does this; just updated univalue to do so.
71 2015-11-07T15:42:27 *** NLNico has joined #bitcoin-core-dev
72 2015-11-07T16:01:50 <cfields> jgarzik: sounds good. At one pont we had to manually specify, because our number was using too much mem
73 2015-11-07T16:01:58 <cfields> i don't think it's a problem anymore, though
74 2015-11-07T16:02:19 <jgarzik> cfields, my basic point is s/make check/make distcheck/
75 2015-11-07T16:02:35 <cfields> jgarzik: oh. we have a distcheck build
76 2015-11-07T16:02:56 <jgarzik> cfields, in bitcoin? where?
77 2015-11-07T16:03:15 <cfields> jgarzik: rather, we 'make dist', cd into the result, and build from there
78 2015-11-07T16:03:25 <cfields> can't remember now why it's not an actual distcheck
79 2015-11-07T16:03:36 <cfields> s/dist/distdir
80 2015-11-07T16:03:47 <jgarzik> cfields, So, restarting, that's my point. We need to be doing make distcheck
81 2015-11-07T16:04:29 <jgarzik> cfields, Right now it bombs out in configure with DB C++ headers/libs. I haven't debugged.
82 2015-11-07T16:04:49 <jgarzik> cfields, 'make distcheck' has several additional validations over and above 'make dist' or 'make check'
83 2015-11-07T16:04:56 <cfields> jgarzik: heh, fair enough. i'm trying to remember why i did it that way
84 2015-11-07T16:05:38 <cfields> jgarzik: right. distcheck definitely passed somewhat recently. there are hacks in there to deal with making leveldb work
85 2015-11-07T16:05:57 <jgarzik> if [ "$RUN_TESTS" = "true" ]; then make $MAKEJOBS distcheck; fi
86 2015-11-07T16:07:03 <jgarzik> cfields, 'distcheck' verifies build attributes like builddir!=srcdir and several other useful details - it catches accidentally omitted make-clean objects as another of many examples.
87 2015-11-07T16:07:11 <cfields> jgarzik: need to avoid doing the double-configure, then. That would make it a third
88 2015-11-07T16:07:24 <jgarzik> cfields, ..and adds a build...
89 2015-11-07T16:08:02 <jgarzik> cfields, My guess was to distcheck on one-and-only-one build matrix build
90 2015-11-07T16:08:08 <cfields> jgarzik: well i think ccache would make the rebuild time close to zero. would need to experiment a bit with keeping the time down
91 2015-11-07T16:08:10 <cfields> but yes, i agree
92 2015-11-07T16:10:19 *** MarcoFalke has joined #bitcoin-core-dev
93 2015-11-07T16:17:49 *** JackH has joined #bitcoin-core-dev
94 2015-11-07T16:29:25 *** fanquake has left #bitcoin-core-dev
95 2015-11-07T16:42:12 *** zooko has quit IRC
96 2015-11-07T17:01:25 *** NLNico has quit IRC
97 2015-11-07T18:50:08 *** paveljanik has joined #bitcoin-core-dev
98 2015-11-07T18:57:16 <MarcoFalke> What could be done when travis hangs?
99 2015-11-07T18:59:59 <MarcoFalke> thanks, running again.
100 2015-11-07T19:09:52 *** CodeShark_ has quit IRC
101 2015-11-07T20:01:55 *** challisto has quit IRC
102 2015-11-07T20:27:38 *** PaulCapestany has quit IRC
103 2015-11-07T20:31:01 *** PaulCapestany has joined #bitcoin-core-dev
104 2015-11-07T20:44:59 *** evoskuil has quit IRC
105 2015-11-07T20:48:58 *** CodeShark_ has joined #bitcoin-core-dev
106 2015-11-07T22:05:45 *** evoskuil has joined #bitcoin-core-dev
107 2015-11-07T22:09:51 *** CodeShark_ has quit IRC
108 2015-11-07T22:10:09 *** CodeShark has joined #bitcoin-core-dev
109 2015-11-07T22:10:09 *** CodeShark_ has joined #bitcoin-core-dev
110 2015-11-07T22:23:49 *** davec has quit IRC
111 2015-11-07T22:29:15 *** davec has joined #bitcoin-core-dev
112 2015-11-07T22:30:55 *** MarcoFalke has quit IRC
113 2015-11-07T23:22:21 *** ParadoxSpiral_ has quit IRC
114 2015-11-07T23:36:03 *** CodeShark has quit IRC
115 2015-11-07T23:36:03 *** CodeShark_ has quit IRC
116 2015-11-07T23:44:05 <gmaxwell> I believe there is nothing more waiting for 0.11 RC. If I'm incorrect, someone please pipe up and tell me what other PRs I should be reviewing/testing.
117 2015-11-07T23:51:08 <gmaxwell> wumpus: ^
118 2015-11-07T23:51:56 <wumpus> I don't think there's anything to be done there either (well apart from version bump and release notes)
119 2015-11-07T23:52:20 <wumpus> (and release notes don't necessarily have to wait before the tag)
120 2015-11-07T23:56:37 <GitHub160> [bitcoin] laanwj pushed 1 new commit to 0.11: https://github.com/bitcoin/bitcoin/commit/984587ac5d3e5593737605a89b442cf0a439a79a
121 2015-11-07T23:56:38 <GitHub160> bitcoin/0.11 984587a Wladimir J. van der Laan: bump version to 0.11.2
122 2015-11-07T23:57:40 <wumpus> * [new tag] v0.11.2rc1 -> v0.11.2rc1
123 2015-11-07T23:58:44 <GitHub55> [bitcoin] TheBlueMatt closed pull request #6964: Use Pieter's signing subkey instead of his primary key (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6964
124 2015-11-07T23:59:07 <GitHub183> [bitcoin] TheBlueMatt opened pull request #6967: Use Pieter's signing subkey instead of his primary key (master...verify-commits-fixes) https://github.com/bitcoin/bitcoin/pull/6967