1 2015-12-15T00:00:02  *** jannes has quit IRC
  2 2015-12-15T00:04:31  *** fkhan has joined #bitcoin-core-dev
  3 2015-12-15T00:05:06  *** go1111111 has quit IRC
  4 2015-12-15T00:09:38  *** morcos has joined #bitcoin-core-dev
  5 2015-12-15T00:19:23  *** Tera2342 has joined #bitcoin-core-dev
  6 2015-12-15T00:23:34  *** go1111111 has joined #bitcoin-core-dev
  7 2015-12-15T00:36:53  *** bitdevsnyc has joined #bitcoin-core-dev
  8 2015-12-15T00:37:28  *** zookolaptop has quit IRC
  9 2015-12-15T00:38:56  *** bitdevsn_ has quit IRC
 10 2015-12-15T00:43:36  *** Tera2342 has quit IRC
 11 2015-12-15T00:44:22  *** Tera2342 has joined #bitcoin-core-dev
 12 2015-12-15T00:59:57  *** Tera2342 has quit IRC
 13 2015-12-15T01:03:22  *** bitdevsnyc has quit IRC
 14 2015-12-15T01:05:04  *** bitdevsnyc has joined #bitcoin-core-dev
 15 2015-12-15T01:19:35  *** Tera2342 has joined #bitcoin-core-dev
 16 2015-12-15T01:31:28  *** Ylbam has quit IRC
 17 2015-12-15T01:32:47  <Luke-Jr> sipa: FYI, there are actually people and miners using master in production (albeit not many enough that it should be a problem)
 18 2015-12-15T02:13:02  *** Quent has quit IRC
 19 2015-12-15T02:37:49  <dcousens> sipa: indeed
 20 2015-12-15T02:37:53  <dcousens> uh, Luke-Jr*
 21 2015-12-15T02:38:20  <dcousens> but, those same cases are probably running custom policies anyway
 22 2015-12-15T02:40:08  *** tripleslash has joined #bitcoin-core-dev
 23 2015-12-15T02:47:43  *** bitdevsnyc has quit IRC
 24 2015-12-15T03:01:48  *** Tera2342 has quit IRC
 25 2015-12-15T03:03:43  <Luke-Jr> dcousens: yes, that guy's problem was clearly unrelated to these facts
 26 2015-12-15T03:06:32  *** afk11 has quit IRC
 27 2015-12-15T03:36:54  <sipa> Luke-Jr: ok, good to know?
 28 2015-12-15T03:37:39  <sipa> s/\?//
 29 2015-12-15T03:42:09  *** PaulCapestany has joined #bitcoin-core-dev
 30 2015-12-15T03:42:42  *** PaulCapestany has quit IRC
 31 2015-12-15T04:06:01  *** zookolaptop has joined #bitcoin-core-dev
 32 2015-12-15T04:12:47  *** challisto has joined #bitcoin-core-dev
 33 2015-12-15T04:12:48  *** challisto has joined #bitcoin-core-dev
 34 2015-12-15T04:19:55  *** bitdevsnyc has joined #bitcoin-core-dev
 35 2015-12-15T04:21:46  *** aj has joined #bitcoin-core-dev
 36 2015-12-15T04:24:38  *** bitdevsnyc has quit IRC
 37 2015-12-15T04:28:46  *** bitdevsnyc has joined #bitcoin-core-dev
 38 2015-12-15T04:36:17  <dcousens> Luke-Jr: why is the ECDSA mess in Fedora relevant?
 39 2015-12-15T04:36:47  <Luke-Jr> dcousens: because it's impossible to support building it against the OS as a result…………….nevermind, we switched to libsecp256k1
 40 2015-12-15T04:37:03  <dcousens> right
 41 2015-12-15T04:37:08  *** bitdevsn_ has joined #bitcoin-core-dev
 42 2015-12-15T04:40:08  *** bitdevsnyc has quit IRC
 43 2015-12-15T04:56:08  *** arowser has quit IRC
 44 2015-12-15T04:56:29  *** arowser has joined #bitcoin-core-dev
 45 2015-12-15T04:58:16  *** Thireus has quit IRC
 46 2015-12-15T05:46:42  *** Tera2342 has joined #bitcoin-core-dev
 47 2015-12-15T06:13:26  *** xiangfu has quit IRC
 48 2015-12-15T06:13:40  *** xiangfu has joined #bitcoin-core-dev
 49 2015-12-15T06:15:45  *** Quent has joined #bitcoin-core-dev
 50 2015-12-15T06:20:11  *** droark has joined #bitcoin-core-dev
 51 2015-12-15T06:20:48  *** bitdevsn_ has quit IRC
 52 2015-12-15T06:24:03  *** jl2012 has quit IRC
 53 2015-12-15T06:24:52  *** jl2012 has joined #bitcoin-core-dev
 54 2015-12-15T06:42:36  *** zookolaptop has quit IRC
 55 2015-12-15T06:58:57  *** Ylbam has joined #bitcoin-core-dev
 56 2015-12-15T07:40:17  *** dcousens has quit IRC
 57 2015-12-15T07:46:32  *** btcdrak has quit IRC
 58 2015-12-15T08:07:19  *** Thireus has joined #bitcoin-core-dev
 59 2015-12-15T08:09:31  *** midnightmagic has quit IRC
 60 2015-12-15T09:13:24  *** raedah has quit IRC
 61 2015-12-15T09:20:46  *** PaulCapestany has joined #bitcoin-core-dev
 62 2015-12-15T09:26:28  *** ParadoxSpiral has joined #bitcoin-core-dev
 63 2015-12-15T09:28:09  *** PaulCapestany has quit IRC
 64 2015-12-15T09:29:53  *** PaulCapestany has joined #bitcoin-core-dev
 65 2015-12-15T10:02:32  *** harding has quit IRC
 66 2015-12-15T10:24:14  *** randy-waterhouse has quit IRC
 67 2015-12-15T10:47:48  *** btcdrak has joined #bitcoin-core-dev
 68 2015-12-15T10:56:16  *** MarcoFalke has joined #bitcoin-core-dev
 69 2015-12-15T11:02:21  *** jgarzik has quit IRC
 70 2015-12-15T11:06:15  *** moli has quit IRC
 71 2015-12-15T11:07:53  *** moli has joined #bitcoin-core-dev
 72 2015-12-15T11:20:03  *** asoltys has quit IRC
 73 2015-12-15T11:27:41  *** laurentmt has joined #bitcoin-core-dev
 74 2015-12-15T11:28:15  *** laurentmt has quit IRC
 75 2015-12-15T11:38:43  <Luke-Jr> jonasschnelli: simple_prodname updated for more testing
 76 2015-12-15T12:02:42  <jonasschnelli> Luke-Jr: okay. Thanks,... will build again.
 77 2015-12-15T12:09:06  *** Tera2342 has quit IRC
 78 2015-12-15T12:13:09  *** MarcoFalke has quit IRC
 79 2015-12-15T12:13:42  *** MarcoFalke has joined #bitcoin-core-dev
 80 2015-12-15T12:35:01  *** afk11 has joined #bitcoin-core-dev
 81 2015-12-15T12:38:55  *** afk11 has quit IRC
 82 2015-12-15T12:43:58  <phantomcircuit> wumpus, i assume CWallet::fFileBacked is used for test harness stuff?
 83 2015-12-15T12:48:48  <jonasschnelli> phantomcircuit: IMO, the fFileBackend is legacy stuff and unused.
 84 2015-12-15T12:51:21  <phantomcircuit> jonasschnelli, it's used by the recovery code apparently
 85 2015-12-15T12:51:26  <phantomcircuit> CWallet dummyWallet;
 86 2015-12-15T12:53:13  *** Tera2342 has joined #bitcoin-core-dev
 87 2015-12-15T12:54:40  <jonasschnelli> phantomcircuit: that might be possible... right
 88 2015-12-15T12:57:29  <phantomcircuit> jonasschnelli, lol there's no good reason for it either
 89 2015-12-15T12:58:01  <phantomcircuit> and it's also used in wallet_tests.cpp
 90 2015-12-15T12:58:48  <jonasschnelli> wallet_test does use it over a file backend? not?
 91 2015-12-15T12:59:09  <jonasschnelli> test_bitcoin.cpp calls 'pwalletMain = new CWallet("wallet.dat");'
 92 2015-12-15T12:59:22  <phantomcircuit> jonasschnelli, src/wallet/wallet_tests.cpp
 93 2015-12-15T13:00:03  <jonasschnelli> Arg. Right: static CWallet wallet;
 94 2015-12-15T13:00:23  <jonasschnelli> Maybe for test reasons it could make sense... although, even there we could inject a tmp file
 95 2015-12-15T13:00:40  <jonasschnelli> (and get rid of the fFileBackend stuff)
 96 2015-12-15T13:17:16  <jonasschnelli> Luke-Jr: background has now to tiffs,... but does not appear on my mac. Maybe a DSStore problem? Why did you change the DS_Store file anyway? Because of the icon position (based on the filename)?
 97 2015-12-15T13:32:26  *** laurentmt has joined #bitcoin-core-dev
 98 2015-12-15T13:36:06  *** laurentmt has quit IRC
 99 2015-12-15T13:37:05  *** ParadoxSpiral_ has joined #bitcoin-core-dev
100 2015-12-15T13:39:58  *** ParadoxSpiral has quit IRC
101 2015-12-15T13:51:56  *** Cory has quit IRC
102 2015-12-15T14:00:05  *** Quent1 has joined #bitcoin-core-dev
103 2015-12-15T14:02:16  *** Quent has quit IRC
104 2015-12-15T14:04:00  <GitHub138> [bitcoin] tnull opened pull request #7216: Removed offline testnet DNSSeed 'alexykot.me'. (master...delete_offline_dnsseed) https://github.com/bitcoin/bitcoin/pull/7216
105 2015-12-15T14:15:35  *** Guest51235 has joined #bitcoin-core-dev
106 2015-12-15T14:17:11  *** Guest51235 has quit IRC
107 2015-12-15T14:18:52  *** midnightmagic has joined #bitcoin-core-dev
108 2015-12-15T14:20:24  *** Cory has joined #bitcoin-core-dev
109 2015-12-15T14:33:12  *** challisto has quit IRC
110 2015-12-15T14:43:46  *** molz has joined #bitcoin-core-dev
111 2015-12-15T14:44:16  *** ParadoxSpiral_ has left #bitcoin-core-dev
112 2015-12-15T14:44:55  *** moli has quit IRC
113 2015-12-15T15:22:13  *** afk11 has joined #bitcoin-core-dev
114 2015-12-15T15:35:20  *** Tera2342 has quit IRC
115 2015-12-15T15:37:18  *** Guyver2 has joined #bitcoin-core-dev
116 2015-12-15T15:41:24  *** jgarzik has joined #bitcoin-core-dev
117 2015-12-15T15:47:45  *** helo has quit IRC
118 2015-12-15T15:48:51  *** helo_ is now known as helo
119 2015-12-15T15:49:12  *** tripleslash has quit IRC
120 2015-12-15T15:51:26  *** laurentmt has joined #bitcoin-core-dev
121 2015-12-15T15:51:46  *** laurentmt has quit IRC
122 2015-12-15T16:15:29  *** zookolaptop has joined #bitcoin-core-dev
123 2015-12-15T16:45:27  *** Cory has quit IRC
124 2015-12-15T16:51:22  *** Cory has joined #bitcoin-core-dev
125 2015-12-15T17:08:07  *** jgarzik has quit IRC
126 2015-12-15T17:28:55  *** tripleslash has joined #bitcoin-core-dev
127 2015-12-15T17:31:25  *** Prattler has joined #bitcoin-core-dev
128 2015-12-15T17:42:05  *** tripleslash has quit IRC
129 2015-12-15T17:49:31  *** tripleslash has joined #bitcoin-core-dev
130 2015-12-15T17:53:53  *** jgarzik has joined #bitcoin-core-dev
131 2015-12-15T17:53:53  *** jgarzik has joined #bitcoin-core-dev
132 2015-12-15T17:53:57  *** jgarzik has quit IRC
133 2015-12-15T17:57:50  *** grayjedi has joined #bitcoin-core-dev
134 2015-12-15T17:58:44  *** MarcoFalke has quit IRC
135 2015-12-15T18:04:54  *** desantis has joined #bitcoin-core-dev
136 2015-12-15T18:07:21  *** tripleslash has quit IRC
137 2015-12-15T18:10:03  <sdaftuar> if anyone is up for reviewing 7062, it could use some review (one of last two PRs tagged for 0.12 that's not yet merged).
138 2015-12-15T18:16:09  *** paveljanik has joined #bitcoin-core-dev
139 2015-12-15T18:16:09  *** paveljanik has joined #bitcoin-core-dev
140 2015-12-15T18:42:16  *** grayjedi has left #bitcoin-core-dev
141 2015-12-15T18:44:49  *** desantis has quit IRC
142 2015-12-15T18:45:28  *** desantis has joined #bitcoin-core-dev
143 2015-12-15T19:22:27  *** desantis has quit IRC
144 2015-12-15T19:23:04  *** desantis has joined #bitcoin-core-dev
145 2015-12-15T19:23:25  *** desantis has quit IRC
146 2015-12-15T19:42:47  *** ChainQuery-Ian has joined #bitcoin-core-dev
147 2015-12-15T19:48:21  *** Quent1 is now known as Quent
148 2015-12-15T19:50:31  *** desantis has joined #bitcoin-core-dev
149 2015-12-15T19:51:39  *** desantis has quit IRC
150 2015-12-15T19:51:59  *** desantis has joined #bitcoin-core-dev
151 2015-12-15T19:53:19  *** treehug88 has joined #bitcoin-core-dev
152 2015-12-15T19:58:56  *** desantis has left #bitcoin-core-dev
153 2015-12-15T20:01:19  *** desantis has joined #bitcoin-core-dev
154 2015-12-15T20:01:46  <desantis> honest question: How does this channel differ from bitcoin-dev?
155 2015-12-15T20:03:07  <sipa> This is specifically about the Bitcoin Core software, and its implementation details
156 2015-12-15T20:03:31  <sipa> #bitcoin-dev is more for development of the protocol
157 2015-12-15T20:08:42  *** zookolaptop has quit IRC
158 2015-12-15T20:12:08  *** Luke-Jr has quit IRC
159 2015-12-15T20:12:45  *** Luke-Jr has joined #bitcoin-core-dev
160 2015-12-15T20:17:16  <desantis> sipa: thanks!
161 2015-12-15T20:23:05  *** desantis has quit IRC
162 2015-12-15T20:23:26  <sdaftuar> why do blocks with more sigops than MAX_BLOCK_SIGOPS not get marked as failed (BLOCK_FAILED_VALID)?
163 2015-12-15T20:23:37  *** desantis has joined #bitcoin-core-dev
164 2015-12-15T20:24:40  *** desantis has quit IRC
165 2015-12-15T20:24:56  *** desantis has joined #bitcoin-core-dev
166 2015-12-15T20:33:13  <sipa> sdaftuar: thry should!
167 2015-12-15T20:33:56  <sdaftuar> sipa: ah, good to know
168 2015-12-15T20:46:57  <GitHub85> [bitcoin] sdaftuar opened pull request #7217: Mark blocks with too many sigops as failed (master...fix-sigops-rejection) https://github.com/bitcoin/bitcoin/pull/7217
169 2015-12-15T20:57:29  *** desantis has quit IRC
170 2015-12-15T20:57:49  *** desantis has joined #bitcoin-core-dev
171 2015-12-15T20:58:16  *** zookolaptop has joined #bitcoin-core-dev
172 2015-12-15T21:04:55  *** zookolaptop has quit IRC
173 2015-12-15T21:11:19  *** zookolaptop has joined #bitcoin-core-dev
174 2015-12-15T21:12:39  *** ChainQuery-Ian has quit IRC
175 2015-12-15T21:28:02  *** zookolaptop has quit IRC
176 2015-12-15T21:41:53  *** helo has quit IRC
177 2015-12-15T21:46:20  *** helo has joined #bitcoin-core-dev
178 2015-12-15T21:51:09  *** moli has joined #bitcoin-core-dev
179 2015-12-15T21:52:10  *** molz has quit IRC
180 2015-12-15T21:53:46  *** afk11 has quit IRC
181 2015-12-15T21:54:15  *** raedah has joined #bitcoin-core-dev
182 2015-12-15T21:59:32  *** bitdevsnyc has joined #bitcoin-core-dev
183 2015-12-15T22:12:19  *** zookolaptop has joined #bitcoin-core-dev
184 2015-12-15T22:15:18  *** Guyver2 has quit IRC
185 2015-12-15T22:19:29  *** treehug88 has quit IRC
186 2015-12-15T22:21:40  *** paveljanik has quit IRC
187 2015-12-15T22:21:49  *** job_ has joined #bitcoin-core-dev
188 2015-12-15T22:22:52  <job_> BlueMatt gmaxwell good seeing you guys last night. a few quick questions about getblocktemplate when you've got a sec
189 2015-12-15T22:22:56  *** job_ is now known as jamesob
190 2015-12-15T22:23:54  <BlueMatt> go for it
191 2015-12-15T22:24:44  <jamesob> i) what, in particular, about getblocktemplate requires holding cs_main? is it just that CreateNewBlock needs it, or do we want a consistent snapshot of the txs to include in the template?
192 2015-12-15T22:25:00  <sipa> yeah, consistent snapshot
193 2015-12-15T22:25:09  <sipa> and later verification of the constructed block
194 2015-12-15T22:25:19  <sipa> which needs access to the utxo set
195 2015-12-15T22:25:45  <jamesob> okay, so we need a consistent view of the utxo set to validate the block template we've just constructed
196 2015-12-15T22:27:07  <jamesob> ii) under what circumstances do we want to rebuild this blocktemplate cache we're talking about replacing the `CreateNewBlock` routine with?
197 2015-12-15T22:27:10  <BlueMatt> jamesob: yes, CreateNewBlock needs a consistent snapshot of the utxo
198 2015-12-15T22:27:21  <BlueMatt> so getblocktemplate shouldn't take cs_main, but CreateNewBlock will, ofc, have to
199 2015-12-15T22:27:24  <jamesob> e.g. on new chain tip, on new txs, periodically?
200 2015-12-15T22:27:50  <jamesob> or some/all of the above
201 2015-12-15T22:27:53  <BlueMatt> hmm? no, keep CreateNewBlock, just cache its output in a field that getblocktemplate reads from
202 2015-12-15T22:28:10  <BlueMatt> as for rebuilding, just call CreateNewBlock on a timer for now
203 2015-12-15T22:28:15  <BlueMatt> we can get smarter later :)
204 2015-12-15T22:28:26  <jamesob> right on
205 2015-12-15T22:28:48  <jamesob> so should we start with a PR that moves CreateNewBlock to a time-rebuilt cache, then iterate from there?
206 2015-12-15T22:28:50  <BlueMatt> and the timer can be aggressive as long as CreateNewBlock aggressively gives up cs_main and just fails when a new block is coming in
207 2015-12-15T22:29:16  <BlueMatt> I'd assume all three things from last night can fit into one pr
208 2015-12-15T22:29:26  <BlueMatt> I'd hope its not much code, though, again, I havent looked at it
209 2015-12-15T22:29:42  <BlueMatt> problem with moving CNB to a background-thread by itself is you end up with way more cs_main time :(
210 2015-12-15T22:29:57  <jamesob> it looks like there's gonna be some shuffling... might have to factor the innards of the rpc definition out into some separate bit that we can call from some scheduled routine
211 2015-12-15T22:30:08  <jamesob> BlueMatt yeah, that's what I was thinking...
212 2015-12-15T22:30:31  <jamesob> like, if we've got this thing acquiring cs_main on an aggressive regular schedule, that may cause MORE contention
213 2015-12-15T22:30:32  <BlueMatt> yea, I figured half of the rpc code would have to be moved out
214 2015-12-15T22:30:35  <BlueMatt> that wouldnt surprise me
215 2015-12-15T22:31:02  <BlueMatt> yup, hence the requirement to drop cs_main and fail mid-process if there is "important" contention (ie a new block came in)
216 2015-12-15T22:31:18  <BlueMatt> contention around cs_main for other things sucks, but doesnt matter too much to most users
217 2015-12-15T22:31:59  <jamesob> ah, right. is there some existing pattern for saying "hey, this is a low-prio lock acquisition, allow interrupts"?
218 2015-12-15T22:32:25  <BlueMatt> nope
219 2015-12-15T22:32:33  <sipa> a large portion of the cs_main locking is actually due to ProcessMessage/SendMessage, which don't actually need cs_main (they could get their own locks that lock node-specific data)
220 2015-12-15T22:32:35  <BlueMatt> (and dont go overengineering there, either, which would be easy to do)
221 2015-12-15T22:32:45  <BlueMatt> ahhhhh, scope creep
222 2015-12-15T22:32:49  <jamesob> heh
223 2015-12-15T22:33:02  <BlueMatt> this one is wayyyy too easy to scope-creep on
224 2015-12-15T22:33:17  <jamesob> don't worry, I'm just tryin' to hold onto my ass for now -- not going to go on any cosmic refactoring adventures ;)
225 2015-12-15T22:33:32  <BlueMatt> adding a global boolean called fAboutToLockCSMainForBlockProcessing sucks, but.....more than that is gonna lead to bike shedding
226 2015-12-15T22:35:27  *** fwfwefwef has joined #bitcoin-core-dev
227 2015-12-15T22:35:28  <jamesob> so, I forget: your suggestion was to set fAboutToLock...=true once you're going to rebuild the cache, and drop out of the process if some other thread has set that flag to false, i.e. signifying that there's some more important op that needs that lock?
228 2015-12-15T22:36:40  <BlueMatt> no, set the flag to true in ProcessMessage or AcceptNewBlock or wherever cs_main is first locked for block acceptance (from RPC or net, you really need to check both)
229 2015-12-15T22:36:52  <BlueMatt> then CNB will poll that flag a bunch while its running, and if it sees it, bail out
230 2015-12-15T22:36:55  *** fwfwefwef has quit IRC
231 2015-12-15T22:37:08  <jamesob> gotcha
232 2015-12-15T22:37:18  <BlueMatt> once you get cs_main for new block processing, you can then drop the flag and let the background CNB thread wait for its turn for cs_main
233 2015-12-15T22:37:22  <sipa> note that such a flag technically would require its own lock :)
234 2015-12-15T22:37:30  <BlueMatt> yup :(
235 2015-12-15T22:37:44  <sipa> or an atomic bool (but c++11 isn't quite there yet...)
236 2015-12-15T22:37:52  <BlueMatt> yea, this is muchhh nicer with atomics
237 2015-12-15T22:37:59  <BlueMatt> since atomic bool is guaranteed to be lock-free
238 2015-12-15T22:38:09  <sipa> is it?
239 2015-12-15T22:38:11  <BlueMatt> fGonnaLockHereRealSoonNow = true; LOCK(cs_main); fGonnaLockHereRealSoonNow = false;
240 2015-12-15T22:39:24  <BlueMatt> oops, no, sorry, atomic_flag is guaranteed, atomic_bool is not
241 2015-12-15T22:39:31  <jamesob> cool. iii) how do we want to handle this periodic rebuild; is this going to hook into the CScheduler abstraction somehow, or would we dedicate a whole new thread for it (which I doubt)?
242 2015-12-15T22:39:45  <sipa> use CScheduler
243 2015-12-15T22:40:02  <jamesob> roger
244 2015-12-15T22:44:49  *** molz has joined #bitcoin-core-dev
245 2015-12-15T22:46:25  *** moli has quit IRC
246 2015-12-15T22:46:59  *** tripleslash has joined #bitcoin-core-dev
247 2015-12-15T22:49:54  <jamesob> good seeing you last night as well, sipa. hope you got some sleep :)
248 2015-12-15T22:50:39  <sipa> i did!
249 2015-12-15T22:55:04  *** belcher has joined #bitcoin-core-dev
250 2015-12-15T22:56:26  *** jamesob has quit IRC
251 2015-12-15T23:03:27  *** tripleslash has quit IRC
252 2015-12-15T23:03:40  *** tripleslash has joined #bitcoin-core-dev
253 2015-12-15T23:10:55  *** molz has quit IRC
254 2015-12-15T23:12:51  *** randy-waterhouse has joined #bitcoin-core-dev
255 2015-12-15T23:14:42  *** bitdevsn_ has joined #bitcoin-core-dev
256 2015-12-15T23:17:31  *** desantis has quit IRC
257 2015-12-15T23:17:51  *** bitdevsnyc has quit IRC
258 2015-12-15T23:46:46  *** zookolaptop has quit IRC
259 2015-12-15T23:47:14  *** moli has joined #bitcoin-core-dev