12016-02-11T00:08:36  *** frankenmint has joined #bitcoin-core-dev
  22016-02-11T00:20:12  *** skyraider_ has quit IRC
  32016-02-11T00:24:10  *** laurentmt has joined #bitcoin-core-dev
  42016-02-11T00:24:21  *** laurentmt has quit IRC
  52016-02-11T00:28:25  *** Ylbam has quit IRC
  62016-02-11T00:50:43  *** goregrind has joined #bitcoin-core-dev
  72016-02-11T00:53:41  *** goregrin1 has quit IRC
  82016-02-11T01:09:49  <GitHub59> [bitcoin] promag opened pull request #7506: Use CCoinControl selection in CWallet::FundTransaction (master...enhancement/use-coin-control-selection) https://github.com/bitcoin/bitcoin/pull/7506
  92016-02-11T01:11:45  *** pmienk has quit IRC
 102016-02-11T01:16:58  *** pmienk has joined #bitcoin-core-dev
 112016-02-11T01:28:59  *** wallet42 has joined #bitcoin-core-dev
 122016-02-11T01:34:06  *** mkarrer_ has joined #bitcoin-core-dev
 132016-02-11T01:36:11  *** mkarrer has quit IRC
 142016-02-11T02:10:56  *** lecusemb1e has joined #bitcoin-core-dev
 152016-02-11T02:12:35  *** justanot1eruser has joined #bitcoin-core-dev
 162016-02-11T02:13:02  *** justanotheruser has quit IRC
 172016-02-11T02:14:40  *** afk11_ has joined #bitcoin-core-dev
 182016-02-11T02:15:31  *** afk11 has quit IRC
 192016-02-11T02:15:31  *** lecusemble has quit IRC
 202016-02-11T02:26:34  *** bityogi has quit IRC
 212016-02-11T02:29:42  <GitHub87> [bitcoin] Leviathn opened pull request #7507: Remove internal miner (master...master) https://github.com/bitcoin/bitcoin/pull/7507
 222016-02-11T02:58:41  *** jtimon has quit IRC
 232016-02-11T03:16:51  *** Thireus has quit IRC
 242016-02-11T03:19:22  *** Thireus has joined #bitcoin-core-dev
 252016-02-11T03:20:23  *** Evel-Knievel has quit IRC
 262016-02-11T03:21:01  *** Evel-Knievel has joined #bitcoin-core-dev
 272016-02-11T03:21:26  *** afk11_ has quit IRC
 282016-02-11T03:22:16  *** afk11 has joined #bitcoin-core-dev
 292016-02-11T03:33:35  *** Chris_Stewart_5 has quit IRC
 302016-02-11T03:38:02  *** Sparyx has quit IRC
 312016-02-11T03:48:52  *** justanot1eruser is now known as justanotheruser
 322016-02-11T04:06:06  *** wasi has quit IRC
 332016-02-11T04:28:07  *** Sparyx has joined #bitcoin-core-dev
 342016-02-11T04:49:12  *** p15 has joined #bitcoin-core-dev
 352016-02-11T05:12:40  *** Cory has quit IRC
 362016-02-11T05:15:17  *** Pasha has joined #bitcoin-core-dev
 372016-02-11T05:18:13  *** wasi has joined #bitcoin-core-dev
 382016-02-11T05:22:11  *** Pasha is now known as Cory
 392016-02-11T05:26:11  *** Sparyx has quit IRC
 402016-02-11T05:27:40  *** wallet42 has quit IRC
 412016-02-11T05:42:53  *** Sparyx has joined #bitcoin-core-dev
 422016-02-11T06:25:08  *** Sparyx has quit IRC
 432016-02-11T06:32:42  *** Sparyx has joined #bitcoin-core-dev
 442016-02-11T06:38:45  <GitHub131> [bitcoin] luke-jr opened pull request #7509: Common argument defaults for NODE_BLOOM stuff and -wallet (master...common_defaults_0.12) https://github.com/bitcoin/bitcoin/pull/7509
 452016-02-11T06:46:11  *** dermoth has joined #bitcoin-core-dev
 462016-02-11T06:58:40  <GitHub178> [bitcoin] luke-jr opened pull request #7510: Read/write bitcoin_rw.conf for exposing shared Daemon/GUI options in the GUI (master...rwconf) https://github.com/bitcoin/bitcoin/pull/7510
 472016-02-11T07:04:50  *** Sparyx has quit IRC
 482016-02-11T07:06:07  *** paveljanik has joined #bitcoin-core-dev
 492016-02-11T07:11:26  *** Sparyx has joined #bitcoin-core-dev
 502016-02-11T07:18:36  <GitHub1> [bitcoin] paveljanik opened pull request #7511: [WIP] New ax_pthread.m4 from upstream - draft 3 (not final), for testing on all platforms (master...20160211_WIP_test_new_ax_pthread) https://github.com/bitcoin/bitcoin/pull/7511
 512016-02-11T07:22:50  *** BashCo_ has quit IRC
 522016-02-11T07:29:01  *** Alopex has quit IRC
 532016-02-11T07:30:06  *** Alopex has joined #bitcoin-core-dev
 542016-02-11T07:41:37  <GitHub17> [bitcoin] laanwj closed pull request #7493: rpc: add null assert (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7493
 552016-02-11T07:52:26  *** Ylbam has joined #bitcoin-core-dev
 562016-02-11T08:02:10  *** BashCo has joined #bitcoin-core-dev
 572016-02-11T08:10:10  *** NewLiberty_ has quit IRC
 582016-02-11T08:24:46  *** MazrimTaim has joined #bitcoin-core-dev
 592016-02-11T08:31:30  *** AaronvanW has joined #bitcoin-core-dev
 602016-02-11T08:46:58  *** Sparyx has quit IRC
 612016-02-11T08:47:31  *** Thireus1 has joined #bitcoin-core-dev
 622016-02-11T08:52:31  *** Thireus has quit IRC
 632016-02-11T08:52:31  *** midnightmagic has quit IRC
 642016-02-11T08:56:45  *** Sparyx has joined #bitcoin-core-dev
 652016-02-11T08:58:57  *** midnightmagic has joined #bitcoin-core-dev
 662016-02-11T09:07:36  <GitHub88> [bitcoin] jmacwhyte opened pull request #7514: Fix IsInitialBlockDownload for testnet (master...fixisinitialblock) https://github.com/bitcoin/bitcoin/pull/7514
 672016-02-11T09:28:12  *** qlql has joined #bitcoin-core-dev
 682016-02-11T09:50:19  *** Thireus1 has quit IRC
 692016-02-11T09:50:32  *** Thireus has joined #bitcoin-core-dev
 702016-02-11T09:55:45  *** Sparyx has quit IRC
 712016-02-11T09:56:19  *** NewLiberty has joined #bitcoin-core-dev
 722016-02-11T09:59:38  *** gevs has quit IRC
 732016-02-11T10:12:43  *** Sparyx has joined #bitcoin-core-dev
 742016-02-11T10:12:47  *** gevs has joined #bitcoin-core-dev
 752016-02-11T10:54:04  *** adnn_ has joined #bitcoin-core-dev
 762016-02-11T10:54:47  *** Sparyx has quit IRC
 772016-02-11T10:56:38  *** adnn has quit IRC
 782016-02-11T11:06:23  *** Sparyx has joined #bitcoin-core-dev
 792016-02-11T11:15:45  *** laurentmt has joined #bitcoin-core-dev
 802016-02-11T11:16:38  *** laurentmt has quit IRC
 812016-02-11T11:42:23  *** wasi has quit IRC
 822016-02-11T11:43:03  *** randy-waterhouse has quit IRC
 832016-02-11T12:05:36  *** murch has joined #bitcoin-core-dev
 842016-02-11T12:33:13  *** wallet42 has joined #bitcoin-core-dev
 852016-02-11T12:33:14  *** murch has quit IRC
 862016-02-11T12:36:26  *** Prattler has quit IRC
 872016-02-11T12:37:15  *** Prattler has joined #bitcoin-core-dev
 882016-02-11T12:37:22  *** wallet42 has quit IRC
 892016-02-11T12:43:54  *** Sparyx has quit IRC
 902016-02-11T12:48:11  *** Sparyx has joined #bitcoin-core-dev
 912016-02-11T12:51:12  *** p15x has joined #bitcoin-core-dev
 922016-02-11T12:57:38  *** laurentmt has joined #bitcoin-core-dev
 932016-02-11T13:16:09  *** laurentmt has quit IRC
 942016-02-11T13:24:46  *** justanotheruser has quit IRC
 952016-02-11T13:30:05  *** laurentmt has joined #bitcoin-core-dev
 962016-02-11T13:37:01  *** Sparyx has quit IRC
 972016-02-11T13:39:02  <da2ce7> it would be nice to get https://github.com/bitcoin/bitcoin/pull/7346 merged if there aren’t any further objections to it.
 982016-02-11T13:51:21  *** Thireus has quit IRC
 992016-02-11T13:52:29  *** laurentmt has quit IRC
1002016-02-11T13:54:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1012016-02-11T13:56:03  *** jtimon has joined #bitcoin-core-dev
1022016-02-11T13:56:25  *** Sparyx has joined #bitcoin-core-dev
1032016-02-11T14:05:45  <sipa> wumpus: there is no release note entry for the new fundrawtransaction RPC
1042016-02-11T14:06:22  <wumpus> sipa: correct
1052016-02-11T14:07:35  <sipa> list of all new RPCs: disconnectnode, setban, listbanned, clearbanned, getblockheader, fundrawtransaction, estimatesmartfee, estimatesmartpriority, abandontransaction, importpubkey
1062016-02-11T14:07:58  <sipa> i forgot about most of these already...
1072016-02-11T14:08:04  *** Chris_Stewart_5 has quit IRC
1082016-02-11T14:08:24  *** justanotheruser has joined #bitcoin-core-dev
1092016-02-11T14:10:17  <wumpus> me too - could mention them shortly in the release notes, for documentation they can check 'help <rpc>', the release notes are already long enough that no one will see it anyhow :)
1102016-02-11T14:11:33  <sipa> maybe that's a reason for having more frequent releases? *ducks*
1112016-02-11T14:12:44  *** p15 has quit IRC
1122016-02-11T14:12:47  <wumpus> meh, I can't take the release stress more than twice a year
1132016-02-11T14:13:00  *** p15x has quit IRC
1142016-02-11T14:13:48  <sipa> that's why i duck :)
1152016-02-11T14:13:50  <wumpus> maybe we could appoint someone to do the hammer-people-with-deadlines part for me
1162016-02-11T14:14:18  <wumpus> yeah :)
1172016-02-11T14:14:29  <sipa> damn, there are so many release note entries that maybe they should be organized per topic
1182016-02-11T14:14:55  <sipa> RPC changes, wallet changes, P2P changes, policy changes
1192016-02-11T14:16:00  <wumpus> other people think we should sort by other criteria https://github.com/bitcoin/bitcoin/pull/7429
1202016-02-11T14:16:21  <wumpus> I wonder if everyone would ever agree on a sorting :)
1212016-02-11T14:17:10  <wumpus> I mean, sorting by category would make some sense, on the other hand e.g. not all wallet changes are of the same importance to most users
1222016-02-11T14:18:24  <sipa> ah, ok
1232016-02-11T14:18:52  *** p15x has joined #bitcoin-core-dev
1242016-02-11T14:20:46  <wumpus> on the other hand the bottom list is already sorted by category so there is precedent
1252016-02-11T14:22:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1262016-02-11T14:23:29  <wumpus> and if anyone wants to sort it this would be the time, it's unlikely there will still be major changes, well apart from 7346 but that one should be merged
1272016-02-11T14:30:48  <GitHub42> [bitcoin] laanwj closed pull request #7346: 0.12 release notes: Mining Policy Changes (0.12...0.12-release-notes-mining) https://github.com/bitcoin/bitcoin/pull/7346
1282016-02-11T14:30:48  <GitHub123> [bitcoin] laanwj pushed 6 new commits to 0.12: https://github.com/bitcoin/bitcoin/compare/772863583c35...04503f78c750
1292016-02-11T14:30:49  <GitHub123> bitcoin/0.12 4b8d2bc Luke Dashjr: release-notes: Cover priority changes correctly, removing mentions of possible futures
1302016-02-11T14:30:49  <GitHub123> bitcoin/0.12 73a0375 Luke Dashjr: release-notes: Mention possibility of priority removal in 0.13, uncertainty of priority calculation being changed back, and request community input
1312016-02-11T14:30:50  <GitHub123> bitcoin/0.12 d0dbb6d Luke Dashjr: release-notes: Remove suggestion to use 0.11
1322016-02-11T14:31:18  <morcos> heh, i wonder if i should explain what estimatesmart does?  nah..
1332016-02-11T14:31:29  <sipa> morcos: i honestly have no clue what it does
1342016-02-11T14:32:45  <morcos> the idea is i might add more functionality to it in the future, so didn't want people to start depending on it yet.  but the main advantage is if you ask for an estimate at a target of N and there is no estimate, it starts incrementing N until it can give you an estimate and then returns the target it was able to find an estimate at as well
1352016-02-11T14:33:29  <morcos> but it also does a couple other smart things like recognize mempool limiting min fees
1362016-02-11T14:36:14  <morcos> estimatesmart is what all the internal code uses now, but didn't want to break functionality that depended on the old API
1372016-02-11T14:42:56  *** laurentmt has joined #bitcoin-core-dev
1382016-02-11T14:53:46  *** laurentmt has quit IRC
1392016-02-11T14:57:44  *** Guyver2 has joined #bitcoin-core-dev
1402016-02-11T14:58:26  *** Sparyx has quit IRC
1412016-02-11T15:01:31  *** frankenmint has quit IRC
1422016-02-11T15:07:54  *** laurentmt has joined #bitcoin-core-dev
1432016-02-11T15:07:56  *** laurentmt has quit IRC
1442016-02-11T15:08:41  *** dgenr8 has quit IRC
1452016-02-11T15:09:10  *** dgenr8 has joined #bitcoin-core-dev
1462016-02-11T15:11:11  *** Thireus has joined #bitcoin-core-dev
1472016-02-11T15:18:32  *** halovast__ has joined #bitcoin-core-dev
1482016-02-11T15:21:31  *** treehug88 has joined #bitcoin-core-dev
1492016-02-11T15:36:43  *** bityogi has joined #bitcoin-core-dev
1502016-02-11T15:42:09  *** zooko has joined #bitcoin-core-dev
1512016-02-11T15:42:47  *** p15x has quit IRC
1522016-02-11T15:50:10  <GitHub71> [bitcoin] laanwj opened pull request #7517: test: script_error checking in script_invalid tests (master...2016_02_test_script_errors) https://github.com/bitcoin/bitcoin/pull/7517
1532016-02-11T15:51:56  *** Prattler has quit IRC
1542016-02-11T15:53:36  *** Prattler has joined #bitcoin-core-dev
1552016-02-11T15:59:47  *** fkhan has quit IRC
1562016-02-11T16:05:55  *** zooko` has joined #bitcoin-core-dev
1572016-02-11T16:07:20  *** zooko has quit IRC
1582016-02-11T16:09:19  *** laurentmt has joined #bitcoin-core-dev
1592016-02-11T16:09:51  *** BashCo has quit IRC
1602016-02-11T16:10:09  *** adam3us1 has joined #bitcoin-core-dev
1612016-02-11T16:12:08  *** adam3us has quit IRC
1622016-02-11T16:15:21  *** xabbix has quit IRC
1632016-02-11T16:15:40  *** fkhan has joined #bitcoin-core-dev
1642016-02-11T16:15:48  <Luke-Jr> wumpus: What kind of backwards compatibility issues do you mean for https://github.com/bitcoin/bitcoin/pull/7510 ?
1652016-02-11T16:16:30  *** zooko` has quit IRC
1662016-02-11T16:16:32  <wumpus> the whole shitload of ways that various ways of setting settings can interact
1672016-02-11T16:16:51  <wumpus> and whether the right one takes precedence
1682016-02-11T16:17:08  <wumpus> we don't have any tests for that, certainly not for the GUI
1692016-02-11T16:18:30  <Luke-Jr> I got the param. interaction part, it's the backward compatibility part I don't understand.
1702016-02-11T16:19:18  <wumpus> that settings set through QSettings in a previous release still work
1712016-02-11T16:20:01  <Luke-Jr> k
1722016-02-11T16:20:17  <wumpus> I agree that's not necessarily a problem as long as the set of settings set through QSettings and through your mechanism is disjoint
1732016-02-11T16:20:40  <wumpus> but I was just trying to be general because I know you won't let it stay that way
1742016-02-11T16:21:27  <Luke-Jr> I had no real plans to change that, actually, but you're probably right that at least some should, and regardless testing QSettings seems reasonable
1752016-02-11T16:21:35  <wumpus> I think gui-only settings should at least stay in QSettings
1762016-02-11T16:21:47  <Luke-Jr> yeah, I agree with that
1772016-02-11T16:22:37  <Luke-Jr> wumpus: any thoughts on eliminating the enum? or is that just necessary?
1782016-02-11T16:23:17  <wumpus> I'm not sure. I like having an enumeration of settings, that's better than having arbitrary strings. Although something could be said for splitting GUI-only and core options.
1792016-02-11T16:23:39  *** xabbix has joined #bitcoin-core-dev
1802016-02-11T16:26:28  <Luke-Jr> seems like a lot of unnecessary code just to translate enumeration->string
1812016-02-11T16:26:38  <Luke-Jr> but I guess so far the 2 I added aren't that simple anywayh
1822016-02-11T16:26:47  <wumpus> the problem with the current core option handling is that it is sloppy, and part of that is due to using arbitrary magic strings everywhere
1832016-02-11T16:27:08  <wumpus> I don't necessarily want to import that into the GUI too :-)
1842016-02-11T16:27:10  <Luke-Jr> hm, so maybe the solution is to use an enum everywhere?
1852016-02-11T16:27:16  *** adam3us1 has quit IRC
1862016-02-11T16:27:23  <wumpus> possibly, I do think the options handling needs to be revamped at some point
1872016-02-11T16:27:33  <Luke-Jr> perhaps that would be best off as part of the setconfig RPC idea
1882016-02-11T16:27:36  *** adam3us has joined #bitcoin-core-dev
1892016-02-11T16:27:45  <Luke-Jr> since it needs a registry of params anyway
1902016-02-11T16:27:54  <wumpus> so that it can report misspelled or otherwise invalid options, better value checking (at init time) etc
1912016-02-11T16:28:12  <wumpus> exactly
1922016-02-11T16:29:26  *** zooko has joined #bitcoin-core-dev
1932016-02-11T16:31:50  <wumpus> thinking about it, a global enumeration will not actually be possible; different sub-parts of the application can have their own settings, e.g. the wallet, and need to be able to register them independently
1942016-02-11T16:33:42  <Luke-Jr> wumpus: a registration class can abstract the enum part?
1952016-02-11T16:34:08  <wumpus> ok
1962016-02-11T16:37:40  *** NewLiberty_ has joined #bitcoin-core-dev
1972016-02-11T16:37:55  *** btcdrak has quit IRC
1982016-02-11T16:38:55  *** NewLiberty has quit IRC
1992016-02-11T16:38:55  *** Nuief has quit IRC
2002016-02-11T16:39:16  *** michagogo has quit IRC
2012016-02-11T16:39:57  *** bityogi has quit IRC
2022016-02-11T16:40:33  *** BashCo has joined #bitcoin-core-dev
2032016-02-11T16:43:52  *** michagogo has joined #bitcoin-core-dev
2042016-02-11T16:51:22  *** treehug88 has quit IRC
2052016-02-11T16:55:03  *** zooko has quit IRC
2062016-02-11T16:55:16  *** Nuief has joined #bitcoin-core-dev
2072016-02-11T16:55:38  *** zooko has joined #bitcoin-core-dev
2082016-02-11T16:58:06  *** btcdrak has joined #bitcoin-core-dev
2092016-02-11T17:02:11  <GitHub129> [bitcoin] promag opened pull request #7518: [RPC] Add changeAddress option to fundrawtransaction (master...enhancement/fundrawtransaction-with-changeaddress) https://github.com/bitcoin/bitcoin/pull/7518
2102016-02-11T17:03:26  *** frankenmint has joined #bitcoin-core-dev
2112016-02-11T17:06:56  *** Thireus has quit IRC
2122016-02-11T17:09:10  *** frankenmint has quit IRC
2132016-02-11T17:09:17  *** halovast__ has quit IRC
2142016-02-11T17:09:40  *** bsm117532 has quit IRC
2152016-02-11T17:21:15  *** adam3us has quit IRC
2162016-02-11T17:21:26  *** zooko has quit IRC
2172016-02-11T17:21:31  *** zooko` has joined #bitcoin-core-dev
2182016-02-11T17:21:59  *** adam3us_ has joined #bitcoin-core-dev
2192016-02-11T17:26:26  *** NewLiberty_ has quit IRC
2202016-02-11T17:33:42  *** drnet has joined #bitcoin-core-dev
2212016-02-11T17:33:46  *** NewLiberty_ has joined #bitcoin-core-dev
2222016-02-11T17:38:24  *** jujumax has quit IRC
2232016-02-11T17:45:43  *** jujumax has joined #bitcoin-core-dev
2242016-02-11T17:47:31  *** murch has joined #bitcoin-core-dev
2252016-02-11T17:50:29  *** Sparyx has joined #bitcoin-core-dev
2262016-02-11T17:56:05  *** drnet has quit IRC
2272016-02-11T17:58:56  *** jarret has quit IRC
2282016-02-11T18:01:08  *** Tasoshi has joined #bitcoin-core-dev
2292016-02-11T18:03:47  *** Tasoshi_ has quit IRC
2302016-02-11T18:08:05  *** treehug88 has joined #bitcoin-core-dev
2312016-02-11T18:19:38  *** murch has quit IRC
2322016-02-11T18:20:38  *** zooko` has quit IRC
2332016-02-11T18:21:23  *** zooko has joined #bitcoin-core-dev
2342016-02-11T18:33:26  *** Thireus has joined #bitcoin-core-dev
2352016-02-11T18:33:50  *** s1w has quit IRC
2362016-02-11T18:40:30  *** s1w has joined #bitcoin-core-dev
2372016-02-11T18:40:55  *** s1w is now known as Guest42535
2382016-02-11T18:52:09  <morcos> anybody want to answer a question about CWalletTx's and save me deciphering a bunch of code?  I'm trying to figure out whether there is an easy way to calculate the fee of the tx from a CWalletTx or whether it would be easy to store this information if its not currently saved.
2392016-02-11T18:52:31  <morcos> But the Credit/Debit stuff confuses me
2402016-02-11T18:52:32  *** bityogi has joined #bitcoin-core-dev
2412016-02-11T18:54:23  <wumpus> it confuses me too
2422016-02-11T18:54:53  <wumpus> but the code to compute the fee should be thre already?
2432016-02-11T18:55:28  <morcos> what i first looked at seemed to only compute the fee if the Debit > 0 (or vice versa or something)
2442016-02-11T18:56:40  <Luke-Jr> someone -m -dev pls
2452016-02-11T18:56:58  <Luke-Jr> also -i probably etc
2462016-02-11T18:58:26  *** NewLiberty_ has quit IRC
2472016-02-11T19:00:03  <cfields> wumpus: hmm, noticed after pushing that my rc5 win doesn't match yours
2482016-02-11T19:00:06  <cfields> others match
2492016-02-11T19:00:08  <cfields> checking now
2502016-02-11T19:01:32  <sipa> morcos: the wallet only knows how to compute the fee for transactions where all inputs are from us
2512016-02-11T19:03:29  <morcos> sipa: sigh, thats going to be annoying for my feefilter code
2522016-02-11T19:03:48  <sipa> we could pass it down, though
2532016-02-11T19:03:57  <sipa> but it wouldn't work in a potential future SPV mode
2542016-02-11T19:04:23  <morcos> what do you mean by pass it down?
2552016-02-11T19:04:50  <sipa> through the signal that informs the wallet of new transactions
2562016-02-11T19:05:22  <morcos> and save it in the database?
2572016-02-11T19:05:33  <sipa> yes
2582016-02-11T19:05:46  <sipa> what do you need it for?
2592016-02-11T19:05:59  <morcos> i want to have a filter on RelayTransaction
2602016-02-11T19:06:16  <morcos> everywhere other than the wallet that that gets called is right after ATMP so i can return the fee from ATMP
2612016-02-11T19:06:25  <morcos> but the wallet resends txs
2622016-02-11T19:06:28  <sipa> RelayTransaction could be moved to main, where it has access to the UTXO set
2632016-02-11T19:07:03  *** achow101 has joined #bitcoin-core-dev
2642016-02-11T19:07:03  <morcos> you dont' want to relook it up though everywhere.
2652016-02-11T19:07:19  <morcos> maybe that would be ok for the wallet resend though
2662016-02-11T19:07:55  <morcos> oh, sdaftuar points out that in all the other use cases when you look it up, you'll find it in the mempool... so maybe that would be ok too
2672016-02-11T19:07:58  <morcos> ok i'll play around
2682016-02-11T19:11:56  *** Sparyx has quit IRC
2692016-02-11T19:12:11  *** wallet42 has joined #bitcoin-core-dev
2702016-02-11T19:15:29  *** wallet42 has quit IRC
2712016-02-11T19:17:45  *** wallet42 has joined #bitcoin-core-dev
2722016-02-11T19:18:45  *** wallet42 has quit IRC
2732016-02-11T19:19:36  *** bsm117532 has joined #bitcoin-core-dev
2742016-02-11T19:21:37  *** wallet42 has joined #bitcoin-core-dev
2752016-02-11T19:22:07  *** wallet42 has quit IRC
2762016-02-11T19:29:28  *** jujumax has quit IRC
2772016-02-11T19:34:25  *** jujumax has joined #bitcoin-core-dev
2782016-02-11T19:39:35  *** achow101 has quit IRC
2792016-02-11T19:46:00  *** adnn_ has quit IRC
2802016-02-11T19:48:28  *** bityogi has quit IRC
2812016-02-11T19:54:53  *** bityogi has joined #bitcoin-core-dev
2822016-02-11T20:00:43  *** _dR has joined #bitcoin-core-dev
2832016-02-11T20:01:21  *** _dR has quit IRC
2842016-02-11T20:03:08  <michagogo> cfields: can you pull my sigs? Having a PR outstanding is breaking my script
2852016-02-11T20:03:37  <michagogo> (I have rc5 sigs ready to push up, I think)
2862016-02-11T20:03:43  <cfields> michagogo: i don't see a PR?
2872016-02-11T20:04:00  <michagogo> Hm?
2882016-02-11T20:04:02  * michagogo looks
2892016-02-11T20:04:02  *** NewLiberty_ has joined #bitcoin-core-dev
2902016-02-11T20:04:32  <michagogo> Oops.
2912016-02-11T20:04:59  <michagogo> There we go
2922016-02-11T20:05:28  <michagogo> The problem is that my script relies on FFs to avoid things breaking
2932016-02-11T20:05:46  *** laurentmt has quit IRC
2942016-02-11T20:05:55  <michagogo> Which breaks things when there I try to use it multiple times before one session is fully resolved
2952016-02-11T20:06:52  *** jujumax has quit IRC
2962016-02-11T20:07:31  <cfields> ah ok
2972016-02-11T20:07:37  * michagogo looks to see at what point his script crashed
2982016-02-11T20:08:00  <cfields> michagogo: rc5 sigs would be great when you've got them. wumpus and i have a mismatch
2992016-02-11T20:08:08  <cfields> i re-ran and got the same result as before
3002016-02-11T20:08:18  <michagogo> cfields: #301
3012016-02-11T20:08:33  <cfields> perfect, thanks. checking.
3022016-02-11T20:09:06  <GitHub175> [bitcoin] maaku closed pull request #6564: BIP-112: Mempool-only CHECKSEQUENCEVERIFY (master...checksequenceverify) https://github.com/bitcoin/bitcoin/pull/6564
3032016-02-11T20:09:20  <michagogo> The builds all finished, it just crashes out (set -e) on the git stuff, the first line of it being git pull --ff-only upstream master
3042016-02-11T20:09:41  <cfields> grr, you and wumpus match, mine's different
3052016-02-11T20:11:06  <wumpus> strange. Need me to upload any of the files?
3062016-02-11T20:11:35  <cfields> wumpus: comparing now to see what broke. thanks :)
3072016-02-11T20:11:50  <cfields> weird though, i used the same script as always
3082016-02-11T20:12:00  * helo chuckles
3092016-02-11T20:12:33  <wumpus> I also used the same script and base image as for all other 0.12.0 rcs
3102016-02-11T20:13:24  <wumpus> huh, I'm getting tons of non-final transactions on my node, is block 397955 up to date?
3112016-02-11T20:13:56  <morcos> what i have
3122016-02-11T20:14:05  <wumpus> (I could check w/ the others but I'm lazy and going to bed)
3132016-02-11T20:19:26  <cfields> hmm, deps match, only the binaries differ.
3142016-02-11T20:19:42  <cfields> wumpus: if you're still around, an upload would be great. otherwise i'll bother michagogo for one :)
3152016-02-11T20:20:19  <wumpus> cfields: which one?
3162016-02-11T20:21:31  <cfields> wumpus: bitcoin-0.12.0-win64.zip please
3172016-02-11T20:21:35  <wumpus> ok
3182016-02-11T20:23:57  <wumpus> cfields: https://dev.visucore.com/bitcoin/tmp/bitcoin-0.12.0-win64.zip
3192016-02-11T20:24:02  <cfields> wumpus: thanks!
3202016-02-11T20:24:49  *** bityogi has quit IRC
3212016-02-11T20:25:45  <GitHub160> [bitcoin] paveljanik opened pull request #7520: LibreSSL doesn't define OPENSSL_VERSION, use LIBRESSL_VERSION_TEXT instead (master...20160211_LibreSSL_compile_fix) https://github.com/bitcoin/bitcoin/pull/7520
3222016-02-11T20:27:24  *** treehug88 has quit IRC
3232016-02-11T20:28:14  *** windsok has quit IRC
3242016-02-11T20:29:21  *** windsok has joined #bitcoin-core-dev
3252016-02-11T20:29:22  <wumpus> <wumpus> huh, I'm getting tons of non-final transactions on my node, is block 397955 up to date? <- never mind, I was confused, I'm logging reject messages from *other* nodes, and some of them are rejecting the transactions I relay with non-final
3262016-02-11T20:30:18  <wumpus> all probably pre-0.12 versions that still request transactions during IBD
3272016-02-11T20:33:33  <sdaftuar> i think 0.12 also requests transactions during IBD if i remember right
3282016-02-11T20:34:18  <wumpus> ok, I was pretty sure there was a pull to change that, but I may be confused
3292016-02-11T20:34:32  <sdaftuar> it's in master, just missed the 0.12 cutoff i think
3302016-02-11T20:34:46  <wumpus> cfields: btw midnightmagic doesn't get windows gitian build to work for 0.12.0 at all https://github.com/bitcoin/bitcoin/issues/7492
3312016-02-11T20:35:01  <wumpus> sdaftuar: oh! ok  may make sense to label it for backport to 0.12.1
3322016-02-11T20:35:13  <sdaftuar> yeah that seems reasonable to me
3332016-02-11T20:35:53  <cfields> wumpus: hmm, more data. thanks.
3342016-02-11T20:37:19  <wumpus> sdaftuar: you were right https://github.com/bitcoin/bitcoin/pull/7164
3352016-02-11T20:39:24  <michagogo> wumpus: midnightmagic has always had weird stuff going on.
3362016-02-11T20:39:36  <michagogo> I don't know if anyone ever figured out what's different in his setuo
3372016-02-11T20:39:38  <michagogo> setup
3382016-02-11T20:42:42  <wumpus> michagogo: indeed
3392016-02-11T20:42:59  *** jujumax has joined #bitcoin-core-dev
3402016-02-11T20:48:40  <morcos> sipa: what were you wondering about with regards to BIP68 and the wallet.  the previous implementation had code to indicate if your wallet txs were non-final which i removed.  but that should be quite rare as it won't end up in your mempool in the first place
3412016-02-11T20:53:47  <cfields> strange, i have tons of single-byte differences
3422016-02-11T20:58:41  *** treehug88 has joined #bitcoin-core-dev
3432016-02-11T21:07:11  <midnightmagic> the host is a straight Ubuntu LTS update + upgrade machine. There are KVM and LXC running alongside the gitian built. But it's not like it's some custom-rolled machine.
3442016-02-11T21:12:17  *** jarret has joined #bitcoin-core-dev
3452016-02-11T21:16:34  *** jujumax has quit IRC
3462016-02-11T21:18:39  <gmaxwell> Is there a strong argument against not to have the varrious pruning effects-- like unsetting node network-- not happen until pruning actually happens?   E.g. today you can't set pruning to 200GB and operate as a completely unpruned node until the history gets that large.
3472016-02-11T21:19:26  <paveljanik> Luke-Jr, hope everything is OK...
3482016-02-11T21:19:52  <paveljanik> Luke-Jr, https://github.com/bitcoin/bitcoin/commit/d5f46832de900cee0801ca40bba743c9564cccb8 where can I read more about ]AC_PACKAGE_NAME[ syntax? ;-)
3492016-02-11T21:19:54  *** laurentmt has joined #bitcoin-core-dev
3502016-02-11T21:20:12  *** zooko` has joined #bitcoin-core-dev
3512016-02-11T21:21:08  *** wallet42 has joined #bitcoin-core-dev
3522016-02-11T21:21:26  *** zooko has quit IRC
3532016-02-11T21:22:22  *** bityogi has joined #bitcoin-core-dev
3542016-02-11T21:22:36  *** jujumax has joined #bitcoin-core-dev
3552016-02-11T21:22:49  *** treehug88 has quit IRC
3562016-02-11T21:25:08  *** Tasoshi has quit IRC
3572016-02-11T21:25:35  *** Tasoshi has joined #bitcoin-core-dev
3582016-02-11T21:26:15  <michagogo> cfields: in what?
3592016-02-11T21:28:57  *** NewLiberty_ has quit IRC
3602016-02-11T21:33:43  <michagogo> gmaxwell: off the top of my head, I think you'd need to kick all your peers when you hit the limit
3612016-02-11T21:35:01  <michagogo> And considering some of the changes are in the form of things you can't do anymore (e.g. rescan), leaving that functionality active for a while and then suddenly turning it off with no warning could be a problem
3622016-02-11T21:35:27  <michagogo> IMO pruning is a big enough change that no part of it should happen without the user's explicit action
3632016-02-11T21:38:26  <midnightmagic> cfields: does your build completely finish? like does it build all the artifacts including the signed bins for win and osx?
3642016-02-11T21:43:38  *** Prattler has quit IRC
3652016-02-11T21:44:00  *** wallet42 has quit IRC
3662016-02-11T21:44:39  *** ryitpm has quit IRC
3672016-02-11T21:46:10  *** Prattler has joined #bitcoin-core-dev
3682016-02-11T21:46:34  *** frankenmint has joined #bitcoin-core-dev
3692016-02-11T21:47:38  <morcos> gmaxwell: got a privacy related question for you regarding ResendWalletTransactions
3702016-02-11T21:48:12  <morcos> Shouldn't your node not relay a wallet tx that your own node doesn't accept into its mempool?
3712016-02-11T21:48:24  <morcos> crap, this might be a regression
3722016-02-11T21:48:45  <gmaxwell> morcos: hm. We didn't use to. Did we manage to break that?
3732016-02-11T21:48:54  <morcos> before 0.12 GetDepthInMainChain was < 0 for things not in your mempool right?
3742016-02-11T21:49:05  <morcos> but now it is 0 unless it is conflicted?
3752016-02-11T21:49:17  <gmaxwell> bleh. hah.
3762016-02-11T21:49:37  <morcos> what do you want to do?
3772016-02-11T21:50:23  <morcos> it seems to me the proper fix is to test if its in your mempool and if so re-relay, and if not , re try to accept it into your mempool
3782016-02-11T21:50:34  <morcos> (and relay if successful)
3792016-02-11T21:50:54  <sipa> morcos: aw
3802016-02-11T21:51:01  *** Sparyx has joined #bitcoin-core-dev
3812016-02-11T21:51:10  *** frankenmint has quit IRC
3822016-02-11T21:51:10  <cfields> midnightmagic: ah, i remember that problem
3832016-02-11T21:51:12  <gmaxwell> I believe that is the correct behavior.
3842016-02-11T21:51:19  <cfields> midnightmagic: long story short, nuke your gitian cache
3852016-02-11T21:51:24  <morcos> thats what you get when i try to find ways to avoid calculating the fee on wallet txs
3862016-02-11T21:51:27  <morcos> :)
3872016-02-11T21:51:45  <cfields> midnightmagic: it's due to not checking something that we need to check, i'll fix
3882016-02-11T21:51:58  <morcos> gmaxwell: but are we going to fix that for 0.12.0 ?
3892016-02-11T21:52:34  <gmaxwell> lets fix and see what the fix looks like?  It's a non-trivial privacy regression.
3902016-02-11T21:52:42  <morcos> ok, i can do it right now.
3912016-02-11T21:53:03  <morcos> i don' tthink its too much code, but i'm worried that it might need a bit of testing
3922016-02-11T21:53:20  <warren> Do we generally have an option to turn off transaction sending while allowing the wallet to create transactions?
3932016-02-11T21:54:08  <gmaxwell> resending is horrible for privacy period; a regression wouldn't be the _end_ of the world, but I would rather not have it.
3942016-02-11T21:54:11  *** frankenmint has joined #bitcoin-core-dev
3952016-02-11T21:54:12  <gmaxwell> warren: yes.
3962016-02-11T21:54:50  <gmaxwell> warren: walletbroadcast=0
3972016-02-11T21:56:48  *** jujumax has quit IRC
3982016-02-11T21:59:02  *** zooko` has quit IRC
3992016-02-11T21:59:45  *** zooko has joined #bitcoin-core-dev
4002016-02-11T22:14:34  <GitHub14> [bitcoin] morcos opened pull request #7521: Don't resend wallet txs that aren't in our own mempool (master...testBeforeRelay) https://github.com/bitcoin/bitcoin/pull/7521
4012016-02-11T22:15:00  <morcos> Ok I think this is the idea.  Not sure if you'd want it to look slightly different, was trying to keep the changes minimal.
4022016-02-11T22:15:34  <morcos> gmaxwell: ^
4032016-02-11T22:16:26  *** jujumax has joined #bitcoin-core-dev
4042016-02-11T22:17:35  *** wallet42 has joined #bitcoin-core-dev
4052016-02-11T22:18:32  <gmaxwell> morcos: In what case is that force needed? I think for creation it doesn't attempt to relay if it can't be mempooled?
4062016-02-11T22:19:10  <morcos> yeah, it shouldn't do anything.  i think its safe to remove that and just use the mempool.exists() test to see if we need to try to accept it
4072016-02-11T22:20:02  <morcos> i'm happy to change it around a bit, but i wanted to sort of point out the two different ways this was called and emphasize that behavior is only changing in one of them
4082016-02-11T22:22:10  <midnightmagic> cfields: ahhh, yes thank you. I had updated, and rebuilt the gitian base image; the next was blowing everything away and starting right from scratch. I'll update the issue for that and report it fixed if that proves to be the solution.
4092016-02-11T22:22:42  <cfields> midnightmagic: yea, the issue is that you built the 0.12 branch before it switched to trusty
4102016-02-11T22:24:48  <cfields> the solution is adding the current compiler info to the dep packages hashid
4112016-02-11T22:25:26  *** laurentmt has quit IRC
4122016-02-11T22:26:41  <morcos> gmaxwell: I'm missing required locks.  Need to add those.  Want me to remove the bool?
4132016-02-11T22:27:11  <gmaxwell> morcos: would be a smaller diff without it.
4142016-02-11T22:27:29  <sipa> morcos: you can use IsTrusted, perhaps?
4152016-02-11T22:30:44  <morcos> sipa: you mean InMempool() ?  I can, but it locks mempool.cs even though exists locks it itself.  sigh...
4162016-02-11T22:30:54  <morcos> But I was referring to cs_main
4172016-02-11T22:31:04  <morcos> which is needed for AcceptToMemoryPool
4182016-02-11T22:31:32  <morcos> It looks like I'd need to lock it for the entire ResendWalletTransactionsBefore function (so its not locked after cs_wallet)
4192016-02-11T22:32:00  <morcos> Is that bad?
4202016-02-11T22:32:24  <midnightmagic> cfields: okay. if you have a PR or something I'd be glad to leave the system in a broken state and verify the fix for you
4212016-02-11T22:32:51  *** zooko has quit IRC
4222016-02-11T22:32:52  *** frankenmint has quit IRC
4232016-02-11T22:33:11  <morcos> Alternatively we just skip trying to resend wallet txs that are no longer in our mempool, this would actually be most similar to old behavior i guess (although we didn't use to end up with those due to eviction beforehand)
4242016-02-11T22:33:45  <cfields> midnightmagic: no worries, no need to keep broken. it's easy enough to test. thanks though :)
4252016-02-11T22:33:46  <morcos> Also there would be this unfortunate string of ERRORS resulting from RBF replacements I think where you try to resend the old one that was RBF'ed
4262016-02-11T22:34:54  <morcos> Perhaps simpler to just do that then..  Check mempool.exists() and leave it at that?  better to use InMempool?
4272016-02-11T22:38:22  <midnightmagic> cfields: okie doke.
4282016-02-11T22:43:32  <morcos> gmaxwell: ok thats a much smaller diff. :)  but now if something gets evicted (or never made it in to your mempool), it will not automatically try to reaccept or rerelay, so this could be worse behavior depending on your point of view.
4292016-02-11T22:44:16  *** wallet42 has quit IRC
4302016-02-11T22:44:42  <morcos> this doesn't affect trying to reaccept wallet txs on startup though
4312016-02-11T22:46:13  <morcos> have to reboot, back in a few
4322016-02-11T22:46:30  *** morcos has quit IRC
4332016-02-11T22:49:21  *** morcos has joined #bitcoin-core-dev
4342016-02-11T22:50:04  *** jujumax has quit IRC
4352016-02-11T22:56:27  *** jujumax has joined #bitcoin-core-dev
4362016-02-11T23:01:12  <morcos> gmaxwell: sipa: i pushed the simple version which doesn't try to reaccpet, that would be my preference, it seems like you might not always want to automatically resend things that are no longer in your mempool for some reason.
4372016-02-11T23:01:55  <gmaxwell> you'll still try puting it back in on restart at least.
4382016-02-11T23:03:08  *** JackH has quit IRC
4392016-02-11T23:03:34  <morcos> Yes, unless you have abandoned it.  Which seems reasonable.
4402016-02-11T23:04:56  <gmaxwell> my that is a smaller patch.
4412016-02-11T23:05:13  <morcos> I'll let you ask wumpus for an RC6
4422016-02-11T23:05:57  <gmaxwell> I am going to need offerings. Does anyone have a goat?
4432016-02-11T23:09:08  <midnightmagic> I know people who have goats!
4442016-02-11T23:11:40  <midnightmagic> Goats can eat poison ivy without passing it to their milk *and* will clean roadside brush like scotch broom! :-D
4452016-02-11T23:11:53  *** Sparyx has quit IRC
4462016-02-11T23:12:57  *** frankenmint has joined #bitcoin-core-dev
4472016-02-11T23:15:24  <sipa> not sure that's worth doing another rc for
4482016-02-11T23:17:16  <gmaxwell> I think it would also be fine to include it in a release without RCing it, assuming we test it.
4492016-02-11T23:18:53  <morcos> sipa: i don't feel strongly, but i do think it would be a pretty big privacy difference
4502016-02-11T23:18:58  *** brg444 has joined #bitcoin-core-dev
4512016-02-11T23:19:13  <morcos> actually, also it'll be a network bandwidth issue
4522016-02-11T23:19:17  *** frankenmint has quit IRC
4532016-02-11T23:19:22  <morcos> everytime you have tx's evicted
4542016-02-11T23:19:31  <morcos> you'll periodically resend them to all your peers
4552016-02-11T23:19:35  <morcos> forever?
4562016-02-11T23:19:51  <sipa> until you abandon them, which is not in the GUI?
4572016-02-11T23:20:01  <morcos> correct, not in the gui
4582016-02-11T23:20:08  <sipa> ... i think it should be in the gui
4592016-02-11T23:20:20  <morcos> you're lucky its in at all, i had to fight for that
4602016-02-11T23:20:26  <sipa> but let's keep that for 0.12.1
4612016-02-11T23:20:30  <sipa> yeah, i know
4622016-02-11T23:20:31  <gmaxwell> I don't think it's actually a network bandwidth issue, at least not materially. If you're personally generating enough abandoned transactions... well...
4632016-02-11T23:20:54  <morcos> gmaxwell: its not just one persons txs.  look at it on the network scale
4642016-02-11T23:21:10  <morcos> all txs that are ever evicted are still locally bouncing around both inv an tx
4652016-02-11T23:22:21  <morcos> so right now for instance tx traffic in a period roughly equals number of nodes * number of txs in that period
4662016-02-11T23:23:04  <morcos> going forward it'll equal small constat * number of txs that were ever evicted  every X minutes
4672016-02-11T23:23:13  <morcos> sorry, not very rigorous, but you get the idea
4682016-02-11T23:23:57  <morcos> i might be changing my mind to think this is definitely worth fixing
4692016-02-11T23:24:21  *** brg444 has quit IRC
4702016-02-11T23:24:47  <gmaxwell> Right, -- this is a consquence of eviction generally. It isn't that bad because it's only thos which were evicted but are now placable (or do you just mean without the fix)
4712016-02-11T23:25:28  *** Guyver2 has quit IRC
4722016-02-11T23:26:31  <morcos> yes i mean without the fix
4732016-02-11T23:28:03  <morcos> you could even sort of make an attack with this right by sending 1k sat/kB txs of small amounts to lots of random nodes
4742016-02-11T23:28:12  <morcos> then they'll do the work of rebroadcasting them all the time for you
4752016-02-11T23:28:43  <gmaxwell> Even on the privacy side, I was not thinking in terms of recieved. Thats a release blocker.
4762016-02-11T23:29:25  <morcos> oh yes, good point.  want to identify to which node an address belongs
4772016-02-11T23:29:28  <gmaxwell> (corner case bad behavior in a already privacy weak part of the system where only you can trigger it is one thing... where it can be remotely triggered is another)
4782016-02-11T23:30:01  <morcos> sigh, eviction is complicated
4792016-02-11T23:30:18  *** jujumax has quit IRC
4802016-02-11T23:30:46  <gmaxwell> really retransmission is a general privacy disaster. Even with this check-- if someone retransmits something you know they already sent you and should have had in their mempool: they are the origin.
4812016-02-11T23:31:35  <morcos> yeah actually, retransmit is kind of weird
4822016-02-11T23:32:44  <gmaxwell> this would be fixed if we moved more towards mempool reconciliation instead of transmission... also would be greatly improved if broadcasting was done in some private way... both things I want to work on in the not so far future... but for now, lets at least not make things worse.
4832016-02-11T23:32:45  <morcos> I suppose disabling that is too big a change
4842016-02-11T23:33:04  <morcos> There is already a manual way to do it
4852016-02-11T23:33:41  <gmaxwell> well you can all of this transmission it by setting walletbroadcast=0 so at least there is that.
4862016-02-11T23:35:18  <morcos> I don't think I'd ever realized how silly the resendwallettransactions is though.  it's emphasized by the fact that we think its better not to do it if its not in your mempool anymore.  well if its still in your mempool, why the hell wouldn't it still be in other mempools
4872016-02-11T23:35:46  <gmaxwell> because you've connected to different nodes. it's stull stupid.
4882016-02-11T23:35:58  <gmaxwell> s/stull/still/
4892016-02-11T23:36:32  <morcos> It seems like a simple privacy fix (even if not for this release) would be to just default that to off.  walletbroadcast=0 requires outside work of some kind.  but taking your chance with initial broadcast only is a reasonable middle ground.  shoudl at least be an option.
4902016-02-11T23:37:11  <morcos> anyway, ok so if we think we NEED to do something for 0.12.  what is that something?  the small change i made?
4912016-02-11T23:37:25  <gmaxwell> I believe so!
4922016-02-11T23:37:28  <gmaxwell> (am testing it)
4932016-02-11T23:40:13  <Luke-Jr> paveljanik: search for autoconf/m4 manuals; admittedly, figuring out quoting is mostly trial-and-error for me
4942016-02-11T23:40:15  <morcos> i guess what i said before about integrating all previous evicted txs is an exaggeration of how bad it would be, because one they become conflicted they'd no longer get resent
4952016-02-11T23:41:12  *** jtimon has quit IRC
4962016-02-11T23:43:15  *** jtimon has joined #bitcoin-core-dev
4972016-02-11T23:46:02  *** AaronvanW has quit IRC
4982016-02-11T23:49:43  *** jujumax has joined #bitcoin-core-dev
4992016-02-11T23:54:16  *** brg444 has joined #bitcoin-core-dev