1 2016-04-05T00:01:57  *** zooko has quit IRC
  2 2016-04-05T00:02:47  *** zooko`` has joined #bitcoin-core-dev
  3 2016-04-05T00:17:19  *** zooko`` has quit IRC
  4 2016-04-05T00:21:03  *** Ylbam has quit IRC
  5 2016-04-05T00:39:26  *** cguida has joined #bitcoin-core-dev
  6 2016-04-05T00:52:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  7 2016-04-05T00:53:31  *** zooko`` has joined #bitcoin-core-dev
  8 2016-04-05T01:26:37  *** [b__b] has quit IRC
  9 2016-04-05T01:26:56  *** [b__b] has joined #bitcoin-core-dev
 10 2016-04-05T01:29:23  *** Luke-Jr has quit IRC
 11 2016-04-05T01:31:59  *** Luke-Jr has joined #bitcoin-core-dev
 12 2016-04-05T01:32:26  *** Giszmo has quit IRC
 13 2016-04-05T01:40:07  *** fengling has joined #bitcoin-core-dev
 14 2016-04-05T01:44:24  *** zooko`` has quit IRC
 15 2016-04-05T01:49:25  *** wallet42 has joined #bitcoin-core-dev
 16 2016-04-05T02:02:58  *** p15 has joined #bitcoin-core-dev
 17 2016-04-05T02:18:14  *** gevs has quit IRC
 18 2016-04-05T02:41:27  *** zooko has joined #bitcoin-core-dev
 19 2016-04-05T02:41:41  *** hsmiths2 is now known as hsmiths
 20 2016-04-05T02:42:03  *** hsmiths has joined #bitcoin-core-dev
 21 2016-04-05T02:42:18  <gmaxwell> sipa: jonasschnelli:  Here is the authentication protocol I was thinking of:
 22 2016-04-05T02:42:21  <gmaxwell> https://people.xiph.org/~greg/auth0.txt
 23 2016-04-05T02:43:35  <gmaxwell> And this is an extension to the former that allows for mutual autentication while keeping the client identity private: https://people.xiph.org/~greg/auth1.txt  This is useful because it would protect against a shared server tracking clients (e.g. observing what they broadcast), but still allow the client to authenticate for elevated service.
 24 2016-04-05T02:45:41  *** jtimon has quit IRC
 25 2016-04-05T02:48:17  <gmaxwell> An example application where this would be important, is if clients paid a server for a priority access account. (more bandwidth, protection against DOS limits).. it would be unfortunate if the existance of such a service compromised the users privacy by giving them a persistant identity that the server could track them with.  I don't think it's something we'd implement right away, but it shows
 26 2016-04-05T02:48:23  <gmaxwell> how our channel authentication could be extended.
 27 2016-04-05T02:48:31  *** xiangfu has joined #bitcoin-core-dev
 28 2016-04-05T03:03:58  *** zooko has quit IRC
 29 2016-04-05T03:05:01  *** Alopex has quit IRC
 30 2016-04-05T03:06:07  *** Alopex has joined #bitcoin-core-dev
 31 2016-04-05T03:19:32  *** frankenmint has joined #bitcoin-core-dev
 32 2016-04-05T03:45:16  *** Chris_Stewart_5 has quit IRC
 33 2016-04-05T05:01:01  *** Alopex has quit IRC
 34 2016-04-05T05:02:06  *** Alopex has joined #bitcoin-core-dev
 35 2016-04-05T05:02:33  *** paveljanik has quit IRC
 36 2016-04-05T05:17:01  *** Alopex has quit IRC
 37 2016-04-05T05:18:06  *** Alopex has joined #bitcoin-core-dev
 38 2016-04-05T05:53:02  *** Ylbam has joined #bitcoin-core-dev
 39 2016-04-05T06:06:11  *** murch has joined #bitcoin-core-dev
 40 2016-04-05T06:09:01  *** Alopex has quit IRC
 41 2016-04-05T06:10:06  *** Alopex has joined #bitcoin-core-dev
 42 2016-04-05T06:19:36  *** fengling has quit IRC
 43 2016-04-05T06:20:48  *** paveljanik has joined #bitcoin-core-dev
 44 2016-04-05T06:28:00  *** mesmer_ has joined #bitcoin-core-dev
 45 2016-04-05T06:31:04  *** mesmer has quit IRC
 46 2016-04-05T06:33:54  *** fengling has joined #bitcoin-core-dev
 47 2016-04-05T06:55:01  *** Alopex has quit IRC
 48 2016-04-05T06:56:06  *** Alopex has joined #bitcoin-core-dev
 49 2016-04-05T07:01:23  *** frankenmint has quit IRC
 50 2016-04-05T07:14:07  <jonasschnelli> gmaxwell: Nice! Will try to fully understand it now...
 51 2016-04-05T07:22:11  *** chris2000 has joined #bitcoin-core-dev
 52 2016-04-05T07:36:34  *** frankenmint has joined #bitcoin-core-dev
 53 2016-04-05T07:44:53  <GitHub111> [bitcoin] paveljanik opened pull request #7810: Refactor AlertNotifyOnce out of UpdateTip (master...20160405_AlertNotifyOnce) https://github.com/bitcoin/bitcoin/pull/7810
 54 2016-04-05T07:55:01  *** Alopex has quit IRC
 55 2016-04-05T07:56:07  *** Alopex has joined #bitcoin-core-dev
 56 2016-04-05T07:59:19  *** lejitz has joined #bitcoin-core-dev
 57 2016-04-05T08:02:37  *** lejitz has quit IRC
 58 2016-04-05T08:09:04  *** xiangfu has quit IRC
 59 2016-04-05T08:11:03  *** paveljanik has quit IRC
 60 2016-04-05T08:11:15  *** xiangfu has joined #bitcoin-core-dev
 61 2016-04-05T08:29:02  <jonasschnelli> This looks ready: https://github.com/bitcoin/bitcoin/pull/7753
 62 2016-04-05T08:40:10  *** abritoid has joined #bitcoin-core-dev
 63 2016-04-05T08:46:45  *** Guyver2 has joined #bitcoin-core-dev
 64 2016-04-05T08:50:24  *** MarcoFalke has joined #bitcoin-core-dev
 65 2016-04-05T08:56:22  <StringerBell> ok it's killing me. How does that github bot work?
 66 2016-04-05T08:58:22  <jonasschnelli> StringerBell: Its publishing created/closed/merged PRs issues?
 67 2016-04-05T08:58:53  * jonasschnelli thinks GitHub is extraslow today.
 68 2016-04-05T08:59:09  <StringerBell> I mean it is a user but it's not connected to the channel
 69 2016-04-05T08:59:45  <StringerBell> Don't mean to get off topic but never seen that before.
 70 2016-04-05T08:59:46  <Luke-Jr> StringerBell: the channel is not +n which restricts sending to members
 71 2016-04-05T08:59:46  <sipa> StringerBell: be default you can send messages to a channel without being joined
 72 2016-04-05T08:59:59  <StringerBell> oh lol ok
 73 2016-04-05T09:00:13  <Luke-Jr> IRC isn't designed to be "rooms" as much as it is pub/sub IM ;)
 74 2016-04-05T09:00:47  <Luke-Jr> so JOIN = subscribe, and PRIVMSG = publish
 75 2016-04-05T09:00:58  <StringerBell> ah
 76 2016-04-05T09:05:12  <btcdrak> It can be set to authorise,  join, mag and leave but then it is a lot more messages
 77 2016-04-05T09:05:37  <btcdrak> It is a github commit hook
 78 2016-04-05T09:05:41  <Luke-Jr> not like anyone abuses the -n
 79 2016-04-05T09:38:42  <wumpus> yes the side is a tad slow
 80 2016-04-05T09:38:45  <wumpus> site*
 81 2016-04-05T09:38:58  *** lejitz has joined #bitcoin-core-dev
 82 2016-04-05T09:39:21  *** wallet42 has quit IRC
 83 2016-04-05T09:43:28  *** lejitz has quit IRC
 84 2016-04-05T09:49:04  *** AaronvanW has joined #bitcoin-core-dev
 85 2016-04-05T09:49:05  *** AaronvanW has quit IRC
 86 2016-04-05T09:49:05  *** AaronvanW has joined #bitcoin-core-dev
 87 2016-04-05T09:59:03  <GitHub37> [bitcoin] MarcoFalke opened pull request #7811: [0.12.2] qa Backports (0.12...Mf1604-qa012) https://github.com/bitcoin/bitcoin/pull/7811
 88 2016-04-05T10:09:42  *** murch has quit IRC
 89 2016-04-05T10:18:07  *** xiangfu has quit IRC
 90 2016-04-05T10:18:57  *** fengling has quit IRC
 91 2016-04-05T10:19:46  *** xiangfu has joined #bitcoin-core-dev
 92 2016-04-05T10:30:17  *** gevs has joined #bitcoin-core-dev
 93 2016-04-05T10:30:17  *** gevs has joined #bitcoin-core-dev
 94 2016-04-05T10:35:47  *** xabbix has quit IRC
 95 2016-04-05T10:36:15  *** xabbix has joined #bitcoin-core-dev
 96 2016-04-05T10:44:54  *** gevs has quit IRC
 97 2016-04-05T10:44:55  *** chris2000 has quit IRC
 98 2016-04-05T10:46:34  *** gevs has joined #bitcoin-core-dev
 99 2016-04-05T11:06:55  *** Luke-Jr has quit IRC
100 2016-04-05T11:07:37  *** Luke-Jr has joined #bitcoin-core-dev
101 2016-04-05T11:26:22  *** xiangfu has quit IRC
102 2016-04-05T11:32:24  <btcdrak> Last week's meeting summary: https://bitcoincore.org/en/meetings/2016/03/31/
103 2016-04-05T11:34:13  *** cryptapus_ has joined #bitcoin-core-dev
104 2016-04-05T11:35:03  *** slackircbridge has joined #bitcoin-core-dev
105 2016-04-05T11:37:59  *** cryptapus_ is now known as cryptapus
106 2016-04-05T11:38:53  <btcdrak> wumpus: can you try an experiment for me please, by kicking slackircbridge
107 2016-04-05T11:40:21  *** davec has quit IRC
108 2016-04-05T11:40:54  *** davec has joined #bitcoin-core-dev
109 2016-04-05T11:51:15  <sipa> hmm, when i regenerate the script_tests, i get lines like:
110 2016-04-05T11:51:16  <sipa> [
111 2016-04-05T11:51:18  <sipa> ...
112 2016-04-05T11:51:21  <sipa>    ],
113 2016-04-05T11:51:24  <sipa> instead of:
114 2016-04-05T11:51:26  <sipa> [
115 2016-04-05T11:51:27  <sipa> ...
116 2016-04-05T11:51:29  <sipa> ],
117 2016-04-05T11:51:36  <sipa> wumpus: you touched that code last
118 2016-04-05T11:52:04  *** ChanServ sets mode: +o sipa
119 2016-04-05T11:52:12  *** slackircbridge was kicked by sipa (btcdrak does not like you)
120 2016-04-05T11:52:28  <sipa> btcdrak: done
121 2016-04-05T11:52:36  *** ChanServ sets mode: -o sipa
122 2016-04-05T11:52:50  <btcdrak> sipa thanks
123 2016-04-05T11:57:08  *** slackircbridge has joined #bitcoin-core-dev
124 2016-04-05T11:57:43  <btcdrak> sipa: thanks. one last time please boot him again.
125 2016-04-05T11:58:46  *** slackircbridge has quit IRC
126 2016-04-05T11:58:49  <jonasschnelli> ping sdaftuar
127 2016-04-05T11:58:58  *** slackircbridge has joined #bitcoin-core-dev
128 2016-04-05T11:59:05  <sipa> btcdrak: you've got op
129 2016-04-05T11:59:41  <jonasschnelli> Or anyone else... check https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85  I think this is wrong.
130 2016-04-05T11:59:46  <jonasschnelli> (Already merged)
131 2016-04-05T12:00:09  <jonasschnelli> If a tx is not in the mempool and signal rbf, we can't be sure if it's rbfable.
132 2016-04-05T12:00:16  <jonasschnelli> *signals
133 2016-04-05T12:01:04  <sipa> why not?
134 2016-04-05T12:03:54  <jonasschnelli> sipa: ancestors?
135 2016-04-05T12:04:08  <jonasschnelli> sipa: I think this check is more appropriate: https://github.com/bitcoin/bitcoin/pull/7222/files#diff-d0eca4d0f80c5b045d2aa64609e811ecR28?
136 2016-04-05T12:05:27  <jonasschnelli> Because a unconfirmed input could signal RBF?
137 2016-04-05T12:06:07  *** ChanServ sets mode: +o btcdrak
138 2016-04-05T12:06:21  *** slackircbridge was kicked by btcdrak (testing rejoin)
139 2016-04-05T12:07:41  *** slackircbridge has joined #bitcoin-core-dev
140 2016-04-05T12:08:18  *** slackircbridge was kicked by btcdrak (remember false != true)
141 2016-04-05T12:08:19  *** slackircbridge has joined #bitcoin-core-dev
142 2016-04-05T12:10:04  *** ChanServ sets mode: -o btcdrak
143 2016-04-05T12:17:07  *** randy-waterhouse has left #bitcoin-core-dev
144 2016-04-05T12:23:56  *** SteveTaylor has joined #bitcoin-core-dev
145 2016-04-05T12:24:39  *** davec has quit IRC
146 2016-04-05T12:25:03  *** davec has joined #bitcoin-core-dev
147 2016-04-05T12:27:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
148 2016-04-05T12:29:06  <sipa> jonasschnelli: i think it's correct
149 2016-04-05T12:29:16  <jonasschnelli> sipa: Yes. Me2!
150 2016-04-05T12:29:22  <sipa> if it signals rbf by itself, it should be yes; if it doesn't, it's unknown
151 2016-04-05T12:29:35  <sipa> and IsRBFOptIn can't be called for things not in the mempool
152 2016-04-05T12:29:44  <jonasschnelli> I overlooked https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR85
153 2016-04-05T12:29:49  <jonasschnelli> if (!mempool.exists(hash)) {
154 2016-04-05T12:30:18  <jonasschnelli> The "unknown" https://github.com/bitcoin/bitcoin/pull/7222/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR89 is not 100% true.
155 2016-04-05T12:30:29  <jonasschnelli> But "unknown" from the local peer perspective is right.
156 2016-04-05T12:30:54  <sipa> what other perspective is there?
157 2016-04-05T12:31:19  <jonasschnelli> We could miss a ancestor/input in the mempool that has a final nSequence and therefore the transaction would _not_ be replaceable.
158 2016-04-05T12:33:27  <jonasschnelli> But however, I think its correct. Yes.
159 2016-04-05T12:33:52  <jonasschnelli> But doing a tiny refactor (before I extend it to the GUI)
160 2016-04-05T12:34:03  *** Chris_Stewart_5 has quit IRC
161 2016-04-05T12:40:17  <sipa> jonasschnelli, wumpus: i don't understand the univalue json pretty printer
162 2016-04-05T12:40:28  <jonasschnelli> write(2)
163 2016-04-05T12:40:41  <jonasschnelli> sipa: what is unclear?
164 2016-04-05T12:41:13  <sipa> it puts spaces between comma's and the end of a line
165 2016-04-05T12:41:33  <jonasschnelli> sipa: yes. You need to ask jeff. :) Or fix it.
166 2016-04-05T12:41:57  <jonasschnelli> sipa: Are you referring to your script_tests issue above?
167 2016-04-05T12:42:06  <sipa> yes
168 2016-04-05T12:43:18  <GitHub178> [bitcoin] jonasschnelli opened pull request #7812: Tiny refactor of `IsRBFOptIn`, avoid exception (master...2016/04/rbf_refact) https://github.com/bitcoin/bitcoin/pull/7812
169 2016-04-05T12:44:16  <jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L79
170 2016-04-05T12:44:44  <sdaftuar> jonasschnelli: pong.  happy to review any refactors of that code...
171 2016-04-05T12:44:47  *** dermoth has joined #bitcoin-core-dev
172 2016-04-05T12:45:18  <jonasschnelli> sdaftuar: Thanks. Not sure if it makes sense. I think the code is fine. Its just the exception that kinda disturbs me.
173 2016-04-05T12:45:21  <jonasschnelli> sipa: https://github.com/bitcoin/univalue/blob/master/lib/univalue_write.cpp#L100
174 2016-04-05T12:45:50  <jonasschnelli> sipa: it misses a newline before L100
175 2016-04-05T12:46:03  <jonasschnelli> no wait...
176 2016-04-05T12:46:15  <sipa> jonasschnelli: it's complicated; i'm writing a workaround for now
177 2016-04-05T12:46:18  <jonasschnelli> L98-99 is wrong.
178 2016-04-05T12:46:23  <jonasschnelli> I'll fix it.
179 2016-04-05T12:47:06  <sipa> please add tests for the pretty printer, i think it's very easy to break
180 2016-04-05T12:47:46  <jonasschnelli> sipa: yes.
181 2016-04-05T12:47:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2016-04-05T12:49:40  *** cryptapus has quit IRC
183 2016-04-05T12:51:05  *** jannes has quit IRC
184 2016-04-05T12:53:59  *** jannes has joined #bitcoin-core-dev
185 2016-04-05T12:57:02  <GitHub91> [bitcoin] MarcoFalke opened pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813
186 2016-04-05T12:58:07  *** jtimon has joined #bitcoin-core-dev
187 2016-04-05T13:00:07  <GitHub153> [bitcoin] MarcoFalke opened pull request #7814: [qa] Switch to py3 (master...Mf1604-qaPy3) https://github.com/bitcoin/bitcoin/pull/7814
188 2016-04-05T13:08:34  <jonasschnelli> sipa: script_tests.cpp uses "write(1,4)" (which means 1 whitespace indent, start at level 4).
189 2016-04-05T13:08:49  <jonasschnelli> But there is a bug at the opening "[" (not the closing)
190 2016-04-05T13:09:18  *** Chris_Stewart_5 has quit IRC
191 2016-04-05T13:13:54  <sipa> jonasschnelli: yeah, changing it to write(4)
192 2016-04-05T13:21:47  *** mesmer_ has quit IRC
193 2016-04-05T13:21:47  *** cheese_ has quit IRC
194 2016-04-05T13:21:47  *** cfields has quit IRC
195 2016-04-05T13:21:48  *** Guest27562 has quit IRC
196 2016-04-05T13:21:48  *** Alopex has quit IRC
197 2016-04-05T13:21:48  *** Arnavion has quit IRC
198 2016-04-05T13:21:48  *** Madars has quit IRC
199 2016-04-05T13:21:48  *** Squidicuz has quit IRC
200 2016-04-05T13:21:48  *** harding has quit IRC
201 2016-04-05T13:21:48  *** wumpus has quit IRC
202 2016-04-05T13:21:48  *** BlueMatt has quit IRC
203 2016-04-05T13:21:48  *** fkhan_ has quit IRC
204 2016-04-05T13:21:48  *** windsok has quit IRC
205 2016-04-05T13:21:48  *** cjcj has quit IRC
206 2016-04-05T13:21:48  *** gijensen has quit IRC
207 2016-04-05T13:21:48  *** Eliel_ has quit IRC
208 2016-04-05T13:21:49  *** davec has quit IRC
209 2016-04-05T13:21:49  *** cryptapus_afk has quit IRC
210 2016-04-05T13:21:49  *** dgenr8 has quit IRC
211 2016-04-05T13:21:49  *** ghtdak has quit IRC
212 2016-04-05T13:21:49  *** baldur has quit IRC
213 2016-04-05T13:21:49  *** rubensayshi has quit IRC
214 2016-04-05T13:21:49  *** ebfull has quit IRC
215 2016-04-05T13:21:50  *** zxzzt has quit IRC
216 2016-04-05T13:21:50  *** nanotube has quit IRC
217 2016-04-05T13:21:50  *** adam3us has quit IRC
218 2016-04-05T13:21:50  *** frankenmint has quit IRC
219 2016-04-05T13:21:50  *** phantomcircuit has quit IRC
220 2016-04-05T13:21:50  *** neha has quit IRC
221 2016-04-05T13:21:50  *** zmanian__ has quit IRC
222 2016-04-05T13:21:50  *** eragmus has quit IRC
223 2016-04-05T13:21:50  *** binns has quit IRC
224 2016-04-05T13:21:50  *** Amnez777 has quit IRC
225 2016-04-05T13:21:50  *** heath has quit IRC
226 2016-04-05T13:21:50  *** CyrusV has quit IRC
227 2016-04-05T13:21:50  *** jl2012 has quit IRC
228 2016-04-05T13:21:51  *** helo has quit IRC
229 2016-04-05T13:21:51  *** jonasschnelli has quit IRC
230 2016-04-05T13:21:51  *** slackircbridge has quit IRC
231 2016-04-05T13:21:51  *** Luke-Jr has quit IRC
232 2016-04-05T13:21:51  *** Ylbam has quit IRC
233 2016-04-05T13:21:51  *** [b__b] has quit IRC
234 2016-04-05T13:21:51  *** AtashiCon has quit IRC
235 2016-04-05T13:21:51  *** Thireus has quit IRC
236 2016-04-05T13:21:51  *** gribble has quit IRC
237 2016-04-05T13:21:51  *** ryan-c has quit IRC
238 2016-04-05T13:21:52  *** sturles has quit IRC
239 2016-04-05T13:21:52  *** teward has quit IRC
240 2016-04-05T13:21:52  *** petertodd has quit IRC
241 2016-04-05T13:21:52  *** Expanse has quit IRC
242 2016-04-05T13:21:52  *** StringerBell has quit IRC
243 2016-04-05T13:21:53  *** PaulCapestany has quit IRC
244 2016-04-05T13:21:53  *** arubi has quit IRC
245 2016-04-05T13:21:53  *** da2ce7_mobile has quit IRC
246 2016-04-05T13:21:53  *** sanada has quit IRC
247 2016-04-05T13:21:53  *** jyap has quit IRC
248 2016-04-05T13:21:53  *** go1111111 has quit IRC
249 2016-04-05T13:21:53  *** warren has quit IRC
250 2016-04-05T13:21:53  *** OxADADA has quit IRC
251 2016-04-05T13:21:53  *** [Author] has quit IRC
252 2016-04-05T13:21:53  *** gevs has quit IRC
253 2016-04-05T13:21:53  *** justanotheruser has quit IRC
254 2016-04-05T13:21:53  *** afk11 has quit IRC
255 2016-04-05T13:21:53  *** amiller has quit IRC
256 2016-04-05T13:21:53  *** aureianimus has quit IRC
257 2016-04-05T13:21:53  *** kanzure has quit IRC
258 2016-04-05T13:21:53  *** nkuttler has quit IRC
259 2016-04-05T13:21:54  *** roasbeef has quit IRC
260 2016-04-05T13:21:54  *** dermoth has quit IRC
261 2016-04-05T13:21:54  *** Guyver2 has quit IRC
262 2016-04-05T13:21:54  *** cguida has quit IRC
263 2016-04-05T13:21:54  *** goregrind has quit IRC
264 2016-04-05T13:21:54  *** jouke has quit IRC
265 2016-04-05T13:21:54  *** mr_burdell has quit IRC
266 2016-04-05T13:21:54  *** berndj has quit IRC
267 2016-04-05T13:21:54  *** zibbo has quit IRC
268 2016-04-05T13:21:54  *** morcos has quit IRC
269 2016-04-05T13:21:54  *** d9b4bef9 has quit IRC
270 2016-04-05T13:21:54  *** sdaftuar has quit IRC
271 2016-04-05T13:21:55  *** haakonn has quit IRC
272 2016-04-05T13:21:55  *** jtimon has quit IRC
273 2016-04-05T13:21:55  *** xabbix has quit IRC
274 2016-04-05T13:21:55  *** MarcoFalke has quit IRC
275 2016-04-05T13:21:55  *** moli has quit IRC
276 2016-04-05T13:21:55  *** da2ce7 has quit IRC
277 2016-04-05T13:21:55  *** achow101 has quit IRC
278 2016-04-05T13:21:55  *** mkarrer has quit IRC
279 2016-04-05T13:21:55  *** fredrin has quit IRC
280 2016-04-05T13:21:55  *** gmaxwell has quit IRC
281 2016-04-05T13:21:55  *** Anduck has quit IRC
282 2016-04-05T13:21:55  *** lclc has quit IRC
283 2016-04-05T13:21:55  *** lecusemble has quit IRC
284 2016-04-05T13:21:55  *** instagibbs has quit IRC
285 2016-04-05T13:21:55  *** crescendo has quit IRC
286 2016-04-05T13:21:55  *** murr4y has quit IRC
287 2016-04-05T13:21:56  *** droark has quit IRC
288 2016-04-05T13:21:56  *** Evel-Knievel has quit IRC
289 2016-04-05T13:21:56  *** btcdrak has quit IRC
290 2016-04-05T13:21:56  *** CodeShark has quit IRC
291 2016-04-05T13:21:56  *** wangchun has quit IRC
292 2016-04-05T13:21:56  *** tucenaber has quit IRC
293 2016-04-05T13:21:56  *** ibrightly has quit IRC
294 2016-04-05T13:21:56  *** lesderid has quit IRC
295 2016-04-05T13:21:56  *** limpkin has quit IRC
296 2016-04-05T13:21:56  *** AaronvanW has quit IRC
297 2016-04-05T13:21:57  *** Cory has quit IRC
298 2016-04-05T13:21:57  *** devrandom has quit IRC
299 2016-04-05T13:21:57  *** pigeons has quit IRC
300 2016-04-05T13:21:57  *** mm_1 has quit IRC
301 2016-04-05T13:21:57  *** nickler has quit IRC
302 2016-04-05T13:21:57  *** bad_duck has quit IRC
303 2016-04-05T13:21:57  *** midnightmagic has quit IRC
304 2016-04-05T13:21:57  *** aj has quit IRC
305 2016-04-05T13:21:57  *** so has quit IRC
306 2016-04-05T13:21:57  *** jannes has quit IRC
307 2016-04-05T13:21:57  *** abritoid has quit IRC
308 2016-04-05T13:21:58  *** jarret has quit IRC
309 2016-04-05T13:21:58  *** JackH has quit IRC
310 2016-04-05T13:21:58  *** BCBot has quit IRC
311 2016-04-05T13:21:58  *** Bootvis has quit IRC
312 2016-04-05T13:21:58  *** SteveTaylor has quit IRC
313 2016-04-05T13:21:58  *** hsmiths has quit IRC
314 2016-04-05T13:21:58  *** PRab has quit IRC
315 2016-04-05T13:21:58  *** hybridsole has quit IRC
316 2016-04-05T13:21:58  *** e0_ has quit IRC
317 2016-04-05T13:21:58  *** kinlo has quit IRC
318 2016-04-05T13:21:58  *** Lightsword has quit IRC
319 2016-04-05T13:21:59  *** isis has quit IRC
320 2016-04-05T13:24:34  *** mesmer_ has joined #bitcoin-core-dev
321 2016-04-05T13:24:34  *** cfields_ has joined #bitcoin-core-dev
322 2016-04-05T13:24:34  *** gavinandresen has joined #bitcoin-core-dev
323 2016-04-05T13:24:34  *** Cheeseo has joined #bitcoin-core-dev
324 2016-04-05T13:24:34  *** jtimon has joined #bitcoin-core-dev
325 2016-04-05T13:24:34  *** jannes has joined #bitcoin-core-dev
326 2016-04-05T13:24:34  *** dermoth has joined #bitcoin-core-dev
327 2016-04-05T13:24:34  *** davec has joined #bitcoin-core-dev
328 2016-04-05T13:24:34  *** SteveTaylor has joined #bitcoin-core-dev
329 2016-04-05T13:24:34  *** slackircbridge has joined #bitcoin-core-dev
330 2016-04-05T13:24:34  *** Luke-Jr has joined #bitcoin-core-dev
331 2016-04-05T13:24:34  *** gevs has joined #bitcoin-core-dev
332 2016-04-05T13:24:34  *** xabbix has joined #bitcoin-core-dev
333 2016-04-05T13:24:34  *** AaronvanW has joined #bitcoin-core-dev
334 2016-04-05T13:24:34  *** MarcoFalke has joined #bitcoin-core-dev
335 2016-04-05T13:24:34  *** Guyver2 has joined #bitcoin-core-dev
336 2016-04-05T13:24:34  *** abritoid has joined #bitcoin-core-dev
337 2016-04-05T13:24:34  *** Alopex has joined #bitcoin-core-dev
338 2016-04-05T13:24:34  *** frankenmint has joined #bitcoin-core-dev
339 2016-04-05T13:24:34  *** Ylbam has joined #bitcoin-core-dev
340 2016-04-05T13:24:34  *** hsmiths has joined #bitcoin-core-dev
341 2016-04-05T13:24:34  *** [b__b] has joined #bitcoin-core-dev
342 2016-04-05T13:24:34  *** cguida has joined #bitcoin-core-dev
343 2016-04-05T13:24:34  *** moli has joined #bitcoin-core-dev
344 2016-04-05T13:24:34  *** cryptapus_afk has joined #bitcoin-core-dev
345 2016-04-05T13:24:34  *** da2ce7 has joined #bitcoin-core-dev
346 2016-04-05T13:24:34  *** droark has joined #bitcoin-core-dev
347 2016-04-05T13:24:34  *** AtashiCon has joined #bitcoin-core-dev
348 2016-04-05T13:24:34  *** Anduck has joined #bitcoin-core-dev
349 2016-04-05T13:24:34  *** Thireus has joined #bitcoin-core-dev
350 2016-04-05T13:24:34  *** Evel-Knievel has joined #bitcoin-core-dev
351 2016-04-05T13:24:34  *** justanotheruser has joined #bitcoin-core-dev
352 2016-04-05T13:24:34  *** dgenr8 has joined #bitcoin-core-dev
353 2016-04-05T13:24:34  *** sanada has joined #bitcoin-core-dev
354 2016-04-05T13:24:34  *** achow101 has joined #bitcoin-core-dev
355 2016-04-05T13:24:34  *** PRab has joined #bitcoin-core-dev
356 2016-04-05T13:24:34  *** StringerBell has joined #bitcoin-core-dev
357 2016-04-05T13:24:34  *** gribble has joined #bitcoin-core-dev
358 2016-04-05T13:24:34  *** phantomcircuit has joined #bitcoin-core-dev
359 2016-04-05T13:24:34  *** btcdrak has joined #bitcoin-core-dev
360 2016-04-05T13:24:34  *** PaulCapestany has joined #bitcoin-core-dev
361 2016-04-05T13:24:34  *** Arnavion has joined #bitcoin-core-dev
362 2016-04-05T13:24:34  *** mkarrer has joined #bitcoin-core-dev
363 2016-04-05T13:24:34  *** jarret has joined #bitcoin-core-dev
364 2016-04-05T13:24:34  *** JackH has joined #bitcoin-core-dev
365 2016-04-05T13:24:34  *** BCBot has joined #bitcoin-core-dev
366 2016-04-05T13:24:34  *** Cory has joined #bitcoin-core-dev
367 2016-04-05T13:24:34  *** Madars has joined #bitcoin-core-dev
368 2016-04-05T13:24:34  *** neha has joined #bitcoin-core-dev
369 2016-04-05T13:24:34  *** Squidicuz has joined #bitcoin-core-dev
370 2016-04-05T13:24:34  *** arubi has joined #bitcoin-core-dev
371 2016-04-05T13:24:34  *** ryan-c has joined #bitcoin-core-dev
372 2016-04-05T13:24:34  *** goregrind has joined #bitcoin-core-dev
373 2016-04-05T13:24:34  *** fredrin has joined #bitcoin-core-dev
374 2016-04-05T13:24:34  *** ghtdak has joined #bitcoin-core-dev
375 2016-04-05T13:24:34  *** Bootvis has joined #bitcoin-core-dev
376 2016-04-05T13:24:34  *** gijensen has joined #bitcoin-core-dev
377 2016-04-05T13:24:34  *** afk11 has joined #bitcoin-core-dev
378 2016-04-05T13:24:34  *** baldur has joined #bitcoin-core-dev
379 2016-04-05T13:24:34  *** da2ce7_mobile has joined #bitcoin-core-dev
380 2016-04-05T13:24:34  *** devrandom has joined #bitcoin-core-dev
381 2016-04-05T13:24:34  *** CodeShark has joined #bitcoin-core-dev
382 2016-04-05T13:24:34  *** zmanian__ has joined #bitcoin-core-dev
383 2016-04-05T13:24:34  *** cjcj has joined #bitcoin-core-dev
384 2016-04-05T13:24:34  *** wangchun has joined #bitcoin-core-dev
385 2016-04-05T13:24:34  *** harding has joined #bitcoin-core-dev
386 2016-04-05T13:24:34  *** eragmus has joined #bitcoin-core-dev
387 2016-04-05T13:24:34  *** binns has joined #bitcoin-core-dev
388 2016-04-05T13:24:34  *** amiller has joined #bitcoin-core-dev
389 2016-04-05T13:24:34  *** teward has joined #bitcoin-core-dev
390 2016-04-05T13:24:34  *** Eliel_ has joined #bitcoin-core-dev
391 2016-04-05T13:24:34  *** sturles has joined #bitcoin-core-dev
392 2016-04-05T13:24:34  *** Amnez777 has joined #bitcoin-core-dev
393 2016-04-05T13:24:34  *** rubensayshi has joined #bitcoin-core-dev
394 2016-04-05T13:24:34  *** ebfull has joined #bitcoin-core-dev
395 2016-04-05T13:24:34  *** jouke has joined #bitcoin-core-dev
396 2016-04-05T13:24:34  *** wumpus has joined #bitcoin-core-dev
397 2016-04-05T13:24:34  *** BlueMatt has joined #bitcoin-core-dev
398 2016-04-05T13:24:34  *** pigeons has joined #bitcoin-core-dev
399 2016-04-05T13:24:34  *** tucenaber has joined #bitcoin-core-dev
400 2016-04-05T13:24:34  *** heath has joined #bitcoin-core-dev
401 2016-04-05T13:24:34  *** aureianimus has joined #bitcoin-core-dev
402 2016-04-05T13:24:34  *** kanzure has joined #bitcoin-core-dev
403 2016-04-05T13:24:34  *** fkhan_ has joined #bitcoin-core-dev
404 2016-04-05T13:24:34  *** hybridsole has joined #bitcoin-core-dev
405 2016-04-05T13:24:34  *** jyap has joined #bitcoin-core-dev
406 2016-04-05T13:24:34  *** ibrightly has joined #bitcoin-core-dev
407 2016-04-05T13:24:34  *** windsok has joined #bitcoin-core-dev
408 2016-04-05T13:24:34  *** lesderid has joined #bitcoin-core-dev
409 2016-04-05T13:24:34  *** CyrusV has joined #bitcoin-core-dev
410 2016-04-05T13:24:34  *** gmaxwell has joined #bitcoin-core-dev
411 2016-04-05T13:24:34  *** go1111111 has joined #bitcoin-core-dev
412 2016-04-05T13:24:34  *** [Author] has joined #bitcoin-core-dev
413 2016-04-05T13:24:34  *** lclc has joined #bitcoin-core-dev
414 2016-04-05T13:24:34  *** petertodd has joined #bitcoin-core-dev
415 2016-04-05T13:24:34  *** lecusemble has joined #bitcoin-core-dev
416 2016-04-05T13:24:34  *** warren has joined #bitcoin-core-dev
417 2016-04-05T13:24:34  *** OxADADA has joined #bitcoin-core-dev
418 2016-04-05T13:24:34  *** jl2012 has joined #bitcoin-core-dev
419 2016-04-05T13:24:34  *** instagibbs has joined #bitcoin-core-dev
420 2016-04-05T13:24:34  *** mr_burdell has joined #bitcoin-core-dev
421 2016-04-05T13:24:34  *** crescendo has joined #bitcoin-core-dev
422 2016-04-05T13:24:34  *** limpkin has joined #bitcoin-core-dev
423 2016-04-05T13:24:34  *** Expanse has joined #bitcoin-core-dev
424 2016-04-05T13:24:34  *** berndj has joined #bitcoin-core-dev
425 2016-04-05T13:24:34  *** e0_ has joined #bitcoin-core-dev
426 2016-04-05T13:24:34  *** mm_1 has joined #bitcoin-core-dev
427 2016-04-05T13:24:34  *** nkuttler has joined #bitcoin-core-dev
428 2016-04-05T13:24:34  *** murr4y has joined #bitcoin-core-dev
429 2016-04-05T13:24:34  *** zibbo has joined #bitcoin-core-dev
430 2016-04-05T13:24:34  *** kinlo has joined #bitcoin-core-dev
431 2016-04-05T13:24:34  *** so has joined #bitcoin-core-dev
432 2016-04-05T13:24:34  *** helo has joined #bitcoin-core-dev
433 2016-04-05T13:24:34  *** zxzzt has joined #bitcoin-core-dev
434 2016-04-05T13:24:34  *** nanotube has joined #bitcoin-core-dev
435 2016-04-05T13:24:34  *** nickler has joined #bitcoin-core-dev
436 2016-04-05T13:24:34  *** roasbeef has joined #bitcoin-core-dev
437 2016-04-05T13:24:34  *** adam3us has joined #bitcoin-core-dev
438 2016-04-05T13:24:34  *** jonasschnelli has joined #bitcoin-core-dev
439 2016-04-05T13:24:34  *** morcos has joined #bitcoin-core-dev
440 2016-04-05T13:24:34  *** bad_duck has joined #bitcoin-core-dev
441 2016-04-05T13:24:34  *** d9b4bef9 has joined #bitcoin-core-dev
442 2016-04-05T13:24:34  *** midnightmagic has joined #bitcoin-core-dev
443 2016-04-05T13:24:34  *** Lightsword has joined #bitcoin-core-dev
444 2016-04-05T13:24:34  *** sdaftuar has joined #bitcoin-core-dev
445 2016-04-05T13:24:34  *** aj has joined #bitcoin-core-dev
446 2016-04-05T13:24:34  *** isis has joined #bitcoin-core-dev
447 2016-04-05T13:24:34  *** haakonn has joined #bitcoin-core-dev
448 2016-04-05T13:24:35  <jonasschnelli> https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667 should be write(1)
449 2016-04-05T13:24:35  *** michagogo has quit IRC
450 2016-04-05T13:25:58  *** cryptapus has joined #bitcoin-core-dev
451 2016-04-05T13:26:26  <wumpus> sipa: jonasschnelli: yes I had some problems generating the tests as well last time
452 2016-04-05T13:26:37  <jl2012> sorry for OT.  OP_VERIF is invalid even when occuring in an unexecuted OP_IF branch. Where this rule is defined in the code?
453 2016-04-05T13:27:01  <wumpus> I added the pretty printing because it ended up all on one line
454 2016-04-05T13:27:30  <wumpus> I don't think this was tested after introducing univalue
455 2016-04-05T13:27:42  <jonasschnelli> wumpus: the issue is here: https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L667
456 2016-04-05T13:28:02  <jonasschnelli> you add a root level on level 4
457 2016-04-05T13:28:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
458 2016-04-05T13:28:04  *** michagogo has joined #bitcoin-core-dev
459 2016-04-05T13:28:08  <wumpus> ok
460 2016-04-05T13:28:35  <jonasschnelli> I guess if i change this i need to update all static test data.
461 2016-04-05T13:28:38  <wumpus> apparently I didn't really know what pretty print arguments to use
462 2016-04-05T13:28:49  <jonasschnelli> heh. Yes. I was also not sure.
463 2016-04-05T13:28:51  <wumpus> no, I don't think you need to do that
464 2016-04-05T13:29:17  <wumpus> I probably fixed the excessive indent by hand last time
465 2016-04-05T13:29:52  <sipa> wumpus: i'm making some changes, and fixing it
466 2016-04-05T13:30:03  <jonasschnelli> sipa: thanks!
467 2016-04-05T13:30:06  <wumpus> this was less work than manually formatting the json from everything on one line
468 2016-04-05T13:30:12  <wumpus> but stil not ideal no
469 2016-04-05T13:30:15  <wumpus> sipa: ok great!
470 2016-04-05T13:30:22  * jonasschnelli is heading back to GUI RBF
471 2016-04-05T13:30:48  <sipa> wumpus: any objections to merging the valid and invalid script tests into one file?
472 2016-04-05T13:31:13  <sipa> it's annoying for generating, and makes the tests less clear
473 2016-04-05T13:31:15  <wumpus> sipa: I haven't; though you could consider it an interface change, as it's used by other projects
474 2016-04-05T13:31:35  <jonasschnelli> sipa: I think you should use write(1) (1 whitespace ident) and only use write(1, X) if you want to insert a sublevel at level x
475 2016-04-05T13:31:40  <wumpus> and it makes it harder to backport/forward-port tests
476 2016-04-05T13:31:42  <wumpus> so I'm not sure
477 2016-04-05T13:31:48  <wumpus> I did consider the same at some point
478 2016-04-05T13:32:10  <sipa> wumpus: well, i'm working on segwit tests, and i have no intention of manually writing everything for both master and backports
479 2016-04-05T13:32:24  <sipa> so that would also mean backporting that merging
480 2016-04-05T13:32:28  <btcdrak> wumpus: no thanks!
481 2016-04-05T13:32:40  <wumpus> okay
482 2016-04-05T13:32:50  <btcdrak> kinlo: yes, it's only one way though, so you can read on the Bitcoin Core Slack
483 2016-04-05T13:33:43  <kinlo> as long as this is the only official channel and we don't actually use slack it's all ok
484 2016-04-05T13:33:58  <sipa> wumpus: and for segwit, an interface change is inevitable, as we'll need to add a witness field
485 2016-04-05T13:34:05  <wumpus> sipa: I agree
486 2016-04-05T13:34:13  <wumpus> sipa: that's a good excuse, go ahead :)
487 2016-04-05T13:35:15  <wumpus> kinlo: I'm not sure how happy I really am about it. I mean, in principe everything here is public, but on the other hand non-technical people will put everything under a magnifying glass and are bound to misinterpret things
488 2016-04-05T13:35:23  <btcdrak> wumpus: no thanks!
489 2016-04-05T13:36:48  <wumpus> this happened before a while ago though i don't remember the specific instance, oh yeah some commit that bumped the version to 0.12.1 on the 0.12 branch was misinterpreted as '0.12.1 tagged!'
490 2016-04-05T13:38:46  *** cryptapus__ has joined #bitcoin-core-dev
491 2016-04-05T13:38:46  *** cryptapus__ has joined #bitcoin-core-dev
492 2016-04-05T13:40:29  *** cryptapus has quit IRC
493 2016-04-05T13:40:30  <GitHub15> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9149688f87c...214ec0b5e8b2
494 2016-04-05T13:40:30  <GitHub15> bitcoin/master 3373c43 Adam Brown: [doc] Update port in tor.md...
495 2016-04-05T13:40:31  <GitHub15> bitcoin/master 214ec0b Wladimir J. van der Laan: Merge #7813: [doc] Update port in tor.md...
496 2016-04-05T13:40:39  *** cryptapus__ is now known as cryptapus
497 2016-04-05T13:40:40  <GitHub21> [bitcoin] laanwj closed pull request #7813: [doc] Update port in tor.md (master...Mf1604-docTor) https://github.com/bitcoin/bitcoin/pull/7813
498 2016-04-05T13:41:55  <GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/214ec0b5e8b2...55db5f07b1c4
499 2016-04-05T13:41:56  <GitHub48> bitcoin/master 10d3ae1 Wladimir J. van der Laan: devtools: Auto-set branch to merge to in github-merge...
500 2016-04-05T13:41:56  <GitHub48> bitcoin/master 55db5f0 Wladimir J. van der Laan: Merge #7781: devtools: Auto-set branch to merge to in github-merge...
501 2016-04-05T13:42:00  <GitHub91> [bitcoin] laanwj closed pull request #7781: devtools: Auto-set branch to merge to in github-merge (master...2016_04_github_merge_autobranch) https://github.com/bitcoin/bitcoin/pull/7781
502 2016-04-05T13:43:18  *** frankenmint has quit IRC
503 2016-04-05T13:45:07  <GitHub129> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/55db5f07b1c4...3cc0fb3a23e5
504 2016-04-05T13:45:07  <GitHub129> bitcoin/master f063863 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release...
505 2016-04-05T13:45:08  <GitHub129> bitcoin/master 3cc0fb3 Wladimir J. van der Laan: Merge #7776: build: Remove unnecessary executables from gitian release...
506 2016-04-05T13:45:14  <GitHub28> [bitcoin] laanwj closed pull request #7776: build: Remove unnecessary executables from gitian release (master...2016_03_gitian_release_cleanup) https://github.com/bitcoin/bitcoin/pull/7776
507 2016-04-05T13:46:08  <GitHub41> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/a784675a329d6206af125d997381221dd1e99d11
508 2016-04-05T13:46:09  <GitHub41> bitcoin/0.12 a784675 Wladimir J. van der Laan: build: Remove unnecessary executables from gitian release...
509 2016-04-05T13:47:04  *** crescendo has quit IRC
510 2016-04-05T13:48:16  *** crescendo has joined #bitcoin-core-dev
511 2016-04-05T13:51:09  *** cryptapus has quit IRC
512 2016-04-05T13:56:16  <jl2012> re OP_VERIF I think I find the answer at https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L295
513 2016-04-05T13:57:44  <GitHub158> [bitcoin] jonasschnelli opened pull request #7816: [Wallet] slighly refactor GetOldestKeyPoolTime() (master...2016/04/wallet_oldest_key) https://github.com/bitcoin/bitcoin/pull/7816
514 2016-04-05T14:08:09  <btcdrak> wumpus: kinlo: the slackbridge has been in operation for a few months already
515 2016-04-05T14:09:08  <btcdrak> I was just setting the rejoin flag
516 2016-04-05T14:09:40  <GitHub91> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3cc0fb3a23e5...916b15a87a1f
517 2016-04-05T14:09:41  <GitHub91> bitcoin/master 92107d5 mruddy: RPC: add versionHex in getblock and getblockheader JSON results; expand data in getblockchaininfo bip9_softforks field.
518 2016-04-05T14:09:41  <GitHub91> bitcoin/master 916b15a Wladimir J. van der Laan: Merge #7774: RPC: add versionHex in getblock and getblockheader JSON results...
519 2016-04-05T14:09:47  <GitHub102> [bitcoin] laanwj closed pull request #7774: RPC: add versionHex in getblock and getblockheader JSON results (master...hexver) https://github.com/bitcoin/bitcoin/pull/7774
520 2016-04-05T14:13:59  <wumpus> btcdrak: okay
521 2016-04-05T14:14:18  <GitHub49> [bitcoin] jonasschnelli opened pull request #7817: [Qt] attribute replaceable (RBF) transactions (master...2016/04/qt_rbf) https://github.com/bitcoin/bitcoin/pull/7817
522 2016-04-05T14:16:14  <btcdrak> wumpus: do we need to do a hard coded seeds update for 0.12.1?
523 2016-04-05T14:16:36  <wumpus> I only do that for major releases
524 2016-04-05T14:16:59  <GitHub175> [bitcoin] sipa opened pull request #7818: Refactor script tests (master...refactorscriptests) https://github.com/bitcoin/bitcoin/pull/7818
525 2016-04-05T14:17:40  <wumpus> should update the translation strings though
526 2016-04-05T14:21:39  <GitHub48> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/916b15a87a1f...e30a5b0aaaa9
527 2016-04-05T14:21:39  <GitHub48> bitcoin/master 190c1e2 JeremyRand: Doc: change Precise to Trusty in gitian-building.md...
528 2016-04-05T14:21:40  <GitHub48> bitcoin/master e30a5b0 Wladimir J. van der Laan: Merge #7791: Doc: change Precise to Trusty in gitian-building.md...
529 2016-04-05T14:21:53  <GitHub42> [bitcoin] laanwj closed pull request #7791: Doc: change Precise to Trusty in gitian-building.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7791
530 2016-04-05T15:06:29  <Chris_Stewart_5> I'm looking at this test case from script_invalid.json inside of bitcoin core, shouldn't this have a MINIMALDATA flag?
531 2016-04-05T15:06:31  <Chris_Stewart_5> ["0x4c01","0x01 NOP", "P2SH,STRICTENC", "PUSHDATA1 with not enough bytes"]
532 2016-04-05T15:12:47  *** Giszmo has joined #bitcoin-core-dev
533 2016-04-05T15:15:30  <GitHub68> [bitcoin] jonasschnelli opened pull request #7819: [Qt] Simple opt-in-RBF checkbox (master...2016/04/qt_rbf_set) https://github.com/bitcoin/bitcoin/pull/7819
534 2016-04-05T15:17:48  *** zooko has joined #bitcoin-core-dev
535 2016-04-05T15:18:36  <sipa> Chris_Stewart_5: the test should fail even without minimaldata rule
536 2016-04-05T15:19:26  <sipa> Chris_Stewart_5: as it's trying to push a 1-byte value which is past the end of scriptSig
537 2016-04-05T15:23:27  *** abritoid has quit IRC
538 2016-04-05T15:39:12  <GitHub31> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e30a5b0aaaa9...4dc1b3a29693
539 2016-04-05T15:39:12  <GitHub31> bitcoin/master 0087f26 Pavel Janík: Use relative paths instead of absolute paths
540 2016-04-05T15:39:13  <GitHub31> bitcoin/master 4dc1b3a Wladimir J. van der Laan: Merge #7788: Use relative paths instead of absolute paths in protoc calls...
541 2016-04-05T15:39:17  <GitHub118> [bitcoin] laanwj closed pull request #7788: Use relative paths instead of absolute paths in protoc calls (master...20160402_protoc_use_relpath) https://github.com/bitcoin/bitcoin/pull/7788
542 2016-04-05T15:40:21  <Chris_Stewart_5> sipa: interesting. I didn't realize that limitation was there. I thought you think of the scriptSig & scriptPubKey as one big concatenated list when you were running it through the interpreter.
543 2016-04-05T15:41:20  <sipa> Chris_Stewart_5: yes
544 2016-04-05T15:41:46  *** cryptapus has joined #bitcoin-core-dev
545 2016-04-05T15:41:46  <sipa> Chris_Stewart_5: but the scriptSig here contains an opcode that says "The next 1 byte is to be pushed: ", and then no more bytes
546 2016-04-05T15:41:51  <sipa> which is obviously invalid
547 2016-04-05T15:42:10  <sipa> it's like an unterminated quotation mark, or a missing endif
548 2016-04-05T15:45:52  <sipa> Chris_Stewart_5: typically you want negative tests that specify the weakest condition under which failure is expected
549 2016-04-05T15:48:33  <Chris_Stewart_5> sipa: If it was evaluated at as one big concatenated list though the next byte could be in the scriptPubKey. Where does the validation fail in bitcoin core?
550 2016-04-05T15:48:38  <Chris_Stewart_5> is it this line? https://github.com/bitcoin/bitcoin/blob/master/src/script/interpreter.cpp#L294
551 2016-04-05T15:49:01  <sipa> Chris_Stewart_5: that changed in early 2010
552 2016-04-05T15:49:11  <sipa> Chris_Stewart_5: scriptPubKey and scriptSig are evaluated separately
553 2016-04-05T15:49:18  <Chris_Stewart_5> haha just realized that :-)
554 2016-04-05T15:49:50  <Chris_Stewart_5> stack state is shared between the two, is there a reason this is done? Is it one of those things "Its always been done this way so we are going to keep doing it that way" or is there more reason to it
555 2016-04-05T15:50:08  <GitHub120> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4dc1b3a29693...1b2460bd5824
556 2016-04-05T15:50:08  <GitHub120> bitcoin/master fada0c4 MarcoFalke: [doc] Fix doxygen comments for members
557 2016-04-05T15:50:09  <GitHub120> bitcoin/master 1b2460b Wladimir J. van der Laan: Merge #7793: [doxygen] Fix member comments...
558 2016-04-05T15:50:13  <GitHub171> [bitcoin] laanwj closed pull request #7793: [doxygen] Fix member comments (master...Mf1604-doxygenMembers) https://github.com/bitcoin/bitcoin/pull/7793
559 2016-04-05T15:51:05  <sipa> Chris_Stewart_5: that's how the scriptSig communicates its resulting stack to the scriptPubKey
560 2016-04-05T15:51:12  <sipa> Chris_Stewart_5: what alternative would you suggest?
561 2016-04-05T15:52:52  <Chris_Stewart_5> concatenate the scriptSig ++ scriptPubKey together and run the entire thing through the interpreter instead of mamking two calls to EvalScript and maintaing stack state
562 2016-04-05T15:53:16  <sipa> that's how Bitcoin was in 2009, and it had massive security risks
563 2016-04-05T15:53:22  <sipa> as the scriptSig is under control of the attacker
564 2016-04-05T15:54:11  <sipa> say your scriptPubKey is 47 bytes, you'd just make a scriptSig 0x3F (which means "push the next 47 bytes onto the stack"), and the result would be accepted
565 2016-04-05T15:54:38  <sipa> as it would treat the whole scriptPubKey that's concatenated after it as data being pushed, rather than code
566 2016-04-05T15:54:53  <instagibbs> sipa, ok now that section of code makes sense
567 2016-04-05T15:56:46  <Chris_Stewart_5> sipa: Wow that is a great way to explain it. So basically that would allow the script to trivially succeed since the scriptPubKey != OP_0 || OP_FALSE right?
568 2016-04-05T15:57:25  <sipa> Chris_Stewart_5: furthermore, changing it back to that model of execution would almost by definition be a hard fork
569 2016-04-05T15:57:39  <sipa> because if it has any effect at all, it's going to turn invalid things into valid things
570 2016-04-05T15:58:00  <Chris_Stewart_5> sipa: Ok. Thanks for the explanation. I appreciate it
571 2016-04-05T16:01:36  <GitHub166> [bitcoin] laanwj pushed 1 new commit to 0.12: https://github.com/bitcoin/bitcoin/commit/c2106543fe017d443c2e50daf3dd1d42e6ec35a2
572 2016-04-05T16:01:37  <GitHub166> bitcoin/0.12 c210654 Wladimir J. van der Laan: pre-rc1 translations update...
573 2016-04-05T16:08:09  <GitHub174> [bitcoin] laanwj closed pull request #7654: Add net2 debug option (master...DebugNet2) https://github.com/bitcoin/bitcoin/pull/7654
574 2016-04-05T16:17:12  <gmaxwell>   "errors": "WARNING: check your network connection, 5 blocks received in the last 4 hours (24 expected)"
575 2016-04-05T16:17:50  <gmaxwell> of course I dunno when that triggered, though I don't think that host has had any network outages.
576 2016-04-05T16:18:15  <wumpus> that's the one we disabled on 0.12 right?
577 2016-04-05T16:18:26  <gmaxwell> yep.
578 2016-04-05T16:18:55  *** zooko has quit IRC
579 2016-04-05T16:35:42  *** cjcj has quit IRC
580 2016-04-05T16:51:20  *** Don_John has joined #bitcoin-core-dev
581 2016-04-05T17:01:27  *** paveljanik has joined #bitcoin-core-dev
582 2016-04-05T17:01:27  *** paveljanik has joined #bitcoin-core-dev
583 2016-04-05T17:07:58  *** abritoid has joined #bitcoin-core-dev
584 2016-04-05T17:11:31  *** cjcj has joined #bitcoin-core-dev
585 2016-04-05T17:28:44  <cfields_> wumpus: have you looked into the spurious (possible) race condition that we're hitting on travis sometimes? I'm going to poke at it now, curious if you have anything to go on
586 2016-04-05T17:29:04  *** bsm1175321 has joined #bitcoin-core-dev
587 2016-04-05T17:29:39  <MarcoFalke> which one do you mean?
588 2016-04-05T17:30:06  <cfields_> MarcoFalke: https://github.com/bitcoin/bitcoin/issues/7470
589 2016-04-05T17:30:10  *** bsm1175321 is now known as bsm117532
590 2016-04-05T17:30:30  <cfields_> I've noticed a few of those (or similar) lately
591 2016-04-05T17:31:01  <MarcoFalke> Ok, this is not travis only. I think some people could "reproduce" those locally
592 2016-04-05T17:31:20  <MarcoFalke> Note: Please don't retrigger https://github.com/bitcoin/bitcoin/pull/7817 (just reported the issue to travis)
593 2016-04-05T17:31:30  <cfields_> MarcoFalke: ah nice, you happen to have a repro case handy?
594 2016-04-05T17:32:49  <MarcoFalke> Unfortunatley not, but didn't someone mention it can happen after some time?
595 2016-04-05T17:33:15  <cfields_> not sure
596 2016-04-05T17:33:22  <MarcoFalke> So I was thinking about adding some random sleeps in the test suite and let it run over night
597 2016-04-05T17:37:01  <cfields_> sure, if there's a race condition caused by arbitrary sleeps, we'd definitely want to know about those
598 2016-04-05T17:52:06  *** Thireus has quit IRC
599 2016-04-05T17:52:24  *** Thireus has joined #bitcoin-core-dev
600 2016-04-05T17:59:00  *** e0_ has quit IRC
601 2016-04-05T18:03:41  *** PaulCapestany has quit IRC
602 2016-04-05T18:05:21  *** PaulCapestany has joined #bitcoin-core-dev
603 2016-04-05T18:05:50  *** Don_John has quit IRC
604 2016-04-05T18:08:30  *** moli has quit IRC
605 2016-04-05T18:10:19  *** jtimon has quit IRC
606 2016-04-05T18:13:15  *** moli has joined #bitcoin-core-dev
607 2016-04-05T18:21:03  *** supasonic has joined #bitcoin-core-dev
608 2016-04-05T18:34:03  *** supasonic has quit IRC
609 2016-04-05T18:42:22  *** d_t has joined #bitcoin-core-dev
610 2016-04-05T18:47:41  *** supasonic has joined #bitcoin-core-dev
611 2016-04-05T18:57:10  <paveljanik> GH is a bit slow right now...
612 2016-04-05T18:57:45  *** abritoid has quit IRC
613 2016-04-05T19:33:42  *** cryptapus has quit IRC
614 2016-04-05T19:41:47  <GitHub127> [bitcoin] jtimon opened pull request #7820: Consensus: Policy: Move CFeeRate out of consensus module and create CPolicy interface (master...0.12.99-consensus-dust-out) https://github.com/bitcoin/bitcoin/pull/7820
615 2016-04-05T19:45:07  *** jtimon has joined #bitcoin-core-dev
616 2016-04-05T19:53:07  *** e0_ has joined #bitcoin-core-dev
617 2016-04-05T19:57:31  *** xabbix has quit IRC
618 2016-04-05T20:02:43  *** xabbix has joined #bitcoin-core-dev
619 2016-04-05T20:02:43  *** xabbix has joined #bitcoin-core-dev
620 2016-04-05T20:03:25  *** arubi has quit IRC
621 2016-04-05T20:03:55  *** arubi has joined #bitcoin-core-dev
622 2016-04-05T20:13:53  *** frankenmint has joined #bitcoin-core-dev
623 2016-04-05T20:21:54  *** frankenmint has quit IRC
624 2016-04-05T20:33:03  *** Chris_Stewart_5 has quit IRC
625 2016-04-05T20:36:29  *** MarcoFalke has quit IRC
626 2016-04-05T20:41:03  *** Guyver2_ has joined #bitcoin-core-dev
627 2016-04-05T20:45:12  *** Guyver2 has quit IRC
628 2016-04-05T20:45:19  *** Guyver2_ is now known as Guyver2
629 2016-04-05T20:49:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
630 2016-04-05T21:04:05  *** d_t has quit IRC
631 2016-04-05T21:07:04  *** supasonic has quit IRC
632 2016-04-05T21:20:16  *** zmanian__ has quit IRC
633 2016-04-05T21:22:38  *** supasonic has joined #bitcoin-core-dev
634 2016-04-05T21:23:09  *** zmanian__ has joined #bitcoin-core-dev
635 2016-04-05T21:45:01  *** Squidicc has joined #bitcoin-core-dev
636 2016-04-05T21:45:13  *** Squidicuz has quit IRC
637 2016-04-05T21:46:01  *** Arnavion has quit IRC
638 2016-04-05T21:46:05  *** Arnavion3 has joined #bitcoin-core-dev
639 2016-04-05T21:46:09  *** Arnavion3 is now known as Arnavion
640 2016-04-05T21:48:52  *** fkhan_ has quit IRC
641 2016-04-05T21:52:56  *** fkhan_ has joined #bitcoin-core-dev
642 2016-04-05T22:10:47  *** frankenmint has joined #bitcoin-core-dev
643 2016-04-05T22:13:03  *** p15 has quit IRC
644 2016-04-05T22:26:18  *** Chris_Stewart_5 has quit IRC
645 2016-04-05T22:40:06  *** Guyver2 has quit IRC
646 2016-04-05T22:40:40  *** Chris_Stewart_5 has joined #bitcoin-core-dev
647 2016-04-05T22:57:36  <sipa> oh, github supports verifying gpg signatures now
648 2016-04-05T22:58:01  *** AaronvanW has quit IRC
649 2016-04-05T23:15:05  <PRab> sipa: You figure out how to verify your gpg key? I added mine to https://github.com/settings/keys, but its still showing "Unverified".
650 2016-04-05T23:15:56  <sipa> yeah, works for me: https://github.com/bitcoin/secp256k1/commits/master
651 2016-04-05T23:16:16  <sipa> does your commit email address match an email address in the key?
652 2016-04-05T23:18:17  <PRab> sipa: It should. Maybe it doesn't scan old commits. I believe https://github.com/bitcoin/gitian.sigs/commits/master/0.12.0rc5-linux/prab/bitcoin-linux-0.12-build.assert should have been signed with that key.
653 2016-04-05T23:20:15  <sipa> committer Paul Rabahy <PRabahy@gmail.com> 1455405253 -0500
654 2016-04-05T23:20:33  <sipa> maybe upper/lower case mix?
655 2016-04-05T23:21:39  <PRab> Looks the same to me.
656 2016-04-05T23:21:40  <PRab> https://imgur.com/WN1kiEt
657 2016-04-05T23:22:08  <sipa> PRab: ah, but that email address is not associated with your github account
658 2016-04-05T23:22:44  <PRab> Ah, got it.
659 2016-04-05T23:23:14  <PRab> github has it as prabahy@gmail.com
660 2016-04-05T23:23:41  <PRab> I'll get ahold of github support.
661 2016-04-05T23:27:20  <sipa> and it works pretty far back: https://github.com/bitcoin/bitcoin/commit/9269d0e96e621a6e02da8074785ac310ce64db73
662 2016-04-05T23:28:42  <PRab> Hum, I managed to fix my email address (had to go through a temp email because of case insensitivity), but its still not working.
663 2016-04-05T23:30:26  *** frankenmint has quit IRC
664 2016-04-05T23:31:00  *** frankenmint has joined #bitcoin-core-dev
665 2016-04-05T23:31:15  <PRab> Anyway, really cool feature.
666 2016-04-05T23:35:30  *** frankenmint has quit IRC
667 2016-04-05T23:47:38  *** wallet42 has joined #bitcoin-core-dev
668 2016-04-05T23:50:02  *** frankenmint has joined #bitcoin-core-dev