12016-04-19T00:06:56  *** Samdney has quit IRC
  22016-04-19T00:32:58  <phantomcircuit> cfields: what's the best way to add a new binary to the auto tools stuff? i tried copying bitcoin-tx stuff and renaming it but things exploded
  32016-04-19T00:33:18  <cfields> exploded?
  42016-04-19T00:33:52  <phantomcircuit> complained about things in script.h being redefined
  52016-04-19T00:33:55  <phantomcircuit> i'll try again
  62016-04-19T00:34:06  <cfields> phantomcircuit: i'd need to see what you tried
  72016-04-19T00:37:08  *** btcdrak has quit IRC
  82016-04-19T00:37:53  <phantomcircuit> and of course it worked this time
  92016-04-19T00:38:08  <phantomcircuit> only thing i did differently was git clean -fdx
 102016-04-19T00:38:16  <phantomcircuit> but i guess there's something cached that messed it up before
 112016-04-19T00:38:45  <gmaxwell> phantomcircuit: I told you talking to cfields would fix your problems.
 122016-04-19T00:39:08  <cfields> heh
 132016-04-19T00:40:23  <cfields> phantomcircuit: mm, there really shouldn't be any way for that to happen though, unless you're building with crazy options
 142016-04-19T00:40:46  <phantomcircuit>  --without-gui --disable-wallet
 152016-04-19T00:40:53  <phantomcircuit> nothing else
 162016-04-19T00:41:06  <cfields> i think there are some edge-cases where static libs don't get recreated when you're messing with the Makefiles though. Sounds like maybe you had objects linked in twice as a result of something like that
 172016-04-19T00:42:34  <cfields> gmaxwell: any chance you've ever investigated how often the opportunistic write in EndMessage() ends up being hit?
 182016-04-19T00:42:49  <gmaxwell> Not that I can recall.
 192016-04-19T00:43:02  <cfields> ok
 202016-04-19T00:45:27  <phantomcircuit> cfields: in general socket send() calls typically succeed completely or fail completely
 212016-04-19T00:48:04  <cfields> phantomcircuit: "completely" meaning it swallows the entire buffer it's handed?
 222016-04-19T00:48:47  *** fengling has joined #bitcoin-core-dev
 232016-04-19T00:49:04  <phantomcircuit> cfields, as long as the tcp buffer in the kernel is larger than the buffer being sent then it will complete
 242016-04-19T00:49:08  <BlueMatt> i mean it will if there is room in tcp buf
 252016-04-19T00:49:08  <gmaxwell> by 'general' he means on linux. on windows the default tcp socket buffers are like 8k.
 262016-04-19T00:49:40  <phantomcircuit> cfields: why do you ask though?
 272016-04-19T00:49:50  <cfields> right, i wouldn't think that would hold true in many cases
 282016-04-19T00:50:19  <cfields> phantomcircuit: mainly curious how often we're sending with an empty send queue, regardless of the msg/tcp buffer size
 292016-04-19T00:53:25  <phantomcircuit> cfields, yes im curious why you're curious
 302016-04-19T00:55:59  <cfields> phantomcircuit: the opportunistic send breaks my abstraction model. The connection manager needs to hold total send/recv stats, as opposed to static vars in CNode as it is now. Just thinking through how best to handle it.
 312016-04-19T00:56:46  <cfields> it's actually not a problem at all, but I'm writing some interim code movement for easier review
 322016-04-19T00:59:08  <cfields> (put more plainly, the issue is that the opportunistic send causes send() to be called from 2 threads)
 332016-04-19T00:59:48  <phantomcircuit> cfields: the opportunistic send thing can go away, it just means you'll have an extra memory copy
 342016-04-19T01:04:11  <cfields> phantomcircuit: my concern was that it's helpful as an optim to prioritize immediate sends (version msg after connect, for example) over others. I can't imagine it matters much, though.
 352016-04-19T01:05:30  <phantomcircuit> cfields, it means those things are sent after the recv handler completes
 362016-04-19T01:06:01  <phantomcircuit> although actually there could be a conditional triggered to get the thread that sends stuff to wake up when there's data available
 372016-04-19T01:06:38  <cfields> right
 382016-04-19T01:13:04  *** belcher has quit IRC
 392016-04-19T01:14:12  *** kexkey has joined #bitcoin-core-dev
 402016-04-19T01:22:34  *** kexkey has quit IRC
 412016-04-19T01:23:55  *** Chris_Stewart_5 has quit IRC
 422016-04-19T01:25:54  *** Kexkey has joined #bitcoin-core-dev
 432016-04-19T01:30:06  *** dermoth_ has quit IRC
 442016-04-19T01:30:47  *** dermoth_ has joined #bitcoin-core-dev
 452016-04-19T01:32:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 462016-04-19T01:32:59  *** Ylbam has quit IRC
 472016-04-19T01:49:37  *** go1111111 has joined #bitcoin-core-dev
 482016-04-19T01:56:49  *** Kexkey has quit IRC
 492016-04-19T02:00:15  *** dermoth_ has quit IRC
 502016-04-19T02:00:50  *** dermoth_ has joined #bitcoin-core-dev
 512016-04-19T02:28:13  *** Chris_Stewart_5 has quit IRC
 522016-04-19T02:31:36  *** jtimon has quit IRC
 532016-04-19T03:15:43  *** jtimon has joined #bitcoin-core-dev
 542016-04-19T03:35:09  *** harding has quit IRC
 552016-04-19T03:35:37  *** jtimon has quit IRC
 562016-04-19T03:36:09  *** harding has joined #bitcoin-core-dev
 572016-04-19T03:40:34  *** amiller has quit IRC
 582016-04-19T03:59:13  *** xiangfu has joined #bitcoin-core-dev
 592016-04-19T04:04:47  *** xiangfu has quit IRC
 602016-04-19T04:05:27  *** xiangfu has joined #bitcoin-core-dev
 612016-04-19T04:08:00  *** mrkent has quit IRC
 622016-04-19T04:09:03  *** Guest43084 has joined #bitcoin-core-dev
 632016-04-19T04:20:11  *** gijensen is now known as gijensen_
 642016-04-19T04:27:54  *** Guest43084 has quit IRC
 652016-04-19T04:33:24  *** xiangfu has quit IRC
 662016-04-19T04:35:04  *** amiller_ has joined #bitcoin-core-dev
 672016-04-19T04:40:18  *** paveljanik has quit IRC
 682016-04-19T04:44:48  *** TomMc has quit IRC
 692016-04-19T05:00:11  *** btcdrak has joined #bitcoin-core-dev
 702016-04-19T05:12:01  *** Alopex has quit IRC
 712016-04-19T05:13:07  *** Alopex has joined #bitcoin-core-dev
 722016-04-19T05:17:00  *** cryptocoder has quit IRC
 732016-04-19T05:21:50  *** BashCo has quit IRC
 742016-04-19T05:50:55  *** BashCo has joined #bitcoin-core-dev
 752016-04-19T05:56:20  *** cryptocoder has joined #bitcoin-core-dev
 762016-04-19T06:02:09  <GitHub89> [bitcoin] pstratem opened pull request #7907:  Optimize and Cleanup CScript::FindAndDelete (master...2016-04-17-findanddelete) https://github.com/bitcoin/bitcoin/pull/7907
 772016-04-19T06:13:23  *** frankenmint has quit IRC
 782016-04-19T06:15:22  *** d_t has quit IRC
 792016-04-19T06:26:17  *** [Author] has quit IRC
 802016-04-19T06:29:01  *** Alopex has quit IRC
 812016-04-19T06:30:06  *** Alopex has joined #bitcoin-core-dev
 822016-04-19T06:31:46  *** [Author] has joined #bitcoin-core-dev
 832016-04-19T06:33:45  *** mrkent_ has joined #bitcoin-core-dev
 842016-04-19T06:41:32  *** xiangfu has joined #bitcoin-core-dev
 852016-04-19T06:50:22  *** cryptocoder has quit IRC
 862016-04-19T06:51:53  *** mrkent_ has quit IRC
 872016-04-19T06:55:24  *** mrkent_ has joined #bitcoin-core-dev
 882016-04-19T07:12:52  *** xiangfu_ has joined #bitcoin-core-dev
 892016-04-19T07:17:52  *** xiangfu_ has quit IRC
 902016-04-19T07:18:01  *** Alopex has quit IRC
 912016-04-19T07:19:06  *** Alopex has joined #bitcoin-core-dev
 922016-04-19T07:22:24  <gmaxwell> something intresting...
 932016-04-19T07:22:30  <gmaxwell> $ grep 'received: notfound' ~/.bitcoin/debug.log | cut -d' ' -f1 | sort | uniq -c | sort -n
 942016-04-19T07:22:52  <gmaxwell>     145 2016-04-12
 952016-04-19T07:22:53  <gmaxwell>     296 2016-04-13
 962016-04-19T07:22:53  <gmaxwell>     728 2016-04-15
 972016-04-19T07:22:53  <gmaxwell>     938 2016-04-16
 982016-04-19T07:22:53  <gmaxwell>    1155 2016-04-17
 992016-04-19T07:22:55  <gmaxwell>    1384 2016-04-14
1002016-04-19T07:22:58  <gmaxwell>    1863 2016-04-19
1012016-04-19T07:23:00  <gmaxwell>    2832 2016-04-18
1022016-04-19T07:23:05  <gmaxwell> 19 is low because we're only 7.5 hours into the day.
1032016-04-19T07:23:29  <gmaxwell> but it's on track to be over 5000 based on that.
1042016-04-19T07:26:05  <gmaxwell> Anyone else seeing this?
1052016-04-19T07:28:04  <gmaxwell> anyone have debugnet logs going back betore the 11th?
1062016-04-19T07:47:51  *** Ylbam has joined #bitcoin-core-dev
1072016-04-19T07:54:26  *** Ylbam has quit IRC
1082016-04-19T07:57:46  *** Ylbam has joined #bitcoin-core-dev
1092016-04-19T08:02:03  *** adam3us has quit IRC
1102016-04-19T08:02:41  *** adam3us has joined #bitcoin-core-dev
1112016-04-19T08:07:27  *** jannes has joined #bitcoin-core-dev
1122016-04-19T08:24:10  <GitHub26> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d28995018003...fc9e3346e674
1132016-04-19T08:24:10  <GitHub26> bitcoin/master a3310b4 Wladimir J. van der Laan: txdb: Fix assert crash in new UTXO set cursor...
1142016-04-19T08:24:11  <GitHub26> bitcoin/master fc9e334 Wladimir J. van der Laan: Merge #7904: txdb: Fix assert crash in new UTXO set cursor...
1152016-04-19T08:24:20  <GitHub13> [bitcoin] laanwj closed pull request #7904: txdb: Fix assert crash in new UTXO set cursor (master...2016_04_fix_utxo_iterator) https://github.com/bitcoin/bitcoin/pull/7904
1162016-04-19T08:25:35  <GitHub161> [bitcoin] laanwj closed pull request #7894: [Qt] Use CURRENCY_UNIT for BitcoinUnits. (master...currency-unit) https://github.com/bitcoin/bitcoin/pull/7894
1172016-04-19T08:26:29  <GitHub160> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fc9e3346e674...fa9d86f8c4f4
1182016-04-19T08:26:30  <GitHub160> bitcoin/master fa05e22 MarcoFalke: [qa] pull-tester: Don't mute zmq ImportError
1192016-04-19T08:26:30  <GitHub160> bitcoin/master faa4f22 MarcoFalke: [qa] pull-tester: Exit early when no tests are run
1202016-04-19T08:26:31  <GitHub160> bitcoin/master fae1f4e MarcoFalke: [qa] rpc-tests: Fix link in comment and label error msg
1212016-04-19T08:26:39  <GitHub131> [bitcoin] laanwj closed pull request #7851: [qa] pull-tester: Don't mute zmq ImportError (master...Mf1604-qaUnmuteError) https://github.com/bitcoin/bitcoin/pull/7851
1222016-04-19T08:45:10  <GitHub170> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa9d86f8c4f4...4205ad7ca2b1
1232016-04-19T08:45:10  <GitHub170> bitcoin/master 87049e8 mrbandrews: Speed up getchaintips.
1242016-04-19T08:45:11  <GitHub170> bitcoin/master 4205ad7 Wladimir J. van der Laan: Merge #7827: Speed up getchaintips....
1252016-04-19T08:45:19  <GitHub49> [bitcoin] laanwj closed pull request #7827: Speed up getchaintips. (master...ba-fix-chaintips) https://github.com/bitcoin/bitcoin/pull/7827
1262016-04-19T08:50:05  <GitHub49> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/4205ad7ca2b1...187186b0fe03
1272016-04-19T08:50:06  <GitHub49> bitcoin/master de39c95 Wladimir J. van der Laan: test: move accounting_tests and rpc_wallet_tests to wallet/test...
1282016-04-19T08:50:07  <GitHub49> bitcoin/master f4eae2d Wladimir J. van der Laan: test: Create test fixture for wallet...
1292016-04-19T08:50:07  <GitHub49> bitcoin/master a25a4f5 Wladimir J. van der Laan: wallet_ismine.h → script/ismine.h...
1302016-04-19T08:50:16  <GitHub112> [bitcoin] laanwj closed pull request #7905: test: move accounting_tests and rpc_wallet_tests to wallet/test (master...2016_04_accounting_tests_to_wallet) https://github.com/bitcoin/bitcoin/pull/7905
1312016-04-19T08:51:20  <wumpus> gmaxwell: no, don't have netdebug logs, but wow that's a huge increase
1322016-04-19T08:51:31  <wumpus> that's the number of notfounds sent or received?
1332016-04-19T08:51:55  <gmaxwell> thats recieved.
1342016-04-19T08:52:55  <gmaxwell> my sending went up too... but I don't know if my sending counts are representative since I'm running #7840.
1352016-04-19T08:53:16  *** xiangfu_ has joined #bitcoin-core-dev
1362016-04-19T08:53:30  <gmaxwell>    1236 2016-04-11
1372016-04-19T08:53:30  <gmaxwell>    3469 2016-04-12
1382016-04-19T08:53:30  <gmaxwell>    2961 2016-04-13
1392016-04-19T08:53:30  <gmaxwell>    5494 2016-04-14
1402016-04-19T08:53:30  <gmaxwell>    6788 2016-04-15
1412016-04-19T08:53:33  <gmaxwell>   14933 2016-04-16
1422016-04-19T08:53:35  <gmaxwell>   10706 2016-04-17
1432016-04-19T08:53:38  <gmaxwell>   10018 2016-04-18
1442016-04-19T08:53:40  <gmaxwell>    5225 2016-04-19
1452016-04-19T09:19:24  <phantomcircuit> gmaxwell: that's kind of weird
1462016-04-19T09:19:29  <phantomcircuit> also
1472016-04-19T09:19:33  <phantomcircuit> how did you notice this?
1482016-04-19T09:19:35  <phantomcircuit> :)
1492016-04-19T09:22:46  <wumpus> if it's anything like how I notice these things he just saw a lot of notfounds in his log, wondered what, and then decided to do statistics on them
1502016-04-19T09:23:41  <gmaxwell> yea, I normally have debug logs scrolling by, and when I sense a glitch in the matrix I run stats.
1512016-04-19T09:23:43  <wumpus> could be a few strangely-behaved peers, it's not sudden enough for a code change
1522016-04-19T09:24:07  <gmaxwell> I'm seeing it on two nodes though the pattern is pretty different.
1532016-04-19T09:24:11  <wumpus> (e.g. if we had suddenly started waiting longer before requesting a transaction inved to us, you'd see more of a sudden jump)
1542016-04-19T09:24:53  <gmaxwell> it could be a side effect of some kind of denial of service happening to peers.
1552016-04-19T09:25:46  <gmaxwell> but ... pretty huge delay to see notfounds. It also could be some party trying to deanonymize the network graph by doing some mutually exclusive propagation stunts.
1562016-04-19T09:26:21  <sipa> are the tx or block notfounds?
1572016-04-19T09:26:27  <gmaxwell> tx.
1582016-04-19T09:26:50  <sipa> i don't understand... *your* are the one running 7840
1592016-04-19T09:27:01  <gmaxwell> I think it's unrelated to 7840.
1602016-04-19T09:27:36  <gmaxwell> On the _sending_ not founds, that could be due to 7840. But recieving, no.
1612016-04-19T09:27:39  <sipa> ah
1622016-04-19T09:28:00  <gmaxwell> also I've been running 7840 for a while; and this seems to have ramped.
1632016-04-19T09:29:40  <gmaxwell> e.g. for deanon, step 1 give all nodes except two nodes TX A while giving those nodes node A'.  Then step 2. create B which is a derivative of A', and give to one of them, and you'll learn if they're directly connected.
1642016-04-19T09:30:07  <gmaxwell> and I'm sure there are lots of other variations on that, including more efficient ones, regardless, they'll likely cause a lot of NOTFOUNDS.
1652016-04-19T09:30:43  <gmaxwell> Also, because GETDATA since the introduction of the mempool RPC will return things that aren't in the relay pool, someone could be using GETDATA to bypass inv delays.
1662016-04-19T09:30:56  <gmaxwell> (man, that mempool message is the privacy leak that keeps on giving)
1672016-04-19T09:33:07  <sipa> so you think this is a deanonymization technique?
1682016-04-19T09:36:02  <gmaxwell> maybe, seeing if I can get more or less evidence for that.
1692016-04-19T09:41:19  <GitHub199> [bitcoin] laanwj closed pull request #7625: Bugfix: Check for bench_bitcoin being enabled where needed, and skip UniValue dependency when unused (master...bugfix_bench_checks) https://github.com/bitcoin/bitcoin/pull/7625
1702016-04-19T09:43:52  <gmaxwell> I really can't tell, the highest notfound sending peers I have claim to be 0.11.x.
1712016-04-19T09:44:18  <gmaxwell> but it's not confined to a few peers.
1722016-04-19T09:44:31  <gmaxwell> notfounds could also be cause by blocks which are mining many doublespends.
1732016-04-19T09:44:47  <gmaxwell> since the block will evict the transactions from mempools.
1742016-04-19T09:50:08  *** mrkent_ has quit IRC
1752016-04-19T10:02:25  *** AaronvanW has joined #bitcoin-core-dev
1762016-04-19T10:02:59  *** Ylbam has quit IRC
1772016-04-19T10:18:00  *** AaronvanW has quit IRC
1782016-04-19T10:20:07  *** Ylbam has joined #bitcoin-core-dev
1792016-04-19T10:27:46  *** fengling has quit IRC
1802016-04-19T10:55:52  *** xiangfu_ has quit IRC
1812016-04-19T11:45:09  *** laurentmt has joined #bitcoin-core-dev
1822016-04-19T11:47:04  *** laurentmt has quit IRC
1832016-04-19T11:54:50  *** xiangfu has quit IRC
1842016-04-19T11:55:08  *** AaronvanW has joined #bitcoin-core-dev
1852016-04-19T11:55:09  *** AaronvanW has joined #bitcoin-core-dev
1862016-04-19T12:05:42  *** Giszmo has joined #bitcoin-core-dev
1872016-04-19T12:08:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1882016-04-19T12:17:28  *** jtimon has joined #bitcoin-core-dev
1892016-04-19T12:19:58  *** assder has quit IRC
1902016-04-19T12:19:59  *** cjcj has quit IRC
1912016-04-19T12:22:52  *** jtimon has quit IRC
1922016-04-19T12:42:14  *** assder has joined #bitcoin-core-dev
1932016-04-19T12:42:40  *** jtimon has joined #bitcoin-core-dev
1942016-04-19T12:44:59  *** galileopy has quit IRC
1952016-04-19T12:58:52  <GitHub84> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/187186b0fe03...0e6fd5e4af31
1962016-04-19T12:58:53  <GitHub84> bitcoin/master fa942c7 Joao Fonseca: Move method to check matches within arrays on util.py
1972016-04-19T12:58:53  <GitHub84> bitcoin/master 5d217de Joao Fonseca: Add test to check spendable and unspendable UTXO on RPC listunspent
1982016-04-19T12:58:54  <GitHub84> bitcoin/master 0e6fd5e Wladimir J. van der Laan: Merge #7822: Add listunspent() test for spendable/unspendable UTXO...
1992016-04-19T12:59:02  <GitHub40> [bitcoin] laanwj closed pull request #7822: Add listunspent() test for spendable/unspendable UTXO (master...support/add-test-listunspent) https://github.com/bitcoin/bitcoin/pull/7822
2002016-04-19T13:32:25  *** Amnez777 has quit IRC
2012016-04-19T13:39:03  *** cryptapus_ has joined #bitcoin-core-dev
2022016-04-19T13:39:15  *** cryptapus_ is now known as cryptapus
2032016-04-19T13:45:05  <GitHub37> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e6fd5e4af31...a1eb344ba8f4
2042016-04-19T13:45:07  <GitHub37> bitcoin/master de821d5 Jonas Schnelli: [ZMQ] refactor message string
2052016-04-19T13:45:07  <GitHub37> bitcoin/master 0b25a9f Jonas Schnelli: [ZMQ] append a message sequence number to every ZMQ notification
2062016-04-19T13:45:07  <GitHub37> bitcoin/master a1eb344 Wladimir J. van der Laan: Merge #7762: [ZMQ] append a message sequence number to every ZMQ notification...
2072016-04-19T13:45:11  <GitHub76> [bitcoin] laanwj closed pull request #7762: [ZMQ] append a message sequence number to every ZMQ notification (master...2016/03/zmq_seq) https://github.com/bitcoin/bitcoin/pull/7762
2082016-04-19T13:47:31  *** murch has joined #bitcoin-core-dev
2092016-04-19T13:50:35  *** Guyver2 has joined #bitcoin-core-dev
2102016-04-19T13:51:37  *** TomMc has joined #bitcoin-core-dev
2112016-04-19T13:52:34  *** cryptapus has quit IRC
2122016-04-19T13:58:21  *** BashCo has quit IRC
2132016-04-19T13:58:56  *** zooko has joined #bitcoin-core-dev
2142016-04-19T13:59:07  *** cryptapus has joined #bitcoin-core-dev
2152016-04-19T13:59:07  *** cryptapus has joined #bitcoin-core-dev
2162016-04-19T14:08:50  *** galileopy has joined #bitcoin-core-dev
2172016-04-19T14:11:19  <GitHub29> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1eb344ba8f4...04a29373571d
2182016-04-19T14:11:19  <GitHub29> bitcoin/master fabbf80 MarcoFalke: [ui] Move InitError, InitWarning, AmountErrMsg
2192016-04-19T14:11:20  <GitHub29> bitcoin/master fa10ce6 MarcoFalke: Move ui_interface.cpp to libbitcoin_server_a_SOURCES...
2202016-04-19T14:11:20  <GitHub29> bitcoin/master 04a2937 Wladimir J. van der Laan: Merge #7787: [Moveonly] Create ui_interface.cpp...
2212016-04-19T14:11:24  <GitHub145> [bitcoin] laanwj closed pull request #7787: [Moveonly] Create ui_interface.cpp (master...Mf1604-move-ui-helpers) https://github.com/bitcoin/bitcoin/pull/7787
2222016-04-19T14:20:00  *** BashCo has joined #bitcoin-core-dev
2232016-04-19T14:21:58  *** mkarrer has joined #bitcoin-core-dev
2242016-04-19T14:33:58  <NicolasDorier> I was investigating https://github.com/sipa/bitcoin/issues/73
2252016-04-19T14:34:12  <NicolasDorier> it seems the error does not come from the segwit branch, but is a current bug
2262016-04-19T14:34:28  <NicolasDorier> basically, sendtoaddress is called in rpc
2272016-04-19T14:34:59  <NicolasDorier> between the call to CWallet::CreateTransaction and CWallet::CommitTransaction, there can be a reorg resulting in a smaller chain
2282016-04-19T14:35:18  <NicolasDorier> if it happens, the CommitTransaction will fails because of nLockTime
2292016-04-19T14:35:30  *** galileopy has quit IRC
2302016-04-19T14:35:35  <NicolasDorier> however, when the next block is found the "failed transaction" get broadcasted
2312016-04-19T14:35:48  <NicolasDorier> this may result in people sending twice the money by mistake.
2322016-04-19T14:36:07  <NicolasDorier> I noticed that CreateTransaction use chainActive without holding cs_main
2332016-04-19T14:36:22  <sipa> ho!
2342016-04-19T14:37:05  <NicolasDorier> nor any parent, it seems
2352016-04-19T14:37:28  <NicolasDorier> relevant link : https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365
2362016-04-19T14:39:17  <NicolasDorier> I think the way to fix this bug is to lock the chain at the caller method
2372016-04-19T14:39:47  <NicolasDorier> which is SendMoney (https://github.com/bitcoin/bitcoin/blob/d28995018003db699b0b528f5e97e9002c3feeb9/src/wallet/rpcwallet.cpp#L365)
2382016-04-19T14:40:20  <NicolasDorier> however, ::CommitTransaction get the lock. I don't know if we can lock two times cs_main in the same thread.
2392016-04-19T14:40:48  <sipa> yes, we can
2402016-04-19T14:40:54  <sipa> it's a recursive lock
2412016-04-19T14:41:52  <NicolasDorier> ok so that should do it. I'll try that and ask T909 to try again
2422016-04-19T14:44:31  <NicolasDorier> mmmh no I'm wrong
2432016-04-19T14:44:38  <NicolasDorier> the lock is taken in the top rpc method
2442016-04-19T14:44:43  <NicolasDorier> so not that :/
2452016-04-19T14:49:58  <NicolasDorier> mmh, https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2012
2462016-04-19T14:50:10  <NicolasDorier> there is one chance on 100 that the transaction is not final it seems
2472016-04-19T14:50:21  <NicolasDorier> ah no...
2482016-04-19T14:50:53  <NicolasDorier> since it should be included in next block seems I'm wrong on the cause
2492016-04-19T14:57:35  *** Amnez777 has joined #bitcoin-core-dev
2502016-04-19T14:58:06  <sipa> NicolasDorier: where does this 1 in 100 number come from?
2512016-04-19T14:58:26  <NicolasDorier> sipa: https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2019
2522016-04-19T14:58:50  <NicolasDorier> in the case of the bug we got 0
2532016-04-19T14:59:46  <sipa> that branch has a chance of 1 in 100 to trigger
2542016-04-19T14:59:56  <sipa> so there is a chance of 90.1%
2552016-04-19T15:00:08  <sipa> that nLocktime equals the current height
2562016-04-19T15:00:25  *** zooko has quit IRC
2572016-04-19T15:00:30  <sipa> and in that case it should still be acceptable to the mempool (which uses chainactive+1 to finality check)
2582016-04-19T15:01:08  <NicolasDorier> oh yes indeed... ok I continue searching...
2592016-04-19T15:01:59  *** cryptapus has quit IRC
2602016-04-19T15:03:38  <morcos> gmaxwell: i took a look at 4 different nodes, i didn't see much consistency in how many notfounds i received.  3 of the nodes were generally quite small, a few hundred a day.
2612016-04-19T15:04:47  <morcos> gmaxwell: one of the nodes received several thousand a day and 19k on 4-16, but still received 6-7k on 4-10 and 4-11, so it seems more variance than a clear increase
2622016-04-19T15:05:01  <morcos> might be interesting to understand what causes more of them
2632016-04-19T15:06:32  *** murch has quit IRC
2642016-04-19T15:06:36  *** frankenmint has joined #bitcoin-core-dev
2652016-04-19T15:08:19  *** SteveTaylor has joined #bitcoin-core-dev
2662016-04-19T15:08:33  *** pedrobranco has joined #bitcoin-core-dev
2672016-04-19T15:13:59  *** cryptapus has joined #bitcoin-core-dev
2682016-04-19T15:14:00  *** cryptapus has joined #bitcoin-core-dev
2692016-04-19T15:20:34  <NicolasDorier> btw, I think it is risky to add a transaction to the wallet before it has been accepted by the mempool (https://github.com/bitcoin/bitcoin/blob/04a29373571d44be36bd099c3b3ec3cda89e99d1/src/wallet/wallet.cpp#L2285)
2702016-04-19T15:21:25  <sipa> i agree
2712016-04-19T15:22:35  *** galileopy has joined #bitcoin-core-dev
2722016-04-19T15:22:49  <GitHub10> [bitcoin] sipa opened pull request #7910: Segregated witness (master...segwit-master) https://github.com/bitcoin/bitcoin/pull/7910
2732016-04-19T15:22:54  <morcos> NicolasDorier: sipa: why is that necessarily risky?  it seems to me we should move the other direction.  separating wh
2742016-04-19T15:22:57  <morcos> woo hoo!
2752016-04-19T15:23:30  *** pedrobranco has quit IRC
2762016-04-19T15:23:32  <morcos> (continued) ether a tx is broadcast or in the mempool from its inclusion in your wallet.  And then having some way of informing the wallet of its status
2772016-04-19T15:23:38  *** pedrobranco has joined #bitcoin-core-dev
2782016-04-19T15:24:00  <GitHub166> [bitcoin] jonasschnelli closed pull request #7404: [WIP] Segregated Witness (0.12...segwit) https://github.com/bitcoin/bitcoin/pull/7404
2792016-04-19T15:24:51  <jonasschnelli> \o/
2802016-04-19T15:25:11  <sipa> ugh, github messes up the commit list
2812016-04-19T15:25:16  <NicolasDorier> morcos: there is this bug https://github.com/sipa/bitcoin/issues/73, I'll find out what happen later, but the problem is that the transaction is rejected by mempool but still added to wallet transactions. Then after one block, the transaction is rebroadcasted but this time accepted to mempool. The caller of sendtoaddress got an error and thought the money
2822016-04-19T15:25:17  <NicolasDorier> was not sent, and retried the command, resulting in sending money two times
2832016-04-19T15:25:56  <sipa> morcos: i guess it could be 1) "probe" the mempool whether it would be accepted 2) add to wallet 3) broadcast
2842016-04-19T15:26:15  <morcos> sipa: awesome work on segwit, i guess i know where i'm spending my time this week
2852016-04-19T15:26:17  <NicolasDorier> "probing the mempool" could be also useful for verifytransaction
2862016-04-19T15:27:11  <sipa> i'm not sure whether i should maintain both the 0.12 and master branch independently now, or just work on master, get that review, and then backport again
2872016-04-19T15:27:12  <morcos> NicolasDorier: ah, ok so i agree, that we need to clean up the behavior, hadn't read that issue before.  but it definitely shouldn't be ambigious whether a tx is broadcast or not.
2882016-04-19T15:27:41  <morcos> sipa: do you have both branches ready now?
2892016-04-19T15:28:05  <sipa> yes
2902016-04-19T15:28:09  <morcos> i kind of think we should have as much of a merge freeze as possible and just all buckle down to review segwit
2912016-04-19T15:28:17  <morcos> so that would speak to getting both branches out now
2922016-04-19T15:28:55  *** galileopy has quit IRC
2932016-04-19T15:29:11  <morcos> it would be nice if the 0.12 branch got some review from fresh eyes, instead of people just trying to verify its a correct backport.  with this much code thats prone to failure
2942016-04-19T15:29:14  <sipa> the reasoning against two branches is that it has a higher chance of resulting in unreviewed mistakes in 0.12
2952016-04-19T15:29:46  <sipa> the reasoning against just master-based review is that it may interfere with for example the py3 changes
2962016-04-19T15:30:51  <morcos> personally i think it makes sense if some of us concentrate review on 0.12 and then take a look at master to see if we think its a proper forward port, and some of us work in the opposite direction.
2972016-04-19T15:31:10  <morcos> whenever a bug is found or a change made in one..  then you can port it to the other
2982016-04-19T15:31:28  <morcos> but it should really be up to you and wumpus i guess to figrue out how to best do this
2992016-04-19T15:31:50  <morcos> merging other stuff in the middle, just seems like a mistake though...  lets get segwit merged
3002016-04-19T15:32:17  *** cryptocoder has joined #bitcoin-core-dev
3012016-04-19T15:32:56  <sipa> open question: do i "fake" the author dates of the commits to make github show it in the correct order?
3022016-04-19T15:34:04  <morcos> sipa: meh
3032016-04-19T16:10:20  <instagibbs> sipa, you doubled the "Since github shows" statement
3042016-04-19T16:11:04  <sipa> instagibbs: thanks, fixed
3052016-04-19T16:11:41  *** frankenmint has quit IRC
3062016-04-19T16:12:02  *** frankenmint has joined #bitcoin-core-dev
3072016-04-19T16:13:32  <instagibbs> really glad to see this pull
3082016-04-19T16:23:45  *** Guyver2_ has joined #bitcoin-core-dev
3092016-04-19T16:26:47  *** Guyver2 has quit IRC
3102016-04-19T16:26:49  *** Guyver2_ is now known as Guyver2
3112016-04-19T16:28:48  *** cryptocoder has quit IRC
3122016-04-19T16:34:30  *** cryptocoder has joined #bitcoin-core-dev
3132016-04-19T16:39:27  *** amiller_ has quit IRC
3142016-04-19T16:39:34  <btcdrak> nice work sipa!
3152016-04-19T16:40:45  *** Guyver2_ has joined #bitcoin-core-dev
3162016-04-19T16:41:07  *** Guest87203 has joined #bitcoin-core-dev
3172016-04-19T16:44:52  *** Guyver2 has quit IRC
3182016-04-19T16:45:00  *** Guyver2_ is now known as Guyver2
3192016-04-19T16:47:08  *** laurentmt has joined #bitcoin-core-dev
3202016-04-19T16:47:46  *** laurentmt has quit IRC
3212016-04-19T16:49:28  <Chris_Stewart_5> ^^^^\
3222016-04-19T16:54:37  <instagibbs> can someone share their segnet node ip/seed?
3232016-04-19T16:54:55  <instagibbs> also, how to run segnet regtest?
3242016-04-19T16:55:06  <sipa> bitcoin.sipa.be is a node, and run with -segnet
3252016-04-19T16:55:45  <instagibbs> oh nevermind, it managed to find peers after a bit
3262016-04-19T16:56:32  *** Guyver2 has quit IRC
3272016-04-19T17:02:41  *** Amnez777 has quit IRC
3282016-04-19T17:07:59  *** Guyver2 has joined #bitcoin-core-dev
3292016-04-19T17:08:31  *** Amnez777 has joined #bitcoin-core-dev
3302016-04-19T17:17:11  *** paveljanik has joined #bitcoin-core-dev
3312016-04-19T17:17:11  *** paveljanik has joined #bitcoin-core-dev
3322016-04-19T17:24:07  *** AaronvanW has quit IRC
3332016-04-19T17:53:41  *** slackircbridge has joined #bitcoin-core-dev
3342016-04-19T18:00:33  *** zooko has joined #bitcoin-core-dev
3352016-04-19T18:05:28  *** galileopy has joined #bitcoin-core-dev
3362016-04-19T18:11:19  *** cryptapus__ has joined #bitcoin-core-dev
3372016-04-19T18:15:11  *** cryptapus has quit IRC
3382016-04-19T18:16:24  *** cryptapus__ is now known as cryptapus
3392016-04-19T18:19:29  *** d_t has joined #bitcoin-core-dev
3402016-04-19T18:19:55  *** cryptapus__ has joined #bitcoin-core-dev
3412016-04-19T18:23:27  *** cryptapus has quit IRC
3422016-04-19T18:24:02  *** cryptapus__ is now known as cryptapus
3432016-04-19T18:29:40  *** pedrobranco has quit IRC
3442016-04-19T18:30:58  *** cryptapus has quit IRC
3452016-04-19T18:31:07  *** cryptapus has joined #bitcoin-core-dev
3462016-04-19T18:31:08  *** cryptapus has joined #bitcoin-core-dev
3472016-04-19T18:33:16  *** cryptapus__ has joined #bitcoin-core-dev
3482016-04-19T18:33:16  *** cryptapus__ has joined #bitcoin-core-dev
3492016-04-19T18:35:54  *** cryptapus_ has joined #bitcoin-core-dev
3502016-04-19T18:35:54  *** cryptapus_ has joined #bitcoin-core-dev
3512016-04-19T18:36:38  *** cryptapus has quit IRC
3522016-04-19T18:37:05  *** arowser has quit IRC
3532016-04-19T18:37:21  *** arowser has joined #bitcoin-core-dev
3542016-04-19T18:39:19  *** cryptapus__ has quit IRC
3552016-04-19T18:40:52  <GitHub181> [bitcoin] theuni opened pull request #7911: leveldb: integrate leveldb into our buildsystem (master...leveldb-integration) https://github.com/bitcoin/bitcoin/pull/7911
3562016-04-19T18:48:26  *** d_t has quit IRC
3572016-04-19T18:49:09  *** pedrobranco has joined #bitcoin-core-dev
3582016-04-19T18:53:47  *** pedrobranco has quit IRC
3592016-04-19T18:59:41  *** zooko has quit IRC
3602016-04-19T19:06:05  *** roasbeef_ is now known as roasbeef
3612016-04-19T19:08:34  *** TomMc has quit IRC
3622016-04-19T19:26:08  *** frankenmint has quit IRC
3632016-04-19T19:26:47  *** moli has joined #bitcoin-core-dev
3642016-04-19T19:29:16  *** molly has quit IRC
3652016-04-19T19:32:05  *** molz has joined #bitcoin-core-dev
3662016-04-19T19:34:46  *** moli has quit IRC
3672016-04-19T19:37:12  *** frankenmint has joined #bitcoin-core-dev
3682016-04-19T19:38:08  *** cryptapus_ is now known as cryptapus
3692016-04-19T19:49:51  <sdaftuar> Should BIP61 be interpreted to mean that reject messages with code 0x01 (REJECT_MALFORMED) should NOT have a hash payload, even if the message that triggered the reject is "block" or "tx"?
3702016-04-19T19:57:10  *** TomMc has joined #bitcoin-core-dev
3712016-04-19T20:03:59  *** TomMc has quit IRC
3722016-04-19T20:04:34  *** cryptapus has quit IRC
3732016-04-19T20:10:47  *** Guyver2 has quit IRC
3742016-04-19T20:16:31  *** AaronvanW has joined #bitcoin-core-dev
3752016-04-19T20:23:01  *** mrkent_ has joined #bitcoin-core-dev
3762016-04-19T20:35:47  *** LeMiner has joined #bitcoin-core-dev
3772016-04-19T20:36:31  <GitHub79> [bitcoin] sdaftuar opened pull request #7912: Tests: Fix deserialization of reject messages (master...fix-mininode-reject) https://github.com/bitcoin/bitcoin/pull/7912
3782016-04-19T20:55:30  *** jannes has quit IRC
3792016-04-19T21:01:45  *** mrkent__ has joined #bitcoin-core-dev
3802016-04-19T21:01:53  *** mrkent_ has quit IRC
3812016-04-19T21:06:57  <GitHub192> [bitcoin] yurizhykin opened pull request #7913: Fix for incorrect locking in GetPubKey() (keystore.cpp) (master...getpubkey-locking-fix) https://github.com/bitcoin/bitcoin/pull/7913
3822016-04-19T21:08:18  *** zooko has joined #bitcoin-core-dev
3832016-04-19T21:13:33  *** mrkent_ has joined #bitcoin-core-dev
3842016-04-19T21:16:31  *** mrkent__ has quit IRC
3852016-04-19T21:22:15  *** TomMc has joined #bitcoin-core-dev
3862016-04-19T21:30:00  *** frankenmint has quit IRC
3872016-04-19T21:32:52  *** schmidty has joined #bitcoin-core-dev
3882016-04-19T21:54:30  *** harding has quit IRC
3892016-04-19T21:55:13  *** harding has joined #bitcoin-core-dev
3902016-04-19T22:05:09  *** grimescapes has joined #bitcoin-core-dev
3912016-04-19T22:15:20  *** xabbix__ has quit IRC
3922016-04-19T22:19:24  *** Guest87203 has quit IRC
3932016-04-19T22:19:38  *** AaronvanW has quit IRC
3942016-04-19T22:25:41  *** xabbix__ has joined #bitcoin-core-dev
3952016-04-19T22:26:38  *** Guest53522 has joined #bitcoin-core-dev
3962016-04-19T22:29:16  *** frankenmint has joined #bitcoin-core-dev
3972016-04-19T23:07:43  *** lightningbot has joined #bitcoin-core-dev
3982016-04-19T23:08:52  *** aj has joined #bitcoin-core-dev
3992016-04-19T23:11:35  *** randy-waterhouse has joined #bitcoin-core-dev
4002016-04-19T23:32:53  *** frankenmint has joined #bitcoin-core-dev