1 2016-05-30T00:21:14  *** Ylbam has quit IRC
  2 2016-05-30T00:23:57  *** alpalp has quit IRC
  3 2016-05-30T01:07:24  *** belcher has quit IRC
  4 2016-05-30T01:17:05  *** belcher has joined #bitcoin-core-dev
  5 2016-05-30T01:27:58  *** Squidicc has joined #bitcoin-core-dev
  6 2016-05-30T01:28:22  *** xiangfu has joined #bitcoin-core-dev
  7 2016-05-30T01:30:08  *** Squidicuz has quit IRC
  8 2016-05-30T01:32:36  *** jarret has joined #bitcoin-core-dev
  9 2016-05-30T01:35:12  *** dermoth has quit IRC
 10 2016-05-30T01:36:00  *** dermoth has joined #bitcoin-core-dev
 11 2016-05-30T01:44:46  *** Squidicc is now known as squidicuz
 12 2016-05-30T02:04:03  *** Chris_Stewart_5 has quit IRC
 13 2016-05-30T02:15:21  *** fengling has joined #bitcoin-core-dev
 14 2016-05-30T02:22:59  *** randy-waterhouse has joined #bitcoin-core-dev
 15 2016-05-30T02:37:30  *** cryptapus_afk has quit IRC
 16 2016-05-30T03:13:16  *** cryptapus_afk has joined #bitcoin-core-dev
 17 2016-05-30T03:20:26  *** Giszmo1 has joined #bitcoin-core-dev
 18 2016-05-30T03:20:26  *** Giszmo has quit IRC
 19 2016-05-30T03:28:56  *** belcher has quit IRC
 20 2016-05-30T03:39:01  *** Alopex has quit IRC
 21 2016-05-30T03:40:06  *** Alopex has joined #bitcoin-core-dev
 22 2016-05-30T03:49:50  *** shesek has joined #bitcoin-core-dev
 23 2016-05-30T04:29:41  *** fengling has quit IRC
 24 2016-05-30T04:40:20  *** molz has joined #bitcoin-core-dev
 25 2016-05-30T04:40:49  *** achow101 has quit IRC
 26 2016-05-30T04:42:55  *** moli has quit IRC
 27 2016-05-30T04:47:41  *** [Author] has quit IRC
 28 2016-05-30T04:51:06  *** fengling has joined #bitcoin-core-dev
 29 2016-05-30T05:06:09  *** [Author] has joined #bitcoin-core-dev
 30 2016-05-30T05:10:38  *** molz has quit IRC
 31 2016-05-30T05:10:59  *** molz has joined #bitcoin-core-dev
 32 2016-05-30T05:19:01  *** Alopex has quit IRC
 33 2016-05-30T05:20:06  *** Alopex has joined #bitcoin-core-dev
 34 2016-05-30T05:30:01  *** Alopex has quit IRC
 35 2016-05-30T05:31:07  *** Alopex has joined #bitcoin-core-dev
 36 2016-05-30T06:06:45  *** Giszmo1 has quit IRC
 37 2016-05-30T06:14:57  *** bustd_soket has quit IRC
 38 2016-05-30T06:15:11  *** assder has joined #bitcoin-core-dev
 39 2016-05-30T06:16:00  *** BashCo has quit IRC
 40 2016-05-30T06:23:44  *** randy-waterhouse has quit IRC
 41 2016-05-30T06:27:01  *** bustd_soket has joined #bitcoin-core-dev
 42 2016-05-30T06:33:25  *** grassass has joined #bitcoin-core-dev
 43 2016-05-30T06:48:52  *** grassass has quit IRC
 44 2016-05-30T06:49:11  *** randy-waterhouse has joined #bitcoin-core-dev
 45 2016-05-30T06:52:12  *** paveljanik has quit IRC
 46 2016-05-30T06:54:11  *** BashCo has joined #bitcoin-core-dev
 47 2016-05-30T07:15:24  *** BashCo has quit IRC
 48 2016-05-30T07:27:24  *** p15 has joined #bitcoin-core-dev
 49 2016-05-30T07:28:11  *** p15 has quit IRC
 50 2016-05-30T07:33:16  *** Naphex has joined #bitcoin-core-dev
 51 2016-05-30T07:34:01  *** fengling has quit IRC
 52 2016-05-30T07:34:23  *** gevs_ has quit IRC
 53 2016-05-30T07:34:28  *** fengling has joined #bitcoin-core-dev
 54 2016-05-30T07:36:37  <wumpus> interesting, I have a bitcoind that hangs at "Loading banlist..."
 55 2016-05-30T07:37:33  <wumpus> well it responds to RPC requests with that
 56 2016-05-30T07:39:44  <wumpus> it does actually seem to be syncing with the network
 57 2016-05-30T07:40:47  <wumpus> ok initialization completed now, seems to be a case of misreporting what it is doing
 58 2016-05-30T07:41:46  *** fengling_ has joined #bitcoin-core-dev
 59 2016-05-30T07:42:21  *** fengling has quit IRC
 60 2016-05-30T07:53:48  *** gevs has joined #bitcoin-core-dev
 61 2016-05-30T07:53:59  *** gevs has joined #bitcoin-core-dev
 62 2016-05-30T07:55:56  *** Ylbam has joined #bitcoin-core-dev
 63 2016-05-30T08:08:07  *** G1lius has joined #bitcoin-core-dev
 64 2016-05-30T08:08:14  *** randy-waterhouse has quit IRC
 65 2016-05-30T08:15:01  *** Alopex has quit IRC
 66 2016-05-30T08:16:06  *** Alopex has joined #bitcoin-core-dev
 67 2016-05-30T08:28:06  *** randy-waterhouse has joined #bitcoin-core-dev
 68 2016-05-30T08:45:32  *** Guyver2 has joined #bitcoin-core-dev
 69 2016-05-30T09:05:21  *** justanotheruser has quit IRC
 70 2016-05-30T09:07:49  *** p15 has joined #bitcoin-core-dev
 71 2016-05-30T09:08:06  *** randy-waterhouse has quit IRC
 72 2016-05-30T09:12:11  *** AaronvanW has joined #bitcoin-core-dev
 73 2016-05-30T09:12:12  *** AaronvanW has quit IRC
 74 2016-05-30T09:12:12  *** AaronvanW has joined #bitcoin-core-dev
 75 2016-05-30T09:35:02  *** jannes has joined #bitcoin-core-dev
 76 2016-05-30T09:46:04  *** p15 has quit IRC
 77 2016-05-30T09:49:41  *** fengling_ has quit IRC
 78 2016-05-30T09:56:12  *** fengling_ has joined #bitcoin-core-dev
 79 2016-05-30T09:58:39  *** laurentmt has joined #bitcoin-core-dev
 80 2016-05-30T09:58:59  *** laurentmt has quit IRC
 81 2016-05-30T10:01:01  *** fengling_ has quit IRC
 82 2016-05-30T10:07:16  *** fengling_ has joined #bitcoin-core-dev
 83 2016-05-30T10:14:26  <GitHub101> [bitcoin] jonasnick opened pull request #8118: Reduce unnecessary hashing in signrawtransaction (master...faster-signraw) https://github.com/bitcoin/bitcoin/pull/8118
 84 2016-05-30T10:39:45  <GitHub154> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6ff2c8d29f6b...61b86848b163
 85 2016-05-30T10:39:45  <GitHub154> bitcoin/master 619d569 Pieter Wuille: Benchmark SipHash
 86 2016-05-30T10:39:46  <GitHub154> bitcoin/master 61b8684 Wladimir J. van der Laan: Merge #8111: Benchmark SipHash...
 87 2016-05-30T10:40:00  <GitHub166> [bitcoin] laanwj closed pull request #8111: Benchmark SipHash (master...benchsiphash) https://github.com/bitcoin/bitcoin/pull/8111
 88 2016-05-30T10:40:17  <GitHub141> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61b86848b163...989df7ecf3a1
 89 2016-05-30T10:40:17  <GitHub141> bitcoin/master fc95f6e Chris Moore: fix typo in help text...
 90 2016-05-30T10:40:18  <GitHub141> bitcoin/master 989df7e Wladimir J. van der Laan: Merge #7896: fix typo in help text...
 91 2016-05-30T10:40:22  <GitHub103> [bitcoin] laanwj closed pull request #7896: fix typo in help text (master...patch-1) https://github.com/bitcoin/bitcoin/pull/7896
 92 2016-05-30T10:43:20  *** BashCo has joined #bitcoin-core-dev
 93 2016-05-30T10:46:51  *** G1lius has quit IRC
 94 2016-05-30T10:58:03  *** JackH has quit IRC
 95 2016-05-30T11:06:19  <GitHub29> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/989df7ecf3a1...52b803e09b16
 96 2016-05-30T11:06:19  <GitHub29> bitcoin/master 5fac1f3 Yuri Zhykin: bench: Added base58 encoding/decoding benchmarks
 97 2016-05-30T11:06:20  <GitHub29> bitcoin/master 52b803e Wladimir J. van der Laan: Merge #8107: bench: Added base58 encoding/decoding benchmarks...
 98 2016-05-30T11:06:28  <GitHub51> [bitcoin] laanwj closed pull request #8107: bench: Added base58 encoding/decoding benchmarks (master...benchmarks) https://github.com/bitcoin/bitcoin/pull/8107
 99 2016-05-30T11:20:51  *** laurentmt has joined #bitcoin-core-dev
100 2016-05-30T11:29:42  <GitHub138> [bitcoin] fanquake opened pull request #8119: [trivial] Add .DSYM to .gitignore (master...ignore_debug) https://github.com/bitcoin/bitcoin/pull/8119
101 2016-05-30T11:30:37  *** xiangfu has quit IRC
102 2016-05-30T11:42:50  *** laurentmt has quit IRC
103 2016-05-30T11:44:01  *** fengling_ has quit IRC
104 2016-05-30T11:55:42  *** fengling_ has joined #bitcoin-core-dev
105 2016-05-30T12:00:29  *** belcher has joined #bitcoin-core-dev
106 2016-05-30T12:05:41  *** fengling_ has quit IRC
107 2016-05-30T12:12:10  *** bustd_soket has quit IRC
108 2016-05-30T12:17:42  *** bustd_soket has joined #bitcoin-core-dev
109 2016-05-30T12:28:23  *** Squidicc has joined #bitcoin-core-dev
110 2016-05-30T12:31:34  *** squidicuz has quit IRC
111 2016-05-30T12:34:57  *** dermoth has quit IRC
112 2016-05-30T12:35:38  *** dermoth has joined #bitcoin-core-dev
113 2016-05-30T12:45:56  <GitHub15> [bitcoin] fanquake opened pull request #8121: [Doc] Update implemented BIPs list (master...missing_bips) https://github.com/bitcoin/bitcoin/pull/8121
114 2016-05-30T13:20:03  *** frankenmint has joined #bitcoin-core-dev
115 2016-05-30T13:27:16  *** frankenmint has quit IRC
116 2016-05-30T13:31:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
117 2016-05-30T13:37:42  *** Chris_Stewart_5 has quit IRC
118 2016-05-30T13:39:52  *** G1lius has joined #bitcoin-core-dev
119 2016-05-30T13:40:55  <GitHub73> [bitcoin] sipa opened pull request #8123: Use std::atomic for fRequestShutdown and fReopenDebugLog (master...notsigbutatomic) https://github.com/bitcoin/bitcoin/pull/8123
120 2016-05-30T13:45:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
121 2016-05-30T13:57:14  *** frankenmint has joined #bitcoin-core-dev
122 2016-05-30T14:00:15  <GitHub196> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/52b803e09b16...950be19727a5
123 2016-05-30T14:00:16  <GitHub196> bitcoin/master fa2637a Pieter Wuille: Always require OS randomness when generating secret keys
124 2016-05-30T14:00:16  <GitHub196> bitcoin/master 628cf14 Pieter Wuille: Don't use assert for catching randomness failures
125 2016-05-30T14:00:17  <GitHub196> bitcoin/master 950be19 Pieter Wuille: Merge #7891: Always require OS randomness when generating secret keys...
126 2016-05-30T14:00:17  <GitHub132> [bitcoin] sipa closed pull request #7891: Always require OS randomness when generating secret keys (master...betterrng) https://github.com/bitcoin/bitcoin/pull/7891
127 2016-05-30T14:13:57  *** tucenaber has quit IRC
128 2016-05-30T14:17:54  *** Chris_Stewart_5 has quit IRC
129 2016-05-30T14:29:39  *** Giszmo has joined #bitcoin-core-dev
130 2016-05-30T14:33:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
131 2016-05-30T14:38:43  *** justanotheruser has joined #bitcoin-core-dev
132 2016-05-30T14:54:06  *** achow101 has joined #bitcoin-core-dev
133 2016-05-30T15:24:05  *** TomMc has joined #bitcoin-core-dev
134 2016-05-30T15:30:04  *** rubensayshi has joined #bitcoin-core-dev
135 2016-05-30T15:43:55  <gmaxwell> \O/ (randomness)
136 2016-05-30T15:48:03  *** frankenmint has quit IRC
137 2016-05-30T15:53:35  *** Chris_Stewart_5 has quit IRC
138 2016-05-30T16:04:20  <GitHub170> [bitcoin] sipa opened pull request #8126: std::shared_ptr based CTransaction storage in mempool (master...sharedmempool) https://github.com/bitcoin/bitcoin/pull/8126
139 2016-05-30T16:05:17  *** murch has joined #bitcoin-core-dev
140 2016-05-30T16:06:29  *** TomMc has quit IRC
141 2016-05-30T16:09:15  <gmaxwell> \O/
142 2016-05-30T16:12:41  <luke-jr> O.o
143 2016-05-30T16:14:27  <sipa> ^^
144 2016-05-30T16:17:11  <sipa> gmaxwell: it also conflicts with a few of your PRs, but it should simplify them
145 2016-05-30T16:18:14  <gmaxwell> I don't mind.
146 2016-05-30T16:18:51  <btcdrak> a rebase is a small price to pay for randomness
147 2016-05-30T16:19:07  <btcdrak> the new currency shall be called rebases.
148 2016-05-30T16:19:37  <gmaxwell> sipa: Is CTxMempool::CompareDepthAndScore dead code after the change that puts int in the Comparitor directly?
149 2016-05-30T16:19:55  <luke-jr> might be useful to have a typedef though?
150 2016-05-30T16:20:18  <gmaxwell> btcdrak: Sipa and I were commenting there about the shared_ptr change.
151 2016-05-30T16:20:46  <luke-jr> CTransactionRef or something?
152 2016-05-30T16:21:37  <gmaxwell> I kinda like knowing that its a shared_ptr, but... nevermind my taste.
153 2016-05-30T16:22:16  <luke-jr> I don't feel strongly about this, was mainly thinking if we ever had to go back to pre-C++11 for some reason
154 2016-05-30T16:22:26  <luke-jr> which seems unlikely
155 2016-05-30T16:24:15  <sipa> luke-jr: sounds fine... std::shared_ptr<const Ctransaction> is a bit awkward to type
156 2016-05-30T16:24:27  <sipa> on the aother hand... auto works well :)
157 2016-05-30T16:24:51  <sipa> gmaxwell: no, still used from the heapifier in message handling
158 2016-05-30T16:26:20  <luke-jr> 'auto' certainly tells even less that it is a shared_ptr :P
159 2016-05-30T16:27:02  <luke-jr> so if the long type is going to encourage using auto everywhere, perhaps gmaxwell's goal is actually better suited by a typedef as well
160 2016-05-30T16:27:39  <gmaxwell> I think I'm going to have to give up on editing this code using an editor that can't go and read faraway prototypes.  Auto for return types is pretty useful, but it currently results in me grepping to go find out what the type actually is.
161 2016-05-30T16:28:04  * sipa abandons his rewrite to increase usage of auto
162 2016-05-30T16:28:35  <gmaxwell> I hope not. Don't change what you're doing because of my very C-like preferences.
163 2016-05-30T16:28:51  <sipa> it's a valid argument
164 2016-05-30T16:29:26  <gmaxwell> I think it is best when the return type is obvious. E.g. functions that give you an iterator.
165 2016-05-30T16:29:40  <sipa> we could of course go back to strict hungarian notation :D
166 2016-05-30T16:29:46  * luke-jr understood that as abandoning "a PR intentionally doing nothing but changing stuff to 'auto' where possible"
167 2016-05-30T16:30:00  <sipa> luke-jr: oh, no, i mean improving my current shared_ptr PR
168 2016-05-30T16:30:05  <luke-jr> oh, ok
169 2016-05-30T16:31:21  <gmaxwell> sipa: is there something we can do at shutdown to tell if all the txn have been freed? even in just some debugging build?
170 2016-05-30T16:32:39  <sipa> gmaxwell: how could they not?
171 2016-05-30T16:32:39  <luke-jr> CTx constructor could increment a global, and destructor decrement it?
172 2016-05-30T16:33:01  <sipa> luke-jr: yup
173 2016-05-30T16:33:26  <sipa> an atomic global :)
174 2016-05-30T16:33:36  <sipa> and on every decrement, print to stderr
175 2016-05-30T16:35:00  <gmaxwell> in the current code, they couldn't AFAICT. But if we leaked some object with a shared ptr we'd leak the transaction. It's generally pretty hard to leak shared_ptr... but seems prudent to check for.
176 2016-05-30T16:35:07  <gmaxwell> Yea, that would work.
177 2016-05-30T16:36:52  <sipa> also: the glibc implementation of std::shared_ptr is not readable
178 2016-05-30T16:40:55  <gmaxwell> BlueMatt: thoughts on #8126 ?  would you like to rebase compactblocks on that?
179 2016-05-30T16:46:53  <sipa> with --patience i get much more readable diffs often
180 2016-05-30T16:49:41  *** BashCo has quit IRC
181 2016-05-30T17:16:56  <gmaxwell> http://blog.invisiblethings.org/2016/05/30/build-security.html < on build enviroment security.
182 2016-05-30T17:28:40  *** jtimon has quit IRC
183 2016-05-30T17:38:00  *** BashCo has joined #bitcoin-core-dev
184 2016-05-30T17:39:48  *** frankenmint has joined #bitcoin-core-dev
185 2016-05-30T17:49:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
186 2016-05-30T18:02:13  *** MarcoFalke has joined #bitcoin-core-dev
187 2016-05-30T18:06:45  *** Chris_Stewart_5 has quit IRC
188 2016-05-30T18:08:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
189 2016-05-30T18:10:07  *** frankenmint has quit IRC
190 2016-05-30T18:48:08  *** G1lius has quit IRC
191 2016-05-30T18:59:43  *** moli has joined #bitcoin-core-dev
192 2016-05-30T19:02:03  *** molz has quit IRC
193 2016-05-30T19:02:59  *** molz has joined #bitcoin-core-dev
194 2016-05-30T19:05:10  *** moli has quit IRC
195 2016-05-30T19:05:56  *** frankenmint has joined #bitcoin-core-dev
196 2016-05-30T19:15:05  *** moli has joined #bitcoin-core-dev
197 2016-05-30T19:17:06  *** molz has quit IRC
198 2016-05-30T19:29:01  *** justanotheruser has quit IRC
199 2016-05-30T19:36:20  *** molz has joined #bitcoin-core-dev
200 2016-05-30T19:38:34  *** moli has quit IRC
201 2016-05-30T19:42:15  *** molly has joined #bitcoin-core-dev
202 2016-05-30T19:44:25  *** molz has quit IRC
203 2016-05-30T19:47:35  *** MarcoFalke has left #bitcoin-core-dev
204 2016-05-30T19:49:26  <BlueMatt> gmaxwell: I probably will after its merged, sure
205 2016-05-30T19:50:41  *** moli has joined #bitcoin-core-dev
206 2016-05-30T19:53:31  *** molly has quit IRC
207 2016-05-30T20:00:38  <btcdrak> BlueMatt: could you say so on the ticket so people arent waiting for it?
208 2016-05-30T20:05:41  *** justanotheruser has joined #bitcoin-core-dev
209 2016-05-30T20:10:01  <BlueMatt> btcdrak: who's waiting for what?
210 2016-05-30T20:17:05  <sipa> it shouldn't interfere with review of compact blocks otherwise
211 2016-05-30T20:17:18  <sipa> just the refcounting in the mempool can go away
212 2016-05-30T20:34:10  *** frankenmint has quit IRC
213 2016-05-30T20:37:58  *** kadoban has joined #bitcoin-core-dev
214 2016-05-30T20:44:42  *** justanotheruser has quit IRC
215 2016-05-30T21:03:52  *** AaronvanW has quit IRC
216 2016-05-30T21:10:45  *** murch has quit IRC
217 2016-05-30T21:27:49  *** Guyver2 has quit IRC
218 2016-05-30T21:32:59  <gmaxwell> BlueMatt: you might want to review sipa's patch (or try the rebase) to make sure it won't get in your way.
219 2016-05-30T21:35:17  *** frankenmint has joined #bitcoin-core-dev
220 2016-05-30T21:35:36  <sipa> i'll do the rebase for you, if it helps things forward
221 2016-05-30T21:41:16  *** frankenmint has quit IRC
222 2016-05-30T21:45:34  *** spudowiar has quit IRC
223 2016-05-30T21:49:20  *** spudowiar has joined #bitcoin-core-dev
224 2016-05-30T21:51:28  *** jarret has quit IRC
225 2016-05-30T21:58:46  *** slackircbridge has quit IRC
226 2016-05-30T22:00:03  *** slackircbridge has joined #bitcoin-core-dev
227 2016-05-30T22:27:24  <gmaxwell> sipa: might be a good review excercise even if matt doesn't want to use the result.
228 2016-05-30T22:30:21  <gmaxwell> Opinion piece against most uses of unit tests that I think makes some nice points: http://rbcs-us.com/documents/Why-Most-Unit-Testing-is-Waste.pdf  (the biggest exceptions he makes are cases where there is a clear formal defintion of correctness that can be tested against for the function, and also when the tests are realistically able to completely test the function; otherwise he favors system
229 2016-05-30T22:30:27  <gmaxwell> tests and gives arguments from a number of angles).
230 2016-05-30T22:31:15  *** jannes has quit IRC
231 2016-05-30T22:41:28  *** jarret has joined #bitcoin-core-dev
232 2016-05-30T22:46:17  *** jarret has quit IRC
233 2016-05-30T22:46:32  *** jarret has joined #bitcoin-core-dev
234 2016-05-30T22:51:28  *** jarret has quit IRC
235 2016-05-30T22:53:18  *** slackircbridge has quit IRC
236 2016-05-30T22:54:35  *** slackircbridge has joined #bitcoin-core-dev
237 2016-05-30T23:11:08  *** slackircbridge has quit IRC
238 2016-05-30T23:12:25  *** slackircbridge has joined #bitcoin-core-dev
239 2016-05-30T23:20:09  *** justanotheruser has joined #bitcoin-core-dev
240 2016-05-30T23:26:00  *** belcher has quit IRC
241 2016-05-30T23:27:38  *** belcher has joined #bitcoin-core-dev
242 2016-05-30T23:54:28  *** gevs has quit IRC