1 2016-07-17T00:04:39  *** anchow101 has quit IRC
  2 2016-07-17T00:23:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  3 2016-07-17T00:26:42  *** kadoban has quit IRC
  4 2016-07-17T00:38:54  *** spudowiar is now known as FsckFreenode
  5 2016-07-17T00:39:54  *** FsckFreenode is now known as spudowiar
  6 2016-07-17T00:47:11  *** spudowiar has quit IRC
  7 2016-07-17T00:50:10  <GitHub171> [bitcoin] jtimon opened pull request #8348: Trivial: Segwit: Don't call IsWitnessEnabled from ContextualCheckBlock (master...0.12.99-consensus-segwit) https://github.com/bitcoin/bitcoin/pull/8348
  8 2016-07-17T00:57:29  *** netsin has quit IRC
  9 2016-07-17T00:58:07  *** netsin has joined #bitcoin-core-dev
 10 2016-07-17T01:02:34  *** netsin has quit IRC
 11 2016-07-17T01:05:47  *** Ylbam has quit IRC
 12 2016-07-17T01:07:35  *** achow101 has joined #bitcoin-core-dev
 13 2016-07-17T01:16:48  *** netsin has joined #bitcoin-core-dev
 14 2016-07-17T01:35:01  *** Chris_Stewart_5 has quit IRC
 15 2016-07-17T01:35:22  *** Giszmo1 has joined #bitcoin-core-dev
 16 2016-07-17T01:37:11  *** Giszmo has quit IRC
 17 2016-07-17T01:40:24  *** xinxi has joined #bitcoin-core-dev
 18 2016-07-17T01:47:30  *** xinxi has quit IRC
 19 2016-07-17T01:48:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 20 2016-07-17T01:49:03  *** Arnavion has quit IRC
 21 2016-07-17T01:49:07  *** Arnavion3 has joined #bitcoin-core-dev
 22 2016-07-17T01:49:11  *** Arnavion3 is now known as Arnavion
 23 2016-07-17T01:58:49  *** YOU-JI has joined #bitcoin-core-dev
 24 2016-07-17T02:02:09  *** YOU-JI has quit IRC
 25 2016-07-17T02:16:29  *** belcher has quit IRC
 26 2016-07-17T02:17:16  *** belcher has joined #bitcoin-core-dev
 27 2016-07-17T02:19:38  *** belcher has quit IRC
 28 2016-07-17T02:30:16  *** molly has joined #bitcoin-core-dev
 29 2016-07-17T02:33:45  *** molz has quit IRC
 30 2016-07-17T02:35:36  *** Chris_Stewart_5 has quit IRC
 31 2016-07-17T02:53:14  *** YOU-JI has joined #bitcoin-core-dev
 32 2016-07-17T03:00:17  *** netsin has quit IRC
 33 2016-07-17T03:06:43  *** netsin has joined #bitcoin-core-dev
 34 2016-07-17T03:11:19  *** netsin has quit IRC
 35 2016-07-17T03:12:47  *** achow101 has quit IRC
 36 2016-07-17T03:14:48  *** netsin has joined #bitcoin-core-dev
 37 2016-07-17T03:27:41  *** xinxi has joined #bitcoin-core-dev
 38 2016-07-17T03:34:34  *** xinxi has quit IRC
 39 2016-07-17T03:35:09  *** xinxi has joined #bitcoin-core-dev
 40 2016-07-17T03:43:25  <GitHub36> [bitcoin] Tyler-Hardin opened pull request #8349: Qt: Clearer warning about being out of sync (master...issue8060) https://github.com/bitcoin/bitcoin/pull/8349
 41 2016-07-17T04:05:17  *** xinxi has quit IRC
 42 2016-07-17T04:21:58  *** TomMc has quit IRC
 43 2016-07-17T04:35:51  *** YOU-JI has quit IRC
 44 2016-07-17T04:37:50  *** YOU-JI has joined #bitcoin-core-dev
 45 2016-07-17T04:41:25  *** kadoban has joined #bitcoin-core-dev
 46 2016-07-17T04:45:51  *** bustd_soket has quit IRC
 47 2016-07-17T04:58:29  *** bustd_soket has joined #bitcoin-core-dev
 48 2016-07-17T05:20:07  *** jtimon has quit IRC
 49 2016-07-17T05:32:08  *** kadoban has quit IRC
 50 2016-07-17T06:43:11  *** YOU-JI has quit IRC
 51 2016-07-17T07:14:35  *** netsin has quit IRC
 52 2016-07-17T07:15:23  *** netsin has joined #bitcoin-core-dev
 53 2016-07-17T07:18:21  *** xinxi has joined #bitcoin-core-dev
 54 2016-07-17T07:31:24  <phantomcircuit> wumpus, is 0.13 tagged?
 55 2016-07-17T07:33:54  <luke-jr> …
 56 2016-07-17T07:34:04  <luke-jr> of course not, we didn't even do rc1 yet
 57 2016-07-17T08:03:07  *** xinxi has quit IRC
 58 2016-07-17T08:10:45  *** netsin has joined #bitcoin-core-dev
 59 2016-07-17T08:38:09  <phantomcircuit> luke-jr, branched i mean
 60 2016-07-17T08:38:11  <phantomcircuit> words
 61 2016-07-17T08:48:03  *** jron has quit IRC
 62 2016-07-17T08:49:13  *** jron has joined #bitcoin-core-dev
 63 2016-07-17T08:50:36  *** windsok has joined #bitcoin-core-dev
 64 2016-07-17T08:50:54  *** windsok_ has quit IRC
 65 2016-07-17T08:59:01  <btcdrak> not yet
 66 2016-07-17T09:10:06  *** jtimon has joined #bitcoin-core-dev
 67 2016-07-17T09:26:12  <jtimon> NicolasDorier: When it's complete because it does too many things at once and when it's not complete because it's not complete? come on, make up your mind...
 68 2016-07-17T09:27:16  <btcdrak> jtimon: my observation about ISM logic in versionbits.cpp is that it's got nothing to do with versionbits.cpp. its like you're stuffing a piece of code in there because it doesnt have anywhere else to live.
 69 2016-07-17T09:27:38  <gmaxwell> ISM code should all leave now.
 70 2016-07-17T09:27:57  <btcdrak> right, and now it seems useless to preserve that logic since we can just hard code it
 71 2016-07-17T09:28:14  <gmaxwell> I was planning on doing that as soon as we branch.
 72 2016-07-17T09:28:14  <btcdrak> the softforks have happened and are long since burred deep.
 73 2016-07-17T09:28:20  <btcdrak> gmaxwell: +1
 74 2016-07-17T09:28:43  <jtimon> btcdrak: and which of the alternatives I offereded you suggest?
 75 2016-07-17T09:28:45  <gmaxwell> I have the patch done already (this is why I was checking to find out where the last couple softforks activated a month or so ago)-- or I think I have it, might have been in that repo I corrupted.
 76 2016-07-17T09:28:55  <jtimon> hardcoded or not, it has to be somewhere
 77 2016-07-17T09:29:08  <gmaxwell> jtimon: there will be no ISM code.
 78 2016-07-17T09:29:17  <jtimon> I'm open ofr almost anything but main.cpp, please tell me what you like
 79 2016-07-17T09:29:33  <gmaxwell> The code will be gone, it doesn't go anywhere.
 80 2016-07-17T09:29:53  *** G1lius has joined #bitcoin-core-dev
 81 2016-07-17T09:30:19  <gmaxwell> jtimon: we have soffork activations coded in chain paramters. (vDeployments) the places that call ISM are just changed to check that.
 82 2016-07-17T09:30:36  <jtimon> well, at the very least we have to maintain this failure: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3547 don't we?
 83 2016-07-17T09:31:24  <jtimon> gmaxwell: mhmm, not sure I understand, I thought you were going to hardcode a height for activation or something
 84 2016-07-17T09:32:00  <jtimon> btcdrak: where do you think Consensus::GetFlags should be?
 85 2016-07-17T09:33:29  <gmaxwell> jtimon: the if condition on that code just changes to a test of nHeight vs a vDeployments setting.
 86 2016-07-17T09:33:48  <jtimon> but vDeployments uses BIP9
 87 2016-07-17T09:34:20  <gmaxwell> sorry, not vDeployments (I wasn't looking), see:
 88 2016-07-17T09:34:30  <gmaxwell>          consensus.BIP34Height = 227931;
 89 2016-07-17T09:34:31  <gmaxwell>         consensus.BIP34Hash = uint256S("0x000000000000024b89b42a942fe0d9fea3bb44ab7bd1b19115dd6a759c0808b8");
 90 2016-07-17T09:36:05  <gmaxwell> just elements of consensus.  consensus.BIP65Height  yadda yadda.
 91 2016-07-17T09:37:03  <jtimon> yeah, so hardcoding a height for activation, what I was saying
 92 2016-07-17T09:37:13  <btcdrak> jtimon: for flags, why not in consensus.h?
 93 2016-07-17T09:37:23  <gmaxwell> (which also makes block processing a bit faster, as the ISM checks are surprisingly slow)
 94 2016-07-17T09:37:57  <jtimon> btcdrak: because that would be more of a "layer violation" concern when we have verifyBlock and a bunch of other functions in consensus.h
 95 2016-07-17T09:38:09  <jtimon> btcdrak: why not consensus/flags.h ?
 96 2016-07-17T09:39:08  <jtimon> gmaxwell: we still need to maintain the check I was talking about, right? (although it can be simplified to use the hardcoded heights too)
 97 2016-07-17T09:39:36  *** Ylbam has joined #bitcoin-core-dev
 98 2016-07-17T09:40:11  *** Guyver2 has joined #bitcoin-core-dev
 99 2016-07-17T09:40:41  <jtimon> btcdrak: can you respond to the getflags question? do you mind if that is in versionbits or do you prefer some other place? (not, I won't count "wherever, just not there" nor "let's leave that code in main for now" as answers)
100 2016-07-17T09:40:46  <jtimon> note
101 2016-07-17T09:40:52  *** netsin has quit IRC
102 2016-07-17T09:42:54  <gmaxwell> jtimon: yes the if statement at the top changes, e.g. into nheight >= consensusParams.bipblahblahHeight  -- the check itself would logically remain in ContextualCheckBlock.
103 2016-07-17T09:43:16  <jtimon> it's so hard to get negative feedback on this on a timely manner...we always need more reviewers, but specially of the type that can be less nice and more direct...
104 2016-07-17T09:43:20  <btcdrak> jtimon: I dont have any objection to consensus/flags.h - i only have an objection to stuffing unrelated things into units which have a specific purpose. versionbits.cpp is clearly for BIP9 logic. I would have thought this is self evident :-p :)
105 2016-07-17T09:43:24  <jtimon> gmaxwell: fair enough, I can do that
106 2016-07-17T09:43:58  <jtimon> the goal was getting issupermajority out of main, destroying it counts ;)
107 2016-07-17T09:44:05  <gmaxwell> well I think I've already done it, just need to find the code in a corrupted repository.
108 2016-07-17T09:44:48  <jtimon> gmaxwell: oh, if you've done it no need for me to do it again, please ping me on the PR
109 2016-07-17T09:45:09  <jtimon> well, if it takes you too long to PR it, I will rewrite it ;)
110 2016-07-17T09:46:00  <gmaxwell> the only thing that takes more than 10 minutes is finding the precise heights to set it.
111 2016-07-17T09:46:38  <btcdrak> I think we should update softfork BIPs directly with activation heights.
112 2016-07-17T09:47:21  <btcdrak> something like
113 2016-07-17T09:47:21  <btcdrak> ==Activation==
114 2016-07-17T09:47:21  <btcdrak> This BIP was activated on mainnet at height #nnnnnn
115 2016-07-17T09:47:34  <jtimon> btcdrak: your feedback would be much more useful if you proposed an alternative or at least chose one of the alternatives suggested to you. Where do you think GetFlags should be ? is header_verify.cpp ok?
116 2016-07-17T09:47:38  <gmaxwell> in prior places where we hardcoded softforks we actually bakcdated them.
117 2016-07-17T09:48:43  <jtimon> it seems different people find different preferences (some times incompatible between them) "self evident" it would all be much easier if we all verbalize what is "self evident" to us but doesn't seem to be for other people
118 2016-07-17T09:49:45  <jtimon> btcdrak: I would like to do that encapsulated inside Consensus::GetFlags from now on
119 2016-07-17T09:50:12  *** gmaxwell has left #bitcoin-core-dev
120 2016-07-17T09:50:37  <jtimon> gmaxwell: can we have an array in Consensus::Params with its own little struct ala vDeployments instead of having two new fields for every old deployment?
121 2016-07-17T09:51:08  <jtimon> say, vPastDeployments
122 2016-07-17T09:53:36  *** netsin has joined #bitcoin-core-dev
123 2016-07-17T09:53:38  <jtimon> btcdrak: oh, you meant in the BIP's doc, nevermind then, agreed
124 2016-07-17T09:53:53  *** netsin has quit IRC
125 2016-07-17T09:55:06  <jtimon> gmaxwell is the hash of the block really necessary here? In a super-reorg where that block is changed, shouldn't it be activated anyway?
126 2016-07-17T10:00:53  *** molly has quit IRC
127 2016-07-17T10:01:38  *** moli has joined #bitcoin-core-dev
128 2016-07-17T10:01:44  *** netsin has joined #bitcoin-core-dev
129 2016-07-17T10:06:27  *** netsin has quit IRC
130 2016-07-17T10:16:50  *** netsin has joined #bitcoin-core-dev
131 2016-07-17T10:20:57  *** netsin has quit IRC
132 2016-07-17T10:21:27  *** jtimon has quit IRC
133 2016-07-17T10:35:59  *** xinxi has joined #bitcoin-core-dev
134 2016-07-17T10:39:38  *** netsin has joined #bitcoin-core-dev
135 2016-07-17T10:40:22  *** xinxi has quit IRC
136 2016-07-17T10:48:13  *** jtimon has joined #bitcoin-core-dev
137 2016-07-17T10:53:14  *** netsin has quit IRC
138 2016-07-17T10:55:20  *** belcher has joined #bitcoin-core-dev
139 2016-07-17T10:57:08  *** netsin has joined #bitcoin-core-dev
140 2016-07-17T11:00:42  *** netsin has quit IRC
141 2016-07-17T11:02:58  *** netsin has joined #bitcoin-core-dev
142 2016-07-17T11:05:02  *** netsin has quit IRC
143 2016-07-17T11:10:42  *** shesek has quit IRC
144 2016-07-17T11:12:42  *** netsin has joined #bitcoin-core-dev
145 2016-07-17T11:13:51  *** moli has quit IRC
146 2016-07-17T11:17:47  *** netsin has quit IRC
147 2016-07-17T11:29:20  *** Guyver2 has quit IRC
148 2016-07-17T11:43:17  *** xinxi has joined #bitcoin-core-dev
149 2016-07-17T11:47:31  *** xinxi has quit IRC
150 2016-07-17T12:17:12  *** Samdney has left #bitcoin-core-dev
151 2016-07-17T12:18:41  *** netsin has joined #bitcoin-core-dev
152 2016-07-17T12:23:51  *** netsin has quit IRC
153 2016-07-17T12:25:59  <GitHub139> [bitcoin] Gitju opened pull request #8352: Trivial: Fix typo in bitcoin_es_UY.ts (master...patch-1) https://github.com/bitcoin/bitcoin/pull/8352
154 2016-07-17T12:37:58  *** shesek has joined #bitcoin-core-dev
155 2016-07-17T13:19:32  *** netsin has joined #bitcoin-core-dev
156 2016-07-17T13:23:50  *** netsin has quit IRC
157 2016-07-17T13:29:07  *** moli has joined #bitcoin-core-dev
158 2016-07-17T13:34:05  *** achow101 has joined #bitcoin-core-dev
159 2016-07-17T13:46:11  *** tucenaber has quit IRC
160 2016-07-17T14:04:15  *** tucenaber has joined #bitcoin-core-dev
161 2016-07-17T14:07:08  *** Samdney has joined #bitcoin-core-dev
162 2016-07-17T14:07:54  *** belcher has quit IRC
163 2016-07-17T14:08:16  *** belcher has joined #bitcoin-core-dev
164 2016-07-17T14:15:20  *** TomMc has joined #bitcoin-core-dev
165 2016-07-17T14:20:26  *** netsin has joined #bitcoin-core-dev
166 2016-07-17T14:25:39  *** netsin has quit IRC
167 2016-07-17T14:28:53  *** YOU-JI has joined #bitcoin-core-dev
168 2016-07-17T14:48:17  *** xinxi has joined #bitcoin-core-dev
169 2016-07-17T14:52:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
170 2016-07-17T14:56:18  *** G1lius has quit IRC
171 2016-07-17T15:02:56  *** YOU-JI has quit IRC
172 2016-07-17T15:09:32  *** BCBot has joined #bitcoin-core-dev
173 2016-07-17T15:18:04  *** jtimon has quit IRC
174 2016-07-17T15:22:20  *** netsin has joined #bitcoin-core-dev
175 2016-07-17T15:26:52  *** netsin has quit IRC
176 2016-07-17T15:40:08  *** PRab has quit IRC
177 2016-07-17T16:20:41  *** cryptapus_ has joined #bitcoin-core-dev
178 2016-07-17T16:20:41  *** cryptapus_ has joined #bitcoin-core-dev
179 2016-07-17T16:22:53  *** netsin has joined #bitcoin-core-dev
180 2016-07-17T16:23:01  *** cryptapus_afk is now known as cryptapus
181 2016-07-17T16:23:06  *** cryptapus is now known as cryptapus_afk
182 2016-07-17T16:26:01  *** cryptapus_ has quit IRC
183 2016-07-17T16:26:12  *** kadoban has joined #bitcoin-core-dev
184 2016-07-17T16:28:15  *** netsin has quit IRC
185 2016-07-17T16:58:45  *** Sosumi has quit IRC
186 2016-07-17T17:24:01  *** Sosumi has joined #bitcoin-core-dev
187 2016-07-17T17:29:22  *** molz has joined #bitcoin-core-dev
188 2016-07-17T17:30:13  *** netsin has joined #bitcoin-core-dev
189 2016-07-17T17:31:07  *** spudowiar has joined #bitcoin-core-dev
190 2016-07-17T17:32:01  *** moli has quit IRC
191 2016-07-17T17:41:46  *** zooko has joined #bitcoin-core-dev
192 2016-07-17T18:32:34  *** zooko has quit IRC
193 2016-07-17T18:42:34  *** cjcj has quit IRC
194 2016-07-17T18:43:04  *** afk11 has quit IRC
195 2016-07-17T18:44:24  *** afk11 has joined #bitcoin-core-dev
196 2016-07-17T18:44:24  *** afk11 has quit IRC
197 2016-07-17T18:44:24  *** afk11 has joined #bitcoin-core-dev
198 2016-07-17T18:53:25  *** owowo has quit IRC
199 2016-07-17T18:54:26  *** adamg has quit IRC
200 2016-07-17T18:54:26  *** BonyM has quit IRC
201 2016-07-17T18:54:26  *** JackH has quit IRC
202 2016-07-17T18:54:26  *** instagibbs has quit IRC
203 2016-07-17T18:54:26  *** OxADADA has quit IRC
204 2016-07-17T18:54:26  *** lclc has quit IRC
205 2016-07-17T18:59:34  *** Chris_Stewart_5 has quit IRC
206 2016-07-17T19:01:45  *** owowo has joined #bitcoin-core-dev
207 2016-07-17T19:13:27  *** lclc has joined #bitcoin-core-dev
208 2016-07-17T19:13:32  *** OxADADA has joined #bitcoin-core-dev
209 2016-07-17T19:13:36  *** instagibbs has joined #bitcoin-core-dev
210 2016-07-17T19:13:52  *** JackH has joined #bitcoin-core-dev
211 2016-07-17T19:13:54  *** BonyM has joined #bitcoin-core-dev
212 2016-07-17T19:14:46  *** adamg has joined #bitcoin-core-dev
213 2016-07-17T19:15:45  *** belcher has quit IRC
214 2016-07-17T19:16:33  *** belcher has joined #bitcoin-core-dev
215 2016-07-17T19:21:14  *** moli has joined #bitcoin-core-dev
216 2016-07-17T19:22:31  *** molz has quit IRC
217 2016-07-17T19:35:01  *** molz has joined #bitcoin-core-dev
218 2016-07-17T19:35:34  *** moli has quit IRC
219 2016-07-17T19:56:07  *** instagibbs has quit IRC
220 2016-07-17T20:18:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
221 2016-07-17T21:13:06  *** jtimon has joined #bitcoin-core-dev
222 2016-07-17T21:29:29  *** anu0 has joined #bitcoin-core-dev
223 2016-07-17T21:38:34  *** netsin has quit IRC
224 2016-07-17T21:39:00  *** netsin has joined #bitcoin-core-dev
225 2016-07-17T21:40:07  *** netsin has joined #bitcoin-core-dev
226 2016-07-17T21:41:36  *** netsin has joined #bitcoin-core-dev
227 2016-07-17T21:43:03  *** netsin has quit IRC
228 2016-07-17T21:44:04  *** afk11 has quit IRC
229 2016-07-17T21:48:09  *** xinxi has quit IRC
230 2016-07-17T21:51:42  *** afk11 has joined #bitcoin-core-dev
231 2016-07-17T21:51:42  *** afk11 has quit IRC
232 2016-07-17T21:51:42  *** afk11 has joined #bitcoin-core-dev
233 2016-07-17T21:58:56  *** spudowiar has quit IRC
234 2016-07-17T22:21:50  <GitHub65> [bitcoin] yurizhykin opened pull request #8353: Trivial: tiny c++11 refactors (master...cpp11) https://github.com/bitcoin/bitcoin/pull/8353
235 2016-07-17T22:53:35  *** Samdney has left #bitcoin-core-dev
236 2016-07-17T23:27:52  *** ebfull has joined #bitcoin-core-dev
237 2016-07-17T23:28:09  *** Cheeseo has joined #bitcoin-core-dev
238 2016-07-17T23:31:57  *** anu1 has joined #bitcoin-core-dev
239 2016-07-17T23:34:51  *** anu0 has quit IRC
240 2016-07-17T23:35:21  *** jiggalator has joined #bitcoin-core-dev
241 2016-07-17T23:38:58  *** laurentmt has joined #bitcoin-core-dev
242 2016-07-17T23:39:41  *** jiggalator is now known as netsin
243 2016-07-17T23:39:51  *** laurentmt has quit IRC
244 2016-07-17T23:49:03  *** Cheeseo has quit IRC
245 2016-07-17T23:54:05  *** jcliff42 has joined #bitcoin-core-dev
246 2016-07-17T23:59:11  *** molly has joined #bitcoin-core-dev