12016-11-08T00:00:55 <phantomcircuit> there's no actual bug but it's kind of annoying
22016-11-08T00:01:14 <phantomcircuit> there's a warding about nLowestTimestamp in importmulti
32016-11-08T00:01:23 <phantomcircuit> potentially being used uninitalized
42016-11-08T00:01:32 <sipa> phantomcircuit: yeah, we should fix that
52016-11-08T00:02:14 <jtimon> I have understood and like some of the commits in the middle, just not enough to give an utACK in any of the PRs (note ven the merged ones yet)
62016-11-08T00:06:29 *** AaronvanW has quit IRC
72016-11-08T00:07:02 *** moli has quit IRC
82016-11-08T00:07:40 *** moli has joined #bitcoin-core-dev
92016-11-08T00:07:40 *** cheese_ has quit IRC
102016-11-08T00:23:21 *** gluytium has joined #bitcoin-core-dev
112016-11-08T00:26:21 *** fengling_ has joined #bitcoin-core-dev
122016-11-08T00:28:37 <phantomcircuit> im kind of confused
132016-11-08T00:28:47 <phantomcircuit> sipa: in 8831 you can see i moved IsKeyType
142016-11-08T00:28:51 <phantomcircuit> but im getting wallet/walletdb.h:45: multiple definition of `IsKeyType(std::string)'
152016-11-08T00:29:03 <phantomcircuit> it's protected by #ifndef BITCOIN_WALLET_WALLETDB_H
162016-11-08T00:29:08 <phantomcircuit> so it shouldn't be doing that
172016-11-08T00:29:21 <phantomcircuit> moving the definition to walletdb.cpp fixes this
182016-11-08T00:29:24 <phantomcircuit> but i cant see why
192016-11-08T00:29:38 *** bsm1175321 has quit IRC
202016-11-08T00:31:18 *** fengling_ has quit IRC
212016-11-08T00:34:19 <phantomcircuit> https://api.travis-ci.org/jobs/174075001/log.txt?deansi=true
222016-11-08T00:39:02 *** murch has quit IRC
232016-11-08T00:43:43 *** Evel-Knievel has quit IRC
242016-11-08T00:58:51 <phantomcircuit> sipa: nvm i see where i went wrong
252016-11-08T00:58:55 <phantomcircuit> derp
262016-11-08T00:59:44 <bitcoin-git> [bitcoin] dcousens opened pull request #9100: tx_valid: re-order inputs to how they are encoded (master...testorder) https://github.com/bitcoin/bitcoin/pull/9100
272016-11-08T01:06:04 <phantomcircuit> uh
282016-11-08T01:07:24 <phantomcircuit> CWalletDB::Recover has a dummyWallet which only prints a line in debug.log if LoadKeyValue fails to parse the key/value pair
292016-11-08T01:07:44 <phantomcircuit> this either should fail the recovery or just be removed
302016-11-08T01:13:58 *** bsm1175321 has joined #bitcoin-core-dev
312016-11-08T01:20:09 *** Ylbam has quit IRC
322016-11-08T01:23:22 <bitcoin-git> [bitcoin] pstratem opened pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (master...2016-11-07-cwalletdb-recover) https://github.com/bitcoin/bitcoin/pull/9101
332016-11-08T01:26:40 *** molz has joined #bitcoin-core-dev
342016-11-08T01:27:09 *** fengling_ has joined #bitcoin-core-dev
352016-11-08T01:27:57 *** moli has quit IRC
362016-11-08T01:32:21 *** fengling_ has quit IRC
372016-11-08T01:36:11 *** davec has joined #bitcoin-core-dev
382016-11-08T01:38:41 *** rebroad has joined #bitcoin-core-dev
392016-11-08T01:55:56 *** abpa has quit IRC
402016-11-08T02:03:04 *** molz is now known as moli
412016-11-08T02:05:30 <bitcoin-git> [bitcoin] instagibbs opened pull request #9102: Really don't validate genesis block (master...dontvalidategenesis) https://github.com/bitcoin/bitcoin/pull/9102
422016-11-08T02:09:14 *** rebroad has quit IRC
432016-11-08T02:11:42 <bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f554e03ebe5...dc6b9406bdfa
442016-11-08T02:11:43 <bitcoin-git> bitcoin/master c93beac Suhas Daftuar: [qa] Test that invalid compactblocks don't result in ban
452016-11-08T02:11:43 <bitcoin-git> bitcoin/master 88c3549 Suhas Daftuar: Fix compact block handling to not ban if block is invalid
462016-11-08T02:11:44 <bitcoin-git> bitcoin/master d4833ff Suhas Daftuar: Bump the protocol version to distinguish new banning behavior....
472016-11-08T02:11:52 <bitcoin-git> [bitcoin] sipa closed pull request #9026: Fix handling of invalid compact blocks (master...fix-invalidcb-handling) https://github.com/bitcoin/bitcoin/pull/9026
482016-11-08T02:28:11 *** fengling_ has joined #bitcoin-core-dev
492016-11-08T02:33:24 *** fengling_ has quit IRC
502016-11-08T02:38:00 *** dgenr8 has quit IRC
512016-11-08T02:38:29 *** dgenr8 has joined #bitcoin-core-dev
522016-11-08T02:39:36 *** Alopex has quit IRC
532016-11-08T02:40:41 *** Alopex has joined #bitcoin-core-dev
542016-11-08T02:47:37 *** dgenr8 has quit IRC
552016-11-08T02:59:57 *** fengling_ has joined #bitcoin-core-dev
562016-11-08T03:20:32 *** abpa has joined #bitcoin-core-dev
572016-11-08T03:33:50 *** justanotheruser has quit IRC
582016-11-08T03:37:14 *** justanotheruser has joined #bitcoin-core-dev
592016-11-08T03:40:32 *** Chris_Stewart_5 has quit IRC
602016-11-08T03:43:00 *** CubicEarth has quit IRC
612016-11-08T03:49:11 *** rebroad has joined #bitcoin-core-dev
622016-11-08T03:49:56 *** tunafizz has joined #bitcoin-core-dev
632016-11-08T03:53:02 *** DigiByteDev has joined #bitcoin-core-dev
642016-11-08T04:03:11 *** Alopex has quit IRC
652016-11-08T04:04:16 *** Alopex has joined #bitcoin-core-dev
662016-11-08T04:09:56 *** rebroad has quit IRC
672016-11-08T04:30:52 *** rebroad has joined #bitcoin-core-dev
682016-11-08T04:38:41 *** rebroad has quit IRC
692016-11-08T04:51:14 *** DigiByteDev has quit IRC
702016-11-08T05:03:24 *** aalex has quit IRC
712016-11-08T05:07:11 *** Alopex has quit IRC
722016-11-08T05:07:56 *** btcdrak has quit IRC
732016-11-08T05:08:17 *** Alopex has joined #bitcoin-core-dev
742016-11-08T05:12:01 *** Giszmo has quit IRC
752016-11-08T05:13:59 *** Alopex has quit IRC
762016-11-08T05:18:05 *** sdaftuar has quit IRC
772016-11-08T05:19:24 *** sdaftuar has joined #bitcoin-core-dev
782016-11-08T05:22:08 *** wasi has quit IRC
792016-11-08T05:22:45 *** jtimon has quit IRC
802016-11-08T05:22:54 *** wasi has joined #bitcoin-core-dev
812016-11-08T05:23:11 *** Alopex has joined #bitcoin-core-dev
822016-11-08T05:25:19 *** wasi_ has joined #bitcoin-core-dev
832016-11-08T05:25:25 *** wasi_ has quit IRC
842016-11-08T05:25:30 *** wasi has quit IRC
852016-11-08T05:25:49 *** wasi has joined #bitcoin-core-dev
862016-11-08T05:53:11 *** To7 has joined #bitcoin-core-dev
872016-11-08T05:58:22 *** DigiByteDev has joined #bitcoin-core-dev
882016-11-08T06:02:27 *** fengling_ has quit IRC
892016-11-08T06:20:21 *** Evel-Knievel has joined #bitcoin-core-dev
902016-11-08T06:20:40 *** aalex has joined #bitcoin-core-dev
912016-11-08T06:35:05 *** btcdrak has joined #bitcoin-core-dev
922016-11-08T06:46:43 *** Ylbam has joined #bitcoin-core-dev
932016-11-08T07:02:27 *** belcher has quit IRC
942016-11-08T07:03:14 *** belcher has joined #bitcoin-core-dev
952016-11-08T07:24:28 *** wasi has quit IRC
962016-11-08T07:24:56 *** wasi has joined #bitcoin-core-dev
972016-11-08T07:39:47 *** testnet has joined #bitcoin-core-dev
982016-11-08T07:40:53 *** Alina-malina has quit IRC
992016-11-08T07:42:19 <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc6b9406bdfa...b8f43e33316c
1002016-11-08T07:42:19 <bitcoin-git> bitcoin/master fa8278e MarcoFalke: test: Fix test_random includes
1012016-11-08T07:42:20 <bitcoin-git> bitcoin/master b8f43e3 Jonas Schnelli: Merge #9095: test: Fix test_random includes...
1022016-11-08T07:42:32 <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9095: test: Fix test_random includes (master...Mf1611-testRand) https://github.com/bitcoin/bitcoin/pull/9095
1032016-11-08T07:48:30 *** davec has quit IRC
1042016-11-08T07:49:35 *** whphhg has joined #bitcoin-core-dev
1052016-11-08T07:57:34 *** davec has joined #bitcoin-core-dev
1062016-11-08T08:02:01 *** BashCo has quit IRC
1072016-11-08T08:15:50 *** rubensayshi has joined #bitcoin-core-dev
1082016-11-08T08:27:47 *** BashCo has joined #bitcoin-core-dev
1092016-11-08T08:30:48 *** DigiByteDev has quit IRC
1102016-11-08T08:44:12 *** DigiByteDev has joined #bitcoin-core-dev
1112016-11-08T09:04:37 *** MarcoFalke has joined #bitcoin-core-dev
1122016-11-08T09:05:03 *** gielbier has quit IRC
1132016-11-08T09:09:25 *** AaronvanW has joined #bitcoin-core-dev
1142016-11-08T09:14:30 *** belcher has quit IRC
1152016-11-08T09:23:17 *** paveljanik has quit IRC
1162016-11-08T09:24:13 *** jl2012 has quit IRC
1172016-11-08T09:25:02 *** jl2012 has joined #bitcoin-core-dev
1182016-11-08T09:37:23 *** jl2012 has quit IRC
1192016-11-08T09:37:39 *** jl2012 has joined #bitcoin-core-dev
1202016-11-08T09:55:34 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b8f43e33316c...f53023dbb860
1212016-11-08T09:55:35 <bitcoin-git> bitcoin/master bd0de13 UdjinM6: Fix exit codes:...
1222016-11-08T09:55:35 <bitcoin-git> bitcoin/master 4441018 UdjinM6: Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
1232016-11-08T09:55:36 <bitcoin-git> bitcoin/master f53023d Wladimir J. van der Laan: Merge #9067: Fix exit codes...
1242016-11-08T09:55:44 <bitcoin-git> [bitcoin] laanwj closed pull request #9067: Fix exit codes (master...fixExitCodesBitcoin) https://github.com/bitcoin/bitcoin/pull/9067
1252016-11-08T09:56:08 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f53023dbb860...71ab476b0482
1262016-11-08T09:56:09 <bitcoin-git> bitcoin/master fae19aa MarcoFalke: [qa] test_framework: Exit when tmpdir exists
1272016-11-08T09:56:10 <bitcoin-git> bitcoin/master fab0f07 MarcoFalke: [qa] rpc-tests: Apply random offset to portseed...
1282016-11-08T09:56:10 <bitcoin-git> bitcoin/master 71ab476 Wladimir J. van der Laan: Merge #9098: [qa] Handle zombies and cluttered tmpdirs...
1292016-11-08T09:56:19 <bitcoin-git> [bitcoin] laanwj closed pull request #9098: [qa] Handle zombies and cluttered tmpdirs (master...Mf1611-qaZombies) https://github.com/bitcoin/bitcoin/pull/9098
1302016-11-08T09:57:48 <wumpus> now the tests can even jump over zombies in graveyards \o/
1312016-11-08T10:03:52 *** fengling has joined #bitcoin-core-dev
1322016-11-08T10:05:37 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71ab476b0482...4e5782438c3d
1332016-11-08T10:05:38 <bitcoin-git> bitcoin/master 77cbbd9 R E Broadley: Make warning message about wallet balance possibly...
1342016-11-08T10:05:38 <bitcoin-git> bitcoin/master 4e57824 Wladimir J. van der Laan: Merge #9088: Reduce ambiguity of warning message...
1352016-11-08T10:05:49 <bitcoin-git> [bitcoin] laanwj closed pull request #9088: Reduce ambiguity of warning message (master...LessAmbiguousWalletWarning) https://github.com/bitcoin/bitcoin/pull/9088
1362016-11-08T10:05:51 <MarcoFalke> Heh, I hope it is a good thing because whenever there is a zombie there is a prob of about 0.0016 that you will step on them :P
1372016-11-08T10:06:37 <MarcoFalke> Previously the prob was 1, so at least you knew there is a zombie
1382016-11-08T10:17:09 *** Alina-malina has joined #bitcoin-core-dev
1392016-11-08T10:21:25 *** jyap has quit IRC
1402016-11-08T10:25:19 *** jyap has joined #bitcoin-core-dev
1412016-11-08T10:25:19 *** jyap has joined #bitcoin-core-dev
1422016-11-08T10:33:05 *** MarcoFalke has left #bitcoin-core-dev
1432016-11-08T10:42:21 *** PatBoy has quit IRC
1442016-11-08T10:53:31 *** fengling has quit IRC
1452016-11-08T11:05:31 *** murch has joined #bitcoin-core-dev
1462016-11-08T11:10:18 *** PatBoy has joined #bitcoin-core-dev
1472016-11-08T11:11:54 *** PatBoy has joined #bitcoin-core-dev
1482016-11-08T11:19:15 *** crudel has quit IRC
1492016-11-08T11:30:18 *** cdecker has joined #bitcoin-core-dev
1502016-11-08T12:05:42 *** whphhg has quit IRC
1512016-11-08T12:07:05 *** laurentmt has joined #bitcoin-core-dev
1522016-11-08T12:17:05 <wumpus> well the best way of deailng with zombies would be to no create them in the first place, make sure the test framework cleans up the dead properly
1532016-11-08T12:17:19 <wumpus> this is not always possible, of course
1542016-11-08T12:19:16 *** laurentmt has quit IRC
1552016-11-08T12:24:11 *** dermoth_ has joined #bitcoin-core-dev
1562016-11-08T12:24:39 *** dermoth has quit IRC
1572016-11-08T12:24:41 *** dermoth_ is now known as dermoth
1582016-11-08T12:39:01 *** crescendo has quit IRC
1592016-11-08T12:40:03 *** davec has quit IRC
1602016-11-08T12:42:04 *** cryptapus has joined #bitcoin-core-dev
1612016-11-08T12:50:11 *** arowser has quit IRC
1622016-11-08T12:50:25 *** arowser has joined #bitcoin-core-dev
1632016-11-08T12:54:45 *** cryptapus has quit IRC
1642016-11-08T12:58:44 *** cryptapus has joined #bitcoin-core-dev
1652016-11-08T13:02:54 *** erasmospunk has joined #bitcoin-core-dev
1662016-11-08T13:05:31 *** erasmospunk has quit IRC
1672016-11-08T13:11:10 *** DigiByteDev has quit IRC
1682016-11-08T13:11:18 *** Alina-malina has quit IRC
1692016-11-08T13:11:19 *** Alina-malina has joined #bitcoin-core-dev
1702016-11-08T13:12:09 *** DigiByteDev has joined #bitcoin-core-dev
1712016-11-08T13:16:18 *** DigiByteDev has quit IRC
1722016-11-08T13:21:18 *** Giszmo has joined #bitcoin-core-dev
1732016-11-08T13:23:08 *** laurentmt has joined #bitcoin-core-dev
1742016-11-08T13:23:54 *** laurentmt has quit IRC
1752016-11-08T13:25:23 *** rafalcpp has joined #bitcoin-core-dev
1762016-11-08T13:26:07 *** cryptapus has quit IRC
1772016-11-08T13:40:02 *** DigiByteDev has joined #bitcoin-core-dev
1782016-11-08T13:52:10 *** jtimon has joined #bitcoin-core-dev
1792016-11-08T13:55:56 *** laurentmt has joined #bitcoin-core-dev
1802016-11-08T14:01:20 *** laurentmt has quit IRC
1812016-11-08T14:25:22 *** Guyver2 has joined #bitcoin-core-dev
1822016-11-08T14:32:02 *** cryptapus_ has joined #bitcoin-core-dev
1832016-11-08T14:32:02 *** cryptapus_ has joined #bitcoin-core-dev
1842016-11-08T14:44:26 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1852016-11-08T14:45:40 *** d9b4bef9 has quit IRC
1862016-11-08T14:47:19 *** d9b4bef9 has joined #bitcoin-core-dev
1872016-11-08T14:56:41 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e5782438c3d...924de0bd75a7
1882016-11-08T14:56:41 <bitcoin-git> bitcoin/master 1adf82a Jorge Timón: RPC: Give more details when "generate" fails
1892016-11-08T14:56:42 <bitcoin-git> bitcoin/master 924de0b MarcoFalke: Merge #9087: RPC: why not give more details when "generate" fails?...
1902016-11-08T14:56:50 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9087: RPC: why not give more details when "generate" fails? (master...0.13-errors-rpc-mining) https://github.com/bitcoin/bitcoin/pull/9087
1912016-11-08T15:15:14 *** abpa has quit IRC
1922016-11-08T15:20:05 *** cryptapus_ has quit IRC
1932016-11-08T15:20:53 *** laurentmt has joined #bitcoin-core-dev
1942016-11-08T15:30:20 *** cryptapus_ has joined #bitcoin-core-dev
1952016-11-08T15:31:12 *** davec has joined #bitcoin-core-dev
1962016-11-08T15:31:50 *** cryptapus_ has quit IRC
1972016-11-08T15:32:06 *** cryptapus_ has joined #bitcoin-core-dev
1982016-11-08T15:32:06 *** cryptapus_ has joined #bitcoin-core-dev
1992016-11-08T15:32:15 *** cryptapus_ is now known as cryptapus
2002016-11-08T15:39:41 *** Guyver2__ has joined #bitcoin-core-dev
2012016-11-08T15:40:29 *** aalex has quit IRC
2022016-11-08T15:42:30 *** laurentmt has quit IRC
2032016-11-08T15:42:38 *** Guyver2 has quit IRC
2042016-11-08T15:42:45 *** Guyver2__ is now known as Guyver2
2052016-11-08T15:48:58 *** aalex has joined #bitcoin-core-dev
2062016-11-08T16:00:15 *** rafalcpp has quit IRC
2072016-11-08T16:00:23 *** rafalcpp has joined #bitcoin-core-dev
2082016-11-08T16:02:37 *** laurentmt has joined #bitcoin-core-dev
2092016-11-08T16:03:38 *** Guyver2 has quit IRC
2102016-11-08T16:11:56 *** murch has quit IRC
2112016-11-08T16:20:12 *** rafalcpp_ has joined #bitcoin-core-dev
2122016-11-08T16:20:21 *** rafalcpp has quit IRC
2132016-11-08T16:27:17 *** laurentmt has quit IRC
2142016-11-08T16:38:34 *** Squidicuz has quit IRC
2152016-11-08T16:45:03 *** testnet has quit IRC
2162016-11-08T16:45:33 *** testnet has joined #bitcoin-core-dev
2172016-11-08T16:46:38 *** Guyver2 has joined #bitcoin-core-dev
2182016-11-08T16:55:43 *** abpa has joined #bitcoin-core-dev
2192016-11-08T16:56:18 *** rafalcpp_ has quit IRC
2202016-11-08T16:59:41 *** rubensayshi has quit IRC
2212016-11-08T17:07:04 *** droark has quit IRC
2222016-11-08T17:07:21 *** PRab has joined #bitcoin-core-dev
2232016-11-08T17:09:27 *** BashCo has quit IRC
2242016-11-08T17:10:06 *** BashCo has joined #bitcoin-core-dev
2252016-11-08T17:10:39 *** rafalcpp has joined #bitcoin-core-dev
2262016-11-08T17:14:24 *** BashCo has quit IRC
2272016-11-08T17:17:41 *** Victorsueca has quit IRC
2282016-11-08T17:20:02 *** Victorsueca has joined #bitcoin-core-dev
2292016-11-08T17:40:33 *** aalex has quit IRC
2302016-11-08T17:41:50 *** BashCo has joined #bitcoin-core-dev
2312016-11-08T17:50:01 *** aalex has joined #bitcoin-core-dev
2322016-11-08T17:56:01 *** CubicEarth has joined #bitcoin-core-dev
2332016-11-08T18:03:36 *** davec has quit IRC
2342016-11-08T18:10:01 *** DigiByteDev has quit IRC
2352016-11-08T18:31:58 *** bsm1175321 has quit IRC
2362016-11-08T18:35:35 *** bsm1175321 has joined #bitcoin-core-dev
2372016-11-08T18:40:51 *** paveljanik has joined #bitcoin-core-dev
2382016-11-08T18:40:52 *** paveljanik has joined #bitcoin-core-dev
2392016-11-08T18:42:22 *** CubicEarth has quit IRC
2402016-11-08T18:45:38 *** davec has joined #bitcoin-core-dev
2412016-11-08T18:51:33 *** PRab has quit IRC
2422016-11-08T19:11:55 <gmaxwell> sipa: so perhaps the mempool saving functionality should be saving the mempoolminfee... as it goes to zero after a restart.
2432016-11-08T19:15:57 <sipa> gmaxwell: good point
2442016-11-08T19:16:00 <sipa> file an issue
2452016-11-08T19:17:51 <gmaxwell> sipa: #9103
2462016-11-08T19:17:52 <gribble> https://github.com/bitcoin/bitcoin/issues/9103 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
2472016-11-08T19:29:47 *** testnet has quit IRC
2482016-11-08T19:34:36 <morcos> sipa: i also thought mempool saving was going to be optional?
2492016-11-08T19:35:15 <morcos> on a separately question, is it fine to leave a bunch of BOOST_TEST_MESSAGE(..) in unit_tests or will they slow them down...
2502016-11-08T19:35:37 <morcos> coins_tests are so complicated, might be useful to not have to readd all this debugging information next time they are changed
2512016-11-08T19:36:26 *** bsm1175321 has quit IRC
2522016-11-08T19:36:28 *** Guest89259 has joined #bitcoin-core-dev
2532016-11-08T19:36:53 *** bsm1175321 has joined #bitcoin-core-dev
2542016-11-08T19:38:07 *** Guest89259 is now known as roidster
2552016-11-08T19:43:51 *** testnet has joined #bitcoin-core-dev
2562016-11-08T19:58:57 *** harrymm has quit IRC
2572016-11-08T20:03:48 <BlueMatt> jtimon: cool, thanks
2582016-11-08T20:16:54 *** harrymm has joined #bitcoin-core-dev
2592016-11-08T20:27:07 <jtimon> wumpus: instagibbs I added the reindex rpc tests to #8994, to test #9102 (well, and #8994 in general), if you think of other rpc tests that would be interesting to duplicate for this or default values for the custom chain (ie maybe consensus.BIP34Height = 0 or whatever ) please let me know
2602016-11-08T20:27:08 <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
2612016-11-08T20:27:10 <gribble> https://github.com/bitcoin/bitcoin/issues/9102 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
2622016-11-08T20:27:11 <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
2632016-11-08T20:28:10 <jtimon> strangely enough locally walletbackup is failing, but only when I run all of them, not when I run it individually, there must be something I haven't cleanup up properly because travis seems to be happy
2642016-11-08T20:39:42 *** whphhg has joined #bitcoin-core-dev
2652016-11-08T20:42:06 <sdaftuar> jtimon: if you're seeing failures related to block sync failure in sync_blocks(), there's a good chance that
2662016-11-08T20:42:41 <sdaftuar> is related to #9058
2672016-11-08T20:42:43 <gribble> https://github.com/bitcoin/bitcoin/issues/9058 | Fixes for p2p-compactblocks.py test timeouts on travis (#8842) by ryanofsky · Pull Request #9058 · bitcoin/bitcoin · GitHub
2682016-11-08T20:44:48 <jtimon> I'm not really sure what's happening, it's not a very clear error and the fact that walletbackup passes individually makes it more weird, but I will take a look, thanks
2692016-11-08T20:47:10 *** juscamarena has joined #bitcoin-core-dev
2702016-11-08T20:48:05 *** e4xit has quit IRC
2712016-11-08T20:52:42 *** juscamarena has quit IRC
2722016-11-08T21:00:29 *** whphhg is now known as montau
2732016-11-08T21:02:29 *** cryptapus has quit IRC
2742016-11-08T21:04:12 *** juscamarena has joined #bitcoin-core-dev
2752016-11-08T21:07:18 <bitcoin-git> [bitcoin] morcos opened pull request #9107: Safer modify new coins (master...saferModifyNewCoins) https://github.com/bitcoin/bitcoin/pull/9107
2762016-11-08T21:49:19 *** jtimon has quit IRC
2772016-11-08T22:01:15 *** droark has joined #bitcoin-core-dev
2782016-11-08T22:04:46 *** aalex has quit IRC
2792016-11-08T22:05:40 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9108: WIP: Use importmulti timestamp when importing watch only keys (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108
2802016-11-08T22:06:45 *** Guyver2 has quit IRC
2812016-11-08T22:25:13 <gmaxwell> morcos: it's optional, you can totally kill -9 the process instead of calling stop. :P
2822016-11-08T22:25:43 <gmaxwell> (I suppose it would be reasonable to add an option to let people disable it, though I don't know why anyone would set it, except perhaps saving 150 mb of disk space.
2832016-11-08T22:29:57 <sipa> morcos: i'm not opposed to making it optional, i just didn't think it was a requirement for the first PR
2842016-11-08T22:34:11 <sipa> gmaxwell: i assume you're joking, but there are downsides to killing that may be worse, like not storing the latest blocks' effect to disk
2852016-11-08T22:39:26 *** roidster has quit IRC
2862016-11-08T22:42:50 <cfields> sdaftuar: regarding #9026, did you consider adding fMayBanPeerIfInvalid to CState rather than passing it around? I realize it's merged, just curious after starting to review 9075
2872016-11-08T22:42:52 <gribble> https://github.com/bitcoin/bitcoin/issues/9026 | Fix handling of invalid compact blocks by sdaftuar · Pull Request #9026 · bitcoin/bitcoin · GitHub
2882016-11-08T22:44:10 <sipa> cfields: i dislike turning CValidationState into an input parameter as well
2892016-11-08T22:49:24 <cfields> sipa: fair enough, I suppose that would be the only input. I was thinking there were already some there.
2902016-11-08T22:53:34 <gmaxwell> sipa: well we should fix those downsides if they're actually a concern. :) losing a few blocks of verification should be a non-issue.
2912016-11-08T22:54:27 <phantomcircuit> gmaxwell: i think it can be more than a few
2922016-11-08T23:02:21 <sipa> gmaxwell: not needing a shutdown procedure is a nice design principle, but i don't think we're there
2932016-11-08T23:07:47 <gmaxwell> seems pretty fine to me.
2942016-11-08T23:07:57 *** btcdrak has quit IRC
2952016-11-08T23:30:21 *** cdecker has quit IRC
2962016-11-08T23:32:01 *** droark has quit IRC
2972016-11-08T23:32:41 *** droark has joined #bitcoin-core-dev