1 2016-11-08T00:00:55  <phantomcircuit> there's no actual bug but it's kind of annoying
  2 2016-11-08T00:01:14  <phantomcircuit> there's a warding about nLowestTimestamp in importmulti
  3 2016-11-08T00:01:23  <phantomcircuit> potentially being used uninitalized
  4 2016-11-08T00:01:32  <sipa> phantomcircuit: yeah, we should fix that
  5 2016-11-08T00:02:14  <jtimon> I have understood and like some of the commits in the middle, just not enough to give an utACK in any of the PRs (note ven the merged ones yet)
  6 2016-11-08T00:06:29  *** AaronvanW has quit IRC
  7 2016-11-08T00:07:02  *** moli has quit IRC
  8 2016-11-08T00:07:40  *** moli has joined #bitcoin-core-dev
  9 2016-11-08T00:07:40  *** cheese_ has quit IRC
 10 2016-11-08T00:23:21  *** gluytium has joined #bitcoin-core-dev
 11 2016-11-08T00:26:21  *** fengling_ has joined #bitcoin-core-dev
 12 2016-11-08T00:28:37  <phantomcircuit> im kind of confused
 13 2016-11-08T00:28:47  <phantomcircuit> sipa: in 8831 you can see i moved IsKeyType
 14 2016-11-08T00:28:51  <phantomcircuit> but im getting wallet/walletdb.h:45: multiple definition of `IsKeyType(std::string)'
 15 2016-11-08T00:29:03  <phantomcircuit> it's protected by #ifndef BITCOIN_WALLET_WALLETDB_H
 16 2016-11-08T00:29:08  <phantomcircuit> so it shouldn't be doing that
 17 2016-11-08T00:29:21  <phantomcircuit> moving the definition to walletdb.cpp fixes this
 18 2016-11-08T00:29:24  <phantomcircuit> but i cant see why
 19 2016-11-08T00:29:38  *** bsm1175321 has quit IRC
 20 2016-11-08T00:31:18  *** fengling_ has quit IRC
 21 2016-11-08T00:34:19  <phantomcircuit> https://api.travis-ci.org/jobs/174075001/log.txt?deansi=true
 22 2016-11-08T00:39:02  *** murch has quit IRC
 23 2016-11-08T00:43:43  *** Evel-Knievel has quit IRC
 24 2016-11-08T00:58:51  <phantomcircuit> sipa: nvm i see where i went wrong
 25 2016-11-08T00:58:55  <phantomcircuit> derp
 26 2016-11-08T00:59:44  <bitcoin-git> [bitcoin] dcousens opened pull request #9100: tx_valid: re-order inputs to how they are encoded (master...testorder) https://github.com/bitcoin/bitcoin/pull/9100
 27 2016-11-08T01:06:04  <phantomcircuit> uh
 28 2016-11-08T01:07:24  <phantomcircuit> CWalletDB::Recover has a dummyWallet which only prints a line in debug.log if LoadKeyValue fails to parse the key/value pair
 29 2016-11-08T01:07:44  <phantomcircuit> this either should fail the recovery or just be removed
 30 2016-11-08T01:13:58  *** bsm1175321 has joined #bitcoin-core-dev
 31 2016-11-08T01:20:09  *** Ylbam has quit IRC
 32 2016-11-08T01:23:22  <bitcoin-git> [bitcoin] pstratem opened pull request #9101: [Wallet] Do not parse ssValue in CWalletDB::Recover (master...2016-11-07-cwalletdb-recover) https://github.com/bitcoin/bitcoin/pull/9101
 33 2016-11-08T01:26:40  *** molz has joined #bitcoin-core-dev
 34 2016-11-08T01:27:09  *** fengling_ has joined #bitcoin-core-dev
 35 2016-11-08T01:27:57  *** moli has quit IRC
 36 2016-11-08T01:32:21  *** fengling_ has quit IRC
 37 2016-11-08T01:36:11  *** davec has joined #bitcoin-core-dev
 38 2016-11-08T01:38:41  *** rebroad has joined #bitcoin-core-dev
 39 2016-11-08T01:55:56  *** abpa has quit IRC
 40 2016-11-08T02:03:04  *** molz is now known as moli
 41 2016-11-08T02:05:30  <bitcoin-git> [bitcoin] instagibbs opened pull request #9102: Really don't validate genesis block (master...dontvalidategenesis) https://github.com/bitcoin/bitcoin/pull/9102
 42 2016-11-08T02:09:14  *** rebroad has quit IRC
 43 2016-11-08T02:11:42  <bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f554e03ebe5...dc6b9406bdfa
 44 2016-11-08T02:11:43  <bitcoin-git> bitcoin/master c93beac Suhas Daftuar: [qa] Test that invalid compactblocks don't result in ban
 45 2016-11-08T02:11:43  <bitcoin-git> bitcoin/master 88c3549 Suhas Daftuar: Fix compact block handling to not ban if block is invalid
 46 2016-11-08T02:11:44  <bitcoin-git> bitcoin/master d4833ff Suhas Daftuar: Bump the protocol version to distinguish new banning behavior....
 47 2016-11-08T02:11:52  <bitcoin-git> [bitcoin] sipa closed pull request #9026: Fix handling of invalid compact blocks (master...fix-invalidcb-handling) https://github.com/bitcoin/bitcoin/pull/9026
 48 2016-11-08T02:28:11  *** fengling_ has joined #bitcoin-core-dev
 49 2016-11-08T02:33:24  *** fengling_ has quit IRC
 50 2016-11-08T02:38:00  *** dgenr8 has quit IRC
 51 2016-11-08T02:38:29  *** dgenr8 has joined #bitcoin-core-dev
 52 2016-11-08T02:39:36  *** Alopex has quit IRC
 53 2016-11-08T02:40:41  *** Alopex has joined #bitcoin-core-dev
 54 2016-11-08T02:47:37  *** dgenr8 has quit IRC
 55 2016-11-08T02:59:57  *** fengling_ has joined #bitcoin-core-dev
 56 2016-11-08T03:20:32  *** abpa has joined #bitcoin-core-dev
 57 2016-11-08T03:33:50  *** justanotheruser has quit IRC
 58 2016-11-08T03:37:14  *** justanotheruser has joined #bitcoin-core-dev
 59 2016-11-08T03:40:32  *** Chris_Stewart_5 has quit IRC
 60 2016-11-08T03:43:00  *** CubicEarth has quit IRC
 61 2016-11-08T03:49:11  *** rebroad has joined #bitcoin-core-dev
 62 2016-11-08T03:49:56  *** tunafizz has joined #bitcoin-core-dev
 63 2016-11-08T03:53:02  *** DigiByteDev has joined #bitcoin-core-dev
 64 2016-11-08T04:03:11  *** Alopex has quit IRC
 65 2016-11-08T04:04:16  *** Alopex has joined #bitcoin-core-dev
 66 2016-11-08T04:09:56  *** rebroad has quit IRC
 67 2016-11-08T04:30:52  *** rebroad has joined #bitcoin-core-dev
 68 2016-11-08T04:38:41  *** rebroad has quit IRC
 69 2016-11-08T04:51:14  *** DigiByteDev has quit IRC
 70 2016-11-08T05:03:24  *** aalex has quit IRC
 71 2016-11-08T05:07:11  *** Alopex has quit IRC
 72 2016-11-08T05:07:56  *** btcdrak has quit IRC
 73 2016-11-08T05:08:17  *** Alopex has joined #bitcoin-core-dev
 74 2016-11-08T05:12:01  *** Giszmo has quit IRC
 75 2016-11-08T05:13:59  *** Alopex has quit IRC
 76 2016-11-08T05:18:05  *** sdaftuar has quit IRC
 77 2016-11-08T05:19:24  *** sdaftuar has joined #bitcoin-core-dev
 78 2016-11-08T05:22:08  *** wasi has quit IRC
 79 2016-11-08T05:22:45  *** jtimon has quit IRC
 80 2016-11-08T05:22:54  *** wasi has joined #bitcoin-core-dev
 81 2016-11-08T05:23:11  *** Alopex has joined #bitcoin-core-dev
 82 2016-11-08T05:25:19  *** wasi_ has joined #bitcoin-core-dev
 83 2016-11-08T05:25:25  *** wasi_ has quit IRC
 84 2016-11-08T05:25:30  *** wasi has quit IRC
 85 2016-11-08T05:25:49  *** wasi has joined #bitcoin-core-dev
 86 2016-11-08T05:53:11  *** To7 has joined #bitcoin-core-dev
 87 2016-11-08T05:58:22  *** DigiByteDev has joined #bitcoin-core-dev
 88 2016-11-08T06:02:27  *** fengling_ has quit IRC
 89 2016-11-08T06:20:21  *** Evel-Knievel has joined #bitcoin-core-dev
 90 2016-11-08T06:20:40  *** aalex has joined #bitcoin-core-dev
 91 2016-11-08T06:35:05  *** btcdrak has joined #bitcoin-core-dev
 92 2016-11-08T06:46:43  *** Ylbam has joined #bitcoin-core-dev
 93 2016-11-08T07:02:27  *** belcher has quit IRC
 94 2016-11-08T07:03:14  *** belcher has joined #bitcoin-core-dev
 95 2016-11-08T07:24:28  *** wasi has quit IRC
 96 2016-11-08T07:24:56  *** wasi has joined #bitcoin-core-dev
 97 2016-11-08T07:39:47  *** testnet has joined #bitcoin-core-dev
 98 2016-11-08T07:40:53  *** Alina-malina has quit IRC
 99 2016-11-08T07:42:19  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc6b9406bdfa...b8f43e33316c
100 2016-11-08T07:42:19  <bitcoin-git> bitcoin/master fa8278e MarcoFalke: test: Fix test_random includes
101 2016-11-08T07:42:20  <bitcoin-git> bitcoin/master b8f43e3 Jonas Schnelli: Merge #9095: test: Fix test_random includes...
102 2016-11-08T07:42:32  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9095: test: Fix test_random includes (master...Mf1611-testRand) https://github.com/bitcoin/bitcoin/pull/9095
103 2016-11-08T07:48:30  *** davec has quit IRC
104 2016-11-08T07:49:35  *** whphhg has joined #bitcoin-core-dev
105 2016-11-08T07:57:34  *** davec has joined #bitcoin-core-dev
106 2016-11-08T08:02:01  *** BashCo has quit IRC
107 2016-11-08T08:15:50  *** rubensayshi has joined #bitcoin-core-dev
108 2016-11-08T08:27:47  *** BashCo has joined #bitcoin-core-dev
109 2016-11-08T08:30:48  *** DigiByteDev has quit IRC
110 2016-11-08T08:44:12  *** DigiByteDev has joined #bitcoin-core-dev
111 2016-11-08T09:04:37  *** MarcoFalke has joined #bitcoin-core-dev
112 2016-11-08T09:05:03  *** gielbier has quit IRC
113 2016-11-08T09:09:25  *** AaronvanW has joined #bitcoin-core-dev
114 2016-11-08T09:14:30  *** belcher has quit IRC
115 2016-11-08T09:23:17  *** paveljanik has quit IRC
116 2016-11-08T09:24:13  *** jl2012 has quit IRC
117 2016-11-08T09:25:02  *** jl2012 has joined #bitcoin-core-dev
118 2016-11-08T09:37:23  *** jl2012 has quit IRC
119 2016-11-08T09:37:39  *** jl2012 has joined #bitcoin-core-dev
120 2016-11-08T09:55:34  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b8f43e33316c...f53023dbb860
121 2016-11-08T09:55:35  <bitcoin-git> bitcoin/master bd0de13 UdjinM6: Fix exit codes:...
122 2016-11-08T09:55:35  <bitcoin-git> bitcoin/master 4441018 UdjinM6: Every main()/exit() should return/use one of EXIT_ codes instead of magic numbers
123 2016-11-08T09:55:36  <bitcoin-git> bitcoin/master f53023d Wladimir J. van der Laan: Merge #9067: Fix exit codes...
124 2016-11-08T09:55:44  <bitcoin-git> [bitcoin] laanwj closed pull request #9067: Fix exit codes (master...fixExitCodesBitcoin) https://github.com/bitcoin/bitcoin/pull/9067
125 2016-11-08T09:56:08  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f53023dbb860...71ab476b0482
126 2016-11-08T09:56:09  <bitcoin-git> bitcoin/master fae19aa MarcoFalke: [qa] test_framework: Exit when tmpdir exists
127 2016-11-08T09:56:10  <bitcoin-git> bitcoin/master fab0f07 MarcoFalke: [qa] rpc-tests: Apply random offset to portseed...
128 2016-11-08T09:56:10  <bitcoin-git> bitcoin/master 71ab476 Wladimir J. van der Laan: Merge #9098: [qa] Handle zombies and cluttered tmpdirs...
129 2016-11-08T09:56:19  <bitcoin-git> [bitcoin] laanwj closed pull request #9098: [qa] Handle zombies and cluttered tmpdirs (master...Mf1611-qaZombies) https://github.com/bitcoin/bitcoin/pull/9098
130 2016-11-08T09:57:48  <wumpus> now the tests can even jump over zombies in graveyards \o/
131 2016-11-08T10:03:52  *** fengling has joined #bitcoin-core-dev
132 2016-11-08T10:05:37  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/71ab476b0482...4e5782438c3d
133 2016-11-08T10:05:38  <bitcoin-git> bitcoin/master 77cbbd9 R E Broadley: Make warning message about wallet balance possibly...
134 2016-11-08T10:05:38  <bitcoin-git> bitcoin/master 4e57824 Wladimir J. van der Laan: Merge #9088: Reduce ambiguity of warning message...
135 2016-11-08T10:05:49  <bitcoin-git> [bitcoin] laanwj closed pull request #9088: Reduce ambiguity of warning message (master...LessAmbiguousWalletWarning) https://github.com/bitcoin/bitcoin/pull/9088
136 2016-11-08T10:05:51  <MarcoFalke> Heh, I hope it is a good thing because whenever there is a zombie there is a prob of about 0.0016 that you will step on them :P
137 2016-11-08T10:06:37  <MarcoFalke> Previously the prob was 1, so at least you knew there is a zombie
138 2016-11-08T10:17:09  *** Alina-malina has joined #bitcoin-core-dev
139 2016-11-08T10:21:25  *** jyap has quit IRC
140 2016-11-08T10:25:19  *** jyap has joined #bitcoin-core-dev
141 2016-11-08T10:25:19  *** jyap has joined #bitcoin-core-dev
142 2016-11-08T10:33:05  *** MarcoFalke has left #bitcoin-core-dev
143 2016-11-08T10:42:21  *** PatBoy has quit IRC
144 2016-11-08T10:53:31  *** fengling has quit IRC
145 2016-11-08T11:05:31  *** murch has joined #bitcoin-core-dev
146 2016-11-08T11:10:18  *** PatBoy has joined #bitcoin-core-dev
147 2016-11-08T11:11:54  *** PatBoy has joined #bitcoin-core-dev
148 2016-11-08T11:19:15  *** crudel has quit IRC
149 2016-11-08T11:30:18  *** cdecker has joined #bitcoin-core-dev
150 2016-11-08T12:05:42  *** whphhg has quit IRC
151 2016-11-08T12:07:05  *** laurentmt has joined #bitcoin-core-dev
152 2016-11-08T12:17:05  <wumpus> well the best way of deailng with zombies would be to no create them in the first place, make sure the test framework cleans up the dead properly
153 2016-11-08T12:17:19  <wumpus> this is not always possible, of course
154 2016-11-08T12:19:16  *** laurentmt has quit IRC
155 2016-11-08T12:24:11  *** dermoth_ has joined #bitcoin-core-dev
156 2016-11-08T12:24:39  *** dermoth has quit IRC
157 2016-11-08T12:24:41  *** dermoth_ is now known as dermoth
158 2016-11-08T12:39:01  *** crescendo has quit IRC
159 2016-11-08T12:40:03  *** davec has quit IRC
160 2016-11-08T12:42:04  *** cryptapus has joined #bitcoin-core-dev
161 2016-11-08T12:50:11  *** arowser has quit IRC
162 2016-11-08T12:50:25  *** arowser has joined #bitcoin-core-dev
163 2016-11-08T12:54:45  *** cryptapus has quit IRC
164 2016-11-08T12:58:44  *** cryptapus has joined #bitcoin-core-dev
165 2016-11-08T13:02:54  *** erasmospunk has joined #bitcoin-core-dev
166 2016-11-08T13:05:31  *** erasmospunk has quit IRC
167 2016-11-08T13:11:10  *** DigiByteDev has quit IRC
168 2016-11-08T13:11:18  *** Alina-malina has quit IRC
169 2016-11-08T13:11:19  *** Alina-malina has joined #bitcoin-core-dev
170 2016-11-08T13:12:09  *** DigiByteDev has joined #bitcoin-core-dev
171 2016-11-08T13:16:18  *** DigiByteDev has quit IRC
172 2016-11-08T13:21:18  *** Giszmo has joined #bitcoin-core-dev
173 2016-11-08T13:23:08  *** laurentmt has joined #bitcoin-core-dev
174 2016-11-08T13:23:54  *** laurentmt has quit IRC
175 2016-11-08T13:25:23  *** rafalcpp has joined #bitcoin-core-dev
176 2016-11-08T13:26:07  *** cryptapus has quit IRC
177 2016-11-08T13:40:02  *** DigiByteDev has joined #bitcoin-core-dev
178 2016-11-08T13:52:10  *** jtimon has joined #bitcoin-core-dev
179 2016-11-08T13:55:56  *** laurentmt has joined #bitcoin-core-dev
180 2016-11-08T14:01:20  *** laurentmt has quit IRC
181 2016-11-08T14:25:22  *** Guyver2 has joined #bitcoin-core-dev
182 2016-11-08T14:32:02  *** cryptapus_ has joined #bitcoin-core-dev
183 2016-11-08T14:32:02  *** cryptapus_ has joined #bitcoin-core-dev
184 2016-11-08T14:44:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
185 2016-11-08T14:45:40  *** d9b4bef9 has quit IRC
186 2016-11-08T14:47:19  *** d9b4bef9 has joined #bitcoin-core-dev
187 2016-11-08T14:56:41  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e5782438c3d...924de0bd75a7
188 2016-11-08T14:56:41  <bitcoin-git> bitcoin/master 1adf82a Jorge Timón: RPC: Give more details when "generate" fails
189 2016-11-08T14:56:42  <bitcoin-git> bitcoin/master 924de0b MarcoFalke: Merge #9087: RPC: why not give more details when "generate" fails?...
190 2016-11-08T14:56:50  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9087: RPC: why not give more details when "generate" fails? (master...0.13-errors-rpc-mining) https://github.com/bitcoin/bitcoin/pull/9087
191 2016-11-08T15:15:14  *** abpa has quit IRC
192 2016-11-08T15:20:05  *** cryptapus_ has quit IRC
193 2016-11-08T15:20:53  *** laurentmt has joined #bitcoin-core-dev
194 2016-11-08T15:30:20  *** cryptapus_ has joined #bitcoin-core-dev
195 2016-11-08T15:31:12  *** davec has joined #bitcoin-core-dev
196 2016-11-08T15:31:50  *** cryptapus_ has quit IRC
197 2016-11-08T15:32:06  *** cryptapus_ has joined #bitcoin-core-dev
198 2016-11-08T15:32:06  *** cryptapus_ has joined #bitcoin-core-dev
199 2016-11-08T15:32:15  *** cryptapus_ is now known as cryptapus
200 2016-11-08T15:39:41  *** Guyver2__ has joined #bitcoin-core-dev
201 2016-11-08T15:40:29  *** aalex has quit IRC
202 2016-11-08T15:42:30  *** laurentmt has quit IRC
203 2016-11-08T15:42:38  *** Guyver2 has quit IRC
204 2016-11-08T15:42:45  *** Guyver2__ is now known as Guyver2
205 2016-11-08T15:48:58  *** aalex has joined #bitcoin-core-dev
206 2016-11-08T16:00:15  *** rafalcpp has quit IRC
207 2016-11-08T16:00:23  *** rafalcpp has joined #bitcoin-core-dev
208 2016-11-08T16:02:37  *** laurentmt has joined #bitcoin-core-dev
209 2016-11-08T16:03:38  *** Guyver2 has quit IRC
210 2016-11-08T16:11:56  *** murch has quit IRC
211 2016-11-08T16:20:12  *** rafalcpp_ has joined #bitcoin-core-dev
212 2016-11-08T16:20:21  *** rafalcpp has quit IRC
213 2016-11-08T16:27:17  *** laurentmt has quit IRC
214 2016-11-08T16:38:34  *** Squidicuz has quit IRC
215 2016-11-08T16:45:03  *** testnet has quit IRC
216 2016-11-08T16:45:33  *** testnet has joined #bitcoin-core-dev
217 2016-11-08T16:46:38  *** Guyver2 has joined #bitcoin-core-dev
218 2016-11-08T16:55:43  *** abpa has joined #bitcoin-core-dev
219 2016-11-08T16:56:18  *** rafalcpp_ has quit IRC
220 2016-11-08T16:59:41  *** rubensayshi has quit IRC
221 2016-11-08T17:07:04  *** droark has quit IRC
222 2016-11-08T17:07:21  *** PRab has joined #bitcoin-core-dev
223 2016-11-08T17:09:27  *** BashCo has quit IRC
224 2016-11-08T17:10:06  *** BashCo has joined #bitcoin-core-dev
225 2016-11-08T17:10:39  *** rafalcpp has joined #bitcoin-core-dev
226 2016-11-08T17:14:24  *** BashCo has quit IRC
227 2016-11-08T17:17:41  *** Victorsueca has quit IRC
228 2016-11-08T17:20:02  *** Victorsueca has joined #bitcoin-core-dev
229 2016-11-08T17:40:33  *** aalex has quit IRC
230 2016-11-08T17:41:50  *** BashCo has joined #bitcoin-core-dev
231 2016-11-08T17:50:01  *** aalex has joined #bitcoin-core-dev
232 2016-11-08T17:56:01  *** CubicEarth has joined #bitcoin-core-dev
233 2016-11-08T18:03:36  *** davec has quit IRC
234 2016-11-08T18:10:01  *** DigiByteDev has quit IRC
235 2016-11-08T18:31:58  *** bsm1175321 has quit IRC
236 2016-11-08T18:35:35  *** bsm1175321 has joined #bitcoin-core-dev
237 2016-11-08T18:40:51  *** paveljanik has joined #bitcoin-core-dev
238 2016-11-08T18:40:52  *** paveljanik has joined #bitcoin-core-dev
239 2016-11-08T18:42:22  *** CubicEarth has quit IRC
240 2016-11-08T18:45:38  *** davec has joined #bitcoin-core-dev
241 2016-11-08T18:51:33  *** PRab has quit IRC
242 2016-11-08T19:11:55  <gmaxwell> sipa: so perhaps the mempool saving functionality should be saving the mempoolminfee... as it goes to zero after a restart.
243 2016-11-08T19:15:57  <sipa> gmaxwell: good point
244 2016-11-08T19:16:00  <sipa> file an issue
245 2016-11-08T19:17:51  <gmaxwell> sipa: #9103
246 2016-11-08T19:17:52  <gribble> https://github.com/bitcoin/bitcoin/issues/9103 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
247 2016-11-08T19:29:47  *** testnet has quit IRC
248 2016-11-08T19:34:36  <morcos> sipa: i also thought mempool saving was going to be optional?
249 2016-11-08T19:35:15  <morcos> on a separately question, is it fine to leave a bunch of BOOST_TEST_MESSAGE(..) in unit_tests or will they slow them down...
250 2016-11-08T19:35:37  <morcos> coins_tests are so complicated, might be useful to not have to readd all this debugging information next time they are changed
251 2016-11-08T19:36:26  *** bsm1175321 has quit IRC
252 2016-11-08T19:36:28  *** Guest89259 has joined #bitcoin-core-dev
253 2016-11-08T19:36:53  *** bsm1175321 has joined #bitcoin-core-dev
254 2016-11-08T19:38:07  *** Guest89259 is now known as roidster
255 2016-11-08T19:43:51  *** testnet has joined #bitcoin-core-dev
256 2016-11-08T19:58:57  *** harrymm has quit IRC
257 2016-11-08T20:03:48  <BlueMatt> jtimon: cool, thanks
258 2016-11-08T20:16:54  *** harrymm has joined #bitcoin-core-dev
259 2016-11-08T20:27:07  <jtimon> wumpus: instagibbs I added the reindex rpc tests to #8994, to test #9102 (well, and #8994 in general), if you think of other rpc tests that would be interesting to duplicate for this or default values for the custom chain (ie maybe consensus.BIP34Height = 0 or whatever ) please let me know
260 2016-11-08T20:27:08  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
261 2016-11-08T20:27:10  <gribble> https://github.com/bitcoin/bitcoin/issues/9102 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
262 2016-11-08T20:27:11  <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
263 2016-11-08T20:28:10  <jtimon> strangely enough locally walletbackup is failing, but only when I run all of them, not when I run it individually, there must be something I haven't cleanup up properly because travis seems to be happy
264 2016-11-08T20:39:42  *** whphhg has joined #bitcoin-core-dev
265 2016-11-08T20:42:06  <sdaftuar> jtimon: if you're seeing failures related to block sync failure in sync_blocks(), there's a good chance that
266 2016-11-08T20:42:41  <sdaftuar> is related to #9058
267 2016-11-08T20:42:43  <gribble> https://github.com/bitcoin/bitcoin/issues/9058 | Fixes for p2p-compactblocks.py test timeouts on travis (#8842) by ryanofsky · Pull Request #9058 · bitcoin/bitcoin · GitHub
268 2016-11-08T20:44:48  <jtimon> I'm not really sure what's happening, it's not a very clear error and the fact that walletbackup passes individually makes it more weird, but I will take a look, thanks
269 2016-11-08T20:47:10  *** juscamarena has joined #bitcoin-core-dev
270 2016-11-08T20:48:05  *** e4xit has quit IRC
271 2016-11-08T20:52:42  *** juscamarena has quit IRC
272 2016-11-08T21:00:29  *** whphhg is now known as montau
273 2016-11-08T21:02:29  *** cryptapus has quit IRC
274 2016-11-08T21:04:12  *** juscamarena has joined #bitcoin-core-dev
275 2016-11-08T21:07:18  <bitcoin-git> [bitcoin] morcos opened pull request #9107: Safer modify new coins (master...saferModifyNewCoins) https://github.com/bitcoin/bitcoin/pull/9107
276 2016-11-08T21:49:19  *** jtimon has quit IRC
277 2016-11-08T22:01:15  *** droark has joined #bitcoin-core-dev
278 2016-11-08T22:04:46  *** aalex has quit IRC
279 2016-11-08T22:05:40  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9108: WIP: Use importmulti timestamp when importing watch only keys (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108
280 2016-11-08T22:06:45  *** Guyver2 has quit IRC
281 2016-11-08T22:25:13  <gmaxwell> morcos: it's optional, you can totally kill -9 the process instead of calling stop. :P
282 2016-11-08T22:25:43  <gmaxwell> (I suppose it would be reasonable to add an option to let people disable it, though I don't know why anyone would set it, except perhaps saving 150 mb of disk space.
283 2016-11-08T22:29:57  <sipa> morcos: i'm not opposed to making it optional, i just didn't think it was a requirement for the first PR
284 2016-11-08T22:34:11  <sipa> gmaxwell: i assume you're joking, but there are downsides to killing that may be worse, like not storing the latest blocks' effect to disk
285 2016-11-08T22:39:26  *** roidster has quit IRC
286 2016-11-08T22:42:50  <cfields> sdaftuar: regarding #9026, did you consider adding fMayBanPeerIfInvalid to CState rather than passing it around? I realize it's merged, just curious after starting to review 9075
287 2016-11-08T22:42:52  <gribble> https://github.com/bitcoin/bitcoin/issues/9026 | Fix handling of invalid compact blocks by sdaftuar · Pull Request #9026 · bitcoin/bitcoin · GitHub
288 2016-11-08T22:44:10  <sipa> cfields: i dislike turning CValidationState into an input parameter as well
289 2016-11-08T22:49:24  <cfields> sipa: fair enough, I suppose that would be the only input. I was thinking there were already some there.
290 2016-11-08T22:53:34  <gmaxwell> sipa: well we should fix those downsides if they're actually a concern. :) losing a few blocks of verification should be a non-issue.
291 2016-11-08T22:54:27  <phantomcircuit> gmaxwell: i think it can be more than a few
292 2016-11-08T23:02:21  <sipa> gmaxwell: not needing a shutdown procedure is a nice design principle, but i don't think we're there
293 2016-11-08T23:07:47  <gmaxwell> seems pretty fine to me.
294 2016-11-08T23:07:57  *** btcdrak has quit IRC
295 2016-11-08T23:30:21  *** cdecker has quit IRC
296 2016-11-08T23:32:01  *** droark has quit IRC
297 2016-11-08T23:32:41  *** droark has joined #bitcoin-core-dev