1 2017-01-10T00:03:01  *** d9b4bef9 has quit IRC
  2 2017-01-10T00:04:08  *** d9b4bef9 has joined #bitcoin-core-dev
  3 2017-01-10T00:28:51  *** chjj has quit IRC
  4 2017-01-10T00:38:05  *** blkdb has quit IRC
  5 2017-01-10T00:38:25  *** blkdb has joined #bitcoin-core-dev
  6 2017-01-10T00:43:04  *** Saucery has joined #bitcoin-core-dev
  7 2017-01-10T00:43:31  *** chjj has joined #bitcoin-core-dev
  8 2017-01-10T00:47:51  *** chjj has quit IRC
  9 2017-01-10T00:59:32  *** LeMiner2 has joined #bitcoin-core-dev
 10 2017-01-10T01:01:16  *** chjj has joined #bitcoin-core-dev
 11 2017-01-10T01:01:46  *** LeMiner has quit IRC
 12 2017-01-10T01:01:46  *** LeMiner2 is now known as LeMiner
 13 2017-01-10T01:01:53  *** abpa has quit IRC
 14 2017-01-10T01:37:28  *** Ylbam has quit IRC
 15 2017-01-10T01:37:48  *** Saucery has quit IRC
 16 2017-01-10T01:40:11  *** abpa has joined #bitcoin-core-dev
 17 2017-01-10T02:03:14  *** abpa has quit IRC
 18 2017-01-10T02:25:18  <bitcoin-git> [bitcoin] achow101 opened pull request #9500: [Qt][RPC] Autocomplete commands for 'help' command in debug console (master...help-rpc-autocomplete) https://github.com/bitcoin/bitcoin/pull/9500
 19 2017-01-10T03:14:50  *** wasi has quit IRC
 20 2017-01-10T03:34:49  *** jtimon has quit IRC
 21 2017-01-10T04:20:21  *** chris2000 has joined #bitcoin-core-dev
 22 2017-01-10T04:23:40  *** chris200_ has quit IRC
 23 2017-01-10T05:11:52  <Lightsword> what conditions would cause me to hit this inconclusive for submitblock? https://github.com/bitcoin/bitcoin/blob/0.13/src/rpc/mining.cpp#L776
 24 2017-01-10T05:21:24  <luke-jr> Lightsword: block submitted is not on the longest chain, and therefore was not fully verified
 25 2017-01-10T05:21:39  <luke-jr> eg, stale block
 26 2017-01-10T05:24:49  <Lightsword> luke-jr, so it’s possible to hit that when doing a duplicate submit right?
 27 2017-01-10T05:25:20  <luke-jr> shouldn't be. duplicate is explicitly detected
 28 2017-01-10T05:25:44  <Lightsword> luke-jr, that’s what I thought…but seems you can get that from a duplicate…probably timing dependent
 29 2017-01-10T05:26:02  <luke-jr> oh, maybe if the duplicate is of an inconclusive block?
 30 2017-01-10T05:26:08  <luke-jr> eg, the first submit was inconclusive
 31 2017-01-10T05:26:41  <Lightsword> actually in this case the block first came in over p2p and was then submitted over the RPC at almost the exact same time
 32 2017-01-10T05:27:28  <luke-jr> that doesn't change much
 33 2017-01-10T05:27:54  <Lightsword> hmm, looks like the block came in over p2p in the middle of submitblock actually
 34 2017-01-10T05:29:26  <phantomcircuit> Lightsword, duplicate-inconclusive is a thing
 35 2017-01-10T05:30:12  <Lightsword> phantomcircuit, well duplicate-inconclusive was not what submit block returned, it returned a plain “inconclusive”
 36 2017-01-10T05:31:31  <phantomcircuit> that means the block wasn't already seen was accepted but is not in the main chain
 37 2017-01-10T05:34:01  <Lightsword> phantomcircuit, so that response is given after being accepted but before updatetip?
 38 2017-01-10T05:36:32  <phantomcircuit> Lightsword, a block can be accepted even if it doesn't update the tip iirc
 39 2017-01-10T05:37:24  <profall> I have an issue where my bitcoin core daemon goes out of sync for no reason at all. Plenty of peers and in a proper datacenter. It's a server with an E3 processor and 16GB of Ram, not a resource isssue.
 40 2017-01-10T05:38:23  <profall> It'll run for 24 or 36 hours on the correct block if you compare it in real-time to blockchain.info or wherever, then randomly it'll just stop syncing.
 41 2017-01-10T05:39:52  <phantomcircuit> profall, what version?
 42 2017-01-10T05:40:25  <profall> bitcoin-0.13.2-x86_64-linux-gnu.tar.gz right off the website.
 43 2017-01-10T05:40:59  <profall> (obviously extracted it...)
 44 2017-01-10T05:41:46  <phantomcircuit> bitcoin-cli getinfo how many peers?
 45 2017-01-10T05:42:12  <profall> 69
 46 2017-01-10T05:47:09  <phantomcircuit> profall, how far behind?
 47 2017-01-10T05:47:40  <profall> It'll go 50 blocks behind sometimes until I manually intervene. I simply stop bitcoind and start it again.
 48 2017-01-10T05:47:48  <profall> It'll resync right away.
 49 2017-01-10T05:48:25  <phantomcircuit> hmm
 50 2017-01-10T05:48:51  <profall> I mean, maybe the datacenter is having connection issues? It's like the only thing I can think of I guess ill put in a ticket.
 51 2017-01-10T05:49:22  <profall> Everything else works fine though on that server, so I feel like it's not related to the internet connection.
 52 2017-01-10T05:52:02  <phantomcircuit> uh
 53 2017-01-10T05:52:07  <phantomcircuit> is this by chance in the bay area
 54 2017-01-10T05:52:12  <profall> No
 55 2017-01-10T05:54:59  <phantomcircuit> BlueMatt, ^
 56 2017-01-10T05:56:28  <phantomcircuit> profall, if you run getpeerinfo is there one peer with a bunch of blocks in flight?
 57 2017-01-10T06:12:36  <Lightsword> phantomcircuit, so I guess when parsing submitblock responses inconclusive can potentially mean duplicate and that the tip just hasn’t updated yet?
 58 2017-01-10T06:15:15  *** wasi has joined #bitcoin-core-dev
 59 2017-01-10T06:18:51  *** dgenr8 has quit IRC
 60 2017-01-10T06:19:06  *** dgenr8 has joined #bitcoin-core-dev
 61 2017-01-10T06:22:23  <gmaxwell> profall: that is very interesting and unusual. Can you check the time on that host (including timezone)?  Do you have a debug log covering one of these events?
 62 2017-01-10T06:51:05  *** windsok has quit IRC
 63 2017-01-10T06:52:31  *** tunafizz has quit IRC
 64 2017-01-10T07:02:30  *** Ylbam has joined #bitcoin-core-dev
 65 2017-01-10T07:10:04  *** tunafizz has joined #bitcoin-core-dev
 66 2017-01-10T07:29:28  *** kadoban has quit IRC
 67 2017-01-10T07:29:37  *** windsok has joined #bitcoin-core-dev
 68 2017-01-10T07:29:55  *** kadoban has joined #bitcoin-core-dev
 69 2017-01-10T08:02:59  *** kadoban has quit IRC
 70 2017-01-10T08:03:24  *** kadoban has joined #bitcoin-core-dev
 71 2017-01-10T08:07:01  *** BashCo has quit IRC
 72 2017-01-10T08:07:38  *** BashCo has joined #bitcoin-core-dev
 73 2017-01-10T08:12:02  *** BashCo has quit IRC
 74 2017-01-10T08:28:43  *** BashCo has joined #bitcoin-core-dev
 75 2017-01-10T08:47:24  *** MarcoFalke has joined #bitcoin-core-dev
 76 2017-01-10T08:49:06  *** justanotheruser has quit IRC
 77 2017-01-10T08:58:27  *** Guyver2 has joined #bitcoin-core-dev
 78 2017-01-10T08:59:47  *** justanotheruser has joined #bitcoin-core-dev
 79 2017-01-10T09:04:19  *** jannes has joined #bitcoin-core-dev
 80 2017-01-10T09:08:25  *** paveljanik has quit IRC
 81 2017-01-10T09:15:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/07fd147b9f12...98c80e374b84
 82 2017-01-10T09:15:45  <bitcoin-git> bitcoin/master 7df5e38 Pavel Janík: Rename lambda argument name to prevent shadowing.
 83 2017-01-10T09:15:45  <bitcoin-git> bitcoin/master 98c80e3 MarcoFalke: Merge #9496: Rename lambda argument name to prevent shadowing...
 84 2017-01-10T09:16:00  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9496: Rename lambda argument name to prevent shadowing (master...20170109_Wshadow_rpcconsole_lambda) https://github.com/bitcoin/bitcoin/pull/9496
 85 2017-01-10T09:35:19  *** petertodd has quit IRC
 86 2017-01-10T09:37:17  *** eenoch has quit IRC
 87 2017-01-10T09:37:18  *** kallewoof has quit IRC
 88 2017-01-10T09:37:18  *** warren has quit IRC
 89 2017-01-10T09:37:19  *** lesderid has quit IRC
 90 2017-01-10T09:37:19  *** thestringpuller has quit IRC
 91 2017-01-10T09:37:26  *** lesderid has joined #bitcoin-core-dev
 92 2017-01-10T09:37:30  *** eenoch has joined #bitcoin-core-dev
 93 2017-01-10T09:37:31  *** thestringpuller has joined #bitcoin-core-dev
 94 2017-01-10T09:37:34  *** kallewoof has joined #bitcoin-core-dev
 95 2017-01-10T09:37:54  *** thestringpuller is now known as Guest94281
 96 2017-01-10T09:38:25  *** warren has joined #bitcoin-core-dev
 97 2017-01-10T09:38:47  *** Guyver2 has quit IRC
 98 2017-01-10T09:38:47  *** Squidicuz has quit IRC
 99 2017-01-10T09:38:48  *** morcos has quit IRC
100 2017-01-10T09:38:49  *** amiller has quit IRC
101 2017-01-10T09:38:50  *** mr_burdell has quit IRC
102 2017-01-10T09:38:56  *** mr_burdell has joined #bitcoin-core-dev
103 2017-01-10T09:39:07  *** echonaut has quit IRC
104 2017-01-10T09:39:07  *** thermoman has quit IRC
105 2017-01-10T09:39:08  *** jeremyrubin has quit IRC
106 2017-01-10T09:39:11  *** niska` has quit IRC
107 2017-01-10T09:39:14  *** jeremyru1in has joined #bitcoin-core-dev
108 2017-01-10T09:39:16  *** thermoman has joined #bitcoin-core-dev
109 2017-01-10T09:39:17  *** niska has joined #bitcoin-core-dev
110 2017-01-10T09:39:23  *** echonaut has joined #bitcoin-core-dev
111 2017-01-10T09:39:49  *** Guest5911 has joined #bitcoin-core-dev
112 2017-01-10T09:41:32  *** profall has quit IRC
113 2017-01-10T09:42:27  *** LeMiner2 has joined #bitcoin-core-dev
114 2017-01-10T09:43:35  *** justanotheruser has quit IRC
115 2017-01-10T09:44:00  *** morcos has joined #bitcoin-core-dev
116 2017-01-10T09:44:03  *** profall has joined #bitcoin-core-dev
117 2017-01-10T09:44:54  *** LeMiner has quit IRC
118 2017-01-10T09:44:54  *** LeMiner2 is now known as LeMiner
119 2017-01-10T09:55:00  *** justanotheruser has joined #bitcoin-core-dev
120 2017-01-10T10:06:32  *** BashCo_ has joined #bitcoin-core-dev
121 2017-01-10T10:09:52  *** BashCo has quit IRC
122 2017-01-10T10:20:07  *** Guyver2 has joined #bitcoin-core-dev
123 2017-01-10T10:49:04  *** petertodd has joined #bitcoin-core-dev
124 2017-01-10T11:09:15  *** laurentmt has joined #bitcoin-core-dev
125 2017-01-10T11:10:08  *** laurentmt has quit IRC
126 2017-01-10T11:30:22  *** emmmork has quit IRC
127 2017-01-10T11:58:36  *** BashCo has joined #bitcoin-core-dev
128 2017-01-10T12:01:35  *** BashCo_ has quit IRC
129 2017-01-10T12:08:37  *** emmmork has joined #bitcoin-core-dev
130 2017-01-10T12:35:10  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/68eb56203be17066af4e37837703490af4d4f40c
131 2017-01-10T12:35:10  <bitcoin-git> bitcoin/master 68eb562 Wladimir J. van der Laan: qt: periodic translations update
132 2017-01-10T12:37:24  *** LeMiner2 has joined #bitcoin-core-dev
133 2017-01-10T12:39:54  *** LeMiner has quit IRC
134 2017-01-10T12:39:54  *** LeMiner2 is now known as LeMiner
135 2017-01-10T12:45:16  *** AaronvanW has joined #bitcoin-core-dev
136 2017-01-10T12:45:17  *** AaronvanW has quit IRC
137 2017-01-10T12:45:17  *** AaronvanW has joined #bitcoin-core-dev
138 2017-01-10T13:14:29  *** wump is now known as wumpus
139 2017-01-10T13:15:15  <bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/68eb56203be1...5754e0341b7c
140 2017-01-10T13:15:16  <bitcoin-git> bitcoin/master 5865d41 Wladimir J. van der Laan: authproxy: Add support for RPC named arguments
141 2017-01-10T13:15:16  <bitcoin-git> bitcoin/master 6f1c76a Wladimir J. van der Laan: rpc: Support named arguments...
142 2017-01-10T13:15:17  <bitcoin-git> bitcoin/master 495eb44 Wladimir J. van der Laan: rpc: Named arguments for blockchain calls
143 2017-01-10T13:24:32  *** chjj has quit IRC
144 2017-01-10T13:26:32  *** Chris_Stewart_5 has quit IRC
145 2017-01-10T13:41:02  *** Chris_Stewart_5 has joined #bitcoin-core-dev
146 2017-01-10T13:41:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
147 2017-01-10T13:49:56  *** jtimon has joined #bitcoin-core-dev
148 2017-01-10T13:55:39  *** Sosumi has joined #bitcoin-core-dev
149 2017-01-10T13:57:56  *** chjj has joined #bitcoin-core-dev
150 2017-01-10T14:11:29  *** Chris_Stewart_5 has quit IRC
151 2017-01-10T14:27:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
152 2017-01-10T14:29:35  *** wasi has quit IRC
153 2017-01-10T14:30:00  *** wasi has joined #bitcoin-core-dev
154 2017-01-10T14:31:38  *** wasi has quit IRC
155 2017-01-10T14:32:01  *** wasi has joined #bitcoin-core-dev
156 2017-01-10T14:48:06  *** Chris_Stewart_5 has quit IRC
157 2017-01-10T15:00:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
158 2017-01-10T15:13:53  *** Chris_Stewart_5 has quit IRC
159 2017-01-10T15:27:18  *** BashCo has quit IRC
160 2017-01-10T15:28:04  *** BashCo has joined #bitcoin-core-dev
161 2017-01-10T15:28:07  *** Squidicuz has joined #bitcoin-core-dev
162 2017-01-10T15:29:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
163 2017-01-10T15:32:17  *** BashCo has quit IRC
164 2017-01-10T15:33:32  <jonasschnelli> instagibbs: can you help me parsing your comment... :)
165 2017-01-10T15:33:32  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/9294/files#r95169601
166 2017-01-10T15:33:35  <jonasschnelli> (or anyone)
167 2017-01-10T15:33:43  <jonasschnelli> I don't understand it
168 2017-01-10T15:35:08  <instagibbs> jonasschnelli, in one commit you go from 0 internal to 50/50 external/internal, to 100/20
169 2017-01-10T15:35:13  <instagibbs> in the next
170 2017-01-10T15:35:21  <instagibbs> I just find that a bit odd
171 2017-01-10T15:35:30  <jonasschnelli> Ah. The commit order...
172 2017-01-10T15:35:46  <jonasschnelli> Yes. I force pushed it in a confusing way.
173 2017-01-10T15:35:46  <instagibbs> yeah, not blocking, I just got confused when reviewing commit by commit
174 2017-01-10T15:36:06  <instagibbs> I think logically it's not broken at any point
175 2017-01-10T15:39:23  <jonasschnelli> I think I squash the commits.
176 2017-01-10T15:39:32  <jonasschnelli> It's one single change
177 2017-01-10T15:51:03  <instagibbs> is #9400 reasonable for 0.14? It's gotten decent amount of review, and is a pretty small change
178 2017-01-10T15:51:06  <gribble> https://github.com/bitcoin/bitcoin/issues/9400 | Set peers as HB peers upon full block validation by instagibbs · Pull Request #9400 · bitcoin/bitcoin · GitHub
179 2017-01-10T15:54:05  * jonasschnelli invites instagibbs to re-review #9294 (thanks!)
180 2017-01-10T15:54:07  <gribble> https://github.com/bitcoin/bitcoin/issues/9294 | Use internal HD chain for change outputs (hd split) by jonasschnelli · Pull Request #9294 · bitcoin/bitcoin · GitHub
181 2017-01-10T16:00:22  <instagibbs> well since you asked nicely
182 2017-01-10T16:05:47  *** Guest5911 has quit IRC
183 2017-01-10T16:05:47  *** Guest5911 has joined #bitcoin-core-dev
184 2017-01-10T16:05:47  *** Guest5911 is now known as amiller
185 2017-01-10T16:08:44  <jonasschnelli> Thanks for the review instagibbs: I owe you a review now!
186 2017-01-10T16:09:21  *** BashCo has joined #bitcoin-core-dev
187 2017-01-10T16:09:22  *** xiangfu has quit IRC
188 2017-01-10T16:09:51  *** fengling has quit IRC
189 2017-01-10T16:19:26  *** fengling has joined #bitcoin-core-dev
190 2017-01-10T16:21:53  *** xiangfu has joined #bitcoin-core-dev
191 2017-01-10T16:27:34  *** xinxi has joined #bitcoin-core-dev
192 2017-01-10T16:27:56  <xinxi> cfields: ping. I have a question about codesigning binaries using gitian.
193 2017-01-10T16:28:49  <cfields> xinxi: hi, shoot
194 2017-01-10T16:29:50  <xinxi> ./bin/gbuild -i --commit signature=master ../litecoin/contrib/gitian-descriptors/gitian-win-signer.yml
195 2017-01-10T16:29:50  <xinxi> --- Building for trusty amd64 ---
196 2017-01-10T16:29:51  <xinxi> Stopping target if it is up
197 2017-01-10T16:29:52  <xinxi> Starting target
198 2017-01-10T16:29:54  <xinxi> Checking if target is up..............................
199 2017-01-10T16:29:56  <xinxi> sudo: unknown user: ubuntu
200 2017-01-10T16:29:58  <xinxi> sudo: unable to initialize policy plugin
201 2017-01-10T16:30:00  <xinxi> ./bin/gbuild:21:in `system!': failed to run on-target true (RuntimeError)
202 2017-01-10T16:30:02  <xinxi>     from ./bin/gbuild:73:in `build_one_configuration'
203 2017-01-10T16:30:04  <xinxi>     from ./bin/gbuild:285:in `block (2 levels) in <main>'
204 2017-01-10T16:30:06  <xinxi>     from ./bin/gbuild:280:in `each'
205 2017-01-10T16:30:08  <xinxi>     from ./bin/gbuild:280:in `block in <main>'
206 2017-01-10T16:30:10  <xinxi>     from ./bin/gbuild:278:in `each'
207 2017-01-10T16:30:12  <xinxi>     from ./bin/gbuild:278:in `<main>'
208 2017-01-10T16:30:14  <xinxi> [11:43]
209 2017-01-10T16:30:16  <xinxi> I changed ubuntu -> debian
210 2017-01-10T16:30:19  <xinxi> I got the above error when I was compiling Litecoin.
211 2017-01-10T16:30:20  <cfields> xinxi: ahh, paste somewhere please!
212 2017-01-10T16:30:29  <xinxi> oops
213 2017-01-10T16:31:03  <cfields> xinxi: need to look at the log, the above doesn't tell much
214 2017-01-10T16:32:15  <xinxi> where is the log? no path is shown above.
215 2017-01-10T16:32:46  <cfields> xinxi: ./var/build.log
216 2017-01-10T16:33:16  <xinxi> there is only var/install.log
217 2017-01-10T16:33:23  <xinxi> but it seems not relevant.
218 2017-01-10T16:34:03  <achow101> that means that the build hasn't started yet and it was still updating stuff
219 2017-01-10T16:34:34  <cfields> xinxi: wait, why did you change ubuntu -> debian?
220 2017-01-10T16:34:55  <cfields> xinxi: unknown ubuntu user seems relevant in that case :)
221 2017-01-10T16:34:59  <xinxi> I am compiling on debian.
222 2017-01-10T16:35:23  <xinxi> let me change back.
223 2017-01-10T16:35:35  <cfields> xinxi: doesn't matter, this is creating a vm for you
224 2017-01-10T16:36:51  <xinxi> I just changed back and am compiling again. it seems a bit different now.
225 2017-01-10T16:37:33  <btcdrak> xinxi: use pastebin/0bin please
226 2017-01-10T16:37:50  <xinxi> yeah, just noticed it. sorry about that.
227 2017-01-10T16:40:14  <xinxi> cfields: got a new error: http://pastebin.com/JA4rtscY
228 2017-01-10T16:42:21  <cfields> xinxi: have you signed the binaries and created detached sigs?
229 2017-01-10T16:42:35  <xinxi> yeah, I have.
230 2017-01-10T16:43:22  <xinxi> I got the .assert and .assert.sig files.
231 2017-01-10T16:43:47  <cfields> xinxi: since this isn't bitcoin related, let's go to pm
232 2017-01-10T16:43:58  <instagibbs> 0.13.1 and other NODE_WITNESS only ask for txn from witness peers, right?
233 2017-01-10T16:45:16  <sipa> instagibbs: i don't think so, but i forget
234 2017-01-10T16:50:46  *** abpa has joined #bitcoin-core-dev
235 2017-01-10T16:54:58  <phantomcircuit> cfields, on 9441 the indentation in ba4cae284f6acac4bbbfe08c89dcb8c2ace5da83 is screwed
236 2017-01-10T16:55:33  <cfields> phantomcircuit: yea, i left the indentation alone, otherwise the diff would've been a bloodbath
237 2017-01-10T16:55:54  <cfields> i'll do a whitespace follow-up
238 2017-01-10T16:55:57  <phantomcircuit> cfields, also please use {} for all if statements
239 2017-01-10T16:56:09  <phantomcircuit> kind of makes indentation issues less relevant
240 2017-01-10T16:56:30  <phantomcircuit> the way it is now it looks like nothing will ever run because of the indentation
241 2017-01-10T16:58:00  <cfields> phantomcircuit: fair enough. where in particular?
242 2017-01-10T16:59:04  <phantomcircuit> the fDisconnect check mainly
243 2017-01-10T16:59:34  <phantomcircuit> also probably swap the fDisconnect and !vRecvGetData.empty() checks since ProcessGetData can set fDisconnect
244 2017-01-10T17:00:16  <phantomcircuit> (left these comments on github too)
245 2017-01-10T17:01:36  <cfields> phantomcircuit: ah, they make more sense in context. thanks :)
246 2017-01-10T17:05:24  <phantomcircuit> cfields, it seems like we should disconnect on checksum and header validation issues actually
247 2017-01-10T17:05:32  <phantomcircuit> (we currently ignore them and go to the next message)
248 2017-01-10T17:05:55  <cfields> phantomcircuit: there are several things that should change about the behavior there, but i tried to leave as much alone as i could for this PR
249 2017-01-10T17:06:04  <phantomcircuit> alright
250 2017-01-10T17:06:10  <phantomcircuit> i'll refrain
251 2017-01-10T17:06:30  <cfields> phantomcircuit: agreed ofc, btw
252 2017-01-10T17:36:14  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9502: [Qt] Add option to pause/resume block downloads (master...2017/01/autodownload) https://github.com/bitcoin/bitcoin/pull/9502
253 2017-01-10T17:54:21  <instagibbs> sipa, oh right, definitely not the case since they wont relay non-std txns in general
254 2017-01-10T17:54:52  <sipa> indeed
255 2017-01-10T17:57:06  <jtimon> BlueMatt: it seems #9486 could use a better description, the description seems to only talk about the last commit, which seems trivial and overall unrelated to the rest, certainly I'm missing something
256 2017-01-10T17:57:08  <gribble> https://github.com/bitcoin/bitcoin/issues/9486 | Make peer=%d log prints consistent by TheBlueMatt · Pull Request #9486 · bitcoin/bitcoin · GitHub
257 2017-01-10T17:57:22  <sdaftuar> jtimon: see #9375
258 2017-01-10T17:57:25  <gribble> https://github.com/bitcoin/bitcoin/issues/9375 | Relay compact block messages prior to full block connection by TheBlueMatt · Pull Request #9375 · bitcoin/bitcoin · GitHub
259 2017-01-10T17:57:42  <sipa> jtimon: from the description "Based on #9375"
260 2017-01-10T17:57:46  <gribble> https://github.com/bitcoin/bitcoin/issues/9375 | Relay compact block messages prior to full block connection by TheBlueMatt · Pull Request #9375 · bitcoin/bitcoin · GitHub
261 2017-01-10T17:57:51  <sipa> ah, sdaftuar beat me
262 2017-01-10T17:58:26  <jtimon> yeah, thanks, reading now, read that and then forgot and tried to exact the leitmotiv from looking at the commits
263 2017-01-10T18:01:11  <jtimon> does https://github.com/bitcoin/bitcoin/pull/9486/commits/e6111b2398ca21f0e38333236abb0be7fa48c95f really need to be based on #9375 ? it seems it could be trivially merged independently
264 2017-01-10T18:01:13  <gribble> https://github.com/bitcoin/bitcoin/issues/9375 | Relay compact block messages prior to full block connection by TheBlueMatt · Pull Request #9375 · bitcoin/bitcoin · GitHub
265 2017-01-10T18:27:03  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #9503: listreceivedbyaddress Filter Address (master...listreceivedbyaddress-filtered) https://github.com/bitcoin/bitcoin/pull/9503
266 2017-01-10T18:34:29  *** xinxi has quit IRC
267 2017-01-10T18:34:56  *** xinxi has joined #bitcoin-core-dev
268 2017-01-10T18:39:13  *** xinxi has quit IRC
269 2017-01-10T19:02:25  *** gmaxwell has quit IRC
270 2017-01-10T19:08:46  *** xinxi has joined #bitcoin-core-dev
271 2017-01-10T19:12:49  *** gmaxwell has joined #bitcoin-core-dev
272 2017-01-10T19:18:50  <bitcoin-git> [bitcoin] achow101 opened pull request #9504: [RPC] dumpmasterprivkey command (master...dumpmasterprivkey) https://github.com/bitcoin/bitcoin/pull/9504
273 2017-01-10T19:42:07  *** PaulCapestany has quit IRC
274 2017-01-10T19:42:44  <BlueMatt> gmaxwell: heh, yea, so extra is worth it as-is, will push the use-less-memory thing for 0.15?
275 2017-01-10T19:44:25  <gmaxwell> BlueMatt: seems like it.
276 2017-01-10T19:44:30  <BlueMatt> cool
277 2017-01-10T19:46:29  *** LeMiner has quit IRC
278 2017-01-10T19:48:43  *** GAit has joined #bitcoin-core-dev
279 2017-01-10T19:52:24  *** PaulCapestany has joined #bitcoin-core-dev
280 2017-01-10T20:01:13  *** justanotheruser has quit IRC
281 2017-01-10T20:02:09  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #9505: Prevector Quick Destruct (master...prevector-quick-destruct) https://github.com/bitcoin/bitcoin/pull/9505
282 2017-01-10T20:06:31  <bitcoin-git> [bitcoin] sipa opened pull request #9506: RFC: Improve style for if indentation (master...newstyle) https://github.com/bitcoin/bitcoin/pull/9506
283 2017-01-10T20:19:22  *** Guest94281 is now known as thestringpuller
284 2017-01-10T20:19:29  *** thestringpuller has joined #bitcoin-core-dev
285 2017-01-10T20:28:58  *** dermoth_ has joined #bitcoin-core-dev
286 2017-01-10T20:29:26  *** dermoth has quit IRC
287 2017-01-10T20:29:28  *** dermoth_ is now known as dermoth
288 2017-01-10T20:31:35  *** cbits has joined #bitcoin-core-dev
289 2017-01-10T20:33:06  <bitcoin-git> [bitcoin] sdaftuar opened pull request #9507: Fix use-after-free in CTxMemPool::removeConflicts() (master...fix-mempool-useafterfree) https://github.com/bitcoin/bitcoin/pull/9507
290 2017-01-10T20:34:24  <bitcoin-git> [bitcoin] practicalswift opened pull request #9508: [gardening] Remove unused Python imports (master...remove-unused-python-import) https://github.com/bitcoin/bitcoin/pull/9508
291 2017-01-10T20:35:50  *** paveljanik has joined #bitcoin-core-dev
292 2017-01-10T20:58:28  <bitcoin-git> [bitcoin] theuni opened pull request #9509: build: fix qt distdir builds (master...out-of-tree-build) https://github.com/bitcoin/bitcoin/pull/9509
293 2017-01-10T21:02:21  *** xinxi has quit IRC
294 2017-01-10T21:04:59  *** cbits has quit IRC
295 2017-01-10T21:07:07  *** Sosumi has quit IRC
296 2017-01-10T21:44:57  *** harrymm has joined #bitcoin-core-dev
297 2017-01-10T21:48:39  <instagibbs> what's the functional/use difference between CCoinsViewCache::GetCoins and CCoinsViewCache::AccessCoins?
298 2017-01-10T21:49:04  <sipa> the latter is much faster
299 2017-01-10T21:49:10  <sipa> as it doesn't copy
300 2017-01-10T21:49:34  <sipa> so why would you use the first? AccessCoins only exists in CCoinsViewCache, while GetCoins exists in every CCoins implementation
301 2017-01-10T21:49:41  <sipa> *every CCoinsView
302 2017-01-10T21:49:56  *** waxwing has joined #bitcoin-core-dev
303 2017-01-10T21:50:19  <instagibbs> thanks, let me see if that explains its various uses to me
304 2017-01-10T21:56:09  <bitcoin-git> [bitcoin] practicalswift opened pull request #9510: [gardening] Fix typos in comments (master...fix-typos-in-comments) https://github.com/bitcoin/bitcoin/pull/9510
305 2017-01-10T22:00:41  <bitcoin-git> [bitcoin] morcos opened pull request #9511: Don't overwrite validation state with corruption check (master...ATMPstate) https://github.com/bitcoin/bitcoin/pull/9511
306 2017-01-10T22:02:44  *** xinxi has joined #bitcoin-core-dev
307 2017-01-10T22:06:03  *** Guyver2 has quit IRC
308 2017-01-10T22:10:35  *** molz has quit IRC
309 2017-01-10T22:13:14  <gmaxwell> sipa: BlueMatt has a nit on #9472
310 2017-01-10T22:13:16  <gribble> https://github.com/bitcoin/bitcoin/issues/9472 | Disentangle progress estimation from checkpoints and update it by sipa · Pull Request #9472 · bitcoin/bitcoin · GitHub
311 2017-01-10T22:14:59  <BlueMatt> are we gonna try to merge that for 14 too?
312 2017-01-10T22:15:25  <gmaxwell> sure, it's done its ... has about zero potential to break anything.
313 2017-01-10T22:15:53  <sipa> it would be nice to say that we're only using checkpoints for avoiding a memory-bloating low-difficulty header attack
314 2017-01-10T22:16:01  <sipa> it would be even nicer to say we're not using them at all anymore
315 2017-01-10T22:16:19  *** AaronvanW has quit IRC
316 2017-01-10T22:16:50  <gmaxwell> yes, well... we could have been there, but
317 2017-01-10T22:17:51  <gmaxwell> I don't have a solution for that which doesn't need something which is technically a consensus rule change.
318 2017-01-10T22:18:47  <gmaxwell> https://github.com/gmaxwell/bitcoin/commit/09cef642e7d7866cb7b7026a453e1c791c191ddf
319 2017-01-10T22:18:55  <gmaxwell> oops wrong commit
320 2017-01-10T22:19:02  <gmaxwell> https://github.com/gmaxwell/bitcoin/commit/2db190b183c5204da23191ca642c7f6cad412ae3
321 2017-01-10T22:20:29  *** emmmork has quit IRC
322 2017-01-10T22:22:04  *** xinxi has quit IRC
323 2017-01-10T22:25:57  *** cbits has joined #bitcoin-core-dev
324 2017-01-10T23:05:51  *** belcher has quit IRC
325 2017-01-10T23:15:29  *** fresn3ll has joined #bitcoin-core-dev
326 2017-01-10T23:17:54  <bitcoin-git> [bitcoin] sipa opened pull request #9512: Fix various things -fsanitize complains about (master...sanitize) https://github.com/bitcoin/bitcoin/pull/9512
327 2017-01-10T23:19:00  *** belcher has joined #bitcoin-core-dev
328 2017-01-10T23:19:01  *** xinxi has joined #bitcoin-core-dev
329 2017-01-10T23:21:44  *** NicolasDorier has quit IRC
330 2017-01-10T23:22:17  *** chjj has quit IRC
331 2017-01-10T23:23:13  *** mappum has quit IRC
332 2017-01-10T23:25:56  *** NicolasDorier has joined #bitcoin-core-dev
333 2017-01-10T23:25:56  *** mappum has joined #bitcoin-core-dev
334 2017-01-10T23:36:10  *** xinxi has quit IRC
335 2017-01-10T23:36:56  <dcousens> can prioritisetransaction work on txids that aren't yet in the mempool?
336 2017-01-10T23:37:17  <dcousens> I assume no,  in which case,  it might an idea to allow that as an option or maybe allow sendrawtransaction to have a feedelta field?
337 2017-01-10T23:37:28  <dcousens> (uh,  a 'virtual fee' field)
338 2017-01-10T23:40:03  <sipa> yes, it can
339 2017-01-10T23:40:57  <dcousens> sipa: awesome :)
340 2017-01-10T23:42:08  <gmaxwell> dcousens: it writes it into mapDeltas.
341 2017-01-10T23:48:57  *** fresn3ll has quit IRC
342 2017-01-10T23:51:26  *** cbits has quit IRC
343 2017-01-10T23:57:10  *** chjj has joined #bitcoin-core-dev