12017-01-14T00:03:48  <midnightmagic> In src/core_write.cpp:ScriptToAsmStr() there is a check for an integer printout with 0 <= vch.size() <= 4 -- otherwise it prints out a hex string. But for decodescript 6900, (decoding to OP_VERIFY 0) the vch.size() I believe for the second byte is 0, rather than an actual 0x00, and so the decode works apparently by accident..? Am I missing something?
  22017-01-14T00:05:55  *** justanotheruser has joined #bitcoin-core-dev
  32017-01-14T00:06:29  <bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3908fc472805...e126d0c12ca6
  42017-01-14T00:06:30  <bitcoin-git> bitcoin/master 997a98a Gregory Maxwell: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast....
  52017-01-14T00:06:30  <bitcoin-git> bitcoin/master 4b06e41 Suhas Daftuar: Add unit test for FindEarliestAtLeast
  62017-01-14T00:06:31  <bitcoin-git> bitcoin/master e126d0c Pieter Wuille: Merge #9490: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast....
  72017-01-14T00:06:42  <bitcoin-git> [bitcoin] sipa closed pull request #9490: Replace FindLatestBefore used by importmuti with FindEarliestAtLeast. (master...fix_find_latest_before) https://github.com/bitcoin/bitcoin/pull/9490
  82017-01-14T00:11:49  *** brg444 has joined #bitcoin-core-dev
  92017-01-14T00:21:03  *** xinxi has joined #bitcoin-core-dev
 102017-01-14T00:23:11  *** bsm117532 has joined #bitcoin-core-dev
 112017-01-14T00:25:19  *** xinxi has quit IRC
 122017-01-14T00:29:17  <cfields> sipa: good idea. I'm not exactly sure how to execute it though. I'd rather not trip up someone's manual efforts to enable sanitizers. Maybe add a --enable-sanitizers config option, off by default, that tries to turn on as many non-conflicting ones as possible?
 132017-01-14T00:29:42  <cfields> BlueMatt: woohoo! congrats on merge.
 142017-01-14T00:31:10  <sipa> cfields: we may need 2 or 3 separate builds with sanitizers, unfortunately
 152017-01-14T00:32:18  <sipa> cfields: but yes, optional sounds right
 162017-01-14T00:32:18  <cfields> sipa: right. Maybe there's no realistic way to add to configure, then? We can just handle with cflags for travis/gitian :(
 172017-01-14T00:32:34  *** brg444 has quit IRC
 182017-01-14T00:32:41  <sipa> you wouldn't want to enable sanitizers on production binaries, obviously
 192017-01-14T00:33:06  <cfields> right, it'd build both sets
 202017-01-14T00:33:42  <cfields> I suppose just doing it for travis would be a start
 212017-01-14T00:34:09  <cfields> we already have a slow, minimal build with debug cranked up for libstdc++.
 222017-01-14T00:36:39  <sipa> the sets you can do are 1) -fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer 2) -fsanitize=thread 3) -fsanitize=memory (clang only, and requires rebuild of all dependencies)
 232017-01-14T00:36:56  <sipa> i've only played around with the first for now
 242017-01-14T00:38:59  <cfields> is no-omit-frame-pointer needed for correctness? or just helpful backtraces?
 252017-01-14T00:39:18  <sipa> i am not sure
 262017-01-14T00:39:38  <cfields> that one might be tricky since it's enabled at -O2, iirc. Not sure what "-fno-omit-frame-pointer -O2" turns into
 272017-01-14T00:39:42  <cfields> ok
 282017-01-14T00:40:35  <sipa> i think individual -f things override the -O defaults
 292017-01-14T00:41:13  <cfields> i would hope so. My fear is that it's order-based, like warnings.
 302017-01-14T00:41:20  <sipa> ah
 312017-01-14T00:41:24  <sipa> seems likely
 322017-01-14T00:42:07  <cfields> if so, that'd be tricky, since -Ox sneak in all over the place.
 332017-01-14T00:42:10  <cfields> will mess around with 'em
 342017-01-14T00:45:32  *** juscamarena has quit IRC
 352017-01-14T00:45:51  *** juscamarena has joined #bitcoin-core-dev
 362017-01-14T00:47:20  *** abpa has quit IRC
 372017-01-14T00:47:21  *** brg444 has joined #bitcoin-core-dev
 382017-01-14T00:47:28  *** Ylbam has quit IRC
 392017-01-14T00:59:07  <BlueMatt> cfields: yea, feels good to get a few things in for 0.14....do feel bad that I havent done enough review this week and am holding up things like bumpfee :'(
 402017-01-14T00:59:19  <BlueMatt> will at least finish this review before going out :/
 412017-01-14T00:59:33  * BlueMatt hopes ryanofsky has time to spare this weekend
 422017-01-14T01:00:44  <cfields> heh. it'd be a rookie move to make plans the weekend before freeze/release :)
 432017-01-14T01:00:59  <BlueMatt> well he is a rookie, after all :p
 442017-01-14T01:01:07  <sipa> like 'participating in the mit mystery hunt'
 452017-01-14T01:01:12  <BlueMatt> (at least in bitcoin)
 462017-01-14T01:01:21  <sipa> or 'agreeing to review workshop papers with deadline the 15th' ?
 472017-01-14T01:01:21  <BlueMatt> heh, yea, what were you and gmaxwell thinking, sipa????
 482017-01-14T01:01:23  <BlueMatt> :P
 492017-01-14T01:01:23  <cfields> sipa: ahah, that's this weekend?
 502017-01-14T01:01:54  <sipa> i'll be so happy when i get back to california on tuesday
 512017-01-14T01:02:13  <sipa> all this vacation thing is too stressful
 522017-01-14T01:02:55  <cfields> heh
 532017-01-14T01:04:41  <cfields> jeremyrubin: are you still pushing for your checkqueue rewrite? I'm rebasing the interruptible threads, and just remembered how terribly inefficient that is. There are some easy gains for sure. But I won't mess with it if it's being nuked anyway.
 542017-01-14T01:07:07  <gmaxwell> cfields: we should be careful with '--enable' because there are users that run ./configure and then turn on every enable.
 552017-01-14T01:08:24  <luke-jr> sipa: note that -fsanitize=memory also has weird LLVM/kernel matching issues, and is basically impossible on Travis currently (I used to use it)
 562017-01-14T01:08:49  <cfields> gmaxwell: well --enable-debug would already be hurting them pretty badly :)
 572017-01-14T01:08:50  <sipa> luke-jr: ah, good to know
 582017-01-14T01:09:40  <gmaxwell> cfields: yea agreed we should probably fix that -- though at least that one says 'debug'.
 592017-01-14T01:09:40  <luke-jr> sipa: cfields: also, we absolutely should NOT use -fsanitize=x with prod binaries. they are not intended for that, and add exploits
 602017-01-14T01:09:49  <sipa> luke-jr: absolutely!
 612017-01-14T01:10:03  <bitcoin-git> [bitcoin] practicalswift opened pull request #9549: [net] Avoid possibility of NULL pointer dereference in MarkBlockAsInFlight(...) (master...avoid-potential-null-pointer-dereference-in-markblockasinflight) https://github.com/bitcoin/bitcoin/pull/9549
 622017-01-14T01:10:04  <gmaxwell> maybe making them -dev-debug -dev-sanatize-foo etc would be sufficient.
 632017-01-14T01:10:48  <gmaxwell> can someone tell him that if he thinks he actually has a possible null reref in code like that he should send it privately?
 642017-01-14T01:11:12  <gmaxwell> oh the description is okay
 652017-01-14T01:11:27  <gmaxwell> (ignore me)
 662017-01-14T01:11:37  <sipa> ideally i think those sanitize things should build separate binaries (bitcoind_san_X, test_bitcoin_san_X, ...)
 672017-01-14T01:11:52  <sipa> if that's at all possible
 682017-01-14T01:12:06  <sipa> maybe it's easier with a wrapper script around configure/make rather than inside the system
 692017-01-14T01:12:09  <luke-jr> is there a reason to special-case it at all? what's wrong with just passing CXXFLAGS?
 702017-01-14T01:12:35  <cfields> luke-jr: read the discussion above :)
 712017-01-14T01:12:47  <sipa> ideally, make check etc... build the multiple configurations and run all tests on all
 722017-01-14T01:13:02  <gmaxwell> As another side, we use the oneliners in our release notes but often our choice of them is really poor for this purpose.  Case in point ^ sounds like a serious crasher or even exploitable.
 732017-01-14T01:13:09  <luke-jr> cfields: I did skim it, but didn't see a rationale
 742017-01-14T01:15:00  <sipa> luke-jr: if we do it as a wrapper around (and just re-run configure and test for each of the sanitizers), it will just be passing CXXFLAGS/LDFLAGS
 752017-01-14T01:15:13  <cfields> luke-jr: i was kinda thinking same as you. Not sure it makes sense to handle in the build-system. as sipa said, maybe a wrapper makes more sense
 762017-01-14T01:15:22  <sipa> luke-jr: but it would be nice if it was completely integrated, so that the multiple tests/builds can run in parallel just from make, for exampe
 772017-01-14T01:15:53  <luke-jr> oh, for make check basically?
 782017-01-14T01:15:57  <sipa> right
 792017-01-14T01:16:09  <sipa> but make check should also run pull-tester/rpc-tests.py then
 802017-01-14T01:16:31  <sipa> i guess we can just start by doing it as a wrapper over the build system
 812017-01-14T01:17:24  <luke-jr> making make check run rpc tests shouldn't be hard, unlike sanitizers :P
 822017-01-14T01:19:53  *** moli_ has quit IRC
 832017-01-14T01:20:20  *** moli_ has joined #bitcoin-core-dev
 842017-01-14T01:21:11  <cfields> sipa: hmm, how do they interact with lto? it'd be nice if some of them could be enabled at link-time
 852017-01-14T01:22:20  *** xinxi has joined #bitcoin-core-dev
 862017-01-14T01:22:24  <sipa> cfields: they play well with lto, but you need to pass them both at compile and at link time, i think
 872017-01-14T01:22:42  <midnightmagic> Is a verbose transaction decode available through the rpc block decode interfaces..?
 882017-01-14T01:23:05  <sipa> decoderawtransaction?
 892017-01-14T01:24:10  <midnightmagic> sipa: The function interface has a txDetails bool which defaults to false but .. I don't know where it can be called with true through the rpc. Only the REST interface I think..?
 902017-01-14T01:24:27  <midnightmagic> blockToJSON() I mean.
 912017-01-14T01:24:52  <achow101> midnightmagic: you mean with something like getblock?
 922017-01-14T01:24:56  <midnightmagic> Yeah.
 932017-01-14T01:25:05  <achow101> no. but I have an open pr for that
 942017-01-14T01:25:32  <midnightmagic> ah, nice. \o thanks. I'll look for your PR then instead of doing my own.
 952017-01-14T01:26:23  <bitcoin-git> [bitcoin] gmaxwell opened pull request #9550: Trim down the XP notice and say more about what we support. (master...we_got_it_already) https://github.com/bitcoin/bitcoin/pull/9550
 962017-01-14T01:26:58  <achow101> midnightmagic: #8704
 972017-01-14T01:27:00  <gribble> https://github.com/bitcoin/bitcoin/issues/8704 | [RPC] Transaction details in getblock by achow101 · Pull Request #8704 · bitcoin/bitcoin · GitHub
 982017-01-14T01:27:09  *** xinxi has quit IRC
 992017-01-14T01:28:09  <midnightmagic> excellent.
1002017-01-14T01:29:44  <sipa> </mrburns>
1012017-01-14T01:30:20  <gmaxwell> luke-jr: I really wish make check ran the rpc tests though the rpc tests have more dependencies than the oridnary builds.
1022017-01-14T01:30:31  <gmaxwell> But I think we need to, because increasingly the useful tests are in rpctests.
1032017-01-14T01:30:46  <gmaxwell> I think current make check has a poor ratio of excution time to sensitivity.
1042017-01-14T02:06:37  <BlueMatt> morcos: getbalance("*", 1, True) is defined as a synonym of getbalance(), but bumpfee breaks that
1052017-01-14T02:06:53  <BlueMatt> (note that I think bumpfee also breaks some account balance shit, but I didnt bother to audit that - do we care?)
1062017-01-14T02:08:30  <BlueMatt> morcos / sdaftuar / ryanofsky: please add the following test-case https://0bin.net/paste/m91nHUQbD39EXaQ6#9fJ3bvAfAib5xWWwVdh3Ck0v7jQht1r8iDMQKQDpfTC
1072017-01-14T02:08:32  <gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
1082017-01-14T02:08:37  <BlueMatt> no gribble
1092017-01-14T02:10:27  <BlueMatt> (it currently fails on the last line of the test)
1102017-01-14T02:10:45  <BlueMatt> note that if you move that test to be the last one run you'll get fun results - getbalance("*", 1, True) is negative!
1112017-01-14T02:16:03  *** xinxi has joined #bitcoin-core-dev
1122017-01-14T02:19:26  <instagibbs> BlueMatt, https://github.com/bitcoin/bitcoin/issues/8183 Perhaps still the case
1132017-01-14T02:19:36  <instagibbs> they haven't been the same in a number of cases already :(
1142017-01-14T02:20:16  <BlueMatt> hum, ok, that seems shit
1152017-01-14T02:21:01  <BlueMatt> can we tag #8183 for 0.14, then, that is insane
1162017-01-14T02:21:02  <gribble> https://github.com/bitcoin/bitcoin/issues/8183 | getbalance comment incorrect · Issue #8183 · bitcoin/bitcoin · GitHub
1172017-01-14T02:21:08  <morcos> BlueMatt: I had assumed there might be an issue like that after you brought up your GUI question, and it was on my list to look into...
1182017-01-14T02:21:08  <BlueMatt> we either need to fix it or fix the docs in getbalance
1192017-01-14T02:21:21  <BlueMatt> they significantly imply that if you specify "*" as account you'll get sane results
1202017-01-14T02:21:25  <morcos> i guess in my head i sometimes confuse getbalance "*" with something that has to do with accounts
1212017-01-14T02:21:33  <morcos> but quite honestly getbalance "*" is a shit show
1222017-01-14T02:21:37  <morcos> why do we even need it
1232017-01-14T02:21:39  *** xinxi has quit IRC
1242017-01-14T02:21:40  <instagibbs> yeah it's really bad
1252017-01-14T02:21:40  <instagibbs> :)
1262017-01-14T02:21:47  <instagibbs> i mean :(
1272017-01-14T02:21:47  <morcos> i would suggest it should be deprecated with accounts
1282017-01-14T02:21:48  <BlueMatt> getbalance "*" should throw an exception as "FUCK YOU, WE DEPRECATED THIS FOREVER AGO"
1292017-01-14T02:21:57  <BlueMatt> it is marked deprecated the way i read the docs
1302017-01-14T02:22:30  <BlueMatt> the fact that it returns insanity is gonna confuse someone, and it has been deprecated, so it should throw an exception as its known-unsafe and we likely wont fix it
1312017-01-14T02:22:58  <morcos> From #9167 : "Note that the fee reported in the details and any other function which depends on ListTransactions is not changed as getbalance("*") depends on having incorrect negative fees calculated on mixed debit transactions in order to track the right balances."
1322017-01-14T02:23:00  <gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub
1332017-01-14T02:23:40  <BlueMatt> I mean it may be deprecated, but that doesnt mean it gets to return insanity
1342017-01-14T02:23:45  <BlueMatt> if its gonna return insanity, it needs to die
1352017-01-14T02:25:36  <morcos> anyway got to go
1362017-01-14T02:26:54  *** brg444 has quit IRC
1372017-01-14T02:28:36  *** brg444 has joined #bitcoin-core-dev
1382017-01-14T02:28:52  <BlueMatt> when you have to google C++ operator precedence in the process of review, something has gone horribly wrong :'(
1392017-01-14T02:43:27  *** brg444 has quit IRC
1402017-01-14T02:43:27  *** abpa has joined #bitcoin-core-dev
1412017-01-14T02:44:47  <gmaxwell> BlueMatt: time to study operator precidence more! :)
1422017-01-14T02:47:29  *** laurentmt has joined #bitcoin-core-dev
1432017-01-14T02:48:11  *** xinxi has joined #bitcoin-core-dev
1442017-01-14T02:50:14  <BlueMatt> clearly
1452017-01-14T02:50:38  *** fanquake has joined #bitcoin-core-dev
1462017-01-14T02:51:34  *** laurentmt has quit IRC
1472017-01-14T02:57:23  *** xinxi has quit IRC
1482017-01-14T03:02:32  *** xinxi has joined #bitcoin-core-dev
1492017-01-14T03:03:21  *** veleiro has joined #bitcoin-core-dev
1502017-01-14T03:07:20  *** AaronvanW has quit IRC
1512017-01-14T03:12:46  *** xinxi has quit IRC
1522017-01-14T03:14:08  <fanquake> cfields Made the required changes in 9469, and pulled in your commits. Any chance while your looking at Qt stuff, you can take a look at #9126. Have you seen that issue at all?
1532017-01-14T03:14:09  <gribble> https://github.com/bitcoin/bitcoin/issues/9126 | An error has occurred and has been logged. Please contact this bot's administrator for more information.
1542017-01-14T03:17:56  *** xinxi has joined #bitcoin-core-dev
1552017-01-14T03:18:15  *** brg444 has joined #bitcoin-core-dev
1562017-01-14T03:29:07  *** btcdrak has quit IRC
1572017-01-14T03:30:14  *** Chris_Stewart_5 has quit IRC
1582017-01-14T03:42:40  <BlueMatt> I think #9484 is ready for merge
1592017-01-14T03:42:42  <gribble> https://github.com/bitcoin/bitcoin/issues/9484 | Introduce assumevalid setting to skip validation presumed valid scripts. by gmaxwell · Pull Request #9484 · bitcoin/bitcoin · GitHub
1602017-01-14T03:42:49  <BlueMatt> (just thought I'd mention it so it doesnt slip 0.14)
1612017-01-14T03:44:35  <BlueMatt> gmaxwell: you were saying you'd be super dissapointed if some of the net fixes didnt make 0.14...well there is one bunch left from your pr that is at risk - #9535
1622017-01-14T03:44:37  <gribble> https://github.com/bitcoin/bitcoin/issues/9535 | Split CNode::cs_vSend: message processing and message sending by TheBlueMatt · Pull Request #9535 · bitcoin/bitcoin · GitHub
1632017-01-14T03:45:09  * BlueMatt does solomly swear all helgrind issues will be thoroughly debugged prior to release :p
1642017-01-14T03:45:22  <BlueMatt> 9535 wont add any, but I know of a few still left
1652017-01-14T03:47:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1662017-01-14T04:01:57  * sipa tests 9535 with -fsanitize=thread
1672017-01-14T04:03:48  <BlueMatt> sipa: thar be dragons
1682017-01-14T04:03:52  <BlueMatt> (not cause by 9535)
1692017-01-14T04:04:02  <BlueMatt> d
1702017-01-14T04:04:08  <sipa> yes, i expect it to fail (on master)
1712017-01-14T04:04:09  <BlueMatt> can I buy a "d"?
1722017-01-14T04:04:17  <BlueMatt> I can give you a list of places it will fail :p
1732017-01-14T04:05:01  <BlueMatt> alright folks, I'm all reviewed-out...and likely wont have time tomorrow. apologize for those I didnt get to, but will try again on sunday
1742017-01-14T04:05:45  <sipa> thanks!
1752017-01-14T04:08:57  <sipa> ok, bitcoin-cli fails with -fsanitize=thread... i think there is some build config failure
1762017-01-14T04:10:54  *** windsok has quit IRC
1772017-01-14T04:16:43  *** chris200_ has joined #bitcoin-core-dev
1782017-01-14T04:18:51  *** chris2000 has quit IRC
1792017-01-14T04:20:39  *** Chris_Stewart_5 has quit IRC
1802017-01-14T04:25:10  *** windsok has joined #bitcoin-core-dev
1812017-01-14T04:28:25  <bitcoin-git> [bitcoin] 2HCHO opened pull request #9551: disable out of sync warnings for regtest network (master...ca4b90519c3c210f) https://github.com/bitcoin/bitcoin/pull/9551
1822017-01-14T04:34:23  *** xinxi has quit IRC
1832017-01-14T04:41:04  *** xinxi has joined #bitcoin-core-dev
1842017-01-14T04:58:28  *** brg444 has quit IRC
1852017-01-14T04:59:02  *** Alopex has quit IRC
1862017-01-14T04:59:27  <cfields> sipa: yes, i'd expect that to be a bloodbath if it works. But there should be no new issues, i think
1872017-01-14T04:59:51  <cfields> sipa: specifically, anything that uses CNodeStats is very racy.
1882017-01-14T05:00:07  *** Alopex has joined #bitcoin-core-dev
1892017-01-14T05:02:03  *** brg444 has joined #bitcoin-core-dev
1902017-01-14T05:19:10  <sipa> cfields: i think it inteferes with some fortify/aslr/... we're using
1912017-01-14T05:19:17  <sipa> bitcoin-cli has no threads
1922017-01-14T05:29:33  <cfields> sipa: oh, yes, for sure
1932017-01-14T05:29:55  <cfields> i read somewhere that FORTIFY is incompatible with some, sec for link
1942017-01-14T05:30:34  <sipa> in fact, the compiler detector fails with -fsanitize=thread ("C++ compiler cannot produce binaries")
1952017-01-14T05:31:15  <cfields> sipa: https://www.sourceware.org/ml/libc-alpha/2016-09/msg00080.html
1962017-01-14T05:31:56  <cfields> comes from here: https://github.com/google/sanitizers/wiki/AddressSanitizer
1972017-01-14T05:35:10  <cfields> fanquake: will have a look at 9126
1982017-01-14T05:36:57  <cfields> (at some point this weekend)
1992017-01-14T05:37:22  <fanquake> cfields cheers. Interesting build error on just the osx build of 9469. "Qt requires a C++11 compiler and yours does not seem to be that."
2002017-01-14T05:38:44  <fanquake> Thought I might have messed up passing -c++std c++11. But that looks ok. https://travis-ci.org/bitcoin/bitcoin/jobs/191837557#L895
2012017-01-14T05:41:59  <sipa> -std=c++11 ?
2022017-01-14T05:51:28  *** btcdrak has joined #bitcoin-core-dev
2032017-01-14T05:55:13  <cfields> fanquake: hmm, strange. it built fine for me locally
2042017-01-14T05:55:38  *** xinxi has quit IRC
2052017-01-14T05:55:38  <fanquake> cfields yes me too.
2062017-01-14T05:56:19  <cfields> fanquake: ah, it's the damn .mm again
2072017-01-14T05:57:24  <cfields> fanquake: i noticed something at one point and suspected that might happen
2082017-01-14T05:57:31  <cfields> trying to remember
2092017-01-14T05:59:17  <cfields> ah, right
2102017-01-14T05:59:33  <cfields> fanquake: https://github.com/bitcoin/bitcoin/blob/master/depends/config.site.in#L66
2112017-01-14T05:59:48  <cfields> mind nuking that line and giving it a try?
2122017-01-14T06:01:31  <fanquake> cfields Have pushed that change up to GH.
2132017-01-14T06:01:39  <fanquake> Will start a new build here also.
2142017-01-14T06:01:47  *** xinxi has joined #bitcoin-core-dev
2152017-01-14T06:02:38  <cfields> thanks
2162017-01-14T06:04:02  <fanquake> Just realised I forgot you had two commits on top of mine, so that change is now part of your translations build commit.
2172017-01-14T06:04:08  <cfields> fanquake: for the reasoning, see https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L62
2182017-01-14T06:04:16  <fanquake> Can fixup later if the builds passed. Otherwise np.
2192017-01-14T06:05:32  <cfields> fanquake: np. Though if this fixes, we probably want to commit it as a one-liner. It's a good backport candidate.
2202017-01-14T06:06:26  <fanquake> cfields good point. Will split it out post builds passing.
2212017-01-14T06:08:45  <cfields> fanquake: only reason i mention is that i had a theory at one point that it was the cause of the 10.7 back-compat breakage. Since it's responsible for intoducing c++03 abi objects into the 0.13 build.
2222017-01-14T06:11:26  <fanquake> cfields ok. Just made note of it in a comment in that PR.
2232017-01-14T06:11:36  *** xinxi has quit IRC
2242017-01-14T06:14:49  <cfields> fanquake: thanks :)
2252017-01-14T06:15:24  <fanquake> cfields I'll stop pestering now, you can go and enjoy the rest of your saturday heh
2262017-01-14T06:17:26  *** xinxi has joined #bitcoin-core-dev
2272017-01-14T06:18:02  <cfields> fanquake: heh, np. i meant to test that a long time ago, glad it came up either way
2282017-01-14T06:18:31  <cfields> besides, this is what i enjoy :)
2292017-01-14T06:19:53  <cfields> woohoo, success
2302017-01-14T06:21:36  <fanquake> Awesome. I'll fixup that commit then.
2312017-01-14T06:22:55  <cfields> great, thanks again!
2322017-01-14T07:00:06  *** dermoth has quit IRC
2332017-01-14T07:00:48  *** dermoth has joined #bitcoin-core-dev
2342017-01-14T07:08:21  *** xinxi has quit IRC
2352017-01-14T07:21:57  *** xinxi has joined #bitcoin-core-dev
2362017-01-14T07:44:07  *** fanquake has quit IRC
2372017-01-14T08:02:11  *** Alopex has quit IRC
2382017-01-14T08:03:16  *** Alopex has joined #bitcoin-core-dev
2392017-01-14T08:03:19  *** veleiro has quit IRC
2402017-01-14T08:08:58  *** chjj has quit IRC
2412017-01-14T08:10:21  *** chjj has joined #bitcoin-core-dev
2422017-01-14T08:11:21  *** Ylbam has joined #bitcoin-core-dev
2432017-01-14T08:38:47  *** jtimon has joined #bitcoin-core-dev
2442017-01-14T08:53:40  *** jtimon has quit IRC
2452017-01-14T09:17:34  <bitcoin-git> [bitcoin] jamesmacwhite opened pull request #9552: Add IPv6 support to qos.sh (master...qos-ipv6) https://github.com/bitcoin/bitcoin/pull/9552
2462017-01-14T09:27:30  *** xinxi has quit IRC
2472017-01-14T09:32:34  *** MarcoFalke has joined #bitcoin-core-dev
2482017-01-14T09:32:50  *** xinxi has joined #bitcoin-core-dev
2492017-01-14T09:35:32  *** [Author] has joined #bitcoin-core-dev
2502017-01-14T09:41:12  *** jerryco has joined #bitcoin-core-dev
2512017-01-14T09:41:19  <jerryco> hello
2522017-01-14T09:41:46  <jerryco> how to install bitcoin-core centos ?
2532017-01-14T09:43:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553
2542017-01-14T09:52:27  <MarcoFalke> jerryco: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions-fedora
2552017-01-14T09:55:51  *** jerryco has quit IRC
2562017-01-14T10:11:04  *** xinxi has quit IRC
2572017-01-14T10:25:52  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e126d0c12ca6...8daf103fa138
2582017-01-14T10:25:53  <bitcoin-git> bitcoin/master 988d300 practicalswift: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)
2592017-01-14T10:25:53  <bitcoin-git> bitcoin/master 8daf103 MarcoFalke: Merge #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64)...
2602017-01-14T10:26:04  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9528: [qt] Rename formateNiceTimeOffset(qint64) to formatNiceTimeOffset(qint64) (master...rename-formateNiceTimeOffset) https://github.com/bitcoin/bitcoin/pull/9528
2612017-01-14T10:31:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/8daf103fa138...23281a4dc3af
2622017-01-14T10:31:04  <bitcoin-git> bitcoin/master b348287 Alex Morcos: Clarify that prioritisetransaction remains supported
2632017-01-14T10:31:05  <bitcoin-git> bitcoin/master 34ede12 Alex Morcos: Document fee estimation changes
2642017-01-14T10:31:05  <bitcoin-git> bitcoin/master 23281a4 MarcoFalke: Merge #9531: Release notes for estimation changes...
2652017-01-14T10:31:17  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9531: Release notes for estimation changes  (master...relnotes) https://github.com/bitcoin/bitcoin/pull/9531
2662017-01-14T11:10:59  *** xinxi has joined #bitcoin-core-dev
2672017-01-14T11:31:31  *** chjj has quit IRC
2682017-01-14T11:55:51  *** chjj has joined #bitcoin-core-dev
2692017-01-14T12:06:48  *** AaronvanW has joined #bitcoin-core-dev
2702017-01-14T12:06:48  *** AaronvanW has joined #bitcoin-core-dev
2712017-01-14T12:49:52  *** MarcoFalke has quit IRC
2722017-01-14T12:54:41  *** xinxi has quit IRC
2732017-01-14T12:56:04  *** xinxi has joined #bitcoin-core-dev
2742017-01-14T13:47:30  *** Saucery has joined #bitcoin-core-dev
2752017-01-14T14:02:54  *** Guyver2 has joined #bitcoin-core-dev
2762017-01-14T14:29:58  *** Saucery has quit IRC
2772017-01-14T14:30:11  *** laurentmt has joined #bitcoin-core-dev
2782017-01-14T14:30:25  *** laurentmt has quit IRC
2792017-01-14T14:34:00  *** jtimon has joined #bitcoin-core-dev
2802017-01-14T14:43:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2812017-01-14T15:00:54  *** windsok has quit IRC
2822017-01-14T15:16:19  *** Guyver2 has quit IRC
2832017-01-14T15:18:38  *** laurentmt has joined #bitcoin-core-dev
2842017-01-14T15:28:37  *** windsok has joined #bitcoin-core-dev
2852017-01-14T15:33:05  *** windsok has quit IRC
2862017-01-14T16:00:14  *** Chris_Stewart_5 has quit IRC
2872017-01-14T16:07:01  *** d9b4bef9 has quit IRC
2882017-01-14T16:08:08  *** d9b4bef9 has joined #bitcoin-core-dev
2892017-01-14T16:11:29  *** windsok has joined #bitcoin-core-dev
2902017-01-14T16:12:01  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2912017-01-14T16:22:52  *** laurentmt has quit IRC
2922017-01-14T16:29:58  *** laurentmt has joined #bitcoin-core-dev
2932017-01-14T16:30:02  *** laurentmt has quit IRC
2942017-01-14T17:07:20  *** justanotheruser has quit IRC
2952017-01-14T17:15:22  *** laurentmt has joined #bitcoin-core-dev
2962017-01-14T17:23:32  *** laurentmt has quit IRC
2972017-01-14T17:34:48  *** xinxi has quit IRC
2982017-01-14T17:40:19  *** justanotheruser has joined #bitcoin-core-dev
2992017-01-14T17:44:19  *** xinxi has joined #bitcoin-core-dev
3002017-01-14T18:22:25  *** justan0theruser has joined #bitcoin-core-dev
3012017-01-14T18:24:43  *** justanotheruser has quit IRC
3022017-01-14T18:25:09  *** justan0theruser is now known as justanotheruser
3032017-01-14T18:29:41  *** laurentmt has joined #bitcoin-core-dev
3042017-01-14T18:51:47  <sipa> cfields: -fsanitize=thread "runs" with LDFLAGS="-no-pie"
3052017-01-14T18:52:32  *** xinxi has quit IRC
3062017-01-14T18:52:53  <luke-jr> sipa: only with newer compilers.. neither Gentoo-stable compiler supports sanitize=thread without PIE
3072017-01-14T18:53:11  <luke-jr> and with PIE requires either a newer LLVM or older kernel
3082017-01-14T18:53:11  *** justan0theruser has joined #bitcoin-core-dev
3092017-01-14T18:53:30  <luke-jr> (neither of which are available on Travis)
3102017-01-14T18:54:26  <luke-jr> the LLVM fix backports only so far as 3.8 FWIW (porting to 3.7 seemed difficult, at least)
3112017-01-14T18:54:31  *** justanotheruser has quit IRC
3122017-01-14T18:54:37  <sipa> luke-jr: using gcc 6.2
3132017-01-14T18:55:15  <luke-jr> ok, just pointing out that isn't a reasonable min requirement ;)
3142017-01-14T18:55:44  * luke-jr peers at Gentoo have 6.3 masked, but no other 6.x at all
3152017-01-14T18:55:53  *** laurentmt has quit IRC
3162017-01-14T19:14:17  *** PRab has joined #bitcoin-core-dev
3172017-01-14T19:20:01  <bitcoin-git> [bitcoin] practicalswift opened pull request #9554: [test] Avoid potential NULL pointer dereference in addrman_tests.cpp (master...avoid-null-pointer-dereference-in-addrman_tests) https://github.com/bitcoin/bitcoin/pull/9554
3182017-01-14T19:24:39  *** Netmage has joined #bitcoin-core-dev
3192017-01-14T19:39:32  *** Cheeseo has joined #bitcoin-core-dev
3202017-01-14T19:39:32  *** Cheeseo has joined #bitcoin-core-dev
3212017-01-14T19:45:39  <bitcoin-git> [bitcoin] practicalswift opened pull request #9555: [test] Avoid triggering undefined behaviour in tx_invalid-test (transaction_tests.cpp) (master...avoid-ub-in-tx_invalid-test) https://github.com/bitcoin/bitcoin/pull/9555
3222017-01-14T19:52:39  <Netmage> Hi, I use bitcoint-qt. The size of the block chain is overall 113 GB large. Is this a normal value for the current block chain ?
3232017-01-14T19:52:57  *** xinxi has joined #bitcoin-core-dev
3242017-01-14T19:53:45  <btcdrak> Netmage: sadly yes.
3252017-01-14T19:54:50  <Netmage> ok, is there a good way to decrease the size ?
3262017-01-14T19:55:06  <Netmage> Without having problems afterwards
3272017-01-14T19:55:54  *** atroxes has quit IRC
3282017-01-14T19:57:12  *** atroxes has joined #bitcoin-core-dev
3292017-01-14T19:57:22  <BlueMatt> yes, luke-jr, Netcraft confirmed: gentoo is dead
3302017-01-14T19:57:45  <BlueMatt> Netmage: look at the docs for the -prune option
3312017-01-14T19:57:54  <luke-jr> Netmage: depends on if you need to restore old wallet backups etc
3322017-01-14T19:58:16  <BlueMatt> luke-jr: ok, sooooo utack for #9499?
3332017-01-14T19:58:18  <gribble> https://github.com/bitcoin/bitcoin/issues/9499 | Use recent-rejects, orphans, and recently-replaced txn for compact-block-reconstruction by TheBlueMatt · Pull Request #9499 · bitcoin/bitcoin · GitHub
3342017-01-14T20:00:33  <luke-jr> BlueMatt: I did not complete review of all the code; I'm not sure it's worth doing as-is, but I don't object to it.
3352017-01-14T20:01:18  <BlueMatt> huh? folks have reported on the order of 10% fewer rtts!
3362017-01-14T20:01:21  <BlueMatt> how is that not worth doing?
3372017-01-14T20:01:52  <BlueMatt> (or more)
3382017-01-14T20:02:09  <luke-jr> it just seemed like a lot of complexity for what appeared to be random caching; maybe I'm wrong
3392017-01-14T20:02:14  *** xinxi has quit IRC
3402017-01-14T20:02:39  <luke-jr> maybe in practice it happens to work out to be very effective
3412017-01-14T20:02:39  <BlueMatt> most of that pr's "complexity" is copying one block of code.....
3422017-01-14T20:02:54  <luke-jr> I did review that block
3432017-01-14T20:03:05  <BlueMatt> but, yes, three independant benchmarks posted on the pr suggested its a huge win
3442017-01-14T20:03:28  <luke-jr> ok, maybe it is! I'm not objecting
3452017-01-14T20:04:01  <luke-jr> if my review matters for the merge, I can go back and finish it
3462017-01-14T20:05:08  <BlueMatt> all reviews matter
3472017-01-14T20:05:11  <BlueMatt> :)
3482017-01-14T20:05:23  <luke-jr> maybe I should be doing this one commit-by-commit
3492017-01-14T20:05:30  <BlueMatt> yes
3502017-01-14T20:05:48  <BlueMatt> that tends to make most reviews easier :p
3512017-01-14T20:12:23  <luke-jr> I'd be a lot more comfortable that there isn't an implicit mask in rebasing code, if plTxnReplaced were at the end of the function signature
3522017-01-14T20:12:45  <luke-jr> s/mask/cast/
3532017-01-14T20:14:24  <BlueMatt> I believe gcc would complain in any way you fuck that up?
3542017-01-14T20:14:30  <luke-jr> checking..
3552017-01-14T20:14:38  <BlueMatt> it should complain if you try to pass a bool into that pointer?
3562017-01-14T20:15:18  <BlueMatt> i suppose unless, for some reason, you want to fOverrideMempoolLimit based on whether not a std::vector<CTransactionRef>* is non-null
3572017-01-14T20:15:21  <BlueMatt> but......
3582017-01-14T20:16:27  <luke-jr> yeah, probably safe
3592017-01-14T20:23:42  <luke-jr> BlueMatt: c73554042886fb63fb48edf29cf827951edde341 needs a #include "netprocessing.h" in init.cpp I think
3602017-01-14T20:24:22  <BlueMatt> init has an include net_processing?
3612017-01-14T20:28:12  <luke-jr> right, nm
3622017-01-14T20:29:14  *** xinxi has joined #bitcoin-core-dev
3632017-01-14T20:36:57  *** xinxi has quit IRC
3642017-01-14T20:42:07  *** AaronvanW has quit IRC
3652017-01-14T20:47:18  <BlueMatt> cfields: is there a reason CConnman::ForNode calls the provided function with cs_vNodes still locked? that seems bad?
3662017-01-14T20:47:57  <bitcoin-git> [bitcoin] practicalswift opened pull request #9556: Remove redundant semicolons (master...remove-redundant-braces) https://github.com/bitcoin/bitcoin/pull/9556
3672017-01-14T20:55:46  <Chris_Stewart_5> If anyone is interested in #8469 and wants to get some internet points on SO: http://stackoverflow.com/questions/41539334/including-header-file-in-cpp-causes-nasty-error
3682017-01-14T20:55:48  <gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
3692017-01-14T21:08:07  *** Guyver2 has joined #bitcoin-core-dev
3702017-01-14T21:16:24  <bitcoin-git> [bitcoin] practicalswift opened pull request #9557: Use static_cast<new_type>(...) instead of deprecated new_type(...) (functional cast) (master...avoid-functional-cast-expression) https://github.com/bitcoin/bitcoin/pull/9557
3712017-01-14T21:25:00  *** Cheeseo has quit IRC
3722017-01-14T21:33:33  *** xinxi has joined #bitcoin-core-dev
3732017-01-14T21:42:07  *** xinxi has quit IRC
3742017-01-14T21:42:31  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9558: Clarify assumptions made about when BlockCheck is called (master...2017-01-blockcheckeddocs) https://github.com/bitcoin/bitcoin/pull/9558
3752017-01-14T21:48:15  *** Cheeseo has joined #bitcoin-core-dev
3762017-01-14T21:48:15  *** Cheeseo has joined #bitcoin-core-dev
3772017-01-14T22:08:52  <bitcoin-git> [bitcoin] 2HCHO closed pull request #9551: disable out of sync warnings for regtest network (master...ca4b90519c3c210f) https://github.com/bitcoin/bitcoin/pull/9551
3782017-01-14T22:20:37  *** Saucery has joined #bitcoin-core-dev
3792017-01-14T22:22:43  *** Cheeseo has quit IRC
3802017-01-14T22:23:36  <bitcoin-git> [bitcoin] practicalswift opened pull request #9559: [net] Avoid possibility of NULL pointer dereference in ProcessMessage(...) (master...avoid-null-pointer-deref-in-processmessage) https://github.com/bitcoin/bitcoin/pull/9559
3812017-01-14T22:38:52  *** xinxi has joined #bitcoin-core-dev
3822017-01-14T22:46:09  *** xinxi has quit IRC
3832017-01-14T23:03:02  *** d9b4bef9 has quit IRC
3842017-01-14T23:04:07  <bitcoin-git> [bitcoin] practicalswift opened pull request #9560: [rpc] Avoid possibility of NULL pointer dereference in getblocktemplate(...) (master...avoid-null-pointer-dereference-in-rpc-blockchain) https://github.com/bitcoin/bitcoin/pull/9560
3852017-01-14T23:04:15  *** d9b4bef9 has joined #bitcoin-core-dev
3862017-01-14T23:09:48  *** waxwing has quit IRC
3872017-01-14T23:37:58  <BlueMatt> man practicalswift needs to calm down a bit with this....bad timing, yo
3882017-01-14T23:42:08  <sipa> release's on fire, yo
3892017-01-14T23:43:08  *** xinxi has joined #bitcoin-core-dev
3902017-01-14T23:43:26  <BlueMatt> yea, as in a bunch of stuff is cruisin' to miss :(
3912017-01-14T23:43:31  <BlueMatt> sipa: how's mystery hung going?
3922017-01-14T23:43:32  <BlueMatt> t
3932017-01-14T23:47:17  <sipa> BlueMatt: first team finished at 4am this morning, shortest hunt ever
3942017-01-14T23:47:28  <sipa> BlueMatt: our team finished early afternoon today
3952017-01-14T23:48:49  <BlueMatt> oh shit, wow
3962017-01-14T23:49:37  *** xinxi has quit IRC
3972017-01-14T23:51:47  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9561: Wake message handling thread when we receive a new block (master...2017-01-wakeup-on-new-block) https://github.com/bitcoin/bitcoin/pull/9561
3982017-01-14T23:53:35  <BlueMatt> ^ one-line change provides 100ms improvement in block-relay latency for non-compact-block peers :p
3992017-01-14T23:58:39  *** Guyver2 has quit IRC