12017-01-25T00:02:35  *** laurentmt has joined #bitcoin-core-dev
  22017-01-25T00:06:37  *** laurentmt has quit IRC
  32017-01-25T00:16:51  *** jtimon has joined #bitcoin-core-dev
  42017-01-25T00:18:04  <jtimon> periodical reminder that #8855 is rebase
  52017-01-25T00:18:09  * jtimon ducks
  62017-01-25T00:18:13  <gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
  72017-01-25T00:23:29  *** owowo has quit IRC
  82017-01-25T00:23:49  <gmaxwell> but does it use a factory factory singleton?
  92017-01-25T00:28:38  *** owowo has joined #bitcoin-core-dev
 102017-01-25T00:28:53  *** AaronvanW has quit IRC
 112017-01-25T00:59:28  *** abpa has quit IRC
 122017-01-25T01:00:27  *** waxwing has quit IRC
 132017-01-25T01:04:40  *** wvr has quit IRC
 142017-01-25T01:06:49  *** Lightsword has left #bitcoin-core-dev
 152017-01-25T01:17:31  *** waxwing has joined #bitcoin-core-dev
 162017-01-25T01:20:53  *** MarcoFalke has joined #bitcoin-core-dev
 172017-01-25T01:24:49  *** owowo has quit IRC
 182017-01-25T01:35:17  *** owowo has joined #bitcoin-core-dev
 192017-01-25T01:52:20  *** echonaut1 has quit IRC
 202017-01-25T01:52:37  *** echonaut has joined #bitcoin-core-dev
 212017-01-25T01:53:15  *** jl2012 has joined #bitcoin-core-dev
 222017-01-25T01:57:30  *** Ylbam has quit IRC
 232017-01-25T02:05:39  *** MarcoFalke has quit IRC
 242017-01-25T02:12:43  <Chris_Stewart_5> what exactly is DEFAULT_BLOCK_PRIORITY_SIZE? Does this nodes will not relay blocks with low fee txs inside of it?
 252017-01-25T02:13:17  <sipa> If nodes would choose to not relay valid blocks, they'd choose to be forked off.
 262017-01-25T02:13:25  <sipa> it's a setting for the mining code
 272017-01-25T02:14:13  <Chris_Stewart_5> sipa: Yeah I guess it seems bizarre, I figured logic with building blocks would just be some sort of greedy algo and that would implicitly be enforced
 282017-01-25T02:14:24  <Chris_Stewart_5> unless there were no high fee txs
 292017-01-25T02:14:39  <sipa> Chris_Stewart_5: that's what we're doing in practice
 302017-01-25T02:14:58  <Chris_Stewart_5> I guess why do we need the constant then?
 312017-01-25T02:15:38  <sipa> but there is a legacy mining algorithm that uses BTC_days_destroyed per byte (confusingly named priority) as sorting criteria instead of feerate
 322017-01-25T02:16:15  <sipa> the DEFAULT_BLOCK_PRIORITY_SIZE value gives the default setting for -blockprioritysize (which defaults to 0), which sets the bytes of blockspace assigned to that algorithm
 332017-01-25T02:17:19  <Chris_Stewart_5> Interesting, thanks. So before a fee market was around we would favor old coins being spent for block inclusion instead of new ones?
 342017-01-25T02:18:23  <sipa> yup
 352017-01-25T02:20:26  <Chris_Stewart_5> Cool. Thanks! Always interesting to learn historical contexts around decisions.
 362017-01-25T02:38:31  *** Chris_Stewart_5 has quit IRC
 372017-01-25T02:45:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 382017-01-25T02:45:39  *** Chris_Stewart_5 has quit IRC
 392017-01-25T02:46:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 402017-01-25T03:30:32  *** norotartagen has quit IRC
 412017-01-25T03:32:41  *** kadoban_ has joined #bitcoin-core-dev
 422017-01-25T03:33:22  *** kadoban has quit IRC
 432017-01-25T03:33:32  *** kadoban_ is now known as kadoban
 442017-01-25T04:03:13  <bitcoin-git> [bitcoin] jtimon opened pull request #9627: Remove extra nonce reset logic in IncrementExtraNonce (master...upstream-elements-unused-extranonce) https://github.com/bitcoin/bitcoin/pull/9627
 452017-01-25T04:05:03  *** chris200_ has joined #bitcoin-core-dev
 462017-01-25T04:07:41  *** chris2000 has quit IRC
 472017-01-25T04:08:00  *** norotartagen has joined #bitcoin-core-dev
 482017-01-25T04:14:12  *** droark has quit IRC
 492017-01-25T04:15:46  <luke-jr> jl2012: I think anti-replay isn't something specifically needed for HFs. need it without a HF in some cases too
 502017-01-25T04:59:56  *** jtimon has quit IRC
 512017-01-25T05:00:18  *** dermoth has quit IRC
 522017-01-25T05:01:03  *** dermoth has joined #bitcoin-core-dev
 532017-01-25T05:15:54  <jl2012> luke-jr: for example?
 542017-01-25T05:19:58  <luke-jr> Tx A=UTXO 1 used to pay 1someaddress2 (no change); Tx B=UTXO 1 and UTXO 2 used to pay 1someaddress2 and 1someaddress3 (no change; double-spend of Tx A); Tx A is mined; 1someaddress3 still needs to be paid, but there is no way to guarantee Tx A won't reorg out.
 552017-01-25T05:33:11  *** droark has joined #bitcoin-core-dev
 562017-01-25T05:33:49  <jl2012> Just use the output of TxA to pay
 572017-01-25T05:34:50  <jl2012> Oh, no change
 582017-01-25T05:36:07  <jl2012> Just use UTXO2 to pay someaddress3
 592017-01-25T05:44:44  *** Satoshi_ has joined #bitcoin-core-dev
 602017-01-25T05:46:55  *** Satoshi_ has quit IRC
 612017-01-25T05:48:48  <luke-jr> jl2012: ok, but I think there are rare cases where there isn't such a solution :p
 622017-01-25T05:54:05  <luke-jr> Chris_Stewart_5: btw, note that priority sorting is not strictly historical, and is still is use by some miners.
 632017-01-25T06:10:00  <gmaxwell> luke-jr: what miner?
 642017-01-25T06:13:16  *** waxwing has quit IRC
 652017-01-25T06:16:32  *** owowo has quit IRC
 662017-01-25T06:18:08  *** owowo has joined #bitcoin-core-dev
 672017-01-25T06:19:50  *** davec has quit IRC
 682017-01-25T06:28:38  *** waxwing has joined #bitcoin-core-dev
 692017-01-25T07:06:19  *** davec has joined #bitcoin-core-dev
 702017-01-25T07:10:55  *** Ylbam has joined #bitcoin-core-dev
 712017-01-25T07:36:26  *** PaulCape_ has joined #bitcoin-core-dev
 722017-01-25T07:37:11  *** PaulCapestany has quit IRC
 732017-01-25T08:19:29  *** BashCo has quit IRC
 742017-01-25T08:20:14  *** BashCo has joined #bitcoin-core-dev
 752017-01-25T08:24:53  *** BashCo has quit IRC
 762017-01-25T08:28:49  *** Guyver2 has joined #bitcoin-core-dev
 772017-01-25T08:40:09  *** BashCo has joined #bitcoin-core-dev
 782017-01-25T09:12:08  *** kadoban has quit IRC
 792017-01-25T09:14:07  *** kadoban has joined #bitcoin-core-dev
 802017-01-25T09:27:39  *** jannes has joined #bitcoin-core-dev
 812017-01-25T09:42:11  *** sanada has joined #bitcoin-core-dev
 822017-01-25T10:10:00  *** baldur has quit IRC
 832017-01-25T10:21:49  *** baldur has joined #bitcoin-core-dev
 842017-01-25T10:29:40  *** AaronvanW has joined #bitcoin-core-dev
 852017-01-25T10:40:26  *** BashCo has quit IRC
 862017-01-25T10:41:24  *** BashCo has joined #bitcoin-core-dev
 872017-01-25T10:57:04  *** MarcoFalke has joined #bitcoin-core-dev
 882017-01-25T11:12:37  *** kadoban has quit IRC
 892017-01-25T11:13:02  *** kadoban has joined #bitcoin-core-dev
 902017-01-25T11:13:42  *** chjj has quit IRC
 912017-01-25T11:21:44  *** kadoban has quit IRC
 922017-01-25T11:22:02  *** kadoban has joined #bitcoin-core-dev
 932017-01-25T11:31:55  *** JackH has joined #bitcoin-core-dev
 942017-01-25T11:38:47  *** MarcoFalke has quit IRC
 952017-01-25T11:56:00  *** chjj has joined #bitcoin-core-dev
 962017-01-25T12:31:56  *** justanotheruser has quit IRC
 972017-01-25T12:32:25  *** justanotheruser has joined #bitcoin-core-dev
 982017-01-25T13:15:24  *** wvr has joined #bitcoin-core-dev
 992017-01-25T13:21:28  *** jtimon has joined #bitcoin-core-dev
1002017-01-25T13:31:37  *** thukydides has joined #bitcoin-core-dev
1012017-01-25T13:37:52  *** JackH has quit IRC
1022017-01-25T13:53:00  *** jcorgan has quit IRC
1032017-01-25T13:57:30  *** jnewbery has joined #bitcoin-core-dev
1042017-01-25T13:58:11  *** neha___ has joined #bitcoin-core-dev
1052017-01-25T14:02:17  *** jcorgan has joined #bitcoin-core-dev
1062017-01-25T14:20:09  *** mol has joined #bitcoin-core-dev
1072017-01-25T14:20:48  *** moli_ has quit IRC
1082017-01-25T14:36:14  <bitcoin-git> [bitcoin] sdaftuar opened pull request #9628: qa: Increase a sync_blocks timeout in pruning.py (master...2017-01-longer-pruning-sync) https://github.com/bitcoin/bitcoin/pull/9628
1092017-01-25T15:17:23  <BlueMatt> cfields: re: #9609 yea, I know you dont want to use fSuccessfullyConnected in net_processing after 0.14, but its so much cleaner to use that appropriately now and split it out into CNodeState in 0.14, so i figured I'd suggest it :)
1102017-01-25T15:17:26  <gribble> https://github.com/bitcoin/bitcoin/issues/9609 | net: fix remaining net assertions by theuni · Pull Request #9609 · bitcoin/bitcoin · GitHub
1112017-01-25T15:27:40  *** thukydides has left #bitcoin-core-dev
1122017-01-25T15:34:47  *** wvr has quit IRC
1132017-01-25T16:03:58  *** mol is now known as moli
1142017-01-25T16:16:04  <cfields> BlueMatt: i tried hard to disagree but couldn't :)
1152017-01-25T16:17:00  <cfields> I do want something net-only going forward, but I'll do that next. Once we're forked, I have a flood of changes. I'll just pile that on.
1162017-01-25T16:19:22  <BlueMatt> heh, ok
1172017-01-25T16:22:06  <cfields> gmaxwell: are you ok with that? I see you acked as-is, but I think BlueMatt's suggestion only locks us down tighter
1182017-01-25T16:22:39  <cfields> note that it is a change in p2p behavior though. Pretty sure the current network allows for not sending a VERACK with not much downside
1192017-01-25T16:22:58  <cfields> (other than obviously not getting new serialization)
1202017-01-25T16:23:53  <BlueMatt> I'd hope we consider that undefined behavior?
1212017-01-25T16:24:14  <cfields> i would certainly say so
1222017-01-25T16:24:35  <cfields> i think the only quasi-valid real-world change would be addr races
1232017-01-25T16:25:13  *** BashCo has quit IRC
1242017-01-25T16:25:20  <BlueMatt> have we ever sent addr messages before verack?
1252017-01-25T16:25:48  <BlueMatt> I mean I know we can send shit before verack on accident, but all of that stuff would otherwise just not be sent
1262017-01-25T16:25:58  *** BashCo has joined #bitcoin-core-dev
1272017-01-25T16:27:07  <cfields> not us, i meant other nodes maybe sending verack/getaddr out of order
1282017-01-25T16:30:02  <BlueMatt> ehh, if they send it out of order I'm happy to not resrpond
1292017-01-25T16:30:58  *** BashCo has quit IRC
1302017-01-25T16:49:18  *** BashCo has joined #bitcoin-core-dev
1312017-01-25T16:55:25  *** abpa has joined #bitcoin-core-dev
1322017-01-25T17:25:34  *** Chris_Stewart_5 has quit IRC
1332017-01-25T17:41:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1342017-01-25T18:12:02  *** cryptapus_afk has quit IRC
1352017-01-25T18:12:37  *** jannes has quit IRC
1362017-01-25T18:28:48  <bitcoin-git> [bitcoin] jtimon closed pull request #9627: Remove extra nonce reset logic in IncrementExtraNonce (master...upstream-elements-unused-extranonce) https://github.com/bitcoin/bitcoin/pull/9627
1372017-01-25T18:46:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #9630: Add logging to GetAncestor if pindex->pprev == NULL (master...crashlogging) https://github.com/bitcoin/bitcoin/pull/9630
1382017-01-25T18:46:16  <wallet42> are the slides from jl2012 from Shanghai (about consensus) online somewhere?
1392017-01-25T18:50:45  <moli> wallet42, wrong channel
1402017-01-25T19:09:38  *** jnewbery has quit IRC
1412017-01-25T20:02:54  *** cryptapus_afk has joined #bitcoin-core-dev
1422017-01-25T20:27:59  *** cryptapus_afk has quit IRC
1432017-01-25T20:44:06  *** berndj has quit IRC
1442017-01-25T20:46:27  *** berndj has joined #bitcoin-core-dev
1452017-01-25T20:47:20  *** berndj has quit IRC
1462017-01-25T20:50:30  *** berndj has joined #bitcoin-core-dev
1472017-01-25T20:52:03  *** berndj has quit IRC
1482017-01-25T20:57:06  *** berndj has joined #bitcoin-core-dev
1492017-01-25T21:20:30  *** JB3 has joined #bitcoin-core-dev
1502017-01-25T21:24:50  *** JB3 has quit IRC
1512017-01-25T21:30:30  *** cryptapus_afk has joined #bitcoin-core-dev
1522017-01-25T21:40:31  *** cryptapus_afk has quit IRC
1532017-01-25T21:42:47  *** cysm has quit IRC
1542017-01-25T21:46:16  *** cysm has joined #bitcoin-core-dev
1552017-01-25T21:53:30  <bitcoin-git> [bitcoin] isle2983 opened pull request #9632: Add clang_static_analysis.py to help automate static analysis runs (master...PR-clang-static) https://github.com/bitcoin/bitcoin/pull/9632
1562017-01-25T22:08:15  *** ybit is now known as heath
1572017-01-25T22:37:49  *** cryptapus_afk has joined #bitcoin-core-dev
1582017-01-25T22:37:50  *** cryptapus_afk has joined #bitcoin-core-dev
1592017-01-25T23:14:22  *** CubicEarth has joined #bitcoin-core-dev
1602017-01-25T23:23:10  <CubicEarth> The biggest issue I'm aware of with lightning is the 'bank run' scenario, with not enough on-chain capacity for people to dispute fraud before the block-window closes, as could be the case if a hub tried to steal funds from millions of people. Am I understanding correctly this is an issue? Is there a viable solution?
1612017-01-25T23:24:10  <sipa> not sure this is the best place to discuss it, but i think that is the main reason why we shouldn't accept very large hubs
1622017-01-25T23:27:12  <CubicEarth> sipa: thanks. what's the better place for this topic?
1632017-01-25T23:27:47  <sipa> lightning mailing list, perhaps?
1642017-01-25T23:29:00  <gwillen> CubicEarth: there is a #lightning-dev channel
1652017-01-25T23:29:05  <gwillen> it's not super active but the right people are there
1662017-01-25T23:30:15  <CubicEarth> sipa: gwillen: √
1672017-01-25T23:30:48  *** Guyver2 has quit IRC
1682017-01-25T23:31:11  <gmaxwell> CubicEarth: there are proposals that reduce that exposure, e.g. timestop.. where CSV's counting is not monotone but can slow down when the network is full of high fees.  But it's not really needed for basic operation of the system.
1692017-01-25T23:32:20  *** waxwing has quit IRC
1702017-01-25T23:34:36  <CubicEarth> gmaxwell: cool. I'll read up.
1712017-01-25T23:38:06  <gmaxwell> I don't know if there is much of a writeup of timestop beyond the observation that CSV clock doesn't have to tick once per block.. we setup the CSV spec so there is extra room to signal other kinds of ticking.
1722017-01-25T23:38:28  <gmaxwell> Joseph poon had some ideas on particular incentive compatible timestop schemes but it hasn't had a lot of research.
1732017-01-25T23:42:19  <CubicEarth> It seems like something that needs to be solved or with time, systemic risk will develop
1742017-01-25T23:44:57  <CubicEarth> g2g ... ttyl
1752017-01-25T23:45:02  *** CubicEarth has quit IRC
1762017-01-25T23:53:06  *** Saucery has joined #bitcoin-core-dev