12017-02-09T00:08:47 *** chjj has quit IRC
22017-02-09T00:22:27 *** chjj has joined #bitcoin-core-dev
32017-02-09T00:30:06 *** AaronvanW has quit IRC
42017-02-09T00:30:40 *** AaronvanW has joined #bitcoin-core-dev
52017-02-09T00:30:40 *** AaronvanW has joined #bitcoin-core-dev
62017-02-09T00:40:38 *** Giszmo has quit IRC
72017-02-09T00:46:20 *** goregrind has joined #bitcoin-core-dev
82017-02-09T00:49:25 *** goregrin1 has quit IRC
92017-02-09T00:54:17 *** paracyst_ is now known as paracyst
102017-02-09T01:00:19 *** abpa has quit IRC
112017-02-09T01:05:01 *** AaronvanW has quit IRC
122017-02-09T01:06:39 *** AaronvanW has joined #bitcoin-core-dev
132017-02-09T01:31:03 <gmaxwell> I really wish there were an offline and tui github interface.
142017-02-09T01:31:56 <gmaxwell> jnewbery: Did you intend to thumbs down 9715 without a comment?
152017-02-09T01:32:59 <gmaxwell> (I only ask because maybe a comment got lost or you clicked the wrong button.)
162017-02-09T02:03:58 *** Ylbam has quit IRC
172017-02-09T02:08:30 *** ill has joined #bitcoin-core-dev
182017-02-09T02:21:06 *** Giszmo has joined #bitcoin-core-dev
192017-02-09T02:28:50 *** Chris_Stewart_5 has quit IRC
202017-02-09T02:58:50 *** instagibbs has quit IRC
212017-02-09T02:58:51 *** amiller has quit IRC
222017-02-09T02:59:24 *** thestringpuller has quit IRC
232017-02-09T02:59:41 *** thestringpuller has joined #bitcoin-core-dev
242017-02-09T03:00:04 *** thestringpuller is now known as Guest38580
252017-02-09T03:00:05 *** dermoth has quit IRC
262017-02-09T03:00:47 *** dermoth has joined #bitcoin-core-dev
272017-02-09T03:05:03 *** amiller has joined #bitcoin-core-dev
282017-02-09T03:05:13 *** instagibbs has joined #bitcoin-core-dev
292017-02-09T03:05:27 *** amiller is now known as Guest94103
302017-02-09T03:17:09 *** MarcoFalke has joined #bitcoin-core-dev
312017-02-09T03:19:14 *** AaronvanW has quit IRC
322017-02-09T03:24:50 *** AaronvanW has joined #bitcoin-core-dev
332017-02-09T03:24:53 *** Giszmo has quit IRC
342017-02-09T03:28:34 *** jtimon has quit IRC
352017-02-09T03:36:25 *** MarcoFalke has quit IRC
362017-02-09T03:39:28 *** PRab has quit IRC
372017-02-09T04:08:47 *** PRab has joined #bitcoin-core-dev
382017-02-09T04:13:10 *** echonaut has quit IRC
392017-02-09T04:13:33 *** echonaut has joined #bitcoin-core-dev
402017-02-09T04:20:28 *** AaronvanW has quit IRC
412017-02-09T04:43:24 *** AaronvanW has joined #bitcoin-core-dev
422017-02-09T04:59:17 *** AaronvanW has quit IRC
432017-02-09T05:17:44 *** roidster has joined #bitcoin-core-dev
442017-02-09T05:17:46 *** roidster is now known as Guest32790
452017-02-09T05:27:43 *** AaronvanW has joined #bitcoin-core-dev
462017-02-09T05:47:16 *** AaronvanW has quit IRC
472017-02-09T05:49:10 *** Guest32790 has quit IRC
482017-02-09T05:56:18 *** AaronvanW has joined #bitcoin-core-dev
492017-02-09T06:02:56 *** AaronvanW has quit IRC
502017-02-09T06:16:59 *** lclc has joined #bitcoin-core-dev
512017-02-09T06:17:20 *** luke-jr has quit IRC
522017-02-09T06:21:54 *** luke-jr has joined #bitcoin-core-dev
532017-02-09T06:27:50 *** pavel_ has joined #bitcoin-core-dev
542017-02-09T06:28:46 *** PRab_ has joined #bitcoin-core-dev
552017-02-09T06:29:15 *** jl2012_ has joined #bitcoin-core-dev
562017-02-09T06:29:56 *** wallet42_ has joined #bitcoin-core-dev
572017-02-09T06:30:33 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/dd163f578869...36f9d3ae6da4
582017-02-09T06:30:34 <bitcoin-git> bitcoin/master c8cee26 Luke Dashjr: Qt/Intro: Update block chain size
592017-02-09T06:30:34 <bitcoin-git> bitcoin/master 93ffba7 Luke Dashjr: Bugfix: Qt/Intro: Chain state needs to be stored even with the full blockchain
602017-02-09T06:30:35 <bitcoin-git> bitcoin/master a9baa6d Luke Dashjr: Bugfix: Qt/Intro: Pruned nodes never require *more* space
612017-02-09T06:33:08 *** wallet42 has quit IRC
622017-02-09T06:33:08 *** jl2012 has quit IRC
632017-02-09T06:33:08 *** PRab has quit IRC
642017-02-09T06:33:09 *** paveljanik has quit IRC
652017-02-09T06:33:09 *** NicolasDorier has quit IRC
662017-02-09T06:33:09 *** waxwing has quit IRC
672017-02-09T06:33:09 *** windsok has quit IRC
682017-02-09T06:33:17 *** jl2012_ is now known as jl2012
692017-02-09T06:33:19 *** PRab_ is now known as PRab
702017-02-09T06:33:22 *** wallet42_ is now known as wallet42
712017-02-09T06:33:30 *** windsok has joined #bitcoin-core-dev
722017-02-09T06:33:47 *** waxwing has joined #bitcoin-core-dev
732017-02-09T06:34:43 *** NicolasDorier has joined #bitcoin-core-dev
742017-02-09T06:42:07 *** AaronvanW has joined #bitcoin-core-dev
752017-02-09T06:58:11 <wumpus> should bitseed.xf2.org be removed from the seeds? re: https://github.com/bitcoin/bitcoin/issues/8861#issuecomment-278140201
762017-02-09T07:08:45 *** cannon-c has joined #bitcoin-core-dev
772017-02-09T07:19:35 *** chjj has quit IRC
782017-02-09T07:33:35 *** AaronvanW has quit IRC
792017-02-09T07:37:23 *** udiWertheimer has joined #bitcoin-core-dev
802017-02-09T07:38:23 *** AaronvanW has joined #bitcoin-core-dev
812017-02-09T07:46:13 *** pavel_ has quit IRC
822017-02-09T07:47:30 <luke-jr> wumpus: dunno, but I would prefer if bug text wasn't updated so as to make it useless for understanding what the problem was :p
832017-02-09T07:48:24 <wumpus> luke-jr: changed the title
842017-02-09T07:48:35 <luke-jr> XD
852017-02-09T07:58:12 *** AaronvanW has quit IRC
862017-02-09T08:00:47 <bitcoin-git> [bitcoin] laanwj opened pull request #9726: netbase: Do not print an error on connection timeouts through proxy (master...2017_02_intr_recv_error) https://github.com/bitcoin/bitcoin/pull/9726
872017-02-09T08:03:22 *** AaronvanW has joined #bitcoin-core-dev
882017-02-09T08:09:25 *** BashCo has quit IRC
892017-02-09T08:09:40 *** AaronvanW has quit IRC
902017-02-09T08:13:18 *** AaronvanW has joined #bitcoin-core-dev
912017-02-09T08:22:39 <bitcoin-git> [bitcoin] laanwj opened pull request #9727: Remove fallbacks for boost_filesystem < v3 (master...2017_02_boostfs_flailbacks) https://github.com/bitcoin/bitcoin/pull/9727
922017-02-09T08:29:57 *** Ylbam has joined #bitcoin-core-dev
932017-02-09T08:30:00 *** BashCo has joined #bitcoin-core-dev
942017-02-09T08:30:44 *** AaronvanW has quit IRC
952017-02-09T08:32:32 *** AaronvanW has joined #bitcoin-core-dev
962017-02-09T08:39:24 *** AaronvanW has quit IRC
972017-02-09T08:39:40 *** AaronvanW has joined #bitcoin-core-dev
982017-02-09T08:39:40 *** AaronvanW has joined #bitcoin-core-dev
992017-02-09T09:12:01 <bitcoin-git> [bitcoin] NicolasDorier opened pull request #9728: Can create Watch Only HD wallet with -hdwatchonly (master...watchonlyhd) https://github.com/bitcoin/bitcoin/pull/9728
1002017-02-09T09:39:08 *** rickygee has joined #bitcoin-core-dev
1012017-02-09T10:03:07 *** MarcoFalke has joined #bitcoin-core-dev
1022017-02-09T10:33:04 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9730: Remove bitseed.xf2.org form the dns seed list (master...2017/02/seeds) https://github.com/bitcoin/bitcoin/pull/9730
1032017-02-09T10:33:05 <jonasschnelli> wumpus: yes. Lets remove it.
1042017-02-09T10:33:33 <jonasschnelli> Try a couple of addrs from the bitseed.xf2.org DNS response...
1052017-02-09T10:33:40 *** lclc has quit IRC
1062017-02-09T10:33:42 <jonasschnelli> I could not get a single address that responsed on 8333
1072017-02-09T10:39:01 *** d9b4bef9 has quit IRC
1082017-02-09T10:40:08 *** d9b4bef9 has joined #bitcoin-core-dev
1092017-02-09T10:42:27 *** BashCo has quit IRC
1102017-02-09T10:43:11 *** rickygee has quit IRC
1112017-02-09T10:55:53 *** BashCo has joined #bitcoin-core-dev
1122017-02-09T11:06:45 *** Guyver2 has joined #bitcoin-core-dev
1132017-02-09T11:12:48 *** MarcoFalke has quit IRC
1142017-02-09T11:32:38 *** lclc has joined #bitcoin-core-dev
1152017-02-09T12:05:07 *** wvr has joined #bitcoin-core-dev
1162017-02-09T12:13:59 *** cannon-c has quit IRC
1172017-02-09T12:26:36 *** Guyver2 has quit IRC
1182017-02-09T12:40:05 *** cannon-c has joined #bitcoin-core-dev
1192017-02-09T12:47:55 *** paveljanik has joined #bitcoin-core-dev
1202017-02-09T12:54:09 *** laurentmt has joined #bitcoin-core-dev
1212017-02-09T13:01:53 *** neha has quit IRC
1222017-02-09T13:02:08 *** neha has joined #bitcoin-core-dev
1232017-02-09T13:04:00 *** lclc_ has joined #bitcoin-core-dev
1242017-02-09T13:05:12 *** lclc has quit IRC
1252017-02-09T13:16:11 *** cannon-c has quit IRC
1262017-02-09T13:40:17 *** Sosumi has joined #bitcoin-core-dev
1272017-02-09T13:56:01 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1282017-02-09T13:56:12 *** PaulCapestany has quit IRC
1292017-02-09T13:58:23 *** PaulCapestany has joined #bitcoin-core-dev
1302017-02-09T14:01:53 *** jtimon has joined #bitcoin-core-dev
1312017-02-09T14:33:59 <brg444> https://github.com/bitcoin/bitcoin/pull/9441 is this set to make it into 0.14?
1322017-02-09T14:44:51 <Lauda> brg444 I see it marked for 0.14.0?
1332017-02-09T14:45:15 <brg444> yeah nvm :P
1342017-02-09T14:48:28 *** pigeons has quit IRC
1352017-02-09T14:58:25 *** Giszmo has joined #bitcoin-core-dev
1362017-02-09T14:59:06 *** lclc_ has quit IRC
1372017-02-09T15:00:48 *** lclc has joined #bitcoin-core-dev
1382017-02-09T15:15:09 *** Giszmo has quit IRC
1392017-02-09T15:18:27 *** pigeons has joined #bitcoin-core-dev
1402017-02-09T15:18:50 *** pigeons is now known as Guest98910
1412017-02-09T15:20:16 *** wasi has quit IRC
1422017-02-09T15:20:44 *** wasi has joined #bitcoin-core-dev
1432017-02-09T15:23:30 *** Guest98910 is now known as pigeons
1442017-02-09T15:40:13 *** Guest38580 is now known as thestringpuller
1452017-02-09T15:40:48 *** thestringpuller has quit IRC
1462017-02-09T15:40:48 *** thestringpuller has joined #bitcoin-core-dev
1472017-02-09T15:54:58 *** lclc has quit IRC
1482017-02-09T15:58:30 *** windsok has quit IRC
1492017-02-09T16:13:43 *** MarcoFalke has joined #bitcoin-core-dev
1502017-02-09T16:19:42 <bitcoin-git> [bitcoin] earonesty opened pull request #9731: Bitcoin Unlimited Pull Request (master...release) https://github.com/bitcoin/bitcoin/pull/9731
1512017-02-09T16:20:02 <bitcoin-git> [bitcoin] earonesty closed pull request #9731: Bitcoin Unlimited Pull Request (master...release) https://github.com/bitcoin/bitcoin/pull/9731
1522017-02-09T16:20:11 <instagibbs> I seem to always forget, but what's the best way to get a reference(or copy) of a CScript as a unsigned char*
1532017-02-09T16:21:00 <instagibbs> sigh, as soon as I ask.. .front() seems to do trick
1542017-02-09T16:22:06 <cfields> didn't we give it a .data() ?
1552017-02-09T16:24:34 *** laurentmt has quit IRC
1562017-02-09T16:24:45 <instagibbs> appears so in master, working on slightly older branch. good call.
1572017-02-09T16:32:19 <cfields> ah, ok
1582017-02-09T16:34:28 *** windsok has joined #bitcoin-core-dev
1592017-02-09T16:43:53 <sipa> instagibbs: you can't call front om an empty vector
1602017-02-09T16:44:23 <sipa> and if it isn't empty, &v[0] works fine
1612017-02-09T16:45:31 *** abpa has joined #bitcoin-core-dev
1622017-02-09T16:52:14 <instagibbs> what happens if I do call it on an empty vector?
1632017-02-09T16:52:45 <Chris_Stewart_5> index out of bounds?
1642017-02-09T16:58:18 *** lclc has joined #bitcoin-core-dev
1652017-02-09T17:14:56 *** MarcoFalke has quit IRC
1662017-02-09T17:15:08 *** MarcoFalke has joined #bitcoin-core-dev
1672017-02-09T17:25:47 *** BashCo has quit IRC
1682017-02-09T17:27:47 *** Giszmo has joined #bitcoin-core-dev
1692017-02-09T17:29:18 *** marcoagner has joined #bitcoin-core-dev
1702017-02-09T17:39:50 *** Giszmo has quit IRC
1712017-02-09T17:46:17 *** BashCo has joined #bitcoin-core-dev
1722017-02-09T18:24:48 <sipa> instagibbs: undefined
1732017-02-09T18:25:30 <sipa> Chris_Stewart_5: no, operator[] does not do bounds checking. you're simply only allowed to call it for indexes that exist
1742017-02-09T18:38:51 <wumpus> it's one of the wacky things about c++, but we shouldn't care now that c++11 added .data()
1752017-02-09T18:39:55 <wumpus> we used to have begin_ptr and end_ptr functions to go from a vector to a begin/end pointer and wrap the "if empty" logic, but that's no longer necessary with data()
1762017-02-09T18:43:47 <Chris_Stewart_5> wumpus: Yes, coming from jvm land this has been a little confusing for me. I'll have to read more about .data()
1772017-02-09T18:45:36 *** chjj has joined #bitcoin-core-dev
1782017-02-09T18:48:57 <cfields> Chris_Stewart_5: throw .at() in for even more fun :)
1792017-02-09T18:52:11 <instagibbs> sigh. The More You Know
1802017-02-09T18:53:54 *** molz_ has joined #bitcoin-core-dev
1812017-02-09T18:54:38 *** lclc has quit IRC
1822017-02-09T18:55:43 <wumpus> yes it's bizarre
1832017-02-09T18:56:40 *** mol has quit IRC
1842017-02-09T18:57:13 <MarcoFalke> meeting in 3 minutes I guess
1852017-02-09T18:57:24 <wumpus> yes
1862017-02-09T19:00:12 <sipa> ploink
1872017-02-09T19:01:28 <MarcoFalke> everyone too busy reviewing code
1882017-02-09T19:01:39 <wumpus> #startmeeting
1892017-02-09T19:01:39 <lightningbot> Meeting started Thu Feb 9 19:01:39 2017 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
1902017-02-09T19:01:39 <lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
1912017-02-09T19:01:44 <jonasschnelli> hi
1922017-02-09T19:02:27 <wumpus> topic: 0.14, I guess
1932017-02-09T19:03:25 <jonasschnelli> What holds the rc1 back? The open PRs with 0.14 tag?
1942017-02-09T19:03:35 <wumpus> there are some net issues
1952017-02-09T19:04:00 <jonasschnelli> #9698
1962017-02-09T19:04:02 <gribble> https://github.com/bitcoin/bitcoin/issues/9698 | net: fix socket close race by theuni · Pull Request #9698 · bitcoin/bitcoin · GitHub
1972017-02-09T19:04:31 <wumpus> #9698 #9715 #9720
1982017-02-09T19:04:32 <gribble> https://github.com/bitcoin/bitcoin/issues/9698 | net: fix socket close race by theuni · Pull Request #9698 · bitcoin/bitcoin · GitHub
1992017-02-09T19:04:34 <gribble> https://github.com/bitcoin/bitcoin/issues/9715 | Disconnect peers which we do not receive VERACKs from within 60 sec by TheBlueMatt · Pull Request #9715 · bitcoin/bitcoin · GitHub
2002017-02-09T19:04:36 <gribble> https://github.com/bitcoin/bitcoin/issues/9720 | net: fix banning and disallow sending messages before receiving verack by theuni · Pull Request #9720 · bitcoin/bitcoin · GitHub
2012017-02-09T19:04:42 <wumpus> but I'm not sure that's all; cfields here?
2022017-02-09T19:04:51 <cfields> and the atomics, or did those go in this morning?
2032017-02-09T19:05:28 <cfields> #9708
2042017-02-09T19:05:30 <gribble> https://github.com/bitcoin/bitcoin/issues/9708 | Clean Up all known races/platform-specific UB by TheBlueMatt · Pull Request #9708 · bitcoin/bitcoin · GitHub
2052017-02-09T19:05:41 <wumpus> you mean the wallet update counter?
2062017-02-09T19:05:58 <wumpus> that went in, I don't know about any other atomic changes
2072017-02-09T19:06:00 <cfields> wumpus: ^^
2082017-02-09T19:06:31 <cfields> not strictly necessary for 0.14, but makes it much easier to test the others
2092017-02-09T19:06:57 <wumpus> ok will tag that too
2102017-02-09T19:08:30 <wumpus> anything else?
2112017-02-09T19:08:39 <cfields> sorry for the last minute issues. For back-story/context, BlueMatt began testing in helgrind, and came up with a list of possible races in the net code. I wrote a quick fuzz tool to try to hit some, and managed to do so in a few cases. Some are new issues, some are long-standing
2122017-02-09T19:09:21 <wumpus> well, better to catch these before the release than after atleast :)
2132017-02-09T19:09:36 <achow101> besides these net issues there's just the importmulti stuff left, yes?
2142017-02-09T19:09:38 <cfields> the above PRs address all known races in the net code. By fixing even the harmless ones, it allows us to start using tools as part of c-i to avoid introducing new ones
2152017-02-09T19:09:59 <sipa> do we want to update the static seed IP list for 0.14?
2162017-02-09T19:10:11 <jonasschnelli> That would probably be a good idea.
2172017-02-09T19:10:24 <wumpus> yes, we usually do that before a major release
2182017-02-09T19:10:36 <wumpus> I'll do that
2192017-02-09T19:11:15 <cfields> do defaultAssumeValid/nMinimumChainWork get bumps before rc1?
2202017-02-09T19:11:17 <bitcoin-git> [bitcoin] jnewbery opened pull request #9732: [Trivial] Remove nonsense #undef foreach (master...removeundefforeach) https://github.com/bitcoin/bitcoin/pull/9732
2212017-02-09T19:11:44 <wumpus> #action update hardcoded seeds
2222017-02-09T19:12:07 <sipa> we can update chainTxData (only used for progress estimation) for sure
2232017-02-09T19:13:36 <wumpus> ok, do we have a script or something for that? I wouldn't know how to do that
2242017-02-09T19:13:55 <MarcoFalke> I propose we do the bumps in the commit prior to branch off. thus we don't need to redo the work for the master branch
2252017-02-09T19:14:14 <MarcoFalke> sipa: Is is mentioned in release process.md?
2262017-02-09T19:14:19 <sipa> MarcoFalke: i believe not
2272017-02-09T19:14:29 <sipa> MarcoFalke: i'll write a script, and add it to contrib/ ?
2282017-02-09T19:15:14 <MarcoFalke> Add a note to release-process.md at least, so we don't forget about it in the future.
2292017-02-09T19:15:26 <sipa> yeah, that too
2302017-02-09T19:15:39 <MarcoFalke> If the script is only for maintainers, you can add it to the maintainer repo
2312017-02-09T19:16:18 <sipa> it was updated in #9472, which is very recent, so i don't think it needs much adjusting, but we should have a procedure for it
2322017-02-09T19:16:34 <MarcoFalke> I think it helps devs if the main repo is kept lean
2332017-02-09T19:16:45 <sipa> ok
2342017-02-09T19:17:02 <sipa> unsure what to do about defaultAssumeValid/nMinimumChainWork though
2352017-02-09T19:17:23 <gribble> https://github.com/bitcoin/bitcoin/issues/9472 | Disentangle progress estimation from checkpoints and update it by sipa · Pull Request #9472 · bitcoin/bitcoin · GitHub
2362017-02-09T19:18:38 <wumpus> yes it'd help to have the process described in any case
2372017-02-09T19:19:25 <gmaxwell> sipa: why unsure? there is a process documented in the relase instructions.
2382017-02-09T19:19:39 <gmaxwell> follow the process.
2392017-02-09T19:19:56 <MarcoFalke> sipa: We want those bumped as well, I guess. Would be nice to do assumevalid in a pull, so that people can review the hash.
2402017-02-09T19:20:22 <gmaxwell> (if the process there is somehow insufficent, -- PR's accepted.)
2412017-02-09T19:20:30 <sipa> gmaxwell: cool, i remember reviewing those release instructions even, just forgot about them
2422017-02-09T19:20:38 <gmaxwell> oh good. :P
2432017-02-09T19:21:10 <gmaxwell> There isn't a script but it's trivial enough that I didn't think one was needed. (it's basically 'call getblockchaininfo')
2442017-02-09T19:21:37 <sipa> yeah, chainTxData is a bit more complicated as it needs an estimate of the tx/s rate
2452017-02-09T19:21:40 <sipa> but i'll PR a release process update
2462017-02-09T19:22:06 <MarcoFalke> #action update release process for chainTxData
2472017-02-09T19:22:11 <gmaxwell> sipa: thats 'read two updatetip lines' ?
2482017-02-09T19:22:13 <wumpus> ideally it'd be automated with a script, especially as it's under "every minor release"
2492017-02-09T19:22:40 <gmaxwell> make a RPC that emits a patch. :P
2502017-02-09T19:23:18 <wumpus> if it's manual work, it's probably going to be skipped for most minor releases
2512017-02-09T19:23:30 <wumpus> heck, weforget to update the version numbers half the time :-)
2522017-02-09T19:24:17 <wumpus> anyhow, any other topics?
2532017-02-09T19:24:31 <sipa> well what else is on the 0.14 tagged list?
2542017-02-09T19:24:58 <sipa> is #9392 going to be fixed?
2552017-02-09T19:24:59 <gribble> https://github.com/bitcoin/bitcoin/issues/9392 | Wallet ancestor sanity-check ignores sigops · Issue #9392 · bitcoin/bitcoin · GitHub
2562017-02-09T19:25:00 <jonasschnelli> #9108
2572017-02-09T19:25:02 <gribble> https://github.com/bitcoin/bitcoin/issues/9108 | Use importmulti timestamp when importing watch only keys by ryanofsky · Pull Request #9108 · bitcoin/bitcoin · GitHub
2582017-02-09T19:25:17 <sipa> i don't think 9392 is very high priority
2592017-02-09T19:25:43 <gmaxwell> I don't think 9392 is interesting at all.
2602017-02-09T19:25:46 <wumpus> ok, let's untag it for 0.14 then, there's enough high priority stuff to worry about
2612017-02-09T19:25:51 <gmaxwell> it's not something our wallet can violate.
2622017-02-09T19:25:58 <gmaxwell> (I think, or if so it would be super fringe)
2632017-02-09T19:26:20 <wumpus> ... it isn't tagged for 0.14
2642017-02-09T19:26:39 <wumpus> oh MarcoFalke just did that
2652017-02-09T19:26:46 <wumpus> :D
2662017-02-09T19:29:36 <MarcoFalke> The other issues tagged for 0.14 have pulls open. I think this concludes the meeting
2672017-02-09T19:29:53 <achow101> does anything else need to be added to the release notes?
2682017-02-09T19:30:34 <jonasschnelli> Yes. https://github.com/bitcoin/bitcoin/issues/8455
2692017-02-09T19:30:36 <gmaxwell> I haven't been following the wiki release notes. Hows that been going?
2702017-02-09T19:31:26 <wumpus> from what I remember all the things on the list were done
2712017-02-09T19:31:30 <gmaxwell> cool.
2722017-02-09T19:31:39 <achow101> I added a ton of stuff a couple of weeks ago
2732017-02-09T19:31:46 <wumpus> yes, awesome work achow101
2742017-02-09T19:31:57 <sipa> nice
2752017-02-09T19:32:28 <jonasschnelli> thanks achow101
2762017-02-09T19:33:36 <wumpus> I was planning on merging the release notes from the wiki just before the rc1 branch
2772017-02-09T19:34:29 <wumpus> or just after the 0.14 branch-off, in any case there's no reason to have them on master they'll be cleared there anyway
2782017-02-09T19:34:34 <MarcoFalke> you mean 0.14 branch or rc1 tag?
2792017-02-09T19:34:43 <wumpus> before the rc1 tag
2802017-02-09T19:34:44 <MarcoFalke> ok
2812017-02-09T19:34:47 <wumpus> or after the 0.14 branch
2822017-02-09T19:34:53 <wumpus> doesn't matter much :)
2832017-02-09T19:34:59 <achow101> there's only two things on the release notes todo that aren't checked off. I can't write them because I don't understand those topics :(
2842017-02-09T19:35:12 <sdaftuar> the release notes currently have a recommendation to run Bitcoin Knots, for miners wishing to retain "priority" sorting for mining. i don't think recommending other forks of the project is appropriate (as i've brought up in the past)
2852017-02-09T19:35:22 <sipa> sdaftuar: agree
2862017-02-09T19:35:49 <wumpus> I don't think that makes much sense either
2872017-02-09T19:36:03 <jonasschnelli> sdaftuar: definitively.
2882017-02-09T19:36:15 <gmaxwell> My concern is different:
2892017-02-09T19:36:22 <jtimon> wumpus: if they're cleared on master after the fact, yeah, it doesn't matter
2902017-02-09T19:36:32 *** chjj has quit IRC
2912017-02-09T19:36:43 <gmaxwell> I think it's fine to recommend a compatible fork for a feature we don't care to support. BUT I think we should not be recommending priority, I think it's bad for users of the network.
2922017-02-09T19:36:48 <wumpus> jtimon: master will end up with empty release notes to be filled in for 0.15
2932017-02-09T19:37:23 <sdaftuar> gmaxwell: my primary concern is that developers on this project have not reviewed other forks. secondarily, i agree with your concern that we should not be recommending priority
2942017-02-09T19:37:29 <gmaxwell> (also, if miners do want to do priority, the best way would be using the rpc and a prioriizing daemon... but see my part (2))
2952017-02-09T19:37:40 <wumpus> (and, after 0.14.0 final is released, with the 0.14.0.md in historical release notes)
2962017-02-09T19:38:20 <gmaxwell> Part of my answer to luke when he was complaining about priority is that if miners want priority (I think ~none do) they could just use knots. I think that might motivate that release note recommendation.
2972017-02-09T19:38:32 <gmaxwell> But me saying "you can use knots" is not the same as the project saying it
2982017-02-09T19:38:45 <sdaftuar> gmaxwell: yes, i think it's fine if you or luke individually make that recommendation
2992017-02-09T19:38:50 <wumpus> just doesn't make sense to recommend it in the release notes
3002017-02-09T19:38:50 <sdaftuar> well, "fine" :)
3012017-02-09T19:39:27 <wumpus> would marginally make sense if it was an experimental feature we were expecting to merge in later
3022017-02-09T19:39:28 <jtimon> wumpus: I see, I tend to prefer to put as much in master as possible (and if it makes sense), but in this case it really doesn't matter
3032017-02-09T19:39:40 <gmaxwell> I could make a post about 'I think you shouldn't use priority, I think ~no one does, but if you want-- there is knots' which might make luke happier. I wouldn't mind doing that personally.
3042017-02-09T19:39:42 <jtimon> it's release notes
3052017-02-09T19:42:45 <gmaxwell> in any case, +1 for removing that from release notes.
3062017-02-09T19:42:51 <achow101> it's gone
3072017-02-09T19:42:53 <jtimon> maybe just a question in a faq or something? "we don't recomment using prioirty, but if you miss it, there's knots at..."
3082017-02-09T19:43:09 <gmaxwell> jtimon: infrequently asked questions
3092017-02-09T19:43:15 <achow101> (jonasschnelli removed it)
3102017-02-09T19:43:19 <gmaxwell> never asked questions
3112017-02-09T19:43:35 <jtimon> gmaxwell: yeah, in some iaq.html then
3122017-02-09T19:46:37 <wumpus> ok, any other topics?
3132017-02-09T19:47:28 <wumpus> if not, let's close the meeting
3142017-02-09T19:47:37 <gmaxwell> I'm excited to get 0.14 out. It's got lots of great stuff. :)
3152017-02-09T19:48:23 <cfields> +1 :)
3162017-02-09T19:48:24 <sipa> indeed
3172017-02-09T19:48:24 <wumpus> me too, it should be close now, everyone review!: https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.14.0
3182017-02-09T19:48:28 <jtimon> yep, many optimizations and cleanups
3192017-02-09T19:49:42 <wumpus> #endmeeting
3202017-02-09T19:49:42 <lightningbot> Meeting ended Thu Feb 9 19:49:42 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
3212017-02-09T19:49:42 <lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.html
3222017-02-09T19:49:42 <lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.txt
3232017-02-09T19:49:42 <lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2017/bitcoin-core-dev.2017-02-09-19.01.log.html
3242017-02-09T19:50:40 *** chjj has joined #bitcoin-core-dev
3252017-02-09T19:56:13 <morcos> oops sorry, the snow distracted me from the meeting
3262017-02-09T19:57:29 <morcos> achow101: you said there are 2 unchecked off things, but are there other things that need to be in release notes
3272017-02-09T19:57:38 <morcos> i think i need to mention all my new minimum fees
3282017-02-09T19:57:53 <sipa> morcos: comment about that on #8455 ?
3292017-02-09T19:57:55 <gribble> https://github.com/bitcoin/bitcoin/issues/8455 | TODO for release notes 0.14.0 · Issue #8455 · bitcoin/bitcoin · GitHub
3302017-02-09T19:57:55 <morcos> i can do that, but what's my deadline?
3312017-02-09T19:58:55 <MarcoFalke> morcos: Probably when rc1 is tagged
3322017-02-09T19:59:21 <morcos> ok, i can probably do it tomorrow if not tonight
3332017-02-09T20:06:45 <achow101> morcos: add them to the list with links to relevant PRs
3342017-02-09T20:21:36 *** Giszmo has joined #bitcoin-core-dev
3352017-02-09T20:31:10 <achow101> do maintainer scripts have to by python scripts?
3362017-02-09T20:34:53 *** lclc has joined #bitcoin-core-dev
3372017-02-09T20:43:39 *** Giszmo has quit IRC
3382017-02-09T20:48:04 <sipa> achow101: no, but they have to be usable by the people that tend to run them :)
3392017-02-09T20:48:17 <sipa> (i would object to a visual basic program, for example)
3402017-02-09T20:48:44 <achow101> so bash would be fine
3412017-02-09T20:48:49 <sipa> oh, sure
3422017-02-09T20:50:41 <achow101> ok. I think I'm going to write a do-the-pre-release-things script which does the version increment, seed update, etc
3432017-02-09T20:51:13 <achow101> (because apparently we forget to do those)
3442017-02-09T21:01:29 *** Giszmo has joined #bitcoin-core-dev
3452017-02-09T21:17:36 <sipa> achow101: that would be nice
3462017-02-09T21:30:08 <BlueMatt> does anyone have a 0.14-testing branch anywhere?
3472017-02-09T21:30:13 <BlueMatt> (ie with all the 0.14-tagged things merged)
3482017-02-09T21:39:50 *** lclc has quit IRC
3492017-02-09T21:41:15 *** Guyver2 has joined #bitcoin-core-dev
3502017-02-09T21:47:30 *** justan0theruser has quit IRC
3512017-02-09T21:48:15 *** MarcoFalke has quit IRC
3522017-02-09T21:49:34 *** wvr has quit IRC
3532017-02-09T21:50:07 *** wvr has joined #bitcoin-core-dev
3542017-02-09T22:05:05 *** marcoagner has quit IRC
3552017-02-09T22:07:58 <cfields> BlueMatt: not an answer to your question, but another branch for you to look at: https://github.com/theuni/bitcoin/tree/2017-02-fix-copystats-races
3562017-02-09T22:08:27 <BlueMatt> cfields: what all is integrated there?
3572017-02-09T22:08:35 <cfields> BlueMatt: that adds threading annotations for most net vars, and verifies your race fixes
3582017-02-09T22:08:49 <BlueMatt> ahh
3592017-02-09T22:08:52 *** marcoagner has joined #bitcoin-core-dev
3602017-02-09T22:08:54 <BlueMatt> is the first a fix for more races?
3612017-02-09T22:08:54 <cfields> here are the outstanding ones it turned up: https://github.com/theuni/bitcoin/commit/d185ca0840f8107b2cf4307f51d703e849532928
3622017-02-09T22:09:21 <BlueMatt> ahh, not actual races because of ordering of Start/Stop with other things, but, yea, should fix
3632017-02-09T22:09:24 <cfields> yea. i don't think we actually need to worry about most of it
3642017-02-09T22:09:45 <cfields> the only one with any weight is the cs_filter
3652017-02-09T22:10:00 <cfields> that one's still actually racy
3662017-02-09T22:10:56 <BlueMatt> oh, I guess i never evicted in helgrind, yea
3672017-02-09T22:11:00 <cfields> it's fRelayTxes and pfilter
3682017-02-09T22:11:48 <BlueMatt> yea
3692017-02-09T22:11:52 <BlueMatt> oh pfilter too? ouch
3702017-02-09T22:12:02 <BlueMatt> oh, pfilter != NULL
3712017-02-09T22:12:03 <BlueMatt> not so bad
3722017-02-09T22:12:05 <BlueMatt> but, yea, race
3732017-02-09T22:13:21 <cfields> adding the lock there is kinda ugly, any better ideas?
3742017-02-09T22:15:44 <BlueMatt> cfields: I think the lock is fine? I mean it goes away two LOC later?
3752017-02-09T22:21:50 <cfields> BlueMatt: just that cs_filter is held with wide scope in net_processing, i'm concerned about the ordering
3762017-02-09T22:22:32 *** MarcoFalke has joined #bitcoin-core-dev
3772017-02-09T22:26:25 <BlueMatt> cfields: agreed, does clang do lockorder checking in its compile-time stuff?
3782017-02-09T22:26:28 <BlueMatt> (or can we make it?)
3792017-02-09T22:26:40 <sipa> yes
3802017-02-09T22:27:09 <cfields> yea, you can tell it that a lock is not allowed here
3812017-02-09T22:27:54 <cfields> playing with that now
3822017-02-09T22:28:44 <sipa> the definitions in src/threadsafety.h
3832017-02-09T22:48:48 <cfields> ACQUIRED_BEFORE(...) and ACQUIRED_AFTER(...) are currently unimplemented
3842017-02-09T22:48:50 <cfields> fantastic.
3852017-02-09T22:49:19 <BlueMatt> heh
3862017-02-09T22:49:23 <BlueMatt> does clang support them, though?
3872017-02-09T22:49:59 <cfields> https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
3882017-02-09T22:50:04 <cfields> that's from the clang docs
3892017-02-09T22:50:20 *** droark has quit IRC
3902017-02-09T22:50:28 <BlueMatt> heh
3912017-02-09T23:12:21 *** gluytium has joined #bitcoin-core-dev
3922017-02-09T23:15:02 <cfields> mm, nope. It's not smart enough to figure it out. The fact that cs_vNodes lives in CConnman and cs_filter lives in CNode is too much.
3932017-02-09T23:16:26 *** musalbas has quit IRC
3942017-02-09T23:16:48 *** musalbas has joined #bitcoin-core-dev
3952017-02-09T23:16:49 <luke-jr> can someone reopen #7339 please?
3962017-02-09T23:16:50 <gribble> https://github.com/bitcoin/bitcoin/issues/7339 | Support building without libevent by luke-jr · Pull Request #7339 · bitcoin/bitcoin · GitHub
3972017-02-09T23:32:05 *** jeremyrubin has quit IRC
3982017-02-09T23:33:00 *** jeremyrubin has joined #bitcoin-core-dev
3992017-02-09T23:35:17 *** harrymm1 has joined #bitcoin-core-dev
4002017-02-09T23:35:53 *** marcoagner has quit IRC
4012017-02-09T23:36:00 *** harrymm has quit IRC
4022017-02-09T23:36:09 <cfields> BlueMatt: how much do you hate this https://github.com/theuni/bitcoin/commit/c6a93bd5313297d7ec091988a46366cfc12fef3c ? rather just pile on more atomics instead?
4032017-02-09T23:41:42 *** justanotheruser has joined #bitcoin-core-dev