1 2017-02-10T00:21:48  *** MarcoFalke has quit IRC
  2 2017-02-10T00:30:34  *** JackH has quit IRC
  3 2017-02-10T00:40:52  *** Guyver2 has quit IRC
  4 2017-02-10T00:59:55  *** wasi has quit IRC
  5 2017-02-10T01:01:41  *** abpa has quit IRC
  6 2017-02-10T01:04:07  *** wasi has joined #bitcoin-core-dev
  7 2017-02-10T01:26:27  <bitcoin-git> [bitcoin] sipa opened pull request #9733: Add getchaintxstats RPC (master...chaintxstats) https://github.com/bitcoin/bitcoin/pull/9733
  8 2017-02-10T01:35:11  *** Giszmo has quit IRC
  9 2017-02-10T01:39:48  <BlueMatt> cfields: 0.15, please
 10 2017-02-10T01:40:11  <BlueMatt> cfields: lets please get simple-to-review shit so we can (finally) get 0.14 out the door
 11 2017-02-10T01:42:43  *** wvr has quit IRC
 12 2017-02-10T01:47:32  <cfields> BlueMatt: see the PR. I really have no preference
 13 2017-02-10T01:47:58  <BlueMatt> wait, which pr?
 14 2017-02-10T01:48:48  <BlueMatt> oh, comment
 15 2017-02-10T02:00:36  <BlueMatt> cfields: I guess my (weak) preference is atomics
 16 2017-02-10T02:00:58  <BlueMatt> because it doesnt change the compiled code for x86 (well, ok, only if we use release/acquire, but close enough) and is more obviously correct (tm)
 17 2017-02-10T02:01:45  <cfields> BlueMatt: works for me.
 18 2017-02-10T02:02:10  <BlueMatt> cfields: want me to pull it into that pr or a new one? it already has acks....
 19 2017-02-10T02:02:40  <cfields> heh
 20 2017-02-10T02:03:07  <BlueMatt> hmm?
 21 2017-02-10T02:03:56  <cfields> BlueMatt: well, technically commit is buggy because it doesn't fix the race as advertised. So i'd call that a fix to the PR as opposed to something new
 22 2017-02-10T02:04:41  <cfields> so I think it makes sense to just stick on top and poke for quick re-acks
 23 2017-02-10T02:05:45  <BlueMatt> I'll change the pr title, then :p
 24 2017-02-10T02:05:58  <BlueMatt> wait, no pr title was valid when opened
 25 2017-02-10T02:06:49  <BlueMatt> "Clean up all known races/platform-specific UB at the time PR was opened #9708
 26 2017-02-10T02:06:50  <BlueMatt> "
 27 2017-02-10T02:06:51  <BlueMatt> happy now?
 28 2017-02-10T02:06:51  <gribble> https://github.com/bitcoin/bitcoin/issues/9708 | Clean up all known races/platform-specific UB at the time PR was opened by TheBlueMatt · Pull Request #9708 · bitcoin/bitcoin · GitHub
 29 2017-02-10T02:06:52  <BlueMatt> :p
 30 2017-02-10T02:07:07  <cfields> heh, I was just making the point that it's a fix. I really don't care :)
 31 2017-02-10T02:07:15  <cfields> lol
 32 2017-02-10T02:07:47  <cfields> ok, i'm definitely closing mine now though, since 9708 is tagged for 0.14
 33 2017-02-10T02:08:06  <BlueMatt> ok, sounds good, open another one :)
 34 2017-02-10T02:09:36  <cfields> tell you what, I'll open another one based on master if it happens to not conflict with yours
 35 2017-02-10T02:09:55  <BlueMatt> great! :)
 36 2017-02-10T02:09:56  <cfields> without looking, i'd call it 50/50 :)
 37 2017-02-10T02:10:22  <BlueMatt> conflict on git's within-3-lines shit? probably....actually conflict? no
 38 2017-02-10T02:13:36  <bitcoin-git> [bitcoin] theuni closed pull request #9695: net: fix a few races. Credit @TheBlueMatt (master...net-atomic) https://github.com/bitcoin/bitcoin/pull/9695
 39 2017-02-10T02:13:58  *** Ylbam has quit IRC
 40 2017-02-10T02:16:11  <cfields> actually, I think I'll pass on it either way. I think fatigue of these race commits is starting to set in. And since it's two 1-bit comparisons that have existed in prior releases, it's just not worth holding things up
 41 2017-02-10T02:16:51  *** da2ce7 has quit IRC
 42 2017-02-10T02:17:29  <BlueMatt> cfields: ok, I have no objections to that, either...when its std::string copies I'm not very happy, when its just pointer == NULL comparisons I suppose I dont care much
 43 2017-02-10T02:18:05  <cfields> BlueMatt: sure. The only reason I'd push for it is if it was the lone thing keeping valgrind/helgrind/tsan/etc. from running cleanly.
 44 2017-02-10T02:18:18  <BlueMatt> fair
 45 2017-02-10T02:18:28  <cfields> and I don't think that's the case?
 46 2017-02-10T02:19:02  *** da2ce7 has joined #bitcoin-core-dev
 47 2017-02-10T02:19:03  <BlueMatt> my helgrind is still running cleanly :)
 48 2017-02-10T02:30:49  *** da2ce7 has quit IRC
 49 2017-02-10T03:10:12  <bitcoin-git> [bitcoin] sipa opened pull request #9734: Add updating of chainTxData to release process (master...chaintxnotes) https://github.com/bitcoin/bitcoin/pull/9734
 50 2017-02-10T03:37:30  *** jtimon has quit IRC
 51 2017-02-10T03:43:32  <gmaxwell> Whatever patch stack I'm running with here makes tsan clean except for some startup noise.
 52 2017-02-10T03:43:50  <gmaxwell> (by noise I mean real issues, in this case.)
 53 2017-02-10T04:43:45  *** goksinen has joined #bitcoin-core-dev
 54 2017-02-10T04:53:01  *** goksinen_ has joined #bitcoin-core-dev
 55 2017-02-10T05:01:17  *** gluytium has quit IRC
 56 2017-02-10T05:04:28  *** gluytium has joined #bitcoin-core-dev
 57 2017-02-10T05:07:36  *** goksinen_ has quit IRC
 58 2017-02-10T05:07:59  *** kadoban has quit IRC
 59 2017-02-10T05:18:40  *** Sosumi has quit IRC
 60 2017-02-10T05:19:06  *** dodo has joined #bitcoin-core-dev
 61 2017-02-10T05:19:29  *** dodo is now known as Guest24942
 62 2017-02-10T05:22:16  *** goksinen has quit IRC
 63 2017-02-10T05:23:27  *** goksinen has joined #bitcoin-core-dev
 64 2017-02-10T05:25:52  *** Guest24942 has quit IRC
 65 2017-02-10T05:28:45  *** goksinen has quit IRC
 66 2017-02-10T05:40:15  *** cannon-c has joined #bitcoin-core-dev
 67 2017-02-10T06:04:19  *** instagibbs has quit IRC
 68 2017-02-10T06:06:03  *** instagibbs has joined #bitcoin-core-dev
 69 2017-02-10T06:26:08  *** da2ce7 has joined #bitcoin-core-dev
 70 2017-02-10T06:46:18  *** lclc has joined #bitcoin-core-dev
 71 2017-02-10T07:01:55  *** Ylbam has joined #bitcoin-core-dev
 72 2017-02-10T07:22:59  *** beyondsee has joined #bitcoin-core-dev
 73 2017-02-10T07:24:15  <beyondsee> any one here?
 74 2017-02-10T07:28:15  *** MarcoFalke has joined #bitcoin-core-dev
 75 2017-02-10T07:28:39  <sipa> nope
 76 2017-02-10T07:31:26  <cannon-c> no
 77 2017-02-10T07:36:01  <paveljanik> haven't seen any one for a long time...
 78 2017-02-10T07:36:19  <sipa> paveljanik! what a surprise!
 79 2017-02-10T07:43:56  <paveljanik> gribble" later tell anyone Beyonce wanted to talk to you
 80 2017-02-10T08:02:34  *** arubi has quit IRC
 81 2017-02-10T08:03:38  *** BashCo has quit IRC
 82 2017-02-10T08:03:57  *** arubi has joined #bitcoin-core-dev
 83 2017-02-10T08:14:46  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/36f9d3ae6da4...33f3b21407a3
 84 2017-02-10T08:14:46  <bitcoin-git> bitcoin/master ca9955e Jonas Schnelli: Remove bitseed.xf2.org form the dns seed list
 85 2017-02-10T08:14:47  <bitcoin-git> bitcoin/master 33f3b21 Jonas Schnelli: Merge #9730: Remove bitseed.xf2.org form the dns seed list...
 86 2017-02-10T08:15:05  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #9730: Remove bitseed.xf2.org form the dns seed list (master...2017/02/seeds) https://github.com/bitcoin/bitcoin/pull/9730
 87 2017-02-10T08:15:10  *** harrymm1 has quit IRC
 88 2017-02-10T08:18:01  *** harrymm has joined #bitcoin-core-dev
 89 2017-02-10T08:21:21  *** MarcoFalke has quit IRC
 90 2017-02-10T08:24:22  *** BashCo has joined #bitcoin-core-dev
 91 2017-02-10T09:04:44  <bitcoin-git> [bitcoin] laanwj opened pull request #9735: devtools: Handle Qt formatting characters edge-case in update-translations.py (master...2017_02_qt_translations) https://github.com/bitcoin/bitcoin/pull/9735
 92 2017-02-10T09:28:51  *** echonaut has quit IRC
 93 2017-02-10T09:29:05  *** echonaut has joined #bitcoin-core-dev
 94 2017-02-10T09:29:58  <bitcoin-git> [bitcoin] laanwj opened pull request #9736: Pre-0.14.0 hardcoded seeds update (master...2017_02_dnsseeds) https://github.com/bitcoin/bitcoin/pull/9736
 95 2017-02-10T09:30:05  *** echonaut has quit IRC
 96 2017-02-10T09:30:18  *** echonaut has joined #bitcoin-core-dev
 97 2017-02-10T09:30:39  *** echonaut has quit IRC
 98 2017-02-10T09:30:51  *** echonaut has joined #bitcoin-core-dev
 99 2017-02-10T09:40:22  *** echonaut has quit IRC
100 2017-02-10T09:40:53  *** echonaut has joined #bitcoin-core-dev
101 2017-02-10T09:41:21  *** echonaut has quit IRC
102 2017-02-10T09:47:37  *** echonaut has joined #bitcoin-core-dev
103 2017-02-10T09:52:15  *** echonaut has quit IRC
104 2017-02-10T09:53:20  *** echonaut has joined #bitcoin-core-dev
105 2017-02-10T09:56:05  *** wvr has joined #bitcoin-core-dev
106 2017-02-10T10:02:12  *** beyondsee has quit IRC
107 2017-02-10T10:21:29  <bitcoin-git> [bitcoin] rebroad opened pull request #9737: Don't disconnect feeler connections prematurely (master...ServicesIrrelevantForFeelerConnections) https://github.com/bitcoin/bitcoin/pull/9737
108 2017-02-10T10:21:57  <jl2012> Is it useful to have an rpc command for calling TestBlockValidity, with or without checking PoW?
109 2017-02-10T10:28:05  <wumpus> I don't know? what is your use case?
110 2017-02-10T10:34:14  *** davidlj95 has joined #bitcoin-core-dev
111 2017-02-10T10:34:20  *** davidlj95 has left #bitcoin-core-dev
112 2017-02-10T10:36:13  *** BashCo_ has joined #bitcoin-core-dev
113 2017-02-10T10:39:58  *** BashCo has quit IRC
114 2017-02-10T10:42:24  *** lclc has quit IRC
115 2017-02-10T11:00:27  *** cannon-c has left #bitcoin-core-dev
116 2017-02-10T11:12:42  *** cannon-c has joined #bitcoin-core-dev
117 2017-02-10T11:15:58  *** harrymm has quit IRC
118 2017-02-10T11:17:42  *** Guyver2 has joined #bitcoin-core-dev
119 2017-02-10T11:25:27  *** lclc has joined #bitcoin-core-dev
120 2017-02-10T11:30:51  *** harrymm has joined #bitcoin-core-dev
121 2017-02-10T11:31:33  *** str4d has joined #bitcoin-core-dev
122 2017-02-10T11:34:50  <jl2012> For example, I created a block and want to test if it is valid, before mining it
123 2017-02-10T11:37:35  <wumpus> but sure, a "block proposals" thing could make sense, it has been discussed before on github
124 2017-02-10T11:43:18  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/33f3b21407a3...2447c1024e60
125 2017-02-10T11:43:19  <bitcoin-git> bitcoin/master 45e2e08 Cory Fields: net: rearrange so that socket accesses can be grouped together
126 2017-02-10T11:43:19  <bitcoin-git> bitcoin/master 9a0b784 Cory Fields: net: add a lock around hSocket
127 2017-02-10T11:43:20  <bitcoin-git> bitcoin/master 2447c10 Wladimir J. van der Laan: Merge #9698: net: fix socket close race...
128 2017-02-10T11:43:38  <bitcoin-git> [bitcoin] laanwj closed pull request #9698: net: fix socket close race (master...fix-socket-disconnect2) https://github.com/bitcoin/bitcoin/pull/9698
129 2017-02-10T11:44:32  <wumpus> though I can't find it right now
130 2017-02-10T12:25:13  *** face has joined #bitcoin-core-dev
131 2017-02-10T12:45:58  *** str4d has quit IRC
132 2017-02-10T13:28:06  *** Giszmo has joined #bitcoin-core-dev
133 2017-02-10T13:40:45  <cfields> jl2012: https://github.com/bitcoin/bitcoin/pull/9000
134 2017-02-10T13:41:02  <cfields> i'll rebase
135 2017-02-10T14:10:05  *** harrymm has quit IRC
136 2017-02-10T14:15:48  *** Giszmo has quit IRC
137 2017-02-10T14:29:30  *** harrymm has joined #bitcoin-core-dev
138 2017-02-10T14:32:52  *** Giszmo has joined #bitcoin-core-dev
139 2017-02-10T14:33:46  *** harrymm has quit IRC
140 2017-02-10T14:40:23  *** jtimon has joined #bitcoin-core-dev
141 2017-02-10T14:46:05  *** Giszmo has quit IRC
142 2017-02-10T14:47:05  *** harrymm has joined #bitcoin-core-dev
143 2017-02-10T14:51:05  *** laurentmt has joined #bitcoin-core-dev
144 2017-02-10T15:01:13  *** Giszmo has joined #bitcoin-core-dev
145 2017-02-10T15:06:05  *** laurentmt has quit IRC
146 2017-02-10T15:22:48  *** Guyver2 has quit IRC
147 2017-02-10T15:31:08  *** lclc has quit IRC
148 2017-02-10T15:39:05  *** harrymm has quit IRC
149 2017-02-10T15:57:57  *** harrymm has joined #bitcoin-core-dev
150 2017-02-10T16:09:06  <gmaxwell> jl2012: we have block proposals, use getblocktemplate with the mode "proposal" and it will check a block while ignoring the pow.
151 2017-02-10T16:12:17  <bitcoin-git> [bitcoin] jnewbery opened pull request #9738: gettxoutproof() should return consistent result (master...fixgettxoutproof) https://github.com/bitcoin/bitcoin/pull/9738
152 2017-02-10T16:13:53  *** kewde[m] has joined #bitcoin-core-dev
153 2017-02-10T16:17:41  *** baldur has quit IRC
154 2017-02-10T16:23:45  *** str4d has joined #bitcoin-core-dev
155 2017-02-10T16:23:48  *** BashCo_ has quit IRC
156 2017-02-10T16:24:17  *** chjj has quit IRC
157 2017-02-10T16:30:03  *** chjj has joined #bitcoin-core-dev
158 2017-02-10T16:42:27  *** BashCo has joined #bitcoin-core-dev
159 2017-02-10T16:52:50  *** MarcoFalke has joined #bitcoin-core-dev
160 2017-02-10T16:52:52  *** str4d_ has joined #bitcoin-core-dev
161 2017-02-10T16:56:10  *** str4d has quit IRC
162 2017-02-10T16:58:46  <Chris_Stewart_5> Is there a reason there isn't more functionality exposed for the java secp256k1 api? Or is it a matter of some one just needs to write it?
163 2017-02-10T17:03:13  *** abpa has joined #bitcoin-core-dev
164 2017-02-10T17:03:53  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2447c1024e60...b860915f8b0d
165 2017-02-10T17:03:54  <bitcoin-git> bitcoin/master 9db8eec John Newbery: Fix RPC failure testing...
166 2017-02-10T17:03:54  <bitcoin-git> bitcoin/master b860915 MarcoFalke: Merge #9707: Fix RPC failure testing...
167 2017-02-10T17:04:13  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9707: Fix RPC failure testing (master...rpctestassert) https://github.com/bitcoin/bitcoin/pull/9707
168 2017-02-10T17:05:34  <sipa> Chris_Stewart_5: what is missing?
169 2017-02-10T17:05:41  <sipa> patches welcome
170 2017-02-10T17:08:54  *** goksinen has joined #bitcoin-core-dev
171 2017-02-10T17:10:02  <Chris_Stewart_5> I think you had mentioned there is a CPubKey::IsValid function inside of secp256k1 which is the consensus check if the pubkey is valid?
172 2017-02-10T17:14:14  *** goksinen has quit IRC
173 2017-02-10T17:34:52  <sipa> look at what bitcoin core does
174 2017-02-10T17:36:26  <sipa> CPubKey::IsFullyValid
175 2017-02-10T17:39:28  *** neha has quit IRC
176 2017-02-10T17:41:49  *** goksinen has joined #bitcoin-core-dev
177 2017-02-10T17:54:29  <Chris_Stewart_5> ahh, that makes much more sense.
178 2017-02-10T17:57:41  *** goksinen has quit IRC
179 2017-02-10T18:02:59  *** goksinen has joined #bitcoin-core-dev
180 2017-02-10T18:06:34  *** laurentmt has joined #bitcoin-core-dev
181 2017-02-10T18:20:06  <bitcoin-git> [bitcoin] jnewbery opened pull request #9739: Fix BIP68 activation test (master...fixbip68testing) https://github.com/bitcoin/bitcoin/pull/9739
182 2017-02-10T18:22:12  <cfields> jnewbery: lots of great work!
183 2017-02-10T18:23:04  <jnewbery> Thanks! I've uncovered some gnarly stuff in the course of my archaeology :)
184 2017-02-10T18:26:26  <cfields> jnewbery: heh, i see that. Seems many of the tests have been accidentally working for a while
185 2017-02-10T18:27:12  *** lclc has joined #bitcoin-core-dev
186 2017-02-10T18:27:13  <jnewbery> yup. Hopefully once these PRs have gone through we'll be in a better place and the tests will actually be testing things!
187 2017-02-10T18:28:31  <cfields> heh
188 2017-02-10T18:28:53  <cfields> jnewbery: i ran into something similar to 9707 (i think) when writing a test recently. I suck at python, and the exception model in mininode is not clear to me. Mind taking look when you have a min and seeing if my approach is reasonable or i'm just piling on more brokenness?
189 2017-02-10T18:29:34  <jnewbery> Absolutely. Very happy to look at it
190 2017-02-10T18:30:08  <cfields> jnewbery: thanks! It's the test added in #9720
191 2017-02-10T18:30:10  <gribble> https://github.com/bitcoin/bitcoin/issues/9720 | net: fix banning and disallow sending messages before receiving verack by theuni · Pull Request #9720 · bitcoin/bitcoin · GitHub
192 2017-02-10T18:30:57  <cfields> jnewbery: ping me when you have a min to look at it and i'll explain the problem?
193 2017-02-10T18:31:28  *** lclc has quit IRC
194 2017-02-10T18:32:54  *** laurentmt has quit IRC
195 2017-02-10T18:36:49  <jnewbery> Sure. Give me a few minutes
196 2017-02-10T18:47:10  <cfields> no rush
197 2017-02-10T18:47:50  *** str4d_ has quit IRC
198 2017-02-10T19:01:01  <jnewbery> did you get my private message?
199 2017-02-10T19:03:26  *** Giszmo has quit IRC
200 2017-02-10T19:16:37  *** laurentmt has joined #bitcoin-core-dev
201 2017-02-10T19:18:09  *** Giszmo has joined #bitcoin-core-dev
202 2017-02-10T19:25:43  *** Giszmo has quit IRC
203 2017-02-10T19:45:37  *** jtimon has quit IRC
204 2017-02-10T19:49:35  *** chjj has quit IRC
205 2017-02-10T19:50:14  *** str4d_ has joined #bitcoin-core-dev
206 2017-02-10T19:53:19  *** laurentmt has quit IRC
207 2017-02-10T20:03:12  *** chjj has joined #bitcoin-core-dev
208 2017-02-10T21:13:14  *** ill has quit IRC
209 2017-02-10T21:22:25  *** JackH has joined #bitcoin-core-dev
210 2017-02-10T21:31:55  *** goksinen has quit IRC
211 2017-02-10T21:46:50  *** echonaut has quit IRC
212 2017-02-10T21:47:20  *** echonaut has joined #bitcoin-core-dev
213 2017-02-10T21:47:22  *** goksinen_ has joined #bitcoin-core-dev
214 2017-02-10T22:24:51  *** chjj has quit IRC
215 2017-02-10T22:30:10  *** kadoban has joined #bitcoin-core-dev
216 2017-02-10T22:38:38  *** chjj has joined #bitcoin-core-dev
217 2017-02-10T23:38:10  *** chjj has quit IRC
218 2017-02-10T23:51:46  *** chjj has joined #bitcoin-core-dev