1 2017-02-15T00:09:31  *** kadoban_ is now known as kadoban
  2 2017-02-15T00:35:30  *** Guyver2 has quit IRC
  3 2017-02-15T00:52:36  <BlueMatt> hmmmmmm...i asked to use the MTP of the current block in the default importmulti timestamps because I thought that would be sufficient (+/- reorgs)...I assume #9761 is pretty much just for reorgs, then?
  4 2017-02-15T00:52:37  <gribble> https://github.com/bitcoin/bitcoin/issues/9761 | Use 2 hour grace period for key timestamps in importmulti rescans by ryanofsky · Pull Request #9761 · bitcoin/bitcoin · GitHub
  5 2017-02-15T00:52:38  <BlueMatt> gmaxwell: maybe?
  6 2017-02-15T01:34:35  <morcos_> BlueMatt: the motivation of 9761 was a hypothetical situation that i didn't bother to test the reasonability of
  7 2017-02-15T01:34:46  <morcos_> how do we think someone is going to get these birthdates
  8 2017-02-15T01:35:21  <morcos_> in particular is it likely that you'll get it from a dumpprivkey or a validateaddress call or something else from a node where the key was created in the wallet
  9 2017-02-15T01:35:37  <morcos_> if that wallet created timestamp is exposed, then thats not created with MTP
 10 2017-02-15T01:35:51  <morcos_> so you need the buffer
 11 2017-02-15T01:36:41  *** morcos_ is now known as morcos
 12 2017-02-15T01:40:59  <morcos> i guess looking now before the recent change to validateaddress, there was no way to expose nCreateTime?  but in any case there is now i think.
 13 2017-02-15T01:43:09  <morcos> kind of a weird feature then when it was created.  what were people expected to put in for the timestamp?  how would they know?  i guess maybe they know separately the time of the first block that was relevant?
 14 2017-02-15T01:46:10  *** goksinen has quit IRC
 15 2017-02-15T02:06:55  *** goksinen has joined #bitcoin-core-dev
 16 2017-02-15T02:12:05  *** goksinen has quit IRC
 17 2017-02-15T02:32:03  *** chjj has joined #bitcoin-core-dev
 18 2017-02-15T02:38:58  *** goksinen has joined #bitcoin-core-dev
 19 2017-02-15T02:40:01  *** chjj has quit IRC
 20 2017-02-15T02:41:59  *** Arvidt_ has joined #bitcoin-core-dev
 21 2017-02-15T02:43:27  *** goksinen has quit IRC
 22 2017-02-15T02:45:45  <Arvidt_> When running bitcoind with onlynet=onion, proxy=, listen=1 and externalip=xxx.onion  (Tor with bitcoind hidden service xxx.onion on  can I still connect directly to bitcoind on ? How could I test that?
 23 2017-02-15T02:46:10  <sipa> yes
 24 2017-02-15T02:46:26  <sipa> you can test by running a second bitcoind and -connect= to it
 25 2017-02-15T02:46:38  <sipa> (with a different datadir, -port, and -rpcport)
 26 2017-02-15T02:49:31  <Arvidt_> Thanks a lot for answer. Hm I thought more of a little telnet test, second instance is a little bit too much for me for test setup.
 27 2017-02-15T02:55:20  *** Giszmo has quit IRC
 28 2017-02-15T02:56:17  <sipa> a telnet test would work too, but you'd need to construct a handshake
 29 2017-02-15T02:56:17  <sipa> just a version message should be enough, which you could send with netcat
 30 2017-02-15T03:03:10  *** echonaut1 has joined #bitcoin-core-dev
 31 2017-02-15T03:03:10  *** Aaronvan_ has joined #bitcoin-core-dev
 32 2017-02-15T03:03:10  *** juscamarena_ has joined #bitcoin-core-dev
 33 2017-02-15T03:03:59  *** Ylbam has quit IRC
 34 2017-02-15T03:04:13  *** rubensayshi_ has joined #bitcoin-core-dev
 35 2017-02-15T03:04:55  *** paracyst_ has joined #bitcoin-core-dev
 36 2017-02-15T03:06:01  *** wolfspraul has joined #bitcoin-core-dev
 37 2017-02-15T03:06:26  *** jouke_ has joined #bitcoin-core-dev
 38 2017-02-15T03:06:33  *** emzy_ has joined #bitcoin-core-dev
 39 2017-02-15T03:06:38  *** gwollon has joined #bitcoin-core-dev
 40 2017-02-15T03:06:43  *** wump has joined #bitcoin-core-dev
 41 2017-02-15T03:07:08  *** thestrin1puller has joined #bitcoin-core-dev
 42 2017-02-15T03:07:08  *** Alina-malina_ has joined #bitcoin-core-dev
 43 2017-02-15T03:07:10  *** crescendo has joined #bitcoin-core-dev
 44 2017-02-15T03:09:08  *** rubensayshi has quit IRC
 45 2017-02-15T03:09:08  *** pindarhk has quit IRC
 46 2017-02-15T03:09:08  *** AaronvanW has quit IRC
 47 2017-02-15T03:09:08  *** profall has quit IRC
 48 2017-02-15T03:09:08  *** jouke has quit IRC
 49 2017-02-15T03:09:08  *** isis has quit IRC
 50 2017-02-15T03:09:08  *** lejitz has quit IRC
 51 2017-02-15T03:09:08  *** juscamarena has quit IRC
 52 2017-02-15T03:09:08  *** Alina-malina has quit IRC
 53 2017-02-15T03:09:08  *** crescend1 has quit IRC
 54 2017-02-15T03:09:08  *** ibrightly has quit IRC
 55 2017-02-15T03:09:08  *** gwillen has quit IRC
 56 2017-02-15T03:09:08  *** emzy has quit IRC
 57 2017-02-15T03:09:08  *** belcher has quit IRC
 58 2017-02-15T03:09:08  *** echonaut has quit IRC
 59 2017-02-15T03:09:08  *** face has quit IRC
 60 2017-02-15T03:09:08  *** thestringpuller has quit IRC
 61 2017-02-15T03:09:08  *** wolfspra1l has quit IRC
 62 2017-02-15T03:09:08  *** wumpus has quit IRC
 63 2017-02-15T03:09:21  *** paracyst has quit IRC
 64 2017-02-15T03:09:21  *** rubensayshi_ is now known as rubensayshi
 65 2017-02-15T03:09:21  *** face has joined #bitcoin-core-dev
 66 2017-02-15T03:09:21  *** belcher has joined #bitcoin-core-dev
 67 2017-02-15T03:09:36  *** isis has joined #bitcoin-core-dev
 68 2017-02-15T03:10:53  *** goksinen has joined #bitcoin-core-dev
 69 2017-02-15T03:13:10  *** pindarhk has joined #bitcoin-core-dev
 70 2017-02-15T03:13:10  *** ibrightly has joined #bitcoin-core-dev
 71 2017-02-15T03:15:47  *** goksinen has quit IRC
 72 2017-02-15T03:16:33  *** gwollon is now known as gwillen
 73 2017-02-15T03:30:44  <Arvidt_> @sipa thanks for the tip. I took the second example from https://en.bitcoin.it/wiki/Protocol_documentation#version  to bitcoind and got a VERACK :-)
 74 2017-02-15T03:30:55  <sipa> cool
 75 2017-02-15T03:41:45  *** goksinen has joined #bitcoin-core-dev
 76 2017-02-15T03:45:57  *** goksinen has quit IRC
 77 2017-02-15T04:07:50  *** PaulCape_ has quit IRC
 78 2017-02-15T04:12:01  *** truquini___ has quit IRC
 79 2017-02-15T04:13:31  *** goksinen has joined #bitcoin-core-dev
 80 2017-02-15T04:15:46  *** PRab has quit IRC
 81 2017-02-15T04:17:57  *** goksinen has quit IRC
 82 2017-02-15T04:30:06  *** kadoban has quit IRC
 83 2017-02-15T04:45:36  *** goksinen has joined #bitcoin-core-dev
 84 2017-02-15T04:49:57  *** goksinen has quit IRC
 85 2017-02-15T05:01:18  *** lejitz has joined #bitcoin-core-dev
 86 2017-02-15T05:01:25  *** profall has joined #bitcoin-core-dev
 87 2017-02-15T05:14:53  *** tunafizz has joined #bitcoin-core-dev
 88 2017-02-15T05:16:34  *** goksinen has joined #bitcoin-core-dev
 89 2017-02-15T05:21:05  *** goksinen has quit IRC
 90 2017-02-15T05:32:38  *** goksinen has joined #bitcoin-core-dev
 91 2017-02-15T05:36:57  *** goksinen has quit IRC
 92 2017-02-15T05:39:47  *** Alina-malina_ has quit IRC
 93 2017-02-15T05:39:47  *** Alina-malina_ has joined #bitcoin-core-dev
 94 2017-02-15T05:40:07  *** Alina-malina_ is now known as Alina-malina
 95 2017-02-15T06:51:55  *** lclc has joined #bitcoin-core-dev
 96 2017-02-15T07:09:58  <bitcoin-git> [bitcoin] CryptAxe opened pull request #9763: [Trivial] Update comments referencing main.cpp (master...comments) https://github.com/bitcoin/bitcoin/pull/9763
 97 2017-02-15T07:21:28  *** jtimon has quit IRC
 98 2017-02-15T07:25:59  *** jonasschnelli has quit IRC
 99 2017-02-15T07:25:59  *** jonasschnelli has joined #bitcoin-core-dev
100 2017-02-15T07:35:07  *** BashCo has quit IRC
101 2017-02-15T07:36:22  *** Chris_Stewart_5 has quit IRC
102 2017-02-15T07:44:40  *** Ylbam has joined #bitcoin-core-dev
103 2017-02-15T08:01:43  *** BashCo has joined #bitcoin-core-dev
104 2017-02-15T08:02:50  *** BashCo_ has joined #bitcoin-core-dev
105 2017-02-15T08:06:58  *** BashCo has quit IRC
106 2017-02-15T08:09:17  *** bakunin has joined #bitcoin-core-dev
107 2017-02-15T08:13:10  <bakunin> hiho, just wanted to say thank you, bitcoin core developers, you are doing an outstanding job.-Thank you very much.
108 2017-02-15T08:14:44  *** LeMiner has quit IRC
109 2017-02-15T08:16:52  *** LeMiner has joined #bitcoin-core-dev
110 2017-02-15T08:22:10  *** windsok has quit IRC
111 2017-02-15T08:23:08  *** Guyver2 has joined #bitcoin-core-dev
112 2017-02-15T08:23:39  *** windsok has joined #bitcoin-core-dev
113 2017-02-15T08:24:26  <wump> good to hear that bakunin
114 2017-02-15T08:24:31  *** wump is now known as wumpus
115 2017-02-15T08:28:17  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a441db01b527...4c69d683f22a
116 2017-02-15T08:28:18  <bitcoin-git> bitcoin/master a47da4b practicalswift: Use z = std::max(x - y, 0); instead of z = x - y; if (z < 0) z = 0;
117 2017-02-15T08:28:19  <bitcoin-git> bitcoin/master 4c69d68 Wladimir J. van der Laan: Merge #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0;...
118 2017-02-15T08:28:32  <bitcoin-git> [bitcoin] laanwj closed pull request #9553: Use z = std::max(x - y, 0) instead of z = x - y; if (z < 0) z = 0; (master...std-max) https://github.com/bitcoin/bitcoin/pull/9553
119 2017-02-15T08:46:25  *** bakunin has quit IRC
120 2017-02-15T08:47:25  *** Guyver2 has quit IRC
121 2017-02-15T09:38:03  *** whphhg has quit IRC
122 2017-02-15T09:49:04  *** MarcoFalke has joined #bitcoin-core-dev
123 2017-02-15T10:12:11  *** MarcoFalke has quit IRC
124 2017-02-15T10:14:08  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/4c69d683f22a...d8e8b06bd065
125 2017-02-15T10:14:09  <bitcoin-git> bitcoin/master a58370e Russell Yanofsky: Dedup nTimeFirstKey update logic...
126 2017-02-15T10:14:09  <bitcoin-git> bitcoin/master a80f98b Russell Yanofsky: Use importmulti timestamp when importing watch only keys...
127 2017-02-15T10:14:10  <bitcoin-git> bitcoin/master d8e8b06 Wladimir J. van der Laan: Merge #9108: Use importmulti timestamp when importing watch only keys (on top of #9682)...
128 2017-02-15T10:14:16  <bitcoin-git> [bitcoin] laanwj closed pull request #9108: Use importmulti timestamp when importing watch only keys (on top of #9682) (master...watchtime) https://github.com/bitcoin/bitcoin/pull/9108
129 2017-02-15T10:16:38  <Victorsueca> ^ about that, is the function to remove watch-only addresses from your wallet coming in the near future?
130 2017-02-15T10:35:44  *** chjj has joined #bitcoin-core-dev
131 2017-02-15T10:38:45  <bitcoin-git> [bitcoin] laanwj opened pull request #9764: wallet: Prevent "overrides a member function but is not marked 'override'" warnings (master...2017_02_wallet_inconsistent_missing_override) https://github.com/bitcoin/bitcoin/pull/9764
132 2017-02-15T10:46:56  *** chjj has quit IRC
133 2017-02-15T10:56:11  *** justanotheruser has quit IRC
134 2017-02-15T10:58:20  <wumpus> Victorsueca: depends on whether someone picks up https://github.com/bitcoin/bitcoin/pull/5525
135 2017-02-15T10:58:58  <wumpus> Victorsueca: it needs rebase and needs tests
136 2017-02-15T11:24:44  *** BashCo has joined #bitcoin-core-dev
137 2017-02-15T11:24:47  *** Anduck has quit IRC
138 2017-02-15T11:24:57  *** Anduck has joined #bitcoin-core-dev
139 2017-02-15T11:27:08  *** BashCo_ has quit IRC
140 2017-02-15T11:30:16  *** BashCo has quit IRC
141 2017-02-15T11:54:03  *** BashCo has joined #bitcoin-core-dev
142 2017-02-15T11:58:49  *** BashCo_ has joined #bitcoin-core-dev
143 2017-02-15T12:01:38  *** BashCo has quit IRC
144 2017-02-15T12:20:17  *** Kexkey has joined #bitcoin-core-dev
145 2017-02-15T12:35:55  *** chjj has joined #bitcoin-core-dev
146 2017-02-15T12:39:40  <BlueMatt> morcos: ahh, so you're saying people will import with dates that dont match block time, yea, ok, that sucks
147 2017-02-15T12:40:03  <BlueMatt> would be nice if we had been using some mtp-or-hours-back rule to generate the birthdays to begin with :/
148 2017-02-15T12:40:04  <BlueMatt> oh well
149 2017-02-15T12:52:07  *** BashCo has joined #bitcoin-core-dev
150 2017-02-15T12:54:12  *** BashCo_ has quit IRC
151 2017-02-15T12:55:52  *** BashCo_ has joined #bitcoin-core-dev
152 2017-02-15T12:56:09  <morcos> BlueMatt: ryanofsky suggested changing the way the wallet generates the key birthday to be MTP...  i couldn't immediately see why that would be a problem.., but regardless i think we need the buffer for now
153 2017-02-15T12:56:40  <BlueMatt> yes, well if users are going to get key birthdays from generated birthdays from old wallets then we're gonna need a buffer as long as they do that
154 2017-02-15T12:57:18  <wumpus> in retrospect we should have used birth block number instead of birthdate
155 2017-02-15T12:57:30  <BlueMatt> yes
156 2017-02-15T12:57:42  <BlueMatt> usability issues with that if you're not syned, but, yes
157 2017-02-15T12:57:49  <wumpus> the drawback is that then it's no longer possible to generate keys on hardware that has no block chain access
158 2017-02-15T12:58:02  <wumpus> well no big one in that case, it'd just make the birth block a bit earlier
159 2017-02-15T12:58:15  <jonasschnelli> but keys have timestamps as birthdays
160 2017-02-15T12:58:28  *** BashCo has quit IRC
161 2017-02-15T12:58:33  <wumpus> yes, it's no longer possible to do that, that's why I said in retrospect
162 2017-02-15T12:59:12  <wumpus> keeping a safety margin of 2 hours seems prudent to me
163 2017-02-15T12:59:23  <BlueMatt> indeed
164 2017-02-15T12:59:27  <jonasschnelli> Yes.
165 2017-02-15T12:59:48  <jonasschnelli> I also mentioned this in the initial importmulti PR IIRC
166 2017-02-15T13:00:33  *** BashCo has joined #bitcoin-core-dev
167 2017-02-15T13:00:47  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/7551#discussion_r80929574
168 2017-02-15T13:02:57  *** BashCo_ has quit IRC
169 2017-02-15T13:09:45  *** BashCo_ has joined #bitcoin-core-dev
170 2017-02-15T13:13:08  *** BashCo has quit IRC
171 2017-02-15T13:18:09  *** BashCo has joined #bitcoin-core-dev
172 2017-02-15T13:18:15  <bitcoin-git> [bitcoin] NicolasDorier closed pull request #8460: Parametrize buried soft fork in regtest and refactor (master...buriedsf) https://github.com/bitcoin/bitcoin/pull/8460
173 2017-02-15T13:21:23  *** BashCo_ has quit IRC
174 2017-02-15T13:23:56  <bitcoin-git> [bitcoin] sdaftuar opened pull request #9765: Harden against mistakes handling invalid blocks (master...fix-checkblock-call) https://github.com/bitcoin/bitcoin/pull/9765
175 2017-02-15T13:33:22  *** kadoban has joined #bitcoin-core-dev
176 2017-02-15T13:42:59  *** justanotheruser has joined #bitcoin-core-dev
177 2017-02-15T13:52:36  *** chjj has quit IRC
178 2017-02-15T14:01:38  *** justanotheruser has quit IRC
179 2017-02-15T14:07:10  *** lclc has quit IRC
180 2017-02-15T14:09:00  *** isle2983 has quit IRC
181 2017-02-15T14:09:28  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d8e8b06bd065...476cc47da084
182 2017-02-15T14:09:28  <bitcoin-git> bitcoin/master 4b6cccc Jonas Schnelli: Selectively suppress deprecation warnings
183 2017-02-15T14:09:29  <bitcoin-git> bitcoin/master 476cc47 Wladimir J. van der Laan: Merge #9758: Selectively suppress deprecation warnings...
184 2017-02-15T14:09:51  <bitcoin-git> [bitcoin] laanwj closed pull request #9758: Selectively suppress deprecation warnings (master...2017/02/deprac_warns) https://github.com/bitcoin/bitcoin/pull/9758
185 2017-02-15T14:10:58  *** goksinen has joined #bitcoin-core-dev
186 2017-02-15T14:11:13  *** isle2983 has joined #bitcoin-core-dev
187 2017-02-15T14:12:27  *** BashCo_ has joined #bitcoin-core-dev
188 2017-02-15T14:15:28  *** BashCo has quit IRC
189 2017-02-15T14:19:43  *** chjj has joined #bitcoin-core-dev
190 2017-02-15T14:26:37  *** laurentmt has joined #bitcoin-core-dev
191 2017-02-15T14:47:47  *** Giszmo has joined #bitcoin-core-dev
192 2017-02-15T14:48:38  *** eminogrande has joined #bitcoin-core-dev
193 2017-02-15T15:00:44  *** Kexkey has quit IRC
194 2017-02-15T15:02:49  *** jtimon has joined #bitcoin-core-dev
195 2017-02-15T15:05:12  *** eminogrande has quit IRC
196 2017-02-15T15:05:24  *** eminogrande has joined #bitcoin-core-dev
197 2017-02-15T15:06:15  <bitcoin-git> [bitcoin] jnewbery opened pull request #9766: Add --exclude option to rpc-tests.py (master...rpctestexclude) https://github.com/bitcoin/bitcoin/pull/9766
198 2017-02-15T15:10:17  *** lclc has joined #bitcoin-core-dev
199 2017-02-15T15:13:00  *** lejit has quit IRC
200 2017-02-15T15:21:51  *** emzy_ is now known as emzy
201 2017-02-15T15:21:57  *** emzy has joined #bitcoin-core-dev
202 2017-02-15T15:25:28  *** Guyver2 has joined #bitcoin-core-dev
203 2017-02-15T15:28:44  *** laurentmt1 has joined #bitcoin-core-dev
204 2017-02-15T15:29:38  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/476cc47da084...7a93af8340d9
205 2017-02-15T15:29:38  <bitcoin-git> bitcoin/master 9acf25c Russell Yanofsky: Return error when importmulti called with invalid address....
206 2017-02-15T15:29:39  <bitcoin-git> bitcoin/master 7a93af8 Wladimir J. van der Laan: Merge #9756: Return error when importmulti called with invalid address....
207 2017-02-15T15:30:00  <bitcoin-git> [bitcoin] laanwj closed pull request #9756: Return error when importmulti called with invalid address. (master...pr/multiaddr) https://github.com/bitcoin/bitcoin/pull/9756
208 2017-02-15T15:31:48  *** laurentmt has quit IRC
209 2017-02-15T15:31:48  *** laurentmt1 is now known as laurentmt
210 2017-02-15T15:40:12  *** Chris_Stewart_5 has joined #bitcoin-core-dev
211 2017-02-15T15:44:58  *** tan1k has joined #bitcoin-core-dev
212 2017-02-15T15:50:50  *** Chris_Stewart_5 has quit IRC
213 2017-02-15T15:51:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
214 2017-02-15T15:53:03  *** Guest74962 has joined #bitcoin-core-dev
215 2017-02-15T15:53:05  <Guest74962> hey
216 2017-02-15T15:53:19  *** Aaronvan_ has quit IRC
217 2017-02-15T15:55:27  *** Guest74962 has left #bitcoin-core-dev
218 2017-02-15T15:57:10  *** AaronvanW has joined #bitcoin-core-dev
219 2017-02-15T15:59:23  *** senior1 has joined #bitcoin-core-dev
220 2017-02-15T15:59:42  *** senior1 has joined #bitcoin-core-dev
221 2017-02-15T15:59:49  *** senior2 has joined #bitcoin-core-dev
222 2017-02-15T15:59:54  *** senior1 has quit IRC
223 2017-02-15T15:59:56  *** senior2 has quit IRC
224 2017-02-15T16:00:07  *** senior1 has joined #bitcoin-core-dev
225 2017-02-15T16:00:13  *** senior1 has left #bitcoin-core-dev
226 2017-02-15T16:00:32  *** senior1 has joined #bitcoin-core-dev
227 2017-02-15T16:01:36  *** lclc has quit IRC
228 2017-02-15T16:06:52  *** laurentmt1 has joined #bitcoin-core-dev
229 2017-02-15T16:08:00  *** laurentmt has quit IRC
230 2017-02-15T16:08:00  *** laurentmt1 is now known as laurentmt
231 2017-02-15T16:08:19  *** wasi_ has quit IRC
232 2017-02-15T16:10:07  *** senior1 has joined #bitcoin-core-dev
233 2017-02-15T16:17:29  <morcos> wumpus: can we powwow on what we want to do about importmulti and pruned nodes?
234 2017-02-15T16:17:55  <morcos> you mentioned its the same issues as importwallet, but that is just disabled for pruned nodes, importmulti isn't
235 2017-02-15T16:18:11  *** senior1 has left #bitcoin-core-dev
236 2017-02-15T16:18:26  *** senior1 has joined #bitcoin-core-dev
237 2017-02-15T16:18:32  <wumpus> importmulti should ideally work when using timestamps more recent than what is pruned
238 2017-02-15T16:18:46  *** wasi_ has joined #bitcoin-core-dev
239 2017-02-15T16:18:51  <morcos> i think right now it'll mostly silently fail if you importmulti with a key timestamp before your earliest on disk block...  (looks to me like ReadBlockFromDisk will fail and error to debug log, but rescan should keep chugging along until it finds blocks)
240 2017-02-15T16:19:00  <morcos> right, agreed.
241 2017-02-15T16:19:08  <wumpus> if that is broken then I'd say disable it for 0.14 and worry about it later
242 2017-02-15T16:19:09  <morcos> but important enough to fix that for 0.14?
243 2017-02-15T16:19:16  <morcos> ah ok, that was the question
244 2017-02-15T16:19:29  <morcos> so just disable importmulti for pruned nodes altogether for 0.14, then fix properly later
245 2017-02-15T16:19:42  *** senior1 has quit IRC
246 2017-02-15T16:19:46  <morcos> that seems reasonable to me..  gmaxwell or sipa any serious objections?
247 2017-02-15T16:20:07  <wumpus> my mention about the problem being the same as for importwallet was about the 2-hour grace period, we had that for importwallet and I think it should be the same for importmulti
248 2017-02-15T16:21:14  <wumpus> no matter how that interacts with nodes that have just pruned those two hours, it should just be documented that the grace period is there and blocks should exist for its duration until now
249 2017-02-15T16:21:38  <wumpus> but anyhow if importmulti doesn't even throw an error when there's not enough block data then disabling it would be better
250 2017-02-15T16:21:48  <morcos> right..  it's a separate edge case to be solved later if your last non-pruned block falls in the grace period.
251 2017-02-15T16:21:49  <wumpus> I'd assume the ReadBlockFromDisk error would not be ignored
252 2017-02-15T16:22:21  <morcos> just from a quick read my guess is it does not error, but i have not tried anything...
253 2017-02-15T16:22:32  <morcos> yeah i agree thats a problem, b/c you could think you have all the funds and not
254 2017-02-15T16:24:32  *** thestrin1puller is now known as thestringpuller
255 2017-02-15T16:24:45  *** thestringpuller has joined #bitcoin-core-dev
256 2017-02-15T16:25:02  <wumpus> yes, silently missing blocks is a very bad
257 2017-02-15T16:28:14  <wumpus> important disctinction: importprivkey is only disabled in pruning mode when a rescan is requested
258 2017-02-15T16:28:46  <wumpus> probably should be the same for importmulti then, it should bark when any keys are not 'now', otherwise it'd lose functionality compared to importprivkey
259 2017-02-15T16:34:19  *** arubi has quit IRC
260 2017-02-15T16:40:03  *** arubi has joined #bitcoin-core-dev
261 2017-02-15T16:46:08  *** abpa has joined #bitcoin-core-dev
262 2017-02-15T16:52:33  <bitcoin-git> [bitcoin] jaladin1222 opened pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767
263 2017-02-15T16:58:41  *** lclc has joined #bitcoin-core-dev
264 2017-02-15T17:03:37  *** laurentmt1 has joined #bitcoin-core-dev
265 2017-02-15T17:05:10  *** laurentmt has quit IRC
266 2017-02-15T17:05:11  *** laurentmt1 is now known as laurentmt
267 2017-02-15T17:31:37  <bitcoin-git> [bitcoin] sipa closed pull request #9767: 0.9 (master...0.9) https://github.com/bitcoin/bitcoin/pull/9767
268 2017-02-15T17:48:26  <bitcoin-git> [bitcoin] jnewbery opened pull request #9768: [qa] [WIP] Add logging to test_framework.py (master...rpctestlogging) https://github.com/bitcoin/bitcoin/pull/9768
269 2017-02-15T17:50:34  *** laurentmt has quit IRC
270 2017-02-15T17:57:05  *** Chris_Stewart_5 has quit IRC
271 2017-02-15T17:57:32  *** Arvidt_ has left #bitcoin-core-dev
272 2017-02-15T17:58:58  <gmaxwell> wumpus: it should only be disabled where the rescan would scan pruned blocks... that is really the only utility in having the timestamps at all.
273 2017-02-15T17:59:33  *** Chris_Stewart_5 has joined #bitcoin-core-dev
274 2017-02-15T18:00:18  *** BashCo_ has quit IRC
275 2017-02-15T18:00:55  *** BashCo has joined #bitcoin-core-dev
276 2017-02-15T18:05:18  *** BashCo has quit IRC
277 2017-02-15T18:19:05  *** BashCo has joined #bitcoin-core-dev
278 2017-02-15T18:24:40  *** Kexkey has joined #bitcoin-core-dev
279 2017-02-15T18:31:07  *** eminogrande has quit IRC
280 2017-02-15T18:52:54  *** Chris_Stewart_5 has quit IRC
281 2017-02-15T18:56:44  <ryanofsky> gmaxwell, are you talking about a preemptive check? would there be any problem with importing the keys then throwing an exception saying import succeeded, but some blocks were not present and some transactions might be missing?
282 2017-02-15T18:58:29  <ryanofsky> also i don't understand what's wrong with the suggestion from wumpus to just forbid rescan=True on pruned nodes
283 2017-02-15T18:59:15  <gmaxwell> Because it guts the utility of pruning, when you lose major functionality outright just because you were so foolish as to not waste 100GB of diskspace.
284 2017-02-15T18:59:38  <gmaxwell> Esp because rescans of the whole chain take hours, so it's not like they were even all that usable (except in emergencies) in any case.
285 2017-02-15T18:59:56  <gmaxwell> As far as after the fact, I think that would be way less bad than denying it completely.
286 2017-02-15T19:00:39  <gmaxwell> it would be best to deny it first but the way importmulti is constructed makes that harder to implement.
287 2017-02-15T19:00:58  <ryanofsky> oh ok, i got that part, i didn't understand what you were saying about the defeating the "utility of timestamps"
288 2017-02-15T19:03:27  *** goksinen has quit IRC
289 2017-02-15T19:06:44  *** goksinen has joined #bitcoin-core-dev
290 2017-02-15T19:10:29  <gmaxwell> Bascially the only good timestamps do is that they let you import a key without reading all the blocks. (scanning extra blocks is something no one would care about.)   If pruning is prevented then you do save some rescan time, but still take on the 100GB of cost, -- this is a major barrier for people doing their own payment processing on VPSes.
291 2017-02-15T19:11:32  <gmaxwell> The workflow there is that they have a payment processing front end which generates keys using BIP32 public derrivation, and then imports the addresses. Because of contingencies around multiple nodes and restarts they may need to rescan a bit.  The imported keys are used to watch for payments so they can display status to the user.
292 2017-02-15T19:11:49  <gmaxwell> The actual private keys are not put onto the VPS systems, for obvious reasons. :)
293 2017-02-15T19:13:13  <gmaxwell> The alternative to this setup is to use a third party payment processor. But this has the downside of introducing trust where it could be avoided, and all the major processors are known to capricious shut down merchants or block customers on the basis of flimsy risk (that they piss off banks or regulators) analysis.
294 2017-02-15T19:13:34  <gmaxwell> (and, of course, the systemic risk created by those processors holding large amounts of customer funds).
295 2017-02-15T19:16:29  *** AaronvanW has quit IRC
296 2017-02-15T19:17:33  <bitcoin-git> [bitcoin] jnewbery opened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
297 2017-02-15T19:17:43  <bitcoin-git> [bitcoin] jnewbery closed pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
298 2017-02-15T19:18:06  <ryanofsky> ok this use both requires import timestamps and pruning, makes sense
299 2017-02-15T19:18:16  *** AaronvanW has joined #bitcoin-core-dev
300 2017-02-15T19:18:16  *** AaronvanW has joined #bitcoin-core-dev
301 2017-02-15T19:19:56  <gmaxwell> the other somewhat related bug is that even when you don't import a private key, it requires that the wallet be unlocked.
302 2017-02-15T19:20:13  <gmaxwell> the same design make it difficult to reject the rpc based on the arguments.
303 2017-02-15T19:21:12  <bitcoin-git> [bitcoin] jnewbery reopened pull request #9770: Allow maxsigcachesize to be zero (master...sigcachemaxsize) https://github.com/bitcoin/bitcoin/pull/9770
304 2017-02-15T19:38:49  *** goksinen has quit IRC
305 2017-02-15T19:40:04  *** goksinen has joined #bitcoin-core-dev
306 2017-02-15T19:49:45  *** wasi_ is now known as wasi
307 2017-02-15T20:46:08  <cfields> gmaxwell: I'm going to add a little blurb about the net speedup in the changelog. I think i remember you mentioning you'd prefer to see some sort of "validation improvements" or "ibd speedups" section, which may be a more useful way to describe it?
308 2017-02-15T21:14:41  <morcos> Should we be making it so POTENTIAL DEADLOCK DETECTED's are elimintated or is it impossible to eliminate them all
309 2017-02-15T21:15:21  <morcos> I was just trackign down what caused one and I think its not an issue, but is there somehwere I should comment what caused it, or should we actually change the code to not lock incorrectly
310 2017-02-15T21:15:33  <morcos> i'm just not very familar with DEBUG_LOCKORDER
311 2017-02-15T21:16:01  <sipa> i think we can replace it with tsan soon
312 2017-02-15T21:16:07  <sipa> and/or helgrind
313 2017-02-15T21:16:38  <morcos> This particular case is the loading of a wallet can call Mark Conflicted, which causes cs_wallet then cs_main which is the opposite order it happens elsewhere
314 2017-02-15T21:17:11  <sipa> what is the other case?
315 2017-02-15T21:17:45  <morcos> we have tons of LOCK2(cs_main, cs_wallet)'s
316 2017-02-15T21:18:14  <morcos> i was assuming this isn't a problem b/c the wallet loading is done before other threads are spun up, but maybe thats actually not right?
317 2017-02-15T21:18:38  <sipa> well the only question is whether those 2 orders can occur simultaneously
318 2017-02-15T21:19:27  <morcos> yes thats what i mean, can anything else happen while the wallet is still loading?
319 2017-02-15T21:21:16  <morcos> dpesm
320 2017-02-15T21:21:19  <morcos> oops
321 2017-02-15T21:21:40  <morcos> doesn't look like it i suppose...
322 2017-02-15T21:24:23  <sipa> regardless, i think we should have consistent lock orders everywhere
323 2017-02-15T21:24:49  <sipa> i'd say all those LOCK2(cs_main, cs_wallet)s can be swapped
324 2017-02-15T21:25:03  <morcos> yikes!!
325 2017-02-15T21:25:10  <sipa> wallet should call main, not the other way around IMHO
326 2017-02-15T21:25:13  <morcos> i bet several of them are reentrant
327 2017-02-15T21:25:20  <morcos> main is already held before we get there
328 2017-02-15T21:25:38  <sipa> well, that's the issue then
329 2017-02-15T21:25:48  <sipa> main shouldn't be held while calling wallet code
330 2017-02-15T21:26:21  <morcos> :)  we're working on it!   see #9725
331 2017-02-15T21:26:24  <gribble> https://github.com/bitcoin/bitcoin/issues/9725 | CValidationInterface Cleanups by TheBlueMatt · Pull Request #9725 · bitcoin/bitcoin · GitHub
332 2017-02-15T21:27:08  <sipa> great
333 2017-02-15T21:29:42  <morcos> hmm
334 2017-02-15T21:29:59  <morcos> it assert fails when you have a potential deadlock?
335 2017-02-15T21:30:33  <morcos> so this must have been somehow recently introduced?
336 2017-02-15T21:41:27  <cfields> mm, I'm going to go ahead and PR some mutex cleanups I've been waiting on for a while. I'm going to start moving the net code towards non-recursive locks. Would you guys prefer a generic LOCK(cs) that takes any mutex, or NON_RECURSIVE_LOCK(cs) as a form of self-documentation?
337 2017-02-15T22:00:10  <morcos> so...  what should i do about this stupid deadlock warnign for now?  seems like it might annoy someone else..  but only obvious fix i could see would be holding cs_main for all of loadwallet.  its not immediately apparent to me whether that is bad?
338 2017-02-15T22:01:31  <morcos> eh.. i'll move on and make an issue..  if you have a clean wallet, i think the problem goes away
339 2017-02-15T22:08:09  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9771: Add missing cs_wallet lock that triggers new lock held assertion (master...pr/loadlock) https://github.com/bitcoin/bitcoin/pull/9771
340 2017-02-15T22:19:25  <bitcoin-git> [bitcoin] ryanofsky opened pull request #9773: WIP: Return errors from importmulti if complete rescans are not successful (master...pr/multicheck) https://github.com/bitcoin/bitcoin/pull/9773
341 2017-02-15T22:21:41  *** chjj_ has joined #bitcoin-core-dev
342 2017-02-15T22:24:53  *** chjj has quit IRC
343 2017-02-15T22:31:06  *** schmidty has joined #bitcoin-core-dev
344 2017-02-15T22:45:38  <bitcoin-git> [bitcoin] pstratem closed pull request #9762: Add txdetails parameter to getblock. (master...2017-02-14-getblock-includetxs) https://github.com/bitcoin/bitcoin/pull/9762
345 2017-02-15T23:14:45  *** Guyver2 has quit IRC
346 2017-02-15T23:17:07  *** jnewbery has quit IRC
347 2017-02-15T23:19:22  *** chjj_ is now known as chjj
348 2017-02-15T23:26:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev