1 2017-02-20T00:01:10  *** waxwing has joined #bitcoin-core-dev
  2 2017-02-20T00:09:55  *** afk11 has quit IRC
  3 2017-02-20T00:10:07  *** afk11 has joined #bitcoin-core-dev
  4 2017-02-20T00:38:09  <instagibbs> gmaxwell, commits so nice they're credited twice
  5 2017-02-20T00:41:12  *** chris200_ has quit IRC
  6 2017-02-20T00:44:10  *** chjj has joined #bitcoin-core-dev
  7 2017-02-20T00:46:30  *** goksinen_ has joined #bitcoin-core-dev
  8 2017-02-20T00:47:57  *** moli_ has quit IRC
  9 2017-02-20T00:55:14  *** chris2000 has joined #bitcoin-core-dev
 10 2017-02-20T00:55:25  *** IRCFrEAK has joined #bitcoin-core-dev
 11 2017-02-20T00:55:26  *** IRCFrEAK has left #bitcoin-core-dev
 12 2017-02-20T01:01:05  *** moli_ has joined #bitcoin-core-dev
 13 2017-02-20T01:24:28  *** city22 has joined #bitcoin-core-dev
 14 2017-02-20T01:38:55  <bitcoin-git> [bitcoin] droark opened pull request #9806: txoutsbyaddress index (take 3) (master...gettxoutsbyaddress) https://github.com/bitcoin/bitcoin/pull/9806
 15 2017-02-20T01:47:52  <bitcoin-git> [bitcoin] fanquake opened pull request #9807: RPC doc fix-ups. (master...rpc-test-trivial-fixups) https://github.com/bitcoin/bitcoin/pull/9807
 16 2017-02-20T01:58:27  *** AaronvanW has quit IRC
 17 2017-02-20T02:06:33  *** Giszmo has quit IRC
 18 2017-02-20T02:14:00  *** Ylbam has quit IRC
 19 2017-02-20T02:18:02  *** d9b4bef9 has quit IRC
 20 2017-02-20T02:21:07  *** d9b4bef9 has joined #bitcoin-core-dev
 21 2017-02-20T02:28:18  *** chjj has quit IRC
 22 2017-02-20T02:28:40  *** chjj_ has joined #bitcoin-core-dev
 23 2017-02-20T02:28:59  *** chjj has joined #bitcoin-core-dev
 24 2017-02-20T02:59:56  *** chjj has quit IRC
 25 2017-02-20T03:16:24  *** dgenr8 has quit IRC
 26 2017-02-20T03:16:52  *** dgenr8 has joined #bitcoin-core-dev
 27 2017-02-20T03:34:57  *** jtimon has quit IRC
 28 2017-02-20T03:42:28  *** chjj has joined #bitcoin-core-dev
 29 2017-02-20T03:44:06  *** Victor_sueca has joined #bitcoin-core-dev
 30 2017-02-20T03:46:48  *** Victorsueca has quit IRC
 31 2017-02-20T03:48:56  *** chjj has quit IRC
 32 2017-02-20T03:50:49  *** chjj has joined #bitcoin-core-dev
 33 2017-02-20T03:58:32  *** goksinen_ has quit IRC
 34 2017-02-20T04:00:07  *** dermoth has quit IRC
 35 2017-02-20T04:00:57  *** dermoth has joined #bitcoin-core-dev
 36 2017-02-20T04:01:54  *** madgoat has joined #bitcoin-core-dev
 37 2017-02-20T04:01:54  *** madgoat has left #bitcoin-core-dev
 38 2017-02-20T04:19:11  *** kadoban has quit IRC
 39 2017-02-20T04:19:29  <gmaxwell> https://www.reddit.com/r/Bitcoin/comments/5uy4h6/bitcoin_core_0140_release_candidate_1_available/ddyj3sx/  report that the transparent overlay isn't transparent.  (thinking about it I have no idea if it was transparent for me...)
 40 2017-02-20T04:19:52  <achow101> I'm doing a fix for unifying the boolean verbose arguments with the RPCs. should the default be a boolean, or a verbosity number?
 41 2017-02-20T04:19:59  <achow101> gmaxwell: it's supposed to be transparent?
 42 2017-02-20T04:23:01  <sipa> it's modal, not transparent?
 43 2017-02-20T04:24:01  <sipa> oh, release notes say semi-transparent
 44 2017-02-20T04:25:17  <achow101> the pr for it, #8371 says its supposed to be semi-transparent. but that screenshot does not look very semi-transparent
 45 2017-02-20T04:25:19  <gribble> https://github.com/bitcoin/bitcoin/issues/8371 | [Qt] Add out-of-sync modal info layer by jonasschnelli · Pull Request #8371 · bitcoin/bitcoin · GitHub
 46 2017-02-20T04:26:33  <sipa> maybe the transparent part is the background, where you can see the actual tab?
 47 2017-02-20T04:27:45  <achow101> it looks like you have to look really close. then you can see the background
 48 2017-02-20T04:27:51  <achow101> zoom in. a lot
 49 2017-02-20T04:29:44  <gmaxwell> I'm just a messager!
 50 2017-02-20T04:50:31  *** Guest80933 has joined #bitcoin-core-dev
 51 2017-02-20T04:51:35  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 52 2017-02-20T04:54:35  *** chris200_ has joined #bitcoin-core-dev
 53 2017-02-20T04:56:14  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 54 2017-02-20T04:56:15  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 55 2017-02-20T04:56:15  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 56 2017-02-20T04:56:15  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 57 2017-02-20T04:56:15  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 58 2017-02-20T04:56:16  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 59 2017-02-20T04:56:16  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 60 2017-02-20T04:56:17  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 61 2017-02-20T04:56:17  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 62 2017-02-20T04:56:17  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 63 2017-02-20T04:56:18  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 64 2017-02-20T04:56:18  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 65 2017-02-20T04:56:19  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 66 2017-02-20T04:56:19  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 67 2017-02-20T04:56:30  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 68 2017-02-20T04:56:31  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 69 2017-02-20T04:56:31  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 70 2017-02-20T04:56:32  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 71 2017-02-20T04:56:32  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 72 2017-02-20T04:56:33  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 73 2017-02-20T04:56:33  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 74 2017-02-20T04:56:33  <Guest80933>  Sirs How can I start with signature campaign. I am just a newbie in bitcointalk.org
 75 2017-02-20T04:56:34  *** Guest80933 has quit IRC
 76 2017-02-20T04:57:18  *** chris2000 has quit IRC
 77 2017-02-20T05:01:29  *** chjj has quit IRC
 78 2017-02-20T05:01:33  *** city22 has quit IRC
 79 2017-02-20T05:01:43  *** chjj has joined #bitcoin-core-dev
 80 2017-02-20T05:04:41  <bitcoin-git> [bitcoin] GCarneiroA opened pull request #9808: Master (master...master) https://github.com/bitcoin/bitcoin/pull/9808
 81 2017-02-20T05:14:48  *** chjj has quit IRC
 82 2017-02-20T05:19:34  *** owowo has quit IRC
 83 2017-02-20T05:24:06  *** owowo has joined #bitcoin-core-dev
 84 2017-02-20T05:36:58  *** davec has quit IRC
 85 2017-02-20T05:46:12  *** chjj has joined #bitcoin-core-dev
 86 2017-02-20T05:46:41  *** cannon-c has joined #bitcoin-core-dev
 87 2017-02-20T06:07:08  *** arowser has quit IRC
 88 2017-02-20T06:07:24  *** arowser has joined #bitcoin-core-dev
 89 2017-02-20T06:14:27  *** davec has joined #bitcoin-core-dev
 90 2017-02-20T06:17:32  *** paveljanik has quit IRC
 91 2017-02-20T06:22:02  *** d9b4bef9 has quit IRC
 92 2017-02-20T06:22:25  *** justan0theruser is now known as OfficialLeibniz
 93 2017-02-20T06:23:17  *** d9b4bef9 has joined #bitcoin-core-dev
 94 2017-02-20T06:35:32  *** To7 has quit IRC
 95 2017-02-20T06:41:14  *** chjj has quit IRC
 96 2017-02-20T06:41:34  *** chjj has joined #bitcoin-core-dev
 97 2017-02-20T07:09:28  *** lclc has joined #bitcoin-core-dev
 98 2017-02-20T07:25:02  <wumpus> gmaxwell: I like the idea of always adding a warning to getinfo's warning field though. We could introduce that in a minor 0.14 release
 99 2017-02-20T07:29:01  *** Ylbam has joined #bitcoin-core-dev
100 2017-02-20T07:35:09  <jonasschnelli> Has there been talk to default enable -walletrbf=1 in 0.15? Or should the direction be that one can set the rbf flag per send*?
101 2017-02-20T07:40:30  *** BashCo has quit IRC
102 2017-02-20T07:52:52  *** chjj has quit IRC
103 2017-02-20T07:53:59  *** chjj has joined #bitcoin-core-dev
104 2017-02-20T07:54:53  <wumpus> jonasschnelli: not sure about that. We'd have be sure there are no significant wallets or companies that have problems accepting RBF transactions before making it default
105 2017-02-20T08:01:44  *** BashCo has joined #bitcoin-core-dev
106 2017-02-20T08:05:06  *** BashCo_ has joined #bitcoin-core-dev
107 2017-02-20T08:08:24  *** BashCo has quit IRC
108 2017-02-20T08:14:16  <cannon-c> Default RBF would make fee increase for faster processing easier for the non-tech savvy. I see lots of
109 2017-02-20T08:14:57  <cannon-c> questions referring how to get transactions unstuck, most wallets that are not core, are difficult for non-technical to resend transaction.
110 2017-02-20T08:16:00  <cannon-c> But I believe should notify users that RBF is set, with easily accessible ability to uncheck. Just my opinion
111 2017-02-20T08:17:06  *** paveljanik has joined #bitcoin-core-dev
112 2017-02-20T08:17:09  *** paveljanik has joined #bitcoin-core-dev
113 2017-02-20T08:18:42  <cannon-c> Wouldn't RBF fee increase in lieu of sending new transaction that is stuck, prevent transaction ID from changing? If so I see how RBF would be great advantage
114 2017-02-20T08:23:14  *** pavel_ has joined #bitcoin-core-dev
115 2017-02-20T08:24:02  *** chjj has quit IRC
116 2017-02-20T08:24:24  *** chjj has joined #bitcoin-core-dev
117 2017-02-20T08:24:40  *** paveljanik has quit IRC
118 2017-02-20T08:25:05  *** [Author] has quit IRC
119 2017-02-20T08:30:29  <gmaxwell> wumpus: fwiw, I believe several other wallets are producing OO rbf (electrum and green address)
120 2017-02-20T08:30:59  <gmaxwell> wumpus: also, you can always bump your way out of flagging, which should reduce the issue.
121 2017-02-20T08:31:20  <gmaxwell> jonasschnelli: I think we should hear feedback for how things go for bumpfee users in 0.14.x
122 2017-02-20T08:31:35  <jonasschnelli> I think OO rbf should be the default and optionally, if you want to pay a 0-conf merchant, you may want to switch it of.
123 2017-02-20T08:31:49  <jonasschnelli> *off
124 2017-02-20T08:32:11  <gmaxwell> jonasschnelli: I think bumping it off is somewhat superior to switching it off, unless you're really sure you want it off.
125 2017-02-20T08:32:43  <gmaxwell> rationale: even if the rx side will ignore the unconfirmed tx with it off, it might just confirm right away.
126 2017-02-20T08:39:22  *** juscamarena has joined #bitcoin-core-dev
127 2017-02-20T08:39:27  *** juscamarena_ has joined #bitcoin-core-dev
128 2017-02-20T08:55:10  *** paveljanik has joined #bitcoin-core-dev
129 2017-02-20T08:58:32  <wumpus> gmaxwell: okay that would be a good argument to enable it by default on master now, at least
130 2017-02-20T08:58:38  <jonasschnelli> 0.14.0rc1 sync against random peers
131 2017-02-20T08:58:39  <jonasschnelli> 2017-02-19 20:25:48 UpdateTip: new best=00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048 height=1 version=0x00000001 log2_work=33.000022 tx=2 date='2009-01-09 02:54:25' progress=0.000000 cache=0.0MiB(1tx)
132 2017-02-20T08:58:44  <jonasschnelli> 2017-02-19 23:06:26 UpdateTip: new best=000000000000000002204d1e9885416bfef39a2259a48a3eb5d36b6e8e21fad7 height=453816 version=0x20000002 log2_work=86.006491 tx=197951144 date='2017-02-19 23:00:41' progress=0.999994 cache=4096.3MiB(7229926tx) warning='2 of last 100 blocks have unexpected version'
133 2017-02-20T08:59:22  <wumpus> is it syncing or stuck?
134 2017-02-20T08:59:29  <jonasschnelli> No.. it's fast. :)
135 2017-02-20T08:59:45  <gmaxwell> 453816 is currentish.
136 2017-02-20T08:59:48  <wumpus> ooh! great.I thought you were worried about the version warning
137 2017-02-20T08:59:57  <jonasschnelli> 453816  was at 2017-02-19 23:06:26
138 2017-02-20T09:00:01  <gmaxwell> that is with increased dbcache, obviously.
139 2017-02-20T09:00:10  <jonasschnelli> 7GB cache. yes.
140 2017-02-20T09:00:32  <wumpus> oh only 7GB cache :-)
141 2017-02-20T09:00:34  <gmaxwell> a little cheating there because it has never flushed at all. :P
142 2017-02-20T09:00:45  <jonasschnelli> Almost same sync-times then we has with 0.13.0 but more blocks. :)
143 2017-02-20T09:01:01  <wumpus> yes seems the bottleneck now is really i/o for the utxo database
144 2017-02-20T09:01:19  <gmaxwell> well, sipa has code that makes it ~33% faster.
145 2017-02-20T09:01:20  <sipa> last week gmaxwell and i tried to sync a 0.7.2 node from scratch, with -connect to a fast new node
146 2017-02-20T09:01:21  <jonasschnelli> flush takes only a couple of seconds on that machine.. so neglectable
147 2017-02-20T09:01:46  <gmaxwell> jonasschnelli: flush of the utxo cache, with 4gb in is not going to take a couple seconds.
148 2017-02-20T09:01:55  <gmaxwell> try a minute.
149 2017-02-20T09:02:01  <wumpus> but yes with database in RAM or on a SSD it's surprisingly fast
150 2017-02-20T09:02:07  <jonasschnelli> I'll measure my shutdown now...
151 2017-02-20T09:02:20  <gmaxwell> also, part of the time is hidden in the next start up.
152 2017-02-20T09:02:34  <wumpus> too bad that that doesn't help my odroid64 :-)
153 2017-02-20T09:02:50  <sipa> jonasschnelli: flushing means that every subsequent spend from an out-of-cache tx afterwards needs a read from disk and deserialization
154 2017-02-20T09:02:50  <jonasschnelli> Maybe 15s
155 2017-02-20T09:03:02  <jonasschnelli> I'm using a 1GB/s SSD
156 2017-02-20T09:03:16  <sipa> so the slowdown is partially in later entries
157 2017-02-20T09:03:26  <wumpus> yes it's not the flushing itself, as in writing, that poses a bottleneck with leveldb. leveldb is very fast with writing. It's that the flush empties the entire db
158 2017-02-20T09:03:54  <wumpus> +cache
159 2017-02-20T09:04:03  <jonasschnelli> https://0bin.net/paste/RdqE7Qkd8uMcew8H#o5kz3c7fBGijX2ZXzJ4d8fAozAN0h5IAQvaD8gwaeRz
160 2017-02-20T09:04:09  <sipa> half of the time is constructing the batch for leveldb to write
161 2017-02-20T09:04:39  <wumpus> <gmaxwell> well, sipa has code that makes it ~33% faster.<- that's good news! how?
162 2017-02-20T09:04:49  <sipa> wumpus: per txout caching
163 2017-02-20T09:05:11  <wumpus> sipa: ah nice
164 2017-02-20T09:05:12  <gmaxwell> It unfortunately increases the size of the utxo database on disk somewhat.
165 2017-02-20T09:05:20  <sipa> and undo data
166 2017-02-20T09:05:35  <wumpus> by how much?
167 2017-02-20T09:05:43  <gmaxwell> Less than double. I think it's a clear win.
168 2017-02-20T09:06:13  <gmaxwell> Basically the keys get repeated.. leveldb has some compaction of that, but its not perfect.
169 2017-02-20T09:06:20  <wumpus> could anything be gained by compressing undo data?
170 2017-02-20T09:06:23  <gmaxwell> and the undo data is only slightly larger.
171 2017-02-20T09:06:37  <wumpus> as you say "repeated", compression seems obvs answer
172 2017-02-20T09:06:39  <sipa> undo data is already compressed pretty well
173 2017-02-20T09:06:43  <wumpus> ok
174 2017-02-20T09:07:03  <gmaxwell> well we can reduce the size of all blocks by ~27% using different stuff, I don't think we've looked to shrink undo data much more than it alread is.
175 2017-02-20T09:07:04  <sipa> but the size increase on the chainstate should be investigated more carefully
176 2017-02-20T09:07:28  <sipa> if it increases significantly, it may not be a win for systems with slow disks
177 2017-02-20T09:07:30  <wumpus> true, undo data is deleted together with the blocks on pruning
178 2017-02-20T09:07:38  <wumpus> chainstate growth is much more worrying
179 2017-02-20T09:07:46  <sipa> yes :(
180 2017-02-20T09:07:52  <gmaxwell> also, I'm sure now we have enough improvements that the sse2-sha256 will be more of a speedup, I think jonasschnelli benchmarked 5% in IBD time, and that was before assumevalid.
181 2017-02-20T09:08:08  <gmaxwell> wumpus: well the growth, whatever it is, should be roughly a constant factor.
182 2017-02-20T09:08:11  <jonasschnelli> Yes. IBD is not much of a difference...
183 2017-02-20T09:08:20  <jonasschnelli> with wumpuses sse2
184 2017-02-20T09:08:35  <wumpus> 5% is pretty nice
185 2017-02-20T09:08:40  <jonasschnelli> Yes. Sure.
186 2017-02-20T09:08:42  <gmaxwell> jonasschnelli: I think 5% isn't bad. y'all expect too much from optimizations. And on top of assume valid and that 33% gain that 5% will be much larger.
187 2017-02-20T09:08:46  <sipa> oh, so... we were unable to get 0.7.2 to sync past some block in 2015
188 2017-02-20T09:09:02  <jonasschnelli> But I think it's great for nodes running in sync.
189 2017-02-20T09:09:04  <wumpus> compound growth, heh
190 2017-02-20T09:09:08  <gmaxwell> even with massively increased locks.
191 2017-02-20T09:09:20  <wumpus> all those 5% and 3% stacked on top of each other do count
192 2017-02-20T09:09:21  <gmaxwell> In libsecp256k1 we celebrate 1% improvements.
193 2017-02-20T09:10:24  <jonasschnelli> We often focus on IBD improvments,... they are great. Boiling hot water quick is great,... but keeping it warm with low amount of energy also counts. :)
194 2017-02-20T09:11:01  <sipa> well IBD time is a biased proxy for block validation time
195 2017-02-20T09:11:09  <sipa> and it keeps users happy
196 2017-02-20T09:11:47  <sipa> many of the improvements to IBD time do matter for single node validation... except assumevalid, though we get sigcache in return
197 2017-02-20T09:12:15  *** moli_ has quit IRC
198 2017-02-20T09:12:47  <jonasschnelli> Yes. That's true. But sse2 5% in IBD may results in 10-15% during in-sync state because of lesser IO. My Pine64 (RPi clone) would really love that.
199 2017-02-20T09:13:17  <jonasschnelli> (and it actually has SHA256 NI)
200 2017-02-20T09:13:45  *** moli_ has joined #bitcoin-core-dev
201 2017-02-20T09:17:15  <bitcoin-git> [bitcoin] fanquake closed pull request #9808: Master (master...master) https://github.com/bitcoin/bitcoin/pull/9808
202 2017-02-20T09:18:47  <jonasschnelli> wumpus: since we have 0.14 now branched off, we could try to make a little step towards refactoring out BDB. Maybe check #9143?
203 2017-02-20T09:18:50  <gribble> https://github.com/bitcoin/bitcoin/issues/9143 | Refactor ZapWalletTxes to avoid layer violations by jonasschnelli · Pull Request #9143 · bitcoin/bitcoin · GitHub
204 2017-02-20T09:21:22  *** cbits has joined #bitcoin-core-dev
205 2017-02-20T09:23:39  *** harrymm has quit IRC
206 2017-02-20T09:25:07  <cbits> @jonasschnelli I'm in the camp that rbf should either be set by default with a checkbox to unset it per transaction, or entirely off in the settings. Or the other option, of having it not set by default, but you get the behavior I first described if you set rbf on.
207 2017-02-20T09:26:36  <cbits> Electrum currently makes you set rbf on for every transaction even after making the option visible in the settings. Which imo is annoying. Should be default.
208 2017-02-20T09:27:01  <jonasschnelli> cbits: I think the GUI can handle RBF pretty well. I see more potential in improving the RPC API.
209 2017-02-20T09:27:19  <jonasschnelli> The gui will very likely have https://github.com/bitcoin/bitcoin/pull/9697 in 0.15.
210 2017-02-20T09:27:32  <jonasschnelli> And a per-tx-opt-in checkbox
211 2017-02-20T09:27:51  <jonasschnelli> And, the GUI offers user verification before sending (to inform better about the RBF state).
212 2017-02-20T09:28:18  *** chjj has quit IRC
213 2017-02-20T09:30:43  <cbits> jonasschnelli: nice. Didn't see that pull. I'll check it out.
214 2017-02-20T09:33:40  *** BashCo_ has quit IRC
215 2017-02-20T09:34:00  *** BashCo has joined #bitcoin-core-dev
216 2017-02-20T09:38:50  *** laurentmt has joined #bitcoin-core-dev
217 2017-02-20T09:39:37  *** laurentmt has quit IRC
218 2017-02-20T09:40:29  <jonasschnelli> I'm setting up a new gitian machine... but facing an error with the vm sudoers config:
219 2017-02-20T09:40:29  <jonasschnelli> https://0bin.net/paste/V1mMAN3IRN2c1lSE#Xuff715O4aijc+o9h04ohmF145+fRrXqojsb11jDxmy
220 2017-02-20T09:40:35  <jonasschnelli> Any idea how to fix that?
221 2017-02-20T09:41:01  <jonasschnelli> It seems that the prompt breaks the make-base-vm process
222 2017-02-20T09:46:25  *** harrymm has joined #bitcoin-core-dev
223 2017-02-20T09:46:35  <wumpus> strange
224 2017-02-20T09:47:43  <wumpus> is this a sudo issue in the VM or the host machine? confusing
225 2017-02-20T09:47:55  <wumpus> looks something *on* the vm, so changing sudoers won't help you either
226 2017-02-20T09:50:29  <jonasschnelli> Yes. Seems to be on the VM.
227 2017-02-20T09:50:52  <jonasschnelli> I'm using make-base-vm on a non-VM host. Using -KVM
228 2017-02-20T09:50:54  <wumpus> I created a new base image twice yesterday - no issues
229 2017-02-20T09:51:58  <wumpus> this is kvm or lxc?
230 2017-02-20T09:52:28  <jonasschnelli> KVM
231 2017-02-20T09:52:37  <wumpus> okay what I tried is LXC
232 2017-02-20T09:52:52  <jonasschnelli> Just tried LXC and seems to have worked..
233 2017-02-20T09:55:09  <wumpus> the upgrader should probably be passed some kind of silent/don't prompt flag for the KVM image build
234 2017-02-20T09:57:42  <jonasschnelli> After using LXC, the base image was named "base-trusty-amd64" instead of "base-trusty-amd64.qcow2"... renamed and trying to gbuild now
235 2017-02-20T09:58:29  *** Victor_sueca is now known as Victorsueca
236 2017-02-20T09:59:38  *** city22 has joined #bitcoin-core-dev
237 2017-02-20T10:04:25  <wumpus> jonasschnelli: that is the correct naming
238 2017-02-20T10:04:33  <wumpus> lxc image is not a qcow
239 2017-02-20T10:04:49  <jonasschnelli> ah... I guess I need to set USE_LXC
240 2017-02-20T10:13:09  <wumpus> yep
241 2017-02-20T10:13:28  *** city22 has quit IRC
242 2017-02-20T10:16:26  <jonasschnelli> libexec/config-bootstrap-fixup: line 15: target-bin/bootstrap-fixup.in: No such file or directory
243 2017-02-20T10:20:27  <wumpus> never seen that one before
244 2017-02-20T10:22:42  *** whphhg has quit IRC
245 2017-02-20T10:24:01  <wumpus> not sure if KVM will work at all in my setup, but will try making a KVM image
246 2017-02-20T10:36:12  *** goksinen has joined #bitcoin-core-dev
247 2017-02-20T10:40:39  *** goksinen has quit IRC
248 2017-02-20T10:43:43  *** city22 has joined #bitcoin-core-dev
249 2017-02-20T10:46:09  *** lclc has quit IRC
250 2017-02-20T10:50:11  <wumpus> jonasschnelli: I get the same error as you
251 2017-02-20T10:50:27  <wumpus> making an issue
252 2017-02-20T10:57:59  *** cbits has quit IRC
253 2017-02-20T11:00:03  *** city22 has quit IRC
254 2017-02-20T11:00:49  <wumpus> https://github.com/devrandom/gitian-builder/issues/144
255 2017-02-20T11:01:40  <wumpus> would be nice if we could resolve this before final
256 2017-02-20T11:12:32  *** JackH has joined #bitcoin-core-dev
257 2017-02-20T11:20:00  *** lclc has joined #bitcoin-core-dev
258 2017-02-20T11:29:27  *** whphhg has joined #bitcoin-core-dev
259 2017-02-20T11:30:38  *** goksinen has joined #bitcoin-core-dev
260 2017-02-20T11:34:59  *** goksinen has quit IRC
261 2017-02-20T11:36:16  *** [Author] has joined #bitcoin-core-dev
262 2017-02-20T11:42:45  *** chjj has joined #bitcoin-core-dev
263 2017-02-20T11:56:23  *** cannon-c has quit IRC
264 2017-02-20T12:03:25  <bitcoin-git> [bitcoin] GCarneiroA opened pull request #9809: Master (0.10...master) https://github.com/bitcoin/bitcoin/pull/9809
265 2017-02-20T12:04:34  <bitcoin-git> [bitcoin] fanquake closed pull request #9809: Master (0.10...master) https://github.com/bitcoin/bitcoin/pull/9809
266 2017-02-20T12:05:46  *** Lauda has quit IRC
267 2017-02-20T12:11:10  *** Lauda has joined #bitcoin-core-dev
268 2017-02-20T12:24:52  *** goksinen has joined #bitcoin-core-dev
269 2017-02-20T12:28:59  *** goksinen has quit IRC
270 2017-02-20T12:33:19  *** squidicuz has quit IRC
271 2017-02-20T12:33:44  *** squidicuz has joined #bitcoin-core-dev
272 2017-02-20T12:36:18  *** Giszmo has joined #bitcoin-core-dev
273 2017-02-20T12:45:01  *** cryptapus has joined #bitcoin-core-dev
274 2017-02-20T12:45:02  *** cryptapus has joined #bitcoin-core-dev
275 2017-02-20T13:22:46  *** AaronvanW has joined #bitcoin-core-dev
276 2017-02-20T13:26:53  *** OptMate has joined #bitcoin-core-dev
277 2017-02-20T13:28:34  *** OptMate has joined #bitcoin-core-dev
278 2017-02-20T13:36:26  *** Guyver2 has joined #bitcoin-core-dev
279 2017-02-20T13:48:19  *** laurentmt has joined #bitcoin-core-dev
280 2017-02-20T13:50:20  <achow101> jonasschnelli: that's an issue with vmbuilder. see https://bugs.launchpad.net/vmbuilder/+bug/1659952
281 2017-02-20T13:51:07  <jonasschnelli> achow101: Nice! thanks. You should probably report that also here -> https://github.com/devrandom/gitian-builder/issues/144
282 2017-02-20T13:51:13  *** kadoban has joined #bitcoin-core-dev
283 2017-02-20T13:52:00  *** OptMate has quit IRC
284 2017-02-20T14:03:57  *** city22 has joined #bitcoin-core-dev
285 2017-02-20T14:07:54  *** laurentmt has quit IRC
286 2017-02-20T14:21:27  *** chjj has quit IRC
287 2017-02-20T14:28:41  *** city22 has quit IRC
288 2017-02-20T14:30:37  *** chjj has joined #bitcoin-core-dev
289 2017-02-20T14:31:16  *** chjj has joined #bitcoin-core-dev
290 2017-02-20T14:32:28  *** Alina-malina has quit IRC
291 2017-02-20T14:33:40  *** Alina-malina has joined #bitcoin-core-dev
292 2017-02-20T14:37:36  *** chjj has quit IRC
293 2017-02-20T14:40:06  *** Alina-malina_ has joined #bitcoin-core-dev
294 2017-02-20T14:40:24  *** Alina-malina has quit IRC
295 2017-02-20T14:42:44  *** lclc has quit IRC
296 2017-02-20T14:42:59  *** goksinen has joined #bitcoin-core-dev
297 2017-02-20T14:43:30  *** Alina-malina_ has quit IRC
298 2017-02-20T14:43:30  *** Alina-malina_ has joined #bitcoin-core-dev
299 2017-02-20T14:47:19  *** goksinen has quit IRC
300 2017-02-20T14:48:43  *** wasi has quit IRC
301 2017-02-20T14:49:10  *** whphhg has quit IRC
302 2017-02-20T14:49:25  *** harrymm has quit IRC
303 2017-02-20T14:53:19  *** aalex has joined #bitcoin-core-dev
304 2017-02-20T14:59:15  *** chjj has joined #bitcoin-core-dev
305 2017-02-20T14:59:32  *** lclc has joined #bitcoin-core-dev
306 2017-02-20T15:00:53  *** wasi has joined #bitcoin-core-dev
307 2017-02-20T15:03:49  *** Chris_Stewart_5 has quit IRC
308 2017-02-20T15:06:50  *** whphhg has joined #bitcoin-core-dev
309 2017-02-20T15:09:08  *** harrymm has joined #bitcoin-core-dev
310 2017-02-20T15:17:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
311 2017-02-20T15:20:54  *** laurentmt has joined #bitcoin-core-dev
312 2017-02-20T15:25:20  <paveljanik> anyone running Windows here?
313 2017-02-20T15:25:32  <paveljanik> can you please try loading mempool.dat?
314 2017-02-20T15:26:07  *** lclc has quit IRC
315 2017-02-20T15:35:03  *** laurentmt has quit IRC
316 2017-02-20T15:35:26  *** laurentmt has joined #bitcoin-core-dev
317 2017-02-20T15:36:09  *** laurentmt has quit IRC
318 2017-02-20T15:37:18  *** goksinen has joined #bitcoin-core-dev
319 2017-02-20T15:41:39  *** goksinen has quit IRC
320 2017-02-20T16:00:08  *** goksinen has joined #bitcoin-core-dev
321 2017-02-20T16:04:39  *** goksinen has quit IRC
322 2017-02-20T16:25:09  *** lclc has joined #bitcoin-core-dev
323 2017-02-20T16:26:46  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/390a39bb5cf4...1a9fd5cb9d13
324 2017-02-20T16:26:47  <bitcoin-git> bitcoin/master 9adb694 Luke Dashjr: Qt/Intro: Move sizeWarningLabel text into C++ code
325 2017-02-20T16:26:47  <bitcoin-git> bitcoin/master 50c5657 Luke Dashjr: Qt/Intro: Storage shouldn't grow significantly with pruning enabled
326 2017-02-20T16:26:48  <bitcoin-git> bitcoin/master f6d18f5 Luke Dashjr: Qt/Intro: Explain a bit more what will happen first time
327 2017-02-20T16:27:07  <bitcoin-git> [bitcoin] laanwj closed pull request #9724: Qt/Intro: Add explanation of IBD process (master...intro_explain) https://github.com/bitcoin/bitcoin/pull/9724
328 2017-02-20T16:29:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1a9fd5cb9d13...7ca2f542708b
329 2017-02-20T16:29:41  <bitcoin-git> bitcoin/master 1bfe6b4 Mitchell Cash: Use package name variable inside $(package)_file_name variable
330 2017-02-20T16:29:42  <bitcoin-git> bitcoin/master 7ca2f54 Wladimir J. van der Laan: Merge #9794: Minor update to qrencode package builder...
331 2017-02-20T16:30:05  <bitcoin-git> [bitcoin] laanwj closed pull request #9794: Minor update to qrencode package builder (master...minor_depends_fix) https://github.com/bitcoin/bitcoin/pull/9794
332 2017-02-20T16:30:29  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ca2f542708b...2dad02232af1
333 2017-02-20T16:30:29  <bitcoin-git> bitcoin/master ec1267f Russell Yanofsky: [wallet] Remove importmulti always-true check...
334 2017-02-20T16:30:30  <bitcoin-git> bitcoin/master 2dad022 Wladimir J. van der Laan: Merge #9760: [wallet] Remove importmulti always-true check...
335 2017-02-20T16:30:54  <bitcoin-git> [bitcoin] laanwj closed pull request #9760: [wallet] Remove importmulti always-true check (master...pr/multitaut) https://github.com/bitcoin/bitcoin/pull/9760
336 2017-02-20T16:32:21  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/2dad02232af1...aa791e29114f
337 2017-02-20T16:32:22  <bitcoin-git> bitcoin/master 9fc7f0b Luke Dashjr: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates
338 2017-02-20T16:32:23  <bitcoin-git> bitcoin/master 279f944 Luke Dashjr: QA: Test GBT size/weight limit values
339 2017-02-20T16:32:23  <bitcoin-git> bitcoin/master aa791e2 Wladimir J. van der Laan: Merge #9619: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates...
340 2017-02-20T16:32:39  <bitcoin-git> [bitcoin] laanwj closed pull request #9619: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates (master...bugfix_gbt_presw) https://github.com/bitcoin/bitcoin/pull/9619
341 2017-02-20T16:36:57  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/40c754cb38cd...861cb0c83db0
342 2017-02-20T16:36:58  <bitcoin-git> bitcoin/0.14 6552729 Luke Dashjr: Bugfix: RPC/Mining: GBT should return 1 MB sizelimit before segwit activates...
343 2017-02-20T16:36:58  <bitcoin-git> bitcoin/0.14 861cb0c Luke Dashjr: QA: Test GBT size/weight limit values...
344 2017-02-20T16:46:26  *** goksinen has joined #bitcoin-core-dev
345 2017-02-20T16:50:14  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/aa791e29114f...7639d38f14b1
346 2017-02-20T16:50:15  <bitcoin-git> bitcoin/master 13f6085 Wladimir J. van der Laan: netbase: Make InterruptibleRecv return an error code instead of bool
347 2017-02-20T16:50:15  <bitcoin-git> bitcoin/master 3ddfe29 Wladimir J. van der Laan: netbase: Do not print an error on connection timeouts through proxy...
348 2017-02-20T16:50:16  <bitcoin-git> bitcoin/master 7639d38 Wladimir J. van der Laan: Merge #9726: netbase: Do not print an error on connection timeouts through proxy...
349 2017-02-20T16:50:40  <bitcoin-git> [bitcoin] laanwj closed pull request #9726: netbase: Do not print an error on connection timeouts through proxy (master...2017_02_intr_recv_error) https://github.com/bitcoin/bitcoin/pull/9726
350 2017-02-20T16:58:17  *** lclc has quit IRC
351 2017-02-20T17:00:36  *** kyletorpey has joined #bitcoin-core-dev
352 2017-02-20T17:02:44  <paveljanik> sipa, wumpus: #9810 - any idea (seems to be crlf on serialization ;-)?
353 2017-02-20T17:02:45  <gribble> https://github.com/bitcoin/bitcoin/issues/9810 | 0.14 not loading mempool.dat? · Issue #9810 · bitcoin/bitcoin · GitHub
354 2017-02-20T17:03:06  <paveljanik> binary on write?
355 2017-02-20T17:03:24  <paveljanik> Windows...
356 2017-02-20T17:03:41  *** wangchun has joined #bitcoin-core-dev
357 2017-02-20T17:04:00  <wumpus> that could be the explanation, good catch! how is the file opened?
358 2017-02-20T17:04:24  <wumpus> if its opened in text (instead of binary) mode, windows will convert \n to \r\n
359 2017-02-20T17:06:19  *** moli_ has quit IRC
360 2017-02-20T17:06:29  <paveljanik> it is written with "w" and opened with "r"
361 2017-02-20T17:06:50  <wumpus> that should be "wb" and "rb"
362 2017-02-20T17:06:58  <wumpus> so you've found the issue, congrats
363 2017-02-20T17:07:01  <paveljanik> Hmm, this reminds me: zerocoin was missing =, we are missing b ;-)
364 2017-02-20T17:07:17  <paveljanik> we should congrat to the reporter!
365 2017-02-20T17:07:25  *** eenoch_ has joined #bitcoin-core-dev
366 2017-02-20T17:07:49  <wumpus> I mean you've found the probable solution
367 2017-02-20T17:08:04  <paveljanik> but really: any dev with Windows to really test this?
368 2017-02-20T17:08:21  *** Alina-malina_ is now known as Alina-malina
369 2017-02-20T17:08:21  <wumpus> are you going to make a PR?
370 2017-02-20T17:08:35  *** cryptapus is now known as cryptapus_afk
371 2017-02-20T17:08:46  *** BashCo_ has joined #bitcoin-core-dev
372 2017-02-20T17:08:56  <paveljanik> for master and you'll backport?
373 2017-02-20T17:09:12  <wumpus> yes
374 2017-02-20T17:09:16  *** cryptapus_afk is now known as cryptapus
375 2017-02-20T17:09:17  *** instagibbs has quit IRC
376 2017-02-20T17:09:19  *** OfficialLeibniz has quit IRC
377 2017-02-20T17:09:19  *** eenoch has quit IRC
378 2017-02-20T17:09:19  *** atroxes has quit IRC
379 2017-02-20T17:09:19  *** dgenr8 has quit IRC
380 2017-02-20T17:09:20  *** murchandamus has quit IRC
381 2017-02-20T17:09:30  <paveljanik> give me a few minutes
382 2017-02-20T17:09:33  *** atroxes has joined #bitcoin-core-dev
383 2017-02-20T17:09:40  *** dgenr8 has joined #bitcoin-core-dev
384 2017-02-20T17:09:48  *** murchandamus has joined #bitcoin-core-dev
385 2017-02-20T17:11:39  *** BashCo has quit IRC
386 2017-02-20T17:11:40  *** moli_ has joined #bitcoin-core-dev
387 2017-02-20T17:11:58  *** instagibbs has joined #bitcoin-core-dev
388 2017-02-20T17:13:45  *** OfficialLeibniz has joined #bitcoin-core-dev
389 2017-02-20T17:15:38  <bitcoin-git> [bitcoin] paveljanik opened pull request #9813: Read/write mempool.dat as a binary. (master...20170220_mempool_binary) https://github.com/bitcoin/bitcoin/pull/9813
390 2017-02-20T17:25:25  <wumpus> paveljanik: thanks
391 2017-02-20T17:25:52  <paveljanik> you're welcome!
392 2017-02-20T17:27:43  <paveljanik> we use "w" for PID and log
393 2017-02-20T17:28:53  <paveljanik> and in tests
394 2017-02-20T17:28:56  <paveljanik> all "text" files
395 2017-02-20T17:32:22  *** bsm117532 has joined #bitcoin-core-dev
396 2017-02-20T17:32:42  <cfields> windows users who ran rc1 will need to delete mempool.dat. Not sure if that
397 2017-02-20T17:32:49  <cfields> 's worth adding to the release notes or not
398 2017-02-20T17:34:30  <paveljanik> it is auto fixed at the first exit?
399 2017-02-20T17:34:37  <paveljanik> by saving the new file...
400 2017-02-20T17:34:55  *** aalex has quit IRC
401 2017-02-20T17:35:40  *** kyletorpey has quit IRC
402 2017-02-20T17:36:13  <cfields> ah, right.
403 2017-02-20T17:39:42  <wumpus> for text files it makes sense not to add 'b', otherwise you cannot open it in notepad
404 2017-02-20T17:50:47  *** jannes has joined #bitcoin-core-dev
405 2017-02-20T17:53:04  *** whphhg has quit IRC
406 2017-02-20T17:55:21  *** cryptapus is now known as cryptapus_afk
407 2017-02-20T17:59:35  *** aalex has joined #bitcoin-core-dev
408 2017-02-20T18:03:16  <achow101> paveljanik: I can test on windows, as soon as I my windows node finishes syncing
409 2017-02-20T18:03:39  <paveljanik> achow101, great!
410 2017-02-20T18:13:27  <achow101> if only we could figure out how to make cross compiling work on xenial... cross compiling for windows is such a pain now
411 2017-02-20T18:19:12  *** jamoes has joined #bitcoin-core-dev
412 2017-02-20T18:23:05  <sipa> achow101: what fails?
413 2017-02-20T18:23:43  <achow101> sipa: https://github.com/bitcoin/bitcoin/projects/1
414 2017-02-20T18:23:45  <achow101> still unresolved
415 2017-02-20T18:25:22  *** BashCo_ has quit IRC
416 2017-02-20T18:25:42  *** jamoes has quit IRC
417 2017-02-20T18:26:03  *** BashCo has joined #bitcoin-core-dev
418 2017-02-20T18:29:15  *** jamoes has joined #bitcoin-core-dev
419 2017-02-20T18:29:39  *** whphhg has joined #bitcoin-core-dev
420 2017-02-20T18:31:07  *** BashCo has quit IRC
421 2017-02-20T18:33:40  <achow101> paveljanik: your fix didn't work for me on ubuntu 16.04
422 2017-02-20T18:34:06  <paveljanik> achow101, on Ubuntu?
423 2017-02-20T18:34:19  <paveljanik> you have tried the provided mempool.dat?
424 2017-02-20T18:34:28  <paveljanik> My fix fixes save on Windows...
425 2017-02-20T18:35:03  <achow101> oh, it was windows specific? I am testing on both ubuntu and windows, just waiting for windows to finish building
426 2017-02-20T18:35:26  *** Giszmo has quit IRC
427 2017-02-20T18:37:08  *** murchandamus has quit IRC
428 2017-02-20T18:38:01  *** murchandamus has joined #bitcoin-core-dev
429 2017-02-20T18:46:06  <achow101> paveljanik: for some reason I had to delete the mempool.dats before it would work properly
430 2017-02-20T18:46:33  *** murchandamus has quit IRC
431 2017-02-20T18:48:56  *** murchandamus has joined #bitcoin-core-dev
432 2017-02-20T18:50:25  *** murchandamus has quit IRC
433 2017-02-20T18:50:37  *** Giszmo has joined #bitcoin-core-dev
434 2017-02-20T18:50:48  *** BashCo has joined #bitcoin-core-dev
435 2017-02-20T18:51:12  <paveljanik> yes, this is probably caused by the issue fixed ;-)
436 2017-02-20T18:51:53  *** isle2983 has quit IRC
437 2017-02-20T18:51:56  <paveljanik> achow101, can you please try again with the master-saved mempool.dat?
438 2017-02-20T18:52:16  <paveljanik> and then run fixed tree with the old mempool.dat?
439 2017-02-20T18:52:39  <paveljanik> it won't use it. But at exit, it should rewrite it and then on the new start it should use it.
440 2017-02-20T18:53:21  *** murchandamus has joined #bitcoin-core-dev
441 2017-02-20T18:57:32  *** harrymm has quit IRC
442 2017-02-20T19:03:48  *** owowo has quit IRC
443 2017-02-20T19:08:30  *** owowo has joined #bitcoin-core-dev
444 2017-02-20T19:09:29  *** lclc has joined #bitcoin-core-dev
445 2017-02-20T19:13:03  *** Giszmo has quit IRC
446 2017-02-20T19:16:59  <achow101> ok, it looks like it does rewrite the old one and actually uses it
447 2017-02-20T19:17:51  *** harrymm has joined #bitcoin-core-dev
448 2017-02-20T19:26:39  *** Giszmo has joined #bitcoin-core-dev
449 2017-02-20T19:32:47  *** isle2983 has joined #bitcoin-core-dev
450 2017-02-20T19:52:31  *** harrymm has quit IRC
451 2017-02-20T19:53:53  *** kyletorpey has joined #bitcoin-core-dev
452 2017-02-20T19:59:36  *** lclc has quit IRC
453 2017-02-20T20:08:13  *** lclc has joined #bitcoin-core-dev
454 2017-02-20T20:12:39  <paveljanik> achow101, perfect!
455 2017-02-20T20:13:08  *** harrymm has joined #bitcoin-core-dev
456 2017-02-20T20:15:47  *** laurentmt has joined #bitcoin-core-dev
457 2017-02-20T20:26:40  *** handlex has joined #bitcoin-core-dev
458 2017-02-20T20:28:51  *** droark has quit IRC
459 2017-02-20T20:35:28  *** handlex has quit IRC
460 2017-02-20T20:37:00  <BlueMatt> what am I missing? why are we going out of our way to prefer data() over &v[0]?
461 2017-02-20T20:37:14  <BlueMatt> I mean its more readable, sure, but I dont believe it is safer in any measurable way?
462 2017-02-20T20:38:12  <BlueMatt> or, maybe I'm missing in docs...is it that data() is defined for 0-length vectors (though not dereferenceable - it can return any garbage it wants), but &[0] is not?
463 2017-02-20T20:43:14  <gwillen> BlueMatt: I believe &[0] should be defined for zero-length vectors, it's legal to take a pointer to the slot right after the end of an array (this is what e.g. a .end() iterator is)
464 2017-02-20T20:43:33  <gwillen> see the _second_ (not accepted) answer which quotes the standard: http://stackoverflow.com/questions/988158/take-the-address-of-a-one-past-the-end-array-element-via-subscript-legal-by-the
465 2017-02-20T20:43:46  <midnightmagic> huh, that's interesting. I've been fighting with almost that exact same thing.
466 2017-02-20T20:43:53  *** justanotheruser has joined #bitcoin-core-dev
467 2017-02-20T20:44:08  *** jannes has quit IRC
468 2017-02-20T20:44:59  <BlueMatt> gwillen: hmm? I mean that doesnt inherintly mean C++ allows it as well?
469 2017-02-20T20:45:09  <sipa> BlueMatt: vect[0] is a reference to non-existing data if vector is empty, which is illegal
470 2017-02-20T20:45:17  <sipa> you can have a pointer to non-existing data, but not a reference
471 2017-02-20T20:45:49  <BlueMatt> ahh, ok, so it is illegal in C++ but not C?
472 2017-02-20T20:45:54  <gwillen> sipa: but &foo[0] is a pointer, not a reference
473 2017-02-20T20:45:55  <BlueMatt> (well, vector but not array)
474 2017-02-20T20:46:00  <gwillen> and a pointer to one past the end is definitely legal
475 2017-02-20T20:46:08  <sipa> gwillen: &foo[0] = &(foo[0])
476 2017-02-20T20:46:17  <sipa> that's taking the address of a reference to non-existing data
477 2017-02-20T20:46:31  <BlueMatt> sipa: see stackoverflow link from gwillen, it sppears to be legal in C
478 2017-02-20T20:46:33  <gwillen> do you believe it's different in C++ with a vector than in C with an array?
479 2017-02-20T20:46:39  <sipa> C doesn't have references
480 2017-02-20T20:46:39  *** OfficialLeibniz has quit IRC
481 2017-02-20T20:46:45  <sipa> the question doesn't apply
482 2017-02-20T20:46:46  <gwillen> right
483 2017-02-20T20:47:01  <sipa> a[b] in C is just syntactic sugar for *(a+b)
484 2017-02-20T20:47:04  <gwillen> but in C that construction would appear to actually dereference an invalid pointer, but the standard gives it a pass
485 2017-02-20T20:47:25  <gwillen> and explicity says that if you do &foo[x] it turns into foo+x and does not dereference
486 2017-02-20T20:47:34  <sipa> well that's about arrays
487 2017-02-20T20:47:38  * gwillen nods
488 2017-02-20T20:47:48  <sipa> which are defined by the language
489 2017-02-20T20:47:51  <BlueMatt> mmm, ok
490 2017-02-20T20:48:06  <gwillen> well, it actually also says this pass applies to the * operator as well, and &(*foo) does not dereference either, which is slightly more general
491 2017-02-20T20:48:20  <sipa> but vector is a standard library class, where vect[x] is an operator that returns a reference to a vector element
492 2017-02-20T20:48:23  <gwillen> but I suppose that would be hard to spec for user-defined operators
493 2017-02-20T20:48:24  * gwillen nod
494 2017-02-20T20:48:29  <sipa> which is just impossible to do if there are no elements
495 2017-02-20T20:50:12  <sipa> for example, a vector implementation (and in practice does) contains a pointer to the first element of the data
496 2017-02-20T20:50:25  <sipa> but initializes it to nullptr if there are no elements allocated
497 2017-02-20T20:50:44  <sipa> vect[0] would then be implemented as a dereference of nullptr
498 2017-02-20T20:51:07  * gwillen no
499 2017-02-20T20:51:09  <sipa> so forcing vect[0] to be valid for empty vectors would outlaw the obviously simplest implementation
500 2017-02-20T20:51:12  <gwillen> nod*
501 2017-02-20T20:51:47  <BlueMatt> yea, ok
502 2017-02-20T20:51:49  <sipa> whereas array[0] is simply a reference to the element 1 past the array... not nullptr
503 2017-02-20T20:52:05  <gwillen> right
504 2017-02-20T20:52:20  <sipa> actually, i believe that C and/or C++ require every object to have non-zero allocation space
505 2017-02-20T20:52:47  <sipa> otherwise alias detection is nearly impossible
506 2017-02-20T20:56:42  <luke-jr> hmm
507 2017-02-20T20:57:04  <luke-jr> &foo[0] actually called operator[] in C++, rather than just being (foo+0)?
508 2017-02-20T20:57:14  <sipa> for vectors, yes
509 2017-02-20T20:57:18  <luke-jr> I guess it would have to :x
510 2017-02-20T20:57:30  <sipa> for arrays i don't know
511 2017-02-20T20:57:51  <luke-jr> a shame, &foo[0] looks nicer XD
512 2017-02-20T20:58:27  <sipa> also, (foo+0) for a vector would be nonsense... you can't add 0 to a vector
513 2017-02-20T20:58:37  <luke-jr> ☺
514 2017-02-20T21:01:43  <sipa> FATAL: ThreadSanitizer CHECK failed: ../../../../src/libsanitizer/sanitizer_common/sanitizer_deadlock_detector1.cc:122 "((len)) > ((0U))" (0x0, 0x0)
515 2017-02-20T21:01:46  <sipa>     #0 <null> <null> (libtsan.so.0+0x00000007c0d3)
516 2017-02-20T21:01:46  <gribble> https://github.com/bitcoin/bitcoin/issues/0 | HTTP Error 404: Not Found
517 2017-02-20T21:01:48  <sipa>     #1 <null> <null> (libtsan.so.0+0x00000007c0db)
518 2017-02-20T21:01:50  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
519 2017-02-20T21:01:51  <sipa>     #2 __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) <null> (libtsan.so.0+0x000000081303)
520 2017-02-20T21:01:53  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
521 2017-02-20T21:01:54  <sipa> much sad
522 2017-02-20T21:02:11  <sipa> assertion failure inside tsan :(
523 2017-02-20T21:03:11  *** lclc has quit IRC
524 2017-02-20T21:05:37  *** lclc has joined #bitcoin-core-dev
525 2017-02-20T21:15:20  *** lclc has quit IRC
526 2017-02-20T21:17:16  *** lclc has joined #bitcoin-core-dev
527 2017-02-20T21:23:10  *** lclc has quit IRC
528 2017-02-20T21:42:22  *** wasi has quit IRC
529 2017-02-20T21:42:47  *** wasi has joined #bitcoin-core-dev
530 2017-02-20T21:50:02  <BlueMatt> god damnit gribble
531 2017-02-20T21:51:04  <sipa> indeed!
532 2017-02-20T21:51:19  <btcdrak> issue 0 as well lol
533 2017-02-20T21:57:40  *** harrymm has quit IRC
534 2017-02-20T22:00:47  *** Guest42592 has joined #bitcoin-core-dev
535 2017-02-20T22:04:15  <BlueMatt> should we mention somewhere in the release notes that 0.14 has mega-super-amazing-faster block relay?
536 2017-02-20T22:07:22  <sipa> there is an issue about that by cory i think
537 2017-02-20T22:07:23  <sipa> or a pr
538 2017-02-20T22:08:17  <BlueMatt> ok, good...I often dont read release-notes stuff :/
539 2017-02-20T22:08:21  <BlueMatt> I suppose I'm a bad contributor :/
540 2017-02-20T22:13:10  *** harrymm has joined #bitcoin-core-dev
541 2017-02-20T22:44:05  *** aalex has quit IRC
542 2017-02-20T22:58:02  *** Guyver2 has quit IRC
543 2017-02-20T23:00:13  *** AaronvanW has quit IRC
544 2017-02-20T23:06:00  *** justan0theruser has joined #bitcoin-core-dev
545 2017-02-20T23:07:27  *** justanotheruser has quit IRC
546 2017-02-20T23:43:17  *** roidster has joined #bitcoin-core-dev
547 2017-02-20T23:43:20  *** roidster is now known as Guest47564
548 2017-02-20T23:44:18  *** Guest47564 is now known as roidster
549 2017-02-20T23:50:00  <gmaxwell> BlueMatt: you should measure it.
550 2017-02-20T23:50:19  <BlueMatt> gmaxwell: which part?
551 2017-02-20T23:52:56  <gmaxwell> preferably the mega-super-amazing parts.
552 2017-02-20T23:53:52  <BlueMatt> fast-relay: we have good measurements for how long validation takes
553 2017-02-20T23:53:55  <BlueMatt> you win by that much :)
554 2017-02-20T23:54:01  *** laurentmt has quit IRC