12017-02-21T00:00:24 *** cbits has joined #bitcoin-core-dev
22017-02-21T00:04:19 *** cbits has quit IRC
32017-02-21T00:14:15 *** IRCFrEAK has joined #bitcoin-core-dev
42017-02-21T00:14:16 *** IRCFrEAK has left #bitcoin-core-dev
52017-02-21T00:15:22 *** grubles has quit IRC
62017-02-21T00:18:46 *** justanotheruser has joined #bitcoin-core-dev
72017-02-21T00:18:55 *** grubles has joined #bitcoin-core-dev
82017-02-21T00:20:28 *** justan0theruser has quit IRC
92017-02-21T00:55:21 <gmaxwell> cfields: I'd like to see the vla warning go in ( #9789 ) -- but it really should be a warning, as we just encountered a fails in one compiler but not another.
102017-02-21T00:55:22 <gribble> https://github.com/bitcoin/bitcoin/issues/9789 | build: disallow variable length arrays by theuni · Pull Request #9789 · bitcoin/bitcoin · GitHub
112017-02-21T00:56:46 <gmaxwell> BlueMatt: We're making too many changes with the network without good data on their improvements. The recent ones have been such obviously clear wins that it's okay-- but if we do not get good ways of benchmarking these things running constantly, we're going to eventually make dumb decisions. As a bonus, we'll be able to describe our improvements in ways more specific than mega-super-amazing. :)
122017-02-21T00:56:49 <cfields> gmaxwell: ok. i thought on that a good bit after you raised the objection, and ultimately i agree
132017-02-21T00:57:22 <cfields> gmaxwell: speaking of which, i'm futzing with gnuplot atm :)
142017-02-21T00:57:35 <BlueMatt> gmaxwell: talk to jnewbery :)
152017-02-21T00:58:06 <BlueMatt> (he's working on using the simulation framework stuff to build benchmark CI, and I told him he should set up mini-networks with simulated latency and benchmark that, too)
162017-02-21T00:58:09 <cfields> gmaxwell: plotting out a few different data sets wrt ibd sync between 0.13/0.14
172017-02-21T00:58:19 <gmaxwell> cfields: sweet.
182017-02-21T00:58:36 <gmaxwell> title "Mega-super-amazing performance"
192017-02-21T01:30:50 *** chjj has quit IRC
202017-02-21T01:32:14 *** BashCo_ has joined #bitcoin-core-dev
212017-02-21T01:32:57 *** BashCo has quit IRC
222017-02-21T01:46:46 *** dodomojo has joined #bitcoin-core-dev
232017-02-21T02:04:13 *** jtimon has joined #bitcoin-core-dev
242017-02-21T02:15:19 *** jtimon has quit IRC
252017-02-21T02:15:52 *** jtimon has joined #bitcoin-core-dev
262017-02-21T02:32:30 *** wasi has quit IRC
272017-02-21T02:33:03 *** wasi has joined #bitcoin-core-dev
282017-02-21T02:34:00 *** Ylbam has quit IRC
292017-02-21T02:45:15 *** jtimon has quit IRC
302017-02-21T03:00:05 *** dermoth has quit IRC
312017-02-21T03:00:47 *** dermoth has joined #bitcoin-core-dev
322017-02-21T03:23:40 *** dodomojo has quit IRC
332017-02-21T03:31:39 *** roidster has quit IRC
342017-02-21T03:36:21 *** dodomojo has joined #bitcoin-core-dev
352017-02-21T03:53:44 *** Giszmo has quit IRC
362017-02-21T04:18:34 *** dodomojo has quit IRC
372017-02-21T04:20:07 *** dodomojo has joined #bitcoin-core-dev
382017-02-21T04:23:48 *** nickler has quit IRC
392017-02-21T04:27:39 *** nickler has joined #bitcoin-core-dev
402017-02-21T04:53:53 *** chris2000 has joined #bitcoin-core-dev
412017-02-21T04:57:12 *** chris200_ has quit IRC
422017-02-21T05:27:22 *** chjj has joined #bitcoin-core-dev
432017-02-21T06:11:31 *** Guyver2 has joined #bitcoin-core-dev
442017-02-21T06:12:57 <cfields> gmaxwell: https://i.imgur.com/8M3wPM4.png
452017-02-21T06:13:24 <cfields> i got tired of arguing with gnuplot over the x axis :\
462017-02-21T06:14:00 <cfields> (it's linear)
472017-02-21T06:14:37 <gmaxwell> set xdata time
482017-02-21T06:14:55 <gmaxwell> set timefmt "%s" ?
492017-02-21T06:15:26 <cfields> gmaxwell: it's real timestamps, not scaled down to 0. So it wants to show crazy-high second-values
502017-02-21T06:15:44 <gmaxwell> it's a neat graph though it really hides a lot of the other improvements on 0.14 since it only goes to 295k
512017-02-21T06:15:59 <sipa> cfields: so subtract the lowest timestamp?
522017-02-21T06:16:21 <gmaxwell> using 1:($2-constant) with lines
532017-02-21T06:16:40 <cfields> gmaxwell: well the 295k is where the checkpoint kicks in in 0.14. I'd prefer to see a separate graph syncing blocks 0 to 100,000 or so without checkpoints/assumevalid
542017-02-21T06:16:52 <cfields> *in 0.13, sorry
552017-02-21T06:17:13 <gmaxwell> it's not just that, the behavior of the blockchain is quite different in the last two years than the first two. :)
562017-02-21T06:17:16 <sipa> i think it's a neat graph
572017-02-21T06:17:40 <sipa> it doesn't show everything, but it's hard to put everything in one graph without misrepresenting one thing or another
582017-02-21T06:18:13 <cfields> gmaxwell: very much so. Clearly 0.14 benefits most from the improved short bursts in the early blocks
592017-02-21T06:19:33 <cfields> but yes, i'd like to do another where validation is forced for all
602017-02-21T06:23:49 <gmaxwell> It would be nice to have a general figure reflecting user expirence for the release note. "With default settings syncing has been reduced from X hours to Y hours on a quad-core system from another local 0.14 node."
612017-02-21T06:25:31 <cfields> gmaxwell: agreed. I have figures for 0.14->0.14 on an ec2 4xcpu, 8gb ram. It's ~3hrs. 0.13.2->0.13.2 was taking too long and i got impatent, wanting to run other tests :(
622017-02-21T06:25:40 <cfields> i can fire that one up again tomorrow and just let it go
632017-02-21T06:26:27 <cfields> (that was dbcache=4000, blocksonly=1, listen=0, disablewallet=1)
642017-02-21T06:26:59 <gmaxwell> ec2 is really IO starved normally no?
652017-02-21T06:27:04 <cfields> *impatient. That was a dangerous typo :)
662017-02-21T06:29:03 <cfields> gmaxwell: unsure. I figured it was representative of how lots of nodes are run, so good data point
672017-02-21T06:29:07 <cfields> no clue how true that is
682017-02-21T06:32:30 <gmaxwell> I'm pretty sure any customization of dbcache limits it to representing <5% of nodes.
692017-02-21T06:33:09 *** lclc has joined #bitcoin-core-dev
702017-02-21T06:33:43 <cfields> mm, good point
712017-02-21T06:36:24 <jeremyrubin> Hey I have an idea...
722017-02-21T06:36:36 <jeremyrubin> what if during validating sync
732017-02-21T06:37:11 <jeremyrubin> hmmm nevermind... let me read more
742017-02-21T06:43:23 * luke-jr discovers GCC 4.9 doesn't actually support all C++11 >_<
752017-02-21T06:43:33 *** yahtoo has joined #bitcoin-core-dev
762017-02-21T06:44:05 <cfields> luke-jr: atomic shared_ptr ?
772017-02-21T06:44:14 <luke-jr> cfields: std::align
782017-02-21T06:45:04 <cfields> huh, i wasn't aware of std::align. Only alignof/alignas
792017-02-21T06:53:04 *** kyletorpey has quit IRC
802017-02-21T07:02:19 <gmaxwell> ... idiot fake nodes, I have one connected to me that continually sends verack messages instead of pongs.
812017-02-21T07:04:44 <sipa> lol
822017-02-21T07:05:22 <luke-jr> XD
832017-02-21T07:05:52 <sipa> Ḧello! speed v 70012?- sure, i can speak 70012 - have you heard about tx ab315fa5118? - sure i can speak 70012!
842017-02-21T07:07:05 <gmaxwell> "It says ack, right in the name."
852017-02-21T07:08:17 <cfields> heh
862017-02-21T07:08:33 <luke-jr> gmaxwell: verack
872017-02-21T07:08:33 <cfields> makes sense, i think. From the laziest possible implementor's perspective
882017-02-21T07:08:43 <cfields> pretty sure we never penalized dupe veracks
892017-02-21T07:09:09 <sipa> i thought we did
902017-02-21T07:09:10 <cfields> so if you don't feel like coding an extra 3 lines, just always reply with verack. ship it!
912017-02-21T07:09:17 <gmaxwell> yea, if your goal is just to record inv traffic; 'anytime you get anything send this canned verack' is the absolute minimum to make the protocol go.
922017-02-21T07:10:24 <luke-jr> gmaxwell: why wait until you get something? XD
932017-02-21T07:10:55 <cfields> sipa: doesn't look like it. Unless there's something subtle
942017-02-21T07:12:15 <sipa> we do penalize duplicate version, right?
952017-02-21T07:12:30 <cfields> both, now
962017-02-21T07:12:46 <gmaxwell> I don't think we peanalize duplicate verack now, do we?
972017-02-21T07:13:00 *** yahtoo has quit IRC
982017-02-21T07:13:50 <luke-jr> gmaxwell: verack
992017-02-21T07:14:20 <cfields> hmm, i guess not. Could've sworn that went in
1002017-02-21T07:21:35 *** Guyver2 has quit IRC
1012017-02-21T07:39:29 *** Ylbam has joined #bitcoin-core-dev
1022017-02-21T07:42:37 *** BashCo_ has quit IRC
1032017-02-21T07:43:16 *** BashCo has joined #bitcoin-core-dev
1042017-02-21T07:43:48 *** aalex has joined #bitcoin-core-dev
1052017-02-21T07:47:46 *** BashCo has quit IRC
1062017-02-21T07:50:01 *** aalex has quit IRC
1072017-02-21T08:05:27 *** harrymm has quit IRC
1082017-02-21T08:06:34 *** BashCo has joined #bitcoin-core-dev
1092017-02-21T08:20:38 *** harrymm has joined #bitcoin-core-dev
1102017-02-21T08:38:47 <bitcoin-git> [bitcoin] benma opened pull request #9815: Trivial: use EXIT_ codes instead of magic numbers (master...exitcode) https://github.com/bitcoin/bitcoin/pull/9815
1112017-02-21T08:43:12 <gmaxwell> I vaguely recall from some other project that there was a reason to not do that ^. ... probably on obscure platforms we don't support.
1122017-02-21T08:44:41 <gmaxwell> hm. perhaps I remember incorrectly.
1132017-02-21T08:59:10 <jonasschnelli> Still having troubles setting up gitian LXC. The LXC container can't connect to the internet. I don't have a VM for gitian. I run gbuild directly on a host. The host has a single public IPv4 addr. I'm not sure how I can setup the bridging..
1142017-02-21T09:00:18 *** paveljanik has quit IRC
1152017-02-21T09:03:40 <wumpus> gmaxwell: that's pretty late to start arguing against it we've already done it for 99% of the project
1162017-02-21T09:04:18 <wumpus> jonasschnelli: strange.
1172017-02-21T09:05:05 <wumpus> jonasschnelli: did you set the GITIAN_HOST_IP and LXC_GUEST_IP?
1182017-02-21T09:05:43 *** fanquake has joined #bitcoin-core-dev
1192017-02-21T09:06:28 <wumpus> jonasschnelli: there's some setup here that you need https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#setting-up-debian-for-gitian-building
1202017-02-21T09:06:36 <fanquake> wumpus I agree with your comments re gitian building and LXC. That is what I've always used, these problems are all that I've ever had with it. I think the gitian build guide also does a, lengthy, but good job of explaining setup.
1212017-02-21T09:07:20 <fanquake> That's using a debian & virtualbox on osx.
1222017-02-21T09:07:40 <wumpus> fanquake: thanks. we should just try to fix the guide, at least the parts people stumbling on. Writing another one for KVM, which proabably gets outdated just as quickly isn't much of a solution.
1232017-02-21T09:08:25 <fanquake> cfields If I start a node with those params, and quit after some syncing I get a segfault :o Investigating now.
1242017-02-21T09:09:26 <wumpus> also I think LXC is conceptually the right solution for this problem - what you want for building is an isolated container, not a full emulated operating system
1252017-02-21T09:09:38 <fanquake> wumpus yea, the guide could probably use some improving. I've tried to keep it up to date every now and then. I though we also had a gitian-building script that was meant to automate some of the setting up?
1262017-02-21T09:10:03 <gmaxwell> wumpus: fair enough!
1272017-02-21T09:10:22 <wumpus> fanquake: I'm kind of disappointed that the person adding the gitian-building script didn't update the guide to use it
1282017-02-21T09:10:33 <wumpus> fanquake: that kind of guarantees no one will use his script
1292017-02-21T09:11:13 <fanquake> We also link to that Docker setup. I checked the other day and it hasn't been updated in > 1yr. Think we could probably drop that link from the guide.
1302017-02-21T09:11:15 <wumpus> gmaxwell: according to the manpage it's even more portable "The use of EXIT_SUCCESS and EXIT_FAILURE is slightly more portable (to non-UNIX environments) than the use of 0 and some nonzero value like 1 or -1. In particular, VMS uses a different convention." VMS!
1312017-02-21T09:11:19 <luke-jr> wumpus: I think UML is a better solution :p
1322017-02-21T09:11:34 <wumpus> luke-jr: the 90's called and want UML back? :p
1332017-02-21T09:12:04 <gmaxwell> maybe thats what I'm remembering! :P
1342017-02-21T09:12:06 <luke-jr> âº
1352017-02-21T09:12:26 <wumpus> luke-jr: more seriously, I haven't heard of anyone using UML in 10 years or so
1362017-02-21T09:12:30 <jonasschnelli> wumpus: I have set GITIAN_HOST_IP and LXC_GUEST_IP to the same public ipv4 addr. I'm not aware of any other IP address that could be used?!
1372017-02-21T09:12:39 <jonasschnelli> There is no LAN in my case
1382017-02-21T09:12:47 <fanquake> Can anyone confirm this. src/qt/bitcoin-qt --reindex --dbacache=8192 --par=10 --blocksonly=1 --listen=0 --disablewallet=1 quiting after any amount of time gives a segfault.
1392017-02-21T09:13:00 <luke-jr> wumpus: I'm surprised you remembered it
1402017-02-21T09:13:08 <luke-jr> well, slightly.
1412017-02-21T09:13:35 <wumpus> luke-jr: I remember a lot of useless things
1422017-02-21T09:14:02 <wumpus> jonasschnelli:i: if you set them to the same IP it will fail. The point is that the host and guest communicate with each other on this bridge network
1432017-02-21T09:15:08 <jonasschnelli> Hmm.. maybe I use ifconfig br0 10.0.3.2/24 up for the bridge and set 10.0.3.5 as guest IP and my public ip as host... let me try
1442017-02-21T09:15:29 <wumpus> jonasschnelli: so the sequence there is : set up a br0 network, assign ourlelves an IP on it and bring it up, set up masquerading for the interface to the outside, set up forwarding, then tell gitian-builder these things by the way of environment variables
1452017-02-21T09:16:08 <wumpus> GITIAN_HOST_IP should be the IP we assign ourselves using ifconfig br0
1462017-02-21T09:16:21 <wumpus> LXC_GUEST_IP is the IP that the guest should have, and should be within this subnet
1472017-02-21T09:17:06 <fanquake> Ok, the problem is just with âdisablewallet=1 , running with that and then quitting will segfault on master.
1482017-02-21T09:17:08 <jonasschnelli> Okay. Then GITIAN_HOST_IP=10.0.3.2 and LXC_GUEST_IP=10.0.3.5 should work... ok let me try. I think i also enabled Ipv4 forwarding
1492017-02-21T09:18:25 <jonasschnelli> fanquake: Thanks for the report. Is there already an issue on github for that?
1502017-02-21T09:18:38 <jonasschnelli> I can try to fix this
1512017-02-21T09:18:45 <fanquake> jonasschnelli checking, if not ill open with some details.
1522017-02-21T09:18:54 <jonasschnelli> Thanks!
1532017-02-21T09:18:55 <fanquake> Checking with 0.14.0rc1 that is.
1542017-02-21T09:19:20 <jonasschnelli> Oh. Now install.log reports successful apt installed... thanks wumpus!
1552017-02-21T09:19:42 * jonasschnelli think he should learn the basics of net bridging...
1562017-02-21T09:20:30 *** Squidicc has joined #bitcoin-core-dev
1572017-02-21T09:22:47 *** squidicuz has quit IRC
1582017-02-21T09:24:14 *** Squidicuz has joined #bitcoin-core-dev
1592017-02-21T09:24:59 <jonasschnelli> Hmm... now I see in build.log that Fetching ccache-3.3.3.tar.bz2 has stalled (no progress at all). I guess this means the target can't connect to the internet?
1602017-02-21T09:25:29 <fanquake> Don't you have to clone the repositories first?
1612017-02-21T09:25:47 *** Squidicc has quit IRC
1622017-02-21T09:30:35 <jonasschnelli> fanquake. I think the nat is not working correctly..
1632017-02-21T09:31:43 *** harrymm has quit IRC
1642017-02-21T09:37:17 *** moli_ has quit IRC
1652017-02-21T09:39:31 *** moli_ has joined #bitcoin-core-dev
1662017-02-21T09:42:13 *** aalex has joined #bitcoin-core-dev
1672017-02-21T09:46:01 <jonasschnelli> Can I somehow start the LXC container manually and execute commands in the container? lxc-ls returns an empy list
1682017-02-21T09:46:17 *** harrymm has joined #bitcoin-core-dev
1692017-02-21T09:46:53 <luke-jr> lxc-execute? :p
1702017-02-21T09:47:22 <jonasschnelli> luke-jr: lxc-execute: missing container name? And lxc-ls doesn't show any container...
1712017-02-21T09:52:47 *** harrymm has quit IRC
1722017-02-21T09:59:03 <jonasschnelli> Found it out. LXC_ARCH=amd64 LXC_SUITE=trusty on-target -u root ping 8.8.8.8
1732017-02-21T10:06:51 *** harrymm has joined #bitcoin-core-dev
1742017-02-21T10:08:08 *** jannes has joined #bitcoin-core-dev
1752017-02-21T10:08:32 <jonasschnelli> Ping to the inet from within the lxc container now worked after re-setting up the bridge with 10.0.2.2 (instead of 10.0.3.2)
1762017-02-21T10:09:42 *** AaronvanW has joined #bitcoin-core-dev
1772017-02-21T10:16:59 *** aalex has quit IRC
1782017-02-21T10:17:20 <jonasschnelli> hm... dns resolving does not work in the LXC container. That's the issue.
1792017-02-21T10:17:28 *** _mn3monic has quit IRC
1802017-02-21T10:39:07 <jonasschnelli> Ah. I think there is a dnsmasq conflict with the bitcoin dns-seeder
1812017-02-21T10:46:03 *** lclc_ has joined #bitcoin-core-dev
1822017-02-21T10:46:52 *** lclc has quit IRC
1832017-02-21T10:56:54 *** undo12 has joined #bitcoin-core-dev
1842017-02-21T10:58:39 *** undo12 has left #bitcoin-core-dev
1852017-02-21T11:05:52 *** lclc_ has quit IRC
1862017-02-21T11:06:39 *** fanquake has quit IRC
1872017-02-21T11:22:52 <wumpus> yes AFAIK it uses the host as DNS server
1882017-02-21T11:28:16 *** chjj has quit IRC
1892017-02-21T11:28:53 <wumpus> it should be possible to make the client use a different DNS server
1902017-02-21T11:29:24 <wumpus> though you could avoid this with https://github.com/bitcoin/bitcoin/blob/master/doc/gitian-building.md#building-fully-offline
1912017-02-21T11:34:54 <wumpus> in principle the guest doesn't need a network connection to anything but the host
1922017-02-21T11:34:57 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7639d38f14b1...7d46b3ea8d6c
1932017-02-21T11:34:58 <bitcoin-git> bitcoin/master 171fc91 Pavel JanÃk: Read/write mempool.dat as a binary....
1942017-02-21T11:34:58 <bitcoin-git> bitcoin/master 7d46b3e Wladimir J. van der Laan: Merge #9813: Read/write mempool.dat as a binary....
1952017-02-21T11:35:20 <bitcoin-git> [bitcoin] laanwj closed pull request #9813: Read/write mempool.dat as a binary. (master...20170220_mempool_binary) https://github.com/bitcoin/bitcoin/pull/9813
1962017-02-21T11:36:05 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/3972a8efb2f8fd727ca045dcf89104c9f8a2f846
1972017-02-21T11:36:05 <bitcoin-git> bitcoin/0.14 3972a8e Pavel JanÃk: Read/write mempool.dat as a binary....
1982017-02-21T11:57:26 *** fanquake has joined #bitcoin-core-dev
1992017-02-21T12:03:22 *** lclc has joined #bitcoin-core-dev
2002017-02-21T12:17:10 *** paveljanik has joined #bitcoin-core-dev
2012017-02-21T12:17:14 <fanquake> #9464 has been labelled low-priority, but I'm wondering if this is actually something we want to fix for 0.14.0 ?
2022017-02-21T12:17:16 <gribble> https://github.com/bitcoin/bitcoin/issues/9464 | [GUI] "Number of blocks left" never updates when running with -reindex-chainstate · Issue #9464 · bitcoin/bitcoin · GitHub
2032017-02-21T12:17:46 <fanquake> You get a similar problem was running with âreindex, in that number of blocks is unknown, but both progress increase and estimated time left are both "calculating".
2042017-02-21T12:18:06 <fanquake> So you basically get no gui output expect for the progress bar, and when you hover over it.
2052017-02-21T12:19:11 <fanquake> Even the debug window doesn't update with progress.
2062017-02-21T12:19:34 <fanquake> Seems less than ideal, and user forced to reindex will have no idea of progress, or how long it's going to take.
2072017-02-21T12:19:42 <fanquake> *any
2082017-02-21T12:20:20 <wumpus> if it's another lock contention issue it's less than trivial to solve
2092017-02-21T12:20:35 <wumpus> so I would prefer not to hold up 0.14.0 for that, no
2102017-02-21T12:21:18 <fanquake> Something for 0.14.1 then? I'm sure the complaints of "reindexing with no progress output!" "How long is it going to take!" will roll in.
2112017-02-21T12:21:22 <wumpus> but if someone comes up with a solution it could be backported to 0.14
2122017-02-21T12:21:30 <wumpus> sure
2132017-02-21T12:22:13 <fanquake> I'll update the above issue with some more info, and create a 0.14.1 milestone.
2142017-02-21T12:22:16 <wumpus> it'd nice to not have the problem, but reindexing GUI output just isn't critical, in the way that say a crash is
2152017-02-21T12:22:24 * luke-jr stabs QTableView for not letting him resize the freaking columns
2162017-02-21T12:22:40 <wumpus> luke-jr: you should be able to resize the columns?
2172017-02-21T12:22:53 <luke-jr> wumpus: tried 3 or 4 different ways, none seem to work :/
2182017-02-21T12:23:08 <wumpus> luke-jr: we resize tables in various parts of the source, don't know by heart how though
2192017-02-21T12:23:22 <luke-jr> yeah, I must be missing something stupid
2202017-02-21T12:23:23 <wumpus> the most tricky thing is not the resizing itself
2212017-02-21T12:23:28 <luke-jr> ?
2222017-02-21T12:23:29 <wumpus> but *how large* to make the columns
2232017-02-21T12:23:42 <luke-jr> QFontMetrics::width?
2242017-02-21T12:23:46 <wumpus> font sizes can differ, high-dpi versus normal-dpi columns, and so on
2252017-02-21T12:24:00 <wumpus> yeah it's possible to get it right, just tricky
2262017-02-21T12:46:43 *** paveljanik has quit IRC
2272017-02-21T12:47:05 *** paveljanik has joined #bitcoin-core-dev
2282017-02-21T12:47:36 *** paveljanik has quit IRC
2292017-02-21T13:17:48 *** fanquake has quit IRC
2302017-02-21T13:20:50 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/ae1c4e24a6510b2ace819eccbb928a3cb0074daf
2312017-02-21T13:20:51 <bitcoin-git> bitcoin/0.14 ae1c4e2 Chris Moore: Fix typo in release notes.
2322017-02-21T13:22:47 <jonasschnelli> wumpus: thanks. I'll try to do use your offline building solution.
2332017-02-21T13:23:23 <bitcoin-git> [bitcoin] laanwj closed pull request #9803: Fix typo in release notes. (0.14...patch-5) https://github.com/bitcoin/bitcoin/pull/9803
2342017-02-21T13:25:35 *** Giszmo has joined #bitcoin-core-dev
2352017-02-21T13:27:04 *** goksinen_ has joined #bitcoin-core-dev
2362017-02-21T13:30:46 *** goksinen has quit IRC
2372017-02-21T13:33:21 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7d46b3ea8d6c...8ad31f9aa311
2382017-02-21T13:33:21 <bitcoin-git> bitcoin/master 40f11f8 kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer.
2392017-02-21T13:33:22 <bitcoin-git> bitcoin/master 8ad31f9 Wladimir J. van der Laan: Merge #9798: Fix Issue #9775 (Check returned value of fopen)...
2402017-02-21T13:33:40 <bitcoin-git> [bitcoin] laanwj closed pull request #9798: Fix Issue #9775 (Check returned value of fopen) (master...issue) https://github.com/bitcoin/bitcoin/pull/9798
2412017-02-21T13:34:12 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/e22c0671c74bc4db70b3ba04d093cd110f9f22a7
2422017-02-21T13:34:12 <bitcoin-git> bitcoin/0.14 e22c067 kirit93: Fix for issue #9775. Added check for open() returning a NULL pointer....
2432017-02-21T13:38:26 *** zyla has quit IRC
2442017-02-21T13:43:18 <bitcoin-git> [bitcoin] jonasschnelli opened pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (master...2017/02/sf_gui) https://github.com/bitcoin/bitcoin/pull/9817
2452017-02-21T13:47:22 *** Sosumi has joined #bitcoin-core-dev
2462017-02-21T13:51:35 *** _mn3monic has joined #bitcoin-core-dev
2472017-02-21T13:54:35 <jonasschnelli> wumpus: re your offline build mode in gitian: how does it can get the depends/packages in the offline mode?
2482017-02-21T13:55:30 <jonasschnelli> I still see "Fetching ccache-3.3.3.tar.bz2 from https://bitcoincore.org/depends-sources" in the build.log
2492017-02-21T13:56:28 <wumpus> jonasschnelli: the idea is that the cache is prepopulated
2502017-02-21T13:56:37 <wumpus> jonasschnelli: so that it won't try to download the tarballs
2512017-02-21T13:57:04 <jonasschnelli> wumpus: cd into the git bitcoin repository/depends and download all soucres?
2522017-02-21T13:58:04 <jonasschnelli> I think there is a "make download" (in the depends Makefile)
2532017-02-21T13:58:16 <wumpus> indeed, there is "make download"
2542017-02-21T13:59:30 <wumpus> you could also copy the directory from another build host, if you already have gitian-built before
2552017-02-21T13:59:55 <wumpus> I don't think the offline building section is very useful in that regard, it only talks about apt
2562017-02-21T14:00:27 <wumpus> which is the least issue as the host is used as apt-cache so that part never needs DNS lookups on the guest
2572017-02-21T14:00:58 *** ryanofsky has quit IRC
2582017-02-21T14:02:00 *** laurentmt has joined #bitcoin-core-dev
2592017-02-21T14:05:16 *** laurentmt has quit IRC
2602017-02-21T14:13:44 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8ad31f9aa311...8528d6ac6d51
2612017-02-21T14:13:45 <bitcoin-git> bitcoin/master 312c4f1 Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode
2622017-02-21T14:13:45 <bitcoin-git> bitcoin/master 8528d6a Wladimir J. van der Laan: Merge #9817: Fix segfault crash when shutdown the GUI in disablewallet mode...
2632017-02-21T14:14:07 <bitcoin-git> [bitcoin] laanwj closed pull request #9817: Fix segfault crash when shutdown the GUI in disablewallet mode (master...2017/02/sf_gui) https://github.com/bitcoin/bitcoin/pull/9817
2642017-02-21T14:16:02 <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/7d75a5a93c161aa4de22ac862702ba0241e8faa2
2652017-02-21T14:16:02 <bitcoin-git> bitcoin/0.14 7d75a5a Jonas Schnelli: Fix segfault crash when shutdown the GUI in disablewallet mode...
2662017-02-21T14:32:52 *** ryanofsky has joined #bitcoin-core-dev
2672017-02-21T14:33:01 *** jnewbery_ has joined #bitcoin-core-dev
2682017-02-21T14:44:14 *** ryanofsky has quit IRC
2692017-02-21T14:44:22 *** ryanofsky has joined #bitcoin-core-dev
2702017-02-21T14:54:44 *** aalex has joined #bitcoin-core-dev
2712017-02-21T14:58:17 *** lclc has quit IRC
2722017-02-21T15:17:16 *** Kexkey has joined #bitcoin-core-dev
2732017-02-21T15:31:24 *** moli_ has quit IRC
2742017-02-21T15:33:53 *** moli_ has joined #bitcoin-core-dev
2752017-02-21T15:34:42 *** aalex has quit IRC
2762017-02-21T16:00:25 *** jnewbery1 has joined #bitcoin-core-dev
2772017-02-21T16:02:12 *** jnewbery has quit IRC
2782017-02-21T16:02:12 *** jnewbery1 is now known as jnewbery
2792017-02-21T16:02:59 *** Kexkey has quit IRC
2802017-02-21T16:08:57 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8528d6ac6d51...5f0556d0326b
2812017-02-21T16:08:57 <bitcoin-git> bitcoin/master 056aba2 Wladimir J. van der Laan: Remove fallbacks for boost_filesystem < v3...
2822017-02-21T16:08:58 <bitcoin-git> bitcoin/master 5f0556d Wladimir J. van der Laan: Merge #9727: Remove fallbacks for boost_filesystem < v3...
2832017-02-21T16:09:20 <bitcoin-git> [bitcoin] laanwj closed pull request #9727: Remove fallbacks for boost_filesystem < v3 (master...2017_02_boostfs_flailbacks) https://github.com/bitcoin/bitcoin/pull/9727
2842017-02-21T16:11:09 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9818: Save watch only key timestamps when reimporting keys (master...pr/multirewatch) https://github.com/bitcoin/bitcoin/pull/9818
2852017-02-21T16:16:00 <bitcoin-git> [bitcoin] morcos opened pull request #9819: Remove harmless read of unusued priority estimates (master...removeExtraRead) https://github.com/bitcoin/bitcoin/pull/9819
2862017-02-21T16:38:38 *** mol has joined #bitcoin-core-dev
2872017-02-21T16:39:32 *** moli_ has quit IRC
2882017-02-21T16:40:14 *** mol has quit IRC
2892017-02-21T16:40:57 *** mol has joined #bitcoin-core-dev
2902017-02-21T16:51:19 *** abpa has joined #bitcoin-core-dev
2912017-02-21T16:51:45 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5f0556d0326b...61a640ea9741
2922017-02-21T16:51:46 <bitcoin-git> bitcoin/master 5ea5368 Bob McElrath: ZMQ example using python3 and asyncio
2932017-02-21T16:51:46 <bitcoin-git> bitcoin/master 5406d51 Bob McElrath: Rewrite to not use Polling wrapper for asyncio, link to python2.7 example
2942017-02-21T16:51:47 <bitcoin-git> bitcoin/master 4bb7d1b Bob McElrath: Add python version checks and 3.4 example
2952017-02-21T16:51:57 <bitcoin-git> [bitcoin] laanwj closed pull request #9485: ZMQ example using python3 and asyncio (master...python3zmq) https://github.com/bitcoin/bitcoin/pull/9485
2962017-02-21T16:52:52 <morcos> Just a heads up that pruning.py is broken in 0.14 and master, cause seems to be the 2 hour buffer added in #9778. I think ryanofsky is working on a fix.
2972017-02-21T16:52:54 <gribble> https://github.com/bitcoin/bitcoin/issues/9778 | Add two hour buffer to manual pruning by morcos · Pull Request #9778 · bitcoin/bitcoin · GitHub
2982017-02-21T16:54:27 *** instagibbs has quit IRC
2992017-02-21T16:59:02 *** instagibbs has joined #bitcoin-core-dev
3002017-02-21T17:00:33 *** chjj has joined #bitcoin-core-dev
3012017-02-21T17:31:14 *** Squidicuz has quit IRC
3022017-02-21T17:35:42 *** arowser has quit IRC
3032017-02-21T17:37:07 *** arowser has joined #bitcoin-core-dev
3042017-02-21T17:37:53 *** Squidicuz has joined #bitcoin-core-dev
3052017-02-21T17:41:42 *** Giszmo has quit IRC
3062017-02-21T17:48:54 *** Giszmo has joined #bitcoin-core-dev
3072017-02-21T17:54:59 *** Giszmo has quit IRC
3082017-02-21T18:02:25 <bitcoin-git> [bitcoin] ryanofsky opened pull request #9820: Fix pruning test broken by 2 hour manual prune window (master...pr/prunewind) https://github.com/bitcoin/bitcoin/pull/9820
3092017-02-21T18:02:34 *** Giszmo has joined #bitcoin-core-dev
3102017-02-21T18:04:07 *** Giszmo1 has joined #bitcoin-core-dev
3112017-02-21T18:06:57 *** Giszmo has quit IRC
3122017-02-21T18:11:56 *** Giszmo1 has quit IRC
3132017-02-21T18:14:11 *** paveljanik has joined #bitcoin-core-dev
3142017-02-21T18:15:43 *** BashCo has quit IRC
3152017-02-21T18:25:40 *** Giszmo has joined #bitcoin-core-dev
3162017-02-21T18:26:44 <morcos> Question re fee estimation improvements. We have two rpc calls now. estimatefee and estimatesmartfee. I'd like to improve estimatesmartfee to be even "more smarter" and perhaps return more data to you about how it arrived at its estimates.
3172017-02-21T18:27:18 <morcos> And I'd like to turn estimatefee into more of a raw call that allows you to generate your own smart estimation through repeated calls to estimatefee with various parameters
3182017-02-21T18:29:24 <morcos> but that would imply re-enabling estimates for a target of 1 in the estimatefee call. does anyone think that's necessarily an issue. seems a bit odd to disable for a release and then reenable, but it becomes more of a raw utility, it makes sense to not constrain it
3192017-02-21T18:30:03 <morcos> does this make sense as a way forward for improving and extending fee estimation?
3202017-02-21T18:30:55 <morcos> or would it perhaps make sense to make a new rpc call for low level functionality that is even more raw and could give you direct acess to the saved data?
3212017-02-21T18:32:27 <ryanofsky> imo, disabling and reenabling is nicer than disabling and then adding a new rpc to do what the disabled thing did
3222017-02-21T18:46:53 <gmaxwell> funny, I was going to say the opposite!
3232017-02-21T18:47:01 <gmaxwell> the purpose of it is changing, so perhaps it should have a new name. "feeestimationdata"
3242017-02-21T18:50:18 <ryanofsky> yeah, it's a tradeoff. personally when i am a user of an api, i just want it to be as straightforward as possible what the various options in the api do, and what the behavioral differences are
3252017-02-21T18:50:46 *** BashCo has joined #bitcoin-core-dev
3262017-02-21T18:50:56 <ryanofsky> i care a lot more about the actual behavior of the api, than whatever the intended "purpose" of the api was when it was developed
3272017-02-21T18:54:57 <morcos> after some discussion i'm leaning towards this: adding a new hidden rpc call estimaterawfee that allows raw access to the model data. It can be useful for debugging people with fee estimate problems or for super advanced users that want to implement their own smartness
3282017-02-21T18:55:13 <morcos> estimatefee itself will continue as is to hopefully eventually be deprecated
3292017-02-21T18:55:35 *** molz_ has joined #bitcoin-core-dev
3302017-02-21T18:56:04 <morcos> and most people will use estimatesmartfee which may return more information to help people who want to read more than one number understand the tradeoffs.. but is more user friendly and doesn't take a whole lot of parameters, just how quickly you want the damn tx confirmed
3312017-02-21T18:58:43 *** mol has quit IRC
3322017-02-21T18:59:27 *** Giszmo has quit IRC
3332017-02-21T19:01:03 *** Guyver2 has joined #bitcoin-core-dev
3342017-02-21T19:02:54 *** Guyver2_ has joined #bitcoin-core-dev
3352017-02-21T19:04:55 *** Guyver2 has quit IRC
3362017-02-21T19:05:00 *** Guyver2_ is now known as Guyver2
3372017-02-21T19:10:58 *** whphhg has quit IRC
3382017-02-21T19:28:17 *** whphhg has joined #bitcoin-core-dev
3392017-02-21T19:42:56 *** davec has quit IRC
3402017-02-21T19:44:28 *** davec has joined #bitcoin-core-dev
3412017-02-21T19:56:30 *** Giszmo has joined #bitcoin-core-dev
3422017-02-21T20:01:23 *** Giszmo has quit IRC
3432017-02-21T20:01:38 *** Giszmo has joined #bitcoin-core-dev
3442017-02-21T20:04:24 *** Giszmo1 has joined #bitcoin-core-dev
3452017-02-21T20:06:14 *** Giszmo has quit IRC
3462017-02-21T20:07:23 *** Giszmo has joined #bitcoin-core-dev
3472017-02-21T20:07:57 <bitcoin-git> [bitcoin] laanwj opened pull request #9821: util: Specific GetOSRandom for Linux/FreeBSD/OpenBSD (master...2017_02_osrandom) https://github.com/bitcoin/bitcoin/pull/9821
3482017-02-21T20:10:18 *** mol has joined #bitcoin-core-dev
3492017-02-21T20:10:19 *** Giszmo1 has quit IRC
3502017-02-21T20:11:44 *** mol has quit IRC
3512017-02-21T20:12:12 *** mol has joined #bitcoin-core-dev
3522017-02-21T20:12:20 *** molz_ has quit IRC
3532017-02-21T20:50:28 *** moli_ has joined #bitcoin-core-dev
3542017-02-21T20:52:00 *** mol has quit IRC
3552017-02-21T20:53:15 *** mol has joined #bitcoin-core-dev
3562017-02-21T20:56:17 *** Sosumi has quit IRC
3572017-02-21T20:56:27 *** moli_ has quit IRC
3582017-02-21T20:58:25 *** Giszmo has quit IRC
3592017-02-21T21:15:00 *** Giszmo has joined #bitcoin-core-dev
3602017-02-21T21:16:31 *** Guyver2_ has joined #bitcoin-core-dev
3612017-02-21T21:20:19 *** Guyver2 has quit IRC
3622017-02-21T21:20:24 *** Guyver2_ is now known as Guyver2
3632017-02-21T21:24:22 *** Guyver2_ has joined #bitcoin-core-dev
3642017-02-21T21:25:34 *** Guyver2 has quit IRC
3652017-02-21T21:25:39 *** Guyver2_ is now known as Guyver2
3662017-02-21T22:03:44 *** Lauda has quit IRC
3672017-02-21T22:04:04 *** Giszmo has quit IRC
3682017-02-21T22:14:39 *** jannes has quit IRC
3692017-02-21T22:18:10 *** Giszmo has joined #bitcoin-core-dev
3702017-02-21T22:22:04 *** bsm117532 has quit IRC
3712017-02-21T22:28:57 *** bsm117532 has joined #bitcoin-core-dev
3722017-02-21T22:35:20 *** Creeper is now known as slimeball
3732017-02-21T23:02:13 *** jtimon has joined #bitcoin-core-dev
3742017-02-21T23:03:16 <jtimon> post-0.14-fork review begging https://github.com/bitcoin/bitcoin/pull/8855
3752017-02-21T23:03:21 <jtimon> also #8994
3762017-02-21T23:03:23 <gribble> https://github.com/bitcoin/bitcoin/issues/8994 | Testchains: Introduce custom chain whose constructor... by jtimon · Pull Request #8994 · bitcoin/bitcoin · GitHub
3772017-02-21T23:06:22 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/61a640ea9741...5628c70f2a44
3782017-02-21T23:06:23 <bitcoin-git> bitcoin/master 41e7219 fanquake: [trivial] Add tests_config.ini to .gitignore
3792017-02-21T23:06:23 <bitcoin-git> bitcoin/master 851f6a3 fanquake: [qa][doc] Correct rpc test options in readme
3802017-02-21T23:06:24 <bitcoin-git> bitcoin/master 5628c70 MarcoFalke: Merge #9807: RPC doc fix-ups....
3812017-02-21T23:06:45 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #9807: RPC doc fix-ups. (master...rpc-test-trivial-fixups) https://github.com/bitcoin/bitcoin/pull/9807
3822017-02-21T23:26:27 *** jtimon has quit IRC
3832017-02-21T23:29:38 *** belcher has quit IRC
3842017-02-21T23:30:14 *** JackH has quit IRC
3852017-02-21T23:33:05 *** jtimon has joined #bitcoin-core-dev
3862017-02-21T23:37:24 *** Guyver2 has quit IRC
3872017-02-21T23:41:55 *** belcher has joined #bitcoin-core-dev