1 2017-03-27T00:12:08  *** vicenteH has quit IRC
  2 2017-03-27T00:12:28  *** chjj has quit IRC
  3 2017-03-27T00:30:12  *** chjj has joined #bitcoin-core-dev
  4 2017-03-27T00:44:07  *** Ylbam has quit IRC
  5 2017-03-27T00:51:11  *** voyager_ has quit IRC
  6 2017-03-27T00:51:44  *** voyager_ has joined #bitcoin-core-dev
  7 2017-03-27T00:55:38  *** jtimon has quit IRC
  8 2017-03-27T01:15:26  <phantomcircuit> is there an rpc that returns the distribution of fees in the mempool?
  9 2017-03-27T01:15:55  <gmaxwell> phantomcircuit: "getblocktemplate" :P
 10 2017-03-27T01:16:44  <phantomcircuit> gmaxwell, thanks -_-
 11 2017-03-27T01:36:27  *** str4d has joined #bitcoin-core-dev
 12 2017-03-27T01:40:28  *** harrymm has quit IRC
 13 2017-03-27T01:48:58  *** str4d has quit IRC
 14 2017-03-27T01:52:11  *** str4d has joined #bitcoin-core-dev
 15 2017-03-27T02:06:28  *** chjj has quit IRC
 16 2017-03-27T02:13:25  *** Giszmo has quit IRC
 17 2017-03-27T02:13:45  *** chjj has joined #bitcoin-core-dev
 18 2017-03-27T02:17:00  *** gotojyh has joined #bitcoin-core-dev
 19 2017-03-27T02:32:34  *** CubicEarth_ has joined #bitcoin-core-dev
 20 2017-03-27T02:45:08  *** chjj has quit IRC
 21 2017-03-27T02:51:07  *** dodomojo has joined #bitcoin-core-dev
 22 2017-03-27T02:52:42  *** dodomojo_ has joined #bitcoin-core-dev
 23 2017-03-27T02:56:18  *** dodomojo has quit IRC
 24 2017-03-27T03:06:05  *** Victor_sueca has joined #bitcoin-core-dev
 25 2017-03-27T03:08:28  *** Victorsueca has quit IRC
 26 2017-03-27T03:25:31  *** arubi has quit IRC
 27 2017-03-27T03:37:34  *** midnightmagic has quit IRC
 28 2017-03-27T03:49:34  *** dodomojo_ has quit IRC
 29 2017-03-27T03:50:15  *** gotojyh has quit IRC
 30 2017-03-27T03:59:03  *** chris200_ has joined #bitcoin-core-dev
 31 2017-03-27T04:01:28  *** chris2000 has quit IRC
 32 2017-03-27T04:01:52  *** midnightmagic has joined #bitcoin-core-dev
 33 2017-03-27T04:04:17  *** n1ce_ has quit IRC
 34 2017-03-27T04:08:34  *** chjj has joined #bitcoin-core-dev
 35 2017-03-27T04:13:37  *** dodomojo has joined #bitcoin-core-dev
 36 2017-03-27T04:27:35  *** JackH has quit IRC
 37 2017-03-27T04:39:41  *** Victor_sueca has quit IRC
 38 2017-03-27T04:41:04  *** Victor_sueca has joined #bitcoin-core-dev
 39 2017-03-27T04:41:55  *** mol has joined #bitcoin-core-dev
 40 2017-03-27T04:45:35  *** moli_ has quit IRC
 41 2017-03-27T04:48:12  *** arubi has joined #bitcoin-core-dev
 42 2017-03-27T04:57:59  *** CubicEarth_ has quit IRC
 43 2017-03-27T05:14:56  *** dodomojo has quit IRC
 44 2017-03-27T05:35:23  <bitcoin-git> [bitcoin] 1Hyena opened pull request #10092: Update consensus.h (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10092
 45 2017-03-27T05:37:46  <rabidus> :(
 46 2017-03-27T05:42:00  <bitcoin-git> [bitcoin] sipa closed pull request #10092: Update consensus.h (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10092
 47 2017-03-27T05:45:55  *** QBcrusher_ has joined #bitcoin-core-dev
 48 2017-03-27T05:49:21  *** QBcrusher has quit IRC
 49 2017-03-27T05:49:29  *** Ylbam has joined #bitcoin-core-dev
 50 2017-03-27T05:50:19  *** QBcrusher_ is now known as QBcrusher
 51 2017-03-27T06:07:42  *** dodomojo has joined #bitcoin-core-dev
 52 2017-03-27T06:12:25  *** dodomojo has quit IRC
 53 2017-03-27T06:33:08  *** cannon-c has joined #bitcoin-core-dev
 54 2017-03-27T06:38:05  *** chris200_ has quit IRC
 55 2017-03-27T06:38:32  *** chris2000 has joined #bitcoin-core-dev
 56 2017-03-27T06:41:31  *** waxwing__ is now known as waxwing
 57 2017-03-27T06:46:56  *** BashCo has quit IRC
 58 2017-03-27T07:02:08  *** dodomojo has joined #bitcoin-core-dev
 59 2017-03-27T07:06:48  *** dodomojo has quit IRC
 60 2017-03-27T07:06:50  *** CubicEarthh has joined #bitcoin-core-dev
 61 2017-03-27T07:06:58  *** BashCo has joined #bitcoin-core-dev
 62 2017-03-27T07:14:50  <wumpus> jonasschnelli: yes, I'd also say remove support for qt4. But apparently luke-jr and BlueMatt are still using that
 63 2017-03-27T07:15:19  <jonasschnelli> wumpus: Yes. I just re-read the Qt4 EOL issue...
 64 2017-03-27T07:15:42  <jonasschnelli> Maybe keep it for now... at least we should fix the compiling issue.
 65 2017-03-27T07:15:46  <wumpus> it's kind of annoying, but that's what you get with 'big step' API changes, the old version will virtually stay around forever
 66 2017-03-27T07:15:49  <wumpus> same with python2/3
 67 2017-03-27T07:15:55  <jonasschnelli> Yeah.
 68 2017-03-27T07:16:07  <wumpus> though qt4->qt5 is nowhere as much work as py2->3
 69 2017-03-27T07:16:13  <jonasschnelli> Adding qt4 compilation over travis seems to be not worth it... I guess?
 70 2017-03-27T07:16:20  <wumpus> I'd prefer not to
 71 2017-03-27T07:16:39  <jonasschnelli> Okay. Lets fix then the compilation issue whenever someone reports them.
 72 2017-03-27T07:16:58  <luke-jr> wumpus: and we don't need to support Py2 because Py3 is everywhere and works as well
 73 2017-03-27T07:17:13  <wumpus> I'd prefer some timeframe for dropping qt4, but should be announced upfront
 74 2017-03-27T07:17:20  <luke-jr> jonasschnelli: I already added Qt4 to Travis a while ago, and was under the impression we had a daily (not every PR) running it
 75 2017-03-27T07:18:00  <luke-jr> it's funny how Qt5 is more compatible with GTK2 than it is with Qt4
 76 2017-03-27T07:18:13  <wumpus> ironically qt3->qt4 was a bigger step, and people ported software over quicker
 77 2017-03-27T07:18:13  *** Victor_sueca has quit IRC
 78 2017-03-27T07:18:22  <luke-jr> they did? O.o
 79 2017-03-27T07:18:28  <luke-jr> IIRC KDE 4 took a looong time
 80 2017-03-27T07:18:54  <luke-jr> and even today, KMail isn't up to par with the Qt3 version
 81 2017-03-27T07:18:56  <wumpus> how I remember things they did, almost every project saw the need of supporting qt4 immediately, and it was very hard to support both 3 and 4 so 3 was pretty quickly dropped
 82 2017-03-27T07:19:22  *** Victor_sueca has joined #bitcoin-core-dev
 83 2017-03-27T07:19:22  <wumpus> qt5 on the other hand, maybe because it's releatiively easy to suport both 4 and 5, takes longer
 84 2017-03-27T07:19:36  <wumpus> but it's just anecdotal I don't have numbers to back it up
 85 2017-03-27T07:20:09  <wumpus> qt5 does have some nice new features the thing is we don't really need them, at least not for the essential features
 86 2017-03-27T07:20:36  <luke-jr> you mean dropping the old vs supporting the new, then?
 87 2017-03-27T07:20:52  <wumpus> I gues
 88 2017-03-27T07:21:10  *** BashCo_ has joined #bitcoin-core-dev
 89 2017-03-27T07:21:25  <luke-jr> IMO old should only be dropped when it becomes a burden; so Qt4->Qt5 being minimal delays that because the burden is somewhat low
 90 2017-03-27T07:21:28  <wumpus> yes I mean qt3 was dead sooner than qt4
 91 2017-03-27T07:21:53  <wumpus> I'm fine with supporting qt4 as long as some of us compile with that and use it
 92 2017-03-27T07:22:15  <wumpus> if not it means it goes largely untested
 93 2017-03-27T07:22:54  <wumpus> in any case i'm not worried about a "doesn't compile with qt4" issue once in half a year which usually gets promptly fixed
 94 2017-03-27T07:23:07  <wumpus> I'm much more worried about the wshadow diff noise
 95 2017-03-27T07:23:37  *** arubi has quit IRC
 96 2017-03-27T07:24:00  *** arubi has joined #bitcoin-core-dev
 97 2017-03-27T07:24:05  <wumpus> that's more work to support than qt4
 98 2017-03-27T07:24:41  *** BashCo has quit IRC
 99 2017-03-27T07:25:07  <jonasschnelli> wumpus: wshadow: you mean because of your statement: "There's a large chance that one of the 'fixes' for WShadow, which seem to trail any larger change in the source code, introduce a bug."?
100 2017-03-27T07:25:15  <wumpus> jonasschnelli: yes
101 2017-03-27T07:25:17  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/111849345bb5...c044f03f99ba
102 2017-03-27T07:25:17  <bitcoin-git> bitcoin/master dd5be2c NicolasDorier: [QA] Renaming rawTx into rawtx
103 2017-03-27T07:25:18  <bitcoin-git> bitcoin/master c044f03 Wladimir J. van der Laan: Merge #10083: [QA] Renaming rawTx into rawtx...
104 2017-03-27T07:25:36  <wumpus> jonasschnelli: every single variable in the source code seems to be in progress of being renamed
105 2017-03-27T07:25:38  <jonasschnelli> Can we disable WShadow for the QT part?
106 2017-03-27T07:25:42  <bitcoin-git> [bitcoin] laanwj closed pull request #10083: [QA] Renaming rawTx into rawtx (master...fundrawtransactionfix) https://github.com/bitcoin/bitcoin/pull/10083
107 2017-03-27T07:25:55  <wumpus> I think we should disable wsshadow, full stop
108 2017-03-27T07:26:04  <wumpus> but I'm starting to sound like a broken record on that
109 2017-03-27T07:26:30  <jonasschnelli> heh... I have no strong opinion on that.
110 2017-03-27T07:26:39  <jonasschnelli> But the warnings are definitively annoying.
111 2017-03-27T07:26:41  <wumpus> it was just a mistake to enable it, and that's only been confirmed
112 2017-03-27T07:26:53  <jonasschnelli> Yes. It seems like.
113 2017-03-27T07:27:07  <jonasschnelli> What's the benefits of enabling it? IMO compilers handle it pretty well,... right?
114 2017-03-27T07:27:07  <wumpus> and yes, some of the annoyance may go away when disabling it for certain compilers, or parts of the code base
115 2017-03-27T07:27:50  <wumpus> compilers handle it fine, it's people that sometimes do not. We had one bug that was hidden by shadowing
116 2017-03-27T07:28:03  <wumpus> I don't think this whole operation has found any other
117 2017-03-27T07:28:16  <jonasschnelli> I see...
118 2017-03-27T07:28:55  <wumpus> #8102 is the bug that set it all in motion
119 2017-03-27T07:28:57  <gribble> https://github.com/bitcoin/bitcoin/issues/8102 | Bugfix: use global ::fRelayTxes instead of CNode in version send by sipa · Pull Request #8102 · bitcoin/bitcoin · GitHub
120 2017-03-27T07:32:43  *** arubi has quit IRC
121 2017-03-27T07:33:25  *** CubicEarthh has quit IRC
122 2017-03-27T07:35:22  *** CubicEarthh has joined #bitcoin-core-dev
123 2017-03-27T07:35:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c044f03f99ba...db1ae5470bab
124 2017-03-27T07:35:25  <bitcoin-git> bitcoin/master d5690f1 Jameson Lopp: remove 'noconnect' option from documentation
125 2017-03-27T07:35:26  <bitcoin-git> bitcoin/master db1ae54 Wladimir J. van der Laan: Merge #10085: Docs: remove 'noconnect' option...
126 2017-03-27T07:35:46  <bitcoin-git> [bitcoin] laanwj closed pull request #10085: Docs: remove 'noconnect' option (master...noconnect) https://github.com/bitcoin/bitcoin/pull/10085
127 2017-03-27T07:38:59  *** Victor_sueca is now known as Victorsueca
128 2017-03-27T07:42:37  *** CubicEar_ has joined #bitcoin-core-dev
129 2017-03-27T07:43:48  *** CubicEarthh has quit IRC
130 2017-03-27T07:46:11  *** CubicEarthh has joined #bitcoin-core-dev
131 2017-03-27T07:48:01  *** CubicEar_ has quit IRC
132 2017-03-27T07:51:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db1ae5470bab...b1a4f2757695
133 2017-03-27T07:51:03  <bitcoin-git> bitcoin/master 717ad13 John Newbery: Actually run assumevalid.py....
134 2017-03-27T07:51:03  <bitcoin-git> bitcoin/master b1a4f27 Wladimir J. van der Laan: Merge #10073: Actually run assumevalid.py...
135 2017-03-27T07:51:18  *** bambum has joined #bitcoin-core-dev
136 2017-03-27T07:51:27  <bitcoin-git> [bitcoin] laanwj closed pull request #10073: Actually run assumevalid.py (master...improveassumevalid) https://github.com/bitcoin/bitcoin/pull/10073
137 2017-03-27T07:51:30  <bambum> hi
138 2017-03-27T07:54:19  <bambum> last time I was told core dont want to decide about what people want to run, but some commits being closed and locked after 4 minutes about block site increase should be at least commented why they are closed and locked https://github.com/bitcoin/bitcoin/pull/10092
139 2017-03-27T07:54:50  <bambum> otherwise ppl talking about it all over the place: https://bitcointalk.org/index.php?topic=1842146.220
140 2017-03-27T07:55:52  <bambum> so someone awake might answer be that question, thanks
141 2017-03-27T07:56:04  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b1a4f2757695...0ddea4430d62
142 2017-03-27T07:56:04  <bitcoin-git> bitcoin/master 4df76e2 Andrew Chow: Ensure an item exists on the rpcconsole stack before adding...
143 2017-03-27T07:56:05  <bitcoin-git> bitcoin/master 0ddea44 Jonas Schnelli: Merge #10060: [Qt] Ensure an item exists on the rpcconsole stack before adding...
144 2017-03-27T07:56:29  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10060: [Qt] Ensure an item exists on the rpcconsole stack before adding (master...fix-rpcconsole-empty-stack) https://github.com/bitcoin/bitcoin/pull/10060
145 2017-03-27T07:56:33  *** dodomojo has joined #bitcoin-core-dev
146 2017-03-27T07:56:59  *** jouke has quit IRC
147 2017-03-27T07:59:21  <gmaxwell> bambum: presumably because it was broken garbage-- would instantly break everything, didn't even pass the tests-- and submitted by someone who has made nasty comments in the past. No one is going to waste their time on trolling.
148 2017-03-27T07:59:55  <wumpus> bambum: because it is trolling
149 2017-03-27T08:00:07  <wumpus> he's not exactly the first to open a pull like that
150 2017-03-27T08:00:39  <wumpus> it's not funny, it's not constructive
151 2017-03-27T08:00:44  *** jouke has joined #bitcoin-core-dev
152 2017-03-27T08:00:55  *** dodomojo has quit IRC
153 2017-03-27T08:00:56  <wumpus> the only sensible reply is to block it and ignore it and continue on as normal
154 2017-03-27T08:01:34  <bambum> ok, but for better transparency it should be commented, just a copy past would be enough "trolling" is not specified. For someone like me it hard to know, I thought also it might not fit into some rules, but a clear comment why it is closed would be good
155 2017-03-27T08:01:36  <wumpus> also this is not about 'deciding about what people want to run' but concerns our project
156 2017-03-27T08:02:12  <wumpus> attacking our project with random PRs is only going to get you banned
157 2017-03-27T08:02:30  <wumpus> that's the end of this discussion. Please try to keep drama out of this channel.
158 2017-03-27T08:02:58  <bambum> there was nowhere drama in my questions, it was a fair question, you are over interpreting it
159 2017-03-27T08:03:08  <bambum> I wish more transparency
160 2017-03-27T08:03:18  <jonasschnelli> bambum: please...
161 2017-03-27T08:04:03  <wumpus> we are not obliged to give any motivation for closing issues, or giving you any extra information. Most of the people involved here are volunteers and their time they can spend on this project is very limited and better directed to useful purposes
162 2017-03-27T08:04:04  <jonasschnelli> You need to understand how tiresome such PRs are... it's like trowing a stones into gears.
163 2017-03-27T08:04:28  <jonasschnelli> s/a//
164 2017-03-27T08:04:31  <wumpus> jonasschnelli: yes, it's just tiring, drags on and on and on
165 2017-03-27T08:04:37  <wumpus> at some point you get annoyed and just close things
166 2017-03-27T08:04:43  <bambum> @jonasschnelli yes but how can I recognize it as someone not being involved in techs ?
167 2017-03-27T08:04:47  <gmaxwell> Any any comment left is just trolled against.
168 2017-03-27T08:05:07  <wumpus> bambum: again, this channel and github is for doing development
169 2017-03-27T08:05:20  <bambum> so you saying you can recognize its trolling just by seeing the code ?
170 2017-03-27T08:05:37  <bambum> @wumpus you dont understand the point
171 2017-03-27T08:05:41  <jonasschnelli> bambum: It's like changing the default port number from 80 to 13735 in apache... It's not serious.. everyone at bitcoin github level must understand this...
172 2017-03-27T08:05:47  <wumpus> bambum: maybe not, but you're starting to annoy me
173 2017-03-27T08:05:51  <bambum> I am talking about transparency, everyone should now what is happening
174 2017-03-27T08:05:55  <gmaxwell> bambum: sure, like the fact that it didn't even pass the selftests. it wasn't an actual proposal for anything.
175 2017-03-27T08:06:19  <bambum> know
176 2017-03-27T08:06:30  <jonasschnelli> bambum: It's clear what happend. Somebody started to throw a stone. It got rejected. Fullstop.
177 2017-03-27T08:06:30  <wumpus> bambum: this is the second time in a few days that you're monopolizing this channel with discussion about non-development things
178 2017-03-27T08:06:39  <jonasschnelli> Yes. Let's stop this here.
179 2017-03-27T08:06:45  <jonasschnelli> Move this on to #bitcoin if you like
180 2017-03-27T08:07:10  <wumpus> please mind the topic of this channel "This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin"
181 2017-03-27T08:08:00  <bambum> wumpus this was something what happend on the github website, last time i was here in the channel I was told that core dont want to influent peoples what do to, so I had a question about
182 2017-03-27T08:08:20  <wumpus> we don't influence 'peoples what to do' but we do influence our own project
183 2017-03-27T08:08:21  <bambum> I appreciate having the option to talk about it
184 2017-03-27T08:08:44  <bambum> and the only think i am requesting is more transparency
185 2017-03-27T08:09:26  <gmaxwell> bambum: request heard. now please stop repeating it.
186 2017-03-27T08:10:02  <gmaxwell> (and while you're at it, go look at the post history of the person making that PR, you'll find it quite informative)
187 2017-03-27T08:10:04  <bambum> jonasschnelli yes for me it was not so easy to understand it
188 2017-03-27T08:10:26  <bambum> I just had the idea that his code don´t fits into some rules
189 2017-03-27T08:10:53  <bambum> but needs to be commented imo, especially nowatimes
190 2017-03-27T08:11:05  <gmaxwell> K.
191 2017-03-27T08:20:06  *** chris2000 is now known as schnerchi
192 2017-03-27T08:21:51  *** riemann has joined #bitcoin-core-dev
193 2017-03-27T08:22:44  *** CubicEarthh has quit IRC
194 2017-03-27T08:23:22  <wumpus> jonasschnelli: at least github deleted the fake jonasschneli account
195 2017-03-27T08:23:48  <jonasschnelli> wumpus: heh. Yes. I reported it and ~48h later they deleted it.
196 2017-03-27T08:23:55  <jonasschnelli> Not superfast but still okay.
197 2017-03-27T08:24:06  *** CubicEarthh has joined #bitcoin-core-dev
198 2017-03-27T08:25:38  *** schnerchi is now known as chris20000
199 2017-03-27T08:25:41  *** chris20000 is now known as chris2000
200 2017-03-27T08:25:59  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10093: [Qt] Don't add arguments of sensitive command to console window (master...2017/03/qt_console) https://github.com/bitcoin/bitcoin/pull/10093
201 2017-03-27T08:26:40  *** chris2000 has quit IRC
202 2017-03-27T08:26:50  *** schnerchi has joined #bitcoin-core-dev
203 2017-03-27T08:27:44  *** jtimon has joined #bitcoin-core-dev
204 2017-03-27T08:27:49  *** schnerchi has quit IRC
205 2017-03-27T08:28:01  *** schnerchi has joined #bitcoin-core-dev
206 2017-03-27T08:29:09  <jonasschnelli> wumpus: did you assigned yourself intentionally for this PR https://github.com/bitcoin/bitcoin/pull/8694
207 2017-03-27T08:29:41  <wumpus> jonasschnelli: yes
208 2017-03-27T08:29:50  <jonasschnelli> Okay. Good to know...
209 2017-03-27T08:29:54  *** schnerchi has quit IRC
210 2017-03-27T08:30:03  *** schnerchi has joined #bitcoin-core-dev
211 2017-03-27T08:34:40  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0ddea4430d62...e6156a0aa329
212 2017-03-27T08:34:40  <bitcoin-git> bitcoin/master 5ba61f0 Karl-Johan Alm: [zmq] Call va_end() on va_start()ed args.
213 2017-03-27T08:34:41  <bitcoin-git> bitcoin/master e6156a0 Wladimir J. van der Laan: Merge #10056: [zmq] Call va_end() on va_start()ed args....
214 2017-03-27T08:35:00  <bitcoin-git> [bitcoin] laanwj closed pull request #10056: [zmq] Call va_end() on va_start()ed args. (master...fix-zmqpublishnotifier-va-end) https://github.com/bitcoin/bitcoin/pull/10056
215 2017-03-27T08:37:17  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e6156a0aa329...5114f8113627
216 2017-03-27T08:37:17  <bitcoin-git> bitcoin/master 81a3857 Thomas Snider: Deduplicated sigaction() boilerplate
217 2017-03-27T08:37:18  <bitcoin-git> bitcoin/master 5114f81 Wladimir J. van der Laan: Merge #10057: [init] Deduplicated sigaction() boilerplate...
218 2017-03-27T08:37:37  <bitcoin-git> [bitcoin] laanwj closed pull request #10057: [init] Deduplicated sigaction() boilerplate (master...tjps_dedupe_sigaction) https://github.com/bitcoin/bitcoin/pull/10057
219 2017-03-27T08:38:37  *** CubicEarthh has quit IRC
220 2017-03-27T08:40:21  *** CubicEarthh has joined #bitcoin-core-dev
221 2017-03-27T08:42:01  *** d9b4bef9 has quit IRC
222 2017-03-27T08:43:18  *** d9b4bef9 has joined #bitcoin-core-dev
223 2017-03-27T08:48:57  *** vicenteH has joined #bitcoin-core-dev
224 2017-03-27T08:49:39  *** schnerchi has joined #bitcoin-core-dev
225 2017-03-27T08:57:31  <schnerchi> .
226 2017-03-27T08:57:50  *** CubicEar_ has joined #bitcoin-core-dev
227 2017-03-27T08:57:53  *** CubicEarthh has quit IRC
228 2017-03-27T09:03:29  *** schnerchi123 has joined #bitcoin-core-dev
229 2017-03-27T09:04:05  *** jannes has joined #bitcoin-core-dev
230 2017-03-27T09:05:40  <bambum> @gmaxwell thanks for commenting the commit, imo it would be totally enough to list like "locked for -" or "banned for -" 1. Submitting broken code 2. Not passing self-tests 3. Breaking network .. next time. Even a bot can do this, if devs prefer to not comment themself the lock or the bann. Would save up some energy.
231 2017-03-27T09:06:11  *** schnerchi123 has quit IRC
232 2017-03-27T09:12:22  *** jtimon has quit IRC
233 2017-03-27T09:12:55  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #10094: 0.14: Clear release notes (0.14...Mf1703-014docClear) https://github.com/bitcoin/bitcoin/pull/10094
234 2017-03-27T09:21:36  *** BashCo has joined #bitcoin-core-dev
235 2017-03-27T09:21:48  *** _biO_ has quit IRC
236 2017-03-27T09:24:34  *** BashCo_ has quit IRC
237 2017-03-27T09:54:17  <bitcoin-git> [bitcoin] laanwj closed pull request #10094: 0.14: Clear release notes (0.14...Mf1703-014docClear) https://github.com/bitcoin/bitcoin/pull/10094
238 2017-03-27T09:54:39  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/ccb47bf83036...37bf0d5b381f
239 2017-03-27T09:54:40  <bitcoin-git> bitcoin/0.14 eeeeacd MarcoFalke: 0.14: Clear release notes
240 2017-03-27T09:54:41  <bitcoin-git> bitcoin/0.14 37bf0d5 Wladimir J. van der Laan: Merge #10094: 0.14: Clear release notes...
241 2017-03-27T10:04:38  *** Colten has quit IRC
242 2017-03-27T10:04:50  *** CubicEarthh has joined #bitcoin-core-dev
243 2017-03-27T10:06:58  *** harrymm has joined #bitcoin-core-dev
244 2017-03-27T10:07:25  *** CubicEar_ has quit IRC
245 2017-03-27T10:10:19  *** cannon-c has quit IRC
246 2017-03-27T10:14:35  *** shesek has quit IRC
247 2017-03-27T10:17:29  *** CubicEar_ has joined #bitcoin-core-dev
248 2017-03-27T10:17:57  *** CubicEarthh has quit IRC
249 2017-03-27T10:20:54  *** CubicEar_ has quit IRC
250 2017-03-27T10:38:45  *** idufohid has joined #bitcoin-core-dev
251 2017-03-27T10:51:05  *** jtimon has joined #bitcoin-core-dev
252 2017-03-27T11:21:16  *** CubicEarthh has joined #bitcoin-core-dev
253 2017-03-27T11:26:28  *** CubicEarthh has quit IRC
254 2017-03-27T11:32:34  *** str4d has quit IRC
255 2017-03-27T11:37:28  *** Naphex has quit IRC
256 2017-03-27T11:37:44  *** Naphex has joined #bitcoin-core-dev
257 2017-03-27T11:47:59  *** bambuma has joined #bitcoin-core-dev
258 2017-03-27T11:50:10  <jonasschnelli> wumpus: there is a travis issue with your #9902 (https://travis-ci.org/bitcoin/bitcoin/jobs/215449039#L2083)
259 2017-03-27T11:50:12  <gribble> https://github.com/bitcoin/bitcoin/issues/9902 | Lightweight abstraction of boost::filesystem by laanwj · Pull Request #9902 · bitcoin/bitcoin · GitHub
260 2017-03-27T11:51:04  *** bambum has quit IRC
261 2017-03-27T11:52:54  <wumpus> jonasschnelli: in the qt tests?! that's weird
262 2017-03-27T11:53:16  <wumpus> undefined reference to `vtable for boost::unit_test::unit_test_log_t'
263 2017-03-27T11:53:20  <wumpus> I don't get it
264 2017-03-27T11:53:30  <jonasschnelli> Yes. Strage error indeed. Maybe rebase?
265 2017-03-27T11:53:42  <wumpus> I just rebased it
266 2017-03-27T11:56:33  *** JackH has joined #bitcoin-core-dev
267 2017-03-27T11:57:58  *** laurentmt has joined #bitcoin-core-dev
268 2017-03-27T11:59:28  *** laurentmt has quit IRC
269 2017-03-27T12:01:33  *** harrymm has quit IRC
270 2017-03-27T12:17:52  *** harrymm has joined #bitcoin-core-dev
271 2017-03-27T12:22:22  <jonasschnelli> wumpus: https://github.com/bitcoin/bitcoin/pull/9902#issuecomment-289437353
272 2017-03-27T12:22:43  *** CubicEarthh has joined #bitcoin-core-dev
273 2017-03-27T12:24:27  <wumpus> jonasschnelli: thanks, makes sense
274 2017-03-27T12:25:01  <wumpus> seems unrelated to that pull though, I don't get why it starts failing there
275 2017-03-27T12:25:04  <wumpus> or why it works now
276 2017-03-27T12:25:14  <jonasschnelli> Yes. I wonder why it works now...
277 2017-03-27T12:27:16  *** CubicEarthh has quit IRC
278 2017-03-27T12:32:10  <bitcoin-git> [bitcoin] laanwj opened pull request #10095: refactor: Move GetDifficulty out of `rpc/server.h` (master...2017_03_getdifficulty_header) https://github.com/bitcoin/bitcoin/pull/10095
279 2017-03-27T12:33:40  <wumpus> jonasschnelli: we didn't use to use boost test framework in the qt tests
280 2017-03-27T12:34:00  <jonasschnelli> But your PR doesn't change that? Or does it?
281 2017-03-27T12:34:08  <wumpus> no, it doesn't do anything with that
282 2017-03-27T12:34:59  <wumpus> makes sense to PR that separately
283 2017-03-27T12:35:40  <wumpus> uhm, we're still not using boost::test in the qt tests, I don't understand why we'd need that library
284 2017-03-27T12:35:58  <jonasschnelli> Okay. I'll PR it.
285 2017-03-27T12:36:01  *** dcousens has quit IRC
286 2017-03-27T12:36:30  <wumpus> well let's try to find out why it's needed first, I'm not sure anymore, I thought we had a good reason, but there's no reference to boost test in the qt tests
287 2017-03-27T12:37:33  <wumpus> so that change should not be necessary :/
288 2017-03-27T12:38:16  <jonasschnelli> It's seems to be for the logging....
289 2017-03-27T12:39:50  <wumpus> the only three occurences of 'boost' or 'BOOST' in src/qt/test are: #include <boost/filesystem.hpp> boost::filesystem::remove_all  boost::signals2::scoped_connection
290 2017-03-27T12:40:11  <wumpus> boost is not used for logging nor evaluating test cases
291 2017-03-27T12:40:24  * wumpus confused
292 2017-03-27T12:43:54  <wumpus> argh
293 2017-03-27T12:44:43  <wumpus> wallettests.cpp includes test/test_bitcoin.h
294 2017-03-27T12:44:50  <wumpus> maybe that indirectly imports some boost test stuff?
295 2017-03-27T12:46:58  <wumpus> ideally the qt tests would test with a mocked wallet model instead of importing all the core stuff
296 2017-03-27T12:47:39  <jonasschnelli> hmm. Yes. That probably the issue.
297 2017-03-27T12:48:54  <wumpus> oh it even links against test_bitcoin.cpp
298 2017-03-27T12:49:00  <jonasschnelli> wumpus: but even after I remove the #include "test/test_bitcoin.h" (and remove the test code), I still get the linker issue
299 2017-03-27T12:49:01  <wumpus> that one certainly uses boost::test
300 2017-03-27T12:49:05  <jonasschnelli> ah... thats it!
301 2017-03-27T12:49:34  <jonasschnelli> I don't think this can be fix easily.
302 2017-03-27T12:49:39  <wumpus> bleh, the test utils should not themselves rely on any test framework
303 2017-03-27T12:49:54  <wumpus> e.g. testutil.cpp is fine
304 2017-03-27T12:50:27  <wumpus> I don't think so either, I think it was mistake to make the qt and normal tests interdependent like this
305 2017-03-27T12:50:54  <wumpus> anyhow no big deal to make qt tests depend on boost::unittest
306 2017-03-27T12:50:57  <wumpus> at least we know why, now
307 2017-03-27T12:51:23  <jonasschnelli> But why does this work in current master?!
308 2017-03-27T12:51:45  <wumpus> maybe we should go all the way and make the qt tests a boost test runner as well... but fixing it for now is easy just add the lib
309 2017-03-27T12:51:48  <wumpus> I don't know
310 2017-03-27T12:53:02  <jonasschnelli> wumpus: Yes. Let's fix the missing lib add, then let's see if ryanofsky is up for a clean split
311 2017-03-27T12:54:09  <wumpus> well it needs to be one of either: either the qt tests go fully boost::unit_test, or the shared code between the two test suites should be independent on the test framework
312 2017-03-27T12:54:56  <wumpus> either is fine with me, but using a few functions from boost::unit_test through linking in test_bitcoin.cpp *without* using the framework is asking for trouble
313 2017-03-27T12:55:07  <wumpus> e.g. what happens if you do BOOST_ASSERT while not in a boost unit test
314 2017-03-27T12:56:07  <jonasschnelli> Indeed
315 2017-03-27T12:56:18  <wumpus> hm! but seems he took that into account
316 2017-03-27T12:56:27  <wumpus> I don't see references to boost_test in test_bitcoin.cpp
317 2017-03-27T12:56:42  *** Chris_Stewart_5 has joined #bitcoin-core-dev
318 2017-03-27T12:56:48  <wumpus> it's no longer the test main file
319 2017-03-27T12:58:30  <wumpus> what, I don't get it, I remember I added some BOOST_REQUIRE to TestingSetup at some point
320 2017-03-27T12:59:09  <wumpus> I'm really, raelly confused now
321 2017-03-27T12:59:32  <wumpus> that wasn't #9902 at least
322 2017-03-27T12:59:35  <gribble> https://github.com/bitcoin/bitcoin/issues/9902 | Lightweight abstraction of boost::filesystem by laanwj · Pull Request #9902 · bitcoin/bitcoin · GitHub
323 2017-03-27T13:01:11  <wumpus> oh 91e3035 removed those again
324 2017-03-27T13:01:21  <wumpus> " Make test_bitcoin.cpp compatible with Qt Test framework"
325 2017-03-27T13:02:29  <wumpus> then... what does 9902 change that re-introduces boost::unittest in either test_bitcoin.cpp or the qt tests?
326 2017-03-27T13:03:24  <wumpus> OH I see! https://github.com/bitcoin/bitcoin/pull/9902/files#diff-d5ba361c5f8be78eb4cc0c787c1fc78eR28
327 2017-03-27T13:03:31  <wumpus> accidentally re-adding the header
328 2017-03-27T13:03:46  <jonasschnelli> ahh,...
329 2017-03-27T13:03:48  <jonasschnelli> right.
330 2017-03-27T13:04:36  <jonasschnelli> wumpus: so the non QT test_bitcoin is "boost/QT" free and can be included from both worlds.. right?
331 2017-03-27T13:04:43  <wumpus> yep
332 2017-03-27T13:05:08  <jonasschnelli> Okay. Got it... all good then. Then its just the accidentally added "include <boost/test/unit_test.hpp>".
333 2017-03-27T13:05:14  <jonasschnelli> Great. At least we know now. :)
334 2017-03-27T13:06:02  <wumpus> re-pushed with that line removed, let's see
335 2017-03-27T13:14:30  *** riemann has quit IRC
336 2017-03-27T13:20:36  *** Cory has quit IRC
337 2017-03-27T13:23:29  *** CubicEarthh has joined #bitcoin-core-dev
338 2017-03-27T13:27:29  *** Cory has joined #bitcoin-core-dev
339 2017-03-27T13:28:10  *** CubicEarthh has quit IRC
340 2017-03-27T13:35:42  *** magicwund has joined #bitcoin-core-dev
341 2017-03-27T13:37:57  *** bambuma has quit IRC
342 2017-03-27T14:08:19  *** Annabelle has joined #bitcoin-core-dev
343 2017-03-27T14:08:34  *** riemann has joined #bitcoin-core-dev
344 2017-03-27T14:08:41  *** Annabelle is now known as Guest53386
345 2017-03-27T14:24:26  *** CubicEarthh has joined #bitcoin-core-dev
346 2017-03-27T14:24:52  *** adiabat has quit IRC
347 2017-03-27T14:27:42  *** Giszmo has joined #bitcoin-core-dev
348 2017-03-27T14:28:59  *** CubicEarthh has quit IRC
349 2017-03-27T14:32:41  *** arubi has joined #bitcoin-core-dev
350 2017-03-27T14:33:52  *** harrymm has quit IRC
351 2017-03-27T14:36:20  *** paveljanik has joined #bitcoin-core-dev
352 2017-03-27T14:45:11  *** laurentmt has joined #bitcoin-core-dev
353 2017-03-27T14:49:32  *** harrymm has joined #bitcoin-core-dev
354 2017-03-27T14:51:13  *** Guyver2 has joined #bitcoin-core-dev
355 2017-03-27T14:59:04  *** n1ce has joined #bitcoin-core-dev
356 2017-03-27T15:03:44  *** laurentmt has quit IRC
357 2017-03-27T15:08:08  *** laurentmt has joined #bitcoin-core-dev
358 2017-03-27T15:10:16  *** dodomojo has joined #bitcoin-core-dev
359 2017-03-27T15:14:34  *** dodomojo has quit IRC
360 2017-03-27T15:23:26  *** laurentmt has quit IRC
361 2017-03-27T15:24:55  *** CubicEarthh has joined #bitcoin-core-dev
362 2017-03-27T15:29:35  *** CubicEarthh has quit IRC
363 2017-03-27T15:30:10  *** n1ce has quit IRC
364 2017-03-27T15:32:26  *** magicwund has quit IRC
365 2017-03-27T15:35:04  <bitcoin-git> [bitcoin] JeremyRubin closed pull request #9495: Fix CCheckQueue IsIdle (potential) race condition (master...checkqueue-control-lock) https://github.com/bitcoin/bitcoin/pull/9495
366 2017-03-27T15:37:28  *** magicwund has joined #bitcoin-core-dev
367 2017-03-27T15:37:37  *** harrymm has quit IRC
368 2017-03-27T15:40:53  <bitcoin-git> [bitcoin] jnewbery opened pull request #10096: Check that all test scripts in test/functional are being run (master...check_all_tests_run) https://github.com/bitcoin/bitcoin/pull/10096
369 2017-03-27T16:02:15  *** shesek has joined #bitcoin-core-dev
370 2017-03-27T16:09:26  <BlueMatt> jonasschnelli: as noteed in the issue qt4 -> qt5 introduces regressions
371 2017-03-27T16:09:32  <BlueMatt> we need to fix those before we can turn it off
372 2017-03-27T16:10:04  <BlueMatt> major regressions that break peoples' ability to use Bitcoin-Qt, that is
373 2017-03-27T16:15:25  <bitcoin-git> [bitcoin] jnewbery opened pull request #10097: Move zmq test skipping logic into individual test case. (master...zmq_optional) https://github.com/bitcoin/bitcoin/pull/10097
374 2017-03-27T16:22:30  *** chjj has quit IRC
375 2017-03-27T16:26:08  *** CubicEarthh has joined #bitcoin-core-dev
376 2017-03-27T16:30:33  *** CubicEarthh has quit IRC
377 2017-03-27T16:30:59  *** abpa has joined #bitcoin-core-dev
378 2017-03-27T16:34:22  *** midnightmagic has quit IRC
379 2017-03-27T16:35:42  *** chjj has joined #bitcoin-core-dev
380 2017-03-27T16:40:01  *** midnightmagic has joined #bitcoin-core-dev
381 2017-03-27T17:00:40  *** magicwund has quit IRC
382 2017-03-27T17:09:02  *** CubicEarthh has joined #bitcoin-core-dev
383 2017-03-27T17:09:53  *** magicwund has joined #bitcoin-core-dev
384 2017-03-27T17:12:07  *** magicwund has joined #bitcoin-core-dev
385 2017-03-27T17:34:16  *** BashCo has quit IRC
386 2017-03-27T17:42:02  *** riemann has quit IRC
387 2017-03-27T17:49:40  *** adiabat has joined #bitcoin-core-dev
388 2017-03-27T18:01:19  *** BashCo has joined #bitcoin-core-dev
389 2017-03-27T18:24:48  *** n1ce has joined #bitcoin-core-dev
390 2017-03-27T18:31:11  *** riemann has joined #bitcoin-core-dev
391 2017-03-27T18:47:41  <bitcoin-git> [bitcoin] ryanofsky opened pull request #10098: Make qt wallet test compatible with qt4 (master...pr/wqt4) https://github.com/bitcoin/bitcoin/pull/10098
392 2017-03-27T18:50:54  *** mol has quit IRC
393 2017-03-27T18:51:16  *** mol has joined #bitcoin-core-dev
394 2017-03-27T18:54:37  *** ovovo is now known as owowo
395 2017-03-27T19:12:29  *** chjj has quit IRC
396 2017-03-27T19:14:03  *** talmai has joined #bitcoin-core-dev
397 2017-03-27T19:17:18  *** caracareddit has joined #bitcoin-core-dev
398 2017-03-27T19:26:27  *** chjj has joined #bitcoin-core-dev
399 2017-03-27T19:27:51  *** mol is now known as moli
400 2017-03-27T19:30:43  *** CubicEar_ has joined #bitcoin-core-dev
401 2017-03-27T19:34:14  *** CubicEarthh has quit IRC
402 2017-03-27T19:35:20  *** CubicEar_ has quit IRC
403 2017-03-27T19:35:38  *** michagogo has quit IRC
404 2017-03-27T19:37:02  *** michagogo has joined #bitcoin-core-dev
405 2017-03-27T19:37:04  <bitcoin-git> [bitcoin] kallewoof closed pull request #10062: [net] Clean up the CNode class in net.h (master...20170322-cleanup-net) https://github.com/bitcoin/bitcoin/pull/10062
406 2017-03-27T19:39:26  *** frabrunelle1 has joined #bitcoin-core-dev
407 2017-03-27T19:39:53  *** abpa has quit IRC
408 2017-03-27T19:40:15  *** xhire_ has joined #bitcoin-core-dev
409 2017-03-27T19:41:34  *** abpa has joined #bitcoin-core-dev
410 2017-03-27T19:41:39  *** frabrunelle has quit IRC
411 2017-03-27T19:41:40  *** xHire has quit IRC
412 2017-03-27T19:42:01  *** xhire_ is now known as xHire
413 2017-03-27T19:44:10  *** abpa_ has joined #bitcoin-core-dev
414 2017-03-27T19:44:35  <bitcoin-git> [bitcoin] JeremyRubin opened pull request #10099: Speedup & Slightly Improve Unit Tests for Checkqueue (master...speedup-checkqueue-tests) https://github.com/bitcoin/bitcoin/pull/10099
415 2017-03-27T19:46:32  *** abpa has quit IRC
416 2017-03-27T19:49:08  *** trotski2000 has quit IRC
417 2017-03-27T19:50:15  *** trotski2000 has joined #bitcoin-core-dev
418 2017-03-27T19:50:47  *** moli_ has joined #bitcoin-core-dev
419 2017-03-27T19:51:58  *** moli has quit IRC
420 2017-03-27T19:56:27  *** root-servers has joined #bitcoin-core-dev
421 2017-03-27T19:57:12  *** Chris_Stewart_5 has quit IRC
422 2017-03-27T20:00:51  *** root-servers has quit IRC
423 2017-03-27T20:05:10  *** CubicEarthh has joined #bitcoin-core-dev
424 2017-03-27T20:10:25  *** talmai has quit IRC
425 2017-03-27T20:21:21  *** magicwund has quit IRC
426 2017-03-27T20:24:49  <BlueMatt> jonasschnelli: ping
427 2017-03-27T20:26:28  *** caracareddit has quit IRC
428 2017-03-27T20:41:40  *** chjj has quit IRC
429 2017-03-27T20:41:49  *** magicwund has joined #bitcoin-core-dev
430 2017-03-27T20:46:37  *** magicwund has quit IRC
431 2017-03-27T20:50:54  *** riemann has quit IRC
432 2017-03-27T20:51:19  *** ndriggs has joined #bitcoin-core-dev
433 2017-03-27T20:56:07  *** chjj has joined #bitcoin-core-dev
434 2017-03-27T20:59:27  *** CubicEar_ has joined #bitcoin-core-dev
435 2017-03-27T21:00:24  *** ndriggs has left #bitcoin-core-dev
436 2017-03-27T21:02:40  *** CubicEarthh has quit IRC
437 2017-03-27T21:02:40  *** talmai has joined #bitcoin-core-dev
438 2017-03-27T21:02:57  *** magicwund has joined #bitcoin-core-dev
439 2017-03-27T21:06:13  *** moli_ has quit IRC
440 2017-03-27T21:07:10  *** moli_ has joined #bitcoin-core-dev
441 2017-03-27T21:07:44  *** magicwund has quit IRC
442 2017-03-27T21:10:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
443 2017-03-27T21:14:19  *** abpa_ has quit IRC
444 2017-03-27T21:16:28  *** abpa has joined #bitcoin-core-dev
445 2017-03-27T21:18:19  *** magicwund has joined #bitcoin-core-dev
446 2017-03-27T21:22:46  <bitcoin-git> [bitcoin] RHavar opened pull request #10100: Make ApproximateBestSubset optimize for amount of inputs (master...coinselection) https://github.com/bitcoin/bitcoin/pull/10100
447 2017-03-27T21:24:44  *** talmai has quit IRC
448 2017-03-27T21:26:45  *** CubicEarthh has joined #bitcoin-core-dev
449 2017-03-27T21:27:03  *** CubicEar_ has quit IRC
450 2017-03-27T21:28:45  *** Giszmo has quit IRC
451 2017-03-27T21:35:03  *** dcousens has joined #bitcoin-core-dev
452 2017-03-27T21:38:20  *** CubicEarthh has quit IRC
453 2017-03-27T21:41:25  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #10101: [0.14] backports (0.14...Mf1703-014backp) https://github.com/bitcoin/bitcoin/pull/10101
454 2017-03-27T21:41:50  *** bitcoinreminder_ has left #bitcoin-core-dev
455 2017-03-27T21:42:03  *** bitcoinreminder_ has joined #bitcoin-core-dev
456 2017-03-27T21:46:04  *** CubicEarthh has joined #bitcoin-core-dev
457 2017-03-27T21:47:26  *** Giszmo has joined #bitcoin-core-dev
458 2017-03-27T21:48:41  <bitcoin-git> [bitcoin] ryanofsky opened pull request #10102: bitcoin-qt: spawn bitcoind and communicate over pipe (Experimental, WIP) (master...pr/ipc) https://github.com/bitcoin/bitcoin/pull/10102
459 2017-03-27T21:54:07  *** CubicEar_ has joined #bitcoin-core-dev
460 2017-03-27T21:54:13  *** CubicEarthh has quit IRC
461 2017-03-27T21:59:19  <cfields> ryanofsky: cool!
462 2017-03-27T22:04:18  *** CubicEar_ has quit IRC
463 2017-03-27T22:05:12  *** CubicEarthh has joined #bitcoin-core-dev
464 2017-03-27T22:10:44  *** CubicEarthh has quit IRC
465 2017-03-27T22:15:46  *** Guyver2 has quit IRC
466 2017-03-27T22:16:49  *** magicwund has quit IRC
467 2017-03-27T22:17:32  *** magicwund has joined #bitcoin-core-dev
468 2017-03-27T22:18:29  *** CubicEarthh has joined #bitcoin-core-dev
469 2017-03-27T22:21:14  <achow101> does anyone know if the way that Core 0.14 broadcasts messages has changed from the way the 0.13.2 did?
470 2017-03-27T22:22:06  <sipa> can you be more specific?
471 2017-03-27T22:23:13  <achow101> I guess more specific would be how network packets are being sent
472 2017-03-27T22:23:19  *** magicwund has quit IRC
473 2017-03-27T22:23:40  <sipa> there have been significant changes to that, yes
474 2017-03-27T22:24:12  <sipa> not sure whether those should be observable, though
475 2017-03-27T22:25:11  <achow101> I think I mentioned this several months ago when I first started looking into this issue. On Armory, I have noticed that it was receiving and processing message headers separately from the message payloads
476 2017-03-27T22:25:36  *** CubicEarthh has quit IRC
477 2017-03-27T22:25:42  <achow101> it would appear that this behavior is caused by something in 0.14.0 since people have only been reporting the issue since 0.14.0's release
478 2017-03-27T22:25:57  *** CubicEarthh has joined #bitcoin-core-dev
479 2017-03-27T22:25:59  <achow101> I only noticed because I always run a build of the master branch.
480 2017-03-27T22:26:00  <sipa> define 'separate' ?
481 2017-03-27T22:26:38  <achow101> it would interpret the message header as a message, and then interpret the message payload as a completely new message
482 2017-03-27T22:26:45  <sipa> TCP does not have messages
483 2017-03-27T22:26:51  <sipa> it is a byte stream
484 2017-03-27T22:26:58  <achow101> message being the bitcoin p2p messages
485 2017-03-27T22:27:16  <cfields> achow101: yes, that's possible now
486 2017-03-27T22:27:17  <sipa> that makes no sense... a p2p message is defined as a header + payload
487 2017-03-27T22:27:27  <sipa> you're asking whether a message can consist of a message and a message
488 2017-03-27T22:27:37  <sipa> cfields: it was always possible
489 2017-03-27T22:27:38  <achow101> cfields: how so?
490 2017-03-27T22:27:47  <cfields> sipa: tcp fast-send + split message sends
491 2017-03-27T22:27:50  <phantomcircuit> sipa, im guessing they screwed up and are assuming the entire message will be received in a single recv()
492 2017-03-27T22:28:01  <cfields> sec for some grepping so i can use better terms
493 2017-03-27T22:28:03  <sipa> phantomcircuit: yes, that's my assumption too, but that would have always been a bug
494 2017-03-27T22:28:08  <achow101> phantomcircuit: well we never saw this issue before 0.14.0
495 2017-03-27T22:28:22  *** magicwund has joined #bitcoin-core-dev
496 2017-03-27T22:28:23  <phantomcircuit> sipa, yeah but wouldn't have been easily triggered until recently
497 2017-03-27T22:28:28  <BlueMatt> phantomcircuit: in that case you'd also see it for big messages
498 2017-03-27T22:28:38  <BlueMatt> (>~1k)
499 2017-03-27T22:28:38  <sipa> achow101: yes, it's now done as separate send calls
500 2017-03-27T22:28:48  <cfields> TCP_NODELAY + separate sends
501 2017-03-27T22:28:50  <phantomcircuit> BlueMatt, not if they have a huge recv buffer and are on localhost always
502 2017-03-27T22:28:52  <phantomcircuit> which they are
503 2017-03-27T22:28:52  <achow101> we fixed the issue on our end, but I just wanted to figure out why that happened since it only appeared when people used 0.14.0
504 2017-03-27T22:28:58  <cfields> make it likely that you'll receive the header in the first chunk
505 2017-03-27T22:29:04  <BlueMatt> phantomcircuit: you still usually see it for things >>1k
506 2017-03-27T22:29:09  <BlueMatt> eg 1MB you'd def see it
507 2017-03-27T22:29:14  <phantomcircuit> uh
508 2017-03-27T22:29:17  <phantomcircuit> hmm let me see
509 2017-03-27T22:29:21  <phantomcircuit> i dont think that's right
510 2017-03-27T22:29:32  <BlueMatt> localhost can be surprisingly slow somteimts
511 2017-03-27T22:29:35  <BlueMatt> sometimes
512 2017-03-27T22:30:08  <sipa> achow101: so, yes, there has been a change where header and payload are now sent through separate kernel calls, which makes it much more likely you'll see them in separate recv() calls
513 2017-03-27T22:30:10  *** laurentmt has joined #bitcoin-core-dev
514 2017-03-27T22:30:22  <achow101> ok. thanks
515 2017-03-27T22:30:45  <achow101> we fixed the problem, I just wanted to know why it was a problem in the first place
516 2017-03-27T22:30:48  *** laurentmt has quit IRC
517 2017-03-27T22:31:08  *** Giszmo has quit IRC
518 2017-03-27T22:31:25  <sipa> it should always have been possible to see this; TCP does not guarantee that message boundares are preserved
519 2017-03-27T22:31:30  <gmaxwell> it's easy in tcp applications to write bugs where you assume your reads will always contain a complete message... when the remote end used a single write (or nagle merged them)... then something changes and the reads are short.
520 2017-03-27T22:31:32  <sipa> but on localhost i guess it would be unlikely
521 2017-03-27T22:32:38  <achow101> well I don't know how it was originally implemented in Armory nor how it was fixed. I just know that one day it magically started giving me errors for something that had never happened in a previous version of core
522 2017-03-27T22:32:53  <achow101> anyways, thanks for the info
523 2017-03-27T22:33:03  <cfields> well also if you're receiving a few messages in one read, it'd be very likely that a header would span 2 chunks
524 2017-03-27T22:33:11  <cfields> so seems strange that that would've ever worked :)
525 2017-03-27T22:33:14  <phantomcircuit> BlueMatt, why do i get two sendcmpt messages for every connection?
526 2017-03-27T22:33:29  <BlueMatt> phantomcircuit: thats how the version negotiation works
527 2017-03-27T22:34:52  *** magicwund has quit IRC
528 2017-03-27T22:39:13  *** CubicEarthh has quit IRC
529 2017-03-27T22:47:10  *** Giszmo has joined #bitcoin-core-dev
530 2017-03-27T22:48:04  *** vicenteH has quit IRC
531 2017-03-27T22:57:08  *** tripleslash has quit IRC
532 2017-03-27T22:57:09  *** afk11 has left #bitcoin-core-dev
533 2017-03-27T22:57:20  *** tripleslash has joined #bitcoin-core-dev
534 2017-03-27T23:00:12  *** tripleslash has quit IRC
535 2017-03-27T23:00:22  *** tripleslash has joined #bitcoin-core-dev
536 2017-03-27T23:09:58  *** davec has quit IRC
537 2017-03-27T23:16:31  *** magicwund has joined #bitcoin-core-dev
538 2017-03-27T23:21:04  *** magicwund has quit IRC
539 2017-03-27T23:24:29  *** whphhg has joined #bitcoin-core-dev
540 2017-03-27T23:33:09  *** droark has quit IRC
541 2017-03-27T23:50:13  *** droark has joined #bitcoin-core-dev