12017-04-14T00:00:21  *** abpa has quit IRC
  22017-04-14T00:01:11  *** AaronvanW has joined #bitcoin-core-dev
  32017-04-14T00:08:32  *** AaronvanW has quit IRC
  42017-04-14T00:22:17  *** tw2006 has joined #bitcoin-core-dev
  52017-04-14T00:23:24  *** AaronvanW has joined #bitcoin-core-dev
  62017-04-14T00:42:05  *** AaronvanW has quit IRC
  72017-04-14T00:42:30  <gmaxwell> Anyone have AMD Ryzen yet? apparently they implement the intel SHA extensions.
  82017-04-14T00:54:10  *** Ylbam has quit IRC
  92017-04-14T01:22:28  *** tw2006 has quit IRC
 102017-04-14T01:24:18  *** d_t has joined #bitcoin-core-dev
 112017-04-14T01:47:38  *** array has joined #bitcoin-core-dev
 122017-04-14T01:48:59  *** laurentmt has quit IRC
 132017-04-14T01:58:44  *** laurentmt has joined #bitcoin-core-dev
 142017-04-14T02:00:06  *** dermoth has quit IRC
 152017-04-14T02:00:54  *** dermoth has joined #bitcoin-core-dev
 162017-04-14T02:08:04  *** laurentmt has quit IRC
 172017-04-14T02:21:28  *** cfields_ is now known as cfields
 182017-04-14T02:23:22  *** tw2006 has joined #bitcoin-core-dev
 192017-04-14T02:23:29  *** juscamarena has joined #bitcoin-core-dev
 202017-04-14T02:24:48  *** squidicuz has quit IRC
 212017-04-14T02:25:31  *** dodomojo has joined #bitcoin-core-dev
 222017-04-14T02:28:12  *** tw2006 has quit IRC
 232017-04-14T02:30:46  *** Squidicuz has joined #bitcoin-core-dev
 242017-04-14T02:37:40  *** str4d has joined #bitcoin-core-dev
 252017-04-14T02:43:47  *** juscamarena has quit IRC
 262017-04-14T02:44:09  *** juscamarena has joined #bitcoin-core-dev
 272017-04-14T02:44:32  *** juscamarena is now known as Guest28992
 282017-04-14T02:45:30  *** warren_ is now known as warren
 292017-04-14T02:45:32  <warren> Yikes ... rescan is very slow.
 302017-04-14T02:51:22  *** fauve has joined #bitcoin-core-dev
 312017-04-14T02:56:19  *** Guest28992 is now known as juscamarean
 322017-04-14T03:12:45  *** fauve has quit IRC
 332017-04-14T03:16:04  <bitcoin-git> [bitcoin] wtogami opened pull request #10207: Clarify importprivkey help text ... example of blank label without rescan (master...importprivkey) https://github.com/bitcoin/bitcoin/pull/10207
 342017-04-14T03:21:35  *** Giszmo has quit IRC
 352017-04-14T03:25:07  *** Squidicuz has quit IRC
 362017-04-14T03:25:31  *** Squidicuz has joined #bitcoin-core-dev
 372017-04-14T03:26:53  <kallewoof> I think the PR review request part of the weekly meetings is a bad idea. It risks alienating the contributors who aren't hard core enough to participate and/or who aren't in a compatible time zone. I also don't think I would ever ask for a review for anything as I wouldn't consider my PRs important enough to take anyone's time at a specific time.
 382017-04-14T03:28:38  <kallewoof> At the same time it's a bit frustrating watching PRs just gather dust for no (to oneself) apparent reason. Maybe that's just me.
 392017-04-14T03:30:15  <kallewoof> Meetings start 4 in the morning where I am, FWIW.
 402017-04-14T03:36:38  <warren> kallewoof: you make a good point, although I don't have a good suggestion.  Asking for reviews during the meeting is not decision making.  It is merely humans asking other humans to take a look at something.  Perhaps folks here could volunteer to talk with you and others at other hours to better communication and coordination in other schedules.
 412017-04-14T03:38:10  *** btcdrak has joined #bitcoin-core-dev
 422017-04-14T03:38:28  *** Victorsueca has joined #bitcoin-core-dev
 432017-04-14T03:41:05  *** Victor_sueca has quit IRC
 442017-04-14T03:41:17  <kallewoof> I am a bit surprised that there's no better method to keep the ball rolling so to say. After the initial comment spree (if any) it sort of just sits there. If you're like me, who hates bugging people for no particular reason, that can be a long time. E.g. #9517 is over 3 months old and I don't even know if people want it merged.
 452017-04-14T03:41:18  <gribble> https://github.com/bitcoin/bitcoin/issues/9517 | [refactor] Switched httpserver.cpp to use RAII wrapped libevents. by kallewoof · Pull Request #9517 · bitcoin/bitcoin · GitHub
 462017-04-14T03:41:45  <kallewoof> And it's a very simple PR. +8 lines -16 lines.
 472017-04-14T03:42:34  *** Giszmo has joined #bitcoin-core-dev
 482017-04-14T03:50:10  *** str4d has quit IRC
 492017-04-14T03:57:23  <gmaxwell> kallewoof: sometimes they get forgotten and you need to nag. It's suboptimal but there is often more in flight than we can really manage. squeaky wheel and all that.
 502017-04-14T04:00:13  <gmaxwell> kallewoof: in any case, sorry about that I will test now.
 512017-04-14T04:01:03  <gmaxwell> Recommended procedure is: (1) wait until we're not closing for a major release (e.g. now is fine), (2) nag.  (3) apologize for nagging by cross responding to other people's nags: end result everyone happy.
 522017-04-14T04:03:15  <kallewoof> gmaxwell: Yeah, I can sort of grasp that this is the approach, but for a newcomer I think it's very intimidating. (Not necessarily speaking about myself there, though i do hate nagging.) It'd be a pity for a bright individual to lose their steam and go somewhere else because they are too scared to bug you guys. That's more of an issue here since everyone here is a damn genius.
 532017-04-14T04:03:58  <kallewoof> Friendly geniuses, but that's not necessarily obvious to someone who hasn't spent a great deal of time watching you interact.
 542017-04-14T04:05:21  <kallewoof> My approach so far has been to jump to e.g. page 5-6 in the PR list and just go from bottom and upwards. But I am not exactly the most qualified to review a lot of the stuff there. :)
 552017-04-14T04:07:17  *** annanay25 has quit IRC
 562017-04-14T04:07:19  <gmaxwell> kallewoof: people do go and advocate for other PRs, which does rescue this case in some cases. But it happens at a much greater rate when they've taken some personal interest in the result; and so good cleanup work like the RAII wrapper takes a backseat because as good as it may be, it isn't sexy.
 572017-04-14T04:07:25  *** annanay25 has joined #bitcoin-core-dev
 582017-04-14T04:08:00  <gmaxwell> It's certantly something we need to improve-- and you can help improve it by also advocating for other people. I dunno about you but I find it less intimidating to ask for other people than for myself.
 592017-04-14T04:09:12  <kallewoof> That makes a lot of sense, yeah.
 602017-04-14T04:11:22  <kallewoof> TBH I think part of the problem is that you aren't sure if what you are suggesting is desired or not. Getting a concept ACK from someone goes a long way and makes the wait less of an issue, at least in my book.
 612017-04-14T04:11:48  <kallewoof> Or a concept NACK for that matter.
 622017-04-14T04:12:01  <gmaxwell> kallewoof: ah, well in this case you got suggestions from wumpus that weren't a "don't do this", which was not a Concept NACK.
 632017-04-14T04:12:22  *** tw2006 has joined #bitcoin-core-dev
 642017-04-14T04:12:55  <gmaxwell> Part of it is familarity with the codebase-- I would expect wumpus to be the person most opinionated with this code. (I believe he wrote all of it.)
 652017-04-14T04:13:00  <gmaxwell> well almost all of it.
 662017-04-14T04:13:47  <gmaxwell> if you don't already know its handy to run a git blame / git log on whatever your change and get an idea of who has been working on that part most recently, since they're most likely to have the most useful review and strongest opinions.
 672017-04-14T04:14:11  <kallewoof> *nods* this is true, but even a code suggestion can be less than a concept ACK. "Merge desire opinions aside, you can improve this code by doing XYZ". That's how I interpret it usually. I wouldn't be surprised to get a concept NACK later.
 682017-04-14T04:14:17  <kallewoof> Oh... I never thought of that, actually.
 692017-04-14T04:14:48  <kallewoof> That might make it easier to nag as it's sort of a suggestion on top of their work..
 702017-04-14T04:15:06  <gmaxwell> oh, I would not expect a person to suggest changes and then concept NACK for a simple patch. For a complex patch where the implications are unclear, perhaps.
 712017-04-14T04:15:27  <kallewoof> *nods*
 722017-04-14T04:15:56  <gmaxwell> Generally if people mildly dislike a change you'll get a thundering silence, not exactly useful feedback to you-- but often people would prefer to bite their tongue in case someone else likes it.
 732017-04-14T04:17:04  *** tw2006 has quit IRC
 742017-04-14T04:17:12  <gmaxwell> Suggestions are an investment of resources into your change, in some sense they're better than an ACK in that an ACK can be a drive by review, while if someone makes suggesitons they've basically put themselves on the hook to explain the suggestions to you and collaborate. :)
 752017-04-14T04:18:39  <kallewoof> Right. I've learned a tremendous amount since becoming a contributor. I wish I'd joined an OSS project much earlier. In that sense even a NACK can be appreciated and feel rewarding.
 762017-04-14T04:20:17  <gmaxwell> I think the most important thing to learn is that-- at least once you're beyond a basic level of skill-- your real contribution is the attempt, it doesn't matter if the result ends up in the finished version or stays there, but we're all pushing towards an improved piece of software, and if we keep pushing we'll be successful, even though-- in fact, especially because-- not every change makes it
 772017-04-14T04:20:23  <gmaxwell>  in.
 782017-04-14T04:21:46  <gmaxwell> now, ... trying to test your patch and I'm bombing out with a perplexing multiple definition error that looks like you missed an include guard. But it has an include guard.
 792017-04-14T04:22:05  <kallewoof> I agree that that's exactly the right approach to take, and you've given me feedback that I think will help me advocate my own stuff or stuff I feel about by others. Maybe I'll make a PR to the contribution doc summarizing what you said, cause some of it was NOT obvious, at least not to me.
 802017-04-14T04:22:28  <kallewoof> Weird. Testing.
 812017-04-14T04:22:46  <gmaxwell> test/test_test_bitcoin-raii_event_tests.o:/home/gmaxwell/src/bitcoin/src/./support/events.h:30: first defined here
 822017-04-14T04:22:49  <gmaxwell> libbitcoin_server.a(libbitcoin_server_a-httpserver.o): In function `obtain_event(event_base*, int, short, void (*)(int, short, void*), void*)':
 832017-04-14T04:22:52  <gmaxwell> /home/gmaxwell/src/bitcoin/src/support/events.h:37: multiple definition of `obtain_event(event_base*, int, short, void (*)(int, short, void*), void*)'
 842017-04-14T04:23:17  <gmaxwell> oh
 852017-04-14T04:23:41  <gmaxwell> the test. missed that it was the test.
 862017-04-14T04:32:27  <kallewoof> Weird. I'm not getting that compile error (on lubuntu).
 872017-04-14T04:33:49  <gmaxwell> kallewoof: in any case, I went and made all the function definitions in that header static inline, it's fine then. AFAICT the duplicate symbol is real.
 882017-04-14T04:34:10  <gmaxwell> May just be that your linker is handling it differently.
 892017-04-14T04:34:50  <kallewoof> Yeah they should be static and/or inline for sure.
 902017-04-14T04:34:57  <gmaxwell> or moved out of the header.
 912017-04-14T04:35:59  <gmaxwell> (I tend to have relatively few optinions about these things, because I am not much of a C++ coder; and don't really have a sense of taste for such things beyond preferring almost everything to look like C, which is usually the wrong answer. :) )
 922017-04-14T04:36:34  * kallewoof laughs
 932017-04-14T04:38:03  <gmaxwell> in any case seems to work for me, I'll ACK when you've updated to do something about the duplicate function definitions.
 942017-04-14T04:39:00  *** AaronvanW has joined #bitcoin-core-dev
 952017-04-14T04:40:44  <kallewoof> Thanks a lot :) I just pushed a commit that adds inline.
 962017-04-14T04:44:52  <cfields> kallewoof: you on osx?
 972017-04-14T04:44:55  *** AaronvanW has quit IRC
 982017-04-14T04:45:12  <gmaxwell> kallewoof: obtain_event_base too.
 992017-04-14T04:45:27  <kallewoof> cfields: Yep. I do have a linux box too though.
1002017-04-14T04:45:46  <kallewoof> gmaxwell: Yeah, sorry. I force-pushed a squash fix of that one. Was hoping you wouldn't grab before I did.
1012017-04-14T04:46:00  <cfields> kallewoof: the osx linker is very forgiving. too much so, imo.
1022017-04-14T04:46:06  <NicolasDorier> kallewoof: Yeah, the solution to our time zone problem is called the ACK Begging. It works, just need to find the right balance to not get a kick in the butt while getting things committed.
1032017-04-14T04:46:15  <kallewoof> cfields: I compiled fine under lubuntu too, though.
1042017-04-14T04:46:33  <NicolasDorier> btcdrak taught me this technique. Now I think I surpassed the master.
1052017-04-14T04:46:47  <cfields> ah
1062017-04-14T04:47:32  <cfields> kallewoof: fyi, I've written a pretty full-featured c++ wrapper for libevent. Maybe we should collaborate a bit to avoid stepping on eachother.
1072017-04-14T04:48:05  <kallewoof> cfields: That would be lovely. :)
1082017-04-14T04:48:42  <cfields> kallewoof: i'm getting ready to libevent-ify the net code, and I'd really rather not litter it with c code. I think we're probably in agreement there :)
1092017-04-14T04:49:38  <kallewoof> Isn't that what #9517 does already?
1102017-04-14T04:49:39  <gribble> https://github.com/bitcoin/bitcoin/issues/9517 | [refactor] Switched httpserver.cpp to use RAII wrapped libevents. by kallewoof · Pull Request #9517 · bitcoin/bitcoin · GitHub
1112017-04-14T04:49:51  *** RubenSomsen has joined #bitcoin-core-dev
1122017-04-14T04:51:40  <kallewoof> Oh wait, that's just the httpserver part.
1132017-04-14T04:51:51  <cfields> kallewoof: yea, but it doesn't handle refcounting, std::function, etc. I'd much prefer more native looking callbacks and functors.
1142017-04-14T04:53:55  <kallewoof> That sounds nice yeah. I'd love to help if there's anything I can do.
1152017-04-14T04:54:47  <cfields> kallewoof: for ex, the bufferevent wrapper looks like this: https://0bin.net/paste/1tIvDfqrmUlS5DZU#2y7U59tfCueh+QfprDlMv+5XBjGm2wWceUeKX-PZrTz
1162017-04-14T04:54:48  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
1172017-04-14T04:55:05  <cfields> (it's been a while since I've worked with it, I don't recall exactly what state it's in)
1182017-04-14T04:55:25  *** Giszmo has quit IRC
1192017-04-14T04:55:53  <kallewoof> Oh, wow.
1202017-04-14T04:56:22  <cfields> kallewoof: the goal would be to be able to cleanly work with events like: bufferevent.read_cb([](size_t bytes){printf("read %lu bytes\n", bytes);});
1212017-04-14T04:56:58  <kallewoof> Looks pretty neat. Would this be a separate library? It looks like it would be.
1222017-04-14T04:57:34  <cfields> it's intended to be a standalone wrapper, but included in our repo
1232017-04-14T04:58:13  * kallewoof nods
1242017-04-14T04:58:56  <cfields> kallewoof: anyway, that's the reason I haven't chimed in on your PRs. I'd like something a little different, but I don't like standing in the way of obvious improvements either.
1252017-04-14T05:00:25  <kallewoof> cfields: I initially started writing something like that (less elegant) but wumpus suggested he wanted something more light weight. I think a fully featured wrapper might be useful, but it adds some amount of maintainer load in case libevent changes. But then again, I doubt libevent will change a whole lot ever, so I don't think it would be a prob.
1262017-04-14T05:01:39  <cfields> kallewoof: yea, understandable. fwiw, I don't intend to wrap everything, just the stuff we use
1272017-04-14T05:02:05  <kallewoof> Yeah, uh, s/fully featured//
1282017-04-14T05:02:11  <cfields> kallewoof: the reason I ultimately decided on that route is I found my own code to be unreadble without it :(
1292017-04-14T05:03:04  <cfields> kallewoof: anyway, I'm open to whatever is cleanest/simplest. Maybe minimal would be better. But we should collaborate either way :)
1302017-04-14T05:03:17  <kallewoof> I admittedly haven't done a lot. I just fixed the stuff that had // TODO: RAII comments on them, in my never ending quest to find something that needs doing that I am capable of. :P
1312017-04-14T05:04:00  <kallewoof> cfields: I would love to collaborate! :)
1322017-04-14T05:05:12  <cfields> kallewoof: great, give me a few days and I'll push up what I have. Don't let me keep you from working on what you already have though, we can converge later
1332017-04-14T05:07:50  <cfields> kallewoof: one of the most important things (imo) is tracking ownership by passing objects around. For example, if an event needs a pointer to its base, it should hold a reference and keep the base alive. Otherwise, it gets very difficult to guarantee that everything will tear down safely.
1342017-04-14T05:09:36  <kallewoof> cfields: I noticed that too. I tried to do something clever but it kind of backfired and I simplified it. It ended up not being intuitive at all. (I think it was something like, a wrapper holding an object lost the object after a certain operation, but I can't remember.)
1352017-04-14T05:09:58  *** dodomojo has quit IRC
1362017-04-14T05:10:21  <cfields> heh
1372017-04-14T05:11:57  <cfields> in the example above, the CBufferEvent requires a CEventBase in its ctor. CEventBase contains a shared_ptr<event_base>. That way, the base lives at least as long as any bufferevents using it.
1382017-04-14T05:13:19  <cfields> so there's no way to create a bufferevent without a valid base, and no way for the base to be deleted out from under a bufferevent.
1392017-04-14T05:13:52  <kallewoof> In some cases the underlying libevent struct takes ownership of an argument, e.g. I believe the evhttp takes ownership of passed-in evhttp_requests. That is what got me.
1402017-04-14T05:14:26  <kallewoof> Even with shared pointers, the request should sometimes be deleted (if not passed into evhttp) and sometimes not (if passed in).
1412017-04-14T05:15:53  <cfields> ah yea, I remember seeing some wonky stuff in evhttp.
1422017-04-14T05:16:12  <cfields> (I didn't wrap that)
1432017-04-14T05:16:34  *** moli_ has quit IRC
1442017-04-14T05:17:14  <kallewoof> cfields: This is the part, I was a bit off on the struct names, but: https://github.com/bitcoin/bitcoin/pull/9387/files#diff-321303fddcf725df060981d626a05df9R234
1452017-04-14T05:18:35  <cfields> kallewoof: is it just evhttp_make_request that does that?
1462017-04-14T05:18:39  <kallewoof> Or not... either way, an evhttp_request is stolen by an evhttp_request when calling evhttp_make_request().
1472017-04-14T05:18:47  <cfields> or.. just certain functions?
1482017-04-14T05:18:58  <kallewoof> Not sure. I think certain functions simply take ownership of stuff you pass in.
1492017-04-14T05:19:12  *** moli_ has joined #bitcoin-core-dev
1502017-04-14T05:19:25  <kallewoof> So far this is the only case I ran into.
1512017-04-14T05:20:05  <cfields> kallewoof: well that'd be easy enough to wrap: http.Request(const CConn& conn, CRequest&& req)
1522017-04-14T05:20:40  <cfields> I think those could be handled with move semantics reasonably enough?
1532017-04-14T05:21:05  <kallewoof> I'm not sure. I talked to wumpus about it. See e.g. https://github.com/bitcoin/bitcoin/pull/9387#issuecomment-268213151
1542017-04-14T05:22:23  <kallewoof> I think part of the problem with my approach was that it wasn't especially elegant, so there was no reason for its existence other than simply wrapping libevent into C++ish fluff. Having a more solid solution like what you're proposing is probably more meaningful.
1552017-04-14T05:23:12  <cfields> oh i see, it's conditional on what happens in different places
1562017-04-14T05:23:36  <cfields> sorry, I really shouldn't speak on the evhttp code, I'm not familiar enough with it.
1572017-04-14T05:24:29  <kallewoof> To be honest, neither am I. I just learned enough to make it work replacing the stuff that was there already.
1582017-04-14T05:25:03  <cfields> kallewoof: well I agree with trying to keep it as minimal as possible. I think there's some middle ground that maintains the api while adding protection and type/memory safety.
1592017-04-14T05:25:44  <cfields> kallewoof: sounds like a good approach if it gets the job done :)
1602017-04-14T05:26:55  <cfields> kallewoof: I'll ping you in the next few days. keep up the good work :)
1612017-04-14T05:27:04  <kallewoof> Looking forward to it! :)
1622017-04-14T05:32:39  *** kadoban has quit IRC
1632017-04-14T05:34:09  <bitcoin-git> [bitcoin] kallewoof closed pull request #9872: [qa] Multi-chain support in test framework (master...qa-multi-chain-support) https://github.com/bitcoin/bitcoin/pull/9872
1642017-04-14T05:55:02  *** Lauda has quit IRC
1652017-04-14T06:01:17  *** tw2006 has joined #bitcoin-core-dev
1662017-04-14T06:05:07  *** zach_ has joined #bitcoin-core-dev
1672017-04-14T06:05:39  *** AaronvanW has joined #bitcoin-core-dev
1682017-04-14T06:05:42  *** zach_ has quit IRC
1692017-04-14T06:05:56  *** tw2006 has quit IRC
1702017-04-14T06:07:31  *** Lauda has joined #bitcoin-core-dev
1712017-04-14T06:25:47  *** AaronvanW has quit IRC
1722017-04-14T06:32:00  *** RubenSomsen has quit IRC
1732017-04-14T06:42:46  *** RubenSomsen has joined #bitcoin-core-dev
1742017-04-14T06:48:14  <bitcoin-git> [bitcoin] kallewoof opened pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
1752017-04-14T06:51:41  *** jtimon has joined #bitcoin-core-dev
1762017-04-14T06:52:24  *** jtimon has quit IRC
1772017-04-14T07:02:32  *** CubicEarth has quit IRC
1782017-04-14T07:03:12  *** CubicEarth has joined #bitcoin-core-dev
1792017-04-14T07:09:19  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
1802017-04-14T07:09:39  <bitcoin-git> [bitcoin] jonasschnelli reopened pull request #10208: [wallet] Rescan abortability (master...rescan-abortability) https://github.com/bitcoin/bitcoin/pull/10208
1812017-04-14T07:23:19  *** mol has joined #bitcoin-core-dev
1822017-04-14T07:26:28  *** moli_ has quit IRC
1832017-04-14T07:26:48  *** molz_ has joined #bitcoin-core-dev
1842017-04-14T07:30:09  *** mol has quit IRC
1852017-04-14T07:38:58  <jonasschnelli> Having a stalled shutdown on a node. It's on c7e73eafa139c29a38f73ab697e2e967a386908d (not a release)
1862017-04-14T07:47:01  <sipa> file an issue, give debug.log, ...
1872017-04-14T07:49:09  *** AaronvanW has joined #bitcoin-core-dev
1882017-04-14T07:50:12  *** tw2006 has joined #bitcoin-core-dev
1892017-04-14T07:54:34  *** harding_ is now known as harding
1902017-04-14T07:54:48  *** tw2006 has quit IRC
1912017-04-14T07:56:47  *** AaronvanW has quit IRC
1922017-04-14T07:57:44  <jonasschnelli> sipa_ https://github.com/bitcoin/bitcoin/issues/10209
1932017-04-14T07:58:45  *** AaronvanW has joined #bitcoin-core-dev
1942017-04-14T07:59:05  <jonasschnelli> Hmm.... I don't really understand why getaddrinfo on OSX does cache forever... https://github.com/bitcoin/bitcoin/blob/1a5aaabb8a3d67a039ad120bb5d8d418467cac4e/src/netbase.cpp#L104
1952017-04-14T07:59:20  <jonasschnelli> The result in OSX client always get the same result from the dnsseed,...
1962017-04-14T07:59:44  <jonasschnelli> Well,.. it's not very bad becuase you very likely have a peer that can response reasonable to a getaddr
1972017-04-14T08:00:06  <jonasschnelli> But still something thats unfortunate in "client-mode"
1982017-04-14T08:08:35  *** AaronvanW has quit IRC
1992017-04-14T08:16:34  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b7365f0545b1...f4db00f9a548
2002017-04-14T08:16:34  <bitcoin-git> bitcoin/master 883154c John Newbery: [rpc] rename disconnectnode argument
2012017-04-14T08:16:35  <bitcoin-git> bitcoin/master f4db00f Wladimir J. van der Laan: Merge #10204: [rpc] rename disconnectnode argument...
2022017-04-14T08:16:57  <bitcoin-git> [bitcoin] laanwj closed pull request #10204: [rpc] rename disconnectnode argument (master...rename_disconnect_node_argument) https://github.com/bitcoin/bitcoin/pull/10204
2032017-04-14T08:26:12  <wumpus> jonasschnelli: that's crappy. good thing we're going to stop getaddrinfo in favor of libevent after cfields's p2p changes
2042017-04-14T08:26:39  <wumpus> (e.g. libevent implements its own DNS resolving instead of using libc's)
2052017-04-14T08:26:48  <jonasschnelli> wumpus: What will be the substitute? I hope it won't be evutil_getaddrinfo
2062017-04-14T08:27:10  <wumpus> no, I don't think so
2072017-04-14T08:27:16  <wumpus> evutil_* is just a wrapper
2082017-04-14T08:27:19  <jonasschnelli> Yes. This makes sense.
2092017-04-14T08:28:32  *** Guyver2 has joined #bitcoin-core-dev
2102017-04-14T08:36:14  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.14: https://github.com/bitcoin/bitcoin/compare/06909df179e7...30fa231011a6
2112017-04-14T08:36:14  <bitcoin-git> bitcoin/0.14 3c79602 John Newbery: [rpc] rename disconnectnode argument...
2122017-04-14T08:36:15  <bitcoin-git> bitcoin/0.14 30fa231 Cory Fields: net: define NodeId as an int64_t...
2132017-04-14T08:36:32  <bitcoin-git> [bitcoin] laanwj closed pull request #10205: [0.14] net: define NodeId as an int64_t (0.14...10176-backport) https://github.com/bitcoin/bitcoin/pull/10205
2142017-04-14T08:38:56  <wumpus> did I forget anything for rc2? last chance
2152017-04-14T08:40:40  *** Victorsueca has quit IRC
2162017-04-14T08:55:30  *** To7 has quit IRC
2172017-04-14T08:56:04  *** Victorsueca has joined #bitcoin-core-dev
2182017-04-14T09:02:44  *** AaronvanW has joined #bitcoin-core-dev
2192017-04-14T09:02:45  *** AaronvanW has joined #bitcoin-core-dev
2202017-04-14T09:04:55  *** jannes has joined #bitcoin-core-dev
2212017-04-14T09:31:45  *** CubicEarth has quit IRC
2222017-04-14T09:36:47  <btcdrak> wumpus: activate segwit ✓ 😁
2232017-04-14T09:38:33  <wumpus> 😈
2242017-04-14T09:39:07  *** tw2006 has joined #bitcoin-core-dev
2252017-04-14T09:43:40  *** tw2006 has quit IRC
2262017-04-14T10:22:05  *** Victorsueca has quit IRC
2272017-04-14T10:22:49  <wumpus> can we activate that before the world goes up in flames, pretty please
2282017-04-14T10:23:14  *** Victorsueca has joined #bitcoin-core-dev
2292017-04-14T10:30:35  *** Lauda has quit IRC
2302017-04-14T10:35:19  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/348a71701db4cb29a762c7d60aba34380ee1d403
2312017-04-14T10:35:19  <bitcoin-git> bitcoin/0.14 348a717 Wladimir J. van der Laan: qt: translations update pre-rc2
2322017-04-14T10:39:07  *** Lauda has joined #bitcoin-core-dev
2332017-04-14T10:47:15  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/33fadc20bae4828788d6d82c582c457adc6941e1
2342017-04-14T10:47:15  <bitcoin-git> bitcoin/0.14 33fadc2 Wladimir J. van der Laan: doc: Update release notes pre-rc2
2352017-04-14T10:51:19  <wumpus>  * [new tag]         v0.14.1rc2 -> v0.14.1rc2
2362017-04-14T11:02:02  *** tw2006 has joined #bitcoin-core-dev
2372017-04-14T11:05:30  *** tw2006 has quit IRC
2382017-04-14T11:06:07  *** tw2006 has joined #bitcoin-core-dev
2392017-04-14T11:13:34  *** RubenSomsen has quit IRC
2402017-04-14T11:52:19  *** JackH has quit IRC
2412017-04-14T12:13:25  *** tw2006 has quit IRC
2422017-04-14T12:14:01  *** tw2006 has joined #bitcoin-core-dev
2432017-04-14T12:26:42  *** laurentmt has joined #bitcoin-core-dev
2442017-04-14T12:27:31  <emucode> wumpus: core could perhaps include segwit, just as a command line (and gui?) option
2452017-04-14T12:27:39  *** tw2006 has quit IRC
2462017-04-14T12:27:47  <emucode> I mean, include UASF, BIP148, of segwit
2472017-04-14T12:27:52  *** RubenSomsen has joined #bitcoin-core-dev
2482017-04-14T12:28:18  *** tw2006 has joined #bitcoin-core-dev
2492017-04-14T12:31:00  <wumpus> UASF, in its current form at least, is under heavy discussion still
2502017-04-14T12:33:49  <wumpus> the current form has quite some risks while it activates, which wouldn't really be our prefered way of working, see the mailing list for example gmaxwell's writeup here: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2017-April/014152.html
2512017-04-14T12:35:11  *** d_t has quit IRC
2522017-04-14T12:36:12  *** d_t has joined #bitcoin-core-dev
2532017-04-14T12:38:59  *** shaolinfry has joined #bitcoin-core-dev
2542017-04-14T13:11:37  <achow101> rc2? I thought we were doing final
2552017-04-14T13:13:09  *** Ylbam has joined #bitcoin-core-dev
2562017-04-14T13:14:13  <wumpus> meeting yesterday wasn't really conclusive on that, and the rc2 backported changes were deemed too important to leave out, also I forgot to do a translations update for rc1. Hopefully rc2 can be final...
2572017-04-14T13:20:15  *** RubenSomsen has quit IRC
2582017-04-14T13:21:38  *** molz_ has quit IRC
2592017-04-14T13:23:47  *** moli_ has joined #bitcoin-core-dev
2602017-04-14T13:50:15  *** d_t has joined #bitcoin-core-dev
2612017-04-14T13:57:29  *** dermoth_ has joined #bitcoin-core-dev
2622017-04-14T13:57:57  *** dermoth has quit IRC
2632017-04-14T13:57:59  *** dermoth_ is now known as dermoth
2642017-04-14T14:01:59  *** hsmiths has quit IRC
2652017-04-14T14:02:13  *** hsmiths has joined #bitcoin-core-dev
2662017-04-14T14:07:33  *** goksinen has joined #bitcoin-core-dev
2672017-04-14T14:11:33  *** Char0n has quit IRC
2682017-04-14T14:12:41  <bitcoin-git> [bitcoin] kallewoof opened pull request #10211: [doc] Contributor fixes & new "finding reviewers" section (master...contributor-finding-reviewers) https://github.com/bitcoin/bitcoin/pull/10211
2692017-04-14T14:15:35  *** goksinen has quit IRC
2702017-04-14T14:22:22  *** tw2006 has quit IRC
2712017-04-14T14:40:52  *** Ylbam has quit IRC
2722017-04-14T14:41:08  *** Ylbam has joined #bitcoin-core-dev
2732017-04-14T14:42:08  *** annanay25 has quit IRC
2742017-04-14T14:42:16  *** annanay25 has joined #bitcoin-core-dev
2752017-04-14T14:45:58  *** To7 has joined #bitcoin-core-dev
2762017-04-14T15:01:59  *** tw2006 has joined #bitcoin-core-dev
2772017-04-14T15:02:19  <bitcoin-git> [bitcoin] practicalswift opened pull request #10212: Make sure parameter names in .cpp and .h files are in sync (master...make-doxygen-happy-by-using-consistent-parameter-names) https://github.com/bitcoin/bitcoin/pull/10212
2782017-04-14T15:04:53  *** jl2012 has quit IRC
2792017-04-14T15:05:07  *** jl2012 has joined #bitcoin-core-dev
2802017-04-14T15:06:03  *** Giszmo has joined #bitcoin-core-dev
2812017-04-14T15:23:12  *** g0d355__ has quit IRC
2822017-04-14T15:26:12  *** dermoth has quit IRC
2832017-04-14T15:30:32  *** dermoth has joined #bitcoin-core-dev
2842017-04-14T15:57:10  *** waxwing has quit IRC
2852017-04-14T16:10:50  *** waxwing has joined #bitcoin-core-dev
2862017-04-14T16:30:17  *** tw2006 has quit IRC
2872017-04-14T16:30:54  *** tw2006 has joined #bitcoin-core-dev
2882017-04-14T16:52:59  *** afk11 has quit IRC
2892017-04-14T16:53:18  *** afk11 has joined #bitcoin-core-dev
2902017-04-14T16:56:07  *** tw2006 has quit IRC
2912017-04-14T16:56:44  *** tw2006 has joined #bitcoin-core-dev
2922017-04-14T17:07:24  *** tw2006 has quit IRC
2932017-04-14T17:07:58  *** tw2006 has joined #bitcoin-core-dev
2942017-04-14T17:08:25  *** tw2006 has quit IRC
2952017-04-14T17:09:03  *** tw2006 has joined #bitcoin-core-dev
2962017-04-14T17:13:09  *** abpa has joined #bitcoin-core-dev
2972017-04-14T17:14:58  *** jl2012 has quit IRC
2982017-04-14T17:26:53  *** tw2006 has quit IRC
2992017-04-14T17:27:30  *** tw2006 has joined #bitcoin-core-dev
3002017-04-14T17:31:47  *** tw2006 has quit IRC
3012017-04-14T17:32:11  <cfields> gitian builders: detached sigs for 0.14.1rc2 are up
3022017-04-14T17:45:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3032017-04-14T18:38:57  *** d_t has joined #bitcoin-core-dev
3042017-04-14T18:52:11  *** justan0theruser has quit IRC
3052017-04-14T18:52:44  *** justanotheruser has joined #bitcoin-core-dev
3062017-04-14T18:57:29  *** mol has joined #bitcoin-core-dev
3072017-04-14T19:00:49  *** moli_ has quit IRC
3082017-04-14T19:00:57  *** Ylbam has quit IRC
3092017-04-14T19:02:20  *** moli_ has joined #bitcoin-core-dev
3102017-04-14T19:02:57  <bitcoin-git> [bitcoin] rawodb opened pull request #10214: Abortable rescans & rpc abortrescan command (master...pr/rpc_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10214
3112017-04-14T19:03:11  *** mol has quit IRC
3122017-04-14T19:11:31  <bitcoin-git> [bitcoin] rawodb closed pull request #10214: Abortable rescans & rpc abortrescan command (master...pr/rpc_abort_rescan) https://github.com/bitcoin/bitcoin/pull/10214
3132017-04-14T19:15:58  *** tw2006 has joined #bitcoin-core-dev
3142017-04-14T19:20:58  *** tw2006 has quit IRC
3152017-04-14T19:21:03  *** Guyver2 has quit IRC
3162017-04-14T19:21:32  *** Ylbam has joined #bitcoin-core-dev
3172017-04-14T19:23:29  *** instagibbs has quit IRC
3182017-04-14T19:26:09  *** instagibbs has joined #bitcoin-core-dev
3192017-04-14T19:33:29  *** instagibbs has quit IRC
3202017-04-14T19:36:46  *** mol has joined #bitcoin-core-dev
3212017-04-14T19:37:25  *** instagibbs has joined #bitcoin-core-dev
3222017-04-14T19:39:19  *** molz_ has joined #bitcoin-core-dev
3232017-04-14T19:40:29  *** moli_ has quit IRC
3242017-04-14T19:41:29  *** mol has quit IRC
3252017-04-14T19:42:14  *** instagibbs has quit IRC
3262017-04-14T19:43:08  *** molz_ has quit IRC
3272017-04-14T19:47:08  *** instagibbs has joined #bitcoin-core-dev
3282017-04-14T20:09:48  <BlueMatt> jonasschnelli: hey
3292017-04-14T20:16:11  *** justanotheruser has quit IRC
3302017-04-14T20:17:40  *** instagibbs has quit IRC
3312017-04-14T20:21:38  *** rgrant has joined #bitcoin-core-dev
3322017-04-14T20:23:24  <bitcoin-git> [bitcoin] KibbledJiveElkZoo closed pull request #10183: [RPC] Don't default rescan on private/public key imports. (master...rpc_rescan_fixes) https://github.com/bitcoin/bitcoin/pull/10183
3332017-04-14T20:23:37  *** justanotheruser has joined #bitcoin-core-dev
3342017-04-14T20:24:38  *** instagibbs has joined #bitcoin-core-dev
3352017-04-14T20:35:13  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10215: Check interruptNet during dnsseed lookups (master...2017-04-dnsseed-break) https://github.com/bitcoin/bitcoin/pull/10215
3362017-04-14T20:35:50  *** CubicEarth has joined #bitcoin-core-dev
3372017-04-14T20:51:59  *** laurentmt has quit IRC
3382017-04-14T20:52:47  *** moli_ has joined #bitcoin-core-dev
3392017-04-14T21:04:55  *** tw2006 has joined #bitcoin-core-dev
3402017-04-14T21:09:50  *** tw2006 has quit IRC
3412017-04-14T21:12:09  *** kadoban has joined #bitcoin-core-dev
3422017-04-14T21:20:03  *** nu11p7r has joined #bitcoin-core-dev
3432017-04-14T21:58:30  *** CubicEarth has quit IRC
3442017-04-14T21:58:47  *** CubicEarth has joined #bitcoin-core-dev
3452017-04-14T21:59:59  *** laurentmt has joined #bitcoin-core-dev
3462017-04-14T22:09:50  *** shaolinfry has quit IRC
3472017-04-14T22:24:00  *** laurentmt has quit IRC
3482017-04-14T22:53:56  *** tw2006 has joined #bitcoin-core-dev
3492017-04-14T22:56:50  *** d_t has quit IRC
3502017-04-14T22:57:18  *** d_t has joined #bitcoin-core-dev
3512017-04-14T22:58:42  *** tw2006 has quit IRC
3522017-04-14T22:59:23  *** d_t has quit IRC
3532017-04-14T23:03:36  *** rgrant has left #bitcoin-core-dev
3542017-04-14T23:30:57  *** Ylbam has quit IRC
3552017-04-14T23:34:19  *** laurentmt has joined #bitcoin-core-dev
3562017-04-14T23:35:07  *** justanotheruser has quit IRC
3572017-04-14T23:35:14  *** laurentmt has quit IRC
3582017-04-14T23:40:46  *** mol has joined #bitcoin-core-dev
3592017-04-14T23:41:05  *** justanotheruser has joined #bitcoin-core-dev
3602017-04-14T23:41:51  *** mol has quit IRC
3612017-04-14T23:43:57  *** moli_ has quit IRC
3622017-04-14T23:54:59  *** abpa has quit IRC
3632017-04-14T23:55:16  *** str4d has joined #bitcoin-core-dev