1 2017-04-19T00:02:56  *** AaronvanW has quit IRC
  2 2017-04-19T00:03:46  *** AaronvanW has joined #bitcoin-core-dev
  3 2017-04-19T00:09:35  *** AaronvanW has quit IRC
  4 2017-04-19T00:11:08  *** AaronvanW has joined #bitcoin-core-dev
  5 2017-04-19T00:11:37  *** d_t has quit IRC
  6 2017-04-19T00:11:58  *** d_t has joined #bitcoin-core-dev
  7 2017-04-19T00:14:10  *** NewLiberty has quit IRC
  8 2017-04-19T00:14:43  *** juscamarena has quit IRC
  9 2017-04-19T00:16:28  *** juscamarena has joined #bitcoin-core-dev
 10 2017-04-19T00:16:53  *** juscamarena is now known as Guest36442
 11 2017-04-19T00:21:40  *** AaronvanW has quit IRC
 12 2017-04-19T00:23:35  *** NewLiberty has joined #bitcoin-core-dev
 13 2017-04-19T00:25:26  *** d_t has quit IRC
 14 2017-04-19T00:40:57  *** Ylbam has quit IRC
 15 2017-04-19T00:47:26  *** Giszmo has quit IRC
 16 2017-04-19T00:47:59  *** talmai has joined #bitcoin-core-dev
 17 2017-04-19T00:54:28  *** jeremyrubin has quit IRC
 18 2017-04-19T00:55:24  *** jeremyrubin has joined #bitcoin-core-dev
 19 2017-04-19T00:56:54  *** jtimon has quit IRC
 20 2017-04-19T00:58:10  *** talmai has quit IRC
 21 2017-04-19T00:59:13  *** tw2006 has joined #bitcoin-core-dev
 22 2017-04-19T01:04:02  *** tw2006 has quit IRC
 23 2017-04-19T01:05:37  *** Giszmo has joined #bitcoin-core-dev
 24 2017-04-19T01:12:20  *** goksinen has joined #bitcoin-core-dev
 25 2017-04-19T01:13:11  *** goksinen has joined #bitcoin-core-dev
 26 2017-04-19T01:14:45  *** goksinen has quit IRC
 27 2017-04-19T01:15:30  *** goksinen has joined #bitcoin-core-dev
 28 2017-04-19T01:16:43  *** dodomojo has joined #bitcoin-core-dev
 29 2017-04-19T01:19:19  *** AaronvanW has joined #bitcoin-core-dev
 30 2017-04-19T01:20:42  *** goksinen has quit IRC
 31 2017-04-19T01:24:15  *** AaronvanW has quit IRC
 32 2017-04-19T01:32:41  *** jl2012 has joined #bitcoin-core-dev
 33 2017-04-19T01:49:26  *** dodomojo has quit IRC
 34 2017-04-19T01:50:03  *** goksinen has joined #bitcoin-core-dev
 35 2017-04-19T02:06:33  *** d_t has joined #bitcoin-core-dev
 36 2017-04-19T02:11:53  *** belcher has quit IRC
 37 2017-04-19T02:16:55  *** dodomojo has joined #bitcoin-core-dev
 38 2017-04-19T02:19:36  *** pepe__ has joined #bitcoin-core-dev
 39 2017-04-19T02:19:57  *** goksinen has quit IRC
 40 2017-04-19T02:31:20  *** AaronvanW has joined #bitcoin-core-dev
 41 2017-04-19T02:35:42  *** AaronvanW has quit IRC
 42 2017-04-19T02:38:00  *** AaronvanW has joined #bitcoin-core-dev
 43 2017-04-19T02:39:50  *** d_t has quit IRC
 44 2017-04-19T02:42:49  *** pepe__ has quit IRC
 45 2017-04-19T02:43:10  *** pepe__ has joined #bitcoin-core-dev
 46 2017-04-19T02:44:23  *** AaronvanW has quit IRC
 47 2017-04-19T02:45:47  *** AaronvanW has joined #bitcoin-core-dev
 48 2017-04-19T02:45:59  *** pepe__ has quit IRC
 49 2017-04-19T02:46:20  *** pepe__ has joined #bitcoin-core-dev
 50 2017-04-19T02:47:17  *** pepe__ has joined #bitcoin-core-dev
 51 2017-04-19T02:48:11  *** tw2006 has joined #bitcoin-core-dev
 52 2017-04-19T02:52:56  *** tw2006 has quit IRC
 53 2017-04-19T02:58:25  <bitcoin-git> [bitcoin] jimmysong opened pull request #10229: Tests: Add test for getdifficulty (master...test_getdifficulty) https://github.com/bitcoin/bitcoin/pull/10229
 54 2017-04-19T03:00:40  *** AaronvanW has quit IRC
 55 2017-04-19T03:03:26  *** AaronvanW has joined #bitcoin-core-dev
 56 2017-04-19T03:17:35  *** AaronvanW has quit IRC
 57 2017-04-19T03:23:23  *** AaronvanW has joined #bitcoin-core-dev
 58 2017-04-19T03:41:20  *** AaronvanW has quit IRC
 59 2017-04-19T03:48:41  *** AaronvanW has joined #bitcoin-core-dev
 60 2017-04-19T04:14:12  *** AaronvanW has quit IRC
 61 2017-04-19T04:15:18  *** mol has joined #bitcoin-core-dev
 62 2017-04-19T04:18:32  *** molz_ has quit IRC
 63 2017-04-19T04:18:54  *** mol has quit IRC
 64 2017-04-19T04:19:12  *** mol has joined #bitcoin-core-dev
 65 2017-04-19T04:22:50  *** AaronvanW has joined #bitcoin-core-dev
 66 2017-04-19T04:23:38  *** moli_ has joined #bitcoin-core-dev
 67 2017-04-19T04:24:30  *** mol has quit IRC
 68 2017-04-19T04:25:43  *** dodomojo has quit IRC
 69 2017-04-19T04:31:44  *** fao has quit IRC
 70 2017-04-19T04:32:01  *** arowser has quit IRC
 71 2017-04-19T04:37:14  *** tw2006 has joined #bitcoin-core-dev
 72 2017-04-19T04:37:25  *** arowser has joined #bitcoin-core-dev
 73 2017-04-19T04:38:30  *** AaronvanW has quit IRC
 74 2017-04-19T04:39:03  *** fao has joined #bitcoin-core-dev
 75 2017-04-19T04:41:50  *** tw2006 has quit IRC
 76 2017-04-19T04:45:04  *** AaronvanW has joined #bitcoin-core-dev
 77 2017-04-19T04:57:05  *** AaronvanW has quit IRC
 78 2017-04-19T04:59:59  *** AaronvanW has joined #bitcoin-core-dev
 79 2017-04-19T05:11:40  *** goksinen has joined #bitcoin-core-dev
 80 2017-04-19T05:13:57  *** pepe__ has quit IRC
 81 2017-04-19T05:16:29  *** goksinen has quit IRC
 82 2017-04-19T05:20:32  *** Chris_Stewart_5 has quit IRC
 83 2017-04-19T05:22:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 84 2017-04-19T05:22:50  *** d9b4bef9 has quit IRC
 85 2017-04-19T05:23:57  *** d9b4bef9 has joined #bitcoin-core-dev
 86 2017-04-19T05:28:05  *** AaronvanW has quit IRC
 87 2017-04-19T05:33:03  *** AaronvanW has joined #bitcoin-core-dev
 88 2017-04-19T05:43:17  *** RubenSomsen has joined #bitcoin-core-dev
 89 2017-04-19T05:48:40  *** AaronvanW has quit IRC
 90 2017-04-19T05:52:30  *** Chris_Stewart_5 has quit IRC
 91 2017-04-19T05:52:51  *** Giszmo has quit IRC
 92 2017-04-19T05:53:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 93 2017-04-19T06:00:08  *** dermoth has quit IRC
 94 2017-04-19T06:00:48  *** dermoth has joined #bitcoin-core-dev
 95 2017-04-19T06:06:17  *** goksinen has joined #bitcoin-core-dev
 96 2017-04-19T06:10:41  *** goksinen has quit IRC
 97 2017-04-19T06:13:07  *** AaronvanW has joined #bitcoin-core-dev
 98 2017-04-19T06:17:05  *** NewLiberty has quit IRC
 99 2017-04-19T06:21:12  *** fao has quit IRC
100 2017-04-19T06:22:45  *** fao has joined #bitcoin-core-dev
101 2017-04-19T06:25:42  *** AaronvanW has quit IRC
102 2017-04-19T06:26:04  *** tw2006 has joined #bitcoin-core-dev
103 2017-04-19T06:30:38  *** tw2006 has quit IRC
104 2017-04-19T06:34:00  *** AaronvanW has joined #bitcoin-core-dev
105 2017-04-19T06:39:50  *** AaronvanW has quit IRC
106 2017-04-19T06:42:35  *** AaronvanW has joined #bitcoin-core-dev
107 2017-04-19T06:47:24  *** AaronvanW has quit IRC
108 2017-04-19T06:49:37  *** AaronvanW has joined #bitcoin-core-dev
109 2017-04-19T07:03:44  *** kexkey has quit IRC
110 2017-04-19T07:04:35  *** AaronvanW has quit IRC
111 2017-04-19T07:05:34  *** AaronvanW has joined #bitcoin-core-dev
112 2017-04-19T07:18:42  *** AaronvanW has quit IRC
113 2017-04-19T07:22:59  *** AaronvanW has joined #bitcoin-core-dev
114 2017-04-19T07:34:04  *** AaronvanW has quit IRC
115 2017-04-19T07:36:39  *** AaronvanW has joined #bitcoin-core-dev
116 2017-04-19T07:38:13  <wumpus> git add --patch is so useful
117 2017-04-19T07:40:05  <wumpus> it's essential if you want to add just some changes in a file to a commit but not all. Only discovered this recently, don't ask what hacks I was doing to accomplish that before...
118 2017-04-19T07:41:02  <sipa> you can also use it split existing commits
119 2017-04-19T07:41:24  <sipa> during a rebase, while editing a commit, use git reset HEAD~
120 2017-04-19T07:41:39  <sipa> then git add -p to select the changes to be in the first half
121 2017-04-19T07:41:54  <sipa> git commit -m first; git commit -am second
122 2017-04-19T07:42:18  <wumpus> 'git gui' can also be used for this (you can stage and unstage individual lines, even), but usually work in the console so that was kind of annoying
123 2017-04-19T07:42:27  <wumpus> ah great
124 2017-04-19T07:42:53  <sipa> and then git rebase --continue
125 2017-04-19T07:43:05  *** AaronvanW has quit IRC
126 2017-04-19T07:43:48  *** AaronvanW has joined #bitcoin-core-dev
127 2017-04-19T07:48:08  *** AaronvanW has quit IRC
128 2017-04-19T07:56:54  *** AaronvanW has joined #bitcoin-core-dev
129 2017-04-19T07:59:12  <wumpus> is there anything (almost) ready for merging?
130 2017-04-19T07:59:39  *** Novella has joined #bitcoin-core-dev
131 2017-04-19T08:01:42  *** AaronvanW has quit IRC
132 2017-04-19T08:04:12  *** Novella has quit IRC
133 2017-04-19T08:04:30  *** AaronvanW has joined #bitcoin-core-dev
134 2017-04-19T08:05:10  *** Dahlia2 has joined #bitcoin-core-dev
135 2017-04-19T08:10:49  *** AaronvanW has quit IRC
136 2017-04-19T08:14:58  *** tw2006 has joined #bitcoin-core-dev
137 2017-04-19T08:19:37  *** tw2006 has quit IRC
138 2017-04-19T08:23:58  *** AaronvanW has joined #bitcoin-core-dev
139 2017-04-19T08:26:02  <wumpus> thought #10143 was, but needs some minor changes still
140 2017-04-19T08:26:04  <gribble> https://github.com/bitcoin/bitcoin/issues/10143 | [net] Allow disconnectnode RPC to be called with node id by jnewbery · Pull Request #10143 · bitcoin/bitcoin · GitHub
141 2017-04-19T08:33:06  <bitcoin-git> [bitcoin] laanwj closed pull request #9524: rpc: Don't FlushStateToDisk when pruneblockchain(0) (master...Mf1701-qaPruning) https://github.com/bitcoin/bitcoin/pull/9524
142 2017-04-19T08:41:35  *** AaronvanW has quit IRC
143 2017-04-19T08:42:26  <paveljanik> wumpus, #10226?
144 2017-04-19T08:42:27  <gribble> https://github.com/bitcoin/bitcoin/issues/10226 | wallet: Use boost to more portably ensure -wallet specifies only a filename by luke-jr · Pull Request #10226 · bitcoin/bitcoin · GitHub
145 2017-04-19T08:44:21  *** nOgAnOo has joined #bitcoin-core-dev
146 2017-04-19T08:44:56  <wumpus> yes, that one is very straightforward
147 2017-04-19T08:51:44  *** AaronvanW has joined #bitcoin-core-dev
148 2017-04-19T08:55:40  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9111df9673be...64c45aada702
149 2017-04-19T08:55:40  <bitcoin-git> bitcoin/master a4186dd Luke Dashjr: wallet: Use boost to more portably ensure -wallet specifies only a filename
150 2017-04-19T08:55:41  <bitcoin-git> bitcoin/master 64c45aa Wladimir J. van der Laan: Merge #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename...
151 2017-04-19T08:56:04  <bitcoin-git> [bitcoin] laanwj closed pull request #10226: wallet: Use boost to more portably ensure -wallet specifies only a filename (master...refactor_wallet_pathsep) https://github.com/bitcoin/bitcoin/pull/10226
152 2017-04-19T08:57:18  *** AaronvanW has quit IRC
153 2017-04-19T09:03:44  *** AaronvanW has joined #bitcoin-core-dev
154 2017-04-19T09:03:45  *** AaronvanW has joined #bitcoin-core-dev
155 2017-04-19T09:10:38  *** AaronvanW has quit IRC
156 2017-04-19T09:11:50  *** d9b4bef9 has quit IRC
157 2017-04-19T09:12:55  *** d9b4bef9 has joined #bitcoin-core-dev
158 2017-04-19T09:14:15  *** PaulCape_ has joined #bitcoin-core-dev
159 2017-04-19T09:15:05  *** AaronvanW has joined #bitcoin-core-dev
160 2017-04-19T09:15:32  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64c45aada702...e96486cbebc6
161 2017-04-19T09:15:33  <bitcoin-git> bitcoin/master 608bbcc Matt Corallo: [qt] Stop treating coinbase outputs differently: show them at 1conf
162 2017-04-19T09:15:33  <bitcoin-git> bitcoin/master e96486c Jonas Schnelli: Merge #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf...
163 2017-04-19T09:15:53  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #10221: Stop treating coinbase outputs differently in GUI: show them at 1conf (master...2017-04-no-coinbase-display-lag) https://github.com/bitcoin/bitcoin/pull/10221
164 2017-04-19T09:16:53  *** PaulCapestany has quit IRC
165 2017-04-19T09:21:00  <jonasschnelli> Anyone has an opinion on: https://github.com/bitcoin/bitcoin/pull/9502
166 2017-04-19T09:21:18  <jonasschnelli> I think it's useful even if there is the "hidden" feature of clicking the peers-statusbar-icon
167 2017-04-19T09:22:05  *** AaronvanW has quit IRC
168 2017-04-19T09:23:10  *** AaronvanW has joined #bitcoin-core-dev
169 2017-04-19T09:32:05  *** AaronvanW has quit IRC
170 2017-04-19T09:40:11  *** AaronvanW has joined #bitcoin-core-dev
171 2017-04-19T09:44:42  *** AaronvanW has quit IRC
172 2017-04-19T09:46:26  *** AaronvanW has joined #bitcoin-core-dev
173 2017-04-19T09:50:42  *** AaronvanW has quit IRC
174 2017-04-19T09:51:47  *** AaronvanW has joined #bitcoin-core-dev
175 2017-04-19T09:56:42  *** AaronvanW has quit IRC
176 2017-04-19T09:56:51  *** Ylbam has joined #bitcoin-core-dev
177 2017-04-19T09:58:28  *** AaronvanW has joined #bitcoin-core-dev
178 2017-04-19T09:59:18  *** AaronvanW has quit IRC
179 2017-04-19T09:59:34  *** AaronvanW has joined #bitcoin-core-dev
180 2017-04-19T10:03:54  *** tw2006 has joined #bitcoin-core-dev
181 2017-04-19T10:08:36  *** tw2006 has quit IRC
182 2017-04-19T10:19:05  *** Guyver2 has joined #bitcoin-core-dev
183 2017-04-19T10:24:33  <jonasschnelli> I think this is RFM: https://github.com/bitcoin/bitcoin/pull/9827
184 2017-04-19T10:29:33  <wumpus> yep, thanks
185 2017-04-19T10:30:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e96486cbebc6...c91ca0ace9bd
186 2017-04-19T10:30:26  <bitcoin-git> bitcoin/master 30abce7 Russell Yanofsky: Improve ScanForWalletTransactions return value...
187 2017-04-19T10:30:26  <bitcoin-git> bitcoin/master c91ca0a Wladimir J. van der Laan: Merge #9827: Improve ScanForWalletTransactions return value...
188 2017-04-19T10:30:39  <bitcoin-git> [bitcoin] laanwj closed pull request #9827: Improve ScanForWalletTransactions return value (master...pr/scanret) https://github.com/bitcoin/bitcoin/pull/9827
189 2017-04-19T10:36:31  *** goksinen has joined #bitcoin-core-dev
190 2017-04-19T10:37:17  <wumpus> jonasschnelli: and yes I think it can be a useful feature
191 2017-04-19T10:37:32  <jonasschnelli> wumpus: Thanks for the review.
192 2017-04-19T10:37:36  <jonasschnelli> Will fix your points soon
193 2017-04-19T10:41:10  *** goksinen has quit IRC
194 2017-04-19T10:45:05  *** RubenSomsen has quit IRC
195 2017-04-19T10:50:26  *** face has quit IRC
196 2017-04-19T10:56:51  *** tw2006 has joined #bitcoin-core-dev
197 2017-04-19T10:57:29  *** pepe__ has joined #bitcoin-core-dev
198 2017-04-19T11:03:14  *** BashCo has joined #bitcoin-core-dev
199 2017-04-19T11:05:42  *** Soligor has quit IRC
200 2017-04-19T11:06:09  *** face has joined #bitcoin-core-dev
201 2017-04-19T11:10:12  *** Soligor has joined #bitcoin-core-dev
202 2017-04-19T11:27:34  *** nOgAnOo has quit IRC
203 2017-04-19T11:30:51  *** goksinen has joined #bitcoin-core-dev
204 2017-04-19T11:35:24  *** goksinen has quit IRC
205 2017-04-19T11:36:23  *** laurentmt has joined #bitcoin-core-dev
206 2017-04-19T11:56:07  *** Dahlia2 has quit IRC
207 2017-04-19T11:56:08  *** NewLiberty has joined #bitcoin-core-dev
208 2017-04-19T11:58:44  *** jtimon has joined #bitcoin-core-dev
209 2017-04-19T12:09:01  *** tw2006 has quit IRC
210 2017-04-19T12:14:23  *** To7 has quit IRC
211 2017-04-19T12:14:53  *** RubenSomsen has joined #bitcoin-core-dev
212 2017-04-19T12:26:01  *** laurentmt has quit IRC
213 2017-04-19T12:31:05  <instagibbs> wumpus, git add -p also works line by line, in manual edit mode
214 2017-04-19T12:32:28  <instagibbs> 's' to keep splitting chunks, if not granular enough, 'e' for manual editor. A bit confusing at first but description is at end.
215 2017-04-19T12:33:09  *** NielsvG` is now known as NielsvG
216 2017-04-19T12:36:51  <wumpus> instagibbs: ah :) thanks
217 2017-04-19T12:43:49  *** nu11p7r has quit IRC
218 2017-04-19T12:48:06  *** tw2006 has joined #bitcoin-core-dev
219 2017-04-19T12:52:51  *** wasi has joined #bitcoin-core-dev
220 2017-04-19T12:53:35  *** To7 has joined #bitcoin-core-dev
221 2017-04-19T13:15:38  *** owowo has quit IRC
222 2017-04-19T13:18:19  *** jannes has joined #bitcoin-core-dev
223 2017-04-19T13:18:51  *** goksinen has joined #bitcoin-core-dev
224 2017-04-19T13:23:40  *** goksinen has quit IRC
225 2017-04-19T13:34:51  *** SopaXorzTaker has joined #bitcoin-core-dev
226 2017-04-19T13:46:39  *** owowo has joined #bitcoin-core-dev
227 2017-04-19T13:46:40  *** owowo has joined #bitcoin-core-dev
228 2017-04-19T13:50:12  *** d_t has joined #bitcoin-core-dev
229 2017-04-19T13:54:17  *** RubenSomsen has quit IRC
230 2017-04-19T14:04:22  *** timothy has joined #bitcoin-core-dev
231 2017-04-19T14:08:00  *** talmai has joined #bitcoin-core-dev
232 2017-04-19T14:13:13  *** goksinen has joined #bitcoin-core-dev
233 2017-04-19T14:17:17  *** goksinen has quit IRC
234 2017-04-19T14:19:34  <BlueMatt> sipa: re #10148: I'm still super unconvinced that multi-head is worth it. in the future optimization space of "flush in chunks in the background", there is relatively little harm in requiring that mid-flush-states be in only one direction - either you're during ibd, in which cas I'd certainly hope this is already the case, or you're not in which case it should be relatively rare that your disk cant keep up and enforcing a
235 2017-04-19T14:19:35  <BlueMatt> fully-flushed state prior to block disconnect seems perfectly reasonable
236 2017-04-19T14:19:38  <gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
237 2017-04-19T14:19:52  <BlueMatt> sipa: not to mention multihead is super hard to review right now since we dont even have the write side of it implemented
238 2017-04-19T14:20:00  <BlueMatt> so the assumptions on the read side just seem arbitrary
239 2017-04-19T14:20:07  <BlueMatt> (and complicated)
240 2017-04-19T14:20:14  <sipa> BlueMatt: i don't think it's reasonanle to require a full flush before a reorg
241 2017-04-19T14:21:04  <sipa> reorgs should lead to network-wide slowdowns
242 2017-04-19T14:21:29  <sipa> and the write side is partially implemented; i'm writing a test for it now
243 2017-04-19T14:24:22  *** n1ce has joined #bitcoin-core-dev
244 2017-04-19T14:25:07  <BlueMatt> sipa: why? if your node cant finish flushing its state before the next block comes in 9 times out of 10 you have no hope of staying up to date anyway
245 2017-04-19T14:25:36  <sipa> BlueMatt: the idea is that you'd be flushing continuously
246 2017-04-19T14:25:42  <sipa> and never fully flush
247 2017-04-19T14:25:49  <BlueMatt> sipa: why?
248 2017-04-19T14:25:55  <BlueMatt> why would you want to never fully flush
249 2017-04-19T14:26:00  <BlueMatt> that'd mean startup would always be painfully slow
250 2017-04-19T14:26:01  <sipa> because wiping your cache is retarded
251 2017-04-19T14:26:16  <BlueMatt> well then dont wipe cache when you flush :)
252 2017-04-19T14:26:25  <BlueMatt> thats an orthogonal issue, i think
253 2017-04-19T14:26:29  <sipa> it isn't
254 2017-04-19T14:26:39  <sipa> if you don't wipe when you flush, you need to flush more frequently
255 2017-04-19T14:26:59  <sipa> and we've benchmarked that (before non-atomic flush)... it's slower
256 2017-04-19T14:26:59  <BlueMatt> what happened to always flushing in the background?
257 2017-04-19T14:27:40  <sipa> we're already flushing outside of normal block connection
258 2017-04-19T14:27:54  *** RubenSomsen has joined #bitcoin-core-dev
259 2017-04-19T14:27:59  <sipa> it's still just more CPU to not wipe your cache
260 2017-04-19T14:28:08  <morcos> sipa: at the very least this is an unnecessarily complicated optimization for right now
261 2017-04-19T14:28:11  <sipa> (again, before non-atomic)
262 2017-04-19T14:28:34  <morcos> this code is difficult to reason about with high certainty and i think BlueMatt is right that multi-head really compounds that
263 2017-04-19T14:28:48  <morcos> If we decide we need it later, we can discuss it then...
264 2017-04-19T14:29:08  <sipa> morcos: i think both the test code i'm writing and the recovery code would he hardly any simpler without it
265 2017-04-19T14:29:23  <sipa> it still needs to be able to deal with reorgs, just not multi-headed ones
266 2017-04-19T14:29:24  <morcos> Ideally I think we would do #10195 first and not make that contingent on 10148 (w or w/o multihead)
267 2017-04-19T14:29:26  <gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
268 2017-04-19T14:29:37  <sipa> oh
269 2017-04-19T14:29:42  <sipa> that's certainly possible
270 2017-04-19T14:30:54  <morcos> the issue i see with 10148 is that it seems like a lot of complication to solve a relatively simple problem about the way leveldb flushes...   it seems to me it would make more sense to review flush/don't erase strategies with 10195 as a first step
271 2017-04-19T14:30:59  <BlueMatt> sipa: I'm more than happy to revisit multihead after per-utxo, but right now I'm super worried about the complication in it
272 2017-04-19T14:31:29  <sipa> BlueMatt: if i put an assert(blockhead.size() == 2), would you be happy about it?
273 2017-04-19T14:31:44  <morcos> maybe we eventually want to do 10148, but i'm hesitant to rework cache writiing in 2 big ways at the same time...
274 2017-04-19T14:32:01  <sipa> i think 10148 is much more urgent
275 2017-04-19T14:32:17  <sipa> it dramatically changes our memory usage
276 2017-04-19T14:32:25  <morcos> so does 10195?
277 2017-04-19T14:32:38  <sipa> how so?
278 2017-04-19T14:32:57  <morcos> for the same cache performance you can have a much smaller cache
279 2017-04-19T14:33:29  <sipa> eh, slightly
280 2017-04-19T14:33:55  <sipa> anyway, i'm happy to rebase 10195 without 10148
281 2017-04-19T14:34:04  <sipa> i just assumed we'd want 10148 sooner
282 2017-04-19T14:34:39  *** RubenSomsen has quit IRC
283 2017-04-19T14:34:45  <BlueMatt> sipa: possibly I'd be ok with an assert like that, but then why have the much more complicated code in our consensus logic when we can push that review to when we actually remove the assert, right where it should be? Otherwise you have dormant code and people wont sufficiently review it when it becomes active?
284 2017-04-19T14:34:51  <morcos> really?  only slightly?  i haven't tested 10195 yet, but it was my memory that a lot of the cache mem usage was taken up with dead weight from txs you bring along
285 2017-04-19T14:35:00  <BlueMatt> I tend to agree that I like 10148, personally
286 2017-04-19T14:35:15  <BlueMatt> i mean both, dont really care tooo much about order, just dont think we need to worry about multi-head
287 2017-04-19T14:35:22  <sipa> morcos: but with 10195 you get duplication instead
288 2017-04-19T14:35:39  <morcos> in memory?
289 2017-04-19T14:35:41  <sipa> yes
290 2017-04-19T14:35:54  <morcos> oh i havent' reveiwed 10195 yet, i was envisioning a structure without duplication
291 2017-04-19T14:35:55  <sipa> if multiple outputs for the same tx are in the cache, they become independent entries
292 2017-04-19T14:36:03  <morcos> like a multi level cache
293 2017-04-19T14:36:20  <sipa> we can think about that later, first switch the model to be per-txout
294 2017-04-19T14:36:44  <morcos> ok, well i'll shut up until i review more... but i have to say, the complication of 10148 turns me off from getting to 10195!
295 2017-04-19T14:37:00  <sipa> have you seen the commit i just added to 10148?
296 2017-04-19T14:37:35  <sipa> well, yesterdat
297 2017-04-19T14:37:40  <morcos> Yes...  And the part that is confusing is the Multiple reorganizations
298 2017-04-19T14:37:55  <morcos> Thats still not clear to me exactly what scenario you guys are envisioning that results in that
299 2017-04-19T14:38:20  <BlueMatt> frankly, we only have 2.5 months before 0.15 feature freeze, and we're gonna get in half of what people are PRing these days
300 2017-04-19T14:38:37  <sipa> multiple reorgs, with partial flushing
301 2017-04-19T14:38:40  <morcos> the rest of that comment is very good though
302 2017-04-19T14:38:58  * BlueMatt is entirely unconvinced thats a thing we need to ever worry about
303 2017-04-19T14:39:21  <BlueMatt> unless we never fully flush, but if we never fully flush startup will /always/ be painfully slow
304 2017-04-19T14:39:25  <BlueMatt> which i also dont think is acceptable
305 2017-04-19T14:39:38  <sipa> how so?
306 2017-04-19T14:39:44  <sipa> it would just lag a few blocks behind
307 2017-04-19T14:40:01  <sdaftuar> how would it only be a few blocks behind?
308 2017-04-19T14:40:35  <sipa> at least it's configurable... during IBD it could lag behind more
309 2017-04-19T14:40:53  <BlueMatt> during ibd you only need single-head, though, I think
310 2017-04-19T14:40:58  <BlueMatt> it should be pretty much all serial
311 2017-04-19T14:41:08  <sipa> sure, but i don't want two separate recovery algorithms
312 2017-04-19T14:41:15  <BlueMatt> huh?
313 2017-04-19T14:41:42  <morcos> I just think its too many steps at once...   Matt and Suhas are trying to explain to me what the series of events that happens here is and I just don't understand
314 2017-04-19T14:41:49  <BlueMatt> sipa: I'm saying never support recovery of multiple reorgs at once
315 2017-04-19T14:42:09  <sipa> BlueMatt: it's maybe 5 lines less code!
316 2017-04-19T14:42:28  <sipa> instead of rolling back from one branch, you roll back from all of them
317 2017-04-19T14:42:31  <morcos> I don't understand what a partial flush is
318 2017-04-19T14:42:39  <sipa> morcos: write some of the entries in your cache to disk
319 2017-04-19T14:42:45  <sipa> instead of all
320 2017-04-19T14:42:46  <morcos> And then what?
321 2017-04-19T14:42:53  <BlueMatt> and then...thats it?
322 2017-04-19T14:42:54  <sipa> continue
323 2017-04-19T14:43:18  <sipa> you're running out of memory, pick a few dirty entries in the cache, and write those to disk
324 2017-04-19T14:43:24  <sipa> and perhaps delete a few non-dirty entries
325 2017-04-19T14:43:26  <sipa> and continue
326 2017-04-19T14:43:38  <sipa> there are tons of tweaks and analysis possible to find good strategies
327 2017-04-19T14:43:48  <sipa> but non-atomic flushing makes all of it safe
328 2017-04-19T14:43:55  <BlueMatt> sipa: but 20 more edge cases in consensus code, 30 more lines of comments to explain why its ok. the previous stuff was very reviewable, now its super tricky unless we /also/ implement the write side (I know you said you have that, but can we leave that for a separate pr?)
329 2017-04-19T14:44:03  <morcos> So while you are writing those entries, no one else is modifying the cache...  but then you give up the lock before you've flushed the whole cache, so then when people modify the cache more..  ok i guess  i get it.
330 2017-04-19T14:44:19  <morcos> But why can't we save that for a later "improvement" , why is it necessary now?
331 2017-04-19T14:44:34  <sipa> morcos: because the algorithm is the same
332 2017-04-19T14:44:35  *** tripleslash has quit IRC
333 2017-04-19T14:44:47  <sipa> can we just put an assert in it, that forces it to be the simple case?
334 2017-04-19T14:45:00  <sipa> so you can review it assuming it only needs to deal with the simple case
335 2017-04-19T14:45:10  <morcos> What am I missing, why do you want to have the code there if we are not using it?
336 2017-04-19T14:45:23  <sipa> it's 5 lines...
337 2017-04-19T14:45:29  <sipa> yes, i can remove it
338 2017-04-19T14:46:47  *** tripleslash has joined #bitcoin-core-dev
339 2017-04-19T14:47:01  <sipa> but it's nice to at least have the database format support multihead, so it's not yet another backward compatible upgrade that needs upgrade
340 2017-04-19T14:47:25  <BlueMatt> hardly? just means you cant downgrade after an unclear shutdown?
341 2017-04-19T14:47:38  * BlueMatt is much less concerned about that
342 2017-04-19T14:47:38  <sipa> plus new code that needs to deal with the old case
343 2017-04-19T14:47:41  <BlueMatt> but maybe others are?
344 2017-04-19T14:47:49  <sdaftuar> you can still downgrade with a -reindex-chainstate!
345 2017-04-19T14:47:57  <sipa> ok...
346 2017-04-19T14:49:13  <sipa> would you be fine with a database format that just has a record saying "rollback block X, rollforward block Y, rollback block Z", and the recovery code literally follows those steps?
347 2017-04-19T14:49:52  <sipa> actually, that's pretty complicated on the write side
348 2017-04-19T14:50:40  <BlueMatt> possibly, though the "might have had stuff from a future branch way down the line partially flushed" stuff just makes it harder to review consensus-critical crap
349 2017-04-19T14:51:14  <sipa> sigh, ok, i'll try to simplify the code as much as possible to only deal with a single reorg
350 2017-04-19T14:51:28  <morcos> sipa: i'm not sure that your approach is wrong..  i think its just a lot to hit someone all at once in thinking about it
351 2017-04-19T14:51:39  <sipa> morcos: fair enough
352 2017-04-19T14:51:49  <BlueMatt> sipa: thanks, now lets get this all merged for 0.14 =D
353 2017-04-19T14:51:52  <BlueMatt> ehh, 15
354 2017-04-19T14:51:54  <morcos> you might be right that it is a more elegant approach if you have this end goal in mind down the road
355 2017-04-19T14:52:22  <morcos> but we're stuck trying to recreate the logical progression you went through to end up there
356 2017-04-19T14:52:28  <sipa> understood
357 2017-04-19T14:52:49  <sdaftuar> sipa: did you ever test the performance of flush-without-wiping with a per-utxo model?
358 2017-04-19T14:52:50  <morcos> that said... i'm getting more comfortable with it after hashing it out a bit
359 2017-04-19T14:53:42  <sipa> sdaftuar: i haven't
360 2017-04-19T14:56:00  *** pepe__ has quit IRC
361 2017-04-19T14:57:10  *** nu11p7r has joined #bitcoin-core-dev
362 2017-04-19T15:02:02  <morcos> sipa: another simple improvement would be to instead of having a 2.0x factor for cache memory usage to just track usage =  all cache usage + dirty coins usage
363 2017-04-19T15:02:49  <sipa> morcos: i really hope that the non-atomic flushing after simplifying will be simple enough to be reviewed
364 2017-04-19T15:03:58  *** Giszmo has joined #bitcoin-core-dev
365 2017-04-19T15:20:06  *** tripleslash has quit IRC
366 2017-04-19T15:21:26  *** tripleslash has joined #bitcoin-core-dev
367 2017-04-19T15:24:09  <sdaftuar> wumpus: i think #9942 is ready for merge
368 2017-04-19T15:24:11  <gribble> https://github.com/bitcoin/bitcoin/issues/9942 | Refactor CBlockPolicyEstimator by morcos · Pull Request #9942 · bitcoin/bitcoin · GitHub
369 2017-04-19T15:24:52  <bitcoin-git> [bitcoin] jet0 opened pull request #10230: Merge pull request #1 from bitcoin/master (master...freeze) https://github.com/bitcoin/bitcoin/pull/10230
370 2017-04-19T15:25:03  <bitcoin-git> [bitcoin] jet0 closed pull request #10230: Merge pull request #1 from bitcoin/master (master...freeze) https://github.com/bitcoin/bitcoin/pull/10230
371 2017-04-19T15:29:19  *** tripleslash has quit IRC
372 2017-04-19T15:31:44  <jonasschnelli> I have significant freezes in the GUI with current master catching up a couple of days on mainnet..
373 2017-04-19T15:32:48  *** tripleslash has joined #bitcoin-core-dev
374 2017-04-19T15:33:01  <jonasschnelli> I think this was re-introduced with https://github.com/bitcoin/bitcoin/pull/9583
375 2017-04-19T15:33:26  <jonasschnelli> Although not sure...
376 2017-04-19T15:34:42  <Lauda> ^happens to me occasionally in 0.14.0
377 2017-04-19T15:36:00  <BlueMatt> jonasschnelli: great! review #10179 :p
378 2017-04-19T15:36:02  <gribble> https://github.com/bitcoin/bitcoin/issues/10179 | Give CValidationInterface Support for calling notifications on the CScheduler Thread by TheBlueMatt · Pull Request #10179 · bitcoin/bitcoin · GitHub
379 2017-04-19T15:36:07  *** n1ce has quit IRC
380 2017-04-19T15:38:39  <jonasschnelli> BlueMatt: Oh... I totally forgot that one.. thanks. Will try.
381 2017-04-19T15:41:22  <BlueMatt> jonasschnelli: that doesnt do anything by itself
382 2017-04-19T15:41:26  <BlueMatt> the real change is the pr after it
383 2017-04-19T15:41:29  <BlueMatt> but its blocking :)
384 2017-04-19T15:41:33  <jonasschnelli> Okay... thanks.
385 2017-04-19T15:41:55  <jonasschnelli> I think the freezes i face are caused by something different then the 9583
386 2017-04-19T15:43:03  <sipa> BlueMatt: ha, blocking.
387 2017-04-19T15:44:43  <BlueMatt> lol
388 2017-04-19T15:45:20  <BlueMatt> jonasschnelli: you may still wish to test my branch which is based on that (https://github.com/TheBlueMatt/bitcoin/tree/2017-01-wallet-cache-inmempool-4, I think, though i believe travis didnt like it last time, i need to go back and fix it prior to pring it)
389 2017-04-19T15:45:25  <BlueMatt> would be good feedback if it is faster :)
390 2017-04-19T15:46:00  <jonasschnelli> BlueMatt: Yes. I'll give it a try and a review once I have tracked the current freeze down
391 2017-04-19T15:46:11  <jonasschnelli> *tracked down the current freeze
392 2017-04-19T15:52:23  <cfields> jonasschnelli: https://github.com/bitcoin/bitcoin/issues/10209#issuecomment-295311664
393 2017-04-19T15:52:27  <cfields> $10 says it's that :)
394 2017-04-19T15:53:20  <jonasschnelli> cfields: But don't I need https://github.com/bitcoin/bitcoin/issues/10228?
395 2017-04-19T15:53:54  <cfields> jonasschnelli: 10228 just keeps it from happening in the future. Problem is that your bitcoin-config.h is busted atm
396 2017-04-19T15:54:03  <cfields> (i strongly suspect, anyway)
397 2017-04-19T15:54:20  <jonasschnelli> ah... I see. That seams reasonable...
398 2017-04-19T15:55:09  <cfields> jonasschnelli: specifically MSG_DONTWAIT. Are you seeing a warning about it when you build?
399 2017-04-19T15:55:23  <jonasschnelli> oh.. maybe. :|
400 2017-04-19T15:55:52  <cfields> if so, this is your problem, and autogen will fix you right up.
401 2017-04-19T15:56:49  *** d9b4bef9 has quit IRC
402 2017-04-19T15:57:56  *** d9b4bef9 has joined #bitcoin-core-dev
403 2017-04-19T16:05:42  <bitcoin-git> [bitcoin] jonasschnelli opened pull request #10231: [Qt] Reduce a significant cs_main lock freeze (master...2017/04/qt_freeze) https://github.com/bitcoin/bitcoin/pull/10231
404 2017-04-19T16:08:13  <cfields> jonasschnelli: why not subscribe to UpdatedBlockTip() and cache it there?
405 2017-04-19T16:14:31  <jonasschnelli> cfields: IMO we don't have a signal that covers the bestheader (not bestblock)
406 2017-04-19T16:14:36  *** abpa has joined #bitcoin-core-dev
407 2017-04-19T16:15:34  <jonasschnelli> ermm... we have NotifyHeaderTip
408 2017-04-19T16:15:37  *** Guyver2 has quit IRC
409 2017-04-19T16:16:40  <jonasschnelli> cfields: Do you think it would be preferable to cache it in the GUI clientmodel instead of the core validation part (validation.cpp)?
410 2017-04-19T16:16:44  <cfields> jonasschnelli: heh, I just grepped to the same conclusion :)
411 2017-04-19T16:17:14  <jonasschnelli> cfields: Yes. I could cache it in "static void BlockTipChanged(ClientModel *clientmodel, bool initialSync, const CBlockIndex *pIndex, bool fHeader)"
412 2017-04-19T16:17:18  <jonasschnelli> when fHeader == true
413 2017-04-19T16:17:40  <cfields> jonasschnelli: i think it makes sense for each subsystem to maintain their own view of those things, yes
414 2017-04-19T16:17:54  <jonasschnelli> Yes. Let me change this... I don't think there are valid use cases outside the GUI
415 2017-04-19T16:17:59  <cfields> (not sure everyone would agree with that, but that's the direction we've been moving in)
416 2017-04-19T16:18:01  <jonasschnelli> cfields: indeed.
417 2017-04-19T16:19:49  <cfields> jonasschnelli: the exception obviously being if you need atomic access to a few locally cached things, in which case you have to be careful to keep everything in sync. But if it's just for the gui, I think caching it there makes sense.
418 2017-04-19T16:20:22  <jonasschnelli> Yes. Right... i'll change the PR
419 2017-04-19T16:24:52  *** laurentmt has joined #bitcoin-core-dev
420 2017-04-19T16:28:20  *** Dyaheon has quit IRC
421 2017-04-19T16:31:53  *** Dyaheon has joined #bitcoin-core-dev
422 2017-04-19T16:32:53  *** timothy has quit IRC
423 2017-04-19T16:34:23  *** BashCo has quit IRC
424 2017-04-19T16:37:24  <cfields> jonasschnelli: any reason we can't do the same thing for the other cs_main takers in there?
425 2017-04-19T16:37:45  <jonasschnelli> cfields: Yes. We should do similar things there... i'll have a look
426 2017-04-19T16:37:50  <cfields> (adding new ui events, i mean)
427 2017-04-19T16:37:50  *** talmai has quit IRC
428 2017-04-19T16:39:30  <cfields> jonasschnelli: great :)
429 2017-04-19T16:41:34  *** [\\\] has joined #bitcoin-core-dev
430 2017-04-19T16:41:57  *** tripleslash has quit IRC
431 2017-04-19T16:42:28  <morcos> Here is my attempt at a high level description of the current fee estimation algorithm.
432 2017-04-19T16:42:31  <morcos> https://gist.github.com/morcos/d3637f015bc4e607e1fd10d8351e9f41
433 2017-04-19T16:42:47  <morcos> gmaxwell: Please let me know if ^ is what you had in mind
434 2017-04-19T16:43:07  <morcos> I thought it best to explain the basic concept of how it currently works without getting into the changes yet
435 2017-04-19T16:46:25  <bitcoin-git> [bitcoin] luke-jr opened pull request #10232: release-notes: Accurately explain getblocktemplate improvements (0.14...0.14_relnotes_mining) https://github.com/bitcoin/bitcoin/pull/10232
436 2017-04-19T16:49:57  <sipa> morcos: very clear
437 2017-04-19T16:50:20  <bitcoin-git> [bitcoin] jet0 opened pull request #10233: Wallet: Support not reusing addresses (master...freezea) https://github.com/bitcoin/bitcoin/pull/10233
438 2017-04-19T16:52:52  <morcos> sipa: heh, had a bug in it though!
439 2017-04-19T16:58:49  *** [\\\] has quit IRC
440 2017-04-19T16:59:53  <bitcoin-git> [bitcoin] jnewbery opened pull request #10234: [net] listbanned RPC and QT should show correct banned subnets (master...list_banned_correctly) https://github.com/bitcoin/bitcoin/pull/10234
441 2017-04-19T17:00:50  *** tripleslash has joined #bitcoin-core-dev
442 2017-04-19T17:07:26  *** BashCo has joined #bitcoin-core-dev
443 2017-04-19T17:09:00  *** tw2006 has quit IRC
444 2017-04-19T17:13:03  <sipa> BlueMatt, morcos, sdaftuar: i hope it's easier to review now
445 2017-04-19T17:13:14  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10235: Track keypool entries as internal vs external in memory (master...2017-04-wallet-more-keypool-cache) https://github.com/bitcoin/bitcoin/pull/10235
446 2017-04-19T17:13:14  <sipa> i'll leave the WIP marker in until I had a test for the reorganization
447 2017-04-19T17:13:14  <sdaftuar> sipa: thanks, i'm taking a look
448 2017-04-19T17:13:59  <BlueMatt> sipa: thanks, will review
449 2017-04-19T17:14:57  <jonasschnelli> BlueMatt: re: https://github.com/bitcoin/bitcoin/pull/10184#issuecomment-295350649
450 2017-04-19T17:14:59  <jonasschnelli> Yes. Makse sense..
451 2017-04-19T17:15:10  <jonasschnelli> though the argument of "little money" is dangerous..
452 2017-04-19T17:15:18  <sipa> sdaftuar, BlueMatt: thank you
453 2017-04-19T17:15:32  <jonasschnelli> Years back some of us probably had little money on VPS's which now has worth a six digit number. :)
454 2017-04-19T17:15:51  <jonasschnelli> And while you move your keys away from your VPS,... there is no guarantee they where not compromised..
455 2017-04-19T17:16:11  <jonasschnelli> the security requirements can change over time and most people won't sweep the funds to a new address
456 2017-04-19T17:16:14  * sipa remembers the linode hack
457 2017-04-19T17:16:54  <sipa> but agree that there is not argument why it shouldn't work
458 2017-04-19T17:16:55  <jonasschnelli> But I know... i also run nodes on external root servers and sometimes,.. they have a some test mainnet coins
459 2017-04-19T17:17:00  <BlueMatt> jonasschnelli: I'm not saying its a *good* idea, just that if people want to do it we shouldnt try to break it
460 2017-04-19T17:17:04  <sipa> new key creation performance has been horrible for ages
461 2017-04-19T17:17:11  <BlueMatt> (some people buy insurance, too :p)
462 2017-04-19T17:17:16  <sipa> we should improve that when we can, period
463 2017-04-19T17:18:15  <jonasschnelli> Yes. Sure... I just in general think it's good to show some critical respons whenever someone mentions AWS or Azure. :)
464 2017-04-19T17:18:23  <BlueMatt> fair
465 2017-04-19T17:18:38  <sipa> btw
466 2017-04-19T17:18:48  * sipa had a bitcoind with wallet on a vps, and its money was stolen
467 2017-04-19T17:18:56  <jonasschnelli> see! :-)
468 2017-04-19T17:18:57  <BlueMatt> lol
469 2017-04-19T17:19:08  <sipa> though i do consider that my own damned fault
470 2017-04-19T17:19:12  <jonasschnelli> so it even happens to core devs. :)
471 2017-04-19T17:39:33  *** talmai has joined #bitcoin-core-dev
472 2017-04-19T17:44:04  *** talmai has quit IRC
473 2017-04-19T17:45:00  *** vicenteH has quit IRC
474 2017-04-19T17:49:50  *** talmai has joined #bitcoin-core-dev
475 2017-04-19T17:52:10  *** tripleslash has quit IRC
476 2017-04-19T17:54:34  *** talmai has quit IRC
477 2017-04-19T17:55:39  *** arowser_ has joined #bitcoin-core-dev
478 2017-04-19T17:56:05  *** fao1 has joined #bitcoin-core-dev
479 2017-04-19T17:58:06  *** arowser has quit IRC
480 2017-04-19T17:58:06  *** fao has quit IRC
481 2017-04-19T17:58:06  *** tripleslash has joined #bitcoin-core-dev
482 2017-04-19T18:01:22  <gmaxwell> BlueMatt:  I don't understand your complaint about multiple head. It's strictly safer than not having it.
483 2017-04-19T18:02:13  <gmaxwell> I agree it will be easier to reason about the effects of multi-head after were're per-txout, and I expect we won't make intentional use of it until then.
484 2017-04-19T18:04:39  <sipa> gmaxwell: multi-head is only needed once we do multiple partial flushes
485 2017-04-19T18:05:36  <sipa> gmaxwell: we *do* need reorg support immediately, but not necessarily support for multiple reorgs at once
486 2017-04-19T18:05:44  *** SopaXorzTaker has quit IRC
487 2017-04-19T18:07:12  <BlueMatt> gmaxwell: I'm happy to re-review post-per-utxo
488 2017-04-19T18:08:34  <BlueMatt> but right now the review burden is high, and I'm not convinced of its usefulness unless we actually have a write side that we're gonna merge :)
489 2017-04-19T18:09:12  <sipa> BlueMatt: well the advantage would be not breaking backward compatibility
490 2017-04-19T18:09:20  <sipa> but per-txout will break that anyway
491 2017-04-19T18:09:26  <BlueMatt> yes, also not sold on that :)
492 2017-04-19T18:09:27  <BlueMatt> indeed
493 2017-04-19T18:09:47  <gmaxwell> the same code fixes reorgs to that, the extra stuff that does things for multi-head is just a no-op otherwise.
494 2017-04-19T18:10:29  <BlueMatt> gmaxwell: can we not have no-ops in consensus-critical logic?
495 2017-04-19T18:11:36  <gmaxwell> so then if there is some corner case we should corrupt the state rather than just handling it?
496 2017-04-19T18:12:12  <sipa> gmaxwell: there is no way we can now end up in a situation that needs multi-head support
497 2017-04-19T18:12:34  <sipa> unless there is a bug in the code, and in that case it's unlikely the multi-head code actually does the right thing
498 2017-04-19T18:14:00  <sipa> my reason for having it in the first place was because i don't consider it much more complicated, so it's easier to get it in now than changing it again later
499 2017-04-19T18:14:09  <sipa> but it seems people disagree it's easy to understand
500 2017-04-19T18:16:17  *** chartractegg has joined #bitcoin-core-dev
501 2017-04-19T18:33:40  *** d_t has joined #bitcoin-core-dev
502 2017-04-19T18:35:42  *** Dyaheon has quit IRC
503 2017-04-19T18:36:29  *** Dyaheon has joined #bitcoin-core-dev
504 2017-04-19T18:49:13  <luke-jr> wumpus: might make sense to backport #10207
505 2017-04-19T18:49:15  <gribble> https://github.com/bitcoin/bitcoin/issues/10207 | Clarify importprivkey help text ... example of blank label without rescan by wtogami · Pull Request #10207 · bitcoin/bitcoin · GitHub
506 2017-04-19T18:50:26  *** tw2006 has joined #bitcoin-core-dev
507 2017-04-19T18:51:48  *** chartractegg has quit IRC
508 2017-04-19T18:54:58  *** tw2006 has quit IRC
509 2017-04-19T18:58:38  <luke-jr> why is abortrescan not allowed in safe mode?
510 2017-04-19T18:58:55  <sipa> lol
511 2017-04-19T19:02:34  *** tw2006 has joined #bitcoin-core-dev
512 2017-04-19T19:07:39  <jonasschnelli> luke-jr: heh... is that already merged?
513 2017-04-19T19:07:57  <luke-jr> seems so
514 2017-04-19T19:25:35  *** talmai has joined #bitcoin-core-dev
515 2017-04-19T19:33:35  *** jtimon has quit IRC
516 2017-04-19T19:45:11  *** chjj has quit IRC
517 2017-04-19T19:54:42  *** vicenteH has joined #bitcoin-core-dev
518 2017-04-19T19:56:40  <luke-jr> Travis jobs are randomly cancelling?
519 2017-04-19T19:59:04  *** chjj has joined #bitcoin-core-dev
520 2017-04-19T20:04:14  *** chjj has quit IRC
521 2017-04-19T20:04:15  <BlueMatt> luke-jr: they do that automagically if you force push before they run now
522 2017-04-19T20:07:21  <luke-jr> BlueMatt: it doesn't *look* like jonasschnelli is force-pushing on #10231
523 2017-04-19T20:07:23  <gribble> https://github.com/bitcoin/bitcoin/issues/10231 | [Qt] Reduce a significant cs_main lock freeze by jonasschnelli · Pull Request #10231 · bitcoin/bitcoin · GitHub
524 2017-04-19T20:07:39  <BlueMatt> luke-jr: oh, then i dont know
525 2017-04-19T20:07:47  <BlueMatt> i think people can also manually cancel their own jobs
526 2017-04-19T20:07:53  <BlueMatt> maybe someone hit it on accident
527 2017-04-19T20:08:07  <luke-jr> hmm
528 2017-04-19T20:10:36  *** tw2006 has quit IRC
529 2017-04-19T20:10:38  *** justanotheruser has quit IRC
530 2017-04-19T20:13:58  *** talmai has quit IRC
531 2017-04-19T20:16:07  *** chjj has joined #bitcoin-core-dev
532 2017-04-19T20:16:10  *** Guest36442 has quit IRC
533 2017-04-19T20:16:50  *** jtimon has joined #bitcoin-core-dev
534 2017-04-19T20:16:58  *** juscamarena has joined #bitcoin-core-dev
535 2017-04-19T20:17:20  *** juscamarena is now known as Guest12838
536 2017-04-19T20:21:10  *** chjj has quit IRC
537 2017-04-19T20:26:49  *** CubicEarth has joined #bitcoin-core-dev
538 2017-04-19T20:31:46  *** goksinen has joined #bitcoin-core-dev
539 2017-04-19T20:35:03  *** chjj has joined #bitcoin-core-dev
540 2017-04-19T20:36:34  *** goksinen has quit IRC
541 2017-04-19T20:55:29  *** talmai has joined #bitcoin-core-dev
542 2017-04-19T21:00:13  *** talmai has quit IRC
543 2017-04-19T21:13:46  *** vicenteH` has joined #bitcoin-core-dev
544 2017-04-19T21:15:56  *** vicenteH has quit IRC
545 2017-04-19T21:17:11  *** CubicEarth has quit IRC
546 2017-04-19T21:20:29  *** e4xit has joined #bitcoin-core-dev
547 2017-04-19T21:20:43  *** chjj has quit IRC
548 2017-04-19T21:29:20  *** d_t has quit IRC
549 2017-04-19T21:34:52  *** chjj has joined #bitcoin-core-dev
550 2017-04-19T21:36:53  *** belcher has joined #bitcoin-core-dev
551 2017-04-19T21:41:19  *** chjj has quit IRC
552 2017-04-19T21:55:19  *** chjj has joined #bitcoin-core-dev
553 2017-04-19T21:59:32  *** tw2006 has joined #bitcoin-core-dev
554 2017-04-19T22:01:44  *** chjj has quit IRC
555 2017-04-19T22:04:39  *** tw2006 has quit IRC
556 2017-04-19T22:10:58  *** AaronvanW has quit IRC
557 2017-04-19T22:15:46  *** chjj has joined #bitcoin-core-dev
558 2017-04-19T22:17:32  *** Giszmo has quit IRC
559 2017-04-19T22:20:20  *** chjj has quit IRC
560 2017-04-19T22:22:20  *** Naphex has quit IRC
561 2017-04-19T22:22:37  *** Naphex has joined #bitcoin-core-dev
562 2017-04-19T22:33:29  *** jannes has quit IRC
563 2017-04-19T22:33:47  *** chjj has joined #bitcoin-core-dev
564 2017-04-19T22:35:05  *** Dyaheon has quit IRC
565 2017-04-19T22:36:05  *** Giszmo has joined #bitcoin-core-dev
566 2017-04-19T22:38:54  *** Dyaheon has joined #bitcoin-core-dev
567 2017-04-19T22:50:16  *** CubicEarth has joined #bitcoin-core-dev
568 2017-04-19T22:55:59  *** Giszmo has quit IRC
569 2017-04-19T23:15:45  *** Giszmo has joined #bitcoin-core-dev
570 2017-04-19T23:27:57  *** dermoth has quit IRC
571 2017-04-19T23:48:27  *** tw2006 has joined #bitcoin-core-dev
572 2017-04-19T23:48:49  *** CubicEarth has quit IRC
573 2017-04-19T23:53:09  *** tw2006 has quit IRC
574 2017-04-19T23:56:01  *** d_t has joined #bitcoin-core-dev