1 2017-05-05T00:12:38  *** goksinen has joined #bitcoin-core-dev
  2 2017-05-05T00:12:57  <luke-jr> it seems that my system univalue returns a temporary, and for some reason Core is including that instead of the embedded univalue :|
  3 2017-05-05T00:13:34  <praxeology> Not sure how "garbage collection" works with std::string.  Does that line make a string array on the stack or is it allocated in heap?
  4 2017-05-05T00:14:14  *** marcoagner has quit IRC
  5 2017-05-05T00:14:23  <sipa> praxeology: c++ has no garbage collection
  6 2017-05-05T00:14:37  *** marcoagner has joined #bitcoin-core-dev
  7 2017-05-05T00:14:41  <sipa> when the variable goes out of scope, it is destroyed
  8 2017-05-05T00:14:46  <luke-jr> what is supposed to add src/univalue/include/ to the include path? it's not there..
  9 2017-05-05T00:15:25  <sipa> praxeology: and strings are always allocated on the heap (in practice), but that's not relevant
 10 2017-05-05T00:15:40  <sipa> praxeology: there is no refcounting for references
 11 2017-05-05T00:16:30  <sipa> some c++ standard libraries implement refcounting for strings internally, but that still only works with different _string_ objects with the same content, not multiple references to the same one
 12 2017-05-05T00:16:43  <luke-jr> oh, system univalue is used by default, as expected, ok
 13 2017-05-05T00:17:04  <luke-jr> so I guess options are: 1) require newer univalue to use system, or 2) rewrite this code to work either way
 14 2017-05-05T00:17:08  *** goksinen has quit IRC
 15 2017-05-05T00:18:12  <luke-jr> it's probably slightly optimised to do num 2
 16 2017-05-05T00:18:49  <luke-jr> is it valid to assign the return std::string temporary to a reference? or is G++ just extra tolerant?
 17 2017-05-05T00:18:57  <gmaxwell> 'system univalue' dear lord, why would that exist?
 18 2017-05-05T00:18:58  <luke-jr> const std::string& account_param = request.params[0].get_str();
 19 2017-05-05T00:19:15  <luke-jr> gmaxwell: because that's the right way to do libraries
 20 2017-05-05T00:19:16  <sipa> luke-jr: it is valid
 21 2017-05-05T00:19:24  <sipa> (i commented on the PR)
 22 2017-05-05T00:20:34  <praxeology> sipa: yea thought so... "it's taking a pointer to a temporary", not sure why you used the word "temporary" there because if allocated on the heap, its not temporary in any way.
 23 2017-05-05T00:20:35  <luke-jr> which PR?
 24 2017-05-05T00:20:51  <luke-jr> praxeology: it's not. if there's no "new", it's not on the heap
 25 2017-05-05T00:20:57  <gmaxwell> luke-jr: if it were actually a library and not some unmaintained code dump that only we use...
 26 2017-05-05T00:21:24  <praxeology> luke-jr: are you sure there is no "new" deeper in the library?
 27 2017-05-05T00:21:25  <sipa> praxeology: 'heap' and 'stack' don't exist in the C++ spec, they're implementation details
 28 2017-05-05T00:21:34  <sipa> praxeology: 'temporary' however exists in the spec
 29 2017-05-05T00:22:05  <sipa> praxeology: a temporary is the result of an expression that returns something by-value, and isn't assigned to a variable
 30 2017-05-05T00:22:30  <bitcoin-git> [bitcoin] luke-jr opened pull request #10341: rpc/wallet: Workaround older UniValue which returns a std::string temporary for get_str (master...rpcwallet_uv_workaround) https://github.com/bitcoin/bitcoin/pull/10341
 31 2017-05-05T00:23:14  <sipa> praxeology: in practice, the std::string is allocated on the stack, but the string object itself allocates the string/length data on the heap
 32 2017-05-05T00:24:43  <sipa> but again, that doesn't matter
 33 2017-05-05T00:24:56  <sipa> the compiler may even optimize part out and not have such objects hit memory at all
 34 2017-05-05T00:25:15  <sipa> what matters is that it's returning an object and not storing it in a variable
 35 2017-05-05T00:26:16  <praxeology> Hm, yea I guess somehow with the automatic out-of scope clearing/freeing/deleting of the actual data... you need to assign the std::string to a stack variable for the duration you want it to exist
 36 2017-05-05T00:26:38  *** tw2006 has joined #bitcoin-core-dev
 37 2017-05-05T00:26:53  <sipa> no, you don't
 38 2017-05-05T00:26:57  <sipa> that's what i just pointed out
 39 2017-05-05T00:27:25  <sipa> you can take a reference to a temporary, and in that case, the lifetime of the temporary is automatically extended as long as the reference exists
 40 2017-05-05T00:27:46  <sipa> but that's done by static analysis by the compiler, not by reference counting
 41 2017-05-05T00:28:16  <praxeology> its returning an object that becomes part of stack, but in order for that to happen you need to assign the object to a variable that exists in the stack
 42 2017-05-05T00:28:34  <sipa> stop talking about stacks, that doesn't matter
 43 2017-05-05T00:30:00  <praxeology> ok, scope somehow.  but that is less clear to me how such works...  I guess we don't have to discuss it here, I can look into it  myself
 44 2017-05-05T00:31:11  *** tw2006 has quit IRC
 45 2017-05-05T00:36:56  <praxeology> const std::string* account = nullptr;
 46 2017-05-05T00:37:38  <praxeology> woops sorry I'll leave you guys alone now
 47 2017-05-05T00:37:42  * luke-jr puts praxeology on the stack
 48 2017-05-05T00:40:27  *** owowo has quit IRC
 49 2017-05-05T00:46:09  *** owowo has joined #bitcoin-core-dev
 50 2017-05-05T00:48:20  *** Ylbam has quit IRC
 51 2017-05-05T00:56:05  *** tw2006 has joined #bitcoin-core-dev
 52 2017-05-05T01:02:52  *** jtimon has quit IRC
 53 2017-05-05T01:34:03  *** dcousens has joined #bitcoin-core-dev
 54 2017-05-05T01:34:39  <dcousens> sipa: "its modifying rng_state, protected by the lock" --- I suppose, for an RNG, racing memcpy of random data isn't as much an issue? :D haha
 55 2017-05-05T01:36:37  <gmaxwell> it's very much an issue, as it could cause arbritary corruption.
 56 2017-05-05T01:36:54  <dcousens> gmaxwell: would it could corruption outside of rng_state though?
 57 2017-05-05T01:36:58  <gmaxwell> Yes.
 58 2017-05-05T01:37:04  <dcousens> OK, then yes, issue
 59 2017-05-05T01:37:20  <gmaxwell> yea, I was just being stupid and thought that was the copy into the output too.
 60 2017-05-05T01:39:00  <dcousens> gmaxwell: ooi, what could I lookup to understand the implications of that, I wasn't aware it could cause arbitrary corruption
 61 2017-05-05T01:39:02  <gmaxwell> dcousens: in C/C++ the compiler is allowed to assume that it has exclusive access to any variable it writes to in a scope for the duration of it (the technical guarentee is more complicated and I don't fully understand it, but this approximation is enough).  So the compiler could do optimizations like temporarily store the stack pointer into memory that it knows it's going to later overwrite.  t
 62 2017-05-05T01:39:08  <gmaxwell> hen copy it back out again before overwriting it.
 63 2017-05-05T01:39:09  <dcousens> gmaxwell: answered as I asked
 64 2017-05-05T01:40:03  <dcousens> cheers
 65 2017-05-05T01:40:11  <gmaxwell> Its very rare for it to _in practice_ cause arbritary corruption, but it's not unheared of.. intel's compiler is a little more prone to crazy stunts that expose things like that than GCC is, but presumably future versions of GCC will keep getting smarter until nothing runs. :)
 66 2017-05-05T01:40:20  *** d_t has joined #bitcoin-core-dev
 67 2017-05-05T01:40:27  <dcousens> ha
 68 2017-05-05T02:00:10  *** dermoth has quit IRC
 69 2017-05-05T02:01:05  *** dermoth has joined #bitcoin-core-dev
 70 2017-05-05T02:03:30  *** laurentmt has quit IRC
 71 2017-05-05T02:13:24  *** goksinen has joined #bitcoin-core-dev
 72 2017-05-05T02:17:08  *** d_t has quit IRC
 73 2017-05-05T02:17:54  *** goksinen has quit IRC
 74 2017-05-05T03:01:16  *** atroxes has quit IRC
 75 2017-05-05T03:02:35  *** atroxes has joined #bitcoin-core-dev
 76 2017-05-05T03:02:39  *** talmai has joined #bitcoin-core-dev
 77 2017-05-05T03:12:28  *** tw2006 has quit IRC
 78 2017-05-05T03:51:01  *** d9b4bef9 has quit IRC
 79 2017-05-05T03:52:19  *** d9b4bef9 has joined #bitcoin-core-dev
 80 2017-05-05T04:13:33  *** tw2006 has joined #bitcoin-core-dev
 81 2017-05-05T04:14:09  *** goksinen has joined #bitcoin-core-dev
 82 2017-05-05T04:17:56  *** tw2006 has quit IRC
 83 2017-05-05T04:18:27  *** goksinen has quit IRC
 84 2017-05-05T04:27:18  *** sw1f7 has joined #bitcoin-core-dev
 85 2017-05-05T04:41:04  *** goksinen has joined #bitcoin-core-dev
 86 2017-05-05T04:50:26  *** goksinen has quit IRC
 87 2017-05-05T04:53:34  *** goksinen has joined #bitcoin-core-dev
 88 2017-05-05T04:58:32  *** goksinen has quit IRC
 89 2017-05-05T05:03:13  *** goksinen has joined #bitcoin-core-dev
 90 2017-05-05T05:08:40  *** goksinen has quit IRC
 91 2017-05-05T05:14:20  *** tw2006 has joined #bitcoin-core-dev
 92 2017-05-05T05:17:01  *** kadoban has quit IRC
 93 2017-05-05T05:19:12  *** tw2006 has quit IRC
 94 2017-05-05T05:37:05  *** iprokg has joined #bitcoin-core-dev
 95 2017-05-05T05:38:43  *** Ylbam has joined #bitcoin-core-dev
 96 2017-05-05T05:44:55  *** iprokg has quit IRC
 97 2017-05-05T05:46:24  *** RubenSomsen has joined #bitcoin-core-dev
 98 2017-05-05T05:49:24  *** talmai has quit IRC
 99 2017-05-05T06:00:07  *** dermoth has quit IRC
100 2017-05-05T06:00:43  <jonasschnelli> <*highlight>	[22:47:52] <BlueMatt:#bitcoin-core-dev> jonasschnelli: you might kill me for #10340, sorry :/
101 2017-05-05T06:00:44  <gribble> https://github.com/bitcoin/bitcoin/issues/10340 | Add harmless missing cs_wallet lock in qt CoinControlDialog by TheBlueMatt · Pull Request #10340 · bitcoin/bitcoin · GitHub
102 2017-05-05T06:00:52  *** dermoth has joined #bitcoin-core-dev
103 2017-05-05T06:00:57  * jonasschnelli looking at 10340
104 2017-05-05T06:02:02  <jonasschnelli> BlueMatt: seems reasonable to me (10340)
105 2017-05-05T06:03:20  *** moli_ has quit IRC
106 2017-05-05T06:03:44  *** moli_ has joined #bitcoin-core-dev
107 2017-05-05T06:07:56  *** moli_ has quit IRC
108 2017-05-05T06:08:19  *** moli_ has joined #bitcoin-core-dev
109 2017-05-05T06:13:05  *** moli_ has quit IRC
110 2017-05-05T06:13:43  *** moli_ has joined #bitcoin-core-dev
111 2017-05-05T06:15:14  *** tw2006 has joined #bitcoin-core-dev
112 2017-05-05T06:20:01  *** tw2006 has quit IRC
113 2017-05-05T06:43:44  *** d_t has joined #bitcoin-core-dev
114 2017-05-05T06:52:57  *** BashCo has quit IRC
115 2017-05-05T07:01:20  *** To7 has quit IRC
116 2017-05-05T07:01:48  *** RubenSomsen has quit IRC
117 2017-05-05T07:05:17  *** goksinen has joined #bitcoin-core-dev
118 2017-05-05T07:09:27  *** goksinen has quit IRC
119 2017-05-05T07:11:43  *** d_t has quit IRC
120 2017-05-05T07:11:58  *** tonikt has joined #bitcoin-core-dev
121 2017-05-05T07:16:09  *** tw2006 has joined #bitcoin-core-dev
122 2017-05-05T07:19:17  *** RubenSomsen has joined #bitcoin-core-dev
123 2017-05-05T07:20:37  *** tw2006 has quit IRC
124 2017-05-05T07:27:53  *** Dyaheon has quit IRC
125 2017-05-05T07:30:26  *** Dyaheon has joined #bitcoin-core-dev
126 2017-05-05T07:31:45  *** tonikt has quit IRC
127 2017-05-05T07:40:09  *** BashCo has joined #bitcoin-core-dev
128 2017-05-05T07:49:04  <jonasschnelli> BlueMatt: Ah.. know I now why you mentioned " you might kill me". Massive layer violation.
129 2017-05-05T08:08:39  *** _anthony_ has joined #bitcoin-core-dev
130 2017-05-05T08:08:45  *** anthonyjd has quit IRC
131 2017-05-05T08:17:05  *** tw2006 has joined #bitcoin-core-dev
132 2017-05-05T08:22:04  *** tw2006 has quit IRC
133 2017-05-05T08:23:22  *** jannes has joined #bitcoin-core-dev
134 2017-05-05T08:26:16  *** gielbier has joined #bitcoin-core-dev
135 2017-05-05T08:30:03  *** Giszmo has quit IRC
136 2017-05-05T08:30:04  *** gielbier has quit IRC
137 2017-05-05T08:50:45  *** vicenteH has joined #bitcoin-core-dev
138 2017-05-05T08:58:11  *** Ylbam has quit IRC
139 2017-05-05T09:05:58  *** goksinen has joined #bitcoin-core-dev
140 2017-05-05T09:11:10  *** goksinen has quit IRC
141 2017-05-05T09:18:03  *** tw2006 has joined #bitcoin-core-dev
142 2017-05-05T09:22:25  *** tw2006 has quit IRC
143 2017-05-05T09:27:38  *** Guyver2 has joined #bitcoin-core-dev
144 2017-05-05T09:37:44  *** marcoagn1 has joined #bitcoin-core-dev
145 2017-05-05T09:37:48  *** marcoagner has quit IRC
146 2017-05-05T10:19:12  *** tw2006 has joined #bitcoin-core-dev
147 2017-05-05T10:23:33  *** tw2006 has quit IRC
148 2017-05-05T10:31:51  *** praxeology has left #bitcoin-core-dev
149 2017-05-05T10:36:24  *** tw2006 has joined #bitcoin-core-dev
150 2017-05-05T10:53:21  *** jtimon has joined #bitcoin-core-dev
151 2017-05-05T11:06:42  *** goksinen has joined #bitcoin-core-dev
152 2017-05-05T11:11:07  *** goksinen has quit IRC
153 2017-05-05T11:54:20  *** Ylbam has joined #bitcoin-core-dev
154 2017-05-05T12:44:34  *** NewLiberty has joined #bitcoin-core-dev
155 2017-05-05T12:56:01  *** [\\\] has joined #bitcoin-core-dev
156 2017-05-05T12:57:02  *** vicenteH` has joined #bitcoin-core-dev
157 2017-05-05T12:57:05  *** mol has joined #bitcoin-core-dev
158 2017-05-05T13:01:38  *** atroxes_ has joined #bitcoin-core-dev
159 2017-05-05T13:01:49  *** Dyaheon- has joined #bitcoin-core-dev
160 2017-05-05T13:02:51  *** Ylbam has quit IRC
161 2017-05-05T13:02:52  *** marcoagn1 has quit IRC
162 2017-05-05T13:02:52  *** vicenteH has quit IRC
163 2017-05-05T13:02:52  *** Dyaheon has quit IRC
164 2017-05-05T13:02:52  *** moli_ has quit IRC
165 2017-05-05T13:02:52  *** atroxes has quit IRC
166 2017-05-05T13:02:52  *** tripleslash has quit IRC
167 2017-05-05T13:02:53  *** mturquette has quit IRC
168 2017-05-05T13:02:54  *** atroxes_ is now known as atroxes
169 2017-05-05T13:07:28  *** goksinen has joined #bitcoin-core-dev
170 2017-05-05T13:09:27  *** marcoagn1 has joined #bitcoin-core-dev
171 2017-05-05T13:11:57  <bitcoin-git> [bitcoin] jtimon closed pull request #10119: Util: Remove ArgsManager wrappers: (master...0.14-args-wrappers) https://github.com/bitcoin/bitcoin/pull/10119
172 2017-05-05T13:12:13  *** goksinen has quit IRC
173 2017-05-05T13:14:28  *** Ylbam has joined #bitcoin-core-dev
174 2017-05-05T13:14:28  *** mturquette has joined #bitcoin-core-dev
175 2017-05-05T13:25:23  *** AaronvanW has joined #bitcoin-core-dev
176 2017-05-05T13:26:28  <jonasschnelli> Collecting stats over CScheduler with a interval of 2000ms (TBD), would it still make sense to collect a timestamp per sample of is CScheduler in general precise enough so we can calculate (index-of-sample * 2000ms) == timeoffset?
177 2017-05-05T13:26:31  *** Ylbam has quit IRC
178 2017-05-05T13:26:31  *** mturquette has quit IRC
179 2017-05-05T13:26:57  *** Ylbam has joined #bitcoin-core-dev
180 2017-05-05T13:27:48  *** mturquette has joined #bitcoin-core-dev
181 2017-05-05T13:28:34  *** laurentmt has joined #bitcoin-core-dev
182 2017-05-05T13:29:02  *** goksinen has joined #bitcoin-core-dev
183 2017-05-05T13:31:42  *** laurentmt has quit IRC
184 2017-05-05T13:31:54  <rafalcpp> dcousens: with any UB in c++, anything can happen. In theory a race condition in some debug code, could make your node start mining dogecoin instead
185 2017-05-05T13:32:49  <dcousens> rafalcpp: haha, I suppose I was simply affirming it was U/B,  not just a product of something else I'd missed
186 2017-05-05T13:33:22  *** goksinen has quit IRC
187 2017-05-05T13:35:38  <bitcoin-git> [bitcoin] jnewbery opened pull request #10342: [tests] Improve mempool_persist test (master...improve_wait_until_test) https://github.com/bitcoin/bitcoin/pull/10342
188 2017-05-05T13:36:14  <Chris_Stewart_5> Is there a way to have two local regtest node share the same chain, while having different wallets?
189 2017-05-05T13:40:00  <instagibbs> Chris_Stewart_5, this is #bitcoin question, but yes
190 2017-05-05T13:46:39  *** talmai has joined #bitcoin-core-dev
191 2017-05-05T13:50:34  *** d_t has joined #bitcoin-core-dev
192 2017-05-05T13:55:04  *** d_t has quit IRC
193 2017-05-05T13:57:19  *** laurentmt has joined #bitcoin-core-dev
194 2017-05-05T13:58:28  *** laurentmt has quit IRC
195 2017-05-05T14:03:07  *** talmai has quit IRC
196 2017-05-05T14:08:10  *** JackH has quit IRC
197 2017-05-05T14:12:13  *** zrts_ has left #bitcoin-core-dev
198 2017-05-05T14:19:23  *** RubenSomsen has quit IRC
199 2017-05-05T14:25:26  <BlueMatt> jonasschnelli: ehh, I didnt feel like making needless copies of everything 3 times
200 2017-05-05T14:25:36  <BlueMatt> but i can do that if you prefer
201 2017-05-05T14:26:39  <jonasschnelli> BlueMatt: I don't like accessing the wallet's insides from outside of walletmodel. We can make an exception,... but I guess ryanofsky has to do more work in case we want process sep.
202 2017-05-05T14:27:06  <BlueMatt> well we can merge ryanofsky's pr first and then maybe extend it even further and never expose COutput outside of wallet
203 2017-05-05T14:27:12  <BlueMatt> ultimately we should move towards ^
204 2017-05-05T14:27:32  <jonasschnelli> Yes. Thats a good point. For intermediate steps, I think it's fine.
205 2017-05-05T14:28:48  <BlueMatt> I mean I'm more than happy to not take 10340 yet and do the real fix, as long as we get it in for 0.15
206 2017-05-05T14:28:52  <BlueMatt> it shouldnt be /too/ hard
207 2017-05-05T14:29:02  <ryanofsky> my pr that stops using coutput/cwallettx (#10244) is ready, just needs review
208 2017-05-05T14:29:04  <gribble> https://github.com/bitcoin/bitcoin/issues/10244 | [qt] Add abstraction layer for accessing node and wallet functionality from gui by ryanofsky · Pull Request #10244 · bitcoin/bitcoin · GitHub
209 2017-05-05T14:33:35  *** Alina-malina has quit IRC
210 2017-05-05T14:35:10  *** QBcrusher__ has quit IRC
211 2017-05-05T14:37:34  *** JackH has joined #bitcoin-core-dev
212 2017-05-05T14:37:52  *** goksinen has joined #bitcoin-core-dev
213 2017-05-05T14:45:04  <BlueMatt> oh, heh, missed that
214 2017-05-05T14:45:06  <BlueMatt> k, will review
215 2017-05-05T14:46:46  <bitcoin-git> [bitcoin] TheBlueMatt closed pull request #10340: Add harmless missing cs_wallet lock in qt CoinControlDialog (master...2017-05-fix-mapwallet-zap-runtime) https://github.com/bitcoin/bitcoin/pull/10340
216 2017-05-05T14:47:37  *** jnewbery has quit IRC
217 2017-05-05T14:48:26  *** jnewbery has joined #bitcoin-core-dev
218 2017-05-05T14:51:43  *** Alina-malina has joined #bitcoin-core-dev
219 2017-05-05T14:52:55  *** tonikt has joined #bitcoin-core-dev
220 2017-05-05T14:59:09  *** Alina-malina has quit IRC
221 2017-05-05T14:59:10  *** Alina-malina has joined #bitcoin-core-dev
222 2017-05-05T15:02:51  *** tw2006 has quit IRC
223 2017-05-05T15:05:44  *** Dyaheon- has quit IRC
224 2017-05-05T15:06:32  *** Dyaheon has joined #bitcoin-core-dev
225 2017-05-05T15:09:51  *** tonikt has quit IRC
226 2017-05-05T15:10:19  *** RubenSomsen has joined #bitcoin-core-dev
227 2017-05-05T15:18:23  *** RubenSomsen has quit IRC
228 2017-05-05T15:33:11  *** Giszmo has joined #bitcoin-core-dev
229 2017-05-05T15:35:45  *** harrymm1 has joined #bitcoin-core-dev
230 2017-05-05T15:36:24  *** harrymm1 has joined #bitcoin-core-dev
231 2017-05-05T15:38:27  *** harrymm has quit IRC
232 2017-05-05T15:44:31  *** Giszmo1 has joined #bitcoin-core-dev
233 2017-05-05T15:47:05  *** abpa has joined #bitcoin-core-dev
234 2017-05-05T15:59:00  <bitcoin-git> [bitcoin] practicalswift opened pull request #10343: Remove redundant on-the-same-line-repetition of type names (DRY): RepeatedTypeName foo = static_cast<RepeatedTypeName>(bar) (master...auto) https://github.com/bitcoin/bitcoin/pull/10343
235 2017-05-05T16:02:12  *** tw2006 has joined #bitcoin-core-dev
236 2017-05-05T16:12:22  *** marcoagn1 has quit IRC
237 2017-05-05T16:17:12  *** SopaXorzTaker has joined #bitcoin-core-dev
238 2017-05-05T16:27:05  *** elkalamar has quit IRC
239 2017-05-05T16:28:58  *** dcousens has quit IRC
240 2017-05-05T16:48:20  *** n1ce has quit IRC
241 2017-05-05T16:53:33  *** [\\\] is now known as tripleslash
242 2017-05-05T17:06:42  <bitcoin-git> [bitcoin] jnewbery opened pull request #10344: [tests] Fix abandonconflict.py intermittency (master...fix_abandon_conflict) https://github.com/bitcoin/bitcoin/pull/10344
243 2017-05-05T17:30:50  *** moli_ has joined #bitcoin-core-dev
244 2017-05-05T17:32:22  <BlueMatt> sipa: really? per-txout ends with a smaller dbcache? that's (marginally) surprising to me
245 2017-05-05T17:32:40  *** goksinen has quit IRC
246 2017-05-05T17:33:21  <sipa> BlueMatt: likewise
247 2017-05-05T17:33:23  *** vicenteH` has quit IRC
248 2017-05-05T17:33:53  *** mol has quit IRC
249 2017-05-05T17:34:00  <sipa> BlueMatt: in my memory the master dbcache usage for a full reindex was around 4GB or so, but apparently i haven't done one in a very long time...
250 2017-05-05T17:34:17  <BlueMatt> heh
251 2017-05-05T17:34:52  * BlueMatt would be curious to see the results of default-dbcache-on-tmpfs
252 2017-05-05T17:39:22  <BlueMatt> jtimon: do you feel so inclined to redo #9494 with scripted-diff?
253 2017-05-05T17:39:24  <gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
254 2017-05-05T17:39:33  <BlueMatt> it would be kinda nice, though I'd understand if you dont want to redo it at this point
255 2017-05-05T17:51:04  <jtimon> BlueMatt: yeah, for some parts of it it would make a lot of sense. I think I may have broke something in the last edit from what travis said. I will fix that and will s/argsGlobal/gArgs/ and see if I can move some parts to scripte-diff without much effort
256 2017-05-05T17:52:14  <BlueMatt> sounds good
257 2017-05-05T17:52:16  <BlueMatt> cool
258 2017-05-05T17:53:40  <jtimon> BlueMatt: in the meantime #8855 remains very easy to review :p
259 2017-05-05T17:53:42  <gribble> https://github.com/bitcoin/bitcoin/issues/8855 | Use a proper factory for creating chainparams by jtimon · Pull Request #8855 · bitcoin/bitcoin · GitHub
260 2017-05-05T18:05:08  *** alpalp has joined #bitcoin-core-dev
261 2017-05-05T18:10:24  *** praxeology has joined #bitcoin-core-dev
262 2017-05-05T18:20:52  *** goksinen has joined #bitcoin-core-dev
263 2017-05-05T18:33:24  *** AaronvanW has quit IRC
264 2017-05-05T18:37:44  <BlueMatt> heh, sipa, I was about to PR https://github.com/bitcoin/bitcoin/commit/64d45d0fc3b6f7669d0f2c24bca3beaa37cec0b3
265 2017-05-05T18:37:54  <BlueMatt> (and https://github.com/bitcoin/bitcoin/commit/5e03232a5dcc4674c620187f67163dc462fbafd1)
266 2017-05-05T18:39:17  <sipa> BlueMatt: ha
267 2017-05-05T18:39:25  <sipa> RandAddSeedSleepSanity has no return statement
268 2017-05-05T18:39:42  <luke-jr> sounds very random.
269 2017-05-05T18:39:44  <BlueMatt> oh, well, i never said i had gotten a chance to test it yet
270 2017-05-05T18:40:55  <BlueMatt> sipa: it seems a waste to call GetPerformanceCounter and *not* go ahead and add it to our random state
271 2017-05-05T18:41:51  <sipa> BlueMatt: how about we add that after #10338 ?
272 2017-05-05T18:41:52  <gribble> https://github.com/bitcoin/bitcoin/issues/10338 | Maintain state across GetStrongRandBytes calls by sipa · Pull Request #10338 · bitcoin/bitcoin · GitHub
273 2017-05-05T18:42:13  <BlueMatt> sipa: initially it was built on both, but right now everything is pushed into openssl's prng state, so...meh?
274 2017-05-05T18:44:48  *** mkwia has left #bitcoin-core-dev
275 2017-05-05T18:45:26  *** elkalamar has joined #bitcoin-core-dev
276 2017-05-05T18:46:04  <sipa> BlueMatt: like this? https://github.com/bitcoin/bitcoin/pull/10322/commits/999021ea0c6fce6dcef1ff05514c983e60ddc7eb
277 2017-05-05T18:47:02  <BlueMatt> sipa: sure! RandAddSeed() also memory_cleanse()s, but I dont think thats actually useful
278 2017-05-05T18:48:26  *** alpalp has quit IRC
279 2017-05-05T18:50:18  *** alpalp has joined #bitcoin-core-dev
280 2017-05-05T19:00:13  *** PaulCapestany has joined #bitcoin-core-dev
281 2017-05-05T19:04:58  *** SopaXorzTaker has quit IRC
282 2017-05-05T19:05:30  *** alpalp has quit IRC
283 2017-05-05T19:15:40  <jonasschnelli> hmm... CScheduler seems to be innacurate. I've set up scheduler.scheduleEvery(fn,2000) (every 2000ms)... I often get a callback with a delta of 10 seconds between each other...
284 2017-05-05T19:15:50  <BlueMatt> huh?
285 2017-05-05T19:15:52  <BlueMatt> thats...not good
286 2017-05-05T19:16:43  <jonasschnelli> I need to look into it
287 2017-05-05T19:17:04  <BlueMatt> jonasschnelli: which version? cfields fixed something with sub-second precision not too long ago
288 2017-05-05T19:17:10  <BlueMatt> but i believe the symptom was high cpu usage
289 2017-05-05T19:17:41  <jonasschnelli> Hmm.. my Laptop runs pretty quite... i'll investigate
290 2017-05-05T19:18:08  <jonasschnelli> running in LLDB shoudln't cause such high offsets (i'm not halting the process)¨
291 2017-05-05T19:20:05  <jonasschnelli> BlueMatt: What if another Scheduler task requires a couple of seconds to complete? (not familiar with the internals of the Scheduler)
292 2017-05-05T19:20:30  <BlueMatt> sure, that could cause it, but the only thing in scheduler is wallet flush, really
293 2017-05-05T19:21:21  <jonasschnelli> hmm... I'm not sure if that is the right approach for collecting stats... well,.. at least I have to add a timestamp then to each sample
294 2017-05-05T19:21:43  <BlueMatt> hmm?
295 2017-05-05T19:22:07  <sipa> jonasschnelli: you'll have a timestamp on each sample regardless
296 2017-05-05T19:22:34  <jonasschnelli> sipa: You mean I should have one per sample?
297 2017-05-05T19:22:37  <sipa> yes
298 2017-05-05T19:22:49  <sipa> you can't guarantee that you'll always be able to gather any statistic at any given point in time at that accuracy
299 2017-05-05T19:22:52  * BlueMatt has no idea wtf is going on
300 2017-05-05T19:22:54  <jonasschnelli> Yes. I just removed it when I switch to useing CScheduler.. but I guess your right
301 2017-05-05T19:23:02  <sipa> BlueMatt: jonas is gather statistics
302 2017-05-05T19:23:07  <BlueMatt> stats for what?
303 2017-05-05T19:23:07  <sipa> every 2 seconds
304 2017-05-05T19:23:22  <jonasschnelli> BlueMatt: my stats collector PR (== mempool graph)
305 2017-05-05T19:23:24  <sipa> i assume things like memory usage, bandwidth, ...
306 2017-05-05T19:23:28  <BlueMatt> ohoh, that one
307 2017-05-05T19:23:35  <jonasschnelli> For now it does only collect mempool data..
308 2017-05-05T19:23:47  <jonasschnelli> but it would be trivial to expand it for bandwidth, etc.
309 2017-05-05T19:24:26  <jonasschnelli> sipa: you think it's worth keeping a int64 for the starttime and only uint32 deltas per sample?
310 2017-05-05T19:24:29  <BlueMatt> well if people want to start seriously using the scheduler we can give it another thread
311 2017-05-05T19:25:06  <sipa> jonasschnelli: i assume your resolution is never less than a second
312 2017-05-05T19:25:16  <sipa> jonasschnelli: in that case you can use int32 for the starttime and int16 for the deltas :)
313 2017-05-05T19:26:36  <jonasschnelli> sipa: I have now different precision levels and I wanted to keep it absolute per sample... but,... I can't remember why I have damned the idea of deltaes between samples..
314 2017-05-05T19:27:13  <jonasschnelli> Yes. I guess this would work now that I run over the Schedular (rather then collect "on event")
315 2017-05-05T19:27:47  <sipa> using absolute time and data is certainly easier... you can just delete entries to reduce resolution over time
316 2017-05-05T19:27:56  <sipa> but uses more memory
317 2017-05-05T19:27:56  <jonasschnelli> But still strange that sometimes the Scheduler fires the 2000ms interval after 10000ms (its an inaccuracy of x5)
318 2017-05-05T19:28:17  <sipa> that does not sound normal and should be investigated regardless
319 2017-05-05T19:28:51  <sipa> you're sure this is not due to lock contention on main or mempool, right?
320 2017-05-05T19:29:21  <jonasschnelli> Some sample output of a 2000ms scheduler:
321 2017-05-05T19:29:22  <jonasschnelli> https://0bin.net/paste/HXqOTrnFkRzwECHA#8D9wGGWTFJwNZ1vkcQqarVAawSDdZZtENrMBPKeQcYu
322 2017-05-05T19:29:23  <gribble> https://github.com/bitcoin/bitcoin/issues/8 | RPC command to sign text with wallet private key · Issue #8 · bitcoin/bitcoin · GitHub
323 2017-05-05T19:29:37  <jonasschnelli> No,... it does only lock a new cs_stats
324 2017-05-05T19:29:57  <jonasschnelli> The mempool obtain it's own atomic caches in my current working branch
325 2017-05-05T19:31:01  <jonasschnelli> Although I run with the GUI... but shoudln't make any different. It's a calm regtest peer anyways
326 2017-05-05T19:38:43  *** carbonneau has joined #bitcoin-core-dev
327 2017-05-05T19:46:31  *** vicenteH has joined #bitcoin-core-dev
328 2017-05-05T19:53:16  *** carbonneau has quit IRC
329 2017-05-05T19:55:23  <bitcoin-git> [bitcoin] sdaftuar opened pull request #10345: [P2P] Timeout for headers sync (master...2017-05-timeout-headers-sync) https://github.com/bitcoin/bitcoin/pull/10345
330 2017-05-05T20:00:26  *** CubicEarth has joined #bitcoin-core-dev
331 2017-05-05T20:03:05  <paveljanik> BTW mempool - "standard" nodes are now running with ~300MB mempools...
332 2017-05-05T20:03:50  <gmaxwell> paveljanik: yep,   "mempoolminfee": 0.00002822
333 2017-05-05T20:04:06  <gmaxwell> hurray, system is back to a healthy state.
334 2017-05-05T20:04:27  <paveljanik> not so often tested/run code parts are now being tested :-)
335 2017-05-05T20:04:28  <BlueMatt> gmaxwell: +1
336 2017-05-05T20:04:30  <instagibbs> what was happening before?
337 2017-05-05T20:04:37  <instagibbs> I missed all the excitement it seems
338 2017-05-05T20:04:58  <gmaxwell> instagibbs: nah just for the last couple months we were riding at the minimum mempoolminfee... everything was getting confirmed.
339 2017-05-05T20:05:37  <instagibbs> RIP sub-sat/byte confirms
340 2017-05-05T20:08:48  *** goksinen has quit IRC
341 2017-05-05T20:13:26  * paveljanik going to test dump/load mempool
342 2017-05-05T20:24:15  *** goksinen has joined #bitcoin-core-dev
343 2017-05-05T20:28:57  *** goksinen has quit IRC
344 2017-05-05T20:29:47  *** goksinen has joined #bitcoin-core-dev
345 2017-05-05T20:42:49  *** Guyver2 has quit IRC
346 2017-05-05T20:46:25  *** tw2006 has quit IRC
347 2017-05-05T21:06:41  <bitcoin-git> [bitcoin] practicalswift opened pull request #10346: Use range-based for loops (C++11) when looping over vector elements (master...range-based-for-loops) https://github.com/bitcoin/bitcoin/pull/10346
348 2017-05-05T21:22:12  <bitcoin-git> [bitcoin] practicalswift closed pull request #10346: Use range-based for loops (C++11) when looping over vector elements (master...range-based-for-loops) https://github.com/bitcoin/bitcoin/pull/10346
349 2017-05-05T21:32:14  *** kadoban has joined #bitcoin-core-dev
350 2017-05-05T21:37:31  <bitcoin-git> [bitcoin] practicalswift opened pull request #10347: Use range-based for loops (C++11) when looping over vector elements (master...range-based-for-loops) https://github.com/bitcoin/bitcoin/pull/10347
351 2017-05-05T21:38:54  *** jannes has quit IRC
352 2017-05-05T21:47:16  *** tw2006 has joined #bitcoin-core-dev
353 2017-05-05T21:51:46  *** tw2006 has quit IRC
354 2017-05-05T22:04:03  <phantomcircuit> gmaxwell, odd
355 2017-05-05T22:04:15  <phantomcircuit> my bitcoind running patches to accept anything
356 2017-05-05T22:04:19  <phantomcircuit> is still   "mempoolminfee": 0.00000000
357 2017-05-05T22:04:43  <sipa>   "usage": 294825248,
358 2017-05-05T22:04:46  <sipa>   "mempoolminfee": 0.00001801
359 2017-05-05T22:05:02  <phantomcircuit>   "usage": 298733328,
360 2017-05-05T22:05:07  <phantomcircuit> oh
361 2017-05-05T22:05:16  <phantomcircuit> it's because i have maxmempool set to like infinity also
362 2017-05-05T22:05:17  <phantomcircuit> derp
363 2017-05-05T22:06:26  <luke-jr> lol
364 2017-05-05T22:07:34  <phantomcircuit> so it's just on the edge
365 2017-05-05T22:21:10  <BlueMatt> phantomcircuit: yea, well because most of your peers are limiting to 3MB its rare that your mempool ever gets much above 3mb
366 2017-05-05T22:21:16  <BlueMatt> whether you limit or not
367 2017-05-05T22:21:24  <sipa> 3MB ??
368 2017-05-05T22:21:32  <sipa> 300?
369 2017-05-05T22:21:53  <BlueMatt> oh, yes, 300
370 2017-05-05T22:22:06  *** goksinen has quit IRC
371 2017-05-05T22:22:32  <phantomcircuit> BlueMatt, i have peers that are before any kind of mempool limiting
372 2017-05-05T22:22:34  <phantomcircuit> but yeah
373 2017-05-05T22:22:50  <BlueMatt> well their peers :p
374 2017-05-05T22:23:04  <BlueMatt> even my 200-connection bitcoind seednode has only 307MB of txn
375 2017-05-05T22:27:04  *** goksinen has joined #bitcoin-core-dev
376 2017-05-05T22:27:05  *** bsm1175321 has quit IRC
377 2017-05-05T22:30:07  *** str4d has joined #bitcoin-core-dev
378 2017-05-05T22:31:57  *** goksinen has quit IRC
379 2017-05-05T22:45:22  *** goksinen has joined #bitcoin-core-dev
380 2017-05-05T22:47:46  *** elkalamar has quit IRC
381 2017-05-05T22:48:18  *** tw2006 has joined #bitcoin-core-dev
382 2017-05-05T22:52:59  *** tw2006 has quit IRC
383 2017-05-05T22:53:35  *** goksinen has quit IRC
384 2017-05-05T23:10:21  *** goksinen has joined #bitcoin-core-dev
385 2017-05-05T23:13:29  *** PaulCapestany has quit IRC
386 2017-05-05T23:14:57  *** goksinen has quit IRC
387 2017-05-05T23:16:18  *** PaulCapestany has joined #bitcoin-core-dev
388 2017-05-05T23:22:44  *** PaulCapestany has quit IRC
389 2017-05-05T23:22:57  *** PaulCapestany has joined #bitcoin-core-dev
390 2017-05-05T23:30:35  *** moli_ has quit IRC
391 2017-05-05T23:30:59  *** moli_ has joined #bitcoin-core-dev
392 2017-05-05T23:41:20  *** tunafizz has joined #bitcoin-core-dev
393 2017-05-05T23:49:17  *** tw2006 has joined #bitcoin-core-dev
394 2017-05-05T23:53:39  *** tw2006 has quit IRC
395 2017-05-05T23:53:55  *** goksinen has joined #bitcoin-core-dev
396 2017-05-05T23:59:17  *** goksinen has quit IRC