1 2017-05-09T00:03:29  *** nickler has quit IRC
  2 2017-05-09T00:04:08  *** waxwing has quit IRC
  3 2017-05-09T00:04:11  *** nickler has joined #bitcoin-core-dev
  4 2017-05-09T00:04:29  *** waxwing has joined #bitcoin-core-dev
  5 2017-05-09T00:06:02  *** mol has joined #bitcoin-core-dev
  6 2017-05-09T00:06:30  *** d_t has joined #bitcoin-core-dev
  7 2017-05-09T00:09:13  *** molz_ has quit IRC
  8 2017-05-09T00:20:41  *** justan0theruser is now known as justanotheruser
  9 2017-05-09T00:28:12  *** d_t has quit IRC
 10 2017-05-09T00:39:07  *** marcoagner has quit IRC
 11 2017-05-09T00:39:30  *** marcoagner has joined #bitcoin-core-dev
 12 2017-05-09T01:05:31  *** pindarhk has quit IRC
 13 2017-05-09T01:05:44  *** pindarhk_ has joined #bitcoin-core-dev
 14 2017-05-09T01:26:49  *** d_t has joined #bitcoin-core-dev
 15 2017-05-09T01:29:38  *** d_t has quit IRC
 16 2017-05-09T01:32:40  *** n1ce has quit IRC
 17 2017-05-09T01:35:53  <bitcoin-git> [bitcoin] kallewoof opened pull request #10366: [test] Remove all * imports (master...tests-unstar-imports) https://github.com/bitcoin/bitcoin/pull/10366
 18 2017-05-09T01:45:29  *** d_t has joined #bitcoin-core-dev
 19 2017-05-09T01:51:27  *** kexkey has quit IRC
 20 2017-05-09T02:00:11  *** dermoth has quit IRC
 21 2017-05-09T02:01:02  *** dermoth has joined #bitcoin-core-dev
 22 2017-05-09T02:04:46  *** checksum0_ has joined #bitcoin-core-dev
 23 2017-05-09T02:05:08  *** checksum0 has quit IRC
 24 2017-05-09T02:28:22  <bitcoin-git> [bitcoin] kallewoof opened pull request #10367: [test] Test abortrescan command. (master...test-abort-rescan-2) https://github.com/bitcoin/bitcoin/pull/10367
 25 2017-05-09T02:43:42  *** checksum0_ has quit IRC
 26 2017-05-09T03:00:16  *** belcher has quit IRC
 27 2017-05-09T03:01:17  *** Giszmo1 has quit IRC
 28 2017-05-09T03:18:25  *** d_t has quit IRC
 29 2017-05-09T03:26:48  *** Dyaheon has quit IRC
 30 2017-05-09T03:28:43  *** Dyaheon has joined #bitcoin-core-dev
 31 2017-05-09T04:29:59  *** rafalcpp has quit IRC
 32 2017-05-09T04:32:44  *** gm2053 has joined #bitcoin-core-dev
 33 2017-05-09T04:36:04  *** gm2052 has quit IRC
 34 2017-05-09T05:04:25  *** tunafizz has quit IRC
 35 2017-05-09T05:25:32  *** n1ce has joined #bitcoin-core-dev
 36 2017-05-09T05:27:31  *** Lauda has quit IRC
 37 2017-05-09T05:35:14  *** brg444 has quit IRC
 38 2017-05-09T05:35:28  *** brg444 has joined #bitcoin-core-dev
 39 2017-05-09T05:40:34  *** aspect_ has quit IRC
 40 2017-05-09T05:40:48  *** aspect_ has joined #bitcoin-core-dev
 41 2017-05-09T05:48:57  *** juscamarena_ has quit IRC
 42 2017-05-09T05:59:46  *** Lauda has joined #bitcoin-core-dev
 43 2017-05-09T06:00:25  *** jtimon has quit IRC
 44 2017-05-09T06:01:20  *** eragmus has quit IRC
 45 2017-05-09T06:01:47  *** eragmus_ has joined #bitcoin-core-dev
 46 2017-05-09T06:35:46  <jonasschnelli> Another ACK is required for the QT Fee Bumper: https://github.com/bitcoin/bitcoin/pull/9697
 47 2017-05-09T06:36:01  <jonasschnelli> Maybe paveljanik, fanquake, MarcoFalke?
 48 2017-05-09T06:47:28  *** BashCo has quit IRC
 49 2017-05-09T06:49:00  *** mappum has quit IRC
 50 2017-05-09T06:49:15  *** mappum has joined #bitcoin-core-dev
 51 2017-05-09T06:51:29  <bitcoin-git> [bitcoin] kallewoof opened pull request #10368: [wallet] Remove helper conversion operator from wallet (master...wallet-refactor-remove-ctrans-helper) https://github.com/bitcoin/bitcoin/pull/10368
 52 2017-05-09T06:52:07  *** RubenSomsen has joined #bitcoin-core-dev
 53 2017-05-09T07:00:41  *** Alina-malina has quit IRC
 54 2017-05-09T07:01:53  *** Alina-malina has joined #bitcoin-core-dev
 55 2017-05-09T07:06:11  <paveljanik> jonasschnelli, Does it clean-compile for you? It does not here
 56 2017-05-09T07:06:23  <jonasschnelli> paveljanik: Oh... what did you get?
 57 2017-05-09T07:06:33  <paveljanik> mmnt, doing clean build now
 58 2017-05-09T07:06:39  <paveljanik> to verify
 59 2017-05-09T07:07:00  <jonasschnelli> Travis ran fine... but maybe a rebase-on-top-of-master issue?
 60 2017-05-09T07:07:17  <paveljanik> yes
 61 2017-05-09T07:07:23  <paveljanik> can you please rebase?
 62 2017-05-09T07:07:35  <paveljanik> interesting that github doesn't show problem
 63 2017-05-09T07:07:52  <paveljanik> I haed to add #include "policy/rbf.h" and yes, it is in .rej :-)
 64 2017-05-09T07:09:15  *** EagleTM has joined #bitcoin-core-dev
 65 2017-05-09T07:09:50  <paveljanik> I'll test the PR later today then
 66 2017-05-09T07:09:55  *** BashCo has joined #bitcoin-core-dev
 67 2017-05-09T07:10:28  *** RubenSomsen has quit IRC
 68 2017-05-09T07:11:43  <jonasschnelli> paveljanik: Okay. I'll rebase.
 69 2017-05-09T07:11:46  *** Alina-malina has quit IRC
 70 2017-05-09T07:11:47  *** Alina-malina has joined #bitcoin-core-dev
 71 2017-05-09T07:12:24  <jonasschnelli> paveljanik: where di you had to add the include?
 72 2017-05-09T07:12:33  <paveljanik> walletmodel.cpp
 73 2017-05-09T07:12:56  <paveljanik> you have it there in the PR, but some diff application issue/conflict
 74 2017-05-09T07:13:17  <paveljanik> patching file src/qt/walletmodel.cpp
 75 2017-05-09T07:13:17  <paveljanik> Hunk #1 FAILED at 8.
 76 2017-05-09T07:13:17  <paveljanik> Hunk #2 succeeded at 698 (offset 1 line).
 77 2017-05-09T07:13:17  <paveljanik> 1 out of 2 hunks FAILED -- saving rejects to file src/qt/walletmodel.cpp.rej
 78 2017-05-09T07:13:18  <gribble> https://github.com/bitcoin/bitcoin/issues/1 | JSON-RPC support for mobile devices ("ultra-lightweight" clients) · Issue #1 · bitcoin/bitcoin · GitHub
 79 2017-05-09T07:13:20  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
 80 2017-05-09T07:13:50  <paveljanik> I have to leave now, sorry
 81 2017-05-09T07:14:06  *** paveljanik has quit IRC
 82 2017-05-09T07:20:15  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a796b2b53fe...08a7316c144f
 83 2017-05-09T07:20:16  <bitcoin-git> bitcoin/master 330bb5a Jorge Timón: Consensus: Minimal way to move dust out of consensus
 84 2017-05-09T07:20:17  <bitcoin-git> bitcoin/master 381a46e Jorge Timón: Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module...
 85 2017-05-09T07:20:17  <bitcoin-git> bitcoin/master 08a7316 Wladimir J. van der Laan: Merge #9279: Consensus: Move CFeeRate out of libconsensus...
 86 2017-05-09T07:20:33  <bitcoin-git> [bitcoin] laanwj closed pull request #9279: Consensus: Move CFeeRate out of libconsensus (master...0.13-consensus-dust-out-minimal) https://github.com/bitcoin/bitcoin/pull/9279
 87 2017-05-09T07:25:08  *** baldur has quit IRC
 88 2017-05-09T07:25:39  *** Ylbam has joined #bitcoin-core-dev
 89 2017-05-09T07:38:04  *** baldur has joined #bitcoin-core-dev
 90 2017-05-09T08:18:33  *** timothy has joined #bitcoin-core-dev
 91 2017-05-09T08:29:32  *** Guyver2 has joined #bitcoin-core-dev
 92 2017-05-09T08:32:19  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/08a7316c144f...c973cc5a4318
 93 2017-05-09T08:32:20  <bitcoin-git> bitcoin/master f87f362 Jorge Timón: Chainparams: Use a regular factory for creating chainparams
 94 2017-05-09T08:32:20  <bitcoin-git> bitcoin/master 2351a06 Jorge Timón: Chainparams: Get rid of CChainParams& Params(std::string)
 95 2017-05-09T08:32:21  <bitcoin-git> bitcoin/master c1082a7 Jorge Timón: Chainparams: Use the factory for pow tests
 96 2017-05-09T08:48:15  *** dgenr8 has quit IRC
 97 2017-05-09T08:50:50  *** vicenteH has joined #bitcoin-core-dev
 98 2017-05-09T08:58:43  *** rafalcpp has joined #bitcoin-core-dev
 99 2017-05-09T09:05:03  *** jannes has joined #bitcoin-core-dev
100 2017-05-09T09:22:51  *** dgenr8 has joined #bitcoin-core-dev
101 2017-05-09T09:25:29  *** RubenSomsen has joined #bitcoin-core-dev
102 2017-05-09T10:36:01  *** molz_ has joined #bitcoin-core-dev
103 2017-05-09T10:39:01  *** mol has quit IRC
104 2017-05-09T11:03:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c973cc5a4318...776ba233e939
105 2017-05-09T11:03:28  <bitcoin-git> bitcoin/master ed36de5 Jimmy Song: [tests] Update Unit Test for addrman.h/addrman.cpp...
106 2017-05-09T11:03:29  <bitcoin-git> bitcoin/master 776ba23 MarcoFalke: Merge #10287: [tests] Update Unit Test for addrman.h/addrman.cpp...
107 2017-05-09T11:03:53  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10287: [tests] Update Unit Test for addrman.h/addrman.cpp (master...test_addrman) https://github.com/bitcoin/bitcoin/pull/10287
108 2017-05-09T11:07:32  *** SopaXorzTaker has joined #bitcoin-core-dev
109 2017-05-09T11:12:02  *** laurentmt has joined #bitcoin-core-dev
110 2017-05-09T11:12:11  *** [b__b] has quit IRC
111 2017-05-09T11:17:49  *** laurentmt has quit IRC
112 2017-05-09T11:33:55  *** RubenSomsen has quit IRC
113 2017-05-09T11:34:01  *** [b__b] has joined #bitcoin-core-dev
114 2017-05-09T11:38:16  *** jtimon has joined #bitcoin-core-dev
115 2017-05-09T11:40:42  <jtimon> ryanofsky: not sure what to do with https://github.com/bitcoin/bitcoin/pull/9279#discussion_r115361685 now, if you fix it ping me to utACK it. Same for https://github.com/bitcoin/bitcoin/pull/8855#discussion_r115374175
116 2017-05-09T11:41:34  *** fanquake has joined #bitcoin-core-dev
117 2017-05-09T11:47:43  *** fanquake has quit IRC
118 2017-05-09T11:50:42  <jtimon> BlueMatt: does this comment still apply? not sure I understand it : https://github.com/bitcoin/bitcoin/pull/9494#discussion_r115304251
119 2017-05-09T11:51:06  <jtimon> what intermediate commit breaks the locking and how?
120 2017-05-09T11:59:22  <bitcoin-git> [bitcoin] sdaftuar closed pull request #10357: Allow setting nMinimumChainWork on command line (master...2017-05-chainwork-commandline) https://github.com/bitcoin/bitcoin/pull/10357
121 2017-05-09T11:59:30  *** harrymm has joined #bitcoin-core-dev
122 2017-05-09T12:19:51  <bitcoin-git> [bitcoin] runn1ng opened pull request #10370: [pull request idea] addressindex, spentindex, timestampindex (Bitcore patches) (master...rebase_bitcoin_master) https://github.com/bitcoin/bitcoin/pull/10370
123 2017-05-09T12:24:58  <ryanofsky> jtimon, ok i'll just create little prs for those, sorry for not being clear
124 2017-05-09T12:25:39  <jtimon> ryanofsky: great, although you were clear, I just didn't had the chance to fix the nits
125 2017-05-09T12:26:28  *** n1ce has quit IRC
126 2017-05-09T12:49:59  *** n1ce has joined #bitcoin-core-dev
127 2017-05-09T13:01:00  *** karelb has joined #bitcoin-core-dev
128 2017-05-09T13:02:02  *** karelb has quit IRC
129 2017-05-09T13:02:46  *** goksinen has joined #bitcoin-core-dev
130 2017-05-09T13:34:33  *** cryptapus_afk has quit IRC
131 2017-05-09T13:51:07  *** goksinen has quit IRC
132 2017-05-09T13:51:41  *** goksinen has joined #bitcoin-core-dev
133 2017-05-09T13:54:32  <BlueMatt> jtimon: yes?
134 2017-05-09T13:54:56  <BlueMatt> jtimon: after the first commit on #9494 mapMultiArgs is access without locks while being updated, this is a bug, but its fixed two commits later
135 2017-05-09T13:54:58  <gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
136 2017-05-09T13:55:03  <BlueMatt> jtimon: its not a huge deal, but it would be nice to not do that
137 2017-05-09T14:08:10  *** cryptapus_afk has joined #bitcoin-core-dev
138 2017-05-09T14:14:04  <jtimon> BlueMatt: oh, I see, got you now, thanks for explaining
139 2017-05-09T14:14:55  <jtimon> trivial to fix, no problem, will eat first though
140 2017-05-09T14:18:51  *** CubicEarth has joined #bitcoin-core-dev
141 2017-05-09T14:24:07  *** marcoagner has quit IRC
142 2017-05-09T14:24:33  *** marcoagner has joined #bitcoin-core-dev
143 2017-05-09T14:26:51  *** dcousens has joined #bitcoin-core-dev
144 2017-05-09T14:32:21  *** CubicEarth has quit IRC
145 2017-05-09T14:33:05  *** Giszmo has joined #bitcoin-core-dev
146 2017-05-09T14:33:30  *** goksinen has quit IRC
147 2017-05-09T14:39:29  *** goksinen has joined #bitcoin-core-dev
148 2017-05-09T14:55:09  <instagibbs> morcos, what interaction are you worried about exactly re:#10360? The Core wallet already aggressively picks lots of small inputs. My PR wasn't an attempt to fix this degenerate coin selection strategy.
149 2017-05-09T14:55:11  <gribble> https://github.com/bitcoin/bitcoin/issues/10360 | [WIP] [Wallet] Target effective value during transaction creation by instagibbs · Pull Request #10360 · bitcoin/bitcoin · GitHub
150 2017-05-09T15:02:10  *** BashCo has quit IRC
151 2017-05-09T15:05:02  <morcos> instagibbs: correct that the current algorithm is bad also..  and its possibly 10360 is better, but my concern is now there are more "small" inputs b/c they are effective size inputs.
152 2017-05-09T15:05:19  <instagibbs> ah... I see
153 2017-05-09T15:05:54  <instagibbs> however, previously we would pick even negative effective value inputs. Maybe not apples/oranges.
154 2017-05-09T15:06:22  <morcos> i don't have any code, yet, i was just working out a design...   but in looking at the code today.. i feel like it would behoove us to clean up some stuff first...
155 2017-05-09T15:06:33  <morcos> instagibbs: agreed, thats why i left it as a question mark
156 2017-05-09T15:06:51  <instagibbs> Yeah it's a good point.
157 2017-05-09T15:07:18  <morcos> for instance all the nBytes calculation in coincontroldialog could hopefully be abstracted away into the same DummySignTx
158 2017-05-09T15:07:24  <morcos> back in 2
159 2017-05-09T15:08:39  <morcos> ok back.   or if we are now caching delta nBytes (to include as input) in the wallets spendable outputs themselves, then possibly we just add up those numbers
160 2017-05-09T15:09:37  <morcos> i started thinking about this, b/c i didnt' like the way some of your changes were duplicating code that had previously been unduplicated..  like the maxTxFee check
161 2017-05-09T15:10:20  <morcos> anyway.. in my ideal world.. we'd refactor to clean up a bit first... and then start making changes
162 2017-05-09T15:10:45  <morcos> some of your commits do that
163 2017-05-09T15:11:28  *** gielbier has joined #bitcoin-core-dev
164 2017-05-09T15:11:28  <MarcoFalke> wumpus: The doxygen docs are last generated in April. Mind to kick the server?
165 2017-05-09T15:20:10  <instagibbs> morcos, missed the qt stuff. I think additional refactoring is fine if it makes it easier to manage long-term. I'll reply in thread.
166 2017-05-09T15:30:12  *** goksinen has quit IRC
167 2017-05-09T15:39:27  *** goksinen has joined #bitcoin-core-dev
168 2017-05-09T15:40:17  *** BashCo has joined #bitcoin-core-dev
169 2017-05-09T15:53:53  *** paveljanik has joined #bitcoin-core-dev
170 2017-05-09T15:53:54  *** paveljanik has joined #bitcoin-core-dev
171 2017-05-09T15:54:10  *** waxwing has quit IRC
172 2017-05-09T16:13:26  <bitcoin-git> [bitcoin] jimmysong opened pull request #10371: [tests] Clean up addrman_tests.cpp (master...update_addressman_test) https://github.com/bitcoin/bitcoin/pull/10371
173 2017-05-09T16:17:51  *** abpa has joined #bitcoin-core-dev
174 2017-05-09T16:18:08  *** Guyver2 has quit IRC
175 2017-05-09T16:24:00  *** waxwing has joined #bitcoin-core-dev
176 2017-05-09T16:39:06  *** Giszmo has quit IRC
177 2017-05-09T16:46:35  *** dcousens has quit IRC
178 2017-05-09T16:59:17  *** timothy has quit IRC
179 2017-05-09T17:02:20  *** talmai has joined #bitcoin-core-dev
180 2017-05-09T17:13:05  <bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/776ba233e939...bc64b5aa0fc5
181 2017-05-09T17:13:06  <bitcoin-git> bitcoin/master f544094 Pieter Wuille: Use hardware timestamps in RNG seeding
182 2017-05-09T17:13:07  <bitcoin-git> bitcoin/master 33f853d Pieter Wuille: Test that GetPerformanceCounter() increments
183 2017-05-09T17:13:07  <bitcoin-git> bitcoin/master 2c0a6f1 Pieter Wuille: Use sanity check timestamps as entropy
184 2017-05-09T17:13:35  <bitcoin-git> [bitcoin] sipa closed pull request #10322: Use hardware timestamps in RNG seeding (master...rdtsc) https://github.com/bitcoin/bitcoin/pull/10322
185 2017-05-09T17:14:14  *** Giszmo has joined #bitcoin-core-dev
186 2017-05-09T17:25:09  *** NewLiberty has joined #bitcoin-core-dev
187 2017-05-09T17:25:33  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bc64b5aa0fc5...daf3e7def7b9
188 2017-05-09T17:25:34  <bitcoin-git> bitcoin/master 97477c5 Pieter Wuille: Maintain state across GetStrongRandBytes calls
189 2017-05-09T17:25:34  <bitcoin-git> bitcoin/master daf3e7d Pieter Wuille: Merge #10338: Maintain state across GetStrongRandBytes calls...
190 2017-05-09T17:25:43  <bitcoin-git> [bitcoin] sipa closed pull request #10338: Maintain state across GetStrongRandBytes calls (master...stateful_rng) https://github.com/bitcoin/bitcoin/pull/10338
191 2017-05-09T17:30:13  *** jcliff42 has joined #bitcoin-core-dev
192 2017-05-09T17:31:12  *** jcliff42_ has joined #bitcoin-core-dev
193 2017-05-09T17:34:36  *** jcliff42 has quit IRC
194 2017-05-09T17:34:36  *** vicenteH has quit IRC
195 2017-05-09T17:49:37  *** goksinen has quit IRC
196 2017-05-09T17:57:40  *** jcliff42_ has quit IRC
197 2017-05-09T17:58:41  *** Dosius has joined #bitcoin-core-dev
198 2017-05-09T18:01:46  *** jcliff42 has joined #bitcoin-core-dev
199 2017-05-09T18:03:04  *** laurentmt has joined #bitcoin-core-dev
200 2017-05-09T18:03:15  *** laurentmt has quit IRC
201 2017-05-09T18:05:58  *** jcliff42 has quit IRC
202 2017-05-09T18:07:08  *** SopaXorzTaker has quit IRC
203 2017-05-09T18:08:09  *** SopaXorzTaker has joined #bitcoin-core-dev
204 2017-05-09T18:08:23  *** Alina-malina has quit IRC
205 2017-05-09T18:08:38  *** justanotheruser has quit IRC
206 2017-05-09T18:08:52  *** Dosius has quit IRC
207 2017-05-09T18:10:18  *** Alina-malina has joined #bitcoin-core-dev
208 2017-05-09T18:24:08  *** instagibbs has quit IRC
209 2017-05-09T18:24:25  *** instagibbs has joined #bitcoin-core-dev
210 2017-05-09T18:32:47  *** Squidicuz has quit IRC
211 2017-05-09T18:32:54  *** jcliff42 has joined #bitcoin-core-dev
212 2017-05-09T18:39:18  *** harrymm has quit IRC
213 2017-05-09T18:40:48  *** SopaXorzTaker has quit IRC
214 2017-05-09T18:47:01  *** instagibbs has quit IRC
215 2017-05-09T18:49:59  *** goksinen has joined #bitcoin-core-dev
216 2017-05-09T18:50:18  *** EagleTM has quit IRC
217 2017-05-09T18:51:18  *** kexkey has joined #bitcoin-core-dev
218 2017-05-09T18:52:14  *** harrymm has joined #bitcoin-core-dev
219 2017-05-09T18:53:56  *** waxwing has quit IRC
220 2017-05-09T18:58:07  *** Alina-malina has quit IRC
221 2017-05-09T18:58:07  *** Alina-malina has joined #bitcoin-core-dev
222 2017-05-09T18:58:48  *** aantonop has joined #bitcoin-core-dev
223 2017-05-09T18:59:45  *** instagibbs has joined #bitcoin-core-dev
224 2017-05-09T19:04:09  *** jcliff42 has quit IRC
225 2017-05-09T19:05:35  *** waxwing has joined #bitcoin-core-dev
226 2017-05-09T19:06:08  *** aceat64 has quit IRC
227 2017-05-09T19:08:42  <jtimon> cfields: I'm going to update #9494 with BlueMatt's suggestion, do you want me to also fix your nit https://github.com/bitcoin/bitcoin/pull/9494#discussion_r115337114 ?
228 2017-05-09T19:08:44  <gribble> https://github.com/bitcoin/bitcoin/issues/9494 | Introduce an ArgsManager class encapsulating cs_args, mapArgs and mapMultiArgs by jtimon · Pull Request #9494 · bitcoin/bitcoin · GitHub
229 2017-05-09T19:11:10  <cfields> jtimon: doesn't really matter either way. It just stood out as odd
230 2017-05-09T19:11:49  <jtimon> yeah, I mean, not doing it would be less disruptive, but I guess doing it is "more correct"(tm)
231 2017-05-09T19:15:51  <cfields> jtimon: I only mentioned it because it looks like it was changed for a reason i was missing. If not, may as well leave it as a const ref, no?
232 2017-05-09T19:17:16  <jtimon> cfields: the only reason was https://github.com/bitcoin/bitcoin/pull/9494#discussion_r114871456 so yeah I think we can leave it as a const ref, even if there's no gain with it
233 2017-05-09T19:18:17  <cfields> jtimon: i see. I didn't realize you'd already changed it once
234 2017-05-09T19:18:52  <cfields> jtimon: it's really not worth the time we've put into it :). either way is fine
235 2017-05-09T19:19:11  <jtimon> cfields: fair enough, I'll leave it as it is now then
236 2017-05-09T19:19:19  <cfields> sounds good
237 2017-05-09T19:30:10  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10372: Add perf counter data to GetStrongRandBytes state in scheduler (master...2017-05-scheduler-rng) https://github.com/bitcoin/bitcoin/pull/10372
238 2017-05-09T19:30:16  <BlueMatt> sipa: you said after 10338.... ^
239 2017-05-09T19:34:09  *** Squidicuz has joined #bitcoin-core-dev
240 2017-05-09T19:46:11  *** goksinen has quit IRC
241 2017-05-09T19:47:24  *** NewLiberty has quit IRC
242 2017-05-09T19:55:10  *** talmai has quit IRC
243 2017-05-09T19:55:27  <BlueMatt> sipa: do you happen to have any idea why there is the huge jump at around 35/37% progress in #10195?
244 2017-05-09T19:55:29  <gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
245 2017-05-09T19:55:31  <BlueMatt> in memory usage, that is
246 2017-05-09T19:55:55  <sipa> BlueMatt: dust spam attack
247 2017-05-09T19:56:03  <BlueMatt> ah, ok, i assume something as much
248 2017-05-09T19:56:23  <BlueMatt> they were txn with lots of outputs, i assume?
249 2017-05-09T19:56:29  <sipa> i believe so
250 2017-05-09T19:56:33  <BlueMatt> k
251 2017-05-09T19:57:37  <sipa> i have an earlier graph that shows it too
252 2017-05-09T19:57:40  <BlueMatt> k
253 2017-05-09T19:57:41  <sipa> let's see if i still have it
254 2017-05-09T19:57:46  <BlueMatt> ehh, whatever
255 2017-05-09T19:58:19  <sipa> BlueMatt: http://bitcoin.sipa.be/utxo_size.png
256 2017-05-09T19:59:10  <BlueMatt> heh
257 2017-05-09T19:59:51  <sipa> yay for 200 MiB of waste we'll get to carry around forever...
258 2017-05-09T20:02:06  <BlueMatt> :(
259 2017-05-09T20:03:02  *** jcliff42 has joined #bitcoin-core-dev
260 2017-05-09T20:03:22  *** jcliff42 has joined #bitcoin-core-dev
261 2017-05-09T20:27:02  *** mol has joined #bitcoin-core-dev
262 2017-05-09T20:30:25  *** molz_ has quit IRC
263 2017-05-09T20:35:41  *** jcliff42 has quit IRC
264 2017-05-09T20:51:34  *** jcliff42 has joined #bitcoin-core-dev
265 2017-05-09T20:51:54  *** jcliff42 has joined #bitcoin-core-dev
266 2017-05-09T20:53:10  *** marcoagner has quit IRC
267 2017-05-09T20:53:42  *** cryptapus_afk has quit IRC
268 2017-05-09T21:00:16  *** Squidicc has joined #bitcoin-core-dev
269 2017-05-09T21:05:09  *** marcoagner has joined #bitcoin-core-dev
270 2017-05-09T21:06:23  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/daf3e7def7b9...7ee523604851
271 2017-05-09T21:06:24  <bitcoin-git> bitcoin/master b0bfa23 John Newbery: [tests] Make wait_until timeout 60 seconds by default
272 2017-05-09T21:06:24  <bitcoin-git> bitcoin/master 56befa0 John Newbery: [tests] increase timeouts in sendheaders test
273 2017-05-09T21:06:25  <bitcoin-git> bitcoin/master 7ee5236 MarcoFalke: Merge #10365: [tests] increase timeouts in sendheaders test...
274 2017-05-09T21:06:54  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10365: [tests] increase timeouts in sendheaders test (master...improve_sendheaders) https://github.com/bitcoin/bitcoin/pull/10365
275 2017-05-09T21:10:42  *** goksinen has joined #bitcoin-core-dev
276 2017-05-09T21:13:19  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #10374: qa: Warn when specified test is not found (master...Mf1705-qaWarnTestNotFound) https://github.com/bitcoin/bitcoin/pull/10374
277 2017-05-09T21:15:18  *** aantonop has quit IRC
278 2017-05-09T21:15:48  *** cryptapus has joined #bitcoin-core-dev
279 2017-05-09T21:15:48  *** cryptapus has joined #bitcoin-core-dev
280 2017-05-09T21:15:52  *** cryptapus is now known as cryptapus_afk
281 2017-05-09T21:17:59  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7ee523604851...f6241b3e420e
282 2017-05-09T21:18:00  <bitcoin-git> bitcoin/master fa7396d MarcoFalke: qa: disablewallet: Check that wallet is really disabled
283 2017-05-09T21:18:00  <bitcoin-git> bitcoin/master f6241b3 MarcoFalke: Merge #10361: qa: disablewallet: Check that wallet is really disabled...
284 2017-05-09T21:18:30  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10361: qa: disablewallet: Check that wallet is really disabled (master...Mf1705-disableWalletPass) https://github.com/bitcoin/bitcoin/pull/10361
285 2017-05-09T21:26:56  <bitcoin-git> [bitcoin] jnewbery opened pull request #10376: [tests] fix disconnect_ban intermittency (master...disconnect_ban_flakiness) https://github.com/bitcoin/bitcoin/pull/10376
286 2017-05-09T21:27:08  *** jtimon has quit IRC
287 2017-05-09T21:27:44  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6241b3e420e...4b766fcdd4ca
288 2017-05-09T21:27:44  <bitcoin-git> bitcoin/master a80f295 Jimmy Song: [tests] Clean up addrman_tests.cpp...
289 2017-05-09T21:27:45  <bitcoin-git> bitcoin/master 4b766fc MarcoFalke: Merge #10371: [tests] Clean up addrman_tests.cpp...
290 2017-05-09T21:28:16  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10371: [tests] Clean up addrman_tests.cpp (master...update_addressman_test) https://github.com/bitcoin/bitcoin/pull/10371
291 2017-05-09T21:49:35  *** vicenteH has joined #bitcoin-core-dev
292 2017-05-09T21:50:09  *** jcliff42 has quit IRC
293 2017-05-09T21:56:07  *** jcliff42 has joined #bitcoin-core-dev
294 2017-05-09T21:56:27  *** jcliff42 has joined #bitcoin-core-dev
295 2017-05-09T22:14:42  <bitcoin-git> [bitcoin] sipa opened pull request #10377: Use rdrand as entropy source on supported platforms (master...hwrand) https://github.com/bitcoin/bitcoin/pull/10377
296 2017-05-09T22:21:19  *** aantonop has joined #bitcoin-core-dev
297 2017-05-09T22:25:34  <bitcoin-git> [bitcoin] practicalswift opened pull request #10378: Rename TxConfirmStats to CTxConfirmStats to achieve class naming consistency (master...TxConfirmStats) https://github.com/bitcoin/bitcoin/pull/10378
298 2017-05-09T22:33:37  *** jcliff42 has quit IRC
299 2017-05-09T22:36:45  *** jcliff42 has joined #bitcoin-core-dev
300 2017-05-09T22:37:05  *** jcliff42 has joined #bitcoin-core-dev
301 2017-05-09T22:39:30  *** goksinen has quit IRC
302 2017-05-09T22:40:03  *** jcliff42 has quit IRC
303 2017-05-09T22:40:07  *** goksinen has joined #bitcoin-core-dev
304 2017-05-09T22:41:04  *** jcliff42 has joined #bitcoin-core-dev
305 2017-05-09T22:41:29  *** jcliff42 has joined #bitcoin-core-dev
306 2017-05-09T22:43:03  *** goksinen has quit IRC
307 2017-05-09T22:44:06  <cfields> sipa: out of curiosity, what are your CTxInUndo serialization plans mentioned in 10195?
308 2017-05-09T22:45:34  *** goksinen has joined #bitcoin-core-dev
309 2017-05-09T22:46:19  *** juhanju has joined #bitcoin-core-dev
310 2017-05-09T22:47:02  *** molz_ has joined #bitcoin-core-dev
311 2017-05-09T22:47:20  *** mol has quit IRC
312 2017-05-09T22:47:29  *** juhanju has quit IRC
313 2017-05-09T22:48:57  <sipa> cfields: the TODO's you mean?
314 2017-05-09T22:49:33  <cfields> sipa: https://github.com/bitcoin/bitcoin/pull/10195#discussion_r114689486
315 2017-05-09T22:50:04  <sipa> cfields: create a VectorSerializer<typename E, typename ItemSerializer>(std::vector<E>& v), which instantiates an ItemSerializer<E>(x) for every x in v, and serializes with it
316 2017-05-09T22:50:19  <cfields> some of those serializations are pretty clunky, but I'll ignore if you intend to replace
317 2017-05-09T22:50:23  <sipa> the default std::vector serializer would just use a dummy ItemSerializer
318 2017-05-09T22:50:44  <cfields> hmm
319 2017-05-09T22:52:53  <cfields> ok, i see
320 2017-05-09T22:53:15  *** justanotheruser has joined #bitcoin-core-dev
321 2017-05-09T22:55:02  *** d9b4bef9 has quit IRC
322 2017-05-09T22:55:35  *** goksinen has quit IRC
323 2017-05-09T22:56:19  *** goksinen has joined #bitcoin-core-dev
324 2017-05-09T23:06:09  *** goksinen has quit IRC
325 2017-05-09T23:13:13  *** goksinen has joined #bitcoin-core-dev
326 2017-05-09T23:16:30  *** goksinen has quit IRC
327 2017-05-09T23:18:32  *** goksinen has joined #bitcoin-core-dev
328 2017-05-09T23:19:30  *** goksinen has quit IRC
329 2017-05-09T23:20:31  *** goksinen has joined #bitcoin-core-dev
330 2017-05-09T23:21:27  *** goksinen has quit IRC
331 2017-05-09T23:22:59  *** goksinen has joined #bitcoin-core-dev
332 2017-05-09T23:24:06  *** goksinen has joined #bitcoin-core-dev
333 2017-05-09T23:25:20  *** goksinen has quit IRC
334 2017-05-09T23:26:21  *** goksinen has joined #bitcoin-core-dev
335 2017-05-09T23:27:28  *** goksinen has quit IRC
336 2017-05-09T23:28:57  *** goksinen has joined #bitcoin-core-dev
337 2017-05-09T23:31:06  *** goksinen has quit IRC
338 2017-05-09T23:35:08  *** jannes has quit IRC
339 2017-05-09T23:46:16  *** jcliff42 has quit IRC
340 2017-05-09T23:46:36  *** goksinen has joined #bitcoin-core-dev
341 2017-05-09T23:51:33  *** goksinen has quit IRC
342 2017-05-09T23:56:30  *** jcliff42 has joined #bitcoin-core-dev
343 2017-05-09T23:56:50  *** jcliff42 has joined #bitcoin-core-dev
344 2017-05-09T23:57:09  *** abpa has quit IRC