1 2017-06-02T00:04:01  *** emzy has joined #bitcoin-core-dev
  2 2017-06-02T00:05:44  <jtimon> gmaxwell: I'm not sure what the implications of your comments about #10195 are, sadly I didn't find time to take more than a glance at it
  3 2017-06-02T00:05:48  <gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
  4 2017-06-02T00:07:00  <gmaxwell> jtimon: huh?
  5 2017-06-02T00:07:45  <sipa> jtimon: since 10195, at first startup, your chainstate database will be upgraded to a new format
  6 2017-06-02T00:08:06  <sipa> this may take a while, but only happens once
  7 2017-06-02T00:09:41  <jtimon> sipa: thank you, and gmaxwell is pointing out that trying to downgrade the chainstate database format would be painful, but there's no good reason to want that besides testing, right?
  8 2017-06-02T00:09:56  <sipa> indeed
  9 2017-06-02T00:10:48  <jtimon> but gmaxwell tried anyway, nice
 10 2017-06-02T00:11:13  <jtimon> and it works
 11 2017-06-02T00:12:22  <jtimon> I guess I shouldn't have started with the youtube video
 12 2017-06-02T00:22:02  <jtimon> I know it's selfish, but my plan was to partially review 10195 after squashed and merged all along
 13 2017-06-02T00:26:02  <sipa> that's a perfectly gine strategy
 14 2017-06-02T00:26:05  <sipa> *fine
 15 2017-06-02T00:31:18  *** DCLXVI` has joined #bitcoin-core-dev
 16 2017-06-02T00:33:12  *** emzy_ has joined #bitcoin-core-dev
 17 2017-06-02T00:33:26  *** emzy has quit IRC
 18 2017-06-02T00:33:29  *** cfields has quit IRC
 19 2017-06-02T00:34:18  *** cfields has joined #bitcoin-core-dev
 20 2017-06-02T00:38:07  *** dclxvi has quit IRC
 21 2017-06-02T00:43:01  *** AaronvanW has joined #bitcoin-core-dev
 22 2017-06-02T00:45:35  *** Aaronvan_ has quit IRC
 23 2017-06-02T00:49:04  <jtimon> mhmm sipa I cannot find where this check went: https://github.com/bitcoin/bitcoin/pull/8498/commits/e1cddd6c57e0b40d63c6ed5ff8d61e2c6b44ad3e#r110544416
 24 2017-06-02T00:50:27  <sipa> doesn't exist anymore... we can't distinguish already spent from nonexisting
 25 2017-06-02T00:51:25  <sipa> it was unreliable before
 26 2017-06-02T00:53:23  *** Dyaheon has quit IRC
 27 2017-06-02T00:53:37  <jtimon> thank you, I take that as https://github.com/bitcoin/bitcoin/pull/8498/commits/e1cddd6c57e0b40d63c6ed5ff8d61e2c6b44ad3e#diff-ca81084f62961a188f5c1e86a5ff1d7cL206 still being good (chnaging from 0 to 100 )
 28 2017-06-02T00:53:45  <jtimon> rebasing just that now
 29 2017-06-02T00:54:37  <jtimon> anyway, nver mind, new checks right above
 30 2017-06-02T00:55:15  <jtimon> or are they new? I will figure it out, thanks
 31 2017-06-02T00:55:17  <cfields> wumpus: forgot to bump version before tag :(
 32 2017-06-02T00:56:50  *** Ylbam has quit IRC
 33 2017-06-02T00:57:33  *** Dyaheon has joined #bitcoin-core-dev
 34 2017-06-02T01:05:08  *** dabura667 has joined #bitcoin-core-dev
 35 2017-06-02T01:07:04  <jtimon> sipa: ping https://github.com/bitcoin/bitcoin/pull/8498#issuecomment-305661391
 36 2017-06-02T01:08:22  *** gielbier has quit IRC
 37 2017-06-02T01:08:45  *** gielbier has joined #bitcoin-core-dev
 38 2017-06-02T01:13:35  *** justan0theruser has quit IRC
 39 2017-06-02T01:14:35  *** justanotheruser has joined #bitcoin-core-dev
 40 2017-06-02T01:33:21  *** Chris_Stewart_5 has quit IRC
 41 2017-06-02T01:38:52  *** harrymm has quit IRC
 42 2017-06-02T01:40:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 43 2017-06-02T01:58:07  *** harrymm has joined #bitcoin-core-dev
 44 2017-06-02T02:13:05  *** PaulCapestany has quit IRC
 45 2017-06-02T02:16:34  *** PaulCapestany has joined #bitcoin-core-dev
 46 2017-06-02T02:44:42  *** RubenSomsen has joined #bitcoin-core-dev
 47 2017-06-02T03:04:35  *** Chris_Stewart_5 has quit IRC
 48 2017-06-02T03:10:05  *** mkarrer has quit IRC
 49 2017-06-02T03:13:57  *** RubenSomsen has quit IRC
 50 2017-06-02T03:25:28  *** RubenSomsen has joined #bitcoin-core-dev
 51 2017-06-02T03:47:05  *** RubenSomsen has quit IRC
 52 2017-06-02T03:48:23  *** guest____ has quit IRC
 53 2017-06-02T03:58:53  <instagibbs> bad timing... https://github.com/drivechain-project/bitcoin/pull/10 just told them about new style guide, haha
 54 2017-06-02T03:59:00  <instagibbs> guess it's good it's merged now
 55 2017-06-02T04:25:38  *** kadoban has quit IRC
 56 2017-06-02T05:12:49  *** harrymm has quit IRC
 57 2017-06-02T05:36:47  <wumpus> cfields: darn
 58 2017-06-02T05:40:28  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/4a41de4585a4dffb451a9be8078abb838235f336
 59 2017-06-02T05:40:28  <bitcoin-git> bitcoin/0.14 4a41de4 Wladimir J. van der Laan: build: bump version to 0.14.2
 60 2017-06-02T05:40:38  <wumpus> well that means there will be a rc2 for sure
 61 2017-06-02T05:43:20  <gmaxwell> oh damnit we did it again.
 62 2017-06-02T05:43:41  <gmaxwell> I somehow missed that we were cutting a rc1.
 63 2017-06-02T05:44:00  <wumpus> another reason it's good that we do rcs in the first place
 64 2017-06-02T05:44:29  <wumpus> that was discussed in the meeting yesterday
 65 2017-06-02T05:44:47  <gmaxwell> yea, I missed part of it.
 66 2017-06-02T05:45:29  <gmaxwell> oh hm. testing is slightly harder because I've upgraded most of my nodes to per txo! :P
 67 2017-06-02T05:45:35  <wumpus> yes, not your fault
 68 2017-06-02T05:45:56  <wumpus> ... same here
 69 2017-06-02T05:49:00  *** Ylbam has joined #bitcoin-core-dev
 70 2017-06-02T06:00:08  *** dermoth has quit IRC
 71 2017-06-02T06:00:56  *** dermoth has joined #bitcoin-core-dev
 72 2017-06-02T06:05:37  *** jtimon has quit IRC
 73 2017-06-02T06:38:21  *** BashCo has quit IRC
 74 2017-06-02T06:44:55  *** Guest60910 has joined #bitcoin-core-dev
 75 2017-06-02T06:47:24  *** Giszmo has quit IRC
 76 2017-06-02T06:48:28  *** Victor_sueca has joined #bitcoin-core-dev
 77 2017-06-02T06:49:29  *** Victorsueca has quit IRC
 78 2017-06-02T06:50:00  *** Victorsueca has joined #bitcoin-core-dev
 79 2017-06-02T06:52:27  *** Victor_sueca has quit IRC
 80 2017-06-02T06:55:42  *** nemgun1 has joined #bitcoin-core-dev
 81 2017-06-02T06:58:46  *** nemgun has quit IRC
 82 2017-06-02T07:04:56  *** BashCo has joined #bitcoin-core-dev
 83 2017-06-02T07:25:59  *** emzy_ is now known as emzy
 84 2017-06-02T07:26:05  *** emzy has joined #bitcoin-core-dev
 85 2017-06-02T07:34:44  *** AaronvanW has joined #bitcoin-core-dev
 86 2017-06-02T07:35:19  *** goatturner has joined #bitcoin-core-dev
 87 2017-06-02T07:35:55  *** Aaronvan_ has joined #bitcoin-core-dev
 88 2017-06-02T07:39:21  *** AaronvanW has quit IRC
 89 2017-06-02T07:39:30  <midnightmagic> ô/w 4
 90 2017-06-02T08:20:30  *** jannes has joined #bitcoin-core-dev
 91 2017-06-02T08:31:58  *** Victorsueca has quit IRC
 92 2017-06-02T08:32:07  *** Victorsueca has joined #bitcoin-core-dev
 93 2017-06-02T08:32:45  *** mkarrer has joined #bitcoin-core-dev
 94 2017-06-02T08:38:53  *** Victorsueca has quit IRC
 95 2017-06-02T08:39:07  *** Victorsueca has joined #bitcoin-core-dev
 96 2017-06-02T08:40:01  *** d9b4bef9 has quit IRC
 97 2017-06-02T08:41:08  *** d9b4bef9 has joined #bitcoin-core-dev
 98 2017-06-02T08:43:11  *** vicenteH has joined #bitcoin-core-dev
 99 2017-06-02T08:59:39  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7cc2c670e3d7...00d369239612
100 2017-06-02T08:59:40  <bitcoin-git> bitcoin/master e7c1b44 Pieter Wuille: Squashed 'src/secp256k1/' changes from 8225239..84973d3...
101 2017-06-02T08:59:40  <bitcoin-git> bitcoin/master 5252827 Pieter Wuille: Update to latest libsecp256k1
102 2017-06-02T08:59:41  <bitcoin-git> bitcoin/master 00d3692 Wladimir J. van der Laan: Merge #10323: Update to latest libsecp256k1 master...
103 2017-06-02T09:00:06  <bitcoin-git> [bitcoin] laanwj closed pull request #10323: Update to latest libsecp256k1 master (master...secp_up) https://github.com/bitcoin/bitcoin/pull/10323
104 2017-06-02T09:03:22  *** cysm_ has quit IRC
105 2017-06-02T09:07:20  *** cysm_ has joined #bitcoin-core-dev
106 2017-06-02T09:23:11  *** Yogaqueef has joined #bitcoin-core-dev
107 2017-06-02T09:26:22  *** SopaXorzTaker has joined #bitcoin-core-dev
108 2017-06-02T09:33:01  *** goatturneer has joined #bitcoin-core-dev
109 2017-06-02T09:36:01  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/00d369239612...1aefc94dd78d
110 2017-06-02T09:36:02  <bitcoin-git> bitcoin/master 930deb9 John Newbery: [tests] skipped tests should clean up after themselves
111 2017-06-02T09:36:02  <bitcoin-git> bitcoin/master 1aefc94 MarcoFalke: Merge #10423: [tests] skipped tests should clean up after themselves...
112 2017-06-02T09:36:34  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10423: [tests] skipped tests should clean up after themselves (master...cleanup_skipped) https://github.com/bitcoin/bitcoin/pull/10423
113 2017-06-02T09:36:41  *** goatturner has quit IRC
114 2017-06-02T09:41:10  *** Guyver2 has joined #bitcoin-core-dev
115 2017-06-02T09:52:05  *** tunafizz has quit IRC
116 2017-06-02T09:52:19  *** tunafizz has joined #bitcoin-core-dev
117 2017-06-02T10:02:12  *** dabura667 has quit IRC
118 2017-06-02T10:13:28  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/1aefc94dd78d...329fc1dce7a1
119 2017-06-02T10:13:29  <bitcoin-git> bitcoin/master d8c218f John Newbery: [tests] Functional tests call self.start_node(s) and self.stop_node(s)...
120 2017-06-02T10:13:29  <bitcoin-git> bitcoin/master a433d8a John Newbery: [tests] Update start/stop node functions to be private module functions...
121 2017-06-02T10:13:30  <bitcoin-git> bitcoin/master 53f6775 John Newbery: fixup: fix nits
122 2017-06-02T10:13:59  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10359: [tests] functional tests should call BitcoinTestFramework start/stop node methods (master...test_framework_start_stop_nodes) https://github.com/bitcoin/bitcoin/pull/10359
123 2017-06-02T10:16:27  *** Aaronvan_ is now known as AaronvanW
124 2017-06-02T10:19:12  *** btcdrak has quit IRC
125 2017-06-02T10:49:29  *** btcdrak has joined #bitcoin-core-dev
126 2017-06-02T11:00:41  *** john has joined #bitcoin-core-dev
127 2017-06-02T11:01:05  *** john is now known as Guest26727
128 2017-06-02T11:01:43  *** Guest60910 has quit IRC
129 2017-06-02T11:02:14  *** beatrootfarmer has joined #bitcoin-core-dev
130 2017-06-02T11:04:57  *** BashCo has quit IRC
131 2017-06-02T11:05:40  *** goatturneer has quit IRC
132 2017-06-02T11:06:01  *** NewLiberty has quit IRC
133 2017-06-02T11:07:26  *** BashCo has joined #bitcoin-core-dev
134 2017-06-02T11:15:08  *** goatturneer has joined #bitcoin-core-dev
135 2017-06-02T11:18:52  *** beatrootfarmer has quit IRC
136 2017-06-02T11:34:53  *** beatrootfarmer has joined #bitcoin-core-dev
137 2017-06-02T11:38:20  *** goatturneer has quit IRC
138 2017-06-02T11:49:58  *** goatturneer has joined #bitcoin-core-dev
139 2017-06-02T11:51:03  *** goatturner has joined #bitcoin-core-dev
140 2017-06-02T11:53:46  *** beatrootfarmer has quit IRC
141 2017-06-02T11:53:59  *** beatrootfarmer has joined #bitcoin-core-dev
142 2017-06-02T11:54:44  *** goatturneer has quit IRC
143 2017-06-02T11:55:38  *** goatturner has quit IRC
144 2017-06-02T12:08:56  *** goatturneer has joined #bitcoin-core-dev
145 2017-06-02T12:12:23  *** RubenSomsen has joined #bitcoin-core-dev
146 2017-06-02T12:12:25  *** beatrootfarmer has quit IRC
147 2017-06-02T12:13:34  *** beatrootfarmer has joined #bitcoin-core-dev
148 2017-06-02T12:17:32  *** goatturner has joined #bitcoin-core-dev
149 2017-06-02T12:17:39  *** goatturneer has quit IRC
150 2017-06-02T12:20:53  *** beatrootfarmer has quit IRC
151 2017-06-02T12:38:52  *** AaronvanW has quit IRC
152 2017-06-02T12:41:46  *** AaronvanW has joined #bitcoin-core-dev
153 2017-06-02T12:53:44  *** Alina-malina has quit IRC
154 2017-06-02T12:54:03  *** Alina-malina has joined #bitcoin-core-dev
155 2017-06-02T12:55:44  *** Gnof has joined #bitcoin-core-dev
156 2017-06-02T12:56:20  *** Alina-malina has quit IRC
157 2017-06-02T12:56:20  *** Alina-malina has joined #bitcoin-core-dev
158 2017-06-02T12:59:12  *** btcdrak has quit IRC
159 2017-06-02T13:06:16  *** str4d has quit IRC
160 2017-06-02T13:07:31  *** jtimon has joined #bitcoin-core-dev
161 2017-06-02T13:11:16  *** goatturneer has joined #bitcoin-core-dev
162 2017-06-02T13:11:38  *** laurentmt has joined #bitcoin-core-dev
163 2017-06-02T13:11:52  *** beatrootfarmer has joined #bitcoin-core-dev
164 2017-06-02T13:15:21  *** goatturner has quit IRC
165 2017-06-02T13:15:44  *** goatturneer has quit IRC
166 2017-06-02T13:15:59  *** laurentmt has quit IRC
167 2017-06-02T13:23:52  *** btcdrak has joined #bitcoin-core-dev
168 2017-06-02T13:29:51  <bitcoin-git> [bitcoin] ryanofsky opened pull request #10508: Run Qt wallet tests on travis (master...pr/travqt) https://github.com/bitcoin/bitcoin/pull/10508
169 2017-06-02T13:35:47  <bitcoin-git> [bitcoin] ryanofsky opened pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
170 2017-06-02T13:37:44  *** NewLiberty has joined #bitcoin-core-dev
171 2017-06-02T13:38:21  <Anduck> https://twitter.com/movrcx/status/870527842789892096
172 2017-06-02T13:41:18  <instagibbs> Anduck, I can do the same offer, but only require 499BTC :)
173 2017-06-02T13:41:58  <Anduck> apparently this guy is "vouched" by some earlier found 0days. could be bullshit though
174 2017-06-02T13:42:14  <Apocalyptic> instagibbs, DoS is a broad term
175 2017-06-02T13:42:45  <Lauda> create 300k TXs per day
176 2017-06-02T13:42:51  <Lauda> now pay me 498 BTC
177 2017-06-02T13:44:49  *** goatturneer has joined #bitcoin-core-dev
178 2017-06-02T13:48:35  *** beatrootfarmer has quit IRC
179 2017-06-02T14:00:38  *** beatrootfarmer has joined #bitcoin-core-dev
180 2017-06-02T14:04:31  *** goatturneer has quit IRC
181 2017-06-02T14:09:18  *** Chris_Stewart_5 has joined #bitcoin-core-dev
182 2017-06-02T14:20:32  *** twistedline has quit IRC
183 2017-06-02T14:22:21  *** twistedline has joined #bitcoin-core-dev
184 2017-06-02T14:24:17  *** Giszmo has joined #bitcoin-core-dev
185 2017-06-02T14:27:03  *** Taek42 is now known as Taek
186 2017-06-02T14:41:54  *** laurentmt has joined #bitcoin-core-dev
187 2017-06-02T14:50:06  <kinlo> mja, ge moest u inschrijven, ik ben aant hore of ik wel kan
188 2017-06-02T14:50:15  *** Dyaheon has quit IRC
189 2017-06-02T14:50:23  <kinlo> wrong channel :/
190 2017-06-02T14:50:53  *** Dyaheon has joined #bitcoin-core-dev
191 2017-06-02T14:56:39  *** elkalamar has quit IRC
192 2017-06-02T14:56:41  *** laurentmt has quit IRC
193 2017-06-02T15:03:52  *** jannes has quit IRC
194 2017-06-02T15:20:42  *** goatturneer has joined #bitcoin-core-dev
195 2017-06-02T15:24:37  *** beatrootfarmer has quit IRC
196 2017-06-02T15:26:41  <jonasschnelli> wumpus: do you intend to directly bump to rc2 or does it make sense to gitian build rc1?
197 2017-06-02T15:26:52  <wumpus> I'd prefer to just go on with it
198 2017-06-02T15:27:18  <wumpus> I'll just add in the announcement that the version isn't bumped and we'll do that for next rc
199 2017-06-02T15:28:43  <jonasschnelli> okay.. fine by me
200 2017-06-02T15:30:23  <wumpus> I'd expect something to come up for rc1, and if not, well then we'll do a very short rc2 just to see if the version bump worked
201 2017-06-02T15:49:36  *** abpa has joined #bitcoin-core-dev
202 2017-06-02T15:57:19  *** beatrootfarmer has joined #bitcoin-core-dev
203 2017-06-02T15:58:18  *** goatturner has joined #bitcoin-core-dev
204 2017-06-02T16:01:17  *** goatturneer has quit IRC
205 2017-06-02T16:01:54  *** beatrootfarmer has quit IRC
206 2017-06-02T16:15:11  *** BashCo has quit IRC
207 2017-06-02T16:18:49  *** rafalcpp has quit IRC
208 2017-06-02T16:37:43  *** BashCo has joined #bitcoin-core-dev
209 2017-06-02T16:40:57  *** chjj has quit IRC
210 2017-06-02T16:54:07  *** RubenSomsen has quit IRC
211 2017-06-02T16:55:02  *** NewLiberty has quit IRC
212 2017-06-02T16:55:19  *** chjj has joined #bitcoin-core-dev
213 2017-06-02T17:05:15  *** RubenSomsen has joined #bitcoin-core-dev
214 2017-06-02T17:25:45  *** Chris_Stewart_5 has quit IRC
215 2017-06-02T17:34:35  *** vicenteH has quit IRC
216 2017-06-02T17:47:59  *** laurentmt has joined #bitcoin-core-dev
217 2017-06-02T18:07:19  *** ula has quit IRC
218 2017-06-02T18:07:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
219 2017-06-02T18:09:48  *** spudowiar has joined #bitcoin-core-dev
220 2017-06-02T18:11:05  <spudowiar> What's the protocol for adding new strings to Bitcoin Core? Do I have to worry about translation or will that be sorted by others?
221 2017-06-02T18:14:13  *** Chris_Stewart_5 has quit IRC
222 2017-06-02T18:15:20  *** Chris_Stewart_5 has joined #bitcoin-core-dev
223 2017-06-02T18:15:56  <sipa> spudowiar: don't worry about it
224 2017-06-02T18:16:10  <sipa> in the 0.15 release notes there is a string freeze
225 2017-06-02T18:16:16  <sipa> eh, release schedule
226 2017-06-02T18:16:33  <sipa> after that time, no changes to strings can be made anymore, to give time for translators
227 2017-06-02T18:17:09  <spudowiar> Thanks :)
228 2017-06-02T18:20:52  *** Gnof_ has joined #bitcoin-core-dev
229 2017-06-02T18:24:27  *** Gnof has quit IRC
230 2017-06-02T18:29:05  *** RubenSomsen has quit IRC
231 2017-06-02T18:33:22  *** Gnof_ has quit IRC
232 2017-06-02T18:40:07  <jnewbery> wumpus: please remove #10044 from high priority for review - I'm not actively working on it for now
233 2017-06-02T18:40:09  <gribble> https://github.com/bitcoin/bitcoin/issues/10044 | Run functional tests in `make check` by jnewbery · Pull Request #10044 · bitcoin/bitcoin · GitHub
234 2017-06-02T18:40:21  <sipa> jnewbery: :(
235 2017-06-02T18:41:06  <sipa> jnewbery: done
236 2017-06-02T18:41:51  <jnewbery> sipa: do you particularly want it? I didn't sense there was all that much enthusiasm for it
237 2017-06-02T18:43:11  <spudowiar> Can I use C++11 std::map::at()?
238 2017-06-02T18:43:53  <sipa> spudowiar: yes, but i would advise against relying on exceptions
239 2017-06-02T18:44:03  <spudowiar> Why?
240 2017-06-02T18:45:15  <sipa> especially in the case of at; you can just use auto it = map.find(key); if (it != map.end()) { ... } else { ... } instead
241 2017-06-02T18:45:34  <spudowiar> Ah, I'll do that instead then
242 2017-06-02T18:45:40  <spudowiar> Thanks!
243 2017-06-02T18:46:06  <sipa> jnewbery: i conceptually like i very much... i think make check should do ~all reasonable checking
244 2017-06-02T18:46:18  <sipa> but i understand there are concerns that make the choice of what to run where and when hard
245 2017-06-02T18:47:12  <jnewbery> yeah - I couldn't seem to converge with others on what's a sensible choice of what to run
246 2017-06-02T18:47:54  <jnewbery> I'll probably pick it up again at some point, but it shouldn't really be in the review priority bucket since there's nothing to review at this point
247 2017-06-02T18:47:56  <sipa> perhaps something to bring up as a meeting topic
248 2017-06-02T18:48:06  <sipa> agree with removing it from priority review list
249 2017-06-02T18:49:19  *** Dyaheon has quit IRC
250 2017-06-02T18:49:40  *** Dyaheon has joined #bitcoin-core-dev
251 2017-06-02T18:53:27  *** Guest26727 has quit IRC
252 2017-06-02T18:55:06  *** Guest80280 has joined #bitcoin-core-dev
253 2017-06-02T18:56:50  *** Chris_Stewart_5 has quit IRC
254 2017-06-02T18:59:09  <spudowiar> Do you have any qualms with executing a command and piping data into it?
255 2017-06-02T18:59:17  <spudowiar> Also, are there any examples of this in the Bitcoin Core code?
256 2017-06-02T19:04:15  <spudowiar> Before, I was using popen but now I want to clean up this patch in order to submit it
257 2017-06-02T19:10:22  *** Guyver2 has quit IRC
258 2017-06-02T19:17:00  *** PaulCapestany has quit IRC
259 2017-06-02T19:19:39  <spudowiar> Should I be adding more code using boost? Because I could use boost::process for this
260 2017-06-02T19:20:03  <spudowiar> I mean, should I be avoiding using boost?
261 2017-06-02T19:20:13  *** PaulCapestany has joined #bitcoin-core-dev
262 2017-06-02T19:32:12  *** SopaXorzTaker has quit IRC
263 2017-06-02T19:38:17  *** spudowiar has quit IRC
264 2017-06-02T19:41:00  *** talmai has joined #bitcoin-core-dev
265 2017-06-02T20:01:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
266 2017-06-02T20:02:40  *** jtimon has quit IRC
267 2017-06-02T20:10:45  *** Yogaqueef has quit IRC
268 2017-06-02T20:11:56  *** talmai has quit IRC
269 2017-06-02T20:15:05  *** talmai has joined #bitcoin-core-dev
270 2017-06-02T20:25:03  *** elkalamar has joined #bitcoin-core-dev
271 2017-06-02T20:39:07  *** Chris_Stewart_5 has quit IRC
272 2017-06-02T20:44:35  *** talmai has quit IRC
273 2017-06-02T20:49:18  *** jtimon has joined #bitcoin-core-dev
274 2017-06-02T21:09:10  *** talmai has joined #bitcoin-core-dev
275 2017-06-02T21:12:57  *** dermoth has quit IRC
276 2017-06-02T21:19:04  <bitcoin-git> [bitcoin] achow101 opened pull request #10511: [Tests] Include branch coverage info in coverage test (master...lcov) https://github.com/bitcoin/bitcoin/pull/10511
277 2017-06-02T21:25:36  *** dermoth has joined #bitcoin-core-dev
278 2017-06-02T21:30:27  *** elkalamar has quit IRC
279 2017-06-02T21:35:00  *** talmai has quit IRC
280 2017-06-02T21:37:06  *** talmai has joined #bitcoin-core-dev
281 2017-06-02T21:42:22  *** tiagotrs_ has joined #bitcoin-core-dev
282 2017-06-02T21:43:00  *** talmai has quit IRC
283 2017-06-02T22:04:01  *** harrymm has joined #bitcoin-core-dev
284 2017-06-02T22:05:14  <bitcoin-git> [bitcoin] luke-jr opened pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
285 2017-06-02T22:11:38  *** tiagotrs_ has quit IRC
286 2017-06-02T22:12:54  *** tiagotrs1 has joined #bitcoin-core-dev
287 2017-06-02T22:15:19  <bitcoin-git> [bitcoin] ABISprotocol opened pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513
288 2017-06-02T22:24:58  *** elkalamar has joined #bitcoin-core-dev
289 2017-06-02T22:27:55  *** altoz has quit IRC
290 2017-06-02T22:28:11  *** altoz has joined #bitcoin-core-dev
291 2017-06-02T22:29:52  *** spudowiar has joined #bitcoin-core-dev
292 2017-06-02T22:31:54  *** jrayhawk_ has joined #bitcoin-core-dev
293 2017-06-02T22:32:05  <spudowiar> gmaxwell: Is JSON alright for serializing data for hardware wallet support? I think it'll be easier for the external tools than normal Bitcoin serialization
294 2017-06-02T22:36:41  <gmaxwell> spudowiar: almost certantly not, needing megabytes of ram to buffer such a thing require several extra dollars in parts.
295 2017-06-02T22:36:58  <spudowiar> No, not on the actual hardware wallet
296 2017-06-02T22:37:08  <spudowiar> For the vendor specific tools
297 2017-06-02T22:37:09  <gmaxwell> spudowiar: existing hardware wallets go through serious work to avoid even having to buffer a single transaction, much less a json encoded one.
298 2017-06-02T22:37:37  <gmaxwell> uh? perhaps but you have to be able to handle the bitcoin seralization in order to compute any hashes over it.
299 2017-06-02T22:37:53  <spudowiar> No, because most hardware wallets serialize it themselves
300 2017-06-02T22:38:33  <spudowiar> Although I have a very complete understanding of Trezor and a very limited ones of others
301 2017-06-02T22:39:03  <spudowiar> Btw, didn't jonasschnelli's hardware wallet used to use JSON :)
302 2017-06-02T22:39:31  <spudowiar> Anyway, I was using Protocol Buffers in my PoC but I knew I couldn't submit that because you'd probably kill me ;)
303 2017-06-02T22:40:27  *** Lightsword_ has joined #bitcoin-core-dev
304 2017-06-02T22:40:27  *** Lightsword has quit IRC
305 2017-06-02T22:40:27  *** jrayhawk has quit IRC
306 2017-06-02T22:40:27  *** thermoman has quit IRC
307 2017-06-02T22:40:34  *** thermoman has joined #bitcoin-core-dev
308 2017-06-02T22:41:05  <spudowiar> Basically my patch takes an argument -hardwarewallet=<cmd>
309 2017-06-02T22:41:19  *** Lightsword_ is now known as Lightsword
310 2017-06-02T22:41:48  <spudowiar> When you spend with the wallet, it executes the command, pipes in the transaction (in Protocol Buffers at the moment) and the command returns the serialized transaction
311 2017-06-02T22:41:55  <spudowiar> Then Bitcoin Core verifies that
312 2017-06-02T22:42:27  <spudowiar> If there's an error, it returns a non-zero status and the message on stdin is used as the failure message in Bitcoin Core
313 2017-06-02T22:42:35  *** tiagotrs1 has quit IRC
314 2017-06-02T22:43:51  * luke-jr idly ponders if there's a way to do that such that bitcoind is itself a valid -hardwarewallet
315 2017-06-02T22:44:18  <gmaxwell> I don't see why you wouldn't use the ordinary serialization plus metadata, _any_ hardware wallet needs to be able to handle the serialization of transactions. Plus how would you proprose to handle things like coinjoins and partially signed multsigs?
316 2017-06-02T22:44:20  <spudowiar> I don't have bitcoind as one, but I have a script that talks to a bitcoind over RPC
317 2017-06-02T22:44:51  <spudowiar> gmaxwell: Hardware wallets don't deserialize the transactions, they always accept it in a different format
318 2017-06-02T22:45:10  <spudowiar> JSON is so much easier because, otherwise, each tool has to deserialize the transaction
319 2017-06-02T22:45:55  <spudowiar> Partially signed multisig, on a TREZOR, is done totally differently to a P2PKH
320 2017-06-02T22:47:00  <spudowiar> luke-jr: ln -s bitcoind bitcoind-hardwarewallet and do an argv check :)
321 2017-06-02T22:47:44  <gmaxwell> spudowiar: of course they do, e.g. to pass them the inputs for value checking you must pass them the input transactions exactly.
322 2017-06-02T22:48:26  <spudowiar> Oh, yeah. But they don't deserialize the to-be-signed transaction
323 2017-06-02T22:50:58  <sipa> then how do they compute the sighash?
324 2017-06-02T22:51:14  <spudowiar> They serialize it from their own format
325 2017-06-02T22:51:21  <spudowiar> e.g. TREZOR uses Protocol Buffers
326 2017-06-02T22:52:24  <luke-jr> spudowiar: i was thinking more of using JSON-RPC over stdio
327 2017-06-02T22:52:47  <spudowiar> That's an interesting idea
328 2017-06-02T22:53:20  <spudowiar> Because a hardware wallet could ask for transactions when it needs them, etc.
329 2017-06-02T22:54:01  <spudowiar> Anyway, should I be adding more uses of boost? Was thinking of using boost::process
330 2017-06-02T22:54:16  <spudowiar> In my PoC I used popen and pclose but that's not very C++-esque
331 2017-06-02T22:56:06  <gmaxwell> it just seems like a total waste of time and effort to define a whole new seralization which has to be completely compatible and able to encode everything a transaction can encode.
332 2017-06-02T22:56:10  <gmaxwell> Whats the purpose?
333 2017-06-02T22:56:44  <luke-jr> gmaxwell: HW wallet vendor provides a plugin for Core
334 2017-06-02T22:56:51  <spudowiar> But then each script has to deserialize the transaction which seems like a total waste of time ;)
335 2017-06-02T22:59:37  <gmaxwell> spudowiar: that isn't escape by using a _different_ seralization.
336 2017-06-02T23:00:20  <spudowiar> Python, for example, has built-in JSON support
337 2017-06-02T23:02:19  <spudowiar> JSON-RPC over stdio seems like a neat idea though
338 2017-06-02T23:06:05  <spudowiar> gmaxwell: What about using the format for decoderawtransaction (possibly with a bit more metadata, if needed)
339 2017-06-02T23:07:28  <sipa> whatever you do, please don't try to represent multisig as multiple addresses :)
340 2017-06-02T23:11:02  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/329fc1dce7a1...098b01dc58ff
341 2017-06-02T23:11:02  <bitcoin-git> bitcoin/master b9b814a Russell Yanofsky: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings
342 2017-06-02T23:11:03  <bitcoin-git> bitcoin/master 098b01d Pieter Wuille: Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings...
343 2017-06-02T23:11:34  <bitcoin-git> [bitcoin] sipa closed pull request #10500: Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (master...pr/wtxcopy) https://github.com/bitcoin/bitcoin/pull/10500
344 2017-06-02T23:11:42  *** Guest80280 has quit IRC
345 2017-06-02T23:11:56  *** tiagotrs has joined #bitcoin-core-dev
346 2017-06-02T23:11:59  <luke-jr> hm, 0.14.2 seems to have missed some fixes still :x
347 2017-06-02T23:12:38  <gmaxwell> spudowiar: but you can't do anything with bitcoin transactions without also having bitcoin transaction ser/des support!  and then you have to worry about that your json format cannot losslessly represent a transaction.  Decoderawtransaction cannot. E.g. it can't encoding different choices for encoding in varints.
348 2017-06-02T23:13:40  <luke-jr> gmaxwell: the other end would translate the JSON into some hardware interface; the hardware wallet itself does the serialisation
349 2017-06-02T23:13:51  <luke-jr> ie, there's a middle-man who has no need to understand ser/des
350 2017-06-02T23:14:08  <spudowiar> ^^
351 2017-06-02T23:15:02  *** abpa has quit IRC
352 2017-06-02T23:16:58  <aj> gmaxwell: (post-segwit you don't want the serialised input tx, you just want the txid, value and some signing key id, no?)
353 2017-06-02T23:17:14  <sipa> yes
354 2017-06-02T23:17:15  <luke-jr> spudowiar: note that using JSON-RPC means bitcoind will call signrawtransaction, and you'll have to deserialise (or pass as-is?)
355 2017-06-02T23:18:38  <spudowiar> What do you mean? I was thinking of sending the current transaction then the hardware wallet could ask for input transactions (and the script would use JSON RPC to grab them)
356 2017-06-02T23:20:19  <gmaxwell> aj: not for the inputs, but you still want the whole transaction itself.
357 2017-06-02T23:20:41  *** abpa has joined #bitcoin-core-dev
358 2017-06-02T23:21:40  <gmaxwell> aj: I think it would be fairly hard and at least wasteful to define a whole new serialization that is a guarenteed superset of the transaction format.  I think spudowiar is thinking that you can just say {pay inputs x,y,z to destination a,b,c}  but that doesn't work if the hw wallet isn't the author of the whole transaction.
359 2017-06-02T23:22:18  *** abpa has quit IRC
360 2017-06-02T23:23:23  <spudowiar> gmaxwell: that is literally what all hardware wallets do right now
361 2017-06-02T23:23:47  <spudowiar> Even for multisig, they don't accept a serialized transaction
362 2017-06-02T23:24:18  <arubi> (this is why I was requesting raw sighash support :) )
363 2017-06-02T23:24:24  <aj> gmaxwell: yeah, i think i agree; i think you just want to send the serialised partially-filled out tx you want to create/sign, and extra info needed to do the signature (txids, tx values, pre-segwit-serialised-input-txes, SIGHASH params, etc)?
364 2017-06-02T23:24:36  <gmaxwell> spudowiar: that isn't true; ledger takes seralized transactions.
365 2017-06-02T23:24:50  <gmaxwell> aj: yes, thats my thinking.
366 2017-06-02T23:24:52  <spudowiar> Oh, does it? I didn't know
367 2017-06-02T23:26:54  *** andytoshi has joined #bitcoin-core-dev
368 2017-06-02T23:41:03  <bitcoin-git> [bitcoin] sipa opened pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
369 2017-06-02T23:42:17  <spudowiar> I wonder if it's a good to switch from Google's Protocol Buffers implementation to nanopb
370 2017-06-02T23:42:36  <spudowiar> Google's Protocol Buffers code generator generates an utter mess
371 2017-06-02T23:42:53  <spudowiar> But nanopb generates some nice code (it's used in TREZOR)
372 2017-06-02T23:43:24  <spudowiar> s/a good/a good idea/
373 2017-06-02T23:46:00  *** kadoban has joined #bitcoin-core-dev
374 2017-06-02T23:53:08  *** tiagotrs has quit IRC
375 2017-06-02T23:55:39  *** spudowiar has quit IRC