1 2017-06-04T00:03:04  *** juscamarena has joined #bitcoin-core-dev
  2 2017-06-04T00:03:17  *** Yogaqueef has quit IRC
  3 2017-06-04T00:03:27  *** juscamarena is now known as Guest56917
  4 2017-06-04T00:03:35  *** roidster has quit IRC
  5 2017-06-04T00:06:26  *** juscamarena_ has quit IRC
  6 2017-06-04T00:08:31  *** vicenteH has quit IRC
  7 2017-06-04T00:19:06  *** Victor_sueca has joined #bitcoin-core-dev
  8 2017-06-04T00:21:52  *** jtimon has quit IRC
  9 2017-06-04T00:22:03  *** Victorsueca has quit IRC
 10 2017-06-04T00:24:37  *** Guest80280 has quit IRC
 11 2017-06-04T00:32:40  *** Guest80280 has joined #bitcoin-core-dev
 12 2017-06-04T00:38:14  *** nemgun has quit IRC
 13 2017-06-04T00:46:18  *** nemgun has joined #bitcoin-core-dev
 14 2017-06-04T01:04:02  *** AaronvanW has quit IRC
 15 2017-06-04T01:05:31  *** Guest80280 has quit IRC
 16 2017-06-04T01:05:41  *** Guest60935 has joined #bitcoin-core-dev
 17 2017-06-04T01:06:21  *** nemgun1 has joined #bitcoin-core-dev
 18 2017-06-04T01:09:12  *** nemgun has quit IRC
 19 2017-06-04T01:09:23  *** Ylbam has quit IRC
 20 2017-06-04T01:26:05  *** Guest60935 has quit IRC
 21 2017-06-04T01:46:47  <btcdrak> looks like https://travis-ci.org/bitcoin/bitcoin/builds/238932256 needs of two jobs which stall-errored
 22 2017-06-04T01:58:12  *** RubenSomsen has joined #bitcoin-core-dev
 23 2017-06-04T02:20:30  *** belcher has quit IRC
 24 2017-06-04T02:34:45  *** kadoban has joined #bitcoin-core-dev
 25 2017-06-04T02:48:41  *** nemgun1 has quit IRC
 26 2017-06-04T03:00:05  *** Alina-malina has quit IRC
 27 2017-06-04T03:00:51  *** Alina-malina has joined #bitcoin-core-dev
 28 2017-06-04T03:06:02  *** d9b4bef9 has quit IRC
 29 2017-06-04T03:07:08  *** d9b4bef9 has joined #bitcoin-core-dev
 30 2017-06-04T03:08:13  *** d_t has joined #bitcoin-core-dev
 31 2017-06-04T03:42:09  *** justan0theruser has joined #bitcoin-core-dev
 32 2017-06-04T03:44:19  *** justanotheruser has quit IRC
 33 2017-06-04T03:50:13  *** goatturner has quit IRC
 34 2017-06-04T03:51:13  *** justan0theruser is now known as justanotheruser
 35 2017-06-04T04:00:27  *** kadoban has quit IRC
 36 2017-06-04T04:20:20  *** kadoban has joined #bitcoin-core-dev
 37 2017-06-04T04:25:11  *** kadoban has quit IRC
 38 2017-06-04T04:32:07  *** d_t has quit IRC
 39 2017-06-04T04:41:34  <gmaxwell> wumpus: https://blog.minio.io/accelerating-sha256-by-100x-in-golang-on-arm-1517225f5ff4  those are some pretty impressive numbers.
 40 2017-06-04T04:53:54  *** kadoban has joined #bitcoin-core-dev
 41 2017-06-04T05:07:37  <luke-jr> can people check their positions on https://en.bitcoin.it/wiki/Segwit_support and fill in any blanks? thanks
 42 2017-06-04T05:29:06  *** Deadhand has quit IRC
 43 2017-06-04T05:32:13  *** Deadhand has joined #bitcoin-core-dev
 44 2017-06-04T05:32:53  *** RubenSomsen has quit IRC
 45 2017-06-04T05:44:59  *** btcdrak has quit IRC
 46 2017-06-04T06:00:05  *** dermoth has quit IRC
 47 2017-06-04T06:00:47  *** dermoth has joined #bitcoin-core-dev
 48 2017-06-04T06:18:16  *** Victor_sueca is now known as Victorsueca
 49 2017-06-04T06:20:58  *** Alina-malina has quit IRC
 50 2017-06-04T06:20:58  *** Alina-malina has joined #bitcoin-core-dev
 51 2017-06-04T06:52:43  *** kadoban has quit IRC
 52 2017-06-04T06:53:10  *** kadoban has joined #bitcoin-core-dev
 53 2017-06-04T06:55:07  *** d_t has joined #bitcoin-core-dev
 54 2017-06-04T06:56:13  *** AaronvanW has joined #bitcoin-core-dev
 55 2017-06-04T06:57:25  *** Aaronvan_ has joined #bitcoin-core-dev
 56 2017-06-04T07:01:02  *** d9b4bef9 has quit IRC
 57 2017-06-04T07:01:31  *** AaronvanW has quit IRC
 58 2017-06-04T07:02:08  *** d9b4bef9 has joined #bitcoin-core-dev
 59 2017-06-04T07:06:35  *** d_t has quit IRC
 60 2017-06-04T07:12:05  *** kadoban has quit IRC
 61 2017-06-04T08:00:50  *** chjj has quit IRC
 62 2017-06-04T08:18:52  *** chjj has joined #bitcoin-core-dev
 63 2017-06-04T08:19:07  *** chjj has quit IRC
 64 2017-06-04T08:19:32  *** chjj has joined #bitcoin-core-dev
 65 2017-06-04T08:38:41  *** Guest60935 has joined #bitcoin-core-dev
 66 2017-06-04T08:56:43  *** mkarrer has quit IRC
 67 2017-06-04T09:10:37  *** goatturner has joined #bitcoin-core-dev
 68 2017-06-04T09:34:55  *** jtimon has joined #bitcoin-core-dev
 69 2017-06-04T09:35:06  *** Guyver2 has joined #bitcoin-core-dev
 70 2017-06-04T09:52:19  *** tunafizz has quit IRC
 71 2017-06-04T09:52:48  *** tunafizz has joined #bitcoin-core-dev
 72 2017-06-04T10:29:37  *** Yogaqueef has joined #bitcoin-core-dev
 73 2017-06-04T10:33:44  *** goatturneer has joined #bitcoin-core-dev
 74 2017-06-04T10:37:47  *** goatturner has quit IRC
 75 2017-06-04T10:39:39  *** Yogaqueef has quit IRC
 76 2017-06-04T11:10:10  *** jouke has quit IRC
 77 2017-06-04T11:12:18  *** jouke has joined #bitcoin-core-dev
 78 2017-06-04T11:12:18  *** jouke has quit IRC
 79 2017-06-04T11:12:18  *** jouke has joined #bitcoin-core-dev
 80 2017-06-04T11:28:45  *** btcdrak has joined #bitcoin-core-dev
 81 2017-06-04T11:36:28  *** SopaXorzTaker has quit IRC
 82 2017-06-04T11:37:20  *** SopaXorzTaker has joined #bitcoin-core-dev
 83 2017-06-04T11:42:15  *** mkarrer has joined #bitcoin-core-dev
 84 2017-06-04T12:06:34  *** jtimon has quit IRC
 85 2017-06-04T12:06:43  *** BobBarker has quit IRC
 86 2017-06-04T12:18:55  *** beatrootfarmer has joined #bitcoin-core-dev
 87 2017-06-04T12:22:35  *** goatturneer has quit IRC
 88 2017-06-04T12:31:00  *** spudowiar has joined #bitcoin-core-dev
 89 2017-06-04T12:31:25  <spudowiar> What's your preference for starting a process and piping data?
 90 2017-06-04T12:31:29  <spudowiar> fork, pipe, dup2?
 91 2017-06-04T12:31:44  <spudowiar> I mean pipe, fork , dup2
 92 2017-06-04T12:32:16  <spudowiar> popen won't work because it only supports one direction
 93 2017-06-04T12:33:05  *** Alina-malina has quit IRC
 94 2017-06-04T12:36:52  *** RubenSomsen has joined #bitcoin-core-dev
 95 2017-06-04T12:47:51  *** nemgun has joined #bitcoin-core-dev
 96 2017-06-04T12:53:33  <spudowiar> Actually, Boost dependency was updated to 1.64.0 which has boost::process
 97 2017-06-04T12:56:20  *** nemgun has quit IRC
 98 2017-06-04T12:56:31  *** nemgun has joined #bitcoin-core-dev
 99 2017-06-04T13:08:01  *** Alina-malina has joined #bitcoin-core-dev
100 2017-06-04T13:09:58  *** Alina-malina has joined #bitcoin-core-dev
101 2017-06-04T13:13:18  *** LeMiner has quit IRC
102 2017-06-04T13:16:54  *** jtimon has joined #bitcoin-core-dev
103 2017-06-04T13:35:24  *** goatturneer has joined #bitcoin-core-dev
104 2017-06-04T13:36:31  *** LeMiner has joined #bitcoin-core-dev
105 2017-06-04T13:38:47  *** beatrootfarmer has quit IRC
106 2017-06-04T13:46:22  *** LeMiner has quit IRC
107 2017-06-04T13:49:29  *** LeMiner has joined #bitcoin-core-dev
108 2017-06-04T13:50:28  *** d_t has joined #bitcoin-core-dev
109 2017-06-04T13:55:01  *** d_t has quit IRC
110 2017-06-04T13:56:46  *** LeMiner has quit IRC
111 2017-06-04T13:59:08  *** LeMiner has joined #bitcoin-core-dev
112 2017-06-04T14:04:31  *** Dyaheon has quit IRC
113 2017-06-04T14:05:47  *** Dyaheon has joined #bitcoin-core-dev
114 2017-06-04T14:07:06  *** wasi has joined #bitcoin-core-dev
115 2017-06-04T14:08:37  *** LeMiner has quit IRC
116 2017-06-04T14:10:46  *** LeMiner has joined #bitcoin-core-dev
117 2017-06-04T14:10:59  *** LeMiner has joined #bitcoin-core-dev
118 2017-06-04T14:24:17  *** wasi has quit IRC
119 2017-06-04T14:25:18  *** beatrootfarmer has joined #bitcoin-core-dev
120 2017-06-04T14:27:40  *** wasi has joined #bitcoin-core-dev
121 2017-06-04T14:29:03  *** goatturneer has quit IRC
122 2017-06-04T14:30:02  *** d9b4bef9 has quit IRC
123 2017-06-04T14:33:08  *** d9b4bef9 has joined #bitcoin-core-dev
124 2017-06-04T14:34:01  *** d9b4bef9 has quit IRC
125 2017-06-04T14:35:09  *** d9b4bef9 has joined #bitcoin-core-dev
126 2017-06-04T14:56:21  *** Chris_Stewart_5 has joined #bitcoin-core-dev
127 2017-06-04T15:09:03  <spudowiar> One issue I have is that waiting for the output of the command is run on the UI thread, so Bitcoin Core appears to hang :/
128 2017-06-04T15:10:37  *** str4d has quit IRC
129 2017-06-04T15:12:27  *** Guest60935 has quit IRC
130 2017-06-04T15:24:07  *** owowo has quit IRC
131 2017-06-04T15:27:05  *** Guest60935 has joined #bitcoin-core-dev
132 2017-06-04T15:28:37  *** RubenSomsen has quit IRC
133 2017-06-04T15:40:24  *** goatturneer has joined #bitcoin-core-dev
134 2017-06-04T15:43:24  *** goatturner has joined #bitcoin-core-dev
135 2017-06-04T15:44:11  *** beatrootfarmer has quit IRC
136 2017-06-04T15:45:35  *** owowo has joined #bitcoin-core-dev
137 2017-06-04T15:46:56  *** goatturneer has quit IRC
138 2017-06-04T15:55:53  *** owowo has quit IRC
139 2017-06-04T16:04:38  *** owowo has joined #bitcoin-core-dev
140 2017-06-04T16:04:38  *** owowo has joined #bitcoin-core-dev
141 2017-06-04T16:04:43  *** PaulCapestany has quit IRC
142 2017-06-04T16:09:37  *** Dyaheon has quit IRC
143 2017-06-04T16:12:57  *** Dyaheon has joined #bitcoin-core-dev
144 2017-06-04T16:23:06  *** kadoban has joined #bitcoin-core-dev
145 2017-06-04T16:52:21  *** Ylbam has joined #bitcoin-core-dev
146 2017-06-04T17:16:25  *** DCLXVI` is now known as dclxvi
147 2017-06-04T17:18:24  <BlueMatt> luke-jr: you appear to have seemingly removed nearly all nuance
148 2017-06-04T17:18:43  <BlueMatt> luke-jr: you should have a category like "Fine, iff there is massive community consensus that doesnt nearly yet exist"
149 2017-06-04T17:18:54  <BlueMatt> then you could probably drop almost everyone into that category
150 2017-06-04T17:31:00  *** Guest34260 has joined #bitcoin-core-dev
151 2017-06-04T17:32:00  *** Guest60935 has quit IRC
152 2017-06-04T17:40:50  *** Guyver2 has quit IRC
153 2017-06-04T17:42:06  *** arubi is now known as `arubi
154 2017-06-04T17:43:26  <luke-jr> BlueMatt: that's kinda chicken-and-egg. people are deferring to dev pessimism as a reason to not consent themselves. but if you have a suggestion to get more nuance on the wiki page, we can do that anyway. Perhaps a yellow "Wanting" defined as "it is acceptable, only with more community acceptance"?
155 2017-06-04T17:43:27  *** `arubi is now known as arubi
156 2017-06-04T17:44:06  <BlueMatt> luke-jr: i didnt say "want", i said "fuck no, not without a massive consensus success, which appears to have about zero chance at this moment"
157 2017-06-04T17:44:41  <BlueMatt> luke-jr: and, no, while some rando folks are deferring to devs there, a lot are not, and are flat out saying "this is stupid"
158 2017-06-04T17:44:50  <luke-jr> I was thinking "wanting" as in "I think it is wanting for support"; alternative table-fitting words?
159 2017-06-04T17:45:10  <luke-jr> BlueMatt: people against BIP148 on their own are a very small group
160 2017-06-04T17:45:28  <gmaxwell> luke-jr: perhaps you should take it seriously when many people are telling you that this is a lot like Bitcoin XT or Bitcoin Classic's hardfork, but you've just defined yourself into a corner.
161 2017-06-04T17:47:37  <BlueMatt> luke-jr: people against classic and xt initially were a very small group, fwiw, its only after it became clear that there was a lack of consensus and serious technical concern that folks started jumping ship
162 2017-06-04T17:49:21  <BlueMatt> luke-jr: a series of people saying "this is too risky, I cannot support" (and i mean not just dev folks, also several biz folks have made similar noise) should not imply "ok, full steam ahead, they'll come around"
163 2017-06-04T17:49:36  <luke-jr> there is no comparison. Classic/XT were hardfork proposals with serious technical problems and done by trolls who wanted to "fire Core". BIP148 is a softfork proposal with no real technical problems, and widespread community support.
164 2017-06-04T17:49:37  *** goatturneer has joined #bitcoin-core-dev
165 2017-06-04T17:50:06  <BlueMatt> luke-jr: I was told my several of the most ardent 148 supporters last week that 148 will "fire core" cause core is now getting in the way
166 2017-06-04T17:50:07  <luke-jr> BlueMatt: not doing BIP148 is objectively riskier than BIP148 itself, which has no risk at all given sufficient support.
167 2017-06-04T17:50:15  *** beatrootfarmer has joined #bitcoin-core-dev
168 2017-06-04T17:50:48  <BlueMatt> luke-jr: that is your opinion. other equally-well-informed minds strongly disagree
169 2017-06-04T17:52:56  *** goatturner has quit IRC
170 2017-06-04T17:53:48  <BlueMatt> luke-jr: and, key to your point is "given sufficient support", but, then, "given sufficient support" nearly any consensus change becomes incredibly easy
171 2017-06-04T17:54:10  *** goatturneer has quit IRC
172 2017-06-04T17:54:11  <BlueMatt> luke-jr: and most of what I'm telling you is that bip 148 can not, and will not, get sufficient support in the current community
173 2017-06-04T17:55:05  <luke-jr> it already has it; the only potential risk is people blindly following "Core" who think "Core" is opposed
174 2017-06-04T17:57:50  <midnightmagic> Don't use language that guarantees people can't work together anymore after the resolution becomes clear. There are *actually* bad people sharpening their knives watching.
175 2017-06-04T17:58:12  <luke-jr> midnightmagic: ? referring to what
176 2017-06-04T17:59:10  <midnightmagic> This escalation that's going on in here right now, and jerkoffs who are going to attempt to use it to harm you all in the near future.
177 2017-06-04T18:05:28  <sipa> luke-jr: also don't equate "against merging support for BIP148 in core" with "against BIP148"
178 2017-06-04T18:07:22  <sipa> the bar for the first is far higher than personal preferences
179 2017-06-04T18:07:50  <luke-jr> sipa: are you of a position that BIP148 should not be merged, but you don't oppose it personally?
180 2017-06-04T18:07:59  <luke-jr> (the wiki page is intended to be the latter)
181 2017-06-04T18:08:24  <sipa> if there were pervasive support for BIp148, i would encourage it
182 2017-06-04T18:09:14  <sipa> right now, i think it is too risky (for a combination of technical reasons, too short timeframe, and me not seeing the degree of support i believe is necessary to make it a success) to encourage anyone to run it
183 2017-06-04T18:09:40  <sipa> but i'm not opposed to it in principle... in particular, i'd like be proven wrong on the degree of support which is admitted hard to measure
184 2017-06-04T18:10:37  <sipa> *admittedly
185 2017-06-04T18:13:23  <luke-jr> okay, I've updated the wiki page with two new categories Deficient and Wanting, and reclassified BIP148 for Matt as Deficient and sipa as Wanting; hope this is accurate
186 2017-06-04T18:13:51  <luke-jr> aside from BIP148, it would be helpful to get positions on the other proposals on the page
187 2017-06-04T18:14:23  *** RubenSomsen has joined #bitcoin-core-dev
188 2017-06-04T18:14:57  *** Dyaheon has quit IRC
189 2017-06-04T18:15:23  <luke-jr> (and feel free to edit descriptions/colours/add new categories/etc if you think it helps improve clarity)
190 2017-06-04T18:17:33  *** Dyaheon has joined #bitcoin-core-dev
191 2017-06-04T18:20:27  *** goatturneer has joined #bitcoin-core-dev
192 2017-06-04T18:21:38  <spudowiar> Hmm, either this transaction is totally messed up or EncodeHexTx is totally messing it up
193 2017-06-04T18:22:07  <spudowiar> Or python-bitcoinlib is messed up
194 2017-06-04T18:23:36  <spudowiar> Right, decoderawtransaction is working fine on this tx
195 2017-06-04T18:23:50  *** beatrootfarmer has quit IRC
196 2017-06-04T18:25:20  <spudowiar> Oh, wait, this is a SegWit tx
197 2017-06-04T18:25:35  <spudowiar> I assume that python-bitcoinlib doesn't handle SegWit
198 2017-06-04T18:25:38  <spudowiar> Right, petertodd?
199 2017-06-04T18:29:30  <spudowiar> *celebrates*
200 2017-06-04T18:32:31  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/098b01dc58ff...400fdd08cc95
201 2017-06-04T18:32:31  <bitcoin-git> bitcoin/master 5f672ca Pavlos Antoniou: net: Denote some CNode functions const
202 2017-06-04T18:32:32  <bitcoin-git> bitcoin/master 400fdd0 Pieter Wuille: Merge #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount()  as const...
203 2017-06-04T18:33:02  *** BobBarker has joined #bitcoin-core-dev
204 2017-06-04T18:33:02  <bitcoin-git> [bitcoin] sipa closed pull request #10471: Denote functions CNode::GetRecvVersion() and CNode::GetRefCount()  as const (master...master) https://github.com/bitcoin/bitcoin/pull/10471
205 2017-06-04T18:38:05  *** SopaXorzTaker has quit IRC
206 2017-06-04T18:49:16  <bitcoin-git> [bitcoin] sipa opened pull request #10526: Force on-the-fly compaction during pertxout upgrade (master...compactrange) https://github.com/bitcoin/bitcoin/pull/10526
207 2017-06-04T18:58:16  <spudowiar> GAHH
208 2017-06-04T18:58:27  <spudowiar> It signed it, it sent it back to Core and Core failed the verification
209 2017-06-04T19:10:26  *** belcher has joined #bitcoin-core-dev
210 2017-06-04T19:10:32  *** belcher has quit IRC
211 2017-06-04T19:15:44  *** RubenSomsen has quit IRC
212 2017-06-04T19:17:39  <spudowiar> On one hand, it's failing the verification
213 2017-06-04T19:17:52  <spudowiar> On the other, it's doing a valid transaction that sendrawtransaction can broadcast
214 2017-06-04T19:20:03  <spudowiar> Oh, FML
215 2017-06-04T19:20:12  <spudowiar> I did IsHardwareWallet && !CallHardwareWallet
216 2017-06-04T19:20:21  <spudowiar> Which means if it's successful, it will carry on and fail :(
217 2017-06-04T19:20:31  <spudowiar> (It will do the else part)
218 2017-06-04T19:21:43  <spudowiar> Yes! Hardware wallet support works!
219 2017-06-04T19:26:12  <spudowiar> sipa: I ended up doing a signrawtransaction-esque API https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1489-L1527
220 2017-06-04T19:26:23  <spudowiar> But instead of privkeys, it does the hdKeypath
221 2017-06-04T19:26:37  <spudowiar> And it adds a transaction key to each of the prevtxs with the raw transaction
222 2017-06-04T19:28:30  <spudowiar> Here's the plugin: https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/contrib/bitcoin-hww-trezor
223 2017-06-04T19:28:46  <spudowiar> jonasschnelli, luke-jr, NicolasDorier: ^^
224 2017-06-04T19:29:13  <jonasschnelli> 75 lines?
225 2017-06-04T19:29:48  <jonasschnelli> Can you make it vendor independent? :)
226 2017-06-04T19:29:57  <spudowiar> You need another script for each vendor :)
227 2017-06-04T19:30:14  <jonasschnelli> I guess we need a standard
228 2017-06-04T19:30:19  <luke-jr> jonasschnelli: the whole point is that the script is the interface
229 2017-06-04T19:30:33  <spudowiar> The command is `src/qt/bitcoin-qt -testnet -hardwarewallet=contrib/bitcoin-hww-trezor`
230 2017-06-04T19:30:53  <spudowiar> Or bitcoind if that floats your boat :)
231 2017-06-04T19:31:05  <jonasschnelli> ah. I see.
232 2017-06-04T19:31:15  <jonasschnelli> I though the script is the only thing you need
233 2017-06-04T19:31:41  <spudowiar> You have a script for each hardware wallet, and you set -hardwarewallet= to the script
234 2017-06-04T19:32:09  <spudowiar> One issue with this patch is that it runs on the UI thread so Bitcoin-Qt hangs while you confirm it on the hardware wallet
235 2017-06-04T19:32:35  <sipa> that sounds pretty bad :)
236 2017-06-04T19:32:41  <luke-jr> could be worse
237 2017-06-04T19:32:47  <luke-jr> but definitely something to fix
238 2017-06-04T19:32:49  <spudowiar> luke-jr, always optimistic
239 2017-06-04T19:33:00  <spudowiar> There are issues about moving stuff off the UI thread so I didn't bother with it at the moment
240 2017-06-04T19:33:14  <spudowiar> When CreateTransaction gets moved off the UI thread, this will fix itself
241 2017-06-04T19:34:05  <luke-jr> spudowiar: you mean sign?
242 2017-06-04T19:34:24  <luke-jr> IMO we should prompt in GUI for fee/etc before trying to sign
243 2017-06-04T19:34:26  <spudowiar> Well, CreateTransaction calls the signature stuff
244 2017-06-04T19:35:50  <spudowiar> Whoops, need to add CallHardwareWallet into CWallet::SignTransaction as well
245 2017-06-04T19:36:03  <spudowiar> Anyway, one issue is that it's not doing change addresses right ATM
246 2017-06-04T19:36:14  <spudowiar> So, it sees them as an extra output
247 2017-06-04T19:36:29  <sipa> is that a problem?
248 2017-06-04T19:36:38  <spudowiar> Yes, but it's one I can fix :)
249 2017-06-04T19:36:51  <spudowiar> Because the hardware wallet isn't meant to show the change addresses
250 2017-06-04T19:37:01  <bitcoin-git> [bitcoin] practicalswift opened pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
251 2017-06-04T19:37:22  <spudowiar> e.g. I sent 0.7 tBTC and I had 1.3 tBTC, so the TREZOR asked me to send 1.299 tBTC when it should have said 0.7 tBTC
252 2017-06-04T19:38:08  *** Chris_Stewart_5 has quit IRC
253 2017-06-04T19:40:02  <sipa> right; i guess you should have a way to tell the hardware "output X is to derivation path Y, which is yours; don't include it in the amount"
254 2017-06-04T19:40:55  <spudowiar> Also, this doesn't look good https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/contrib/bitcoin-hww-trezor#L54
255 2017-06-04T19:41:19  <spudowiar> I shouldn't have to reverse it
256 2017-06-04T19:42:39  <sipa> for historical reasons, bitcoin treats txids as little-endian 256-bit numbers, and when printing them for human consumption, uses big-endian (because that's how we format numbers)
257 2017-06-04T19:42:53  <sipa> as a result, the hex string is in the opposite order from the actual bytes
258 2017-06-04T19:43:07  <spudowiar> I know, but this isn't a hex string
259 2017-06-04T19:43:13  <spudowiar> I *think*
260 2017-06-04T19:43:45  <spudowiar> Yeah, it's not a hex string
261 2017-06-04T19:44:04  <sipa> hmm
262 2017-06-04T19:44:14  <sipa> still may be some LE/BE confusion
263 2017-06-04T19:44:39  <spudowiar> Maybe, I'll have a look at my code again another day, do a bit of refactoring
264 2017-06-04T19:45:00  <spudowiar> gtg
265 2017-06-04T19:45:01  *** spudowiar has quit IRC
266 2017-06-04T19:54:01  *** d9b4bef9 has quit IRC
267 2017-06-04T19:55:08  *** d9b4bef9 has joined #bitcoin-core-dev
268 2017-06-04T19:57:47  *** spudowiar has joined #bitcoin-core-dev
269 2017-06-04T20:11:19  <BlueMatt> luke-jr: ehh, I'm more of the "not really ok with the idea, also considers it to have insufficient community support" view
270 2017-06-04T20:11:41  *** betawaffle has joined #bitcoin-core-dev
271 2017-06-04T20:11:51  <luke-jr> BlueMatt: how is that not "No"?
272 2017-06-04T20:12:42  <BlueMatt> luke-jr: taken separately: I'm ok going along with lots of things that I think are technically not good, if there is real community support for them. 148 falls into that category. Separately, I dont think 148 has or will get sufficient community support
273 2017-06-04T20:13:13  <BlueMatt> luke-jr: I dunno, your putting folks into buckets idea loses all nuance
274 2017-06-04T20:13:21  <BlueMatt> luke-jr: you should create a separate category for everyone :)
275 2017-06-04T20:13:51  <luke-jr> BlueMatt: thoughts on BIP 149, Segwit2x, and COOP? :P
276 2017-06-04T20:13:56  *** andytoshi has left #bitcoin-core-dev
277 2017-06-04T20:14:10  <BlueMatt> bye andrew :(
278 2017-06-04T20:17:40  <luke-jr> ?
279 2017-06-04T20:18:20  <BlueMatt> andytoshi left
280 2017-06-04T20:19:00  *** thrasher` has quit IRC
281 2017-06-04T20:21:26  *** Dyaheon has quit IRC
282 2017-06-04T20:22:12  *** Dyaheon has joined #bitcoin-core-dev
283 2017-06-04T20:23:22  *** thrasher` has joined #bitcoin-core-dev
284 2017-06-04T20:37:38  *** lightningbot has joined #bitcoin-core-dev
285 2017-06-04T20:38:59  *** sipa__ has joined #bitcoin-core-dev
286 2017-06-04T20:39:10  *** Taek42 has joined #bitcoin-core-dev
287 2017-06-04T20:39:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
288 2017-06-04T20:46:06  *** da2ce7_ has joined #bitcoin-core-dev
289 2017-06-04T20:46:09  *** sipa has quit IRC
290 2017-06-04T20:46:09  *** Taek has quit IRC
291 2017-06-04T20:46:09  *** nsh has quit IRC
292 2017-06-04T20:46:13  *** da2ce7 has quit IRC
293 2017-06-04T20:46:14  *** wallet42 has quit IRC
294 2017-06-04T20:46:14  *** mappum has quit IRC
295 2017-06-04T20:46:15  *** michagogo has quit IRC
296 2017-06-04T20:46:15  *** profall has quit IRC
297 2017-06-04T20:46:15  *** ChillazZ has quit IRC
298 2017-06-04T20:47:26  *** da2ce7 has joined #bitcoin-core-dev
299 2017-06-04T20:47:26  *** wallet42 has joined #bitcoin-core-dev
300 2017-06-04T20:47:26  *** mappum has joined #bitcoin-core-dev
301 2017-06-04T20:47:43  *** da2ce7 has quit IRC
302 2017-06-04T20:48:12  *** profall has joined #bitcoin-core-dev
303 2017-06-04T20:48:27  *** nsh- has joined #bitcoin-core-dev
304 2017-06-04T20:49:36  *** michagogo has joined #bitcoin-core-dev
305 2017-06-04T20:49:55  *** herzmeister[m] has quit IRC
306 2017-06-04T20:50:42  *** frabrunelle has quit IRC
307 2017-06-04T20:51:02  *** kewde[m] has quit IRC
308 2017-06-04T20:52:23  *** ChillazZ has joined #bitcoin-core-dev
309 2017-06-04T21:03:24  *** herzmeister[m] has joined #bitcoin-core-dev
310 2017-06-04T21:07:48  *** kewde[m] has joined #bitcoin-core-dev
311 2017-06-04T21:07:48  *** frabrunelle has joined #bitcoin-core-dev
312 2017-06-04T21:39:27  *** tiagotrs has joined #bitcoin-core-dev
313 2017-06-04T21:46:56  *** chjj has quit IRC
314 2017-06-04T22:03:23  *** Guest52697 has quit IRC
315 2017-06-04T22:05:17  <aj> luke-jr: wow, your bip148 branch got complicated
316 2017-06-04T22:05:22  *** chjj has joined #bitcoin-core-dev
317 2017-06-04T22:12:54  *** spudowiar has quit IRC
318 2017-06-04T22:17:25  <luke-jr> aj: it now has bugfixes applicable to softforks in general, not specific to BIP148
319 2017-06-04T22:17:28  <luke-jr> (and not required for BIP148)
320 2017-06-04T22:18:26  <aj> luke-jr: yep, i found #10512. sounds like an improvement
321 2017-06-04T22:18:27  <gribble> https://github.com/bitcoin/bitcoin/issues/10512 | Rework same-chain from abusing DoS banning, to explicit checks by luke-jr · Pull Request #10512 · bitcoin/bitcoin · GitHub
322 2017-06-04T22:25:45  *** Dyaheon has quit IRC
323 2017-06-04T22:27:53  *** Dyaheon has joined #bitcoin-core-dev
324 2017-06-04T22:29:32  *** beatrootfarmer has joined #bitcoin-core-dev
325 2017-06-04T22:32:50  *** goatturneer has quit IRC
326 2017-06-04T22:35:07  *** PaulCapestany has joined #bitcoin-core-dev
327 2017-06-04T22:39:55  *** chjj_ has joined #bitcoin-core-dev
328 2017-06-04T22:40:06  *** PaulCape_ has joined #bitcoin-core-dev
329 2017-06-04T22:40:34  *** chjj has quit IRC
330 2017-06-04T22:40:46  *** chjj_ is now known as chjj
331 2017-06-04T22:41:23  *** PaulCapestany has quit IRC
332 2017-06-04T22:41:46  *** btcdrak has quit IRC
333 2017-06-04T22:43:54  *** tiagotrs has quit IRC
334 2017-06-04T22:47:00  *** str4d has joined #bitcoin-core-dev
335 2017-06-04T22:50:58  *** Chris_Stewart_5 has quit IRC
336 2017-06-04T22:56:31  *** PaulCape_ has quit IRC
337 2017-06-04T22:56:38  *** PaulCapestany has joined #bitcoin-core-dev
338 2017-06-04T23:02:41  *** PaulCapestany has quit IRC
339 2017-06-04T23:03:17  *** PaulCape_ has joined #bitcoin-core-dev
340 2017-06-04T23:11:42  *** laurentmt has joined #bitcoin-core-dev
341 2017-06-04T23:13:16  *** laurentmt has quit IRC
342 2017-06-04T23:13:41  *** goatturneer has joined #bitcoin-core-dev
343 2017-06-04T23:15:33  *** PaulCapestany has joined #bitcoin-core-dev
344 2017-06-04T23:16:19  *** PaulCape_ has quit IRC
345 2017-06-04T23:18:03  *** beatrootfarmer has quit IRC
346 2017-06-04T23:29:57  *** Guest34260 has quit IRC
347 2017-06-04T23:38:08  *** Guest34260 has joined #bitcoin-core-dev
348 2017-06-04T23:48:06  *** chjj has quit IRC
349 2017-06-04T23:52:59  *** jtimon has quit IRC