12017-06-05T00:00:18  *** lightningbot has joined #bitcoin-core-dev
  22017-06-05T00:00:31  *** davec_ has joined #bitcoin-core-dev
  32017-06-05T00:00:47  *** d_t has joined #bitcoin-core-dev
  42017-06-05T00:01:38  *** thermoman_ has joined #bitcoin-core-dev
  52017-06-05T00:01:49  *** thermoman has quit IRC
  62017-06-05T00:01:52  *** chjj has joined #bitcoin-core-dev
  72017-06-05T00:06:19  *** davec has quit IRC
  82017-06-05T00:31:46  *** Dyaheon has quit IRC
  92017-06-05T00:32:33  *** Dyaheon has joined #bitcoin-core-dev
 102017-06-05T00:47:12  *** btcdrak has joined #bitcoin-core-dev
 112017-06-05T00:49:00  *** Ylbam has quit IRC
 122017-06-05T01:14:52  *** cryptapus has joined #bitcoin-core-dev
 132017-06-05T01:14:58  *** cryptapus is now known as cryptapus_afk
 142017-06-05T01:18:02  *** beatrootfarmer has joined #bitcoin-core-dev
 152017-06-05T01:22:11  *** goatturneer has quit IRC
 162017-06-05T01:23:46  <NicolasDorier> spudowiar: Awesome. I think you should share that as well with Ledger (btchip), they would probably review and make a plugin. Also it might move forward the conversation about HW standard
 172017-06-05T01:36:56  <bitcoin-git> [bitcoin] fanquake closed pull request #10513: Trivial: grammar fix to CONTRIBUTING.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10513
 182017-06-05T02:00:08  *** dermoth has quit IRC
 192017-06-05T02:01:00  *** dermoth has joined #bitcoin-core-dev
 202017-06-05T02:18:54  *** Aaronvan_ has quit IRC
 212017-06-05T02:19:28  *** AaronvanW has joined #bitcoin-core-dev
 222017-06-05T02:24:15  *** AaronvanW has quit IRC
 232017-06-05T02:25:38  *** RubenSomsen has joined #bitcoin-core-dev
 242017-06-05T02:26:35  *** RubenSomsen has quit IRC
 252017-06-05T02:26:54  *** RubenSomsen has joined #bitcoin-core-dev
 262017-06-05T02:36:25  *** Dyaheon has quit IRC
 272017-06-05T02:37:09  *** Dyaheon has joined #bitcoin-core-dev
 282017-06-05T02:39:57  *** cryptapus_afk has quit IRC
 292017-06-05T02:44:06  *** nemgun has quit IRC
 302017-06-05T03:09:50  *** goatturneer has joined #bitcoin-core-dev
 312017-06-05T03:14:17  *** beatrootfarmer has quit IRC
 322017-06-05T03:19:00  *** elkalamar has quit IRC
 332017-06-05T03:22:57  *** beatrootfarmer has joined #bitcoin-core-dev
 342017-06-05T03:24:24  *** goatturner has joined #bitcoin-core-dev
 352017-06-05T03:26:59  *** goatturneer has quit IRC
 362017-06-05T03:28:13  *** beatrootfarmer has quit IRC
 372017-06-05T04:05:02  *** d9b4bef9 has quit IRC
 382017-06-05T04:06:08  *** d9b4bef9 has joined #bitcoin-core-dev
 392017-06-05T04:07:05  *** goatturneer has joined #bitcoin-core-dev
 402017-06-05T04:10:51  *** goatturner has quit IRC
 412017-06-05T04:43:31  *** Guest34260 has quit IRC
 422017-06-05T05:07:28  *** RubenSomsen has quit IRC
 432017-06-05T05:13:56  *** beatrootfarmer has joined #bitcoin-core-dev
 442017-06-05T05:17:35  *** goatturneer has quit IRC
 452017-06-05T05:20:50  *** AaronvanW has joined #bitcoin-core-dev
 462017-06-05T05:25:10  *** AaronvanW has quit IRC
 472017-06-05T05:29:11  *** goatturneer has joined #bitcoin-core-dev
 482017-06-05T05:33:27  *** beatrootfarmer has quit IRC
 492017-06-05T06:16:42  *** spudowiar has joined #bitcoin-core-dev
 502017-06-05T06:17:44  <spudowiar> NicolasDorier: Will do. I think I'll make a new RPC method (signhwwtransaction) first (because this isn't entirely compatible with signrawtransaction) and then ask him to review it
 512017-06-05T06:21:35  *** spudowiar has quit IRC
 522017-06-05T06:44:53  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/21e1ed48989e1d150e9f85770fd098534e0f81f1
 532017-06-05T06:44:53  <bitcoin-git> bitcoin/0.14 21e1ed4 Wladimir J. van der Laan: doc: Preliminary release notes 0.14.2
 542017-06-05T06:50:10  *** lightningbot has joined #bitcoin-core-dev
 552017-06-05T06:50:26  *** d_t has joined #bitcoin-core-dev
 562017-06-05T06:50:27  *** wallet42 has joined #bitcoin-core-dev
 572017-06-05T06:50:46  *** mappum has joined #bitcoin-core-dev
 582017-06-05T06:58:34  <NicolasDorier> spudowiar: what? signrawtransaction should just work. I mean the wallet already have all the info needed for a hardware wallet to sign
 592017-06-05T06:58:49  <NicolasDorier> so why a new rpc method needed ? oO
 602017-06-05T06:59:44  <NicolasDorier> the cool thing if we can reuse signrawtransaction is that moving from software hotwallet to hardware wallet is a configuration change, not a code change for users
 612017-06-05T07:05:44  <NicolasDorier> Confirmed devs right now are
 622017-06-05T07:21:30  *** AaronvanW has joined #bitcoin-core-dev
 632017-06-05T07:24:02  *** d9b4bef9 has quit IRC
 642017-06-05T07:25:08  *** d9b4bef9 has joined #bitcoin-core-dev
 652017-06-05T07:26:24  *** AaronvanW has quit IRC
 662017-06-05T07:32:04  *** Giszmo has joined #bitcoin-core-dev
 672017-06-05T07:48:09  *** altoz_ has joined #bitcoin-core-dev
 682017-06-05T07:50:17  *** altoz has quit IRC
 692017-06-05T07:54:56  *** paveljanik has joined #bitcoin-core-dev
 702017-06-05T07:54:56  *** paveljanik has joined #bitcoin-core-dev
 712017-06-05T08:10:05  *** ChillazZ has joined #bitcoin-core-dev
 722017-06-05T08:11:12  *** AaronvanW has joined #bitcoin-core-dev
 732017-06-05T08:12:40  *** Ylbam has joined #bitcoin-core-dev
 742017-06-05T08:26:23  *** jtimon has joined #bitcoin-core-dev
 752017-06-05T08:31:03  *** timothy has joined #bitcoin-core-dev
 762017-06-05T08:39:59  *** timothy has quit IRC
 772017-06-05T08:44:59  *** timothy has joined #bitcoin-core-dev
 782017-06-05T08:46:10  *** vicenteH has joined #bitcoin-core-dev
 792017-06-05T08:51:23  *** cryptapus has joined #bitcoin-core-dev
 802017-06-05T08:51:23  *** cryptapus has joined #bitcoin-core-dev
 812017-06-05T08:51:25  *** cryptapus is now known as cryptapus_afk
 822017-06-05T08:54:36  *** d_t has quit IRC
 832017-06-05T08:57:19  <bitcoin-git> [bitcoin] Flowdalic opened pull request #10529: Improve bitcoind systemd service file (master...systemd-service) https://github.com/bitcoin/bitcoin/pull/10529
 842017-06-05T09:00:45  *** Guest34260 has joined #bitcoin-core-dev
 852017-06-05T09:01:03  <_flow_> #10529 was me, in case you have any questions
 862017-06-05T09:01:04  <gribble> https://github.com/bitcoin/bitcoin/issues/10529 | Improve bitcoind systemd service file by Flowdalic · Pull Request #10529 · bitcoin/bitcoin · GitHub
 872017-06-05T09:24:12  *** Guest34260 has quit IRC
 882017-06-05T09:48:56  *** spudowiar has joined #bitcoin-core-dev
 892017-06-05T09:49:08  <spudowiar> NicolasDorier: I meant for the communication with the hardware wallet
 902017-06-05T09:49:14  <spudowiar> The hardware wallet plugins use JSON-RPC
 912017-06-05T09:49:21  <spudowiar> https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1526
 922017-06-05T09:49:46  <spudowiar> I called the method signrawtransaction, but it's not compatible (as it sends hdKeypaths instead of privkeys)
 932017-06-05T09:50:14  <spudowiar> Also, I want to add an identifier, so we can support multiple wallets attached to the computer
 942017-06-05T09:50:18  <spudowiar> e.g. a serial number
 952017-06-05T09:54:25  <bitcoin-git> [bitcoin] pavlosantoniou opened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS>. (master...master) https://github.com/bitcoin/bitcoin/pull/10530
 962017-06-05T09:54:47  <spudowiar> I'm also going to add a listhwwdevices which could be used on the first run to list all the devices so Bitcoin Core can ask the user to select one
 972017-06-05T09:54:57  <spudowiar> And a gethwwinfo to get the xpub for the selected device
 982017-06-05T09:55:29  <spudowiar> Then on first run, Bitcoin Core could allow you to select a vendor and then a device
 992017-06-05T09:55:33  <spudowiar> And store this in the wallet
1002017-06-05T10:07:31  *** john1 has joined #bitcoin-core-dev
1012017-06-05T10:16:45  *** Guyver2 has joined #bitcoin-core-dev
1022017-06-05T10:23:34  *** RubenSomsen has joined #bitcoin-core-dev
1032017-06-05T10:28:15  *** rafalcpp has joined #bitcoin-core-dev
1042017-06-05T10:33:33  *** riemann has joined #bitcoin-core-dev
1052017-06-05T10:42:52  *** spudowiar has quit IRC
1062017-06-05T10:51:05  *** goatturneer has joined #bitcoin-core-dev
1072017-06-05T10:54:53  *** beatrootfarmer has quit IRC
1082017-06-05T10:58:19  *** tiagotrs has joined #bitcoin-core-dev
1092017-06-05T11:02:04  *** beatrootfarmer has joined #bitcoin-core-dev
1102017-06-05T11:05:29  *** goatturneer has quit IRC
1112017-06-05T11:06:49  *** SopaXorzTaker has joined #bitcoin-core-dev
1122017-06-05T11:15:29  *** laurentmt has joined #bitcoin-core-dev
1132017-06-05T11:16:13  *** laurentmt has quit IRC
1142017-06-05T11:34:46  *** goatturneer has joined #bitcoin-core-dev
1152017-06-05T11:37:01  <NicolasDorier> spudowiar: for multiple wallet, you don't need serial number. There is the multi wallet PR which use RPC User/Password as a way to selection a wallet
1162017-06-05T11:37:27  <NicolasDorier> and the wallet already know the keypath given the address
1172017-06-05T11:37:36  <NicolasDorier> so you don't need to pass it to the RPC method
1182017-06-05T11:38:51  *** beatrootfarmer has quit IRC
1192017-06-05T11:42:46  *** timothy has quit IRC
1202017-06-05T11:46:54  *** timothy has joined #bitcoin-core-dev
1212017-06-05T11:50:11  *** timothy has quit IRC
1222017-06-05T11:50:32  *** goatturner has joined #bitcoin-core-dev
1232017-06-05T11:54:15  *** goatturneer has quit IRC
1242017-06-05T11:57:34  *** RubenSomsen has quit IRC
1252017-06-05T12:01:47  *** spudowiar has joined #bitcoin-core-dev
1262017-06-05T12:02:00  <spudowiar> NicolasDorier: How does the wallet plugin know which hardware device to connect to?
1272017-06-05T12:02:31  <spudowiar> NicolasDorier: You might be misunderstanding
1282017-06-05T12:02:32  <spudowiar> I'm not talking about the RPC interface Bitcoin Core normally uses
1292017-06-05T12:02:47  <spudowiar> I'm talking about JSON-RPC that is sent over stdin to the hardware wallet plugin
1302017-06-05T12:03:01  <NicolasDorier> oh
1312017-06-05T12:03:11  <NicolasDorier> yes I was misunderstanding
1322017-06-05T12:03:28  <spudowiar> Check out https://github.com/saleemrashid/bitcoin/blob/hardware-wallet/src/wallet/wallet.cpp#L1527
1332017-06-05T12:03:31  <NicolasDorier> so it will be possible to use BTC signrawtransaction as if it was keys in software ?
1342017-06-05T12:03:38  <spudowiar> Oh yeah
1352017-06-05T12:03:48  <spudowiar> The normal RPC interface won't change
1362017-06-05T12:03:56  <NicolasDorier> ha awesome
1372017-06-05T12:03:59  <spudowiar> Although I might make it compatible as a hardware wallet plugin
1382017-06-05T12:04:03  <NicolasDorier> that is what I meant
1392017-06-05T12:04:06  <spudowiar> So you could connect one instance to another :)
1402017-06-05T12:04:13  <spudowiar> And it thinks the other instance is a hardware wallet :)
1412017-06-05T12:05:36  <NicolasDorier> spudowiar: very cool. Would you mind once you tested a bit to ACK my PR about hdwatchonly ? This would make your PR a bit smaller if you plan to include what you are doing into core
1422017-06-05T12:06:26  <NicolasDorier> my PR is hanging around for a while, I am using it in production. But was lacking reviews
1432017-06-05T12:06:27  <spudowiar> If you check that branch, the first few commits are your PR
1442017-06-05T12:06:42  <spudowiar> I think I did ACK it, if not I'll do that when I can
1452017-06-05T12:07:31  <NicolasDorier> yes I saw. Just a way to make your PR smaller, so it will be easier to merge yours later
1462017-06-05T12:10:06  <spudowiar> The other PR we need is making signing asynchronous in Bitcoin Qt
1472017-06-05T12:10:35  <spudowiar> At the moment, while it is talking to the hardware wallet the GUI freezes
1482017-06-05T12:10:53  <spudowiar> Because the io_service is running on the UI thread
1492017-06-05T12:12:59  <NicolasDorier> rebasing my PR.
1502017-06-05T12:13:22  <spudowiar> Thanks, I'll ACK and rebase ASAP
1512017-06-05T12:13:34  <NicolasDorier> actually you already rebased right ?
1522017-06-05T12:13:45  <NicolasDorier> I can just take your branch up to my commits I think
1532017-06-05T12:14:50  <spudowiar> Yeah, sure but you might want to check (I had to make a few changes for merge conflicts)
1542017-06-05T12:15:10  <NicolasDorier> ok
1552017-06-05T12:15:34  <spudowiar> A three way diff should let you see what I had to change
1562017-06-05T12:27:40  <spudowiar> Do you think I should add a scan in the PATH for plugins? Or a scan in a folder?
1572017-06-05T12:27:48  <spudowiar> e.g. bitcoin-hww-*
1582017-06-05T12:28:12  <spudowiar> Then, on startup, the GUI wallet could display all the vendors
1592017-06-05T12:36:22  *** RubenSomsen has joined #bitcoin-core-dev
1602017-06-05T12:39:13  *** timothy has joined #bitcoin-core-dev
1612017-06-05T12:45:17  <bitcoin-git> [bitcoin] colgreen opened pull request #10531: Increased startup timeout. (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10531
1622017-06-05T13:01:57  *** spudowiar has quit IRC
1632017-06-05T13:07:05  <NicolasDorier> spudowiar: unsure, I like your current approach to just delegate to a child process specified by command line.
1642017-06-05T13:09:10  *** Dyaheon has quit IRC
1652017-06-05T13:10:51  *** Dyaheon has joined #bitcoin-core-dev
1662017-06-05T13:12:37  <wumpus> I also like the external process approach
1672017-06-05T13:13:26  <wumpus> loading plugins into bitcoind/-qt 's address space seem like the wrong way, for me, and is hard harmonize with the static linking we do for distributed executables
1682017-06-05T13:13:38  *** Taek42 is now known as Taek
1692017-06-05T13:14:38  *** AaronvanW has quit IRC
1702017-06-05T13:15:00  *** AaronvanW has joined #bitcoin-core-dev
1712017-06-05T13:15:26  *** Yogaqueef has joined #bitcoin-core-dev
1722017-06-05T13:18:05  *** goatturneer has joined #bitcoin-core-dev
1732017-06-05T13:21:23  *** bsm1175321 has joined #bitcoin-core-dev
1742017-06-05T13:21:59  *** goatturner has quit IRC
1752017-06-05T13:24:38  *** JackH has joined #bitcoin-core-dev
1762017-06-05T13:30:36  *** bsm1175321 has quit IRC
1772017-06-05T13:32:51  *** bsm1175321 has joined #bitcoin-core-dev
1782017-06-05T13:34:10  *** bsm1175321 has quit IRC
1792017-06-05T13:40:39  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/400fdd08cc95...296928eb38a4
1802017-06-05T13:40:40  <bitcoin-git> bitcoin/master a7e3c28 Wladimir J. van der Laan: rpc: Add listen address to incoming connections in `getpeerinfo`...
1812017-06-05T13:40:41  <bitcoin-git> bitcoin/master 3457331 Wladimir J. van der Laan: test: Add test for `getpeerinfo` `bindaddr` field
1822017-06-05T13:40:41  <bitcoin-git> bitcoin/master 296928e Wladimir J. van der Laan: Merge #10478: rpc: Add listen address to incoming connections in `getpeerinfo`...
1832017-06-05T13:41:19  <bitcoin-git> [bitcoin] laanwj closed pull request #10478: rpc: Add listen address to incoming connections in `getpeerinfo` (master...2017_05_peer_listenaddr) https://github.com/bitcoin/bitcoin/pull/10478
1842017-06-05T13:47:06  *** bsm1175321 has joined #bitcoin-core-dev
1852017-06-05T13:50:36  *** d_t has joined #bitcoin-core-dev
1862017-06-05T13:53:40  *** chjj has quit IRC
1872017-06-05T13:58:01  *** beatrootfarmer has joined #bitcoin-core-dev
1882017-06-05T14:01:32  *** goatturneer has quit IRC
1892017-06-05T14:07:39  *** chjj has joined #bitcoin-core-dev
1902017-06-05T14:10:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/296928eb38a4...e103b3ff1e4f
1912017-06-05T14:10:25  <bitcoin-git> bitcoin/master 9aa215b Pieter Wuille: Bugfixes: missing == 0 after randrange
1922017-06-05T14:10:26  <bitcoin-git> bitcoin/master e103b3f Wladimir J. van der Laan: Merge #10514: Bugfix: missing == 0 after randrange...
1932017-06-05T14:10:59  <bitcoin-git> [bitcoin] laanwj closed pull request #10514: Bugfix: missing == 0 after randrange (master...fixtests) https://github.com/bitcoin/bitcoin/pull/10514
1942017-06-05T14:15:54  *** Guyver2 has quit IRC
1952017-06-05T14:18:48  *** wangchun has quit IRC
1962017-06-05T14:20:33  *** yellowsphere_ has joined #bitcoin-core-dev
1972017-06-05T14:24:48  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e103b3ff1e4f...cec9e1ea6174
1982017-06-05T14:24:49  <bitcoin-git> bitcoin/master 8d4f401 Alex Morcos: Fix timestamp in fee estimate debug message
1992017-06-05T14:24:49  <bitcoin-git> bitcoin/master cec9e1e Wladimir J. van der Laan: Merge #10422: Fix timestamp in fee estimate debug message...
2002017-06-05T14:25:26  <bitcoin-git> [bitcoin] laanwj closed pull request #10422: Fix timestamp in fee estimate debug message (master...fixtimeunits) https://github.com/bitcoin/bitcoin/pull/10422
2012017-06-05T14:25:26  *** wangchun has joined #bitcoin-core-dev
2022017-06-05T14:28:03  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/cec9e1ea6174...c871f323b418
2032017-06-05T14:28:04  <bitcoin-git> bitcoin/master cc36b5e Jimmy Song: [test] Add test for getchaintxstats
2042017-06-05T14:28:05  <bitcoin-git> bitcoin/master c871f32 MarcoFalke: Merge #10515: [test] Add test for getchaintxstats...
2052017-06-05T14:28:39  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10515: [test] Add test for getchaintxstats (master...test_getchaintxstats) https://github.com/bitcoin/bitcoin/pull/10515
2062017-06-05T14:34:26  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2072017-06-05T14:38:28  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c871f323b418...0747d3349817
2082017-06-05T14:38:29  <bitcoin-git> bitcoin/master 88b8f0b Russell Yanofsky: Simplify feebumper minimum fee code slightly...
2092017-06-05T14:38:29  <bitcoin-git> bitcoin/master 0747d33 Wladimir J. van der Laan: Merge #10455: Simplify feebumper minimum fee code slightly...
2102017-06-05T14:39:09  <bitcoin-git> [bitcoin] laanwj closed pull request #10455: Simplify feebumper minimum fee code slightly (master...pr/bumpmin) https://github.com/bitcoin/bitcoin/pull/10455
2112017-06-05T14:40:45  *** talmai has joined #bitcoin-core-dev
2122017-06-05T14:41:24  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0747d3349817...08d0390a5fea
2132017-06-05T14:41:24  <bitcoin-git> bitcoin/master 4d2d604 Russell Yanofsky: Fix importmulti failure to return rescan errors...
2142017-06-05T14:41:25  <bitcoin-git> bitcoin/master 08d0390 Wladimir J. van der Laan: Merge #10403: Fix importmulti failure to return rescan errors...
2152017-06-05T14:41:56  <bitcoin-git> [bitcoin] laanwj closed pull request #10403: Fix importmulti failure to return rescan errors (master...pr/scansame) https://github.com/bitcoin/bitcoin/pull/10403
2162017-06-05T14:44:57  *** talmai has quit IRC
2172017-06-05T14:47:51  *** chjj has quit IRC
2182017-06-05T14:47:58  *** tiagotrs has quit IRC
2192017-06-05T14:55:07  *** JackH has quit IRC
2202017-06-05T15:00:17  *** riemann has quit IRC
2212017-06-05T15:00:21  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/08d0390a5fea...e654d61d94ee
2222017-06-05T15:00:22  <bitcoin-git> bitcoin/master cf390df Cory Fields: build: silence gcc7's implicit fallthrough warning...
2232017-06-05T15:00:22  <bitcoin-git> bitcoin/master e654d61 Wladimir J. van der Laan: Merge #10489: build: silence gcc7's implicit fallthrough warning...
2242017-06-05T15:00:56  <bitcoin-git> [bitcoin] laanwj closed pull request #10489: build: silence gcc7's implicit fallthrough warning (master...wimplicit-fallthrough) https://github.com/bitcoin/bitcoin/pull/10489
2252017-06-05T15:02:30  *** RubenSomsen has quit IRC
2262017-06-05T15:12:29  *** RubenSomsen has joined #bitcoin-core-dev
2272017-06-05T15:15:05  *** arubi has quit IRC
2282017-06-05T15:15:33  *** str4d has quit IRC
2292017-06-05T15:15:39  *** arubi has joined #bitcoin-core-dev
2302017-06-05T15:18:24  *** goatturneer has joined #bitcoin-core-dev
2312017-06-05T15:19:59  *** bsm1175321 has quit IRC
2322017-06-05T15:20:16  *** ivo___ has joined #bitcoin-core-dev
2332017-06-05T15:21:44  <ivo___> \disconnect
2342017-06-05T15:21:57  *** ivo___ has quit IRC
2352017-06-05T15:22:23  *** beatrootfarmer has quit IRC
2362017-06-05T15:22:30  *** bsm1175321 has joined #bitcoin-core-dev
2372017-06-05T15:34:41  *** emzy has quit IRC
2382017-06-05T15:35:56  *** emzy has joined #bitcoin-core-dev
2392017-06-05T15:49:45  *** abpa has joined #bitcoin-core-dev
2402017-06-05T15:50:05  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e654d61d94ee...bea5b00cfe95
2412017-06-05T15:50:05  <bitcoin-git> bitcoin/master e4bc19f Russell Yanofsky: Remove xvfb configuration from travis...
2422017-06-05T15:50:06  <bitcoin-git> bitcoin/master bea5b00 MarcoFalke: Merge #10509: Remove xvfb configuration from travis...
2432017-06-05T15:50:40  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10509: Remove xvfb configuration from travis (master...pr/rmfb) https://github.com/bitcoin/bitcoin/pull/10509
2442017-06-05T15:59:38  <bitcoin-git> [bitcoin] laanwj closed pull request #9745: [RPC] Getting confirmations command (master...add-getconfirmations-to-rpc) https://github.com/bitcoin/bitcoin/pull/9745
2452017-06-05T16:01:53  *** emzy has quit IRC
2462017-06-05T16:01:54  *** emzy has joined #bitcoin-core-dev
2472017-06-05T16:06:11  *** laurentmt has joined #bitcoin-core-dev
2482017-06-05T16:06:55  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bea5b00cfe95...9fec4da0bec9
2492017-06-05T16:06:56  <bitcoin-git> bitcoin/master 9f82134 aideca: Add friendly output to dumpwallet refs #9564
2502017-06-05T16:06:56  <bitcoin-git> bitcoin/master 164019d aideca: Add dumpwallet output test
2512017-06-05T16:06:57  <bitcoin-git> bitcoin/master 9fec4da Wladimir J. van der Laan: Merge #9740: Add friendly output to dumpwallet...
2522017-06-05T16:07:15  <bitcoin-git> [bitcoin] laanwj closed pull request #9740: Add friendly output to dumpwallet (master...dumpwallet) https://github.com/bitcoin/bitcoin/pull/9740
2532017-06-05T16:08:21  *** beatrootfarmer has joined #bitcoin-core-dev
2542017-06-05T16:09:17  *** spudowiar has joined #bitcoin-core-dev
2552017-06-05T16:09:39  <spudowiar> NicolasDorier, wumpus: I didn't mean changing it from an external command
2562017-06-05T16:09:49  <spudowiar> Just a method of detecting the available external commands
2572017-06-05T16:10:09  <spudowiar> But I could add it to the wallet file or something
2582017-06-05T16:10:23  <spudowiar> And provide an option at startup of Bitcoin-Qt to enter the command
2592017-06-05T16:12:19  *** goatturneer has quit IRC
2602017-06-05T16:13:43  *** Dyaheon has quit IRC
2612017-06-05T16:15:35  *** Dyaheon has joined #bitcoin-core-dev
2622017-06-05T16:19:31  *** nsh- is now known as nsh
2632017-06-05T16:20:34  *** spudowiar has quit IRC
2642017-06-05T16:20:41  *** spudowiar has joined #bitcoin-core-dev
2652017-06-05T16:24:37  <bitcoin-git> [bitcoin] earonesty opened pull request #10532: -bip148 option (master...bip148) https://github.com/bitcoin/bitcoin/pull/10532
2662017-06-05T16:39:18  *** laurentmt has quit IRC
2672017-06-05T16:40:48  <btcdrak> wumpus: could you restart the two failing jobs here https://travis-ci.org/bitcoin/bitcoin/builds/238932256
2682017-06-05T16:52:48  *** john1 has quit IRC
2692017-06-05T16:56:59  *** laurentmt has joined #bitcoin-core-dev
2702017-06-05T16:58:46  <spudowiar> sipa__: Is there some good reading about the polymod function Bech32 uses?
2712017-06-05T17:01:38  *** timothy has quit IRC
2722017-06-05T17:10:35  <BlueMatt> ;;later tell sipa sipa__ is it just my C++11-lack-of-sanity, or am I suppose to find https://github.com/bitcoin/bitcoin/blob/master/src/coins.cpp#L99 gross as fuck? std::move(it->second.coin) then a few lines later it->second.coin.function_call()?
2732017-06-05T17:10:35  <gribble> The operation succeeded.
2742017-06-05T17:13:07  <cfields> BlueMatt: after a move, contents are usually undefined, but valid
2752017-06-05T17:13:17  <cfields> BlueMatt: a clear after a move makes them defined and valid :)
2762017-06-05T17:13:26  <BlueMatt> cfields: ugh, that just feels super gros
2772017-06-05T17:13:27  <BlueMatt> s
2782017-06-05T17:13:50  <BlueMatt> since that line depends on the exact behavior of CScript::Clear(), prevector, and CTxOut
2792017-06-05T17:15:01  <cfields> BlueMatt: the alternative would be defining an explicit move ctor which does the clear and leaves it in a valid state
2802017-06-05T17:15:12  <cfields> (or, i suppose, you'd rather just have it not used after the move)
2812017-06-05T17:15:35  <BlueMatt> yea, I mean I generally read std::move(X) as "X will not be touched again"
2822017-06-05T17:15:44  <BlueMatt> maybe thats just my naivete on C++11
2832017-06-05T17:15:53  <cfields> BlueMatt: well, that's not really feasible with a container :\
2842017-06-05T17:16:20  <cfields> std::move(foo[0]), foo still exists just fine.
2852017-06-05T17:16:45  <cfields> In many cases, this one included i think, it's the only way to avoid incurring the copy when moving the contents of a member
2862017-06-05T17:17:51  <BlueMatt> cfields: well obv destructor must run fine after std::move(), but to me I read that as, "I wont touch the 0th element of foo anymore after this, except to destruct"
2872017-06-05T17:18:24  <sipa__> BlueMatt: typically the definition os that you're allowed to do anything that foesn't depend on otd prior state
2882017-06-05T17:18:32  <sipa__> so you can assign, clear, ...
2892017-06-05T17:19:00  <sipa__> in a vector, a move-from + .clear() is well specified
2902017-06-05T17:19:19  <sipa__> doesn't
2912017-06-05T17:20:27  *** laurentmt has quit IRC
2922017-06-05T17:21:26  <MarcoFalke> btcdrak: done. Looks like they hit the 50 min timeout :(
2932017-06-05T17:25:02  <sipa__> BlueMatt: https://stackoverflow.com/a/7028318
2942017-06-05T17:25:13  *** sipa__ is now known as sipa
2952017-06-05T17:25:33  <BlueMatt> sipa__: yea, but coin.Clear() is super strange, it calls CScript::clear() which doesnot prevector::clear(), instead it prevector().swap(*this), essentially
2962017-06-05T17:25:35  <BlueMatt> which is...wat
2972017-06-05T17:25:54  <BlueMatt> sipa: can we make it it->second.coin = CCoin() instead?
2982017-06-05T17:26:06  <BlueMatt> should be +/- identical performance, but without feeling so yucky
2992017-06-05T17:26:36  *** sipa has quit IRC
3002017-06-05T17:26:36  *** sipa has joined #bitcoin-core-dev
3012017-06-05T17:27:12  <sipa> i don't see the difference
3022017-06-05T17:27:31  <sipa> both the Clear method and assignment operator can be user defined
3032017-06-05T17:28:01  <BlueMatt> sure, swap just feels worse to me...I'll shut up if no one else thinks it feels strange, though :)
3042017-06-05T17:29:44  <cfields> BlueMatt: the swap idiom comes from pre-c++11 when there was no shrink_to_fit().
3052017-06-05T17:30:15  <cfields> imo the clear shouldn't be forcing mem dealloc, it should just be clearing, and we should be using shrink_to_fit() more liberally at higher layers.
3062017-06-05T17:30:30  <sipa> right
3072017-06-05T17:30:43  <BlueMatt> yes, prevector clear() doesnt, script clear() does
3082017-06-05T17:31:10  <BlueMatt> could make script more vector-like by pushing it up to CCoin Clear()
3092017-06-05T17:31:16  <BlueMatt> or CTxOut
3102017-06-05T17:31:30  <sipa> script clear could be changed into prevector clear + shrink to fit
3112017-06-05T17:31:52  <sipa> though i think prevector clear automatocally shrinks
3122017-06-05T17:31:59  <BlueMatt> std::move() + clear() + shrink_to_fit()?
3132017-06-05T17:32:03  <BlueMatt> i do not believe so
3142017-06-05T17:32:23  <cfields> oh right. prevector essentially has no shrink_to_fit because it never over-allocs
3152017-06-05T17:32:44  <BlueMatt> ohoh, true
3162017-06-05T17:33:39  <BlueMatt> ehh, no, wait, i dont think so?
3172017-06-05T17:34:48  <BlueMatt> erase(it, it) doesnt do any shrinking, i believe
3182017-06-05T17:37:28  <sipa> when usimg direct allocation, the capacity is always equal to the object size
3192017-06-05T17:37:46  <sipa> when using indirect allocation, the capacity is variable
3202017-06-05T17:37:52  <BlueMatt> yes, but if its grown, clear() doesnt shrink_to_fit
3212017-06-05T17:38:22  <sipa> so resizing to something less than the inline capacity always has a deallocation as a result
3222017-06-05T17:38:26  <sipa> or at least should have
3232017-06-05T17:38:29  <MarcoFalke> cfields: I had the impression that the wallet-block_tip race is still a thing. Otherwise we could get rid of waitforblockheight as well
3242017-06-05T17:38:34  <sipa> as there is no way to represent the alternative
3252017-06-05T17:40:15  <cfields> MarcoFalke: yes, that's right. But we don't have any tests that rely on the other 2 things being atomic.
3262017-06-05T17:40:16  <sipa> i'm now questioning whether the prevector code is correct...
3272017-06-05T17:40:27  <cfields> sipa: i was just thinking the same. that seems leaky :\
3282017-06-05T17:41:26  <BlueMatt> sipa: yes, there is a bug on erase(begin(), end()), but not on clear()/resize(0)
3292017-06-05T17:42:03  *** laurentmt has joined #bitcoin-core-dev
3302017-06-05T17:42:16  <sipa> clear() just calls erase all the thing
3312017-06-05T17:42:27  <sipa> erase has no change capacity call at all
3322017-06-05T17:48:15  *** chjj has joined #bitcoin-core-dev
3332017-06-05T17:51:16  *** john1 has joined #bitcoin-core-dev
3342017-06-05T17:52:12  *** ula has joined #bitcoin-core-dev
3352017-06-05T17:52:25  *** chjj has quit IRC
3362017-06-05T17:52:46  *** chjj has joined #bitcoin-core-dev
3372017-06-05T17:56:05  *** QBcrusher has joined #bitcoin-core-dev
3382017-06-05T17:57:15  *** AaronvanW has quit IRC
3392017-06-05T17:57:49  *** yellowsphere_ has quit IRC
3402017-06-05T17:57:52  *** AaronvanW has joined #bitcoin-core-dev
3412017-06-05T17:58:27  *** QBcrusher_ has quit IRC
3422017-06-05T18:07:52  *** owowo has quit IRC
3432017-06-05T18:09:49  *** laurentmt has quit IRC
3442017-06-05T18:16:22  <jtimon> https://github.com/bitcoin/bitcoin/pull/10502 was created 4 days ago and laready needed rebase twice
3452017-06-05T18:16:28  <jtimon> already
3462017-06-05T18:17:10  <sipa> jtimon: thankfully, it's a scripted diff mostly, so should be easy
3472017-06-05T18:17:23  *** Dyaheon has quit IRC
3482017-06-05T18:17:24  <jtimon> it is disruptive (+296 −300 at this point), so it is likely to require more
3492017-06-05T18:17:45  <jtimon> sipa: yeah, I think we can get it reviewed fast too
3502017-06-05T18:20:47  *** Dyaheon has joined #bitcoin-core-dev
3512017-06-05T18:21:10  <jtimon> #10463 has some utACKs already and is easy to review as well
3522017-06-05T18:21:11  <gribble> https://github.com/bitcoin/bitcoin/issues/10463 | Names: BIP9 vs versionbits by jtimon · Pull Request #10463 · bitcoin/bitcoin · GitHub
3532017-06-05T18:22:32  <bitcoin-git> [bitcoin] achow101 opened pull request #10533: [tests] Use cookie auth instead of rpcuser and rpcpassword (master...tests-use-cookie-auth) https://github.com/bitcoin/bitcoin/pull/10533
3542017-06-05T18:22:48  *** john1 has quit IRC
3552017-06-05T18:24:34  *** JackH has joined #bitcoin-core-dev
3562017-06-05T18:34:09  *** chjj has quit IRC
3572017-06-05T18:38:02  *** Chris_Stewart_5 has quit IRC
3582017-06-05T18:40:15  *** harrymm has quit IRC
3592017-06-05T18:42:39  *** talmai has joined #bitcoin-core-dev
3602017-06-05T18:46:48  *** chjj has joined #bitcoin-core-dev
3612017-06-05T18:47:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3622017-06-05T18:49:11  *** john1 has joined #bitcoin-core-dev
3632017-06-05T18:56:05  *** harrymm has joined #bitcoin-core-dev
3642017-06-05T19:01:55  *** JackH has quit IRC
3652017-06-05T19:06:53  <BlueMatt> sipa: ah, indeed, no bug in prevector, I was misreading the meaning of _size
3662017-06-05T19:06:54  <jtimon> sipa: regarding https://github.com/bitcoin/bitcoin/pull/10502#issuecomment-306275178 perhaps you can help me find out what's wrong with https://github.com/bitcoin/bitcoin/pull/10193/commits/0f151d6a1b5b048ca78879e367f7a18f91126066#diff-c295474658e4ef7a9f5324199375edaf
3672017-06-05T19:07:33  <sipa> BlueMatt: oh, good
3682017-06-05T19:10:44  <jtimon> well, except for the reverse lop thing breaking the unittests...
3692017-06-05T19:11:01  <jtimon> loop
3702017-06-05T19:12:38  <sipa> ah i see
3712017-06-05T19:13:11  <jtimon> I haven't been able to understand what's going on there
3722017-06-05T19:13:11  <sipa> https://status.github.com/
3732017-06-05T19:13:51  <jtimon> oh, http://downforeveryoneorjustme.com/https://github.com/bitcoin/bitcoin/ said it was just me
3742017-06-05T19:14:46  <sipa> it's up again
3752017-06-05T19:15:02  <jtimon> nice, thanks
3762017-06-05T19:18:14  <bitcoin-git> [bitcoin] sipa opened pull request #10534: Clarify prevector::erase and avoid swap-to-clear (master...clarify_erase) https://github.com/bitcoin/bitcoin/pull/10534
3772017-06-05T19:19:55  *** chjj has quit IRC
3782017-06-05T19:23:10  *** RubenSomsen has quit IRC
3792017-06-05T19:25:18  *** JackH has joined #bitcoin-core-dev
3802017-06-05T19:28:29  <cfields> jtimon: i think your expression goes out of scope after the first iteration
3812017-06-05T19:31:11  <jtimon> cfields: mhmm, I don't follow
3822017-06-05T19:31:40  *** goatturneer has joined #bitcoin-core-dev
3832017-06-05T19:33:56  <cfields> jtimon: try: https://pastebin.com/raw/USdQhE36
3842017-06-05T19:34:12  *** chjj has joined #bitcoin-core-dev
3852017-06-05T19:35:26  *** beatrootfarmer has quit IRC
3862017-06-05T19:42:48  *** cryptapus_afk has quit IRC
3872017-06-05T19:45:23  <spudowiar> I added some stuff to the Intro Qt form for hardware wallet support... Qt Designer made me cry :(
3882017-06-05T19:46:39  <jtimon> cfields: awesome, I'll have a look, thanks
3892017-06-05T19:49:00  <BlueMatt> sipa: would you be upset if I PRd making AccessCoin return a CoinAccessor which just asserts if you modify the coinscache while holding a reference? I know its not illegal
3902017-06-05T19:49:15  <BlueMatt> cause map, but I'm afraid jeremy or I will at some point suggest using a different map
3912017-06-05T19:49:18  <BlueMatt> and then introduce a bug
3922017-06-05T19:49:29  <BlueMatt> should be +/- free performance wise
3932017-06-05T19:49:54  <sipa> BlueMatt: that seems more something for a sanity checker
3942017-06-05T19:50:06  <sipa> why specifically for CCoinsViewCache and not every other map?
3952017-06-05T19:50:56  <BlueMatt> sipa: cause I have a strong suspicion over the next release or two someone is gonna realize std::unordered_map is not the ideal map and decide to suggest a hand-written one
3962017-06-05T19:51:10  *** spudowiar has quit IRC
3972017-06-05T19:51:11  <sipa> yes, so?
3982017-06-05T19:51:29  <BlueMatt> and then suddenly using the std sanity-check mode wont help?
3992017-06-05T19:51:55  <sipa> yes, so?
4002017-06-05T19:52:04  <sipa> i mean things like valgrind exist to find bugs like that
4012017-06-05T19:52:39  <sipa> i plan to work on replacing the std::unordered_map myself there, btw
4022017-06-05T19:52:42  <BlueMatt> cause I'd be not at all surprised if it were very difficult to tickle that issue during valgrind
4032017-06-05T19:52:45  <jeremyrubin> Can also use a weak reference or something
4042017-06-05T19:52:45  <BlueMatt> lol, figured someone would
4052017-06-05T19:53:11  <sipa> i don't understand why you're specifically worried about this map
4062017-06-05T19:53:11  <BlueMatt> jeremyrubin: that may be incompatible with a smarter map, sadly :(
4072017-06-05T19:53:28  <jeremyrubin> Can just add an "updates" counter to the map
4082017-06-05T19:53:49  <jeremyrubin> and the weak ref is invalid if counter != weakref.counter
4092017-06-05T19:53:50  <sipa> it's a big and important one, but hardly the only complex data structure around
4102017-06-05T19:54:16  <gmaxwell> BlueMatt: please rebase #10192; review #10148
4112017-06-05T19:54:19  <BlueMatt> sipa: well we hold references into that map in rpc functions...I'm not aware of any other map where we do anything like that?
4122017-06-05T19:54:20  <gribble> https://github.com/bitcoin/bitcoin/issues/10192 | Cache full script execution results in addition to signatures by TheBlueMatt · Pull Request #10192 · bitcoin/bitcoin · GitHub
4132017-06-05T19:54:21  <gribble> https://github.com/bitcoin/bitcoin/issues/10148 | [WIP] Use non-atomic flushing with block replay by sipa · Pull Request #10148 · bitcoin/bitcoin · GitHub
4142017-06-05T19:54:31  <sipa> BlueMatt: example?
4152017-06-05T19:54:34  <BlueMatt> gmaxwell: yesyes, I'm working on a few small things i wanted in per-utxo first
4162017-06-05T19:54:34  <jeremyrubin> anyways, I'm generally sympathetic to Matt's request; long held iterators to maps -> bugs
4172017-06-05T19:54:46  <BlueMatt> well, luckily for now we have no "long held" ones
4182017-06-05T19:54:50  <BlueMatt> but we do have ones in RPC
4192017-06-05T19:54:52  <sipa> jtimon: not long held iterators; references to elements
4202017-06-05T19:54:58  <sipa> eh, jeremyrubin
4212017-06-05T19:55:04  <sipa> iterators are encapsulated
4222017-06-05T19:55:08  <BlueMatt> sipa: AccessCoin is called in rpc/rawtransaction
4232017-06-05T19:55:10  <BlueMatt> in several places
4242017-06-05T19:55:33  <sipa> in many places we also hold an iterator that comes out of mapBlockIndex.find
4252017-06-05T19:55:55  <BlueMatt> sipa: I'm sure this comes back to your "objects are transparent holders of data" vs my "objects should be opaque, where possible"
4262017-06-05T19:56:01  <gmaxwell> BlueMatt: k. other people's review is blocked on that rebase.
4272017-06-05T19:56:24  <BlueMatt> gmaxwell: hey, you're the one who got me to focus on fibre for two weeks :p
4282017-06-05T19:56:32  <BlueMatt> gmaxwell: but will try to circle around today
4292017-06-05T19:57:16  <BlueMatt> sipa: hmm, somehow i feel better about that cause its clear its a map, unlike CCoinsViewCache, where its an encapsulated datastructure that is actually private
4302017-06-05T19:57:46  <sipa> BlueMatt: it does return a reference, which is always a worry
4312017-06-05T19:57:57  <gmaxwell> BlueMatt: I know, I know.
4322017-06-05T19:58:08  <jeremyrubin> BlueMatt: at a higher level, I see what you're trying to do, trying to get me to write a better map and I'm maybe falling for it
4332017-06-05T19:58:23  <BlueMatt> jeremyrubin: sipa already said he was working on it :p
4342017-06-05T19:58:31  <sipa> if you're worried about particular call sites, you can always use Coin coin = view.Accessor(outpoint) ... instead of Coin& coin = ...
4352017-06-05T19:58:49  <BlueMatt> sipa: our disagreement is clearly a disagreement about encapsulation
4362017-06-05T19:59:13  <sipa> BlueMatt: i'm just so glad i got rid of that CCoinsModifier... and now you want to introduce it again :)
4372017-06-05T19:59:21  <sipa> the interface got so much easier
4382017-06-05T19:59:30  <BlueMatt> sipa: CCoinsViewModifier *did* things, there I agree that is gross
4392017-06-05T19:59:45  <BlueMatt> I'm proposing something who's only value is to assert with litte/no performance impact
4402017-06-05T20:00:02  <BlueMatt> so as to act as a sanity checker on callsites to a function I cant say I'm sold on
4412017-06-05T20:00:21  <gmaxwell> BlueMatt: what sanity check will it do?
4422017-06-05T20:00:44  <sipa> gmaxwell: check that no references are held while a modify happens
4432017-06-05T20:01:15  <BlueMatt> gmaxwell: technically assert something that is currently allowed, but something I assume will be come unallowed when sipa (or someone) writes a custom map for mapCoins
4442017-06-05T20:01:39  <gmaxwell> that doesn't sound free to verify.
4452017-06-05T20:02:03  <sipa> BlueMatt: also, i don't think it's technically illegal to hold a reference to a deleted object
4462017-06-05T20:02:05  <BlueMatt> hmm? just a boolean/int to set when you AccessCoins and assert() on in function calls
4472017-06-05T20:02:16  <sipa> only using it is
4482017-06-05T20:02:22  <jeremyrubin> what if you have a templated thing that doesn't check that property if the type of map used is the current one ;p
4492017-06-05T20:02:43  <BlueMatt> gmaxwell: compared to looking up in the map it is free :)
4502017-06-05T20:03:13  <gmaxwell> BlueMatt: not necessarily compared to an alternative data structure (also, I doubt it's free even compared to a map)
4512017-06-05T20:03:17  <BlueMatt> sipa: sure, but cutting hairs, I'm asking if you're ok adding a class which is more strict than it needs to be, cause its easy to write and, imo, a useful sanity check
4522017-06-05T20:03:18  <ryanofsky> sipa, not directly related but #9384 also adds back a version of the modifier
4532017-06-05T20:03:27  <gribble> https://github.com/bitcoin/bitcoin/issues/9384 | CCoinsViewCache code cleanup & deduplication by ryanofsky · Pull Request #9384 · bitcoin/bitcoin · GitHub
4542017-06-05T20:03:28  *** JackH has quit IRC
4552017-06-05T20:03:31  <BlueMatt> gmaxwell: assert(nAccessors == 0); ?
4562017-06-05T20:03:32  <sipa> ryanofsky: yes... but not an exposed one
4572017-06-05T20:03:53  <ryanofsky> yeah
4582017-06-05T20:03:58  <BlueMatt> gmaxwell: that sounds like something that the cpu will run without any attached preconditions and will easily run free since you're informing the branch predictor what is unlikely
4592017-06-05T20:04:19  <sipa> ryanofsky: i like that 9384 reduces logic duplication, i dislike that it does not actually reduce the amount of code :)
4602017-06-05T20:05:41  <ryanofsky> i think that could be because i wrote it in an intentionally verbose style with lots of comments and named variables
4612017-06-05T20:06:02  <sipa> ryanofsky: yeah, will review
4622017-06-05T20:06:07  <sipa> that was just a quick comment
4632017-06-05T20:07:01  <sipa> BlueMatt: so, an accessor object may have another advantage at some point... if we'd want to make CCoinsViewCache have split storage for txids and CCoins
4642017-06-05T20:07:04  <sipa> eh, Coins
4652017-06-05T20:07:26  <sipa> i don't know if that's a good idea or not, but it may reduce memory usage a fair bit (or not)
4662017-06-05T20:07:37  <BlueMatt> you mean to hold a ptr to uint256?
4672017-06-05T20:08:08  *** BashCo has quit IRC
4682017-06-05T20:08:10  <sipa> well the point is that encapsulating it may give freedom to change the representation more liberally
4692017-06-05T20:08:13  <BlueMatt> sipa: if you really dont want an accessor object, I'ma add a nice long comment to AccessCoin describing the preciditions...which I'm ok with, but not as much a fan
4702017-06-05T20:08:15  *** BashCo has joined #bitcoin-core-dev
4712017-06-05T20:08:15  <BlueMatt> hence the q
4722017-06-05T20:08:19  <BlueMatt> fair
4732017-06-05T20:08:37  <sipa> so how about we benchmark whether it has an effect?
4742017-06-05T20:08:46  <BlueMatt> do we have a decent way to benchmark?
4752017-06-05T20:08:59  <BlueMatt> i mean could reindex
4762017-06-05T20:09:07  <sipa> reindex chainstate on a -connect=0 node with fixed CPU clockrate
4772017-06-05T20:09:08  <BlueMatt> but that nearly definitely wont show it
4782017-06-05T20:09:11  <sipa> works very accurately
4792017-06-05T20:09:21  <BlueMatt> I so dont want to do that....I can haz ssh?
4802017-06-05T20:10:19  <sipa> i can set things up
4812017-06-05T20:22:20  *** harrymm has quit IRC
4822017-06-05T20:24:28  *** Dyaheon has quit IRC
4832017-06-05T20:24:56  *** Dyaheon has joined #bitcoin-core-dev
4842017-06-05T20:29:37  <BlueMatt> sipa: well, went and did it and no clear way to enforce semantics cause you can take reference and then drop the accessor too easily when writing cleints. it is nice cause it forces back to a ptr and restores a bunch of effectively-assert-cause-nullptrs that you removed in per-utxo
4852017-06-05T20:29:48  <BlueMatt> maybe I'll just re-add asserts and a long comment
4862017-06-05T20:30:40  <bitcoin-git> [bitcoin] practicalswift closed pull request #10527: Use parentheses to clarify intended precedence when using bitwise operations (master...clarify-precedence) https://github.com/bitcoin/bitcoin/pull/10527
4872017-06-05T20:35:52  <Chris_Stewart_5> FYI: You can install bitcoind as a dependency now on travis ci, previously it had been black listed.
4882017-06-05T20:36:16  *** harrymm has joined #bitcoin-core-dev
4892017-06-05T20:37:26  *** beatrootfarmer has joined #bitcoin-core-dev
4902017-06-05T20:40:53  *** goatturneer has quit IRC
4912017-06-05T20:41:15  *** goatturner has joined #bitcoin-core-dev
4922017-06-05T20:44:23  *** beatrootfarmer has quit IRC
4932017-06-05T20:44:43  *** laurentmt has joined #bitcoin-core-dev
4942017-06-05T20:45:19  *** abpa has quit IRC
4952017-06-05T20:47:05  <jtimon> cfields: thanks a lot! with your suggestion and another small change it seems the problem is gone
4962017-06-05T20:47:10  <jtimon> re #10193
4972017-06-05T20:47:11  <gribble> https://github.com/bitcoin/bitcoin/issues/10193 | scripted-diff: Remove #include foreach.hpp> by jtimon · Pull Request #10193 · bitcoin bitcoin · GitHub
4982017-06-05T20:47:15  <jtimon> will update
4992017-06-05T20:53:11  <jtimon> done
5002017-06-05T21:01:11  *** abpa has joined #bitcoin-core-dev
5012017-06-05T21:06:44  *** btcdrak has quit IRC
5022017-06-05T21:14:05  *** cryptapus_afk has joined #bitcoin-core-dev
5032017-06-05T21:29:05  *** chjj has quit IRC
5042017-06-05T21:39:30  *** Chris_Stewart_5 has quit IRC
5052017-06-05T21:43:12  *** chjj has joined #bitcoin-core-dev
5062017-06-05T21:48:08  <cfields> jtimon: great :)
5072017-06-05T21:49:21  <jtimon> :)
5082017-06-05T21:50:04  <cfields> jtimon: err, you need to use the reverser thing everywhere, not just in tests
5092017-06-05T21:50:29  <jtimon> maybe now it doesn't make sense for them to be separated, but maybe if I hadn't separated them I would still be stuck, so no regrets
5102017-06-05T21:50:46  <jtimon> oh, I see
5112017-06-05T21:52:20  <jtimon> I didn't run the python tests, but they should fail in that case, I'll wait for travis to fail
5122017-06-05T21:52:42  <jtimon> then edit the scripted-diff commit to do the same thing everywhere
5132017-06-05T21:53:11  <jtimon> although prevector tests will still need something different for the const reverse loop
5142017-06-05T21:53:17  <jtimon> or I think so
5152017-06-05T21:54:04  <jtimon> thanks for the heads up, I really thought it was just there because of how templates are used there
5162017-06-05T21:55:05  <cfields> np. no, it's because of how a range-based-for binds to the expression
5172017-06-05T21:55:06  <jtimon> then the new class sucks a little bit, perhaps I can do the same with auto and rbegin rend inlined
5182017-06-05T21:55:23  <cfields> though I can't say that I 100% understand the semantics
5192017-06-05T21:55:24  <jtimon> without needing a new class
5202017-06-05T21:55:47  <jtimon> alright, let's wait for travis
5212017-06-05T21:56:09  <jtimon> if it passes and you are still right maybe we can spot some missing tests
5222017-06-05T21:56:47  <jtimon> I can run the python tests locally too, I'll do that
5232017-06-05T22:05:01  <jtimon> jnewbery: what do you think about changing /tmp/bitcoin_test_runner_20170605_235927 to /tmp/bitcoin_test_runner/20170605_235927 ?
5242017-06-05T22:06:01  <jtimon> not a big deal, just slightly easier to remove the whole folder, kudos for the clearer prefix
5252017-06-05T22:06:11  <jnewbery> mildly against. Why add an extra directory layer? It just means I need to press the tab key one more time :)
5262017-06-05T22:06:33  <jnewbery> why easier to remove the whole folder?
5272017-06-05T22:06:39  <jtimon> fair enough, that was the question
5282017-06-05T22:07:18  <jtimon> it wasn't unlikely that it was only more convenient for me
5292017-06-05T22:07:37  <jtimon> the current prefix is good enough anyway
5302017-06-05T22:09:53  <jtimon> cfields: I don't know about travis, but this passes python3 ./test/functional/test_runner.py -j56 --extended -x pruning,smartfees,maxuploadtarget
5312017-06-05T22:10:07  <jnewbery> jtimon: cool. Thanks
5322017-06-05T22:10:54  <cfields> jtimon: I think you need a new set of tests for reverse_iterator. I don't trust it with the simple for construct :(
5332017-06-05T22:15:05  <jtimon> cfields: yep, more reason to simply rewrite the scripted-diff into something that uses rbegin/rend direclty instead of adding the new template
5342017-06-05T22:15:20  <cfields> agreed
5352017-06-05T22:15:45  <jtimon> but, still, if this shouldn't pass tests and it passes, perhaps we should open an issue asking for more tests
5362017-06-05T22:17:01  <cfields> agree with that too :)
5372017-06-05T22:17:44  <jtimon> I will try the version without the new class either way, it'll probably look smaller, just a more complex script to read if you use scripted-diff for review
5382017-06-05T22:18:20  <jtimon> but the diff should look very simple as well
5392017-06-05T22:19:25  <jtimon> cool
5402017-06-05T22:24:37  *** trippysalmon has quit IRC
5412017-06-05T22:26:49  *** Dyaheon has quit IRC
5422017-06-05T22:29:35  *** Dyaheon has joined #bitcoin-core-dev
5432017-06-05T22:32:53  *** trippysalmon has joined #bitcoin-core-dev
5442017-06-05T22:52:26  *** talmai has quit IRC
5452017-06-05T23:18:44  *** jnewbery has quit IRC
5462017-06-05T23:20:03  *** goatturneer has joined #bitcoin-core-dev
5472017-06-05T23:21:34  *** jnewbery_ has quit IRC
5482017-06-05T23:23:38  *** goatturner has quit IRC
5492017-06-05T23:26:05  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #10535: [qa] fundrawtx: Fix shutdown race (master...Mf1706-qaFundrawRace) https://github.com/bitcoin/bitcoin/pull/10535
5502017-06-05T23:29:44  <midnightmagic> wait was there an rc that I missed a gitian for..?
5512017-06-05T23:29:53  <BlueMatt> 14.2? maybe?
5522017-06-05T23:30:09  <midnightmagic> argh
5532017-06-05T23:32:37  <achow101> midnightmagic: might as well not build it now since an rc2 is guaranteed and the rc1 codesigned bins won't be made
5542017-06-05T23:32:56  <achow101> the version number wasn't bumped
5552017-06-05T23:34:34  *** beatrootfarmer has joined #bitcoin-core-dev
5562017-06-05T23:34:44  *** talmai has joined #bitcoin-core-dev
5572017-06-05T23:35:10  <midnightmagic> achow101: I have the time, and I am one of those completionists you see sometimes who opens every crate in the game just because there might be a coupla gold in there..
5582017-06-05T23:35:46  <luke-jr> but there is no chance of gold in this case? :p
5592017-06-05T23:36:01  <midnightmagic> The gold is figurative!
5602017-06-05T23:38:05  *** goatturneer has quit IRC
5612017-06-05T23:46:38  <luke-jr> midnightmagic: what does it represent in this case?
5622017-06-05T23:56:26  <bitcoin-git> [bitcoin] practicalswift opened pull request #10536: Remove unreachable or otherwise redundant code (master...unreachable) https://github.com/bitcoin/bitcoin/pull/10536
5632017-06-05T23:56:40  <midnightmagic> luke-jr: The reward of having opened every case. :) Also, I can say to people that I've built almost every gitian and therefore personally verified that almost every build is represented by source code as it is in the repo.