1 2017-06-07T00:00:46  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/75e898c094ee...be3e042c20e2
  2 2017-06-07T00:00:46  <bitcoin-git> bitcoin/master 656dbd8 practicalswift: Perform member initialization in initialization lists where possible
  3 2017-06-07T00:00:47  <bitcoin-git> bitcoin/master be3e042 Pieter Wuille: Merge #10523: Perform member initialization in initialization lists where possible...
  4 2017-06-07T00:00:53  *** jheathco has left #bitcoin-core-dev
  5 2017-06-07T00:01:22  <bitcoin-git> [bitcoin] sipa closed pull request #10523: Perform member initialization in initialization lists where possible (master...initialization-list) https://github.com/bitcoin/bitcoin/pull/10523
  6 2017-06-07T00:24:52  *** Chris_Stewart_5 has joined #bitcoin-core-dev
  7 2017-06-07T00:33:00  *** AaronvanW has quit IRC
  8 2017-06-07T00:41:00  *** talmai has joined #bitcoin-core-dev
  9 2017-06-07T00:41:33  *** Ylbam has quit IRC
 10 2017-06-07T00:44:02  *** btcdrak has joined #bitcoin-core-dev
 11 2017-06-07T00:49:27  *** jtimon has quit IRC
 12 2017-06-07T01:13:09  *** echonaut has quit IRC
 13 2017-06-07T01:13:13  *** echonaut1 has joined #bitcoin-core-dev
 14 2017-06-07T01:14:16  *** beatrootfarmer has joined #bitcoin-core-dev
 15 2017-06-07T01:17:23  *** goatturneer has quit IRC
 16 2017-06-07T01:26:20  *** jl2012 has joined #bitcoin-core-dev
 17 2017-06-07T01:26:59  *** d_t has joined #bitcoin-core-dev
 18 2017-06-07T01:30:03  *** dermoth has quit IRC
 19 2017-06-07T01:30:59  *** dermoth has joined #bitcoin-core-dev
 20 2017-06-07T01:44:11  *** dabura667 has joined #bitcoin-core-dev
 21 2017-06-07T01:48:26  *** dabura667 has quit IRC
 22 2017-06-07T01:48:37  *** dabura667_ has joined #bitcoin-core-dev
 23 2017-06-07T01:59:43  *** Giszmo has quit IRC
 24 2017-06-07T02:11:43  *** goatturneer has joined #bitcoin-core-dev
 25 2017-06-07T02:15:16  *** beatrootfarmer has quit IRC
 26 2017-06-07T02:15:31  *** beatrootfarmer has joined #bitcoin-core-dev
 27 2017-06-07T02:19:07  *** goatturneer has quit IRC
 28 2017-06-07T02:33:10  *** goatturneer has joined #bitcoin-core-dev
 29 2017-06-07T02:35:23  *** goatturner has joined #bitcoin-core-dev
 30 2017-06-07T02:37:05  *** beatrootfarmer has quit IRC
 31 2017-06-07T02:38:29  *** goatturneer has quit IRC
 32 2017-06-07T02:40:41  <cfields> gitian builders: 0.14.2rc2 sigs are pushed
 33 2017-06-07T02:42:38  *** goatturneer has joined #bitcoin-core-dev
 34 2017-06-07T02:46:11  *** goatturner has quit IRC
 35 2017-06-07T02:46:17  *** Chris_Stewart_5 has quit IRC
 36 2017-06-07T02:48:45  *** goatturner has joined #bitcoin-core-dev
 37 2017-06-07T02:50:21  *** beatrootfarmer has joined #bitcoin-core-dev
 38 2017-06-07T02:52:15  *** goatturneer has quit IRC
 39 2017-06-07T02:54:14  *** goatturner has quit IRC
 40 2017-06-07T02:59:47  *** Dyaheon has quit IRC
 41 2017-06-07T03:02:16  *** Dyaheon has joined #bitcoin-core-dev
 42 2017-06-07T03:07:38  *** RubenSomsen has joined #bitcoin-core-dev
 43 2017-06-07T04:04:28  *** talmai has quit IRC
 44 2017-06-07T04:05:45  *** jamesob has joined #bitcoin-core-dev
 45 2017-06-07T04:21:08  *** goatturneer has joined #bitcoin-core-dev
 46 2017-06-07T04:24:32  *** beatrootfarmer has quit IRC
 47 2017-06-07T04:31:06  *** beatrootfarmer has joined #bitcoin-core-dev
 48 2017-06-07T04:34:55  *** goatturneer has quit IRC
 49 2017-06-07T04:41:00  *** goatturneer has joined #bitcoin-core-dev
 50 2017-06-07T04:44:29  *** beatrootfarmer has quit IRC
 51 2017-06-07T04:47:17  *** RubenSomsen has quit IRC
 52 2017-06-07T04:53:33  *** talmai has joined #bitcoin-core-dev
 53 2017-06-07T04:56:01  *** beatrootfarmer has joined #bitcoin-core-dev
 54 2017-06-07T04:59:30  *** goatturneer has quit IRC
 55 2017-06-07T05:02:57  *** wangchun has quit IRC
 56 2017-06-07T05:03:40  *** wangchun has joined #bitcoin-core-dev
 57 2017-06-07T05:16:01  *** d9b4bef9 has quit IRC
 58 2017-06-07T05:16:15  *** goatturneer has joined #bitcoin-core-dev
 59 2017-06-07T05:17:07  *** d9b4bef9 has joined #bitcoin-core-dev
 60 2017-06-07T05:17:35  *** goatturner has joined #bitcoin-core-dev
 61 2017-06-07T05:20:11  *** beatrootfarmer has quit IRC
 62 2017-06-07T05:20:22  *** beatrootfarmer has joined #bitcoin-core-dev
 63 2017-06-07T05:20:53  *** goatturneer has quit IRC
 64 2017-06-07T05:22:17  *** goatturner has quit IRC
 65 2017-06-07T05:54:49  *** jamesob has quit IRC
 66 2017-06-07T06:16:30  *** goatturneer has joined #bitcoin-core-dev
 67 2017-06-07T06:18:20  *** goatturner has joined #bitcoin-core-dev
 68 2017-06-07T06:20:23  *** beatrootfarmer has quit IRC
 69 2017-06-07T06:21:26  *** goatturneer has quit IRC
 70 2017-06-07T06:23:15  *** talmai has quit IRC
 71 2017-06-07T06:24:03  *** RubenSomsen has joined #bitcoin-core-dev
 72 2017-06-07T06:44:05  *** JackH has joined #bitcoin-core-dev
 73 2017-06-07T06:53:38  *** JackH has quit IRC
 74 2017-06-07T06:55:35  *** jamesob has joined #bitcoin-core-dev
 75 2017-06-07T06:56:37  *** SopaXorzTaker has joined #bitcoin-core-dev
 76 2017-06-07T06:57:28  *** BashCo has quit IRC
 77 2017-06-07T06:59:56  *** jamesob has quit IRC
 78 2017-06-07T07:02:42  *** AaronvanW has joined #bitcoin-core-dev
 79 2017-06-07T07:04:07  *** Aaronvan_ has joined #bitcoin-core-dev
 80 2017-06-07T07:07:38  *** AaronvanW has quit IRC
 81 2017-06-07T07:13:25  *** BashCo has joined #bitcoin-core-dev
 82 2017-06-07T07:26:10  *** JackH has joined #bitcoin-core-dev
 83 2017-06-07T07:57:03  *** jamesob has joined #bitcoin-core-dev
 84 2017-06-07T07:59:08  *** timothy has joined #bitcoin-core-dev
 85 2017-06-07T07:59:25  *** goatturneer has joined #bitcoin-core-dev
 86 2017-06-07T08:01:46  *** jamesob has quit IRC
 87 2017-06-07T08:02:56  *** goatturner has quit IRC
 88 2017-06-07T08:03:53  *** v3d has joined #bitcoin-core-dev
 89 2017-06-07T08:05:57  *** hephaestus has quit IRC
 90 2017-06-07T08:12:38  *** riemann has joined #bitcoin-core-dev
 91 2017-06-07T08:24:30  *** riemann has quit IRC
 92 2017-06-07T08:24:32  *** riemann_ has joined #bitcoin-core-dev
 93 2017-06-07T08:39:50  *** RubenSomsen has quit IRC
 94 2017-06-07T08:56:58  *** john1 has joined #bitcoin-core-dev
 95 2017-06-07T08:58:21  *** jannes has joined #bitcoin-core-dev
 96 2017-06-07T09:01:39  *** RubenSomsen has joined #bitcoin-core-dev
 97 2017-06-07T09:03:48  *** john1 has quit IRC
 98 2017-06-07T09:15:35  *** RubenSomsen has quit IRC
 99 2017-06-07T09:20:33  *** hephaestus has joined #bitcoin-core-dev
100 2017-06-07T09:23:05  *** v3d has quit IRC
101 2017-06-07T09:24:01  *** sjums has joined #bitcoin-core-dev
102 2017-06-07T09:29:27  *** jtimon has joined #bitcoin-core-dev
103 2017-06-07T09:45:37  <bitcoin-git> [bitcoin] practicalswift opened pull request #10546: Remove unused Boost includes (master...remove-unused-boost-includes) https://github.com/bitcoin/bitcoin/pull/10546
104 2017-06-07T09:51:07  *** tunafizz has quit IRC
105 2017-06-07T09:51:15  *** tunafizz has joined #bitcoin-core-dev
106 2017-06-07T09:58:42  *** jamesob has joined #bitcoin-core-dev
107 2017-06-07T10:03:08  *** jamesob has quit IRC
108 2017-06-07T10:22:23  *** chjj has quit IRC
109 2017-06-07T10:27:51  <wumpus> 0.14.2rc2 executables up https://bitcoin.org/bin/bitcoin-core-0.14.2/test.rc2/
110 2017-06-07T10:31:16  *** laurentmt has joined #bitcoin-core-dev
111 2017-06-07T10:32:11  *** gielbier has quit IRC
112 2017-06-07T10:35:30  *** chjj has joined #bitcoin-core-dev
113 2017-06-07T10:41:58  *** laurentmt has quit IRC
114 2017-06-07T10:47:42  <timothy> hi, do you think -bip148 option will be included in 0.14.2 final?
115 2017-06-07T10:52:30  <SopaXorzTaker> https://bitcointalk.org/index.php?topic=1955073.0
116 2017-06-07T10:52:36  <wumpus> timothy: no
117 2017-06-07T10:53:06  <timothy> wumpus: bad :P
118 2017-06-07T10:53:09  <wumpus> there's no agreement to add bip148 support to core at all, and adding a major feature like that between rcs doesn't happen
119 2017-06-07T10:53:18  <wumpus> yeah I know...
120 2017-06-07T10:54:41  *** beatrootfarmer has joined #bitcoin-core-dev
121 2017-06-07T10:54:49  <timothy> it's disabled by default and optional :P
122 2017-06-07T10:56:46  <wumpus> I'm sure there will be a bip148 variant of -final
123 2017-06-07T10:57:18  <wumpus> and you can always just cherry-pick the UASF commit on top while testing
124 2017-06-07T10:57:56  *** goatturneer has quit IRC
125 2017-06-07T10:58:08  <timothy> the UASF commits, since luke-jr is working on DoS stuff
126 2017-06-07T11:07:41  <bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.14: https://github.com/bitcoin/bitcoin/commit/7a643511b474d53f952d3cd403af51aabd104044
127 2017-06-07T11:07:41  <bitcoin-git> bitcoin/0.14 7a64351 Wladimir J. van der Laan: doc: Fill in details about miniupnp CVE-2017-8798
128 2017-06-07T11:08:04  <wumpus> anything else that needs special notice in the 0.14.2 changelog?
129 2017-06-07T11:13:17  <wumpus> ref: https://github.com/bitcoin/bitcoin/blob/0.14/doc/release-notes.md
130 2017-06-07T11:14:04  *** BashCo has quit IRC
131 2017-06-07T11:16:00  *** BashCo has joined #bitcoin-core-dev
132 2017-06-07T11:22:10  *** john has joined #bitcoin-core-dev
133 2017-06-07T11:22:34  *** john is now known as Guest83978
134 2017-06-07T11:28:03  *** goatturneer has joined #bitcoin-core-dev
135 2017-06-07T11:29:56  *** nemgun has joined #bitcoin-core-dev
136 2017-06-07T11:31:32  *** beatrootfarmer has quit IRC
137 2017-06-07T11:31:58  *** goatturner has joined #bitcoin-core-dev
138 2017-06-07T11:33:00  *** str4d has joined #bitcoin-core-dev
139 2017-06-07T11:34:30  *** goatturneer has quit IRC
140 2017-06-07T11:39:53  *** vicenteH has joined #bitcoin-core-dev
141 2017-06-07T11:50:05  *** str4d has quit IRC
142 2017-06-07T11:56:42  *** dabura667_ has quit IRC
143 2017-06-07T12:00:11  *** jamesob has joined #bitcoin-core-dev
144 2017-06-07T12:03:04  *** Ylbam has joined #bitcoin-core-dev
145 2017-06-07T12:04:26  *** jamesob has quit IRC
146 2017-06-07T12:17:33  *** dabura667_ has joined #bitcoin-core-dev
147 2017-06-07T12:18:48  *** Aaronvan_ is now known as AaronvanW
148 2017-06-07T12:19:02  <bitcoin-git> [bitcoin] practicalswift opened pull request #10547: Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents (master...remove-boost-random-dependency) https://github.com/bitcoin/bitcoin/pull/10547
149 2017-06-07T12:27:18  <gmaxwell> what why do we have any of that? grr scheduler.
150 2017-06-07T12:27:34  <wumpus> yea that should use our own fast random context
151 2017-06-07T12:30:43  <wumpus> though this allows for direct conversion of the code, I don't think there's much of a point as we use no fancy statistical distribution stuff at all
152 2017-06-07T12:32:27  *** JackH has quit IRC
153 2017-06-07T12:32:45  *** fanquake has joined #bitcoin-core-dev
154 2017-06-07T12:44:56  *** Chris_Stewart_5 has joined #bitcoin-core-dev
155 2017-06-07T13:10:49  <bitcoin-git> [bitcoin] practicalswift opened pull request #10548: Use std::unordered_{map,set} (C++11) instead of boost::unordered_{map,set} (master...unordered_map) https://github.com/bitcoin/bitcoin/pull/10548
156 2017-06-07T13:31:46  <bitcoin-git> [bitcoin] jnewbery closed pull request #10540: [WIP] Salvage wallet should not set the aggressive flag on Db::verify() (master...fixsalvage) https://github.com/bitcoin/bitcoin/pull/10540
157 2017-06-07T13:32:10  <bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/be3e042c20e2...46311e792f4e
158 2017-06-07T13:32:11  <bitcoin-git> bitcoin/master 578ec80 Luke Dashjr: RPC: rawtransaction: Add RBF support for createrawtransaction
159 2017-06-07T13:32:11  <bitcoin-git> bitcoin/master 891c5ee Luke Dashjr: Wallet: Refactor FundTransaction to accept parameters via CCoinControl
160 2017-06-07T13:32:12  <bitcoin-git> bitcoin/master 36bcab2 Luke Dashjr: RPC/Wallet: Add RBF support for fundrawtransaction
161 2017-06-07T13:32:31  <bitcoin-git> [bitcoin] laanwj closed pull request #9672: Opt-into-RBF for RPC & bitcoin-tx (master...rpc_rbf) https://github.com/bitcoin/bitcoin/pull/9672
162 2017-06-07T13:34:20  *** jnewbery has joined #bitcoin-core-dev
163 2017-06-07T13:53:43  *** btcdrak has quit IRC
164 2017-06-07T14:01:30  *** jamesob has joined #bitcoin-core-dev
165 2017-06-07T14:06:07  *** jamesob has quit IRC
166 2017-06-07T14:07:33  *** AaronvanW has quit IRC
167 2017-06-07T14:09:25  *** Guyver2 has joined #bitcoin-core-dev
168 2017-06-07T14:11:55  *** AaronvanW has joined #bitcoin-core-dev
169 2017-06-07T14:14:04  <wumpus> any opinion on reverting https://github.com/bitcoin/bitcoin/pull/9672 ? seems to have been a bit of a mistake
170 2017-06-07T14:15:24  *** fanquake has quit IRC
171 2017-06-07T14:19:51  *** Guest83978 has quit IRC
172 2017-06-07T14:24:29  <jnewbery> no need to revert. I was just voicing surprise that it got merged without response to review comments or test cases for the new functionality in bitcoin-tx
173 2017-06-07T14:26:14  <wumpus> yes I agree
174 2017-06-07T14:27:12  <wumpus> anyhow can be added later I guess, and your comments should still be addressed
175 2017-06-07T14:38:14  <wumpus> let's wait for luke-jr's response
176 2017-06-07T14:41:11  *** talmai has joined #bitcoin-core-dev
177 2017-06-07T14:45:44  *** talmai has quit IRC
178 2017-06-07T14:51:34  *** nemgun1 has joined #bitcoin-core-dev
179 2017-06-07T14:54:28  *** nemgun has quit IRC
180 2017-06-07T15:01:05  *** riemann_ has quit IRC
181 2017-06-07T15:01:28  *** gribble has quit IRC
182 2017-06-07T15:08:29  *** gribble has joined #bitcoin-core-dev
183 2017-06-07T15:11:05  <jonasschnelli> wumpus, jnewbery: Yes. I think 9672 is okay. No need to revert... if there is something, we can fix it up later. Some of the commits also have reviews/utACKs in other PRs.
184 2017-06-07T15:16:14  *** BashCo has quit IRC
185 2017-06-07T15:16:23  <wumpus> thanks for weighing in, maybe that's what confused me too
186 2017-06-07T15:18:00  *** Guest83978 has joined #bitcoin-core-dev
187 2017-06-07T15:33:37  *** RubenSomsen has joined #bitcoin-core-dev
188 2017-06-07T15:37:00  *** BashCo has joined #bitcoin-core-dev
189 2017-06-07T15:37:24  *** arowser has quit IRC
190 2017-06-07T15:40:19  *** Chris_Stewart_5 has quit IRC
191 2017-06-07T15:43:24  *** arowser has joined #bitcoin-core-dev
192 2017-06-07T15:44:30  <wumpus> checking for QT... no
193 2017-06-07T15:44:30  <wumpus> checking for QT... no
194 2017-06-07T15:44:37  <wumpus> strange, that appears double on freebsd at least
195 2017-06-07T15:47:32  *** abpa has joined #bitcoin-core-dev
196 2017-06-07T15:56:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
197 2017-06-07T16:00:19  *** btcdrak has joined #bitcoin-core-dev
198 2017-06-07T16:00:48  *** Dyaheon has quit IRC
199 2017-06-07T16:02:09  *** Dyaheon has joined #bitcoin-core-dev
200 2017-06-07T16:04:02  *** laurentmt has joined #bitcoin-core-dev
201 2017-06-07T16:05:32  *** ula has quit IRC
202 2017-06-07T16:07:08  *** laurentmt has quit IRC
203 2017-06-07T16:07:45  *** Giszmo has joined #bitcoin-core-dev
204 2017-06-07T16:15:41  *** Chris_Stewart_5 has quit IRC
205 2017-06-07T16:29:57  *** AaronvanW has quit IRC
206 2017-06-07T16:38:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
207 2017-06-07T16:44:29  <timothy> wumpus: me too (fedora 26)
208 2017-06-07T16:45:00  <wumpus> timothy: that's also a case in which QT is not detected?
209 2017-06-07T16:45:51  <timothy> qt4 and qt5
210 2017-06-07T16:45:56  <timothy>         PKG_CHECK_MODULES([QT], [$qt5_modules], [QT_INCLUDES="$QT_CFLAGS"; have_qt=yes],[have_qt=no])
211 2017-06-07T16:45:58  <timothy>         PKG_CHECK_MODULES([QT], [$qt4_modules], [QT_INCLUDES="$QT_CFLAGS"; have_qt=yes], [have_qt=no])
212 2017-06-07T16:47:25  <wumpus> oh, it makes sense then, if only the message was clear about that :)
213 2017-06-07T16:47:41  <timothy> yes, I'll propose a pull request to change QT with QT5 and QT4
214 2017-06-07T16:51:47  *** chjj has quit IRC
215 2017-06-07T16:54:48  <bitcoin-git> [bitcoin] drizzt opened pull request #10549: Avoid printing generic and duplicated "checking for QT" during ./configure (master...check_qt) https://github.com/bitcoin/bitcoin/pull/10549
216 2017-06-07T16:55:13  <timothy> wumpus: ^^
217 2017-06-07T16:55:59  <wumpus> timothy: thanks!
218 2017-06-07T16:56:29  <timothy> (un)likely I work often with autotools :P
219 2017-06-07T16:59:38  <morcos> sipa: i'm still reviewing #10195, but i think i have one issue.  if you agree, i can fix it after i finish review if you want, or you can.
220 2017-06-07T16:59:44  <gribble> https://github.com/bitcoin/bitcoin/issues/10195 | Switch chainstate db and cache to per-txout model by sipa · Pull Request #10195 · bitcoin/bitcoin · GitHub
221 2017-06-07T17:00:19  <morcos> in ATMP, it seems like it will be too slow to do HaveCoins for every outpoint of a new tx, in the common case, that's hitting disk for every outpoint of every new tx
222 2017-06-07T17:01:04  *** timothy has quit IRC
223 2017-06-07T17:01:31  <morcos> we can probably ditch that whole block of code altogether, and rely on AlreadyHave which is called just before ATMP in net_processing, or if we need to because of other places ATMP is called, we can duplicate the idea of just checking 1 or 2 outputs that AlreadyHave uses
224 2017-06-07T17:02:27  <sipa> or change it to HaveCoinInCache?
225 2017-06-07T17:02:43  <sipa> ah no, nvm
226 2017-06-07T17:05:33  *** chjj has joined #bitcoin-core-dev
227 2017-06-07T17:05:38  *** talmai has joined #bitcoin-core-dev
228 2017-06-07T17:17:23  *** PaulCapestany has quit IRC
229 2017-06-07T17:17:41  *** ula has joined #bitcoin-core-dev
230 2017-06-07T17:18:08  *** PaulCapestany has joined #bitcoin-core-dev
231 2017-06-07T17:20:59  <bitcoin-git> [bitcoin] pavlosantoniou closed pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
232 2017-06-07T17:23:47  <bitcoin-git> [bitcoin] pavlosantoniou reopened pull request #10530: Fix possibly unsafe accesses of array in class base_uint<BITS> (master...master) https://github.com/bitcoin/bitcoin/pull/10530
233 2017-06-07T17:26:43  *** SopaXorzTaker has quit IRC
234 2017-06-07T17:28:34  *** goatturneer has joined #bitcoin-core-dev
235 2017-06-07T17:31:50  *** goatturner has quit IRC
236 2017-06-07T17:33:05  *** vicenteH has quit IRC
237 2017-06-07T17:45:46  *** Chris_Stewart_5 has quit IRC
238 2017-06-07T17:58:55  *** talmai has quit IRC
239 2017-06-07T18:04:14  *** Dyaheon has quit IRC
240 2017-06-07T18:04:57  <luke-jr> wumpus: BIP148 is a softfork. We typically consider those bugfixes and only added on minor bumps..
241 2017-06-07T18:05:34  <luke-jr> [10:58:08] <timothy> the UASF commits, since luke-jr is working on DoS stuff <-- for now, it may be safer to omit some of the DoS stuff; that's additional on top of BIP148 (not necessary), and has less review so far
242 2017-06-07T18:05:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
243 2017-06-07T18:06:52  *** Dyaheon has joined #bitcoin-core-dev
244 2017-06-07T18:07:48  <luke-jr> wumpus: I don't see the point in reverting unless there's an actual problem.
245 2017-06-07T18:08:10  *** beatrootfarmer has joined #bitcoin-core-dev
246 2017-06-07T18:11:48  *** goatturneer has quit IRC
247 2017-06-07T18:15:56  <jtimon> if you are included in https://en.bitcoin.it/wiki/Segwit_support please check that your position is not misrepresented (mine was by mistake)
248 2017-06-07T18:18:36  <sipa> luke-jr: i don't "want" BIP148. I want segwit, as I think it's necessary for Bitcoin's future. BIP148 is a overly risky means of obtaining that. That does not mean I oppose it if there were tremendous support, but on itself I think it's a bad idea
249 2017-06-07T18:19:45  <sipa> i'm going to delete my line from that table - i don't think it can represent nuanced opinions
250 2017-06-07T18:20:24  <jcorgan> i think the "wanting" terminology is confusing
251 2017-06-07T18:20:36  <jcorgan> as is the "deficient"
252 2017-06-07T18:21:05  <jcorgan> sipa: "wanting" means you like it but think community support is lacking
253 2017-06-07T18:21:15  <sipa> i don't like it
254 2017-06-07T18:21:23  <jcorgan> that is not how I would take it at first read, and clearly not how you feel
255 2017-06-07T18:21:27  <sipa> i would be happy if it worked, but i don't believe it can
256 2017-06-07T18:22:15  <jcorgan> i suggest you keep yourself there but just keep the prefer 141 and the rest empty
257 2017-06-07T18:23:02  *** SopaXorzTaker has joined #bitcoin-core-dev
258 2017-06-07T18:23:48  <BlueMatt> luke-jr: "We typically consider [soft forks] bugfixes and only added on minor bumps.." <-- NO, WE DO NOT
259 2017-06-07T18:24:09  <luke-jr> BlueMatt: lolwut? even Segwit was added on a minor bump
260 2017-06-07T18:24:18  <BlueMatt> we consider them CONSENSUS CHANGES, and release them in minor version so as to avoid forcing anyone to upgrade to a soft fork for other major-version features they want
261 2017-06-07T18:24:37  <BlueMatt> just because it was a minor version number does not mean its a "minor bump"
262 2017-06-07T18:27:02  <BlueMatt> if anything, the fact that we release them in minor versions indicates how seriously we take them, not the inverse - they are the only thing in that release (+/-) and get an entire release cycle dedicated just to them
263 2017-06-07T18:28:37  <jtimon> who is proposing to change that (ie enabling activation of consensus changes only on minor versions)?
264 2017-06-07T18:29:06  <BlueMatt> jtimon: I dont think anyone, I just found luke's comments laughably insulting to the effort that goes into consensus changes
265 2017-06-07T18:29:21  <sipa> luke-jr: i think the point is that yes softforks can be merged in minor release, but no that does not mean that any softfork will be merged
266 2017-06-07T18:29:45  <wumpus> never between rcs though
267 2017-06-07T18:30:11  <BlueMatt> lol @ merge consensus changes between rcs
268 2017-06-07T18:30:14  <BlueMatt> actually lol
269 2017-06-07T18:30:16  <jtimon> oh, I see, luke wants bip148 for 14.2 ?
270 2017-06-07T18:30:51  <luke-jr> wumpus: point taken
271 2017-06-07T18:31:15  <luke-jr> jtimon: that would be ideal, but wumpus makes a good point that it's too late for 0.14.2
272 2017-06-07T18:32:41  <jtimon> yeah I assumed that was clear. I'm unconvinced a variation of bip149 cannot be merged before mov15 though, so maybe it could make it to 0.14.3
273 2017-06-07T18:34:10  <luke-jr> [18:29:06] <BlueMatt> jtimon: I dont think anyone, I just found luke's comments laughably insulting to the effort that goes into consensus changes <-- effort goes into traditional bugfixes as well. "bugfix" does not make any implication of effort.
274 2017-06-07T18:34:31  <jtimon> yeah I read that
275 2017-06-07T18:34:45  <jtimon> oh, sorry
276 2017-06-07T18:35:20  <BlueMatt> luke-jr: well then let me rephrase, consensus changes are *not* bugfixes....they could be if there was an actual bug, but so far we havent seen one (and, no, "segwit hasnt happened" is not a bug...)
277 2017-06-07T18:35:55  <BlueMatt> more recent consensus changes have been 6+ month review and tweak cycles, even for simple things
278 2017-06-07T18:36:17  <luke-jr> BlueMatt: being vulnerable to miners producing a long chain of invalid blocks, is the bug fixed by (any) softforks
279 2017-06-07T18:36:56  * BlueMatt proposes redlisting soft fork again, clearly its a bugfix so must be merged *now*
280 2017-06-07T18:36:57  <luke-jr> but call it what you like, it's beside the point
281 2017-06-07T18:37:15  <BlueMatt> no, you're missing the point, this is consensus, not a fucking joke
282 2017-06-07T18:37:24  <luke-jr> bugs aren't a joke
283 2017-06-07T18:38:17  <BlueMatt> you appear to be dead-set on taking it as one
284 2017-06-07T18:38:40  <sipa> luke-jr: i don't think you can consider not implementing an new and backward-compatible consensus change a bug
285 2017-06-07T18:38:56  <sipa> luke-jr: i wouldn't call 0.13.0 buggy when segwit actives; at best, it is outdated
286 2017-06-07T18:39:21  <sipa> the whole point of softforks is that nobody is required to adopt the rule
287 2017-06-07T18:39:45  <luke-jr> to retain full node security, you need to adopt the rule
288 2017-06-07T18:40:03  <BlueMatt> the idea that its a "bug" (or even an issue) for a user to *not* "upgrade" to enforce a soft fork is laughable...if that were the case, Bitcoin would pretty clearly have no long-term value
289 2017-06-07T18:40:08  <sipa> luke-jr: what? no
290 2017-06-07T18:40:14  <BlueMatt> "oops, miners are enforcing redlisting, you need to upgrade"
291 2017-06-07T18:40:51  <luke-jr> BlueMatt: false equivalency is not helping
292 2017-06-07T18:41:10  <sipa> how is that a false equivalency?
293 2017-06-07T18:41:16  <BlueMatt> luke-jr: I absolutely do not believe it is false equivalency, actually. We're talking about what precedent is being set for Bitcoin's future and how changes are made in Bitcoin
294 2017-06-07T18:41:43  <morcos> Can we talk about when we're upgrading to C++17 instead?
295 2017-06-07T18:41:48  <BlueMatt> ACK
296 2017-06-07T18:41:55  <BlueMatt> is filesystem in 17?
297 2017-06-07T18:41:58  <BlueMatt> or is that 15?
298 2017-06-07T18:42:06  <BlueMatt> 14
299 2017-06-07T18:42:10  * sipa wants std::this_thread::sleep(10ms);
300 2017-06-07T18:42:12  <luke-jr> hopefully compilers support it sooner than C++11
301 2017-06-07T18:42:19  <BlueMatt> sipa: wait, thats not 11?
302 2017-06-07T18:42:25  <sipa> BlueMatt: no, c++14
303 2017-06-07T18:42:25  *** SopaXorzTaker has quit IRC
304 2017-06-07T18:42:29  <BlueMatt> ohoh, the ms postfix, yea
305 2017-06-07T18:43:07  <sipa> still no concepts :(
306 2017-06-07T18:43:12  <sipa> not even in 17
307 2017-06-07T18:46:35  *** beatrootfarmer has quit IRC
308 2017-06-07T18:47:11  <wumpus> we supported c++11 in.. 2016, so extrapolating that, c++17 will be usable in 2022
309 2017-06-07T18:47:33  <luke-jr> :/
310 2017-06-07T18:47:51  <wumpus> don't shoot me, I'm just the messenger :)
311 2017-06-07T18:50:03  <sipa> c++11 took much longer to be actually available in compilers
312 2017-06-07T18:50:11  <sipa> c++14 is already default in gcc 6
313 2017-06-07T18:50:34  <sipa> the changes in 14 and 17 are also much smaller than the c++03-c++11 changes
314 2017-06-07T18:50:45  <wumpus> std::optional is pretty nice
315 2017-06-07T18:51:06  <luke-jr> how long until GCC 6 is on major distros?
316 2017-06-07T18:51:20  <luke-jr> Gentoo just got GCC 5 like a month ago
317 2017-06-07T18:51:38  <BlueMatt> debian? 2025?
318 2017-06-07T18:51:46  <jtimon> sure, ack on moving to c++14, what do we need to do?
319 2017-06-07T18:52:01  <sipa> i think GCC 5 fully supports c++14
320 2017-06-07T18:52:16  <BlueMatt> oh, thats a lie, wow, next debian is gcc 6
321 2017-06-07T18:52:39  <luke-jr> RHEL tends to be the slowest these days
322 2017-06-07T18:52:42  <sipa> and c++17... doesn't exist yet
323 2017-06-07T18:52:44  <luke-jr> from what I've seen
324 2017-06-07T18:52:59  <wumpus> std::string_view is very useful too
325 2017-06-07T18:53:00  <luke-jr> lo, was morcos just trolling
326 2017-06-07T18:54:07  <BlueMatt> morcos' xkcd 356 is good
327 2017-06-07T18:54:24  <wumpus> recent versions of clang already support a lot of c++17 features, even though it doesn't officially exist yet
328 2017-06-07T18:54:43  <sipa> Clang finished support for C++14 in 3.4 though under the standard name c++1y.[23] GCC finished support for C++14 in GCC 5, and made C++14 the default C++ standard in GCC 6.[24] Microsoft Visual Studio 2015 has support for some but not all C++14 features.[25]
329 2017-06-07T18:55:04  <jtimon> luke-jr: does it matter? the important part is that if we don't move to c++14 coon some people may start moving to ripple, they had c++14 almost from launch </bad joke>
330 2017-06-07T18:55:16  <sipa> hahaha
331 2017-06-07T18:55:51  <jtimon> s/coon/soon
332 2017-06-07T18:55:56  <wumpus> bitcoin core compiles almost entirely without changes in c++17 mode, btw
333 2017-06-07T18:56:14  <luke-jr> wumpus: that's a nice start at least
334 2017-06-07T18:56:16  <wumpus> there were some minor things last time I tried
335 2017-06-07T18:56:33  <jtimon> wumpus: awesome, what are the almost no changes?
336 2017-06-07T18:56:41  <wumpus> but those might be clang-weirdnesses as well
337 2017-06-07T18:57:03  <wumpus> should be in my cloudabi branch, let me see
338 2017-06-07T18:57:46  *** Giszmo has quit IRC
339 2017-06-07T18:58:08  <wumpus> jtimon: https://github.com/laanwj/bitcoin/commit/efeec33d19752de7480f1e8d0fbcd79e49548910
340 2017-06-07T18:58:13  *** Giszmo has joined #bitcoin-core-dev
341 2017-06-07T18:59:26  <BlueMatt> god I keep finding things and being like "wait, didnt I change that???" only to realize its in a queued-next PR based on one still pending :(
342 2017-06-07T18:59:39  * BlueMatt really wants to make all CBlockIndexes const :(
343 2017-06-07T19:00:14  <sipa> BlueMatt: what do you do with the mutable fields?
344 2017-06-07T19:00:25  <sipa> (nChainTx, nStatus, nFile, ...)
345 2017-06-07T19:00:27  <BlueMatt> sipa: ehh, sorry, const outside of validation.cpp
346 2017-06-07T19:00:37  <sipa> ah!
347 2017-06-07T19:00:38  <sipa> yes!
348 2017-06-07T19:00:44  <BlueMatt> ie exposed versions in headers are all const, and mapBlockIndex is const too
349 2017-06-07T19:01:03  <BlueMatt> sipa: its the next one queued after #10279
350 2017-06-07T19:01:07  <gribble> https://github.com/bitcoin/bitcoin/issues/10279 | Add a CChainState class to validation.cpp to take another step towards clarifying internal interfaces by TheBlueMatt · Pull Request #10279 · bitcoin/bitcoin · GitHub
351 2017-06-07T19:02:08  *** chjj has quit IRC
352 2017-06-07T19:03:43  *** beatrootfarmer has joined #bitcoin-core-dev
353 2017-06-07T19:15:30  *** chjj has joined #bitcoin-core-dev
354 2017-06-07T19:16:37  <achow101> wumpus: did you change your gitian key?
355 2017-06-07T19:16:49  <achow101> or sign with the wrong one?
356 2017-06-07T19:18:26  <wumpus> I've added a signing subkey
357 2017-06-07T19:18:33  <wumpus> it's the same I use for signing commits
358 2017-06-07T19:20:03  <jtimon> wumpus: yeah, that's a very small diff
359 2017-06-07T19:20:31  <achow101> wumpus: ah, ok. Apparently I don't have that key
360 2017-06-07T19:21:18  <jtimon> BlueMatt: been there
361 2017-06-07T19:24:10  <wumpus> achow101: --refresh-keys should get it AFAIK
362 2017-06-07T19:24:52  <BlueMatt> jtimon: ehh, its normal 'round here, review is hard
363 2017-06-07T19:25:26  <jtimon> yep, and time consuming
364 2017-06-07T19:25:38  <BlueMatt> with good reason
365 2017-06-07T19:25:49  <jtimon> not saying otherwise
366 2017-06-07T19:28:41  *** goatturneer has joined #bitcoin-core-dev
367 2017-06-07T19:32:05  *** beatrootfarmer has quit IRC
368 2017-06-07T19:36:00  <bitcoin-git> [bitcoin] achow101 opened pull request #10551: [Tests] Wallet encryption functional tests (master...wallet-encrypt-test) https://github.com/bitcoin/bitcoin/pull/10551
369 2017-06-07T19:40:42  <luke-jr> btcdrak: are you planning to do a 0.14 addrindex?
370 2017-06-07T19:43:36  *** parazyd has quit IRC
371 2017-06-07T19:44:25  <jtimon> yeah, I'm interested in knowing that too
372 2017-06-07T19:44:38  <sipa> :(
373 2017-06-07T19:44:57  <BlueMatt> :) ?
374 2017-06-07T19:45:07  <jtimon> for an explorer
375 2017-06-07T19:45:40  *** parazyd has joined #bitcoin-core-dev
376 2017-06-07T19:45:40  *** parazyd has joined #bitcoin-core-dev
377 2017-06-07T19:46:02  <sipa> i wish people wouldn't build solutions that require a fully indexed unpruned blockchain
378 2017-06-07T19:47:00  <jtimon> sipa: although honestly like it as I have it with only blockheight, blockhash and txid for searching
379 2017-06-07T19:47:24  <luke-jr> sipa: I agree, but a 0.14 addrindex will be less annoying than supporting 0.13 longer than necessary XD
380 2017-06-07T19:47:31  *** parazyd has joined #bitcoin-core-dev
381 2017-06-07T19:47:31  *** parazyd has joined #bitcoin-core-dev
382 2017-06-07T19:50:11  *** parazyd has quit IRC
383 2017-06-07T19:51:42  *** parazyd has joined #bitcoin-core-dev
384 2017-06-07T19:51:42  *** parazyd has joined #bitcoin-core-dev
385 2017-06-07T19:59:51  *** RubenSomsen has quit IRC
386 2017-06-07T20:02:14  <BlueMatt> sipa: is deserializing bandb/addrdb any more expensive than any other deserialization?
387 2017-06-07T20:02:20  <BlueMatt> its vector operations, mostly, just like the rest, no?
388 2017-06-07T20:02:34  <BlueMatt> re: 10248: so I dont see why it matters
389 2017-06-07T20:07:26  *** chjj has quit IRC
390 2017-06-07T20:10:31  <sipa> BlueMatt: code simplification
391 2017-06-07T20:10:47  <BlueMatt> hmm? no, i mean i like 10248
392 2017-06-07T20:11:02  <BlueMatt> and dont think the removal of the ability to skip deserialize on hash mismatch is worth worrying about
393 2017-06-07T20:12:57  <sipa> oh, i agree
394 2017-06-07T20:14:22  <wumpus> yes it doesn't really matter in this case, the hash is not a MAC and it's unlikely the bandb/addrdb will be used as an attack vector in any case
395 2017-06-07T20:14:29  <wumpus> so 10248 is fine
396 2017-06-07T20:14:42  <BlueMatt> if you can modify my bandb........
397 2017-06-07T20:14:52  <BlueMatt> something something wallet in same folder
398 2017-06-07T20:14:59  <wumpus> you can also change the hash, sure
399 2017-06-07T20:16:48  <wumpus> the checksum is there against accidental corruption, and checking the hash on the fly is just as good for that
400 2017-06-07T20:16:56  <sipa> i'd change your bitcoind :p
401 2017-06-07T20:18:15  <wumpus> and if there is any way for a corruption to *crash* the deserialization I guess there's worse problems
402 2017-06-07T20:21:03  *** chjj has joined #bitcoin-core-dev
403 2017-06-07T20:29:49  *** jannes has quit IRC
404 2017-06-07T20:31:35  *** QBcrusher has quit IRC
405 2017-06-07T20:37:33  *** vicenteH has joined #bitcoin-core-dev
406 2017-06-07T20:45:03  *** Guyver2 has quit IRC
407 2017-06-07T20:52:20  <ryanofsky> should it be necessary to lock mempool.cs before calling atmp? is this lock needed: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1546
408 2017-06-07T21:01:57  *** Guest83978 has quit IRC
409 2017-06-07T21:04:52  <bitcoin-git> [bitcoin] jtimon closed pull request #10427: Consensus: Introduce static GetScriptFlags (mostly MOVEONLY) (master...b15-consensus-script-flags-min) https://github.com/bitcoin/bitcoin/pull/10427
410 2017-06-07T21:05:57  *** Guest83978 has joined #bitcoin-core-dev
411 2017-06-07T21:15:29  *** [\\\] is now known as tripleslash
412 2017-06-07T21:15:35  *** ajd__ has quit IRC
413 2017-06-07T21:22:56  *** mkarrer_ has joined #bitcoin-core-dev
414 2017-06-07T21:24:23  *** aspect__ has joined #bitcoin-core-dev
415 2017-06-07T21:24:26  *** rubensayshi_ has joined #bitcoin-core-dev
416 2017-06-07T21:24:32  *** brg444_ has joined #bitcoin-core-dev
417 2017-06-07T21:24:53  *** Taek42 has joined #bitcoin-core-dev
418 2017-06-07T21:26:56  *** cfields_ has joined #bitcoin-core-dev
419 2017-06-07T21:27:18  *** nickler_ has joined #bitcoin-core-dev
420 2017-06-07T21:29:23  *** rubensayshi has quit IRC
421 2017-06-07T21:29:23  *** aspect_ has quit IRC
422 2017-06-07T21:29:24  *** brg444 has quit IRC
423 2017-06-07T21:29:24  *** nickler has quit IRC
424 2017-06-07T21:29:24  *** _flow_ has quit IRC
425 2017-06-07T21:29:24  *** mkarrer has quit IRC
426 2017-06-07T21:29:24  *** nsh has quit IRC
427 2017-06-07T21:29:24  *** gijensen has quit IRC
428 2017-06-07T21:29:24  *** Taek has quit IRC
429 2017-06-07T21:29:25  *** cfields has quit IRC
430 2017-06-07T21:29:26  *** rubensayshi_ is now known as rubensayshi
431 2017-06-07T21:29:27  *** aspect__ is now known as aspect_
432 2017-06-07T21:29:30  *** brg444_ is now known as brg444
433 2017-06-07T21:29:43  *** nsh has joined #bitcoin-core-dev
434 2017-06-07T21:30:10  *** gijensen has joined #bitcoin-core-dev
435 2017-06-07T21:31:59  *** _flow_ has joined #bitcoin-core-dev
436 2017-06-07T21:35:21  *** Guest47556 has joined #bitcoin-core-dev
437 2017-06-07T21:35:46  *** Guest83978 has quit IRC
438 2017-06-07T21:41:36  *** Guest47556 has quit IRC
439 2017-06-07T21:42:57  *** Chris_Stewart_5 has quit IRC
440 2017-06-07T21:47:58  *** Guest47556 has joined #bitcoin-core-dev
441 2017-06-07T21:59:43  <BlueMatt> ryanofsky: probably not?
442 2017-06-07T22:01:46  *** _flow_ has quit IRC
443 2017-06-07T22:04:00  <ryanofsky> ok, thx for sanity check
444 2017-06-07T22:04:30  *** nakaluna_ has joined #bitcoin-core-dev
445 2017-06-07T22:04:42  *** _flow_ has joined #bitcoin-core-dev
446 2017-06-07T22:11:46  *** Guest47556 has quit IRC
447 2017-06-07T22:12:44  <bitcoin-git> [bitcoin] sipa pushed 11 new commits to master: https://github.com/bitcoin/bitcoin/compare/46311e792f4e...e801084decf4
448 2017-06-07T22:12:45  <bitcoin-git> bitcoin/master 37e864e Pieter Wuille: Add FastRandomContext::rand256() and ::randbytes()...
449 2017-06-07T22:12:45  <bitcoin-git> bitcoin/master 90620d6 Pieter Wuille: scripted-diff: Rename cuckoo tests' local rand context...
450 2017-06-07T22:12:46  <bitcoin-git> bitcoin/master 124d13a Pieter Wuille: Merge test_random.h into test_bitcoin.h
451 2017-06-07T22:13:04  <bitcoin-git> [bitcoin] sipa closed pull request #10321: Use FastRandomContext for all tests (master...fast_rand_tests) https://github.com/bitcoin/bitcoin/pull/10321
452 2017-06-07T22:14:40  *** Cheeseo has joined #bitcoin-core-dev
453 2017-06-07T22:16:56  *** chjj has quit IRC
454 2017-06-07T22:19:16  *** Cheeseo has quit IRC
455 2017-06-07T22:20:58  *** nemgun1 has quit IRC
456 2017-06-07T22:25:13  *** nakaluna_ is now known as nakaluna
457 2017-06-07T22:25:31  *** _flow_ has quit IRC
458 2017-06-07T22:26:41  *** nakaluna has joined #bitcoin-core-dev
459 2017-06-07T22:31:09  *** chjj has joined #bitcoin-core-dev
460 2017-06-07T22:31:42  <jtimon> btw, I got #9717 out of #10339 as requested
461 2017-06-07T22:31:43  <gribble> https://github.com/bitcoin/bitcoin/issues/9717 | Pow: Remove fCheckPOW from CheckBlockHeader by jtimon · Pull Request #9717 · bitcoin/bitcoin · GitHub
462 2017-06-07T22:31:45  <gribble> https://github.com/bitcoin/bitcoin/issues/10339 | Optimization: Calculate block hash less times by jtimon · Pull Request #10339 · bitcoin/bitcoin · GitHub
463 2017-06-07T22:34:12  *** achow101 has left #bitcoin-core-dev
464 2017-06-07T22:34:22  *** achow101 has joined #bitcoin-core-dev
465 2017-06-07T22:40:57  *** Dyaheon has quit IRC
466 2017-06-07T22:42:34  *** Dyaheon has joined #bitcoin-core-dev
467 2017-06-07T22:47:56  *** _flow_ has joined #bitcoin-core-dev
468 2017-06-07T23:00:43  *** chartractegg has joined #bitcoin-core-dev
469 2017-06-07T23:03:43  *** chartractegg has quit IRC
470 2017-06-07T23:10:59  *** Guest47556 has joined #bitcoin-core-dev
471 2017-06-07T23:16:19  *** PaulCapestany has quit IRC
472 2017-06-07T23:22:16  *** chjj has quit IRC
473 2017-06-07T23:26:58  *** Guest47556 has quit IRC
474 2017-06-07T23:31:39  *** Chris_Stewart_5 has joined #bitcoin-core-dev
475 2017-06-07T23:35:35  *** chjj has joined #bitcoin-core-dev
476 2017-06-07T23:39:11  *** nakaluna has quit IRC
477 2017-06-07T23:48:46  *** Taek42 is now known as Taek
478 2017-06-07T23:49:08  *** cryptapus has joined #bitcoin-core-dev
479 2017-06-07T23:49:13  *** cryptapus is now known as cryptapus_afk
480 2017-06-07T23:59:10  *** abpa has quit IRC