12017-06-14T00:00:31  *** altoz has joined #bitcoin-core-dev
  22017-06-14T00:01:39  *** altoz_ has quit IRC
  32017-06-14T00:25:47  *** talmai has joined #bitcoin-core-dev
  42017-06-14T00:59:37  *** MarcoFalke_ has joined #bitcoin-core-dev
  52017-06-14T01:01:03  *** MarcoFalke has quit IRC
  62017-06-14T01:01:03  *** MarcoFalke_ is now known as MarcoFalke
  72017-06-14T01:02:04  *** Ylbam has quit IRC
  82017-06-14T01:06:26  <bitcoin-git> [bitcoin] sipa pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/fbf5d3ba1516...1ad3d4e1261f
  92017-06-14T01:06:27  <bitcoin-git> bitcoin/master a5410ac Jorge Timón: Small preparations for Q_FOREACH, PAIRTYPE and #include <boost/foreach.hpp> removal
 102017-06-14T01:06:27  <bitcoin-git> bitcoin/master 7c00c26 Jorge Timón: scripted-diff: Fully remove BOOST_FOREACH...
 112017-06-14T01:06:28  <bitcoin-git> bitcoin/master 18dc3c3 Jorge Timón: scripted-diff: Remove Q_FOREACH...
 122017-06-14T01:06:53  <bitcoin-git> [bitcoin] sipa closed pull request #10502: scripted-diff: Remove BOOST_FOREACH, Q_FOREACH and PAIRTYPE (master...b15-boost-foreach) https://github.com/bitcoin/bitcoin/pull/10502
 132017-06-14T01:10:38  *** bitsilent has quit IRC
 142017-06-14T01:14:58  *** bitsilent has joined #bitcoin-core-dev
 152017-06-14T01:17:17  *** coredump_ has quit IRC
 162017-06-14T01:17:41  *** coredump_ has joined #bitcoin-core-dev
 172017-06-14T01:29:07  *** justan0theruser has joined #bitcoin-core-dev
 182017-06-14T01:30:08  *** dermoth has quit IRC
 192017-06-14T01:31:05  *** dermoth has joined #bitcoin-core-dev
 202017-06-14T01:31:05  *** justanotheruser has quit IRC
 212017-06-14T01:38:33  *** coredump_ has quit IRC
 222017-06-14T01:46:32  *** dabura667 has joined #bitcoin-core-dev
 232017-06-14T01:58:23  *** coredump_ has joined #bitcoin-core-dev
 242017-06-14T01:58:58  *** Chris_Stewart_5 has quit IRC
 252017-06-14T02:07:41  *** justan0theruser has quit IRC
 262017-06-14T02:08:13  *** justanotheruser has joined #bitcoin-core-dev
 272017-06-14T02:15:00  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 282017-06-14T02:17:59  *** justanotheruser has quit IRC
 292017-06-14T02:18:24  *** justanotheruser has joined #bitcoin-core-dev
 302017-06-14T02:25:37  *** justanotheruser has quit IRC
 312017-06-14T02:26:06  *** justanotheruser has joined #bitcoin-core-dev
 322017-06-14T02:26:58  *** beatrootfarmer has joined #bitcoin-core-dev
 332017-06-14T02:30:30  *** goatturneer has quit IRC
 342017-06-14T02:31:30  *** coredump_ has quit IRC
 352017-06-14T02:31:59  *** coredump_ has joined #bitcoin-core-dev
 362017-06-14T02:41:33  *** coredump_ has quit IRC
 372017-06-14T02:43:46  *** justanotheruser has quit IRC
 382017-06-14T02:45:35  *** justanotheruser has joined #bitcoin-core-dev
 392017-06-14T02:46:00  *** justanotheruser has joined #bitcoin-core-dev
 402017-06-14T02:46:46  *** Gnof has quit IRC
 412017-06-14T02:56:11  *** justanotheruser has quit IRC
 422017-06-14T02:56:32  *** justanotheruser has joined #bitcoin-core-dev
 432017-06-14T03:12:50  *** talmai has quit IRC
 442017-06-14T03:16:13  <kvnn> gmaxwell : thank you.
 452017-06-14T03:18:47  *** justanotheruser has quit IRC
 462017-06-14T03:19:38  *** justanotheruser has joined #bitcoin-core-dev
 472017-06-14T03:20:11  *** justanotheruser has joined #bitcoin-core-dev
 482017-06-14T03:34:07  *** kvnn has quit IRC
 492017-06-14T03:35:57  *** PRab has joined #bitcoin-core-dev
 502017-06-14T03:43:43  <jtimon> \open_poll Would you (A) or (B) #9176 once and for all? It's never costing rebase time but potentially review time just by being open: A: CLOSE, B: MERGE
 512017-06-14T03:43:44  <gribble> https://github.com/bitcoin/bitcoin/issues/9176 | Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts() by jtimon · Pull Request #9176 · bitcoin/bitcoin · GitHub
 522017-06-14T03:53:27  *** jamesob has joined #bitcoin-core-dev
 532017-06-14T03:57:24  *** davec has quit IRC
 542017-06-14T04:07:11  <gmaxwell> uh. what is up with #10584
 552017-06-14T04:07:12  <gribble> https://github.com/bitcoin/bitcoin/issues/10584 | Remove unused ResendWalletTransactions notification by ryanofsky · Pull Request #10584 · bitcoin/bitcoin · GitHub
 562017-06-14T04:12:01  *** redraid79 has joined #bitcoin-core-dev
 572017-06-14T04:15:02  *** coredump_ has joined #bitcoin-core-dev
 582017-06-14T04:16:08  *** Chris_Stewart_5 has quit IRC
 592017-06-14T04:22:30  *** redraid79 has quit IRC
 602017-06-14T04:28:23  *** ensign has quit IRC
 612017-06-14T04:28:58  *** Giszmo has quit IRC
 622017-06-14T04:29:19  *** PaulCapestany has quit IRC
 632017-06-14T04:30:27  *** murchandamus has quit IRC
 642017-06-14T04:34:11  *** apll has quit IRC
 652017-06-14T04:35:19  *** murchandamus has joined #bitcoin-core-dev
 662017-06-14T04:36:07  *** apll has joined #bitcoin-core-dev
 672017-06-14T04:38:48  *** ensign has joined #bitcoin-core-dev
 682017-06-14T04:44:14  <phantomcircuit> gmaxwell, i think it's just wrong?
 692017-06-14T04:55:20  *** davec has joined #bitcoin-core-dev
 702017-06-14T04:55:37  <sipa> it looks to me he's removing only unused code
 712017-06-14T04:55:53  <sipa> which it shouldn't
 722017-06-14T04:55:55  <sipa> be
 732017-06-14T04:56:02  <sipa> but maybe i miss something
 742017-06-14T05:02:09  *** sanada has joined #bitcoin-core-dev
 752017-06-14T05:07:54  <gmaxwell> sipa: hm? it's hooked up to the Broadcast signal, which is invoked from SendMessages.
 762017-06-14T05:10:18  *** harrymm has quit IRC
 772017-06-14T05:14:06  *** PaulCapestany has joined #bitcoin-core-dev
 782017-06-14T05:15:16  <sipa> oh
 792017-06-14T05:17:14  <gmaxwell> have I said before that I do not slots and signals they and overhead and _obscure control flow_? :P
 802017-06-14T05:27:10  *** coredump_ has quit IRC
 812017-06-14T05:34:25  *** jamesob has quit IRC
 822017-06-14T05:44:56  *** harrymm has joined #bitcoin-core-dev
 832017-06-14T05:46:19  <sipa> gmaxwell: well i'm confused by ryanofsky thinks it's unused
 842017-06-14T05:47:36  <gmaxwell> maybe there is some pattern used in the codebase which makes the control flow less clear to him? :P  (I thought we had tests though for wallet retransmission, but seems the tests are passing. :( )
 852017-06-14T05:56:25  *** afk11 has quit IRC
 862017-06-14T05:56:41  *** cryptapus_afk has quit IRC
 872017-06-14T05:58:47  *** afk11 has joined #bitcoin-core-dev
 882017-06-14T06:14:26  *** PaulCapestany has quit IRC
 892017-06-14T06:16:28  *** goatturneer has joined #bitcoin-core-dev
 902017-06-14T06:17:44  *** vicenteH has joined #bitcoin-core-dev
 912017-06-14T06:20:10  *** beatrootfarmer has quit IRC
 922017-06-14T06:28:17  *** PaulCapestany has joined #bitcoin-core-dev
 932017-06-14T06:30:05  *** Dyaheon has quit IRC
 942017-06-14T06:30:45  *** Dyaheon has joined #bitcoin-core-dev
 952017-06-14T06:39:49  *** jonasschnelli has joined #bitcoin-core-dev
 962017-06-14T06:40:18  *** jonasschnelli has joined #bitcoin-core-dev
 972017-06-14T06:40:51  <jonasschnelli> Anyone up for a quick wallet PR review with great positive performance impacts: #10251
 982017-06-14T06:40:52  <gribble> https://github.com/bitcoin/bitcoin/issues/10251 | Add balances cache / GUI: use a signal instead of a poll thread by jonasschnelli · Pull Request #10251 · bitcoin/bitcoin · GitHub
 992017-06-14T06:45:40  <bitcoin-git> [bitcoin] laanwj closed pull request #10584: Remove unused ResendWalletTransactions notification (master...pr/noresend) https://github.com/bitcoin/bitcoin/pull/10584
1002017-06-14T06:48:09  *** jtimon has quit IRC
1012017-06-14T06:50:40  <bitcoin-git> [bitcoin] kallewoof opened pull request #10585: [WIP] PoW connection slots (master...pow-connection-slots) https://github.com/bitcoin/bitcoin/pull/10585
1022017-06-14T07:11:03  <bitcoin-git> [bitcoin] NicolasDorier closed pull request #9991: listreceivedbyaddress Filter Address (master...listreceivedbyaddress-filtered) https://github.com/bitcoin/bitcoin/pull/9991
1032017-06-14T07:17:10  *** riemann has joined #bitcoin-core-dev
1042017-06-14T07:19:04  *** timothy has joined #bitcoin-core-dev
1052017-06-14T07:20:59  *** riemann_ has joined #bitcoin-core-dev
1062017-06-14T07:21:02  *** riemann has quit IRC
1072017-06-14T07:40:15  *** Ylbam has joined #bitcoin-core-dev
1082017-06-14T08:08:12  *** BashCo has quit IRC
1092017-06-14T08:18:34  *** ghs39ghsggf has joined #bitcoin-core-dev
1102017-06-14T08:18:35  *** ghs39ghsggf has left #bitcoin-core-dev
1112017-06-14T08:22:57  *** cryptapus_afk has joined #bitcoin-core-dev
1122017-06-14T08:22:57  *** cryptapus_afk has joined #bitcoin-core-dev
1132017-06-14T08:28:35  *** jannes has joined #bitcoin-core-dev
1142017-06-14T08:35:27  *** apll has quit IRC
1152017-06-14T08:36:40  *** apll has joined #bitcoin-core-dev
1162017-06-14T08:36:54  *** BashCo has joined #bitcoin-core-dev
1172017-06-14T08:47:30  *** apll has quit IRC
1182017-06-14T08:49:23  *** apll has joined #bitcoin-core-dev
1192017-06-14T09:21:18  *** Guest___ has joined #bitcoin-core-dev
1202017-06-14T09:34:37  *** bananeGetreide has joined #bitcoin-core-dev
1212017-06-14T09:35:17  *** bananeGetreide has quit IRC
1222017-06-14T09:53:48  *** bananeGetreide has joined #bitcoin-core-dev
1232017-06-14T09:59:46  *** bananeGetreide has quit IRC
1242017-06-14T10:23:06  *** Guest___ has quit IRC
1252017-06-14T10:57:13  <wumpus> any problems with 0.14.2rc2 reported yet? anyone have anything to add to the release notes? https://github.com/bitcoin/bitcoin/blob/0.14/doc/release-notes.md
1262017-06-14T10:57:31  <wumpus> if not, it may be time to cut the release
1272017-06-14T11:10:04  *** Guest has joined #bitcoin-core-dev
1282017-06-14T11:11:08  *** Dyaheon has quit IRC
1292017-06-14T11:11:36  *** Dyaheon has joined #bitcoin-core-dev
1302017-06-14T11:18:05  *** bitsilent_ has joined #bitcoin-core-dev
1312017-06-14T11:19:36  *** bitsilent has quit IRC
1322017-06-14T11:19:38  *** bitsilent_ is now known as bitsilent
1332017-06-14T11:41:02  *** d9b4bef9 has quit IRC
1342017-06-14T11:44:17  *** d9b4bef9 has joined #bitcoin-core-dev
1352017-06-14T11:54:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1362017-06-14T11:59:37  *** beatrootfarmer has joined #bitcoin-core-dev
1372017-06-14T12:03:10  *** goatturneer has quit IRC
1382017-06-14T12:10:11  *** Guest has quit IRC
1392017-06-14T12:10:38  *** Guest has joined #bitcoin-core-dev
1402017-06-14T12:11:34  *** dabura667 has quit IRC
1412017-06-14T12:13:15  *** rafalcpp has quit IRC
1422017-06-14T12:24:34  *** BashCo has quit IRC
1432017-06-14T12:27:01  *** BashCo has joined #bitcoin-core-dev
1442017-06-14T12:33:16  *** PRab has quit IRC
1452017-06-14T12:51:35  *** BashCo has quit IRC
1462017-06-14T12:53:47  *** BashCo has joined #bitcoin-core-dev
1472017-06-14T13:07:09  *** Gnof has joined #bitcoin-core-dev
1482017-06-14T13:07:50  *** BashCo has quit IRC
1492017-06-14T13:09:20  *** BashCo has joined #bitcoin-core-dev
1502017-06-14T13:22:47  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1ad3d4e1261f...b63be2c6852f
1512017-06-14T13:22:47  <bitcoin-git> bitcoin/master cb24c85 Pieter Wuille: Use rdrand as entropy source on supported platforms
1522017-06-14T13:22:48  <bitcoin-git> bitcoin/master b63be2c Wladimir J. van der Laan: Merge #10377: Use rdrand as entropy source on supported platforms...
1532017-06-14T13:23:17  <bitcoin-git> [bitcoin] laanwj closed pull request #10377: Use rdrand as entropy source on supported platforms (master...hwrand) https://github.com/bitcoin/bitcoin/pull/10377
1542017-06-14T13:25:37  *** BashCo has quit IRC
1552017-06-14T13:28:14  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b63be2c6852f...6702617c868a
1562017-06-14T13:28:14  <bitcoin-git> bitcoin/master ec98b78 Andrew Chow: Tests for wallet encryption stuff...
1572017-06-14T13:28:15  <bitcoin-git> bitcoin/master 6702617 Wladimir J. van der Laan: Merge #10551: [Tests] Wallet encryption functional tests...
1582017-06-14T13:28:56  <bitcoin-git> [bitcoin] laanwj closed pull request #10551: [Tests] Wallet encryption functional tests (master...wallet-encrypt-test) https://github.com/bitcoin/bitcoin/pull/10551
1592017-06-14T13:29:55  *** BashCo has joined #bitcoin-core-dev
1602017-06-14T13:36:27  <bitcoin-git> [bitcoin] laanwj closed pull request #10081: Add 'dumpbootstrap' RPC for creating bootstrap.dat files. (master...dumpbootstrap) https://github.com/bitcoin/bitcoin/pull/10081
1612017-06-14T13:38:36  *** apll has quit IRC
1622017-06-14T13:39:05  <ryanofsky> re: "well i'm confused by ryanofsky thinks it's unused" just a mistake, my brain wasn't working, and the naming for that signal doesn't follow the normal pattern
1632017-06-14T13:39:27  *** apll has joined #bitcoin-core-dev
1642017-06-14T13:41:01  *** BashCo has quit IRC
1652017-06-14T13:49:12  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6702617c868a...c94b89e90d6a
1662017-06-14T13:49:13  <bitcoin-git> bitcoin/master 6294f32 John Newbery: gettxoutproof() should return consistent result...
1672017-06-14T13:49:13  <bitcoin-git> bitcoin/master c94b89e Wladimir J. van der Laan: Merge #9738: gettxoutproof() should return consistent result...
1682017-06-14T13:49:32  <bitcoin-git> [bitcoin] laanwj closed pull request #9738: gettxoutproof() should return consistent result (master...fixgettxoutproof) https://github.com/bitcoin/bitcoin/pull/9738
1692017-06-14T13:50:10  *** Guest has quit IRC
1702017-06-14T13:51:19  *** Cheeseo has joined #bitcoin-core-dev
1712017-06-14T13:51:19  *** Cheeseo has joined #bitcoin-core-dev
1722017-06-14T13:55:30  *** Cheeseo has quit IRC
1732017-06-14T13:59:03  *** Giszmo has joined #bitcoin-core-dev
1742017-06-14T14:00:51  *** laurentmt has joined #bitcoin-core-dev
1752017-06-14T14:12:36  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c94b89e90d6a...228c319a944b
1762017-06-14T14:12:36  <bitcoin-git> bitcoin/master 1d1ea9f Marko Bencun: Turn TryCreateDirectory() into TryCreateDirectories()...
1772017-06-14T14:12:37  <bitcoin-git> bitcoin/master 228c319 Wladimir J. van der Laan: Merge #9895: Turn TryCreateDirectory() into TryCreateDirectories()...
1782017-06-14T14:13:12  <bitcoin-git> [bitcoin] laanwj closed pull request #9895: Turn TryCreateDirectory() into TryCreateDirectories() (master...appinitmain) https://github.com/bitcoin/bitcoin/pull/9895
1792017-06-14T14:24:08  *** jouke_ is now known as jouke
1802017-06-14T14:24:40  *** jouke has quit IRC
1812017-06-14T14:24:40  *** jouke has joined #bitcoin-core-dev
1822017-06-14T14:30:13  *** rafalcpp has joined #bitcoin-core-dev
1832017-06-14T14:38:57  *** unholymachine has quit IRC
1842017-06-14T14:40:10  *** unholymachine has joined #bitcoin-core-dev
1852017-06-14T14:52:01  *** marcoagner has joined #bitcoin-core-dev
1862017-06-14T14:56:13  *** jtimon has joined #bitcoin-core-dev
1872017-06-14T14:57:15  *** laurentmt has quit IRC
1882017-06-14T14:59:12  *** riemann_ has quit IRC
1892017-06-14T15:13:20  *** harrymm has quit IRC
1902017-06-14T15:16:41  <bitcoin-git> [bitcoin] morcos opened pull request #10586: More economical fee estimates for opt-in-RBF transactions (master...aggressiveEstimates) https://github.com/bitcoin/bitcoin/pull/10586
1912017-06-14T15:17:04  *** AaronvanW has joined #bitcoin-core-dev
1922017-06-14T15:20:45  *** Guyver2 has joined #bitcoin-core-dev
1932017-06-14T15:25:08  *** Dizzle has joined #bitcoin-core-dev
1942017-06-14T15:29:01  *** harrymm has joined #bitcoin-core-dev
1952017-06-14T15:29:35  *** goatturneer has joined #bitcoin-core-dev
1962017-06-14T15:32:31  *** goatturner has joined #bitcoin-core-dev
1972017-06-14T15:33:16  *** beatrootfarmer has quit IRC
1982017-06-14T15:35:41  *** goatturneer has quit IRC
1992017-06-14T15:40:58  <morcos> sipa: Ruling requested
2002017-06-14T15:41:11  <morcos> What is the style guide for an rpc named argument?
2012017-06-14T15:41:18  <morcos> conf_target?
2022017-06-14T15:41:52  <morcos> we already have a confTarget inside the options for bumpfee, but its inside the options, and it seems most named argumetns aren't camelCase
2032017-06-14T15:43:58  <sipa> from developer-notes.md, under RPC:
2042017-06-14T15:44:00  <sipa> Argument naming: use snake case fee_delta (and not, e.g. camel case feeDelta)
2052017-06-14T15:44:03  <sipa> Rationale: Consistency with existing interface.
2062017-06-14T15:47:58  *** abpa has joined #bitcoin-core-dev
2072017-06-14T15:50:46  <bitcoin-git> [bitcoin] practicalswift opened pull request #10587: Net: Fix resource leak in ReadBinaryFile(...) (master...fopen-not-followed-by-fclose-in-all-states-of-the-universe) https://github.com/bitcoin/bitcoin/pull/10587
2082017-06-14T15:57:05  <morcos> sipa: oops, sorry i didn't read
2092017-06-14T16:01:38  *** timothy has quit IRC
2102017-06-14T16:10:31  *** Dyaheon has quit IRC
2112017-06-14T16:11:24  *** Dyaheon has joined #bitcoin-core-dev
2122017-06-14T16:23:19  *** mkarrer has joined #bitcoin-core-dev
2132017-06-14T16:24:27  *** bitsilent has quit IRC
2142017-06-14T16:46:24  *** Guest___ has joined #bitcoin-core-dev
2152017-06-14T17:04:52  <cfields> jtimon: ping
2162017-06-14T17:06:22  <jtimon> cfields: pong
2172017-06-14T17:06:46  <cfields> jtimon: I'm confused. At one point, you had a version of the reverse_iterator that compiled, but failed tests. no?
2182017-06-14T17:07:55  <jtimon> yes, and then I followed your advice for the prevector tests, which was the part that didn't compile unless I commented those lines (but if I did comment them, then the tests failed as they should)
2192017-06-14T17:08:55  <cfields> jtimon: can you point me to a failing revision?
2202017-06-14T17:09:19  <cfields> jtimon: oooooh
2212017-06-14T17:09:42  <cfields> jtimon: the tests failed because some things were commented out, not because of new breakage?
2222017-06-14T17:15:38  *** abpa has quit IRC
2232017-06-14T17:15:44  <jtimon> right the breakage was a compile error
2242017-06-14T17:16:25  <jtimon> sorry, I shouldn't have commented the lines, and should had left the compile error there, I just wanted to see what else would fail
2252017-06-14T17:18:52  *** afk11 has quit IRC
2262017-06-14T17:19:03  *** afk11 has joined #bitcoin-core-dev
2272017-06-14T17:19:25  *** abpa has joined #bitcoin-core-dev
2282017-06-14T17:22:03  *** Guest___ has quit IRC
2292017-06-14T17:33:16  <cfields> jtimon: ok, i misunderstood, then
2302017-06-14T17:33:50  <cfields> jtimon: i wrote some quick tests locally, and everything passed. So I'm not so concerned about the scope issue anymore
2312017-06-14T17:35:05  <cfields> jtimon: compile fix is here: https://pastebin.com/raw/2zscDfbq
2322017-06-14T17:41:07  *** nakaluna has joined #bitcoin-core-dev
2332017-06-14T18:00:19  *** RubenSomsen has joined #bitcoin-core-dev
2342017-06-14T18:12:22  <jtimon> cfields: oh, thanks! I tried to do the reverse iterator more const, but not the prevector!
2352017-06-14T18:15:27  *** Dyaheon has quit IRC
2362017-06-14T18:17:33  *** Dyaheon has joined #bitcoin-core-dev
2372017-06-14T18:28:33  *** SopaXorzTaker has quit IRC
2382017-06-14T18:28:37  *** Chris_Stewart_5 has quit IRC
2392017-06-14T18:35:35  <bitcoin-git> [bitcoin] morcos opened pull request #10588: Note preexisting bug in display of fee calculation in coin control (0.14...notebug) https://github.com/bitcoin/bitcoin/pull/10588
2402017-06-14T18:55:58  *** riemann has joined #bitcoin-core-dev
2412017-06-14T19:09:07  *** owowo has quit IRC
2422017-06-14T19:13:48  *** owowo has joined #bitcoin-core-dev
2432017-06-14T19:18:05  <instagibbs> anyone know the reasoning for the "keyword definition" stuff in importmulti.py? A couple of those strings don't even occur, and none of the variables are ever used.
2442017-06-14T19:18:09  <instagibbs> https://github.com/bitcoin/bitcoin/blob/master/test/functional/importmulti.py#L24
2452017-06-14T19:24:34  <bitcoin-git> [bitcoin] morcos opened pull request #10589: Add RPC options for RBF, confirmation target and conservative fee estimates (master...rpcestimatechoice) https://github.com/bitcoin/bitcoin/pull/10589
2462017-06-14T19:33:27  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2472017-06-14T19:33:56  <instagibbs> morcos, really wish we could get some basic effective value logic in so we could easily improve bumpfee as well.
2482017-06-14T19:34:14  *** talmai has joined #bitcoin-core-dev
2492017-06-14T19:34:52  <morcos> how does that help with improving bumpfee?
2502017-06-14T19:37:20  *** chjj has quit IRC
2512017-06-14T19:37:36  <instagibbs> Well, I guess we could just lamely loop and keep increasing until it grabs enough effective value...
2522017-06-14T19:38:04  <instagibbs> the sickness spreading :P
2532017-06-14T19:38:25  <instagibbs> right now bumpfee must have a change output to be successful
2542017-06-14T19:38:47  *** deplrble has joined #bitcoin-core-dev
2552017-06-14T19:40:09  <morcos> instagibbs: yes but i don't understand how thats related to the effective value logic?
2562017-06-14T19:40:54  <instagibbs> if we had effective value logic, it would be easier? Sorry I'm missing what you're missing.
2572017-06-14T19:41:05  <morcos> i thought the reason bumpfee had to have change had something to do with the complication of adding new inputs which may mean there are multiple txs being replaced
2582017-06-14T19:41:15  <instagibbs> ah, maybe that's a reason
2592017-06-14T19:41:31  <morcos> i dont' think the requirement that we had change to reduce in order to bump fee had anything to do with our stupid coin selection
2602017-06-14T19:41:41  <morcos> in any case, i'm all for improving coin selection.
2612017-06-14T19:42:20  <instagibbs> why would adding confirmed inputs replace multiple txs?
2622017-06-14T19:42:34  <instagibbs> maybe I should go hunt down the bumpfee PR, find the undocumented assumptions
2632017-06-14T19:42:41  <morcos> but limited cycles..  i owe sipa and bluematt tons of review too, but i'm about to be away from work for a bit, so i just wanted to push out the fee changes i think we need for 0.15
2642017-06-14T19:42:48  <instagibbs> Understood
2652017-06-14T19:43:08  <morcos> instagibbs: i don't remember exactly now, but i thin kthe idea was just to limit it to the simplest possible case for starters
2662017-06-14T19:43:19  <morcos> not that we can't do other things , but just to get the first round in
2672017-06-14T19:43:55  <instagibbs> I totally agree, which is why I was thinking about coin selection in that respect.
2682017-06-14T19:44:21  <instagibbs> anyways I'll revisit it post-0.15
2692017-06-14T19:48:57  *** RubenSomsen has quit IRC
2702017-06-14T19:49:20  <sipa> instagibbs, morcos: achow101 and i are looking at murch's branch&bound algorithm for coin selection
2712017-06-14T19:50:31  <instagibbs> great. We might not care about exact matches when hitting `bumpfee`, since we may want followup change
2722017-06-14T19:50:50  *** chjj has joined #bitcoin-core-dev
2732017-06-14T19:51:17  <instagibbs> without linking a bunch of inputs together greedily
2742017-06-14T19:58:37  *** harrymm has quit IRC
2752017-06-14T20:13:24  *** talmai has quit IRC
2762017-06-14T20:21:07  *** Dyaheon has quit IRC
2772017-06-14T20:21:37  *** murch has joined #bitcoin-core-dev
2782017-06-14T20:21:50  <murch> @sipa: What are you guys doing this evening?
2792017-06-14T20:23:26  <murch> I assume you have found the branch in my github repo?
2802017-06-14T20:23:43  <sipa> murch: yup
2812017-06-14T20:23:45  *** Dyaheon has joined #bitcoin-core-dev
2822017-06-14T20:23:46  <sipa> see pm
2832017-06-14T20:27:18  *** harrymm has joined #bitcoin-core-dev
2842017-06-14T20:29:41  *** Giszmo has quit IRC
2852017-06-14T20:32:18  *** Giszmo has joined #bitcoin-core-dev
2862017-06-14T20:41:08  *** jtimon has quit IRC
2872017-06-14T20:44:11  <bitcoin-git> [bitcoin] jnewbery opened pull request #10591: [tests] make pruning.py faster (master...fastprune) https://github.com/bitcoin/bitcoin/pull/10591
2882017-06-14T20:46:53  *** schmidty has joined #bitcoin-core-dev
2892017-06-14T20:52:42  *** Gnof has quit IRC
2902017-06-14T21:15:06  <bitcoin-git> [bitcoin] jnewbery opened pull request #10592: [trivial] fix indentation for ArgsManager class (master...argsmanager) https://github.com/bitcoin/bitcoin/pull/10592
2912017-06-14T21:24:08  *** riemann has quit IRC
2922017-06-14T21:28:21  *** riemann has joined #bitcoin-core-dev
2932017-06-14T21:33:06  *** JackH has quit IRC
2942017-06-14T21:35:59  *** paveljanik has quit IRC
2952017-06-14T21:37:30  *** cryptapus_afk has quit IRC
2962017-06-14T21:39:44  *** Chris_Stewart_5 has quit IRC
2972017-06-14T21:41:40  *** cryptapus has joined #bitcoin-core-dev
2982017-06-14T21:41:43  *** cryptapus is now known as cryptapus_afk
2992017-06-14T21:41:49  <bitcoin-git> [bitcoin] luke-jr closed pull request #10512: Rework same-chain from abusing DoS banning, to explicit checks (master...samechain_rework) https://github.com/bitcoin/bitcoin/pull/10512
3002017-06-14T21:42:24  <bitcoin-git> [bitcoin] luke-jr opened pull request #10593: Relax punishment for peers relaying invalid blocks and headers (master...relax_invblk_punishment) https://github.com/bitcoin/bitcoin/pull/10593
3012017-06-14T21:42:34  <gmaxwell> instagibbs: I believe the reason for fixing the inputs was just to simplify the first implementation.
3022017-06-14T21:43:19  <bitcoin-git> [bitcoin] luke-jr opened pull request #10594: Bugfix: net: Apply whitelisting criteria to outgoing connections (master...whitelist_outgoing) https://github.com/bitcoin/bitcoin/pull/10594
3032017-06-14T21:43:38  <gmaxwell> Also, it's preferable to not use extra inputs if you can avoid it, because you'll burn down your unspent outputs available for other transactions. (keep in mind you really don't want to spend the bump change, since you can't be sure which version will confirm)
3042017-06-14T21:46:12  *** thermoman_ has quit IRC
3052017-06-14T21:48:02  *** goatpig has joined #bitcoin-core-dev
3062017-06-14T21:48:29  *** paveljanik has joined #bitcoin-core-dev
3072017-06-14T21:52:26  *** Dizzle has quit IRC
3082017-06-14T21:55:30  *** nakaluna has quit IRC
3092017-06-14T21:58:53  *** zeusa1mighty has quit IRC
3102017-06-14T22:09:04  *** fizzwont has joined #bitcoin-core-dev
3112017-06-14T22:12:44  *** Guyver2 has quit IRC
3122017-06-14T22:15:02  *** ivan has joined #bitcoin-core-dev
3132017-06-14T22:17:56  *** Guest___ has joined #bitcoin-core-dev
3142017-06-14T22:21:30  *** gaf_ has joined #bitcoin-core-dev
3152017-06-14T23:15:18  *** Guest___ has quit IRC
3162017-06-14T23:21:10  *** AaronvanW has quit IRC
3172017-06-14T23:26:42  *** AaronvanW has joined #bitcoin-core-dev
3182017-06-14T23:31:50  *** justanotheruser has quit IRC
3192017-06-14T23:32:57  *** Dyaheon has quit IRC
3202017-06-14T23:33:05  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3212017-06-14T23:36:00  *** Dyaheon has joined #bitcoin-core-dev
3222017-06-14T23:37:45  *** Gnof has joined #bitcoin-core-dev
3232017-06-14T23:47:32  *** justanotheruser has joined #bitcoin-core-dev
3242017-06-14T23:57:37  *** nemgun has joined #bitcoin-core-dev
3252017-06-14T23:59:25  *** abpa has quit IRC