12017-06-25T00:02:55  *** suryab has joined #bitcoin-core-dev
  22017-06-25T00:04:01  <suryab> Hi, i'm trying to calculate the fee rate of a transaction that is not in the mempool. I saw the way fees are traditionally calculated and can't do the mempool.info() route. Any suggestions?
  32017-06-25T00:05:27  <suryab> There also doesn't seem to be any functionality already there for getting the feerate out of a transaction.
  42017-06-25T00:11:11  <sipa> you can't get the feerate from a transaction
  52017-06-25T00:11:16  <sipa> you need the UTXOs it spends
  62017-06-25T00:11:18  <jtimon> suryab: I believe you are correct. Not only at the rpc level but not even at a lower level. https://github.com/bitcoin/bitcoin/pull/8498 would solve this or you can just CAmount nFees = view.GetValueIn(tx)- tx.GetValueOut();
  72017-06-25T00:11:33  <jtimon> right, there the utxos are in view
  82017-06-25T00:56:54  *** jamesob has joined #bitcoin-core-dev
  92017-06-25T01:07:44  *** jamesob has quit IRC
 102017-06-25T01:38:48  *** Ylbam has quit IRC
 112017-06-25T01:43:57  *** diteli_ has joined #bitcoin-core-dev
 122017-06-25T02:02:01  *** harrymm has quit IRC
 132017-06-25T02:26:27  *** jtimon has quit IRC
 142017-06-25T02:33:15  *** jtimon has joined #bitcoin-core-dev
 152017-06-25T02:33:27  *** jtimon has quit IRC
 162017-06-25T02:38:55  *** diteli_ has quit IRC
 172017-06-25T02:44:49  *** belcher_ has quit IRC
 182017-06-25T02:54:27  *** goofie_ has quit IRC
 192017-06-25T02:55:27  *** chjj has quit IRC
 202017-06-25T03:10:14  *** goofie_ has joined #bitcoin-core-dev
 212017-06-25T04:24:58  *** jtimon has joined #bitcoin-core-dev
 222017-06-25T04:50:05  *** suryab has quit IRC
 232017-06-25T05:06:55  <bitcoin-git> [bitcoin] jtimon closed pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
 242017-06-25T05:07:04  *** chjj has joined #bitcoin-core-dev
 252017-06-25T05:16:10  <bitcoin-git> [bitcoin] jtimon reopened pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717
 262017-06-25T05:23:33  *** chjj has quit IRC
 272017-06-25T05:58:20  *** ProfMac_ has quit IRC
 282017-06-25T06:09:50  <jtimon> mhmm, it doesn't seem like https://travis-ci.org/bitcoin/bitcoin/jobs/246709867  and https://travis-ci.org/bitcoin/bitcoin/jobs/246709865 should have failed, but I'm on the laptop and I can't say for sure yet
 292017-06-25T06:27:15  *** harrymm has joined #bitcoin-core-dev
 302017-06-25T06:31:06  *** AaronvanW has quit IRC
 312017-06-25T06:31:44  *** AaronvanW has joined #bitcoin-core-dev
 322017-06-25T06:33:46  *** btcdrak has joined #bitcoin-core-dev
 332017-06-25T06:34:37  *** goofie_ has quit IRC
 342017-06-25T06:35:50  *** AaronvanW has quit IRC
 352017-06-25T06:45:58  *** harrymm has quit IRC
 362017-06-25T06:46:14  *** harrymm has joined #bitcoin-core-dev
 372017-06-25T07:19:03  *** chjj has joined #bitcoin-core-dev
 382017-06-25T07:24:54  *** Ylbam has joined #bitcoin-core-dev
 392017-06-25T07:27:39  *** neel has joined #bitcoin-core-dev
 402017-06-25T08:10:00  <jtimon> what's the simplest way to find out whoch commit deleted a given variable, say, pwalletMain
 412017-06-25T08:10:02  <jtimon> ?
 422017-06-25T08:11:44  <jcorgan> some unholy combination of git bisect and grep i'd suppose
 432017-06-25T08:13:28  <jtimon> I guess I can always ask how to do it from xmonad on #haskell
 442017-06-25T08:13:41  <wumpus> git log -p is usually my friend in those cases
 452017-06-25T08:14:14  <wumpus> find out what what commit it was last mentioned in, especially works if you can limit the scope to not the entire source code
 462017-06-25T08:15:24  <wumpus> though bisect and grep seems more elegant
 472017-06-25T08:18:54  *** goatpig has quit IRC
 482017-06-25T08:18:57  *** arubi has quit IRC
 492017-06-25T08:24:14  *** arubi has joined #bitcoin-core-dev
 502017-06-25T08:25:44  *** justanotheruser has quit IRC
 512017-06-25T08:26:07  *** justanotheruser has joined #bitcoin-core-dev
 522017-06-25T08:26:33  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bef02fb6ac9f...d609fd85ca41
 532017-06-25T08:26:34  <bitcoin-git> bitcoin/master b324b28 Jorge Timón: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()
 542017-06-25T08:26:34  <bitcoin-git> bitcoin/master d609fd8 Wladimir J. van der Laan: Merge #9176: Globals: Pass Consensus::Params through CBlockTreeDB::LoadBlockIndexGuts()...
 552017-06-25T08:26:51  *** goatpig has joined #bitcoin-core-dev
 562017-06-25T08:30:49  *** harrymm has quit IRC
 572017-06-25T08:31:03  *** harrymm has joined #bitcoin-core-dev
 582017-06-25T08:35:39  *** harrymm has quit IRC
 592017-06-25T08:44:33  *** arubi has quit IRC
 602017-06-25T08:47:54  *** Yogaqueef has joined #bitcoin-core-dev
 612017-06-25T08:48:54  <bitcoin-git> [bitcoin] jtimon opened pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
 622017-06-25T08:49:39  *** arubi has joined #bitcoin-core-dev
 632017-06-25T08:50:19  <bitcoin-git> [bitcoin] jtimon closed pull request #10668: Pow: Introduce MaybeGenerateProof (master...b15-blocksign) https://github.com/bitcoin/bitcoin/pull/10668
 642017-06-25T08:56:14  <bitcoin-git> [bitcoin] jtimon opened pull request #10669: Pow: Introduce MaybeGenerateProof (master...b14-pow-maybe-prove) https://github.com/bitcoin/bitcoin/pull/10669
 652017-06-25T09:01:44  <bitcoin-git> [bitcoin] laanwj closed pull request #10282: Expire bitcoind & bitcoin-qt 7-8 years after its last change (master...timebomb) https://github.com/bitcoin/bitcoin/pull/10282
 662017-06-25T09:04:05  *** Giszmo has quit IRC
 672017-06-25T09:22:20  *** jtimon has quit IRC
 682017-06-25T09:52:50  *** neel has quit IRC
 692017-06-25T09:54:02  *** d9b4bef9 has quit IRC
 702017-06-25T09:55:08  *** d9b4bef9 has joined #bitcoin-core-dev
 712017-06-25T10:05:03  *** riemann has joined #bitcoin-core-dev
 722017-06-25T10:05:48  *** neel has joined #bitcoin-core-dev
 732017-06-25T10:06:06  *** harrymm has joined #bitcoin-core-dev
 742017-06-25T10:19:57  *** goofie_ has joined #bitcoin-core-dev
 752017-06-25T10:47:48  *** Guyver2 has joined #bitcoin-core-dev
 762017-06-25T11:04:54  *** sipa has quit IRC
 772017-06-25T11:22:30  *** SopaXorzTaker has joined #bitcoin-core-dev
 782017-06-25T11:43:32  <instagibbs> git log -p -M can help you track across renamings at least
 792017-06-25T11:55:39  *** belcher_ has joined #bitcoin-core-dev
 802017-06-25T11:56:10  *** goofie_ has quit IRC
 812017-06-25T12:46:38  *** laurentmt has joined #bitcoin-core-dev
 822017-06-25T12:56:14  *** goofie_ has joined #bitcoin-core-dev
 832017-06-25T12:59:15  *** laurentmt has quit IRC
 842017-06-25T13:14:58  *** goofie_ has quit IRC
 852017-06-25T13:20:33  *** goofie_ has joined #bitcoin-core-dev
 862017-06-25T13:23:26  *** btcdrak has quit IRC
 872017-06-25T13:33:26  *** goofie_ has quit IRC
 882017-06-25T13:53:02  *** d9b4bef9 has quit IRC
 892017-06-25T13:56:07  *** d9b4bef9 has joined #bitcoin-core-dev
 902017-06-25T14:17:41  *** laurentmt has joined #bitcoin-core-dev
 912017-06-25T14:18:25  *** laurentmt has quit IRC
 922017-06-25T14:18:52  *** Guyver2 has quit IRC
 932017-06-25T14:24:56  *** chjj has quit IRC
 942017-06-25T14:29:33  *** dermoth has quit IRC
 952017-06-25T14:30:02  *** dermoth has joined #bitcoin-core-dev
 962017-06-25T14:39:51  *** goofie_ has joined #bitcoin-core-dev
 972017-06-25T14:50:05  *** tiagotrs has joined #bitcoin-core-dev
 982017-06-25T14:58:13  *** Yogaqueef has quit IRC
 992017-06-25T15:06:08  *** ProfMac has joined #bitcoin-core-dev
1002017-06-25T15:28:17  *** ProfMac is now known as ProfMac_
1012017-06-25T15:43:27  *** sipa has joined #bitcoin-core-dev
1022017-06-25T15:59:06  <earlz> Is there some way to force a node to rebroadcast it's mempool?
1032017-06-25T16:09:04  <sipa> no
1042017-06-25T16:09:52  <sipa> (peers can ask for a node's mempool using the bip35 'mempool' command, but it's never broadcast unadvertized)
1052017-06-25T16:23:04  <earlz> is there any way to easily make that request from a Bitcoin Core node?
1062017-06-25T16:23:11  <earlz> ie, an RPC command for it?
1072017-06-25T16:24:11  <sipa> getrawmempool
1082017-06-25T16:24:21  <sipa> oh, no
1092017-06-25T16:24:32  <sipa> you meam make your node request it from another, no
1102017-06-25T16:25:10  <earlz> ah lame, so you'd have to write code to get Bitcoin Core to do that
1112017-06-25T16:27:45  <sipa> why do you need it?
1122017-06-25T16:34:51  <earlz> Testing something and was see some difference between 2 node's mempool count
1132017-06-25T16:35:32  *** laurentmt has joined #bitcoin-core-dev
1142017-06-25T16:37:10  *** laurentmt has quit IRC
1152017-06-25T16:37:54  <sipa> how would that help?
1162017-06-25T16:39:06  <sipa> afaik the only reason you'd use that command on a full node is to get your mempool to converge faster to that of your peers
1172017-06-25T16:39:28  <sipa> something that's much less needed now with mempool being saved to disk
1182017-06-25T16:42:23  <earlz> If node A mempool is 200, and node B only has 100, and B is only connected to A, will the missing txs be broadcast to B through the mempool, or does rebroadcasting never happen naturally?
1192017-06-25T16:49:26  *** Yogaqueef has joined #bitcoin-core-dev
1202017-06-25T16:49:41  <sipa> no, only new transactions are relayed
1212017-06-25T16:50:06  <sipa> and wallets rebroadcast their own transactions occasionally
1222017-06-25T16:51:15  <earlz> What about when a wallet does a rebroadcast because it doesn't see it's tx in the network mempool? Would that cause it to spread to the greater network? (ie, if A has tx X, and B does a rebroadcast of X, does that cause A to also rebroadcast X to it's peers)
1232017-06-25T16:53:13  *** vicenteH` has quit IRC
1242017-06-25T16:53:32  *** vicenteH` has joined #bitcoin-core-dev
1252017-06-25T16:55:55  <sipa> yes
1262017-06-25T16:56:02  <sipa> wait, no
1272017-06-25T16:56:16  <sipa> the rebroascast only happens to peers that don't already have the tx
1282017-06-25T16:56:37  <sipa> they will of course relay it further
1292017-06-25T16:57:15  <sipa> but if a node has a tx already, and sees it inved again, it is ignored
1302017-06-25T17:05:38  *** neel_ has joined #bitcoin-core-dev
1312017-06-25T17:07:15  *** goofie_ has quit IRC
1322017-06-25T17:08:31  *** neel has quit IRC
1332017-06-25T17:17:21  <earlz> ok thanks, I think this behavior makes sense to me now
1342017-06-25T17:28:43  *** ProfMac_ is now known as ProfMac
1352017-06-25T17:39:27  *** justanotheruser has quit IRC
1362017-06-25T17:39:28  *** Dyaheon has quit IRC
1372017-06-25T17:39:55  *** Dyaheon has joined #bitcoin-core-dev
1382017-06-25T17:40:28  *** justanotheruser has joined #bitcoin-core-dev
1392017-06-25T17:46:15  <ProfMac> This may interest this group:  I am trying to set up my own flavor of a deterministic build environment.  This uses the desktop Trusty (14.04.5) amd64 iso and a preseed file.  I am having trouble with preseeding.  I have set up a git with the scripts and the syslog, and hope to get help in #ubuntu-installer
1402017-06-25T17:47:16  <ProfMac> An entry to my git is at https://github.com/a-mcintosh/Trusty-preseed/blob/master/syslog
1412017-06-25T17:57:55  *** AaronvanW has joined #bitcoin-core-dev
1422017-06-25T17:58:07  *** neel_ has quit IRC
1432017-06-25T17:59:14  *** neel has joined #bitcoin-core-dev
1442017-06-25T18:18:42  *** jamesob has joined #bitcoin-core-dev
1452017-06-25T18:18:46  *** jamesob has quit IRC
1462017-06-25T18:19:02  *** jamesob has joined #bitcoin-core-dev
1472017-06-25T18:19:17  <jamesob> heyyyyy everybodyboydyboydy
1482017-06-25T18:19:26  *** goatpig has quit IRC
1492017-06-25T18:21:55  *** tiagotrs has quit IRC
1502017-06-25T18:23:20  *** riemann has quit IRC
1512017-06-25T18:24:25  <jamesob> (wrong window :)
1522017-06-25T18:42:08  *** jamesob has quit IRC
1532017-06-25T18:45:00  *** riemann has joined #bitcoin-core-dev
1542017-06-25T19:02:08  *** Giszmo has joined #bitcoin-core-dev
1552017-06-25T19:05:28  *** ProfMac is now known as ProfMac_
1562017-06-25T19:43:47  *** jamesob has joined #bitcoin-core-dev
1572017-06-25T19:46:44  *** laurentmt has joined #bitcoin-core-dev
1582017-06-25T19:48:00  *** laurentmt has quit IRC
1592017-06-25T19:48:38  *** tripleslash has quit IRC
1602017-06-25T19:52:40  *** tripleslash has joined #bitcoin-core-dev
1612017-06-25T19:53:03  *** tripleslash is now known as Guest34077
1622017-06-25T19:57:53  *** johnwang412 has joined #bitcoin-core-dev
1632017-06-25T20:00:28  *** dermoth has quit IRC
1642017-06-25T20:00:54  *** dermoth has joined #bitcoin-core-dev
1652017-06-25T20:16:08  *** Yogaqueef has quit IRC
1662017-06-25T21:06:13  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1672017-06-25T21:08:14  *** neel_ has joined #bitcoin-core-dev
1682017-06-25T21:08:15  *** neel has quit IRC
1692017-06-25T21:08:33  *** goofie has joined #bitcoin-core-dev
1702017-06-25T21:10:11  *** jtimon has joined #bitcoin-core-dev
1712017-06-25T21:11:15  <jtimon> sipa: continuing here instead of the PR, I'm just curious about your thoughts
1722017-06-25T21:11:58  <jtimon> I see what you are saying, you mean moving part of primitives/transaction.h to consensus/tx_verify or similar, I don't care much about it either way
1732017-06-25T21:12:27  <jtimon> the libconsensus package (which is the encapsulation I care about the most) will have it either way
1742017-06-25T21:15:50  *** Chris_Stewart_5 has quit IRC
1752017-06-25T21:16:34  <jtimon> although data structures don't need to depend on consensus validation, consensus validation does depend on consensus data structures. Both primitives/transaction.h and primitives/block.h are already in LIBBITCOIN_CONSENSUS unlike consensus/tx_verify
1762017-06-25T21:18:13  <jtimon> well, actually I didn't had any question left...
1772017-06-25T21:19:17  <jtimon> I guess I'm just curious of what BlueMatt plans to put on LIBBITCOIN_CONSENSUS, I hope not validation.o and all its dependencies
1782017-06-25T21:20:37  <sipa> jtimon: my thoughts are that serialization code shouldn't need to depend on consensus logic (which includes resource limits and weight calculation)... for example spv wallet code does not need a dependendy on anything consensus related, but it does need to be able to serialize/deserialize transactions
1792017-06-25T21:21:05  <sipa> so i see primitives/* as a basic dependency for everything, while consensus/* is only needed for validation-related things
1802017-06-25T21:21:35  <jtimon> ok, but you will still depend on the LIBBITCOIN_CONSENSUS package if you need anything from primitives
1812017-06-25T21:21:51  <sipa> no, you shouldn't
1822017-06-25T21:22:01  <jtimon> I guess we could do a primitives package on the makefile
1832017-06-25T21:22:09  <sipa> right
1842017-06-25T21:22:11  <jtimon> well, it's the way it is now
1852017-06-25T21:22:23  <sipa> i don't really care about how the package layout is now
1862017-06-25T21:22:33  <sipa> more about what inherent dependencies exist within the code
1872017-06-25T21:23:58  <jtimon> I personally don't have a problem with anything wallet depending on the consensus package tough, pretty much the contrary, I wish more wallets depended on it
1882017-06-25T21:25:07  <sipa> sure, but a hardware wallet glue utility shouldn't need more than just primitives
1892017-06-25T21:25:22  <sipa> it seems unnecessary to have serialization code depend on consensus
1902017-06-25T21:26:30  <jtimon> right, what I've thought more about iw what I would like LIBBITCOIN_CONSENSUS to have in total in the future, but separating some smaller packages shouldn't conflict with that
1912017-06-25T21:26:51  <jtimon> primitiveslib ?
1922017-06-25T21:27:09  <jtimon> oh, sorry, you mean internally
1932017-06-25T21:28:06  <jtimon> yeah, sure, more encapsulation than what I thought I needed can't hurt
1942017-06-25T21:30:30  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1952017-06-25T21:30:45  <sipa> or the primitives/* code can be compiled into multiple packages even, including consensus - i don't really care
1962017-06-25T21:43:51  *** Dyaheon has quit IRC
1972017-06-25T21:43:52  *** jtimon has quit IRC
1982017-06-25T21:45:14  *** Dyaheon has joined #bitcoin-core-dev
1992017-06-25T21:46:28  *** jamesob_ has joined #bitcoin-core-dev
2002017-06-25T21:47:01  *** jamesob has quit IRC
2012017-06-25T21:56:42  *** jamesob has joined #bitcoin-core-dev
2022017-06-25T22:00:14  *** jamesob_ has quit IRC
2032017-06-25T22:07:38  *** riemann has quit IRC
2042017-06-25T22:08:41  *** btcdrak has joined #bitcoin-core-dev
2052017-06-25T22:26:45  *** johnwang412 has quit IRC
2062017-06-25T22:58:15  *** chjj has joined #bitcoin-core-dev
2072017-06-25T23:00:05  *** BobBarker has left #bitcoin-core-dev
2082017-06-25T23:19:13  *** vicenteH` has quit IRC
2092017-06-25T23:26:26  *** chjj has quit IRC
2102017-06-25T23:27:01  *** chjj has joined #bitcoin-core-dev
2112017-06-25T23:58:20  *** chjj has quit IRC
2122017-06-25T23:59:12  *** chjj has joined #bitcoin-core-dev