12017-07-26T00:02:07  *** J-wolf has joined #bitcoin-core-dev
  22017-07-26T00:04:22  *** J-wolf has quit IRC
  32017-07-26T00:07:10  *** BashCo has joined #bitcoin-core-dev
  42017-07-26T00:07:30  *** J-wolf has joined #bitcoin-core-dev
  52017-07-26T00:08:43  *** promag has quit IRC
  62017-07-26T00:09:37  *** Chris_Stewart_5 has quit IRC
  72017-07-26T00:10:04  *** J-wolf_ has joined #bitcoin-core-dev
  82017-07-26T00:10:17  *** J-wolf has quit IRC
  92017-07-26T00:12:30  *** J-wolf_ has quit IRC
 102017-07-26T00:18:24  *** J-wolf has joined #bitcoin-core-dev
 112017-07-26T00:20:03  *** BashCo has quit IRC
 122017-07-26T00:20:35  *** Dyaheon has quit IRC
 132017-07-26T00:20:43  *** BashCo has joined #bitcoin-core-dev
 142017-07-26T00:21:18  *** J-wolf has quit IRC
 152017-07-26T00:24:08  *** J-wolf has joined #bitcoin-core-dev
 162017-07-26T00:24:22  *** Dyaheon has joined #bitcoin-core-dev
 172017-07-26T00:24:57  *** BashCo has quit IRC
 182017-07-26T00:26:41  *** J-wolf has quit IRC
 192017-07-26T00:27:07  *** J-wolf has joined #bitcoin-core-dev
 202017-07-26T00:28:58  *** miknotauro has joined #bitcoin-core-dev
 212017-07-26T00:29:05  *** J-wolf has quit IRC
 222017-07-26T00:29:52  *** J-wolf has joined #bitcoin-core-dev
 232017-07-26T00:32:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 242017-07-26T00:32:11  *** J-wolf has quit IRC
 252017-07-26T00:35:27  *** J-wolf has joined #bitcoin-core-dev
 262017-07-26T00:36:35  *** chjj has quit IRC
 272017-07-26T00:37:49  *** J-wolf has quit IRC
 282017-07-26T00:37:55  *** J-wolf_ has joined #bitcoin-core-dev
 292017-07-26T00:42:09  *** J-wolf_ has quit IRC
 302017-07-26T00:49:35  *** Chris_Stewart_5 has quit IRC
 312017-07-26T00:51:47  *** baldur has quit IRC
 322017-07-26T00:52:13  *** baldur has joined #bitcoin-core-dev
 332017-07-26T00:59:20  *** Ylbam has quit IRC
 342017-07-26T01:08:51  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 352017-07-26T01:17:10  *** rjak has left #bitcoin-core-dev
 362017-07-26T01:50:21  *** Aaronvan_ has quit IRC
 372017-07-26T02:14:52  *** Chris_Stewart_5 has quit IRC
 382017-07-26T02:17:52  *** cryptapus has joined #bitcoin-core-dev
 392017-07-26T02:17:52  *** cryptapus has joined #bitcoin-core-dev
 402017-07-26T02:19:23  *** aj_ has joined #bitcoin-core-dev
 412017-07-26T02:19:32  *** cryptapus_afk has quit IRC
 422017-07-26T02:19:33  *** bitbee has quit IRC
 432017-07-26T02:19:33  *** aj has quit IRC
 442017-07-26T02:20:08  *** bitbee has joined #bitcoin-core-dev
 452017-07-26T02:22:17  *** spinza has quit IRC
 462017-07-26T02:30:46  <gmaxwell> Can someone remind me why we have a setting for turning on and off the standardness of bare multisig? it has no tests but seems kind of pointless to me..
 472017-07-26T02:36:23  *** spinza has joined #bitcoin-core-dev
 482017-07-26T02:45:25  *** goatpig has quit IRC
 492017-07-26T03:05:50  *** treebeardd has joined #bitcoin-core-dev
 502017-07-26T03:15:13  *** jeep-ss has quit IRC
 512017-07-26T03:19:35  *** KevinPan has joined #bitcoin-core-dev
 522017-07-26T03:28:42  *** EagleTM has joined #bitcoin-core-dev
 532017-07-26T03:29:25  *** dabura667 has joined #bitcoin-core-dev
 542017-07-26T03:29:29  *** Eagle[TM] has quit IRC
 552017-07-26T03:31:12  *** justan0theruser has joined #bitcoin-core-dev
 562017-07-26T03:31:33  *** justanotheruser has quit IRC
 572017-07-26T03:32:33  *** arubi has quit IRC
 582017-07-26T03:33:26  *** arubi has joined #bitcoin-core-dev
 592017-07-26T03:35:37  *** justan0theruser has quit IRC
 602017-07-26T03:36:13  *** justanotheruser has joined #bitcoin-core-dev
 612017-07-26T03:41:05  *** KevinPan has quit IRC
 622017-07-26T03:43:03  *** treebeardd has quit IRC
 632017-07-26T03:43:49  *** jamesob has joined #bitcoin-core-dev
 642017-07-26T04:02:02  *** Dyaheon has quit IRC
 652017-07-26T04:05:10  *** Dyaheon has joined #bitcoin-core-dev
 662017-07-26T04:13:30  <jnewbery> 
 672017-07-26T04:13:55  <sipa> 
 682017-07-26T04:19:33  <jnewbery> gmaxwell : can you explain the tsan issue? The new keypool-rescan test checks that bitcoind will exit if the keypool drops below critical. bitcoind will also print to stderr if that happens. Without #10703, any output in stderr results in test failure
 692017-07-26T04:19:35  <gribble> https://github.com/bitcoin/bitcoin/issues/10703 | [tests] Allow tests to pass when stderr is non-empty by jnewbery · Pull Request #10703 · bitcoin/bitcoin · GitHub
 702017-07-26T04:20:02  <jnewbery> I'll work on it tomorrow to make it more targeted
 712017-07-26T04:22:28  *** nelruk has joined #bitcoin-core-dev
 722017-07-26T04:23:17  <sipa> jnewbery: tsan prints violations to stderr
 732017-07-26T04:25:06  <sipa> i assume it's related to that; i haven't followed the discussion
 742017-07-26T04:25:55  *** deep-book-gk_ has joined #bitcoin-core-dev
 752017-07-26T04:27:22  *** JackH has quit IRC
 762017-07-26T04:30:32  *** deep-book-gk_ has left #bitcoin-core-dev
 772017-07-26T04:33:02  <luke-jr> gmaxwell: IIRC last time there was an effort to make it just policy-rejected always, some people didn't agree
 782017-07-26T04:34:51  *** J-wolf has joined #bitcoin-core-dev
 792017-07-26T04:36:04  <gmaxwell> jnewbery: tsan and other dynamic analysis instrumention throws errors to stderr, so if we want to continue to use them for testing we can't just have their errors get eaten.
 802017-07-26T04:36:39  <gmaxwell> jnewbery: for tests that are supposted to throw errors we sould probably actually test for that, rather than generally ignore stderr. I think.
 812017-07-26T04:49:42  *** nelruk has quit IRC
 822017-07-26T04:55:42  *** J-wolf has quit IRC
 832017-07-26T04:57:59  *** J-wolf has joined #bitcoin-core-dev
 842017-07-26T05:05:32  *** J-wolf has quit IRC
 852017-07-26T05:28:40  *** btcdrak has quit IRC
 862017-07-26T05:39:19  <bitcoin-git> [bitcoin] DevlinShepherd opened pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
 872017-07-26T05:40:07  <bitcoin-git> [bitcoin] sipa closed pull request #10928: [bitcoin] Nits for README description (master...patch-1) https://github.com/bitcoin/bitcoin/pull/10928
 882017-07-26T05:41:32  *** btcdrak has joined #bitcoin-core-dev
 892017-07-26T05:41:53  *** miknotauro has quit IRC
 902017-07-26T05:49:37  <wumpus> gmaxwell: seems to me too that if bitcoind is supposed to print to stderr, it should specifically check for that, instead of a general "succeeded with warnings"
 912017-07-26T05:58:23  <wumpus> BlueMatt: https://github.com/bitcoin/bitcoin/pull/10619#pullrequestreview-52181600   which automated warning?
 922017-07-26T06:00:39  <wumpus> I also guess if that was the case, it'd need an assertion at *all* callsites of chainactive.tip, in which case why not check in the function itself?
 932017-07-26T06:00:55  <wumpus> I don't see the point to randomly peppering around some assertions
 942017-07-26T06:01:13  *** d_t has joined #bitcoin-core-dev
 952017-07-26T06:03:10  <wumpus> if there's an automated warning I'd like to know why it triggers just there
 962017-07-26T06:03:20  <wumpus> not just add assertions and pray
 972017-07-26T06:12:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8537187d4213...f29d5dbd04da
 982017-07-26T06:12:25  <bitcoin-git> bitcoin/master 0be03c7 Brian McMichael: Qt: Use _putenv_s instead of setenv on Windows builds
 992017-07-26T06:12:26  <bitcoin-git> bitcoin/master f29d5db Wladimir J. van der Laan: Merge #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds...
1002017-07-26T06:13:02  <bitcoin-git> [bitcoin] laanwj closed pull request #10899: [test] Qt: Use _putenv_s instead of setenv on Windows builds (master...testfix) https://github.com/bitcoin/bitcoin/pull/10899
1012017-07-26T06:15:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f29d5dbd04da...b995a374f727
1022017-07-26T06:15:41  <bitcoin-git> bitcoin/master a56f8b0 Matt Corallo: Add missing lock in CScheduler::AreThreadsServicingQueue()...
1032017-07-26T06:15:41  <bitcoin-git> bitcoin/master b995a37 Wladimir J. van der Laan: Merge #10914: Add missing lock in CScheduler::AreThreadsServicingQueue()...
1042017-07-26T06:15:58  *** justanotheruser has quit IRC
1052017-07-26T06:16:09  <bitcoin-git> [bitcoin] laanwj closed pull request #10914: Add missing lock in CScheduler::AreThreadsServicingQueue() (master...2017-04-fix-missing-scheduler-lock) https://github.com/bitcoin/bitcoin/pull/10914
1062017-07-26T06:45:27  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b995a374f727...78f307b66428
1072017-07-26T06:45:28  <bitcoin-git> bitcoin/master 9f8a46f Ryan Havar: Properly document target_confirmations in listsinceblock
1082017-07-26T06:45:28  <bitcoin-git> bitcoin/master 78f307b Wladimir J. van der Laan: Merge #10655: Properly document target_confirmations in listsinceblock...
1092017-07-26T06:45:51  <bitcoin-git> [bitcoin] laanwj closed pull request #10655: Properly document target_confirmations in listsinceblock (master...listsinceblock) https://github.com/bitcoin/bitcoin/pull/10655
1102017-07-26T06:48:41  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/78f307b66428...04d395e8327d
1112017-07-26T06:48:41  <bitcoin-git> bitcoin/master 095b917 Gregory Maxwell: Avoid using sizes on non-fixed-width types to derive protocol constants....
1122017-07-26T06:48:42  <bitcoin-git> bitcoin/master 04d395e Wladimir J. van der Laan: Merge #10854: Avoid using sizes on non-fixed-width types to derive protocol constants....
1132017-07-26T06:49:16  <bitcoin-git> [bitcoin] laanwj closed pull request #10854: Avoid using sizes on non-fixed-width types to derive protocol constants. (master...rbf-numlimit-fix) https://github.com/bitcoin/bitcoin/pull/10854
1142017-07-26T07:09:35  *** Deadhand has quit IRC
1152017-07-26T07:10:17  *** dabura667 has quit IRC
1162017-07-26T07:11:35  *** coredump_ has joined #bitcoin-core-dev
1172017-07-26T07:11:36  *** Deadhand has joined #bitcoin-core-dev
1182017-07-26T07:13:23  <jnewbery> Redone #10882 with stderr capture/checking done within the individual test. Ready for review. (sipa, gmaxwell)
1192017-07-26T07:13:25  <gribble> https://github.com/bitcoin/bitcoin/issues/10882 | Keypool topup by jnewbery · Pull Request #10882 · bitcoin/bitcoin · GitHub
1202017-07-26T07:14:08  <jnewbery> MarcoFalke: Not urgent for 0.15, but I'd love some review of #10711
1212017-07-26T07:14:09  <gribble> https://github.com/bitcoin/bitcoin/issues/10711 | [tests] Introduce TestNode by jnewbery · Pull Request #10711 · bitcoin/bitcoin · GitHub
1222017-07-26T07:19:43  <sipa> jnewbery: thanks!
1232017-07-26T07:32:02  *** d9b4bef9 has quit IRC
1242017-07-26T07:33:08  *** d9b4bef9 has joined #bitcoin-core-dev
1252017-07-26T07:34:04  <luke-jr> FWIW, master upgraded my testnet3 UTXO set and then crashed syncing due to LevelDB giving $6 = "Corruption: not an sstable (bad magic number)"
1262017-07-26T07:34:26  <luke-jr> leveldb LOG file hasn't changed in a month
1272017-07-26T07:43:41  *** coredump_ has quit IRC
1282017-07-26T07:44:12  <luke-jr> https://github.com/bitcoin/bitcoin/pull/10457#pullrequestreview-52270582 wumpus: what do you mean?
1292017-07-26T07:46:02  *** tripleslash has quit IRC
1302017-07-26T07:46:51  *** jamesob has quit IRC
1312017-07-26T07:49:05  *** tripleslash has joined #bitcoin-core-dev
1322017-07-26T07:53:40  *** d_t has quit IRC
1332017-07-26T07:57:04  *** d_t has joined #bitcoin-core-dev
1342017-07-26T07:57:14  *** a_meteor_ has joined #bitcoin-core-dev
1352017-07-26T07:59:39  *** riemann has joined #bitcoin-core-dev
1362017-07-26T08:02:18  *** JackH has joined #bitcoin-core-dev
1372017-07-26T08:05:46  <luke-jr> jonasschnelli: btw, I think prune-to might be a good novice contributor thing, so might make sense to let it sit as an issue :p
1382017-07-26T08:06:08  <luke-jr> (eg, manual pruning and chainstate obfuscation seemed to work out nicely)
1392017-07-26T08:21:51  <wumpus> luke-jr: I mean: bring back the typedef instead of declaring a function type in a function argument
1402017-07-26T08:22:08  <wumpus> I dont' understand why the typedef is being removed
1412017-07-26T08:22:45  *** timothy has joined #bitcoin-core-dev
1422017-07-26T08:23:00  *** Guyver2 has joined #bitcoin-core-dev
1432017-07-26T08:25:04  <wumpus> or am I alone in finding "CDBEnv::VerifyResult CDBEnv::Verify(const std::string& strFile, bool (*recoverFunc)(const std::string& strFile))" terribly hard to read?
1442017-07-26T08:26:48  <sipa> no.
1452017-07-26T08:29:08  <wumpus> and as for not being sure what the state of that PR is, I read the other discussion and people don't seem to agree wheter it's considered an improvement or not
1462017-07-26T08:29:36  <wumpus> in which case it'd be better to close it instead of review it further
1472017-07-26T08:30:11  <bitcoin-git> [bitcoin] ryanofsky opened pull request #10931: Fix misleading "Method not found" multiwallet errors (master...pr/multierr) https://github.com/bitcoin/bitcoin/pull/10931
1482017-07-26T08:33:21  *** vicenteH has joined #bitcoin-core-dev
1492017-07-26T08:35:34  *** Murch has joined #bitcoin-core-dev
1502017-07-26T08:37:58  <wumpus> jnewbery: yes, testnode is nice
1512017-07-26T08:39:32  * midnightmagic stabs
1522017-07-26T08:39:47  *** Murch has quit IRC
1532017-07-26T08:40:38  *** Yogaqueef has joined #bitcoin-core-dev
1542017-07-26T08:41:09  <midnightmagic> argh, sorry, was behind on scrollback and that had nothing to do with anything current.
1552017-07-26T08:41:27  <wumpus> I already wondered who and why you were stabbing :)
1562017-07-26T08:42:53  <wumpus> jnewbery: thanks for adding explicit check for stderr, I think this is much cleaner
1572017-07-26T09:01:18  <luke-jr> wumpus: ah, got the before/after reversed
1582017-07-26T09:04:39  *** AaronvanW has joined #bitcoin-core-dev
1592017-07-26T09:06:10  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/04d395e8327d...5c003cb1afcb
1602017-07-26T09:06:10  <bitcoin-git> bitcoin/master 4a7a4ff Marko Bencun: developer-notes: add reference to snake_case and PascalCase...
1612017-07-26T09:06:11  <bitcoin-git> bitcoin/master 5c003cb Wladimir J. van der Laan: Merge #10917: developer-notes: add reference to snake_case and PascalCase...
1622017-07-26T09:06:44  <bitcoin-git> [bitcoin] laanwj closed pull request #10917: developer-notes: add reference to snake_case and PascalCase (master...pascalcase) https://github.com/bitcoin/bitcoin/pull/10917
1632017-07-26T09:07:38  * luke-jr suggests merging https://github.com/bitcoin/bitcoin/pull/10824
1642017-07-26T09:08:09  *** Aaronvan_ has joined #bitcoin-core-dev
1652017-07-26T09:08:10  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10932: Create models.js (master...patch-5) https://github.com/bitcoin/bitcoin/pull/10932
1662017-07-26T09:08:30  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933
1672017-07-26T09:08:55  <bitcoin-git> [bitcoin] fanquake closed pull request #10933: Create web3.js (master...patch-4) https://github.com/bitcoin/bitcoin/pull/10933
1682017-07-26T09:09:20  *** Guyver2 has quit IRC
1692017-07-26T09:09:49  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934
1702017-07-26T09:10:15  <bitcoin-git> [bitcoin] fanquake closed pull request #10934: Create transaction.js (master...patch-6) https://github.com/bitcoin/bitcoin/pull/10934
1712017-07-26T09:10:54  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935
1722017-07-26T09:10:57  *** AaronvanW has quit IRC
1732017-07-26T09:11:10  <bitcoin-git> [bitcoin] fanquake closed pull request #10935: Create index.js (master...patch-7) https://github.com/bitcoin/bitcoin/pull/10935
1742017-07-26T09:16:12  *** fanquake has joined #bitcoin-core-dev
1752017-07-26T09:16:13  <wumpus> luke-jr: agree
1762017-07-26T09:16:13  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936
1772017-07-26T09:16:14  <bitcoin-git> [bitcoin] fanquake closed pull request #10936: Create balance.js (master...patch-8) https://github.com/bitcoin/bitcoin/pull/10936
1782017-07-26T09:16:14  <bitcoin-git> [bitcoin] laanwj closed pull request #10824: Avoid unnecessary work in SetNetworkActive (master...2017-07-set-network-active) https://github.com/bitcoin/bitcoin/pull/10824
1792017-07-26T09:16:14  <fanquake> sipa / wumpus want to block @https://github.com/Cr4shOv3rrid3
1802017-07-26T09:16:15  <wumpus> fanquake: good idea
1812017-07-26T09:16:15  <bitcoin-git> [bitcoin] Cr4shOv3rrid3 opened pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937
1822017-07-26T09:16:15  <sipa> i was about to, if he opens one more
1832017-07-26T09:16:15  <sipa> Done.
1842017-07-26T09:16:15  <bitcoin-git> [bitcoin] fanquake closed pull request #10937: Create web3.js (master...patch-9) https://github.com/bitcoin/bitcoin/pull/10937
1852017-07-26T09:16:15  <wumpus> done at the same time lol
1862017-07-26T09:16:15  <fanquake>  /race
1872017-07-26T09:16:15  <wumpus> oh we blocked a different one actually
1882017-07-26T09:16:15  <luke-jr> hopefully it's not a toggle
1892017-07-26T09:16:15  <wumpus> Cr4sh0verr1d3 versus Cr4shOv3rrid3
1902017-07-26T09:16:15  <sipa> wumpus: you got the right one
1912017-07-26T09:16:35  *** hsmiths has quit IRC
1922017-07-26T09:22:28  *** riemann has quit IRC
1932017-07-26T09:22:28  *** str4d has joined #bitcoin-core-dev
1942017-07-26T09:23:52  *** Guest75836 has quit IRC
1952017-07-26T09:26:46  *** Guest71980 has joined #bitcoin-core-dev
1962017-07-26T09:27:06  *** riemann has joined #bitcoin-core-dev
1972017-07-26T09:43:52  *** unholymachine has quit IRC
1982017-07-26T09:45:58  *** unholymachine has joined #bitcoin-core-dev
1992017-07-26T09:57:36  *** SopaXorzTaker has quit IRC
2002017-07-26T10:02:55  *** aj_ is now known as aj
2012017-07-26T10:06:46  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dd6a2be4188...5c8eb7916de7
2022017-07-26T10:06:46  <bitcoin-git> bitcoin/master 065039d practicalswift: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
2032017-07-26T10:06:47  <bitcoin-git> bitcoin/master 5c8eb79 Wladimir J. van der Laan: Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp...
2042017-07-26T10:07:16  <bitcoin-git> [bitcoin] laanwj closed pull request #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp (master...arrays-are-not-pointers) https://github.com/bitcoin/bitcoin/pull/10912
2052017-07-26T10:19:03  *** Joseph__ has joined #bitcoin-core-dev
2062017-07-26T10:19:40  *** Joseph__ is now known as NewLiberty
2072017-07-26T10:22:28  *** NewLiberty_ has quit IRC
2082017-07-26T10:34:22  *** JackH has quit IRC
2092017-07-26T10:41:38  *** JackH has joined #bitcoin-core-dev
2102017-07-26T10:43:40  *** str4d has quit IRC
2112017-07-26T10:43:53  *** NewLiberty_ has joined #bitcoin-core-dev
2122017-07-26T10:47:17  *** promag has joined #bitcoin-core-dev
2132017-07-26T10:47:19  *** NewLiberty has quit IRC
2142017-07-26T11:11:59  *** hsmiths has joined #bitcoin-core-dev
2152017-07-26T11:20:02  *** d9b4bef9 has quit IRC
2162017-07-26T11:21:07  *** d9b4bef9 has joined #bitcoin-core-dev
2172017-07-26T11:24:40  *** JackH has quit IRC
2182017-07-26T11:29:00  *** Ylbam has joined #bitcoin-core-dev
2192017-07-26T11:32:03  *** JackH has joined #bitcoin-core-dev
2202017-07-26T11:42:56  *** NewLiberty_ has quit IRC
2212017-07-26T11:43:22  *** NewLiberty_ has joined #bitcoin-core-dev
2222017-07-26T11:58:52  *** Dyaheon has quit IRC
2232017-07-26T12:01:44  *** Dyaheon has joined #bitcoin-core-dev
2242017-07-26T12:03:25  *** moctos_ has quit IRC
2252017-07-26T12:03:31  *** moctos_ has joined #bitcoin-core-dev
2262017-07-26T12:10:41  *** moctos_ has quit IRC
2272017-07-26T12:17:38  *** chjj has joined #bitcoin-core-dev
2282017-07-26T12:19:56  *** jeep-ss has joined #bitcoin-core-dev
2292017-07-26T12:23:30  *** moctos_ has joined #bitcoin-core-dev
2302017-07-26T12:27:52  *** Magicking_ has left #bitcoin-core-dev
2312017-07-26T12:28:36  *** promag has quit IRC
2322017-07-26T12:29:53  *** moctos_ has quit IRC
2332017-07-26T12:38:25  *** windsok has quit IRC
2342017-07-26T12:44:17  *** fanquake has quit IRC
2352017-07-26T12:44:55  *** Yogaqueef has quit IRC
2362017-07-26T12:47:14  *** justanotheruser has joined #bitcoin-core-dev
2372017-07-26T12:48:52  *** justanotheruser has quit IRC
2382017-07-26T12:50:09  *** justanotheruser has joined #bitcoin-core-dev
2392017-07-26T12:56:39  *** Aaronvan_ is now known as AaronvanW
2402017-07-26T13:05:34  *** goatpig has joined #bitcoin-core-dev
2412017-07-26T13:07:31  *** windsok has joined #bitcoin-core-dev
2422017-07-26T13:09:11  *** J-wolf has joined #bitcoin-core-dev
2432017-07-26T13:10:56  *** Mac2 has joined #bitcoin-core-dev
2442017-07-26T13:11:42  *** marcoagner has quit IRC
2452017-07-26T13:12:38  *** J-wolf has quit IRC
2462017-07-26T13:14:28  *** jeep-ss has quit IRC
2472017-07-26T13:19:02  *** Guyver2 has joined #bitcoin-core-dev
2482017-07-26T13:24:16  *** marcoagner has joined #bitcoin-core-dev
2492017-07-26T13:26:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
2502017-07-26T13:29:10  *** Aron has joined #bitcoin-core-dev
2512017-07-26T13:41:22  *** EagleTM has quit IRC
2522017-07-26T13:47:33  *** Aron has quit IRC
2532017-07-26T13:55:27  *** JackH has quit IRC
2542017-07-26T13:57:41  *** EagleTM has joined #bitcoin-core-dev
2552017-07-26T14:02:49  *** a_meteor_ has quit IRC
2562017-07-26T14:05:14  *** timothy has quit IRC
2572017-07-26T14:05:27  *** timothy has joined #bitcoin-core-dev
2582017-07-26T14:05:52  *** Dyaheon has quit IRC
2592017-07-26T14:06:51  *** Dyaheon has joined #bitcoin-core-dev
2602017-07-26T14:17:35  *** JackH has joined #bitcoin-core-dev
2612017-07-26T14:22:33  *** timothy has quit IRC
2622017-07-26T14:23:57  *** timothy has joined #bitcoin-core-dev
2632017-07-26T14:30:52  *** Susan2 has joined #bitcoin-core-dev
2642017-07-26T14:38:34  *** Susan2 has quit IRC
2652017-07-26T14:41:49  *** JackH has quit IRC
2662017-07-26T14:46:50  *** SopaXorzTaker has joined #bitcoin-core-dev
2672017-07-26T14:49:05  *** tripleslash has quit IRC
2682017-07-26T14:56:40  *** JackH has joined #bitcoin-core-dev
2692017-07-26T14:58:32  *** riemann has quit IRC
2702017-07-26T15:00:31  <BlueMatt> wumpus: I was referring to https://github.com/bitcoin/bitcoin/pull/10619#issuecomment-310257582
2712017-07-26T15:00:47  *** tripleslash has joined #bitcoin-core-dev
2722017-07-26T15:01:19  *** moctos_ has joined #bitcoin-core-dev
2732017-07-26T15:03:32  *** JackH has quit IRC
2742017-07-26T15:07:22  *** Giszmo has quit IRC
2752017-07-26T15:08:10  <gmaxwell> wumpus: I'm glad you commented on the alarmist titles.
2762017-07-26T15:09:11  <gmaxwell> wumpus: someone should also point out to practicalswift that these titles will confuse further troubleshooting, e.g. someone encounters a real crash, then sees commits with titles like "avoid null dereference" they may think "oh thats been fixed" and not report it.
2772017-07-26T15:09:16  *** JackH has joined #bitcoin-core-dev
2782017-07-26T15:09:38  <gmaxwell> "Appease static analysis tool by adding an assert in X" is a fine title.
2792017-07-26T15:14:41  *** JackH has quit IRC
2802017-07-26T15:18:51  *** EagleTM has quit IRC
2812017-07-26T15:22:23  *** Murch has joined #bitcoin-core-dev
2822017-07-26T15:23:10  *** goatpig has quit IRC
2832017-07-26T15:23:55  *** EagleTM has joined #bitcoin-core-dev
2842017-07-26T15:26:09  <morcos> If the next PR literally says "X" in the title, you are responsible
2852017-07-26T15:29:26  *** jannes has joined #bitcoin-core-dev
2862017-07-26T15:31:19  <gmaxwell> hahah
2872017-07-26T15:32:07  *** Guyver2 has quit IRC
2882017-07-26T15:33:09  *** goatpig has joined #bitcoin-core-dev
2892017-07-26T15:57:19  *** a_meteorite has joined #bitcoin-core-dev
2902017-07-26T16:01:53  *** EagleTM has quit IRC
2912017-07-26T16:03:21  *** owowo has quit IRC
2922017-07-26T16:05:48  *** EagleTM has joined #bitcoin-core-dev
2932017-07-26T16:08:37  *** owowo has joined #bitcoin-core-dev
2942017-07-26T16:10:10  *** Dyaheon has quit IRC
2952017-07-26T16:13:30  *** Dyaheon has joined #bitcoin-core-dev
2962017-07-26T16:19:31  *** a_meteorite has quit IRC
2972017-07-26T16:19:41  *** jtimon has joined #bitcoin-core-dev
2982017-07-26T16:21:24  *** a_meteorite has joined #bitcoin-core-dev
2992017-07-26T16:22:38  *** Dizzle has joined #bitcoin-core-dev
3002017-07-26T16:25:33  <jtimon> can I build bitcoind but only bitcoind without bitcoin-cli, bitcoin-tx, libbitcoinconsensus.la, test/test_bitcoin_fuzzy, bench/bench_bitcoin and test/test_bitcoin ?
3012017-07-26T16:26:20  <gmaxwell> make bitcoind
3022017-07-26T16:26:31  <gmaxwell> (or make src/bitcoind )
3032017-07-26T16:28:11  <jtimon> oops, right, I forgot the src/, thanks
3042017-07-26T16:31:53  *** jamesob has joined #bitcoin-core-dev
3052017-07-26T17:05:35  *** timothy has quit IRC
3062017-07-26T17:08:52  *** laurentmt has joined #bitcoin-core-dev
3072017-07-26T17:09:51  *** laurentmt has quit IRC
3082017-07-26T17:10:07  *** J-wolf has joined #bitcoin-core-dev
3092017-07-26T17:17:37  *** J-wolf has quit IRC
3102017-07-26T17:19:10  *** snq has joined #bitcoin-core-dev
3112017-07-26T17:25:38  *** a_meteorite has quit IRC
3122017-07-26T17:31:59  *** JackH has joined #bitcoin-core-dev
3132017-07-26T17:33:42  *** jannes has quit IRC
3142017-07-26T17:35:05  *** vicenteH has quit IRC
3152017-07-26T17:37:43  *** JackH has quit IRC
3162017-07-26T17:39:31  *** J-wolf has joined #bitcoin-core-dev
3172017-07-26T17:40:18  *** JackH has joined #bitcoin-core-dev
3182017-07-26T17:43:16  <bitcoin-git> [bitcoin] laanwj reopened pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
3192017-07-26T17:44:03  *** J-wolf has quit IRC
3202017-07-26T17:46:52  *** JackH has quit IRC
3212017-07-26T17:49:25  *** NewLiberty_ has quit IRC
3222017-07-26T17:50:58  *** J-wolf has joined #bitcoin-core-dev
3232017-07-26T17:57:03  *** J-wolf has quit IRC
3242017-07-26T17:58:25  *** promag has joined #bitcoin-core-dev
3252017-07-26T17:59:01  *** JackH has joined #bitcoin-core-dev
3262017-07-26T18:02:02  *** Chris_Stewart_5 has quit IRC
3272017-07-26T18:04:05  *** JackH has quit IRC
3282017-07-26T18:04:23  *** JackH has joined #bitcoin-core-dev
3292017-07-26T18:08:23  *** JackH_ has joined #bitcoin-core-dev
3302017-07-26T18:09:58  *** JackH has quit IRC
3312017-07-26T18:10:35  *** Aaronvan_ has joined #bitcoin-core-dev
3322017-07-26T18:11:10  *** AaronvanW has quit IRC
3332017-07-26T18:14:38  *** elias19r has joined #bitcoin-core-dev
3342017-07-26T18:16:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3352017-07-26T18:18:01  *** Dyaheon has quit IRC
3362017-07-26T18:19:10  *** Dyaheon has joined #bitcoin-core-dev
3372017-07-26T18:25:23  *** NewLiberty has joined #bitcoin-core-dev
3382017-07-26T18:34:53  *** promag has quit IRC
3392017-07-26T18:45:59  *** moctos_ has quit IRC
3402017-07-26T19:01:00  *** NewLiberty_ has joined #bitcoin-core-dev
3412017-07-26T19:04:33  *** NewLiberty has quit IRC
3422017-07-26T19:17:00  *** SopaXorzTaker has quit IRC
3432017-07-26T19:18:41  <gmaxwell> Interesting observation from the now-public infomation about the mtgox thefts.  Non-HD walletness of MTGOX partially protected it from losses.
3442017-07-26T19:20:14  <gmaxwell> They had a wallet.dat stolen in 2011... and the theif was limited to steal coins that landed on the addresses in it and the 100 after it.
3452017-07-26T19:21:34  <morcos> Did you mean to say not having a bag of 10,000 keys protected them from losses
3462017-07-26T19:21:38  * morcos runs for cover
3472017-07-26T19:22:14  <gmaxwell> morcos: Yes. (though the keypool size is irrelevant for this now, because they're all determinstically derrived now)
3482017-07-26T19:22:45  <gmaxwell> Not using HD protected them, though -- it's pretty remarkable how little it protected them.
3492017-07-26T19:22:49  <achow101> gmaxwell: where is this info?
3502017-07-26T19:22:52  *** Chris_Stewart_5 has quit IRC
3512017-07-26T19:23:29  *** jtimon has quit IRC
3522017-07-26T19:23:30  <gmaxwell> http://blog.wizsec.jp/2017/07/breaking-open-mtgox-1.html
3532017-07-26T19:24:46  <kakobrekla> hd was not a thing back then
3542017-07-26T19:24:56  <kakobrekla> maybe wallets werent even encrypted
3552017-07-26T19:25:01  <kakobrekla> i forgot when that came to be.
3562017-07-26T19:25:47  <gmaxwell> ...
3572017-07-26T19:27:55  <eck> wallet.dat file was stolen sept 2011, the same month encryption was added to bitcoin core (0.4.0 released sep 23, 2011)
3582017-07-26T19:29:10  <grubles> https://bitcoin.org/en/release/v0.4.0
3592017-07-26T19:29:23  <gmaxwell> kakobrekla: you've missed my point.
3602017-07-26T19:29:32  <kakobrekla> i miss all the points :(
3612017-07-26T19:31:07  <grubles> the point was they only had access to the keys generated in that copy of the wallet.dat, and none generated afterwards
3622017-07-26T19:31:59  *** Joseph__ has joined #bitcoin-core-dev
3632017-07-26T19:32:29  <kakobrekla> aha, if only the keypool size would be smaller...
3642017-07-26T19:33:03  <gmaxwell> kakobrekla: it no longer has anything to do with the keypool. Use of hdwallets means that there is no more leakage resistance.
3652017-07-26T19:33:20  <kakobrekla> sure
3662017-07-26T19:33:29  <gmaxwell> There has been a long discussion since 2011 if the 'unstealing' property is meaningfully protective or not. There have been some other examples where leakage resistance was useful, but this would be the largest yet.
3672017-07-26T19:34:14  <kakobrekla> so you stance on this is that hd wallets are bad for your health?
3682017-07-26T19:34:18  <kakobrekla> your*
3692017-07-26T19:34:29  <gmaxwell> No, but there is a tradeoff.
3702017-07-26T19:34:33  <kakobrekla> aha
3712017-07-26T19:34:44  <gmaxwell> also, I introduced these things fwiw.
3722017-07-26T19:34:51  *** NewLiberty_ has quit IRC
3732017-07-26T19:35:44  <gmaxwell> personally I think the ideal functionality would be to rotate HD master keys on a timed basis, e.g. once a year, and only switch to a new one after a backup has happened.
3742017-07-26T19:36:19  <gmaxwell> though I think patterns like mtgox show that lazy rotation might not have been much more protective than no rotation at all... they still lost most of their coins even with the 100 key keypool.
3752017-07-26T19:37:21  <phantomcircuit> gmaxwell, exchange users insist on reusing very old addresses
3762017-07-26T19:37:34  <phantomcircuit> even i they're not displayed anywhere on the site
3772017-07-26T19:37:41  <phantomcircuit> it's quite a problem actually
3782017-07-26T19:38:48  <gmaxwell> phantomcircuit: yea.... I wondered if we should have added an expiration time to bech32 addresses; to make that a bit harder.
3792017-07-26T19:38:55  <gmaxwell> but it's such a mess.
3802017-07-26T19:39:45  <phantomcircuit> gmaxwell, the easiest is for exchanges to charge a fee that increases overtime or older addresses
3812017-07-26T19:40:00  <phantomcircuit> or at least make a big deal out of retiring addresses and then making it annoying to use old ones
3822017-07-26T19:47:23  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3832017-07-26T19:55:16  <kakobrekla> i just checked my db, 4.6% of deposits were made to previously used address
3842017-07-26T19:59:23  <phantomcircuit> kakobrekla, by volume or number
3852017-07-26T20:01:37  <kakobrekla> just count of deposits
3862017-07-26T20:02:50  *** J-wolf has joined #bitcoin-core-dev
3872017-07-26T20:02:53  *** str4d has joined #bitcoin-core-dev
3882017-07-26T20:02:58  *** NewLiberty_ has joined #bitcoin-core-dev
3892017-07-26T20:05:20  *** chjj has quit IRC
3902017-07-26T20:06:02  *** Joseph__ has quit IRC
3912017-07-26T20:13:58  *** J-wolf has quit IRC
3922017-07-26T20:14:33  *** J-wolf has joined #bitcoin-core-dev
3932017-07-26T20:15:07  *** NewLiberty_ has quit IRC
3942017-07-26T20:15:21  *** volure has joined #bitcoin-core-dev
3952017-07-26T20:17:01  *** J-wolf_ has joined #bitcoin-core-dev
3962017-07-26T20:17:35  *** J-wolf has quit IRC
3972017-07-26T20:21:05  *** Dyaheon has quit IRC
3982017-07-26T20:23:40  *** J-wolf_ has quit IRC
3992017-07-26T20:26:50  *** Dyaheon has joined #bitcoin-core-dev
4002017-07-26T20:27:54  *** vicenteH has joined #bitcoin-core-dev
4012017-07-26T20:42:29  *** jamesob__ has joined #bitcoin-core-dev
4022017-07-26T20:44:47  *** jamesob_ has quit IRC
4032017-07-26T20:48:55  *** chjj has joined #bitcoin-core-dev
4042017-07-26T21:33:46  *** Chris_Stewart_5 has quit IRC
4052017-07-26T21:35:05  *** NewLiberty has joined #bitcoin-core-dev
4062017-07-26T21:36:55  *** chjj has quit IRC
4072017-07-26T21:37:52  *** JackH_ has quit IRC
4082017-07-26T21:42:29  *** BashCo has joined #bitcoin-core-dev
4092017-07-26T21:43:45  *** elias19r has left #bitcoin-core-dev
4102017-07-26T21:49:49  *** chjj has joined #bitcoin-core-dev
4112017-07-26T21:59:18  *** JackH has joined #bitcoin-core-dev
4122017-07-26T22:03:03  *** jeep-ss has joined #bitcoin-core-dev
4132017-07-26T22:06:06  *** felco has quit IRC
4142017-07-26T22:06:17  *** NewLiberty has quit IRC
4152017-07-26T22:06:35  *** felco has joined #bitcoin-core-dev
4162017-07-26T22:08:20  *** Orion3k has joined #bitcoin-core-dev
4172017-07-26T22:08:47  *** felco has joined #bitcoin-core-dev
4182017-07-26T22:09:41  *** praxeology has joined #bitcoin-core-dev
4192017-07-26T22:10:02  *** felco has quit IRC
4202017-07-26T22:12:38  *** felco has joined #bitcoin-core-dev
4212017-07-26T22:28:07  *** altoz has quit IRC
4222017-07-26T22:28:26  *** altoz has joined #bitcoin-core-dev
4232017-07-26T22:30:43  *** Dyaheon has quit IRC
4242017-07-26T22:31:25  *** Dyaheon has joined #bitcoin-core-dev
4252017-07-26T22:37:24  *** floog has quit IRC
4262017-07-26T22:38:55  *** Orion3k has quit IRC
4272017-07-26T22:39:15  *** Asquire has joined #bitcoin-core-dev
4282017-07-26T22:39:20  *** Orion3k has joined #bitcoin-core-dev
4292017-07-26T22:44:16  *** JackH has quit IRC
4302017-07-26T22:52:20  *** volure has quit IRC
4312017-07-26T22:54:26  *** promag has joined #bitcoin-core-dev
4322017-07-26T22:56:20  *** chjj has quit IRC
4332017-07-26T22:57:42  *** Dizzle has quit IRC
4342017-07-26T23:02:10  *** coredump_ has joined #bitcoin-core-dev
4352017-07-26T23:09:19  *** chjj has joined #bitcoin-core-dev
4362017-07-26T23:10:10  <sipa> hi, what did i miss?
4372017-07-26T23:13:52  <Murch> sipa: BTCe blew up, BCC implemented mandatory two-way replay protection
4382017-07-26T23:14:22  <Murch> apparently BTCe owner was involved at least in laundering Mt.Gox heist loot, or perhaps even the culprit
4392017-07-26T23:14:40  <Murch> were you in Tokyo after all?
4402017-07-26T23:14:53  <sipa> i'm in tokyo now
4412017-07-26T23:14:55  <bitcoin-git> [bitcoin] practicalswift opened pull request #10939: Check that -blocknotify command is non-empty before executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939
4422017-07-26T23:15:05  <Murch> ah, I see.
4432017-07-26T23:15:40  *** chjj has quit IRC
4442017-07-26T23:28:25  *** chjj has joined #bitcoin-core-dev
4452017-07-26T23:37:49  *** Chris_Stewart_5 has joined #bitcoin-core-dev
4462017-07-26T23:52:38  *** jtimon has joined #bitcoin-core-dev