12017-07-29T00:01:57 *** snkey has quit IRC
22017-07-29T00:05:30 *** jamesob_ has joined #bitcoin-core-dev
32017-07-29T00:09:50 *** jamesob_ has quit IRC
42017-07-29T00:10:25 *** snkey has joined #bitcoin-core-dev
52017-07-29T00:12:49 *** snq has quit IRC
62017-07-29T00:25:25 <bitcoin-git> [bitcoin] achow101 opened pull request #10952: [wallet] Remove vchDefaultKey and have better first run detection (master...remove-defaultkey) https://github.com/bitcoin/bitcoin/pull/10952
72017-07-29T00:47:36 *** jamesob has quit IRC
82017-07-29T00:51:50 *** nejon has quit IRC
92017-07-29T00:55:47 *** abpa has quit IRC
102017-07-29T01:06:02 *** d9b4bef9 has quit IRC
112017-07-29T01:14:08 *** Deacyded has quit IRC
122017-07-29T01:14:26 *** Deacyded has joined #bitcoin-core-dev
132017-07-29T01:15:11 *** Deacyde has joined #bitcoin-core-dev
142017-07-29T01:16:18 *** nejon has joined #bitcoin-core-dev
152017-07-29T01:36:28 *** justanotheruser has quit IRC
162017-07-29T01:41:00 *** jamesob has joined #bitcoin-core-dev
172017-07-29T01:45:25 *** justanotheruser has joined #bitcoin-core-dev
182017-07-29T01:49:27 *** str4d has quit IRC
192017-07-29T02:01:04 *** Deacydal has joined #bitcoin-core-dev
202017-07-29T02:04:07 *** Deacyde has quit IRC
212017-07-29T02:06:48 *** jamesob_ has joined #bitcoin-core-dev
222017-07-29T02:10:50 *** jamesob_ has quit IRC
232017-07-29T02:13:16 *** Deacydal is now known as Deacyde
242017-07-29T02:16:54 *** snq has joined #bitcoin-core-dev
252017-07-29T02:19:32 *** snkey has quit IRC
262017-07-29T02:33:30 *** deep-book-gk_ has joined #bitcoin-core-dev
272017-07-29T02:34:09 *** deep-book-gk_ has left #bitcoin-core-dev
282017-07-29T02:38:25 *** MeshCollider has joined #bitcoin-core-dev
292017-07-29T02:57:39 *** luke-jr has joined #bitcoin-core-dev
302017-07-29T03:12:15 *** jamesob_ has joined #bitcoin-core-dev
312017-07-29T03:13:37 *** Ylbam has quit IRC
322017-07-29T03:21:07 *** MeshCollider has quit IRC
332017-07-29T03:23:37 *** EagleTM has quit IRC
342017-07-29T03:25:00 *** EagleTM has joined #bitcoin-core-dev
352017-07-29T03:25:23 *** MeshCollider has joined #bitcoin-core-dev
362017-07-29T03:45:38 *** deep-book-gk_ has joined #bitcoin-core-dev
372017-07-29T03:48:16 *** deep-book-gk_ has left #bitcoin-core-dev
382017-07-29T03:53:13 *** jannes has quit IRC
392017-07-29T03:53:35 *** Alina-malina has quit IRC
402017-07-29T03:55:14 *** d9b4bef9 has joined #bitcoin-core-dev
412017-07-29T03:55:35 *** achow101 has quit IRC
422017-07-29T03:59:17 *** MeshCollider has quit IRC
432017-07-29T03:59:25 *** MeshCollider has joined #bitcoin-core-dev
442017-07-29T04:03:19 *** Dyaheon has quit IRC
452017-07-29T04:05:40 *** Dyaheon has joined #bitcoin-core-dev
462017-07-29T04:06:20 *** achow101 has joined #bitcoin-core-dev
472017-07-29T04:07:48 *** jeep-ss has quit IRC
482017-07-29T04:12:42 *** jeep-ss has joined #bitcoin-core-dev
492017-07-29T04:21:03 *** jeep-ss has quit IRC
502017-07-29T04:36:23 *** vicenteH has quit IRC
512017-07-29T04:36:23 *** vicenteH has joined #bitcoin-core-dev
522017-07-29T05:01:52 *** Murch has quit IRC
532017-07-29T05:02:30 *** chjj has joined #bitcoin-core-dev
542017-07-29T05:02:34 *** J-wolf has joined #bitcoin-core-dev
552017-07-29T05:23:21 *** J-wolf has quit IRC
562017-07-29T05:40:55 *** vicenteH` has joined #bitcoin-core-dev
572017-07-29T05:42:37 *** vicenteH has quit IRC
582017-07-29T05:49:54 *** Alina-malina has joined #bitcoin-core-dev
592017-07-29T05:54:17 *** Alina-malina has quit IRC
602017-07-29T05:54:18 *** Alina-malina has joined #bitcoin-core-dev
612017-07-29T05:55:32 *** Alina-malina has quit IRC
622017-07-29T05:55:41 *** Alina-malina_ has joined #bitcoin-core-dev
632017-07-29T06:15:00 *** SopaXorzTaker has quit IRC
642017-07-29T06:21:42 *** Alina-malina_ has quit IRC
652017-07-29T06:21:42 *** Alina-malina_ has joined #bitcoin-core-dev
662017-07-29T06:21:51 *** Alina-malina_ is now known as Alina-malina
672017-07-29T06:30:43 *** jamesob has quit IRC
682017-07-29T06:49:39 *** [b__b] has joined #bitcoin-core-dev
692017-07-29T06:59:00 *** SopaXorzTaker has joined #bitcoin-core-dev
702017-07-29T07:48:08 *** justan0theruser has joined #bitcoin-core-dev
712017-07-29T07:49:26 *** Drabiv has joined #bitcoin-core-dev
722017-07-29T07:50:40 *** justanotheruser has quit IRC
732017-07-29T07:50:51 *** Drabiv has quit IRC
742017-07-29T08:00:22 *** justan0theruser has quit IRC
752017-07-29T08:00:47 *** justanotheruser has joined #bitcoin-core-dev
762017-07-29T08:02:15 *** riemann has joined #bitcoin-core-dev
772017-07-29T08:12:29 *** J-wolf has joined #bitcoin-core-dev
782017-07-29T08:26:22 *** miknotauro has joined #bitcoin-core-dev
792017-07-29T08:46:19 *** d_t has quit IRC
802017-07-29T09:12:49 *** vicenteH` is now known as vicenteH
812017-07-29T09:19:52 *** Yogaqueef has joined #bitcoin-core-dev
822017-07-29T09:26:29 *** SopaXorzTaker has quit IRC
832017-07-29T09:27:21 *** SopaXorzTaker has joined #bitcoin-core-dev
842017-07-29T09:33:37 *** cheese_ has joined #bitcoin-core-dev
852017-07-29T09:36:51 *** Cheeseo has quit IRC
862017-07-29T09:49:05 *** THoVer has joined #bitcoin-core-dev
872017-07-29T10:01:52 *** Ylbam has joined #bitcoin-core-dev
882017-07-29T10:18:01 *** AaronvanW has quit IRC
892017-07-29T10:44:17 *** Giszmo has joined #bitcoin-core-dev
902017-07-29T11:19:29 *** THoVer has quit IRC
912017-07-29T11:25:56 *** twistedline has quit IRC
922017-07-29T11:29:20 *** twistedline has joined #bitcoin-core-dev
932017-07-29T11:38:50 *** Dojixo has joined #bitcoin-core-dev
942017-07-29T12:18:35 *** Giszmo has quit IRC
952017-07-29T12:21:04 *** Giszmo has joined #bitcoin-core-dev
962017-07-29T12:22:07 *** riemann has quit IRC
972017-07-29T12:30:04 *** miknotauro has quit IRC
982017-07-29T12:39:31 *** miknotauro has joined #bitcoin-core-dev
992017-07-29T12:44:10 *** miknotauro has quit IRC
1002017-07-29T13:21:18 *** MeshCollider has quit IRC
1012017-07-29T13:31:11 *** AaronvanW has joined #bitcoin-core-dev
1022017-07-29T13:32:24 *** AaronvanW has joined #bitcoin-core-dev
1032017-07-29T13:50:19 *** jeep-ss has joined #bitcoin-core-dev
1042017-07-29T13:57:01 *** laurentmt has joined #bitcoin-core-dev
1052017-07-29T13:59:33 *** luke-jr has quit IRC
1062017-07-29T13:59:48 *** luke-jr has joined #bitcoin-core-dev
1072017-07-29T14:00:33 *** [b__b] has quit IRC
1082017-07-29T14:27:32 *** goatpig has joined #bitcoin-core-dev
1092017-07-29T14:36:12 <sam_c> achow101: FYI wrt pr 10952, you can use git add -p to only add parts of the local changes
1102017-07-29T14:36:25 <sam_c> achow101: this prevents whitespace or other unintentional changes from finding their way into commit.
1112017-07-29T14:36:34 <sam_c> bit late for that one but good to know :)
1122017-07-29T14:37:31 *** Deacydal has joined #bitcoin-core-dev
1132017-07-29T14:38:39 *** Mordan has joined #bitcoin-core-dev
1142017-07-29T14:40:07 *** Deacyde has quit IRC
1152017-07-29T14:57:50 *** EagleTM has quit IRC
1162017-07-29T15:33:42 *** Aaronvan_ has joined #bitcoin-core-dev
1172017-07-29T15:34:58 *** Aaronvan_ has quit IRC
1182017-07-29T15:35:04 *** AaronvanW has quit IRC
1192017-07-29T15:39:52 *** Mordan has quit IRC
1202017-07-29T15:54:57 *** Dojixo has quit IRC
1212017-07-29T15:56:02 *** Guyver2 has joined #bitcoin-core-dev
1222017-07-29T16:01:26 *** Z-Fighter has joined #bitcoin-core-dev
1232017-07-29T16:03:26 *** snkey has joined #bitcoin-core-dev
1242017-07-29T16:05:34 *** J-wolf has quit IRC
1252017-07-29T16:06:07 *** snq has quit IRC
1262017-07-29T16:10:27 *** praxeology1 has joined #bitcoin-core-dev
1272017-07-29T16:11:15 *** praxeology1 has quit IRC
1282017-07-29T16:12:10 *** praxeology has quit IRC
1292017-07-29T16:12:56 *** praxeology1 has joined #bitcoin-core-dev
1302017-07-29T16:19:28 *** jeep-ss has quit IRC
1312017-07-29T16:21:19 *** J-wolf has joined #bitcoin-core-dev
1322017-07-29T16:21:50 *** AaronvanW has joined #bitcoin-core-dev
1332017-07-29T16:22:06 *** J-wolf_ has joined #bitcoin-core-dev
1342017-07-29T16:22:58 *** Aaronvan_ has joined #bitcoin-core-dev
1352017-07-29T16:23:44 *** Aaronva__ has joined #bitcoin-core-dev
1362017-07-29T16:25:46 *** J-wolf has quit IRC
1372017-07-29T16:26:48 *** AaronvanW has quit IRC
1382017-07-29T16:27:34 *** Aaronvan_ has quit IRC
1392017-07-29T16:28:09 *** d_t has joined #bitcoin-core-dev
1402017-07-29T16:31:54 *** snq has joined #bitcoin-core-dev
1412017-07-29T16:34:28 *** snkey has quit IRC
1422017-07-29T16:37:25 *** snkey has joined #bitcoin-core-dev
1432017-07-29T16:37:50 *** sanada has joined #bitcoin-core-dev
1442017-07-29T16:39:48 *** snq has quit IRC
1452017-07-29T16:40:03 *** SopaXorzTaker has quit IRC
1462017-07-29T16:44:31 *** BashCo has joined #bitcoin-core-dev
1472017-07-29T16:45:42 *** Aaronva__ has quit IRC
1482017-07-29T16:46:20 *** AaronvanW has joined #bitcoin-core-dev
1492017-07-29T16:46:57 *** BashCo_ has quit IRC
1502017-07-29T16:50:55 *** jb55 has joined #bitcoin-core-dev
1512017-07-29T16:51:28 *** AaronvanW has quit IRC
1522017-07-29T16:57:18 *** jb55 has quit IRC
1532017-07-29T17:07:57 *** praxeology1 has quit IRC
1542017-07-29T17:18:12 *** jamesob has joined #bitcoin-core-dev
1552017-07-29T17:30:24 *** Guyver2_ has joined #bitcoin-core-dev
1562017-07-29T17:30:54 *** snq has joined #bitcoin-core-dev
1572017-07-29T17:33:02 *** Guyver2 has quit IRC
1582017-07-29T17:33:08 *** Guyver2_ is now known as Guyver2
1592017-07-29T17:33:37 *** snkey has quit IRC
1602017-07-29T17:35:56 *** Ylbam has quit IRC
1612017-07-29T17:51:43 *** J-wolf_ has quit IRC
1622017-07-29T17:55:10 *** snq has quit IRC
1632017-07-29T18:04:40 *** SopaXorzTaker has joined #bitcoin-core-dev
1642017-07-29T18:12:55 *** snq has joined #bitcoin-core-dev
1652017-07-29T18:14:25 *** SopaXorzTaker has quit IRC
1662017-07-29T18:14:45 *** SopaXorzTaker has joined #bitcoin-core-dev
1672017-07-29T18:42:04 *** EagleTM has joined #bitcoin-core-dev
1682017-07-29T19:11:17 *** laurentmt has quit IRC
1692017-07-29T19:13:55 *** justan0theruser has joined #bitcoin-core-dev
1702017-07-29T19:15:42 *** justanotheruser has quit IRC
1712017-07-29T19:17:06 *** justan0theruser has quit IRC
1722017-07-29T19:17:39 *** justanotheruser has joined #bitcoin-core-dev
1732017-07-29T19:24:49 *** BashCo_ has joined #bitcoin-core-dev
1742017-07-29T19:26:12 *** BashCo has quit IRC
1752017-07-29T19:41:00 *** Mordan has joined #bitcoin-core-dev
1762017-07-29T19:43:42 *** jamesob has quit IRC
1772017-07-29T19:47:50 *** AaronvanW has joined #bitcoin-core-dev
1782017-07-29T19:48:07 *** zmin has joined #bitcoin-core-dev
1792017-07-29T19:53:37 *** AaronvanW has quit IRC
1802017-07-29T19:57:36 *** praxeology has joined #bitcoin-core-dev
1812017-07-29T20:18:57 *** Guyver2 has quit IRC
1822017-07-29T20:23:30 *** justan0theruser has joined #bitcoin-core-dev
1832017-07-29T20:25:56 *** justanotheruser has quit IRC
1842017-07-29T20:26:56 *** dermoth has quit IRC
1852017-07-29T20:27:36 *** jeep-ss has joined #bitcoin-core-dev
1862017-07-29T20:28:56 *** jamesob has joined #bitcoin-core-dev
1872017-07-29T20:30:28 *** SopaXorzTaker has quit IRC
1882017-07-29T20:39:53 *** AaronvanW has joined #bitcoin-core-dev
1892017-07-29T20:42:20 *** dermoth has joined #bitcoin-core-dev
1902017-07-29T20:43:28 *** zmin has quit IRC
1912017-07-29T20:52:51 *** Giszmo has quit IRC
1922017-07-29T20:55:06 <jamesob> how welcome are readability improvement & documentation PRs? low-priority distraction or actually welcome? I see a few things in validation.cpp that could be made a bit more readable.
1932017-07-29T20:57:17 <gmaxwell> jamesob: they're welcome if that is what they do; but "change the code to my personal style; because I'm not involved with the project enough to distinguish what I'd like with what other contributors would like" wouldn't be, and it's not always easy to tell unless you're heavily involved.
1942017-07-29T20:57:44 <jamesob> gotcha. maybe I'll save them for when my intuition is better :)
1952017-07-29T20:58:18 <gmaxwell> comments are probably always good, though they take a fair amount of work to review .. since they need to be right. :)
1962017-07-29T20:58:33 <jamesob> e.g. this conditional wraps the entirety of this function; I think an early return might be clearer https://github.com/bitcoin/bitcoin/blob/c86b77fc44c74628f5c890c9015338600c69739b/src/validation.cpp#L1238-L1241
1972017-07-29T21:00:46 <gmaxwell> I think that would be a fine change. oh also on these kinds of changes, if they're ones that provably don't change behavior (e.g. stripped object code is the same) that's always helpful.
1982017-07-29T21:01:32 <jamesob> gmaxwell does that amount to comparing the checksum of `bitcoind` before and after change?
1992017-07-29T21:02:01 <jamesob> probably something a little more granular...
2002017-07-29T21:02:31 <gmaxwell> .o of the relevant file is more granular. diffing and objdump of the .o
2012017-07-29T21:03:05 <jamesob> cool, thanks
2022017-07-29T21:05:19 <gmaxwell> In any case, our threshold for taking improvements like this is lower if it doesn't change the binary. It's also useful to seperate changes into ones that change the binary and ones that don't-- if it doesn't change the binary we only need to review for style. If it changes it we have to worry about subtle mistakes that break the software. :)
2032017-07-29T21:07:45 <jamesob> great, good to know. I'm not keen on flooding the PR list with a bunch of [trivial] titles, but I figure if I'm in the neighborhood and can offer some marginal improvement, maybe it's worthwhile.
2042017-07-29T21:11:25 *** jeep-ss_ has joined #bitcoin-core-dev
2052017-07-29T21:11:59 *** Giszmo has joined #bitcoin-core-dev
2062017-07-29T21:12:25 *** d_t has quit IRC
2072017-07-29T21:12:36 *** jeep-ss has quit IRC
2082017-07-29T21:12:45 *** jeep-ss_ is now known as jeep-ss
2092017-07-29T21:12:57 *** d_t has joined #bitcoin-core-dev
2102017-07-29T21:13:51 <gmaxwell> one thing to do is just rate limit yourself. Do a couple, sleep on it, submit the best of them. Collect feedback, revise the others, submit another later. You can also earn review attention by making an effort to do things that other people want done but don't want to do.
2112017-07-29T21:14:15 *** Ylbam has joined #bitcoin-core-dev
2122017-07-29T21:14:33 <gmaxwell> Or by doing some things which everyone reconizes as clearly useful (clarity fixups are not as universally reconized as useful as writing non-trivial tests, for example)
2132017-07-29T21:14:39 *** Aaronvan_ has joined #bitcoin-core-dev
2142017-07-29T21:14:48 *** cysm has quit IRC
2152017-07-29T21:17:48 *** AaronvanW has quit IRC
2162017-07-29T21:18:57 <jamesob> roger that!
2172017-07-29T21:19:18 *** cysm has joined #bitcoin-core-dev
2182017-07-29T21:31:02 *** Mordan has quit IRC
2192017-07-29T21:42:36 *** justanotheruser has joined #bitcoin-core-dev
2202017-07-29T21:43:19 *** justanotheruser has joined #bitcoin-core-dev
2212017-07-29T21:44:48 *** justan0theruser has quit IRC
2222017-07-29T22:02:57 *** intcat has quit IRC
2232017-07-29T22:08:30 *** Deacydal has quit IRC
2242017-07-29T22:14:41 *** intcat has joined #bitcoin-core-dev
2252017-07-29T22:17:55 *** Aaronvan_ has quit IRC
2262017-07-29T22:19:09 *** snq has quit IRC
2272017-07-29T22:19:27 *** snq has joined #bitcoin-core-dev
2282017-07-29T22:21:26 *** AaronvanW has joined #bitcoin-core-dev
2292017-07-29T22:23:04 *** Aaronvan_ has joined #bitcoin-core-dev
2302017-07-29T22:26:52 *** AaronvanW has quit IRC
2312017-07-29T22:58:24 *** intcat has quit IRC
2322017-07-29T22:59:36 *** intcat has joined #bitcoin-core-dev
2332017-07-29T23:08:24 *** Javon has joined #bitcoin-core-dev
2342017-07-29T23:24:40 *** Deacyde has joined #bitcoin-core-dev
2352017-07-29T23:26:38 *** marcoagner has joined #bitcoin-core-dev
2362017-07-29T23:31:46 *** deep-book-gk_ has joined #bitcoin-core-dev
2372017-07-29T23:32:05 *** deep-book-gk_ has left #bitcoin-core-dev
2382017-07-29T23:32:33 *** goatpig has quit IRC
2392017-07-29T23:54:15 <bitcoin-git> [bitcoin] sipa closed pull request #10946: Add chainwork to getchaintxstats (master...20170727_chainworkstats) https://github.com/bitcoin/bitcoin/pull/10946