1 2017-08-07T00:35:54  *** J-wolf has quit IRC
  2 2017-08-07T01:05:26  *** J-wolf has joined #bitcoin-core-dev
  3 2017-08-07T01:24:05  *** miknotauro has quit IRC
  4 2017-08-07T01:25:43  *** Deacyded has joined #bitcoin-core-dev
  5 2017-08-07T01:29:28  *** Deacydal has quit IRC
  6 2017-08-07T01:30:05  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #10998: 2017 08 fix upgrade cancel warnings (master...2017-08-fix-upgrade-cancel-warnings) https://github.com/bitcoin/bitcoin/pull/10998
  7 2017-08-07T01:40:08  *** Chris_Stewart_5 has quit IRC
  8 2017-08-07T01:43:20  *** ekerstein has joined #bitcoin-core-dev
  9 2017-08-07T01:52:23  *** Ylbam has quit IRC
 10 2017-08-07T02:02:07  *** J-wolf has quit IRC
 11 2017-08-07T02:34:45  *** r251d has joined #bitcoin-core-dev
 12 2017-08-07T02:39:36  *** shaolinfry has joined #bitcoin-core-dev
 13 2017-08-07T02:50:23  *** J-wolf has joined #bitcoin-core-dev
 14 2017-08-07T03:00:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 15 2017-08-07T03:02:33  *** luke-jr has quit IRC
 16 2017-08-07T03:03:13  *** luke-jr has joined #bitcoin-core-dev
 17 2017-08-07T03:03:24  *** J-wolf has quit IRC
 18 2017-08-07T03:09:22  *** ekerstein has quit IRC
 19 2017-08-07T03:50:09  *** Chris_Stewart_5 has quit IRC
 20 2017-08-07T04:13:19  *** r251d has quit IRC
 21 2017-08-07T04:32:38  *** marcoagner has quit IRC
 22 2017-08-07T04:43:33  *** marcoagner has joined #bitcoin-core-dev
 23 2017-08-07T04:49:31  *** Electro has joined #bitcoin-core-dev
 24 2017-08-07T05:12:50  *** dabura667 has joined #bitcoin-core-dev
 25 2017-08-07T05:14:15  *** dabura667 has quit IRC
 26 2017-08-07T05:14:28  *** Giszmo has joined #bitcoin-core-dev
 27 2017-08-07T05:28:38  *** dabura667 has joined #bitcoin-core-dev
 28 2017-08-07T05:29:29  *** dabura667 has quit IRC
 29 2017-08-07T05:34:49  *** veleiro has quit IRC
 30 2017-08-07T05:55:42  *** miknotauro has joined #bitcoin-core-dev
 31 2017-08-07T06:06:26  *** J-wolf has joined #bitcoin-core-dev
 32 2017-08-07T06:21:15  *** J-wolf has quit IRC
 33 2017-08-07T06:28:03  *** KevinPan has joined #bitcoin-core-dev
 34 2017-08-07T06:35:24  *** Electro has quit IRC
 35 2017-08-07T06:50:11  *** jonasschnelli_ has quit IRC
 36 2017-08-07T06:50:25  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a9dd11144152...c8b62c7de3d4
 37 2017-08-07T06:50:25  <bitcoin-git> bitcoin/master 1de73f4 Matt Corallo: Disconnect network service bits 6 and 8 until Aug 1, 2018...
 38 2017-08-07T06:50:26  <bitcoin-git> bitcoin/master c8b62c7 Wladimir J. van der Laan: Merge #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018...
 39 2017-08-07T06:50:30  *** jonasschnelli has joined #bitcoin-core-dev
 40 2017-08-07T06:50:33  *** jonasschnelli has joined #bitcoin-core-dev
 41 2017-08-07T06:51:10  <bitcoin-git> [bitcoin] laanwj closed pull request #10982: Disconnect network service bits 6 and 8 until Aug 1, 2018 (master...2017-08-bad-service-bits) https://github.com/bitcoin/bitcoin/pull/10982
 42 2017-08-07T06:52:17  *** BashCo has quit IRC
 43 2017-08-07T06:52:40  *** elkalamar has quit IRC
 44 2017-08-07T06:52:53  *** BashCo has joined #bitcoin-core-dev
 45 2017-08-07T06:57:37  *** BashCo has quit IRC
 46 2017-08-07T07:04:56  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/c8b62c7de3d4...c1c671feb163
 47 2017-08-07T07:04:57  <bitcoin-git> bitcoin/master efac91e Matt Corallo: Always wait for threadGroup to exit in bitcoind shutdown...
 48 2017-08-07T07:04:57  <bitcoin-git> bitcoin/master fce3f4f Matt Corallo: Fix resume-of-reindex-after-restart...
 49 2017-08-07T07:04:58  <bitcoin-git> bitcoin/master 13ab353 Matt Corallo: Check for empty coinsview instead of just-reset coinsview in init...
 50 2017-08-07T07:05:31  <bitcoin-git> [bitcoin] laanwj closed pull request #10919: Fix more init bugs. (master...2017-07-init-bugs) https://github.com/bitcoin/bitcoin/pull/10919
 51 2017-08-07T07:06:31  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c1c671feb163...fa646369489d
 52 2017-08-07T07:06:31  <bitcoin-git> bitcoin/master 01699fb Matt Corallo: Fix resendwallettransactions assert failure if -walletbroadcast=0
 53 2017-08-07T07:06:32  <bitcoin-git> bitcoin/master fa64636 Wladimir J. van der Laan: Merge #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0...
 54 2017-08-07T07:07:09  <bitcoin-git> [bitcoin] laanwj closed pull request #10995: Fix resendwallettransactions assert failure if -walletbroadcast=0 (master...2018-08-walletbroadcast-assert) https://github.com/bitcoin/bitcoin/pull/10995
 55 2017-08-07T07:13:44  *** J-wolf has joined #bitcoin-core-dev
 56 2017-08-07T07:13:47  *** BashCo has joined #bitcoin-core-dev
 57 2017-08-07T07:21:19  *** J-wolf has quit IRC
 58 2017-08-07T07:21:48  *** Ylbam has joined #bitcoin-core-dev
 59 2017-08-07T07:31:10  *** bryyan has quit IRC
 60 2017-08-07T07:31:22  *** dobak has joined #bitcoin-core-dev
 61 2017-08-07T08:05:48  *** cdecker has quit IRC
 62 2017-08-07T08:06:12  *** cdecker has joined #bitcoin-core-dev
 63 2017-08-07T08:08:56  *** timothy has joined #bitcoin-core-dev
 64 2017-08-07T08:20:49  *** JackH has joined #bitcoin-core-dev
 65 2017-08-07T08:29:09  *** dobak has quit IRC
 66 2017-08-07T08:48:11  *** JackH has quit IRC
 67 2017-08-07T09:04:49  *** sam_c has quit IRC
 68 2017-08-07T09:09:22  *** sam_c has joined #bitcoin-core-dev
 69 2017-08-07T09:21:36  *** AaronvanW has joined #bitcoin-core-dev
 70 2017-08-07T09:23:52  *** Alina-malina has quit IRC
 71 2017-08-07T09:23:59  *** Aaronvan_ has joined #bitcoin-core-dev
 72 2017-08-07T09:26:04  *** Alina-malina has joined #bitcoin-core-dev
 73 2017-08-07T09:26:38  *** AaronvanW has quit IRC
 74 2017-08-07T09:36:02  *** sam_c has quit IRC
 75 2017-08-07T09:38:04  *** sam_c has joined #bitcoin-core-dev
 76 2017-08-07T09:38:10  <jonasschnelli> Anyone willing to review NODE_NETWORK_LIMITED BIP before opening a PR? https://github.com/jonasschnelli/bips/wiki/NODE_NETWORK_LIMITED-BIP-DRAFT
 77 2017-08-07T09:38:14  <jonasschnelli> gmaxwell: some of your comments about required block limits are now working into the BIP.
 78 2017-08-07T09:38:16  <jonasschnelli> I'm not sure about the undefined state of signalling both bits (the BIP states this mode as undefined but required to at least serve the last 90days/12'960)
 79 2017-08-07T09:38:19  <jonasschnelli> To leave enough room for future requirements
 80 2017-08-07T09:39:40  <sipa> jonasschnelli: thanks for working on this
 81 2017-08-07T09:40:19  <sipa> jonasschnelli: i'm not sure that both bits available should have a meaning at all
 82 2017-08-07T09:40:37  <sipa> as network nodes aggregate the bits they see by OR'ing them
 83 2017-08-07T09:41:29  <sipa> a node that at some point advertizes _LOW and later advertizes _HIGH, may result in nodes aggregating it to the combination of both
 84 2017-08-07T09:42:43  <sipa> so maybe LOW should mean "i can relay blocks and transactions at the tip, and also can be asked for blocks up to X deep", while HIGH only means "I can be asked for blocks between A and B deep"
 85 2017-08-07T09:42:58  <sipa> typically you'd set both
 86 2017-08-07T09:43:10  <sipa> or just LOW
 87 2017-08-07T09:46:14  <sipa> (just an idea, see what others think)
 88 2017-08-07T09:49:37  <gmaxwell> sipa: meh, I don't think the "I can do deep but not the tip" really makes sense, what you raise would be resolved by just defining each to be or newer and letting you combine them.
 89 2017-08-07T09:52:16  <jonasschnelli> From a practical standpoint LOW is for the ones who prune to the minimum (current prune=550), HIGH probably for the ones who prune not to the minimum and/or use manual pruning. Also the depth value we set in HIGH will probably give those a guideline who not want to prune to the minimum
 90 2017-08-07T09:52:52  <jonasschnelli> I agree that setting both bits could remain completely undefined
 91 2017-08-07T09:53:09  <jonasschnelli> It just felt wasteful not to define the state when signalling both bits
 92 2017-08-07T09:54:01  <jonasschnelli> Maybe there are some peers who run manual pruning mode but haven't pruned so far and this state could be covered by both bits?
 93 2017-08-07T10:02:44  <sipa> gmaxwell: ?
 94 2017-08-07T10:09:43  *** Ylbam has quit IRC
 95 2017-08-07T10:13:44  *** Deacydal has joined #bitcoin-core-dev
 96 2017-08-07T10:16:50  *** Deacyded has quit IRC
 97 2017-08-07T10:20:53  <wumpus> holy shit 2017-08-07 10:20:38 Error: Error loading wallet.dat: Wallet corrupted
 98 2017-08-07T10:21:02  *** Alina-malina has quit IRC
 99 2017-08-07T10:21:02  *** Alina-malina has joined #bitcoin-core-dev
100 2017-08-07T10:21:20  <jonasschnelli> wumpus: oh! Master?
101 2017-08-07T10:22:01  <wumpus> apparently I still have #10952 merged
102 2017-08-07T10:22:03  <gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
103 2017-08-07T10:22:09  <wumpus> let me try with master
104 2017-08-07T10:22:20  <gmaxwell> wumpus: I was about to suggest 10952 to fix it.
105 2017-08-07T10:22:32  <gmaxwell> (or usehd=0)
106 2017-08-07T10:22:43  <jonasschnelli> The default key is sneaky!
107 2017-08-07T10:23:35  <wumpus> master is ok
108 2017-08-07T10:24:52  <wumpus> this is an old, pre-hd wallet that survived a long time - will try to figure out why #10952 rejects it later
109 2017-08-07T10:24:54  <gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
110 2017-08-07T10:25:08  <jonasschnelli> What are the incentives / reasons why someone pruned to a larger target then the 550 minimum?
111 2017-08-07T10:26:00  <jonasschnelli> (with the current p2p signaling)
112 2017-08-07T10:26:17  <wumpus> the only reason I can think of is to support swapping wallets that can run a bit more out of sync
113 2017-08-07T10:26:34  <jonasschnelli> Good point
114 2017-08-07T10:26:42  <gmaxwell> jonasschnelli: having prune specified in megabytes is pretty daft.
115 2017-08-07T10:26:48  <jonasschnelli> He
116 2017-08-07T10:26:50  <gmaxwell> I think in the future we'll have a small set of options.
117 2017-08-07T10:26:54  <jonasschnelli> Yes
118 2017-08-07T10:27:35  <gmaxwell> and people will set larger ones to support the network more and due to rescans as mentioned.
119 2017-08-07T10:28:20  <jonasschnelli> Yes. I think the thresholds we set in the BIP may have influence what options
120 2017-08-07T10:28:31  <sipa> it helps to realize that effectively every reachable nodes that serves you blocks is altruistic
121 2017-08-07T10:28:31  <jonasschnelli> We will have / users will choose
122 2017-08-07T10:30:20  *** Yogaqueef has joined #bitcoin-core-dev
123 2017-08-07T10:30:22  <gmaxwell> I think the advice in the BIP about connections is not really great advice. It's vague, and I think if followed it will cause a lot of pressure on pruned nodes (Esp because they will likely be much more rare among listening nodes for some time).  The network is self balancing.  If there is more demand on a node, it'll end up disconnecting some peers, and those peers will move elsewhere.
124 2017-08-07T10:30:52  <gmaxwell> I think nodes should likely choose uniformly among all peers offering what they need.
125 2017-08-07T10:31:31  <jonasschnelli> I see this point. gmaxwell: would removing the connection part in the BIP makes sense?
126 2017-08-07T10:31:44  <sipa> gmaxwell: i don't understand what you suggested earlier to deal with the OR'ing?
127 2017-08-07T10:31:47  <jonasschnelli> (Leaving it up to the impl.)
128 2017-08-07T10:31:54  <gmaxwell> if in the future pruned nodes become much more common as listening nodes than unpruned nodes, then it may make sense to try to avoid unpruned if you don't need them; but I don't expect that during the working life of this BIP (Basically by that point we'll have to have made other related service flag changes).
129 2017-08-07T10:32:44  <gmaxwell> sipa: It is a set mean the same as the 1week option.
130 2017-08-07T10:32:59  <gmaxwell> it's OR safe.
131 2017-08-07T10:33:23  <sipa> parse error
132 2017-08-07T10:33:35  <gmaxwell> @#$@# keyboard
133 2017-08-07T10:33:47  <gmaxwell> (loses long strings of text)
134 2017-08-07T10:33:54  <sipa> you need a new laptop
135 2017-08-07T10:34:01  <gmaxwell> sipa: If both are set, it means the same as the 1week option.
136 2017-08-07T10:34:45  <gmaxwell> Your suggestion allows a psycho signal "old but not new", which would just end up making that peer get ignored by peer selection (at best).
137 2017-08-07T10:35:01  <sipa> that's an option too
138 2017-08-07T10:35:42  <sipa> i'm just trying to not lose information by making the bits indicate orthogonal services
139 2017-08-07T10:35:56  <gmaxwell> I don't think we should worry too much about using bits here. We will need a new addr message in the not so far future.
140 2017-08-07T10:36:11  <gmaxwell> (because of HSNG and I2P)
141 2017-08-07T10:37:18  <gmaxwell> and we avoid using them for other things.
142 2017-08-07T10:37:21  <sipa> in that light, i wonder if we'll regret the choice of combining possibly 3 independent things into one bits (tx relay, block at tip relay, blocks up to a day old fetch)
143 2017-08-07T10:38:30  <gmaxwell> I dunno, I think block at tip relay basically needs to impliy 288 in any case, you'll need it for reorg, and the peer will not find your block announcements useful if you can't help the peer reorg.
144 2017-08-07T10:38:45  <gmaxwell> seems dangerous to me to introduce nodes in the topology that can't help you reorg.
145 2017-08-07T10:39:07  <sipa> yes, i agree
146 2017-08-07T10:39:38  <sipa> i'm just wondering whether maybe at some point we'll regret it due to evolutions we don't foresee now
147 2017-08-07T10:39:59  <gmaxwell> for sure, but then we'll change it then.
148 2017-08-07T10:40:55  <sipa> making the bits independent does not need to imply there is  recommendation or even permission to use them in odd ways "i relay blocks at the tip, and older than 3 months, except those between 1 and 2 years old!"
149 2017-08-07T10:41:49  <gmaxwell> if you can signal it, everyone will need code to handle it.
150 2017-08-07T10:42:04  <gmaxwell> which will me realizing that the sensless combination exists in the first place.
151 2017-08-07T10:42:19  <sipa> which will me?
152 2017-08-07T10:42:49  <gmaxwell> in general I prefer to avoid even being able to encode something that makes no more sense because it guarentees more corner cases you must handle.
153 2017-08-07T10:43:03  * sipa zZzZ
154 2017-08-07T11:03:08  *** jannes has joined #bitcoin-core-dev
155 2017-08-07T11:35:15  *** SopaXorzTaker has joined #bitcoin-core-dev
156 2017-08-07T11:39:26  *** miknotauro has quit IRC
157 2017-08-07T11:43:01  *** Deacyde has joined #bitcoin-core-dev
158 2017-08-07T11:43:30  *** Deacydal has quit IRC
159 2017-08-07T11:45:37  *** gaf_ has quit IRC
160 2017-08-07T11:46:24  *** gaf_ has joined #bitcoin-core-dev
161 2017-08-07T12:06:32  <wumpus> seems I found the bug in #10952: https://github.com/bitcoin/bitcoin/pull/10952/files#r131637416
162 2017-08-07T12:06:34  <gribble> https://github.com/bitcoin/bitcoin/issues/10952 | [wallet] Remove vchDefaultKey and have better first run detection by achow101 · Pull Request #10952 · bitcoin/bitcoin · GitHub
163 2017-08-07T12:10:47  <gmaxwell>       "value": 1.00,
164 2017-08-07T12:11:02  <gmaxwell> ^ decoderawtransaction is not zero extending the value field. :-/
165 2017-08-07T12:11:44  *** JackH has joined #bitcoin-core-dev
166 2017-08-07T12:13:59  <wumpus> it's not using the correct formatting function
167 2017-08-07T12:14:26  <wumpus> https://github.com/bitcoin/bitcoin/blob/master/src/core_write.cpp#L187
168 2017-08-07T12:15:31  <wumpus> uses FormatMoney directly instead of ValueFromAmount
169 2017-08-07T12:16:03  <wumpus> I'll make a PR
170 2017-08-07T12:34:09  <gmaxwell> argh!
171 2017-08-07T12:39:48  *** Matt- has quit IRC
172 2017-08-07T12:47:55  <wumpus> sigh, I fixed it locally, now the tests are broken - lol
173 2017-08-07T12:56:55  <bitcoin-git> [bitcoin] laanwj opened pull request #10999: Fix amounts formatting in `decoderawtransaction` (master...2017_08_decoderawtx_amount) https://github.com/bitcoin/bitcoin/pull/10999
174 2017-08-07T12:59:09  <wumpus> gmaxwell: ^^
175 2017-08-07T12:59:35  <gmaxwell> tests exist to make sure we don't fix bugs, apparently. :P
176 2017-08-07T13:00:13  <wumpus> well in this case it's good that the test is so literal - we should catch misformats here - however it checks against the wrong answer :P
177 2017-08-07T13:05:42  <gmaxwell> has this always been broken
178 2017-08-07T13:05:44  <gmaxwell> ?
179 2017-08-07T13:16:24  *** Chris_Stewart_5 has joined #bitcoin-core-dev
180 2017-08-07T13:30:57  *** afk11 has quit IRC
181 2017-08-07T13:35:59  *** afk11 has joined #bitcoin-core-dev
182 2017-08-07T13:44:24  *** belcher has quit IRC
183 2017-08-07T13:52:41  <wumpus> at the least for very long (since the univalue switch?)
184 2017-08-07T13:53:16  <wumpus> and at that time it's very possible that we weren't padding all amounts to 8 digits yet
185 2017-08-07T13:54:04  <gmaxwell> I wonder if I managed to lose money due to this at some point. It's not entirely unlikely.
186 2017-08-07T13:57:01  *** laurentmt has joined #bitcoin-core-dev
187 2017-08-07T14:00:09  *** belcher has joined #bitcoin-core-dev
188 2017-08-07T14:05:36  *** Guyver2 has joined #bitcoin-core-dev
189 2017-08-07T14:15:23  <wumpus> we started always returning 8 decimals in this commit in july 2015, https://github.com/bitcoin/bitcoin/commit/e061e2778d592826970483e0844308c4e9a12626
190 2017-08-07T14:17:26  <wumpus> it was assumed that app RPC-facing stuff was using ValueFromAmount, but apparently TxToUniv in core_io didn't, probably because of some dependency tangle
191 2017-08-07T14:18:00  <wumpus> I've checked the other remaining uses of FormatMoney afaik they're all in debug logging
192 2017-08-07T14:36:07  <Lightsword> anything still needed for #10301?
193 2017-08-07T14:36:12  <gribble> https://github.com/bitcoin/bitcoin/issues/10301 | Check if sys/random.h is required for getentropy. by jameshilliard · Pull Request #10301 · bitcoin/bitcoin · GitHub
194 2017-08-07T14:37:45  *** laurentmt has quit IRC
195 2017-08-07T14:39:54  *** laurentmt has joined #bitcoin-core-dev
196 2017-08-07T14:46:24  *** laurentmt has quit IRC
197 2017-08-07T15:08:28  *** JackH has quit IRC
198 2017-08-07T15:14:29  *** Dizzle has joined #bitcoin-core-dev
199 2017-08-07T15:15:07  *** BashCo has quit IRC
200 2017-08-07T15:15:46  *** BashCo has joined #bitcoin-core-dev
201 2017-08-07T15:15:58  *** Murch has joined #bitcoin-core-dev
202 2017-08-07T15:19:34  <bitcoin-git> [bitcoin] promag opened pull request #11000: test: Add resendwallettransactions functional tests (master...201708-resendwallettransactions-test) https://github.com/bitcoin/bitcoin/pull/11000
203 2017-08-07T15:20:05  *** BashCo has quit IRC
204 2017-08-07T15:23:46  *** promag has joined #bitcoin-core-dev
205 2017-08-07T15:24:18  <promag> wumpus: ^^
206 2017-08-07T15:25:28  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa646369489d...318392ca7cda
207 2017-08-07T15:25:29  <bitcoin-git> bitcoin/master ee2d10a James Hilliard: Check if sys/random.h is required for getentropy on OSX.
208 2017-08-07T15:25:29  <bitcoin-git> bitcoin/master 318392c Wladimir J. van der Laan: Merge #10301: Check if sys/random.h is required for getentropy....
209 2017-08-07T15:25:41  <bitcoin-git> [bitcoin] laanwj closed pull request #10301: Check if sys/random.h is required for getentropy. (master...getentropy-rand) https://github.com/bitcoin/bitcoin/pull/10301
210 2017-08-07T15:28:01  <wumpus> promag: congrats on #11000 I guess?
211 2017-08-07T15:28:03  <gribble> https://github.com/bitcoin/bitcoin/issues/11000 | test: Add resendwallettransactions functional tests by promag · Pull Request #11000 · bitcoin/bitcoin · GitHub
212 2017-08-07T15:28:40  <wumpus> promag: I think you need to add it to the test lists
213 2017-08-07T15:28:40  <promag> heh did nothing all week to catch it :P
214 2017-08-07T15:28:50  <promag> right!
215 2017-08-07T15:29:21  *** veleiro has joined #bitcoin-core-dev
216 2017-08-07T15:30:23  <promag> wumpus: extended script?
217 2017-08-07T15:30:43  <promag> does it have to be run in travis?
218 2017-08-07T15:35:58  <wumpus> if it takes up to a few seconds you should add it to the normal tests
219 2017-08-07T15:36:19  <wumpus> extended tests is for tests that take significant time
220 2017-08-07T15:38:50  *** veleiro has quit IRC
221 2017-08-07T15:41:26  <bitcoin-git> [bitcoin] jnewbery opened pull request #11001: [tests] Test disconnecting unsupported service bits logic. (master...unsupported_service_bits_test) https://github.com/bitcoin/bitcoin/pull/11001
222 2017-08-07T15:45:59  *** BashCo has joined #bitcoin-core-dev
223 2017-08-07T15:54:43  *** belcher has quit IRC
224 2017-08-07T16:02:31  *** belcher has joined #bitcoin-core-dev
225 2017-08-07T16:06:30  *** veleiro has joined #bitcoin-core-dev
226 2017-08-07T16:18:58  *** Guyver2 has quit IRC
227 2017-08-07T16:22:32  *** promag has quit IRC
228 2017-08-07T16:30:30  *** Chris_Stewart_5 has quit IRC
229 2017-08-07T16:31:08  *** veleiro has quit IRC
230 2017-08-07T16:43:21  *** str4d has joined #bitcoin-core-dev
231 2017-08-07T16:47:22  *** spudowiar has joined #bitcoin-core-dev
232 2017-08-07T16:47:45  *** spudowiar has left #bitcoin-core-dev
233 2017-08-07T16:49:03  *** veleiro has joined #bitcoin-core-dev
234 2017-08-07T16:50:22  *** str4d has quit IRC
235 2017-08-07T16:50:54  *** jrayhawk_ is now known as jrayhawkj
236 2017-08-07T16:50:55  *** jrayhawkj is now known as jrayhawk
237 2017-08-07T16:52:42  *** abpa has joined #bitcoin-core-dev
238 2017-08-07T16:52:57  *** str4d has joined #bitcoin-core-dev
239 2017-08-07T16:58:18  *** miknotauro has joined #bitcoin-core-dev
240 2017-08-07T16:59:36  *** timothy has quit IRC
241 2017-08-07T17:06:48  *** promag has joined #bitcoin-core-dev
242 2017-08-07T17:09:35  *** Chris_Stewart_5 has joined #bitcoin-core-dev
243 2017-08-07T17:21:07  <jonasschnelli> gmaxwell: re: https://github.com/jonasschnelli/bips/wiki/NODE_NETWORK_LIMITED-BIP-DRAFT#network-health-optional
244 2017-08-07T17:21:08  <jonasschnelli> What if the BIP would recommend (optional) to connect - once in sync – to a lower percentage (10%) of the percentage of available NODE_NETWORK_LIMITED in addrman? Probably over-specifing?
245 2017-08-07T17:21:37  <jonasschnelli> Nah.. nm. Let me remove that part...
246 2017-08-07T17:26:36  *** d_t has joined #bitcoin-core-dev
247 2017-08-07T17:34:46  *** PaulCapestany has joined #bitcoin-core-dev
248 2017-08-07T17:40:37  <luke-jr> jonasschnelli: dislike that it still requires 90 days for both bits set. Would prefer if it didn't imply anything more than the 2 days
249 2017-08-07T17:40:59  <jonasschnelli> Oh. Yes. Let me remove that part...
250 2017-08-07T17:42:18  <jonasschnelli> luke-jr: its removed now
251 2017-08-07T17:43:17  <luke-jr> jonasschnelli: rather than forbid the bits when NODE_NETWORK is set, I suggest leaving them entirely undefined in that circumstance
252 2017-08-07T17:44:21  *** abpa has quit IRC
253 2017-08-07T17:44:25  <jonasschnelli> luke-jr: I don't think one should signal LIMITED and NODE_NETWORK. It may confuse primitive implementations
254 2017-08-07T17:45:11  <luke-jr> jonasschnelli: forbidding such primitive implementations is why to undefine it now :p
255 2017-08-07T17:45:18  <luke-jr> jonasschnelli: please use BIP number 159
256 2017-08-07T17:45:53  *** arubi has quit IRC
257 2017-08-07T17:46:50  *** arubi has joined #bitcoin-core-dev
258 2017-08-07T17:47:51  *** arubi has quit IRC
259 2017-08-07T17:48:52  *** arubi has joined #bitcoin-core-dev
260 2017-08-07T17:48:53  <sdaftuar> jonasschnelli: i think it's clearest if setting a bit has meaning independent from looking at other bits.
261 2017-08-07T17:49:09  <sdaftuar> eg if you want to know if a node has all historical blocks, just check NODE_NETWORK
262 2017-08-07T17:49:30  <sdaftuar> if you want to know if it serves recent blocks, just check NODE_LIMITED_*
263 2017-08-07T17:49:35  <sdaftuar> and not owrry about setting both
264 2017-08-07T17:49:41  <jonasschnelli> I see. Makes sense... I'll fix that
265 2017-08-07T17:49:48  *** dgenr8 has quit IRC
266 2017-08-07T17:50:05  *** Chris_Stewart_5 has quit IRC
267 2017-08-07T17:54:58  <jonasschnelli> Fixed
268 2017-08-07T18:04:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
269 2017-08-07T18:13:45  <xHire> jonasschnelli: please, what does committing a transaction in the context of fee bumping mean? (doing translation; `git blame qt/walletmodel.cpp` pointed to you :c))
270 2017-08-07T18:14:39  *** str4d has quit IRC
271 2017-08-07T18:14:59  <jonasschnelli> committing means probably add the wallet and broadcast? Need to check that source code comment later. Thx
272 2017-08-07T18:15:11  <jonasschnelli> Add to the
273 2017-08-07T18:15:17  *** str4d has joined #bitcoin-core-dev
274 2017-08-07T18:15:48  <xHire> right, that makes sense. thanks!
275 2017-08-07T18:33:38  *** laurentmt has joined #bitcoin-core-dev
276 2017-08-07T18:34:51  *** Chris_St1 has joined #bitcoin-core-dev
277 2017-08-07T18:35:14  *** laurentmt has quit IRC
278 2017-08-07T18:35:28  *** Chris_Stewart_5 has quit IRC
279 2017-08-07T18:37:18  *** Chris_St1 has quit IRC
280 2017-08-07T18:37:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
281 2017-08-07T18:37:41  *** dermoth has quit IRC
282 2017-08-07T18:38:04  *** dermoth has joined #bitcoin-core-dev
283 2017-08-07T18:47:34  *** Cheeseo has joined #bitcoin-core-dev
284 2017-08-07T18:51:46  <sdaftuar> gmaxwell: luke-jr: is it important that we cache the last call to CNB in getblocktemplate() and return it to callers who are calling getblocktemplate more frequently than every 5 seconds?
285 2017-08-07T18:52:17  <sdaftuar> i've finally gotten around to revisiting #10200, and i think it would make sense to drop that cache, and make the proposed new CNB parameters for recent transaction inclusion arguments to getblocktemplate
286 2017-08-07T18:52:19  <gribble> https://github.com/bitcoin/bitcoin/issues/10200 | Mining: Skip recent transactions if fee difference is small by sdaftuar · Pull Request #10200 · bitcoin/bitcoin · GitHub
287 2017-08-07T18:52:35  <sdaftuar> (rather than bitcoind arguments, which is where that PR started)
288 2017-08-07T18:53:32  <luke-jr> sdaftuar: the cache is AFAIK mainly used for multiple clients calling GBT at almost the same time
289 2017-08-07T18:54:25  <luke-jr> I'm not sure it makes sense to expose the parameters over RPC like that anyway.
290 2017-08-07T18:54:34  <luke-jr> (why would a miner want to run with different configurations?)
291 2017-08-07T18:54:48  <sdaftuar> the CNB parameters?  it seemd like it would be annoying to restart bitcoind if you wanted to change the parameter
292 2017-08-07T18:54:51  <sdaftuar> eg in response to network conditions
293 2017-08-07T18:55:32  <sdaftuar> i hadn't considered multiple rpc clients calling gbt on the same server...  i figured that for a single client, cnb should be fast enough that we could just invoke it each time
294 2017-08-07T18:55:46  <sdaftuar> but no idea how much load it could take from multiple clients
295 2017-08-07T18:58:34  <sdaftuar> eh, i will punt on it for now and just leave it as a bitcoind argument i guess
296 2017-08-07T19:14:29  <luke-jr> sdaftuar: there are more than just mining parameters that are nice to adjust at runtime. Yet another use for a setconfig RPC..
297 2017-08-07T19:15:05  *** Aaronvan_ is now known as AaronvanW
298 2017-08-07T19:15:50  <sdaftuar> sure, i agree with that in general
299 2017-08-07T19:19:46  *** promag has quit IRC
300 2017-08-07T19:27:53  *** d_t has quit IRC
301 2017-08-07T19:31:07  *** Chris_Stewart_5 has quit IRC
302 2017-08-07T19:38:38  <SopaXorzTaker> When will the alert key be published?
303 2017-08-07T19:38:49  <SopaXorzTaker> (don't forget to withdraw the coins that are sitting there, devs!)
304 2017-08-07T19:41:20  *** abpa has joined #bitcoin-core-dev
305 2017-08-07T19:45:51  *** chjj has quit IRC
306 2017-08-07T19:52:29  *** Chris_Stewart_5 has joined #bitcoin-core-dev
307 2017-08-07T19:53:17  <bitcoin-git> [bitcoin] jnewbery opened pull request #11002: [wallet] return correct error code from resendwallettransaction (master...resendwallettransaction_error_code) https://github.com/bitcoin/bitcoin/pull/11002
308 2017-08-07T19:57:20  *** chjj has joined #bitcoin-core-dev
309 2017-08-07T19:59:51  *** Ylbam has joined #bitcoin-core-dev
310 2017-08-07T20:01:00  *** str4d has quit IRC
311 2017-08-07T20:13:15  *** sam_c has quit IRC
312 2017-08-07T20:13:32  *** sam_c has joined #bitcoin-core-dev
313 2017-08-07T20:21:23  *** sam_c has quit IRC
314 2017-08-07T20:22:24  *** sam_c has joined #bitcoin-core-dev
315 2017-08-07T20:24:22  *** chjj has quit IRC
316 2017-08-07T20:29:19  <jnewbery> jonasschnelli: I agree with sdaftuar and sipa that bits should be considered independently.
317 2017-08-07T20:30:42  <jnewbery> it makes logic straightforward: if (NODE_NETWORK) {can serve me all blocks} else if (NODE_LIMITED_HIGH) {can serve me blocks up to 8 days} else if (NODE_LIMITED_LOW) {can serve be blocks up to 2 days} else {can't serve me blocks}
318 2017-08-07T20:31:05  <jnewbery> I'd remove the line "The required behaviour when signaling both bits (NODE_NETWORK_LIMITED_LOW & NODE_NETWORK_LIMITED_HIGH) is currently undefined."
319 2017-08-07T20:32:15  *** SopaXorzTaker has quit IRC
320 2017-08-07T20:33:41  <jnewbery> I also think we should consider sipa's point about orthogonal services having their own bits (tx relay, block relay, addr relay, blocks up to 8 days). It's not like we're short of bits. And the edge-handling code isn't that difficult. For now, just reject if one but not all of them are set.
321 2017-08-07T20:37:52  *** Dizzle has quit IRC
322 2017-08-07T20:37:55  <gmaxwell> if we reject, then we can't use them seperately in the future because older peers will ignore us.
323 2017-08-07T20:39:37  <sipa> jnewbery: i changed the links on the wiki to be section references rather than URLs, and added more
324 2017-08-07T20:48:50  <eck> i want to extend the backupwallet command so that there's a new optional argument, the file mode of the backup file. For a change like this, is it better to ask for interest on the mailing list? or should I just write the code and send a PR?
325 2017-08-07T20:50:21  <eck> arguably this would be better done by allowing there to be different rpcusers with different sets of permissions, but that change seems too expansive
326 2017-08-07T21:02:11  <jnewbery> sipa: looks good. I think everything in #9889 is now covered
327 2017-08-07T21:02:13  <gribble> https://github.com/bitcoin/bitcoin/issues/9889 | TODO for release notes 0.15.0 · Issue #9889 · bitcoin/bitcoin · GitHub
328 2017-08-07T21:03:55  <luke-jr> jnewbery: that wastes bits
329 2017-08-07T21:05:16  <jnewbery> gmaxwell you're right. Reject is incorrect. Should have said 'ignore bits if one but not all of them are set'
330 2017-08-07T21:05:31  <luke-jr> unless perhaps it's if (NODE_NETWORK) else if (NODE_LIMITED_LOW) else if (NODE_LIMITED_HIGH) …
331 2017-08-07T21:06:33  <luke-jr> then the LIMITED bits are properly ignored if NETWORK is set, and if both LIMITED are set, behaviour is only guaranteed as LIMITED_LOW (ie, what the BIP currently says)
332 2017-08-07T21:07:05  <luke-jr> (leaving the LIMITED_LOW | LIMITED_HIGH combination for a LOW + deterministic assortment of history)
333 2017-08-07T21:08:02  *** jamesob has joined #bitcoin-core-dev
334 2017-08-07T21:08:03  *** promag has joined #bitcoin-core-dev
335 2017-08-07T21:12:25  <sdaftuar> i think we should interpret bits as only being affirmative for a given property, and not denying other services.  imo that is the clearest way to describe your state, even if not information maximizing.
336 2017-08-07T21:15:17  <jnewbery> I agree. I don't think the meaning of a single bit should be dependent on other bits
337 2017-08-07T21:16:26  <sipa> agree
338 2017-08-07T21:16:34  *** abpa has quit IRC
339 2017-08-07T21:17:47  *** chjj has joined #bitcoin-core-dev
340 2017-08-07T21:19:32  *** abpa has joined #bitcoin-core-dev
341 2017-08-07T21:22:22  *** sam_c has quit IRC
342 2017-08-07T21:23:34  *** sam_c has joined #bitcoin-core-dev
343 2017-08-07T21:27:29  <promag> jnewbery: updated #11000, ty
344 2017-08-07T21:27:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11000 | test: Add resendwallettransactions functional tests by promag · Pull Request #11000 · bitcoin/bitcoin · GitHub
345 2017-08-07T21:28:17  <bitcoin-git> [bitcoin] eklitzke opened pull request #11003: Docs: Capitalize bullet points in CONTRIBUTING guide (master...contributing_grammar) https://github.com/bitcoin/bitcoin/pull/11003
346 2017-08-07T21:28:46  *** dgenr8 has joined #bitcoin-core-dev
347 2017-08-07T21:29:27  *** veleiro has quit IRC
348 2017-08-07T21:32:39  <jnewbery> thanks promag
349 2017-08-07T21:34:31  *** abpa has quit IRC
350 2017-08-07T21:37:35  *** unholymachine has quit IRC
351 2017-08-07T21:40:05  *** unholymachine has joined #bitcoin-core-dev
352 2017-08-07T21:41:00  *** abpa has joined #bitcoin-core-dev
353 2017-08-07T21:42:42  <luke-jr> jnewbery: so we just burn 1 bit for every resolution of chain archival? :/
354 2017-08-07T21:43:10  <jnewbery> if there are only two resolutions, that's not a problem
355 2017-08-07T21:43:25  <luke-jr> there aren't.
356 2017-08-07T21:43:43  <luke-jr> even with just this BIP, there are three. and no reason to expect it to end with that.
357 2017-08-07T21:43:50  <jnewbery> by the time we run out of bits, we'll already have the new addr message
358 2017-08-07T21:43:59  <luke-jr> why do we want a new addr message?
359 2017-08-07T21:44:54  <jnewbery> 06:35 < gmaxwell> I don't think we should worry too much about using bits here. We will need a new addr message in the not so far future.
360 2017-08-07T21:44:56  <jnewbery> 06:36 < gmaxwell> (because of HSNG and I2P)
361 2017-08-07T21:46:19  <luke-jr> making the IP size longer isn't really a reason to use service bits unwisely
362 2017-08-07T22:02:47  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/318392ca7cda...fa8a0639f7b0
363 2017-08-07T22:02:47  <bitcoin-git> bitcoin/master 5e35cd9 John Newbery: [tests] Test disconnecting unsupported service bits logic....
364 2017-08-07T22:02:48  <bitcoin-git> bitcoin/master fa8a063 MarcoFalke: Merge #11001: [tests] Test disconnecting unsupported service bits logic....
365 2017-08-07T22:03:30  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11001: [tests] Test disconnecting unsupported service bits logic. (master...unsupported_service_bits_test) https://github.com/bitcoin/bitcoin/pull/11001
366 2017-08-07T22:05:24  *** sam_c has quit IRC
367 2017-08-07T22:06:30  *** laurentmt has joined #bitcoin-core-dev
368 2017-08-07T22:08:08  *** sam_c has joined #bitcoin-core-dev
369 2017-08-07T22:20:23  *** veleiro has joined #bitcoin-core-dev
370 2017-08-07T22:24:49  *** Hello has joined #bitcoin-core-dev
371 2017-08-07T22:25:03  *** d_t has joined #bitcoin-core-dev
372 2017-08-07T22:25:31  <Hello> everyone, Can somebody inform me on how to check if the coin chain has split ? is there a RPC command ?
373 2017-08-07T22:26:07  <sipa> getchaintips
374 2017-08-07T22:27:28  *** sam_c has quit IRC
375 2017-08-07T22:28:34  *** sam_c has joined #bitcoin-core-dev
376 2017-08-07T22:30:55  <Hello> hey sipa thank you for the tip but it says method not found
377 2017-08-07T22:31:33  <LordCow> bitcoin-cli getchaintips
378 2017-08-07T22:31:57  <Hello> I forgot to mention I want to check this on a alt coin wallet
379 2017-08-07T22:34:22  *** Chris_Stewart_5 has quit IRC
380 2017-08-07T22:39:21  <Hello> Client version is
381 2017-08-07T22:40:10  *** laurentmt has quit IRC
382 2017-08-07T22:43:56  <gmaxwell> oh jesus I broke the release notes wiki, pieter is fixing it.
383 2017-08-07T22:44:32  <gmaxwell> Pro tip: if you hit edit, then change the title for a page on the wiki, it nukes the history.
384 2017-08-07T22:45:21  <gmaxwell> (people are circulating links to the release notes wiki as if it were the 0.15 release notes, so I tried to change the title to say it's a draft)
385 2017-08-07T22:47:53  *** promag has quit IRC
386 2017-08-07T22:48:11  <sipa> Hello: then go yell at its developers
387 2017-08-07T22:48:48  <sipa> gmaxwell: fixed
388 2017-08-07T22:50:36  <Hello> Sipa: I can't yell at myself lmao
389 2017-08-07T22:52:23  <sipa> Hello: in any case, off topic here
390 2017-08-07T22:52:54  <Hello> sipa: thanks for replying have a nice day
391 2017-08-07T22:53:00  *** promag has joined #bitcoin-core-dev
392 2017-08-07T22:57:40  *** Hello has quit IRC
393 2017-08-07T23:01:00  *** miknotauro has quit IRC
394 2017-08-07T23:01:01  *** arubi has quit IRC
395 2017-08-07T23:02:01  *** arubi has joined #bitcoin-core-dev
396 2017-08-07T23:02:29  *** Giszmo has quit IRC
397 2017-08-07T23:09:55  *** elkalamar has joined #bitcoin-core-dev
398 2017-08-07T23:22:34  *** Soligor has quit IRC
399 2017-08-07T23:33:12  *** Soligor has joined #bitcoin-core-dev
400 2017-08-07T23:38:02  *** Ylbam has quit IRC
401 2017-08-07T23:53:23  <gmaxwell> luke-jr: you should move the block of new questions at the top of https://luke.dashjr.org/programs/kycpoll/answers.php to the bottom, now it just looks stupid with one response.
402 2017-08-07T23:58:40  *** promag has quit IRC