12017-09-01T00:02:02  *** Gunnie has joined #bitcoin-core-dev
  22017-09-01T00:03:06  *** Giszmo has joined #bitcoin-core-dev
  32017-09-01T00:07:50  *** Gunnie has quit IRC
  42017-09-01T00:08:34  *** JackH has quit IRC
  52017-09-01T00:09:08  *** JackH has joined #bitcoin-core-dev
  62017-09-01T00:09:44  *** JackH has quit IRC
  72017-09-01T00:10:29  *** JackH has joined #bitcoin-core-dev
  82017-09-01T00:12:45  *** chjj has joined #bitcoin-core-dev
  92017-09-01T00:13:00  *** JackH has quit IRC
 102017-09-01T00:13:35  *** JackH has joined #bitcoin-core-dev
 112017-09-01T00:13:43  *** dabura667 has joined #bitcoin-core-dev
 122017-09-01T00:17:47  *** JackH has quit IRC
 132017-09-01T00:20:55  <sipa> achow101: i overlooked it before; i've locked the comments on the first commit
 142017-09-01T00:21:11  <achow101> yay
 152017-09-01T00:21:28  <achow101> less spam
 162017-09-01T00:21:37  *** JackH has joined #bitcoin-core-dev
 172017-09-01T00:22:12  <gmaxwell> oh thats why achow was asking. :P
 182017-09-01T00:26:59  <jtimon> review beg https://github.com/bitcoin/bitcoin/pull/8994 now there's no exception for testing segwit.py and I left the loading of the parameters from aseparated file for later
 192017-09-01T00:33:45  <achow101> I think I am close to figuring out what happened with #11171, and it is not related to the off screen thing
 202017-09-01T00:37:12  *** Chris_Stewart_5 has quit IRC
 212017-09-01T00:40:10  *** Aaronvan_ is now known as AaronvanW
 222017-09-01T00:40:39  *** unholymachine has quit IRC
 232017-09-01T00:41:55  *** Deacyde has joined #bitcoin-core-dev
 242017-09-01T00:46:21  *** dabura667 has quit IRC
 252017-09-01T00:46:27  <achow101> well while trying to debug that thing, I found a different bug :/
 262017-09-01T00:47:08  *** unholymachine has joined #bitcoin-core-dev
 272017-09-01T01:05:05  <sipa> achow101: you're on a roll
 282017-09-01T01:06:38  <achow101> sipa: can you help? This is as far as I got: https://github.com/bitcoin/bitcoin/issues/11171#issuecomment-326457725
 292017-09-01T01:06:56  <achow101> I'm not sure if I've gone down the wrong rabbit hole or if I am just not seeing something
 302017-09-01T01:11:48  <sipa> achow101: calling a virtual method on a null pointer will cause a segfault, but this is not true for normal methods (though it's undefined behaviour, in practice the method just gets called with a this == nullptr)
 312017-09-01T01:12:11  <sipa> of course, if the called method tries to access any class fields, a segfault will occur
 322017-09-01T01:14:09  *** jonasschnelli has quit IRC
 332017-09-01T01:14:09  *** jonasschnelli has joined #bitcoin-core-dev
 342017-09-01T01:14:14  <achow101> is there a virtual method here?
 352017-09-01T01:14:37  <sipa> i don't know - i know almost nothing about the GUI code
 362017-09-01T01:20:33  *** belcher has quit IRC
 372017-09-01T01:22:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 382017-09-01T01:28:11  *** belcher has joined #bitcoin-core-dev
 392017-09-01T01:44:42  *** AaronvanW has quit IRC
 402017-09-01T01:56:32  *** Dyaheon has quit IRC
 412017-09-01T01:57:52  *** Dyaheon has joined #bitcoin-core-dev
 422017-09-01T02:38:06  *** dabura667 has joined #bitcoin-core-dev
 432017-09-01T02:40:01  *** Chris_Stewart_5 has quit IRC
 442017-09-01T02:41:04  *** dabura667 has quit IRC
 452017-09-01T02:51:18  *** Murch has quit IRC
 462017-09-01T03:11:58  *** dabura667 has joined #bitcoin-core-dev
 472017-09-01T03:12:49  *** JackH has quit IRC
 482017-09-01T03:14:15  *** JackH has joined #bitcoin-core-dev
 492017-09-01T03:38:06  *** lifeofguenter has quit IRC
 502017-09-01T03:42:34  *** lifeofguenter has joined #bitcoin-core-dev
 512017-09-01T04:07:27  <kallewoof> Ugh... I didn't realize the mempool propagated quite as slowly as it does. I have 3 public nodes (one has been up for months, one for a week or two, and one was started up yesterday). The mempools on each is quite different. 4827 entries for the longest running one, 2848 for the second and 802 for the third.
 522017-09-01T04:08:52  <sipa> that's not necessarily due to propagation
 532017-09-01T04:08:52  <kallewoof> What else could be causing it?
 542017-09-01T04:09:02  <sipa> if the differences are in transactions that (directly or indirectly) depend on unconfirmed transactions that were in the older running nodes but not in the newer ones, that's expected
 552017-09-01T04:09:12  <sipa> there is no mempool reconciliation
 562017-09-01T04:09:51  <kallewoof> So most of the extra cruft would be for low fee txs that are not making it into blocks for a long time?
 572017-09-01T04:10:05  <kallewoof> Oh wait, I see what you're saying
 582017-09-01T04:11:15  <kallewoof> Node gets a tx with an input that is unconfirmed and unknown and the node discards it. Or wait, it puts it in orphanTx vector, right? Maybe I can use that to get a better picture..
 592017-09-01T04:14:25  *** RubenSomsen has joined #bitcoin-core-dev
 602017-09-01T04:17:01  <kallewoof> sipa: Weird. It looks like a node will ask for parent txs if it runs into a tx with unknown inputs, presuming it hasn't rejected any of its parents before. Doesn't that address what you said?
 612017-09-01T04:18:19  <kallewoof> for loop over vin that does `if (!AlreadyHave(_inv)) pfrom->AskFor(_inv);` (net_processing.cpp somewhere around line 1900 or so)
 622017-09-01T04:18:58  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 632017-09-01T04:21:39  <sipa> kallewoof: perhaps they already have a conflict for the parent?
 642017-09-01T04:23:27  <kallewoof> I could see that be the case for a couple of transactions (having a double spent parent I guess? where one node sees one and the other sees the other), but the old node has 4x the # of txs compared to the 1 day old one. seems high.
 652017-09-01T04:24:06  <kallewoof> Connection counts are 63, 17, 14 which might mean that some txs simply don't get very far (need lots of peers to see them), but maybe there's another reason.
 662017-09-01T04:24:28  <kallewoof> s/which might mean/which might indicate/
 672017-09-01T04:25:13  *** Chris_Stewart_5 has quit IRC
 682017-09-01T04:44:24  *** Murch has joined #bitcoin-core-dev
 692017-09-01T04:51:36  *** JackH has quit IRC
 702017-09-01T04:59:43  *** JackH has joined #bitcoin-core-dev
 712017-09-01T05:00:30  *** ghost43 has quit IRC
 722017-09-01T05:08:43  *** ghost43 has joined #bitcoin-core-dev
 732017-09-01T05:09:49  *** luke-jr has quit IRC
 742017-09-01T05:11:45  *** luke-jr has joined #bitcoin-core-dev
 752017-09-01T05:23:02  *** Dyaheon has quit IRC
 762017-09-01T05:23:34  *** Dyaheon has joined #bitcoin-core-dev
 772017-09-01T05:38:26  *** meshcollider has joined #bitcoin-core-dev
 782017-09-01T05:47:42  *** Deadhand has quit IRC
 792017-09-01T05:50:20  *** Deadhand has joined #bitcoin-core-dev
 802017-09-01T06:00:54  *** Cory has joined #bitcoin-core-dev
 812017-09-01T06:04:02  *** c40d9b0743a91f40 has quit IRC
 822017-09-01T06:04:58  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 832017-09-01T06:07:41  *** RubenSomsen has quit IRC
 842017-09-01T06:08:55  *** c40d9b0743a91f40 has quit IRC
 852017-09-01T06:13:45  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 862017-09-01T06:14:13  *** c40d9b0743a91f40 has quit IRC
 872017-09-01T06:14:34  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 882017-09-01T06:16:41  *** Giszmo has quit IRC
 892017-09-01T06:18:35  *** sam_c has quit IRC
 902017-09-01T06:19:22  *** sam_c has joined #bitcoin-core-dev
 912017-09-01T06:22:11  *** lifeofguenter has quit IRC
 922017-09-01T06:26:32  *** c40d9b0743a91f40 has quit IRC
 932017-09-01T06:27:12  *** lifeofguenter has joined #bitcoin-core-dev
 942017-09-01T06:31:46  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 952017-09-01T06:33:16  *** arubi has quit IRC
 962017-09-01T06:34:26  *** c40d9b0743a91f40 has quit IRC
 972017-09-01T06:34:50  *** c40d9b0743a91f40 has joined #bitcoin-core-dev
 982017-09-01T06:37:06  <meshcollider> Since #11171 is being used to discuss the GUI bug could someone please reopen it :)
 992017-09-01T06:38:40  *** Gunnie has joined #bitcoin-core-dev
1002017-09-01T06:41:20  *** lifeofguenter has quit IRC
1012017-09-01T06:45:20  <meshcollider> Thanks sipa
1022017-09-01T06:45:51  <sipa> yw!
1032017-09-01T06:47:39  *** lifeofguenter has joined #bitcoin-core-dev
1042017-09-01T06:50:51  <gmaxwell> kallewoof: it will fetch parents but its pretty limited in doing that. It won't fetch things that it just wasn't online to see.
1052017-09-01T06:50:58  <gmaxwell> unless a child shows up.
1062017-09-01T06:51:30  <gmaxwell> in my expirence it normally takes about 24 hours of operation before compact blocks reaches its full hitrate.
1072017-09-01T06:52:21  <gmaxwell> and right now with a flood of very low fee txn you won't pick those up.
1082017-09-01T06:53:04  *** BashCo has quit IRC
1092017-09-01T06:56:02  *** JackH has quit IRC
1102017-09-01T06:57:47  <jimpo> kallewoof: Do you mind dumping the mempools and sharing if you have RPC enabled? I'd be interested in taking a look.
1112017-09-01T07:01:22  <gmaxwell> kallewoof: fwiw, it's a couple line patch to use the mempool rpc to cause a peer to inv you their whole mempool, it's pretty abusive so you should probably only do it to your own nodes. (e.g. make a patch that adds an rpc command to send a mempool message to a particular node id then use it)
1122017-09-01T07:01:33  <gmaxwell> (or at least use it sparingly against anyone else.)
1132017-09-01T07:16:48  *** BashCo has joined #bitcoin-core-dev
1142017-09-01T07:18:07  *** jannes has joined #bitcoin-core-dev
1152017-09-01T07:20:07  <kallewoof> jimpo: lemme see what they look like now after the rush of 8k txs first..
1162017-09-01T07:20:22  <kallewoof> gmaxwell: ahh okay. well, i kind of want these nodes to behave as a normal average joe node so i don't want them to "cheat"
1172017-09-01T07:20:58  <gmaxwell> kallewoof: sure, depends on what you're testing.
1182017-09-01T07:21:47  *** arubi has joined #bitcoin-core-dev
1192017-09-01T07:22:23  <kallewoof> jimpo: they seem to be a bit closer to what you'd expect now. {11022, 9101, 8525} txs for {69, 13, 17} connection count. still interested?
1202017-09-01T07:23:20  <gmaxwell> connection count won't matter.
1212017-09-01T07:23:37  <kallewoof> I assumed connection count would give you better coverage
1222017-09-01T07:23:37  <gmaxwell> just having been online to see the whole backlog matters mostly.
1232017-09-01T07:24:09  <gmaxwell> no, except with very few good peers or something everything gets flooded to every link.
1242017-09-01T07:24:09  <gmaxwell> but old transactions are not sent.
1252017-09-01T07:25:14  <jimpo> kallewoof: Yeah, I'm still interested. I'll see if I can replicate too, but your nodes have been up a lot longer.
1262017-09-01T07:25:15  <kallewoof> one has only been up ~24h
1272017-09-01T07:25:15  *** JackH has joined #bitcoin-core-dev
1282017-09-01T07:25:15  <kallewoof> would getrawmempool output be enough or do you want more details?
1292017-09-01T07:25:15  <jimpo> getrawmempool is great
1302017-09-01T07:25:15  <gmaxwell> so you don't see things that were broadcast before you came online, except where they get pulled in by children. or by an occasional piece of 'helpful' custom software that connects to you and vomits a bunch of old txn at you for inexplicable reasons.
1312017-09-01T07:25:54  *** laurentmt has joined #bitcoin-core-dev
1322017-09-01T07:26:19  <jimpo> Yeah, that's probably why
1332017-09-01T07:29:06  <kallewoof> jimpo: https://bc-2.jp/grm.zip
1342017-09-01T07:29:30  *** laurentmt has quit IRC
1352017-09-01T07:30:43  <kallewoof> gmaxwell: I thought txs were relayed randomly to enhance privacy
1362017-09-01T07:30:52  <kallewoof> I must've gotten that mixezd up with something else.
1372017-09-01T07:33:04  *** laurentmt has joined #bitcoin-core-dev
1382017-09-01T07:38:15  <kallewoof> Hum. I don't think that's my issue, but if someone sent a tx with a fee so low it wouldn't go into mempoo, and someone else CPFP'd that, it wouldn't go into the mempool because parent was rejected, I think. That might not be ideal.
1392017-09-01T07:42:02  <gmaxwell> kallewoof: you can't use CPFP to evade mempool minimums but they are very low.
1402017-09-01T07:42:23  <gmaxwell> kallewoof: they are relayed with randomized delays, in sorted order, but all are relayed.
1412017-09-01T07:43:06  <kallewoof> gmaxwell: OK, so that wouldn't explain the difference unless there had been a ton of new txs recently (which wasn't the case at the time).
1422017-09-01T07:43:19  <gmaxwell> kallewoof: also peers (well, later than 0.12) will not relay you txn which are too low to go into your mempool.
1432017-09-01T07:43:36  * kallewoof nods
1442017-09-01T07:44:52  <gmaxwell> kallewoof: you can look at the recieved times on all the txn in your mempools, I expect that what you will find that all the txn missing from your lower uptime nodes have recieve times before it started.
1452017-09-01T07:57:41  *** Austindoggie has joined #bitcoin-core-dev
1462017-09-01T08:06:57  <kallewoof> gmaxwell: That's a good idea, yeah.
1472017-09-01T08:23:01  *** timothy has joined #bitcoin-core-dev
1482017-09-01T08:41:27  *** vicenteH has joined #bitcoin-core-dev
1492017-09-01T09:10:41  *** Austindoggie has quit IRC
1502017-09-01T09:11:16  *** Austindoggie has joined #bitcoin-core-dev
1512017-09-01T09:11:26  *** Austindoggie has quit IRC
1522017-09-01T09:12:00  *** harrymm has quit IRC
1532017-09-01T09:17:08  *** SopaXorzTaker has joined #bitcoin-core-dev
1542017-09-01T09:22:12  *** riemann has joined #bitcoin-core-dev
1552017-09-01T09:23:21  *** AaronvanW has joined #bitcoin-core-dev
1562017-09-01T09:39:13  *** chjj has quit IRC
1572017-09-01T09:40:56  *** Giszmo has joined #bitcoin-core-dev
1582017-09-01T10:16:27  *** laurentmt has quit IRC
1592017-09-01T10:27:35  *** Murch has quit IRC
1602017-09-01T10:34:11  *** Yogaqueef has joined #bitcoin-core-dev
1612017-09-01T10:38:33  *** RubenSomsen has joined #bitcoin-core-dev
1622017-09-01T10:43:16  *** Guyver2 has joined #bitcoin-core-dev
1632017-09-01T10:53:05  <meshcollider> I've noticed src/test/testutil.cpp|h seem to basically provide nothing, is there anything wrong with removing those files and calling fs::temp_directory_path() directly instead of GetTempPath() ?
1642017-09-01T11:03:31  *** JackH has quit IRC
1652017-09-01T11:06:41  *** Gunnie has quit IRC
1662017-09-01T11:20:07  *** alreadylate has joined #bitcoin-core-dev
1672017-09-01T11:21:46  *** JackH has joined #bitcoin-core-dev
1682017-09-01T11:22:50  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11210: Stop test_bitcoin-qt touching ~/.bitcoin (master...201708_qt_test_dir) https://github.com/bitcoin/bitcoin/pull/11210
1692017-09-01T11:34:54  *** belcher has quit IRC
1702017-09-01T11:45:35  *** shesek has quit IRC
1712017-09-01T11:49:42  *** unholymachine has quit IRC
1722017-09-01T11:52:07  *** unholymachine has joined #bitcoin-core-dev
1732017-09-01T12:03:25  *** dabura667 has quit IRC
1742017-09-01T12:06:39  *** RubenSomsen has quit IRC
1752017-09-01T12:12:10  *** riemann has quit IRC
1762017-09-01T12:12:16  *** dermoth_ has joined #bitcoin-core-dev
1772017-09-01T12:12:33  *** dermoth has quit IRC
1782017-09-01T12:12:35  *** dermoth_ is now known as dermoth
1792017-09-01T12:21:14  *** laurentmt has joined #bitcoin-core-dev
1802017-09-01T12:26:28  *** laurentmt has quit IRC
1812017-09-01T12:27:03  *** RubenSomsen has joined #bitcoin-core-dev
1822017-09-01T12:27:59  *** laurentmt has joined #bitcoin-core-dev
1832017-09-01T13:10:45  *** cryptapus has quit IRC
1842017-09-01T13:13:15  *** cryptapus has joined #bitcoin-core-dev
1852017-09-01T13:13:15  *** cryptapus has joined #bitcoin-core-dev
1862017-09-01T13:15:36  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1872017-09-01T13:21:25  *** harrymm has joined #bitcoin-core-dev
1882017-09-01T13:30:41  *** Chris_Stewart_5 has quit IRC
1892017-09-01T13:42:18  *** jtimon has quit IRC
1902017-09-01T13:43:28  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1912017-09-01T13:52:16  *** Dyaheon has quit IRC
1922017-09-01T13:52:32  *** cheese_ has joined #bitcoin-core-dev
1932017-09-01T13:53:07  *** Dyaheon has joined #bitcoin-core-dev
1942017-09-01T13:55:49  *** RoyceX has quit IRC
1952017-09-01T14:08:11  *** meshcollider has quit IRC
1962017-09-01T14:09:23  <bitcoin-git> [bitcoin] jjz opened pull request #11212: Change the type of BlockStatus to unsigned int  (master...master) https://github.com/bitcoin/bitcoin/pull/11212
1972017-09-01T14:19:07  *** ChesterVal has left #bitcoin-core-dev
1982017-09-01T14:20:56  *** SisterM has joined #bitcoin-core-dev
1992017-09-01T14:27:35  *** esotericnonsense has quit IRC
2002017-09-01T14:31:18  <bitcoin-git> [bitcoin] jnewbery opened pull request #11213: Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
2012017-09-01T14:41:37  *** Chris_Stewart_5 has quit IRC
2022017-09-01T14:42:12  *** esotericnonsense has joined #bitcoin-core-dev
2032017-09-01T14:47:25  *** JackH has quit IRC
2042017-09-01T14:48:12  *** paveljanik has joined #bitcoin-core-dev
2052017-09-01T14:48:13  *** paveljanik has joined #bitcoin-core-dev
2062017-09-01T14:49:10  *** RoyceX has joined #bitcoin-core-dev
2072017-09-01T14:49:47  *** Murch has joined #bitcoin-core-dev
2082017-09-01T14:51:33  *** Gunnie has joined #bitcoin-core-dev
2092017-09-01T14:51:49  *** cheese_ has quit IRC
2102017-09-01T15:23:15  *** BashCo has quit IRC
2112017-09-01T15:23:50  *** BashCo has joined #bitcoin-core-dev
2122017-09-01T15:28:07  *** BashCo has quit IRC
2132017-09-01T15:46:14  *** SopaXorzTaker has quit IRC
2142017-09-01T15:49:03  *** chjj has joined #bitcoin-core-dev
2152017-09-01T15:53:27  *** alreadylate has quit IRC
2162017-09-01T15:53:40  *** SisterM has quit IRC
2172017-09-01T15:57:22  *** BashCo has joined #bitcoin-core-dev
2182017-09-01T15:58:56  *** SopaXorzTaker has joined #bitcoin-core-dev
2192017-09-01T16:01:32  *** ethforever has joined #bitcoin-core-dev
2202017-09-01T16:10:56  <bitcoin-git> [bitcoin] jnewbery closed pull request #11213: [trivial] [rpc] Fix getrawtransaction help for per-txout chainstate db (master...getrawtransactionhelp) https://github.com/bitcoin/bitcoin/pull/11213
2212017-09-01T16:30:59  *** Gabo has joined #bitcoin-core-dev
2222017-09-01T16:34:36  *** Gabo has quit IRC
2232017-09-01T16:37:07  *** RubenSomsen has quit IRC
2242017-09-01T16:49:04  *** dagurval has joined #bitcoin-core-dev
2252017-09-01T16:52:34  <bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/d81dccf191a4...28f788e47e58
2262017-09-01T16:52:35  <bitcoin-git> bitcoin/master be2a2ab John Newbery: [tests] fix - use rpc_timeout as rpc timeout
2272017-09-01T16:52:35  <bitcoin-git> bitcoin/master 36b6268 John Newbery: [tests] TestNode: separate add_node from start_node...
2282017-09-01T16:52:36  <bitcoin-git> bitcoin/master 6cf094a John Newbery: [tests] Avoid passing around member variables in test_framework
2292017-09-01T16:53:20  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11121: TestNode tidyups (master...test_node_tidyups) https://github.com/bitcoin/bitcoin/pull/11121
2302017-09-01T16:56:24  *** RubenSomsen has joined #bitcoin-core-dev
2312017-09-01T17:02:44  *** abpa has joined #bitcoin-core-dev
2322017-09-01T17:05:29  *** CubicEarth has joined #bitcoin-core-dev
2332017-09-01T17:10:37  <bitcoin-git> [bitcoin] practicalswift closed pull request #11190: [tests] Remove unused imports (script.OP_0 and script.sha256) (master...remove-unused-import-op_0) https://github.com/bitcoin/bitcoin/pull/11190
2342017-09-01T17:16:33  *** Yogaqueef has quit IRC
2352017-09-01T17:19:28  *** Aaronvan_ has joined #bitcoin-core-dev
2362017-09-01T17:21:48  *** AaronvanW has quit IRC
2372017-09-01T17:29:41  *** lifeofguenter has quit IRC
2382017-09-01T17:31:24  *** lifeofguenter has joined #bitcoin-core-dev
2392017-09-01T17:44:01  *** CubicEar_ has joined #bitcoin-core-dev
2402017-09-01T17:44:42  *** CubicEarth has quit IRC
2412017-09-01T17:54:52  <GAit> jnewbery: thanks for the more feedback, updated the PR let me know if/when you want me to squash
2422017-09-01T18:05:53  *** Giszmo has quit IRC
2432017-09-01T18:07:01  *** CubicEar_ has quit IRC
2442017-09-01T18:07:22  <paveljanik> Please close #11202
2452017-09-01T18:09:47  *** CubicEarth has joined #bitcoin-core-dev
2462017-09-01T18:13:05  *** timothy has quit IRC
2472017-09-01T18:21:00  <jnewbery> MarcoFalke : silent merge conflict for #11121 :( I'll open a fixup PR
2482017-09-01T18:21:23  <jnewbery> (bitcoin_cli.py didn't have the set_test_params() override)
2492017-09-01T18:24:17  *** CubicEarth has quit IRC
2502017-09-01T18:26:01  <bitcoin-git> [bitcoin] jnewbery opened pull request #11215: [tests] fixups from set_test_params() (master...bitcoin_cli_set_test_params) https://github.com/bitcoin/bitcoin/pull/11215
2512017-09-01T18:26:29  <jnewbery> #11215 fixes it. Master won't be able to pass travis until that's merged.
2522017-09-01T18:27:05  <jnewbery> wumpus sipa ^^ 2 line change in test file - can review/merge please?
2532017-09-01T18:36:41  *** Dyaheon has quit IRC
2542017-09-01T18:38:57  *** Dyaheon has joined #bitcoin-core-dev
2552017-09-01T19:22:29  *** Giszmo has joined #bitcoin-core-dev
2562017-09-01T19:31:02  *** alreadylate has joined #bitcoin-core-dev
2572017-09-01T19:35:52  *** alreadylate has quit IRC
2582017-09-01T19:59:30  *** AaronvanW has joined #bitcoin-core-dev
2592017-09-01T20:02:04  *** SopaXorzTaker has quit IRC
2602017-09-01T20:02:57  *** Aaronvan_ has quit IRC
2612017-09-01T20:42:57  *** Dyaheon has quit IRC
2622017-09-01T20:45:05  *** Dyaheon has joined #bitcoin-core-dev
2632017-09-01T21:06:29  *** Guyver2 has quit IRC
2642017-09-01T21:13:13  *** CubicEarth has joined #bitcoin-core-dev
2652017-09-01T21:14:32  *** CubicEarth has quit IRC
2662017-09-01T21:14:50  *** meshcollider has joined #bitcoin-core-dev
2672017-09-01T21:27:25  *** laurentmt has quit IRC
2682017-09-01T21:41:15  *** Gunnie has quit IRC
2692017-09-01T21:55:01  *** str4d has joined #bitcoin-core-dev
2702017-09-01T21:55:50  *** paveljanik has quit IRC
2712017-09-01T22:16:00  *** RubenSomsen has quit IRC
2722017-09-01T22:20:02  *** praxeology1 has joined #bitcoin-core-dev
2732017-09-01T22:23:35  *** praxeology has quit IRC
2742017-09-01T22:52:22  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/28f788e47e58...ec20f01ba094
2752017-09-01T22:52:22  <bitcoin-git> bitcoin/master 3918d93 John Newbery: [tests] fixups from set_test_params()
2762017-09-01T22:52:23  <bitcoin-git> bitcoin/master ec20f01 Pieter Wuille: Merge #11215: [tests] fixups from set_test_params()...
2772017-09-01T22:53:03  <bitcoin-git> [bitcoin] sipa closed pull request #11215: [tests] fixups from set_test_params() (master...bitcoin_cli_set_test_params) https://github.com/bitcoin/bitcoin/pull/11215
2782017-09-01T23:04:47  *** Cheeseo has joined #bitcoin-core-dev
2792017-09-01T23:14:07  *** elkalamar has joined #bitcoin-core-dev
2802017-09-01T23:14:21  *** Cheeseo has quit IRC
2812017-09-01T23:26:22  *** belcher has joined #bitcoin-core-dev
2822017-09-01T23:31:01  *** elkalamar has quit IRC
2832017-09-01T23:58:15  *** abpa has quit IRC