12017-09-04T00:02:35  <meshcollider> no not that one, the one about the qt test directory
  22017-09-04T00:02:48  <meshcollider> I got the catch statement thing haha I was only joking :)
  32017-09-04T00:02:58  <meshcollider> I appreciate the reviews :)
  42017-09-04T00:03:04  <sipa> oh
  52017-09-04T00:03:22  <sipa> any reason why the non-qt tests wouldn't need that datadir logic?
  62017-09-04T00:03:45  *** venzen has quit IRC
  72017-09-04T00:05:49  <meshcollider> they have it I thought? Its here for example: https://github.com/bitcoin/bitcoin/blob/master/src/test/test_bitcoin.cpp#L63
  82017-09-04T00:05:54  <sipa> oh
  92017-09-04T00:06:39  <sipa> meshcollider: ignore me
 102017-09-04T00:08:10  <meshcollider> Ok but just this once ;) I pushed the fix for your last nit for the iswitness decode parameter btw
 112017-09-04T00:13:13  *** AaronvanW has joined #bitcoin-core-dev
 122017-09-04T00:16:13  <sipa> awesome, thanks
 132017-09-04T00:17:55  *** goatpig has quit IRC
 142017-09-04T00:19:07  <meshcollider> I'm sitting on a bus for 8 hours today across the country, anything would be useful for me to work on while I'm sitting here? Otherwise I'll just go and review some more PRs
 152017-09-04T00:21:52  *** lupi has quit IRC
 162017-09-04T00:23:57  *** Cheeseo has joined #bitcoin-core-dev
 172017-09-04T00:24:32  *** tripleslash has quit IRC
 182017-09-04T00:26:17  *** RoyceX has joined #bitcoin-core-dev
 192017-09-04T00:26:42  *** tripleslash has joined #bitcoin-core-dev
 202017-09-04T00:28:38  *** Cheeseo has quit IRC
 212017-09-04T00:35:41  *** tripleslash has quit IRC
 222017-09-04T00:37:08  *** tripleslash has joined #bitcoin-core-dev
 232017-09-04T00:40:25  *** bytting has quit IRC
 242017-09-04T00:57:29  *** dabura667 has joined #bitcoin-core-dev
 252017-09-04T01:00:09  *** Giszmo has joined #bitcoin-core-dev
 262017-09-04T01:15:28  *** Aaronvan_ has joined #bitcoin-core-dev
 272017-09-04T01:17:21  *** AaronvanW has quit IRC
 282017-09-04T01:19:55  *** lupi has joined #bitcoin-core-dev
 292017-09-04T01:24:28  *** dermoth has quit IRC
 302017-09-04T01:24:54  *** dermoth has joined #bitcoin-core-dev
 312017-09-04T01:25:03  *** Aaronvan_ has quit IRC
 322017-09-04T02:07:58  *** AaronvanW has joined #bitcoin-core-dev
 332017-09-04T02:18:40  *** jjackson502 has joined #bitcoin-core-dev
 342017-09-04T02:19:04  <jjackson502> join
 352017-09-04T02:23:19  *** jjackson502 has quit IRC
 362017-09-04T02:24:31  *** RubenSomsen has joined #bitcoin-core-dev
 372017-09-04T02:26:29  *** AaronvanW has quit IRC
 382017-09-04T02:37:12  *** Giszmo has quit IRC
 392017-09-04T02:49:04  *** RoyceX has quit IRC
 402017-09-04T03:18:01  *** d9b4bef9 has quit IRC
 412017-09-04T03:33:02  *** Dyaheon has quit IRC
 422017-09-04T03:33:59  *** Dyaheon has joined #bitcoin-core-dev
 432017-09-04T03:57:42  <meshcollider> Is it better to keep src/test/testutil.cpp|h for future use even if they're kinda redundant, or better to remove them because it results in fewer source files?
 442017-09-04T04:01:17  *** lupi has quit IRC
 452017-09-04T04:02:13  <sipa> i don't think anyone cares about the number of source files, as long as the separation in files makes sense (don't make a new file for eveey function...)
 462017-09-04T04:17:48  <jimpo> The stall timeout for headers sync (nHeadersSyncTimeout) appears to be a single timeout to sync the whole header chain instead of a smaller timeout for each successive headers message. Why is that?
 472017-09-04T04:21:39  <midnightmagic> +1 no file-per-function nonsense. not everyone uses a class-browser and ignores other structure.
 482017-09-04T04:23:45  <gmaxwell> jimpo: it's not very sophicated right now. I'm sure it could also have several tiers of timeouts, one thing to be warry of is the sum of small timeouts if fed slowly turning into an unreasonably long wait.
 492017-09-04T04:32:27  *** RubenSomsen has quit IRC
 502017-09-04T04:35:15  *** Gunnie has joined #bitcoin-core-dev
 512017-09-04T04:44:13  <meshcollider> midnightmagic: I'm suggesting removing a file with only one function (a redundant function which just calls another), not adding new files
 522017-09-04T04:45:05  * midnightmagic shrugs
 532017-09-04T04:45:21  <gmaxwell> meshcollider: if you don't know you can also feel free to just make a PR to remove it per your best judgement and if you were mistaken people will explain why. No big deal.
 542017-09-04T05:28:22  *** ill has joined #bitcoin-core-dev
 552017-09-04T05:44:10  *** RubenSomsen has joined #bitcoin-core-dev
 562017-09-04T05:54:14  <kallewoof> sipa: Slightly off topic, but a new file for every public class would be sort of nice though (net.h has 4, for example).
 572017-09-04T05:57:25  <sipa> kallewoof: i couldn't disagree more, soory:)
 582017-09-04T05:58:14  <kallewoof> sipa: If they're small, I can live with it, but net.cpp is 3k lines. I think that's a bit long.
 592017-09-04T05:59:13  <sipa> oh, absolutely
 602017-09-04T05:59:28  <sipa> but nrt.cpp is also way more than one class
 612017-09-04T06:01:36  <kallewoof> CConnman is about 2k, the rest is CNetMessage and CNode and random help functions. Not sure what you mean by 'more than one class' -- that's what I'm saying too, it's 3 classes.
 622017-09-04T06:04:00  <kallewoof> Anyway, it was a random thought. I like files to be less than 1k lines if possible. Maybe that's just a personal preference.
 632017-09-04T06:04:15  <sipa> kallewoof: what i mean is that in an ideal world a lot of the functionality in net could be split up into more classes, but i think many of them may still belong in net
 642017-09-04T06:04:52  <sipa> i don't see a 3k line file as a big problem, but it is suboptimal
 652017-09-04T06:05:04  *** Murch has joined #bitcoin-core-dev
 662017-09-04T06:05:22  <sipa> but splitting up every class into its own file is throwing away the ability for files to convey a structure themselves
 672017-09-04T06:08:51  *** sam_c has quit IRC
 682017-09-04T06:17:33  <kallewoof> That makes sense, yeah. I guess my erk is really with file size, not classes in the same file..
 692017-09-04T06:18:18  <sipa> right
 702017-09-04T06:18:37  <sipa> file structure is there to make you help find things
 712017-09-04T06:19:23  <sipa> if you know the name of every class in the project, and how they relate, then i guess one class per file is optimal
 722017-09-04T06:19:58  <sipa> but typically you don't, and if when investigating program flow you need to jump between files all the time, that's also not very helpful
 732017-09-04T06:23:34  <kallewoof> It feels like a lot of file jumping happens right now though. Everything and its aunt seems to at some point go into validation.cpp, for example. I really wish that file was at least 2 or 3 files with distinct purposes.
 742017-09-04T06:24:00  <kallewoof> I know it's been improved though. (I think it was 7k+ lines when I started and it was still called main.cpp)
 752017-09-04T06:25:27  <sipa> kallewoof: right, the key point is "with distinct purposes"
 762017-09-04T06:26:08  *** d9b4bef9 has joined #bitcoin-core-dev
 772017-09-04T06:27:24  * kallewoof nods.
 782017-09-04T06:43:35  *** Gunnie has quit IRC
 792017-09-04T06:45:35  *** paveljanik has quit IRC
 802017-09-04T06:48:39  *** BashCo_ has quit IRC
 812017-09-04T07:13:44  *** BashCo has joined #bitcoin-core-dev
 822017-09-04T07:18:30  *** Gunnie has joined #bitcoin-core-dev
 832017-09-04T07:30:46  *** Guyver2 has joined #bitcoin-core-dev
 842017-09-04T07:35:29  *** Dyaheon has quit IRC
 852017-09-04T07:36:48  *** Dyaheon has joined #bitcoin-core-dev
 862017-09-04T07:57:36  *** paveljanik has joined #bitcoin-core-dev
 872017-09-04T08:02:27  *** meshcollider has quit IRC
 882017-09-04T08:15:19  *** AaronvanW has joined #bitcoin-core-dev
 892017-09-04T08:17:36  *** Aaronvan_ has joined #bitcoin-core-dev
 902017-09-04T08:19:28  *** AaronvanW has quit IRC
 912017-09-04T08:22:54  *** Guyver2 has quit IRC
 922017-09-04T08:28:02  *** d9b4bef9 has quit IRC
 932017-09-04T08:28:33  *** timothy has joined #bitcoin-core-dev
 942017-09-04T08:29:08  *** d9b4bef9 has joined #bitcoin-core-dev
 952017-09-04T08:30:24  *** timothy has joined #bitcoin-core-dev
 962017-09-04T08:36:42  *** mmoya has quit IRC
 972017-09-04T08:44:03  *** Aaronvan_ has quit IRC
 982017-09-04T09:15:04  *** promag has joined #bitcoin-core-dev
 992017-09-04T09:17:36  <promag> > when investigating program flow you need to jump between files all the time, that's also not very helpful
1002017-09-04T09:17:36  <promag> sipa: the same for big files?
1012017-09-04T09:23:32  *** RubenSomsen has quit IRC
1022017-09-04T09:38:41  *** Dyaheon has quit IRC
1032017-09-04T09:41:26  *** Dyaheon has joined #bitcoin-core-dev
1042017-09-04T09:43:48  *** RubenSomsen has joined #bitcoin-core-dev
1052017-09-04T10:08:23  *** meshcollider has joined #bitcoin-core-dev
1062017-09-04T10:14:49  *** AaronvanW has joined #bitcoin-core-dev
1072017-09-04T10:16:18  <Victorsueca> did anyone check my question about Windows GUI fee setting?
1082017-09-04T10:20:14  *** promag has quit IRC
1092017-09-04T10:31:46  *** chjj has quit IRC
1102017-09-04T10:32:31  *** laurentmt has joined #bitcoin-core-dev
1112017-09-04T10:34:10  *** laurentmt has quit IRC
1122017-09-04T11:06:47  <meshcollider> Victorsueca: sorry what question? Link?
1132017-09-04T11:20:43  *** promag has joined #bitcoin-core-dev
1142017-09-04T11:20:59  <Victorsueca> meshcollider: when setting the fee on Windows with the gui it only displayed the estimate for 2 blocks
1152017-09-04T11:21:37  *** intcat has quit IRC
1162017-09-04T11:21:41  <Victorsueca> I was going to ask if it was intended, but seems it's just it was creating fee estimates
1172017-09-04T11:22:27  *** intcat has joined #bitcoin-core-dev
1182017-09-04T11:22:30  <Victorsueca> whatever setting I used would only display "Estimated to begin confirmation within 2 blocks"
1192017-09-04T11:22:48  <Victorsueca> now it's been up for several days and it display up to 150 blocks
1202017-09-04T11:23:20  *** nickler has quit IRC
1212017-09-04T11:25:46  *** nickler has joined #bitcoin-core-dev
1222017-09-04T11:26:01  *** promag has quit IRC
1232017-09-04T11:32:56  *** randy-waterhouse has joined #bitcoin-core-dev
1242017-09-04T11:33:25  *** randy-waterhouse has joined #bitcoin-core-dev
1252017-09-04T11:38:58  <meshcollider> So it's working as expected now?
1262017-09-04T11:39:36  <meshcollider> Btw Travis needs rerunning on #11062 for someone with git superpowers :)
1272017-09-04T11:44:03  <Victorsueca> I have no idea how is it supposed to work, but seems usable to me
1282017-09-04T11:50:19  *** promag has joined #bitcoin-core-dev
1292017-09-04T12:00:18  *** Dyaheon has quit IRC
1302017-09-04T12:03:04  *** Dyaheon has joined #bitcoin-core-dev
1312017-09-04T12:16:26  *** Aaronvan_ has joined #bitcoin-core-dev
1322017-09-04T12:16:30  <trippysalmon> hi, i created a patch for #10757 (see: https://github.com/jtimon/bitcoin/pull/9) only travis is not happy about it in a build (see: https://travis-ci.org/jtimon/bitcoin/builds/271625340)
1332017-09-04T12:16:59  <trippysalmon> how do i go about debugging this? i've run the extended tests locally and it doesn't give an error
1342017-09-04T12:19:13  *** AaronvanW has quit IRC
1352017-09-04T12:20:59  *** promag has quit IRC
1362017-09-04T12:24:49  *** SopaXorzTaker has joined #bitcoin-core-dev
1372017-09-04T12:27:52  *** dabura667 has quit IRC
1382017-09-04T12:40:11  *** randy-waterhouse has quit IRC
1392017-09-04T12:47:39  *** Giszmo has joined #bitcoin-core-dev
1402017-09-04T13:16:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
1412017-09-04T13:20:00  *** Aaronvan_ has quit IRC
1422017-09-04T13:21:28  *** promag has joined #bitcoin-core-dev
1432017-09-04T13:23:36  *** AaronvanW has joined #bitcoin-core-dev
1442017-09-04T13:24:18  *** Aaronvan_ has joined #bitcoin-core-dev
1452017-09-04T13:26:05  *** promag has quit IRC
1462017-09-04T13:27:59  *** AaronvanW has quit IRC
1472017-09-04T13:34:54  *** AaronvanW has joined #bitcoin-core-dev
1482017-09-04T13:38:47  *** Aaronvan_ has quit IRC
1492017-09-04T13:42:31  *** RubenSomsen has quit IRC
1502017-09-04T13:42:43  *** RubenSomsen has joined #bitcoin-core-dev
1512017-09-04T13:45:02  *** yourmom has joined #bitcoin-core-dev
1522017-09-04T13:48:05  *** meshcollider has quit IRC
1532017-09-04T14:07:08  *** Dyaheon has quit IRC
1542017-09-04T14:08:12  *** Dyaheon has joined #bitcoin-core-dev
1552017-09-04T14:12:39  *** paveljanik has joined #bitcoin-core-dev
1562017-09-04T14:12:40  *** paveljanik has joined #bitcoin-core-dev
1572017-09-04T14:15:00  *** Aaronvan_ has joined #bitcoin-core-dev
1582017-09-04T14:16:18  *** lupi has joined #bitcoin-core-dev
1592017-09-04T14:18:42  *** AaronvanW has quit IRC
1602017-09-04T14:19:51  *** unholymachine has quit IRC
1612017-09-04T14:20:33  *** Aaronvan_ has quit IRC
1622017-09-04T14:21:12  *** AaronvanW has joined #bitcoin-core-dev
1632017-09-04T14:25:34  *** AaronvanW has quit IRC
1642017-09-04T14:28:00  *** promag has joined #bitcoin-core-dev
1652017-09-04T14:28:07  *** unholymachine has joined #bitcoin-core-dev
1662017-09-04T14:29:40  *** promag has quit IRC
1672017-09-04T14:31:29  *** promag has joined #bitcoin-core-dev
1682017-09-04T14:38:37  *** unholymachine has quit IRC
1692017-09-04T14:44:38  *** justanotheruser has joined #bitcoin-core-dev
1702017-09-04T14:46:20  *** unholymachine has joined #bitcoin-core-dev
1712017-09-04T14:46:24  *** justanotheruser has quit IRC
1722017-09-04T14:46:35  *** justanotheruser has joined #bitcoin-core-dev
1732017-09-04T14:51:36  *** promag has quit IRC
1742017-09-04T14:52:40  *** intcat has quit IRC
1752017-09-04T14:54:25  *** justanotheruser has quit IRC
1762017-09-04T14:58:51  *** AaronvanW has joined #bitcoin-core-dev
1772017-09-04T14:59:41  *** intcat has joined #bitcoin-core-dev
1782017-09-04T15:00:29  *** AaronvanW has quit IRC
1792017-09-04T15:19:33  *** promag has joined #bitcoin-core-dev
1802017-09-04T15:23:48  *** promag has quit IRC
1812017-09-04T15:25:37  *** Squidicuz has quit IRC
1822017-09-04T15:41:14  *** justanotheruser has joined #bitcoin-core-dev
1832017-09-04T15:48:10  <bitcoin-git> [bitcoin] jnewbery opened pull request #11230: [tests] fixup dbcrash interaction with add_nodes() (master...fixup_dbcrash) https://github.com/bitcoin/bitcoin/pull/11230
1842017-09-04T15:50:23  *** DrBenway has joined #bitcoin-core-dev
1852017-09-04T15:59:59  *** RoyceX has joined #bitcoin-core-dev
1862017-09-04T16:02:32  *** Cheeseo has joined #bitcoin-core-dev
1872017-09-04T16:05:17  *** RoyceX has quit IRC
1882017-09-04T16:11:39  *** Dyaheon has quit IRC
1892017-09-04T16:12:16  *** Dyaheon has joined #bitcoin-core-dev
1902017-09-04T16:25:14  *** Cheeseo has quit IRC
1912017-09-04T16:40:13  *** laurentmt has joined #bitcoin-core-dev
1922017-09-04T16:40:47  *** laurentmt has quit IRC
1932017-09-04T16:41:49  *** dgenr8 has joined #bitcoin-core-dev
1942017-09-04T16:47:21  *** timothy has quit IRC
1952017-09-04T16:48:16  *** BashCo has quit IRC
1962017-09-04T16:48:51  *** BashCo has joined #bitcoin-core-dev
1972017-09-04T16:53:20  *** BashCo has quit IRC
1982017-09-04T17:00:20  *** ula has joined #bitcoin-core-dev
1992017-09-04T17:05:32  *** justanotheruser has quit IRC
2002017-09-04T17:07:30  *** promag has joined #bitcoin-core-dev
2012017-09-04T17:11:47  *** promag has quit IRC
2022017-09-04T17:23:03  *** AaronvanW has joined #bitcoin-core-dev
2032017-09-04T17:41:15  <bitcoin-git> [bitcoin] danra opened pull request #11231: Improve netaddress implementation (master...refactor/safe-netaddress) https://github.com/bitcoin/bitcoin/pull/11231
2042017-09-04T17:56:05  *** BashCo has joined #bitcoin-core-dev
2052017-09-04T18:00:09  *** RubenSomsen has quit IRC
2062017-09-04T18:02:25  *** promag has joined #bitcoin-core-dev
2072017-09-04T18:05:54  *** laurentmt has joined #bitcoin-core-dev
2082017-09-04T18:06:46  *** promag has quit IRC
2092017-09-04T18:16:23  *** promag has joined #bitcoin-core-dev
2102017-09-04T18:18:00  *** Veseli_Zagorec has joined #bitcoin-core-dev
2112017-09-04T18:25:25  *** promag has quit IRC
2122017-09-04T18:27:58  *** echonaut has joined #bitcoin-core-dev
2132017-09-04T18:28:33  *** laurentmt1 has joined #bitcoin-core-dev
2142017-09-04T18:28:41  *** Cheeseo has joined #bitcoin-core-dev
2152017-09-04T18:29:32  *** laurentmt has quit IRC
2162017-09-04T18:29:33  *** laurentmt1 is now known as laurentmt
2172017-09-04T18:30:39  *** Muis_ has joined #bitcoin-core-dev
2182017-09-04T18:30:39  *** nejon_ has joined #bitcoin-core-dev
2192017-09-04T18:30:41  *** brg444_ has joined #bitcoin-core-dev
2202017-09-04T18:30:41  *** mariorz_ has joined #bitcoin-core-dev
2212017-09-04T18:31:11  *** Guyver2 has joined #bitcoin-core-dev
2222017-09-04T18:33:32  *** roasbeef_ has joined #bitcoin-core-dev
2232017-09-04T18:36:27  *** ryanofsky_ has joined #bitcoin-core-dev
2242017-09-04T18:36:27  *** chainhead_ has joined #bitcoin-core-dev
2252017-09-04T18:36:36  *** atroxes_ has joined #bitcoin-core-dev
2262017-09-04T18:37:25  *** musalbas- has joined #bitcoin-core-dev
2272017-09-04T18:37:35  *** Chris_Stewart_5 has quit IRC
2282017-09-04T18:37:36  *** btcdrak has quit IRC
2292017-09-04T18:37:36  *** cheese_ has quit IRC
2302017-09-04T18:37:36  *** Orion3k has quit IRC
2312017-09-04T18:37:36  *** echonaut3 has quit IRC
2322017-09-04T18:37:37  *** brg444 has quit IRC
2332017-09-04T18:37:37  *** mariorz has quit IRC
2342017-09-04T18:37:37  *** Muis has quit IRC
2352017-09-04T18:37:38  *** roasbeef has quit IRC
2362017-09-04T18:37:38  *** ryanofsky has quit IRC
2372017-09-04T18:37:38  *** griswaalt[m] has quit IRC
2382017-09-04T18:37:39  *** atroxes has quit IRC
2392017-09-04T18:37:39  *** musalbas has quit IRC
2402017-09-04T18:37:39  *** nejon has quit IRC
2412017-09-04T18:37:39  *** _flow_ has quit IRC
2422017-09-04T18:37:39  *** chainhead has quit IRC
2432017-09-04T18:37:39  *** atroxes_ is now known as atroxes
2442017-09-04T18:37:40  *** Muis_ is now known as Muis
2452017-09-04T18:37:45  *** brg444_ is now known as brg444
2462017-09-04T18:37:46  *** mariorz_ is now known as mariorz
2472017-09-04T18:37:51  *** nejon_ is now known as nejon
2482017-09-04T18:37:52  *** musalbas- is now known as musalbas
2492017-09-04T18:38:17  *** chainhead_ is now known as chainhead
2502017-09-04T18:39:48  *** promag has joined #bitcoin-core-dev
2512017-09-04T18:40:37  *** jimpo has quit IRC
2522017-09-04T18:40:49  *** RubenSomsen has joined #bitcoin-core-dev
2532017-09-04T18:41:53  *** BCBot_ has joined #bitcoin-core-dev
2542017-09-04T18:42:05  *** BCBot has quit IRC
2552017-09-04T18:42:05  *** Cory has quit IRC
2562017-09-04T18:42:05  *** fydel has quit IRC
2572017-09-04T18:42:06  *** spinza has quit IRC
2582017-09-04T18:42:40  *** fydel has joined #bitcoin-core-dev
2592017-09-04T18:42:45  *** jimpo has joined #bitcoin-core-dev
2602017-09-04T18:43:50  *** Orion3k has joined #bitcoin-core-dev
2612017-09-04T18:47:52  *** _flow_ has joined #bitcoin-core-dev
2622017-09-04T18:47:58  *** Pasha has joined #bitcoin-core-dev
2632017-09-04T18:48:05  *** shesek has quit IRC
2642017-09-04T18:48:19  *** spinza has joined #bitcoin-core-dev
2652017-09-04T18:49:28  *** griswaalt[m] has joined #bitcoin-core-dev
2662017-09-04T18:51:09  *** Pasha is now known as Cory
2672017-09-04T18:53:41  *** BCBot_ has quit IRC
2682017-09-04T18:54:04  *** BCBot has joined #bitcoin-core-dev
2692017-09-04T19:07:30  *** SopaXorzTaker has quit IRC
2702017-09-04T19:09:54  *** promag has quit IRC
2712017-09-04T19:10:53  *** roasbeef_ is now known as roasbeef
2722017-09-04T19:22:25  <jnewbery> trippysalmon : that's a really weird failure. The test framework is failing to read a username:password from a file, even though it previously read them successfully. I think this must be some random Travis failure. I suggest you ask jtimon to restart the Travis job (since it's a PR to his repo)
2732017-09-04T19:22:58  <sipa> i can restart jobs
2742017-09-04T19:23:24  <trippysalmon> jnewbery: thanks, i thought something like that might be the case, haven't looked to deep into it after i found that out
2752017-09-04T19:23:35  *** Aaronvan_ has joined #bitcoin-core-dev
2762017-09-04T19:23:45  <trippysalmon> sipa: that would be great
2772017-09-04T19:23:52  <sipa> which PR, sorry?
2782017-09-04T19:24:32  <trippysalmon> it's PR #9, but it's on jtimon's repo
2792017-09-04T19:24:38  <sipa> oh!
2802017-09-04T19:24:40  <sipa> then i can't
2812017-09-04T19:25:01  *** AaronvanW has quit IRC
2822017-09-04T19:25:03  <trippysalmon> aww, thanks anyway, i'll ask jtimon when i see him around
2832017-09-04T19:30:31  *** promag has joined #bitcoin-core-dev
2842017-09-04T19:31:59  *** paveljanik has quit IRC
2852017-09-04T19:33:32  *** Veseli_Zagorec has quit IRC
2862017-09-04T19:34:56  *** promag has quit IRC
2872017-09-04T19:40:02  *** cheese_ has joined #bitcoin-core-dev
2882017-09-04T19:40:33  *** PRab has joined #bitcoin-core-dev
2892017-09-04T19:41:33  *** lupi has quit IRC
2902017-09-04T19:41:50  *** lupi has joined #bitcoin-core-dev
2912017-09-04T19:46:29  *** cheese_ has quit IRC
2922017-09-04T19:48:26  *** chjj has joined #bitcoin-core-dev
2932017-09-04T19:51:19  <PRab> FYI, I did a gitian build of 0.15.0rc3, installed it (Windows 10 64 bit), had it upgrade my UTXO db (took ~15 minutes), and all appears to be running well! Keep up the great work!!
2942017-09-04T19:56:04  <sipa> PRab: cool
2952017-09-04T20:10:52  *** cheese_ has joined #bitcoin-core-dev
2962017-09-04T20:10:55  *** lupi_ has joined #bitcoin-core-dev
2972017-09-04T20:12:06  *** promag has joined #bitcoin-core-dev
2982017-09-04T20:14:01  *** lupi has quit IRC
2992017-09-04T20:16:08  *** promag has quit IRC
3002017-09-04T20:17:19  <jnewbery> trippysalmon : alternatively, you can  `git commit --amend` to update the timestamp on your most recent commit and then `git push -f`. New timestamp => new SHA => Travis will rerun.
3012017-09-04T20:21:24  <trippysalmon> jnewbery: clever man :) will do that, thanks
3022017-09-04T20:27:12  <MarcoFalke> tripy
3032017-09-04T20:27:23  <MarcoFalke> trippysalmon: The bug was fixed in current master
3042017-09-04T20:27:43  *** btcdrak has joined #bitcoin-core-dev
3052017-09-04T20:27:43  *** Chris_Stewart_5 has joined #bitcoin-core-dev
3062017-09-04T20:27:44  <MarcoFalke> The issue was that the cookie file was not atomically written on creation
3072017-09-04T20:30:48  <trippysalmon> MarcoFalke: ah ok, thanks for letting me know. this is my first time working on the core codebase so i was unsure if it was my mistake or not
3082017-09-04T20:31:08  <trippysalmon> ill leave the code as it is then and assume it will work out
3092017-09-04T20:31:37  <MarcoFalke> Jup, rerunning should work around the issue
3102017-09-04T20:32:43  <trippysalmon> it's currently running so i hope you're right
3112017-09-04T20:32:46  *** promag has joined #bitcoin-core-dev
3122017-09-04T20:36:53  *** promag has quit IRC
3132017-09-04T20:38:40  *** laurentmt has quit IRC
3142017-09-04T20:46:09  *** RoyceX has joined #bitcoin-core-dev
3152017-09-04T20:49:32  *** Dyaheon has quit IRC
3162017-09-04T20:49:50  *** cheese_ has quit IRC
3172017-09-04T20:50:07  *** Dyaheon has joined #bitcoin-core-dev
3182017-09-04T20:53:23  *** promag has joined #bitcoin-core-dev
3192017-09-04T20:54:19  *** Gunnie has quit IRC
3202017-09-04T20:54:45  <trippysalmon> okay all jobs finished successfully, thanks all
3212017-09-04T20:57:32  *** promag has quit IRC
3222017-09-04T20:58:05  *** Chris_Stewart_5 has quit IRC
3232017-09-04T20:58:23  *** DrBenway has quit IRC
3242017-09-04T21:30:58  *** AaronvanW has joined #bitcoin-core-dev
3252017-09-04T21:32:35  *** Aaronvan_ has quit IRC
3262017-09-04T21:40:29  *** lupi_ has quit IRC
3272017-09-04T21:45:17  *** promag has joined #bitcoin-core-dev
3282017-09-04T21:47:09  <BlueMatt> note: after #10387 (or some way to identify a node as full but pruned) we should stop accepting requests to fast-relay compact blocks pre-validation from non-full nodes. Its a drastic reduction in their security model and unlikely to be worth the tiny change in relay time. I'm especially concerned that some of the spv clients are going to implement compact blocks and then someone who had set up bitcoin core as a border/firewall node
3292017-09-04T21:47:11  <BlueMatt> between their spv wallet and the world will suddenly have only spv security instead of full security without them even noticing
3302017-09-04T21:51:19  <bitcoin-git> [bitcoin] practicalswift closed pull request #10972: [Qt] Check return value of addr.GetKeyID(keyid) on custom change address change (master...GetKeyID-assertion) https://github.com/bitcoin/bitcoin/pull/10972
3312017-09-04T21:52:32  <promag> should be foo(const CAmount& amount) or foo(CAmount amount) ?
3322017-09-04T21:54:58  <BlueMatt> I think we use both...cause CAmount is secretly just int64_t I'm not sure it matters, but there was some idea of making CAmount assert that you dont overflow at some point in the future
3332017-09-04T21:54:59  *** Guyver2 has quit IRC
3342017-09-04T21:55:10  <BlueMatt> I think & is maybe slightly more-used
3352017-09-04T21:55:11  <BlueMatt> iirc
3362017-09-04T21:58:44  *** tiagotrs has joined #bitcoin-core-dev
3372017-09-04T22:05:10  *** cyre has joined #bitcoin-core-dev
3382017-09-04T22:06:55  <promag> yes it is, ty
3392017-09-04T22:11:12  *** cyre has quit IRC
3402017-09-04T22:11:22  *** afk11 has quit IRC
3412017-09-04T22:11:38  *** afk11 has joined #bitcoin-core-dev
3422017-09-04T22:11:43  *** jouke has quit IRC
3432017-09-04T22:14:35  *** jouke has joined #bitcoin-core-dev
3442017-09-04T22:17:16  <bitcoin-git> [bitcoin] jjz opened pull request #11232: Ensure that data types are consistent (master...master) https://github.com/bitcoin/bitcoin/pull/11232
3452017-09-04T22:19:03  *** RubenSomsen has quit IRC
3462017-09-04T22:19:21  *** RubenSomsen has joined #bitcoin-core-dev
3472017-09-04T22:32:24  *** cheese_ has joined #bitcoin-core-dev
3482017-09-04T22:33:31  *** jasonbcox has joined #bitcoin-core-dev
3492017-09-04T22:35:05  *** tiagotrs has quit IRC
3502017-09-04T22:35:06  *** RoyceX has quit IRC
3512017-09-04T22:45:30  *** cheese_ has quit IRC
3522017-09-04T22:47:07  *** vicenteH has quit IRC
3532017-09-04T22:48:36  *** promag has quit IRC
3542017-09-04T23:12:17  *** jouke has quit IRC
3552017-09-04T23:15:22  *** RubenSomsen has quit IRC
3562017-09-04T23:16:34  *** jouke has joined #bitcoin-core-dev
3572017-09-04T23:16:34  *** jouke has quit IRC
3582017-09-04T23:16:34  *** jouke has joined #bitcoin-core-dev
3592017-09-04T23:21:16  *** promag has joined #bitcoin-core-dev
3602017-09-04T23:58:03  *** Murch has quit IRC