1 2017-09-08T00:00:35  *** NicolasDorier has quit IRC
  2 2017-09-08T00:00:46  <wumpus> luke-jr: no, it's not even clear the issue exists on the rc binaries, jonasschnelli tried on a few windows VMs andcouldn't reproduce with the rcs
  3 2017-09-08T00:00:55  *** NicolasDorier has joined #bitcoin-core-dev
  4 2017-09-08T00:01:37  <jonasschnelli> luke-jr: I could reproduce the GUI offset issue with 0.14.1 on Win7, 8.1 and 10. But 0.15.0rc2 did not had the issue anymore.
  5 2017-09-08T00:01:48  <jonasschnelli> Either its fixed in Qt5.7 or without our sources
  6 2017-09-08T00:02:06  <jonasschnelli> It may still happen to users compiling with an older Qt version (not confirmed)
  7 2017-09-08T00:02:30  <jonasschnelli> (like the tray icon but, etc.)
  8 2017-09-08T00:02:40  <luke-jr> hmm
  9 2017-09-08T00:02:45  <wumpus> yes don't get started on the tray icon... :p
 10 2017-09-08T00:03:02  <luke-jr> can we contact the users who experienced it in RCs, and confirm their setup?
 11 2017-09-08T00:03:23  <luke-jr> gmaxwell said he knew of at least a few
 12 2017-09-08T00:05:09  <midnightmagic> jonasschnelli: Is there somewhere that you've more-strongly linked your GPG key to yourself? Maybe a video or something?
 13 2017-09-08T00:05:44  <wumpus> a gpg key video? lol
 14 2017-09-08T00:07:05  <wumpus> if it is an issue in 0.14.1 it's not a regression in 0.15 anyhow
 15 2017-09-08T00:07:29  <wumpus> there's 0 reasons to hold the release for it, sorry
 16 2017-09-08T00:07:41  <luke-jr> just strange that the reports came in when 0.15rc was out
 17 2017-09-08T00:07:46  <midnightmagic> wumpus: :-) peter todd did one where he reads out the fingerprint.
 18 2017-09-08T00:08:08  <luke-jr> midnightmagic: jonas has lots of signatures on his key :P
 19 2017-09-08T00:08:54  <meshcollider> gmaxwell did you see instagibbs comment on #11280
 20 2017-09-08T00:08:58  <meshcollider> there is no rescan RPC
 21 2017-09-08T00:09:47  <jonasschnelli> midnightmagic: a video?
 22 2017-09-08T00:10:32  <jonasschnelli> there are tons of merges and commits with my GPG signature... what would a video improve?
 23 2017-09-08T00:10:48  <jonasschnelli> There will soon be a video from the SF bitcoin dev meetup with my key fingerprint on the slides.
 24 2017-09-08T00:10:51  <jonasschnelli> That may help
 25 2017-09-08T00:11:29  * luke-jr modifies the slides in that video /s
 26 2017-09-08T00:11:45  <wumpus> no, there is no rescan RPC, just the command line argument
 27 2017-09-08T00:12:02  <midnightmagic> luke-jr: yep. secondary trust is sort of meaningless to me in this context
 28 2017-09-08T00:12:04  <luke-jr> also rescanning isn't possible for pruned nodes?
 29 2017-09-08T00:12:18  <meshcollider> so what's gmaxwell talking about in his comment, if restarting with -rescan won't work with encrypted wallets then is there no fix?
 30 2017-09-08T00:12:30  <wumpus> import* have a  'rescan' argument but I'm not sure that's what is meant
 31 2017-09-08T00:12:52  <luke-jr> I think the "fix" is to unlock the wallet immediately when it starts?
 32 2017-09-08T00:13:16  <meshcollider> nah I doubt that's what he meant, would be pretty hacky if people were required to use an import command to get the rescan going
 33 2017-09-08T00:13:34  <jonasschnelli> There is a rescan RPC call PR: https://github.com/bitcoin/bitcoin/pull/7061
 34 2017-09-08T00:13:42  <jonasschnelli> (begs for reviews)
 35 2017-09-08T00:14:13  <jonasschnelli> with that rescans would be possible for pruned peers (if one wants to rescan not below the pruned depth)
 36 2017-09-08T00:15:50  <meshcollider>  hmm yeah that'd be good, I'll review that later too, but that means we have no fix for 0.15.0?
 37 2017-09-08T00:16:13  <meshcollider> Should I remove that section from the notes entirely or just make a note that support for rescanning will come in a new version
 38 2017-09-08T00:16:16  *** luke-jr has quit IRC
 39 2017-09-08T00:16:25  <gmaxwell> meshcollider: you can rescan from RPC.
 40 2017-09-08T00:16:26  *** luke-jr has joined #bitcoin-core-dev
 41 2017-09-08T00:16:37  <meshcollider> using import commands?
 42 2017-09-08T00:16:42  <gmaxwell> you can use yea..
 43 2017-09-08T00:16:46  <gmaxwell> importmulti
 44 2017-09-08T00:17:02  *** d9b4bef9 has quit IRC
 45 2017-09-08T00:17:04  <wumpus> importmulti without any actual keys or so?
 46 2017-09-08T00:17:16  <wumpus> that definitely needs to be documented, I was not aware of that
 47 2017-09-08T00:17:19  <gmaxwell> but indeed I was forgetting that there is no freestanding 'rescan'.
 48 2017-09-08T00:17:25  <jonasschnelli> with a dummy key/address generated in bip32.org or so
 49 2017-09-08T00:17:34  <gmaxwell> you can scan with a dummy.
 50 2017-09-08T00:17:46  <gmaxwell> which I guess we need to suggest. :(
 51 2017-09-08T00:18:09  *** d9b4bef9 has joined #bitcoin-core-dev
 52 2017-09-08T00:18:29  <meshcollider> importmulti [] {"rescan":true}
 53 2017-09-08T00:18:37  <meshcollider> empty array will work or nah?
 54 2017-09-08T00:18:52  <meshcollider> it doesnt seem to throw any errors
 55 2017-09-08T00:18:54  <jonasschnelli> i don't think so
 56 2017-09-08T00:19:28  <gmaxwell> It won't rescan if there is nothing to do.
 57 2017-09-08T00:20:08  <wumpus> that kind of makes sense, though it's sad in this case
 58 2017-09-08T00:20:51  <midnightmagic> .../lastlog jonasschnelli
 59 2017-09-08T00:21:00  <midnightmagic> sorry
 60 2017-09-08T00:21:05  <luke-jr> jonasschnelli: ! no:|
 61 2017-09-08T00:21:16  <jonasschnelli> aha. :)
 62 2017-09-08T00:21:20  <luke-jr> importing random untrusted stuff is not safe and should definitely not be advised..
 63 2017-09-08T00:21:42  <wumpus> there are certainly some risks to that
 64 2017-09-08T00:22:04  <midnightmagic> jonasschnelli: Yes. That SF bitcoin meetup is perfect. That's neat that peter todd stuffed a blockchain hash into his signature in a certificate notation. I wonder if I'm the only one that's actually checked that. :-)
 65 2017-09-08T00:22:15  <jonasschnelli> Yes. Indeed. You may import a random address from another wallet to trigger a rescan
 66 2017-09-08T00:22:30  <jonasschnelli> But that's why we need #7061
 67 2017-09-08T00:22:33  <jonasschnelli> We are claiming rescans are not required since years... but it seems like they are
 68 2017-09-08T00:23:05  <midnightmagic> jonasschnelli: The consistency of the signatures is not an identity verification of the guy that everyone else has met (but I have not.) :-)
 69 2017-09-08T00:24:06  <jonasschnelli> midnightmagic: happy to drink a coffee with you somewhere in the world.
 70 2017-09-08T00:24:24  <midnightmagic> I would be happy to have a coffee with you if we are ever in the same place together. \o
 71 2017-09-08T00:25:00  <jonasschnelli> That's the difficulty... indeed
 72 2017-09-08T00:27:08  <meshcollider> something like this fine then? https://github.com/bitcoin/bitcoin/pull/11280
 73 2017-09-08T00:27:11  <luke-jr> so encrypted HD backup tl;dr = no solution?
 74 2017-09-08T00:27:56  <meshcollider> no good solution, yeah, they'd have to load another wallet, generate a dummy address, then load their encrypted one and import with rescan
 75 2017-09-08T00:28:53  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/791a0e6ddade...c22a53cd6351
 76 2017-09-08T00:28:54  <bitcoin-git> bitcoin/master d4c18f7 Andrew Chow: Bump wallet version number to 159900
 77 2017-09-08T00:28:54  <bitcoin-git> bitcoin/master 713a920 Andrew Chow: Remove usehd option and warn when it is used...
 78 2017-09-08T00:28:55  <bitcoin-git> bitcoin/master c22a53c Wladimir J. van der Laan: Merge #11250: Bump wallet version to 159900 and remove the `usehd` option...
 79 2017-09-08T00:29:33  <bitcoin-git> [bitcoin] laanwj closed pull request #11250: Bump wallet version to 159900 and remove the `usehd` option (master...bump-wallet-version) https://github.com/bitcoin/bitcoin/pull/11250
 80 2017-09-08T00:30:32  <luke-jr> not sure if release notes are really the place for hacky workarounds for long-standing issues
 81 2017-09-08T00:30:36  <wumpus> meshcollider: thanks for doing 11280, seems it's more work than planned for
 82 2017-09-08T00:30:54  <wumpus> how long-standing?
 83 2017-09-08T00:31:17  <meshcollider> thats fine :) Yeah I'm happy to remove the rescan stuff if needed
 84 2017-09-08T00:31:21  <luke-jr> ever since HD wallets were introduced?
 85 2017-09-08T00:31:51  <meshcollider> Yeah ^ and it will be a hacky-fix-issue until the rescan RPC is merged I guess which means we should all go review jonas's PR asap lol
 86 2017-09-08T00:32:11  <wumpus> well a hacky workaround is better than losing funds
 87 2017-09-08T00:32:31  *** promag has joined #bitcoin-core-dev
 88 2017-09-08T00:32:56  <luke-jr> wumpus: right, but it's not a new issue, so maybe it should just be a blog post or smth?
 89 2017-09-08T00:33:03  <meshcollider> True, people can still ask for support on stackexchange or whatever though, doesn't have to be in the release notes I guess
 90 2017-09-08T00:33:20  * luke-jr watches wumpus put his laptop away
 91 2017-09-08T00:33:40  <meshcollider> Has anyone reported having issues with it so far or is it just a 'could happen'
 92 2017-09-08T00:35:30  <meshcollider> Well, my vote is to leave it in there, having a short Notes/Known Issues section in each release notes is quite a nice idea anyway imo
 93 2017-09-08T00:35:53  <luke-jr> meshcollider: we're all packing up and leaving, so expect a delay in response
 94 2017-09-08T00:36:43  *** promag has quit IRC
 95 2017-09-08T00:39:59  *** hxz has joined #bitcoin-core-dev
 96 2017-09-08T00:40:46  *** fanquake has joined #bitcoin-core-dev
 97 2017-09-08T00:51:27  *** luke-jr has quit IRC
 98 2017-09-08T00:51:35  *** luke-jr has joined #bitcoin-core-dev
 99 2017-09-08T00:55:58  *** fanquake has quit IRC
100 2017-09-08T02:02:20  *** zmin has joined #bitcoin-core-dev
101 2017-09-08T02:14:26  *** dabura667 has joined #bitcoin-core-dev
102 2017-09-08T02:41:04  *** promag has joined #bitcoin-core-dev
103 2017-09-08T02:45:45  *** promag has quit IRC
104 2017-09-08T02:46:06  *** shesek has joined #bitcoin-core-dev
105 2017-09-08T03:03:48  *** RubenSomsen has joined #bitcoin-core-dev
106 2017-09-08T03:15:16  *** PaulCapestany has joined #bitcoin-core-dev
107 2017-09-08T04:01:50  *** PaulCapestany has quit IRC
108 2017-09-08T04:02:27  *** PaulCapestany has joined #bitcoin-core-dev
109 2017-09-08T04:09:04  *** hxz has quit IRC
110 2017-09-08T04:30:33  *** shesek has quit IRC
111 2017-09-08T04:34:05  *** jtimon has quit IRC
112 2017-09-08T04:45:47  *** otoburb has quit IRC
113 2017-09-08T05:02:28  *** Gunnie has joined #bitcoin-core-dev
114 2017-09-08T05:03:21  *** DrOlmer has quit IRC
115 2017-09-08T05:03:47  *** DrOlmer has joined #bitcoin-core-dev
116 2017-09-08T05:30:48  <bitcoin-git> [bitcoin] ajtowns opened pull request #11284: Fix invalid memory access in CScript::operator+= (master...cscript_insert) https://github.com/bitcoin/bitcoin/pull/11284
117 2017-09-08T05:33:35  *** zmin has quit IRC
118 2017-09-08T05:35:54  *** Pebblesbaby has joined #bitcoin-core-dev
119 2017-09-08T05:37:46  *** Pebblesbaby has quit IRC
120 2017-09-08T05:42:24  *** AaronvanW has quit IRC
121 2017-09-08T05:50:03  *** AaronvanW has joined #bitcoin-core-dev
122 2017-09-08T06:25:03  *** tripleslash has quit IRC
123 2017-09-08T06:34:57  *** tripleslash has joined #bitcoin-core-dev
124 2017-09-08T07:13:57  *** laurentmt has joined #bitcoin-core-dev
125 2017-09-08T07:19:04  <meshcollider> the fact that -usehd is still used in wallet.cpp#L3845 is causing all travis builds on master to fail
126 2017-09-08T07:19:08  *** promag has joined #bitcoin-core-dev
127 2017-09-08T07:19:22  <meshcollider> because contrib/devtools/check-doc.py thinks it needs documentation
128 2017-09-08T07:19:54  <meshcollider> so we can either remove it from wallet.cpp, or add an exclusion to check-doc.py I guess
129 2017-09-08T07:20:26  <meshcollider> oh wait actually theres already a list of excluded arguments in check-doc, ill just add it in there
130 2017-09-08T07:23:23  *** promag has quit IRC
131 2017-09-08T07:24:25  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11285: Add -usehd to excluded args in check-doc.py (master...201709_fix_usehd_checkdocs) https://github.com/bitcoin/bitcoin/pull/11285
132 2017-09-08T07:25:50  <meshcollider> That should probably be reviewed quickly because all Travis builds depend on it ^
133 2017-09-08T07:40:18  *** RubenSomsen has quit IRC
134 2017-09-08T07:41:04  *** RubenSomsen has joined #bitcoin-core-dev
135 2017-09-08T07:41:26  *** promag has joined #bitcoin-core-dev
136 2017-09-08T07:55:35  *** RubenSomsen has quit IRC
137 2017-09-08T07:59:58  *** promag has quit IRC
138 2017-09-08T08:03:02  *** d9b4bef9 has quit IRC
139 2017-09-08T08:04:08  *** d9b4bef9 has joined #bitcoin-core-dev
140 2017-09-08T08:16:06  *** timothy has joined #bitcoin-core-dev
141 2017-09-08T08:19:03  *** hxz has joined #bitcoin-core-dev
142 2017-09-08T08:33:34  <bitcoin-git> [bitcoin] fanquake opened pull request #11286: [depends] Don't build libevent sample code (master...dont-build-libevent-samples) https://github.com/bitcoin/bitcoin/pull/11286
143 2017-09-08T08:35:16  *** Guyver2 has joined #bitcoin-core-dev
144 2017-09-08T08:42:35  *** hxz has quit IRC
145 2017-09-08T08:43:42  *** Zenton has joined #bitcoin-core-dev
146 2017-09-08T08:49:04  *** VictorSN has joined #bitcoin-core-dev
147 2017-09-08T08:51:30  *** promag has joined #bitcoin-core-dev
148 2017-09-08T08:55:49  *** promag has quit IRC
149 2017-09-08T09:16:17  *** RubenSomsen has joined #bitcoin-core-dev
150 2017-09-08T09:33:41  *** satoshi has joined #bitcoin-core-dev
151 2017-09-08T09:34:31  *** satoshi has left #bitcoin-core-dev
152 2017-09-08T09:38:36  *** laurentmt1 has joined #bitcoin-core-dev
153 2017-09-08T09:40:15  *** laurentmt has quit IRC
154 2017-09-08T09:40:16  *** laurentmt1 is now known as laurentmt
155 2017-09-08T09:51:21  *** AaronvanW has quit IRC
156 2017-09-08T10:09:03  *** AaronvanW has joined #bitcoin-core-dev
157 2017-09-08T10:11:38  *** echonaut4 has joined #bitcoin-core-dev
158 2017-09-08T10:12:13  *** echonaut has quit IRC
159 2017-09-08T10:13:06  *** hxz has joined #bitcoin-core-dev
160 2017-09-08T10:18:08  *** VictorSN has quit IRC
161 2017-09-08T10:20:11  *** SopaXorzTaker has joined #bitcoin-core-dev
162 2017-09-08T10:24:03  *** belcher has joined #bitcoin-core-dev
163 2017-09-08T10:35:40  *** rockhouse has quit IRC
164 2017-09-08T10:36:56  *** meshcollider has quit IRC
165 2017-09-08T10:37:47  <bitcoin-git> [bitcoin] danra opened pull request #11287: DRY config header inclusion (master...refactor/dry-config) https://github.com/bitcoin/bitcoin/pull/11287
166 2017-09-08T10:58:18  *** gmaxwell has quit IRC
167 2017-09-08T10:59:01  *** gmaxwell has joined #bitcoin-core-dev
168 2017-09-08T10:59:32  *** gmaxwell is now known as Guest9986
169 2017-09-08T11:09:05  *** promag has joined #bitcoin-core-dev
170 2017-09-08T11:10:16  *** promag has quit IRC
171 2017-09-08T11:11:05  *** chjj has quit IRC
172 2017-09-08T11:12:33  *** da2ce7 has quit IRC
173 2017-09-08T11:13:00  *** AaronvanW has quit IRC
174 2017-09-08T11:13:32  *** promag has joined #bitcoin-core-dev
175 2017-09-08T11:13:35  *** AaronvanW has joined #bitcoin-core-dev
176 2017-09-08T11:16:03  *** da2ce7 has joined #bitcoin-core-dev
177 2017-09-08T11:17:42  *** DrOlmer has quit IRC
178 2017-09-08T11:17:55  *** AaronvanW has quit IRC
179 2017-09-08T11:32:45  *** VictorSN has joined #bitcoin-core-dev
180 2017-09-08T11:38:45  *** promag has quit IRC
181 2017-09-08T11:43:43  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11288: More user-friendly error message when partially signing (master...201709_partial_sign_error) https://github.com/bitcoin/bitcoin/pull/11288
182 2017-09-08T12:04:29  *** rockhouse has joined #bitcoin-core-dev
183 2017-09-08T12:04:41  *** rockhouse has joined #bitcoin-core-dev
184 2017-09-08T12:06:37  *** promag has joined #bitcoin-core-dev
185 2017-09-08T12:07:33  *** AaronvanW has joined #bitcoin-core-dev
186 2017-09-08T12:09:22  *** VictorSN has quit IRC
187 2017-09-08T12:09:38  *** VictorSN has joined #bitcoin-core-dev
188 2017-09-08T12:09:57  *** Aaronvan_ has joined #bitcoin-core-dev
189 2017-09-08T12:10:56  *** promag has quit IRC
190 2017-09-08T12:12:44  *** AaronvanW has quit IRC
191 2017-09-08T12:13:09  *** dermoth_ has joined #bitcoin-core-dev
192 2017-09-08T12:13:26  *** dermoth has quit IRC
193 2017-09-08T12:13:28  *** dermoth_ is now known as dermoth
194 2017-09-08T12:23:36  *** ferdousbhai has joined #bitcoin-core-dev
195 2017-09-08T12:23:51  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11289: Add wallet backup text to import* and add* RPCs (master...201709_add_help_text) https://github.com/bitcoin/bitcoin/pull/11289
196 2017-09-08T12:27:09  *** meshcollider has joined #bitcoin-core-dev
197 2017-09-08T12:29:03  *** VictorSN has quit IRC
198 2017-09-08T12:31:13  *** promag has joined #bitcoin-core-dev
199 2017-09-08T12:31:15  *** ferdousbhai has quit IRC
200 2017-09-08T12:38:40  *** promag has quit IRC
201 2017-09-08T12:39:09  *** VictorSN has joined #bitcoin-core-dev
202 2017-09-08T12:52:54  *** Aaronvan_ has quit IRC
203 2017-09-08T12:53:32  *** AaronvanW has joined #bitcoin-core-dev
204 2017-09-08T12:55:16  *** promag has joined #bitcoin-core-dev
205 2017-09-08T12:57:37  *** AaronvanW has quit IRC
206 2017-09-08T13:02:07  *** promag has quit IRC
207 2017-09-08T13:04:48  *** dabura667 has quit IRC
208 2017-09-08T13:07:11  *** promag has joined #bitcoin-core-dev
209 2017-09-08T13:11:14  *** promag has quit IRC
210 2017-09-08T13:12:33  *** promag has joined #bitcoin-core-dev
211 2017-09-08T13:13:17  *** Chris_Stewart_5 has joined #bitcoin-core-dev
212 2017-09-08T13:22:17  *** promag has quit IRC
213 2017-09-08T13:22:50  *** promag has joined #bitcoin-core-dev
214 2017-09-08T13:28:35  *** kinlo has quit IRC
215 2017-09-08T13:31:08  *** kinlo has joined #bitcoin-core-dev
216 2017-09-08T13:37:35  *** kinlo has quit IRC
217 2017-09-08T13:38:22  *** kinlo has joined #bitcoin-core-dev
218 2017-09-08T13:38:46  *** shesek has joined #bitcoin-core-dev
219 2017-09-08T13:38:47  *** shesek has joined #bitcoin-core-dev
220 2017-09-08T13:39:39  *** jtimon has joined #bitcoin-core-dev
221 2017-09-08T13:55:49  *** Gunnie has quit IRC
222 2017-09-08T13:57:36  <jtimon> Args undocumented: 1
223 2017-09-08T13:57:36  <jtimon> set(['-usehd'])
224 2017-09-08T14:08:13  *** wxxs has joined #bitcoin-core-dev
225 2017-09-08T14:22:25  *** promag has quit IRC
226 2017-09-08T14:25:32  *** RubenSomsen has quit IRC
227 2017-09-08T14:25:58  *** RubenSomsen has joined #bitcoin-core-dev
228 2017-09-08T14:30:33  *** RubenSomsen has quit IRC
229 2017-09-08T15:07:12  *** hxz has quit IRC
230 2017-09-08T15:12:38  *** Gunnie has joined #bitcoin-core-dev
231 2017-09-08T15:13:01  *** VictorSN has quit IRC
232 2017-09-08T15:13:20  *** VictorSN has joined #bitcoin-core-dev
233 2017-09-08T15:26:21  *** Mattie161 has quit IRC
234 2017-09-08T15:36:56  *** meshcollider has quit IRC
235 2017-09-08T15:38:41  *** wxxs has quit IRC
236 2017-09-08T15:45:12  *** wxxs has joined #bitcoin-core-dev
237 2017-09-08T16:00:46  *** abpa has joined #bitcoin-core-dev
238 2017-09-08T16:10:39  <sdaftuar> sipa: is using upper case in the human readable part of bech32 addresses not allowed?  that wasn't clear to me from the bip, but it seems to result in broken behavior with eg the python implementation (if i'm doing this right)
239 2017-09-08T16:11:15  *** Zenton has quit IRC
240 2017-09-08T16:12:05  <sdaftuar> ie if you call encode and pass an hrp that contains an upper-case character, then the result doesn't seem to decode
241 2017-09-08T16:21:44  *** pigsalsa has quit IRC
242 2017-09-08T16:22:41  *** LampTreadStone07 has joined #bitcoin-core-dev
243 2017-09-08T16:33:46  <Guest9986> sdaftuar: you have to make the whole thing uppercase or whole thing lowercase.
244 2017-09-08T16:34:14  <sdaftuar> Guest9986: if i understand hrp expansion correctly though, that changes the interpretation of the hrp
245 2017-09-08T16:34:25  <sdaftuar> implying that only lower case is allowed for hrp?
246 2017-09-08T16:36:05  *** Murch has joined #bitcoin-core-dev
247 2017-09-08T16:37:09  <Guest9986> That isn't the intent, for the checksum the lowercase value is used. I think the BIP may be a big ambigious there.
248 2017-09-08T16:37:33  *** LampTreadStone07 has quit IRC
249 2017-09-08T16:37:50  <sdaftuar> i don't think the lowercase value of the hrp is used -- just the lowercase value of the data
250 2017-09-08T16:38:13  *** Guest9986 has quit IRC
251 2017-09-08T16:38:13  *** Guest9986 has joined #bitcoin-core-dev
252 2017-09-08T16:38:22  *** Guest9986 is now known as gmaxwell
253 2017-09-08T16:38:49  *** VictorSN has quit IRC
254 2017-09-08T16:39:39  <sdaftuar> so do you think hrp expansion should first convert to lowercase?
255 2017-09-08T16:42:39  <gmaxwell> both bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4 and BC1QW508D6QEJXTDG4Y5R3ZARVARY0C5XW7KV8F3T4 are accepted by the reference code for me
256 2017-09-08T16:42:58  *** cluelessperson has quit IRC
257 2017-09-08T16:42:59  <sdaftuar> right, but try encoding something with an hrp using capital letters, say "BC"
258 2017-09-08T16:43:05  <sdaftuar> and then try decoding
259 2017-09-08T16:43:23  <sdaftuar> i think that will fail
260 2017-09-08T16:45:06  <gmaxwell> The BIP says: "The lowercase form is used when determining a character's value for checksum purposes.", and the ref code correctly accepts upper and lowercase versions of the same string.  So I think what you're saying is that the encoder doesn't convert the case, but the decoder works fine.
261 2017-09-08T16:45:29  <gmaxwell> So if one uses the encoder with an uppercase hrp you'll get a value that never decodes.
262 2017-09-08T16:45:33  <sdaftuar> yes
263 2017-09-08T16:46:13  <gmaxwell> seems plausable to me, sounds like an implementation bug, though not one that would be a problem for us. (not like the HRP is a user specified value)
264 2017-09-08T16:46:55  *** laurentmt has quit IRC
265 2017-09-08T16:47:04  <sdaftuar> well i wasn't sure if it was an implementation bug or a misunderstanding in my reading of the BIP
266 2017-09-08T16:48:02  <gmaxwell> No misunderstanding on your part, I think: consider, since the decoder works with strings converted to uppercase, your uppercase encodes could never work, not exactly all that useful. :P
267 2017-09-08T16:48:04  <sdaftuar> if we are converting the hrp to lowercase when we encode, then the BIP should probably just make that clear, that hrp values are more restricted
268 2017-09-08T16:49:13  <sdaftuar> if the hrp expansion function treated upper case hrp's the same as lower-case hrp's, it woulnd't be a problem either i guess
269 2017-09-08T16:51:30  *** RubenSomsen has joined #bitcoin-core-dev
270 2017-09-08T16:53:49  *** pigsalsa has joined #bitcoin-core-dev
271 2017-09-08T17:05:16  *** timothy has quit IRC
272 2017-09-08T17:10:57  *** sanjeev has joined #bitcoin-core-dev
273 2017-09-08T17:31:34  <jimpo> Would appreciate reviews on 11113 and 11116
274 2017-09-08T17:43:07  <achow101> seems like travis is all messed up now
275 2017-09-08T18:03:38  *** SopaXorzTaker has quit IRC
276 2017-09-08T18:08:14  *** SopaXorzTaker has joined #bitcoin-core-dev
277 2017-09-08T18:14:24  *** jtimon has quit IRC
278 2017-09-08T18:15:04  *** SopaXorzTaker has quit IRC
279 2017-09-08T18:21:21  <instagibbs> achow101, ok, not just me then
280 2017-09-08T18:22:43  <achow101> instagibbs: apparently that's my fault. We need to merge 11285.
281 2017-09-08T18:23:22  <achow101> I guess this is what happens when things are merged right before leaving for dinner
282 2017-09-08T18:24:43  *** jtimon has joined #bitcoin-core-dev
283 2017-09-08T18:40:49  *** jamesob has joined #bitcoin-core-dev
284 2017-09-08T18:41:08  <jamesob> Have 4 hours on a plane to write some unittests. Any recommendations?
285 2017-09-08T18:41:45  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c22a53cd6351...3255d6347b1f
286 2017-09-08T18:41:45  <bitcoin-git> bitcoin/master 7d03418 MeshCollider: Add -usehd to excluded args in check-doc.py
287 2017-09-08T18:41:46  <bitcoin-git> bitcoin/master 3255d63 Pieter Wuille: Merge #11285: Add -usehd to excluded args in check-doc.py...
288 2017-09-08T18:42:33  <bitcoin-git> [bitcoin] sipa closed pull request #11285: Add -usehd to excluded args in check-doc.py (master...201709_fix_usehd_checkdocs) https://github.com/bitcoin/bitcoin/pull/11285
289 2017-09-08T18:44:17  <sipa> restarting jobs that failed due to usehd doc
290 2017-09-08T18:45:29  <instagibbs> jamesob, feel like there should be a coverage report to look at...
291 2017-09-08T19:06:03  *** AdrianG is now known as aleph_null
292 2017-09-08T19:15:45  <jamesob> instagibbs thanks, I'll take a look at the gcov output
293 2017-09-08T19:16:35  <achow101> jamesob: you can do `./configure --enable-lcov` and then `make cov` and that will make you a testing coverage report
294 2017-09-08T19:17:18  <jamesob> thanks, achow101.
295 2017-09-08T19:42:58  *** jamesob has quit IRC
296 2017-09-08T19:47:35  *** vicenteH has joined #bitcoin-core-dev
297 2017-09-08T20:22:05  *** owowo has quit IRC
298 2017-09-08T20:27:08  *** owowo has joined #bitcoin-core-dev
299 2017-09-08T20:45:05  *** owowo has quit IRC
300 2017-09-08T20:51:29  *** rockhouse has quit IRC
301 2017-09-08T21:00:41  *** owowo has joined #bitcoin-core-dev
302 2017-09-08T21:01:36  *** meshcollider has joined #bitcoin-core-dev
303 2017-09-08T21:25:25  <meshcollider> Anyone else want to review #11280 (release notes)?
304 2017-09-08T21:36:06  *** Guyver2 has quit IRC
305 2017-09-08T21:56:02  *** wxxs has quit IRC
306 2017-09-08T21:57:46  *** promag has joined #bitcoin-core-dev
307 2017-09-08T22:00:55  *** promag_ has joined #bitcoin-core-dev
308 2017-09-08T22:04:02  *** promag has quit IRC
309 2017-09-08T22:06:22  *** Chris_Stewart_5 has quit IRC
310 2017-09-08T22:16:56  *** AaronvanW has joined #bitcoin-core-dev
311 2017-09-08T22:18:14  *** Aaronvan_ has joined #bitcoin-core-dev
312 2017-09-08T22:21:02  *** chjj has joined #bitcoin-core-dev
313 2017-09-08T22:21:32  *** AaronvanW has quit IRC
314 2017-09-08T22:30:33  *** promag_ has quit IRC
315 2017-09-08T22:35:27  <bitcoin-git> [bitcoin] dongsam opened pull request #11291: Fix PEP8 warnings about formatting (master...Fix-PEP8-warnings) https://github.com/bitcoin/bitcoin/pull/11291
316 2017-09-08T22:38:56  *** Gunnie has quit IRC
317 2017-09-08T22:41:30  <meshcollider> sipa: the fix for travis isn't on the 0.15 branch
318 2017-09-08T22:41:52  <meshcollider> That's why its failing for the release notes
319 2017-09-08T22:42:24  <sipa> meshcollider: oh!
320 2017-09-08T22:42:33  <sipa> meshcollider: what commit needs backport?
321 2017-09-08T22:43:08  <meshcollider> https://github.com/bitcoin/bitcoin/commit/aa2e0f09ec94dd0908f792ebc2249859ad174586 I believe
322 2017-09-08T23:08:37  *** Austindoggie has joined #bitcoin-core-dev
323 2017-09-08T23:11:44  *** abpa has quit IRC
324 2017-09-08T23:12:35  *** RubenSomsen has quit IRC
325 2017-09-08T23:13:11  *** promag has joined #bitcoin-core-dev
326 2017-09-08T23:16:11  *** dabura667 has joined #bitcoin-core-dev
327 2017-09-08T23:16:22  *** PaulCapestany has quit IRC
328 2017-09-08T23:17:03  *** PaulCape_ has joined #bitcoin-core-dev
329 2017-09-08T23:17:29  *** promag has quit IRC
330 2017-09-08T23:21:21  <bitcoin-git> [bitcoin] sipa opened pull request #11292: travis: filter out pyenv (0.15...backport_11271) https://github.com/bitcoin/bitcoin/pull/11292
331 2017-09-08T23:28:35  *** dabura667 has quit IRC
332 2017-09-08T23:30:09  *** PaulCape_ has quit IRC
333 2017-09-08T23:31:23  *** Aaronvan_ has quit IRC
334 2017-09-08T23:32:01  *** AaronvanW has joined #bitcoin-core-dev
335 2017-09-08T23:32:08  *** PaulCapestany has joined #bitcoin-core-dev
336 2017-09-08T23:35:57  *** cluelessperson has joined #bitcoin-core-dev
337 2017-09-08T23:36:47  *** AaronvanW has quit IRC
338 2017-09-08T23:39:28  *** PaulCapestany has quit IRC
339 2017-09-08T23:43:33  *** PaulCapestany has joined #bitcoin-core-dev
340 2017-09-08T23:54:25  <bitcoin-git> [bitcoin] sipa pushed 2 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/adcc788f2a89...5f2cf88c2311
341 2017-09-08T23:54:26  <bitcoin-git> bitcoin/0.15 0ced455 Cory Fields: travis: filter out pyenv
342 2017-09-08T23:54:26  <bitcoin-git> bitcoin/0.15 5f2cf88 Pieter Wuille: Merge #11292: travis: filter out pyenv...
343 2017-09-08T23:54:38  *** promag has joined #bitcoin-core-dev
344 2017-09-08T23:59:14  *** promag has quit IRC