12017-09-30T00:01:26 *** promag has joined #bitcoin-core-dev
22017-09-30T00:10:29 *** promag has quit IRC
32017-09-30T00:11:44 *** mess110 has quit IRC
42017-09-30T00:43:05 *** PaulCapestany has joined #bitcoin-core-dev
52017-09-30T00:46:38 *** promag has joined #bitcoin-core-dev
62017-09-30T00:48:32 *** m4gdev has joined #bitcoin-core-dev
72017-09-30T00:48:38 <m4gdev> o/
82017-09-30T00:48:44 *** promag has quit IRC
92017-09-30T00:49:00 *** promag has joined #bitcoin-core-dev
102017-09-30T00:52:20 *** abpa has quit IRC
112017-09-30T00:52:51 *** promag has quit IRC
122017-09-30T00:55:56 *** m4gdev has quit IRC
132017-09-30T00:58:15 *** darkROL has joined #bitcoin-core-dev
142017-09-30T01:09:21 *** owowo has quit IRC
152017-09-30T01:15:57 *** owowo has joined #bitcoin-core-dev
162017-09-30T01:16:36 *** StopAndDecrypt_ has joined #bitcoin-core-dev
172017-09-30T01:16:54 *** darkROL has quit IRC
182017-09-30T01:27:27 *** Ylbam has quit IRC
192017-09-30T01:45:35 *** darkROL has joined #bitcoin-core-dev
202017-09-30T01:46:19 *** PaulCape_ has joined #bitcoin-core-dev
212017-09-30T01:48:02 *** PaulCapestany has quit IRC
222017-09-30T01:48:42 *** darkROL has quit IRC
232017-09-30T01:50:31 *** Deacydal has joined #bitcoin-core-dev
242017-09-30T01:53:35 *** Deacyde has quit IRC
252017-09-30T01:57:09 *** Deacydal has quit IRC
262017-09-30T02:11:01 *** Aaronva__ has quit IRC
272017-09-30T02:13:47 *** wxxs has quit IRC
282017-09-30T02:20:22 *** Geoffy has quit IRC
292017-09-30T02:21:26 *** belcher has quit IRC
302017-09-30T02:22:07 *** belcher has joined #bitcoin-core-dev
312017-09-30T02:39:58 *** belcher has quit IRC
322017-09-30T02:43:52 *** justanotheruser has joined #bitcoin-core-dev
332017-09-30T02:45:39 *** belcher has joined #bitcoin-core-dev
342017-09-30T02:51:58 *** darkROL has joined #bitcoin-core-dev
352017-09-30T02:54:34 *** darkROL has quit IRC
362017-09-30T04:01:16 *** jtimon has joined #bitcoin-core-dev
372017-09-30T04:01:50 *** GTOPapi has joined #bitcoin-core-dev
382017-09-30T04:02:47 *** LeMiner has quit IRC
392017-09-30T04:04:34 *** LeMiner has joined #bitcoin-core-dev
402017-09-30T04:04:40 *** LeMiner has joined #bitcoin-core-dev
412017-09-30T04:20:15 *** StopAndDecrypt_ has quit IRC
422017-09-30T05:25:58 *** photonclock has joined #bitcoin-core-dev
432017-09-30T05:30:09 *** wittysense has quit IRC
442017-09-30T05:30:35 *** SopaXorzTaker has joined #bitcoin-core-dev
452017-09-30T05:38:46 *** goatpig has joined #bitcoin-core-dev
462017-09-30T05:45:48 *** meshcollider has quit IRC
472017-09-30T05:58:58 *** meshcollider has joined #bitcoin-core-dev
482017-09-30T06:11:52 *** Ylbam has joined #bitcoin-core-dev
492017-09-30T06:27:01 *** chjj has quit IRC
502017-09-30T06:29:03 *** chjj has joined #bitcoin-core-dev
512017-09-30T06:53:27 *** ThomasV has joined #bitcoin-core-dev
522017-09-30T07:19:04 *** Guyver2 has joined #bitcoin-core-dev
532017-09-30T07:24:37 *** Alina-malina has quit IRC
542017-09-30T07:26:14 *** Alina-malina has joined #bitcoin-core-dev
552017-09-30T07:38:47 *** ThomasV has quit IRC
562017-09-30T07:55:21 *** Alina-malina has quit IRC
572017-09-30T07:59:38 *** btcdrak has quit IRC
582017-09-30T07:59:48 *** Alina-malina has joined #bitcoin-core-dev
592017-09-30T08:01:46 <meshcollider> ugh irieGhost is spamming comments on random PR
602017-09-30T08:14:33 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/38c201f47c0b...763231051596
612017-09-30T08:14:34 <bitcoin-git> bitcoin/master 8849130 MeshCollider: Remove lxcbr0 lines from gitian-build.sh
622017-09-30T08:14:34 <bitcoin-git> bitcoin/master 7632310 MarcoFalke: Merge #11391: Remove lxcbr0 lines from gitian-build.sh...
632017-09-30T08:15:08 *** riemann has joined #bitcoin-core-dev
642017-09-30T08:15:08 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11391: Remove lxcbr0 lines from gitian-build.sh (master...201709_gitian_script_fix) https://github.com/bitcoin/bitcoin/pull/11391
652017-09-30T08:15:20 *** spencertruman has joined #bitcoin-core-dev
662017-09-30T08:15:23 *** spencertruman has left #bitcoin-core-dev
672017-09-30T08:20:30 *** Guyver2 has quit IRC
682017-09-30T08:33:19 *** ThomasV has joined #bitcoin-core-dev
692017-09-30T08:57:05 *** spencertruman has joined #bitcoin-core-dev
702017-09-30T09:17:35 *** timothy has joined #bitcoin-core-dev
712017-09-30T09:23:14 *** alreadylate has joined #bitcoin-core-dev
722017-09-30T09:27:00 *** alreadylate has quit IRC
732017-09-30T09:28:34 *** alreadylate has joined #bitcoin-core-dev
742017-09-30T09:30:32 *** alreadylate has quit IRC
752017-09-30T09:32:37 *** Evel-Knievel has joined #bitcoin-core-dev
762017-09-30T09:46:52 *** kazure has joined #bitcoin-core-dev
772017-09-30T09:47:24 *** wxxs has joined #bitcoin-core-dev
782017-09-30T09:54:42 *** wvr has quit IRC
792017-09-30T09:56:24 *** wvr has joined #bitcoin-core-dev
802017-09-30T10:34:36 *** ThomasV has quit IRC
812017-09-30T10:34:49 *** ThomasV has joined #bitcoin-core-dev
822017-09-30T11:09:23 *** ThomasV has quit IRC
832017-09-30T11:12:20 *** alreadylate has joined #bitcoin-core-dev
842017-09-30T11:16:02 *** alreadylate has quit IRC
852017-09-30T11:16:58 *** AaronvanW has joined #bitcoin-core-dev
862017-09-30T11:19:47 *** spencertruman has quit IRC
872017-09-30T11:20:11 *** spencertruman has joined #bitcoin-core-dev
882017-09-30T11:26:52 *** Cheeseo has quit IRC
892017-09-30T11:40:15 *** spencertruman has quit IRC
902017-09-30T11:40:28 *** spencertruman has joined #bitcoin-core-dev
912017-09-30T11:53:23 *** laurentmt has joined #bitcoin-core-dev
922017-09-30T12:17:54 <bitcoin-git> [bitcoin] jtimon opened pull request #11426: BIP90: Make buried deployments slightly more easily extensible (master...e16-bip90-extensible) https://github.com/bitcoin/bitcoin/pull/11426
932017-09-30T12:29:28 *** wittysense has joined #bitcoin-core-dev
942017-09-30T12:44:37 <jtimon> re https://github.com/bitcoin/bitcoin/pull/11398 I wonder if we should always leave at least the last bip9/bip8 deployment there to make sure we're using the rpc part of bip9
952017-09-30T12:45:49 *** meshcollider has quit IRC
962017-09-30T12:47:44 *** meshcollider has joined #bitcoin-core-dev
972017-09-30T12:47:45 <jtimon> I mean, I was about to start the same, but only for csv
982017-09-30T13:01:30 *** kazure has quit IRC
992017-09-30T13:05:03 <bitcoin-git> [bitcoin] jtimon opened pull request #11427: Optimization: Remove Consensus::Params::BIP34Hash (master...e16-bip90-bip30) https://github.com/bitcoin/bitcoin/pull/11427
1002017-09-30T13:38:44 *** sturles has quit IRC
1012017-09-30T13:38:55 *** sturles_ has joined #bitcoin-core-dev
1022017-09-30T13:38:55 *** sturles_ has joined #bitcoin-core-dev
1032017-09-30T13:43:02 *** sturles_ has quit IRC
1042017-09-30T14:12:37 *** laurentmt has quit IRC
1052017-09-30T14:34:54 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1062017-09-30T14:37:24 *** JackH has joined #bitcoin-core-dev
1072017-09-30T14:44:13 *** sturles_ has joined #bitcoin-core-dev
1082017-09-30T14:44:13 *** sturles_ has joined #bitcoin-core-dev
1092017-09-30T14:44:53 *** sturles_ is now known as sturles
1102017-09-30T14:46:27 *** AaronvanW has quit IRC
1112017-09-30T14:55:49 *** meshcollider has quit IRC
1122017-09-30T15:04:52 *** PaulCape_ has quit IRC
1132017-09-30T15:25:46 *** StopAndDecrypt_ has joined #bitcoin-core-dev
1142017-09-30T15:39:27 *** promag has joined #bitcoin-core-dev
1152017-09-30T15:42:13 *** promag has quit IRC
1162017-09-30T15:54:06 <bitcoin-git> [bitcoin] wodry opened pull request #11428: Better understandable text for sending transaction option "Request Replace-By-Fee" (master...master) https://github.com/bitcoin/bitcoin/pull/11428
1172017-09-30T16:11:24 <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/763231051596...e542728cde67
1182017-09-30T16:11:25 <bitcoin-git> bitcoin/master 0b1b914 Matt Corallo: Remove countMaskInv caching in bench framework...
1192017-09-30T16:11:26 <bitcoin-git> bitcoin/master 53a6590 Matt Corallo: Make float <-> int casts explicit outside of test, qt, CFeeRate
1202017-09-30T16:11:26 <bitcoin-git> bitcoin/master 1789e46 Matt Corallo: Force explicit double -> int conversion for CFeeRate constructor...
1212017-09-30T16:12:03 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11303: Fix estimatesmartfee rounding display issue (master...2017-09-estimatesmartfee-round) https://github.com/bitcoin/bitcoin/pull/11303
1222017-09-30T16:12:08 *** justanotheruser has quit IRC
1232017-09-30T16:13:03 *** ula has quit IRC
1242017-09-30T16:31:03 *** wittysense has quit IRC
1252017-09-30T16:31:18 *** wittysense has joined #bitcoin-core-dev
1262017-09-30T16:36:09 *** goatpig has quit IRC
1272017-09-30T16:42:58 *** promag has joined #bitcoin-core-dev
1282017-09-30T16:47:20 *** promag has quit IRC
1292017-09-30T16:59:55 *** moctos has joined #bitcoin-core-dev
1302017-09-30T17:20:35 <bitcoin-git> [bitcoin] jtimon opened pull request #11430: B16 bip90 bip16 (master...b16-bip90-bip16) https://github.com/bitcoin/bitcoin/pull/11430
1312017-09-30T17:25:16 *** PaulCapestany has joined #bitcoin-core-dev
1322017-09-30T17:28:18 *** justanotheruser has joined #bitcoin-core-dev
1332017-09-30T17:35:43 *** laurentmt has joined #bitcoin-core-dev
1342017-09-30T17:47:38 *** Giszmo has quit IRC
1352017-09-30T17:53:21 *** PaulCapestany has quit IRC
1362017-09-30T17:53:53 *** SopaXorzTaker has quit IRC
1372017-09-30T17:57:26 *** PaulCapestany has joined #bitcoin-core-dev
1382017-09-30T17:58:00 *** Giszmo has joined #bitcoin-core-dev
1392017-09-30T18:06:38 *** brianhoffman has quit IRC
1402017-09-30T18:13:08 *** riemann_ has joined #bitcoin-core-dev
1412017-09-30T18:15:53 *** riemann has quit IRC
1422017-09-30T18:19:07 <jtimon> jl2012: edited https://github.com/bitcoin/bitcoin/pull/11398#issuecomment-333325969
1432017-09-30T18:20:35 <jtimon> btw thanks again for https://github.com/bitcoin/bitcoin/pull/11427 I could have looked at it for hours without distinguising < from >
1442017-09-30T18:23:51 <jl2012> jtimon: I'm trying to make IsSoftForkEnabled(), so all softforks, buried or bip9, could use that
1452017-09-30T18:24:01 <jl2012> not sure if it is a good idea
1462017-09-30T18:25:09 <jl2012> So next time when we bury a bip9 softfork, we don't need to edit validation.cpp at all
1472017-09-30T18:26:33 <jtimon> jl2012: I saw some simplification/preparation on rpc that looked spot on at a first glance, but will review more
1482017-09-30T18:27:40 <jtimon> IIRC you were unifying SoftForkMajorityDesc and SoftForkDesc and preparing it for post-bip9 buried deployments
1492017-09-30T18:29:14 <jl2012> I'm trying to combine softforks and bip9_softforks in getblockchaininfo
1502017-09-30T18:29:14 <jtimon> that kind of thing should pass all the tests before moving anything from bip9 to buried
1512017-09-30T18:30:04 <jl2012> ok. Do you think it should be a separate PR?
1522017-09-30T18:30:29 <jtimon> yeah, I think leaving BIP9SoftForkDesc as it is and rewritting SoftForkMajorityDesc/SoftForkDesc as it fits as you were doing looks good
1532017-09-30T18:32:19 <jtimon> I think most people won't care about them being separated PRs, I slightly care and maybe some people care in the opposite direction (but they can always ignore the dependency PR and ack the upper one directly)
1542017-09-30T18:33:40 <jtimon> just eager to ack the csv part I guess, but probably better to focus on commits than PRs
1552017-09-30T18:36:07 <jtimon> I would focus first on a commit that leaves everything prepared on the rpc side but without actually changing anything and thus passing all tests, but just my very opinionated and also criticized modus operandi, don't feel obliged to comply
1562017-09-30T18:36:27 <jl2012> jtimon: i think you are right
1572017-09-30T18:38:28 *** Guyver2 has joined #bitcoin-core-dev
1582017-09-30T18:38:41 <jtimon> I think it will make things easier for you, but just try modifying your thing with an interactive rebase and if you're not convinced, rebase --abort (sorry, being verbose about my customes again)
1592017-09-30T18:40:00 *** riemann_ has quit IRC
1602017-09-30T18:42:04 <jtimon> forget about a separate PR for now, more separated commits will probably do it even for me, the terror of history bike-shedding
1612017-09-30T18:43:21 <jtimon> always remember I may compain about tiny things and there the right answer is probably "thanks, but no" I won't be offended
1622017-09-30T18:44:55 <jl2012> it's ok
1632017-09-30T18:45:29 <jtimon> cool, happy to help, but also don't want to slow you down
1642017-09-30T18:45:33 <jl2012> jtimon: the compiler complains comparing uint with int
1652017-09-30T18:45:43 <jtimon> cast ?
1662017-09-30T18:46:07 <jtimon> (unint32_t) somewhere probably
1672017-09-30T18:46:09 <jl2012> i think you changed buried_deployments from int to uint?
1682017-09-30T18:49:12 <jtimon> yep, I did, I was changing a local variable from int to uint32 initially, but I ended up liking luke-jr's casting in https://github.com/BitcoinHardfork/bitcoin/pull/3/files more and I also needed it for https://github.com/bitcoin/bitcoin/pull/11430
1692017-09-30T18:49:21 <jtimon> sorry for the incenvenience
1702017-09-30T18:50:23 <jtimon> I should have thought about those 2 things before asking you to rebase on top of it, sorry...excitement...impacience...sw is activated!
1712017-09-30T18:52:49 <luke-jr> speaking of comparing signed vs unsigned, is it well-defined how it behaves? does it actually compare correctly, or is the warning because of some real bug risk?
1722017-09-30T18:54:37 <esotericnonsense> luke-jr: -1 > 1
1732017-09-30T18:55:58 <esotericnonsense> my understanding (could be wrong) is that the signed int is cast to unsigned and then compared, so it is well defined, but whether it compares correctly depends on what you mean by correctly :P
1742017-09-30T18:57:54 *** pr0zac- has joined #bitcoin-core-dev
1752017-09-30T18:58:06 <jtimon> perhaps someone should decide between 64 and 32 (which seems to dominate in consensus code, see primitives/block/CBlockHeader) and do a univeral transparent wrapper for int and unsigned or something
1762017-09-30T18:59:35 <esotericnonsense> e.g. https://0bin.net/paste/tytLfw5A072VUD4R#m49We78TgI6LQqcoMAK7Nwe9S2uIv2HFwyJCdawYzpZ
1772017-09-30T18:59:57 <esotericnonsense> I don't even get a compiler warning, heh
1782017-09-30T19:01:37 <jtimon> yeah, unsigned vs signed is much more dangerous than 32 vs 64
1792017-09-30T19:01:42 <luke-jr> esotericnonsense: eck
1802017-09-30T19:02:07 <luke-jr> jtimon: since everyone uses 64-bit platforms now, IMO we should make height be uint64_t everywhere
1812017-09-30T19:02:09 <jtimon> but in this case I think it should be ok
1822017-09-30T19:02:20 <luke-jr> unless we want to support negative heights some places, in which case int64_t is prob fine too
1832017-09-30T19:02:21 *** meshcollider has joined #bitcoin-core-dev
1842017-09-30T19:02:56 *** nabu has joined #bitcoin-core-dev
1852017-09-30T19:03:39 <jtimon> luke-jr: yeah, makes sense. besides is more forward compatible, we don't want to slow down the rest for miliseconds of performance in inferior platforms, right? I bet they simulate 64 just fine
1862017-09-30T19:05:14 <luke-jr> not sure 32-bit is slower on 64-bit platforms, but I don't think we need to support 32-bit performantly.
1872017-09-30T19:05:15 *** laurentmt has quit IRC
1882017-09-30T19:12:13 <jtimon> jl2012: changed from 32 to 64, mainteined the change to unsigned
1892017-09-30T19:12:33 *** StopAndDecrypt_ has quit IRC
1902017-09-30T19:14:01 <sipa> converting from signed to unsigned is always well-defined, unsigned to signed is only well-defined if there is no overflow
1912017-09-30T19:14:13 <jtimon> no, I was saying probably 64 is slower in 32 platforms, but...not so much slower, that was early optimization
1922017-09-30T19:15:28 <jtimon> sipa: thus converting unsigned to signed is never well defined without knowing the input, right?
1932017-09-30T19:15:35 <sipa> indeed
1942017-09-30T19:15:46 <sipa> (in practice, it works fine, though)
1952017-09-30T19:15:53 <sipa> on all platforms we support
1962017-09-30T19:16:14 <sipa> 64-bit arithmetic is several times slower than 32-bit arithmetic on 32-bit platforms
1972017-09-30T19:16:25 <sipa> on 64-bit they're the same speed
1982017-09-30T19:18:04 <jtimon> yep, we're discussing edge cases that you just want to be sure about because...consensus code, no? training neural networks this kind of undefined behaviour could be a feature!
1992017-09-30T19:20:03 <jtimon> or if not, you probably don't care, whatever the machine does, if the network is not fit for that problem and architecture...just select another one, weights are extremly unlikely to ever get anywhere close to where that matters anyway
2002017-09-30T19:24:03 *** promag has joined #bitcoin-core-dev
2012017-09-30T19:24:33 *** promag has joined #bitcoin-core-dev
2022017-09-30T19:26:11 *** promag has quit IRC
2032017-09-30T19:28:00 *** promag has joined #bitcoin-core-dev
2042017-09-30T19:29:15 *** Cheeseo has joined #bitcoin-core-dev
2052017-09-30T19:30:18 *** photonclock has quit IRC
2062017-09-30T19:31:54 *** qrestlove has quit IRC
2072017-09-30T19:39:12 *** qrestlove has joined #bitcoin-core-dev
2082017-09-30T19:43:59 *** vicenteH` has joined #bitcoin-core-dev
2092017-09-30T19:45:38 *** vicenteH has quit IRC
2102017-09-30T19:46:25 *** justanotheruser has quit IRC
2112017-09-30T20:04:39 *** justanotheruser has joined #bitcoin-core-dev
2122017-09-30T20:04:47 *** brianhoffman has joined #bitcoin-core-dev
2132017-09-30T20:18:19 *** pr0zac- has quit IRC
2142017-09-30T20:22:10 *** timothy has quit IRC
2152017-09-30T20:25:05 *** timothy has joined #bitcoin-core-dev
2162017-09-30T20:25:27 *** Chris_Stewart_5 has quit IRC
2172017-09-30T20:27:14 *** RoyceX has joined #bitcoin-core-dev
2182017-09-30T20:29:51 *** goatpig has joined #bitcoin-core-dev
2192017-09-30T20:36:59 *** promag has quit IRC
2202017-09-30T20:37:27 *** promag has joined #bitcoin-core-dev
2212017-09-30T20:42:19 *** justanotheruser has quit IRC
2222017-09-30T20:43:01 *** intcat has quit IRC
2232017-09-30T20:44:09 *** intcat has joined #bitcoin-core-dev
2242017-09-30T20:51:03 <bitcoin-git> [bitcoin] geohic opened pull request #11431: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/11431
2252017-09-30T20:52:04 *** PaulCapestany has quit IRC
2262017-09-30T20:52:58 <bitcoin-git> [bitcoin] geohic closed pull request #11431: 0.12 (master...0.12) https://github.com/bitcoin/bitcoin/pull/11431
2272017-09-30T20:55:46 *** PaulCapestany has joined #bitcoin-core-dev
2282017-09-30T21:01:51 *** pr0zac- has joined #bitcoin-core-dev
2292017-09-30T21:03:04 *** justanotheruser has joined #bitcoin-core-dev
2302017-09-30T21:16:26 *** qrestlove has quit IRC
2312017-09-30T21:22:06 *** meshcollider has quit IRC
2322017-09-30T21:22:45 *** qrestlove has joined #bitcoin-core-dev
2332017-09-30T21:28:03 *** promag has joined #bitcoin-core-dev
2342017-09-30T21:36:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2352017-09-30T21:55:08 <bitcoin-git> [bitcoin] promag opened pull request #11432: Remove unused fTry from push_lock (master...2017-08-clean-push-lock) https://github.com/bitcoin/bitcoin/pull/11432
2362017-09-30T21:56:07 *** meshcollider has joined #bitcoin-core-dev
2372017-09-30T22:03:44 *** PaulCapestany has quit IRC
2382017-09-30T22:19:08 *** CryptAxe_ has quit IRC
2392017-09-30T22:28:30 *** Cheeseo has quit IRC
2402017-09-30T22:30:41 *** Cheeseo has joined #bitcoin-core-dev
2412017-09-30T22:31:35 *** Guyver2 has quit IRC
2422017-09-30T22:39:40 *** promag has quit IRC
2432017-09-30T22:44:30 *** timothy has quit IRC
2442017-09-30T22:49:12 *** Chris_Stewart_5 has quit IRC
2452017-09-30T23:03:23 *** Cheeseo has quit IRC
2462017-09-30T23:18:20 *** Cheeseo has joined #bitcoin-core-dev
2472017-09-30T23:30:50 *** JackH has quit IRC
2482017-09-30T23:43:05 *** Cheeseo has quit IRC
2492017-09-30T23:43:30 *** Cheeseo has joined #bitcoin-core-dev
2502017-09-30T23:43:39 *** laksia has joined #bitcoin-core-dev
2512017-09-30T23:45:58 *** marcoagner has joined #bitcoin-core-dev
2522017-09-30T23:46:06 *** JackH has joined #bitcoin-core-dev
2532017-09-30T23:46:38 *** promag has joined #bitcoin-core-dev
2542017-09-30T23:49:00 *** spencertruman has quit IRC
2552017-09-30T23:50:57 *** promag has quit IRC
2562017-09-30T23:55:52 <bitcoin-git> [bitcoin] jtimon closed pull request #9717: Pow: Remove fCheckPOW from CheckBlockHeader (master...pre-0.14-dont-call-me) https://github.com/bitcoin/bitcoin/pull/9717