1 2017-10-04T00:22:29  *** Ylbam has quit IRC
  2 2017-10-04T00:26:28  *** Alina-malina has quit IRC
  3 2017-10-04T00:28:06  *** Alina-malina has joined #bitcoin-core-dev
  4 2017-10-04T00:33:39  *** Murch has quit IRC
  5 2017-10-04T00:35:05  *** mkarrer has quit IRC
  6 2017-10-04T00:44:19  *** Scrat has quit IRC
  7 2017-10-04T00:46:13  *** mkarrer has joined #bitcoin-core-dev
  8 2017-10-04T00:56:32  *** meshcollider has quit IRC
  9 2017-10-04T00:57:30  *** Aaronvan_ has joined #bitcoin-core-dev
 10 2017-10-04T00:58:02  *** dabura667 has joined #bitcoin-core-dev
 11 2017-10-04T01:01:05  *** AaronvanW has quit IRC
 12 2017-10-04T01:06:40  *** dabura667 has quit IRC
 13 2017-10-04T01:06:54  *** dabura667 has joined #bitcoin-core-dev
 14 2017-10-04T01:07:45  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 15 2017-10-04T01:09:05  *** harrymm has quit IRC
 16 2017-10-04T01:22:09  *** harrymm has joined #bitcoin-core-dev
 17 2017-10-04T01:23:13  *** Chris_Stewart_5 has quit IRC
 18 2017-10-04T01:49:54  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 19 2017-10-04T01:59:30  *** Alina-malina has quit IRC
 20 2017-10-04T02:01:06  *** mkarrer has quit IRC
 21 2017-10-04T02:01:11  *** Alina-malina has joined #bitcoin-core-dev
 22 2017-10-04T02:46:39  *** Alina-malina has quit IRC
 23 2017-10-04T02:48:09  *** Alina-malina has joined #bitcoin-core-dev
 24 2017-10-04T02:48:52  *** arubi has quit IRC
 25 2017-10-04T03:01:21  *** luke-jr has quit IRC
 26 2017-10-04T03:01:35  *** Alina-malina has quit IRC
 27 2017-10-04T03:01:55  *** luke-jr has joined #bitcoin-core-dev
 28 2017-10-04T03:02:27  *** mkarrer has joined #bitcoin-core-dev
 29 2017-10-04T03:02:37  *** Alina-malina has joined #bitcoin-core-dev
 30 2017-10-04T03:06:49  *** meshcollider has joined #bitcoin-core-dev
 31 2017-10-04T03:06:58  *** mkarrer has quit IRC
 32 2017-10-04T03:13:35  *** mkarrer has joined #bitcoin-core-dev
 33 2017-10-04T03:15:01  *** luke-jr has quit IRC
 34 2017-10-04T03:15:37  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b4a509a3f817...093074b84395
 35 2017-10-04T03:15:38  <bitcoin-git> bitcoin/master ab5bba7 Alejandro Avilés: Fix launchctl not being able to stop bitcoind...
 36 2017-10-04T03:15:38  <bitcoin-git> bitcoin/master 093074b Jonas Schnelli: Merge #11419: Utils: Fix launchctl not being able to stop bitcoind...
 37 2017-10-04T03:16:18  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11419: Utils: Fix launchctl not being able to stop bitcoind (master...fix-macos-init) https://github.com/bitcoin/bitcoin/pull/11419
 38 2017-10-04T03:21:29  *** luke-jr has joined #bitcoin-core-dev
 39 2017-10-04T03:26:04  *** Alina-malina has quit IRC
 40 2017-10-04T03:26:31  *** Chris_Stewart_5 has quit IRC
 41 2017-10-04T03:28:42  *** Alina-malina has joined #bitcoin-core-dev
 42 2017-10-04T03:30:38  *** lukedashjr has joined #bitcoin-core-dev
 43 2017-10-04T03:33:04  *** luke-jr has quit IRC
 44 2017-10-04T03:34:24  *** BlueMatt has quit IRC
 45 2017-10-04T03:35:02  *** lukedashjr is now known as luke-jr
 46 2017-10-04T03:39:19  *** BlueMatt has joined #bitcoin-core-dev
 47 2017-10-04T03:40:27  *** justanotheruser has quit IRC
 48 2017-10-04T03:42:12  *** justanotheruser has joined #bitcoin-core-dev
 49 2017-10-04T03:53:37  *** mkarrer has quit IRC
 50 2017-10-04T03:56:09  *** justanotheruser has quit IRC
 51 2017-10-04T03:56:29  *** justanotheruser has joined #bitcoin-core-dev
 52 2017-10-04T04:07:35  *** Victorsueca has quit IRC
 53 2017-10-04T04:08:44  *** Victorsueca has joined #bitcoin-core-dev
 54 2017-10-04T04:12:38  <jonasschnelli> ping cfields
 55 2017-10-04T04:13:21  *** luke-jr has quit IRC
 56 2017-10-04T04:16:59  *** goatpig has joined #bitcoin-core-dev
 57 2017-10-04T04:19:35  *** luke-jr has joined #bitcoin-core-dev
 58 2017-10-04T04:19:40  *** luke-jr has quit IRC
 59 2017-10-04T04:19:40  *** luke-jr has joined #bitcoin-core-dev
 60 2017-10-04T04:26:04  *** luke-jr has quit IRC
 61 2017-10-04T04:30:58  *** luke-jr has joined #bitcoin-core-dev
 62 2017-10-04T04:44:28  *** lukedashjr has joined #bitcoin-core-dev
 63 2017-10-04T04:44:49  *** luke-jr has quit IRC
 64 2017-10-04T04:48:53  *** lukedashjr is now known as luke-jr
 65 2017-10-04T04:49:09  *** Murch has joined #bitcoin-core-dev
 66 2017-10-04T04:55:41  *** mkarrer has joined #bitcoin-core-dev
 67 2017-10-04T04:55:43  *** lukedashjr has joined #bitcoin-core-dev
 68 2017-10-04T04:58:37  *** luke-jr has quit IRC
 69 2017-10-04T05:00:05  *** mkarrer has quit IRC
 70 2017-10-04T05:00:23  *** luke-jr has joined #bitcoin-core-dev
 71 2017-10-04T05:04:04  *** lukedashjr has quit IRC
 72 2017-10-04T05:04:13  *** SopaXorzTaker has joined #bitcoin-core-dev
 73 2017-10-04T05:04:34  *** Alina-malina has quit IRC
 74 2017-10-04T05:07:18  *** Alina-malina has joined #bitcoin-core-dev
 75 2017-10-04T05:07:54  *** lukedashjr has joined #bitcoin-core-dev
 76 2017-10-04T05:11:33  *** luke-jr has quit IRC
 77 2017-10-04T05:12:18  *** lukedashjr is now known as luke-jr
 78 2017-10-04T05:14:37  *** chjj has quit IRC
 79 2017-10-04T05:20:51  *** geezas has joined #bitcoin-core-dev
 80 2017-10-04T05:31:45  *** luke-jr has quit IRC
 81 2017-10-04T05:32:14  *** promag has joined #bitcoin-core-dev
 82 2017-10-04T05:40:08  *** promag has quit IRC
 83 2017-10-04T05:40:28  *** intcat has quit IRC
 84 2017-10-04T05:43:47  *** promag has joined #bitcoin-core-dev
 85 2017-10-04T05:45:37  *** Alina-malina has quit IRC
 86 2017-10-04T05:47:48  *** Alina-malina has joined #bitcoin-core-dev
 87 2017-10-04T05:49:25  *** promag has quit IRC
 88 2017-10-04T06:03:54  *** luke-jr has joined #bitcoin-core-dev
 89 2017-10-04T06:09:01  *** chjj has joined #bitcoin-core-dev
 90 2017-10-04T06:10:52  *** afk11 has quit IRC
 91 2017-10-04T06:11:21  *** Guest86958 is now known as ndrst
 92 2017-10-04T06:11:24  *** ndrst has joined #bitcoin-core-dev
 93 2017-10-04T06:35:12  *** owowo has quit IRC
 94 2017-10-04T06:36:42  *** harrymm has quit IRC
 95 2017-10-04T06:38:20  *** harrymm has joined #bitcoin-core-dev
 96 2017-10-04T06:42:34  *** sanada has joined #bitcoin-core-dev
 97 2017-10-04T06:57:08  *** timothy has joined #bitcoin-core-dev
 98 2017-10-04T06:57:25  *** promag has joined #bitcoin-core-dev
 99 2017-10-04T07:00:31  *** timothy has quit IRC
100 2017-10-04T07:03:16  *** promag has quit IRC
101 2017-10-04T07:09:01  *** jtimon has quit IRC
102 2017-10-04T07:44:09  *** laurentmt has joined #bitcoin-core-dev
103 2017-10-04T07:50:10  *** JackH has quit IRC
104 2017-10-04T07:50:13  *** geezas has quit IRC
105 2017-10-04T07:56:29  *** Guyver2 has joined #bitcoin-core-dev
106 2017-10-04T07:57:18  *** Emcy has quit IRC
107 2017-10-04T08:01:41  *** JackH has joined #bitcoin-core-dev
108 2017-10-04T08:20:50  *** Guyver2 has quit IRC
109 2017-10-04T08:25:17  *** timothy has joined #bitcoin-core-dev
110 2017-10-04T08:43:45  *** vicenteH has joined #bitcoin-core-dev
111 2017-10-04T08:47:21  *** Ylbam has joined #bitcoin-core-dev
112 2017-10-04T08:59:02  *** promag has joined #bitcoin-core-dev
113 2017-10-04T09:31:35  *** BashCo has quit IRC
114 2017-10-04T09:37:36  *** afk11 has joined #bitcoin-core-dev
115 2017-10-04T09:37:51  *** AaronvanW has joined #bitcoin-core-dev
116 2017-10-04T09:38:00  *** arubi has joined #bitcoin-core-dev
117 2017-10-04T09:39:31  *** AaronvanW has quit IRC
118 2017-10-04T09:40:05  *** AaronvanW has joined #bitcoin-core-dev
119 2017-10-04T09:40:52  *** intcat has joined #bitcoin-core-dev
120 2017-10-04T09:41:03  *** Aaronvan_ has joined #bitcoin-core-dev
121 2017-10-04T09:41:23  *** EricCartman has joined #bitcoin-core-dev
122 2017-10-04T09:44:46  *** AaronvanW has quit IRC
123 2017-10-04T09:56:30  *** wxxs_ has joined #bitcoin-core-dev
124 2017-10-04T09:57:43  *** BashCo has joined #bitcoin-core-dev
125 2017-10-04T09:58:01  *** wxxs has quit IRC
126 2017-10-04T09:58:09  *** wxxs_ is now known as wxxs
127 2017-10-04T10:15:59  *** rafalcpp has joined #bitcoin-core-dev
128 2017-10-04T10:20:40  *** promag has quit IRC
129 2017-10-04T10:21:49  *** promag has joined #bitcoin-core-dev
130 2017-10-04T10:35:02  *** d9b4bef9 has quit IRC
131 2017-10-04T10:36:08  *** d9b4bef9 has joined #bitcoin-core-dev
132 2017-10-04T10:38:38  *** W4RL0RD has joined #bitcoin-core-dev
133 2017-10-04T10:40:04  <bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/093074b84395...9ccafb1d7bdd
134 2017-10-04T10:40:05  <bitcoin-git> bitcoin/master fd86f99 MarcoFalke: Squashed 'src/secp256k1/' changes from 84973d393..0b7024185...
135 2017-10-04T10:40:05  <bitcoin-git> bitcoin/master 999968e MarcoFalke: Bump secp256k1 subtree
136 2017-10-04T10:40:06  <bitcoin-git> bitcoin/master 9ccafb1 MarcoFalke: Merge #11421: Merge current secp256k1 subtree...
137 2017-10-04T10:40:39  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11421: Merge current secp256k1 subtree (master...Mf1709-subtree-secp256k1) https://github.com/bitcoin/bitcoin/pull/11421
138 2017-10-04T10:58:44  *** pbase has joined #bitcoin-core-dev
139 2017-10-04T11:06:37  *** meshcollider has quit IRC
140 2017-10-04T11:09:33  *** owowo has joined #bitcoin-core-dev
141 2017-10-04T11:38:45  *** promag has quit IRC
142 2017-10-04T11:39:09  *** pbase has quit IRC
143 2017-10-04T11:44:54  *** promag has joined #bitcoin-core-dev
144 2017-10-04T11:48:02  *** mkarrer has joined #bitcoin-core-dev
145 2017-10-04T11:52:35  *** mkarrer has quit IRC
146 2017-10-04T12:01:55  *** mkarrer has joined #bitcoin-core-dev
147 2017-10-04T12:04:28  *** drnet has joined #bitcoin-core-dev
148 2017-10-04T12:05:12  *** mkarrer has quit IRC
149 2017-10-04T12:05:19  *** mkarrer has joined #bitcoin-core-dev
150 2017-10-04T12:15:37  *** Chris_Stewart_5 has joined #bitcoin-core-dev
151 2017-10-04T12:23:56  *** mkarrer has quit IRC
152 2017-10-04T12:26:09  *** Chris_Stewart_5 has quit IRC
153 2017-10-04T12:26:28  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ccafb1d7bdd...a4c833fec104
154 2017-10-04T12:26:29  <bitcoin-git> bitcoin/master fae2673 MarcoFalke: qa: check-rpc-mapping must not run on empty lists
155 2017-10-04T12:26:30  <bitcoin-git> bitcoin/master fae60e3 MarcoFalke: qa: Fix lcov for out-of-tree builds
156 2017-10-04T12:26:30  <bitcoin-git> bitcoin/master a4c833f Wladimir J. van der Laan: Merge #11443: [qa] Allow "make cov" out-of-tree; Fix rpc mapping check...
157 2017-10-04T12:26:44  *** Chris_Stewart_5 has joined #bitcoin-core-dev
158 2017-10-04T12:27:11  <bitcoin-git> [bitcoin] laanwj closed pull request #11443: [qa] Allow "make cov" out-of-tree; Fix rpc mapping check (master...Mf1710-qaFixups) https://github.com/bitcoin/bitcoin/pull/11443
159 2017-10-04T12:36:37  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4c833fec104...e12522dfdaab
160 2017-10-04T12:36:37  <bitcoin-git> bitcoin/master 6643b80 Matt Corallo: Add state message print to AcceptBlock failure message....
161 2017-10-04T12:36:38  <bitcoin-git> bitcoin/master e12522d Wladimir J. van der Laan: Merge #11406: Add state message print to AcceptBlock failure message....
162 2017-10-04T12:37:19  <bitcoin-git> [bitcoin] laanwj closed pull request #11406: Add state message print to AcceptBlock failure message. (master...2017-09-checkblock-fail-print) https://github.com/bitcoin/bitcoin/pull/11406
163 2017-10-04T12:47:27  *** arubi has quit IRC
164 2017-10-04T12:47:54  *** arubi has joined #bitcoin-core-dev
165 2017-10-04T12:48:32  *** dabura667 has quit IRC
166 2017-10-04T12:54:41  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/e12522dfdaab...a1f7f1870931
167 2017-10-04T12:54:42  <bitcoin-git> bitcoin/master 6fb8f5f practicalswift: Check that -blocknotify command is non-empty before executing...
168 2017-10-04T12:54:42  <bitcoin-git> bitcoin/master cffe85f practicalswift: Skip sys::system(...) call in case of empty command
169 2017-10-04T12:54:43  <bitcoin-git> bitcoin/master a1f7f18 Wladimir J. van der Laan: Merge #10939: [init] Check non-emptiness of -blocknotify command prior to executing...
170 2017-10-04T12:55:10  <bitcoin-git> [bitcoin] laanwj closed pull request #10939: [init] Check non-emptiness of -blocknotify command prior to executing (master...blocknotify-consistentcy) https://github.com/bitcoin/bitcoin/pull/10939
171 2017-10-04T12:59:09  <bitcoin-git> [bitcoin] laanwj closed pull request #10233: Wallet: Support not reusing addresses (master...freezea) https://github.com/bitcoin/bitcoin/pull/10233
172 2017-10-04T13:01:51  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1f7f1870931...7f11ef260855
173 2017-10-04T13:01:52  <bitcoin-git> bitcoin/master 0cd9273 Wladimir J. van der Laan: rpc: Prevent `dumpwallet` from overwriting files...
174 2017-10-04T13:01:53  <bitcoin-git> bitcoin/master 7f11ef2 Wladimir J. van der Laan: Merge #9937: rpc: Prevent `dumpwallet` from overwriting files...
175 2017-10-04T13:02:01  <bitcoin-git> [bitcoin] laanwj closed pull request #9937: rpc: Prevent `dumpwallet` from overwriting files (master...2017_03_walletdump_nooverwrite) https://github.com/bitcoin/bitcoin/pull/9937
176 2017-10-04T13:03:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7f11ef260855...74123eabdd91
177 2017-10-04T13:03:07  <bitcoin-git> bitcoin/master 96c2ce9 Matt Corallo: Fix validationinterface build on super old boost/clang...
178 2017-10-04T13:03:08  <bitcoin-git> bitcoin/master 74123ea Wladimir J. van der Laan: Merge #11440: Fix validationinterface build on super old boost/clang...
179 2017-10-04T13:03:52  <bitcoin-git> [bitcoin] laanwj closed pull request #11440: Fix validationinterface build on super old boost/clang (master...2017-10-cblock-validationinterface) https://github.com/bitcoin/bitcoin/pull/11440
180 2017-10-04T13:12:31  *** drnet has quit IRC
181 2017-10-04T13:13:23  *** Ylbam has quit IRC
182 2017-10-04T13:36:09  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/74123eabdd91...167cef8082e2
183 2017-10-04T13:36:09  <bitcoin-git> bitcoin/master f35d033 practicalswift: build: Make "make clean" remove all files created when running "make check"...
184 2017-10-04T13:36:10  <bitcoin-git> bitcoin/master 167cef8 Wladimir J. van der Laan: Merge #11435: build: Make "make clean" remove all files created when running "make check"...
185 2017-10-04T13:36:49  <bitcoin-git> [bitcoin] laanwj closed pull request #11435: build: Make "make clean" remove all files created when running "make check" (master...make-cleaner) https://github.com/bitcoin/bitcoin/pull/11435
186 2017-10-04T13:38:14  <bitcoin-git> [bitcoin] laanwj closed pull request #11046: Replace boost sleep_for with C++11 equivalent (master...2017/08/boost_sleep_for) https://github.com/bitcoin/bitcoin/pull/11046
187 2017-10-04T13:39:34  <bitcoin-git> [bitcoin] laanwj closed pull request #10990: 0 locktime issue (master...fix0locktimebug) https://github.com/bitcoin/bitcoin/pull/10990
188 2017-10-04T13:49:47  *** promag has joined #bitcoin-core-dev
189 2017-10-04T13:57:57  <promag> should we have only one BitcoinTestFramework subclass in each test file?
190 2017-10-04T14:02:24  <MarcoFalke> I'd prefer so. Otherwise you'd have to run them sequentially and a failure of the first causes the others not to run.
191 2017-10-04T14:03:02  <MarcoFalke> Also would be confusing to have (potentially) different topologies set in a single file
192 2017-10-04T14:03:51  <promag> Regarding #10941, I think we can merge -(alert|block|wallet)notify tests later
193 2017-10-04T14:03:53  <gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify functional test by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub
194 2017-10-04T14:04:07  <promag> but at the moment each one has different network setups and params
195 2017-10-04T14:05:50  <promag> I think merging those tests deserve a separate PR
196 2017-10-04T14:10:32  *** Tank4910 has joined #bitcoin-core-dev
197 2017-10-04T14:10:46  *** Tank4910 has left #bitcoin-core-dev
198 2017-10-04T14:18:08  *** Chris_Stewart_5 has quit IRC
199 2017-10-04T14:25:46  *** Chris_Stewart_5 has joined #bitcoin-core-dev
200 2017-10-04T14:31:22  *** jb55 has joined #bitcoin-core-dev
201 2017-10-04T14:33:18  *** Alina-malina has quit IRC
202 2017-10-04T14:35:45  *** Alina-malina has joined #bitcoin-core-dev
203 2017-10-04T14:39:25  *** Murch has quit IRC
204 2017-10-04T14:47:50  *** bitsko has joined #bitcoin-core-dev
205 2017-10-04T14:49:55  *** sanada has quit IRC
206 2017-10-04T14:50:53  <bitcoin-git> [bitcoin] promag closed pull request #11439: [test] Refactor ZMQ test to use one address per notification type (master...2017-10-clean-zmq-test) https://github.com/bitcoin/bitcoin/pull/11439
207 2017-10-04T14:52:02  *** Chris_Stewart_5 has quit IRC
208 2017-10-04T14:54:22  <promag> jnewbery: ScanForWalletTransactions interface is a bit weird
209 2017-10-04T14:54:43  *** sanada has joined #bitcoin-core-dev
210 2017-10-04T14:54:59  <promag> I think it should return the last block scanned
211 2017-10-04T14:55:15  <promag> and also *all* failed blocks
212 2017-10-04T14:55:28  <promag> not sure why only the most recent is useful
213 2017-10-04T15:07:55  *** Aaronvan_ has quit IRC
214 2017-10-04T15:08:31  *** AaronvanW has joined #bitcoin-core-dev
215 2017-10-04T15:10:04  *** alreadylate has joined #bitcoin-core-dev
216 2017-10-04T15:10:24  *** jb55 has quit IRC
217 2017-10-04T15:11:30  *** wraithm has joined #bitcoin-core-dev
218 2017-10-04T15:12:52  *** AaronvanW has quit IRC
219 2017-10-04T15:39:22  *** JackH has quit IRC
220 2017-10-04T15:40:37  *** Emcy has joined #bitcoin-core-dev
221 2017-10-04T15:43:37  *** sanada has quit IRC
222 2017-10-04T15:43:40  *** alreadylate has quit IRC
223 2017-10-04T15:44:38  *** mess110 has joined #bitcoin-core-dev
224 2017-10-04T15:49:32  *** sanada has joined #bitcoin-core-dev
225 2017-10-04T15:51:53  *** promag has quit IRC
226 2017-10-04T16:08:13  *** jtimon has joined #bitcoin-core-dev
227 2017-10-04T16:13:07  *** bitsko has quit IRC
228 2017-10-04T16:16:20  *** Murch has joined #bitcoin-core-dev
229 2017-10-04T16:22:02  *** AaronvanW has joined #bitcoin-core-dev
230 2017-10-04T16:22:32  *** jb55 has joined #bitcoin-core-dev
231 2017-10-04T16:28:05  *** mess110 has quit IRC
232 2017-10-04T16:28:25  *** Chris_Stewart_5 has joined #bitcoin-core-dev
233 2017-10-04T16:32:05  *** Ylbam has joined #bitcoin-core-dev
234 2017-10-04T16:56:55  *** timothy has quit IRC
235 2017-10-04T16:58:10  *** timothy has joined #bitcoin-core-dev
236 2017-10-04T17:00:32  *** timothy has quit IRC
237 2017-10-04T17:02:55  *** laurentmt has quit IRC
238 2017-10-04T17:15:22  *** BashCo has quit IRC
239 2017-10-04T17:15:40  *** pergaminho has joined #bitcoin-core-dev
240 2017-10-04T17:20:44  *** promag has joined #bitcoin-core-dev
241 2017-10-04T17:28:31  *** abpa has joined #bitcoin-core-dev
242 2017-10-04T17:33:43  *** BashCo has joined #bitcoin-core-dev
243 2017-10-04T17:34:00  *** promag has quit IRC
244 2017-10-04T17:35:43  *** ghost43 has quit IRC
245 2017-10-04T17:35:43  *** dermoth has quit IRC
246 2017-10-04T17:35:43  *** afk11 has quit IRC
247 2017-10-04T17:35:43  *** arubi has quit IRC
248 2017-10-04T17:35:43  *** intcat has quit IRC
249 2017-10-04T17:36:39  *** ghost43 has joined #bitcoin-core-dev
250 2017-10-04T17:36:47  *** intcat has joined #bitcoin-core-dev
251 2017-10-04T17:36:59  *** afk11 has joined #bitcoin-core-dev
252 2017-10-04T17:39:04  *** lifeofguenter has quit IRC
253 2017-10-04T17:39:39  *** W4RL0RD has quit IRC
254 2017-10-04T17:40:08  *** arubi has joined #bitcoin-core-dev
255 2017-10-04T17:40:29  *** lifeofguenter has joined #bitcoin-core-dev
256 2017-10-04T17:45:07  *** vicenteH has quit IRC
257 2017-10-04T17:52:38  *** intcat has quit IRC
258 2017-10-04T17:53:33  *** intcat has joined #bitcoin-core-dev
259 2017-10-04T17:56:24  <jonasschnelli> Hopefully we can merge #7061 soon. (178 comments, open since almost two years)... :)
260 2017-10-04T17:56:28  <gribble> https://github.com/bitcoin/bitcoin/issues/7061 | [Wallet] Add RPC call "rescanblockchain " by jonasschnelli · Pull Request #7061 · bitcoin/bitcoin · GitHub
261 2017-10-04T17:56:29  <jonasschnelli> Needs some reacks
262 2017-10-04T17:59:30  *** Emcy has quit IRC
263 2017-10-04T18:21:08  *** Dizzle has joined #bitcoin-core-dev
264 2017-10-04T18:21:49  *** Guyver2 has joined #bitcoin-core-dev
265 2017-10-04T19:09:32  *** meshcollider has joined #bitcoin-core-dev
266 2017-10-04T19:11:23  *** Emcy has joined #bitcoin-core-dev
267 2017-10-04T19:22:59  *** Cheeseo has joined #bitcoin-core-dev
268 2017-10-04T19:23:42  <meshcollider> How long does it normally take before changes to bitcoincore.org repo go live
269 2017-10-04T19:30:57  *** mkarrer has joined #bitcoin-core-dev
270 2017-10-04T19:37:21  <cfields> jonasschnelli: very late pong
271 2017-10-04T19:37:41  <jonasschnelli> Heh...
272 2017-10-04T19:37:56  <jonasschnelli> It's now in a comment... let me link you
273 2017-10-04T19:38:10  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/10387#pullrequestreview-66842269
274 2017-10-04T19:38:41  <jonasschnelli> meshcollider: ask BlueMatt. But the recent merged changes are online
275 2017-10-04T19:39:12  <BlueMatt> meshcollider: like....60 seconds?
276 2017-10-04T19:39:36  <BlueMatt> unless someone fucked up the commit signatures, which folks are want to do
277 2017-10-04T19:39:53  <BlueMatt> err, wont to do
278 2017-10-04T19:40:34  *** mkarrer has quit IRC
279 2017-10-04T19:43:44  <cfields> jonasschnelli: sounds good to me
280 2017-10-04T19:44:07  <jonasschnelli> okay... there is still an issue... will fix soon, so wait with looking at the code
281 2017-10-04T19:44:25  <cfields> I'd really rather see fLimitedNode in CNodeState though :(
282 2017-10-04T19:44:38  <cfields> BlueMatt: thoughts on starting to migrate that way?
283 2017-10-04T19:44:58  <cfields> (see above link for reference)
284 2017-10-04T19:45:04  <BlueMatt> whats context?
285 2017-10-04T19:45:16  *** afk11 has quit IRC
286 2017-10-04T19:46:12  <cfields> BlueMatt: a bool to indicate whether or not a node is limited. Stored during version. Pretty much same use case as fPreferred
287 2017-10-04T19:47:46  *** jb55 has quit IRC
288 2017-10-04T19:48:38  <meshcollider> BlueMatt: jonasschnelli Oh I didn't see it because the release announcement isn't in the recent posts list
289 2017-10-04T19:48:43  <cfields> I think just used to avoid fetching old blocks. presumably jonasschnelli stuck it in CNode because that's where fClient lives (but shouldn't)
290 2017-10-04T19:49:09  <BlueMatt> meshcollider: we only fixed it like an hour or three ago
291 2017-10-04T19:49:32  <jonasschnelli> cfields: would always checking nServices be terrible? (instead of caching a boolen)?
292 2017-10-04T19:49:50  <BlueMatt> cfields: so, wait, you want to add an fLimitedNode in addition to the fPreferred stuff? why not just adapt UpdatePreferredDownload to consider limited-ness and call it on our peers in the first UpdatedBlockTip with not-fInitialDownload?
293 2017-10-04T19:51:13  *** afk11 has joined #bitcoin-core-dev
294 2017-10-04T19:52:47  <BlueMatt> you may be stuck in ibd for a while, there isnt much point in filling your outbound peers with limited nodes for that duration
295 2017-10-04T19:52:50  <BlueMatt> or am I missing something?
296 2017-10-04T19:54:51  <BlueMatt> grr, I'll go review the pr and give real feedback instead of bullshitting, give me 20 minutes
297 2017-10-04T19:55:00  <cfields> My initial thought was to tie it to preferred as well, but iirc that broke down somewhere
298 2017-10-04T19:56:27  *** SopaXorzTaker has quit IRC
299 2017-10-04T19:56:54  <cfields> I was also thinking that we'd want to avoid pruned nodes for initial headers sync, but I guess that's not really necessary
300 2017-10-04T19:58:35  <cfields> BlueMatt: generally though, I really dislike expanding the scope of variables like that. eventualy fPreferred turns into something entirely meaningless like "whitelisted"
301 2017-10-04T20:05:14  <jonasschnelli> Okay. Updated the PR
302 2017-10-04T20:05:15  <jonasschnelli> Relevant parts are here: https://github.com/bitcoin/bitcoin/pull/10387/files#diff-eff7adeaec73a769788bb78858815c91R1322
303 2017-10-04T20:13:45  <jonasschnelli> ping JeremyRu1in
304 2017-10-04T20:14:20  <jonasschnelli> My re-check / re-test told me,  rescanblockchain { start_height: 10, stop_height: 20 } does also rescan block 20
305 2017-10-04T20:17:10  *** jb55 has joined #bitcoin-core-dev
306 2017-10-04T20:18:17  *** JeremyRu1in is now known as JeremyRubin
307 2017-10-04T20:19:04  <JeremyRubin> jonasschnelli: it doesn't work; see PR comment
308 2017-10-04T20:19:26  <JeremyRubin> it's the failure mode that's broken, I should have been more clear
309 2017-10-04T20:19:46  <JeremyRubin> but I was confused about the general range semantics too; so more clear language is good there nonetheless
310 2017-10-04T20:27:18  <JeremyRubin> jonasschnelli: try scanning from 10 - 20 on a healthy node
311 2017-10-04T20:27:28  <JeremyRubin> then, corrupt block 20 so it won't scan.
312 2017-10-04T20:27:42  <JeremyRubin> now, rescan again
313 2017-10-04T20:27:45  <JeremyRubin> same result
314 2017-10-04T20:27:52  <JeremyRubin> now, corrupt blocks 10-20
315 2017-10-04T20:27:56  <JeremyRubin> will return the same thing
316 2017-10-04T20:28:32  <jonasschnelli> JeremyRubin: I added a LogPrintf below the ReadBlockFromDisk and AddToWalletIfInvolvingMe scan... and block 20 was scanned.
317 2017-10-04T20:28:43  <jonasschnelli> But maybe I should try your setup
318 2017-10-04T20:28:50  <BlueMatt> jonasschnelli: will you kill me if I suggest a cleanup to nRequiredServices/nRelevantServices as a first commit in your pr?
319 2017-10-04T20:29:00  * BlueMatt feels like he's pulling a cfields here :p
320 2017-10-04T20:29:14  <JeremyRubin> jonasschnelli: Yes, if your scanning does not fail, it is fine.
321 2017-10-04T20:29:14  <jonasschnelli> BlueMatt: ideally we keep cleanups in a seperate PR
322 2017-10-04T20:29:19  <BlueMatt> not like cfields ever requires it for others, but endless first-commit cleanups
323 2017-10-04T20:29:22  <JeremyRubin> But if you have a corruption, it is not.
324 2017-10-04T20:29:22  <jonasschnelli> BlueMatt: but I can cherry pick.. :)
325 2017-10-04T20:29:26  <cfields> heh
326 2017-10-04T20:29:29  <BlueMatt> jonasschnelli: let me play around a bit
327 2017-10-04T20:29:51  <jonasschnelli> JeremyRubin: what do you mean with corruption?
328 2017-10-04T20:29:57  <cfields> BlueMatt: only allowed if you first ack my socket changes you required :p
329 2017-10-04T20:29:58  <jonasschnelli> invalidateblock?
330 2017-10-04T20:30:27  <ryanofsky> jonasschnelli, if readblockfrom disk fails
331 2017-10-04T20:30:30  <jonasschnelli> BlueMatt: yeah. Happy to pull-in a cleanup into bip159 PR
332 2017-10-04T20:30:36  <BlueMatt> cfields: damn you
333 2017-10-04T20:30:57  *** jtimon has quit IRC
334 2017-10-04T20:31:36  <cfields> jonasschnelli: oh that reminds me, what do you think about adding "NODE_NETWORK should be combined with NODE_NETWORK_LIMITED" to the bip (if not already) ?
335 2017-10-04T20:31:44  <cfields> I don't think that's just an implementation detail
336 2017-10-04T20:31:46  <jonasschnelli> JeremyRubin, ryanofsky: aha... a filed ReadBlockFromDisk falsely reports a successful scan.
337 2017-10-04T20:32:04  <jonasschnelli> cfields: Yeah. Need to add this... is unclear in the BIP
338 2017-10-04T20:32:06  <JeremyRubin> No
339 2017-10-04T20:32:17  <jonasschnelli> *a failed
340 2017-10-04T20:32:20  <JeremyRubin> It correctly reports an unsuccessful scan
341 2017-10-04T20:32:28  <jonasschnelli> yeah.. what I meant. sry
342 2017-10-04T20:32:32  <JeremyRubin> you incorrectly interpret that result :)
343 2017-10-04T20:33:27  <JeremyRubin> basically ANY non-nullptr return should cause you to return "scan failed"
344 2017-10-04T20:33:30  <jonasschnelli> JeremyRubin: this would also be undetected in classic startup -rescans? Right?
345 2017-10-04T20:33:57  <JeremyRubin> Unsure of prior semantics of rescan
346 2017-10-04T20:34:21  *** vicenteH has joined #bitcoin-core-dev
347 2017-10-04T20:34:50  <JeremyRubin> it would be reported that you have only succeeded in scanning blocks after LAST_FAILED, so then you would need to rescan up to LAST_FAILED
348 2017-10-04T20:34:56  <jonasschnelli> the current rescan function skips corrupted blocks IMO
349 2017-10-04T20:35:39  <JeremyRubin> Yes, but it also tells you 'no guarantees before block N'
350 2017-10-04T20:35:53  <JeremyRubin> where N = LAST_FAILED
351 2017-10-04T20:36:17  <JeremyRubin> this impl, however, is happy to tell you Blocks A-B succeded
352 2017-10-04T20:36:20  <JeremyRubin> which is incorrect
353 2017-10-04T20:37:23  <jonasschnelli> I see.. let me see how we can fix this.
354 2017-10-04T20:37:37  <JeremyRubin> you have 2 choices I think
355 2017-10-04T20:37:41  <jonasschnelli> I don't want to change the way how current startup -rescans work..
356 2017-10-04T20:37:45  <JeremyRubin> either keep a vector of all failures
357 2017-10-04T20:37:57  <jonasschnelli> aborting on a corrupted block seems not to be the ideal choice
358 2017-10-04T20:38:00  <JeremyRubin> if passed in as a ptr arg with default nullptr
359 2017-10-04T20:38:16  <JeremyRubin> And return a vector of failures
360 2017-10-04T20:38:30  <jonasschnelli> or report "could not read all block" (bool)?
361 2017-10-04T20:38:52  <JeremyRubin> That could work too...
362 2017-10-04T20:39:24  <JeremyRubin> I would (personally) not return *anything* if there are any failures.
363 2017-10-04T20:39:44  <jonasschnelli> AFAIK, ScanForWalletTransactions returns non-nullptr when detecting a corrupt block.. could use that
364 2017-10-04T20:41:12  <JeremyRubin> yes, that's fine. I would return a `Maybe (Int,Int)`, and only return `Some (start, stop)` if there are no failures.
365 2017-10-04T20:42:50  <JeremyRubin> I would also push you to rework the errors to differentiate when the numbers are actually invalid v.s. out of range for the current chain we're on.
366 2017-10-04T20:43:38  <JeremyRubin> Because asking for (1000, 2000) could fail depending on how caught up you are.
367 2017-10-04T20:44:06  <JeremyRubin> But is not an invalid request like (2000,1000), (-10, 20), etc.
368 2017-10-04T20:45:49  <JeremyRubin> (in particular, because I think that it would be useful to issue a rescan from, let's say, (tip-10, tip+1000) and for it to return (tip-10, tip)
369 2017-10-04T20:48:54  <jonasschnelli> JeremyRubin: I think that should do it: https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3237
370 2017-10-04T20:50:15  <JeremyRubin> jonasschnelli: I think that seems correct to me. If you have no failures reported, then all the blocks were scanned in that range
371 2017-10-04T20:50:49  <jonasschnelli> Yes. If you get this (new) error, you may have scanned some of the blocks (but we won't tell which one)
372 2017-10-04T20:51:03  <JeremyRubin> Correct.
373 2017-10-04T20:51:17  <jonasschnelli> If you have a corrupted block you are alreafy in serious troubles... :)
374 2017-10-04T20:51:54  <JeremyRubin> Yes. Maybe worth saying 'Rescan Failed. Potentially corruputed data files.'
375 2017-10-04T20:52:52  <jonasschnelli> JeremyRubin: Thanks... let me add this
376 2017-10-04T20:53:17  <JeremyRubin> jonasschnelli: my comment about handling of invalid ranges though still stands. differentiating between the cases of overlap is good, an you can return useful results in some of them.
377 2017-10-04T20:54:06  <jonasschnelli> JeremyRubin: can you rephrase? I don't get your range concern
378 2017-10-04T20:54:22  <JeremyRubin> bad ranges: ()[] ([)] good ranges: [()] ok ranges: [(]) []()
379 2017-10-04T20:54:36  <jonasschnelli> ?
380 2017-10-04T20:55:01  <JeremyRubin> (let '(' and ')' denote the start and stop range, and '[' and ']' denote genesis to tip on a number line)
381 2017-10-04T20:55:14  <jonasschnelli> aha...
382 2017-10-04T20:55:42  *** promag has joined #bitcoin-core-dev
383 2017-10-04T20:55:43  <JeremyRubin> so if i ask for (tip -10, tip+100) you should return scanned (tip-10, tip)
384 2017-10-04T20:55:45  <jonasschnelli> stop_height is optional but start_heigt is required when stop_height is passed
385 2017-10-04T20:56:22  <jonasschnelli> I think tip+100 should result in an error
386 2017-10-04T20:56:35  <JeremyRubin> I don't
387 2017-10-04T20:56:47  <JeremyRubin> because it could result from our node just being behind and syncing
388 2017-10-04T20:57:03  *** promag has quit IRC
389 2017-10-04T20:57:14  <jonasschnelli> Yeah.. but would you silently ignore it? IMO it deserves that we inform the user (with an error)
390 2017-10-04T20:57:18  <JeremyRubin> If you want it to be an error, it shouldn't be invalid it should be 'not synced to X yet'
391 2017-10-04T20:57:24  <jonasschnelli> Then he can self-correct rather then auto-correct
392 2017-10-04T20:57:24  *** pergaminho has quit IRC
393 2017-10-04T20:57:39  <JeremyRubin> if you want it to be more clear, then you should always return the current tip
394 2017-10-04T20:58:44  <JeremyRubin> but in the 'ok ranges' cases, the type of failure is very different from the bad ranges
395 2017-10-04T20:59:00  <JeremyRubin> bad ranges will NEVER succeed, ok ranges will succeed if you wait long enough
396 2017-10-04T20:59:45  <JeremyRubin> So bad ranges are invalid. ok ranges are too 'soon' for our node.
397 2017-10-04T21:00:17  *** jtimon has joined #bitcoin-core-dev
398 2017-10-04T21:01:03  <JeremyRubin> And if you don't want to support ok ranges, then there is no point of returning the range scanned at all, you may as well return `Maybe ()` because success means the range was scanned.
399 2017-10-04T21:02:15  <JeremyRubin> ((unless I'm not seeing some edge case? Maybe if you somehow trigger an abortrescan you would return (start, point_aborted)?))
400 2017-10-04T21:02:26  <jonasschnelli> JeremyRubin: but with the current fix (throw when getting a non-nullptr) there is a guarantee we have scanned the given range, right?
401 2017-10-04T21:02:35  <JeremyRubin> Correct!
402 2017-10-04T21:02:45  <jonasschnelli> Do you see anything else t
403 2017-10-04T21:02:49  <jonasschnelli> to fix?
404 2017-10-04T21:02:57  <JeremyRubin> ((Except see above abortrescan concern))
405 2017-10-04T21:03:13  <jonasschnelli> abortrescan leads to an explicit error thrown
406 2017-10-04T21:03:24  <JeremyRubin> ok -- so then no point in returning the range
407 2017-10-04T21:03:28  <jonasschnelli> https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3231
408 2017-10-04T21:03:31  <JeremyRubin> so remove the return values
409 2017-10-04T21:03:36  <jonasschnelli> the throw will lead to not return the range
410 2017-10-04T21:04:10  <JeremyRubin> Actually... making abortrescan return the range seems like good UX
411 2017-10-04T21:04:51  <jonasschnelli> We could add that later,.. seems out of scope and related to #11450
412 2017-10-04T21:04:52  <gribble> https://github.com/bitcoin/bitcoin/issues/11450 | ScanForWalletTransactions return value is incorrectly documented · Issue #11450 · bitcoin/bitcoin · GitHub
413 2017-10-04T21:05:06  <JeremyRubin> k -- so otherwise, you should get rid of the return values.
414 2017-10-04T21:05:16  <jtimon> I really don't get it, if someone else can try to explain, that would be welcomed re https://github.com/bitcoin/bitcoin/pull/11427#issuecomment-334033122
415 2017-10-04T21:05:20  <JeremyRubin> Unless you want to handle the ranges I've labelled 'ok'
416 2017-10-04T21:05:50  <jonasschnelli> You are aware that a *throw" will lead to return nothing blow that acctuall throw code line?
417 2017-10-04T21:06:00  <JeremyRubin> (which, even if not handled, I think merit a separate designation from 'invalid')
418 2017-10-04T21:06:38  <JeremyRubin> jonasschnelli: I'm merely pointing out that the absence of an error indicates that the request completed as requested, so the caller already knows start and stop.
419 2017-10-04T21:07:15  <JeremyRubin> But maybe it's better interface design to not rely on that in case we improve the behavior in the future ;)
420 2017-10-04T21:07:52  <jonasschnelli> JeremyRubin: hm... sorry for not following completely... which absence of an error you referring to?
421 2017-10-04T21:08:10  *** promag has joined #bitcoin-core-dev
422 2017-10-04T21:08:11  <jonasschnelli> Abort rescan leads to an error: https://github.com/bitcoin/bitcoin/pull/7061/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR3232
423 2017-10-04T21:08:37  <JeremyRubin> Ok. So you're a client. You ask for rescan (tip-10,tip-5).
424 2017-10-04T21:08:48  <JeremyRubin> I'm the server.
425 2017-10-04T21:08:59  <JeremyRubin> I see the request, and I rescan happily.
426 2017-10-04T21:09:44  <JeremyRubin> I now will return a range (start, stop) based on your request.
427 2017-10-04T21:10:12  <JeremyRubin> Under what circumstance do you, the caller, not already know what that range is?
428 2017-10-04T21:10:33  <JeremyRubin> I suppose you don't know the tip if you only pass a start?
429 2017-10-04T21:11:21  <JeremyRubin> So maybe it merits returning just the finish height, but you never don't know what start you requested already.
430 2017-10-04T21:12:28  *** Alina-malina has quit IRC
431 2017-10-04T21:12:53  <JeremyRubin> Anyways... this is secondary, it's not really an issue. But I think that handling ok ranges addresses my concern anyways.
432 2017-10-04T21:13:40  *** promag has quit IRC
433 2017-10-04T21:13:58  <jonasschnelli> JeremyRubin: Okay. I see you point.
434 2017-10-04T21:14:16  <jonasschnelli> I guess we could leave it away completely then.... or keep it for future extenions...
435 2017-10-04T21:14:37  *** Alina-malina has joined #bitcoin-core-dev
436 2017-10-04T21:14:42  <jonasschnelli> Although, if you keep away the stop height,... you should at leat get the height of the scanned tip
437 2017-10-04T21:14:46  <jonasschnelli> Which may be important
438 2017-10-04T21:18:08  <JeremyRubin> I think that handling ok ranges in the manner suggested gets this to have the correct semantics for the returned data
439 2017-10-04T21:18:11  <jonasschnelli> JeremyRubin: thanks for reviewing and helping me to understand your point. :)
440 2017-10-04T21:18:23  <JeremyRubin> yeah, sorry if my explanations were unclear
441 2017-10-04T21:19:13  <JeremyRubin> It was a pretty subtle bug I guess, because a lot of people missed it!
442 2017-10-04T21:19:14  <jonasschnelli> Re-reading your comments looks like I had my eyes covered with tomatos
443 2017-10-04T21:20:29  <jonasschnelli> Yes. Glad you did a review.. and tell me, if you think other stuff needs to be changed/fixed.
444 2017-10-04T21:24:35  *** promag has joined #bitcoin-core-dev
445 2017-10-04T21:27:57  *** Alina-malina has quit IRC
446 2017-10-04T21:28:40  <JeremyRubin> jonasschnelli: I would like to see ok_ranges handled in the code and then I'd ack it. If you feel strongly that they should not attempt to scan, and just fail, that's fine. But it should at least return different error strings (e.g., 'start is greater than tip', 'end is greater than tip', 'start must be positive', 'end must be positive')
447 2017-10-04T21:29:35  *** Alina-malina has joined #bitcoin-core-dev
448 2017-10-04T21:30:11  <JeremyRubin> but I think that it is simple to say that at least the end being greater than the tip has an obvious execution (execute as if no argument were provided).
449 2017-10-04T21:32:20  <JeremyRubin> Start being greater than the tip requires some notion of an empty scan, which I don't think you can express easily with an inclusive range (unless you do another optional bool not_synced_fully).
450 2017-10-04T21:35:21  *** Alina-malina has quit IRC
451 2017-10-04T21:38:09  *** Alina-malina has joined #bitcoin-core-dev
452 2017-10-04T21:41:01  *** tiktaktoe has joined #bitcoin-core-dev
453 2017-10-04T21:44:09  *** tiktaktoe has quit IRC
454 2017-10-04T21:46:41  *** Alina-malina has quit IRC
455 2017-10-04T21:48:02  *** d9b4bef9 has quit IRC
456 2017-10-04T21:48:37  *** Alina-malina has joined #bitcoin-core-dev
457 2017-10-04T21:49:07  *** d9b4bef9 has joined #bitcoin-core-dev
458 2017-10-04T21:54:33  *** Alina-malina has quit IRC
459 2017-10-04T21:55:53  *** Guyver2 has quit IRC
460 2017-10-04T21:56:08  *** Alina-malina has joined #bitcoin-core-dev
461 2017-10-04T21:59:13  *** laurentmt has joined #bitcoin-core-dev
462 2017-10-04T21:59:14  *** laurentmt has quit IRC
463 2017-10-04T21:59:44  *** laurentmt has joined #bitcoin-core-dev
464 2017-10-04T21:59:56  *** laurentmt has quit IRC
465 2017-10-04T22:02:39  <JeremyRubin> jonasschnelli: ^^^ afk soon, shoot an email if questions
466 2017-10-04T22:08:46  *** Chris_Stewart_5 has quit IRC
467 2017-10-04T22:09:21  *** owowo has quit IRC
468 2017-10-04T22:11:21  *** Alina-malina has quit IRC
469 2017-10-04T22:13:37  *** Alina-malina has joined #bitcoin-core-dev
470 2017-10-04T22:14:42  *** owowo has joined #bitcoin-core-dev
471 2017-10-04T22:22:12  *** Alina-malina has quit IRC
472 2017-10-04T22:23:35  *** Alina-malina has joined #bitcoin-core-dev
473 2017-10-04T22:27:41  *** wraithm has quit IRC
474 2017-10-04T22:37:17  <bitcoin-git> [bitcoin] promag opened pull request #11452: Improve ZMQ functional test (master...2017-10-improve-zmq-test) https://github.com/bitcoin/bitcoin/pull/11452
475 2017-10-04T23:01:49  *** goatpig has quit IRC
476 2017-10-04T23:09:44  *** Dizzle has quit IRC
477 2017-10-04T23:11:00  *** promag has quit IRC
478 2017-10-04T23:12:05  *** Alina-malina has quit IRC
479 2017-10-04T23:14:12  *** Alina-malina has joined #bitcoin-core-dev
480 2017-10-04T23:20:33  *** Alina-malina has quit IRC
481 2017-10-04T23:23:43  *** Alina-malina has joined #bitcoin-core-dev
482 2017-10-04T23:25:38  *** promag has joined #bitcoin-core-dev
483 2017-10-04T23:43:52  *** Alina-malina has quit IRC
484 2017-10-04T23:46:17  *** Alina-malina has joined #bitcoin-core-dev
485 2017-10-04T23:46:28  *** promag has quit IRC
486 2017-10-04T23:52:32  *** jb55 has quit IRC
487 2017-10-04T23:58:41  *** abpa has quit IRC
488 2017-10-04T23:59:08  *** Alina-malina has quit IRC