1 2017-10-11T00:09:40  *** owowo has quit IRC
  2 2017-10-11T00:10:34  *** jb55 has quit IRC
  3 2017-10-11T00:11:52  *** VIctorsueca has quit IRC
  4 2017-10-11T00:14:11  *** Victorsueca has joined #bitcoin-core-dev
  5 2017-10-11T00:15:55  *** owowo has joined #bitcoin-core-dev
  6 2017-10-11T00:17:40  *** ProfMac has quit IRC
  7 2017-10-11T00:24:07  *** AaronvanW has quit IRC
  8 2017-10-11T00:28:38  *** Victorsueca has quit IRC
  9 2017-10-11T00:29:47  *** Victorsueca has joined #bitcoin-core-dev
 10 2017-10-11T00:33:05  *** Emcy_ has joined #bitcoin-core-dev
 11 2017-10-11T00:35:48  *** Emcy has quit IRC
 12 2017-10-11T00:43:01  *** jannes has quit IRC
 13 2017-10-11T01:00:21  *** dabura667 has joined #bitcoin-core-dev
 14 2017-10-11T01:04:35  *** dabura667 has quit IRC
 15 2017-10-11T01:05:48  *** dabura667 has joined #bitcoin-core-dev
 16 2017-10-11T01:16:25  *** wxss has quit IRC
 17 2017-10-11T01:26:04  *** jb55 has joined #bitcoin-core-dev
 18 2017-10-11T01:36:26  *** ProfMac has joined #bitcoin-core-dev
 19 2017-10-11T02:01:41  *** sager has joined #bitcoin-core-dev
 20 2017-10-11T02:21:35  *** kayamm has quit IRC
 21 2017-10-11T02:24:13  *** kayamm has joined #bitcoin-core-dev
 22 2017-10-11T02:24:14  *** kayamm has joined #bitcoin-core-dev
 23 2017-10-11T02:25:41  *** merehap__ has quit IRC
 24 2017-10-11T02:25:50  *** merehap__ has joined #bitcoin-core-dev
 25 2017-10-11T02:27:19  *** merehap_ has joined #bitcoin-core-dev
 26 2017-10-11T02:27:19  *** merehap__ has quit IRC
 27 2017-10-11T02:30:04  *** merehap_ has quit IRC
 28 2017-10-11T02:30:17  *** merehap_ has joined #bitcoin-core-dev
 29 2017-10-11T02:32:38  <bitcoin-git> [bitcoin] PierreRochard opened pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478
 30 2017-10-11T02:35:09  <bitcoin-git> [bitcoin] PierreRochard closed pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478
 31 2017-10-11T02:35:09  *** rty has joined #bitcoin-core-dev
 32 2017-10-11T02:42:22  *** sager has quit IRC
 33 2017-10-11T02:43:48  *** bbt has joined #bitcoin-core-dev
 34 2017-10-11T02:44:11  *** bbt is now known as Guest34123
 35 2017-10-11T02:45:29  *** Guest34123 has quit IRC
 36 2017-10-11T02:51:28  <bitcoin-git> [bitcoin] kswapd opened pull request #11479: [Docs] Update README.md to add Freenode  links (master...master) https://github.com/bitcoin/bitcoin/pull/11479
 37 2017-10-11T02:53:58  *** rty has quit IRC
 38 2017-10-11T03:02:30  *** harding has quit IRC
 39 2017-10-11T04:03:22  *** goatpig has joined #bitcoin-core-dev
 40 2017-10-11T04:15:08  *** arubi has quit IRC
 41 2017-10-11T04:20:26  *** arubi has joined #bitcoin-core-dev
 42 2017-10-11T04:37:51  *** chjj has quit IRC
 43 2017-10-11T05:02:08  <bitcoin-git> [bitcoin] tjps opened pull request #11480: [ui] Add toggle for unblinding password fields (master...tjps_wallet_dialog) https://github.com/bitcoin/bitcoin/pull/11480
 44 2017-10-11T05:48:49  *** DrOlmer has quit IRC
 45 2017-10-11T05:49:18  *** DrOlmer has joined #bitcoin-core-dev
 46 2017-10-11T05:58:25  *** ananteris has quit IRC
 47 2017-10-11T06:16:19  *** Giszmo has quit IRC
 48 2017-10-11T06:23:23  *** finapteka has joined #bitcoin-core-dev
 49 2017-10-11T06:24:26  *** finapteka has quit IRC
 50 2017-10-11T06:34:09  *** PatBoy has quit IRC
 51 2017-10-11T06:35:53  *** PatBoy has joined #bitcoin-core-dev
 52 2017-10-11T06:37:48  *** dcousens has quit IRC
 53 2017-10-11T06:50:13  *** BashCo has quit IRC
 54 2017-10-11T06:57:40  *** promag has joined #bitcoin-core-dev
 55 2017-10-11T07:05:59  *** promag has quit IRC
 56 2017-10-11T07:08:49  *** BashCo has joined #bitcoin-core-dev
 57 2017-10-11T07:17:21  *** jb55 has quit IRC
 58 2017-10-11T07:23:44  *** timothy has joined #bitcoin-core-dev
 59 2017-10-11T07:25:32  *** Guyver2 has joined #bitcoin-core-dev
 60 2017-10-11T07:40:05  *** laurentmt has joined #bitcoin-core-dev
 61 2017-10-11T07:41:54  *** Cheeseo has quit IRC
 62 2017-10-11T08:03:13  *** JackH has quit IRC
 63 2017-10-11T08:12:06  <bitcoin-git> [bitcoin] AmirAbrams opened pull request #11482: Use CPrivKey typedef for keydata in CKey (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11482
 64 2017-10-11T08:18:18  *** Guyver2 has quit IRC
 65 2017-10-11T08:21:21  *** rafalcpp has quit IRC
 66 2017-10-11T08:21:40  *** promag has joined #bitcoin-core-dev
 67 2017-10-11T08:44:09  *** drizztbsd has joined #bitcoin-core-dev
 68 2017-10-11T08:44:57  *** timothy has quit IRC
 69 2017-10-11T08:45:54  <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a9da37fb3f4...0e3a41135157
 70 2017-10-11T08:45:55  <bitcoin-git> bitcoin/master 3f0ee3e Jorge Timón: Proper indentation for CheckTxInputs and other minor fixes
 71 2017-10-11T08:45:55  <bitcoin-git> bitcoin/master 832e074 Jorge Timón: Optimization: Minimize the number of times it is checked that no money is created...
 72 2017-10-11T08:45:56  <bitcoin-git> bitcoin/master 3e8c916 Jorge Timón: Introduce CheckInputsAndUpdateCoins static wrapper in txmempool.cpp
 73 2017-10-11T08:46:39  *** vicenteH has joined #bitcoin-core-dev
 74 2017-10-11T08:48:03  *** alreadylate has joined #bitcoin-core-dev
 75 2017-10-11T08:48:32  *** rafalcpp has joined #bitcoin-core-dev
 76 2017-10-11T08:53:14  *** Ylbam has joined #bitcoin-core-dev
 77 2017-10-11T08:53:29  <wumpus> meshcollider: listing 'available' wallets would be a lot easier with the walletdir
 78 2017-10-11T08:54:35  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e3a41135157...fef65c4f5e59
 79 2017-10-11T08:54:36  <bitcoin-git> bitcoin/master a2be3b6 Jim Posen: [net] Ignore getheaders requests for very old side blocks...
 80 2017-10-11T08:54:36  <bitcoin-git> bitcoin/master eff4bd8 Jim Posen: [test] P2P functional test for certain fingerprinting protections
 81 2017-10-11T08:54:37  <bitcoin-git> bitcoin/master fef65c4 Wladimir J. van der Laan: Merge #11113: [net] Ignore getheaders requests for very old side blocks...
 82 2017-10-11T08:55:13  <bitcoin-git> [bitcoin] laanwj closed pull request #11113: [net] Ignore getheaders requests for very old side blocks (master...net-getheaders-fingerprint) https://github.com/bitcoin/bitcoin/pull/11113
 83 2017-10-11T08:56:32  <meshcollider> wumpus: yes indeed, I'm just wondering whether there is any point in adding a list of `available` wallets inside the walletdir to the `listwallets` RPC
 84 2017-10-11T08:56:48  <promag>  wumpus what is the real use case for that?
 85 2017-10-11T08:57:07  <wumpus> promag: for listing available wallets? would be nice in the GUI at least
 86 2017-10-11T08:57:23  <wumpus> otherwise peopel have to remember the names
 87 2017-10-11T08:57:45  <wumpus> which is okay for the first version or whatever, but in the long run would be nice to select from a list instead
 88 2017-10-11T08:57:54  <wumpus> there's no urgency in having it though
 89 2017-10-11T08:57:57  <promag> But the app is configured with the wallets, and there is no way to create wallets
 90 2017-10-11T08:58:00  <meshcollider> because the only clean-ish way I can think of to find wallets in the walletdir is looking for .dat extensions right?
 91 2017-10-11T08:58:28  <meshcollider> promag dynamic loading/unloading of wallets will be coming soon right?
 92 2017-10-11T08:58:29  <wumpus> check for berkeleydb databases
 93 2017-10-11T08:59:06  <wumpus> (requiring .dat naming is fine with me too, but not all .dats are bdb databases unfortuantely)
 94 2017-10-11T08:59:12  <promag> I feel that's not the right path
 95 2017-10-11T08:59:19  <promag> not all berkeleydb files are wallets
 96 2017-10-11T08:59:30  <wumpus> in the wallet directory they can be assumed to be
 97 2017-10-11T08:59:41  <wumpus> but if you want to add an additional check on loading, fine
 98 2017-10-11T08:59:48  <wumpus> there's some keys that are only in wallets...
 99 2017-10-11T08:59:52  <wumpus> (like the wallet version)
100 2017-10-11T09:00:37  <wumpus> I'm more afraid of users copying valid wallets from other forks though :(
101 2017-10-11T09:01:01  <wumpus> so if we want to add more robustness to wallet loading, yeah, we'd have to consider that...
102 2017-10-11T09:01:08  <meshcollider> The easiest way to check if a file is a bdb file is with magic bytes like ryanofsky suggested here? https://github.com/bitcoin/bitcoin/pull/11466#discussion_r143730935
103 2017-10-11T09:01:13  <wumpus> meshcollider: yes
104 2017-10-11T09:01:34  *** Emcy has joined #bitcoin-core-dev
105 2017-10-11T09:01:42  <wumpus> certainly that's the way to do it without getting berkeleydb involved
106 2017-10-11T09:01:49  <meshcollider> I think I'll take that commit out of my current PR and make a new one
107 2017-10-11T09:01:54  <meshcollider> this will be too much to discuss
108 2017-10-11T09:01:58  <wumpus> but why do you need this now?
109 2017-10-11T09:02:29  <meshcollider> I was going to do the `listwallets` change as part of #11466
110 2017-10-11T09:02:30  <wumpus> I think we need listing available wallets yet, yes lease separate that out
111 2017-10-11T09:02:31  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | [WIP] Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
112 2017-10-11T09:02:41  <meshcollider> yep 👍
113 2017-10-11T09:02:51  <promag> I would open the wallet, keep it open, but not load the transactions
114 2017-10-11T09:03:22  <wumpus> I mean I *don't* think we need listing available wallets yet
115 2017-10-11T09:03:50  <promag> listwallets change in a different PR will make your PR faster to review and merge meshcollider
116 2017-10-11T09:03:54  <wumpus> we need to enforce some naming convention on wallets in that case (we don't even require .dat at the moment) as well as make sure wallets are somehow tagged as bitcoin wallet
117 2017-10-11T09:04:04  <wumpus> e.g. by having a key in them that identifies them as being such
118 2017-10-11T09:04:09  <promag> *.wlt :troll:
119 2017-10-11T09:04:43  *** Emcy_ has quit IRC
120 2017-10-11T09:05:03  <meshcollider> Yep its more complicated than i initially thought, seperating it out now
121 2017-10-11T09:05:05  *** laurentmt has quit IRC
122 2017-10-11T09:05:10  <wumpus> promag: if you want to go that way it's better to go full out and use .bitcoinwallet - to rule out overlap with forks etc
123 2017-10-11T09:05:29  <wumpus> and altcoins
124 2017-10-11T09:06:02  <wumpus> this is a discussion topic when the wallet format is changed
125 2017-10-11T09:06:16  <promag> I was kidding :P but maybe .bitcoin-core-wallet
126 2017-10-11T09:06:17  <wumpus> from berkeleydb to something custom, for example
127 2017-10-11T09:06:39  <wumpus> we certainly don't want to stick with .dat then
128 2017-10-11T09:07:40  <promag> well, I think a good implementation will open the whatever-file-is and use/validate the content
129 2017-10-11T09:08:26  <wumpus> I'm all for being more robust when actually opening wallets
130 2017-10-11T09:08:34  <wumpus> but when scanning for available wallets please don't get bdb involved
131 2017-10-11T09:09:01  <wumpus> if you need to look at magics etc, a quick read-only scan should be enough
132 2017-10-11T09:09:03  <promag> listing an available but invalid wallet is stupid?
133 2017-10-11T09:09:11  <wumpus> but rare!
134 2017-10-11T09:09:18  <promag> ok then
135 2017-10-11T09:09:20  <wumpus> opening with berkeleydb is heavy
136 2017-10-11T09:09:35  <promag> why? does it load everything?
137 2017-10-11T09:09:36  <wumpus> also involves potential writing, you don't want the program to write to files it's not told to touch
138 2017-10-11T09:09:38  <wumpus> yes
139 2017-10-11T09:09:45  <wumpus> it does various things
140 2017-10-11T09:09:46  <promag> ok, I rest
141 2017-10-11T09:10:25  <meshcollider> hah i dont think i can checkout a new branch while building the current one
142 2017-10-11T09:10:32  <meshcollider> ill have to use my tablet instead
143 2017-10-11T09:10:45  <wumpus> meshcollider: you can use git worktrees
144 2017-10-11T09:11:03  <wumpus> and check out different branches in different directories
145 2017-10-11T09:11:16  <meshcollider> ooh really? That's cool, I've never even heard of that being possible before
146 2017-10-11T09:11:21  <meshcollider> I'll look it up
147 2017-10-11T09:11:21  <wumpus> it's awesome, especially with large projects like linux where you really don't want to have multiple full clones
148 2017-10-11T09:11:30  <meshcollider> Yeah :D
149 2017-10-11T09:15:13  <promag> yes, thank god sipa introduced that to me a couple of months ago
150 2017-10-11T09:18:57  <promag> wumpus: easy one #10941, just improves test suite
151 2017-10-11T09:18:59  <wumpus> it also helps for some things to do out-of-tree builds, though mostly to keep you git tree clean, and be able to build for different architectures from one source tree - it doesn't allow you to switch the branch while building
152 2017-10-11T09:19:00  <gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify and walletnotify functional tests by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub
153 2017-10-11T09:20:31  <promag> I think it's time give #11006 a chance?
154 2017-10-11T09:20:32  <gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
155 2017-10-11T09:23:23  *** oakley91 has joined #bitcoin-core-dev
156 2017-10-11T09:26:15  *** promag has quit IRC
157 2017-10-11T09:26:45  <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fef65c4f5e59...364da2c52942
158 2017-10-11T09:26:46  <bitcoin-git> bitcoin/master 9c72a46 John Newbery: [tests] Tidy up forknotify.py
159 2017-10-11T09:26:46  <bitcoin-git> bitcoin/master df18d29 João Barbosa: [tests] Add -blocknotify functional test
160 2017-10-11T09:26:47  <bitcoin-git> bitcoin/master 857b32b João Barbosa: [tests] Add -walletnotify functional test
161 2017-10-11T09:27:11  <bitcoin-git> [bitcoin] laanwj closed pull request #10941: Add blocknotify and walletnotify functional tests (master...2017-07-blocknotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10941
162 2017-10-11T09:29:12  *** anusorns has joined #bitcoin-core-dev
163 2017-10-11T09:31:25  *** AaronvanW has joined #bitcoin-core-dev
164 2017-10-11T09:32:02  *** anusorns has quit IRC
165 2017-10-11T09:32:59  *** promag has joined #bitcoin-core-dev
166 2017-10-11T09:33:25  *** Aaronvan_ has joined #bitcoin-core-dev
167 2017-10-11T09:33:57  *** promag has quit IRC
168 2017-10-11T09:36:24  *** promag_ has joined #bitcoin-core-dev
169 2017-10-11T09:36:57  *** AaronvanW has quit IRC
170 2017-10-11T09:40:06  <promag_> wumpus: regarding the eye icon, are there designers contributing? or are the used icons open source?
171 2017-10-11T09:41:22  <wumpus> what's wrong with the eye icon we alread have?
172 2017-10-11T09:42:39  <wumpus> (I edited th4e post)
173 2017-10-11T09:45:44  <promag_> oh there is an eye icon already
174 2017-10-11T09:45:58  <wumpus> if you want a new icon you'd have to find an icon that has the correct license (ideally MIT or public design) or an artist that wants to create such an icon under the appropriate license
175 2017-10-11T09:46:08  <wumpus> jonasschnelli designed most of the current ones
176 2017-10-11T09:46:30  <promag_> this eye? src/qt/res/icons/eye.png
177 2017-10-11T09:46:33  <wumpus> yes :)
178 2017-10-11T09:46:51  <promag_> ok, lgtm
179 2017-10-11T09:47:51  <wumpus> s/public design/public domain
180 2017-10-11T09:48:42  *** AaronvanW has joined #bitcoin-core-dev
181 2017-10-11T09:51:33  *** Aaronvan_ has quit IRC
182 2017-10-11T09:52:07  *** promag_ has quit IRC
183 2017-10-11T09:58:32  *** Aaronvan_ has joined #bitcoin-core-dev
184 2017-10-11T09:59:41  *** AaronvanW has quit IRC
185 2017-10-11T10:02:53  *** laurentmt has joined #bitcoin-core-dev
186 2017-10-11T10:11:05  *** dabura667 has quit IRC
187 2017-10-11T10:12:33  <bitcoin-git> [bitcoin] laanwj closed pull request #11479: [Docs] Update README.md to add Freenode  links (master...master) https://github.com/bitcoin/bitcoin/pull/11479
188 2017-10-11T10:20:16  <bitcoin-git> [bitcoin] pedrobranco opened pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483
189 2017-10-11T10:28:59  *** moctos has joined #bitcoin-core-dev
190 2017-10-11T10:29:47  *** niska has quit IRC
191 2017-10-11T10:34:33  *** niska has joined #bitcoin-core-dev
192 2017-10-11T10:35:11  <bitcoin-git> [bitcoin] pedrobranco opened pull request #11484: Optional update rescan option in importmulti RPC (master...enhancement/optional-update-rescan-on-importmulti) https://github.com/bitcoin/bitcoin/pull/11484
193 2017-10-11T10:41:27  *** mmgen has joined #bitcoin-core-dev
194 2017-10-11T10:44:37  *** m8tion has joined #bitcoin-core-dev
195 2017-10-11T10:48:07  *** cluskinator has joined #bitcoin-core-dev
196 2017-10-11T10:48:47  *** cluskinator is now known as clusk
197 2017-10-11T10:51:38  *** m8tion01 has joined #bitcoin-core-dev
198 2017-10-11T10:52:42  *** promag has joined #bitcoin-core-dev
199 2017-10-11T10:54:01  *** m8tion has quit IRC
200 2017-10-11T10:54:01  *** Emcy has quit IRC
201 2017-10-11T10:55:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
202 2017-10-11T10:56:32  *** timothy has joined #bitcoin-core-dev
203 2017-10-11T10:57:01  *** drizztbsd has quit IRC
204 2017-10-11T11:02:33  *** pindarhk_ has quit IRC
205 2017-10-11T11:03:21  *** pindarhk_ has joined #bitcoin-core-dev
206 2017-10-11T11:06:15  *** AaronvanW has joined #bitcoin-core-dev
207 2017-10-11T11:09:21  *** Aaronvan_ has quit IRC
208 2017-10-11T11:10:41  *** Aaronvan_ has joined #bitcoin-core-dev
209 2017-10-11T11:13:52  *** AaronvanW has quit IRC
210 2017-10-11T11:14:39  *** laurentmt1 has joined #bitcoin-core-dev
211 2017-10-11T11:16:49  *** laurentmt has quit IRC
212 2017-10-11T11:16:49  *** laurentmt1 is now known as laurentmt
213 2017-10-11T11:19:34  *** laurentmt has quit IRC
214 2017-10-11T11:20:06  *** W4RL0RD has joined #bitcoin-core-dev
215 2017-10-11T11:25:02  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11485: [WIP] Add `available` field to listwallets RPC (master...201710_listwallets_available) https://github.com/bitcoin/bitcoin/pull/11485
216 2017-10-11T11:28:31  *** AaronvanW has joined #bitcoin-core-dev
217 2017-10-11T11:30:08  *** promag has quit IRC
218 2017-10-11T11:30:48  *** Aaronvan_ has quit IRC
219 2017-10-11T11:35:08  *** promag has joined #bitcoin-core-dev
220 2017-10-11T11:41:27  *** promag has quit IRC
221 2017-10-11T11:43:21  *** dcousens has joined #bitcoin-core-dev
222 2017-10-11T12:02:06  *** wxss has joined #bitcoin-core-dev
223 2017-10-11T12:02:37  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
224 2017-10-11T12:02:48  *** Cogito_Ergo_Sum has left #bitcoin-core-dev
225 2017-10-11T12:08:00  *** dcousens has quit IRC
226 2017-10-11T12:25:58  <Chris_Stewart_5> Does anyone have an idea why I wouldn't be able to generate a CPubKey from a CKey after calling k.MakeNewKey(true)
227 2017-10-11T12:26:17  <Chris_Stewart_5> the error: test_bitcoin: key.cpp:153: CPubKey CKey::GetPubKey() const: Assertion `ret' failed.
228 2017-10-11T12:26:25  <Chris_Stewart_5> it seems to be failing in secp256k1
229 2017-10-11T12:28:16  *** SopaXorzTaker has joined #bitcoin-core-dev
230 2017-10-11T12:35:02  <Chris_Stewart_5> the line it fails on: https://github.com/bitcoin/bitcoin/blob/f90603ac6d24f5263649675d51233f1fce8b2ecd/src/key.cpp#L153
231 2017-10-11T12:36:15  *** W4RL0RD has quit IRC
232 2017-10-11T12:47:10  *** m8tion01 has quit IRC
233 2017-10-11T12:47:29  *** m8tion has joined #bitcoin-core-dev
234 2017-10-11T12:47:38  *** chjj has joined #bitcoin-core-dev
235 2017-10-11T12:47:48  <wumpus> Chris_Stewart_5: that can only fail if the private key is not in the valid range
236 2017-10-11T12:49:32  *** CadelLeeStormer has joined #bitcoin-core-dev
237 2017-10-11T12:51:35  <Chris_Stewart_5> wumpus: Hmm, is there any reason that calling .MakeNewKey(true) would generate one that is invalid?
238 2017-10-11T12:52:07  <Chris_Stewart_5> because assert(fValid) passes on line 135
239 2017-10-11T12:52:18  <Chris_Stewart_5> line 148*
240 2017-10-11T13:00:53  *** daizisheng has joined #bitcoin-core-dev
241 2017-10-11T13:03:55  *** SopaXorzTaker has quit IRC
242 2017-10-11T13:04:54  *** daizisheng has quit IRC
243 2017-10-11T13:08:24  *** CadelLeeStormer has quit IRC
244 2017-10-11T13:14:44  <wumpus> no, I don't know, it would help to print the generated key I guess
245 2017-10-11T13:16:05  <Chris_Stewart_5> wumpus: wif: KwDiBf89QgGbjEhKnhXJuH7LrciVrZi3qYjgd9M7rFU73Nd2Mcv1
246 2017-10-11T13:18:32  *** promag has joined #bitcoin-core-dev
247 2017-10-11T13:25:01  *** clusk has quit IRC
248 2017-10-11T13:25:07  <arubi> it's 0
249 2017-10-11T13:25:13  *** jannes has joined #bitcoin-core-dev
250 2017-10-11T13:25:14  <arubi> 0000000000000000000000000000000000000000000000000000000000000000 rather
251 2017-10-11T13:25:44  <Chris_Stewart_5> hmmm... so that indicates .MakeNewKey() isn't being called?
252 2017-10-11T13:26:04  <wumpus> indeed, and a private key of zero is not valid, should be at least one
253 2017-10-11T13:26:23  <wumpus> either you must be doing something wrong or there's a bug
254 2017-10-11T13:26:55  *** dabura667 has joined #bitcoin-core-dev
255 2017-10-11T13:27:07  <Chris_Stewart_5> Eh, I'm playing with #8469
256 2017-10-11T13:27:11  <gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
257 2017-10-11T13:27:40  <Chris_Stewart_5> I'm generating various standard tx types (p2pk,p2pkh,multisig) etc and then running them through the interpreter to assert our interpreter/wallet code base are consistent
258 2017-10-11T13:28:02  <Chris_Stewart_5> When I'm generating a std::vector<CKey> this bug appears, but does not appear when I generate a single CKey
259 2017-10-11T13:28:15  <Chris_Stewart_5> arubi: Thanks by the way
260 2017-10-11T13:28:42  <arubi> oh cheers
261 2017-10-11T13:28:43  <wumpus> right, next step would be to figure out why it returns the zero key. I'm happy secp256k1 catches this at least.
262 2017-10-11T13:30:02  *** mmgen has quit IRC
263 2017-10-11T13:30:15  *** mmgen has joined #bitcoin-core-dev
264 2017-10-11T13:30:44  <Chris_Stewart_5> wumpus: Agreed! It is weird because if I try to explicitly call .MakeNewKey(true) (again) before I convert it to a pubkey secp256k1 gives this error
265 2017-10-11T13:31:05  <wumpus> yes I was still in the process of trying to convert that key to raw bytes - a google would have been faster in this case :)
266 2017-10-11T13:31:09  <Chris_Stewart_5> [libsecp256k1] illegal argument: seckey != NULL
267 2017-10-11T13:31:39  <Chris_Stewart_5> perhaps my generator is generating a valid 0 byte key, which is *technically* a valid key right?
268 2017-10-11T13:32:06  <Chris_Stewart_5> and secp256k1 just says 'you really don't want to be doing this...'
269 2017-10-11T13:35:40  <wumpus> not sure about "technically" in this case - I think it's mathemtically undefined
270 2017-10-11T13:35:54  <arubi> it's not a valid key in secp256k1, but it's base58 encoding is valid
271 2017-10-11T13:36:00  <wumpus> right ^^
272 2017-10-11T13:36:01  <arubi> so something generated it..
273 2017-10-11T13:36:57  <wumpus> so are you expecting a random key?
274 2017-10-11T13:40:43  <Chris_Stewart_5> wumpus: Yes... here is the sequence I am using to generate one: https://github.com/Christewart/bitcoin/blob/af2f6f2a639d94945a73e63f9f4203071caad984/src/test/gen/crypto_gen.h#L18
275 2017-10-11T13:40:52  <Chris_Stewart_5> do you see something inherently wrong with it?
276 2017-10-11T13:42:03  *** dabura667 has quit IRC
277 2017-10-11T13:45:05  *** meshcollider has quit IRC
278 2017-10-11T13:45:28  *** Ylbam has quit IRC
279 2017-10-11T13:48:05  *** m8tion01 has joined #bitcoin-core-dev
280 2017-10-11T13:49:21  *** DrOlmer has quit IRC
281 2017-10-11T13:49:48  *** DrOlmer has joined #bitcoin-core-dev
282 2017-10-11T13:50:28  *** m8tion has quit IRC
283 2017-10-11T13:51:58  *** chjj has quit IRC
284 2017-10-11T13:55:04  *** SopaXorzTaker has joined #bitcoin-core-dev
285 2017-10-11T14:00:27  *** Giszmo has joined #bitcoin-core-dev
286 2017-10-11T14:01:50  <jnewbery> meshcollider: sorry - missed the discussion earlier. I think updating listwallets to list available wallets would definitely be a useful feature, but it's by no means necessary for #11466.
287 2017-10-11T14:01:54  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
288 2017-10-11T14:02:50  <jnewbery> promag: Both your alternative schemas in https://github.com/bitcoin/bitcoin/pull/11485#issuecomment-335813034 are fine. I'm not too concerned about the exact format, but I think it's useful for users to be able to access the information somehow
289 2017-10-11T14:04:18  <Chris_Stewart_5> wumpus: For what it is worth it is unrelated to anyting in core. I wasn't capturing a variable correctly in a lambda
290 2017-10-11T14:04:30  <promag> Right, I just think there is no strong use case for that
291 2017-10-11T14:06:09  <promag> I kind of like findwallets because it can return "invalid" wallets where as listwallets is returning valid and loaded wallets
292 2017-10-11T14:07:14  <promag> at the moment listwallet can return available "invalid" wallet that cannot be loaded
293 2017-10-11T14:08:08  <promag> btw, do you think we should have the inverse of -experimentalrpc=?
294 2017-10-11T14:08:46  <promag> so 0.15 introduced listwallets but to use it it should be enabled like so
295 2017-10-11T14:09:46  <promag> sorry, **the inverse of -deprecaterpc**
296 2017-10-11T14:10:23  <promag> therefore all experimental rpc can change
297 2017-10-11T14:11:46  <jnewbery> The use case is being able to find and load wallets dynamically at run-time. If you have any concept feedback on that, the PR is 10740
298 2017-10-11T14:13:19  <jnewbery> re: -experimentalrpc - I don't think that's necessary. Release notes for multiwallet stated 'Note that while multi-wallet is now fully supported, the RPC multi-wallet interface should be considered unstable for version 0.15.0, and there may backwards-incompatible changes in future versions.
299 2017-10-11T14:33:34  <promag> ok and ok
300 2017-10-11T14:58:03  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
301 2017-10-11T15:11:49  *** jb55 has joined #bitcoin-core-dev
302 2017-10-11T15:17:53  *** jb55 has quit IRC
303 2017-10-11T15:27:46  *** wraithm has joined #bitcoin-core-dev
304 2017-10-11T15:28:15  *** wraithm has quit IRC
305 2017-10-11T15:28:41  *** wraithm has joined #bitcoin-core-dev
306 2017-10-11T15:29:05  *** SopaXT has joined #bitcoin-core-dev
307 2017-10-11T15:29:12  *** wraithm has quit IRC
308 2017-10-11T15:29:55  *** wraithm has joined #bitcoin-core-dev
309 2017-10-11T15:30:01  *** SopaXT has quit IRC
310 2017-10-11T15:46:33  *** ananteris has joined #bitcoin-core-dev
311 2017-10-11T15:48:15  *** vicenteH has quit IRC
312 2017-10-11T15:50:37  *** Chris_Stewart_5 has quit IRC
313 2017-10-11T15:56:32  <promag> wumpus: you deleted the comment in #11476?
314 2017-10-11T15:56:34  <gribble> https://github.com/bitcoin/bitcoin/issues/11476 | Avoid opening copied wallet databases simultaneously by ryanofsky · Pull Request #11476 · bitcoin/bitcoin · GitHub
315 2017-10-11T16:08:38  *** m8tion03 has joined #bitcoin-core-dev
316 2017-10-11T16:10:13  *** promag has quit IRC
317 2017-10-11T16:11:12  *** m8tion01 has quit IRC
318 2017-10-11T16:11:48  <wumpus> no?
319 2017-10-11T16:14:31  *** jb55 has joined #bitcoin-core-dev
320 2017-10-11T16:17:57  *** BashCo has quit IRC
321 2017-10-11T16:18:32  *** BashCo has joined #bitcoin-core-dev
322 2017-10-11T16:19:37  <timothy> little-OT: do you think bitcoin gold have enough time to implement replay protection?
323 2017-10-11T16:20:18  <timothy> if no, it may be a big problem for (some) bitcoin users too due to replay attack
324 2017-10-11T16:22:14  <jnewbery> timothy: #bitcoin please. This channel is for discussing Bitcoin Core development
325 2017-10-11T16:22:35  *** BashCo has quit IRC
326 2017-10-11T16:24:10  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/364da2c52942...892809309c1b
327 2017-10-11T16:24:11  <bitcoin-git> bitcoin/master 619bb05 MarcoFalke: Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74...
328 2017-10-11T16:24:11  <bitcoin-git> bitcoin/master faaeeb0 MarcoFalke: Bump univalue and fix json formatting in tests...
329 2017-10-11T16:24:12  <bitcoin-git> bitcoin/master 8928093 Wladimir J. van der Laan: Merge #11420: Bump univalue subtree and fix json formatting in tests...
330 2017-10-11T16:24:39  <wumpus> if you get any linker errors while building master, you probably need to clean your tree after #11420 (it seems that some changes to univalue are not detected by the build system)
331 2017-10-11T16:24:41  <gribble> https://github.com/bitcoin/bitcoin/issues/11420 | Bump univalue subtree and fix json formatting in tests by MarcoFalke · Pull Request #11420 · bitcoin/bitcoin · GitHub
332 2017-10-11T16:24:49  <bitcoin-git> [bitcoin] laanwj closed pull request #11420: Bump univalue subtree and fix json formatting in tests (master...Mf1709-bumpUnivalue) https://github.com/bitcoin/bitcoin/pull/11420
333 2017-10-11T16:30:42  *** alreadylate has quit IRC
334 2017-10-11T16:30:54  <bitcoin-git> [bitcoin] laanwj closed pull request #11445: [qa] 0.15.1 Backports (0.15...Mf1710-0151qaBackports) https://github.com/bitcoin/bitcoin/pull/11445
335 2017-10-11T16:42:28  *** Provoostenator has joined #bitcoin-core-dev
336 2017-10-11T16:42:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
337 2017-10-11T16:50:52  *** Provoostenator has quit IRC
338 2017-10-11T16:57:44  *** Provoostenator has joined #bitcoin-core-dev
339 2017-10-11T16:58:30  *** m8tion has joined #bitcoin-core-dev
340 2017-10-11T16:59:42  <Chris_Stewart_5> Does ProduceSignature have the capability to sign a p2sh(multisig) tx? Here is how I am trying to use it https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569
341 2017-10-11T16:59:58  <Chris_Stewart_5> if not, is there capability for this else where in the code base?
342 2017-10-11T17:00:58  *** m8tion03 has quit IRC
343 2017-10-11T17:04:16  *** Provoostenator has quit IRC
344 2017-10-11T17:04:50  *** BashCo has joined #bitcoin-core-dev
345 2017-10-11T17:05:02  <sipa> Chris_Stewart_5: yes, it does
346 2017-10-11T17:05:23  <sipa> but you need to have the redeemscript in the keystore
347 2017-10-11T17:06:05  <Chris_Stewart_5> I believe I did this https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L14
348 2017-10-11T17:06:09  <Chris_Stewart_5> sipa: ^
349 2017-10-11T17:06:27  <sipa> your redeemscript is just a key?
350 2017-10-11T17:06:49  <sipa> or what is spk_keys
351 2017-10-11T17:06:52  <Chris_Stewart_5> tuple
352 2017-10-11T17:07:01  <Chris_Stewart_5> std::tuple<CScript,std::vector<CKey>>
353 2017-10-11T17:07:11  <sipa> and what's the script?
354 2017-10-11T17:07:46  <Chris_Stewart_5> one of the following: P2PK CScript, P2PKH CScript, Multisig CScript
355 2017-10-11T17:07:53  <Chris_Stewart_5> It is randomly choosing one of those
356 2017-10-11T17:09:03  <Chris_Stewart_5> then creating a p2sh script
357 2017-10-11T17:09:51  *** abpa has joined #bitcoin-core-dev
358 2017-10-11T17:10:04  <sipa> looks right to me
359 2017-10-11T17:10:10  <sipa> what is the problem?
360 2017-10-11T17:10:23  <Chris_Stewart_5> the assert fails on this line -- it should return complete right? https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L20
361 2017-10-11T17:10:33  <Chris_Stewart_5> *theoretically* haha
362 2017-10-11T17:11:32  <sipa> yes
363 2017-10-11T17:12:11  <sipa> i don't see anything obviously wrong
364 2017-10-11T17:12:20  <Chris_Stewart_5> I'll dig more -- it is probably something stupid I am doing else where. I just wanted to confirm produce signature has the capability before I go deeper
365 2017-10-11T17:26:18  *** Aaronvan_ has joined #bitcoin-core-dev
366 2017-10-11T17:26:50  *** m8tion has quit IRC
367 2017-10-11T17:27:14  *** Ylbam has joined #bitcoin-core-dev
368 2017-10-11T17:30:09  *** AaronvanW has quit IRC
369 2017-10-11T17:40:39  *** Emcy has joined #bitcoin-core-dev
370 2017-10-11T17:48:37  *** LeMiner has joined #bitcoin-core-dev
371 2017-10-11T17:53:07  *** abpa has quit IRC
372 2017-10-11T17:54:35  *** jb55 has quit IRC
373 2017-10-11T17:56:33  *** W4RL0RD has joined #bitcoin-core-dev
374 2017-10-11T18:05:12  *** chjj has joined #bitcoin-core-dev
375 2017-10-11T18:08:33  *** vicenteH has joined #bitcoin-core-dev
376 2017-10-11T18:11:01  *** chjj has quit IRC
377 2017-10-11T18:12:12  *** jb55 has joined #bitcoin-core-dev
378 2017-10-11T18:17:03  *** AaronvanW has joined #bitcoin-core-dev
379 2017-10-11T18:20:42  *** Aaronvan_ has quit IRC
380 2017-10-11T18:21:18  *** Aaronvan_ has joined #bitcoin-core-dev
381 2017-10-11T18:21:46  *** W4RL0RD has quit IRC
382 2017-10-11T18:24:31  *** AaronvanW has quit IRC
383 2017-10-11T18:37:39  *** Guyver2 has joined #bitcoin-core-dev
384 2017-10-11T18:40:44  *** promag has joined #bitcoin-core-dev
385 2017-10-11T18:45:07  *** promag has quit IRC
386 2017-10-11T18:55:21  *** AaronvanW has joined #bitcoin-core-dev
387 2017-10-11T18:57:36  *** Aaronvan_ has quit IRC
388 2017-10-11T19:01:25  *** goatpig has quit IRC
389 2017-10-11T19:03:13  *** wxss has quit IRC
390 2017-10-11T19:03:29  *** Emcy_ has joined #bitcoin-core-dev
391 2017-10-11T19:05:21  *** Emcy_ has quit IRC
392 2017-10-11T19:05:38  *** wxss has joined #bitcoin-core-dev
393 2017-10-11T19:06:57  *** Emcy has quit IRC
394 2017-10-11T19:07:04  *** Emcy_ has joined #bitcoin-core-dev
395 2017-10-11T19:07:44  <morcos> I'm just trying to catch up on old review by looking at what was merged..  In #11113 , what is the use case of responding to these strange getheaders requests with no locator at all?  Or at the very least shouldn't we only respond if the hashStop is on our main chain
396 2017-10-11T19:07:46  <gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub
397 2017-10-11T19:08:06  <morcos> Not objection to merging the PR, it seems like a strict improvement, but just trying to understand why that functionality even exists
398 2017-10-11T19:12:56  *** alreadylate has joined #bitcoin-core-dev
399 2017-10-11T19:16:33  *** timothy has quit IRC
400 2017-10-11T19:35:20  *** jannes has quit IRC
401 2017-10-11T19:42:23  *** meshcollider has joined #bitcoin-core-dev
402 2017-10-11T19:49:54  *** qrestlove has quit IRC
403 2017-10-11T19:55:07  *** Emcy_ has quit IRC
404 2017-10-11T19:55:33  *** niko__ has joined #bitcoin-core-dev
405 2017-10-11T19:55:34  *** Emcy_ has joined #bitcoin-core-dev
406 2017-10-11T19:59:04  *** niko__ has quit IRC
407 2017-10-11T20:02:53  <bitcoin-git> [bitcoin] mess110 opened pull request #11486: [tests] Add uacomment tests (master...test_uacomment) https://github.com/bitcoin/bitcoin/pull/11486
408 2017-10-11T20:06:45  *** Cheeseo has joined #bitcoin-core-dev
409 2017-10-11T20:09:48  *** niko__ has joined #bitcoin-core-dev
410 2017-10-11T20:10:59  *** Aaronvan_ has joined #bitcoin-core-dev
411 2017-10-11T20:13:52  *** AaronvanW has quit IRC
412 2017-10-11T20:18:54  *** Emcy_ has quit IRC
413 2017-10-11T20:19:30  *** Emcy has joined #bitcoin-core-dev
414 2017-10-11T20:19:40  *** Emcy has quit IRC
415 2017-10-11T20:19:41  *** Emcy has joined #bitcoin-core-dev
416 2017-10-11T20:33:36  *** qrestlove has joined #bitcoin-core-dev
417 2017-10-11T20:35:40  *** laurentmt has joined #bitcoin-core-dev
418 2017-10-11T20:37:52  *** laurentmt has quit IRC
419 2017-10-11T20:38:10  *** qrestlove has quit IRC
420 2017-10-11T20:51:01  *** qrestlove has joined #bitcoin-core-dev
421 2017-10-11T20:52:21  *** chjj has joined #bitcoin-core-dev
422 2017-10-11T21:02:09  *** AaronvanW has joined #bitcoin-core-dev
423 2017-10-11T21:05:05  *** Aaronvan_ has quit IRC
424 2017-10-11T21:08:07  *** Emcy has quit IRC
425 2017-10-11T21:13:57  *** niko__ has quit IRC
426 2017-10-11T21:18:40  *** qrestlove has quit IRC
427 2017-10-11T21:22:41  *** qrestlove has joined #bitcoin-core-dev
428 2017-10-11T21:26:22  <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11487:  Check that new headers are not a descendant of an invalid block (master...2017-10-acceptblock-validity-check) https://github.com/bitcoin/bitcoin/pull/11487
429 2017-10-11T21:33:47  *** Cogito_Ergo_Sum has quit IRC
430 2017-10-11T21:35:01  *** alreadylate has quit IRC
431 2017-10-11T21:36:09  *** mmgen has quit IRC
432 2017-10-11T21:40:30  *** alreadylate has joined #bitcoin-core-dev
433 2017-10-11T21:46:50  *** dcousens has joined #bitcoin-core-dev
434 2017-10-11T21:49:08  *** DrOlmer has quit IRC
435 2017-10-11T21:49:20  *** dgenr8 has quit IRC
436 2017-10-11T21:49:42  *** Emcy has joined #bitcoin-core-dev
437 2017-10-11T21:49:50  *** DrOlmer has joined #bitcoin-core-dev
438 2017-10-11T21:50:21  *** dgenr8 has joined #bitcoin-core-dev
439 2017-10-11T21:50:38  *** Guyver2 has quit IRC
440 2017-10-11T21:59:13  *** Cheeseo has quit IRC
441 2017-10-11T22:00:58  *** Chris_Stewart_5 has quit IRC
442 2017-10-11T22:14:04  *** cheese_ has joined #bitcoin-core-dev
443 2017-10-11T22:17:25  *** abpa has joined #bitcoin-core-dev
444 2017-10-11T22:25:32  *** qrestlove has quit IRC
445 2017-10-11T22:26:12  *** alreadylate has quit IRC
446 2017-10-11T22:35:50  *** harrymm has quit IRC
447 2017-10-11T22:36:45  *** harrymm has joined #bitcoin-core-dev
448 2017-10-11T22:38:59  *** qrestlove has joined #bitcoin-core-dev
449 2017-10-11T22:47:03  *** RoyceX has joined #bitcoin-core-dev
450 2017-10-11T22:49:41  *** cheese_ has quit IRC
451 2017-10-11T23:10:40  *** AaronvanW has quit IRC
452 2017-10-11T23:18:26  *** RoyceX has quit IRC
453 2017-10-11T23:29:37  *** dgenr8 has quit IRC
454 2017-10-11T23:50:57  *** dermoth has joined #bitcoin-core-dev
455 2017-10-11T23:57:14  *** wraithm has quit IRC
456 2017-10-11T23:57:26  *** abpa has quit IRC
457 2017-10-11T23:57:27  <bitcoin-git> [bitcoin] C0deAi opened pull request #11488: Codeai fixes: remove dead code, prevent possible division by zero. (master...codeai-fixes) https://github.com/bitcoin/bitcoin/pull/11488
458 2017-10-11T23:58:55  *** dcousens has quit IRC