12017-10-11T00:09:40 *** owowo has quit IRC
22017-10-11T00:10:34 *** jb55 has quit IRC
32017-10-11T00:11:52 *** VIctorsueca has quit IRC
42017-10-11T00:14:11 *** Victorsueca has joined #bitcoin-core-dev
52017-10-11T00:15:55 *** owowo has joined #bitcoin-core-dev
62017-10-11T00:17:40 *** ProfMac has quit IRC
72017-10-11T00:24:07 *** AaronvanW has quit IRC
82017-10-11T00:28:38 *** Victorsueca has quit IRC
92017-10-11T00:29:47 *** Victorsueca has joined #bitcoin-core-dev
102017-10-11T00:33:05 *** Emcy_ has joined #bitcoin-core-dev
112017-10-11T00:35:48 *** Emcy has quit IRC
122017-10-11T00:43:01 *** jannes has quit IRC
132017-10-11T01:00:21 *** dabura667 has joined #bitcoin-core-dev
142017-10-11T01:04:35 *** dabura667 has quit IRC
152017-10-11T01:05:48 *** dabura667 has joined #bitcoin-core-dev
162017-10-11T01:16:25 *** wxss has quit IRC
172017-10-11T01:26:04 *** jb55 has joined #bitcoin-core-dev
182017-10-11T01:36:26 *** ProfMac has joined #bitcoin-core-dev
192017-10-11T02:01:41 *** sager has joined #bitcoin-core-dev
202017-10-11T02:21:35 *** kayamm has quit IRC
212017-10-11T02:24:13 *** kayamm has joined #bitcoin-core-dev
222017-10-11T02:24:14 *** kayamm has joined #bitcoin-core-dev
232017-10-11T02:25:41 *** merehap__ has quit IRC
242017-10-11T02:25:50 *** merehap__ has joined #bitcoin-core-dev
252017-10-11T02:27:19 *** merehap_ has joined #bitcoin-core-dev
262017-10-11T02:27:19 *** merehap__ has quit IRC
272017-10-11T02:30:04 *** merehap_ has quit IRC
282017-10-11T02:30:17 *** merehap_ has joined #bitcoin-core-dev
292017-10-11T02:32:38 <bitcoin-git> [bitcoin] PierreRochard opened pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478
302017-10-11T02:35:09 <bitcoin-git> [bitcoin] PierreRochard closed pull request #11478: ODB Integration (master...odb) https://github.com/bitcoin/bitcoin/pull/11478
312017-10-11T02:35:09 *** rty has joined #bitcoin-core-dev
322017-10-11T02:42:22 *** sager has quit IRC
332017-10-11T02:43:48 *** bbt has joined #bitcoin-core-dev
342017-10-11T02:44:11 *** bbt is now known as Guest34123
352017-10-11T02:45:29 *** Guest34123 has quit IRC
362017-10-11T02:51:28 <bitcoin-git> [bitcoin] kswapd opened pull request #11479: [Docs] Update README.md to add Freenode links (master...master) https://github.com/bitcoin/bitcoin/pull/11479
372017-10-11T02:53:58 *** rty has quit IRC
382017-10-11T03:02:30 *** harding has quit IRC
392017-10-11T04:03:22 *** goatpig has joined #bitcoin-core-dev
402017-10-11T04:15:08 *** arubi has quit IRC
412017-10-11T04:20:26 *** arubi has joined #bitcoin-core-dev
422017-10-11T04:37:51 *** chjj has quit IRC
432017-10-11T05:02:08 <bitcoin-git> [bitcoin] tjps opened pull request #11480: [ui] Add toggle for unblinding password fields (master...tjps_wallet_dialog) https://github.com/bitcoin/bitcoin/pull/11480
442017-10-11T05:48:49 *** DrOlmer has quit IRC
452017-10-11T05:49:18 *** DrOlmer has joined #bitcoin-core-dev
462017-10-11T05:58:25 *** ananteris has quit IRC
472017-10-11T06:16:19 *** Giszmo has quit IRC
482017-10-11T06:23:23 *** finapteka has joined #bitcoin-core-dev
492017-10-11T06:24:26 *** finapteka has quit IRC
502017-10-11T06:34:09 *** PatBoy has quit IRC
512017-10-11T06:35:53 *** PatBoy has joined #bitcoin-core-dev
522017-10-11T06:37:48 *** dcousens has quit IRC
532017-10-11T06:50:13 *** BashCo has quit IRC
542017-10-11T06:57:40 *** promag has joined #bitcoin-core-dev
552017-10-11T07:05:59 *** promag has quit IRC
562017-10-11T07:08:49 *** BashCo has joined #bitcoin-core-dev
572017-10-11T07:17:21 *** jb55 has quit IRC
582017-10-11T07:23:44 *** timothy has joined #bitcoin-core-dev
592017-10-11T07:25:32 *** Guyver2 has joined #bitcoin-core-dev
602017-10-11T07:40:05 *** laurentmt has joined #bitcoin-core-dev
612017-10-11T07:41:54 *** Cheeseo has quit IRC
622017-10-11T08:03:13 *** JackH has quit IRC
632017-10-11T08:12:06 <bitcoin-git> [bitcoin] AmirAbrams opened pull request #11482: Use CPrivKey typedef for keydata in CKey (master...patch-3) https://github.com/bitcoin/bitcoin/pull/11482
642017-10-11T08:18:18 *** Guyver2 has quit IRC
652017-10-11T08:21:21 *** rafalcpp has quit IRC
662017-10-11T08:21:40 *** promag has joined #bitcoin-core-dev
672017-10-11T08:44:09 *** drizztbsd has joined #bitcoin-core-dev
682017-10-11T08:44:57 *** timothy has quit IRC
692017-10-11T08:45:54 <bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5a9da37fb3f4...0e3a41135157
702017-10-11T08:45:55 <bitcoin-git> bitcoin/master 3f0ee3e Jorge Timón: Proper indentation for CheckTxInputs and other minor fixes
712017-10-11T08:45:55 <bitcoin-git> bitcoin/master 832e074 Jorge Timón: Optimization: Minimize the number of times it is checked that no money is created...
722017-10-11T08:45:56 <bitcoin-git> bitcoin/master 3e8c916 Jorge Timón: Introduce CheckInputsAndUpdateCoins static wrapper in txmempool.cpp
732017-10-11T08:46:39 *** vicenteH has joined #bitcoin-core-dev
742017-10-11T08:48:03 *** alreadylate has joined #bitcoin-core-dev
752017-10-11T08:48:32 *** rafalcpp has joined #bitcoin-core-dev
762017-10-11T08:53:14 *** Ylbam has joined #bitcoin-core-dev
772017-10-11T08:53:29 <wumpus> meshcollider: listing 'available' wallets would be a lot easier with the walletdir
782017-10-11T08:54:35 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0e3a41135157...fef65c4f5e59
792017-10-11T08:54:36 <bitcoin-git> bitcoin/master a2be3b6 Jim Posen: [net] Ignore getheaders requests for very old side blocks...
802017-10-11T08:54:36 <bitcoin-git> bitcoin/master eff4bd8 Jim Posen: [test] P2P functional test for certain fingerprinting protections
812017-10-11T08:54:37 <bitcoin-git> bitcoin/master fef65c4 Wladimir J. van der Laan: Merge #11113: [net] Ignore getheaders requests for very old side blocks...
822017-10-11T08:55:13 <bitcoin-git> [bitcoin] laanwj closed pull request #11113: [net] Ignore getheaders requests for very old side blocks (master...net-getheaders-fingerprint) https://github.com/bitcoin/bitcoin/pull/11113
832017-10-11T08:56:32 <meshcollider> wumpus: yes indeed, I'm just wondering whether there is any point in adding a list of `available` wallets inside the walletdir to the `listwallets` RPC
842017-10-11T08:56:48 <promag> wumpus what is the real use case for that?
852017-10-11T08:57:07 <wumpus> promag: for listing available wallets? would be nice in the GUI at least
862017-10-11T08:57:23 <wumpus> otherwise peopel have to remember the names
872017-10-11T08:57:45 <wumpus> which is okay for the first version or whatever, but in the long run would be nice to select from a list instead
882017-10-11T08:57:54 <wumpus> there's no urgency in having it though
892017-10-11T08:57:57 <promag> But the app is configured with the wallets, and there is no way to create wallets
902017-10-11T08:58:00 <meshcollider> because the only clean-ish way I can think of to find wallets in the walletdir is looking for .dat extensions right?
912017-10-11T08:58:28 <meshcollider> promag dynamic loading/unloading of wallets will be coming soon right?
922017-10-11T08:58:29 <wumpus> check for berkeleydb databases
932017-10-11T08:59:06 <wumpus> (requiring .dat naming is fine with me too, but not all .dats are bdb databases unfortuantely)
942017-10-11T08:59:12 <promag> I feel that's not the right path
952017-10-11T08:59:19 <promag> not all berkeleydb files are wallets
962017-10-11T08:59:30 <wumpus> in the wallet directory they can be assumed to be
972017-10-11T08:59:41 <wumpus> but if you want to add an additional check on loading, fine
982017-10-11T08:59:48 <wumpus> there's some keys that are only in wallets...
992017-10-11T08:59:52 <wumpus> (like the wallet version)
1002017-10-11T09:00:37 <wumpus> I'm more afraid of users copying valid wallets from other forks though :(
1012017-10-11T09:01:01 <wumpus> so if we want to add more robustness to wallet loading, yeah, we'd have to consider that...
1022017-10-11T09:01:08 <meshcollider> The easiest way to check if a file is a bdb file is with magic bytes like ryanofsky suggested here? https://github.com/bitcoin/bitcoin/pull/11466#discussion_r143730935
1032017-10-11T09:01:13 <wumpus> meshcollider: yes
1042017-10-11T09:01:34 *** Emcy has joined #bitcoin-core-dev
1052017-10-11T09:01:42 <wumpus> certainly that's the way to do it without getting berkeleydb involved
1062017-10-11T09:01:49 <meshcollider> I think I'll take that commit out of my current PR and make a new one
1072017-10-11T09:01:54 <meshcollider> this will be too much to discuss
1082017-10-11T09:01:58 <wumpus> but why do you need this now?
1092017-10-11T09:02:29 <meshcollider> I was going to do the `listwallets` change as part of #11466
1102017-10-11T09:02:30 <wumpus> I think we need listing available wallets yet, yes lease separate that out
1112017-10-11T09:02:31 <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | [WIP] Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
1122017-10-11T09:02:41 <meshcollider> yep ð
1132017-10-11T09:02:51 <promag> I would open the wallet, keep it open, but not load the transactions
1142017-10-11T09:03:22 <wumpus> I mean I *don't* think we need listing available wallets yet
1152017-10-11T09:03:50 <promag> listwallets change in a different PR will make your PR faster to review and merge meshcollider
1162017-10-11T09:03:54 <wumpus> we need to enforce some naming convention on wallets in that case (we don't even require .dat at the moment) as well as make sure wallets are somehow tagged as bitcoin wallet
1172017-10-11T09:04:04 <wumpus> e.g. by having a key in them that identifies them as being such
1182017-10-11T09:04:09 <promag> *.wlt :troll:
1192017-10-11T09:04:43 *** Emcy_ has quit IRC
1202017-10-11T09:05:03 <meshcollider> Yep its more complicated than i initially thought, seperating it out now
1212017-10-11T09:05:05 *** laurentmt has quit IRC
1222017-10-11T09:05:10 <wumpus> promag: if you want to go that way it's better to go full out and use .bitcoinwallet - to rule out overlap with forks etc
1232017-10-11T09:05:29 <wumpus> and altcoins
1242017-10-11T09:06:02 <wumpus> this is a discussion topic when the wallet format is changed
1252017-10-11T09:06:16 <promag> I was kidding :P but maybe .bitcoin-core-wallet
1262017-10-11T09:06:17 <wumpus> from berkeleydb to something custom, for example
1272017-10-11T09:06:39 <wumpus> we certainly don't want to stick with .dat then
1282017-10-11T09:07:40 <promag> well, I think a good implementation will open the whatever-file-is and use/validate the content
1292017-10-11T09:08:26 <wumpus> I'm all for being more robust when actually opening wallets
1302017-10-11T09:08:34 <wumpus> but when scanning for available wallets please don't get bdb involved
1312017-10-11T09:09:01 <wumpus> if you need to look at magics etc, a quick read-only scan should be enough
1322017-10-11T09:09:03 <promag> listing an available but invalid wallet is stupid?
1332017-10-11T09:09:11 <wumpus> but rare!
1342017-10-11T09:09:18 <promag> ok then
1352017-10-11T09:09:20 <wumpus> opening with berkeleydb is heavy
1362017-10-11T09:09:35 <promag> why? does it load everything?
1372017-10-11T09:09:36 <wumpus> also involves potential writing, you don't want the program to write to files it's not told to touch
1382017-10-11T09:09:38 <wumpus> yes
1392017-10-11T09:09:45 <wumpus> it does various things
1402017-10-11T09:09:46 <promag> ok, I rest
1412017-10-11T09:10:25 <meshcollider> hah i dont think i can checkout a new branch while building the current one
1422017-10-11T09:10:32 <meshcollider> ill have to use my tablet instead
1432017-10-11T09:10:45 <wumpus> meshcollider: you can use git worktrees
1442017-10-11T09:11:03 <wumpus> and check out different branches in different directories
1452017-10-11T09:11:16 <meshcollider> ooh really? That's cool, I've never even heard of that being possible before
1462017-10-11T09:11:21 <meshcollider> I'll look it up
1472017-10-11T09:11:21 <wumpus> it's awesome, especially with large projects like linux where you really don't want to have multiple full clones
1482017-10-11T09:11:30 <meshcollider> Yeah :D
1492017-10-11T09:15:13 <promag> yes, thank god sipa introduced that to me a couple of months ago
1502017-10-11T09:18:57 <promag> wumpus: easy one #10941, just improves test suite
1512017-10-11T09:18:59 <wumpus> it also helps for some things to do out-of-tree builds, though mostly to keep you git tree clean, and be able to build for different architectures from one source tree - it doesn't allow you to switch the branch while building
1522017-10-11T09:19:00 <gribble> https://github.com/bitcoin/bitcoin/issues/10941 | Add blocknotify and walletnotify functional tests by promag · Pull Request #10941 · bitcoin/bitcoin · GitHub
1532017-10-11T09:20:31 <promag> I think it's time give #11006 a chance?
1542017-10-11T09:20:32 <gribble> https://github.com/bitcoin/bitcoin/issues/11006 | Improve shutdown process by promag · Pull Request #11006 · bitcoin/bitcoin · GitHub
1552017-10-11T09:23:23 *** oakley91 has joined #bitcoin-core-dev
1562017-10-11T09:26:15 *** promag has quit IRC
1572017-10-11T09:26:45 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/fef65c4f5e59...364da2c52942
1582017-10-11T09:26:46 <bitcoin-git> bitcoin/master 9c72a46 John Newbery: [tests] Tidy up forknotify.py
1592017-10-11T09:26:46 <bitcoin-git> bitcoin/master df18d29 João Barbosa: [tests] Add -blocknotify functional test
1602017-10-11T09:26:47 <bitcoin-git> bitcoin/master 857b32b João Barbosa: [tests] Add -walletnotify functional test
1612017-10-11T09:27:11 <bitcoin-git> [bitcoin] laanwj closed pull request #10941: Add blocknotify and walletnotify functional tests (master...2017-07-blocknotify-functional-test) https://github.com/bitcoin/bitcoin/pull/10941
1622017-10-11T09:29:12 *** anusorns has joined #bitcoin-core-dev
1632017-10-11T09:31:25 *** AaronvanW has joined #bitcoin-core-dev
1642017-10-11T09:32:02 *** anusorns has quit IRC
1652017-10-11T09:32:59 *** promag has joined #bitcoin-core-dev
1662017-10-11T09:33:25 *** Aaronvan_ has joined #bitcoin-core-dev
1672017-10-11T09:33:57 *** promag has quit IRC
1682017-10-11T09:36:24 *** promag_ has joined #bitcoin-core-dev
1692017-10-11T09:36:57 *** AaronvanW has quit IRC
1702017-10-11T09:40:06 <promag_> wumpus: regarding the eye icon, are there designers contributing? or are the used icons open source?
1712017-10-11T09:41:22 <wumpus> what's wrong with the eye icon we alread have?
1722017-10-11T09:42:39 <wumpus> (I edited th4e post)
1732017-10-11T09:45:44 <promag_> oh there is an eye icon already
1742017-10-11T09:45:58 <wumpus> if you want a new icon you'd have to find an icon that has the correct license (ideally MIT or public design) or an artist that wants to create such an icon under the appropriate license
1752017-10-11T09:46:08 <wumpus> jonasschnelli designed most of the current ones
1762017-10-11T09:46:30 <promag_> this eye? src/qt/res/icons/eye.png
1772017-10-11T09:46:33 <wumpus> yes :)
1782017-10-11T09:46:51 <promag_> ok, lgtm
1792017-10-11T09:47:51 <wumpus> s/public design/public domain
1802017-10-11T09:48:42 *** AaronvanW has joined #bitcoin-core-dev
1812017-10-11T09:51:33 *** Aaronvan_ has quit IRC
1822017-10-11T09:52:07 *** promag_ has quit IRC
1832017-10-11T09:58:32 *** Aaronvan_ has joined #bitcoin-core-dev
1842017-10-11T09:59:41 *** AaronvanW has quit IRC
1852017-10-11T10:02:53 *** laurentmt has joined #bitcoin-core-dev
1862017-10-11T10:11:05 *** dabura667 has quit IRC
1872017-10-11T10:12:33 <bitcoin-git> [bitcoin] laanwj closed pull request #11479: [Docs] Update README.md to add Freenode links (master...master) https://github.com/bitcoin/bitcoin/pull/11479
1882017-10-11T10:20:16 <bitcoin-git> [bitcoin] pedrobranco opened pull request #11483: Fix importmulti bug when importing an already imported key (master...bugfix/fix-importmulti-bug) https://github.com/bitcoin/bitcoin/pull/11483
1892017-10-11T10:28:59 *** moctos has joined #bitcoin-core-dev
1902017-10-11T10:29:47 *** niska has quit IRC
1912017-10-11T10:34:33 *** niska has joined #bitcoin-core-dev
1922017-10-11T10:35:11 <bitcoin-git> [bitcoin] pedrobranco opened pull request #11484: Optional update rescan option in importmulti RPC (master...enhancement/optional-update-rescan-on-importmulti) https://github.com/bitcoin/bitcoin/pull/11484
1932017-10-11T10:41:27 *** mmgen has joined #bitcoin-core-dev
1942017-10-11T10:44:37 *** m8tion has joined #bitcoin-core-dev
1952017-10-11T10:48:07 *** cluskinator has joined #bitcoin-core-dev
1962017-10-11T10:48:47 *** cluskinator is now known as clusk
1972017-10-11T10:51:38 *** m8tion01 has joined #bitcoin-core-dev
1982017-10-11T10:52:42 *** promag has joined #bitcoin-core-dev
1992017-10-11T10:54:01 *** m8tion has quit IRC
2002017-10-11T10:54:01 *** Emcy has quit IRC
2012017-10-11T10:55:16 *** Chris_Stewart_5 has joined #bitcoin-core-dev
2022017-10-11T10:56:32 *** timothy has joined #bitcoin-core-dev
2032017-10-11T10:57:01 *** drizztbsd has quit IRC
2042017-10-11T11:02:33 *** pindarhk_ has quit IRC
2052017-10-11T11:03:21 *** pindarhk_ has joined #bitcoin-core-dev
2062017-10-11T11:06:15 *** AaronvanW has joined #bitcoin-core-dev
2072017-10-11T11:09:21 *** Aaronvan_ has quit IRC
2082017-10-11T11:10:41 *** Aaronvan_ has joined #bitcoin-core-dev
2092017-10-11T11:13:52 *** AaronvanW has quit IRC
2102017-10-11T11:14:39 *** laurentmt1 has joined #bitcoin-core-dev
2112017-10-11T11:16:49 *** laurentmt has quit IRC
2122017-10-11T11:16:49 *** laurentmt1 is now known as laurentmt
2132017-10-11T11:19:34 *** laurentmt has quit IRC
2142017-10-11T11:20:06 *** W4RL0RD has joined #bitcoin-core-dev
2152017-10-11T11:25:02 <bitcoin-git> [bitcoin] MeshCollider opened pull request #11485: [WIP] Add `available` field to listwallets RPC (master...201710_listwallets_available) https://github.com/bitcoin/bitcoin/pull/11485
2162017-10-11T11:28:31 *** AaronvanW has joined #bitcoin-core-dev
2172017-10-11T11:30:08 *** promag has quit IRC
2182017-10-11T11:30:48 *** Aaronvan_ has quit IRC
2192017-10-11T11:35:08 *** promag has joined #bitcoin-core-dev
2202017-10-11T11:41:27 *** promag has quit IRC
2212017-10-11T11:43:21 *** dcousens has joined #bitcoin-core-dev
2222017-10-11T12:02:06 *** wxss has joined #bitcoin-core-dev
2232017-10-11T12:02:37 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
2242017-10-11T12:02:48 *** Cogito_Ergo_Sum has left #bitcoin-core-dev
2252017-10-11T12:08:00 *** dcousens has quit IRC
2262017-10-11T12:25:58 <Chris_Stewart_5> Does anyone have an idea why I wouldn't be able to generate a CPubKey from a CKey after calling k.MakeNewKey(true)
2272017-10-11T12:26:17 <Chris_Stewart_5> the error: test_bitcoin: key.cpp:153: CPubKey CKey::GetPubKey() const: Assertion `ret' failed.
2282017-10-11T12:26:25 <Chris_Stewart_5> it seems to be failing in secp256k1
2292017-10-11T12:28:16 *** SopaXorzTaker has joined #bitcoin-core-dev
2302017-10-11T12:35:02 <Chris_Stewart_5> the line it fails on: https://github.com/bitcoin/bitcoin/blob/f90603ac6d24f5263649675d51233f1fce8b2ecd/src/key.cpp#L153
2312017-10-11T12:36:15 *** W4RL0RD has quit IRC
2322017-10-11T12:47:10 *** m8tion01 has quit IRC
2332017-10-11T12:47:29 *** m8tion has joined #bitcoin-core-dev
2342017-10-11T12:47:38 *** chjj has joined #bitcoin-core-dev
2352017-10-11T12:47:48 <wumpus> Chris_Stewart_5: that can only fail if the private key is not in the valid range
2362017-10-11T12:49:32 *** CadelLeeStormer has joined #bitcoin-core-dev
2372017-10-11T12:51:35 <Chris_Stewart_5> wumpus: Hmm, is there any reason that calling .MakeNewKey(true) would generate one that is invalid?
2382017-10-11T12:52:07 <Chris_Stewart_5> because assert(fValid) passes on line 135
2392017-10-11T12:52:18 <Chris_Stewart_5> line 148*
2402017-10-11T13:00:53 *** daizisheng has joined #bitcoin-core-dev
2412017-10-11T13:03:55 *** SopaXorzTaker has quit IRC
2422017-10-11T13:04:54 *** daizisheng has quit IRC
2432017-10-11T13:08:24 *** CadelLeeStormer has quit IRC
2442017-10-11T13:14:44 <wumpus> no, I don't know, it would help to print the generated key I guess
2452017-10-11T13:16:05 <Chris_Stewart_5> wumpus: wif: KwDiBf89QgGbjEhKnhXJuH7LrciVrZi3qYjgd9M7rFU73Nd2Mcv1
2462017-10-11T13:18:32 *** promag has joined #bitcoin-core-dev
2472017-10-11T13:25:01 *** clusk has quit IRC
2482017-10-11T13:25:07 <arubi> it's 0
2492017-10-11T13:25:13 *** jannes has joined #bitcoin-core-dev
2502017-10-11T13:25:14 <arubi> 0000000000000000000000000000000000000000000000000000000000000000 rather
2512017-10-11T13:25:44 <Chris_Stewart_5> hmmm... so that indicates .MakeNewKey() isn't being called?
2522017-10-11T13:26:04 <wumpus> indeed, and a private key of zero is not valid, should be at least one
2532017-10-11T13:26:23 <wumpus> either you must be doing something wrong or there's a bug
2542017-10-11T13:26:55 *** dabura667 has joined #bitcoin-core-dev
2552017-10-11T13:27:07 <Chris_Stewart_5> Eh, I'm playing with #8469
2562017-10-11T13:27:11 <gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
2572017-10-11T13:27:40 <Chris_Stewart_5> I'm generating various standard tx types (p2pk,p2pkh,multisig) etc and then running them through the interpreter to assert our interpreter/wallet code base are consistent
2582017-10-11T13:28:02 <Chris_Stewart_5> When I'm generating a std::vector<CKey> this bug appears, but does not appear when I generate a single CKey
2592017-10-11T13:28:15 <Chris_Stewart_5> arubi: Thanks by the way
2602017-10-11T13:28:42 <arubi> oh cheers
2612017-10-11T13:28:43 <wumpus> right, next step would be to figure out why it returns the zero key. I'm happy secp256k1 catches this at least.
2622017-10-11T13:30:02 *** mmgen has quit IRC
2632017-10-11T13:30:15 *** mmgen has joined #bitcoin-core-dev
2642017-10-11T13:30:44 <Chris_Stewart_5> wumpus: Agreed! It is weird because if I try to explicitly call .MakeNewKey(true) (again) before I convert it to a pubkey secp256k1 gives this error
2652017-10-11T13:31:05 <wumpus> yes I was still in the process of trying to convert that key to raw bytes - a google would have been faster in this case :)
2662017-10-11T13:31:09 <Chris_Stewart_5> [libsecp256k1] illegal argument: seckey != NULL
2672017-10-11T13:31:39 <Chris_Stewart_5> perhaps my generator is generating a valid 0 byte key, which is *technically* a valid key right?
2682017-10-11T13:32:06 <Chris_Stewart_5> and secp256k1 just says 'you really don't want to be doing this...'
2692017-10-11T13:35:40 <wumpus> not sure about "technically" in this case - I think it's mathemtically undefined
2702017-10-11T13:35:54 <arubi> it's not a valid key in secp256k1, but it's base58 encoding is valid
2712017-10-11T13:36:00 <wumpus> right ^^
2722017-10-11T13:36:01 <arubi> so something generated it..
2732017-10-11T13:36:57 <wumpus> so are you expecting a random key?
2742017-10-11T13:40:43 <Chris_Stewart_5> wumpus: Yes... here is the sequence I am using to generate one: https://github.com/Christewart/bitcoin/blob/af2f6f2a639d94945a73e63f9f4203071caad984/src/test/gen/crypto_gen.h#L18
2752017-10-11T13:40:52 <Chris_Stewart_5> do you see something inherently wrong with it?
2762017-10-11T13:42:03 *** dabura667 has quit IRC
2772017-10-11T13:45:05 *** meshcollider has quit IRC
2782017-10-11T13:45:28 *** Ylbam has quit IRC
2792017-10-11T13:48:05 *** m8tion01 has joined #bitcoin-core-dev
2802017-10-11T13:49:21 *** DrOlmer has quit IRC
2812017-10-11T13:49:48 *** DrOlmer has joined #bitcoin-core-dev
2822017-10-11T13:50:28 *** m8tion has quit IRC
2832017-10-11T13:51:58 *** chjj has quit IRC
2842017-10-11T13:55:04 *** SopaXorzTaker has joined #bitcoin-core-dev
2852017-10-11T14:00:27 *** Giszmo has joined #bitcoin-core-dev
2862017-10-11T14:01:50 <jnewbery> meshcollider: sorry - missed the discussion earlier. I think updating listwallets to list available wallets would definitely be a useful feature, but it's by no means necessary for #11466.
2872017-10-11T14:01:54 <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
2882017-10-11T14:02:50 <jnewbery> promag: Both your alternative schemas in https://github.com/bitcoin/bitcoin/pull/11485#issuecomment-335813034 are fine. I'm not too concerned about the exact format, but I think it's useful for users to be able to access the information somehow
2892017-10-11T14:04:18 <Chris_Stewart_5> wumpus: For what it is worth it is unrelated to anyting in core. I wasn't capturing a variable correctly in a lambda
2902017-10-11T14:04:30 <promag> Right, I just think there is no strong use case for that
2912017-10-11T14:06:09 <promag> I kind of like findwallets because it can return "invalid" wallets where as listwallets is returning valid and loaded wallets
2922017-10-11T14:07:14 <promag> at the moment listwallet can return available "invalid" wallet that cannot be loaded
2932017-10-11T14:08:08 <promag> btw, do you think we should have the inverse of -experimentalrpc=?
2942017-10-11T14:08:46 <promag> so 0.15 introduced listwallets but to use it it should be enabled like so
2952017-10-11T14:09:46 <promag> sorry, **the inverse of -deprecaterpc**
2962017-10-11T14:10:23 <promag> therefore all experimental rpc can change
2972017-10-11T14:11:46 <jnewbery> The use case is being able to find and load wallets dynamically at run-time. If you have any concept feedback on that, the PR is 10740
2982017-10-11T14:13:19 <jnewbery> re: -experimentalrpc - I don't think that's necessary. Release notes for multiwallet stated 'Note that while multi-wallet is now fully supported, the RPC multi-wallet interface should be considered unstable for version 0.15.0, and there may backwards-incompatible changes in future versions.
2992017-10-11T14:33:34 <promag> ok and ok
3002017-10-11T14:58:03 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
3012017-10-11T15:11:49 *** jb55 has joined #bitcoin-core-dev
3022017-10-11T15:17:53 *** jb55 has quit IRC
3032017-10-11T15:27:46 *** wraithm has joined #bitcoin-core-dev
3042017-10-11T15:28:15 *** wraithm has quit IRC
3052017-10-11T15:28:41 *** wraithm has joined #bitcoin-core-dev
3062017-10-11T15:29:05 *** SopaXT has joined #bitcoin-core-dev
3072017-10-11T15:29:12 *** wraithm has quit IRC
3082017-10-11T15:29:55 *** wraithm has joined #bitcoin-core-dev
3092017-10-11T15:30:01 *** SopaXT has quit IRC
3102017-10-11T15:46:33 *** ananteris has joined #bitcoin-core-dev
3112017-10-11T15:48:15 *** vicenteH has quit IRC
3122017-10-11T15:50:37 *** Chris_Stewart_5 has quit IRC
3132017-10-11T15:56:32 <promag> wumpus: you deleted the comment in #11476?
3142017-10-11T15:56:34 <gribble> https://github.com/bitcoin/bitcoin/issues/11476 | Avoid opening copied wallet databases simultaneously by ryanofsky · Pull Request #11476 · bitcoin/bitcoin · GitHub
3152017-10-11T16:08:38 *** m8tion03 has joined #bitcoin-core-dev
3162017-10-11T16:10:13 *** promag has quit IRC
3172017-10-11T16:11:12 *** m8tion01 has quit IRC
3182017-10-11T16:11:48 <wumpus> no?
3192017-10-11T16:14:31 *** jb55 has joined #bitcoin-core-dev
3202017-10-11T16:17:57 *** BashCo has quit IRC
3212017-10-11T16:18:32 *** BashCo has joined #bitcoin-core-dev
3222017-10-11T16:19:37 <timothy> little-OT: do you think bitcoin gold have enough time to implement replay protection?
3232017-10-11T16:20:18 <timothy> if no, it may be a big problem for (some) bitcoin users too due to replay attack
3242017-10-11T16:22:14 <jnewbery> timothy: #bitcoin please. This channel is for discussing Bitcoin Core development
3252017-10-11T16:22:35 *** BashCo has quit IRC
3262017-10-11T16:24:10 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/364da2c52942...892809309c1b
3272017-10-11T16:24:11 <bitcoin-git> bitcoin/master 619bb05 MarcoFalke: Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74...
3282017-10-11T16:24:11 <bitcoin-git> bitcoin/master faaeeb0 MarcoFalke: Bump univalue and fix json formatting in tests...
3292017-10-11T16:24:12 <bitcoin-git> bitcoin/master 8928093 Wladimir J. van der Laan: Merge #11420: Bump univalue subtree and fix json formatting in tests...
3302017-10-11T16:24:39 <wumpus> if you get any linker errors while building master, you probably need to clean your tree after #11420 (it seems that some changes to univalue are not detected by the build system)
3312017-10-11T16:24:41 <gribble> https://github.com/bitcoin/bitcoin/issues/11420 | Bump univalue subtree and fix json formatting in tests by MarcoFalke · Pull Request #11420 · bitcoin/bitcoin · GitHub
3322017-10-11T16:24:49 <bitcoin-git> [bitcoin] laanwj closed pull request #11420: Bump univalue subtree and fix json formatting in tests (master...Mf1709-bumpUnivalue) https://github.com/bitcoin/bitcoin/pull/11420
3332017-10-11T16:30:42 *** alreadylate has quit IRC
3342017-10-11T16:30:54 <bitcoin-git> [bitcoin] laanwj closed pull request #11445: [qa] 0.15.1 Backports (0.15...Mf1710-0151qaBackports) https://github.com/bitcoin/bitcoin/pull/11445
3352017-10-11T16:42:28 *** Provoostenator has joined #bitcoin-core-dev
3362017-10-11T16:42:38 *** Chris_Stewart_5 has joined #bitcoin-core-dev
3372017-10-11T16:50:52 *** Provoostenator has quit IRC
3382017-10-11T16:57:44 *** Provoostenator has joined #bitcoin-core-dev
3392017-10-11T16:58:30 *** m8tion has joined #bitcoin-core-dev
3402017-10-11T16:59:42 <Chris_Stewart_5> Does ProduceSignature have the capability to sign a p2sh(multisig) tx? Here is how I am trying to use it https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569
3412017-10-11T16:59:58 <Chris_Stewart_5> if not, is there capability for this else where in the code base?
3422017-10-11T17:00:58 *** m8tion03 has quit IRC
3432017-10-11T17:04:16 *** Provoostenator has quit IRC
3442017-10-11T17:04:50 *** BashCo has joined #bitcoin-core-dev
3452017-10-11T17:05:02 <sipa> Chris_Stewart_5: yes, it does
3462017-10-11T17:05:23 <sipa> but you need to have the redeemscript in the keystore
3472017-10-11T17:06:05 <Chris_Stewart_5> I believe I did this https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L14
3482017-10-11T17:06:09 <Chris_Stewart_5> sipa: ^
3492017-10-11T17:06:27 <sipa> your redeemscript is just a key?
3502017-10-11T17:06:49 <sipa> or what is spk_keys
3512017-10-11T17:06:52 <Chris_Stewart_5> tuple
3522017-10-11T17:07:01 <Chris_Stewart_5> std::tuple<CScript,std::vector<CKey>>
3532017-10-11T17:07:11 <sipa> and what's the script?
3542017-10-11T17:07:46 <Chris_Stewart_5> one of the following: P2PK CScript, P2PKH CScript, Multisig CScript
3552017-10-11T17:07:53 <Chris_Stewart_5> It is randomly choosing one of those
3562017-10-11T17:09:03 <Chris_Stewart_5> then creating a p2sh script
3572017-10-11T17:09:51 *** abpa has joined #bitcoin-core-dev
3582017-10-11T17:10:04 <sipa> looks right to me
3592017-10-11T17:10:10 <sipa> what is the problem?
3602017-10-11T17:10:23 <Chris_Stewart_5> the assert fails on this line -- it should return complete right? https://gist.github.com/Christewart/3d930327e7b27e6a897fa6d2744ec569#file-produce_signature_p2sh-cpp-L20
3612017-10-11T17:10:33 <Chris_Stewart_5> *theoretically* haha
3622017-10-11T17:11:32 <sipa> yes
3632017-10-11T17:12:11 <sipa> i don't see anything obviously wrong
3642017-10-11T17:12:20 <Chris_Stewart_5> I'll dig more -- it is probably something stupid I am doing else where. I just wanted to confirm produce signature has the capability before I go deeper
3652017-10-11T17:26:18 *** Aaronvan_ has joined #bitcoin-core-dev
3662017-10-11T17:26:50 *** m8tion has quit IRC
3672017-10-11T17:27:14 *** Ylbam has joined #bitcoin-core-dev
3682017-10-11T17:30:09 *** AaronvanW has quit IRC
3692017-10-11T17:40:39 *** Emcy has joined #bitcoin-core-dev
3702017-10-11T17:48:37 *** LeMiner has joined #bitcoin-core-dev
3712017-10-11T17:53:07 *** abpa has quit IRC
3722017-10-11T17:54:35 *** jb55 has quit IRC
3732017-10-11T17:56:33 *** W4RL0RD has joined #bitcoin-core-dev
3742017-10-11T18:05:12 *** chjj has joined #bitcoin-core-dev
3752017-10-11T18:08:33 *** vicenteH has joined #bitcoin-core-dev
3762017-10-11T18:11:01 *** chjj has quit IRC
3772017-10-11T18:12:12 *** jb55 has joined #bitcoin-core-dev
3782017-10-11T18:17:03 *** AaronvanW has joined #bitcoin-core-dev
3792017-10-11T18:20:42 *** Aaronvan_ has quit IRC
3802017-10-11T18:21:18 *** Aaronvan_ has joined #bitcoin-core-dev
3812017-10-11T18:21:46 *** W4RL0RD has quit IRC
3822017-10-11T18:24:31 *** AaronvanW has quit IRC
3832017-10-11T18:37:39 *** Guyver2 has joined #bitcoin-core-dev
3842017-10-11T18:40:44 *** promag has joined #bitcoin-core-dev
3852017-10-11T18:45:07 *** promag has quit IRC
3862017-10-11T18:55:21 *** AaronvanW has joined #bitcoin-core-dev
3872017-10-11T18:57:36 *** Aaronvan_ has quit IRC
3882017-10-11T19:01:25 *** goatpig has quit IRC
3892017-10-11T19:03:13 *** wxss has quit IRC
3902017-10-11T19:03:29 *** Emcy_ has joined #bitcoin-core-dev
3912017-10-11T19:05:21 *** Emcy_ has quit IRC
3922017-10-11T19:05:38 *** wxss has joined #bitcoin-core-dev
3932017-10-11T19:06:57 *** Emcy has quit IRC
3942017-10-11T19:07:04 *** Emcy_ has joined #bitcoin-core-dev
3952017-10-11T19:07:44 <morcos> I'm just trying to catch up on old review by looking at what was merged.. In #11113 , what is the use case of responding to these strange getheaders requests with no locator at all? Or at the very least shouldn't we only respond if the hashStop is on our main chain
3962017-10-11T19:07:46 <gribble> https://github.com/bitcoin/bitcoin/issues/11113 | [net] Ignore getheaders requests for very old side blocks by jimpo · Pull Request #11113 · bitcoin/bitcoin · GitHub
3972017-10-11T19:08:06 <morcos> Not objection to merging the PR, it seems like a strict improvement, but just trying to understand why that functionality even exists
3982017-10-11T19:12:56 *** alreadylate has joined #bitcoin-core-dev
3992017-10-11T19:16:33 *** timothy has quit IRC
4002017-10-11T19:35:20 *** jannes has quit IRC
4012017-10-11T19:42:23 *** meshcollider has joined #bitcoin-core-dev
4022017-10-11T19:49:54 *** qrestlove has quit IRC
4032017-10-11T19:55:07 *** Emcy_ has quit IRC
4042017-10-11T19:55:33 *** niko__ has joined #bitcoin-core-dev
4052017-10-11T19:55:34 *** Emcy_ has joined #bitcoin-core-dev
4062017-10-11T19:59:04 *** niko__ has quit IRC
4072017-10-11T20:02:53 <bitcoin-git> [bitcoin] mess110 opened pull request #11486: [tests] Add uacomment tests (master...test_uacomment) https://github.com/bitcoin/bitcoin/pull/11486
4082017-10-11T20:06:45 *** Cheeseo has joined #bitcoin-core-dev
4092017-10-11T20:09:48 *** niko__ has joined #bitcoin-core-dev
4102017-10-11T20:10:59 *** Aaronvan_ has joined #bitcoin-core-dev
4112017-10-11T20:13:52 *** AaronvanW has quit IRC
4122017-10-11T20:18:54 *** Emcy_ has quit IRC
4132017-10-11T20:19:30 *** Emcy has joined #bitcoin-core-dev
4142017-10-11T20:19:40 *** Emcy has quit IRC
4152017-10-11T20:19:41 *** Emcy has joined #bitcoin-core-dev
4162017-10-11T20:33:36 *** qrestlove has joined #bitcoin-core-dev
4172017-10-11T20:35:40 *** laurentmt has joined #bitcoin-core-dev
4182017-10-11T20:37:52 *** laurentmt has quit IRC
4192017-10-11T20:38:10 *** qrestlove has quit IRC
4202017-10-11T20:51:01 *** qrestlove has joined #bitcoin-core-dev
4212017-10-11T20:52:21 *** chjj has joined #bitcoin-core-dev
4222017-10-11T21:02:09 *** AaronvanW has joined #bitcoin-core-dev
4232017-10-11T21:05:05 *** Aaronvan_ has quit IRC
4242017-10-11T21:08:07 *** Emcy has quit IRC
4252017-10-11T21:13:57 *** niko__ has quit IRC
4262017-10-11T21:18:40 *** qrestlove has quit IRC
4272017-10-11T21:22:41 *** qrestlove has joined #bitcoin-core-dev
4282017-10-11T21:26:22 <bitcoin-git> [bitcoin] TheBlueMatt opened pull request #11487: Check that new headers are not a descendant of an invalid block (master...2017-10-acceptblock-validity-check) https://github.com/bitcoin/bitcoin/pull/11487
4292017-10-11T21:33:47 *** Cogito_Ergo_Sum has quit IRC
4302017-10-11T21:35:01 *** alreadylate has quit IRC
4312017-10-11T21:36:09 *** mmgen has quit IRC
4322017-10-11T21:40:30 *** alreadylate has joined #bitcoin-core-dev
4332017-10-11T21:46:50 *** dcousens has joined #bitcoin-core-dev
4342017-10-11T21:49:08 *** DrOlmer has quit IRC
4352017-10-11T21:49:20 *** dgenr8 has quit IRC
4362017-10-11T21:49:42 *** Emcy has joined #bitcoin-core-dev
4372017-10-11T21:49:50 *** DrOlmer has joined #bitcoin-core-dev
4382017-10-11T21:50:21 *** dgenr8 has joined #bitcoin-core-dev
4392017-10-11T21:50:38 *** Guyver2 has quit IRC
4402017-10-11T21:59:13 *** Cheeseo has quit IRC
4412017-10-11T22:00:58 *** Chris_Stewart_5 has quit IRC
4422017-10-11T22:14:04 *** cheese_ has joined #bitcoin-core-dev
4432017-10-11T22:17:25 *** abpa has joined #bitcoin-core-dev
4442017-10-11T22:25:32 *** qrestlove has quit IRC
4452017-10-11T22:26:12 *** alreadylate has quit IRC
4462017-10-11T22:35:50 *** harrymm has quit IRC
4472017-10-11T22:36:45 *** harrymm has joined #bitcoin-core-dev
4482017-10-11T22:38:59 *** qrestlove has joined #bitcoin-core-dev
4492017-10-11T22:47:03 *** RoyceX has joined #bitcoin-core-dev
4502017-10-11T22:49:41 *** cheese_ has quit IRC
4512017-10-11T23:10:40 *** AaronvanW has quit IRC
4522017-10-11T23:18:26 *** RoyceX has quit IRC
4532017-10-11T23:29:37 *** dgenr8 has quit IRC
4542017-10-11T23:50:57 *** dermoth has joined #bitcoin-core-dev
4552017-10-11T23:57:14 *** wraithm has quit IRC
4562017-10-11T23:57:26 *** abpa has quit IRC
4572017-10-11T23:57:27 <bitcoin-git> [bitcoin] C0deAi opened pull request #11488: Codeai fixes: remove dead code, prevent possible division by zero. (master...codeai-fixes) https://github.com/bitcoin/bitcoin/pull/11488
4582017-10-11T23:58:55 *** dcousens has quit IRC