12017-10-18T00:01:47 *** jb55 has joined #bitcoin-core-dev
22017-10-18T00:02:01 *** AaronvanW has quit IRC
32017-10-18T00:06:14 *** wxss has quit IRC
42017-10-18T00:59:25 *** dabura667 has joined #bitcoin-core-dev
52017-10-18T01:02:25 *** jb55 has quit IRC
62017-10-18T01:12:42 *** jb55 has joined #bitcoin-core-dev
72017-10-18T01:18:32 *** esotericnonsense has joined #bitcoin-core-dev
82017-10-18T01:41:09 *** Ylbam has quit IRC
92017-10-18T01:48:59 *** BashCo has quit IRC
102017-10-18T01:50:48 *** BashCo has joined #bitcoin-core-dev
112017-10-18T02:11:09 *** rhavar has quit IRC
122017-10-18T02:24:33 *** brianhoffman has quit IRC
132017-10-18T02:35:48 *** Chris_Stewart_5 has joined #bitcoin-core-dev
142017-10-18T02:49:11 *** Emcy has quit IRC
152017-10-18T02:49:15 *** Emcy_ has joined #bitcoin-core-dev
162017-10-18T02:51:29 *** roadcrap has joined #bitcoin-core-dev
172017-10-18T02:58:57 *** Chris_Stewart_5 has quit IRC
182017-10-18T03:14:47 *** justanotheruser has quit IRC
192017-10-18T03:15:00 *** Emcy_ has quit IRC
202017-10-18T03:15:08 *** justanotheruser has joined #bitcoin-core-dev
212017-10-18T03:21:26 *** ok has joined #bitcoin-core-dev
222017-10-18T03:23:59 *** dlb76 has quit IRC
232017-10-18T03:24:32 *** meshcollider has quit IRC
242017-10-18T03:25:35 *** jonasschnelli has quit IRC
252017-10-18T03:30:42 *** jonasschnelli has joined #bitcoin-core-dev
262017-10-18T03:32:03 *** dlb76 has joined #bitcoin-core-dev
272017-10-18T03:35:35 *** d_p_ has quit IRC
282017-10-18T03:35:53 *** d_p has joined #bitcoin-core-dev
292017-10-18T03:51:16 *** meshcollider has joined #bitcoin-core-dev
302017-10-18T03:57:13 *** justan0theruser has joined #bitcoin-core-dev
312017-10-18T03:59:05 *** justanotheruser has quit IRC
322017-10-18T04:00:34 *** justan0theruser has quit IRC
332017-10-18T04:00:52 *** justanotheruser has joined #bitcoin-core-dev
342017-10-18T04:34:43 *** cheetah2 has joined #bitcoin-core-dev
352017-10-18T04:37:57 *** jb55 has quit IRC
362017-10-18T04:42:40 <cfields> sdaftuar: https://github.com/theuni/bitcoin/tree/move-addrdb . It builds on top of #11457, mostly as a cheap review beg :)
372017-10-18T04:42:42 <gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
382017-10-18T04:44:57 <cfields> It still needs a few things. At minimum, it needs an interface class (similar to NetEventsInterface) to be useful for your tests. Then a few things to tidy up in CConnman, as it was just kinda shoved in there as-is.
392017-10-18T04:45:39 <cfields> I'll try to get it finished up tomorrow. But I think that gets you mostly what you were after.
402017-10-18T04:47:20 <cfields> oh, and loading the addrdb is very shoe-horned in there. Need to figure out where to stick that. IMO moving it into CAddrMan makes sense, as other implementations (tests) will likely be memory-backed anyway.
412017-10-18T04:58:27 <ossifrage> This may be me seeing things, of the 87 nodes connected, the ones with the longest ping times are all 0.15.0
422017-10-18T04:58:45 *** Guest83 has joined #bitcoin-core-dev
432017-10-18T05:00:30 *** cheetah2 has quit IRC
442017-10-18T05:23:12 *** Emcy has joined #bitcoin-core-dev
452017-10-18T05:34:08 *** harrymm_ has quit IRC
462017-10-18T05:47:39 *** harrymm_ has joined #bitcoin-core-dev
472017-10-18T05:59:55 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
482017-10-18T05:59:55 *** Cogito_Ergo_Sum has quit IRC
492017-10-18T05:59:55 *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
502017-10-18T06:12:22 *** BashCo has quit IRC
512017-10-18T06:17:03 *** Emcy_ has joined #bitcoin-core-dev
522017-10-18T06:20:16 *** Emcy has quit IRC
532017-10-18T06:47:29 *** BashCo has joined #bitcoin-core-dev
542017-10-18T07:13:28 *** harrymm_ has quit IRC
552017-10-18T07:14:33 *** meshcollider has quit IRC
562017-10-18T07:17:02 *** harrymm has joined #bitcoin-core-dev
572017-10-18T07:25:22 *** Guyver2 has joined #bitcoin-core-dev
582017-10-18T07:30:24 *** meshcollider has joined #bitcoin-core-dev
592017-10-18T07:38:31 *** sybarite has joined #bitcoin-core-dev
602017-10-18T07:52:26 *** timothy has joined #bitcoin-core-dev
612017-10-18T07:53:52 *** laurentmt has joined #bitcoin-core-dev
622017-10-18T07:54:31 *** Guest83 has quit IRC
632017-10-18T08:02:00 *** victorSN has joined #bitcoin-core-dev
642017-10-18T08:02:39 *** victorSN has joined #bitcoin-core-dev
652017-10-18T08:07:57 *** sybarite has quit IRC
662017-10-18T08:17:32 *** victorSN has quit IRC
672017-10-18T08:18:28 *** victorSN has joined #bitcoin-core-dev
682017-10-18T08:18:57 *** goatpig has joined #bitcoin-core-dev
692017-10-18T08:20:57 *** Guyver2 has quit IRC
702017-10-18T08:26:18 *** jcorgan_ has joined #bitcoin-core-dev
712017-10-18T08:26:48 *** dabura667_ has joined #bitcoin-core-dev
722017-10-18T08:28:36 *** dabura667 has quit IRC
732017-10-18T08:28:36 *** jcorgan has quit IRC
742017-10-18T08:31:27 *** lifeofguenter has quit IRC
752017-10-18T08:31:32 *** Apocalyptic has quit IRC
762017-10-18T08:33:30 *** lifeofguenter has joined #bitcoin-core-dev
772017-10-18T08:33:38 *** Apocalyptic has joined #bitcoin-core-dev
782017-10-18T08:35:08 *** ekrion has quit IRC
792017-10-18T08:38:16 *** sanada has joined #bitcoin-core-dev
802017-10-18T08:39:12 *** vicenteH has joined #bitcoin-core-dev
812017-10-18T08:39:26 *** sanada` has quit IRC
822017-10-18T08:40:08 *** Aaronvan_ has joined #bitcoin-core-dev
832017-10-18T08:40:08 *** promag has joined #bitcoin-core-dev
842017-10-18T08:43:52 *** midnightmagic has quit IRC
852017-10-18T08:49:18 *** Aaronvan_ has quit IRC
862017-10-18T08:49:47 *** AaronvanW has joined #bitcoin-core-dev
872017-10-18T08:50:49 *** cheetah2 has joined #bitcoin-core-dev
882017-10-18T08:54:23 *** aj has joined #bitcoin-core-dev
892017-10-18T09:06:31 *** JackH has joined #bitcoin-core-dev
902017-10-18T09:07:36 <kallewoof> ossifrage: not seeing that on my end
912017-10-18T09:13:46 *** midnightmagic has joined #bitcoin-core-dev
922017-10-18T09:15:41 *** dermoth has joined #bitcoin-core-dev
932017-10-18T09:31:41 *** pedrobranco has joined #bitcoin-core-dev
942017-10-18T09:32:20 *** sybarite has joined #bitcoin-core-dev
952017-10-18T09:38:22 <bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/808c84f89d0e...26fee4f6bd9a
962017-10-18T09:38:22 <bitcoin-git> bitcoin/master 258d33b Karl-Johan Alm: [mempool] Mark unaccepted txs present in mempool as 'already there'....
972017-10-18T09:38:23 <bitcoin-git> bitcoin/master 26fee4f Pieter Wuille: Merge #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there'...
982017-10-18T09:38:34 <sipa> kallewoof: ^ i was confused to not see a 'already there' when starting up a master node, and then realized that wasn't merged yet
992017-10-18T09:38:47 <bitcoin-git> [bitcoin] sipa closed pull request #11062: [mempool] Mark mempool import fails that were found in mempool as 'already there' (master...mempool-alreadythere) https://github.com/bitcoin/bitcoin/pull/11062
1002017-10-18T09:39:16 <gmaxwell> sipa: kallewoof: thanks.
1012017-10-18T09:48:28 *** dermoth has quit IRC
1022017-10-18T09:48:28 *** d_p has quit IRC
1032017-10-18T09:48:28 *** intcat has quit IRC
1042017-10-18T09:48:28 *** arubi has quit IRC
1052017-10-18T09:51:01 * kallewoof cheers :)
1062017-10-18T10:03:14 *** geezas has quit IRC
1072017-10-18T10:03:31 *** dabura667_ has quit IRC
1082017-10-18T10:08:37 *** arubi has joined #bitcoin-core-dev
1092017-10-18T10:08:39 *** d_p_ has joined #bitcoin-core-dev
1102017-10-18T10:14:52 *** intcat has joined #bitcoin-core-dev
1112017-10-18T10:16:10 *** pedrobranco has quit IRC
1122017-10-18T10:16:19 *** pedrobranco has joined #bitcoin-core-dev
1132017-10-18T10:30:07 *** Banzai10 has joined #bitcoin-core-dev
1142017-10-18T10:30:57 *** chjj has quit IRC
1152017-10-18T10:41:27 *** qwe_ has joined #bitcoin-core-dev
1162017-10-18T10:43:35 *** Emcy_ has quit IRC
1172017-10-18T10:52:13 *** chjj has joined #bitcoin-core-dev
1182017-10-18T11:10:55 *** shesek has joined #bitcoin-core-dev
1192017-10-18T11:10:55 *** shesek has joined #bitcoin-core-dev
1202017-10-18T11:24:44 *** pedrobranco has quit IRC
1212017-10-18T11:25:21 *** pedrobranco has joined #bitcoin-core-dev
1222017-10-18T11:27:34 *** rafalcpp has joined #bitcoin-core-dev
1232017-10-18T11:30:02 *** pedrobranco has quit IRC
1242017-10-18T11:32:26 *** SopaXorzTaker has joined #bitcoin-core-dev
1252017-10-18T12:04:49 *** wxss has joined #bitcoin-core-dev
1262017-10-18T12:15:38 *** promag has quit IRC
1272017-10-18T12:20:05 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1282017-10-18T12:23:22 *** intcat has quit IRC
1292017-10-18T12:24:49 *** intcat has joined #bitcoin-core-dev
1302017-10-18T12:24:53 *** Emcy has joined #bitcoin-core-dev
1312017-10-18T12:30:48 *** Emcy has quit IRC
1322017-10-18T12:31:39 *** Emcy has joined #bitcoin-core-dev
1332017-10-18T12:42:27 *** nelruk has joined #bitcoin-core-dev
1342017-10-18T12:43:49 *** [Author] has quit IRC
1352017-10-18T12:43:49 *** Magma has quit IRC
1362017-10-18T12:44:55 *** Emcy has quit IRC
1372017-10-18T12:46:03 *** pedrobranco has joined #bitcoin-core-dev
1382017-10-18T12:51:21 *** unholymachine has quit IRC
1392017-10-18T12:54:11 *** unholymachine has joined #bitcoin-core-dev
1402017-10-18T12:55:44 *** nelruk has quit IRC
1412017-10-18T12:55:49 *** pergaminho has joined #bitcoin-core-dev
1422017-10-18T13:00:28 *** intcat has quit IRC
1432017-10-18T13:00:28 *** d_p_ has quit IRC
1442017-10-18T13:01:00 *** arubi has quit IRC
1452017-10-18T13:02:33 *** Chris_Stewart_5 has quit IRC
1462017-10-18T13:03:22 *** promag has joined #bitcoin-core-dev
1472017-10-18T13:17:02 *** d_p has joined #bitcoin-core-dev
1482017-10-18T13:17:13 *** Chris_Stewart_5 has joined #bitcoin-core-dev
1492017-10-18T13:17:23 *** arubi has joined #bitcoin-core-dev
1502017-10-18T13:17:28 *** intcat has joined #bitcoin-core-dev
1512017-10-18T13:23:23 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26fee4f6bd9a...ffa5159cefb8
1522017-10-18T13:23:23 <bitcoin-git> bitcoin/master 207408b Jonas Schnelli: Fix crash via division by zero assertion
1532017-10-18T13:23:24 <bitcoin-git> bitcoin/master ffa5159 Wladimir J. van der Laan: Merge #11508: Fix crash via division by zero assertion...
1542017-10-18T13:24:03 <bitcoin-git> [bitcoin] laanwj closed pull request #11508: Fix crash via division by zero assertion (master...2017/10/qt_cc_crash_zero) https://github.com/bitcoin/bitcoin/pull/11508
1552017-10-18T13:40:09 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ffa5159cefb8...b645f368f299
1562017-10-18T13:40:09 <bitcoin-git> bitcoin/master 7104de8 João Barbosa: [wallet] Fix leak in CDB constructor...
1572017-10-18T13:40:10 <bitcoin-git> bitcoin/master b645f36 Wladimir J. van der Laan: Merge #11492: [wallet] Fix leak in CDB constructor...
1582017-10-18T13:40:16 <promag> doesn't make sense to "return false" here: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L941 ?
1592017-10-18T13:40:39 <bitcoin-git> [bitcoin] laanwj closed pull request #11492: [wallet] Fix leak in CDB constructor (master...2017-10-cdb-constructor-leak) https://github.com/bitcoin/bitcoin/pull/11492
1602017-10-18T13:41:22 <promag> if fTxIndex and !ReadTxIndex why continue?
1612017-10-18T13:42:11 <sipa> promag: makes sense
1622017-10-18T13:42:23 <promag> PR on the way
1632017-10-18T13:42:32 <promag> btw
1642017-10-18T13:42:54 <promag> sometimes why on earth AssertLockHeld fails on some travis jobs?
1652017-10-18T13:43:04 <promag> any insight?
1662017-10-18T13:43:30 <promag> https://travis-ci.org/bitcoin/bitcoin/builds/289428354
1672017-10-18T13:43:38 <sipa> that would indicate a bug..
1682017-10-18T13:44:03 <promag> right, I've added the AssertLockHeld, but only some builds fail
1692017-10-18T13:44:19 <promag> s/builds/jobs
1702017-10-18T13:44:33 *** meshcollider has quit IRC
1712017-10-18T13:46:18 <sipa> not all are built with -DDEBUG_LOCKS
1722017-10-18T13:47:51 <wumpus> there is significant overhead to lock checking so it is only enabled for debug builds
1732017-10-18T13:48:17 <promag> you mean debug_lockorder?
1742017-10-18T13:48:31 <wumpus> yes
1752017-10-18T13:48:38 <promag> I understand, I'll check that out
1762017-10-18T13:49:38 <sipa> we have an ad-hoc lock contention/correctness checking, which is compiled in when you build with -DDEBUG_LOCKORDER
1772017-10-18T13:49:58 <Banzai10> promag, do you have the logs?
1782017-10-18T13:49:59 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b645f368f299...2ca518deff25
1792017-10-18T13:50:00 <bitcoin-git> bitcoin/master c5dfa90 Cristian Mircea Messel: [tests] Add uacomment tests...
1802017-10-18T13:50:00 <bitcoin-git> bitcoin/master 2ca518d Wladimir J. van der Laan: Merge #11486: [tests] Add uacomment tests...
1812017-10-18T13:50:16 *** m8tion has joined #bitcoin-core-dev
1822017-10-18T13:50:32 <bitcoin-git> [bitcoin] laanwj closed pull request #11486: [tests] Add uacomment tests (master...test_uacomment) https://github.com/bitcoin/bitcoin/pull/11486
1832017-10-18T13:50:45 <promag> Banzai10: check https://travis-ci.org/bitcoin/bitcoin/jobs/289428359
1842017-10-18T14:03:01 <promag> forever alone #11514 :P
1852017-10-18T14:03:02 <gribble> https://github.com/bitcoin/bitcoin/issues/11514 | Iterate and remove nodes without container copy by promag · Pull Request #11514 · bitcoin/bitcoin · GitHub
1862017-10-18T14:04:07 <promag> wumpus: now that 1 line pr is done, take this with 2 lines https://github.com/bitcoin/bitcoin/pull/11006/files
1872017-10-18T14:05:36 <wumpus> ah yes that one looks good to me now
1882017-10-18T14:07:10 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2ca518deff25...a1d78b59fc03
1892017-10-18T14:07:10 <bitcoin-git> bitcoin/master 793667a João Barbosa: Improve shutdown process
1902017-10-18T14:07:11 <bitcoin-git> bitcoin/master a1d78b5 Wladimir J. van der Laan: Merge #11006: Improve shutdown process...
1912017-10-18T14:07:18 <promag> :confetti:
1922017-10-18T14:07:34 <bitcoin-git> [bitcoin] laanwj closed pull request #11006: Improve shutdown process (master...201708-fast-shutdown) https://github.com/bitcoin/bitcoin/pull/11006
1932017-10-18T14:18:01 *** promag has quit IRC
1942017-10-18T14:21:43 <wumpus> vNodes.erase(remove(vNodes.begin(), vNodes.end(), pnode), vNodes.end()); , huh
1952017-10-18T14:23:12 <wumpus> so std::vector::erase removes elements in a range, remove() returns the range vNodes.begin() to vNodes.end() minus pnode
1962017-10-18T14:23:32 <wumpus> shouldn't this remove everything but pnode?
1972017-10-18T14:27:45 <wumpus> std::remove "Transforms the range [first,last) into a range with all the elements that compare equal to val removed, and returns an iterator to the new end of that range."
1982017-10-18T14:28:41 <cfields> wumpus: https://en.wikipedia.org/wiki/Erase%E2%80%93remove_idiom
1992017-10-18T14:28:51 <cfields> I had to look it up first time I saw it
2002017-10-18T14:29:07 <wumpus> whoa that could have at least used a comment
2012017-10-18T14:32:09 <wumpus> oh no did i break travis?
2022017-10-18T14:33:12 <wumpus> E: Failed to fetch https://packagecloud.io/basho/riak/ubuntu/dists/trusty/main/source/Sources 401 Unauthorized no, apparently a download failure
2032017-10-18T14:35:43 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a1d78b59fc03...50d72b357081
2042017-10-18T14:35:43 <bitcoin-git> bitcoin/master f4c4e38 John Newbery: [trivial] Make namespace explicit for is_regular_file...
2052017-10-18T14:35:44 <bitcoin-git> bitcoin/master 50d72b3 Wladimir J. van der Laan: Merge #11495: [trivial] Make namespace explicit for is_regular_file...
2062017-10-18T14:36:06 <sdaftuar> hm, this looks like a pretty sketchy comment: https://github.com/bitcoin/bitcoin/issues/11519#issuecomment-337453387
2072017-10-18T14:36:18 <bitcoin-git> [bitcoin] laanwj closed pull request #11495: [trivial] Make namespace explicit for is_regular_file (master...explicit_is_regular_file) https://github.com/bitcoin/bitcoin/pull/11495
2082017-10-18T14:37:40 <wumpus> right, deleted it, it made no sense at all (download the app to your mobile? bitcoin.com?)
2092017-10-18T14:47:14 <sdaftuar> yeah, thanks - your response looks much better :)
2102017-10-18T14:52:14 *** wraithm has joined #bitcoin-core-dev
2112017-10-18T14:53:13 <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/50d72b357081...6759a24eaaf7
2122017-10-18T14:53:14 <bitcoin-git> bitcoin/master fa9de37 MarcoFalke: qa: Make tmpdir option an absolute path...
2132017-10-18T14:53:14 <bitcoin-git> bitcoin/master fafa003 MarcoFalke: qa: Remove never used return value of sync_with_ping
2142017-10-18T14:53:15 <bitcoin-git> bitcoin/master 6759a24 Wladimir J. van der Laan: Merge #11472: qa: Make tmpdir option an absolute path, misc cleanup...
2152017-10-18T14:53:42 <bitcoin-git> [bitcoin] laanwj closed pull request #11472: qa: Make tmpdir option an absolute path, misc cleanup (master...Mf1710-qaMultiwalletRelDir) https://github.com/bitcoin/bitcoin/pull/11472
2162017-10-18T14:53:50 <wumpus> thanks :)
2172017-10-18T14:55:56 <wumpus> can we solve the basho riak download issue? I get an angry travis mail a few seconds after every merge now
2182017-10-18T14:56:47 <sipa> ?
2192017-10-18T14:56:49 <wumpus> I have no idea why it's downloading that package in the first place, part of travis infrastructure I guess... hm in that case there's nothing we can do
2202017-10-18T14:56:59 <wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/289537283
2212017-10-18T14:58:20 *** d_p has quit IRC
2222017-10-18T15:02:25 <bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/6759a24eaaf7...937613d215de
2232017-10-18T15:02:26 <bitcoin-git> bitcoin/master c6b07fd practicalswift: Fix a vs. an typo
2242017-10-18T15:02:26 <bitcoin-git> bitcoin/master 68feb49 practicalswift: Use nullptr instead of NULL
2252017-10-18T15:02:27 <bitcoin-git> bitcoin/master 0aacfa4 practicalswift: Remove accidental stray semicolon
2262017-10-18T15:03:00 <bitcoin-git> [bitcoin] laanwj closed pull request #11467: Fix typos. Use nullptr instead of NULL. (master...cleanups-20171009) https://github.com/bitcoin/bitcoin/pull/11467
2272017-10-18T15:04:01 *** rafalcpp has quit IRC
2282017-10-18T15:06:01 *** arubi_ has joined #bitcoin-core-dev
2292017-10-18T15:07:09 *** d_p_ has joined #bitcoin-core-dev
2302017-10-18T15:08:03 *** Guest83 has joined #bitcoin-core-dev
2312017-10-18T15:08:49 *** sybarite has quit IRC
2322017-10-18T15:09:32 *** arubi has quit IRC
2332017-10-18T15:12:53 *** arubi_ is now known as arubi
2342017-10-18T15:30:50 *** intcat has quit IRC
2352017-10-18T15:31:48 *** intcat has joined #bitcoin-core-dev
2362017-10-18T15:43:02 *** Guest83 has quit IRC
2372017-10-18T15:50:48 *** rafalcpp has joined #bitcoin-core-dev
2382017-10-18T15:55:46 *** alreadylate has joined #bitcoin-core-dev
2392017-10-18T15:59:03 *** alreadylate has quit IRC
2402017-10-18T16:09:35 <cfields> sdaftuar: in case you missed it, see backlog re moving addrman
2412017-10-18T16:09:58 <sdaftuar> cfields: thanks, i got it -- reviewing #11457 now in fact
2422017-10-18T16:10:01 <gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
2432017-10-18T16:10:16 *** jb55 has joined #bitcoin-core-dev
2442017-10-18T16:10:31 <cfields> ok. with an added interface class, is that what you were after?
2452017-10-18T16:11:23 <sdaftuar> i think so, yeah (well i haven't looked at the addrman change yet, but if it's just like the banman change, then yes)
2462017-10-18T16:12:03 <sdaftuar> i think the idea would be in regtest mode, to create a special mockedaddrman and sub it in. so just would want a (minimal) interface class to have to implement
2472017-10-18T16:12:28 <cfields> sdaftuar: ok
2482017-10-18T16:12:57 <cfields> though, my hope was that creating interfaces for these would allow us to do actual c++ unit tests, rather than having to launch an entire program instance for tests
2492017-10-18T16:15:02 <sdaftuar> hm. that would be better!
2502017-10-18T16:15:39 <sdaftuar> do you think we could really unit test interactions between net and net_processing though? that seems very hard.
2512017-10-18T16:15:57 <sdaftuar> (then again, what i'm doing now is also very hard)
2522017-10-18T16:16:12 <cfields> well we're getting close. the message processor is now an interface
2532017-10-18T16:16:44 <cfields> so you can define your own PeerLogicValidation and ProcessMessages as necessary
2542017-10-18T16:16:58 <cfields> i assume you need a good bit of stuff pulled out still, though?
2552017-10-18T16:17:13 <cfields> you're trying to test the outgoing peer eviction here, right?
2562017-10-18T16:17:34 <sdaftuar> yeah i want to test the logic i'm adding in #11490
2572017-10-18T16:17:35 <gribble> https://github.com/bitcoin/bitcoin/issues/11490 | Disconnect from outbound peers with bad headers chains by sdaftuar · Pull Request #11490 · bitcoin/bitcoin · GitHub
2582017-10-18T16:18:05 <cfields> ah thaks, i didn't realize you'd already PR'd it. Will review.
2592017-10-18T16:19:37 <sdaftuar> i have one more commit that is possibly even harder to test than what i've pushed so far, actually. what is there now is mostly just behavior in net_processing which might be sort-of testable (i was able to rig a single peer in regtest mode that was correctly disconnected)
2602017-10-18T16:20:08 <sdaftuar> but the next commit, where i have net_processing set an able_to_evict flag for net.cpp to choose to use, is trickier
2612017-10-18T16:20:29 <sdaftuar> as i have no way to get multiple outbound connections in our regtest environment righ tnow
2622017-10-18T16:21:15 <sdaftuar> that's partly due to addrman behavior (no more than one peer per ip) and net (don't connect out to a peer in the same network group as an existing peer)
2632017-10-18T16:21:31 <cfields> sdaftuar: one thing i have in one of my libevent branches is an ip spoofer for CNode. The idea is to setup 2 CConnman, have 1 connect x times to the other, each with a specified (fake) IP. Then you can simulate the behavior of both sides of the conenection.
2642017-10-18T16:21:32 <sdaftuar> so that aspect of it might be easier to do in a unit test than regtest
2652017-10-18T16:23:08 <cfields> sounds like it would be, yes. Otherwise you have to shove in a bunch of test-specific behavior
2662017-10-18T16:23:09 <sdaftuar> i don't think i'm very familiar right now with the existing unit tests that use connman, i should start there
2672017-10-18T16:23:32 <cfields> heh, well there really aren't any. I'm desperately trying to get the interfaces stubbed out so that we can start writing them :)
2682017-10-18T16:23:58 <sdaftuar> well i just noticed the existing DoS_tests file while reviewing your banman pr, that is already more than i thought we could do!
2692017-10-18T16:24:13 <sdaftuar> so maybe it's not crazy to think i could write a unit test with just what we have now
2702017-10-18T16:24:52 <cfields> yes, that one is a pretty good example of where I'd like to be heading. It allows for all local behavior without relying on a global instance
2712017-10-18T16:26:40 <cfields> Something else I really needed when testing the libevent code was a way to flood a peer with garbage and see how it would react. Garbage from 1 peer, 100 peers, etc. I think that's the perfect use-case for this kind of testing, because it's easy to code up a quick stub of a message processor that just does ping/pong as quickly as possible.
2722017-10-18T16:27:06 <cfields> I could try to code that up if it'd be helpful
2732017-10-18T16:27:41 <sdaftuar> thanks, not sure yet what i need until i think about the unit testing framework a bit more! i'll dive into it and see what issues i run into
2742017-10-18T16:27:59 <cfields> ok
2752017-10-18T16:29:17 <cfields> sdaftuar: thanks for the review!
2762017-10-18T16:36:09 *** timothy has quit IRC
2772017-10-18T16:36:15 <sdaftuar> np!
2782017-10-18T17:00:38 <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/937613d215de...02ac8c892b1f
2792017-10-18T17:00:38 <bitcoin-git> bitcoin/master cc9ee80 João Barbosa: Improve ZMQ functional test
2802017-10-18T17:00:39 <bitcoin-git> bitcoin/master 02ac8c8 Wladimir J. van der Laan: Merge #11452: Improve ZMQ functional test...
2812017-10-18T17:00:44 *** JackH has quit IRC
2822017-10-18T17:01:10 <bitcoin-git> [bitcoin] laanwj closed pull request #11452: Improve ZMQ functional test (master...2017-10-improve-zmq-test) https://github.com/bitcoin/bitcoin/pull/11452
2832017-10-18T17:09:18 *** laurentmt has quit IRC
2842017-10-18T17:10:37 *** m8tion has quit IRC
2852017-10-18T17:12:02 *** rockhouse has quit IRC
2862017-10-18T17:25:00 *** intcat has quit IRC
2872017-10-18T17:25:32 *** d_p_ has quit IRC
2882017-10-18T17:25:32 *** arubi has quit IRC
2892017-10-18T17:27:09 *** d_p_ has joined #bitcoin-core-dev
2902017-10-18T17:27:34 *** intcat has joined #bitcoin-core-dev
2912017-10-18T17:29:21 *** tripleslash has quit IRC
2922017-10-18T17:30:35 *** arubi has joined #bitcoin-core-dev
2932017-10-18T17:31:42 *** JackH has joined #bitcoin-core-dev
2942017-10-18T17:33:41 *** tripleslash has joined #bitcoin-core-dev
2952017-10-18T17:33:46 *** PaulCapestany has quit IRC
2962017-10-18T17:46:10 *** Dizzle has joined #bitcoin-core-dev
2972017-10-18T18:14:53 *** meshcollider has joined #bitcoin-core-dev
2982017-10-18T18:18:41 *** ekrion has joined #bitcoin-core-dev
2992017-10-18T18:20:04 *** pedrobranco has quit IRC
3002017-10-18T18:20:35 *** pedrobranco has joined #bitcoin-core-dev
3012017-10-18T18:25:05 *** pedrobranco has quit IRC
3022017-10-18T18:28:04 <bitcoin-git> [bitcoin] theuni opened pull request #11521: travis: move back to the minimal image (master...travis-minimal) https://github.com/bitcoin/bitcoin/pull/11521
3032017-10-18T18:43:15 *** jonasschnelli has quit IRC
3042017-10-18T18:43:16 *** jonasschnelli has joined #bitcoin-core-dev
3052017-10-18T18:50:38 *** kewde[m] has quit IRC
3062017-10-18T18:53:56 *** SopaXorzTaker has quit IRC
3072017-10-18T18:53:57 *** tripleslash has quit IRC
3082017-10-18T18:55:32 *** Guyver2 has joined #bitcoin-core-dev
3092017-10-18T18:56:04 <bitcoin-git> [bitcoin] laanwj pushed 26 new commits to 0.15: https://github.com/bitcoin/bitcoin/compare/51bad9195eb4...1646f9c76036
3102017-10-18T18:56:05 <bitcoin-git> bitcoin/0.15 9e8aae3 Karl-Johan Alm: [wallet] Close DB on error....
3112017-10-18T18:56:05 <bitcoin-git> bitcoin/0.15 50bd3f6 practicalswift: Avoid returning a BIP9Stats object with uninitialized values...
3122017-10-18T18:56:06 <bitcoin-git> bitcoin/0.15 b278a43 Wladimir J. van der Laan: rpc: Write authcookie atomically...
3132017-10-18T18:57:20 *** tripleslash has joined #bitcoin-core-dev
3142017-10-18T19:01:19 *** rockhouse has joined #bitcoin-core-dev
3152017-10-18T19:02:35 *** kewde[m] has joined #bitcoin-core-dev
3162017-10-18T19:03:55 *** sanada has quit IRC
3172017-10-18T19:07:41 *** Ylbam has joined #bitcoin-core-dev
3182017-10-18T19:08:56 *** abpa has joined #bitcoin-core-dev
3192017-10-18T19:31:56 *** ghost43 has quit IRC
3202017-10-18T19:33:31 *** ghost43 has joined #bitcoin-core-dev
3212017-10-18T19:39:38 *** cheese_ has joined #bitcoin-core-dev
3222017-10-18T19:51:56 *** rockhouse has quit IRC
3232017-10-18T19:52:02 <cfields> wumpus: I forgot to mention in the PR, but I believe 11521 would've mitigated today's travis issue
3242017-10-18T19:53:08 *** rockhouse has joined #bitcoin-core-dev
3252017-10-18T20:10:41 *** goksinen has joined #bitcoin-core-dev
3262017-10-18T20:25:48 *** rockhouse has quit IRC
3272017-10-18T20:31:08 *** rockhouse has joined #bitcoin-core-dev
3282017-10-18T20:33:29 *** goksinen_ has joined #bitcoin-core-dev
3292017-10-18T20:36:37 *** goksinen has quit IRC
3302017-10-18T20:37:31 *** cheese_ has quit IRC
3312017-10-18T20:49:57 *** jimpo has quit IRC
3322017-10-18T20:52:45 *** goksinen has joined #bitcoin-core-dev
3332017-10-18T20:55:27 *** goksinen_ has quit IRC
3342017-10-18T20:56:52 *** jimpo has joined #bitcoin-core-dev
3352017-10-18T20:59:12 *** JackH has quit IRC
3362017-10-18T21:07:29 *** lrvick has quit IRC
3372017-10-18T21:09:38 *** goksinen has quit IRC
3382017-10-18T21:13:19 *** lrvick has joined #bitcoin-core-dev
3392017-10-18T21:14:20 *** ghost43 has quit IRC
3402017-10-18T21:19:26 *** ghost43 has joined #bitcoin-core-dev
3412017-10-18T21:20:58 *** rockhouse has quit IRC
3422017-10-18T21:22:44 *** rockhouse has joined #bitcoin-core-dev
3432017-10-18T21:24:01 *** promag has joined #bitcoin-core-dev
3442017-10-18T21:27:54 *** fluidjax has joined #bitcoin-core-dev
3452017-10-18T21:33:50 *** ecurrencyhodler_ has quit IRC
3462017-10-18T21:39:27 <ossifrage> This is very strange, the 'copy addess' (all copy to clipboard) functions just stop running on bitcoin-qt (0.15.0 linux), other programs talk to the cut buffer just fine, but not bitcoin-qt
3472017-10-18T21:43:10 <ossifrage> Ah, there is console output: "Warn Dissector bug, protocol Bitcoin, in packet 3560375: proto.c:5519: failed assertion "idx >= 0 && idx < num_tree_types""
3482017-10-18T21:44:05 <ossifrage> Never mind, that has nothing to do with this...
3492017-10-18T21:44:32 *** Chris_Stewart_5 has quit IRC
3502017-10-18T21:45:04 *** promag has quit IRC
3512017-10-18T21:45:28 <ossifrage> I can't even copy text from the transaction details dialog...
3522017-10-18T21:59:13 *** DEV_ has joined #bitcoin-core-dev
3532017-10-18T21:59:16 <DEV_> we are working on a development project of the blockchain any donations will be welcome we will update you on the progress of the project as you go btc wallet : 1LJBnabTgobc6xpgH92eV7yha36KSMvtSP
3542017-10-18T21:59:32 *** DEV_ has quit IRC
3552017-10-18T22:02:19 *** roadcrap has quit IRC
3562017-10-18T22:02:40 *** moctos has joined #bitcoin-core-dev
3572017-10-18T22:04:03 *** laurentmt has joined #bitcoin-core-dev
3582017-10-18T22:05:36 *** promag has joined #bitcoin-core-dev
3592017-10-18T22:05:53 *** Guyver2 has quit IRC
3602017-10-18T22:10:29 *** wraithm has quit IRC
3612017-10-18T22:18:51 *** laurentmt has quit IRC
3622017-10-18T22:27:18 *** promag has quit IRC
3632017-10-18T22:55:37 *** abpa has quit IRC
3642017-10-18T23:01:52 *** Dizzle has quit IRC
3652017-10-18T23:09:15 *** goatpig has quit IRC
3662017-10-18T23:23:22 *** Cogito_Ergo_Sum has quit IRC
3672017-10-18T23:39:14 *** AaronvanW has quit IRC
3682017-10-18T23:41:52 *** Banzai10 has quit IRC
3692017-10-18T23:43:34 *** Banzai10 has joined #bitcoin-core-dev