1 2017-11-08T00:02:35  *** dcousens has joined #bitcoin-core-dev
  2 2017-11-08T00:06:40  *** LumberCartel has joined #bitcoin-core-dev
  3 2017-11-08T00:06:51  *** AaronvanW has joined #bitcoin-core-dev
  4 2017-11-08T00:07:33  *** Aaronvan_ has joined #bitcoin-core-dev
  5 2017-11-08T00:11:13  *** AaronvanW has quit IRC
  6 2017-11-08T00:22:36  *** Aaronvan_ has quit IRC
  7 2017-11-08T00:41:54  *** Cheeseo has quit IRC
  8 2017-11-08T00:51:11  *** shesek has quit IRC
  9 2017-11-08T01:01:21  *** dgenr8 has quit IRC
 10 2017-11-08T01:02:07  *** dgenr8 has joined #bitcoin-core-dev
 11 2017-11-08T01:03:37  *** Giszmo has joined #bitcoin-core-dev
 12 2017-11-08T01:09:51  *** jb55 has quit IRC
 13 2017-11-08T01:11:00  *** EEXIST64 has joined #bitcoin-core-dev
 14 2017-11-08T01:14:43  *** EEXIST64 has quit IRC
 15 2017-11-08T01:15:23  *** shesek has joined #bitcoin-core-dev
 16 2017-11-08T01:27:40  *** arubi has quit IRC
 17 2017-11-08T01:28:25  *** arubi has joined #bitcoin-core-dev
 18 2017-11-08T01:30:06  *** dgenr8 has quit IRC
 19 2017-11-08T01:30:27  *** dgenr8 has joined #bitcoin-core-dev
 20 2017-11-08T01:36:33  *** RubenSomsen has joined #bitcoin-core-dev
 21 2017-11-08T01:47:13  *** Ylbam has quit IRC
 22 2017-11-08T02:06:08  *** btcdrak has joined #bitcoin-core-dev
 23 2017-11-08T02:12:46  *** ula has quit IRC
 24 2017-11-08T02:49:27  *** AaronvanW has joined #bitcoin-core-dev
 25 2017-11-08T03:13:16  *** wxss has quit IRC
 26 2017-11-08T03:37:06  *** d9b4bef9 has quit IRC
 27 2017-11-08T03:38:59  *** PaulCapestany has quit IRC
 28 2017-11-08T03:42:02  <wumpus> BlueMatt: I'm all for adding different formats but please keep csv output support
 29 2017-11-08T03:42:15  <wumpus> it's easy to parse for my own tooling, I don't eally like web tools
 30 2017-11-08T03:42:30  <BlueMatt> wumpus: csv is still there and still default
 31 2017-11-08T03:42:47  <BlueMatt> (and not my pr)
 32 2017-11-08T03:44:09  <wumpus> relating the bench framework, #11562 seems ready for merge at least
 33 2017-11-08T03:44:11  <gribble> https://github.com/bitcoin/bitcoin/issues/11562 | bench: use std::chrono rather than gettimeofday by theuni · Pull Request #11562 · bitcoin/bitcoin · GitHub
 34 2017-11-08T03:45:13  *** PaulCape_ has joined #bitcoin-core-dev
 35 2017-11-08T03:48:35  *** chjj has quit IRC
 36 2017-11-08T03:50:09  *** bule2 has joined #bitcoin-core-dev
 37 2017-11-08T03:52:23  *** bule2 has quit IRC
 38 2017-11-08T03:53:17  *** bule has quit IRC
 39 2017-11-08T04:33:03  <achow101> For some reason, all of my builds locally continuously fail p2p-fullblocktest.py (it's been happening for a while now, I've just been ignoring it). any ideas why?
 40 2017-11-08T04:33:18  <achow101> it just times out
 41 2017-11-08T04:33:50  <achow101> and it's unrelated to anything that I am working on, happens on master and checked out PRs that are passing Travis
 42 2017-11-08T04:35:19  <wumpus> well it used to be that such issues were related to the cache, but I think that's properly cleared now
 43 2017-11-08T04:35:35  <wumpus> (e.g. sticky issues that seem to happen only in one environment)
 44 2017-11-08T04:36:49  <gmaxwell> how do timeouts even work if not running in travis?
 45 2017-11-08T04:38:30  <wumpus> there are some timeouts during the test as well, say if it's waiting for two nodes to be synced and it takes too long, or when an RPC command takes too long
 46 2017-11-08T04:39:00  <gmaxwell> makes sense.
 47 2017-11-08T04:39:02  *** AaronvanW has quit IRC
 48 2017-11-08T04:39:08  *** RubenSomsen has quit IRC
 49 2017-11-08T04:39:11  <gmaxwell> achow101: sounds concerning.
 50 2017-11-08T04:39:28  <wumpus> these should be really high but just make sure it finishes some day even if there's some bug preventing forward progress
 51 2017-11-08T04:39:31  *** AaronvanW has joined #bitcoin-core-dev
 52 2017-11-08T04:39:53  <wumpus> in some cases they're set too tight though and they can trigger if a system is just at high load
 53 2017-11-08T04:40:04  <wumpus> (then again that tends to happen on travis not locally)
 54 2017-11-08T04:40:23  *** uneeb has joined #bitcoin-core-dev
 55 2017-11-08T04:40:38  <achow101> It's a consistent test failure, happens on test 98 of p2p-fullblocktest.py and it is a timeout
 56 2017-11-08T04:40:53  <achow101> I think it's literally the same line every single time, but I haven't actually bothered to investigate
 57 2017-11-08T04:41:27  <wumpus> they're among the most annoying failures to debug, at least with wrong output there's something clear to investigate
 58 2017-11-08T04:41:48  <gmaxwell> Which test is "98"?
 59 2017-11-08T04:42:37  *** uneeb has quit IRC
 60 2017-11-08T04:42:38  <gmaxwell> I don't see a number 98 in the file, so... (sorry, I'm still kind of embarassingly ignorant about a lot of the test framework)
 61 2017-11-08T04:42:50  <achow101> gmaxwell: I dunno. It just says "Test 98: PASS" and then "(ERROR): Assertion failed"
 62 2017-11-08T04:42:58  <achow101> ehh, I guess it's failing on test 99 then..
 63 2017-11-08T04:44:02  *** AaronvanW has quit IRC
 64 2017-11-08T04:44:51  <wumpus> any specifics on the assertion that fails?
 65 2017-11-08T04:46:22  <achow101> https://0bin.net/paste/tsfO8D4nhJB+dN6i#PoyRukFXKiHKLFR-t8dxloT74Ys0SdaK6bhhBm9lVUR <-- traceback
 66 2017-11-08T04:50:32  <achow101> gmaxwell: Test 99 is the thing that the 99th yield of get_tests() in p2p-fullblocktest.py "returns"
 67 2017-11-08T04:50:58  <gmaxwell> If I understand this correctly, it's waiting for a ping response.
 68 2017-11-08T04:51:23  <wumpus> oh the assertion is that a timeout is exceeded, yes that seems to be it gmaxwell
 69 2017-11-08T04:53:03  <gmaxwell> it's really hard for me to tell from this traceback what the test conditions were where it croaked out.
 70 2017-11-08T04:54:41  <achow101> gmaxwell: it should be whatever accepted() at this line is: https://github.com/bitcoin/bitcoin/blob/master/test/functional/p2p-fullblocktest.py#L1282
 71 2017-11-08T04:54:48  <wumpus> there's a command line argument jump into the python debugger on a failure, so the conditions can be investigated
 72 2017-11-08T04:54:56  <achow101> which is something that this loop https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/comptool.py#L299 does something with
 73 2017-11-08T05:00:07  *** AaronvanW has joined #bitcoin-core-dev
 74 2017-11-08T05:01:47  *** Aaronvan_ has joined #bitcoin-core-dev
 75 2017-11-08T05:05:27  *** AaronvanW has quit IRC
 76 2017-11-08T05:09:58  *** fanquake has joined #bitcoin-core-dev
 77 2017-11-08T05:10:17  <fanquake> achow101 I have occasionally seen the same. Only that test.
 78 2017-11-08T05:22:42  *** MrPaz has quit IRC
 79 2017-11-08T05:35:31  *** luke-jr has quit IRC
 80 2017-11-08T05:37:16  *** luke-jr has joined #bitcoin-core-dev
 81 2017-11-08T05:58:28  *** fanquake has quit IRC
 82 2017-11-08T06:09:09  *** jtimon has quit IRC
 83 2017-11-08T06:36:24  *** bule2 has joined #bitcoin-core-dev
 84 2017-11-08T06:51:13  *** d9b4bef9 has joined #bitcoin-core-dev
 85 2017-11-08T07:09:32  *** bule2 has quit IRC
 86 2017-11-08T07:15:40  <wumpus> is this one of the extended tests?
 87 2017-11-08T07:29:33  <wumpus> no it's not - strange, so I'm running it all the time and not triggering that FWIW
 88 2017-11-08T07:33:57  *** Aaronvan_ has quit IRC
 89 2017-11-08T07:47:17  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5776582b7f3e...5ef3b6967b5c
 90 2017-11-08T07:47:18  <bitcoin-git> bitcoin/master 5ce7cb9 Thomas Snider: [net] De-duplicate connection eviction logic
 91 2017-11-08T07:47:18  <bitcoin-git> bitcoin/master 5ef3b69 Wladimir J. van der Laan: Merge #11524: [net] De-duplicate connection eviction logic...
 92 2017-11-08T07:51:15  *** BashCo has quit IRC
 93 2017-11-08T08:07:32  *** rafalcpp has quit IRC
 94 2017-11-08T08:15:00  *** BashCo has joined #bitcoin-core-dev
 95 2017-11-08T08:17:05  *** shesek has quit IRC
 96 2017-11-08T08:20:27  *** Cory has quit IRC
 97 2017-11-08T08:24:47  *** shesek has joined #bitcoin-core-dev
 98 2017-11-08T08:26:07  *** Pasha has joined #bitcoin-core-dev
 99 2017-11-08T08:27:25  *** adetate has joined #bitcoin-core-dev
100 2017-11-08T08:29:18  *** Pasha is now known as Cory
101 2017-11-08T08:33:16  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
102 2017-11-08T08:50:39  *** DvdKhl has quit IRC
103 2017-11-08T09:01:37  *** JackH has quit IRC
104 2017-11-08T09:02:39  *** timothy has joined #bitcoin-core-dev
105 2017-11-08T09:04:31  *** kexkey has quit IRC
106 2017-11-08T09:05:47  *** shesek has quit IRC
107 2017-11-08T09:08:51  *** laurentmt has joined #bitcoin-core-dev
108 2017-11-08T09:20:10  *** puff has quit IRC
109 2017-11-08T09:22:27  *** puff has joined #bitcoin-core-dev
110 2017-11-08T09:24:48  *** promag has joined #bitcoin-core-dev
111 2017-11-08T09:27:49  *** puff has quit IRC
112 2017-11-08T09:27:50  *** adetate has quit IRC
113 2017-11-08T09:28:22  *** puff has joined #bitcoin-core-dev
114 2017-11-08T09:34:10  <bitcoin-git> [bitcoin] practicalswift opened pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634
115 2017-11-08T09:43:23  *** btcdrak has quit IRC
116 2017-11-08T09:43:23  *** felco has quit IRC
117 2017-11-08T09:43:23  *** rubensayshi has quit IRC
118 2017-11-08T09:43:23  *** pindarhk_ has quit IRC
119 2017-11-08T09:43:24  *** griswaalt[m] has quit IRC
120 2017-11-08T09:43:24  *** herzmeister[m] has quit IRC
121 2017-11-08T09:43:24  *** unholymachine has quit IRC
122 2017-11-08T09:43:24  *** eragmus has quit IRC
123 2017-11-08T09:43:24  *** derbumi has quit IRC
124 2017-11-08T09:43:24  *** jimpo has quit IRC
125 2017-11-08T09:43:24  *** NielsvG has quit IRC
126 2017-11-08T09:43:25  *** bitbee has quit IRC
127 2017-11-08T09:43:25  *** newbold has quit IRC
128 2017-11-08T09:43:25  *** gwillen has quit IRC
129 2017-11-08T09:43:25  *** adam3us has quit IRC
130 2017-11-08T09:43:25  *** jonasschnelli has quit IRC
131 2017-11-08T09:43:25  *** bordeaux_facile has quit IRC
132 2017-11-08T09:43:25  *** robby938 has quit IRC
133 2017-11-08T09:43:25  *** wbnns has quit IRC
134 2017-11-08T09:43:25  *** CodeShark has quit IRC
135 2017-11-08T09:47:00  *** Masaomi[m] has quit IRC
136 2017-11-08T09:47:01  *** kewde[m] has quit IRC
137 2017-11-08T09:48:39  *** shesek has joined #bitcoin-core-dev
138 2017-11-08T09:49:04  *** btcdrak has joined #bitcoin-core-dev
139 2017-11-08T09:49:05  *** felco has joined #bitcoin-core-dev
140 2017-11-08T09:49:05  *** rubensayshi has joined #bitcoin-core-dev
141 2017-11-08T09:49:05  *** pindarhk_ has joined #bitcoin-core-dev
142 2017-11-08T09:49:05  *** unholymachine has joined #bitcoin-core-dev
143 2017-11-08T09:49:05  *** eragmus has joined #bitcoin-core-dev
144 2017-11-08T09:49:05  *** derbumi has joined #bitcoin-core-dev
145 2017-11-08T09:49:05  *** jimpo has joined #bitcoin-core-dev
146 2017-11-08T09:49:05  *** NielsvG has joined #bitcoin-core-dev
147 2017-11-08T09:49:05  *** bitbee has joined #bitcoin-core-dev
148 2017-11-08T09:49:05  *** newbold has joined #bitcoin-core-dev
149 2017-11-08T09:49:05  *** gwillen has joined #bitcoin-core-dev
150 2017-11-08T09:49:05  *** adam3us has joined #bitcoin-core-dev
151 2017-11-08T09:49:05  *** jonasschnelli has joined #bitcoin-core-dev
152 2017-11-08T09:49:05  *** bordeaux_facile has joined #bitcoin-core-dev
153 2017-11-08T09:49:05  *** wbnns has joined #bitcoin-core-dev
154 2017-11-08T09:49:05  *** robby938 has joined #bitcoin-core-dev
155 2017-11-08T09:49:05  *** CodeShark has joined #bitcoin-core-dev
156 2017-11-08T09:49:09  *** shesek has quit IRC
157 2017-11-08T09:49:09  *** shesek has joined #bitcoin-core-dev
158 2017-11-08T09:49:19  *** mlz has quit IRC
159 2017-11-08T09:51:25  *** mlz has joined #bitcoin-core-dev
160 2017-11-08T09:56:56  *** herzmeister[m] has joined #bitcoin-core-dev
161 2017-11-08T10:05:44  *** griswaalt[m] has joined #bitcoin-core-dev
162 2017-11-08T10:05:44  *** kewde[m] has joined #bitcoin-core-dev
163 2017-11-08T10:05:56  *** Masaomi[m] has joined #bitcoin-core-dev
164 2017-11-08T10:10:21  *** wxss has joined #bitcoin-core-dev
165 2017-11-08T10:14:41  *** adetate has joined #bitcoin-core-dev
166 2017-11-08T10:24:03  *** rafalcpp has joined #bitcoin-core-dev
167 2017-11-08T10:33:52  *** Ylbam has joined #bitcoin-core-dev
168 2017-11-08T10:41:44  *** timothy has quit IRC
169 2017-11-08T10:44:54  *** btcdrak has quit IRC
170 2017-11-08T10:49:11  *** timothy has joined #bitcoin-core-dev
171 2017-11-08T10:53:01  *** shesek has quit IRC
172 2017-11-08T10:53:46  *** promag has quit IRC
173 2017-11-08T10:54:03  *** promag has joined #bitcoin-core-dev
174 2017-11-08T10:55:35  *** StopAndDecrypt_ has quit IRC
175 2017-11-08T10:56:18  *** StopAndDecrypt has joined #bitcoin-core-dev
176 2017-11-08T11:07:01  *** shesek has joined #bitcoin-core-dev
177 2017-11-08T11:07:02  *** shesek has joined #bitcoin-core-dev
178 2017-11-08T11:16:15  *** shesek has quit IRC
179 2017-11-08T11:16:50  *** shesek has joined #bitcoin-core-dev
180 2017-11-08T11:16:51  *** shesek has joined #bitcoin-core-dev
181 2017-11-08T11:35:38  *** laurentmt has quit IRC
182 2017-11-08T11:41:30  *** lukedashjr has joined #bitcoin-core-dev
183 2017-11-08T11:42:23  *** luke-jr has quit IRC
184 2017-11-08T11:43:32  *** promag has quit IRC
185 2017-11-08T11:44:42  *** laurentmt has joined #bitcoin-core-dev
186 2017-11-08T11:45:54  *** lukedashjr is now known as luke-jr
187 2017-11-08T11:50:03  *** manamex has left #bitcoin-core-dev
188 2017-11-08T11:51:55  *** shesek has quit IRC
189 2017-11-08T11:56:25  *** shesek has joined #bitcoin-core-dev
190 2017-11-08T11:56:26  *** shesek has joined #bitcoin-core-dev
191 2017-11-08T11:58:38  *** ula has joined #bitcoin-core-dev
192 2017-11-08T12:06:58  *** promag has joined #bitcoin-core-dev
193 2017-11-08T12:12:43  *** shesek has quit IRC
194 2017-11-08T12:15:02  *** SopaXorzTaker has joined #bitcoin-core-dev
195 2017-11-08T12:15:04  *** Khunbish has joined #bitcoin-core-dev
196 2017-11-08T12:17:28  *** adetate has quit IRC
197 2017-11-08T12:18:23  *** shesek has joined #bitcoin-core-dev
198 2017-11-08T12:18:23  *** shesek has joined #bitcoin-core-dev
199 2017-11-08T12:18:40  *** Khunbish has quit IRC
200 2017-11-08T12:23:05  *** shesek has quit IRC
201 2017-11-08T12:26:17  *** shesek has joined #bitcoin-core-dev
202 2017-11-08T13:03:30  *** promag has quit IRC
203 2017-11-08T13:14:41  <instagibbs> achow101, same issue for months locally
204 2017-11-08T13:15:11  <instagibbs> "glad" im not the only one
205 2017-11-08T13:20:42  *** promag has joined #bitcoin-core-dev
206 2017-11-08T13:21:36  <morcos> can you guys open an issue or something for these test failures.  they should not be failing.  they can be annoying to debug, but i feel like we are slowly improving them so lets not become immune to failures
207 2017-11-08T13:35:16  <jnewbery> #11468 should make comp test framework tests more debuggable (and we should remove them entirely at some point)
208 2017-11-08T13:35:17  <gribble> https://github.com/bitcoin/bitcoin/issues/11468 | [tests] Make comp test framework more debuggable by jnewbery · Pull Request #11468 · bitcoin/bitcoin · GitHub
209 2017-11-08T13:37:28  <luke-jr> I noticed timeouts give a useless assertion error with regard to times.. I wonder what it would take to have the message describe the actual condition
210 2017-11-08T13:38:48  <luke-jr> (otoh, the traceback typically includes that, so not a huge deal)
211 2017-11-08T13:39:46  *** promag has quit IRC
212 2017-11-08T13:41:50  *** btcdrak has joined #bitcoin-core-dev
213 2017-11-08T13:44:01  <jnewbery> luke-jr: yeah, it's buried in there, but assert message could def be improved
214 2017-11-08T13:45:17  <luke-jr> just not sure how to do that kind of thing with Python. I guess catch it and analyze the traceback object to get info to re-throw with?
215 2017-11-08T13:50:24  *** meshcollider has quit IRC
216 2017-11-08T13:51:19  *** Gnof has joined #bitcoin-core-dev
217 2017-11-08T13:52:52  *** Giszmo1 has joined #bitcoin-core-dev
218 2017-11-08T14:00:19  *** Giszmo has quit IRC
219 2017-11-08T14:00:19  *** Giszmo1 has quit IRC
220 2017-11-08T14:02:55  *** Giszmo has joined #bitcoin-core-dev
221 2017-11-08T14:03:01  <jnewbery> correct. That's possible with traceback: https://docs.python.org/3/library/traceback.html
222 2017-11-08T14:12:36  *** Ylbam has quit IRC
223 2017-11-08T14:19:09  *** Manoj_ has joined #bitcoin-core-dev
224 2017-11-08T14:23:40  *** Manoj_ has quit IRC
225 2017-11-08T14:25:18  *** xinxi has quit IRC
226 2017-11-08T14:25:51  *** xinxi has joined #bitcoin-core-dev
227 2017-11-08T14:31:04  *** Khunbish has joined #bitcoin-core-dev
228 2017-11-08T14:31:18  *** jb55 has joined #bitcoin-core-dev
229 2017-11-08T14:39:37  *** jb55 has quit IRC
230 2017-11-08T14:39:42  *** Khunbish has quit IRC
231 2017-11-08T14:40:08  *** jb55 has joined #bitcoin-core-dev
232 2017-11-08T14:40:51  *** Khunbish has joined #bitcoin-core-dev
233 2017-11-08T14:44:39  *** promag has joined #bitcoin-core-dev
234 2017-11-08T14:46:48  *** laurentmt has quit IRC
235 2017-11-08T14:48:42  *** laurentmt has joined #bitcoin-core-dev
236 2017-11-08T14:57:15  *** MrPaz has joined #bitcoin-core-dev
237 2017-11-08T15:13:17  *** jb55 has quit IRC
238 2017-11-08T15:15:22  *** adetate has joined #bitcoin-core-dev
239 2017-11-08T15:17:34  <MarcoFalke> re: test failure. Agree that an issue should be opened in case the fix is not trivial.
240 2017-11-08T15:18:19  <MarcoFalke> Also, the command line switch to jump into pdb only works on shutdown/teardown of nodes
241 2017-11-08T15:18:34  *** AaronvanW has joined #bitcoin-core-dev
242 2017-11-08T15:18:36  <MarcoFalke> Currently not possible where the assertion hits, iirc
243 2017-11-08T15:27:18  *** arubi has quit IRC
244 2017-11-08T15:27:18  *** zshlyk has quit IRC
245 2017-11-08T15:27:18  *** dermoth has quit IRC
246 2017-11-08T15:27:18  *** ghost43 has quit IRC
247 2017-11-08T15:31:37  *** shesek has quit IRC
248 2017-11-08T15:32:13  *** jtimon has joined #bitcoin-core-dev
249 2017-11-08T15:33:23  *** zshlyk has joined #bitcoin-core-dev
250 2017-11-08T15:34:08  *** ghost43 has joined #bitcoin-core-dev
251 2017-11-08T15:34:16  *** arubi has joined #bitcoin-core-dev
252 2017-11-08T15:37:14  *** promag has quit IRC
253 2017-11-08T15:39:09  *** Aaronvan_ has joined #bitcoin-core-dev
254 2017-11-08T15:42:53  *** AaronvanW has quit IRC
255 2017-11-08T15:43:01  *** Khunbish has quit IRC
256 2017-11-08T15:44:52  *** shesek has joined #bitcoin-core-dev
257 2017-11-08T15:44:52  *** shesek has joined #bitcoin-core-dev
258 2017-11-08T15:47:58  *** Guest3097 has joined #bitcoin-core-dev
259 2017-11-08T15:54:13  *** Guest3097 has quit IRC
260 2017-11-08T15:56:43  *** promag has joined #bitcoin-core-dev
261 2017-11-08T15:59:10  *** arubi has quit IRC
262 2017-11-08T15:59:27  *** Aaronvan_ has quit IRC
263 2017-11-08T15:59:31  *** arubi has joined #bitcoin-core-dev
264 2017-11-08T16:01:37  *** btcdrak has quit IRC
265 2017-11-08T16:20:42  *** promag has quit IRC
266 2017-11-08T16:24:22  *** quantbot has joined #bitcoin-core-dev
267 2017-11-08T16:24:32  *** quantbot_ has quit IRC
268 2017-11-08T16:24:49  <BlueMatt> luke-jr: care to close #10593 or at least provide some justification? there were objections about it in principal and you didn't materially address them or explain what the pr was even trying to do.....
269 2017-11-08T16:24:52  <gribble> https://github.com/bitcoin/bitcoin/issues/10593 | Relax punishment for peers relaying invalid blocks and headers by luke-jr · Pull Request #10593 · bitcoin/bitcoin · GitHub
270 2017-11-08T16:26:54  *** AaronvanW has joined #bitcoin-core-dev
271 2017-11-08T16:31:28  *** goatpig has joined #bitcoin-core-dev
272 2017-11-08T16:33:02  *** AaronvanW has quit IRC
273 2017-11-08T16:53:31  *** LumberCartel has quit IRC
274 2017-11-08T17:00:21  *** shesek has quit IRC
275 2017-11-08T17:03:13  *** shesek has joined #bitcoin-core-dev
276 2017-11-08T17:03:14  *** shesek has joined #bitcoin-core-dev
277 2017-11-08T17:05:26  <luke-jr> BlueMatt: the ONLY objection I see there is Suhas assuming it reverts 8305, which isn't "in principle" and isn't even true..
278 2017-11-08T17:07:01  <luke-jr> elaborated a bit on the OP description
279 2017-11-08T17:08:47  *** adetate has quit IRC
280 2017-11-08T17:10:36  *** kkode has joined #bitcoin-core-dev
281 2017-11-08T17:10:37  *** bule2 has joined #bitcoin-core-dev
282 2017-11-08T17:14:38  *** Khunbish has joined #bitcoin-core-dev
283 2017-11-08T17:14:45  *** MrPaz has quit IRC
284 2017-11-08T17:15:57  *** shesek has quit IRC
285 2017-11-08T17:25:58  *** MrPaz has joined #bitcoin-core-dev
286 2017-11-08T17:36:56  *** tux3do has joined #bitcoin-core-dev
287 2017-11-08T17:39:19  *** MrPaz has quit IRC
288 2017-11-08T17:40:29  *** AaronvanW has joined #bitcoin-core-dev
289 2017-11-08T17:40:57  *** BashCo has quit IRC
290 2017-11-08T17:41:33  *** BashCo has joined #bitcoin-core-dev
291 2017-11-08T17:46:17  *** BashCo has quit IRC
292 2017-11-08T17:46:52  *** kkode has quit IRC
293 2017-11-08T17:48:33  *** Gnof has quit IRC
294 2017-11-08T17:53:14  *** quantbot_ has joined #bitcoin-core-dev
295 2017-11-08T17:53:14  *** quantbot has quit IRC
296 2017-11-08T17:56:19  *** quantbot has joined #bitcoin-core-dev
297 2017-11-08T17:57:21  *** quantbot_ has quit IRC
298 2017-11-08T18:00:15  *** BashCo has joined #bitcoin-core-dev
299 2017-11-08T18:01:47  *** jb55 has joined #bitcoin-core-dev
300 2017-11-08T18:04:16  *** Aaronvan_ has joined #bitcoin-core-dev
301 2017-11-08T18:04:56  *** pbase has joined #bitcoin-core-dev
302 2017-11-08T18:06:01  *** ExtraCrispy has joined #bitcoin-core-dev
303 2017-11-08T18:06:49  *** meshcollider has joined #bitcoin-core-dev
304 2017-11-08T18:07:04  <karelb> Is 0.15.1 "canceled" now? :)
305 2017-11-08T18:07:21  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/77546a3182e5...0a2f46b0158b
306 2017-11-08T18:07:22  <bitcoin-git> bitcoin/master 7536b08 practicalswift: trivial: Fix typo – alreardy → already
307 2017-11-08T18:07:22  <bitcoin-git> bitcoin/master 0a2f46b MarcoFalke: Merge #11635: trivial: Fix typo – alreardy → already...
308 2017-11-08T18:07:52  *** AaronvanW has quit IRC
309 2017-11-08T18:08:13  *** Arokh has joined #bitcoin-core-dev
310 2017-11-08T18:08:50  *** Chris_Stewart_5 has joined #bitcoin-core-dev
311 2017-11-08T18:09:48  <meshcollider> karelb: cancelled? Why?
312 2017-11-08T18:09:51  <luke-jr> karelb: meh, might as well get bugfixes out
313 2017-11-08T18:09:55  <luke-jr> meshcollider: 2X aborted
314 2017-11-08T18:10:09  <meshcollider> What really :O yay!
315 2017-11-08T18:10:16  <Chris_Stewart_5> ... so is segwit support wallet support back on the menu for 0.15.1?? :P
316 2017-11-08T18:10:31  <luke-jr> meshcollider: https://lists.linuxfoundation.org/pipermail/bitcoin-segwit2x/2017-November/000685.html
317 2017-11-08T18:10:55  <meshcollider> Only just woke up, excellent start to the day \o/
318 2017-11-08T18:11:07  <gmaxwell> lol
319 2017-11-08T18:11:15  <gmaxwell> there are other fixes in 0.15.1
320 2017-11-08T18:11:24  *** MrPaz has joined #bitcoin-core-dev
321 2017-11-08T18:11:37  <karelb> yeah I saw the backports list :)
322 2017-11-08T18:12:04  <gmaxwell> also, there is no guarentee that B2X won't fork anyways, it might not be completely centeralized.
323 2017-11-08T18:12:46  <Chris_Stewart_5> it will be interesting to see how fast the node count drops
324 2017-11-08T18:12:50  <luke-jr> gmaxwell: lol
325 2017-11-08T18:14:19  <gmaxwell> last three blocks still "NYA" signaling.
326 2017-11-08T18:14:43  <sipa> asia is asleep
327 2017-11-08T18:14:51  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a2f46b0158b...f7388e93d3dd
328 2017-11-08T18:14:52  <bitcoin-git> bitcoin/master b86c1cd John Newbery: [tests] fix TestNode.__getattr__() method
329 2017-11-08T18:14:53  <bitcoin-git> bitcoin/master 5e5725c John Newbery: [tests] Add p2p connection to TestNode...
330 2017-11-08T18:14:53  <bitcoin-git> bitcoin/master 32ae82f John Newbery: [tests] use TestNode p2p connection in tests
331 2017-11-08T18:14:59  <sipa> also, no reason to cancel the 0.15.1 release which is already in RC
332 2017-11-08T18:15:11  <sipa> though decision is up to wumpus i'd say
333 2017-11-08T18:15:16  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11182: [tests] Add P2P interface to TestNode (master...test_node_p2p) https://github.com/bitcoin/bitcoin/pull/11182
334 2017-11-08T18:15:18  <MarcoFalke> Is there be going to be a 15.2?
335 2017-11-08T18:15:54  <gmaxwell> I'm still in favor of 0.15.1 though I do think the urgency is reduced a little.
336 2017-11-08T18:16:04  <Chris_Stewart_5> MarcoFalke: It was my understanding that is the release for segwit wallet support because of s2x stuff
337 2017-11-08T18:16:48  <jnewbery> I reckon the improvements in v0.15.1 are helpful to fortify against any hostile hard fork. Si vis pacem, para bellum.
338 2017-11-08T18:16:58  <luke-jr> I thought we moved it to an early 0.16 *shrug*
339 2017-11-08T18:17:16  <MarcoFalke> Yeah. 15.1 has other bugfixes in as well. Though, not all that I liked to put in
340 2017-11-08T18:17:23  <MarcoFalke> We should get it out ntl
341 2017-11-08T18:17:39  <sipa> luke-jr: undecided in last meeting, but i think that's a reasonable thing to do - push 0.16 forward a bit rather than a 0.15.2 in between
342 2017-11-08T18:18:40  <gmaxwell> I hope a lot rather than a bit. :)
343 2017-11-08T18:18:47  <gmaxwell> that would be pretty awesome.
344 2017-11-08T18:20:26  <MarcoFalke> Can move it at most 1 or 2 months ahead. Moving it to december would be way too rushed, imo
345 2017-11-08T18:22:14  <aj> is it bringing 0.16 features forward or renaming 0.15.2 as 0.16 and 0.16 as 0.17?
346 2017-11-08T18:23:01  <luke-jr> meh, when it's ready it's ready..?
347 2017-11-08T18:23:04  <luke-jr> aj: IMO the latter
348 2017-11-08T18:26:30  <aj> MarcoFalke: 0.16 timeline has two months for translations, that seems like it puts an absolute minimum? ie, make the decision on friday, open translations this month some time, then no release prior to mid january?
349 2017-11-08T18:26:53  <MarcoFalke> aj: Segwit wallet review/testing is still needed
350 2017-11-08T18:28:29  <aj> MarcoFalke: yeah. and needed prior to merging and hence prior to translations?
351 2017-11-08T18:29:26  <MarcoFalke> ideally
352 2017-11-08T18:32:55  *** ula has quit IRC
353 2017-11-08T18:39:27  *** daljeet has joined #bitcoin-core-dev
354 2017-11-08T18:40:44  *** ula has joined #bitcoin-core-dev
355 2017-11-08T18:41:36  <bitcoin-git> [bitcoin] MarcoFalke opened pull request #11637: Remove dead service bits code (master...Mf1711-p2pDead) https://github.com/bitcoin/bitcoin/pull/11637
356 2017-11-08T18:41:55  *** daljeet has quit IRC
357 2017-11-08T18:47:21  *** laurentmt has quit IRC
358 2017-11-08T18:47:48  *** chjj has joined #bitcoin-core-dev
359 2017-11-08T18:50:31  *** kambinghitam has joined #bitcoin-core-dev
360 2017-11-08T18:52:09  *** Aaronvan_ has quit IRC
361 2017-11-08T18:52:40  *** bule2 has quit IRC
362 2017-11-08T18:55:37  *** SopaXorzTaker has quit IRC
363 2017-11-08T18:58:32  *** SopaXorzTaker has joined #bitcoin-core-dev
364 2017-11-08T18:59:58  *** kambinghitam has quit IRC
365 2017-11-08T19:00:35  *** Chris_Stewart_5 has quit IRC
366 2017-11-08T19:02:22  *** timothy has quit IRC
367 2017-11-08T19:02:39  <gmaxwell> MarcoFalke: there are thousands of b2x nodes that will go off in space still, and also still make bcash nodes that are off in space.
368 2017-11-08T19:02:54  <gmaxwell> MarcoFalke: so I don't think removing the service flag thing makes sense.
369 2017-11-08T19:02:58  <gmaxwell> unless I'm missing something.
370 2017-11-08T19:03:20  <achow101> gmaxwell: for 0.16, not 0.15.x I think
371 2017-11-08T19:03:28  <achow101> hopefully they'll be gone by then
372 2017-11-08T19:03:33  *** kambinghitam has joined #bitcoin-core-dev
373 2017-11-08T19:03:51  <gmaxwell> they're not gone yet, and if they're not by then we need to add it back. Plus people run master.
374 2017-11-08T19:03:55  <gmaxwell> (some people)
375 2017-11-08T19:04:01  <MarcoFalke> Jup, this is meant for 0.16. We can merge it in a couple of weeks. That should be fine, no?
376 2017-11-08T19:04:26  *** ula has quit IRC
377 2017-11-08T19:04:29  *** kambinghitam has quit IRC
378 2017-11-08T19:04:32  <gmaxwell> I don't expect it'll make it for 0.16.  There are still hundreds of bcash nodes that use the old magic.
379 2017-11-08T19:04:41  <gmaxwell> no harm in having a pull req, I suppose.
380 2017-11-08T19:05:31  <achow101> maybe we should hold off on that until shortly before 0.16 and re-evaluate then
381 2017-11-08T19:05:35  *** AaronvanW has joined #bitcoin-core-dev
382 2017-11-08T19:06:36  *** ula has joined #bitcoin-core-dev
383 2017-11-08T19:07:05  <cfields> oh, commented on the PR before i saw the discussion here. Agree it's too early for that.
384 2017-11-08T19:08:28  *** ExtraCrispy has quit IRC
385 2017-11-08T19:09:56  *** adetate has joined #bitcoin-core-dev
386 2017-11-08T19:10:52  *** chjj has quit IRC
387 2017-11-08T19:14:46  *** SopaXorzTaker has quit IRC
388 2017-11-08T19:28:39  *** promag has joined #bitcoin-core-dev
389 2017-11-08T19:30:15  *** bule has joined #bitcoin-core-dev
390 2017-11-08T19:31:45  *** bule2 has joined #bitcoin-core-dev
391 2017-11-08T19:31:54  *** bule has quit IRC
392 2017-11-08T19:31:57  *** bule2 is now known as bule
393 2017-11-08T19:32:36  *** promag has quit IRC
394 2017-11-08T19:36:35  <achow101> can we remove the "good first issue" tag from the release schedule issue? It apparently confuses the people that I talk to about how they can start contributing to core
395 2017-11-08T19:38:46  <sdaftuar> luke-jr: regarding #10593 -- as i read the code, a peer serving a header that doesn't connect will be assigned 20 dos points.  is that correct?
396 2017-11-08T19:38:48  <gribble> https://github.com/bitcoin/bitcoin/issues/10593 | Relax punishment for peers relaying invalid blocks and headers by luke-jr · Pull Request #10593 · bitcoin/bitcoin · GitHub
397 2017-11-08T19:40:38  <sdaftuar> luke-jr: actually, scratch that (i just looked at it again)
398 2017-11-08T19:40:53  <sdaftuar> luke-jr: an outbound peer that serves a header that doesn't connect will be disconnected?
399 2017-11-08T19:41:04  <luke-jr> sdaftuar: right
400 2017-11-08T19:41:38  <luke-jr> we want our outbound peers to always be on the same chain ideally
401 2017-11-08T19:41:45  <sdaftuar> so in particular someone mining a block 2 hours ahead can split the network
402 2017-11-08T19:42:34  <luke-jr> disconnecting outbound peers only should never split the network, am I wrong?
403 2017-11-08T19:44:11  <sdaftuar> i think, at the least, that being so aggressive is risky
404 2017-11-08T19:45:54  <luke-jr> it might make sense to be softer on the time rule I guessw
405 2017-11-08T19:46:41  <luke-jr> not sure that's related to this PR though
406 2017-11-08T19:47:02  <sdaftuar> the point of that unconnecting headers PR was to avoid (eventual) disconnection in the situation where peers weren't on an incompatible chain
407 2017-11-08T19:47:09  <sdaftuar> that's why i called your PR a reversion of that logic
408 2017-11-08T19:47:40  <luke-jr> it only disconnects when the peer *is* on an incompatible chain, though?
409 2017-11-08T19:47:51  <sdaftuar> i don't think so?  it disconnects if they serve a header that doesn't connect
410 2017-11-08T19:47:56  <sdaftuar> which could be for a number of reasons
411 2017-11-08T19:48:04  <sdaftuar> including the intermediate block being just over 2 hrs in the future
412 2017-11-08T19:48:16  <sdaftuar> or because they sent a header when they shoudl have sent an inv or something
413 2017-11-08T19:48:32  <sdaftuar> which is a p2p error, not a consensus error
414 2017-11-08T19:49:12  *** neep3r has joined #bitcoin-core-dev
415 2017-11-08T19:49:28  <luke-jr> not sure disconnecting for p2p errors is a bad thing; are there any cases where it's neither a p2p issue nor a consensus error (which the 2h limit kindof is)?
416 2017-11-08T19:49:35  <sdaftuar> but the original way i saw this was on testnet, where a peer using headers announcements for blocks (eg via the sendheaders p2p protocol) would announce a block, via header, that didn't connect, because the prior block was on the wrong side of the 2hr rule
417 2017-11-08T19:49:37  <luke-jr> and don't we disconnect after N such headers anyway already?
418 2017-11-08T19:50:19  <sdaftuar> we do, but we set N to be big-ish to account for this occasionally happening iirc
419 2017-11-08T19:50:59  <sdaftuar> the thing that scares me is if an attacker can get us to disconnect an outbound peer
420 2017-11-08T19:51:11  <sdaftuar> i mean, disconnect an outbound peer for spurious reasons
421 2017-11-08T19:51:20  <sdaftuar> because that makes us more vulnerable to sybil attack
422 2017-11-08T19:51:28  <luke-jr> hmm
423 2017-11-08T19:53:58  *** tux3do has quit IRC
424 2017-11-08T19:54:07  *** jb55 has quit IRC
425 2017-11-08T19:54:08  <luke-jr> sdaftuar: can you think of any cases besides the time one this might be an issue for?
426 2017-11-08T19:54:09  *** neep3r is now known as tux3do
427 2017-11-08T19:57:57  *** AndBobsYourUncle has joined #bitcoin-core-dev
428 2017-11-08T19:57:58  <sdaftuar> well i think matt hated the idea that peers couldn't just switch to announcing everything via header, rather than having to send an inv if they weren't sure the header would connect
429 2017-11-08T19:58:10  <sdaftuar> the idea that we might disconnect a peer for an unconnecting header is an undocumented p2p behavior
430 2017-11-08T19:58:27  *** pbase has quit IRC
431 2017-11-08T19:58:56  <sdaftuar> so i think it's sort of a question of how the p2p layer ought to work, and what we should tolerate
432 2017-11-08T20:03:22  *** bule has quit IRC
433 2017-11-08T20:03:49  *** bule has joined #bitcoin-core-dev
434 2017-11-08T20:12:24  *** AaronvanW has quit IRC
435 2017-11-08T20:13:51  *** roasbeef has quit IRC
436 2017-11-08T20:14:02  *** hg_ has joined #bitcoin-core-dev
437 2017-11-08T20:15:27  *** jtimon has quit IRC
438 2017-11-08T20:17:22  <luke-jr> sdaftuar: so long as you know your peers have header X, sending X+1, X+2, etc should be safe so long as they're on the same chain?
439 2017-11-08T20:17:30  <luke-jr> (and if they're not, you don't want them as a primary peer)
440 2017-11-08T20:18:34  <sdaftuar> i'm not sure i understand your question, but i think the answer is yes. can you remind me what case you're concerned about addressing?
441 2017-11-08T20:18:48  *** hg_ is now known as hnfgns
442 2017-11-08T20:19:21  <sdaftuar> i think the recently merged PRs for 0.15.1 address all the cases of bad outbound peer that i was able to come up with, with the goal of ensuring that not all of the outbound peers are on bogus chains
443 2017-11-08T20:19:46  <sdaftuar> (i'm actually working on a document now that explains all the cases and our logic, which i can share when i'm done)
444 2017-11-08T20:20:12  *** bule has quit IRC
445 2017-11-08T20:20:37  *** bule has joined #bitcoin-core-dev
446 2017-11-08T20:20:53  *** Chris_Stewart_5 has joined #bitcoin-core-dev
447 2017-11-08T20:22:40  *** AndBobsYourUncle has quit IRC
448 2017-11-08T20:24:07  *** AaronvanW has joined #bitcoin-core-dev
449 2017-11-08T20:24:58  *** jtimon has joined #bitcoin-core-dev
450 2017-11-08T20:25:23  *** Ylbam has joined #bitcoin-core-dev
451 2017-11-08T20:25:59  *** clarkmoody has joined #bitcoin-core-dev
452 2017-11-08T20:26:51  *** AndBobsYourUncle has joined #bitcoin-core-dev
453 2017-11-08T20:31:08  *** bule has quit IRC
454 2017-11-08T20:31:43  *** bule has joined #bitcoin-core-dev
455 2017-11-08T20:32:27  *** promag has joined #bitcoin-core-dev
456 2017-11-08T20:32:38  *** hnfgns has quit IRC
457 2017-11-08T20:33:17  *** hnfgns has joined #bitcoin-core-dev
458 2017-11-08T20:33:35  <luke-jr> sdaftuar: "This is necessary to avoid banning peers that merely run old formerly-full nodes, after a softfork. We disconnect primary peers because we want compatible full nodes for that role, but allow non-full nodes to remain connected to inbound slots so they can sync the correct chain from us."
459 2017-11-08T20:34:03  *** LumberCartel has joined #bitcoin-core-dev
460 2017-11-08T20:34:25  *** JackH has joined #bitcoin-core-dev
461 2017-11-08T20:34:33  <luke-jr> I suppose there's no reason we couldn't leave the counter in too.
462 2017-11-08T20:34:40  *** tux3do has quit IRC
463 2017-11-08T20:36:02  *** bule has quit IRC
464 2017-11-08T20:36:25  *** bule has joined #bitcoin-core-dev
465 2017-11-08T20:38:21  *** LumberCartel has quit IRC
466 2017-11-08T20:41:37  *** promag has quit IRC
467 2017-11-08T20:47:22  *** cheese_ has joined #bitcoin-core-dev
468 2017-11-08T20:48:21  *** ekrion has quit IRC
469 2017-11-08T20:50:27  *** ekrion has joined #bitcoin-core-dev
470 2017-11-08T20:51:05  *** jtimon has quit IRC
471 2017-11-08T20:57:54  *** wunpunch has joined #bitcoin-core-dev
472 2017-11-08T20:59:02  <sdaftuar> luke-jr: ok yes, i agree with that objective (sorry i haven't paged in your PR in a while). i will try to take a look with fresh eyes, i've lost track a little of where we are (i seem to recall some other PRs that try to address this as well)
473 2017-11-08T21:00:23  <sdaftuar> to rephrase -- i think we have enough protection in place for outbound peers now (to ensure that we're not solely connected to bogus outbound peers).  but we can do more to protect inbound peers from disconnection, eg in the event that they are unaware of a softfork
474 2017-11-08T21:03:49  *** hnfgns has quit IRC
475 2017-11-08T21:04:03  *** hnfgns has joined #bitcoin-core-dev
476 2017-11-08T21:04:04  *** adetate has quit IRC
477 2017-11-08T21:07:02  *** RoyceX has joined #bitcoin-core-dev
478 2017-11-08T21:07:28  *** jb55 has joined #bitcoin-core-dev
479 2017-11-08T21:09:52  *** cheese_ has quit IRC
480 2017-11-08T21:15:30  *** AaronvanW has quit IRC
481 2017-11-08T21:19:39  <BlueMatt> luke-jr: you might consider rebasing on #11639
482 2017-11-08T21:19:40  <gribble> https://github.com/bitcoin/bitcoin/issues/11639 | Rewrite the interface between validation and net_processing wrt DoS by TheBlueMatt · Pull Request #11639 · bitcoin/bitcoin · GitHub
483 2017-11-08T21:20:03  <BlueMatt> then you get nice things like invalid reasons (including SOFT_FORK and BAD_TIME) so you can avoid splitting the network
484 2017-11-08T21:20:16  <BlueMatt> plus the resulting pr will be much clearer
485 2017-11-08T21:26:24  *** Chris_Stewart_5 has quit IRC
486 2017-11-08T21:34:50  *** p3scobar has joined #bitcoin-core-dev
487 2017-11-08T21:34:58  <p3scobar> Roger, you in here?
488 2017-11-08T21:35:32  *** p3scobar has quit IRC
489 2017-11-08T21:35:55  *** AaronvanW has joined #bitcoin-core-dev
490 2017-11-08T21:43:27  *** hnfgns has quit IRC
491 2017-11-08T21:45:35  *** lxer has joined #bitcoin-core-dev
492 2017-11-08T21:45:44  *** hnfgns has joined #bitcoin-core-dev
493 2017-11-08T21:48:29  *** MrPaz has quit IRC
494 2017-11-08T21:50:12  *** AndBobsYourUncle has quit IRC
495 2017-11-08T21:53:21  *** LumberCartel has joined #bitcoin-core-dev
496 2017-11-08T21:56:50  *** wunpunch has quit IRC
497 2017-11-08T21:59:33  *** StopAndDecrypt has quit IRC
498 2017-11-08T22:04:10  *** Chris_Stewart_5 has joined #bitcoin-core-dev
499 2017-11-08T22:04:13  *** StopAndDecrypt has joined #bitcoin-core-dev
500 2017-11-08T22:06:53  *** chjj has joined #bitcoin-core-dev
501 2017-11-08T22:11:52  *** RoyceX has quit IRC
502 2017-11-08T22:12:25  *** RoyceX has joined #bitcoin-core-dev
503 2017-11-08T22:16:31  *** meshcollider has quit IRC
504 2017-11-08T22:16:37  *** promag has joined #bitcoin-core-dev
505 2017-11-08T22:20:52  *** RoyceX has quit IRC
506 2017-11-08T22:24:50  <luke-jr> BlueMatt: from the description, I wonder if 11639 makes 10593 unnecessary
507 2017-11-08T22:25:04  <BlueMatt> it might, i still dont fully understand 10593
508 2017-11-08T22:25:12  <BlueMatt> but 11639 (mostly) doesnt change behavior
509 2017-11-08T22:25:26  <luke-jr> BlueMatt: the goal of 10593 is essentially to not ban pre-softfork nodes
510 2017-11-08T22:25:55  <BlueMatt> I doubt its fully fixed by 11639, but I dont know exactly which case you're handling differently there
511 2017-11-08T22:30:39  *** Cogito_Ergo_Sum has quit IRC
512 2017-11-08T22:30:51  <promag> ryanofsky: ping
513 2017-11-08T22:31:50  <ryanofsky> i'm here
514 2017-11-08T22:32:12  <promag> does the qt test timeout?
515 2017-11-08T22:32:48  <promag> if one callback stays pending
516 2017-11-08T22:34:03  <ryanofsky> it will hang if an expected signal never arrives
517 2017-11-08T22:34:37  <ryanofsky> existing wallettests also does this, probably there should be a global test timeout
518 2017-11-08T22:35:05  <promag> ok, something to improve later if relevant
519 2017-11-08T22:36:32  *** boreddanman has joined #bitcoin-core-dev
520 2017-11-08T22:37:55  *** spinza has quit IRC
521 2017-11-08T22:38:34  <boreddanman> Hey all, my name is Dan, and I'm a software engineer & crypto analyst. Figured i'd stop by the dev chat to see what's cookin'
522 2017-11-08T22:39:02  <BlueMatt> not much, usually, usually pretty quiet unless people are talking about specific things - keeps the backlog short so folks can stay caught up easily
523 2017-11-08T22:40:03  <boreddanman> gotchya. any other channels i should check out?
524 2017-11-08T22:41:43  <BlueMatt> #bitcoin is more active, #bitcoin-wizards is occasionally interesting
525 2017-11-08T22:43:47  *** Chris_Stewart_5 has quit IRC
526 2017-11-08T22:44:06  *** hnfgns has quit IRC
527 2017-11-08T22:48:07  *** AndBobsYourUncle has joined #bitcoin-core-dev
528 2017-11-08T22:48:19  *** xinxi has quit IRC
529 2017-11-08T22:48:52  *** xinxi has joined #bitcoin-core-dev
530 2017-11-08T22:50:31  *** CubicEarth has joined #bitcoin-core-dev
531 2017-11-08T22:51:11  *** hnfgns has joined #bitcoin-core-dev
532 2017-11-08T22:54:29  *** promag has quit IRC
533 2017-11-08T22:55:08  *** bule has quit IRC
534 2017-11-08T22:56:50  *** MrPaz has joined #bitcoin-core-dev
535 2017-11-08T22:57:14  *** Chris_Stewart_5 has joined #bitcoin-core-dev
536 2017-11-08T22:57:23  *** promag has joined #bitcoin-core-dev
537 2017-11-08T22:59:12  *** hnfgns has quit IRC
538 2017-11-08T23:01:52  *** promag has quit IRC
539 2017-11-08T23:03:07  *** Khunbish has quit IRC
540 2017-11-08T23:11:21  *** spinza has joined #bitcoin-core-dev
541 2017-11-08T23:11:51  *** bule has joined #bitcoin-core-dev
542 2017-11-08T23:13:24  *** Cheeseo has joined #bitcoin-core-dev
543 2017-11-08T23:15:45  *** Victor_sueca has joined #bitcoin-core-dev
544 2017-11-08T23:16:28  *** fanquake has joined #bitcoin-core-dev
545 2017-11-08T23:18:12  *** Cheeseo has quit IRC
546 2017-11-08T23:18:25  *** Victorsueca has quit IRC
547 2017-11-08T23:19:32  <fanquake> morcos see #11632
548 2017-11-08T23:19:33  <gribble> https://github.com/bitcoin/bitcoin/issues/11632 | p2p-fullblocktest.py fails occasionally · Issue #11632 · bitcoin/bitcoin · GitHub
549 2017-11-08T23:19:44  *** fanquake has quit IRC
550 2017-11-08T23:20:38  *** AaronvanW has quit IRC
551 2017-11-08T23:21:05  *** hnfgns has joined #bitcoin-core-dev
552 2017-11-08T23:24:37  *** Chris_Stewart_5 has quit IRC
553 2017-11-08T23:26:28  *** CubicEarth has quit IRC
554 2017-11-08T23:28:29  *** hellocoin has joined #bitcoin-core-dev
555 2017-11-08T23:30:21  *** hellocoin has quit IRC
556 2017-11-08T23:46:07  *** quantbot_ has joined #bitcoin-core-dev
557 2017-11-08T23:46:07  *** quantbot has quit IRC
558 2017-11-08T23:47:30  *** quantbot has joined #bitcoin-core-dev
559 2017-11-08T23:49:21  *** bule2 has joined #bitcoin-core-dev
560 2017-11-08T23:49:30  *** Victor_sueca is now known as Victorsueca
561 2017-11-08T23:50:21  *** quantbot_ has quit IRC
562 2017-11-08T23:52:31  *** bule2 has quit IRC
563 2017-11-08T23:54:39  *** AndBobsYourUncle has quit IRC
564 2017-11-08T23:57:00  *** mxg has joined #bitcoin-core-dev
565 2017-11-08T23:58:45  *** promag has joined #bitcoin-core-dev