1 2017-11-15T00:03:03  *** jsfour has left #bitcoin-core-dev
  2 2017-11-15T00:03:17  *** jsfour has joined #bitcoin-core-dev
  3 2017-11-15T00:11:57  *** ghost43 has quit IRC
  4 2017-11-15T00:17:42  *** ghost43 has joined #bitcoin-core-dev
  5 2017-11-15T00:25:43  *** jsfour has quit IRC
  6 2017-11-15T00:30:03  *** LumberCartel has quit IRC
  7 2017-11-15T00:30:32  *** jsfour has joined #bitcoin-core-dev
  8 2017-11-15T00:32:08  *** MrPaz has quit IRC
  9 2017-11-15T00:53:36  *** fanquake has quit IRC
 10 2017-11-15T00:57:56  *** dabura667 has joined #bitcoin-core-dev
 11 2017-11-15T00:59:01  *** bule has quit IRC
 12 2017-11-15T01:03:39  *** bule has joined #bitcoin-core-dev
 13 2017-11-15T01:04:29  *** Cheeseo has quit IRC
 14 2017-11-15T01:06:14  *** LumberCartel has joined #bitcoin-core-dev
 15 2017-11-15T01:09:52  *** wunpunch has quit IRC
 16 2017-11-15T01:13:27  *** LumberCartel has quit IRC
 17 2017-11-15T01:14:20  *** dermoth has quit IRC
 18 2017-11-15T01:39:05  *** LumberCartel has joined #bitcoin-core-dev
 19 2017-11-15T01:44:19  *** MrPaz has joined #bitcoin-core-dev
 20 2017-11-15T01:47:34  *** MrPaz has quit IRC
 21 2017-11-15T01:52:21  *** dermoth has joined #bitcoin-core-dev
 22 2017-11-15T01:53:27  *** LumberCartel has quit IRC
 23 2017-11-15T01:53:29  *** LumberCartel_ has joined #bitcoin-core-dev
 24 2017-11-15T01:53:36  *** dermoth has joined #bitcoin-core-dev
 25 2017-11-15T01:58:01  *** LumberCartel_ has quit IRC
 26 2017-11-15T02:07:09  *** harrymm has quit IRC
 27 2017-11-15T02:10:49  *** harrymm has joined #bitcoin-core-dev
 28 2017-11-15T02:11:06  *** Tatty has joined #bitcoin-core-dev
 29 2017-11-15T02:19:27  *** Ylbam has quit IRC
 30 2017-11-15T02:19:44  <Tatty> I think I found an outdated version User Agent on Bitcoin Core 64 bit for Windows v0.15.0.1.  I enabled 2 tor proxies, both making bidirectional connections. It happened one of the proxies contacted the other, and that's when I saw a wrong version: User Agent /Satoshi:0.14.0/
 31 2017-11-15T02:20:28  <sipa> why is that wrong?
 32 2017-11-15T02:21:02  <Tatty> I am sure because I recognize the Hidden Service, of the income connection, it is mine
 33 2017-11-15T02:21:26  <gmaxwell> Tatty: what reason do you have to believe it wasn't some other node connecting to you.
 34 2017-11-15T02:21:27  <sipa> you can't know where an hidden service connection is coming from
 35 2017-11-15T02:21:32  *** bule has quit IRC
 36 2017-11-15T02:21:56  <gmaxwell> gives a correct useragent, so either that connection wasn't from you or you're not running what you think you are. :)
 37 2017-11-15T02:22:56  <Tatty> it says on top via and then my hidden service
 38 2017-11-15T02:26:07  <Tatty> is it possible the user agent is only wrong one one of them when using 2 tor proxies?
 39 2017-11-15T02:26:34  <Tatty> and I am sorry for insisting
 40 2017-11-15T02:26:39  <sipa> what do you mean by 2 tor proxies?
 41 2017-11-15T02:26:44  <sipa> you can only configure oe
 42 2017-11-15T02:26:46  <sipa> one
 43 2017-11-15T02:27:42  <Tatty> I run 2 different ptor proxies as allowed by Bitcoin Core
 44 2017-11-15T02:28:02  <sipa> what's your configuration like?
 45 2017-11-15T02:28:09  *** LumberCartel has joined #bitcoin-core-dev
 46 2017-11-15T02:28:43  <Tatty> no, I have 2 configured, running and one connecting to the other as I can only set 1 externalip=
 47 2017-11-15T02:29:13  <sipa> i have no idea what you mean by that
 48 2017-11-15T02:29:19  <sipa> can you paste your config somewhere?
 49 2017-11-15T02:31:27  <Tatty> I try
 50 2017-11-15T02:34:35  *** btcdrak has joined #bitcoin-core-dev
 51 2017-11-15T02:42:13  *** AaronvanW has quit IRC
 52 2017-11-15T02:50:07  *** spellinmistache has joined #bitcoin-core-dev
 53 2017-11-15T02:50:59  <Tatty> https://ibb.co/dqtWyR https://ibb.co/kX50sm
 54 2017-11-15T02:51:11  <Tatty> screenshots
 55 2017-11-15T02:51:44  <sipa> that means some Tor peer connected to you via Tor
 56 2017-11-15T02:52:03  *** spellinmistache has quit IRC
 57 2017-11-15T02:52:03  <sipa> using that ou26n... address (which is *your* onion address, not theirs)
 58 2017-11-15T02:52:11  <Tatty> YES!
 59 2017-11-15T02:52:23  <sipa> and *they* have user agent 0.14.0
 60 2017-11-15T02:52:26  <Tatty> it is my hidden service
 61 2017-11-15T02:52:30  <sipa> i know
 62 2017-11-15T02:52:41  <sipa> but that address is the onion address they are connecting TO
 63 2017-11-15T02:52:49  <sipa> i.e., yours
 64 2017-11-15T02:53:18  <Tatty> no, they are conecting to the seconf one, managed by bitcoin-qt
 65 2017-11-15T02:53:34  <sipa> that's not what it says
 66 2017-11-15T02:54:04  <sipa> all i can see is an external peer connecting to you
 67 2017-11-15T02:54:38  <Tatty> right
 68 2017-11-15T02:55:02  <Tatty> I know it connected to the 2nd tor proxy
 69 2017-11-15T02:55:23  <Tatty> by those phictures you can't know
 70 2017-11-15T02:55:32  <sipa> then i can't help you
 71 2017-11-15T02:55:53  <sipa> everything you're showing me just says there is some external peer running 0.14 that is connecting to you over tor
 72 2017-11-15T02:56:32  <Tatty> do you really want me to post unsafe tor logs?
 73 2017-11-15T02:56:39  <sipa> no
 74 2017-11-15T02:56:50  <sipa> i want you to explain me why you think my theory is wrong
 75 2017-11-15T02:57:57  <Tatty> because I know the hidden service on that picture in unkown to tor proxy #2
 76 2017-11-15T02:58:01  <gribble> https://github.com/bitcoin/bitcoin/issues/2 | Long-term, safe, store-of-value · Issue #2 · bitcoin/bitcoin · GitHub
 77 2017-11-15T02:58:38  *** GateKeeper__ has joined #bitcoin-core-dev
 78 2017-11-15T02:58:57  <Tatty> and you see  a incoming connection via that hidden service
 79 2017-11-15T02:59:13  *** LumberCartel has quit IRC
 80 2017-11-15T02:59:53  <sipa> what do you mean by tor proxy 2
 81 2017-11-15T03:00:15  <Tatty> ok, someone might be having some fun announcing my hidden service as being theirs, but the simplest solution is that tor proxy 1 contacted tor proxy 2
 82 2017-11-15T03:00:35  <sipa> what do you mean by tor proxy 1 and tor proxy 2
 83 2017-11-15T03:01:40  <Tatty> check the second picture, the one set for port 9150 instead of 9050
 84 2017-11-15T03:02:28  <sipa> are those screenshots from the same client?
 85 2017-11-15T03:02:37  <Tatty> https://ibb.co/kX50sm proxy on top = proxy 1, the other is proxy 2
 86 2017-11-15T03:03:34  <Tatty> yes they are Ionly have this one
 87 2017-11-15T03:03:47  <sipa> those settings are irrelevant
 88 2017-11-15T03:03:49  <Tatty> and I never used any version prior to this
 89 2017-11-15T03:03:56  <sipa> they're about outgoing connections
 90 2017-11-15T03:04:07  <sipa> the peer screenshot is about an incoming connection
 91 2017-11-15T03:04:31  <Tatty> correct
 92 2017-11-15T03:04:46  <sipa> so i don't understand what the problem is
 93 2017-11-15T03:05:18  <sipa> a random other peer on the internet connected to you over tor
 94 2017-11-15T03:05:27  <sipa> those two proxy settings are not relevant
 95 2017-11-15T03:05:41  <Tatty> incomming to the hidden service created by Bitcoin Core on tor proxy 2
 96 2017-11-15T03:05:57  <Tatty> ok, I give up.
 97 2017-11-15T03:06:00  <sipa> ok?
 98 2017-11-15T03:06:12  <Tatty> sorry for taking your time
 99 2017-11-15T03:06:19  <sipa> why is that not possible?
100 2017-11-15T03:07:21  <sipa> your bitcoin client rumours its addresses to other peers, including onion addresses if it knows th
101 2017-11-15T03:07:47  <sipa> some peer saw yours, and connected to you
102 2017-11-15T03:08:04  <Tatty> sipa, I can't make you understand
103 2017-11-15T03:08:32  <Tatty> one of my peers conected to one of my peers with the wrong User Agent
104 2017-11-15T03:08:44  <Tatty> putting it simple that is what happens
105 2017-11-15T03:08:46  <sipa> i see no evidence of that
106 2017-11-15T03:09:03  <Tatty> you keep telling me this setting doesn't work, but it does work
107 2017-11-15T03:09:16  <sipa> no, i'm saying this setting is not relevant
108 2017-11-15T03:09:30  <Tatty> proxy 1 doesn't accept any incoming connection as it doesn't have any hidden service
109 2017-11-15T03:09:51  <Tatty> only the second does and it is Bitcoin Core who creates it
110 2017-11-15T03:09:55  *** Murch has quit IRC
111 2017-11-15T03:09:59  <sipa> ok
112 2017-11-15T03:10:02  <Tatty> now you say that is not possible
113 2017-11-15T03:10:15  <sipa> no, i'm saying that you're seeing an incoming connection
114 2017-11-15T03:10:28  <sipa> the settings you're showing me only affect outgoing connections
115 2017-11-15T03:11:22  <Tatty> proxy= listen=1 bind= proxyrandomize=1 externalip=ou26nyghcyiwrecx.onion
116 2017-11-15T03:11:32  <Tatty> is this what you needed?
117 2017-11-15T03:11:53  <sipa> so, you configured your external address as ou26...
118 2017-11-15T03:12:03  <sipa> your bitcoin node rumoured that address around
119 2017-11-15T03:12:09  <sipa> and someone is connecting to it
120 2017-11-15T03:12:29  <sipa> the proxy setting does not matter, it changes how outgoing connections are made
121 2017-11-15T03:13:08  <Tatty> I see yur point
122 2017-11-15T03:13:45  <Tatty> Iam advertising a hidden service on the wrong tor proxy
123 2017-11-15T03:14:21  <sipa> it is advertized to all your peers, regardless of connection type
124 2017-11-15T03:14:22  <Tatty> You helped me very much
125 2017-11-15T03:14:26  <Tatty> thank you!
126 2017-11-15T03:14:42  <sipa> ok!
127 2017-11-15T03:14:43  *** jsfour has quit IRC
128 2017-11-15T03:16:03  *** Tatty has quit IRC
129 2017-11-15T03:17:03  *** LumberCartel has joined #bitcoin-core-dev
130 2017-11-15T03:18:53  *** LumberCartel_ has joined #bitcoin-core-dev
131 2017-11-15T03:20:24  *** GateKeeper__ has quit IRC
132 2017-11-15T03:20:51  *** LumberCartel_ has quit IRC
133 2017-11-15T03:21:43  *** LumberCartel has quit IRC
134 2017-11-15T03:46:36  <kallewoof> luke-jr: any idea what the error is for this BIP PR? https://travis-ci.org/bitcoin/bips/builds/302293555?utm_source=github_status&utm_medium=notification
135 2017-11-15T03:46:44  <kallewoof> I don't even see the error in that log.
136 2017-11-15T03:54:46  *** jb55 has joined #bitcoin-core-dev
137 2017-11-15T03:56:30  <meshcollider> kallewoof its something to do with that table diff, it runs scripts/buildtable.pl before and after your commit and then runs `if [ -n "$newdiff" ]; then echo "$newdiff"; exit 1;`
138 2017-11-15T03:57:48  <meshcollider> Should you add an entry to README.mediawiki?
139 2017-11-15T04:00:19  *** bule has joined #bitcoin-core-dev
140 2017-11-15T04:05:35  <kallewoof> Ohh, that is probably it yeah. Thanks!
141 2017-11-15T04:11:57  *** Chao has joined #bitcoin-core-dev
142 2017-11-15T04:12:38  *** Chao has left #bitcoin-core-dev
143 2017-11-15T04:26:27  *** promag has joined #bitcoin-core-dev
144 2017-11-15T04:27:52  *** grio has joined #bitcoin-core-dev
145 2017-11-15T04:27:56  *** promag has quit IRC
146 2017-11-15T04:34:46  *** jsfour has joined #bitcoin-core-dev
147 2017-11-15T04:43:11  *** jsfour has quit IRC
148 2017-11-15T04:51:36  <kallewoof> That was it, yep. Thanks again.
149 2017-11-15T04:53:48  <meshcollider> Sweet :)
150 2017-11-15T04:55:30  *** jsfour has joined #bitcoin-core-dev
151 2017-11-15T05:11:25  <meshcollider> wumpus: https://github.com/bitcoin-core/bitcoincore.org/commit/ba1b4d6e97efead5f1bd0e6239b42c7faed0a4aa
152 2017-11-15T05:38:06  <eck> if any of you use fedora, I just set up a bitcoin rpm repo based mostly on the existing spec file in the contrib/ directory, feel free to help me test it or give me feedback: https://copr.fedorainfracloud.org/coprs/eklitzke/bitcoin/
153 2017-11-15T05:55:17  *** jtimon has quit IRC
154 2017-11-15T06:23:38  *** jsfour has quit IRC
155 2017-11-15T06:34:09  *** jsfour has joined #bitcoin-core-dev
156 2017-11-15T06:38:49  *** jsfour has quit IRC
157 2017-11-15T06:42:39  *** spinza has quit IRC
158 2017-11-15T06:44:50  <wumpus> meshcollider: nice!
159 2017-11-15T06:54:55  *** jsfour has joined #bitcoin-core-dev
160 2017-11-15T06:59:33  *** jsfour has quit IRC
161 2017-11-15T07:07:39  *** jb55 has quit IRC
162 2017-11-15T07:09:39  *** btcdrak has quit IRC
163 2017-11-15T07:13:17  *** spinza has joined #bitcoin-core-dev
164 2017-11-15T07:16:07  *** promag has joined #bitcoin-core-dev
165 2017-11-15T07:17:12  *** promag has quit IRC
166 2017-11-15T07:18:12  *** Victor_sueca is now known as Victorsueca
167 2017-11-15T07:25:42  *** jsfour has joined #bitcoin-core-dev
168 2017-11-15T07:29:28  <bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3bdf242fc68a...4db82b7aab4a
169 2017-11-15T07:29:28  <bitcoin-git> bitcoin/master 5ff01c2 James O'Beirne: [docs] Add instructions for lcov coverage report generation
170 2017-11-15T07:29:29  <bitcoin-git> bitcoin/master 4db82b7 Jonas Schnelli: Merge #11680: [docs] Add instructions for lcov report generation...
171 2017-11-15T07:30:01  <bitcoin-git> [bitcoin] jonasschnelli closed pull request #11680: [docs] Add instructions for lcov report generation (master...lcov-docs) https://github.com/bitcoin/bitcoin/pull/11680
172 2017-11-15T07:30:23  *** jsfour has quit IRC
173 2017-11-15T07:36:43  *** promag has joined #bitcoin-core-dev
174 2017-11-15T07:39:47  <kallewoof> Man, running a full node with datadir on an external USB drive is really slow. Like, handshakes are timing out kind of slow.
175 2017-11-15T07:40:18  *** promag has quit IRC
176 2017-11-15T07:41:32  *** JackH has quit IRC
177 2017-11-15T07:42:14  *** prestonparris has joined #bitcoin-core-dev
178 2017-11-15T07:42:55  *** ctulino has quit IRC
179 2017-11-15T07:46:30  <jonasschnelli> kallewoof: you could do a PR that would allow to keep the block files on a different "datadir"...
180 2017-11-15T07:46:34  <jonasschnelli> That would be handy IMO
181 2017-11-15T07:46:58  <jonasschnelli> Maybe only blocks older then 144+...
182 2017-11-15T07:47:11  <kallewoof> Can't you just ln -s the blocks folder? I was thinking of doing that
183 2017-11-15T07:47:13  <jonasschnelli> You want the UTXO/chainstate internal and the blocks external
184 2017-11-15T07:47:22  <jonasschnelli> kallewoof: you can...
185 2017-11-15T07:47:26  <jonasschnelli> but meh
186 2017-11-15T07:47:55  <kallewoof> I actually think this might be a problem on my end, but not sure. It's way too slow to be normal behavior. I can't even addnode another full node on the same network. It times out.
187 2017-11-15T07:51:23  *** JackH has joined #bitcoin-core-dev
188 2017-11-15T07:54:37  *** alreadylate has joined #bitcoin-core-dev
189 2017-11-15T07:56:09  *** AaronvanW has joined #bitcoin-core-dev
190 2017-11-15T07:56:46  *** Leminer has quit IRC
191 2017-11-15T07:57:43  *** dermoth has quit IRC
192 2017-11-15T07:58:08  *** dermoth has joined #bitcoin-core-dev
193 2017-11-15T07:58:23  *** mesh_ has quit IRC
194 2017-11-15T07:59:09  *** Leminer has joined #bitcoin-core-dev
195 2017-11-15T07:59:12  *** windsok_ has quit IRC
196 2017-11-15T08:00:03  *** promag has joined #bitcoin-core-dev
197 2017-11-15T08:00:30  *** windsok has joined #bitcoin-core-dev
198 2017-11-15T08:01:11  *** AaronvanW has quit IRC
199 2017-11-15T08:05:00  *** promag has quit IRC
200 2017-11-15T08:05:40  *** meshcoll- has joined #bitcoin-core-dev
201 2017-11-15T08:07:27  *** JackH has quit IRC
202 2017-11-15T08:08:01  *** warxhead has quit IRC
203 2017-11-15T08:09:39  <kallewoof> After running for awhile, things got faster. I don't know what was going on but it seems to have been temporary.
204 2017-11-15T08:10:57  *** BashCo has quit IRC
205 2017-11-15T08:11:09  <jonasschnelli> kallewoof: anyways,.. that datadir split PR is still welcome. :)
206 2017-11-15T08:11:37  *** BashCo has joined #bitcoin-core-dev
207 2017-11-15T08:12:53  <bitcoin-git> [bitcoin] eklitzke opened pull request #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (master...desktop-file) https://github.com/bitcoin/bitcoin/pull/11690
208 2017-11-15T08:13:17  <kallewoof> OK! I'll see what I can do. :) Related: I wanted to make a PR that lets you have a readonly "cache" of the blockchain in a separate folder. You can spin up more than one node very easily without having to copy entire chain if you have access to the filesystem of the first one. Would be helpful for testing things I think.
209 2017-11-15T08:16:30  *** BashCo has quit IRC
210 2017-11-15T08:19:28  *** andytosh1 has quit IRC
211 2017-11-15T08:19:54  *** JackH has joined #bitcoin-core-dev
212 2017-11-15T08:20:55  *** meshcoll- is now known as mesh_
213 2017-11-15T08:24:01  *** JackH has quit IRC
214 2017-11-15T08:24:17  *** alreadylate has quit IRC
215 2017-11-15T08:25:28  <meshcollider> You can already move conf file with -conf and #11466 splits walletdir out so soon there'll be nothing left in the datadir itself ;)
216 2017-11-15T08:25:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
217 2017-11-15T08:29:42  *** JackH has joined #bitcoin-core-dev
218 2017-11-15T08:31:06  *** BashCo has joined #bitcoin-core-dev
219 2017-11-15T08:32:01  *** andytoshi has joined #bitcoin-core-dev
220 2017-11-15T08:38:51  <kallewoof> Huh... 2017-11-15 08:37:57       - Connect 1802 transactions: 156296.66ms (86.735ms/tx, 25.606ms/txin) [270.35s]
221 2017-11-15T08:40:27  <kallewoof> WOuld this benefit from having only blocks on external drive? I am not sure what part of the fs is used for the tx connect stuff. *checking*
222 2017-11-15T08:42:20  *** bule has quit IRC
223 2017-11-15T08:43:24  <wumpus> where you put chainstate is going to have the most influence there
224 2017-11-15T08:43:56  <jonasschnelli> Yeah.. I guess the lag comes from leveldb internals
225 2017-11-15T08:43:59  <wumpus> the blocks directory has the block data and block index, which are relatively rarely accessed (unless -txindex)
226 2017-11-15T08:44:19  <kallewoof> Okay, testing ln -s solution to see if it helps.
227 2017-11-15T08:44:50  <wumpus> (and unless you're reindexing, at which point it has to go through all blocks twice, but stilll chainstate drive will be much, much more busy)
228 2017-11-15T08:45:40  <kallewoof> I'm not
229 2017-11-15T08:48:04  <kallewoof> Yay! 2017-11-15 08:47:24       - Connect 2033 transactions: 2525.99ms (1.242ms/tx, 0.515ms/txin) [9.74s]
230 2017-11-15T08:50:52  <jonasschnelli> kallewoof: that's with chainstate on internal drive an ln -s of your blocks to your ext drive?
231 2017-11-15T08:51:57  <kallewoof> Yeah
232 2017-11-15T08:52:22  <kallewoof> 4.7GB on internal and the rest on external
233 2017-11-15T08:52:37  *** timothy has joined #bitcoin-core-dev
234 2017-11-15T08:53:03  <wumpus> nice!
235 2017-11-15T08:55:38  *** cbag has joined #bitcoin-core-dev
236 2017-11-15T08:56:39  *** cbag has left #bitcoin-core-dev
237 2017-11-15T08:57:04  *** laurentmt has joined #bitcoin-core-dev
238 2017-11-15T08:57:43  *** Emcy has quit IRC
239 2017-11-15T08:57:51  *** cbag has joined #bitcoin-core-dev
240 2017-11-15T09:00:21  *** Emcy has joined #bitcoin-core-dev
241 2017-11-15T09:06:26  *** Emcy has quit IRC
242 2017-11-15T09:06:52  *** Emcy has joined #bitcoin-core-dev
243 2017-11-15T09:20:47  *** indistylo has joined #bitcoin-core-dev
244 2017-11-15T09:22:36  *** promag has joined #bitcoin-core-dev
245 2017-11-15T09:26:21  *** alreadylate has joined #bitcoin-core-dev
246 2017-11-15T09:26:32  *** jsfour has joined #bitcoin-core-dev
247 2017-11-15T09:29:03  *** cl0uding has quit IRC
248 2017-11-15T09:31:09  <bitcoin-git> [bitcoin] practicalswift opened pull request #11691: rpc: Add missing lock in getblocktemplate(...). Work around Clang thread safety analysis quirks. (master...rpc-locking) https://github.com/bitcoin/bitcoin/pull/11691
249 2017-11-15T09:31:11  *** jsfour has quit IRC
250 2017-11-15T09:33:54  *** dermoth has quit IRC
251 2017-11-15T09:34:18  *** dermoth has joined #bitcoin-core-dev
252 2017-11-15T09:36:53  <wumpus> gah, we sould create a separate issue for WFL issues
253 2017-11-15T09:37:53  *** Caroline6Von has joined #bitcoin-core-dev
254 2017-11-15T09:39:35  *** wxss has quit IRC
255 2017-11-15T09:40:08  *** halform has joined #bitcoin-core-dev
256 2017-11-15T09:40:34  *** cl0uding has joined #bitcoin-core-dev
257 2017-11-15T09:41:19  *** wxss has joined #bitcoin-core-dev
258 2017-11-15T09:41:19  *** Caroline6Von has quit IRC
259 2017-11-15T09:42:05  *** vicenteH has joined #bitcoin-core-dev
260 2017-11-15T09:42:49  *** halform has quit IRC
261 2017-11-15T09:43:20  *** checksauce has joined #bitcoin-core-dev
262 2017-11-15T09:46:09  *** checksauce has quit IRC
263 2017-11-15T09:46:36  *** checksauce has joined #bitcoin-core-dev
264 2017-11-15T09:48:15  *** dabura667 has quit IRC
265 2017-11-15T09:48:43  *** checksauce has quit IRC
266 2017-11-15T09:49:43  *** l4ng1t has joined #bitcoin-core-dev
267 2017-11-15T09:49:54  *** dabura667 has joined #bitcoin-core-dev
268 2017-11-15T09:50:13  *** l4ng1t is now known as Guest27291
269 2017-11-15T09:51:22  <Guest27291> hi
270 2017-11-15T09:51:49  *** checksauce has joined #bitcoin-core-dev
271 2017-11-15T09:52:08  <Guest27291> can someone confirm segiwit2x is still execute?
272 2017-11-15T09:52:14  *** checksauce has quit IRC
273 2017-11-15T09:52:34  <timothy> Guest27291: OT
274 2017-11-15T09:52:44  <meshcollider> Guest27291: this is not the place, but segwit2x was called off https://lists.linuxfoundation.org/pipermail/bitcoin-segwit2x/2017-November/000685.html
275 2017-11-15T09:53:22  <Guest27291> thanks.. but i still heard a lot of rumour about segwit2x which is make me confuse
276 2017-11-15T09:53:45  *** checksauce has joined #bitcoin-core-dev
277 2017-11-15T09:53:55  <meshcollider> You should probably discuss it in #bitcoin not this channel
278 2017-11-15T09:55:01  <Guest27291> sorry.. thanks anyway
279 2017-11-15T09:55:37  <meshcollider> No problem :)
280 2017-11-15T10:00:25  *** Giszmo has quit IRC
281 2017-11-15T10:02:49  *** m8tion03 has joined #bitcoin-core-dev
282 2017-11-15T10:03:32  *** roconnor_ has quit IRC
283 2017-11-15T10:05:57  *** m8tion01 has quit IRC
284 2017-11-15T10:11:35  <bitcoin-git> [bitcoin] practicalswift opened pull request #11692: Remove unused Boost include. Move Boost include. (master...remove-boost-includes) https://github.com/bitcoin/bitcoin/pull/11692
285 2017-11-15T10:12:17  *** prestonparris has quit IRC
286 2017-11-15T10:15:30  *** yange has joined #bitcoin-core-dev
287 2017-11-15T10:27:41  *** Guest27291 has quit IRC
288 2017-11-15T10:38:12  *** prestonparris has joined #bitcoin-core-dev
289 2017-11-15T10:39:16  <promag> meshcollider: hi
290 2017-11-15T10:39:26  <meshcollider> promag: Hey :)
291 2017-11-15T10:39:37  <promag> I'm not familiar with the dumpwallet test
292 2017-11-15T10:39:43  <promag> let me read it
293 2017-11-15T10:40:17  <meshcollider> The dumpwallet test basically counts the number of keys present in the file and makes sure that is the number that were generated in the wallet
294 2017-11-15T10:40:52  <meshcollider> For the scripts part which I added, it relies on the comment to find which scripts correspond to which P2SH address we generated
295 2017-11-15T10:41:09  <meshcollider> and then reimports to make sure the script was valid
296 2017-11-15T10:42:05  <meshcollider> I'm looking into the GetAllReserveKeys() comment you wrote now, I'm unsure on that as I didn't change that part of it
297 2017-11-15T10:42:52  <promag> +1 on the test
298 2017-11-15T10:43:05  <promag> dunno why there is no lock in the RPC
299 2017-11-15T10:43:15  <meshcollider> there is a lock on cs_wallet
300 2017-11-15T10:43:21  <meshcollider> I commented on the PR, its on line 630
301 2017-11-15T10:43:44  <meshcollider> https://github.com/bitcoin/bitcoin/pull/11667/files#diff-522490d83dce5375d423b23886e4125eR630
302 2017-11-15T10:44:01  <meshcollider> Unless I misunderstood what you're referring to
303 2017-11-15T10:44:15  <promag> f*** sorry!
304 2017-11-15T10:44:46  <meshcollider> Heh all good :)
305 2017-11-15T10:44:57  <promag> Missed one expand in gh
306 2017-11-15T10:45:54  <meshcollider> So do you suggest modifying GetAllReserveKeys or is it ok since it is locked?
307 2017-11-15T10:46:22  <meshcollider> This is the only place in the entire codebase which that function is called iirc
308 2017-11-15T10:46:37  <promag> yes, it is fine the way it is
309 2017-11-15T10:46:45  <meshcollider> Sweet, thanks :)
310 2017-11-15T10:51:43  *** prestonparris has quit IRC
311 2017-11-15T10:57:06  <meshcollider> promag: lol I like your thumbs_up reaction to that random "O" comment
312 2017-11-15T10:57:18  <promag> hehe
313 2017-11-15T10:57:35  <promag> meshcollider: I think you can remove ::GetCScripts
314 2017-11-15T10:57:44  *** spinza has quit IRC
315 2017-11-15T10:57:55  <promag> why not return a const reference to mapScripts?
316 2017-11-15T10:58:27  <promag> that way you avoid a bunch of copies, set sorts and map lookups?
317 2017-11-15T10:59:04  <meshcollider> mmm yeah true, that function is basically a C+P of CBasicKeyStore::GetKeys()
318 2017-11-15T11:00:20  <meshcollider> Is there any disadvantage to that?
319 2017-11-15T11:00:48  <promag> meshcollider: the only one I can see is that `cs_KeyStore` must be locked
320 2017-11-15T11:01:05  <promag> while using/iterating the mapScripts
321 2017-11-15T11:01:52  <promag> I would wait for someone with deeper knowledge there
322 2017-11-15T11:02:52  <promag> but the idea is the same as GetAllReserveKeys()
323 2017-11-15T11:03:34  <promag> but that one is protected by cs_wallet I think
324 2017-11-15T11:03:42  <meshcollider> Yeah
325 2017-11-15T11:03:43  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
326 2017-11-15T11:05:38  <meshcollider> Ok maybe just post the idea on the PR so others can weigh in on it when they see it 👍
327 2017-11-15T11:07:14  *** promag has quit IRC
328 2017-11-15T11:09:46  <bitcoin-git> [bitcoin] practicalswift closed pull request #11692: Remove unused Boost include. Move Boost include. (master...remove-boost-includes) https://github.com/bitcoin/bitcoin/pull/11692
329 2017-11-15T11:11:11  *** kgc has joined #bitcoin-core-dev
330 2017-11-15T11:11:19  <kgc> Hi! I have a question, sorry for interrupting, is it planned in the foreseeable future to change signrawtransaction rpc method to successfully sign an output that was sent to a P2SH-P2WSH address? I tried doing so resulted in failure.
331 2017-11-15T11:13:50  *** Jadyn10Hagenes has joined #bitcoin-core-dev
332 2017-11-15T11:15:50  *** cbag has quit IRC
333 2017-11-15T11:17:51  *** prestonparris has joined #bitcoin-core-dev
334 2017-11-15T11:20:57  *** Khunbish has joined #bitcoin-core-dev
335 2017-11-15T11:22:09  *** Jadyn10Hagenes has quit IRC
336 2017-11-15T11:22:39  *** Flavio25Buckridg has quit IRC
337 2017-11-15T11:24:33  <wumpus> kgc: hrm, I think that should just work?
338 2017-11-15T11:27:27  *** jsfour has joined #bitcoin-core-dev
339 2017-11-15T11:28:07  *** AaronvanW has joined #bitcoin-core-dev
340 2017-11-15T11:30:21  *** Kirstin82Ledner has joined #bitcoin-core-dev
341 2017-11-15T11:30:27  *** prestonparris has quit IRC
342 2017-11-15T11:31:11  <meshcollider> kgc wumpus: yep should just work, tested on
343 2017-11-15T11:32:15  *** jsfour has quit IRC
344 2017-11-15T11:32:50  <wumpus> thanks for testing meshcollider
345 2017-11-15T11:33:03  <wumpus> kgc: so you need to be a bit more specific about the steps you followed and the result you get
346 2017-11-15T11:39:09  <kgc> ok, I'll give you a json request I made, give me a sec
347 2017-11-15T11:40:21  <kgc> {     "jsonrpc": "1.0",     "id": "requestId",     "method": "signrawtransaction",     "params": [         "0200000001d6b67546a418331a5e3877d103e7c95b2e0c69a2e289ddca75383dcca53128120100000000ffffffff0198929800000000001976a914423ffad905158d1d472f5fcd5fbc6916c2fb031f88ac00000000",         [             {                 "txid": "122831a5cc3d3875cadd89e2a2690c2e5bc9e703d177385e1a3318a44675b6d6",                 "vout": 1,
348 2017-11-15T11:40:29  *** intcat has quit IRC
349 2017-11-15T11:40:50  <kgc> ok, not the best idea...
350 2017-11-15T11:41:54  <kgc> https://pastebin.com/2apuckBk
351 2017-11-15T11:41:54  *** intcat has joined #bitcoin-core-dev
352 2017-11-15T11:41:59  <wumpus> better use a pastebi.. yea
353 2017-11-15T11:42:57  *** Giszmo has joined #bitcoin-core-dev
354 2017-11-15T11:43:07  *** promag has joined #bitcoin-core-dev
355 2017-11-15T11:45:00  <kgc> this is the response from that request
356 2017-11-15T11:45:01  <kgc> https://pastebin.com/SsszYS2w
357 2017-11-15T11:47:03  <kgc> are there some undocumented parameters I should be passing in?
358 2017-11-15T11:51:46  *** limpkin is now known as limpkin_irc
359 2017-11-15T11:52:00  *** yange has quit IRC
360 2017-11-15T11:52:26  <wumpus> no, there are no further parameters. Sounds like the transaction is missing the witness somehow?
361 2017-11-15T11:57:17  *** andre1 has joined #bitcoin-core-dev
362 2017-11-15T11:57:27  *** andre1 has left #bitcoin-core-dev
363 2017-11-15T11:59:18  *** promag has quit IRC
364 2017-11-15T11:59:56  *** promag has joined #bitcoin-core-dev
365 2017-11-15T12:01:30  *** dcousens has quit IRC
366 2017-11-15T12:02:40  *** dcousens has joined #bitcoin-core-dev
367 2017-11-15T12:02:59  <meshcollider> oh hrm
368 2017-11-15T12:03:16  *** spinza has joined #bitcoin-core-dev
369 2017-11-15T12:03:40  <kgc> well, it's slightly weird because if I create corresponding deposit address and import it inside bitcoin core wallet, I can send to and spend funds without anyproblems
370 2017-11-15T12:04:50  <meshcollider> Yeah that's what I thought you were asking about initially
371 2017-11-15T12:05:12  <wumpus> it looks like the witness was stripped from the transaction
372 2017-11-15T12:06:42  <meshcollider> Does signtrawtransaction need a witness transaction with empty witness?
373 2017-11-15T12:06:48  <meshcollider> Or will it add the witness itself
374 2017-11-15T12:07:01  *** dcousens has quit IRC
375 2017-11-15T12:07:52  <kgc> Hmm, are you suggesting that createrawtransaction method somehow cut out the witness part?
376 2017-11-15T12:07:53  *** dcousens has joined #bitcoin-core-dev
377 2017-11-15T12:08:35  *** prestonparris has joined #bitcoin-core-dev
378 2017-11-15T12:09:38  <meshcollider> createrawtransaction would not create a witness transaction because it would not know it was a P2WSH address would it
379 2017-11-15T12:10:38  <kgc> yeah, sounds legit, are there any workarounds for this except for realizing serialization myself (which I would much rather avoid)
380 2017-11-15T12:11:01  *** SopaXorzTaker has joined #bitcoin-core-dev
381 2017-11-15T12:11:01  <meshcollider> Well it shouldn't be hard to make it into a witness transaction right
382 2017-11-15T12:11:34  <meshcollider> `02000000000101d6b67546a418331a5e3877d103e7c95b2e0c69a2e289ddca75383dcca5312812010000002322002016a91e58e02069f95ea6defba7436199658573c34d384c69779779f4500d7cacffffffff0198929800000000001976a914423ffad905158d1d472f5fcd5fbc6916c2fb031f88ac0000000000`
383 2017-11-15T12:11:56  <meshcollider> just added marker, flag and empty witness
384 2017-11-15T12:12:26  <wumpus> it's strange if that is needed though
385 2017-11-15T12:12:37  <meshcollider> indeed
386 2017-11-15T12:12:41  <wumpus> so I think we're missing something
387 2017-11-15T12:12:49  *** prestonparris has quit IRC
388 2017-11-15T12:16:35  <meshcollider> Ideally signrawtransaction should just convert the raw transaction to a witness transaction itself if the input is a witness input right
389 2017-11-15T12:17:39  <kgc> that would be the desired behavior I guess
390 2017-11-15T12:17:46  <wumpus> maybe reading the test code helps: https://github.com/bitcoin/bitcoin/blob/master/test/functional/segwit.py
391 2017-11-15T12:18:01  <wumpus> send_to_witness and create_witness_tx
392 2017-11-15T12:19:16  <meshcollider> I looked into that, but there are no tests for P2SH-P2WSH it seems
393 2017-11-15T12:19:22  <meshcollider> using signrawtransaction
394 2017-11-15T12:20:23  *** Victorsueca has quit IRC
395 2017-11-15T12:20:36  <meshcollider> because L251-L264 notice that encode_p2sh is False
396 2017-11-15T12:21:09  *** prestonparris has joined #bitcoin-core-dev
397 2017-11-15T12:22:41  *** dabura667 has quit IRC
398 2017-11-15T12:25:21  <meshcollider> Hmm actually how does it know what the redeemscript is for the P2WSH part
399 2017-11-15T12:25:32  <meshcollider> you only pass in the P2SH redeemscript aye
400 2017-11-15T12:28:05  <kgc> these are the parameters I've available: https://pastebin.com/TE1LrR44 should I be passing in as a redeem script something other than: 002016a91e58e02069f95ea6defba7436199658573c34d384c69779779f4500d7cac
401 2017-11-15T12:30:12  <meshcollider> Yeah see you give it `002016a91e58e02069f95ea6defba7436199658573c34d384c69779779f4500d7cac` which is the redeemScript for the P2SH wrapper, but then it must not know what the redeemscript for the internal `16a91e58e02069f95ea6defba7436199658573c34d384c69779779f4500d7cac` is
402 2017-11-15T12:30:22  <meshcollider> which is what hex=...
403 2017-11-15T12:30:32  <meshcollider> but I don't know how to pass that in, no :/
404 2017-11-15T12:30:41  *** mmgen has joined #bitcoin-core-dev
405 2017-11-15T12:32:10  <kgc> I'm confused, then what is it expecting as the redeem script parameter
406 2017-11-15T12:34:48  *** prestonparris has quit IRC
407 2017-11-15T12:34:50  <meshcollider> I would think what you did was correct, maybe it really isn't supported without importing the script into the wallet... I would wait for someone more experienced than me to say for sure though
408 2017-11-15T12:37:02  <kgc> well the very least I got the address generation part right :D hopefully someone can shed some light on it, because implementing tx serialization/deserialization/signing and maintaining it would be painful for me
409 2017-11-15T12:37:30  <kgc> then I might as well start contributing to bitcoinj project on my spare time (which I don't have)
410 2017-11-15T12:38:19  <aj> MarcoFalke: #11646 was merged, so it shouldn't be labelled up for grabs, should it?
411 2017-11-15T12:38:21  <gribble> https://github.com/bitcoin/bitcoin/issues/11646 | Require a steady clock for bench with at least micro precision by TheBlueMatt · Pull Request #11646 · bitcoin/bitcoin · GitHub
412 2017-11-15T12:39:09  <meshcollider> aj: might be related to the comment
413 2017-11-15T12:39:28  *** roconnor_ has joined #bitcoin-core-dev
414 2017-11-15T12:39:44  <kgc> should I open an issue on the github so it doesn't get lost?
415 2017-11-15T12:39:58  <meshcollider> kgc: someone like sipa will probably be able to clarify things when he is online :)
416 2017-11-15T12:40:17  <meshcollider> Yes I think an issue is a good idea
417 2017-11-15T12:40:37  <kgc> ok, will do that, thank you for helping out :)
418 2017-11-15T12:42:50  <meshcollider> There should be a way to pass scripts in as well as private keys
419 2017-11-15T12:43:14  *** mmgen has quit IRC
420 2017-11-15T12:43:28  *** mmgen has joined #bitcoin-core-dev
421 2017-11-15T12:46:08  <meshcollider> kgc: in the mean time, you could just import the witness redeem script into your wallet I think :)
422 2017-11-15T12:52:47  <wumpus> aj: I see now, it's merged but there was a mistake in it
423 2017-11-15T12:56:02  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4db82b7aab4a...aca77a4d58c6
424 2017-11-15T12:56:03  <bitcoin-git> bitcoin/master 63c2d83 practicalswift: Explicitly state assumption that state.m_chain_sync.m_work_header != nullptr in ConsiderEviction...
425 2017-11-15T12:56:04  <bitcoin-git> bitcoin/master aca77a4 Wladimir J. van der Laan: Merge #11655: net: Assert state.m_chain_sync.m_work_header in ConsiderEviction...
426 2017-11-15T12:56:37  <bitcoin-git> [bitcoin] laanwj closed pull request #11655: net: Assert state.m_chain_sync.m_work_header in ConsiderEviction (master...m_chain_sync.m_work_header) https://github.com/bitcoin/bitcoin/pull/11655
427 2017-11-15T12:57:15  <JackH> how can I dump privkey on segwit addresses? I get an error when doing dumpprivkey
428 2017-11-15T12:59:27  <JackH> from the one topic I read, since it is a p2sh script, there is no address, thus I cannot dump privkey? but how can I otherwise get the privkey for the inputs?
429 2017-11-15T12:59:30  <wumpus> you probably added the witness address using addwitnessaddress?
430 2017-11-15T12:59:39  *** luke-jr has quit IRC
431 2017-11-15T12:59:43  <wumpus> that won't add a private key
432 2017-11-15T13:00:01  *** luke-jr has joined #bitcoin-core-dev
433 2017-11-15T13:00:38  <JackH> so how do I get access to the inputs? basically I am looking to do a child pays for parent for some stuck txs
434 2017-11-15T13:00:46  <JackH> and I wanted to import the privkey into electrum
435 2017-11-15T13:00:52  <JackH> or is there a better way?
436 2017-11-15T13:02:14  <wumpus> I think you need the address you called addwitnessaddress with, and use dumpprivkey with that
437 2017-11-15T13:03:39  *** promag has quit IRC
438 2017-11-15T13:08:12  *** prestonparris has joined #bitcoin-core-dev
439 2017-11-15T13:10:08  <wumpus> that would give you a private key, though importing it in other software is not going to be easy I expect, e.g. just importing the key isn't going to make it recognize the transaction
440 2017-11-15T13:12:28  *** prestonparris has quit IRC
441 2017-11-15T13:15:27  *** Giszmo has quit IRC
442 2017-11-15T13:28:18  *** jsfour has joined #bitcoin-core-dev
443 2017-11-15T13:32:35  *** jsfour has quit IRC
444 2017-11-15T13:34:01  *** LeMiner2 has joined #bitcoin-core-dev
445 2017-11-15T13:34:23  *** Leminer has quit IRC
446 2017-11-15T13:34:24  *** LeMiner2 is now known as Leminer
447 2017-11-15T13:56:21  *** alreadylate has quit IRC
448 2017-11-15T14:04:57  *** was has joined #bitcoin-core-dev
449 2017-11-15T14:05:05  <was> hello
450 2017-11-15T14:05:17  <was> is someone can help me ?
451 2017-11-15T14:05:48  <wumpus> just ask your question in the channel and if someone can help you they'll answer (or tell you where it's better to ask it)
452 2017-11-15T14:06:07  <was> i have a wallet btc core
453 2017-11-15T14:06:12  <was> i save wallet.dat
454 2017-11-15T14:06:19  <was> for change another pc
455 2017-11-15T14:06:31  <was> now how can getback ?
456 2017-11-15T14:06:39  <was> i have wallet.dat and my password
457 2017-11-15T14:10:23  <was> you know ?
458 2017-11-15T14:12:05  <sipa> try #bitcoin
459 2017-11-15T14:13:27  *** promag has joined #bitcoin-core-dev
460 2017-11-15T14:18:56  *** DigitalSwell has joined #bitcoin-core-dev
461 2017-11-15T14:20:30  *** LumberCartel has joined #bitcoin-core-dev
462 2017-11-15T14:21:28  *** DigitalSwell has quit IRC
463 2017-11-15T14:23:34  *** checksauce has quit IRC
464 2017-11-15T14:24:02  *** checksauce has joined #bitcoin-core-dev
465 2017-11-15T14:24:10  *** aruns has joined #bitcoin-core-dev
466 2017-11-15T14:26:51  *** indistylo has quit IRC
467 2017-11-15T14:27:53  *** Giszmo has joined #bitcoin-core-dev
468 2017-11-15T14:28:38  *** checksauce has quit IRC
469 2017-11-15T14:36:37  *** Khunbish has quit IRC
470 2017-11-15T14:41:47  <promag> Are CBlockTreeDB/CDBWrapper member functions thread safe?
471 2017-11-15T14:42:19  <wumpus> no
472 2017-11-15T14:44:05  *** was has quit IRC
473 2017-11-15T14:45:24  *** alreadylate has joined #bitcoin-core-dev
474 2017-11-15T14:46:28  <wumpus> though leveldb itself is thread safe
475 2017-11-15T14:46:32  *** jtimon has joined #bitcoin-core-dev
476 2017-11-15T14:47:22  <wumpus> we make use of that only in one place, for the Cursor in GetUTXOStats, to iterate over a snapshot of the database while the rest of the process continues
477 2017-11-15T14:52:08  <wumpus> but none of the caching and buffering we do on top of leveldb is thread-safe
478 2017-11-15T14:52:17  *** alreadylate has quit IRC
479 2017-11-15T14:52:28  <bitcoin-git> [bitcoin] practicalswift closed pull request #11691: rpc: Add missing lock in getblocktemplate(...). Work around Clang thread safety analysis quirks. (master...rpc-locking) https://github.com/bitcoin/bitcoin/pull/11691
480 2017-11-15T14:53:35  *** aruns has quit IRC
481 2017-11-15T14:57:12  <promag> wumpus: ty
482 2017-11-15T15:08:38  *** Chris_Stewart_5 has joined #bitcoin-core-dev
483 2017-11-15T15:09:08  *** felco has quit IRC
484 2017-11-15T15:21:26  <bitcoin-git> [bitcoin] practicalswift opened pull request #11694: rpc: Add missing cs_main lock in getblocktemplate(...) (master...missing-lock-in-getblocktemplate) https://github.com/bitcoin/bitcoin/pull/11694
485 2017-11-15T15:24:22  *** SopaXorzTaker has quit IRC
486 2017-11-15T15:24:52  *** SopaXorzTaker has joined #bitcoin-core-dev
487 2017-11-15T15:26:16  <bitcoin-git> [bitcoin] laanwj pushed 13 new commits to master: https://github.com/bitcoin/bitcoin/compare/aca77a4d58c6...927a1d7d088e
488 2017-11-15T15:26:17  <bitcoin-git> bitcoin/master a7d3936 Matt Corallo: Add a CValidationInterface::TransactionRemovedFromMempool...
489 2017-11-15T15:26:17  <bitcoin-git> bitcoin/master 0343676 Matt Corallo: Call TransactionRemovedFromMempool in the CScheduler thread...
490 2017-11-15T15:26:18  <bitcoin-git> bitcoin/master 2b4b345 Matt Corallo: Add ability to assert a lock is not held in DEBUG_LOCKORDER
491 2017-11-15T15:26:27  <bitcoin-git> [bitcoin] laanwj closed pull request #10286: Call wallet notify callbacks in scheduler thread (without cs_main) (master...2017-01-wallet-cache-inmempool-4) https://github.com/bitcoin/bitcoin/pull/10286
492 2017-11-15T15:27:21  *** goatpig has joined #bitcoin-core-dev
493 2017-11-15T15:29:08  *** jsfour has joined #bitcoin-core-dev
494 2017-11-15T15:30:54  <promag> is practicalswift around?
495 2017-11-15T15:33:42  *** jsfour has quit IRC
496 2017-11-15T15:37:38  *** felco has joined #bitcoin-core-dev
497 2017-11-15T15:38:41  *** boreddanman1 has quit IRC
498 2017-11-15T15:40:38  *** meshcollider has quit IRC
499 2017-11-15T15:45:03  *** Khunbish has joined #bitcoin-core-dev
500 2017-11-15T15:59:52  *** Chris_Stewart_5 has quit IRC
501 2017-11-15T16:14:33  *** gustav has joined #bitcoin-core-dev
502 2017-11-15T16:14:39  <gustav> hello
503 2017-11-15T16:16:14  <promag> guess not
504 2017-11-15T16:16:28  <promag> luke-jr: friendly reminder https://github.com/bitcoin/bitcoin/pull/11660#discussion_r150875214
505 2017-11-15T16:20:10  <gustav> i have one app where users are given 1 bitcoin address A, they deposit btc on A and later on they withdraw on their address B. I'd like to use segwit addresses to cut down expenses on network fees (if im getting this right). now i use getnewaddress, sendmany and rawtransactions functions. would it be possible to use $addr = getnewaddress(); $segwit
506 2017-11-15T16:20:10  <gustav> addr = addwitnessaddress($addr); to "move into segwit addresses usage"? if so would users be able to send to my app segwit address, and will my existing code be able to send payments to user addresses (non segwit and segwit)? thank you very much for all the work. now fees are insane this is why im asking. if wrong irc please tell me where to ask.
507 2017-11-15T16:21:54  <gustav> reading online on stackoverflow and similar leads me to believe it can be done but im not sure about compatibility (user sends from non-segwit to segwit, needs to receive from segwit to non-segwit) and if addwitnessaddress is all i need. again thanks and sorry for wall of texts
508 2017-11-15T16:22:46  <gustav> oopsie, using bitcoin-core latest version on linux (rpc, with php)
509 2017-11-15T16:26:44  *** Giszmo has quit IRC
510 2017-11-15T16:27:21  *** shesek has quit IRC
511 2017-11-15T16:30:55  *** Giszmo has joined #bitcoin-core-dev
512 2017-11-15T16:37:48  *** JackH has quit IRC
513 2017-11-15T16:51:37  *** JackH has joined #bitcoin-core-dev
514 2017-11-15T16:53:04  *** Murch has joined #bitcoin-core-dev
515 2017-11-15T16:53:51  *** LumberCartel has quit IRC
516 2017-11-15T16:57:51  <sturles> Yes, this will make an address into a segwit address (P2SH-P2WPKH).  There are multiple kinds of segwit addresses.  To get the highest nenefit, you can make a P2PKWH address like this: addwitnessaddress($addr,true)
517 2017-11-15T16:58:01  *** gustav has quit IRC
518 2017-11-15T16:58:29  *** carlitos has joined #bitcoin-core-dev
519 2017-11-15T16:58:30  <sturles> The P2PKWH address will begin with bc1... (Bech32 format), and the sending wallet must be segwit aware to use it.
520 2017-11-15T16:59:23  *** shesek has joined #bitcoin-core-dev
521 2017-11-15T16:59:23  *** shesek has joined #bitcoin-core-dev
522 2017-11-15T16:59:26  <sturles> You can only convert your own addresses.  Do not attempt to convert addresses you get from other people.
523 2017-11-15T17:03:26  *** jsfour has joined #bitcoin-core-dev
524 2017-11-15T17:07:15  *** Chris_Stewart_5 has joined #bitcoin-core-dev
525 2017-11-15T17:10:19  *** LumberCartel has joined #bitcoin-core-dev
526 2017-11-15T17:15:35  <BlueMatt> note to anyone with open wallet-rpc PRs: ##10286 will likely cause a silent conflict - you will need to add calls to BlockUntilSyncedToCurrentChain!
527 2017-11-15T17:15:38  <gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
528 2017-11-15T17:16:49  *** LumberCartel has quit IRC
529 2017-11-15T17:22:54  *** jb55 has joined #bitcoin-core-dev
530 2017-11-15T17:29:18  *** BashCo has quit IRC
531 2017-11-15T17:29:57  *** BashCo has joined #bitcoin-core-dev
532 2017-11-15T17:30:42  *** btcdrak has joined #bitcoin-core-dev
533 2017-11-15T17:34:29  *** BashCo has quit IRC
534 2017-11-15T17:36:52  *** aruns has joined #bitcoin-core-dev
535 2017-11-15T17:37:25  *** Dizzle has joined #bitcoin-core-dev
536 2017-11-15T17:51:17  *** carlitos has quit IRC
537 2017-11-15T17:52:45  <bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/927a1d7d088e...4ed818060ecf
538 2017-11-15T17:52:46  <bitcoin-git> bitcoin/master 7c4f009 Russell Yanofsky: [trivial] Rename feebumper variables according to project code style...
539 2017-11-15T17:52:47  <bitcoin-git> bitcoin/master 37bdcca Russell Yanofsky: [refactor] Make feebumper namespace...
540 2017-11-15T17:52:47  <bitcoin-git> bitcoin/master aed1d90 Russell Yanofsky: [wallet] Change feebumper from class to functions...
541 2017-11-15T17:53:00  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #10600: Make feebumper class stateless (master...pr/ipc-bump) https://github.com/bitcoin/bitcoin/pull/10600
542 2017-11-15T18:01:26  *** bule has joined #bitcoin-core-dev
543 2017-11-15T18:04:20  *** bule has quit IRC
544 2017-11-15T18:04:55  *** bule has joined #bitcoin-core-dev
545 2017-11-15T18:08:51  *** BashCo has joined #bitcoin-core-dev
546 2017-11-15T18:21:39  *** laurentmt has quit IRC
547 2017-11-15T18:26:17  *** Ylbam has joined #bitcoin-core-dev
548 2017-11-15T18:31:41  *** bule has quit IRC
549 2017-11-15T18:32:06  *** bule has joined #bitcoin-core-dev
550 2017-11-15T18:35:43  *** vicenteH has quit IRC
551 2017-11-15T18:54:11  <jonasschnelli> Thanks BlueMatt for the info
552 2017-11-15T19:03:08  *** meshcollider has joined #bitcoin-core-dev
553 2017-11-15T19:04:43  *** Dizzle has quit IRC
554 2017-11-15T19:04:51  *** Victorsueca has joined #bitcoin-core-dev
555 2017-11-15T19:07:33  *** sanada has quit IRC
556 2017-11-15T19:08:12  *** arubi has quit IRC
557 2017-11-15T19:08:35  *** arubi has joined #bitcoin-core-dev
558 2017-11-15T19:10:40  <luke-jr> BlueMatt: I wonder if there's a good way to make builds fail if they're incompatible
559 2017-11-15T19:10:50  <luke-jr> though I can't think of anything obvious
560 2017-11-15T19:11:40  *** bule has quit IRC
561 2017-11-15T19:12:00  <BlueMatt> I mean its kinda a manual thing to figure out if a given RPC needs the block
562 2017-11-15T19:25:46  *** wunpunch has joined #bitcoin-core-dev
563 2017-11-15T19:27:39  *** shtirlic has joined #bitcoin-core-dev
564 2017-11-15T19:29:33  *** shtirlic has quit IRC
565 2017-11-15T19:31:06  *** wunpunch has quit IRC
566 2017-11-15T19:40:13  <luke-jr> BlueMatt: right, but we could fail everything until some change is made to indicate one way or the other
567 2017-11-15T19:40:28  *** btcdrak has quit IRC
568 2017-11-15T19:42:01  <BlueMatt> that seems like overkill? I mean as long as people pay attention when merging wallet rpc changes in the same way that we will need to in the future
569 2017-11-15T19:42:13  <luke-jr> dunno
570 2017-11-15T19:42:26  <luke-jr> incompatible changes breaking stuff is generally a good idea to avoid bug
571 2017-11-15T19:42:47  <BlueMatt> I mean if you want to write one I'd be happy to see it, but I dont think its a huge risk
572 2017-11-15T19:42:53  <BlueMatt> just gotta educate =D
573 2017-11-15T19:52:51  *** warxhead has joined #bitcoin-core-dev
574 2017-11-15T19:56:48  *** kewde[m] has quit IRC
575 2017-11-15T20:02:22  <jonasschnelli> BlueMatt: re: https://github.com/bitcoin/bitcoin/pull/10387/commits/005fafdaa99b900d4a3ed0320e73e0a4863abf87
576 2017-11-15T20:03:10  <jonasschnelli> Do you recommend to keep MayHaveUsefulAddressDB() as it is and add the HasAllDesirableServiceFlags() at another place?
577 2017-11-15T20:03:48  <jonasschnelli> IMO NODE_NETWORK_LIMITED  should conform to MayHaveUsefulAddressDB()... or why not?
578 2017-11-15T20:04:10  <BlueMatt> hmm?
579 2017-11-15T20:04:16  <BlueMatt> yes, no, I was not objecting to the code changes there
580 2017-11-15T20:04:17  <BlueMatt> at all
581 2017-11-15T20:04:34  <BlueMatt> my complaint was about the commit message and the confusion it implies
582 2017-11-15T20:04:44  <BlueMatt> an easy fix for which would be to change net_processing's addr handling
583 2017-11-15T20:05:04  <BlueMatt> to check MayHaveUsefulAddressDB(services) || HasAllDesirableServiceFlags(services)
584 2017-11-15T20:05:14  <BlueMatt> as the condition for getting an address into *our* addr db
585 2017-11-15T20:05:35  <BlueMatt> (which, as indicated in the comment, would also not be a change in behavior, but it'd make things much clearer)
586 2017-11-15T20:06:35  *** kewde[m] has joined #bitcoin-core-dev
587 2017-11-15T20:07:05  <jonasschnelli> I see..
588 2017-11-15T20:07:14  <jonasschnelli> BlueMatt: but we should also do feeler to NODE_NETWORK_LIMITED, right?
589 2017-11-15T20:07:21  <jonasschnelli> That's why I have changed MayHaveUsefulAddressDB()
590 2017-11-15T20:07:26  <BlueMatt> correct
591 2017-11-15T20:07:44  <BlueMatt> again, I think the *code* in that commit is right, the changes I was talking about would change no behavior against what you already have
592 2017-11-15T20:07:46  <jonasschnelli> Okay with just rewording the commit message to mention the feeler thing?
593 2017-11-15T20:07:59  <BlueMatt> wait, huh?
594 2017-11-15T20:08:04  <BlueMatt> ohoh, yes
595 2017-11-15T20:08:05  *** SopaXorzTaker has quit IRC
596 2017-11-15T20:08:18  <BlueMatt> so the function is named MayHaveUsefulAddressDB because its primary use is "should i do a feeler to this connection"
597 2017-11-15T20:08:35  <jonasschnelli> Or do you think adding "HasAllDesirableServiceFlags(services)" in net_processing would make the code more readable (not an acctual change)
598 2017-11-15T20:08:38  <BlueMatt> the fact that acceptance into our addr db relies on that function is purely because its a superset of HasAllDesirableServiceFlags
599 2017-11-15T20:08:49  <BlueMatt> my request was that you do both
600 2017-11-15T20:09:06  <jonasschnelli> okay... got it
601 2017-11-15T20:11:32  *** timothy has quit IRC
602 2017-11-15T20:13:22  <jonasschnelli> BlueMatt: wait,... but HasAllDesirableServiceFlags() changes over time. Should we not add NODE_NETWORK_LIMITED to our addr man even during IBD?
603 2017-11-15T20:14:25  <jonasschnelli> A check in net_processing (MayHaveUsefulAddressDB(services) || HasAllDesirableServiceFlags(services)) would lead to not adding NODE_NETWORK_LIMITED during IBD, right? Is that desirable?
604 2017-11-15T20:14:57  *** jsfour has quit IRC
605 2017-11-15T20:19:16  *** jsfour has joined #bitcoin-core-dev
606 2017-11-15T20:23:47  *** jsfour has quit IRC
607 2017-11-15T20:24:14  *** jsfour has joined #bitcoin-core-dev
608 2017-11-15T20:25:37  *** shtirlic has joined #bitcoin-core-dev
609 2017-11-15T20:29:51  *** jsfour has quit IRC
610 2017-11-15T20:35:54  <BlueMatt> jonasschnelli: I mean MayHaveUsefulAddressDB will always return true for either NODE_NETWORK{,_LIMITED}
611 2017-11-15T20:35:58  <BlueMatt> jonasschnelli: so it should be fine?
612 2017-11-15T20:36:36  <jonasschnelli> Yes. Your right...
613 2017-11-15T20:40:26  <rabidus> no, that's your left
614 2017-11-15T20:40:34  <rabidus> sry.
615 2017-11-15T20:41:40  <sipa> it's your right to be left on the left
616 2017-11-15T20:41:50  <sipa> sry.
617 2017-11-15T20:42:19  *** jsfour has joined #bitcoin-core-dev
618 2017-11-15T20:42:43  <jonasschnelli> lol
619 2017-11-15T20:51:38  *** promag has quit IRC
620 2017-11-15T20:54:03  <jonasschnelli> Anyone willing to review https://github.com/bitcoin/bitcoin/pull/11281/files?w=1 ?
621 2017-11-15T20:54:09  <jonasschnelli> #11281
622 2017-11-15T20:54:11  <gribble> https://github.com/bitcoin/bitcoin/issues/11281 | Avoid pemanent cs_main/cs_wallet lock during RescanFromTime by jonasschnelli · Pull Request #11281 · bitcoin/bitcoin · GitHub
623 2017-11-15T20:54:13  <jonasschnelli> (use ?w=1)
624 2017-11-15T20:54:26  *** mmgen has quit IRC
625 2017-11-15T21:01:04  *** wxss_ has joined #bitcoin-core-dev
626 2017-11-15T21:02:01  *** wxss has quit IRC
627 2017-11-15T21:02:29  *** wxss_ is now known as wxss
628 2017-11-15T21:11:32  *** aruns__ has joined #bitcoin-core-dev
629 2017-11-15T21:13:01  *** aruns has quit IRC
630 2017-11-15T21:14:42  *** tess_ has joined #bitcoin-core-dev
631 2017-11-15T21:15:07  *** indistylo has joined #bitcoin-core-dev
632 2017-11-15T21:16:12  <bitcoin-git> [bitcoin] jnewbery opened pull request #11697: [trivial] remove trailing whitespace in streams.h (master...streams_trailing_whitespace) https://github.com/bitcoin/bitcoin/pull/11697
633 2017-11-15T21:16:19  <meshcollider> wumpus: #11651 is ready to merge I think
634 2017-11-15T21:16:19  *** aruns__ has quit IRC
635 2017-11-15T21:16:21  <gribble> https://github.com/bitcoin/bitcoin/issues/11651 | refactor: Make all #includes relative to project root (laanwj, MeshCollider, ryanofsky) by MeshCollider · Pull Request #11651 · bitcoin/bitcoin · GitHub
636 2017-11-15T21:26:35  *** Chris_Stewart_5 has quit IRC
637 2017-11-15T21:39:02  *** _parts has joined #bitcoin-core-dev
638 2017-11-15T21:39:43  *** JackH has quit IRC
639 2017-11-15T21:39:58  *** vicenteH has joined #bitcoin-core-dev
640 2017-11-15T21:41:20  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4ed818060ecf...f0c1f8abb018
641 2017-11-15T21:41:21  <bitcoin-git> bitcoin/master b077fe9 Evan Klitzke: fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it
642 2017-11-15T21:41:21  <bitcoin-git> bitcoin/master f0c1f8a MarcoFalke: Merge #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it...
643 2017-11-15T21:41:55  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11690: [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it (master...desktop-file) https://github.com/bitcoin/bitcoin/pull/11690
644 2017-11-15T21:56:02  *** jsfour has quit IRC
645 2017-11-15T22:07:17  <bitcoin-git> [bitcoin] lmlsna opened pull request #11698: [Docs] [Qt] RPC-Console nested commands documentation  (master...doc-rpc-console) https://github.com/bitcoin/bitcoin/pull/11698
646 2017-11-15T22:11:54  *** jsfour has joined #bitcoin-core-dev
647 2017-11-15T22:13:33  *** Aaronvan_ has joined #bitcoin-core-dev
648 2017-11-15T22:14:55  *** Aaronva__ has joined #bitcoin-core-dev
649 2017-11-15T22:16:33  *** jsfour has quit IRC
650 2017-11-15T22:16:33  *** AaronvanW has quit IRC
651 2017-11-15T22:17:05  *** indistylo has quit IRC
652 2017-11-15T22:18:09  *** Aaronvan_ has quit IRC
653 2017-11-15T22:19:09  *** jsfour has joined #bitcoin-core-dev
654 2017-11-15T22:23:26  <go1111111> I'm experiencing a fairly painful UX issue with Core. I'm probably "using it wrong", but I wanted to describe my problem in case it influences development, and also see if there's a workaround:
655 2017-11-15T22:23:29  *** jsfour has quit IRC
656 2017-11-15T22:23:52  *** Aaronva__ is now known as AaronvanW
657 2017-11-15T22:24:59  <go1111111> I have several different wallet files, with different passwords. I rename them 'wallet.dat' as needed. I also recently started pruning my node. These two things don't work together well, as whenever the node is given a wallet with new addresses and it thinks it might be missing info, it wants to re-download the entire blockchain
658 2017-11-15T22:25:42  <go1111111> so, i essentially have to redownload and revalidate the entire blockchain for every wallet (it is possible to be smarter about this by taking snapshots, but it's cumbersome). Is there a workaround to that?
659 2017-11-15T22:26:14  <sipa> are you using multiwallet? you can load all wallets at once
660 2017-11-15T22:28:27  <bitcoin-git> [bitcoin] jnewbery opened pull request #11699: [travis-ci] Only run linters on Pull Requests (master...lint_only_prs) https://github.com/bitcoin/bitcoin/pull/11699
661 2017-11-15T22:28:40  <bitcoin-git> [bitcoin] jnewbery closed pull request #11697: [trivial] remove trailing whitespace in streams.h (master...streams_trailing_whitespace) https://github.com/bitcoin/bitcoin/pull/11697
662 2017-11-15T22:28:52  <go1111111> Oh, wasn't aware of that. I'll look into it -- thanks!   My other problem: I'm about 40% of the way through validating the blockchain, but all the inputs I want to spend have already been seen by the node, so I'd like to be able to broadcast a tx even though the node itself doesn't know that inputs are unspent. Is there a better way to do this other than using createrawtransaction?
663 2017-11-15T22:29:17  <go1111111> I'd like to take advantage of the transaction construction of the UI to avoid errors, but also don't want to wait another 6 hours..
664 2017-11-15T22:30:00  <sipa> you can construct a transaction as soon as your node knows about the outputs
665 2017-11-15T22:30:26  <sipa> however, if you would construct a transaction that spends inputs which happen to be already spent in the chain, the result will be invalid (and you'll need to use abandontransaction to fix things)
666 2017-11-15T22:34:45  <go1111111> interesting. that's how I wanted it to work, but when I construct my tx in the UI and click 'send', the UI doesn't respond at all. I expect to be prompted for my pw. Now that I know this is unexpected i'll try some variations to see if I can get it to work. thanks
667 2017-11-15T22:35:50  <sipa> i'm unfamiliar with the GUI, but that does sound like a bug
668 2017-11-15T22:36:10  <sipa> or at least something that requires more accurate information
669 2017-11-15T22:38:11  *** jay_ has joined #bitcoin-core-dev
670 2017-11-15T22:38:50  *** jay_ has quit IRC
671 2017-11-15T22:41:02  <go1111111> it seems to relate to coin-control. I get the expected behavior when I don't manually select the inputs
672 2017-11-15T22:43:13  <go1111111> wait no, that's wrong.. I'll be back when/if I have a proper bug report. thanks for the help.
673 2017-11-15T22:43:17  <bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f0c1f8abb018...54aedc013744
674 2017-11-15T22:43:17  <bitcoin-git> bitcoin/master ea3f363 Matt Corallo: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests
675 2017-11-15T22:43:18  <bitcoin-git> bitcoin/master 54aedc0 MarcoFalke: Merge #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests...
676 2017-11-15T22:43:48  <bitcoin-git> [bitcoin] MarcoFalke closed pull request #11686: Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (master...2017-11-shorter-default-issue) https://github.com/bitcoin/bitcoin/pull/11686
677 2017-11-15T22:45:14  *** Cogito_Ergo_Sum has quit IRC
678 2017-11-15T22:50:30  *** jsfour has joined #bitcoin-core-dev
679 2017-11-15T22:54:55  *** jsfour has quit IRC
680 2017-11-15T23:11:04  *** jsfour has joined #bitcoin-core-dev
681 2017-11-15T23:51:29  *** jsfour has quit IRC
682 2017-11-15T23:52:16  *** jsfour has joined #bitcoin-core-dev
683 2017-11-15T23:58:06  *** LumberCartel has joined #bitcoin-core-dev