1 2017-11-17T00:03:22  <gmaxwell> jcorgan: after reading NIST tests of varrious CDR media I dunno about trusting any of it-- they found two order of magnitude variations in durability of even 'archival grade' media.  Seemed like the only way to be confident at all is to have an independant lab test it.
  2 2017-11-17T00:04:45  *** jsfour has joined #bitcoin-core-dev
  3 2017-11-17T00:04:57  *** torkelrogstad has quit IRC
  4 2017-11-17T00:05:25  <gmaxwell> jonasschnelli: probably a short private key with error correction scribed on metal (with a diamond scribe or cryptosteel) is probably the best durability that can be achieved.  Most other alternatives are not especially fire/water durable.
  5 2017-11-17T00:09:07  <jcorgan> yeah, it's more a convenience than anything to really trust. the US navy testing report i posted above used fairly good methodology and th mdisc fared well. again, though, it's a convenience and only one part of an overall system.
  6 2017-11-17T00:09:29  <jcorgan> "If it isn't backed up in three different ways and stored in three different places, it is already lost."
  7 2017-11-17T00:10:01  <gmaxwell> yea, thanks for the pointer.
  8 2017-11-17T00:11:20  *** ok7685 has quit IRC
  9 2017-11-17T00:11:21  <gmaxwell> FWIW, I've found in research that CD readers actually have far less reading robustness that in theoretically possible.  So for data recovery you could potentially read a lot of unreadable disks with a specialized drive.  (there is a project on github to read audio CDs with a USRP bolted to the photodetector output of a laserdisk player).
 10 2017-11-17T00:11:45  <bitcoin-git> [bitcoin] CryptAxe closed pull request #11098: [Qt] Add spend all button to the SendCoinsDialog (master...spendall) https://github.com/bitcoin/bitcoin/pull/11098
 11 2017-11-17T00:12:31  <gmaxwell> far less == e.g. they use the inner RS code only as a checksum, and the outer only as an erasure code,  and don't do any soft-input or iteration.
 12 2017-11-17T00:16:35  <jcorgan> i don't think the system was designed around archival, only incidental damage (scratches, etc.)
 13 2017-11-17T00:16:44  *** LumberCartel has joined #bitcoin-core-dev
 14 2017-11-17T00:17:36  <jcorgan> so none of the commodity write-once optical systems deal with things like fires or chemical damage, etc.
 15 2017-11-17T00:18:16  *** torkelrogstad has joined #bitcoin-core-dev
 16 2017-11-17T00:19:22  <jcorgan> SDR/DSP is magic :-)
 17 2017-11-17T00:21:44  <jcorgan> physical damage aside, i'm still not sure if any proper bip32 hd-wallet seed/hierarchy designs have emerged
 18 2017-11-17T00:23:39  <gmaxwell> jonasschnelli: there are two things I'd like to talk to you about with future hardware wallet stuff.
 19 2017-11-17T00:24:20  <gmaxwell> jonasschnelli: One of them is that we now have a scheme where the host software can protect against a hardware wallet signing maliciously in a way that leaks keys.
 20 2017-11-17T00:24:49  <gmaxwell> jonasschnelli: perhaps you'd have some interest in implementing that. It requires an extra round trip between the host and HW wallet during signing.
 21 2017-11-17T00:25:54  <gmaxwell> jonasschnelli: the other thing is this KDF scheme.  Basically, I want to address the problem that you want to enter a password protected seed on a hardware wallet and not expose the password or seed to an untrusted host...  but the hardware wallet does not have enough CPU power to do a meaningful KDF (the 2000 rounds in BIP39 is basically pointless)
 22 2017-11-17T00:26:40  <gmaxwell> jonasschnelli: so I would suggest we use a scheme proposed some years ago by Adam Back that would let the host computer do the KDF grinding in zero knoweldge-- it learns nothing about the password entered on the hardware wallet.
 23 2017-11-17T00:30:38  *** Dizzle has quit IRC
 24 2017-11-17T00:30:57  *** torkelrogstad has quit IRC
 25 2017-11-17T00:32:24  <sipa> link: https://bitcointalk.org/index.php?topic=311000.0
 26 2017-11-17T00:33:50  <achow101> what does everyone think about putting various docs about things in progress and plans (e.g. sipa's wallet thing) on the wiki here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki
 27 2017-11-17T00:33:58  <achow101> that's where we did release notes things
 28 2017-11-17T00:39:52  <sipa> achow101: without large scale effort to commit to keeping something like that up to date, i'm afraid it will very easily go outdated
 29 2017-11-17T00:40:29  <achow101> sipa: I was thinking more of a repository to keep these writeups that morcos keeps asking for
 30 2017-11-17T00:40:43  <sipa> ah, yes
 31 2017-11-17T00:40:46  <achow101> to have them all in one place instead of having to search for all of them
 32 2017-11-17T00:41:01  <sipa> any reason they couldn't be in the repo?
 33 2017-11-17T00:41:19  <sipa> https://github.com/bitcoin-core/docs for example
 34 2017-11-17T00:41:39  <achow101> they could be in the repo I guess
 35 2017-11-17T00:42:36  <achow101> just somewhere that they can be easily found in one place is good enough
 36 2017-11-17T00:47:13  <meshcollider> +1
 37 2017-11-17T01:00:46  *** dabura667 has joined #bitcoin-core-dev
 38 2017-11-17T01:06:22  *** blockchain has quit IRC
 39 2017-11-17T01:13:35  *** vicenteH has quit IRC
 40 2017-11-17T01:16:07  *** Khunbish has quit IRC
 41 2017-11-17T01:35:22  *** wunpunch has quit IRC
 42 2017-11-17T01:42:57  *** Murch has quit IRC
 43 2017-11-17T01:45:16  *** Muis has joined #bitcoin-core-dev
 44 2017-11-17T01:48:16  *** Chris_Stewart_5 has joined #bitcoin-core-dev
 45 2017-11-17T01:55:50  *** AaronvanW has quit IRC
 46 2017-11-17T02:00:45  *** Cory has quit IRC
 47 2017-11-17T02:05:18  *** Ylbam has quit IRC
 48 2017-11-17T02:17:16  *** RubenSomsen has joined #bitcoin-core-dev
 49 2017-11-17T02:18:35  *** Cory has joined #bitcoin-core-dev
 50 2017-11-17T02:18:58  <bitcoin-git> [bitcoin] MeshCollider opened pull request #11708: Add P2SH-P2WSH support to signrawtransaction and listunspent RPC (master...201711_signrawtransaction_wsh) https://github.com/bitcoin/bitcoin/pull/11708
 51 2017-11-17T02:20:45  <meshcollider> validateaddress is basically an address info call isn't it
 52 2017-11-17T02:21:18  <meshcollider> so should witnessScript and redeemScript be added to its output?
 53 2017-11-17T02:27:57  <sipa> i believe my segwit wallet pr does that
 54 2017-11-17T02:28:04  <sipa> or something similar at least
 55 2017-11-17T02:29:06  <meshcollider> oh cool, thanks :)
 56 2017-11-17T02:40:13  *** intcat has quit IRC
 57 2017-11-17T02:42:59  *** intcat has joined #bitcoin-core-dev
 58 2017-11-17T02:48:33  *** Guest83 has joined #bitcoin-core-dev
 59 2017-11-17T02:58:35  *** Chris_Stewart_5 has quit IRC
 60 2017-11-17T03:03:01  *** justan0theruser has quit IRC
 61 2017-11-17T03:08:31  *** Guest83 has quit IRC
 62 2017-11-17T03:08:50  *** Guest83 has joined #bitcoin-core-dev
 63 2017-11-17T03:09:20  *** Guest83 has quit IRC
 64 2017-11-17T03:09:42  *** Guest83 has joined #bitcoin-core-dev
 65 2017-11-17T03:14:34  *** Guest83 has quit IRC
 66 2017-11-17T03:15:26  *** Guest83 has joined #bitcoin-core-dev
 67 2017-11-17T03:20:07  *** Guest83 has quit IRC
 68 2017-11-17T03:20:53  *** satwo has joined #bitcoin-core-dev
 69 2017-11-17T03:46:51  *** jsfour has quit IRC
 70 2017-11-17T03:54:08  *** cxr has quit IRC
 71 2017-11-17T04:08:47  *** checksauce has joined #bitcoin-core-dev
 72 2017-11-17T04:09:43  *** checksauce has quit IRC
 73 2017-11-17T04:39:49  *** jsfour has joined #bitcoin-core-dev
 74 2017-11-17T05:07:17  *** Guest92143 has joined #bitcoin-core-dev
 75 2017-11-17T05:20:09  *** justanotheruser has joined #bitcoin-core-dev
 76 2017-11-17T05:28:34  *** justanotheruser has quit IRC
 77 2017-11-17T05:28:54  *** justanotheruser has joined #bitcoin-core-dev
 78 2017-11-17T05:30:40  *** sunday-afternoon has joined #bitcoin-core-dev
 79 2017-11-17T05:41:44  *** RubenSomsen has quit IRC
 80 2017-11-17T06:26:43  *** satwo has quit IRC
 81 2017-11-17T06:27:13  <achow101> meshcollider: yes, and that's why I have a PR to move most of the functionality to a new call getaddressinfo
 82 2017-11-17T06:27:39  <meshcollider> achow101: Ah sweet, will check it out in a second
 83 2017-11-17T06:30:29  *** Ylbam has joined #bitcoin-core-dev
 84 2017-11-17T06:37:23  <jonasschnelli> [14:24:20]  <gmaxwell>	jonasschnelli: One of them is that we now have a scheme where the host software can protect against a hardware wallet signing maliciously in a way that leaks keys.
 85 2017-11-17T06:37:36  <jonasschnelli> That is not adam3us's proposal? Right?
 86 2017-11-17T06:38:23  <sipa> jonasschnelli: https://www.reddit.com/r/Bitcoin/comments/7a7i69/electrum_30_release/dpaetyn/?context=3
 87 2017-11-17T06:39:09  <jonasschnelli> sipa... thanks! reading...
 88 2017-11-17T06:50:25  *** Cory has quit IRC
 89 2017-11-17T06:53:39  *** SopaXorzTaker has quit IRC
 90 2017-11-17T06:54:20  *** SopaXorzTaker has joined #bitcoin-core-dev
 91 2017-11-17T06:54:57  *** d_t has quit IRC
 92 2017-11-17T06:57:26  *** Cory has joined #bitcoin-core-dev
 93 2017-11-17T06:59:02  <jonasschnelli> sipa: so your scheme is to protect against possible malicious HWW (and or it's firmware)?
 94 2017-11-17T07:17:40  <kallewoof> What was the configure option to enable deadlock detection stuff again?
 95 2017-11-17T07:20:04  <kallewoof> Got it, I think... (CPPFLAGS=-DDEBUG_LOCKORDER)
 96 2017-11-17T07:44:55  <sipa> kallewoof: indeed
 97 2017-11-17T07:44:59  <sipa> jonasschnelli: indeed
 98 2017-11-17T07:46:23  *** cxr has joined #bitcoin-core-dev
 99 2017-11-17T07:46:39  <jonasschnelli> For now,.. all HWW manufacturer consider the hosts/desktop as compromised.. but it's an interesting perspective (from the user) to get kind of a two factor security between HWW/Desktop
100 2017-11-17T07:47:32  *** d_t has joined #bitcoin-core-dev
101 2017-11-17T07:49:42  <jonasschnelli> sipa: is that scheme: (k1+H(k2,R1))*G = k1*G+H(k2,R1)*G = R1+H(k2,R1)*G compatible with BIP32?
102 2017-11-17T07:50:53  <gmaxwell> it doesn't change anything about the public keys used, it changes the nonces in the signatures.
103 2017-11-17T07:51:31  <jonasschnelli> gmaxwell: instead of secp256k1_nonce_function_rfc6979 it would use the construction k1+H(k2,R1)?
104 2017-11-17T07:52:27  <jonasschnelli> interesting... the desktop could verify the signature before broadcasting.. I see
105 2017-11-17T07:52:38  <gmaxwell> a concern is that hw wallets may actually reduce user security, if I were an /evil/ genius, I'd start making counterfeit trezors and selling them on ebay for slightly under the normal retail price... with evil firmware on them.  Backdooring regular computers would be a waste of my resources, but backdooring a hw wallet-- I could be confident that a high percentage of my backdoored devices were g
106 2017-11-17T07:52:43  <gmaxwell> oing to get cryptocoins on them.
107 2017-11-17T07:53:16  <gmaxwell> jonasschnelli: yes, the hw wallet sends the original R to the desktop and it can verify.  If the HW wallet did something malicious it couldn't get its malicious effect further than the desktop.
108 2017-11-17T07:54:15  <gmaxwell> So a backdoored HW wallet would only compromise the user (1) through orignial key generation, if it does that (user can avoid by rolling dice or something for the key),  or (2) with the cooperation of the desktop; which an evil party selling backdoored hardware wallets hopefully wouldn't have.
109 2017-11-17T07:54:29  <jonasschnelli> How Digital Bitbox wanted to prevent from that attack was by proving the device authenticity by signing arbitraty data via the HWW device and have the signature verified. But that security model is based on obscurity of the auth-private key inside the device
110 2017-11-17T07:54:40  <gmaxwell> at least in that kind of setup a HW wallet couldn't make you less secure than your desktop alone.
111 2017-11-17T07:55:08  <gmaxwell> jonasschnelli: right, which could be compromised, and it doesn't help against bad firmware being made at the maker.
112 2017-11-17T07:55:13  *** dabura667 has quit IRC
113 2017-11-17T07:55:34  <gmaxwell> or something like making the compromised devices out of legitimate ones... where it just passes through the tamper detect to the original hardware but intercepts the rest.
114 2017-11-17T07:55:36  <jonasschnelli> gmaxwell: bad firmware can't be installed because the bootloader only accepts signed firmware
115 2017-11-17T07:56:15  *** jtimon has quit IRC
116 2017-11-17T07:56:29  *** dabura667 has joined #bitcoin-core-dev
117 2017-11-17T07:56:42  <jonasschnelli> In the case of proving authenticity with a pinned private key in the device,.. this can be made relatively secure when using a EPROM chip with physical extraction measurements
118 2017-11-17T07:56:59  <jonasschnelli> It's as hard to extract as the seed on the device
119 2017-11-17T07:57:56  <jonasschnelli> But I'd say both schemes should be implemented == more security
120 2017-11-17T07:58:23  <sipa> well this protects against the case where the device creator is complicit
121 2017-11-17T08:02:15  <jonasschnelli> sipa: Indeed...
122 2017-11-17T08:03:12  <jonasschnelli> sipa: those key-exchanges would have to be made for each single private key (input)?
123 2017-11-17T08:07:39  <jonasschnelli> One downside: ability to use the HWW on any (untrusted) computer or cellphone ( == portability) would be lost.
124 2017-11-17T08:08:04  <gmaxwell> why?
125 2017-11-17T08:09:28  <sipa> heh?
126 2017-11-17T08:11:46  <jonasschnelli> gmaxwell: sipa: maybe I'm not getting it. Is the key exchange only used for the nonce?
127 2017-11-17T08:11:53  <sipa> yes
128 2017-11-17T08:12:05  <sipa> at signing time
129 2017-11-17T08:15:13  <jonasschnelli> sipa: it would only protect from leaking private key via signatures?
130 2017-11-17T08:15:45  <sipa> yes
131 2017-11-17T08:16:12  <jonasschnelli> What one probably wants is a security that the device have signed the data it has displayed on the device screen... I guess that hard to achieve
132 2017-11-17T08:18:01  <jonasschnelli> But if we assume the host is not fully compromised, then this is not a big deal...
133 2017-11-17T08:18:09  *** cxr has quit IRC
134 2017-11-17T08:20:24  <jonasschnelli> Example: Trezor is backdoored. You sign "Send 1 BTC to Bob" (verified with Trezor screen), while it actually signs "Send 1 BTC to Malory". Because your using the online Trezor wallet, it would go undetected.
135 2017-11-17T08:23:57  <jonasschnelli> sipa: Thanks for that proposal.. I think that is something the Digital Bitbox guys will implement in the next (hardware) version!
136 2017-11-17T08:24:11  <gmaxwell> well that wouldn't be detected if the host checks the resulting transaction and isn't compromised.
137 2017-11-17T08:24:21  <jonasschnelli> I'm just worries how easy it is to screw up the implementation. :)
138 2017-11-17T08:25:03  <jonasschnelli> gmaxwell: the problem is, users just love this browser based apps!.. they are so easy to compromise IMO
139 2017-11-17T08:27:13  <jonasschnelli> gmaxwell, sipa: by looking at a signature, is it impossible to say wether it has used RFC6979 or if it leaks potential key material?
140 2017-11-17T08:27:20  <gmaxwell> sure, if the everything the user has is compromised you're out of luck.
141 2017-11-17T08:27:35  <gmaxwell> jonasschnelli: right you cannot tell.
142 2017-11-17T08:27:43  *** d_t has quit IRC
143 2017-11-17T08:28:00  <jonasschnelli> gmaxwell: So there is a change that plenty of public signatures leak key material and that someone may have already collected those keys?
144 2017-11-17T08:28:10  <gmaxwell> Yes, sure.
145 2017-11-17T08:28:25  <jonasschnelli> I never thought of this... interesting
146 2017-11-17T08:28:35  <gmaxwell> I think we haven't seen attacks like this because it is not (yet) a low hanging fruit.
147 2017-11-17T08:28:53  <gmaxwell> Why bother understanding crypto when you can send the user an email that says "click here, you just won a free monkey."
148 2017-11-17T08:29:23  <gmaxwell> and the user says "oh hey, I like monkies."  and then all their bitcoins are gone, no signature trickery required.
149 2017-11-17T08:31:02  <midnightmagic> I want a free monkey!
150 2017-11-17T08:31:03  <jonasschnelli> haha
151 2017-11-17T08:31:43  <jonasschnelli> I mean consider the fact that (I think so) Ledger does program their devices in china... they could have implemented that "change"
152 2017-11-17T08:32:09  <jonasschnelli> Although a firmware upgrade / verification would reveal that
153 2017-11-17T08:32:50  *** rafalcpp has quit IRC
154 2017-11-17T08:33:03  <jonasschnelli> gmaxwell: If you self-compile (and have verified that it uses RFC6979) the firmware, you are pretty safe from that attack? right?
155 2017-11-17T08:33:18  <gmaxwell> how can you tell if it's using the code you think it is?
156 2017-11-17T08:33:28  <wumpus> yes, the new malware going around on facebook seems to be more subtle psychology than free monkies, "hey I found a video of you", in which the link infects with a malware and auto-sends it to the other friends
157 2017-11-17T08:33:31  <jonasschnelli> gmaxwell: self compile it?
158 2017-11-17T08:33:51  <jonasschnelli> gmaxwell: aha.. I see
159 2017-11-17T08:33:51  <wumpus> so many ways to manipulate people into clicking links, even those that don't like free monkeys :)
160 2017-11-17T08:34:42  <wumpus> if something like that would include a wallet grabber it'd be pretty terrible
161 2017-11-17T08:38:25  *** JackH has quit IRC
162 2017-11-17T08:39:50  <gmaxwell> jonasschnelli: if you have signed messages and the private key you can tell if 6979 was used by recomputing the nonces yourself, but thats not a useful way to secure a hardware wallet, since the point is to not have the private key laying around. :P  just testing once isn't good enough since an evil wallet could use 6979 for the first N uses or whatnot.
163 2017-11-17T08:41:15  <jonasschnelli> gmaxwell: At least a special HWW function could recompute all your signatures and the desktop app could verify it agains the public ones...
164 2017-11-17T08:42:16  <jonasschnelli> I really like the "nonce-leak-prevention"... the cost the implementation if worth the +security one can get
165 2017-11-17T08:42:26  <jonasschnelli> *is worth
166 2017-11-17T08:42:43  <jonasschnelli> And IMO there is no UX costs (if done right=
167 2017-11-17T08:43:00  <gmaxwell> yes, no ux cost, just a little more data between the signer and host.
168 2017-11-17T08:43:10  <gmaxwell> and some software.
169 2017-11-17T08:43:41  <jonasschnelli> gmaxwell, sipa: are you going to write a proposal?
170 2017-11-17T08:44:41  <jonasschnelli> Or is that (https://www.reddit.com/r/Bitcoin/comments/7a7i69/electrum_30_release/dpaetyn/?context=3=) the proposal?
171 2017-11-17T08:45:57  * jonasschnelli falls asleep
172 2017-11-17T08:51:12  *** JackH has joined #bitcoin-core-dev
173 2017-11-17T08:51:41  <wumpus> you're not in the CH timezone are you jonasschnelli :)
174 2017-11-17T08:53:44  *** whphhg has quit IRC
175 2017-11-17T08:55:15  *** laurentmt has joined #bitcoin-core-dev
176 2017-11-17T08:58:35  *** wxss has quit IRC
177 2017-11-17T09:03:00  *** timothy has joined #bitcoin-core-dev
178 2017-11-17T09:06:13  *** kgc has quit IRC
179 2017-11-17T09:06:20  *** promag has joined #bitcoin-core-dev
180 2017-11-17T09:06:32  <promag> wumpus: and you?
181 2017-11-17T09:06:52  *** wxss has joined #bitcoin-core-dev
182 2017-11-17T09:06:52  <wumpus> I am
183 2017-11-17T09:07:04  <promag> Heh
184 2017-11-17T09:07:26  <wumpus> it's morning here
185 2017-11-17T09:11:15  *** whphhg has joined #bitcoin-core-dev
186 2017-11-17T09:24:09  *** wxss_ has joined #bitcoin-core-dev
187 2017-11-17T09:25:27  *** wxss has quit IRC
188 2017-11-17T09:25:28  *** wxss_ is now known as wxss
189 2017-11-17T09:27:50  *** promag has quit IRC
190 2017-11-17T09:36:54  *** torkelrogstad has joined #bitcoin-core-dev
191 2017-11-17T09:38:41  *** vicenteH has joined #bitcoin-core-dev
192 2017-11-17T09:40:47  *** SopaXorzTaker has quit IRC
193 2017-11-17T09:48:12  *** promag has joined #bitcoin-core-dev
194 2017-11-17T09:48:48  <wumpus> sigh @ #11466, I hate when something went through a review cycle and it's almost ready for merge
195 2017-11-17T09:48:51  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
196 2017-11-17T09:49:03  <wumpus> then people come up with "you should do it like this instead"
197 2017-11-17T09:49:16  <meshcollider> Yeah haha
198 2017-11-17T09:49:22  *** SopaXorzTaker has joined #bitcoin-core-dev
199 2017-11-17T09:49:29  <meshcollider> wumpus: I'll rebase it now
200 2017-11-17T09:49:30  <wumpus> I know it's well meant, but it's no way to cooporate
201 2017-11-17T09:50:07  <meshcollider> General consensus is that its fine as-is though I think, based on the feedback #11687 got
202 2017-11-17T09:50:08  <gribble> https://github.com/bitcoin/bitcoin/issues/11687 | External wallet files by ryanofsky · Pull Request #11687 · bitcoin/bitcoin · GitHub
203 2017-11-17T09:50:09  <wumpus> users have been requesting a way to store their wallets somewhere else for ages
204 2017-11-17T09:50:31  <meshcollider> Yeah and IMO its not safe enough to start separating them all over the show yet
205 2017-11-17T09:50:39  <wumpus> so let's just add it, we can always add another mechanism later (then walletdir will just be the *default* wallet directory)
206 2017-11-17T09:53:24  <wumpus> meshcollider: I agree, the other approach just isn't ready yet
207 2017-11-17T09:53:34  <wumpus> and having a default wallet directory is useful too.
208 2017-11-17T09:55:16  *** Ylbam has quit IRC
209 2017-11-17T09:55:37  <wumpus> meshcollider: yes please rebase, I hope I've saved your PR :)
210 2017-11-17T09:56:55  <wumpus> I'll help testing it
211 2017-11-17T09:57:36  <meshcollider> wumpus: rebased, thanks :)
212 2017-11-17T10:03:43  *** roconnor_ has quit IRC
213 2017-11-17T10:23:25  <meshcollider> Ah 1 sec there has been a change to walletbackup.py which I need to fix
214 2017-11-17T10:29:52  *** AaronvanW has joined #bitcoin-core-dev
215 2017-11-17T10:36:10  <wumpus> no hurry...
216 2017-11-17T10:37:09  <meshcollider> Yep travis is passing now, let me know if you want me to squash the last commit into "Create walletdir if datadir doesn't exist and fix tests"
217 2017-11-17T10:46:11  *** nickler has quit IRC
218 2017-11-17T11:00:25  *** promag has quit IRC
219 2017-11-17T11:03:38  *** nickler has joined #bitcoin-core-dev
220 2017-11-17T11:05:07  <wumpus> meshcollider: seems to work as expected here
221 2017-11-17T11:07:37  <wumpus> I'd hold off on the squashing, still reviewing/testing
222 2017-11-17T11:07:43  *** promag has joined #bitcoin-core-dev
223 2017-11-17T11:08:03  <meshcollider> wumpus: Okay
224 2017-11-17T11:09:41  *** promag has quit IRC
225 2017-11-17T11:11:46  <wumpus> I hopefully got someone else to test it as well
226 2017-11-17T11:14:15  *** torkelrogstad has quit IRC
227 2017-11-17T11:16:02  <wumpus> the only problem with getting testers is that people tend to want it on top of 0.15.x, but if it's relevant for backport at all it makes no sense to do so before it's merged into master
228 2017-11-17T11:26:12  *** laurentmt has quit IRC
229 2017-11-17T11:27:39  *** laurentmt has joined #bitcoin-core-dev
230 2017-11-17T11:29:07  *** Lauda has quit IRC
231 2017-11-17T11:29:40  *** Lauda has joined #bitcoin-core-dev
232 2017-11-17T11:37:46  *** photonclock_ has joined #bitcoin-core-dev
233 2017-11-17T11:45:28  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/99bc0b428b03...41221126c855
234 2017-11-17T11:45:29  <bitcoin-git> bitcoin/master af9103e James O'Beirne: [build] Add a script for installing db4...
235 2017-11-17T11:45:29  <bitcoin-git> bitcoin/master 6e4cdd6 James O'Beirne: [docs] Add reference to install_db4.sh in OS X build instructions
236 2017-11-17T11:45:30  <bitcoin-git> bitcoin/master 4122112 Wladimir J. van der Laan: Merge #11702: [build] Add a script for installing db4...
237 2017-11-17T11:46:05  <bitcoin-git> [bitcoin] laanwj closed pull request #11702: [build] Add a script for installing db4 (master...install-db4-script) https://github.com/bitcoin/bitcoin/pull/11702
238 2017-11-17T11:46:10  <meshcollider> wumpus: Alright I'm heading to bed now, if you want I can squash the commits now or just do it tomorrow
239 2017-11-17T11:46:39  <wumpus> I'm finished with it, ok with me to squash nwo
240 2017-11-17T11:46:42  *** Aaronvan_ has joined #bitcoin-core-dev
241 2017-11-17T11:47:30  <wumpus> I'll ACK
242 2017-11-17T11:50:56  *** AaronvanW has quit IRC
243 2017-11-17T11:52:25  <meshcollider> wumpus: done, thanks :)
244 2017-11-17T12:05:23  *** promag has joined #bitcoin-core-dev
245 2017-11-17T12:07:04  *** dabura667 has quit IRC
246 2017-11-17T12:08:05  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/41221126c855...f6f8d54aff34
247 2017-11-17T12:08:06  <bitcoin-git> bitcoin/master 446e261 practicalswift: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)
248 2017-11-17T12:08:06  <bitcoin-git> bitcoin/master f6f8d54 Wladimir J. van der Laan: Merge #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet)...
249 2017-11-17T12:08:20  <bitcoin-git> [bitcoin] laanwj closed pull request #10920: [qt] Fix potential memory leak in newPossibleKey(ChangeCWallet *wallet) (master...fix-newPossibleKeyChange-memory-leak) https://github.com/bitcoin/bitcoin/pull/10920
250 2017-11-17T12:12:37  *** roconnor_ has joined #bitcoin-core-dev
251 2017-11-17T12:14:32  *** goatpig has joined #bitcoin-core-dev
252 2017-11-17T12:17:31  *** Aaronvan_ is now known as AaronvanW
253 2017-11-17T12:17:50  <bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/f6f8d54aff34...ccc70a295fc5
254 2017-11-17T12:17:51  <bitcoin-git> bitcoin/master f9cd9b1 John Newbery: [tests] Move test_framework Bitcoin primitives into separate module...
255 2017-11-17T12:17:52  <bitcoin-git> bitcoin/master 1135c79 John Newbery: [tests] Tidy up mininode.py module...
256 2017-11-17T12:17:52  <bitcoin-git> bitcoin/master ccc70a2 Wladimir J. van der Laan: Merge #11648: [tests] Add messages.py...
257 2017-11-17T12:18:20  <bitcoin-git> [bitcoin] laanwj closed pull request #11648: [tests] Add messages.py (master...add_primitives_py) https://github.com/bitcoin/bitcoin/pull/11648
258 2017-11-17T12:29:56  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
259 2017-11-17T12:29:56  *** Cogito_Ergo_Sum has joined #bitcoin-core-dev
260 2017-11-17T12:31:27  <promag> wumpus: are you going to merge #11466?
261 2017-11-17T12:31:30  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
262 2017-11-17T12:32:03  <wumpus> promag: I intend to, but would prefer if it gets stilll some more testing of course
263 2017-11-17T12:32:25  <promag> I was planning to test it after lunch
264 2017-11-17T12:33:08  <wumpus> great!
265 2017-11-17T12:33:32  <promag> ok
266 2017-11-17T12:34:45  <wumpus> I just tested it quite extensively as I was the person to propose the change in the first place, but I didn't try e.g. multiwallet things (though I don't see why there'd be an issue)
267 2017-11-17T12:37:19  <wumpus> but could always be some edge case
268 2017-11-17T12:38:26  *** SopaXorzTaker has quit IRC
269 2017-11-17T12:41:26  *** SopaXorzTaker has joined #bitcoin-core-dev
270 2017-11-17T12:46:42  *** torkelrogstad has joined #bitcoin-core-dev
271 2017-11-17T12:52:13  *** nelruk has joined #bitcoin-core-dev
272 2017-11-17T12:54:15  *** fanquake has joined #bitcoin-core-dev
273 2017-11-17T12:54:32  *** Chris_Stewart_5 has joined #bitcoin-core-dev
274 2017-11-17T12:55:46  <fanquake> Hope that wasn't too rude #11709
275 2017-11-17T12:55:47  <gribble> https://github.com/bitcoin/bitcoin/issues/11709 | issue : Message store directory does not exist · Issue #11709 · bitcoin/bitcoin · GitHub
276 2017-11-17T12:57:36  <wumpus> fanquake: no, your response is clear and to the point, he's on his own there, we can't provide support for all the gazilion forks
277 2017-11-17T12:58:25  <wumpus> and if he's able to use git enough to trace it back to our repository he's also able to find the person that made the relevant change for his altcoin...
278 2017-11-17T13:00:12  <wumpus> I get loads of mail about altcoins as well because my mail is in the git log so often
279 2017-11-17T13:01:32  <fanquake> Yea, I seem to get random messages on Twitter all the time. Get a few emails as well.
280 2017-11-17T13:02:36  <fanquake> #11621 Should be able to go in now
281 2017-11-17T13:02:37  <gribble> https://github.com/bitcoin/bitcoin/issues/11621 | [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck by fanquake · Pull Request #11621 · bitcoin/bitcoin · GitHub
282 2017-11-17T13:03:53  <fanquake> I might fixup 11222 over the weekend, and the original author doesn't seem to have time for it.
283 2017-11-17T13:03:57  <wumpus> fanquake: thanks
284 2017-11-17T13:04:30  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ccc70a295fc5...1f7695b4194b
285 2017-11-17T13:04:31  <bitcoin-git> bitcoin/master a7c949f fanquake: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck
286 2017-11-17T13:04:31  <bitcoin-git> bitcoin/master 1f7695b Wladimir J. van der Laan: Merge #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck...
287 2017-11-17T13:05:00  <bitcoin-git> [bitcoin] laanwj closed pull request #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (master...fix-osx-distcheck) https://github.com/bitcoin/bitcoin/pull/11621
288 2017-11-17T13:05:41  <wumpus> fanquake: my reply there was a last ping, if he doesn't reply or pick it up again I'll close and add a 'up for grabs' label. But yes feel free to pick it up if it's worth doing so :)
289 2017-11-17T13:08:24  <wumpus> apparently I stumbled on the issue exactly a month after cfields' last comment
290 2017-11-17T13:08:49  *** Guest92143 has quit IRC
291 2017-11-17T13:09:32  <fanquake> heh, it's easy for PRs to sit and idle for a long time. Little burst of activity and interest, and then it gets a few rebases out of date, or too far buried in the stream of new PRs
292 2017-11-17T13:13:23  <fanquake> wumpus Thoughts on new PGP key additions? A few recently seem to be submitting their keys for addition before they've even gitian built. There's not really a rule about adding them?
293 2017-11-17T13:14:19  <fanquake> I think jonass is right in that there are so few builders you don't want to turn anyone away. Keys can also easily be removed later on.
294 2017-11-17T13:14:54  <wumpus> fanquake: that tends to happen, it's quite common for open source projects, especially busy ones. Though it can be sad if a certain PR gets no review interest at all, e.g. #10994
295 2017-11-17T13:14:56  <gribble> https://github.com/bitcoin/bitcoin/issues/10994 | Add option to avoid warning on certain network upgrades by ajtowns · Pull Request #10994 · bitcoin/bitcoin · GitHub
296 2017-11-17T13:15:25  <wumpus> fanquake: we currently have no rules for that, because addition was so rare
297 2017-11-17T13:15:40  <wumpus> fanquake: I think we should have rules for expiration, remove the key if someone isn't gitian building anymore for e.g. a year
298 2017-11-17T13:15:48  *** promag has quit IRC
299 2017-11-17T13:16:01  <wumpus> fanquake: but not for addition so much, if people can gitian build at this point they're awesome
300 2017-11-17T13:16:15  <wumpus> fanquake: and he's proven he could do it at least once :)
301 2017-11-17T13:16:49  <fanquake> Indeed https://github.com/bitcoin-core/gitian.sigs/graphs/contributors isn't a long list. Plenty of people in there that haven't built recently as well.
302 2017-11-17T13:17:08  <wumpus> yes, even expiration might be overkill at this point, it's just not so much of an issue
303 2017-11-17T13:17:22  <wumpus> not like the repository is getting cluttered with them
304 2017-11-17T13:17:29  <fanquake> I think the fact that the build process is so much *easier* now is great. Can remember I struggled to get it working for a while.
305 2017-11-17T13:18:39  <fanquake> Guess #11700 can go in then. If no-one objects.
306 2017-11-17T13:18:40  <gribble> https://github.com/bitcoin/bitcoin/issues/11700 | Add gitian PGP key: willyko by willyko · Pull Request #11700 · bitcoin/bitcoin · GitHub
307 2017-11-17T13:19:30  <wumpus> agree
308 2017-11-17T13:20:07  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f7695b4194b...595ec11d804f
309 2017-11-17T13:20:08  <bitcoin-git> bitcoin/master f88d900 Willy Ko: Add gitian PGP key: willyko
310 2017-11-17T13:20:08  <bitcoin-git> bitcoin/master 595ec11 Wladimir J. van der Laan: Merge #11700: Add gitian PGP key: willyko...
311 2017-11-17T13:20:34  <bitcoin-git> [bitcoin] laanwj closed pull request #11700: Add gitian PGP key: willyko (master...master) https://github.com/bitcoin/bitcoin/pull/11700
312 2017-11-17T13:21:30  <bitcoin-git> [bitcoin] laanwj opened pull request #11710: cli: Reject arguments to -getinfo (master...2017_11_getinfo_args) https://github.com/bitcoin/bitcoin/pull/11710
313 2017-11-17T13:25:43  <fanquake> I think #11704 should be ok now. If sipsorcery is committed to getting the Windows build side of things in order, that'll be good.
314 2017-11-17T13:25:44  <gribble> https://github.com/bitcoin/bitcoin/issues/11704 | Windows build doc update by sipsorcery · Pull Request #11704 · bitcoin/bitcoin · GitHub
315 2017-11-17T13:26:13  <wumpus> fanquake: it's great to have someone working on that
316 2017-11-17T13:28:55  <wumpus> I'm going to edit his commit message a bit before merging, he put everything in the subject line
317 2017-11-17T13:29:34  *** Nhia has joined #bitcoin-core-dev
318 2017-11-17T13:32:45  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/595ec11d804f...ea68190132b2
319 2017-11-17T13:32:45  <bitcoin-git> bitcoin/master 1cecea7 Aaron Clauson: doc: Specify required source location for Windows WSL builds...
320 2017-11-17T13:32:46  <bitcoin-git> bitcoin/master ea68190 Wladimir J. van der Laan: Merge #11704: Windows build doc update...
321 2017-11-17T13:33:10  <bitcoin-git> [bitcoin] laanwj closed pull request #11704: Windows build doc update (master...windoc) https://github.com/bitcoin/bitcoin/pull/11704
322 2017-11-17T13:37:05  *** davec has quit IRC
323 2017-11-17T13:38:55  *** glauberdm has joined #bitcoin-core-dev
324 2017-11-17T13:42:52  <fanquake> Still not sure about #11526 though. We had discussions about this with an Xcode project a while ago. Ended up in a separate repository, doesn't look like it lasted too long.
325 2017-11-17T13:42:54  <gribble> https://github.com/bitcoin/bitcoin/issues/11526 | Visual Studio build configuration for Bitcoin Core. by sipsorcery · Pull Request #11526 · bitcoin/bitcoin · GitHub
326 2017-11-17T13:44:50  <wumpus> I don't know either. I like the idea of making MSVC build easier, but I don't want to expect from people to maintain two build systems when e.g. adding a file.
327 2017-11-17T13:45:31  <wumpus> certainly not one that only runs on one platform
328 2017-11-17T13:46:01  *** nelruk has quit IRC
329 2017-11-17T13:46:16  *** davec has joined #bitcoin-core-dev
330 2017-11-17T13:46:38  <wumpus> I'm ok with merging it though, the author committed to maintaining MSVC support
331 2017-11-17T13:47:40  <fanquake> There are some other PRs that need merging first. To fix compilation issues, and "a tonne of warnings" apparently. Should probably get those in fix at least, and see what other issues they turn up. If any.
332 2017-11-17T13:47:59  <fanquake> Mostly in #11558
333 2017-11-17T13:48:01  <gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
334 2017-11-17T13:48:56  <fanquake> Corys comment re #11196 should get a look too I think
335 2017-11-17T13:48:59  <gribble> https://github.com/bitcoin/bitcoin/issues/11196 | Switch memory_cleanse implementation to BoringSSLs to ensure memory clearing even with -lto by maaku · Pull Request #11196 · bitcoin/bitcoin · GitHub
336 2017-11-17T13:49:22  <fanquake> https://github.com/bitcoin/bitcoin/pull/11196#discussion_r137124417
337 2017-11-17T13:49:33  *** uneeb has joined #bitcoin-core-dev
338 2017-11-17T13:50:06  *** uneeb has quit IRC
339 2017-11-17T13:50:14  *** nelruk has joined #bitcoin-core-dev
340 2017-11-17T13:52:28  *** Chris_Stewart_5 has quit IRC
341 2017-11-17T14:00:02  <wumpus> #11558 is pretty much ready, though I agree with cfields' last comment
342 2017-11-17T14:00:04  <gribble> https://github.com/bitcoin/bitcoin/issues/11558 | Minimal code changes to allow msvc compilation by sipsorcery · Pull Request #11558 · bitcoin/bitcoin · GitHub
343 2017-11-17T14:00:17  <wumpus> we should keep the compat header out of the headers
344 2017-11-17T14:01:21  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea68190132b2...5197100704b8
345 2017-11-17T14:01:21  <bitcoin-git> bitcoin/master e89adba Matt Corallo: Make default issue text all comments to make issues more readable
346 2017-11-17T14:01:21  *** torkelrogstad has quit IRC
347 2017-11-17T14:01:22  <bitcoin-git> bitcoin/master 5197100 Wladimir J. van der Laan: Merge #11706: Make default issue text all comments to make issues more readable...
348 2017-11-17T14:01:29  *** torkelrogstad has joined #bitcoin-core-dev
349 2017-11-17T14:01:46  <bitcoin-git> [bitcoin] laanwj closed pull request #11706: Make default issue text all comments to make issues more readable (master...2017-11-shorter-default-issue-redux) https://github.com/bitcoin/bitcoin/pull/11706
350 2017-11-17T14:02:31  <fanquake> Hopefully now the first line I'll see in issue emails will actually contain some information, rather than 99% of the time it being the template text.
351 2017-11-17T14:03:13  <wumpus> oh yes that's annoying, almost everyone just kept the template text there, usually without even paying attention to it
352 2017-11-17T14:04:01  <wumpus> I certainly understand why some bug reporting systems (e.g. bugzilla) make people fill in a form, instead of just offering a free text field
353 2017-11-17T14:04:54  <fanquake> It's a trade off between capturing everything, and missing some obscure bug being reported by an unmotivated passer by
354 2017-11-17T14:04:56  <wumpus> a template is apparently not a working substitute for that, well who knows, maybe BlueMatt's cleanups improve it
355 2017-11-17T14:05:20  <wumpus> yes
356 2017-11-17T14:09:45  *** vicenteH has quit IRC
357 2017-11-17T14:10:15  *** promag has joined #bitcoin-core-dev
358 2017-11-17T14:10:23  <fanquake> wumpus trivial merge or close? #11140
359 2017-11-17T14:10:25  <gribble> https://github.com/bitcoin/bitcoin/issues/11140 | Trivial: Improve #endif comments by danra · Pull Request #11140 · bitcoin/bitcoin · GitHub
360 2017-11-17T14:13:52  *** vicenteH has joined #bitcoin-core-dev
361 2017-11-17T14:13:59  *** torkelrogstad has quit IRC
362 2017-11-17T14:18:18  *** vicenteH has quit IRC
363 2017-11-17T14:18:43  *** jtimon has joined #bitcoin-core-dev
364 2017-11-17T14:21:51  *** vicenteH has joined #bitcoin-core-dev
365 2017-11-17T14:23:51  *** Aaronvan_ has joined #bitcoin-core-dev
366 2017-11-17T14:26:52  *** AaronvanW has quit IRC
367 2017-11-17T14:27:33  <bitcoin-git> [bitcoin] fanquake opened pull request #11711: bitcoin_qt.m4: Minor fixes and clean-ups. (master...bitcoin-qt-m4-cleanup) https://github.com/bitcoin/bitcoin/pull/11711
368 2017-11-17T14:27:59  <bitcoin-git> [bitcoin] fanquake closed pull request #11222: bitcoin_qt.m4: Minor fixes and clean-ups. (master...config-fixes) https://github.com/bitcoin/bitcoin/pull/11222
369 2017-11-17T14:28:14  <promag> I would say meh to 11140
370 2017-11-17T14:29:24  <promag> the blocks are so small I would remove the comments, repeating the condition is kind of unnecessary there
371 2017-11-17T14:33:12  *** AaronvanW has joined #bitcoin-core-dev
372 2017-11-17T14:33:40  <wumpus> well he has a point w/ mentioning ==0, and it has an ACK so meh, i'm just going to merge it
373 2017-11-17T14:34:36  <wumpus> promag: agree that the blocks are so small that mentinoing the condition on the endif is not necessary in the first place
374 2017-11-17T14:34:46  <wumpus> but it's there, so it should be correct...
375 2017-11-17T14:35:15  <fanquake> just merge it then heh
376 2017-11-17T14:35:16  <bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5197100704b8...142913296f00
377 2017-11-17T14:35:17  <bitcoin-git> bitcoin/master ac1cf8d danra: Trivial: Improve #endif comments...
378 2017-11-17T14:35:17  <promag> yes, at the moment the comment is misleading
379 2017-11-17T14:35:17  <bitcoin-git> bitcoin/master 1429132 Wladimir J. van der Laan: Merge #11140: Trivial: Improve #endif comments...
380 2017-11-17T14:35:29  <promag> hence the meh
381 2017-11-17T14:35:42  <bitcoin-git> [bitcoin] laanwj closed pull request #11140: Trivial: Improve #endif comments (master...patch-4) https://github.com/bitcoin/bitcoin/pull/11140
382 2017-11-17T14:35:46  *** satwo has joined #bitcoin-core-dev
383 2017-11-17T14:36:01  *** Aaronvan_ has quit IRC
384 2017-11-17T14:37:23  <fanquake> wumpus looking in byteswap, does the protobuf check affect your work in 11622 at all?
385 2017-11-17T14:37:26  <promag> wumpus: regarding #11466
386 2017-11-17T14:37:29  <gribble> https://github.com/bitcoin/bitcoin/issues/11466 | Specify custom wallet directory with -walletdir param by MeshCollider · Pull Request #11466 · bitcoin/bitcoin · GitHub
387 2017-11-17T14:37:55  <promag> first time run is doesn't use -walletdir right?
388 2017-11-17T14:37:56  <fanquake> I assume not looking at the comments, if the behaviour is assumed to be the same in either case
389 2017-11-17T14:38:30  <wumpus> fanquake: I think it's harmless to run it, though maybe unnecessary, I don't know
390 2017-11-17T14:38:57  <wumpus> fanquake: the test is there to check if there is a collision between protobuf and our bswap primitives, so it will always pass if protobuf is not included
391 2017-11-17T14:39:24  <wumpus> promag: you mean when it's run when the datadir doesn't exist yet?
392 2017-11-17T14:39:30  <promag> yes
393 2017-11-17T14:39:40  <wumpus> promag: that would be bad, let's see
394 2017-11-17T14:39:48  <promag> it's building here so..
395 2017-11-17T14:52:51  *** glauberdm has quit IRC
396 2017-11-17T14:54:08  *** nelruk has quit IRC
397 2017-11-17T14:57:05  <promag> wumpus: it creates datadir/wallets but uses the provided -walletdir
398 2017-11-17T14:57:13  <wumpus> promag: yep, that's expected
399 2017-11-17T14:57:49  *** nelruk has joined #bitcoin-core-dev
400 2017-11-17T14:58:23  <wumpus> promag: there was earlier discussion about that: https://github.com/bitcoin/bitcoin/pull/11466#discussion_r150251905
401 2017-11-17T14:59:43  <wumpus> not creating all new data directories (including when running without wallets) with a wallets subdirectory would enormously complicate things
402 2017-11-17T15:00:19  *** Chris_Stewart_5 has joined #bitcoin-core-dev
403 2017-11-17T15:01:18  <promag> yes I saw that. But here I've provided -walletdir no there's no need (and no harm) creating datadir/wallets
404 2017-11-17T15:01:34  <wumpus> it should still be created if you want to run without -walletdir later
405 2017-11-17T15:01:34  *** meshcollider has quit IRC
406 2017-11-17T15:01:52  <wumpus> because if not it's too late - it's no longer a new data directory, so it will use legacy layout
407 2017-11-17T15:02:30  <promag> right
408 2017-11-17T15:02:40  <bitcoin-git> [bitcoin] fanquake closed pull request #9737: Don't disconnect feeler connections prematurely (master...ServicesIrrelevantForFeelerConnections) https://github.com/bitcoin/bitcoin/pull/9737
409 2017-11-17T15:02:45  <promag> btw, why not validate walletdir before intro?
410 2017-11-17T15:03:10  <promag> edge case?
411 2017-11-17T15:03:15  <wumpus> it's a bit tricky but I think it's the most straightforward and easy to verify way to do this
412 2017-11-17T15:03:45  <wumpus> promag: doing things before intro is extremely difficult
413 2017-11-17T15:04:07  <wumpus> e.g. bitcoin.conf hasn't been read yet
414 2017-11-17T15:04:27  <wumpus> nor have per-network GUI settings
415 2017-11-17T15:04:41  <wumpus> so if you'd validate walletdir before intro, you'd miss it if it's provided in bitcoin.conf
416 2017-11-17T15:04:42  <promag> btw, if -walletdir points to a file, the error is still "Error: Specified wallet directory "/Users/promag/foo2" does not exist."
417 2017-11-17T15:04:59  <wumpus> that could use a clearer error
418 2017-11-17T15:05:03  *** nelruk has quit IRC
419 2017-11-17T15:06:21  *** nelruk has joined #bitcoin-core-dev
420 2017-11-17T15:07:59  *** lolek_ has joined #bitcoin-core-dev
421 2017-11-17T15:10:20  <bitcoin-git> [bitcoin] fanquake closed pull request #10172: Fix opt-in RBF reliance on compiler integer size (master...rbf-numlimits-fix) https://github.com/bitcoin/bitcoin/pull/10172
422 2017-11-17T15:13:30  <bitcoin-git> [bitcoin] fanquake closed pull request #10702: [Trivial] Improve end-of-namespace comment consistency (master...improve-end-of-namespace-comment-consistence) https://github.com/bitcoin/bitcoin/pull/10702
423 2017-11-17T15:13:48  *** nelruk has quit IRC
424 2017-11-17T15:16:01  *** nelruk has joined #bitcoin-core-dev
425 2017-11-17T15:18:21  *** RubenSomsen has joined #bitcoin-core-dev
426 2017-11-17T15:18:51  *** lolek_ has quit IRC
427 2017-11-17T15:25:03  *** nelruk has quit IRC
428 2017-11-17T15:25:25  *** nelruk has joined #bitcoin-core-dev
429 2017-11-17T15:31:41  *** satwo has quit IRC
430 2017-11-17T15:31:55  *** satwo has joined #bitcoin-core-dev
431 2017-11-17T15:32:15  *** nelruk has quit IRC
432 2017-11-17T15:34:11  *** nelruk has joined #bitcoin-core-dev
433 2017-11-17T15:34:56  *** fanquake has quit IRC
434 2017-11-17T15:34:59  <promag> https://github.com/bitcoin/bitcoin/pull/11648#discussion_r151709875
435 2017-11-17T15:35:14  <promag> MarcoFalke: just a question, I saw the moveonly
436 2017-11-17T15:35:40  <promag> now it can be cleaned right?
437 2017-11-17T15:36:19  *** satwo has quit IRC
438 2017-11-17T15:36:41  *** satwo has joined #bitcoin-core-dev
439 2017-11-17T15:40:48  *** nelruk has quit IRC
440 2017-11-17T15:40:51  <wumpus> promag: sure
441 2017-11-17T15:44:15  *** JackH has quit IRC
442 2017-11-17T15:45:16  *** nelruk has joined #bitcoin-core-dev
443 2017-11-17T15:51:11  *** jadox has joined #bitcoin-core-dev
444 2017-11-17T15:52:21  *** nelruk has quit IRC
445 2017-11-17T15:53:08  *** Edgardo10Toy has quit IRC
446 2017-11-17T15:54:27  *** Aaronvan_ has joined #bitcoin-core-dev
447 2017-11-17T15:54:41  *** nelruk has joined #bitcoin-core-dev
448 2017-11-17T15:55:50  *** torkelrogstad has joined #bitcoin-core-dev
449 2017-11-17T15:56:57  *** jadox has quit IRC
450 2017-11-17T15:58:05  *** AaronvanW has quit IRC
451 2017-11-17T15:58:53  <MarcoFalke> promag: Not sure if that single change warrants a pull on its own
452 2017-11-17T16:00:22  <MarcoFalke> I'd prefer if is cleaned up when the function is touched by other reasons. Though, no strong opinion. Just -0
453 2017-11-17T16:00:36  *** Erich43Homenick has joined #bitcoin-core-dev
454 2017-11-17T16:01:37  *** nelruk has quit IRC
455 2017-11-17T16:02:26  *** shesek has joined #bitcoin-core-dev
456 2017-11-17T16:02:26  *** shesek has joined #bitcoin-core-dev
457 2017-11-17T16:05:35  *** nelruk has joined #bitcoin-core-dev
458 2017-11-17T16:06:01  *** JackH has joined #bitcoin-core-dev
459 2017-11-17T16:07:39  *** SopaXorzTaker has quit IRC
460 2017-11-17T16:10:06  *** SopaXorzTaker has joined #bitcoin-core-dev
461 2017-11-17T16:16:41  *** Erich43Homenick has quit IRC
462 2017-11-17T16:24:32  *** Darryl87Hartmann has joined #bitcoin-core-dev
463 2017-11-17T16:27:49  *** torkelrogstad has quit IRC
464 2017-11-17T16:34:17  *** promag has quit IRC
465 2017-11-17T16:34:36  *** jadox has joined #bitcoin-core-dev
466 2017-11-17T16:42:30  *** promag has joined #bitcoin-core-dev
467 2017-11-17T16:46:55  *** promag has quit IRC
468 2017-11-17T16:48:35  *** LumberCartel has quit IRC
469 2017-11-17T17:07:52  *** nelruk has quit IRC
470 2017-11-17T17:14:01  *** Dizzle has joined #bitcoin-core-dev
471 2017-11-17T17:15:05  *** Murch has joined #bitcoin-core-dev
472 2017-11-17T17:21:19  *** Ylbam has joined #bitcoin-core-dev
473 2017-11-17T17:21:25  *** meshcollider has joined #bitcoin-core-dev
474 2017-11-17T17:28:22  *** tomahawk has joined #bitcoin-core-dev
475 2017-11-17T17:34:10  *** thanos has joined #bitcoin-core-dev
476 2017-11-17T17:34:34  *** thanos has quit IRC
477 2017-11-17T17:36:16  *** LumberCartel has joined #bitcoin-core-dev
478 2017-11-17T17:39:10  *** laurentmt has quit IRC
479 2017-11-17T17:40:15  *** tomahawk has quit IRC
480 2017-11-17T17:53:24  <meshcollider> wumpus: re net-specific walletdir subdirectories, what do you think of it just using them if they exist, but defaulting to root dir (so the user has to create the subdirectories themselves if they want them)
481 2017-11-17T17:54:11  <meshcollider> Would be a much simpler change I think
482 2017-11-17T17:55:31  *** bule has joined #bitcoin-core-dev
483 2017-11-17T18:15:08  *** jitendra has joined #bitcoin-core-dev
484 2017-11-17T18:15:42  *** jitendra has left #bitcoin-core-dev
485 2017-11-17T18:33:00  *** pergaminho has joined #bitcoin-core-dev
486 2017-11-17T18:35:08  <jonasschnelli> wumpus: yeah. Not in CH timezone. Right now in Hawaii
487 2017-11-17T18:36:47  *** vicenteH has quit IRC
488 2017-11-17T18:42:44  *** timothy has quit IRC
489 2017-11-17T18:51:47  *** jb55 has joined #bitcoin-core-dev
490 2017-11-17T18:54:37  *** satwo has quit IRC
491 2017-11-17T19:06:33  *** Provoostenator has joined #bitcoin-core-dev
492 2017-11-17T19:16:00  *** satwo has joined #bitcoin-core-dev
493 2017-11-17T19:29:33  *** Dizzle has quit IRC
494 2017-11-17T19:34:00  *** d_t has joined #bitcoin-core-dev
495 2017-11-17T19:36:09  *** LumberCartel has quit IRC
496 2017-11-17T19:36:28  *** jadox has quit IRC
497 2017-11-17T19:58:15  *** RubenSomsen has quit IRC
498 2017-11-17T19:59:15  *** RubenSomsen has joined #bitcoin-core-dev
499 2017-11-17T20:11:11  *** meshcollider has quit IRC
500 2017-11-17T20:12:31  <jonasschnelli> is there a quick way to compile without tests (without re-configure)? I wish i could speed up compile time of pull requests for a quick test...
501 2017-11-17T20:12:46  <jonasschnelli> compile time is a main show stopper for testing pulls
502 2017-11-17T20:13:01  <BlueMatt> jonasschnelli: make src/bitcoind (or maybe its just make bitcoind?)
503 2017-11-17T20:13:55  <jonasschnelli> BlueMatt: hmm.. yes. That could work (now all pre-built,.. need to test with a new PR)
504 2017-11-17T20:15:44  *** meshcollider has joined #bitcoin-core-dev
505 2017-11-17T20:18:57  *** Drrhh has joined #bitcoin-core-dev
506 2017-11-17T20:23:30  *** Drrhh has quit IRC
507 2017-11-17T20:27:24  *** SopaXorzTaker has quit IRC
508 2017-11-17T20:27:45  *** Chris_Stewart_5 has quit IRC
509 2017-11-17T20:35:31  *** d_t has quit IRC
510 2017-11-17T20:45:46  *** dgenr8 has quit IRC
511 2017-11-17T20:46:49  *** dgenr8 has joined #bitcoin-core-dev
512 2017-11-17T21:11:57  *** LumberCartel has joined #bitcoin-core-dev
513 2017-11-17T21:25:42  *** Dizzle has joined #bitcoin-core-dev
514 2017-11-17T21:26:53  *** Aaronvan_ has quit IRC
515 2017-11-17T21:34:07  *** Khunbish has joined #bitcoin-core-dev
516 2017-11-17T21:41:07  *** vicenteH has joined #bitcoin-core-dev
517 2017-11-17T21:47:49  <bitcoin-git> [bitcoin] jnewbery opened pull request #11712: [tests] Split NodeConn from NodeConnCB (master...split_nodeconn) https://github.com/bitcoin/bitcoin/pull/11712
518 2017-11-17T21:52:33  *** RubenSomsen has quit IRC
519 2017-11-17T21:55:35  *** neha has quit IRC
520 2017-11-17T22:03:44  *** JackH has quit IRC
521 2017-11-17T22:04:15  *** JackH has joined #bitcoin-core-dev
522 2017-11-17T22:11:30  *** Provoostenator has quit IRC
523 2017-11-17T22:24:23  *** coin_trader has quit IRC
524 2017-11-17T22:25:26  *** spinza has quit IRC
525 2017-11-17T22:30:17  *** spinza has joined #bitcoin-core-dev
526 2017-11-17T22:42:45  *** sunday-afternoon has quit IRC
527 2017-11-17T22:51:01  *** Cheeseo has quit IRC
528 2017-11-17T22:54:05  *** roadcrap has joined #bitcoin-core-dev
529 2017-11-17T22:54:14  *** Dizzle has quit IRC
530 2017-11-17T23:12:59  *** Chris_Stewart_5 has joined #bitcoin-core-dev
531 2017-11-17T23:21:35  *** Chris_Stewart_5 has quit IRC
532 2017-11-17T23:28:22  *** d_t has joined #bitcoin-core-dev
533 2017-11-17T23:29:28  *** moctos has joined #bitcoin-core-dev
534 2017-11-17T23:38:05  *** moctos has quit IRC
535 2017-11-17T23:52:20  *** devin_ has quit IRC